Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-08-30 Thread Jassi Brar
On Fri, Aug 30, 2019 at 4:32 AM Sudeep Holla wrote: > > On Fri, Aug 30, 2019 at 02:52:40AM -0500, Jassi Brar wrote: > > On Fri, Aug 30, 2019 at 2:37 AM Peng Fan wrote: > > [...] > > > > > > > If I get your point correctly, > > > On UP, both could not be active. On SMP, tx/rx could be both

Re: [PATCH V5 1/4] dt-bindings: watchdog: Add i.MX7ULP bindings

2019-08-30 Thread Guenter Roeck
On Wed, Aug 28, 2019 at 09:35:00AM -0400, Anson Huang wrote: > Add the watchdog bindings for Freescale i.MX7ULP. > > Signed-off-by: Anson Huang > Reviewed-by: Rob Herring Missed this version. For the record: Reviewed-by: Guenter Roeck > --- > Changes since V4: > - improve watchdog

Re: [PATCH V4 1/4] dt-bindings: watchdog: Add i.MX7ULP bindings

2019-08-30 Thread Guenter Roeck
On Wed, Aug 21, 2019 at 10:37:40PM -0400, Anson Huang wrote: > Add the watchdog bindings for Freescale i.MX7ULP. > > Signed-off-by: Anson Huang With the change requested by Rob: Reviewed-by: Guenter Roeck > --- > No changes. > --- > .../bindings/watchdog/fsl-imx7ulp-wdt.txt | 22 >

Re: objtool warning "uses BP as a scratch register" with clang-9

2019-08-30 Thread Josh Poimboeuf
On Fri, Aug 30, 2019 at 08:48:49AM -0700, Linus Torvalds wrote: > On Fri, Aug 30, 2019 at 8:02 AM Josh Poimboeuf wrote: > > > > For KASAN, the Clang threshold for inserting memset() is *2* consecutive > > writes instead of 17. Isn't that likely to cause tearing-related > > surprises? > >

Re: [PATCH V4 2/4] watchdog: Add i.MX7ULP watchdog support

2019-08-30 Thread Guenter Roeck
On Wed, Aug 21, 2019 at 10:37:41PM -0400, Anson Huang wrote: > The i.MX7ULP Watchdog Timer (WDOG) module is an independent timer > that is available for system use. > It provides a safety feature to ensure that software is executing > as planned and that the CPU is not stuck in an infinite loop or

Re: [PATCH RESEND v2 1/6] dt-bindings: watchdog: Add YAML schemas for the generic watchdog bindings

2019-08-30 Thread Guenter Roeck
On Wed, Aug 21, 2019 at 04:38:30PM +0200, Maxime Ripard wrote: > From: Maxime Ripard > > The watchdogs have a bunch of generic properties that are needed in a > device tree. Add a YAML schemas for those. > > Reviewed-by: Rob Herring > Signed-off-by: Maxime Ripard Reviewed-by: Guenter Roeck

Re: [PATCH RESEND v2 4/6] dt-bindings: watchdog: sun4i: Add the watchdog clock

2019-08-30 Thread Guenter Roeck
On Wed, Aug 21, 2019 at 04:38:33PM +0200, Maxime Ripard wrote: > From: Maxime Ripard > > The Allwinner watchdog has a clock that has been described in some DT, but > not all of them. > > The binding is also completely missing that description. Let's add that > property to be consistent. > >

Re: [PATCH RESEND v2 2/6] dt-bindings: watchdog: Convert Allwinner watchdog to a schema

2019-08-30 Thread Guenter Roeck
On Wed, Aug 21, 2019 at 04:38:31PM +0200, Maxime Ripard wrote: > From: Maxime Ripard > > The Allwinner SoCs have a watchdog supported in Linux, with a matching > Device Tree binding. > > Now that we have the DT validation in place, let's convert the device tree > bindings for that controller

Re: [PATCH RESEND v2 3/6] dt-bindings: watchdog: sun4i: Add the watchdog interrupts

2019-08-30 Thread Guenter Roeck
On Wed, Aug 21, 2019 at 04:38:32PM +0200, Maxime Ripard wrote: > From: Maxime Ripard > > The Allwinner watchdog has an interrupt, either shared or dedicated > depending on the SoC, that has been described in some DT, but not all of > them. > > The binding is also completely missing that

Re: [PATCH] drivers/staging/exfat - by default, prohibit mount of fat/vfat

2019-08-30 Thread Christoph Hellwig
On Fri, Aug 30, 2019 at 12:42:39PM -0400, Valdis Klētnieks wrote: > Concerns have been raised about the exfat driver accidentally mounting > fat/vfat file systems. Add an extra configure option to help prevent that. Just remove that code. This is exactly what I fear about this staging crap, all

Re: [BUG] Use of probe_kernel_address() in task_rcu_dereference() without checking return value

2019-08-30 Thread Oleg Nesterov
On 08/30, Linus Torvalds wrote: > > But yes, your hack is I guess optimal for this particular case where > you simply can depend on "we know the pointer was valid, we just don't > know if it was freed". > > Hmm. Don't we RCU-free the task struct? Because then we don't even > need to care about

Re: [PATCH 2/3] kbuild, arc: add CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE_O3 for ARC

2019-08-30 Thread Vineet Gupta
On 8/20/19 10:09 AM, Masahiro Yamada wrote: > arch/arc/Makefile overrides -O2 with -O3. This is the only user of > ARCH_CFLAGS. There is no user of ARCH_CPPFLAGS or ARCH_AFLAGS. > My plan is to remove ARCH_{CPP,A,C}FLAGS after refactoring the ARC > Makefile. Why, it seems like a good generic

[PATCH] drivers/staging/exfat - by default, prohibit mount of fat/vfat

2019-08-30 Thread Valdis Klētnieks
Concerns have been raised about the exfat driver accidentally mounting fat/vfat file systems. Add an extra configure option to help prevent that. Suggested-by: Christoph Hellwig Signed-off-by: Valdis Kletnieks diff --git a/drivers/staging/exfat/Kconfig b/drivers/staging/exfat/Kconfig index

Re: [PATCH v4 3/4] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings

2019-08-30 Thread Bjorn Andersson
On Fri 30 Aug 09:01 PDT 2019, Stephen Boyd wrote: > Quoting Jorge Ramirez (2019-08-29 00:03:48) > > On 2/23/19 17:52, Bjorn Andersson wrote: > > > On Thu 07 Feb 03:17 PST 2019, Jorge Ramirez-Ortiz wrote: > > >> + > > >> +Required child nodes: > > >> + > > >> +- usb connector node as defined in

RE: objtool warning "uses BP as a scratch register" with clang-9

2019-08-30 Thread David Laight
From: Linus Torvalds > Sent: 30 August 2019 17:01 > On Fri, Aug 30, 2019 at 8:55 AM David Laight wrote: ... > But yeah, in general it's just not obviously safe to turn individual > accesses into memset/memcpy. In contrast, the reverse is obviously > fine (and _required_ for any kind of half-way

Re: [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver

2019-08-30 Thread Amit Kucheria
On Fri, Aug 30, 2019 at 9:25 PM Stephen Boyd wrote: > > Quoting Amit Kucheria (2019-08-30 04:32:54) > > On Thu, Aug 29, 2019 at 10:04 PM Amit Kucheria > > wrote: > > > > > > On Thu, Aug 29, 2019 at 8:23 PM Stephen Boyd wrote: > > > > > > > > Can we get a known quantity of interrupts for a

Re: [GIT PULL] Ceph fixes for 5.3-rc7

2019-08-30 Thread pr-tracker-bot
The pull request you sent on Fri, 30 Aug 2019 16:11:15 +0200: > https://github.com/ceph/ceph-client.git tags/ceph-for-5.3-rc7 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/fbcb0b4feb5c3f5431a2ed9f0211653864cf2104 Thank you! -- Deet-doot-dot, I am a bot.

Re: [GIT PULL] MMC fixes for v5.3-rc7

2019-08-30 Thread pr-tracker-bot
The pull request you sent on Fri, 30 Aug 2019 09:41:47 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git tags/mmc-v5.3-rc5 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/0d70787b65941a8db36fd2c35d25c93178f8b545 Thank you! -- Deet-doot-dot, I am a

Re: [PULL REQUEST] Please pull rdma.git

2019-08-30 Thread pr-tracker-bot
The pull request you sent on Fri, 30 Aug 2019 11:42:36 -0400: > git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git tags/for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8fb8e9e46261e0117cb3cffb6dd8bb7e08f8649b Thank you! -- Deet-doot-dot, I am a

Re: [PATCH] checkpatch: Remove obsolete period from "ambiguous SHA1" query

2019-08-30 Thread Joe Perches
On Fri, 2019-08-30 at 09:31 -0700, Sean Christopherson wrote: > Git dropped the period from its "ambiguous SHA1" error message in commit > 0c99171ad2 ("get_short_sha1: mark ambiguity error for translation"), > circa 2016. Drop the period from checkpatch's associated query so as to > match both

[PATCH v2 -rcu dev 2/5] rcu/tree: Add multiple in-flight batches of kfree_rcu work

2019-08-30 Thread Joel Fernandes (Google)
During testing, it was observed that amount of memory consumed due kfree_rcu() batching is 300-400MB. Previously we had only a single head_free pointer pointing to the list of rcu_head(s) that are to be freed after a grace period. Until this list is drained, we cannot queue any more objects on it

[PATCH] checkpatch: Validate Fixes: tag using 'commit' checks

2019-08-30 Thread Sean Christopherson
Rework checkpatch's commit checking to explicitly include the Fixes: tag so that it catches errors like too short[1] or fat fingered[2] SHA1 references. Add a new Fixes-only check to verify the fixed commit is a valid object in the repository. [1]

[PATCH v2 -rcu dev 0/5] kfree_rcu() additions for -rcu

2019-08-30 Thread Joel Fernandes (Google)
Hi, This is a series on top of the patch "rcu/tree: Add basic support for kfree_rcu() batching". It adds performance tests, some clean ups and removal of "lazy" RCU callbacks. Now that kfree_rcu() is handled separately from call_rcu(), we also get rid of kfree "lazy" handling from tree RCU as

[PATCH v2 -rcu dev 5/5] rcu: Remove kfree_call_rcu_nobatch()

2019-08-30 Thread Joel Fernandes (Google)
Now that kfree_rcu() special casing have been removed from tree RCU, remove kfree_call_rcu_nobatch() since it is not needed. Signed-off-by: Joel Fernandes (Google) --- .../admin-guide/kernel-parameters.txt | 4 --- include/linux/rcutiny.h | 5 ---

[PATCH v2 -rcu dev 3/5] rcu/tree: Add support for debug_objects debugging for kfree_rcu()

2019-08-30 Thread Joel Fernandes (Google)
Make use of RCU's debug_objects debugging support (CONFIG_DEBUG_OBJECTS_RCU_HEAD) similar to call_rcu() and other flavors. We queue the object during the kfree_rcu() call and dequeue it during reclaim. Tested that enabling CONFIG_DEBUG_OBJECTS_RCU_HEAD successfully detects double kfree_rcu()

[PATCH v2 -rcu dev 4/5] rcu: Remove kfree_rcu() special casing and lazy handling

2019-08-30 Thread Joel Fernandes (Google)
Remove kfree_rcu() special casing and lazy handling from RCU. For Tiny RCU we fold the special handling into just Tiny RCU code. Results in a nice negative delta as well. Suggested-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) --- Documentation/RCU/stallwarn.txt | 11 +++-

[PATCH v2 -rcu dev 1/5] rcu/rcuperf: Add kfree_rcu() performance Tests

2019-08-30 Thread Joel Fernandes (Google)
This test runs kfree_rcu() in a loop to measure performance of the new kfree_rcu() batching functionality. The following table shows results when booting with arguments: rcuperf.kfree_loops=2 rcuperf.kfree_alloc_num=8000 rcuperf.kfree_rcu_test=1 rcuperf.kfree_no_batch=X

Re: [GIT PULL] ARM: SoC fixes for Linux-5.3

2019-08-30 Thread Linus Torvalds
On Fri, Aug 30, 2019 at 9:26 AM Arnd Bergmann wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git armsoc-fixes > > for you to fetch changes up to 7a6c9dbb36a415c5901313fc89871fd19f533656: Nope. That's a stale tag for me, pointing to commit 7bd9d465140a. Your old pull

Re: [PATCH V40 23/29] bpf: Restrict bpf when kernel lockdown is in confidentiality mode

2019-08-30 Thread David Howells
Matthew Garrett wrote: > From: David Howells > > bpf_read() and bpf_read_str() could potentially be abused to (eg) allow > private keys in kernel memory to be leaked. Disable them if the kernel > has been locked down in confidentiality mode. > > Suggested-by: Alexei Starovoitov >

Re: [PATCH V40 04/29] lockdown: Enforce module signatures if the kernel is locked down

2019-08-30 Thread David Howells
Matthew Garrett wrote: > enum lockdown_reason { > LOCKDOWN_NONE, > + LOCKDOWN_MODULE_SIGNATURE, > LOCKDOWN_INTEGRITY_MAX, > LOCKDOWN_CONFIDENTIALITY_MAX, > }; Aren't you mixing disjoint sets? > + [LOCKDOWN_MODULE_SIGNATURE] = "unsigned module loading", Wouldn't it

[PATCH] checkpatch: Remove obsolete period from "ambiguous SHA1" query

2019-08-30 Thread Sean Christopherson
Git dropped the period from its "ambiguous SHA1" error message in commit 0c99171ad2 ("get_short_sha1: mark ambiguity error for translation"), circa 2016. Drop the period from checkpatch's associated query so as to match both the old and new error messages. Signed-off-by: Sean Christopherson ---

Re: [PATCH V40 03/29] security: Add a static lockdown policy LSM

2019-08-30 Thread David Howells
Matthew Garrett wrote: > +static char *lockdown_reasons[LOCKDOWN_CONFIDENTIALITY_MAX+1] = { const char *const maybe? > +static enum lockdown_reason lockdown_levels[] = {LOCKDOWN_NONE, > + LOCKDOWN_INTEGRITY_MAX, > +

[PATCH v2 -rcu dev 2/2] rcu/dyntick-idle: Add better tracing

2019-08-30 Thread Joel Fernandes (Google)
The dyntick-idle traces are a bit confusing. This patch makes it simpler and adds some missing cases such as EQS-enter due to user vs idle mode. Following are the changes: (1) Add a new context field to trace_rcu_dyntick tracepoint. This context field can be "USER", "IDLE" or "IRQ". (2)

[PATCH v2 -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

2019-08-30 Thread Joel Fernandes (Google)
This code is unused and can be removed now. Revert was straightforward. Tested with light rcutorture. Link: http://lore.kernel.org/r/CALCETrWNPOOdTrFabTDd=h7+wc6xj9rjceg6ol1s0rtv5pf...@mail.gmail.com Suggested-by: Andy Lutomirski Signed-off-by: Joel Fernandes (Google) --- Only made some

[GIT PULL] ARM: SoC fixes for Linux-5.3

2019-08-30 Thread Arnd Bergmann
The following changes since commit d45331b00ddb179e291766617259261c112db872: Linux 5.3-rc4 (2019-08-11 13:26:41 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git armsoc-fixes for you to fetch changes up to

[PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

2019-08-30 Thread Joel Fernandes (Google)
This code is unused and can be removed now. Revert was straightforward. Tested with light rcutorture. Link: http://lore.kernel.org/r/CALCETrWNPOOdTrFabTDd=h7+wc6xj9rjceg6ol1s0rtv5pf...@mail.gmail.com Suggested-by: Andy Lutomirski Signed-off-by: Joel Fernandes (Google) ---

[PATCH -rcu dev 2/2] rcu/dyntick-idle: Add better tracing

2019-08-30 Thread Joel Fernandes (Google)
The dyntick-idle traces are a bit confusing. This patch makes it simpler and adds some missing cases such as EQS-enter due to user vs idle mode. Following are the changes: (1) Add a new context field to trace_rcu_dyntick tracepoint. This context field can be "USER", "IDLE" or "IRQ". (2)

Re: [BUG] Use of probe_kernel_address() in task_rcu_dereference() without checking return value

2019-08-30 Thread Linus Torvalds
On Fri, Aug 30, 2019 at 9:10 AM Oleg Nesterov wrote: > > > Yes, please see > > [PATCH 2/3] introduce probe_slab_address() > https://lore.kernel.org/lkml/20141027195425.gc11...@redhat.com/ > > I sent 5 years ago ;) Do you think > > /* > * Same as

Re: [PATCH v2] selftests: watchdog: Add optional file argument

2019-08-30 Thread shuah
On 8/30/19 10:13 AM, George G. Davis wrote: On Fri, Aug 30, 2019 at 09:12:10AM -0600, shuah wrote: On 8/30/19 6:53 AM, George G. Davis wrote: diff --git a/tools/testing/selftests/watchdog/watchdog-test.c b/tools/testing/selftests/watchdog/watchdog-test.c @@ -69,6 +70,7 @@ static void term(int

Re: [PATCH v2] selftests: watchdog: Add optional file argument

2019-08-30 Thread George G. Davis
On Fri, Aug 30, 2019 at 09:12:10AM -0600, shuah wrote: > On 8/30/19 6:53 AM, George G. Davis wrote: > >diff --git a/tools/testing/selftests/watchdog/watchdog-test.c > >b/tools/testing/selftests/watchdog/watchdog-test.c > >@@ -69,6 +70,7 @@ static void term(int sig) > > static void usage(char

Re: [PATCH] net/skbuff: silence warnings under memory pressure

2019-08-30 Thread Eric Dumazet
On 8/30/19 5:25 PM, Qian Cai wrote: > On Fri, 2019-08-30 at 17:11 +0200, Eric Dumazet wrote: >> >> On 8/30/19 4:57 PM, Qian Cai wrote: >>> When running heavy memory pressure workloads, the system is throwing >>> endless warnings below due to the allocation could fail from >>> __build_skb(), and

[PATCH] dmaengine: stm32-dma: Use struct_size() helper

2019-08-30 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct stm32_dma_desc { ... struct stm32_dma_sg_req sg_req[]; };

Re: [PATCH 2/2] tpm: tpm_crb: enhance resource mapping mechanism for supporting AMD's fTPM

2019-08-30 Thread Seunghun Han
> > On Fri, Aug 30, 2019 at 10:54:59PM +0900, Seunghun Han wrote: > > > When I tested this patch in my machine, it seemed that ACPI NVS was > > saved after TPM CRB driver sent "TPM2_Shutdown(STATE)" to the fTPM > > while suspending. Then, ACPI NVS was restored while resuming. > > After resuming,

[PATCH 1/3] m68k: remove ioremap_fullcache

2019-08-30 Thread Christoph Hellwig
No callers of this function. Signed-off-by: Christoph Hellwig Acked-by: Geert Uytterhoeven --- arch/m68k/include/asm/kmap.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/arch/m68k/include/asm/kmap.h b/arch/m68k/include/asm/kmap.h index aac7f045f7f0..03d904fe6087 100644 ---

[PATCH 3/3] ia64: rename ioremap_nocache to ioremap_uc

2019-08-30 Thread Christoph Hellwig
On ia64 ioremap_nocache fails if attributes don't match. Not other architectures does this, and we plan to get rid of ioremap_nocache. So get rid of the special semantics and define ioremap_nocache in terms of ioremap as no portable driver could rely on the behavior anyway. However x86

ioremap cleanups

2019-08-30 Thread Christoph Hellwig
Hi all, these are three cleanups from my generic ioremap series that needed a few edits, and which I'd like you to pick up through your respective arch trees for 5.4 if possible.

[PATCH 2/3] microblaze: remove ioremap_fullcache

2019-08-30 Thread Christoph Hellwig
No callers of this function. Signed-off-by: Christoph Hellwig --- arch/microblaze/include/asm/io.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/microblaze/include/asm/io.h b/arch/microblaze/include/asm/io.h index c7968139486f..86c95b2a1ce1 100644 ---

RE: objtool warning "uses BP as a scratch register" with clang-9

2019-08-30 Thread David Laight
From: Arnd Bergmann > Sent: 30 August 2019 16:59 ... > > Or even better, it would be great if we could get Clang to change their > > memset() insertion heuristics, so that KASAN acts more like non-KASAN > > code in that regard. > > I suspect that's going to be harder. The clang-9 release is going

Re: [BUG] Use of probe_kernel_address() in task_rcu_dereference() without checking return value

2019-08-30 Thread Oleg Nesterov
On 08/30, Linus Torvalds wrote: > > Side note: that code had better not be performance-critical, because > "probe_kernel_address()" is actually really really slow. Yes, please see [PATCH 2/3] introduce probe_slab_address()

[PATCH 1/3] dt-bindings: hwmon: Document ibm,cffps2 compatible string

2019-08-30 Thread Eddie James
Document the compatible string for version 2 of the IBM CFFPS PSU. Signed-off-by: Eddie James --- Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt

Re: [PATCH] tpm: Remove duplicate code from caps_show() in tpm-sysfs.c

2019-08-30 Thread Jerry Snitselaar
On Thu Aug 29 19, Jarkko Sakkinen wrote: Replace existing TPM 1.x version structs with new structs that consolidate the common parts into a single struct so that code duplication is no longer needed in caps_show(). Cc: Alexey Klimov Cc: Jerry Snitselaar Signed-off-by: Jarkko Sakkinen ---

Re: [PATCH v3 6/7] erofs: remove all likely/unlikely annotations

2019-08-30 Thread Gao Xiang
Hi Christoph, On Fri, Aug 30, 2019 at 08:46:50AM -0700, Christoph Hellwig wrote: > On Fri, Aug 30, 2019 at 11:36:42AM +0800, Gao Xiang wrote: > > As Dan Carpenter suggested [1], I have to remove > > all erofs likely/unlikely annotations. > > Do you have to remove all of them, or just those where

Re: [RFC][Patch v12 1/2] mm: page_reporting: core infrastructure

2019-08-30 Thread Nitesh Narayan Lal
On 8/30/19 11:31 AM, Alexander Duyck wrote: > On Fri, Aug 30, 2019 at 8:15 AM Nitesh Narayan Lal wrote: >> >> On 8/12/19 2:47 PM, Alexander Duyck wrote: >>> On Mon, Aug 12, 2019 at 6:13 AM Nitesh Narayan Lal >>> wrote: This patch introduces the core infrastructure for free page reporting

Re: objtool warning "uses BP as a scratch register" with clang-9

2019-08-30 Thread Linus Torvalds
On Fri, Aug 30, 2019 at 8:14 AM Josh Poimboeuf wrote: > > What about just adding a couple of WRITE_ONCE's to sas_ss_reset()? That > would probably be the least disruptive option. I think that WRITE_ONCE() with a comment about why is a good idea. The reason I dislike WRITE_ONCE() in general is

Re: [PATCH v2] s390: vfio-ap: remove unnecessary calls to disable queue interrupts

2019-08-30 Thread Halil Pasic
On Mon, 19 Aug 2019 13:48:49 -0400 Tony Krowiak wrote: > When an AP queue is reset (zeroized), interrupts are disabled. The queue > reset function currently tries to disable interrupts unnecessarily. This patch > removes the unnecessary calls to disable interrupts after queue reset. > >

Re: [PATCH v4 3/4] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings

2019-08-30 Thread Stephen Boyd
Quoting Jorge Ramirez (2019-08-29 00:03:48) > On 2/23/19 17:52, Bjorn Andersson wrote: > > On Thu 07 Feb 03:17 PST 2019, Jorge Ramirez-Ortiz wrote: > >> + > >> +Required child nodes: > >> + > >> +- usb connector node as defined in bindings/connector/usb-connector.txt > >> + containing the

Re: objtool warning "uses BP as a scratch register" with clang-9

2019-08-30 Thread Linus Torvalds
On Fri, Aug 30, 2019 at 8:55 AM David Laight wrote: > > Even in userspace you might be accessing mmap()ed PCIe device memory. > The last thing you want is the compiler converting anything into > 'rep movsb'. Agreed, although for actual IO accesses you likely should really be doing "volatile"

Re: [PATCH v3] libata/ahci: Drop PCS quirk for Denverton and beyond

2019-08-30 Thread Dan Williams
On Fri, Aug 30, 2019 at 8:47 AM Stephen Douthit wrote: > > On 8/29/19 7:30 PM, Dan Williams wrote: > > The Linux ahci driver has historically implemented a configuration fixup > > for platforms / platform-firmware that fails to enable the ports prior > > to OS hand-off at boot. The fixup was

Re: objtool warning "uses BP as a scratch register" with clang-9

2019-08-30 Thread Arnd Bergmann
On Fri, Aug 30, 2019 at 5:14 PM Josh Poimboeuf wrote: > On Fri, Aug 30, 2019 at 12:44:24PM +0200, Arnd Bergmann wrote: > > On Fri, Aug 30, 2019 at 1:24 AM Josh Poimboeuf wrote: > > > On Wed, Aug 28, 2019 at 05:40:01PM +0200, Arnd Bergmann wrote: > > > > diff --git a/arch/x86/kernel/signal.c

Re: [PATCH RFC 03/14] drivers: irqchip: add PDC irqdomain for wakeup capable GPIOs

2019-08-30 Thread Lina Iyer
On Fri, Aug 30 2019 at 08:50 -0600, Marc Zyngier wrote: [Please use my kernel.org address in the future. The days of this arm.com address are numbered...] Sure, will update and repost. On 29/08/2019 19:11, Lina Iyer wrote: Introduce a new domain for wakeup capable GPIOs. The domain can be

Re: [PATCH v2 1/1] netfilter: nf_tables: fib: Drop IPV6 packages if IPv6 is disabled on boot

2019-08-30 Thread Florian Westphal
Leonardo Bras wrote: > On Thu, 2019-08-29 at 22:58 +0200, Florian Westphal wrote: > [...] > > 1. add a patch to BREAK in nft_fib_netdev.c for !ipv6_mod_enabled() > [...] > > But this is still needed? I mean, in nft_fib_netdev_eval there are only > 2 functions being called for IPv6 protocol :

RE: objtool warning "uses BP as a scratch register" with clang-9

2019-08-30 Thread David Laight
From: Linus Torvalds > Sent: 30 August 2019 16:49 > On Fri, Aug 30, 2019 at 8:02 AM Josh Poimboeuf wrote: > > > > For KASAN, the Clang threshold for inserting memset() is *2* consecutive > > writes instead of 17. Isn't that likely to cause tearing-related > > surprises? > > Tearing isn't likely

Re: [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver

2019-08-30 Thread Stephen Boyd
Quoting Amit Kucheria (2019-08-30 04:32:54) > On Thu, Aug 29, 2019 at 10:04 PM Amit Kucheria > wrote: > > > > On Thu, Aug 29, 2019 at 8:23 PM Stephen Boyd wrote: > > > > > > Can we get a known quantity of interrupts for a particular compatible > > > string instead? Let's be as specific as

Re: [PATCH 0/5] dt-bindings: arm: idle-states: Miscellaneous improvements

2019-08-30 Thread Amit Kucheria
On Fri, Aug 30, 2019 at 8:33 PM Geert Uytterhoeven wrote: > > - Replace abbreviations "eg" and "ie" by "e.g." resp. "i.e.", > - Correct references to wake-up delay, > - Correct "constraints guarantees" to "constraint guarantees", > - Add punctuation marks to improve readability, > -

Re: [PATCH] riscv: add arch/riscv/Kbuild

2019-08-30 Thread Christoph Hellwig
On Tue, Aug 27, 2019 at 02:14:59PM +0900, Masahiro Yamada wrote: > There is a small documentation about "Makefile" vs "Kbuild" > in Documentation/kbuild/modules.rst section 3.2 I know that part. > > It is talking about external modules, but the benefit applies > to arch/$(SRCARCH)/Kbuild as

Re: [PATCH v2 2/7] erofs: some marcos are much more readable as a function

2019-08-30 Thread Gao Xiang
Hi Christoph, On Fri, Aug 30, 2019 at 08:45:51AM -0700, Christoph Hellwig wrote: > On Thu, Aug 29, 2019 at 08:16:27PM -0700, Joe Perches wrote: > > > - sizeof(__u32) * ((__count) - 1); }) > > > +static inline unsigned int erofs_xattr_ibody_size(__le16 d_icount) > > > +{ > > > + unsigned

[PATCH] keys: ensure that ->match_free() is called in request_key_and_link()

2019-08-30 Thread David Howells
From: Eric Biggers If check_cached_key() returns a non-NULL value, we still need to call key_type::match_free() to undo key_type::match_preparse(). Fixes: 7743c48e54ee ("keys: Cache result of request_key*() temporarily in task_struct") Signed-off-by: Eric Biggers Signed-off-by: David Howells

Re: [PATCH v2 1/1] netfilter: nf_tables: fib: Drop IPV6 packages if IPv6 is disabled on boot

2019-08-30 Thread Leonardo Bras
On Thu, 2019-08-29 at 22:58 +0200, Florian Westphal wrote: [...] > 1. add a patch to BREAK in nft_fib_netdev.c for !ipv6_mod_enabled() [...] But this is still needed? I mean, in nft_fib_netdev_eval there are only 2 functions being called for IPv6 protocol : nft_fib6_eval and nft_fib6_eval_type.

Re: objtool warning "uses BP as a scratch register" with clang-9

2019-08-30 Thread Linus Torvalds
On Fri, Aug 30, 2019 at 8:02 AM Josh Poimboeuf wrote: > > For KASAN, the Clang threshold for inserting memset() is *2* consecutive > writes instead of 17. Isn't that likely to cause tearing-related > surprises? Tearing isn't likely to be a problem. It's not like memcpy() does byte-by-byte

Re: [PATCH v3] libata/ahci: Drop PCS quirk for Denverton and beyond

2019-08-30 Thread Stephen Douthit
On 8/29/19 7:30 PM, Dan Williams wrote: > The Linux ahci driver has historically implemented a configuration fixup > for platforms / platform-firmware that fails to enable the ports prior > to OS hand-off at boot. The fixup was originally implemented way back > before ahci moved from drivers/scsi/

RE: [PATCH v2 1/6] mdev: Introduce sha1 based mdev alias

2019-08-30 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Friday, August 30, 2019 7:32 PM > To: Parav Pandit > Cc: alex.william...@redhat.com; Jiri Pirko ; > kwankh...@nvidia.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger.kernel.org > Subject:

Re: [PATCH v2 4/4] sched/fair: Prevent active LB from preempting higher sched classes

2019-08-30 Thread Valentin Schneider
On 29/08/2019 15:19, Vincent Guittot wrote: [...] >> Right, if we end up kicking the cpu_stopper this can still happen (since >> we drop the lock). Thing is, you can't detect it on the cpu_stopper side, >> since the currently running is obviously not going to be CFS (and it's >> too late anyway,

[PATCH 2/2] tpm: tpm_crb: enhance resource mapping mechanism for supporting AMD's fTPM

2019-08-30 Thread Safford, David (GE Global Research, US)
> From: linux-integrity-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Seunghun Han > Sent: Friday, August 30, 2019 9:55 AM > To: Jason Gunthorpe > Cc: Jarkko Sakkinen ; Peter Huewe > ; open list:TPM DEVICE DRIVER integr...@vger.kernel.org>; Linux Kernel Mailing List

Re: [BUG] Use of probe_kernel_address() in task_rcu_dereference() without checking return value

2019-08-30 Thread Linus Torvalds
On Fri, Aug 30, 2019 at 8:40 AM Russell King - ARM Linux admin wrote: > > Ah, ok. Might be worth some comments - I find the comments in that > function particularly unhelpful (even after Oleg mentions this is > case 2.) Yeah, a comment like "This might fault if we race with the task scheduling

Re: [PATCH 4/7] iommu/arm-smmu: Add global/context fault implementation hooks

2019-08-30 Thread Robin Murphy
On 29/08/2019 23:47, Krishna Reddy wrote: Add global/context fault hooks to allow Nvidia SMMU implementation handle faults across multiple SMMUs. Signed-off-by: Krishna Reddy --- drivers/iommu/arm-smmu-nvidia.c | 127 drivers/iommu/arm-smmu.c

Re: [PATCH] staging: exfat: add exfat filesystem code to staging

2019-08-30 Thread Pali Rohár
On Friday 30 August 2019 08:40:06 Christoph Hellwig wrote: > On Thu, Aug 29, 2019 at 10:56:31PM +0200, Pali Rohár wrote: > > In my opinion, proper way should be to implement exFAT support into > > existing fs/fat/ code instead of replacing whole vfat/msdosfs by this > > new (now staging) fat

[PULL REQUEST] Please pull rdma.git

2019-08-30 Thread Doug Ledford
Hi Linus, *Much* calmer week this week. Just one -rc patch queued up. The way the siw driver was locking around the traversal of the list of ipv6 addresses on a device was causing a scheduling while atomic issue. Bernard straightened it out by using the rtnl_lock. Here's the boiler plate:

Re: [BUG] Use of probe_kernel_address() in task_rcu_dereference() without checking return value

2019-08-30 Thread Linus Torvalds
On Fri, Aug 30, 2019 at 8:30 AM Linus Torvalds wrote: > > Do you actually see that behavior? > > Because the foillowing lines: > > smp_rmb(); > if (unlikely(task != READ_ONCE(*ptask))) > goto retry; Side note: that code had better not be performance-critical,

Re: [PATCH 10/11] selinux: Implement the watch_key security hook [ver #7]

2019-08-30 Thread Stephen Smalley
On 8/30/19 10:41 AM, David Howells wrote: How about the attached instead, then? Works for me. David --- commit 00444a695b35c602230ac2cabb4f1d7e94e3966d Author: David Howells Date: Thu Aug 29 17:01:34 2019 +0100 selinux: Implement the watch_key security hook Implement the

Re: [PATCH 0/4] objtool,perf: Use shared x86 insn decoder

2019-08-30 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 31, 2019 at 12:20:04AM +0900, Masami Hiramatsu escreveu: > On Thu, 29 Aug 2019 17:41:17 -0500 > Josh Poimboeuf wrote: > > > It's kind of silly that we have *three* identical copies of the x86 insn > > decoder in the kernel tree. Make it approximately 50% less silly by > > reducing

Re: [PATCH v6 4/4] tpm: tpm_tis_spi: Support cr50 devices

2019-08-30 Thread Stephen Boyd
Quoting Heiko Stuebner (2019-08-30 08:33:48) > Am Freitag, 30. August 2019, 00:41:10 CEST schrieb Stephen Boyd: > > From: Andrey Pronin > > > > Add TPM2.0 PTP FIFO compatible SPI interface for chips with Cr50 > > firmware. The firmware running on the currently supported H1 Secure > >

Re: [BUG] Use of probe_kernel_address() in task_rcu_dereference() without checking return value

2019-08-30 Thread Russell King - ARM Linux admin
On Fri, Aug 30, 2019 at 08:30:00AM -0700, Linus Torvalds wrote: > On Fri, Aug 30, 2019 at 7:08 AM Russell King - ARM Linux admin > wrote: > > > > which means that when probe_kernel_address() returns -EFAULT, the > > destination is left uninitialised. In the case of > > task_rcu_dereference(),

Re: [PATCH block/for-next] writeback: add tracepoints for cgroup foreign writebacks

2019-08-30 Thread Jan Kara
On Thu 29-08-19 15:47:19, Tejun Heo wrote: > cgroup foreign inode handling has quite a bit of heuristics and > internal states which sometimes makes it difficult to understand > what's going on. Add tracepoints to improve visibility. > > Signed-off-by: Tejun Heo ... >

Re: [PATCH] staging: exfat: add exfat filesystem code to staging

2019-08-30 Thread Christoph Hellwig
On Thu, Aug 29, 2019 at 10:56:31PM +0200, Pali Rohár wrote: > In my opinion, proper way should be to implement exFAT support into > existing fs/fat/ code instead of replacing whole vfat/msdosfs by this > new (now staging) fat implementation. > > In linux kernel we really do not need two different

RE: objtool warning "uses BP as a scratch register" with clang-9

2019-08-30 Thread David Laight
From: Josh Poimboeuf > Sent: 30 August 2019 16:02 > On Thu, Aug 29, 2019 at 03:26:30PM -0700, Linus Torvalds wrote: > > On Thu, Aug 29, 2019 at 1:22 PM Arnd Bergmann wrote: > > > > > > Maybe we can just pass -fno-builtin-memcpy -fno-builtin-memset > > > for clang when CONFIG_KASAN is set and hope

Re: [PATCH] staging: exfat: add exfat filesystem code to staging

2019-08-30 Thread Christoph Hellwig
On Thu, Aug 29, 2019 at 01:18:10PM +0200, Greg Kroah-Hartman wrote: > Hey, that's not nice, erofs isn't a POS. It could always use more > review, which the developers asked for numerous times. > > There's nothing different from a filesystem compared to a driver. If > its stand-alone, and

Re: [RFC PATCH] tools/power turbostat: Add support for Hygon Fam 18h (Dhyana) RAPL

2019-08-30 Thread Pu Wen
On 2019/8/30 22:27, Calvin Walton wrote: > I was a bit worried about these two chunks, since as far as I know AMD > has not yet released any processor with family 0x18, so there might be > future conflicts: Hygon negotiated with AMD to make sure that only Hygon will use family 18h. > Please add

Re: [PATCH v6 4/4] tpm: tpm_tis_spi: Support cr50 devices

2019-08-30 Thread Heiko Stuebner
Am Freitag, 30. August 2019, 00:41:10 CEST schrieb Stephen Boyd: > From: Andrey Pronin > > Add TPM2.0 PTP FIFO compatible SPI interface for chips with Cr50 > firmware. The firmware running on the currently supported H1 Secure > Microcontroller requires a special driver to handle its specifics: >

Re: [PATCH 2/2] touchscreen: goodix: define GPIO mapping for GPD P2 Max

2019-08-30 Thread Peter Cai
On August 30, 2019 7:55:05 PM GMT+08:00, Andy Shevchenko wrote: >On Fri, Aug 30, 2019 at 08:00:24AM +0800, Peter Cai wrote: >> The firmware of GPD P2 Max could not handle panel resets although >code >> is present in DSDT. The kernel needs to take on this job instead, but >> the DSDT does not

Re: [PATCH] selftests/seccomp: fix build on older kernels

2019-08-30 Thread Tycho Andersen
On Fri, Aug 30, 2019 at 09:19:00AM -0600, shuah wrote: > On 8/29/19 6:45 PM, shuah wrote: > > On 8/29/19 11:06 AM, Kees Cook wrote: > > > On Mon, Aug 26, 2019 at 08:43:02AM -0600, Tycho Andersen wrote: > > > > The seccomp selftest goes to some length to build against older kernel > > > > headers,

Re: [RFC][Patch v12 1/2] mm: page_reporting: core infrastructure

2019-08-30 Thread Alexander Duyck
On Fri, Aug 30, 2019 at 8:15 AM Nitesh Narayan Lal wrote: > > > On 8/12/19 2:47 PM, Alexander Duyck wrote: > > On Mon, Aug 12, 2019 at 6:13 AM Nitesh Narayan Lal > > wrote: > >> This patch introduces the core infrastructure for free page reporting in > >> virtual environments. It enables the

Re: [BUG] Use of probe_kernel_address() in task_rcu_dereference() without checking return value

2019-08-30 Thread Linus Torvalds
On Fri, Aug 30, 2019 at 7:08 AM Russell King - ARM Linux admin wrote: > > which means that when probe_kernel_address() returns -EFAULT, the > destination is left uninitialised. In the case of > task_rcu_dereference(), this means that "siginfo" can be used without > having been initialised,

Re: [PATCH v4 01/10] KVM: arm64: Document PV-time interface

2019-08-30 Thread Steven Price
On 30/08/2019 15:47, Andrew Jones wrote: > On Fri, Aug 30, 2019 at 09:42:46AM +0100, Steven Price wrote: >> Introduce a paravirtualization interface for KVM/arm64 based on the >> "Arm Paravirtualized Time for Arm-Base Systems" specification DEN 0057A. >> >> This only adds the details about "Stolen

Re: [PATCH] net/skbuff: silence warnings under memory pressure

2019-08-30 Thread Qian Cai
On Fri, 2019-08-30 at 17:11 +0200, Eric Dumazet wrote: > > On 8/30/19 4:57 PM, Qian Cai wrote: > > When running heavy memory pressure workloads, the system is throwing > > endless warnings below due to the allocation could fail from > > __build_skb(), and the volume of this call could be huge

Re: [BUG] Use of probe_kernel_address() in task_rcu_dereference() without checking return value

2019-08-30 Thread Oleg Nesterov
On 08/30, Russell King - ARM Linux admin wrote: > > which means that when probe_kernel_address() returns -EFAULT, the > destination is left uninitialised. In the case of > task_rcu_dereference(), this means that "siginfo" can be used without > having been initialised, Yes, but this is fine,

Re: [kbuild-all] [tip: x86/vmware] input/vmmouse: Update the backdoor call with support for new instructions

2019-08-30 Thread Philip Li
On Fri, Aug 30, 2019 at 05:06:53PM +0200, Borislav Petkov wrote: > On Fri, Aug 30, 2019 at 11:00:02PM +0800, Philip Li wrote: > > Early on, there's requirement to blacklist a few branches, which is > > configured > > as below > > blacklist_branch: auto-.*|tmp-.*|base-.*|test.*|.*-for-linus >

Re: [PATCH 0/4] objtool,perf: Use shared x86 insn decoder

2019-08-30 Thread Masami Hiramatsu
On Thu, 29 Aug 2019 17:41:17 -0500 Josh Poimboeuf wrote: > It's kind of silly that we have *three* identical copies of the x86 insn > decoder in the kernel tree. Make it approximately 50% less silly by > reducing that number to two. > Sounds good to me ;) Reviewed-by: Masami Hiramatsu

Re: [PATCH] selftests/seccomp: fix build on older kernels

2019-08-30 Thread shuah
On 8/29/19 6:45 PM, shuah wrote: On 8/29/19 11:06 AM, Kees Cook wrote: On Mon, Aug 26, 2019 at 08:43:02AM -0600, Tycho Andersen wrote: The seccomp selftest goes to some length to build against older kernel headers, viz. all the #ifdefs at the beginning of the file. 201766a20e30 ("ptrace: add

Re: [PATCH] xfs: add function name in xfs_trans_ail_delete function header comments

2019-08-30 Thread Darrick J. Wong
On Fri, Aug 30, 2019 at 06:59:49PM +0800, yu kuai wrote: > Fix following warning: > make W=1 fs/xfs/xfs_trans_ail.o > fs/xfs/xfs_trans_ail.c:793: warning: Function parameter or member > 'ailp' not described in 'xfs_trans_ail_delete' > fs/xfs/xfs_trans_ail.c:793: warning: Function parameter or

Re: [RFC][Patch v12 1/2] mm: page_reporting: core infrastructure

2019-08-30 Thread Nitesh Narayan Lal
On 8/12/19 2:47 PM, Alexander Duyck wrote: > On Mon, Aug 12, 2019 at 6:13 AM Nitesh Narayan Lal wrote: >> This patch introduces the core infrastructure for free page reporting in >> virtual environments. It enables the kernel to track the free pages which >> can be reported to its hypervisor so

<    1   2   3   4   5   6   7   8   9   >