Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-02 Thread Jacek Anaszewski
On 9/2/19 8:12 PM, Greg KH wrote: > On Sun, Sep 01, 2019 at 06:53:34PM +0200, Jacek Anaszewski wrote: >> Hi Akinobu, >> >> Thank you for the patch. >> >> I have one nit below but in general it looks good to me. >> I've tested it with 2000 mtd triggers (~14kB file size) >> and it worked flawlessly.

Re: [PATCH] Fix a double free bug in rsi_91x_deinit

2019-09-02 Thread Greg KH
On Sun, Sep 01, 2019 at 07:08:29AM -0700, Guenter Roeck wrote: > On 9/1/19 1:03 AM, Kalle Valo wrote: > > Guenter Roeck writes: > > > > > On Mon, Aug 19, 2019 at 06:02:29PM -0400, Hui Peng wrote: > > > > `dev` (struct rsi_91x_usbdev *) field of adapter > > > > (struct rsi_91x_usbdev *) is

Re: [PATCH] net: stmmac: dwmac-sun8i: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized

2019-09-02 Thread David Miller
From: Yizhuo Date: Fri, 30 Aug 2019 19:00:48 -0700 > In function sun8i_dwmac_set_syscon(), local variable "val" could > be uninitialized if function regmap_field_read() returns -EINVAL. > However, it will be used directly in the if statement, which > is potentially unsafe. > > Signed-off-by:

[PATCH] staging: exfat: use BIT macro for defining sizes

2019-09-02 Thread Valentin Vidic
Fixes checkpatch.pl warning: CHECK: Prefer using the BIT macro Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h index

Re: [PATCH] power/supply: ingenic-battery: Don't change scale if there's only one

2019-09-02 Thread Sebastian Reichel
Hi, On Mon, Jul 22, 2019 at 10:45:54PM -0400, Paul Cercueil wrote: > The ADC in the JZ4740 can work either in high-precision mode with a 2.5V > range, or in low-precision mode with a 7.5V range. The code in place in > this driver will select the proper scale according to the maximum > voltage of

Re: [PATCH] drivers/staging/exfat - by default, prohibit mount of fat/vfat

2019-09-02 Thread Valdis Klētnieks
On Mon, 02 Sep 2019 17:25:24 +0200, Greg Kroah-Hartman said: > I dug up my old discussion with the current vfat maintainer and he said > something to the affect of, "leave the existing code alone, make a new > filesystem, I don't want anything to do with exfat". > > And I don't blame them, vfat

Re: [PATCH] power: supply: max17042_battery: Fix a typo in function names

2019-09-02 Thread Sebastian Reichel
Hi, On Sun, Jul 21, 2019 at 06:03:28PM +0200, Christophe JAILLET wrote: > It is likely that 'max10742_[un]lock_model()' functions should be > 'max17042_[un]lock_model()' > (0 and 7 switched in 10742) > > Signed-off-by: Christophe JAILLET > --- Thanks, queued. -- Sebastian >

Re: [PATCH net-next] net/ncsi: support unaligned payload size in NC-SI cmd handler

2019-09-02 Thread David Miller
From: Ben Wei Date: Mon, 2 Sep 2019 02:46:52 + > Update NC-SI command handler (both standard and OEM) to take into > account of payload paddings in allocating skb (in case of payload > size is not 32-bit aligned). > > The checksum field follows payload field, without taking payload >

[PATCH] staging: exfat: cleanup blank line warnings

2019-09-02 Thread Valentin Vidic
Fixes checkpatch.pl warnings: CHECK: Please don't use multiple blank lines CHECK: Blank lines aren't necessary after an open brace '{' CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat.h

Re: [PATCH v2] power: supply: ab8500: remove set but not used variables 'vbup33_vrtcn' and 'bup_vch_range'

2019-09-02 Thread Sebastian Reichel
Hi, On Wed, Jul 17, 2019 at 10:18:48PM +0800, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warnings: > > drivers/power/supply/ab8500_charger.c: > In function ab8500_charger_init_hw_registers: > drivers/power/supply/ab8500_charger.c:3013:24: warning: > variable vbup33_vrtcn set but

Re: [PATCH] drivers/staging/exfat - by default, prohibit mount of fat/vfat

2019-09-02 Thread Greg Kroah-Hartman
On Mon, Sep 02, 2019 at 03:00:17PM -0400, Valdis Klētnieks wrote: > On Mon, 02 Sep 2019 17:25:24 +0200, Greg Kroah-Hartman said: > > > I dug up my old discussion with the current vfat maintainer and he said > > something to the affect of, "leave the existing code alone, make a new > > filesystem,

Re: [PATCH] power: reset: reboot-mode: Fix author email format

2019-09-02 Thread Sebastian Reichel
Hi, On Sat, Jul 13, 2019 at 06:42:48PM +0300, Matwey V. Kornilov wrote: > Closing angle bracket was missing. > > Signed-off-by: Matwey V. Kornilov > --- Thanks, queued. -- Sebastian > drivers/power/reset/reboot-mode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH net-next 0/2] mvpp2: per-cpu buffers

2019-09-02 Thread David Miller
From: Matteo Croce Date: Mon, 2 Sep 2019 12:21:35 +0200 > This patchset workarounds an PP2 HW limitation which prevents to use > per-cpu rx buffers. > The first patch is just a refactor to prepare for the second one. > The second one allocates percpu buffers if the following conditions are met:

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-02 Thread Greg KH
On Mon, Sep 02, 2019 at 08:47:02PM +0200, Jacek Anaszewski wrote: > On 9/2/19 8:12 PM, Greg KH wrote: > > On Sun, Sep 01, 2019 at 06:53:34PM +0200, Jacek Anaszewski wrote: > >> Hi Akinobu, > >> > >> Thank you for the patch. > >> > >> I have one nit below but in general it looks good to me. > >>

Re: [PATCH 03/14] power: supply: sc27xx: Introduce local variable 'struct device *dev'

2019-09-02 Thread Sebastian Reichel
Hi, On Mon, Jul 08, 2019 at 08:32:51PM +0800, Fuqian Huang wrote: > Introduce local variable 'struct device *dev' and use it instead of > dereferencing it repeatly. > > Signed-off-by: Fuqian Huang > --- Thanks, queued. -- Sebastian > drivers/power/supply/sc27xx_fuel_gauge.c | 47 >

Re: [PATCH 04/14] power: supply: sc27xx: Replace devm_add_action() followed by failure action with devm_add_action_or_reset()

2019-09-02 Thread Sebastian Reichel
Hi, On Mon, Jul 08, 2019 at 08:32:59PM +0800, Fuqian Huang wrote: > devm_add_action_or_reset() is introduced as a helper function which > internally calls devm_add_action(). If devm_add_action() fails > then it will execute the action mentioned and return the error code. > This reduce source

Re: [PATCH] power: supply: isp1704: remove redundant assignment to variable ret

2019-09-02 Thread Sebastian Reichel
Hi, On Fri, Jul 05, 2019 at 10:36:12AM +0100, Colin King wrote: > From: Colin Ian King > > The variable ret is being assigned with a value that is never > read and it is being updated later with a new value. The > assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused

Re: [PATCH] power: supply: bq25890_charger: Add the BQ25895 part

2019-09-02 Thread Sebastian Reichel
Hi, On Fri, Jul 05, 2019 at 05:37:51AM -0600, Angus Ainslie (Purism) wrote: > The BQ25895 is almost identical to the BQ25890. > > Signed-off-by: Angus Ainslie (Purism) > --- Thanks, queued. -- Sebastian > drivers/power/supply/bq25890_charger.c | 12 > 1 file changed, 8

Re: [PATCH] power: supply: max77650: add MODULE_ALIAS()

2019-09-02 Thread Sebastian Reichel
Hi, On Wed, Jul 03, 2019 at 10:48:10AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Define a MODULE_ALIAS() in the charger sub-driver for max77650 so that > the appropriate module gets loaded together with the core mfd driver. > > Signed-off-by: Bartosz Golaszewski > ---

[PATCH] adfs: Fill in max and min timestamps in sb

2019-09-02 Thread Deepa Dinamani
Fill in the appropriate limits to avoid inconsistencies in the vfs cached inode times when timestamps are outside the permitted range. Note that the min timestamp is assumed to be 01 Jan 1970 00:00:00 (Unix epoch). This is consistent with the way we convert timestamps in adfs_adfs2unix_time().

Re: [PATCH v2 1/3] ASoC: es8316: judge PCM rate at later timing

2019-09-02 Thread Katsuhiro Suzuki
Hello Mark, Thanks a lot for your comments. On 2019/09/02 21:02, Mark Brown wrote: On Sun, Sep 01, 2019 at 01:26:48AM +0900, Katsuhiro Suzuki wrote: This patch change the judge timing about playing/capturing PCM rate. Original code set constraints list of PCM rate limits at set_sysclk. This

Re: [PATCH] doc:lock: remove reference to clever use of read-write lock

2019-09-02 Thread Federico Vaga
On Monday, September 2, 2019 8:10:10 PM CEST Ingo Molnar wrote: > * Federico Vaga wrote: > > On Saturday, August 31, 2019 4:43:44 PM CEST Jonathan Corbet wrote: > > > On Sat, 31 Aug 2019 15:41:16 +0200 > > > > > > Federico Vaga wrote: > > > > several CPU's and you want to use spinlocks you can

Re: [PATCH] power: reset: reboot-mode: Fix author email format

2019-09-02 Thread Joe Perches
On Mon, 2019-09-02 at 21:06 +0200, Sebastian Reichel wrote: > Hi, > > On Sat, Jul 13, 2019 at 06:42:48PM +0300, Matwey V. Kornilov wrote: > > Closing angle bracket was missing. > > > > Signed-off-by: Matwey V. Kornilov > > --- > > Thanks, queued. This is relatively widespread. There are 80

Re: [PATCH] Fix a double free bug in rsi_91x_deinit

2019-09-02 Thread Guenter Roeck
On 9/2/19 11:47 AM, Greg KH wrote: On Sun, Sep 01, 2019 at 07:08:29AM -0700, Guenter Roeck wrote: On 9/1/19 1:03 AM, Kalle Valo wrote: Guenter Roeck writes: On Mon, Aug 19, 2019 at 06:02:29PM -0400, Hui Peng wrote: `dev` (struct rsi_91x_usbdev *) field of adapter (struct rsi_91x_usbdev *)

Re: [PATCH v2 3/3] nvme: fire discovery log page change events to userspace

2019-09-02 Thread Greg Kroah-Hartman
On Fri, Aug 30, 2019 at 11:14:39AM -0700, Sagi Grimberg wrote: > > > > > > > > You are correct that this information can be derived from sysfs, > > > > > > > but the > > > > > > > main reason why we add these here, is because in udev rule we > > > > > > > can't > > > > > > > just go ahead and

Re: [PATCH][V2][cifs-next] cifs: fix dereference on ses before it is null checked

2019-09-02 Thread Steve French
Tentatively merged into cifs-2.6.git pending additional testing Kicked off buildbot with rc7+patches in cifs for-next See http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/247 On Mon, Sep 2, 2019 at 10:33 AM Colin King wrote: > > From: Colin Ian King > > The

[PATCH] compal-laptop: Variable "value" in function ec_read_u8() could be uninitialized

2019-09-02 Thread Yizhuo
In function ec_read_u8(), variable "value" could be uninitialized if ec_read() fails. However, "value" is returned directly and used in its callers. This is potentially unsafe. Signed-off-by: Yizhuo --- drivers/platform/x86/compal-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Dear Friend,

2019-09-02 Thread Elizabeth Edwards
Dear Friend, Please forgive me for stressing you with my predicaments as I know that this letter may come to you as big surprise. Actually, as my pastor advised me to reject earthly reward and thanks by handing the project to someone I have never seen or met for a greater reward in heaven

Re: [PATCH] Fix a double free bug in rsi_91x_deinit

2019-09-02 Thread Greg KH
On Mon, Sep 02, 2019 at 12:32:37PM -0700, Guenter Roeck wrote: > On 9/2/19 11:47 AM, Greg KH wrote: > > On Sun, Sep 01, 2019 at 07:08:29AM -0700, Guenter Roeck wrote: > > > On 9/1/19 1:03 AM, Kalle Valo wrote: > > > > Guenter Roeck writes: > > > > > > > > > On Mon, Aug 19, 2019 at 06:02:29PM

Re: Let's talk about the elephant in the room - the Linux kernel's inability to gracefully handle low memory pressure

2019-09-02 Thread Pavel Machek
Hi! > > > > And if there is a meaningful way to make the kernel behave better, that > > would > > obviously be of huge value too. > > > > Thanks > > Daniel > > Hi, > > Is there a way for an application to be told that there is a memory > pressure situation? > For example, say I do a "make

Re: Policy to keep USB ports powered in low-power states

2019-09-02 Thread Pavel Machek
Hi! > > Without knowing the internal design, but having more infor now, looks to me > > that > > should be modelled more as a kind of power supply? Maybe something similar > > to > > UCS1002-2 device (drivers/power/supply/ucs1002_power.c) but behind the EC? > > This would work, the problem

Re: [PATCH 0/5] EDAC: Small cleanups and fixes

2019-09-02 Thread Mauro Carvalho Chehab
Em Mon, 2 Sep 2019 12:33:38 + Robert Richter escreveu: > A bunch of cleanups and fixes for issues found while working with the > code. Changes are individual and independent from each other. They can > be applied separately (only #4 depends on #3). > > Also updating the reviewer's entry as

Re: [PATCH] arm64: dts: imx8mn-ddr4-evk: Enable GPIO LED

2019-09-02 Thread Pavel Machek
On Mon 2019-09-02 16:45:38, Anson Huang wrote: > i.MX8MN DDR4 EVK board has a GPIO LED to indicate status, > add support for it. LED maintainers want to be on the cc list... > @@ -15,6 +15,18 @@ > stdout-path = > }; > > + leds { > + compatible =

Re: [PATCH v3] cpuidle-haltpoll: vcpu hotplug support

2019-09-02 Thread Rafael J. Wysocki
On Mon, Sep 2, 2019 at 12:43 PM Joao Martins wrote: > > When cpus != maxcpus cpuidle-haltpoll will fail to register all vcpus > past the online ones and thus fail to register the idle driver. > This is because cpuidle_add_sysfs() will return with -ENODEV as a > consequence from get_cpu_device()

Re: [PATCH] power: reset: make reboot-mode user selectable

2019-09-02 Thread Sebastian Reichel
Hi Arnd and Nandor, On Mon, Aug 05, 2019 at 09:57:15AM +0200, Arnd Bergmann wrote: > Nandor Han points out that there might be drivers that can use > the reboot-mode interfaces but might also be usable on configurations > without device tree. > > Move the 'depends on OF' dependency into

Re: [PATCH] iio: adc: meson_saradc: Fix memory allocation order

2019-09-02 Thread Elie Roudninski
On Sun, Sep 1, 2019 at 12:29 PM Martin Blumenstingl wrote: > > On Sun, Sep 1, 2019 at 12:45 PM Remi Pommarel wrote: > > > > meson_saradc's irq handler uses priv->regmap so make sure that it is > > allocated before the irq get enabled. > > > > This also fixes crash when CONFIG_DEBUG_SHIRQ is

Re: [RFC,v2 2/6] i2c: add I2C Address Translator (ATR) support

2019-09-02 Thread Wolfram Sang
Hi Luca, > + * Topology: > + * > + * Slave X @ 0x10 > + * .-. | > + * .-. | |---+ B > + * | CPU |--A--| ATR | > + * `-' | |---+ C > + * `-' | > + * Slave Y @ 0x10 > + * > + *

Re: [RFC,v2 3/6] media: dt-bindings: add DS90UB954-Q1 video deserializer

2019-09-02 Thread Wolfram Sang
> + - i2c-alias-pool: list of I2C addresses that are known to be available on > the > + "local" (SoC-to-deser) I2C bus; they will be picked at > +runtime and used as aliases to reach remove I2C chips After some internal discussion, I have been kinda convinced

Re: [PATCH] ACPI: support for NXP i2c controller

2019-09-02 Thread Rafael J. Wysocki
On Thu, Jul 11, 2019 at 12:35 PM Chuanhua Han wrote: > > Enable NXP i2c controller to boot with ACPI > > Signed-off-by: Meenakshi Aggarwal > Signed-off-by: Udit Kumar > Signed-off-by: Chuanhua Han Wolfram, any objections to this from the i2c side? > --- > drivers/acpi/acpi_apd.c | 6

Re: [PATCH] ACPI: support for NXP i2c controller

2019-09-02 Thread Wolfram Sang
On Mon, Sep 02, 2019 at 10:56:22PM +0200, Rafael J. Wysocki wrote: > On Thu, Jul 11, 2019 at 12:35 PM Chuanhua Han wrote: > > > > Enable NXP i2c controller to boot with ACPI > > > > Signed-off-by: Meenakshi Aggarwal > > Signed-off-by: Udit Kumar > > Signed-off-by: Chuanhua Han > > Wolfram,

Re: [PATCH] iwlwifi: mvm: Move static keyword to the front of declarations

2019-09-02 Thread Krzysztof Wilczynski
Hi Luca, [...] > Thanks for your patch! Though we already have this change in our > internal tree (submitted by YueHaibing) and it will reach the mainline > soon. Thank you for letting me know. I am glad it's fixed. :) Krzysztof

Re: [PATCH 0/6] Optimize the Spreadtrum SC27xx fuel gauge

2019-09-02 Thread Sebastian Reichel
Hi, On Wed, Jul 31, 2019 at 06:00:22PM +0800, Baolin Wang wrote: > This patch set adds new attributes for userspace, and fixes the the > accuracy issue of coulomb counter calculation, as well as optimizing > the battery capacity calibration in some abnormal scenarios. > > Any comments are

Re: [PATCH 1/3] ACPI: Remove acpi_has_method() call from acpi_adxl.c

2019-09-02 Thread Rafael J. Wysocki
Sorry for the delayed reply. On Mon, Jul 22, 2019 at 8:29 PM Bjorn Helgaas wrote: > > [+cc Tony (original author), Borislav (merged original patch)] > > On Mon, Jul 22, 2019 at 10:31:11AM +0200, Rafael J. Wysocki wrote: > > On Mon, Jul 22, 2019 at 4:36 AM Kelsey Skunberg > > wrote: > > > > > >

linux-next: Signed-off-by missing for commits in the fuse tree

2019-09-02 Thread Stephen Rothwell
Hi all, Commit 5eae593422da ("vfs: Convert fuse to use the new mount API") is missing a Signed-off-by from its author. Commit c08428c528bc ("vfs: Create fs_context-aware mount_bdev() replacement") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell

Re: [PATCH] ACPI: support for NXP i2c controller

2019-09-02 Thread Andy Shevchenko
On Mon, Sep 2, 2019 at 11:58 PM Rafael J. Wysocki wrote: > > On Thu, Jul 11, 2019 at 12:35 PM Chuanhua Han wrote: > > > > Enable NXP i2c controller to boot with ACPI > > > > Signed-off-by: Meenakshi Aggarwal > > Signed-off-by: Udit Kumar > > Signed-off-by: Chuanhua Han > > Wolfram, any

Re: [PATCH] power: reset: make reboot-mode user selectable

2019-09-02 Thread Arnd Bergmann
On Mon, Sep 2, 2019 at 10:39 PM Sebastian Reichel wrote: > > This patch does not look good to me. Better patch would be to > allow compiling CONFIG_REBOOT_MODE without CONFIG_OF. Obviously > the configuration would not be useful for anything except compile > testing, but that is also true for

linux-next: Signed-off-by missing for commits in the kgdb-dt tree

2019-09-02 Thread Stephen Rothwell
Hi all, Commits f12dc871e3ec ("kgdb: fix comment regarding static function") c60d67aad7b7 ("kdb: Replace strncmp with str_has_prefix") are missing a Signed-off-by from their committer. -- Cheers, Stephen Rothwell pgp1tiNEWoLiD.pgp Description: OpenPGP digital signature

[PATCH RFC 0/2] interconnect: qcom: add msm8974 driver

2019-09-02 Thread Brian Masney
Here's a patch series that adds interconnect support for the Qualcomm MSM8974, which is needed so that the GPU can be supported upstream. I'm having an issue with getting this to work fully and included a detailed write up in patch 2 with what I'm seeing. I think I am close to getting this working

[PATCH RFC 2/2] interconnect: qcom: add msm8974 driver

2019-09-02 Thread Brian Masney
Add driver for the Qualcomm MSM8974 interconnect providers that support setting system bandwidth requirements between various network-on-chip fabrics. I marked this as a PATCH RFC since I'm not able to write to all of the master IDs with qcom_icc_rpm_smd_send(). I included tables below that shows

[PATCH RFC 1/2] dt-bindings: interconnect: qcom: add msm8974 bindings

2019-09-02 Thread Brian Masney
Add device tree bindings for the Qualcomm MSM8974 interconnect providers that support setting system bandwidth requirements between various network-on-chip fabrics. Signed-off-by: Brian Masney --- .../bindings/interconnect/qcom,msm8974.yaml | 163 ++

Re: [PATCH v2] ACPI / PCI: fix acpi_pci_irq_enable() memory leak

2019-09-02 Thread Rafael J. Wysocki
On Wed, Aug 21, 2019 at 5:44 AM Wenwen Wang wrote: > > In acpi_pci_irq_enable(), 'entry' is allocated by kzalloc() in > acpi_pci_irq_check_entry() (invoked from acpi_pci_irq_lookup()). However, > it is not deallocated if acpi_pci_irq_valid() returns false, leading to a > memory leak. To fix this

Re: [PATCH 1/4] ACPI: Support Generic Initiator only domains

2019-09-02 Thread Rafael J. Wysocki
On Wed, Aug 21, 2019 at 4:53 PM Jonathan Cameron wrote: > > Generic Initiators are a new ACPI concept that allows for the > description of proximity domains that contain a device which > performs memory access (such as a network card) but neither > host CPU nor Memory. > > This patch has the

Re: [PATCH] mm/vmalloc: move 'area->pages' after if statement

2019-09-02 Thread Austin Kim
2019년 8월 31일 (토) 오전 5:50, Andrew Morton 님이 작성: > > On Fri, 30 Aug 2019 12:57:16 +0900 Austin Kim wrote: > > > If !area->pages statement is true where memory allocation fails, > > area is freed. > > > > In this case 'area->pages = pages' should not executed. > > So move 'area->pages = pages' after

Re: [PATCH] acpi/hmat: ACPI_HMAT_MEMORY_PD_VALID is deprecated in ACPI-6.3

2019-09-02 Thread Rafael J. Wysocki
On Tue, Aug 6, 2019 at 6:24 AM Daniel Black wrote: > > ACPI-6.3 corresponds to when hmat revision was bumped from > 1 to 2. In this version ACPI_HMAT_MEMORY_PD_VALID was > deprecated and made reserved. > > As such in revision 2+ we shouldn't be testing this flag. > > This is as per ACPI-6.3,

Re: [PATCH] ACPICA: Namespace: fix the no brace needed warning

2019-09-02 Thread Rafael J. Wysocki
On Sat, Aug 31, 2019 at 10:34 AM tiantao wrote: > > for if else statements having single block no braces are needed fixed > the following checkpatch warning > > WARNING: braces {} are not necessary for any arm of this statement > + if (!prev_node) { > [...] > + } else

Re: [PATCH 15/22] media: imx7-media-csi: Create media links in bound notifier

2019-09-02 Thread Steve Longerbeam
Hi Rui, On 9/2/19 2:38 AM, Rui Miguel Silva wrote: Hi Steve, On Tue 06 Aug 2019 at 00:34, Steve Longerbeam wrote: Implement a notifier bound op to register media links from the remote sub-device's source pad(s) to the CSI sink pad. Signed-off-by: Steve Longerbeam ---

Re: Is: Default governor regardless of cpuidle driver Was: [PATCH v2] cpuidle-haltpoll: vcpu hotplug support

2019-09-02 Thread Rafael J. Wysocki
On Thu, Aug 29, 2019 at 7:24 PM Marcelo Tosatti wrote: > > On Thu, Aug 29, 2019 at 06:16:05PM +0100, Joao Martins wrote: > > On 8/29/19 4:10 PM, Joao Martins wrote: > > > When cpus != maxcpus cpuidle-haltpoll will fail to register all vcpus > > > past the online ones and thus fail to register the

Re: Default governor regardless of cpuidle driver

2019-09-02 Thread Rafael J. Wysocki
On Fri, Aug 30, 2019 at 1:09 PM Joao Martins wrote: > > On 8/29/19 10:51 PM, Daniel Lezcano wrote: > > On 29/08/2019 23:12, Joao Martins wrote: > > > > [ ... ] > > > Say you wanted to have a kvm specific config, you would still see the > same > problem if you happen to compile

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-09-02 Thread Martin Blumenstingl
Hi, On Mon, Sep 2, 2019 at 11:45 AM Chuan Hua, Lei wrote: > > Hi Martin, > > > On 9/2/2019 5:38 AM, Martin Blumenstingl wrote: > > Hi, > > > > On Fri, Aug 30, 2019 at 5:02 AM Chuan Hua, Lei > > wrote: > >> Hi Martin, > >> > >> On 8/30/2019 5:40 AM, Martin Blumenstingl wrote: > >>> Hi, > >>> >

Re: [PATCH V7 5/5] mmc: host: sdhci-pci: Add Genesys Logic GL975x support

2019-09-02 Thread Andy Shevchenko
On Fri, Aug 30, 2019 at 5:28 AM Ben Chuang wrote: > > From: Ben Chuang > > Add support for the GL9750 and GL9755 chipsets. > > Enable v4 mode and wait 5ms after set 1.8V signal enable for GL9750/ > GL9755. Fix the value of SDHCI_MAX_CURRENT register and use the vendor > tuning flow for GL9750. >

[PATCH] regulator: pfuze100-regulator: Variable "val" in pfuze100_regulator_probe() could be uninitialized

2019-09-02 Thread Yizhuo
In function pfuze100_regulator_probe(), variable "val" could be initialized if regmap_read() fails. However, "val" is used to decide the control flow later in the if statement, which is potentially unsafe. Signed-off-by: Yizhuo --- drivers/regulator/pfuze100-regulator.c | 2 +- 1 file changed,

Re: [PATCH v3] cpuidle-haltpoll: vcpu hotplug support

2019-09-02 Thread Marcelo Tosatti
On Mon, Sep 02, 2019 at 10:34:07PM +0200, Rafael J. Wysocki wrote: > On Mon, Sep 2, 2019 at 12:43 PM Joao Martins > wrote: > > > > When cpus != maxcpus cpuidle-haltpoll will fail to register all vcpus > > past the online ones and thus fail to register the idle driver. > > This is because

RE: [PATCH v1 1/2] clk: intel: Add CGU clock driver for a new SoC

2019-09-02 Thread Martin Blumenstingl
Hello, I only noticed this patchset today and I don't have much time left. Here's my initial impressions without going through the code in detail. I'll continue my review in the next days (as time permits). As with all other Intel LGM patches: I don't have access to the datasheets, so it's

Re: [RFC PATCH v2 00/19] RDMA/FS DAX truncate proposal V1,000,002 ;-)

2019-09-02 Thread Dave Chinner
On Wed, Aug 28, 2019 at 07:02:31PM -0700, Ira Weiny wrote: > On Mon, Aug 26, 2019 at 03:55:10PM +1000, Dave Chinner wrote: > > On Fri, Aug 23, 2019 at 10:08:36PM -0700, Ira Weiny wrote: > > > On Sat, Aug 24, 2019 at 10:11:24AM +1000, Dave Chinner wrote: > > > > On Fri, Aug 23, 2019 at 09:04:29AM

[PATCH] clocksource: atmel-st: Variable sr in at91rm9200_timer_interrupt() could be uninitialized

2019-09-02 Thread Yizhuo
Inside function at91rm9200_timer_interrupt(), variable sr could be uninitialized if regmap_read() fails. However, sr is used to decide the control flow later in the if statement, which is potentially unsafe. We could check the return value of regmap_read() and print an error here. Signed-off-by:

Re: [PATCH v2] ACPI / PCI: fix acpi_pci_irq_enable() memory leak

2019-09-02 Thread Bjorn Helgaas
On Mon, Sep 02, 2019 at 11:19:58PM +0200, Rafael J. Wysocki wrote: > On Wed, Aug 21, 2019 at 5:44 AM Wenwen Wang wrote: > > > > In acpi_pci_irq_enable(), 'entry' is allocated by kzalloc() in > > acpi_pci_irq_check_entry() (invoked from acpi_pci_irq_lookup()). However, > > it is not deallocated if

Re: [PATCH] clocksource: atmel-st: Variable sr in at91rm9200_timer_interrupt() could be uninitialized

2019-09-02 Thread Alexandre Belloni
On 02/09/2019 15:29:46-0700, Yizhuo wrote: > Inside function at91rm9200_timer_interrupt(), variable sr could > be uninitialized if regmap_read() fails. However, sr is used Could you elaborate on how this could fail? > to decide the control flow later in the if statement, which is > potentially

[PATCH] extcon: axp288: Variable "val" could be uninitialized if regmap_read() fails

2019-09-02 Thread Yizhuo
In function axp288_extcon_log_rsi(), variable "val" could be uninitialized if regmap_read() fails. However, it's ued to decide the control flow later in the if statement, which is potentially unsafe. Signed-off-by: Yizhuo --- drivers/extcon/extcon-axp288.c | 5 + 1 file changed, 5

Re: [PATCH 2/2] tpm: tpm_crb: enhance resource mapping mechanism for supporting AMD's fTPM

2019-09-02 Thread Seunghun Han
> > On Fri, Aug 30, 2019 at 05:58:39PM +, Safford, David (GE Global Research, > US) wrote: > > > Thank you for your advice. We also discussed earlier and concluded that > > > checking and raw remapping are enough to work around this. The link is > > > here, https://lkml.org/lkml/2019/8/29/962

Re: [PATCH v14 1/6] sched/core: uclamp: Extend CPU's cgroup controller

2019-09-02 Thread Suren Baghdasaryan
Hi Patrick, On Thu, Aug 22, 2019 at 6:28 AM Patrick Bellasi wrote: > > The cgroup CPU bandwidth controller allows to assign a specified > (maximum) bandwidth to the tasks of a group. However this bandwidth is > defined and enforced only on a temporal base, without considering the > actual

Re: linux-next: build failure after merge of the keys tree

2019-09-02 Thread Stephen Rothwell
Hi David, On Mon, 02 Sep 2019 17:01:19 +0100 David Howells wrote: > > Stephen Rothwell wrote: > > > The forward declararion doesn't seem to work (at laste for the > > !CONFIG_USB_NOTIFICATIONS case. > > In the !CONFIG_USB_NOTIFICATIONS case, the argument is to a stub inline > function.

Re: [f2fs-dev] [PATCH] f2fs: convert inline_data in prior to i_size_write

2019-09-02 Thread Jaegeuk Kim
On 09/02, Chao Yu wrote: > On 2019/9/1 15:25, Jaegeuk Kim wrote: > > On 08/31, Chao Yu wrote: > >> On 2019/8/30 23:34, Jaegeuk Kim wrote: > >>> This can guarantee inline_data has smaller i_size. > >> > >> So I guess "f2fs: fix to avoid corruption during inline conversion" didn't > >> fix > >>

[PATCH] net: hisilicon: Variable "reg_value" in function mdio_sc_cfg_reg_write() could be uninitialized

2019-09-02 Thread Yizhuo
In function mdio_sc_cfg_reg_write(), variable reg_value could be uninitialized if regmap_read() fails. However, this variable is used later in the if statement, which is potentially unsafe. Signed-off-by: Yizhuo --- drivers/net/ethernet/hisilicon/hns_mdio.c | 8 +++- 1 file changed, 7

[PATCH] irqdomain: Add the missing assignment of domain->fwnode for named fwnode

2019-09-02 Thread Dexuan Cui
Recently device pass-through stops working for Linux VM running on Hyper-V. git-bisect shows the regression is caused by the recent commit 467a3bb97432 ("PCI: hv: Allocate a named fwnode ..."), but the root cause is that the commit d59f6617eef0 forgets to set the domain->fwnode for

Re: linux-next: build failure after merge of the keys tree

2019-09-02 Thread David Howells
Stephen Rothwell wrote: > > static inline void post_usb_device_notification(const struct usb_device > > *udev, > > unsigned int subtype, u32 > > error) {} > > But not published, yet? I was hoping to get the smack patch reviewed by Casey first, but

Re: linux-next: build failure after merge of the keys tree

2019-09-02 Thread Stephen Rothwell
Hi David, On Tue, 3 Sep 2019 09:07:22 +1000 Stephen Rothwell wrote: > > > > I then discovered that I needed to install libkeyutils-dev :-( but it > > > built OK after that. > > > > ? The kernel shouldn't require that to build. > > I was doing an x86_64 allmodconfig build which seems to

Re: [PATCH] net: hisilicon: Variable "reg_value" in function mdio_sc_cfg_reg_write() could be uninitialized

2019-09-02 Thread Yizhuo Zhai
Sorry for the inconvenience. I made some mistake here, please ignore this patch and I will submit a new one. On Mon, Sep 2, 2019 at 4:14 PM Yizhuo wrote: > > In function mdio_sc_cfg_reg_write(), variable reg_value could be > uninitialized if regmap_read() fails. However, this variable is > used

Re: [PATCH] extcon: axp288: Variable "val" could be uninitialized if regmap_read() fails

2019-09-02 Thread Yizhuo Zhai
Thanks Andy, sorry for the inconvenience, I will check the log more carefully next time. On Mon, Sep 2, 2019 at 3:48 PM Andy Shevchenko wrote: > > > > On Tuesday, September 3, 2019, Yizhuo wrote: >> >> In function axp288_extcon_log_rsi(), variable "val" could be >> uninitialized if

Re: linux-next: manual merge of the vfs tree with the fuse tree

2019-09-02 Thread Stephen Rothwell
Hi Al, On Mon, 2 Sep 2019 16:30:04 +0100 Al Viro wrote: > > ... originals cheerfully dropped; will be gone in today's push to > vfs.git#for-next. Not pushed out yet? -- Cheers, Stephen Rothwell pgpC6lmOgb0FJ.pgp Description: OpenPGP digital signature

Re: linux-next: manual merge of the vfs tree with the fuse tree

2019-09-02 Thread Al Viro
On Tue, Sep 03, 2019 at 09:23:17AM +1000, Stephen Rothwell wrote: > Hi Al, > > On Mon, 2 Sep 2019 16:30:04 +0100 Al Viro wrote: > > > > ... originals cheerfully dropped; will be gone in today's push to > > vfs.git#for-next. > > Not pushed out yet? Give me about fifteen minutes...

Re: linux-next: build failure after merge of the keys tree

2019-09-02 Thread Stephen Rothwell
Hi David, On Tue, 03 Sep 2019 00:20:08 +0100 David Howells wrote: > > Ah, yes - the sample demonstrates the key/keyring notifications as well as USB > and block notifications and requires a constant from the keyutils-devel > package. Maybe I should get it from the kernel UAPI headers instead,

RE: [PATCH net-next] net/ncsi: support unaligned payload size in NC-SI cmd handler

2019-09-02 Thread Ben Wei
> > Update NC-SI command handler (both standard and OEM) to take into > > account of payload paddings in allocating skb (in case of payload > > size is not 32-bit aligned). > > > > The checksum field follows payload field, without taking payload > > padding into account can cause checksum being

Re: linux-next: build failure after merge of the hmm tree

2019-09-02 Thread Stephen Rothwell
Hi Jason, On Mon, 2 Sep 2019 10:51:41 + Jason Gunthorpe wrote: > > On Mon, Sep 02, 2019 at 08:50:17PM +1000, Stephen Rothwell wrote: > > Hi all, > > > ERROR: "nd_region_provider_data" [drivers/acpi/nfit/nfit.ko] undefined! > > ERROR: "to_nd_blk_region" [drivers/acpi/nfit/nfit.ko]

Re: [PATCH v7 3/6] powerpc/perf: consolidate read_user_stack_32

2019-09-02 Thread Michael Ellerman
Michal Suchánek writes: > On Mon, 02 Sep 2019 14:01:17 +1000 > Michael Ellerman wrote: >> Michael Ellerman writes: >> > Michal Suchanek writes: >> ... >> >> @@ -295,6 +279,12 @@ static inline int current_is_64bit(void) >> >> } >> >> >> >> #else /* CONFIG_PPC64 */ >> >> +static int

Re: linux-next: build failure after merge of the keys tree

2019-09-02 Thread David Howells
Stephen Rothwell wrote: > > Ah, yes - the sample demonstrates the key/keyring notifications as well as > > USB and block notifications and requires a constant from the > > keyutils-devel package. Maybe I should get it from the kernel UAPI > > headers instead, but that risks generating a

Re: linux-next: build failure after merge of the keys tree

2019-09-02 Thread David Howells
Stephen Rothwell wrote: > > I was doing an x86_64 allmodconfig build which seems to build (all of?) > > the samples. > > Of course, this breaks our crossbuilds :-( > > e.g. S390 allyesconfig build: > > /usr/bin/ld: cannot find -lkeyutils Is it a requirement that stuff in samples/ should be

Re: [PATCH v7 5/6] powerpc/64: Make COMPAT user-selectable disabled on littleendian by default.

2019-09-02 Thread Michael Ellerman
Segher Boessenkool writes: > On Mon, Sep 02, 2019 at 12:03:12PM +1000, Michael Ellerman wrote: >> Michal Suchanek writes: >> > On bigendian ppc64 it is common to have 32bit legacy binaries but much >> > less so on littleendian. >> >> I think the toolchain people will tell you that there is no

[PATCH] fat: fix corruption in fat_alloc_new_dir()

2019-09-02 Thread Jan Stancek
sb_getblk does not guarantee that buffer_head is uptodate. If there is async read running in parallel for same buffer_head, it can overwrite just initialized msdos_dir_entry, leading to corruption: FAT-fs (loop0): error, corrupted directory (invalid entries) FAT-fs (loop0): Filesystem has been

Re: [PATCH v7 5/6] powerpc/64: Make COMPAT user-selectable disabled on littleendian by default.

2019-09-02 Thread Michael Ellerman
Michal Suchánek writes: > On Mon, 02 Sep 2019 12:03:12 +1000 > Michael Ellerman wrote: > >> Michal Suchanek writes: >> > On bigendian ppc64 it is common to have 32bit legacy binaries but much >> > less so on littleendian. >> >> I think the toolchain people will tell you that there is no

Re: [PATCH] power: reset: make reboot-mode user selectable

2019-09-02 Thread Sebastian Reichel
Hi, On Mon, Sep 02, 2019 at 11:16:27PM +0200, Arnd Bergmann wrote: > On Mon, Sep 2, 2019 at 10:39 PM Sebastian Reichel wrote: > > This patch does not look good to me. Better patch would be to > > allow compiling CONFIG_REBOOT_MODE without CONFIG_OF. Obviously > > the configuration would not be

[PATCH 6/8] x86/platform/uv: Decode UVsystab Info

2019-09-02 Thread Mike Travis
Decode the hubless UVsystab passed from BIOS to the kernel saving pertinent info in a similar manner that hubbed UVsystabs are decoded. Signed-off-by: Mike Travis Reviewed-by: Steve Wahl Reviewed-by: Dimitri Sivanich --- arch/x86/kernel/apic/x2apic_uv_x.c | 16 ++-- 1 file

[PATCH 8/8] x86/platform/uv: Account for UV Hubless in is_uvX_hub Ops

2019-09-02 Thread Mike Travis
The references in the is_uvX_hub() function uses the hub_info pointer which will be NULL when the system is hubless. This change avoids that NULL dereference. It is also an optimization in performance. Signed-off-by: Mike Travis Reviewed-by: Steve Wahl Reviewed-by: Dimitri Sivanich ---

[PATCH 7/8] x86/platform/uv: Check EFI Boot to set reboot type

2019-09-02 Thread Mike Travis
Change to checking for EFI Boot type from previous check on if this is a KDUMP kernel. This allows for KDUMP kernels that can handle EFI reboots. Signed-off-by: Mike Travis Reviewed-by: Steve Wahl Reviewed-by: Dimitri Sivanich --- arch/x86/kernel/apic/x2apic_uv_x.c | 18 --

[PATCH 2/8] x86/platform/uv: Return UV Hubless System Type

2019-09-02 Thread Mike Travis
Return the type of UV hubless system for UV specific code that depends on that. Use a define to indicate the change in arg type for this function in uv.h. Add a function to convert UV system type to bit pattern needed for is_uv_hubless(). Signed-off-by: Mike Travis Reviewed-by: Steve Wahl

[PATCH 0/8] x86/platform/UV: Update UV Hubless System Support

2019-09-02 Thread Mike Travis
These patches support upcoming UV systems that do not have a UV HUB. * Save OEM_ID from ACPI MADT probe * Return UV Hubless System Type * Add return code to UV BIOS Init function * Setup UV functions for Hubless UV Systems * Add UV Hubbed/Hubless Proc FS

[PATCH 4/8] x86/platform/uv: Setup UV functions for Hubless UV Systems

2019-09-02 Thread Mike Travis
Add more support for UV systems that do not contain a UV Hub (AKA "hubless"). This update adds support for additional functions required: Use PCH NMI handler instead of a UV Hub NMI handler. Initialize the UV BIOS callback interface used to support specific UV functions.

[PATCH 5/8] x86/platform/uv: Add UV Hubbed/Hubless Proc FS Files

2019-09-02 Thread Mike Travis
Indicate to UV user utilities that UV hubless support is available on this system via the existing /proc infterface. The current interface is maintained with the addition of a new /proc leaves ("hubbed" and "hubless") that contain the specific type of UV arch this one is. Signed-off-by: Mike

[PATCH 3/8] x86/platform/uv: Add return code to UV BIOS Init function

2019-09-02 Thread Mike Travis
Add a return code to the UV BIOS init function that indicates the successful initialization of the kernel/BIOS callback interface. Signed-off-by: Mike Travis Reviewed-by: Steve Wahl Reviewed-by: Dimitri Sivanich --- arch/x86/include/asm/uv/bios.h |2 +- arch/x86/platform/uv/bios_uv.c |

[PATCH 1/8] x86/platform/uv: Save OEM_ID from ACPI MADT probe

2019-09-02 Thread Mike Travis
Save the OEM_ID and OEM_TABLE_ID passed to the apic driver probe function for later use. Also, convert the char list arg passed from the kernel to a true null-terminated string. Signed-off-by: Mike Travis Reviewed-by: Steve Wahl Reviewed-by: Dimitri Sivanich ---

[PATCH v4 04/12] Drivers: hv: vmbus: Break out synic enable and disable operations

2019-09-02 Thread Dexuan Cui
Break out synic enable and disable operations into separate hv_synic_disable_regs() and hv_synic_enable_regs() functions for use by a later patch to support hibernation. There is no functional change except the unnecessary check "if (sctrl.enable != 1) return -EFAULT;" which is removed, because

<    3   4   5   6   7   8   9   >