Re: [PATCH 09/15] sched,fair: refactor enqueue/dequeue_entity

2019-09-03 Thread Rik van Riel
On Tue, 2019-09-03 at 17:38 +0200, Vincent Guittot wrote: > Hi Rik, > > On Thu, 22 Aug 2019 at 04:18, Rik van Riel wrote: > > Refactor enqueue_entity, dequeue_entity, and update_load_avg, in > > order > > to split out the things we still want to happen at every level in > > the > > cgroup

Re: [PATCH] drm/virtio: Use vmalloc for command buffer allocations.

2019-09-03 Thread David Riley
On Sun, Sep 1, 2019 at 10:28 PM Gerd Hoffmann wrote: > > On Fri, Aug 30, 2019 at 10:49:25AM -0700, David Riley wrote: > > Hi Gerd, > > > > On Fri, Aug 30, 2019 at 4:16 AM Gerd Hoffmann wrote: > > > > > > Hi, > > > > > > > > > - kfree(vbuf->data_buf); > > > > > > +

Re: [RFC PATCH 1/2] Fix: sched/membarrier: p->mm->membarrier_state racy load

2019-09-03 Thread Linus Torvalds
On Tue, Sep 3, 2019 at 1:11 PM Mathieu Desnoyers wrote: > > + cpus_read_lock(); > + for_each_online_cpu(cpu) { This would likely be better off using mm_cpumask(mm) instead of all online CPU's. Plus doing the rcu_read_lock() inside the loop seems pointless. Even with a lot of cores,

Re: [RFC PATCH 1/2] Fix: sched/membarrier: p->mm->membarrier_state racy load

2019-09-03 Thread Peter Zijlstra
On Tue, Sep 03, 2019 at 04:11:34PM -0400, Mathieu Desnoyers wrote: > diff --git a/include/linux/sched.h b/include/linux/sched.h > index 9f51932bd543..e24d52a4c37a 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -1130,6 +1130,10 @@ struct task_struct { > unsigned long

Re: [PATCH v2 3/6] powerpc: Convert flush_icache_range & friends to C

2019-09-03 Thread Gabriel Paubert
On Tue, Sep 03, 2019 at 01:31:57PM -0500, Segher Boessenkool wrote: > On Tue, Sep 03, 2019 at 07:05:19PM +0200, Christophe Leroy wrote: > > Le 03/09/2019 à 18:04, Segher Boessenkool a écrit : > > >(Why are they separate though? It could just be one loop var). > > > > Yes it could just be a

[PATCH v3 8/9] media: ov6650: Fix stored frame format not in sync with hardware

2019-09-03 Thread Janusz Krzysztofik
The driver stores frame format settings supposed to be in line with hardware state in a device private structure. Since the driver initial submission, those settings are updated before they are actually applied on hardware. If an error occurs on device update, the stored settings my not reflect

[PATCH v3 3/9] media: ov6650: Fix crop rectangle alignment not passed back

2019-09-03 Thread Janusz Krzysztofik
Commit 4f996594ceaf ("[media] v4l2: make vidioc_s_crop const") introduced a writable copy of constified user requested crop rectangle in order to be able to perform hardware alignments on it. Later on, commit 10d5509c8d50 ("[media] v4l2: remove g/s_crop from video ops") replaced s_crop() video

[PATCH v3 2/9] media: ov6650: Fix control handler not freed on init error

2019-09-03 Thread Janusz Krzysztofik
Since commit afd9690c72c3 ("[media] ov6650: convert to the control framework"), if an error occurs during initialization of a control handler, resources possibly allocated to the handler are not freed before device initialiaton is aborted. Fix it. Fixes: afd9690c72c3 ("[media] ov6650: convert to

Re: [PATCH v2 2/2] mm, sl[aou]b: guarantee natural alignment for kmalloc(power-of-two)

2019-09-03 Thread Christopher Lameter
On Sat, 31 Aug 2019, Matthew Wilcox wrote: > > The current behavior without special alignment for these caches has been > > in the wild for over a decade. And this is now coming up? > > In the wild ... and rarely enabled. When it is enabled, it may or may > not be noticed as data corruption, or

[PATCH v3 6/9] media: ov6650: Fix .get_fmt() V4L2_SUBDEV_FORMAT_TRY support

2019-09-03 Thread Janusz Krzysztofik
Commit da298c6d98d5 ("[media] v4l2: replace video op g_mbus_fmt by pad op get_fmt") converted a former ov6650_g_fmt() video operation callback to an ov6650_get_fmt() pad operation callback. However, the converted function disregards a format->which flag that pad operations should obey and always

[PATCH v3 4/9] media: ov6650: Fix incorrect use of JPEG colorspace

2019-09-03 Thread Janusz Krzysztofik
Since its initial submission, the driver selects V4L2_COLORSPACE_JPEG for supported formats other than V4L2_MBUS_FMT_SBGGR8_1X8. According to v4l2-compliance test program, V4L2_COLORSPACE_JPEG applies exclusively to V4L2_PIX_FMT_JPEG. Since the sensor does not support JPEG format, fix it to

[PATCH v3 5/9] media: ov6650: Fix some format attributes not under control

2019-09-03 Thread Janusz Krzysztofik
User arguments passed to .get/set_fmt() pad operation callbacks may contain unsupported values. The driver takes control over frame size and pixel code as well as colorspace and field attributes but has never cared for remainig format attributes, i.e., ycbcr_enc, quantization and xfer_func,

[PATCH v3 7/9] media: ov6650: Fix default format not applied on device probe

2019-09-03 Thread Janusz Krzysztofik
It is not clear what pixel format is actually configured in hardware on reset. MEDIA_BUS_FMT_YUYV8_2X8, assumed on device probe since the driver was intiially submitted, is for sure not the one. Fix it by explicitly applying a known, driver default frame format just after initial device reset.

[PATCH v3 0/9] media: ov6650: A collection of fixes

2019-09-03 Thread Janusz Krzysztofik
Janusz Krzysztofik (9): media: ov6650: Fix MODULE_DESCRIPTION media: ov6650: Fix control handler not freed on init error media: ov6650: Fix crop rectangle alignment not passed back media: ov6650: Fix incorrect use of JPEG colorspace media: ov6650: Fix some format attributes not under

[PATCH v3 1/9] media: ov6650: Fix MODULE_DESCRIPTION

2019-09-03 Thread Janusz Krzysztofik
Commit 23a52386fabe ("media: ov6650: convert to standalone v4l2 subdevice") converted the driver from a soc_camera sensor to a standalone V4L subdevice driver. Unfortunately, module description was not updated to reflect the change. Fix it. While being at it, update email address of the module

Re: [RFC PATCH 2/3] Fix: sched/membarrier: READ_ONCE p->mm in membarrier_global_expedited

2019-09-03 Thread Mathieu Desnoyers
- On Sep 3, 2019, at 12:23 PM, Linus Torvalds torva...@linux-foundation.org wrote: > On Tue, Sep 3, 2019 at 9:00 AM Mathieu Desnoyers > wrote: >> >> Due to the lack of READ_ONCE() on p->mm, this code can in fact turn into >> a NULL deref when we hit do_exit() around exit_mm(). The first

Re: [PATCH 03/12] media: hantro: Fix H264 motion vector buffer offset

2019-09-03 Thread Jonas Karlman
On 2019-09-03 12:58, Philipp Zabel wrote: > Hi Jonas, > > On Sun, 2019-09-01 at 12:45 +, Jonas Karlman wrote: >> A decoded 8-bit 4:2:0 frame need memory for up to 448 macroblocks >> and is laid out in memory as follow: > Do you mean "A decoded 8-bit 4:2:0 frame needs up to 448 bytes per >

[PATCH v3 9/9] media: ov6650: Fix stored crop rectangle not in sync with hardware

2019-09-03 Thread Janusz Krzysztofik
The driver stores crop rectangle settings supposed to be in line with hardware state in a device private structure. Since the driver initial submission, crop rectangle width and height settings are not updated correctly when rectangle offset settings are applied on hardware. If an error occurs

[RFC PATCH 2/2] Fix: sched/membarrier: private expedited registration check

2019-09-03 Thread Mathieu Desnoyers
Fix a logic flaw in the way membarrier_register_private_expedited() handles ready state checks for private expedited sync core and private expedited registrations. If a private expedited membarrier registration is first performed, and then a private expedited sync_core registration is performed,

[RFC PATCH 1/2] Fix: sched/membarrier: p->mm->membarrier_state racy load

2019-09-03 Thread Mathieu Desnoyers
The membarrier_state field is located within the mm_struct, which is not guaranteed to exist when used from runqueue-lock-free iteration on runqueues by the membarrier system call. Copy the membarrier_state from the mm_struct into the next task_struct in the scheduler prepare task switch. Upon

Re: [PATCH] staging: exfat: cleanup explicit comparisons to NULL

2019-09-03 Thread Greg Kroah-Hartman
On Tue, Sep 03, 2019 at 07:13:37PM +0200, Valentin Vidic wrote: > Fixes checkpatch.pl warnings: > > CHECK: Comparison to NULL could be written "expr" > CHECK: Comparison to NULL could be written "!expr" > > Signed-off-by: Valentin Vidic > --- > drivers/staging/exfat/exfat_core.c | 34

[PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-03 Thread Joel Fernandes (Google)
Useful to track how RSS is changing per TGID to detect spikes in RSS and memory hogs. Several Android teams have been using this patch in various kernel trees for half a year now. Many reported to me it is really useful so I'm posting it upstream. Initial patch developed by Tim Murray. Changes I

Re: [PATCH] net/mlx5: Use PTR_ERR_OR_ZERO rather than its implementation

2019-09-03 Thread Saeed Mahameed
On Tue, 2019-09-03 at 14:56 +0800, zhong jiang wrote: > PTR_ERR_OR_ZERO contains if(IS_ERR(...)) + PTR_ERR. It is better > to use it directly. hence just replace it. > > Signed-off-by: zhong jiang > --- > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 5 + > 1 file changed, 1

Re: [PATCH 1/5] rcu/rcuperf: Add kfree_rcu() performance Tests

2019-09-03 Thread Paul E. McKenney
On Thu, Aug 29, 2019 at 04:56:37PM -0400, Joel Fernandes wrote: > On Wed, Aug 28, 2019 at 02:12:26PM -0700, Paul E. McKenney wrote: [ . . . ] > > > +static int > > > +kfree_perf_thread(void *arg) > > > +{ > > > + int i, loop = 0; > > > + long me = (long)arg; > > > + struct kfree_obj *alloc_ptr;

Re: [PATCH 2/3] task: RCU protect tasks on the runqueue

2019-09-03 Thread Peter Zijlstra
On Tue, Sep 03, 2019 at 12:18:47PM -0700, Linus Torvalds wrote: > Now, if you can point to some particular field where that ordering > makes sense for the particular case of "make it active on the > runqueue" vs "look up the task from the runqueue using RCU", then I do > think that the whole

[PATCH] mm: emit tracepoint when RSS changes by threshold

2019-09-03 Thread Joel Fernandes (Google)
Useful to track how RSS is changing per TGID. Several Android teams have been using this patch in various kernel trees for half a year now. Many reported to me it is really useful. Initial patch developed by Tim Murray. Changes I made from original patch: o Prevent any additional space consumed

Re: [PATCH -rcu dev 2/2] rcu/dyntick-idle: Add better tracing

2019-09-03 Thread Paul E. McKenney
On Fri, Aug 30, 2019 at 12:23:48PM -0400, Joel Fernandes (Google) wrote: > The dyntick-idle traces are a bit confusing. This patch makes it simpler > and adds some missing cases such as EQS-enter due to user vs idle mode. > > Following are the changes: > (1) Add a new context field to

Re: [PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

2019-09-03 Thread Paul E. McKenney
On Fri, Aug 30, 2019 at 12:23:47PM -0400, Joel Fernandes (Google) wrote: > This code is unused and can be removed now. Revert was straightforward. > > Tested with light rcutorture. > > Link: > http://lore.kernel.org/r/CALCETrWNPOOdTrFabTDd=h7+wc6xj9rjceg6ol1s0rtv5pf...@mail.gmail.com >

Re: [GIT PULL] Please pull FPGA Manager changes for 5.4

2019-09-03 Thread Greg KH
On Sat, Aug 31, 2019 at 01:45:28PM -0700, Moritz Fischer wrote: > The following changes since commit 2949dc443116a66fd1a92d9ef107be16cdd197cd: > > dt-bindings: fpga: Consolidate bridge properties (2019-07-24 14:19:15 -0700) > > are available in the Git repository at: > >

Re: KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device

2019-09-03 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device usb 4-1: Using ep0 maxpacket: 16 usb 4-1: Old BOS 8881d516b780 Len 0xa8 usb 4-1: New BOS 8881d5dd6d20 Len 0xa8

Re: [GIT PULL] Thunderbolt changes for v5.4

2019-09-03 Thread Greg Kroah-Hartman
On Sat, Aug 31, 2019 at 04:56:16PM +0300, Mika Westerberg wrote: > Hi Greg, > > The following changes since commit e21a712a9685488f5ce80495b37b9fdbe96c230d: > > Linux 5.3-rc3 (2019-08-04 18:40:12 -0700) > > are available in the Git repository at: > >

Re: [GIT PULL] PHY: For 5.4

2019-09-03 Thread Greg Kroah-Hartman
On Tue, Aug 27, 2019 at 08:21:46PM +0530, Kishon Vijay Abraham I wrote: > Hi Greg, > > Please find the pull request for 5.4 merge window below. Most of the > updates here are in Marvell's Armada CP110 COMPHY. It also adds a new > PHY driver for Lantiq (now Intel) VRX200/ARX300 PCIe PHY. Please

Re: [PATCH] unicode: Move static keyword to the front of declarations

2019-09-03 Thread Gabriel Krisman Bertazi
Krzysztof Wilczynski writes: > Move the static keyword to the front of declarations of nfdi_test_data > and nfdicf_test_data, and resolve the following compiler warnings that > can be seen when building with warnings enabled (W=1): > > fs/unicode/utf8-selftest.c:38:1: warning: > ‘static’ is

Re: [PATCH v2 3/4] drm/ttm, drm/vmwgfx: Correctly support support AMD memory encryption

2019-09-03 Thread Daniel Vetter
On Tue, Sep 3, 2019 at 9:38 PM Dave Hansen wrote: > > This whole thing looks like a fascinating collection of hacks. :) > > ttm is taking a stack-alllocated "VMA" and handing it to vmf_insert_*() > which obviously are expecting "real" VMAs that are linked into the mm. > It's extracting some

Re: "beyond 2038" warnings from loopback mount is noisy

2019-09-03 Thread Arnd Bergmann
On Tue, Sep 3, 2019 at 9:39 PM Andreas Dilger wrote: > > On Sep 3, 2019, at 12:15 PM, Qian Cai wrote: > > > > On Tue, 2019-09-03 at 09:36 -0700, Deepa Dinamani wrote: > >> We might also want to consider updating the file system the LTP is > >> being run on here. > > > > It simply format

Re: [GIT PULL] interconnect changes for 5.4

2019-09-03 Thread Greg Kroah-Hartman
On Fri, Aug 23, 2019 at 06:14:19PM +0300, Georgi Djakov wrote: > Hi Greg, > > This is a pull request with interconnect patches for the 5.4 merge window. > The patches have been for a while in linux-next without reported issues. The > details are in the signed tag. Please consider pulling into

Re: [RFC 08/12] media: hantro: Fix H264 decoding of field encoded content

2019-09-03 Thread Jonas Karlman
On 2019-09-03 17:01, Philipp Zabel wrote: > On Tue, 2019-09-03 at 14:02 +, Jonas Karlman wrote: >> On 2019-09-03 15:21, Philipp Zabel wrote: >>> On Sun, 2019-09-01 at 12:45 +, Jonas Karlman wrote: This need code cleanup and formatting Signed-off-by: Jonas Karlman >>> The

Re: [GIT PULL] extcon next for v5.4

2019-09-03 Thread Greg KH
On Mon, Aug 26, 2019 at 11:55:13AM +0900, Chanwoo Choi wrote: > Dear Greg, > > This is extcon-next pull request for v5.4. I add detailed description of > this pull request on below. Please pull extcon with following updates. > > > Detailed description for this pull request: > 1. Clean up the

Re: [PATCH 0/3] task: Making tasks on the runqueue rcu protected

2019-09-03 Thread Peter Zijlstra
On Tue, Sep 03, 2019 at 08:44:40AM -0700, Linus Torvalds wrote: > That said, it won't affect any of the core architectures much, because > smp_store_release() isn't that expensive (it's just a compiler barrier > on x86, it's a cheap instruction on arm64, and it should be very cheap > on any other

Re: [PATCH AUTOSEL 4.19 066/167] iio: adc: exynos-adc: Add S5PV210 variant

2019-09-03 Thread Sasha Levin
On Tue, Sep 03, 2019 at 06:53:28PM +0100, Jonathan Cameron wrote: On Tue, 3 Sep 2019 12:23:38 -0400 Sasha Levin wrote: From: Jonathan Bakker [ Upstream commit 882bf52fdeab47dbe991cc0e564b0b51c571d0a3 ] S5PV210's ADC variant is almost the same as v1 except that it has 10 channels and

Re: general protection fault in pk_probe

2019-09-03 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+1088533649dafa1c9...@syzkaller.appspotmail.com Tested on: commit: eea39f24 usb-fuzzer: main usb gadget fuzzer driver git tree:

Re: [PATCH] net: fixed_phy: Add forward declaration for struct gpio_desc;

2019-09-03 Thread Florian Fainelli
On 9/3/19 11:46 AM, Moritz Fischer wrote: > Add forward declaration for struct gpio_desc in order to address > the following: > > ./include/linux/phy_fixed.h:48:17: error: 'struct gpio_desc' declared inside > parameter list [-Werror] > ./include/linux/phy_fixed.h:48:17: error: its scope is only

Re: [RFC PATCH 0/2] Add predictive memory reclamation and compaction

2019-09-03 Thread Khalid Aziz
On 9/2/19 2:02 AM, Michal Hocko wrote: > On Fri 30-08-19 15:35:06, Khalid Aziz wrote: > [...] >> - Kernel is not self-tuning and is dependent upon a userspace tool to >> perform well in a fundamental area of memory management. > > You keep bringing this up without an actual analysis of a wider

Re: [PATCH AUTOSEL 4.19 111/167] signal/arc: Use force_sig_fault where appropriate

2019-09-03 Thread Sasha Levin
On Tue, Sep 03, 2019 at 11:49:16AM -0500, Eric W. Biederman wrote: Sasha Levin writes: From: "Eric W. Biederman" [ Upstream commit 15773ae938d8d93d982461990bebad6e1d7a1830 ] To the best of my knowledge this is just a clean up, no changes in behavior are present. The only reason I can see

Re: [PATCH] csky: Move static keyword to the front of declaration

2019-09-03 Thread Krzysztof Wilczynski
Hello Guo, Thank you for the feedback! [...] > You may also modify others' [...] That work is on-going, and patches are being sent out to address other warnings of this nature to the respective maintainers. :) Krzysztof

Re: [PATCH AUTOSEL 4.19 126/167] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

2019-09-03 Thread Sasha Levin
On Tue, Sep 03, 2019 at 09:53:46AM -0700, Jerry Snitselaar wrote: On Tue Sep 03 19, Doug Anderson wrote: Hi, On Tue, Sep 3, 2019 at 9:28 AM Sasha Levin wrote: From: Vadim Sukhomlinov [ Upstream commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 ] TPM 2.0 Shutdown involve sending

Re: [PATCH 2/3] task: RCU protect tasks on the runqueue

2019-09-03 Thread Peter Zijlstra
On Tue, Sep 03, 2019 at 01:13:22PM -0500, Eric W. Biederman wrote: > I think this is where I am looking a things differently than you and > Peter. Why does it have to be ___schedule() that changes the value > in the task_struct? Why can't it be something else that changes the > value and then

Re: "beyond 2038" warnings from loopback mount is noisy

2019-09-03 Thread Andreas Dilger
On Sep 3, 2019, at 12:15 PM, Qian Cai wrote: > > On Tue, 2019-09-03 at 09:36 -0700, Deepa Dinamani wrote: >> We might also want to consider updating the file system the LTP is >> being run on here. > > It simply format (mkfs.ext4) a loop back device on ext4 with the kernel. > >

Re: KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device

2019-09-03 Thread Alan Stern
On Tue, 3 Sep 2019, syzbot wrote: > Hello, > > syzbot has tested the proposed patch but the reproducer still triggered > crash: > KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device > > usb 4-1: Old BOS ffd70172 Len 0xa8 > usb 4-1: New BOS b6d58371 Len 0xa8 >

Re: [PATCH] powerpc: Avoid clang warnings around setjmp and longjmp

2019-09-03 Thread Segher Boessenkool
On Mon, Sep 02, 2019 at 10:55:53PM -0700, Nathan Chancellor wrote: > On Thu, Aug 29, 2019 at 09:59:48AM +, David Laight wrote: > > From: Nathan Chancellor > > > Sent: 28 August 2019 19:45 > > ... > > > However, I think that -fno-builtin-* would be appropriate here because > > > we are

[PATCH] ufs: Delete an unnecessary check before brelse()

2019-09-03 Thread Markus Elfring
From: Markus Elfring Date: Tue, 3 Sep 2019 21:27:55 +0200 The brelse() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: general protection fault in pk_probe

2019-09-03 Thread Alan Stern
On Tue, 3 Sep 2019, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:eea39f24 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.txt?x=14c3589e60

[PATCH 2/3] arm64: defconfig: Enable the EFI Framebuffer

2019-09-03 Thread Lee Jones
Tested on the Lenovo Yoga C630 where this patch enables the framebuffer (screen/monitor). Without it the device appears not to boot. Signed-off-by: Lee Jones Reviewed-by: Bjorn Andersson --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 3/3] arm64: defconfig: Enable Qualcomm QUSB2 PHY

2019-09-03 Thread Lee Jones
Tested on the Lenovo Yoga C630 where this patch enables USB. Without it USB devices are not enumerated. Signed-off-by: Lee Jones Reviewed-by: Bjorn Andersson --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig

[PATCH 1/3] arm64: defconfig: Enable Qualcomm GENI based I2C controller

2019-09-03 Thread Lee Jones
Tested on the Lenovo Yoga C630 where this patch enables the keyboard, touchpad and touchscreen. Signed-off-by: Lee Jones Reviewed-by: Bjorn Andersson --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig

RE: [PATCH net-next] net/ncsi: support unaligned payload size in NC-SI cmd handler

2019-09-03 Thread Justin.Lee1
That is right. It is necessary to adjust the len for padding on both places. Thanks, Justin > > > Update NC-SI command handler (both standard and OEM) to take into > > > account of payload paddings in allocating skb (in case of payload > > > size is not 32-bit aligned). > > > > > > The

Re: KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device

2019-09-03 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device usb 4-1: Old BOS ffd70172 Len 0xa8 usb 4-1: New BOS b6d58371 Len 0xa8

Re: [PATCH 2/3] task: RCU protect tasks on the runqueue

2019-09-03 Thread Linus Torvalds
On Tue, Sep 3, 2019 at 11:13 AM Eric W. Biederman wrote: > > I think this is where I am looking a things differently than you and > Peter. Why does it have to be ___schedule() that changes the value > in the task_struct? Why can't it be something else that changes the > value and then proceeds

Re: [PATCH v5 1/2] mm: Allow the page cache to allocate large pages

2019-09-03 Thread Michal Hocko
On Tue 03-09-19 09:28:31, Matthew Wilcox wrote: > On Tue, Sep 03, 2019 at 02:19:52PM +0200, Michal Hocko wrote: > > On Tue 03-09-19 05:11:55, Matthew Wilcox wrote: > > > On Tue, Sep 03, 2019 at 01:57:48PM +0200, Michal Hocko wrote: > > > > On Mon 02-09-19 03:23:40, William Kucharski wrote: > > > >

[PATCH] fs-udf: Delete an unnecessary check before brelse()

2019-09-03 Thread Markus Elfring
From: Markus Elfring Date: Tue, 3 Sep 2019 21:12:09 +0200 The brelse() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [PATCH v5 2/2] mm,thp: Add experimental config option RO_EXEC_FILEMAP_HUGE_FAULT_THP

2019-09-03 Thread Michal Hocko
On Tue 03-09-19 08:10:15, Matthew Wilcox wrote: > On Tue, Sep 03, 2019 at 02:51:50PM +0200, Michal Hocko wrote: > > On Tue 03-09-19 05:22:08, Matthew Wilcox wrote: > > > On Tue, Sep 03, 2019 at 02:14:24PM +0200, Michal Hocko wrote: > > > > On Mon 02-09-19 03:23:41, William Kucharski wrote: > > > >

Re: [PATCH v4] tpm: Parse event log from TPM2 ACPI table

2019-09-03 Thread Jordan Hand
On 9/3/19 11:27 AM, Jerry Snitselaar wrote: >> +    len = tpm2_trailer.minimum_log_length; >> +    start = tpm2_trailer.log_address; > > Are your builds not failing here? Both v3 and v4 have this. > Ya, I saw the kbuild bot failure and fixed in v5. I'm not entirely sure why I didn't

[PATCH] rt-tests: backfire: Don't include asm/uaccess.h directly

2019-09-03 Thread Sultan Alsawaf
From: Sultan Alsawaf Architecture-specific uaccess.h headers can have dependencies on linux/uaccess.h (i.e., VERIFY_WRITE), so it cannot be included directly. Since linux/uaccess.h includes asm/uaccess.h, just do that instead. This fixes compile errors with certain kernels and architectures.

Re: Regression in 5.1.20: Reading long directory fails

2019-09-03 Thread Chuck Lever
On Sep 3, 2019, at 3:06 PM, Jason L Tibbitts III wrote: >> "WW" == Wolfgang Walter writes: > > WW> What filesystem do you use on the server? xfs? > > Yeah, it's XFS. > > WW> If yes, does it use 64bit inodes (or started to use them)? > > These filesystems aren't super old, and were all

Re: [RFC PATCH] mm, oom: disable dump_tasks by default

2019-09-03 Thread Michal Hocko
On Tue 03-09-19 11:32:58, Qian Cai wrote: > On Tue, 2019-09-03 at 17:13 +0200, Michal Hocko wrote: > > On Tue 03-09-19 11:02:46, Qian Cai wrote: > > > On Tue, 2019-09-03 at 16:45 +0200, Michal Hocko wrote: > > > > From: Michal Hocko > > > > > > > > dump_tasks has been introduced by quite some

Re: [PATCH v2 1/3] dt-bindings: iio/adc: Add a compatible string for JZ4770 SoC ADC

2019-09-03 Thread Artur Rojek
Hi Jonathan, Just reminding you of this patch set. Artur On 2019-07-28 10:45, Jonathan Cameron wrote: On Sat, 27 Jul 2019 21:59:38 +0200 Artur Rojek wrote: Add a compatible string for the ADC controller present on Ingenic JZ4770 SoC. Signed-off-by: Artur Rojek Reviewed-by: Rob Herring

Re: [PATCHv1 0/3] Odroid c2 missing regulator linking

2019-09-03 Thread Martin Blumenstingl
Hi Anand, On Fri, Aug 30, 2019 at 11:34 AM Anand Moon wrote: [...] > > SCPI works fine on all tested devices, except Odroid-C2, because Hardkernel > > left > > the > 1.5GHz freq in the initial SCPI tables loaded by the BL2, i.e. packed > > with U-Boot. > > Nowadays they have removed the bad

Re: Regression in 5.1.20: Reading long directory fails

2019-09-03 Thread Jason L Tibbitts III
> "WW" == Wolfgang Walter writes: WW> What filesystem do you use on the server? xfs? Yeah, it's XFS. WW> If yes, does it use 64bit inodes (or started to use them)? These filesystems aren't super old, and were all created with the default RHEL7 options. I'm not sure how to check that 64

kernel BUG at ./include/linux/highmem.h:LINE!

2019-09-03 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:6525771f Merge tag 'arc-5.3-rc7' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1758843260 kernel config: https://syzkaller.appspot.com/x/.config?x=58485246ad14eafe

INFO: trying to register non-static key in hci_uart_flush (2)

2019-09-03 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:6d028043 Add linux-next specific files for 20190830 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=141d6cae60 kernel config: https://syzkaller.appspot.com/x/.config?x=82a6bec43ab0cb69

BUG: using smp_processor_id() in preemptible [ADDR] code: mime_typevmnet0/NUM

2019-09-03 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:eea17309 Merge branch 'i2c/for-current' of git://git.kerne.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10b0622a60 kernel config: https://syzkaller.appspot.com/x/.config?x=5cbaa3be0b36022f

Re: KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device

2019-09-03 Thread Alan Stern
On Tue, 3 Sep 2019, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:eea39f24 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.txt?x=174761b660

Re: [PATCHv2-next 1/3] arm64: dts: meson: odroid-c2: Add missing regulator linked to P5V0 regulator

2019-09-03 Thread Martin Blumenstingl
Hi Anand, On Mon, Sep 2, 2019 at 10:58 AM Anand Moon wrote: > > As per schematics VDDIO_AO18, VDDIO_AO3V3/VDD3V3 DDR3_1V5/DDR_VDDC: > fixed regulator output which is supplied by P5V0. > > Cc: Martin Blumenstingl > Cc: Jerome Brunet > Cc: Neil Armstrong > Signed-off-by: Anand Moon one comment

Re: [PATCH 8/8] x86/platform/uv: Account for UV Hubless in is_uvX_hub Ops

2019-09-03 Thread Mike Travis
On 9/3/2019 11:58 AM, Mike Travis wrote: On 9/3/2019 9:19 AM, Christoph Hellwig wrote: On Mon, Sep 02, 2019 at 07:18:23PM -0500, Mike Travis wrote: +#ifdef    UV1_HUB_IS_SUPPORTED All these ifdefs are dead code, please just remove them. Those ifdefs are not dead code and are being

Re: [PATCHv2-next 3/3] arm64: dts: meson: odroid-c2: Add missing regulator linked to HDMI supply

2019-09-03 Thread Martin Blumenstingl
On Mon, Sep 2, 2019 at 10:58 AM Anand Moon wrote: > > As per schematics HDMI_P5V0 is supplied by P5V0 so add missing link. > > Cc: Martin Blumenstingl > Cc: Jerome Brunet > Cc: Neil Armstrong > Signed-off-by: Anand Moon Reviewed-by: Martin Blumenstingl

Re: [PATCH v3 4/4] edac: Add support for Amazon's Annapurna Labs L2 EDAC

2019-09-03 Thread Robert Richter
On 03.09.19 10:58:16, Borislav Petkov wrote: > On Tue, Sep 03, 2019 at 08:46:24AM +, Robert Richter wrote: > > This is good, but recent practice is also to have all the drivers for > > the same piece of hardware in a single file, see e.g. thunderx_edac.c. > > I don't know how detailed this was

Re: [PATCH 8/8] x86/platform/uv: Account for UV Hubless in is_uvX_hub Ops

2019-09-03 Thread Mike Travis
On 9/3/2019 9:19 AM, Christoph Hellwig wrote: On Mon, Sep 02, 2019 at 07:18:23PM -0500, Mike Travis wrote: +#ifdef UV1_HUB_IS_SUPPORTED All these ifdefs are dead code, please just remove them. Those ifdefs are not dead code and are being actively used. Plus UV1 support is dead and I

Re: [PATCHv4-next 2/3] arm64: dts: meson: odroid-c2: Add missing linking regulator to usb bus

2019-09-03 Thread Martin Blumenstingl
On Mon, Sep 2, 2019 at 7:50 AM Anand Moon wrote: > > Add missing linking regulator node to usb bus for power usb devices. > > Cc: Martin Blumenstingl > Cc: Jerome Brunet > Cc: Neil Armstrong > Acked-by: Martin Blumenstingl > Signed-off-by: Anand Moon > --- > Re-base on linux-next > Added Ack

Re: Problem when function alarmtimer_suspend returns 0 if time delta is zero

2019-09-03 Thread Michael
Thomas, thank you very much for your patch. Unfortunately currently I can only test it with a kernel 4.1.52 but i've tried to patch your new logic into my older kernel version. There seem to be rare cases where the "delta" value becomes negative. Therefore I added if(unlikely(delta < 0)) {

[PATCH] staging: exfat: drop local TRUE/FALSE defines

2019-09-03 Thread Valentin Vidic
Replace with bool where it makes sense. Also drop unused local variable lossy in fat_find_dir_entry. Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat.h | 3 -- drivers/staging/exfat/exfat_core.c | 81 +++-- drivers/staging/exfat/exfat_nls.c | 2 +-

[PATCH] fs/sysv: Delete unnecessary checks before brelse()

2019-09-03 Thread Markus Elfring
From: Markus Elfring Date: Tue, 3 Sep 2019 20:52:07 +0200 The brelse() function tests whether its argument is NULL and then returns immediately. Thus the tests around the shown calls are not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [PATCH v4 02/16] powerpc/pseries: Introduce option to build secure virtual machines

2019-09-03 Thread Thiago Jung Bauermann
Michael Ellerman writes: > On Tue, 2019-08-20 at 02:13:12 UTC, Thiago Jung Bauermann wrote: >> Introduce CONFIG_PPC_SVM to control support for secure guests and include >> Ultravisor-related helpers when it is selected >> >> Signed-off-by: Thiago Jung Bauermann > > Patch 2-14 & 16 applied to

Re: [PATCH v1 1/2] clk: intel: Add CGU clock driver for a new SoC

2019-09-03 Thread Martin Blumenstingl
Hi Rahul, On Tue, Sep 3, 2019 at 11:54 AM Tanwar, Rahul wrote: > > > Hi Martin, > > On 3/9/2019 6:20 AM, Martin Blumenstingl wrote: > > Hello, > > > > I only noticed this patchset today and I don't have much time left. > > Here's my initial impressions without going through the code in detail. >

Re: [PATCH] net/skbuff: silence warnings under memory pressure

2019-09-03 Thread Michal Hocko
On Tue 03-09-19 11:42:22, Qian Cai wrote: > On Tue, 2019-09-03 at 15:22 +0200, Michal Hocko wrote: > > On Fri 30-08-19 18:15:22, Eric Dumazet wrote: > > > If there is a risk of flooding the syslog, we should fix this generically > > > in mm layer, not adding hundred of __GFP_NOWARN all over the

[PATCH v5] tpm: Parse event log from TPM2 ACPI table

2019-09-03 Thread Jordan Hand
For systems with a TPM2 chip which use ACPI to expose event logs, retrieve the crypto-agile event log from the TPM2 ACPI table. The TPM2 table is defined in section 7.3 of the TCG ACPI Specification (see link). The TPM2 table is used by SeaBIOS in place of the TCPA table when the system's TPM is

Re: [PATCH 2/2] tpm: tpm_crb: enhance resource mapping mechanism for supporting AMD's fTPM

2019-09-03 Thread Seunghun Han
> > On Tue, 2019-09-03 at 18:56 +0900, Seunghun Han wrote: > > Thank you for your notification. I am sorry. I missed it and > > misunderstood Jarkko's idea. So, I would like to invite Matthew > > Garrett to this thread and attach my opinion on that. The problem is > > that command and response

Re: [PATCH v2 1/2] leds: lm3532: Move static keyword to the front of declarations

2019-09-03 Thread Jacek Anaszewski
Hi Krzysztof, Thank you for the patch set. On 8/30/19 8:11 PM, Krzysztof Wilczynski wrote: > Move the static keyword to the front of declarations ramp_table, > als_avrg_table and als_imp_table, and resolve the following > compiler warnings that can be seen when building with warnings > enabled

Re: [PATCH 2/8] x86/platform/uv: Return UV Hubless System Type

2019-09-03 Thread Mike Travis
On 9/3/2019 8:41 AM, Christoph Hellwig wrote: On Tue, Sep 03, 2019 at 07:12:28AM -0700, Mike Travis wrote: +#define is_uv_hubless _is_uv_hubless Why the weird macro indirection? -static inline int is_uv_hubless(void) { return 0; } +static inline int _is_uv_hubless(int uv) { return 0; }

Re: [PATCH v2] ARM: Emit __gnu_mcount_nc when using Clang 10.0.0 or newer

2019-09-03 Thread Matthias Kaehlcke
On Fri, Aug 30, 2019 at 11:05:31PM -0700, Nathan Chancellor wrote: > Currently, multi_v7_defconfig + CONFIG_FUNCTION_TRACER fails to build > with clang: > > arm-linux-gnueabi-ld: kernel/softirq.o: in function `_local_bh_enable': > softirq.c:(.text+0x504): undefined reference to `mcount' >

Re: [PATCH 08/15] riscv: provide native clint access for M-mode

2019-09-03 Thread Palmer Dabbelt
On Tue, 27 Aug 2019 23:11:46 PDT (-0700), Christoph Hellwig wrote: On Tue, Aug 27, 2019 at 04:37:16PM -0700, Palmer Dabbelt wrote: clint0 would be version 0 of the clint, with is the core-local interrupt controller in rocket chip. It should be "sifive,clint-1.0.0", not "riscv,clint0", as it's

[PATCH] net: fixed_phy: Add forward declaration for struct gpio_desc;

2019-09-03 Thread Moritz Fischer
Add forward declaration for struct gpio_desc in order to address the following: ./include/linux/phy_fixed.h:48:17: error: 'struct gpio_desc' declared inside parameter list [-Werror] ./include/linux/phy_fixed.h:48:17: error: its scope is only this definition or declaration, which is probably not

[PATCH] reiserfs: Delete an unnecessary check before brelse()

2019-09-03 Thread Markus Elfring
From: Markus Elfring Date: Tue, 3 Sep 2019 20:00:16 +0200 The brelse() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [PATCH v2 3/3] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-03 Thread Martin Blumenstingl
Hi Dilip, On Tue, Sep 3, 2019 at 12:20 PM Dilip Kota wrote: > > Hi Martin, > > On 8/29/2019 10:54 AM, Chuan Hua, Lei wrote: > > > On 8/29/2019 3:36 AM, Martin Blumenstingl wrote: > > On Wed, Aug 28, 2019 at 5:35 AM Chuan Hua, Lei > wrote: > [...] > > +static int intel_pcie_ep_rst_init(struct

Re: [PATCH v2] HID: apple: Fix stuck function keys when using FN

2019-09-03 Thread João Moreno
Hi Benjamin, On Tue, 3 Sep 2019 at 16:46, Benjamin Tissoires wrote: > > From: Joao Moreno > > This fixes an issue in which key down events for function keys would be > repeatedly emitted even after the user has raised the physical key. For > example, the driver fails to emit the F5 key up event

Re: [BACKPORT 4.14.y 4/8] net: sctp: fix warning "NULL check before some freeing functions is not needed"

2019-09-03 Thread Greg KH
On Tue, Sep 03, 2019 at 11:52:06AM -0300, Marcelo Ricardo Leitner wrote: > On Tue, Sep 03, 2019 at 02:58:16PM +0800, Baolin Wang wrote: > > From: Hariprasad Kelam > > > > This patch removes NULL checks before calling kfree. > > > > fixes below issues reported by coccicheck > >

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-03 Thread Greg KH
On Tue, Sep 03, 2019 at 08:18:36PM +0200, Jacek Anaszewski wrote: > On 9/3/19 4:21 PM, Akinobu Mita wrote: > > 2019年9月3日(火) 23:07 Greg KH : > >> > >> On Tue, Sep 03, 2019 at 10:55:40PM +0900, Akinobu Mita wrote: > >>> 2019年9月3日(火) 4:08 Greg KH : > > On Mon, Sep 02, 2019 at 08:47:02PM

Re: [PATCH v2 3/6] powerpc: Convert flush_icache_range & friends to C

2019-09-03 Thread Segher Boessenkool
On Tue, Sep 03, 2019 at 07:05:19PM +0200, Christophe Leroy wrote: > Le 03/09/2019 à 18:04, Segher Boessenkool a écrit : > >(Why are they separate though? It could just be one loop var). > > Yes it could just be a single loop var, but in that case it would have > to be reset at the start of the

Re: [PATCH v4] tpm: Parse event log from TPM2 ACPI table

2019-09-03 Thread Jerry Snitselaar
On Fri Aug 30 19, Jordan Hand wrote: For systems with a TPM2 chip which use ACPI to expose event logs, retrieve the crypto-agile event log from the TPM2 ACPI table. The TPM2 table is defined in section 7.3 of the TCG ACPI Specification (see link). The TPM2 table is used by SeaBIOS in place of

Re: [PATCH] staging: exfat: cleanup braces for if/else statements

2019-09-03 Thread Greg Kroah-Hartman
On Tue, Sep 03, 2019 at 06:32:49PM +0100, Al Viro wrote: > On Tue, Sep 03, 2019 at 06:47:32PM +0200, Valentin Vidic wrote: > > + } else if (uni == 0x) { > > skip = TRUE; > > While we are at it, could you get rid of that 'TRUE' macro? > Or added >

Re: [PATCH] sched: make struct task_struct::state 32-bit

2019-09-03 Thread Alexey Dobriyan
On Tue, Sep 03, 2019 at 06:29:06PM +0100, Valentin Schneider wrote: > On 02/09/2019 22:05, Alexey Dobriyan wrote: > > 32-bit accesses are shorter than 64-bit accesses on x86_64. > > Nothing uses 64-bitness of ->state. > It looks like you missed a few places. There's a long prev_state in >

<    1   2   3   4   5   6   7   8   9   10   >