Re: [RFC PATCH 1/2] Fix: sched/membarrier: p->mm->membarrier_state racy load

2019-09-03 Thread Linus Torvalds
On Tue, Sep 3, 2019 at 1:11 PM Mathieu Desnoyers wrote: > > + cpus_read_lock(); > + for_each_online_cpu(cpu) { This would likely be better off using mm_cpumask(mm) instead of all online CPU's. Plus doing the rcu_read_lock() inside the loop seems pointless. Even with a lot of cores,

Re: [PATCH 09/15] sched,fair: refactor enqueue/dequeue_entity

2019-09-03 Thread Rik van Riel
On Tue, 2019-09-03 at 17:38 +0200, Vincent Guittot wrote: > Hi Rik, > > On Thu, 22 Aug 2019 at 04:18, Rik van Riel wrote: > > Refactor enqueue_entity, dequeue_entity, and update_load_avg, in > > order > > to split out the things we still want to happen at every level in > > the > > cgroup

Re: [PATCH] drm/virtio: Use vmalloc for command buffer allocations.

2019-09-03 Thread David Riley
On Sun, Sep 1, 2019 at 10:28 PM Gerd Hoffmann wrote: > > On Fri, Aug 30, 2019 at 10:49:25AM -0700, David Riley wrote: > > Hi Gerd, > > > > On Fri, Aug 30, 2019 at 4:16 AM Gerd Hoffmann wrote: > > > > > > Hi, > > > > > > > > > - kfree(vbuf->data_buf); > > > > > > +

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-03 Thread Pavel Machek
Hi! > > Also, you all didn't document the heck out of this. So no, I really do > > not want to see this patch accepted as-is. > > > > > Provided that will be fixed, can we count on your ack for the > > > implementation of the solution you proposed? :-) > > > > Let's see the patch that actually

[PATCH v2 26/26] NFS: Attach supplementary error information to fs_context.

2019-09-03 Thread Scott Mayhew
Split out from commit "NFS: Add fs_context support." Add wrappers nfs_errorf(), nfs_invalf(), and nfs_warnf() which log error information to the fs_context. Convert some printk's to use these new wrappers instead. Signed-off-by: Scott Mayhew --- fs/nfs/fs_context.c | 105

[PATCH v2 13/26] nfs: get rid of mount_info ->fill_super()

2019-09-03 Thread Scott Mayhew
From: Al Viro The only possible values are nfs_fill_super and nfs_clone_super. The latter is used only when crossing into a submount and it is almost identical to the former; the only differences are * ->s_time_gran unconditionally set to 1 (even for v2 mounts). Regression dating back

[PATCH v2 01/26] saner calling conventions for nfs_fs_mount_common()

2019-09-03 Thread Scott Mayhew
From: Al Viro Allow it to take ERR_PTR() for server and return ERR_CAST() of it in such case. All callers used to open-code that... Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/nfs4super.c | 16 +--- fs/nfs/super.c | 11 --- 2 files changed, 5

[PATCH v2 19/26] NFS: Split nfs_parse_mount_options()

2019-09-03 Thread Scott Mayhew
From: David Howells Split nfs_parse_mount_options() to move the prologue, list-splitting and epilogue into one function and the per-option processing into another. Signed-off-by: David Howells Signed-off-by: Al Viro --- fs/nfs/fs_context.c | 126

[PATCH v2 25/26] NFS: Add fs_context support.

2019-09-03 Thread Scott Mayhew
From: David Howells Add filesystem context support to NFS, parsing the options in advance and attaching the information to struct nfs_fs_context. The highlights are: (*) Merge nfs_mount_info and nfs_clone_mount into nfs_fs_context. This structure represents NFS's superblock config.

[PATCH v2 11/26] nfs: unexport nfs_fs_mount_common()

2019-09-03 Thread Scott Mayhew
From: Al Viro Make it static, even. And remove a stale extern of (long-gone) nfs_xdev_mount_common() from internal.h, while we are at it. Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/internal.h | 3 --- fs/nfs/super.c| 5 +++-- 2 files changed, 3 insertions(+), 5

[PATCH v2 21/26] NFS: Add a small buffer in nfs_fs_context to avoid string dup

2019-09-03 Thread Scott Mayhew
From: David Howells Add a small buffer in nfs_fs_context to avoid string duplication when parsing numbers. Also make the parsing function wrapper place the parsed integer directly in the appropriate nfs_fs_context struct member. Signed-off-by: David Howells Signed-off-by: Al Viro ---

[PATCH v2 24/26] NFS: Convert mount option parsing to use functionality from fs_parser.h

2019-09-03 Thread Scott Mayhew
Split out from commit "NFS: Add fs_context support." Convert existing mount option definitions to fs_parameter_enum's and fs_parameter_spec's. Parse mount options using fs_parse() and lookup_constant(). Notes: 1) Fixed a typo in the udp6 definition in nfs_xprt_protocol_tokens from the original

[PATCH v2 18/26] NFS: Rename struct nfs_parsed_mount_data to struct nfs_fs_context

2019-09-03 Thread Scott Mayhew
From: David Howells Rename struct nfs_parsed_mount_data to struct nfs_fs_context and rename pointers to it to "ctx". At some point this will be pointed to by an fs_context struct's fs_private pointer. Signed-off-by: David Howells Signed-off-by: Al Viro --- fs/nfs/client.c | 66 +++

[PATCH v2 14/26] nfs_clone_sb_security(): simplify the check for server bogosity

2019-09-03 Thread Scott Mayhew
From: Al Viro We used to check ->i_op for being nfs_dir_inode_operations. With separate inode_operations for v3 and v4 that became bogus, but rather than going for protocol-dependent comparison we could've just checked ->i_fop instead; _that_ is the same for all protocol versions. Reviewed-by:

[PATCH v2 00/26] nfs: Mount API conversion

2019-09-03 Thread Scott Mayhew
Hi Trond, Anna, Here's a set of patches that converts NFS to use the mount API. Note that there are a lot of preliminary patches, some from David and some from Al. The final patch (the one that does the actual conversion) from the David's initial posting has been split into 4 separate patches,

[PATCH v2 04/26] nfs: fold nfs4_remote_fs_type and nfs4_remote_referral_fs_type

2019-09-03 Thread Scott Mayhew
From: Al Viro They are identical now. Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/nfs4super.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c index 773c347df3ab..d0237d8ffa2b 100644 ---

[PATCH v2 23/26] NFS: rename nfs_fs_context pointer arg in a few functions

2019-09-03 Thread Scott Mayhew
Split out from commit "NFS: Add fs_context support." Rename cfg to ctx in nfs_init_server(), nfs_verify_authflavors(), and nfs_request_mount(). No functional changes. Signed-off-by: Scott Mayhew --- fs/nfs/client.c | 62 - fs/nfs/super.c | 54

[PATCH v2 20/26] NFS: Deindent nfs_fs_context_parse_option()

2019-09-03 Thread Scott Mayhew
From: David Howells Deindent nfs_fs_context_parse_option(). Signed-off-by: David Howells Signed-off-by: Al Viro --- fs/nfs/fs_context.c | 739 ++-- 1 file changed, 367 insertions(+), 372 deletions(-) diff --git a/fs/nfs/fs_context.c

[PATCH v2 16/26] NFS: Move mount parameterisation bits into their own file

2019-09-03 Thread Scott Mayhew
From: David Howells Split various bits relating to mount parameterisation out from fs/nfs/super.c into their own file to form the basis of filesystem context handling for NFS. No other changes are made to the code beyond removing 'static' qualifiers. Signed-off-by: David Howells

[PATCH v2 07/26] nfs: lift setting mount_info from nfs_xdev_mount()

2019-09-03 Thread Scott Mayhew
From: Al Viro Do it in nfs_do_submount() instead. As a side benefit, nfs_clone_data doesn't need ->fh and ->fattr anymore. Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/internal.h | 3 +-- fs/nfs/namespace.c | 35 +-- fs/nfs/super.c | 25

[PATCH v2 15/26] nfs: get rid of ->set_security()

2019-09-03 Thread Scott Mayhew
From: Al Viro it's always either nfs_set_sb_security() or nfs_clone_sb_security(), the choice being controlled by mount_info->cloned != NULL. No need to add methods, especially when both instances live right next to the caller and are never accessed anywhere else. Reviewed-by: David Howells

[PATCH v2 17/26] NFS: Constify mount argument match tables

2019-09-03 Thread Scott Mayhew
From: David Howells The mount argument match tables should never be altered so constify them. Signed-off-by: David Howells Signed-off-by: Al Viro --- fs/nfs/fs_context.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/nfs/fs_context.c b/fs/nfs/fs_context.c index

[PATCH v2 08/26] nfs: stash nfs_subversion reference into nfs_mount_info

2019-09-03 Thread Scott Mayhew
From: Al Viro That will allow to get rid of passing those references around in quite a few places. Moreover, that will allow to merge xdev and remote file_system_type. Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/internal.h | 1 + fs/nfs/namespace.c | 6 +++---

[PATCH v2 03/26] nfs: lift setting mount_info from nfs4_remote{,_referral}_mount

2019-09-03 Thread Scott Mayhew
From: Al Viro Do that (fhandle allocation, setting struct server up) in nfs4_referral_mount() and nfs4_try_mount() resp. and pass the server and pointer to mount_info into nfs_do_root_mount() so that nfs4_remote_referral_mount()/nfs_remote_mount() could be merged. Since we are moving stuff from

[PATCH v2 02/26] nfs: stash server into struct nfs_mount_info

2019-09-03 Thread Scott Mayhew
From: Al Viro Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/internal.h | 3 ++- fs/nfs/nfs4super.c | 10 -- fs/nfs/super.c | 19 --- 3 files changed, 14 insertions(+), 18 deletions(-) diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h index

[PATCH v2 06/26] nfs4: fold nfs_do_root_mount/nfs_follow_remote_path

2019-09-03 Thread Scott Mayhew
From: Al Viro Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/nfs4super.c | 88 +++--- 1 file changed, 37 insertions(+), 51 deletions(-) diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c index a0b66f98f6ba..91ba1b6741dc 100644 ---

[PATCH v2 12/26] nfs: don't pass nfs_subversion to ->create_server()

2019-09-03 Thread Scott Mayhew
From: Al Viro pick it from mount_info Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/client.c | 4 ++-- fs/nfs/internal.h | 7 ++- fs/nfs/nfs3_fs.h| 2 +- fs/nfs/nfs3client.c | 5 ++--- fs/nfs/nfs4client.c | 3 +-- fs/nfs/nfs4super.c

Re: [PATCH] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-03 Thread Jonas Karlman
On 2019-09-03 20:08, Jernej Škrabec wrote: > Hi! > > Dne torek, 03. september 2019 ob 20:00:33 CEST je Neil Armstrong napisal(a): >> Hi, >> >> Le 03/09/2019 à 11:53, Neil Armstrong a écrit : >>> Hi, >>> >>> On 03/09/2019 07:51, Cheng-Yi Chiang wrote: From: Yakir Yang When

[PATCH v2 09/26] nfs: don't bother passing nfs_subversion to ->try_mount() and nfs_fs_mount_common()

2019-09-03 Thread Scott Mayhew
From: Al Viro Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/internal.h | 6 ++ fs/nfs/nfs4_fs.h| 2 +- fs/nfs/nfs4super.c | 5 ++--- fs/nfs/super.c | 19 --- include/linux/nfs_xdr.h | 3 +-- 5 files changed, 14 insertions(+),

[PATCH v2 10/26] nfs: merge xdev and remote file_system_type

2019-09-03 Thread Scott Mayhew
From: Al Viro they are identical now... Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/internal.h | 2 +- fs/nfs/namespace.c | 2 +- fs/nfs/nfs4super.c | 22 +- fs/nfs/super.c | 14 -- 4 files changed, 11 insertions(+), 29 deletions(-)

[PATCH v2 22/26] NFS: Do some tidying of the parsing code

2019-09-03 Thread Scott Mayhew
From: David Howells Do some tidying of the parsing code, including: (*) Returning 0/error rather than true/false. (*) Putting the nfs_fs_context pointer first in some arg lists. (*) Unwrap some lines that will now fit on one line. (*) Provide unioned sockaddr/sockaddr_storage fields to

[PATCH v2 05/26] nfs: don't bother setting/restoring export_path around do_nfs_root_mount()

2019-09-03 Thread Scott Mayhew
From: Al Viro nothing in it will be looking at that thing anyway Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/nfs4super.c | 4 1 file changed, 4 deletions(-) diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c index d0237d8ffa2b..a0b66f98f6ba 100644 ---

Re: [RFC PATCH 1/2] Fix: sched/membarrier: p->mm->membarrier_state racy load

2019-09-03 Thread Linus Torvalds
On Tue, Sep 3, 2019 at 1:25 PM Peter Zijlstra wrote: > > Why can't we frob this state into a line/word we already have to > unconditionally touch, like the thread_info::flags word for example. I agree, but we don't have any easily used flags left, I think. But yes, it would be better to not

Re: [PATCH 07/10] drm/msm: split power control from prepare/complete_commit

2019-09-03 Thread Sean Paul
On Thu, Aug 29, 2019 at 09:45:15AM -0700, Rob Clark wrote: > From: Rob Clark > > With atomic commit, ->prepare_commit() and ->complete_commit() may not > be evenly balanced (although ->complete_commit() will complete each > crtc that had been previously prepared). So these will no longer be > a

Re: [RFC PATCH 1/2] Fix: sched/membarrier: p->mm->membarrier_state racy load

2019-09-03 Thread Mathieu Desnoyers
- On Sep 3, 2019, at 4:24 PM, Peter Zijlstra pet...@infradead.org wrote: > On Tue, Sep 03, 2019 at 04:11:34PM -0400, Mathieu Desnoyers wrote: > >> diff --git a/include/linux/sched.h b/include/linux/sched.h >> index 9f51932bd543..e24d52a4c37a 100644 >> --- a/include/linux/sched.h >> +++

Re: [RFC PATCH] mm, oom: disable dump_tasks by default

2019-09-03 Thread Tetsuo Handa
On 2019/09/03 23:45, Michal Hocko wrote: > It's primary purpose is > to help analyse oom victim selection decision. I disagree, for I use the process list for understanding what / how many processes are consuming what kind of memory (without crashing the system) for anomaly detection purpose.

Re: [PATCH 09/10] drm/msm/dpu: async commit support

2019-09-03 Thread Sean Paul
On Thu, Aug 29, 2019 at 09:45:17AM -0700, Rob Clark wrote: > From: Rob Clark > > In addition, moving to kms->flush_commit() lets us drop the only user > of kms->commit(). > > Signed-off-by: Rob Clark Reviewed-by: Sean Paul > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 13 -- >

Re: [PATCH v2 2/2] mm, sl[aou]b: guarantee natural alignment for kmalloc(power-of-two)

2019-09-03 Thread Matthew Wilcox
On Tue, Sep 03, 2019 at 08:13:45PM +, Christopher Lameter wrote: > On Sat, 31 Aug 2019, Matthew Wilcox wrote: > > > > The current behavior without special alignment for these caches has been > > > in the wild for over a decade. And this is now coming up? > > > > In the wild ... and rarely

Re: [RFC PATCH 1/2] Fix: sched/membarrier: p->mm->membarrier_state racy load

2019-09-03 Thread Mathieu Desnoyers
- On Sep 3, 2019, at 4:27 PM, Linus Torvalds torva...@linux-foundation.org wrote: > On Tue, Sep 3, 2019 at 1:11 PM Mathieu Desnoyers > wrote: >> >> + cpus_read_lock(); >> + for_each_online_cpu(cpu) { > > This would likely be better off using mm_cpumask(mm) instead of all >

Re: [PATCH] Smack: Move request_buffer from stack to smack_audit_data

2019-09-03 Thread Casey Schaufler
On 9/3/2019 11:01 AM, Denis Efremov wrote: > request_buffer is required to describe an access type in a string for > the audit. The problem here is that the string is saved on the stack > and then passed by reference to the next function in request field of > the smack_audit_data structure.

Re: KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device

2019-09-03 Thread Alan Stern
On Tue, 3 Sep 2019, syzbot wrote: > Hello, > > syzbot has tested the proposed patch but the reproducer still triggered > crash: > KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device > > usb 4-1: Using ep0 maxpacket: 16 > usb 4-1: Old BOS 8881d516b780 Len 0xa8 > usb 4-1: New BOS

Re: [PATCH v2 3/8] mips: compat: vdso: Use legacy syscalls as fallback

2019-09-03 Thread Paul Burton
Hello, Vincenzo Frascino wrote: > The generic VDSO implementation uses the Y2038 safe clock_gettime64() and > clock_getres_time64() syscalls as fallback for 32bit VDSO. This breaks > seccomp setups because these syscalls might be not (yet) allowed. > > Implement the 32bit variants which use the

[PATCH v2] staging: exfat: cleanup explicit comparisons to NULL

2019-09-03 Thread Valentin Vidic
Fixes checkpatch.pl warnings: CHECK: Comparison to NULL could be written "expr" CHECK: Comparison to NULL could be written "!expr" Signed-off-by: Valentin Vidic --- v2: fix gcc warning in strsep call drivers/staging/exfat/exfat_core.c | 34 -

Re: [PATCH v2 1/3] fuse: on 64-bit store time in d_fsdata directly

2019-09-03 Thread Khazhismel Kumykov
On Thu, Aug 22, 2019 at 1:00 PM Khazhismel Kumykov wrote: > > Implements the optimization noted in f75fdf22b0a8 ("fuse: don't use > ->d_time"), as the additional memory can be significant. (In particular, > on SLAB configurations this 8-byte alloc becomes 32 bytes). Per-dentry, > this can consume

Re: KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device

2019-09-03 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device usb 6-1: Using ep0 maxpacket: 16 usb 6-1: BOS total length 54, descriptor 168 usb 6-1: Old BOS 8881cd814f60 Len 0xa8 usb 6-1: New BOS

Re: "beyond 2038" warnings from loopback mount is noisy

2019-09-03 Thread Qian Cai
On Tue, 2019-09-03 at 21:50 +0200, Arnd Bergmann wrote: > On Tue, Sep 3, 2019 at 9:39 PM Andreas Dilger wrote: > > > > On Sep 3, 2019, at 12:15 PM, Qian Cai wrote: > > > > > > On Tue, 2019-09-03 at 09:36 -0700, Deepa Dinamani wrote: > > > > We might also want to consider updating the file

Re: [PATCH RESEND] fs/epoll: fix the edge-triggered mode for nested epoll

2019-09-03 Thread Jason Baron
On 9/2/19 11:36 AM, Roman Penyaev wrote: > Hi, > > This is indeed a bug. (quick side note: could you please remove efd[1] > from your test, because it is not related to the reproduction of a > current bug). > > Your patch lacks a good description, what exactly you've fixed.  Let > me speak

Re: "beyond 2038" warnings from loopback mount is noisy

2019-09-03 Thread Theodore Y. Ts'o
On Tue, Sep 03, 2019 at 09:18:44AM -0700, Deepa Dinamani wrote: > > This prints a warning for each inode that doesn't extend limits beyond > 2038. It is rate limited by the ext4_warning_inode(). > Looks like your filesystem has inodes that cannot be extended. > We could use a different rate limit

Re: [PATCH] mailmap: Update email address for Quentin Perret

2019-09-03 Thread Joe Perches
On Tue, 2019-09-03 at 15:59 +0100, Will Deacon wrote: > What's the best way > for get_maintainer.pl to retrieve up-to-date contact details for developers > who aren't in MAINTAINERS? Updated .mailmap entries.

Re: [PATCH] net: sched: taprio: Fix potential integer overflow in taprio_set_picos_per_byte

2019-09-03 Thread Vinicius Costa Gomes
Hi, Vladimir Oltean writes: > Right. And while we're at it, there's still the potential > division-by-zero problem which I still don't know how to solve without > implementing a full-blown __ethtool_get_link_ksettings parser that > checks against all the possible outputs it can have under the

Re: [PATCH v2] mm/hugetlb: avoid looping to the same hugepage if !pages and !vmas

2019-09-03 Thread Mike Kravetz
On 8/29/19 6:50 AM, Zhigang Lu wrote: > From: Zhigang Lu > > When mmapping an existing hugetlbfs file with MAP_POPULATE, we find > it is very time consuming. For example, mmapping a 128GB file takes > about 50 milliseconds. Sampling with perfevent shows it spends 99% > time in the same_page loop

Re: "fs/namei.c: keep track of nd->root refcount status" causes boot panic

2019-09-03 Thread Theodore Y. Ts'o
On Tue, Sep 03, 2019 at 06:50:24AM -0700, Christoph Hellwig wrote: > On Tue, Sep 03, 2019 at 02:48:32PM +0100, Al Viro wrote: > > Not sure what would be the best way to do it... I don't mind breaking > > the out-of-tree modules, whatever their license is; what I would rather > > avoid is _quiet_

Re: "beyond 2038" warnings from loopback mount is noisy

2019-09-03 Thread Deepa Dinamani
On Tue, Sep 3, 2019 at 2:18 PM Theodore Y. Ts'o wrote: > > On Tue, Sep 03, 2019 at 09:18:44AM -0700, Deepa Dinamani wrote: > > > > This prints a warning for each inode that doesn't extend limits beyond > > 2038. It is rate limited by the ext4_warning_inode(). > > Looks like your filesystem has

Re: [PATCH 2/3] task: RCU protect tasks on the runqueue

2019-09-03 Thread Paul E. McKenney
On Tue, Sep 03, 2019 at 10:06:03PM +0200, Peter Zijlstra wrote: > On Tue, Sep 03, 2019 at 12:18:47PM -0700, Linus Torvalds wrote: > > Now, if you can point to some particular field where that ordering > > makes sense for the particular case of "make it active on the > > runqueue" vs "look up the

Re: [RFC PATCH 0/3] x86/mm/tlb: Defer TLB flushes with PTI

2019-09-03 Thread Andy Lutomirski
On Thu, Aug 29, 2019 at 10:24 AM Nadav Amit wrote: > > > On Aug 27, 2019, at 5:30 PM, Andy Lutomirski wrote: > > > > On Tue, Aug 27, 2019 at 4:52 PM Nadav Amit wrote: > >>> On Aug 27, 2019, at 4:18 PM, Andy Lutomirski wrote: > >>> > >>> On Fri, Aug 23, 2019 at 11:07 PM Nadav Amit wrote: >

Re: [PATCH v2 1/2] dt-bindings: phy: intel-sdxc-phy: Add YAML schema for LGM SDXC PHY

2019-09-03 Thread Rob Herring
On Tue, Sep 3, 2019 at 11:52 AM Ramuthevar, Vadivel MuruganX wrote: > > Hi Rob, > > Thank you for your suggestions and clarifications. > > On 3/9/2019 6:34 PM, Rob Herring wrote: > > On Tue, Sep 3, 2019 at 11:08 AM Ramuthevar, Vadivel MuruganX > > wrote: > >> Hi Rob, > >> > >>Thank you

Re: Regression in 5.1.20: Reading long directory fails

2019-09-03 Thread Wolfgang Walter
Am Dienstag, 3. September 2019, 14:06:33 schrieb Jason L Tibbitts III: > > "WW" == Wolfgang Walter writes: > WW> What filesystem do you use on the server? xfs? > > Yeah, it's XFS. > > WW> If yes, does it use 64bit inodes (or started to use them)? > > These filesystems aren't super old, and

Re: [PATCH] net/skbuff: silence warnings under memory pressure

2019-09-03 Thread Qian Cai
On Tue, 2019-09-03 at 20:53 +0200, Michal Hocko wrote: > On Tue 03-09-19 11:42:22, Qian Cai wrote: > > On Tue, 2019-09-03 at 15:22 +0200, Michal Hocko wrote: > > > On Fri 30-08-19 18:15:22, Eric Dumazet wrote: > > > > If there is a risk of flooding the syslog, we should fix this > > > >

Re: [PATCH v2 15/27] drm/dp_mst: Cleanup drm_dp_send_link_address() a bit

2019-09-03 Thread Dave Airlie
On Wed, 4 Sep 2019 at 06:48, Lyude Paul wrote: > > Declare local pointer to the drm_dp_link_address_ack_reply struct > instead of constantly dereferencing it through the union in > txmsg->reply. Then, invert the order of conditionals so we don't have to > do the bulk of the work inside them, and

Re: [PATCH v4 3/4] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings

2019-09-03 Thread Stephen Boyd
Quoting Jack Pham (2019-09-03 10:39:24) > On Mon, Sep 02, 2019 at 08:23:04AM +0200, Jorge Ramirez wrote: > > On 8/30/19 20:28, Stephen Boyd wrote: > > > Quoting Bjorn Andersson (2019-08-30 09:45:20) > > >> On Fri 30 Aug 09:01 PDT 2019, Stephen Boyd wrote: > > >> > > > > > > The USB-C

Re: "beyond 2038" warnings from loopback mount is noisy

2019-09-03 Thread Arnd Bergmann
On Tue, Sep 3, 2019 at 11:31 PM Deepa Dinamani wrote: > On Tue, Sep 3, 2019 at 2:18 PM Theodore Y. Ts'o wrote: > > On Tue, Sep 03, 2019 at 09:18:44AM -0700, Deepa Dinamani wrote: > > > > > > This prints a warning for each inode that doesn't extend limits beyond > > > 2038. It is rate limited by

Re: "beyond 2038" warnings from loopback mount is noisy

2019-09-03 Thread Reindl Harald
Am 03.09.19 um 23:17 schrieb Theodore Y. Ts'o: > I know of a truly vast number of servers in production all over the > world which are using 128 byte inodes, and spamming the inodes at the > maximum rate limit is a really bad idea. This includes at some major > cloud data centers where the

Re: [PATCH v1 2/3] perf cs-etm: Add callchain to instruction sample

2019-09-03 Thread Mathieu Poirier
On Fri, Aug 30, 2019 at 02:24:20PM +0800, Leo Yan wrote: > Firstly, this patch adds support for the thread stack; when every branch > packet is coming we will push or pop the stack based on the sample > flags. > > Secondly, based on the thread stack we can synthesize call chain for the >

Re: "beyond 2038" warnings from loopback mount is noisy

2019-09-03 Thread Theodore Y. Ts'o
On Tue, Sep 03, 2019 at 02:31:06PM -0700, Deepa Dinamani wrote: > > We need to drop this commit (ext4: Initialize timestamps limits), or > > at least the portion which adds the call to the EXT4_INODE_SET_XTIME > > macro in ext4.h. > > As Arnd said, I think this can be fixed by warning only when

Re: [PATCH 8/8] tools/power/x86/intel-speed-select: Output success/failed for command output

2019-09-03 Thread Srinivas Pandruvada
On Tue, 2019-09-03 at 11:37 -0400, Prarit Bhargava wrote: > Command output has confusing data, returning "0" on success. For > example > > > # ./intel-speed-select -c 14 turbo-freq enable > > Intel(R) Speed Select Technology > Executing on CPU model:106[0x6a] > package-1 >die-0 >

Re: [PATCH v1 1/3] perf cs-etm: Refactor instruction size handling

2019-09-03 Thread Mathieu Poirier
On Fri, Aug 30, 2019 at 02:24:19PM +0800, Leo Yan wrote: > There has several code pieces need to know the instruction size, but > now every place calculates the instruction size separately. > > This patch refactors to create a new function cs_etm__instr_size() as > a central place to analyze the

[PATCH v2] net: fixed_phy: Add forward declaration for struct gpio_desc;

2019-09-03 Thread Moritz Fischer
From: Moritz Fischer Add forward declaration for struct gpio_desc in order to address the following: ./include/linux/phy_fixed.h:48:17: error: 'struct gpio_desc' declared inside parameter list [-Werror] ./include/linux/phy_fixed.h:48:17: error: its scope is only this definition or

Re: [PATCH v2] riscv: add support for SECCOMP and SECCOMP_FILTER

2019-09-03 Thread Palmer Dabbelt
On Wed, 28 Aug 2019 10:52:05 PDT (-0700), l...@amacapital.net wrote: On Aug 25, 2019, at 2:59 PM, Kees Cook wrote: On Thu, Aug 22, 2019 at 01:55:22PM -0700, David Abdurachmanov wrote: This patch was extensively tested on Fedora/RISCV (applied by default on top of 5.2-rc7 kernel for <2

Re: "beyond 2038" warnings from loopback mount is noisy

2019-09-03 Thread Theodore Y. Ts'o
On Tue, Sep 03, 2019 at 11:48:14PM +0200, Arnd Bergmann wrote: > I think the warning as it was intended makes sense, the idea > was never to warn on every inode update for file systems that > cannot handle future dates, only to warn when we > > a) try to set a future date > b) fail to do that

Re: [RFC PATCH v2 2/2] ELF: Add ELF program property parsing support

2019-09-03 Thread Yu-cheng Yu
On Mon, 2019-09-02 at 10:28 +0100, Dave Martin wrote: > On Fri, Aug 30, 2019 at 06:03:27PM +0100, Yu-cheng Yu wrote: > > On Fri, 2019-08-30 at 09:34 +0100, Dave Martin wrote: > > > On Fri, Aug 30, 2019 at 06:37:45AM +0100, Kees Cook wrote: > > > > On Fri, Aug 23, 2019 at 06:23:40PM +0100, Dave

Re: [PATCH 0/4] ethtool: implement Energy Detect Powerdown support via phy-tunable

2019-09-03 Thread David Miller
From: Alexandru Ardelean Date: Tue, 3 Sep 2019 19:06:22 +0300 > First 2 patches implement the kernel support for controlling Energy Detect > Powerdown support via phy-tunable, and the next 2 patches implement the > ethtool user-space control. You should do this as two separate patch series, one

Re: [PATCH] clk: qcom: gcc-sdm845: Use floor ops for sdcc clks

2019-09-03 Thread Stephen Boyd
Quoting Taniya Das (2019-09-03 08:52:12) > Hi, > > On 8/31/2019 3:04 AM, Doug Anderson wrote: > > Hi, > > > > On Fri, Aug 30, 2019 at 12:51 PM Stephen Boyd wrote: > >> > >> Some MMC cards fail to enumerate properly when inserted into an MMC slot > >> on sdm845 devices. This is because the clk

Re: "beyond 2038" warnings from loopback mount is noisy

2019-09-03 Thread Deepa Dinamani
> > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h > > index 9e3ae3be3de9..5a971d1b6d5e 100644 > > --- a/fs/ext4/ext4.h > > +++ b/fs/ext4/ext4.h > > @@ -835,7 +835,9 @@ do { > > \ > > } > > \ > > else{\ > >

Re: Problem when function alarmtimer_suspend returns 0 if time delta is zero

2019-09-03 Thread Thomas Gleixner
On Tue, 3 Sep 2019, Michael wrote: > Thomas, > > thank you very much for your patch. Unfortunately currently I can only test it > with a kernel 4.1.52 but i've tried to patch > your new logic into my older kernel version. https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH RFC 03/14] drivers: irqchip: add PDC irqdomain for wakeup capable GPIOs

2019-09-03 Thread Stephen Boyd
Quoting Lina Iyer (2019-08-29 11:11:52) > Introduce a new domain for wakeup capable GPIOs. The domain can be > requested using the bus token DOMAIN_BUS_WAKEUP. In the following > patches, we will specify PDC as the wakeup-parent for the TLMM GPIO > irqchip. Requesting a wakeup GPIO will setup the

Re: "beyond 2038" warnings from loopback mount is noisy

2019-09-03 Thread Theodore Y. Ts'o
On Tue, Sep 03, 2019 at 03:47:54PM -0700, Deepa Dinamani wrote: > > > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h > > > index 9e3ae3be3de9..5a971d1b6d5e 100644 > > > --- a/fs/ext4/ext4.h > > > +++ b/fs/ext4/ext4.h > > > @@ -835,7 +835,9 @@ do { > > > \ > > >

Re: [PATCH v1 1/1] i2c: iproc: Add i2c repeated start capability

2019-09-03 Thread Ray Jui
On 8/31/19 2:49 AM, Wolfram Sang wrote: Hi Ray, With all the limitations in place, I wonder if it might be easier to implement an smbus_xfer callback instead? What is left that makes this controller more than SMBus and real I2C? Right. But what is the implication of using smbus_xfer

Re: linux-next: build failure after merge of the hmm tree

2019-09-03 Thread Dan Williams
On Mon, Sep 2, 2019 at 10:42 PM Stephen Rothwell wrote: > > Hi Dan, > > On Mon, 2 Sep 2019 22:31:00 -0700 Dan Williams > wrote: > > > > On Mon, Sep 2, 2019 at 4:45 PM Stephen Rothwell > > wrote: > > > > > > Hi Jason, > > > > > > On Mon, 2 Sep 2019 10:51:41 + Jason Gunthorpe > > > wrote:

Re: [PATCH 1/2] KVM: VMX: Disable posted interrupts for odd IRQs

2019-09-03 Thread Liran Alon
> On 3 Sep 2019, at 17:29, Alexander Graf wrote: > > We can easily route hardware interrupts directly into VM context when > they target the "Fixed" or "LowPriority" delivery modes. > > However, on modes such as "SMI" or "Init", we need to go via KVM code > to actually put the vCPU into a

Several errors on my dmesg on kernel 4.15.18

2019-09-03 Thread Developer sequielo
[0.00] Linux version 4.15.0-60-generic (buildd@lgw01-amd64-030) (gcc version 7.4.0 (Ubuntu 7.4.0-1ubuntu1~18.04.1)) #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 (Ubuntu 4.15.0-60.67-generic 4.15.18) [0.00] Command line: BOOT_IMAGE=/boot/vmlinuz-4.15.0-60-generic

Re: general protection fault in smack_socket_sendmsg

2019-09-03 Thread Casey Schaufler
On 8/30/2019 10:33 PM, Hillf Danton wrote: > On Fri, 30 Aug 2019 12:40:07 -0700 >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:6525771f Merge tag 'arc-5.3-rc7' of git://git.kernel.org/p.. >> git tree: upstream >> console output:

[PATCH] gpiolib: of: fix fallback quirks handling

2019-09-03 Thread Dmitry Torokhov
We should only try to execute fallback quirks handling when previous call returned -ENOENT, and not when we did not get -EPROBE_DEFER. The other errors should be treated as hard errors: we did find the GPIO description, but for some reason we failed to handle it properly. The fallbacks should

[PATCH v3] kunit: fix failure to build without printk

2019-09-03 Thread Brendan Higgins
Previously KUnit assumed that printk would always be present, which is not a valid assumption to make. Fix that by removing call to vprintk_emit, and calling printk directly. This fixes a build error[1] reported by Randy. For context this change comes after much discussion. My first stab[2] at

Re: [PATCH 2/2] KVM: SVM: Disable posted interrupts for odd IRQs

2019-09-03 Thread Liran Alon
> On 3 Sep 2019, at 17:29, Alexander Graf wrote: > > We can easily route hardware interrupts directly into VM context when > they target the "Fixed" or "LowPriority" delivery modes. > > However, on modes such as "SMI" or "Init", we need to go via KVM code > to actually put the vCPU into a

Re: [PATCH v4 3/4] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings

2019-09-03 Thread Bjorn Andersson
On Tue 03 Sep 14:45 PDT 2019, Stephen Boyd wrote: > Quoting Jack Pham (2019-09-03 10:39:24) > > On Mon, Sep 02, 2019 at 08:23:04AM +0200, Jorge Ramirez wrote: > > > On 8/30/19 20:28, Stephen Boyd wrote: > > > > Quoting Bjorn Andersson (2019-08-30 09:45:20) > > > >> On Fri 30 Aug 09:01 PDT 2019,

Re: [PATCH v3] kunit: fix failure to build without printk

2019-09-03 Thread Joe Perches
On Tue, 2019-09-03 at 16:21 -0700, Brendan Higgins wrote: > Previously KUnit assumed that printk would always be present, which is > not a valid assumption to make. Fix that by removing call to > vprintk_emit, and calling printk directly. > > This fixes a build error[1] reported by Randy. > >

[PATCH] KVM: x86: Manually calculate reserved bits when loading PDPTRS

2019-09-03 Thread Sean Christopherson
Manually generate the PDPTR reserved bit mask when explicitly loading PDPTRs. The reserved bits that are being tracked by the MMU reflect the current paging mode, which is unlikely to be PAE paging in the vast majority of flows that use load_pdptrs(), e.g. CR0 and CR4 emulation, __set_sregs(),

Re: About compiler memory barrier for atomic_set/atomic_read on x86

2019-09-03 Thread Yin, Fengwei
Hi Peter, On 9/3/2019 10:06 PM, Peter Zijlstra wrote: On Tue, Sep 03, 2019 at 09:23:41PM +0800, Yin, Fengwei wrote: Hi Peter, There is one question regarding following commit: commit 69d927bba39517d0980462efc051875b7f4db185 Author: Peter Zijlstra Date: Wed Apr 24 13:38:23 2019 +0200

Re: [PATCH v7 5/5] kasan debug: track pages allocated for vmalloc shadow

2019-09-03 Thread Daniel Axtens
Andrey Konovalov writes: > On Tue, Sep 3, 2019 at 4:56 PM Daniel Axtens wrote: >> >> Provide the current number of vmalloc shadow pages in >> /sys/kernel/debug/kasan_vmalloc/shadow_pages. > > Maybe it makes sense to put this into /sys/kernel/debug/kasan/ > (without _vmalloc) and name e.g.

Re: [PATCH v3] kunit: fix failure to build without printk

2019-09-03 Thread Brendan Higgins
On Tue, Sep 3, 2019 at 4:35 PM Joe Perches wrote: > > On Tue, 2019-09-03 at 16:21 -0700, Brendan Higgins wrote: > > Previously KUnit assumed that printk would always be present, which is > > not a valid assumption to make. Fix that by removing call to > > vprintk_emit, and calling printk

Re: [PATCH v3 0/6] hugetlb_cgroup: Add hugetlb_cgroup reservation limits

2019-09-03 Thread Mike Kravetz
On 9/3/19 10:57 AM, Mike Kravetz wrote: > On 8/29/19 12:18 AM, Michal Hocko wrote: >> [Cc cgroups maintainers] >> >> On Wed 28-08-19 10:58:00, Mina Almasry wrote: >>> On Wed, Aug 28, 2019 at 4:23 AM Michal Hocko wrote: On Mon 26-08-19 16:32:34, Mina Almasry wrote: > mm/hugetlb.c

RE: [PATCH v1 1/2] clk: intel: Add CGU clock driver for a new SoC

2019-09-03 Thread Stephen Boyd
Quoting Martin Blumenstingl (2019-09-02 15:20:15) > +struct intel_clk_gate { > + struct clk_hw hw; > + struct device *dev; > + struct regmap *map; > + unsigned int reg; > + u8 shift; > + unsigned long flags; > +}; > I know at least two existing regmap clock

[PATCH v4] kunit: fix failure to build without printk

2019-09-03 Thread Brendan Higgins
Previously KUnit assumed that printk would always be present, which is not a valid assumption to make. Fix that by removing call to vprintk_emit, and calling printk directly. This fixes a build error[1] reported by Randy. For context this change comes after much discussion. My first stab[2] at

Re: [PATCH v2 1/4] mmc: sdhci-of-aspeed: Fix link failure for SPARC

2019-09-03 Thread Andrew Jeffery
On Wed, 4 Sep 2019, at 00:18, Ulf Hansson wrote: > On Mon, 2 Sep 2019 at 07:26, Andrew Jeffery wrote: > > > > > > > > On Mon, 2 Sep 2019, at 13:42, Joel Stanley wrote: > > > On Mon, 2 Sep 2019 at 03:58, Andrew Jeffery wrote: > > > > > > > > Resolves the following build error reported by the

linux-next: build warnings after merge of the kbuild tree

2019-09-03 Thread Stephen Rothwell
Hi all, After merging the kbuild tree, today's linux-next build (powerpc ppc64_defconfig) produced these warnings: Presumably introduced by commit 1267f9d3047d ("kbuild: add $(BASH) to run scripts with bash-extension") and presumably arch/powerpc/tools/unrel_branch_check.sh (which has no #!

Re: [PATCH] powerpc: Avoid clang warnings around setjmp and longjmp

2019-09-03 Thread Nathan Chancellor
On Tue, Sep 03, 2019 at 02:31:28PM -0500, Segher Boessenkool wrote: > On Mon, Sep 02, 2019 at 10:55:53PM -0700, Nathan Chancellor wrote: > > On Thu, Aug 29, 2019 at 09:59:48AM +, David Laight wrote: > > > From: Nathan Chancellor > > > > Sent: 28 August 2019 19:45 > > > ... > > > > However, I

[PATCH] xen/pci: try to reserve MCFG areas earlier

2019-09-03 Thread Igor Druzhinin
If MCFG area is not reserved in E820, Xen by default will defer its usage until Dom0 registers it explicitly after ACPI parser recognizes it as a reserved resource in DSDT. Having it reserved in E820 is not mandatory according to "PCI Firmware Specification, rev 3.2" (par. 4.1.2) and firmware is

Re: [PATCH -rcu dev 2/2] rcu/dyntick-idle: Add better tracing

2019-09-03 Thread Joel Fernandes
On Tue, Sep 03, 2019 at 01:04:46PM -0700, Paul E. McKenney wrote: > On Fri, Aug 30, 2019 at 12:23:48PM -0400, Joel Fernandes (Google) wrote: > > The dyntick-idle traces are a bit confusing. This patch makes it simpler > > and adds some missing cases such as EQS-enter due to user vs idle mode. > >

Re: [PATCH] genirq: move debugfs option to kernel hacking

2019-09-03 Thread Changbin Du
On Sun, Sep 01, 2019 at 11:49:36AM +0100, Marc Zyngier wrote: > On Sun, 1 Sep 2019 18:10:33 +0800 > Changbin Du wrote: > > > On Sun, Sep 01, 2019 at 08:23:02AM +0200, Thomas Gleixner wrote: > > > On Sun, 1 Sep 2019, Changbin Du wrote: > > > > > > > Just like the other generic debug options,

Re: [btrfs] 3ae92b3782: xfstests.generic.269.fail

2019-09-03 Thread Rong Chen
On 9/3/19 9:25 PM, Josef Bacik wrote: On Tue, Sep 03, 2019 at 04:06:33PM +0800, kernel test robot wrote: FYI, we noticed the following commit (built with gcc-7): commit: 3ae92b3782182d282a92573abe95c96d34ca6e73 ("btrfs: change the minimum global reserve size")

<    6   7   8   9   10   11   12   13   >