Re: [PATCH v5 03/11] dt-bindings: i2c: dw: Add Baikal-T1 SoC I2C controller

2020-05-27 Thread Serge Semin
Rob, Could you please pay attention to this patch? The patchset review procedure is nearly over, while the DT part is only partly reviewed by you. Thanks -Sergey On Wed, May 27, 2020 at 06:30:38PM +0300, Serge Semin wrote: > Add the "baikal,bt1-sys-i2c" compatible string to the DW I2C binding.

[tip:WIP.sched/core 7/9] smp.c:undefined reference to `irq_work_single'

2020-05-27 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.sched/core head: 68a1740c687d4a75b9e9dea0ab0aae61f167c880 commit: 5033cfdeb4a2a51fa847b1a3f5f6eee65dda6c75 [7/9] irq_work, smp: Allow irq_work on call_single_queue config: s390-allnoconfig (attached as .config) compiler:

Re: [PATCH 1/2] seccomp: notify user trap about unused filter

2020-05-27 Thread Christian Brauner
On Wed, May 27, 2020 at 09:25:59AM -0600, Tycho Andersen wrote: > On Wed, May 27, 2020 at 01:19:01PM +0200, Christian Brauner wrote: > > +void seccomp_filter_notify(const struct task_struct *tsk) > > +{ > > + struct seccomp_filter *orig = tsk->seccomp.filter; > > + > > + while (orig &&

Re: [PATCH v3 64/75] x86/sev-es: Cache CPUID results for improved performance

2020-05-27 Thread Tom Lendacky
On 4/28/20 10:17 AM, Joerg Roedel wrote: From: Mike Stunes To avoid a future VMEXIT for a subsequent CPUID function, cache the results returned by CPUID into an xarray. [tl: coding standard changes, register zero extension] Signed-off-by: Mike Stunes Signed-off-by: Tom Lendacky [

Re: [PATCH v5 02/11] dt-bindings: i2c: Discard i2c-slave flag from the DW I2C example

2020-05-27 Thread Serge Semin
Rob, Could you pay attention to this patch? The patchset review procedure is nearly over, while the DT part is only partly reviewed by you. Thanks -Sergey On Wed, May 27, 2020 at 06:30:37PM +0300, Serge Semin wrote: > dtc currently doesn't support I2C_OWN_SLAVE_ADDRESS flag set in the > i2c

[PATCH v5 10/11] i2c: designware: Move reg-space remapping into a dedicated function

2020-05-27 Thread Serge Semin
This is a preparation patch before adding a quirk with custom registers map creation required for the Baikal-T1 System I2C support. Signed-off-by: Serge Semin Reviewed-by: Andy Shevchenko Cc: Alexey Malahov Cc: Thomas Bogendoerfer Cc: Rob Herring Cc: linux-m...@vger.kernel.org Cc:

Re: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-27 Thread Greg KH
On Wed, May 13, 2020 at 05:08:19PM +, Ashwin H wrote: > > Ok, but what does that mean for us? > > > > You need to say why you are sending a patch, otherwise we will guess wrong. > > In drivers/gpu/drm/i915/i915_gem_execbuffer.c, ioctl functions does > user_access_begin() without doing

[PATCH v5 07/11] i2c: designware: Discard Cherry Trail model flag

2020-05-27 Thread Serge Semin
A PM workaround activated by the flag MODEL_CHERRYTRAIL has been removed since commit 9cbeeca05049 ("i2c: designware: Remove Cherry Trail PMIC I2C bus pm_disabled workaround"), but the flag most likely by mistake has been left in the Dw I2C drivers. Let's remove it. Since MODEL_MSCC_OCELOT is the

[PATCH v5 05/11] i2c: designware: slave: Set DW I2C core module dependency

2020-05-27 Thread Serge Semin
DW APB I2C slave code in fact depends on the DW I2C driver core, but not on the platform code as it used to be before commit 90bc1ee6de9f ("i2c: designware: Allow slave mode for PCI enumerated devices"). Yes, the I2C slave interface is currently supported by both the platform and PCI versions of

[PATCH v5 11/11] i2c: designware: Add Baikal-T1 System I2C support

2020-05-27 Thread Serge Semin
Baikal-T1 System Controller is equipped with a dedicated I2C Controller which functionality is based on the DW APB I2C IP-core, the only difference in a way it' registers are accessed. There are three access register provided in the System Controller registers map, which indirectly address the

[PATCH v5 08/11] i2c: designware: Convert driver to using regmap API

2020-05-27 Thread Serge Semin
Seeing the DW I2C driver is using flags-based accessors with two conditional clauses it would be better to replace them with the regmap API IO methods and to initialize the regmap object with read/write callbacks specific to the controller registers map implementation. This will be also handy for

[PATCH v5 09/11] i2c: designware: Retrieve quirk flags as early as possible

2020-05-27 Thread Serge Semin
Some platforms might need to activate the driver quirks at a very early probe stage. For instance, Baikal-T1 System I2C doesn't need to map the registers space as ones belong to the system controller. Instead it will request the syscon regmap from the parental DT node. In order to be able to do so

[PATCH v5 02/11] dt-bindings: i2c: Discard i2c-slave flag from the DW I2C example

2020-05-27 Thread Serge Semin
dtc currently doesn't support I2C_OWN_SLAVE_ADDRESS flag set in the i2c "reg" property. If it is the compiler will print a warning: Warning (i2c_bus_reg): /example-2/i2c@112/eeprom@64: I2C bus unit address format error, expected "4064" Warning (i2c_bus_reg):

[PATCH v5 03/11] dt-bindings: i2c: dw: Add Baikal-T1 SoC I2C controller

2020-05-27 Thread Serge Semin
Add the "baikal,bt1-sys-i2c" compatible string to the DW I2C binding. Even though the corresponding node is supposed to be a child of the Baikal-T1 System Controller, its reg property is left required for compatibility. Signed-off-by: Serge Semin Cc: Alexey Malahov Cc: Thomas Bogendoerfer Cc:

[PATCH v5 04/11] i2c: designware: Use `-y` to build multi-object modules

2020-05-27 Thread Serge Semin
Since commit 4f8272802739 ("Documentation: update kbuild loadable modules goals & examples") `-objs` is fitted for building host programs, lets change DW I2C core, platform and PCI driver kbuild directives to using `-y`, which more straightforward for device drivers. By doing so we can discard the

[PATCH v5 00/11] i2c: designeware: Add Baikal-T1 System I2C support

2020-05-27 Thread Serge Semin
Jarkko, Wolfram, the merge window is upon us, please review/merge in/whatever the patchset. Initially this has been a small patchset which embedded the Baikal-T1 System I2C support into the DW APB I2C driver as is by using a simplest way. After a short discussion with Andy we decided to implement

Re: [PATCH] capabilities: Introduce CAP_RESTORE

2020-05-27 Thread Christian Brauner
On Wed, May 27, 2020 at 04:14:03PM +0200, Adrian Reber wrote: > On Tue, May 26, 2020 at 08:59:29AM -0500, Eric W. Biederman wrote: > > Adrian Reber writes: > > > > > On Fri, May 22, 2020 at 09:40:37AM -0700, Casey Schaufler wrote: > > > > >> What are the other blockers? Are you going to suggest

[PATCH v5 01/11] dt-bindings: i2c: Convert DW I2C binding to DT schema

2020-05-27 Thread Serge Semin
Modern device tree bindings are supposed to be created as YAML-files in accordance with dt-schema. This commit replaces Synopsys DW I2C legacy bare text bindings with YAML file. As before the bindings file states that the corresponding dts node is supposed to be compatible either with generic DW

[PATCH v5 06/11] i2c: designware: Add Baytrail sem config DW I2C platform dependency

2020-05-27 Thread Serge Semin
Currently Intel Baytrail I2C semaphore is a feature of the DW APB I2C platform driver. It's a bit confusing to see it's config in the menu at some separated place with no reference to the platform code. Let's move the config definition to be below the I2C_DESIGNWARE_PLATFORM config and mark it

Re: [PATCH v6 2/5] dt-bindings: iio: magnetometer: ak8975: convert format to yaml, add maintainer

2020-05-27 Thread Jonathan Albrieux
On Tue, May 26, 2020 at 04:28:47PM -0600, Rob Herring wrote: > On Mon, May 25, 2020 at 05:10:36PM +0200, Jonathan Albrieux wrote: > > Converts documentation from txt format to yaml. > > I would have converted to yaml and do any re-formatting/wording, then > added 'interrupts', but this is fine.

Re: [PATCH -tip] compiler_types.h: Optimize __unqual_scalar_typeof compilation time

2020-05-27 Thread Nathan Chancellor
On Wed, May 27, 2020 at 12:32:36PM +0200, 'Marco Elver' via Clang Built Linux wrote: > If the compiler supports C11's _Generic, use it to speed up compilation > times of __unqual_scalar_typeof(). GCC version 4.9 or later and > all supported versions of Clang support the feature (the oldest >

Re: [PATCH 4.19 00/81] 4.19.125-rc1 review

2020-05-27 Thread Greg Kroah-Hartman
On Wed, May 27, 2020 at 07:02:25AM -0700, Guenter Roeck wrote: > On Tue, May 26, 2020 at 08:52:35PM +0200, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.19.125 release. > > There are 81 patches in this series, all will be posted as a response > > to this one.

Re: [PATCH 1/2] seccomp: notify user trap about unused filter

2020-05-27 Thread Tycho Andersen
On Wed, May 27, 2020 at 01:19:01PM +0200, Christian Brauner wrote: > +void seccomp_filter_notify(const struct task_struct *tsk) > +{ > + struct seccomp_filter *orig = tsk->seccomp.filter; > + > + while (orig && refcount_dec_and_test(>live)) { > + if (waitqueue_active(>wqh)) > +

[tip: locking/kcsan] compiler_types.h: Optimize __unqual_scalar_typeof compilation time

2020-05-27 Thread tip-bot2 for Marco Elver
The following commit has been merged into the locking/kcsan branch of tip: Commit-ID: a5dead405f6be1fb80555bdcb77c406bf133fdc8 Gitweb: https://git.kernel.org/tip/a5dead405f6be1fb80555bdcb77c406bf133fdc8 Author:Marco Elver AuthorDate:Wed, 27 May 2020 12:32:36 +02:00

Re: [PATCH] arm64: disable -fsanitize=shadow-call-stack for big-endian

2020-05-27 Thread Mark Rutland
On Wed, May 27, 2020 at 03:39:46PM +0200, Arnd Bergmann wrote: > clang-11 and earlier do not support -fsanitize=shadow-call-stack > in combination with -mbig-endian, but the Kconfig check does not > pass the endianess flag, so building a big-endian kernel with > this fails at build time: > >

Re: [PATCH ghak124 v1] audit: log nftables configuration change events

2020-05-27 Thread Richard Guy Briggs
On 2020-05-27 16:53, Florian Westphal wrote: > Richard Guy Briggs wrote: > > iptables, ip6tables, arptables and ebtables table registration, > > replacement and unregistration configuration events are logged for the > > native (legacy) iptables setsockopt api, but not for the > > nftables netlink

Re: [PATCH] proc/base: Skip assignment to len when there is no error on d_path in do_proc_readlink.

2020-05-27 Thread Alexey Dobriyan
On Wed, May 27, 2020 at 09:41:53AM -0500, Eric W. Biederman wrote: > Kaitao Cheng writes: > > > we don't need {len = PTR_ERR(pathname)} when IS_ERR(pathname) is false, > > it's better to move it into if(IS_ERR(pathname)){}. > > Please look at the generated code. > > I believe you will find

Re: [PATCH 0/3] workqueue: Make the workqueue code PREEMPT_RT safe

2020-05-27 Thread Sebastian Andrzej Siewior
On 2020-05-26 14:46:59 [-0700], Linus Torvalds wrote: > On Tue, May 26, 2020 at 2:41 PM Linus Torvalds > wrote: > > > > Almost all users of swait have historically been buggy and/or > > pointless. > > Yeah, looking at this one, it really seems to fundamentally fall in > the "pointless" category.

Re: [PATCH][V3] arm64: perf: Get the wrong PC value in REGS_ABI_32 mode

2020-05-27 Thread Mark Rutland
On Wed, May 27, 2020 at 09:33:00AM +0800, Jiping Ma wrote: > > > On 05/26/2020 06:26 PM, Mark Rutland wrote: > > On Mon, May 11, 2020 at 10:52:07AM +0800, Jiping Ma wrote: > > > Modified the patch subject and the change description. > > > > > > PC value is get from regs[15] in REGS_ABI_32 mode,

Re: [PATCH 0/2] Fix issue with not starting nesting guests on my system

2020-05-27 Thread Maxim Levitsky
On Tue, 2020-05-26 at 18:13 -0700, Sean Christopherson wrote: > On Sat, May 23, 2020 at 07:14:53PM +0300, Maxim Levitsky wrote: > > On my AMD machine I noticed that I can't start any nested guests, > > because nested KVM (everything from master git branches) complains > > that it can't find msr

RE: [PATCH] perf/x86/intel/uncore: Fix oops when counting IMC uncore events on some TGL

2020-05-27 Thread David Laight
From: Liang, Kan > Sent: 27 May 2020 16:01 > On 5/27/2020 10:51 AM, David Laight wrote: > > From: Liang, Kan > >> Sent: 27 May 2020 15:47 > >> On 5/27/2020 8:59 AM, David Laight wrote: > >>> From: kan.li...@linux.intel.com > Sent: 27 May 2020 13:31 > > From: Kan Liang > >

Re: [PATCH 0/2] Fix issue with not starting nesting guests on my system

2020-05-27 Thread Maxim Levitsky
On Tue, 2020-05-26 at 18:13 -0700, Sean Christopherson wrote: > On Sat, May 23, 2020 at 07:14:53PM +0300, Maxim Levitsky wrote: > > On my AMD machine I noticed that I can't start any nested guests, > > because nested KVM (everything from master git branches) complains > > that it can't find msr

Re: [PATCH 1/2] kvm/x86/vmx: enable X86_FEATURE_WAITPKG in KVM capabilities

2020-05-27 Thread Maxim Levitsky
On Tue, 2020-05-26 at 18:20 -0700, Sean Christopherson wrote: > On Sat, May 23, 2020 at 07:14:54PM +0300, Maxim Levitsky wrote: > > Even though we might not allow the guest to use > > WAITPKG's new instructions, we should tell KVM > > that the feature is supported by the host CPU. > > > > Note

Re: [PATCH 2/2] kvm/x86: don't expose MSR_IA32_UMWAIT_CONTROL unconditionally

2020-05-27 Thread Maxim Levitsky
On Tue, 2020-05-26 at 18:21 -0700, Sean Christopherson wrote: > On Sat, May 23, 2020 at 07:14:55PM +0300, Maxim Levitsky wrote: > > This msr is only available when the host supports WAITPKG feature. > > > > This breaks a nested guest, if the L1 hypervisor is set to ignore > > unknown msrs,

[PATCH] media: stm32-dcmi: Set minimum cpufreq requirement

2020-05-27 Thread Benjamin Gaignard
Before start streaming set cpufreq minimum frequency requirement. The cpufreq governor will adapt the frequencies and we will have no latency for handling interrupts. Signed-off-by: Benjamin Gaignard --- drivers/media/platform/stm32/stm32-dcmi.c | 29 - 1 file

Re: [PATCH 1/2] x86: mm: ptdump: Calculate effective permissions correctly

2020-05-27 Thread Jan Beulich
On 21.05.2020 17:23, Steven Price wrote: > By switching the x86 page table dump code to use the generic code the > effective permissions are no longer calculated correctly because the > note_page() function is only called for *leaf* entries. To calculate the > actual effective permissions it is

Re: [PATCH] tee: fix crypto select

2020-05-27 Thread Jens Wiklander
Hi Arnd, On Wed, May 27, 2020 at 3:39 PM Arnd Bergmann wrote: > > When selecting a crypto cipher, we also need to select the > subsystem itself: > > WARNING: unmet direct dependencies detected for CRYPTO_SHA1 > Depends on [m]: CRYPTO [=m] > Selected by [y]: > - TEE [=y] && (HAVE_ARM_SMCCC

[PATCH] rtc: rv3028: add the missed check for devm_regmap_init_i2c

2020-05-27 Thread Chuhong Yuan
rv3028_probe() misses a check for devm_regmap_init_i2c(). Add the missed check to fix it. Signed-off-by: Chuhong Yuan --- drivers/rtc/rtc-rv3028.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/rtc/rtc-rv3028.c b/drivers/rtc/rtc-rv3028.c index a0ddc86c975a..ec84db0b3d7a 100644

[PATCH] media: exynos4-is: add the missed check for pinctrl_lookup_state

2020-05-27 Thread Chuhong Yuan
From: Chuhong Yuan fimc_md_get_pinctrl() misses a check for pinctrl_lookup_state(). Add the missed check to fix it. Signed-off-by: Chuhong Yuan --- drivers/media/platform/exynos4-is/media-dev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH] iio: mma8452: add missed iio_device_unregister in probe failure

2020-05-27 Thread Chuhong Yuan
mma8452_probe() calls iio_device_register() but misses to call iio_device_unregister() when probe fails. Add the missed call in error handler to fix it. Signed-off-by: Chuhong Yuan --- drivers/iio/accel/mma8452.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v25 03/16] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers

2020-05-27 Thread Dan Murphy
Pavel On 5/27/20 8:58 AM, Pavel Machek wrote: Hi! + There can only be one instance of the ti,led-bank + property for each device node. This is a required node is the LED + modules are to be backed. I don't understand the second sentence. Pretty sure it is not

[PATCH] iio: amplifiers: ad8366: add the missed check for devm_gpiod_get

2020-05-27 Thread Chuhong Yuan
ad8366_probe() forgets to check the return value of devm_gpiod_get(). Add the missed check to fix it. Signed-off-by: Chuhong Yuan --- drivers/iio/amplifiers/ad8366.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/iio/amplifiers/ad8366.c b/drivers/iio/amplifiers/ad8366.c index

[tip: objtool/core] objtool: Move struct objtool_file into arch-independent header

2020-05-27 Thread tip-bot2 for Matt Helsley
The following commit has been merged into the objtool/core branch of tip: Commit-ID: d37c90d47fc4657423d2ff1c3ed3fd70612a9b43 Gitweb: https://git.kernel.org/tip/d37c90d47fc4657423d2ff1c3ed3fd70612a9b43 Author:Matt Helsley AuthorDate:Tue, 19 May 2020 13:55:32 -07:00

[tip: objtool/core] objtool: Enable compilation of objtool for all architectures

2020-05-27 Thread tip-bot2 for Matt Helsley
The following commit has been merged into the objtool/core branch of tip: Commit-ID: 0decf1f8de919782b152daf9c991967a2bac54f0 Gitweb: https://git.kernel.org/tip/0decf1f8de919782b152daf9c991967a2bac54f0 Author:Matt Helsley AuthorDate:Tue, 19 May 2020 13:55:33 -07:00

[tip: objtool/core] samples/ftrace: Fix asm function ELF annotations

2020-05-27 Thread tip-bot2 for Josh Poimboeuf
The following commit has been merged into the objtool/core branch of tip: Commit-ID: 9d907f1ae80b8a67d5397e26912b9d56d0b70a02 Gitweb: https://git.kernel.org/tip/9d907f1ae80b8a67d5397e26912b9d56d0b70a02 Author:Josh Poimboeuf AuthorDate:Fri, 24 Apr 2020 15:40:43 -05:00

[tip: objtool/core] objtool: Add check_kcov_mode() to the uaccess safelist

2020-05-27 Thread tip-bot2 for Josh Poimboeuf
The following commit has been merged into the objtool/core branch of tip: Commit-ID: ae033f088f277efd5b3c6d681ce9e7682380efff Gitweb: https://git.kernel.org/tip/ae033f088f277efd5b3c6d681ce9e7682380efff Author:Josh Poimboeuf AuthorDate:Wed, 29 Apr 2020 14:09:04 -05:00

[tip: objtool/core] objtool: Exit successfully when requesting help

2020-05-27 Thread tip-bot2 for Matt Helsley
The following commit has been merged into the objtool/core branch of tip: Commit-ID: f15c648f202cd0232d4a9c98627bc08bcd6d11ee Gitweb: https://git.kernel.org/tip/f15c648f202cd0232d4a9c98627bc08bcd6d11ee Author:Matt Helsley AuthorDate:Tue, 19 May 2020 13:55:31 -07:00

Re: [PATCH v4 11/11] i2c: designware: Add Baikal-T1 System I2C support

2020-05-27 Thread Serge Semin
On Wed, May 27, 2020 at 05:03:03PM +0300, Andy Shevchenko wrote: > On Wed, May 27, 2020 at 03:01:11PM +0300, Serge Semin wrote: > > Baikal-T1 System Controller is equipped with a dedicated I2C Controller > > which functionality is based on the DW APB I2C IP-core, the only > > difference in a way

Re: [PATCH v2] mfd: tps65910: Correct power-off programming sequence

2020-05-27 Thread Dmitry Osipenko
26.05.2020 18:01, Michał Mirosław пишет: > On Sun, May 24, 2020 at 10:26:43PM +0300, Dmitry Osipenko wrote: >> This patch fixes system shutdown on a devices that use TPS65910 as a >> system's power controller. In accordance to the TPS65910 datasheet, the >> PMIC's state-machine transitions into

Re: [RFC RESEND 0/3] Introduce cpufreq minimum load QoS

2020-05-27 Thread Rafael J. Wysocki
On Wed, May 27, 2020 at 4:54 PM Benjamin GAIGNARD wrote: > > > > On 5/27/20 2:48 PM, Benjamin GAIGNARD wrote: > > > > > > On 5/27/20 2:22 PM, Vincent Guittot wrote: > >> On Wed, 27 May 2020 at 13:17, Benjamin GAIGNARD > >> wrote: > >>> > >>> > >>> On 5/27/20 12:09 PM, Valentin Schneider wrote: >

Re: [PATCH][V3] arm64: perf: Get the wrong PC value in REGS_ABI_32 mode

2020-05-27 Thread Mark Rutland
On Tue, May 26, 2020 at 08:54:19PM +0100, Will Deacon wrote: > On Tue, May 26, 2020 at 11:26:11AM +0100, Mark Rutland wrote: > > On Mon, May 11, 2020 at 10:52:07AM +0800, Jiping Ma wrote: > > > Modified the patch subject and the change description. > > > > > > PC value is get from regs[15] in

Re: [RFC RESEND 0/3] Introduce cpufreq minimum load QoS

2020-05-27 Thread Valentin Schneider
On 27/05/20 14:11, Benjamin GAIGNARD wrote: > On 5/27/20 2:14 PM, Valentin Schneider wrote: >> On 27/05/20 12:17, Benjamin GAIGNARD wrote: >>> On 5/27/20 12:09 PM, Valentin Schneider wrote: Hi Benjamin, On 26/05/20 16:16, Benjamin Gaignard wrote: > A first round [1] of

Re: [PATCH] perf/x86/intel/uncore: Fix oops when counting IMC uncore events on some TGL

2020-05-27 Thread Liang, Kan
On 5/27/2020 10:51 AM, David Laight wrote: From: Liang, Kan Sent: 27 May 2020 15:47 On 5/27/2020 8:59 AM, David Laight wrote: From: kan.li...@linux.intel.com Sent: 27 May 2020 13:31 From: Kan Liang When counting IMC uncore events on some TGL machines, an oops will be triggered. [

Re: [PATCH v3 0/7] Statsfs: a new ram-based file system for Linux kernel statistics

2020-05-27 Thread Paolo Bonzini
On 27/05/20 15:33, Andrew Lunn wrote: >> I don't really know a lot about the networking subsystem, and as it was >> pointed out in another email on patch 7 by Andrew, networking needs to >> atomically gather and display statistics in order to make them consistent, >> and currently this is not

Re: [PATCH v2 09/14] device core: Add ability to handle multiple dma offsets

2020-05-27 Thread Nicolas Saenz Julienne
Hi Jim, one thing comes to mind, there is a small test suite in drivers/of/unittest.c (specifically of_unittest_pci_dma_ranges()) you could extend it to include your use cases. On Tue, 2020-05-26 at 15:12 -0400, Jim Quinlan wrote: > The new field in struct device 'dma_pfn_offset_map' is used to

Re: [PATCH] ASoC: img-spdif-in: Fix runtime PM imbalance on error

2020-05-27 Thread Mark Brown
On Wed, 27 May 2020 16:43:24 +0800, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > the call returns an error code. Thus a pairing decrement is needed > on the error handling path to keep the counter balanced. Applied to

Re: [PATCH] ASoC: img-spdif-out: Fix runtime PM imbalance on error

2020-05-27 Thread Mark Brown
On Wed, 27 May 2020 16:46:08 +0800, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > the call returns an error code. Thus a pairing decrement is needed > on the error handling path to keep the counter balanced. Applied to

Re: [PATCH 1/2] dt-bindings: sound: tlv320adcx140: Add GPI config property

2020-05-27 Thread Mark Brown
On Tue, 26 May 2020 15:09:16 -0500, Dan Murphy wrote: > Add an array property that configures the General Purpose Input (GPI) > register. The device has 4 GPI pins and each pin can be configured in 1 > of 7 different ways. Applied to

Re: [PATCH] ASoC: tlv320adcx140: Fix warnings when using W=1

2020-05-27 Thread Mark Brown
On Tue, 26 May 2020 12:52:47 -0500, Dan Murphy wrote: > Fix the warnings when using the W=1 compiler flag. > > sound/soc/codecs/tlv320adcx140.c: In function ‘adcx140_reset’: > sound/soc/codecs/tlv320adcx140.c:570:6: warning: variable ‘ret’ set but > not used [-Wunused-but-set-variable] >

Re: [PATCH -next] ASoC: mmp-sspa: Fix return value check in asoc_mmp_sspa_probe()

2020-05-27 Thread Mark Brown
On Wed, 27 May 2020 03:02:10 +, Wei Yongjun wrote: > In case of error, the function devm_ioremap() returns NULL pointer not > ERR_PTR(). The IS_ERR() test in the return value check should be > replaced with NULL test. Applied to

Re: [PATCH] ASoC: wm8962: Fix runtime PM imbalance on error

2020-05-27 Thread Mark Brown
On Wed, 27 May 2020 10:46:22 +0800, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > the call returns an error code. Thus a pairing decrement is needed > on the error handling path to keep the counter balanced. Applied to

Re: [RFC RESEND 0/3] Introduce cpufreq minimum load QoS

2020-05-27 Thread Benjamin GAIGNARD
On 5/27/20 2:48 PM, Benjamin GAIGNARD wrote: > > > On 5/27/20 2:22 PM, Vincent Guittot wrote: >> On Wed, 27 May 2020 at 13:17, Benjamin GAIGNARD >> wrote: >>> >>> >>> On 5/27/20 12:09 PM, Valentin Schneider wrote: Hi Benjamin, On 26/05/20 16:16, Benjamin Gaignard wrote: > A

Re: [PATCH v4 10/11] i2c: designware: Move reg-space remapping into a dedicated function

2020-05-27 Thread Serge Semin
On Wed, May 27, 2020 at 04:58:01PM +0300, Andy Shevchenko wrote: > On Wed, May 27, 2020 at 03:01:10PM +0300, Serge Semin wrote: > > This is a preparation patch before adding a quirk with custom registers > > map creation required for the Baikal-T1 System I2C support. > > Looks good. Though one

Re: [PATCH ghak124 v1] audit: log nftables configuration change events

2020-05-27 Thread Florian Westphal
Richard Guy Briggs wrote: > iptables, ip6tables, arptables and ebtables table registration, > replacement and unregistration configuration events are logged for the > native (legacy) iptables setsockopt api, but not for the > nftables netlink api which is used by the nft-variant of iptables in >

Re: [PATCH] drm: pl111: add CONFIG_VEXPRESS_CONFIG dependency

2020-05-27 Thread Sam Ravnborg
Hi Arnd. On Wed, May 27, 2020 at 03:31:42PM +0200, Arnd Bergmann wrote: > The vexpress_config code fails to link in some configurations: > > drivers/gpu/drm/pl111/pl111_versatile.o: in function `pl111_versatile_init': > (.text+0x1f0): undefined reference to `devm_regmap_init_vexpress_config' >

Re: [PATCH net-next v3 4/4] net: dp83869: Add RGMII internal delay configuration

2020-05-27 Thread Dan Murphy
Andrew On 5/27/20 8:12 AM, Andrew Lunn wrote: If the dt defines rgmii-rx/tx-id then these values are required not optional.  That was the discussion on the binding. How many times do i need to say it. They are optional. If not specified, default to 2ns. OK.  I guess then the DP83867 driver

Re: [PATCH] cpumask: guard cpumask_of_node() macro argument

2020-05-27 Thread Guenter Roeck
On Wed, May 27, 2020 at 03:46:08PM +0200, Arnd Bergmann wrote: > drivers/hwmon/amd_energy.c:195:15: error: invalid operands to binary > expression ('void' and 'int') > (channel - data->nr_cpus)); >

RE: [PATCH] perf/x86/intel/uncore: Fix oops when counting IMC uncore events on some TGL

2020-05-27 Thread David Laight
From: Liang, Kan > Sent: 27 May 2020 15:47 > On 5/27/2020 8:59 AM, David Laight wrote: > > From: kan.li...@linux.intel.com > >> Sent: 27 May 2020 13:31 > >> > >> From: Kan Liang > >> > >> When counting IMC uncore events on some TGL machines, an oops will be > >> triggered. > >>[ 393.101262]

Re: [PATCH -tip V6 0/6] kprobes: Fixes mutex, rcu-list warnings and cleanups

2020-05-27 Thread Masami Hiramatsu
(Oops, I missed Jiri in loop.) Hi Ingo, Could you take this series? These are not adding any feature, but fixing real bugs. Thank you, On Tue, 12 May 2020 17:02:22 +0900 Masami Hiramatsu wrote: > Hi Ingo, > > Here is the 6th version of the series for kprobes. The previous > version is here.

Re: [PATCH] perf/x86/intel/uncore: Fix oops when counting IMC uncore events on some TGL

2020-05-27 Thread Liang, Kan
On 5/27/2020 8:59 AM, David Laight wrote: From: kan.li...@linux.intel.com Sent: 27 May 2020 13:31 From: Kan Liang When counting IMC uncore events on some TGL machines, an oops will be triggered. [ 393.101262] BUG: unable to handle page fault for address: b45200e15858 [

Re: [PATCH v8 06/14] media: platform: Improve the implementation of the system PM ops

2020-05-27 Thread Tomasz Figa
On Wed, May 27, 2020 at 3:58 AM Xia Jiang wrote: > > On Thu, 2020-05-21 at 15:32 +, Tomasz Figa wrote: > > Hi Xia, > > > > On Fri, Apr 03, 2020 at 05:40:25PM +0800, Xia Jiang wrote: > > > Cancel reset hw operation in suspend and resume function because this > > > will be done in device_run().

drivers/tty/serial/ucc_uart.c:264:21: sparse: sparse: incorrect type in argument 1 (different address spaces)

2020-05-27 Thread kbuild test robot
date: 6 months ago config: arm64-randconfig-s031-20200527 (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.1-240-gf0fe1cd9-dirty git checkout 5a35435ef4e6e4bd2aabd6706b146b298a9cffe5 # save

[PATCH v1] Documentation: devres: add missing entry for devm_platform_get_and_ioremap_resource()

2020-05-27 Thread Dejin Zheng
The devm_platform_get_and_ioremap_resource() should be documented in devres.rst. Add the missing entry. Signed-off-by: Dejin Zheng --- Documentation/driver-api/driver-model/devres.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/driver-api/driver-model/devres.rst

Re: [PATCH] proc/base: Skip assignment to len when there is no error on d_path in do_proc_readlink.

2020-05-27 Thread Eric W. Biederman
Kaitao Cheng writes: > we don't need {len = PTR_ERR(pathname)} when IS_ERR(pathname) is false, > it's better to move it into if(IS_ERR(pathname)){}. Please look at the generated code. I believe you will find that your change will generate worse assembly. Eric > Signed-off-by: Kaitao Cheng

Re: [PATCH 1/2] ia64: Hide the archdata.iommu field behind generic IOMMU_API

2020-05-27 Thread Joerg Roedel
On Mon, May 18, 2020 at 02:08:54PM +0200, Krzysztof Kozlowski wrote: > There is a generic, kernel wide configuration symbol for enabling the > IOMMU specific bits: CONFIG_IOMMU_API. Implementations (including > INTEL_IOMMU driver) select it so use it here as well. > > This makes the conditional

Re: [PATCH 2/3] objtool: Move struct objtool_file into arch-independent header

2020-05-27 Thread Kamalesh Babulal
On 5/20/20 2:25 AM, Matt Helsley wrote: > The objtool_file structure describes the files objtool works on, > is used by the check subcommand, and the check.h header is included > by the orc subcommands so it's presently used by all subcommands. > > Since the structure will be useful in all

Re: [PATCH 3/3] objtool: Enable compilation of objtool for all architectures

2020-05-27 Thread Kamalesh Babulal
[...] > From: Matt Helsley > Subject: [PATCH] objtool: Enable compilation of objtool for all architectures > > Objtool currently only compiles for x86 architectures. This is > fine as it presently does not support tooling for other > architectures. However, we would like to be able to convert

Re: [PATCH 1/3] objtool: Exit successfully when requesting help

2020-05-27 Thread Kamalesh Babulal
On 5/20/20 2:25 AM, Matt Helsley wrote: > When the user requests help it's not an error so do not exit with > a non-zero exit code. This is not especially useful for a user but > any script that might wish to check that objtool --help is at least > available can't rely on the exit code to crudely

Re: [PATCH v3 05/10] media: i2c: imx290: Add configurable link frequency and pixel rate

2020-05-27 Thread kbuild test robot
-20200527 (attached as .config) compiler: microblaze-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All errors (new ones prefixed by >>, old ones prefixed by <<): microblaze-linux-ld: drivers/media/i2c/imx290.o:

Re: [PATCH v5 0/3] interconnect: Support Samsung Exynos use-case

2020-05-27 Thread Sylwester Nawrocki
Hi Georgi, On 27.05.2020 15:49, Georgi Djakov wrote: > Hi Sylwester, > > Thank you for re-sending these! > > On 5/21/20 15:28, Sylwester Nawrocki wrote: >> Hi All, >> >> This is a continuation of Artur's efforts to add interconnect and PM QoS >> support for Exynos SoCs. Previous version of the

[PATCH v4 2/2] clk: Allow COMPILE_TEST for subdir hisilicon in Makefile

2020-05-27 Thread Tiezhu Yang
If CONFIG_ARCH_HISI is not set but COMPILE_TEST is set, some files in the subdir hisilicon can not be built due to CONFIG_ARCH_HISI check in drivers/clk/Makefile. Since the related configs in drivers/clk/hisilicon/Kconfig depend on ARCH_HISI, so remove CONFIG_ARCH_HISI check for subdir hisilicon

Re: [PATCH v4 08/11] i2c: designware: Convert driver to using regmap API

2020-05-27 Thread Serge Semin
On Wed, May 27, 2020 at 04:50:23PM +0300, Andy Shevchenko wrote: > On Wed, May 27, 2020 at 03:01:08PM +0300, Serge Semin wrote: > > Seeing the DW I2C driver is using flags-based accessors with two > > conditional clauses it would be better to replace them with the regmap > > API IO methods and to

[PATCH v4 1/2] clk: hisilicon: Use correct return value about hisi_reset_init()

2020-05-27 Thread Tiezhu Yang
The return value about hisi_reset_init() is not correct, fix it. Fixes: e9a2310fb689 ("reset: hisilicon: fix potential NULL pointer dereference") Signed-off-by: Tiezhu Yang --- v2: - No changes, just add "Fixes:" tag v3: - Use ERR_CAST(rstc->membase) to fix the sparse warning v4: - No

Re: [PATCH 16/17] dt-bindings: watchdog: renesas,wdt: Document r8a7742 support

2020-05-27 Thread Rob Herring
On Wed, May 27, 2020 at 5:23 AM Lad, Prabhakar wrote: > > Hi Rob, > > On Wed, May 27, 2020 at 2:31 AM Rob Herring wrote: > > > > On Fri, May 15, 2020 at 04:08:56PM +0100, Lad Prabhakar wrote: > > > RZ/G1H (R8A7742) watchdog implementation is compatible with R-Car Gen2, > > > therefore add

Re: [PATCH] mtd: rawnand: arasan: select CONFIG_BCH

2020-05-27 Thread Arnd Bergmann
On Wed, May 27, 2020 at 3:53 PM Miquel Raynal wrote: > > Hi Arnd, > > Arnd Bergmann wrote on Wed, 27 May 2020 15:42:03 +0200: > > > Like several other nand flash drivers, this one requires the BCH > > library to be selected from Kconfig. > > Actually most of the time these drivers do not depend

Re: [PATCH v2 2/3] x86/boot/compressed: force hidden visibility for all symbol references

2020-05-27 Thread Arvind Sankar
On Sat, May 23, 2020 at 02:00:20PM +0200, Ard Biesheuvel wrote: > Eliminate all GOT entries in the decompressor binary, by forcing hidden > visibility for all symbol references, which informs the compiler that > such references will be resolved at link time without the need for > allocating GOT

[PATCH] IB/core: Use sizeof_field() helper

2020-05-27 Thread Gustavo A. R. Silva
Make use of the sizeof_field() helper instead of an open-coded version. Signed-off-by: Gustavo A. R. Silva --- drivers/infiniband/core/sa_query.c | 8 drivers/infiniband/core/uverbs_cmd.c | 2 +- drivers/infiniband/core/uverbs_ioctl.c | 2 +- 3 files changed, 6 insertions(+), 6

Re: [Nouveau] [PATCH] nouveau: add fbdev dependency

2020-05-27 Thread Arnd Bergmann
On Wed, May 27, 2020 at 4:05 PM Ilia Mirkin wrote: > > Isn't this already fixed by > > https://cgit.freedesktop.org/drm/drm/commit/?id=7dbbdd37f2ae7dd4175ba3f86f4335c463b18403 Ok, I see that fixes the link error, but I when I created my fix, that did not seem like the correct solution because it

Re: [PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier for userspace

2020-05-27 Thread John Garry
I also really dislike this. What's the preferred way to identify the SoC from userspace? /proc/cpuinfo? ;) The *SoC*! For an non-firmware specific case, I'd say soc_device should be. I'd guess ACPI systems don't use it and for them it's dmidecode typically. The other problem I have with

Re: [PATCH v25 01/16] dt: bindings: Add multicolor class dt bindings documention

2020-05-27 Thread Rob Herring
On Wed, May 27, 2020 at 7:39 AM Pavel Machek wrote: > > Hi! > > Thanks for reviews! > > > > +additionalProperties: false > > > +... > > > diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c > > > > This isn't a binding file. Belongs in another patch. > > These constants are directly

Re: [PATCH 2/2] kobject: send KOBJ_REMOVE uevent when the object is removed from sysfs

2020-05-27 Thread Rafael J. Wysocki
On Wednesday, May 27, 2020 11:01:16 AM CEST Rafael J. Wysocki wrote: > On Wednesday, May 27, 2020 10:34:51 AM CEST Rafael J. Wysocki wrote: > > On Wed, May 27, 2020 at 9:50 AM Heikki Krogerus > > wrote: > > > > > > On Tue, May 26, 2020 at 10:26:23AM +0200, Rafael J. Wysocki wrote: > > > > On Tue,

Re: [PATCH 1/1] soc: keembay: Add Keem Bay IMR driver

2020-05-27 Thread Arnd Bergmann
On Wed, May 27, 2020 at 3:31 PM Alessandrelli, Daniele wrote: > > > Alternatively, take that memory off the "memory available" maps, > > > and only re-add it once > > > it is usable. > > > > > > Anything else is dangerous. > > That sounds like an interesting solution, thanks! > > Do you know any

Re: [PATCH 4.19 49/81] powerpc: Remove STRICT_KERNEL_RWX incompatibility with RELOCATABLE

2020-05-27 Thread Greg Kroah-Hartman
On Wed, May 27, 2020 at 03:28:31PM +0200, Pavel Machek wrote: > On Tue 2020-05-26 20:53:24, Greg Kroah-Hartman wrote: > > From: Russell Currey > > > > [ Upstream commit c55d7b5e64265fdca45c85b639013e770bde2d0e ] > > > > I have tested this with the Radix MMU and everything seems to work, and > >

Hi

2020-05-27 Thread Jessica Vail
Hi dear, I'm Jessica Vail, from the United States,please i wish to have a communication with you. I wait for your answer. Jessica Vail.

Re: [PATCH 2/2] x86: Hide the archdata.iommu field behind generic IOMMU_API

2020-05-27 Thread Borislav Petkov
On Mon, May 18, 2020 at 02:08:55PM +0200, Krzysztof Kozlowski wrote: > There is a generic, kernel wide configuration symbol for enabling the > IOMMU specific bits: CONFIG_IOMMU_API. Implementations (including > INTEL_IOMMU and AMD_IOMMU driver) select it so use it here as well. > > This makes

Re: [PATCH 12/14] clk: sparx5: Add Sparx5 SoC DPLL clock driver

2020-05-27 Thread Lars Povlsen
Stephen Boyd writes: > Quoting Lars Povlsen (2020-05-13 05:55:30) >> diff --git a/drivers/clk/clk-sparx5.c b/drivers/clk/clk-sparx5.c >> new file mode 100644 >> index 0..685b3028a7071 >> --- /dev/null >> +++ b/drivers/clk/clk-sparx5.c >> @@ -0,0 +1,269 @@ >> +//

[PATCH 2/2] isolcpus: Affine unbound kernel threads to housekeeping cpus

2020-05-27 Thread Frederic Weisbecker
From: Marcelo Tosatti This is a kernel enhancement that configures the cpu affinity of kernel threads via kernel boot option nohz_full=. When this option is specified, the cpumask is immediately applied upon kthread launch. This does not affect kernel threads that specify cpu and node. This

Re: [PATCH v4 07/11] i2c: designware: Discard Cherry Trail model flag

2020-05-27 Thread Serge Semin
On Wed, May 27, 2020 at 04:43:39PM +0300, Andy Shevchenko wrote: > On Wed, May 27, 2020 at 03:01:07PM +0300, Serge Semin wrote: > > A PM workaround activated by the flag MODEL_CHERRYTRAIL has been removed > > since commit 9cbeeca05049 ("i2c: designware: Remove Cherry Trail PMIC I2C > > bus

[PATCH 0/2] sched/isolation: Isolate unbound kthreads

2020-05-27 Thread Frederic Weisbecker
Kthreads are harder to affine and isolate than user tasks. They can't be placed inside cgroups/cpusets and the affinity for any newly created kthread is always overriden from the inherited kthreadd's affinity to system wide. Take that into account for nohz_full.

[PATCH 1/2] kthread: Switch to cpu_possible_mask

2020-05-27 Thread Frederic Weisbecker
From: Marcelo Tosatti Next patch will switch unbound kernel threads mask to housekeeping_cpumask(), a subset of cpu_possible_mask. So in order to ease bisection, lets first switch kthreads default affinity from cpu_all_mask to cpu_possible_mask. It looks safe to do so as cpu_possible_mask seem

<    6   7   8   9   10   11   12   13   14   15   >