Re: Regression with PM / wakeup: Show wakeup sources stats in sysfs"

2020-05-29 Thread Florian Fainelli
On 5/29/20 3:28 PM, Tri Vo wrote: > On Fri, May 29, 2020 at 9:51 AM Rafael J. Wysocki > wrote: >> >> On 5/28/2020 10:46 PM, Florian Fainelli wrote: >>> Hi, >>> >>> Commit c8377adfa78103be5380200eb9dab764d7ca890e ("PM / wakeup: Show >>> wakeup sources stats in sysfs") is causing some of our tests

Re: general protection fault in inet_unhash

2020-05-29 Thread Andrii Nakryiko
On 5/29/20 10:32 AM, Eric Dumazet wrote: On 5/28/20 11:32 PM, Andrii Nakryiko wrote: On 5/28/20 11:23 PM, Dmitry Vyukov wrote: On Thu, May 28, 2020 at 11:01 PM 'Andrii Nakryiko' via syzkaller-bugs wrote: On 5/28/20 9:44 AM, syzbot wrote: Hello, syzbot found the following crash on: HEAD

Re: [PATCH v2] blkdev: Replace blksize_bits() with ilog2()

2020-05-29 Thread Jens Axboe
On 5/29/20 4:27 PM, Bart Van Assche wrote: > On 2020-05-29 13:27, Matthew Wilcox wrote: >> On Fri, May 29, 2020 at 10:11:00PM +0800, Kaitao Cheng wrote: >>> There is a function named ilog2() exist which can replace blksize. >>> The generated code will be shorter and more efficient on some >>>

Re: [PATCH V2] dt-bindings: regulator: Convert anatop regulator to json-schema

2020-05-29 Thread Mark Brown
On Fri, 29 May 2020 09:59:11 +0800, Anson Huang wrote: > Convert the anatop regulator binding to DT schema format using json-schema. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [1/1] dt-bindings: regulator: Convert anatop regulator to

Re: [PATCH v3 4/7] watchdog: dw_wdt: Support devices with non-fixed TOP values

2020-05-29 Thread Guenter Roeck
On Tue, May 26, 2020 at 06:41:20PM +0300, Serge Semin wrote: > In case if the DW Watchdog IP core is synthesised with > WDT_USE_FIX_TOP == false, the TOP interval indexes make the device > to load a custom periods to the counter. These periods are hardwired > at the IP synthesis stage and can be

Re: [PATCH v3 5/7] watchdog: dw_wdt: Support devices with asynch clocks

2020-05-29 Thread Guenter Roeck
On Tue, May 26, 2020 at 06:41:21PM +0300, Serge Semin wrote: > DW Watchdog IP core can be synthesised with asynchronous timer/APB > clocks support (WDT_ASYNC_CLK_MODE_ENABLE == 1). In this case > separate clock signals are supposed to be used to feed watchdog timer > and APB interface of the

[PATCH] perf libdw: Fix off-by 1 relative directory includes

2020-05-29 Thread Ian Rogers
This is currently working due to extra include paths in the build. Before: $ cd tools/perf/arch/arm64/util $ ls -la ../../util/unwind-libdw.h ls: cannot access '../../util/unwind-libdw.h': No such file or directory After: $ ls -la ../../../util/unwind-libdw.h -rw-r- 1 irogers irogers 553 Apr

Re: [PATCH v3 1/7] dt-bindings: watchdog: Convert DW WDT binding to DT schema

2020-05-29 Thread Guenter Roeck
On Tue, May 26, 2020 at 06:41:17PM +0300, Serge Semin wrote: > Modern device tree bindings are supposed to be created as YAML-files > in accordance with dt-schema. This commit replaces the DW Watchdog > legacy bare text bindings with YAML file. As before the binding states > that the corresponding

Re: [PATCH v3 2/7] dt-bindings: watchdog: dw-wdt: Support devices with asynch clocks

2020-05-29 Thread Guenter Roeck
On Tue, May 26, 2020 at 06:41:18PM +0300, Serge Semin wrote: > DW Watchdog IP core can be synthesised with asynchronous timer/APB > clocks support (WDT_ASYNC_CLK_MODE_ENABLE == 1). In this case > separate clock signals are supposed to be used to feed watchdog timer > and APB interface of the

Re: [PATCH v3 3/7] dt-bindings: watchdog: dw-wdt: Add watchdog TOPs array property

2020-05-29 Thread Guenter Roeck
On Tue, May 26, 2020 at 06:41:19PM +0300, Serge Semin wrote: > In case if DW Watchdog IP core is built with WDT_USE_FIX_TOP == false, > a custom timeout periods are used to preset the timer counter. In > this case that periods should be specified in a new "snps,watchdog-tops" > property of the DW

Re: linux-next: manual merge of the akpm-current tree with the mips tree

2020-05-29 Thread Stephen Rothwell
Hi Andrew, On Fri, 29 May 2020 14:15:46 -0700 Andrew Morton wrote: > > On Thu, 28 May 2020 19:29:43 +1000 Stephen Rothwell > wrote: > > > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@@ -2752,9 -2748,6 +2749,8 @@@ static vm_fault_t wp_page_copy(struct v > > /* Free the old

Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")

2020-05-29 Thread Matthew Garrett
On Sat, May 30, 2020 at 12:26:17AM +0200, Heiner Kallweit wrote: > Current situation means that PME is unusable on all systems where > pcie_aspm_support_enabled() returns false, what is basically every > system except EXPERT mode is enabled and CONFIG_PCIEASPM is set. > So we definitely need to

Re: [PATCH v3 6/7] watchdog: dw_wdt: Add pre-timeouts support

2020-05-29 Thread Guenter Roeck
On Tue, May 26, 2020 at 06:41:22PM +0300, Serge Semin wrote: > DW Watchdog can rise an interrupt in case if IRQ request mode is enabled > and timer reaches the zero value. In this case the IRQ lane is left > pending until either the next watchdog kick event (watchdog restart) or > until the

Re: [PATCH] ASoC: SOF: Intel: byt: fix unused-function warnings

2020-05-29 Thread Mark Brown
On Fri, May 29, 2020 at 10:04:17PM +0200, Arnd Bergmann wrote: > Several functions in this driver are only referenced for baytrail-class > configurations and building configurations with only merrifield enabled > causes a warning: Pierre fixed this earlier today. signature.asc Description: PGP

Re: [PATCH v3 7/7] watchdog: dw_wdt: Add DebugFS files

2020-05-29 Thread Guenter Roeck
On Tue, May 26, 2020 at 06:41:23PM +0300, Serge Semin wrote: > For the sake of the easier device-driver debug procedure, we added a > DebugFS file with the controller registers state. It's available only if > kernel is configured with DebugFS support. > > Signed-off-by: Serge Semin > Cc: Alexey

[PATCH v2 0/2] nvmem: add ONIE NVMEM cells provider

2020-05-29 Thread Vadym Kochan
This series adds cells provider for the ONIE TLV attributes which are stored on NVMEM device. It adds possibility to read the mac address (and other info) by other drivers. Driver needs to register NVMEM cells table for already registered NVMEM device, this requires additional change to the core

[PATCH v2 1/2] nvmem: core: allow to register cells for existing device

2020-05-29 Thread Vadym Kochan
Current implementation does not allow to register nvmem cells for existing device and requires that this will be done before device is registered. But there might a driver which provides only cells info which needs to be added for already registered nvmem device. Signed-off-by: Vadym Kochan ---

[PATCH v2 2/2] nvmem: add ONIE NVMEM cells support

2020-05-29 Thread Vadym Kochan
ONIE is a small operating system, pre-installed on bare metal network switches, that provides an environment for automated provisioning. This system requires that NVMEM (EEPROM) device holds various system information (mac address, platform name, etc) in a special TLV layout. The driver

Re: [PATCH v4 0/5] Remove AER HEST table parser

2020-05-29 Thread Bjorn Helgaas
On Tue, May 26, 2020 at 04:18:24PM -0700, sathyanarayanan.kuppusw...@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > Commit c100beb9ccfb ("PCI/AER: Use only _OSC to determine AER ownership") > removed HEST dependency in determining the AER ownership status. The > following patch

mmotm 2020-05-29-16-09 uploaded

2020-05-29 Thread akpm
The mm-of-the-moment snapshot 2020-05-29-16-09 has been uploaded to http://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: http://www.ozlabs.org/~akpm/mmotm/ This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week. You

[PATCH] checkpatch/coding-style: Allow 100 column lines

2020-05-29 Thread Joe Perches
Change the maximum allowed line length to 100 from 80. Miscellanea: o to avoid unnecessary whitespace changes in files, checkpatch will no longer emit a warning about line length when scanning files unless --strict is also used o Add a bit to coding-style about alignment to open parenthesis

Re: [PATCH v4 3/5] ACPI/PCI: Ignore _OSC negotiation result if pcie_ports_native is set.

2020-05-29 Thread Bjorn Helgaas
On Tue, May 26, 2020 at 04:18:27PM -0700, sathyanarayanan.kuppusw...@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > pcie_ports_native is set only if user requests native handling > of PCIe capabilities via pcie_port_setup command line option. > User input takes precedence over

Re: Regression with PM / wakeup: Show wakeup sources stats in sysfs"

2020-05-29 Thread Tri Vo
On Fri, May 29, 2020 at 3:37 PM Florian Fainelli wrote: > > On 5/29/20 3:28 PM, Tri Vo wrote: > > On Fri, May 29, 2020 at 9:51 AM Rafael J. Wysocki > > wrote: > >> > >> On 5/28/2020 10:46 PM, Florian Fainelli wrote: > >>> Hi, > >>> > >>> Commit c8377adfa78103be5380200eb9dab764d7ca890e ("PM /

Re: [PATCH v4 0/5] Remove AER HEST table parser

2020-05-29 Thread Kuppuswamy, Sathyanarayanan
On 5/29/20 4:09 PM, Bjorn Helgaas wrote: On Tue, May 26, 2020 at 04:18:24PM -0700, sathyanarayanan.kuppusw...@linux.intel.com wrote: From: Kuppuswamy Sathyanarayanan Commit c100beb9ccfb ("PCI/AER: Use only _OSC to determine AER ownership") removed HEST dependency in determining the AER

[PATCH blk-cgroup/for-5.8] blk-cgroup: show global disk stats in root cgroup io.stat

2020-05-29 Thread Boris Burkov
In order to improve consistency and usability in cgroup stat accounting, we would like to support the root cgroup's io.stat. Since the root cgroup has processes doing io even if the system has no explicitly created cgroups, we need to be careful to avoid overhead in that case. For that reason,

Re: [PATCH 1/2] objtool: Rename rela to reloc

2020-05-29 Thread Josh Poimboeuf
On Fri, May 29, 2020 at 02:01:13PM -0700, Matt Helsley wrote: > Before supporting additional relocation types rename the relevant > types and functions from "rela" to "reloc". This work be done with > the following regex: > > sed -i -e 's/struct rela/struct reloc/g' \ > -e

Re: [PATCH 0/6] nouveau/hmm: add support for mapping large pages

2020-05-29 Thread Jason Gunthorpe
On Tue, May 26, 2020 at 10:32:48AM -0700, Ralph Campbell wrote: > > On 5/25/20 6:41 AM, Jason Gunthorpe wrote: > > On Fri, May 08, 2020 at 12:20:03PM -0700, Ralph Campbell wrote: > > > hmm_range_fault() returns an array of page frame numbers and flags for > > > how the pages are mapped in the

[PATCHES] uaccess misc

2020-05-29 Thread Al Viro
The stuff that doesn't fit anywhere else. Hopefully saner marshalling for weird 7-argument syscalls (pselect6()), low-hanging fruit in several binfmt, unsafe_put_user-based x86 cp_stat64(), etc. - there's really no common topic here. BTW, after that series there's no more

[PATCH 3/9] binfmt_elf_fdpic: don't use __... uaccess primitives

2020-05-29 Thread Al Viro
From: Al Viro Signed-off-by: Al Viro --- fs/binfmt_elf_fdpic.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c index 240f3543..ab6fb117b33c 100644 --- a/fs/binfmt_elf_fdpic.c +++

[PATCH 1/9] pselect6() and friends: take handling the combined 6th/7th args into helper

2020-05-29 Thread Al Viro
From: Al Viro ... and use unsafe_get_user(), while we are at it. Signed-off-by: Al Viro --- fs/select.c | 112 ++-- 1 file changed, 64 insertions(+), 48 deletions(-) diff --git a/fs/select.c b/fs/select.c index

[PATCH 4/9] binfmt_flat: don't use __put_user()

2020-05-29 Thread Al Viro
From: Al Viro ... and check the return value Signed-off-by: Al Viro --- fs/binfmt_flat.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index 831a2b25ba79..7b663ed5247b 100644 --- a/fs/binfmt_flat.c +++

[PATCH 6/9] TEST_ACCESS_OK _never_ had been checked anywhere

2020-05-29 Thread Al Viro
From: Al Viro Once upon a time the predecessor of that thing (TEST_VERIFY_AREA) used to be. However, that had been gone for years now (and the patch that introduced TEST_ACCESS_OK has not touched any ifdefs - they got gradually removed later). Just bury it... Signed-off-by: Al Viro ---

[PATCH 2/9] binfmt_elf: don't bother with __{put,copy_to}_user()

2020-05-29 Thread Al Viro
From: Al Viro Signed-off-by: Al Viro --- fs/binfmt_elf.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 13f25e241ac4..782d218c3bb9 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -202,7 +202,7 @@

[PATCH 7/9] user_regset_copyout_zero(): use clear_user()

2020-05-29 Thread Al Viro
From: Al Viro that's the only caller of __clear_user() in generic code, and it's not hot enough to bother with skipping access_ok(). Signed-off-by: Al Viro --- include/linux/regset.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/regset.h

[PATCH v4 9/9] clocksource/drivers/timer-atmel-tcb: add sama5d2 support

2020-05-29 Thread Alexandre Belloni
The first divisor for the sama5d2 is actually the gclk selector. Because the currently remaining divisors are fitting the use case, currently ensure it is skipped. Signed-off-by: Alexandre Belloni --- drivers/clocksource/timer-atmel-tcb.c | 11 ++- 1 file changed, 10 insertions(+), 1

[PATCH 5/9] x86: switch cp_stat64() to unsafe_put_user()

2020-05-29 Thread Al Viro
From: Al Viro Signed-off-by: Al Viro --- arch/x86/kernel/sys_ia32.c | 40 ++-- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/arch/x86/kernel/sys_ia32.c b/arch/x86/kernel/sys_ia32.c index ab03fede1422..f8d65c99feb8 100644 ---

[PATCH v4 8/9] clocksource/drivers/timer-atmel-tcb: allow selecting first divider

2020-05-29 Thread Alexandre Belloni
The divider selection algorithm never allowed to get index 0. It was also continuing to look for dividers, trying to find the slow clock selection. This is not necessary anymore. Signed-off-by: Alexandre Belloni --- drivers/clocksource/timer-atmel-tcb.c | 6 ++ 1 file changed, 2

[PATCH 9/9] bpf: make bpf_check_uarg_tail_zero() use check_zeroed_user()

2020-05-29 Thread Al Viro
From: Al Viro ... rather than open-coding it, and badly, at that. Signed-off-by: Al Viro --- kernel/bpf/syscall.c | 25 ++--- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c index 64783da34202..41ba746ecbc2 100644

[PATCH v4 0/9] clocksource/drivers/timer-atmel-tcb: add sama5d2 support

2020-05-29 Thread Alexandre Belloni
Hello, This series mainly adds sama5d2 support where we need to avoid using clock index 0 because that clock is never enabled by the driver. There is also a rework of the 32khz clock handling so it is not used for clockevents on 32 bit counter because the increased rate improves the resolution

[PATCH v4 2/9] dt-bindings: microchip: atmel,at91rm9200-tcb: add sama5d2 compatible

2020-05-29 Thread Alexandre Belloni
The sama5d2 TC block TIMER_CLOCK1 is different from the at91sam9x5 one. Instead of being MCK / 2, it is the TCB GCLK. Signed-off-by: Alexandre Belloni Reviewed-by: Rob Herring --- Reviewed by tag taken from: https://lore.kernel.org/linux-arm-kernel/20200526225046.GA534667@bogus/

[PATCH 8/9] x86: kvm_hv_set_msr(): use __put_user() instead of 32bit __clear_user()

2020-05-29 Thread Al Viro
From: Al Viro Signed-off-by: Al Viro --- arch/x86/kvm/hyperv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c index bcefa9d4e57e..b85b211d4676 100644 --- a/arch/x86/kvm/hyperv.c +++ b/arch/x86/kvm/hyperv.c @@ -1129,7 +1129,7 @@

[PATCH v4 7/9] clocksource/drivers/timer-atmel-tcb: stop using the 32kHz for clockevents

2020-05-29 Thread Alexandre Belloni
Stop using the slow clock as the clock source for 32 bit counters because even at 10MHz, they are able to handle delays up to two minutes. This provides a way better resolution. Signed-off-by: Alexandre Belloni --- drivers/clocksource/timer-atmel-tcb.c | 61 ++- 1 file

[PATCH v4 5/9] clocksource/drivers/timer-atmel-tcb: rework 32khz clock selection

2020-05-29 Thread Alexandre Belloni
On all the supported SoCs, the slow clock is always ATMEL_TC_TIMER_CLOCK5, avoid looking it up and pass it directly to setup_clkevents. Signed-off-by: Alexandre Belloni --- drivers/clocksource/timer-atmel-tcb.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git

[PATCH v4 6/9] clocksource/drivers/timer-atmel-tcb: fill tcb_config

2020-05-29 Thread Alexandre Belloni
Use the tcb_config and struct atmel_tcb_config to get the timer counter width. This is necessary because atmel_tcb_config will be extended later on. Signed-off-by: Alexandre Belloni --- drivers/clocksource/timer-atmel-tcb.c | 18 +++--- 1 file changed, 15 insertions(+), 3

[PATCH v4 3/9] ARM: dts: at91: sama5d2: add TCB GCLK

2020-05-29 Thread Alexandre Belloni
The sama5d2 tcbs take an extra input clock, their gclk. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/sama5d2.dtsi | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi index

[PATCH v4 4/9] ARM: at91: add atmel tcb capabilities

2020-05-29 Thread Alexandre Belloni
From: Kamel Bouhara Some atmel socs have extra tcb capabilities that allow using a generic clock source or enabling a quadrature decoder. Signed-off-by: Kamel Bouhara Signed-off-by: Alexandre Belloni --- include/soc/at91/atmel_tcb.h | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [RFC][PATCH v3 1/5] sparc64: Fix asm/percpu.h build error

2020-05-29 Thread David Miller
From: Peter Zijlstra Date: Fri, 29 May 2020 23:35:51 +0200 > ../arch/sparc/include/asm/percpu_64.h:7:24: warning: call-clobbered register > used for global register variable > register unsigned long __local_per_cpu_offset asm("g5"); The "-ffixed-g5" option on the command line tells gcc that we

[PATCH v4 1/9] dt-bindings: atmel-tcb: convert bindings to json-schema

2020-05-29 Thread Alexandre Belloni
Convert Atmel Timer Counter Blocks bindings to DT schema format using json-schema. Also move it out of mfd as it is not and has never been related to mfd. Cc: Rob Herring Signed-off-by: Alexandre Belloni --- Changes in v4: - use oneOf to describe possible clock-names list

Re: [PATCH 1/2] dt-bindings: chrome: Add cros-ec-typec mux props

2020-05-29 Thread Prashant Malani
Hi Rob, Thanks for reviewing the patch! Kindly see inline: On Fri, May 29, 2020 at 2:55 PM Rob Herring wrote: > > > > " Reference to a DT node for the USB Type C Multiplexer controlling the > > > data lines routing for this connector. This switch is assumed registered > > > with the Type C

Re: drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:2019:1: warning: no previous prototype for 'gf100_gr_dtor'

2020-05-29 Thread Ben Skeggs
On Sat, May 30, 2020 at 6:04 AM kbuild test robot wrote: > > Hi Ben, > > FYI, the error/warning still remains. Thanks, I've got a patch in my tree. Ben. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 75caf310d16cc5e2f851c048cd597f5437013368 >

Re: drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: warning: no previous prototype for 'lsb_header_tail_dump'

2020-05-29 Thread Ben Skeggs
On Sat, May 30, 2020 at 7:00 AM kbuild test robot wrote: > > Hi Ben, > > FYI, the error/warning still remains. Thanks, I've got a patch in my tree. Ben. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 75caf310d16cc5e2f851c048cd597f5437013368 >

Re: linux-next: manual merge of the rcu tree with the tip tree

2020-05-29 Thread Stephen Rothwell
Hi Paul, On Fri, 29 May 2020 07:15:01 -0700 "Paul E. McKenney" wrote: > > Given that the merge window might be opening in a couple days, my thought > is to defer these -rcu commits to my v5.9 pile, and then I resolve this > conflict in the -rcu tree when v5.8-rc1 comes out. I just now adjusted

[PATCHES] uaccess hpsa

2020-05-29 Thread Al Viro
hpsa compat ioctl done (hopefully) saner. I really want to kill compat_alloc_user_space() off - it's always trouble and for a driver-private ioctls it's absolutely pointless. Note that this is only compile-tested - I don't have the hardware to test it on *or* userland to issue

[PATCH 2/4] hpsa: don't bother with vmalloc for BIG_IOCTL_Command_struct

2020-05-29 Thread Al Viro
From: Al Viro "BIG" in the name refers to the amount of data being transferred, _not_ the size of structure itself; it's 140 or 144 bytes (for 32bit and 64bit hosts resp.). IOCTL_Command_struct is 136 or 144 bytes large... No point whatsoever turning that into dynamic allocation, let alone

[PATCH 1/4] hpsa passthrough: lift {BIG_,}IOCTL_Command_struct copy{in,out} into hpsa_ioctl()

2020-05-29 Thread Al Viro
From: Al Viro Signed-off-by: Al Viro --- drivers/scsi/hpsa.c | 116 +--- 1 file changed, 56 insertions(+), 60 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 1e9302e99d05..3344a06c938e 100644 --- a/drivers/scsi/hpsa.c

[PATCH 3/4] hpsa: get rid of compat_alloc_user_space()

2020-05-29 Thread Al Viro
From: Al Viro no need for building a native struct on kernel stack, copying it to userland one, then calling hpsa_ioctl() which copies it back into _another_ instance of the same struct. Signed-off-by: Al Viro --- drivers/scsi/hpsa.c | 80 -

[PATCH 4/4] hpsa_ioctl(): tidy up a bit

2020-05-29 Thread Al Viro
From: Al Viro Signed-off-by: Al Viro --- drivers/scsi/hpsa.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index c7fbe56891ef..81d0414e2117 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -6577,14 +6577,11 @@

[PATCH 0/2] vhost, docs: convert to pin_user_pages(), new "case 5"

2020-05-29 Thread John Hubbard
Hi, It recently became clear to me that there are some get_user_pages*() callers that don't fit neatly into any of the four cases that are so far listed in pin_user_pages.rst. vhost.c is one of those. Add a Case 5 to the documentation, and refer to that when converting vhost.c. Thanks to Jan

[PATCH 2/2] vhost: convert get_user_pages() --> pin_user_pages()

2020-05-29 Thread John Hubbard
This code was using get_user_pages*(), in approximately a "Case 5" scenario (accessing the data within a page), using the categorization from [1]. That means that it's time to convert the get_user_pages*() + put_page() calls to pin_user_pages*() + unpin_user_pages() calls. There is some helpful

[PATCH 1/2] docs: mm/gup: pin_user_pages.rst: add a "case 5"

2020-05-29 Thread John Hubbard
There are four cases listed in pin_user_pages.rst. These are intended to help developers figure out whether to use get_user_pages*(), or pin_user_pages*(). However, the four cases do not cover all the situations. For example, drivers/vhost/vhost.c has a "pin, write to page, set page dirty, unpin"

Re: [PATCH v2] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN

2020-05-29 Thread Vijay Khemka
On 5/29/20, 11:56 AM, "Guenter Roeck" wrote: On 5/29/20 10:57 AM, Vijay Khemka wrote: > > > On 5/29/20, 5:47 AM, "Manikandan Elumalai" wrote: > > The adm1278 temperature sysfs attribute need it for one of the openbmc platform . > This functionality

Re: [PATCH] HID: usbhid: do not sleep when opening device

2020-05-29 Thread Nicolas Boichat
On Sat, May 30, 2020 at 3:59 AM Dmitry Torokhov wrote: > > usbhid tries to give the device 50 milliseconds to drain its queues > when opening the device, but does it naively by simply sleeping in open > handler, which slows down device probing (and thus may affect overall > boot time). > >

Re: [PATCH 8/9] x86: kvm_hv_set_msr(): use __put_user() instead of 32bit __clear_user()

2020-05-29 Thread Linus Torvalds
On Fri, May 29, 2020 at 4:27 PM Al Viro wrote: > a/arch/x86/kvm/hyperv.c > - if (__clear_user((void __user *)addr, sizeof(u32))) > + if (__put_user(0, (u32 __user *)addr)) I'm not doubting that this is a correct transformation and an improvement, but why is it using

Re: [PATCHES] uaccess misc

2020-05-29 Thread Linus Torvalds
On Fri, May 29, 2020 at 4:26 PM Al Viro wrote: > > The stuff that doesn't fit anywhere else. Hopefully > saner marshalling for weird 7-argument syscalls (pselect6()), That looked fine to me, btw. Looks like an improvement even outside the "avoid __get_user()" and double STAC/CLAC issue. >

Re: [PATCHES] uaccess misc

2020-05-29 Thread Linus Torvalds
On Fri, May 29, 2020 at 4:54 PM Linus Torvalds wrote: > > My only complaint was that kvm thing that I think should have gone even > further. Oh... And the cc list looks a bit odd. You cc'd fsdevel, but none of the patches were really to any filesystem code (ok, the pselect and binfmt thing is

Re: [PATCH] NFC: st21nfca: add missed kfree_skb() in an error path

2020-05-29 Thread David Miller
From: Chuhong Yuan Date: Thu, 28 May 2020 18:20:37 +0800 > st21nfca_tm_send_atr_res() misses to call kfree_skb() in an error path. > Add the missed function call to fix it. > > Fixes: 1892bf844ea0 ("NFC: st21nfca: Adding P2P support to st21nfca in > Initiator & Target mode") > Signed-off-by:

Re: [PATCH net-next v2] dt-bindings: net: rename the bindings document for MediaTek STAR EMAC

2020-05-29 Thread David Miller
From: Bartosz Golaszewski Date: Thu, 28 May 2020 15:59:02 +0200 > From: Bartosz Golaszewski > > The driver itself was renamed before getting merged into mainline, but > the binding document kept the old name. This makes both names consistent. > > Signed-off-by: Bartosz Golaszewski > --- > v1

Re: KASAN: use-after-free Read in ib_uverbs_remove_one

2020-05-29 Thread Jason Gunthorpe
On Thu, May 28, 2020 at 07:33:16AM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:c11d28ab Add linux-next specific files for 20200522 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=12fc3e7210 > kernel

Re: [PATCH][net-next] nexthop: fix incorrect allocation failure on nhg->spare

2020-05-29 Thread David Miller
From: Colin King Date: Thu, 28 May 2020 15:51:14 +0100 > @@ -1185,7 +1185,7 @@ static struct nexthop *nexthop_create_group(struct net > *net, > > /* spare group used for removals */ > nhg->spare = nexthop_grp_alloc(num_nh); I don't even see this line in the current net-next tree

Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-05-29 Thread David Miller
Please remove all of the __packed attributes. I looked at your data structures and all of them use fixed sized types and are multiples of 4 so the __packed attribute is completely unnecessary. The alignment attribute is also unnecessary so please remove that too.

Re: [PATCH v10 1/2] dt-bindings: mtd: Add Nand Flash Controller support for Intel LGM SoC

2020-05-29 Thread Ramuthevar, Vadivel MuruganX
Hi Rob, On 30/5/2020 3:31 am, Rob Herring wrote: On Thu, May 28, 2020 at 11:39:28PM +0800, Ramuthevar,Vadivel MuruganX wrote: From: Ramuthevar Vadivel Murugan Add YAML file for dt-bindings to support NAND Flash Controller on Intel's Lightning Mountain SoC. Signed-off-by: Ramuthevar Vadivel

Re: [PATCH v7 0/3] perf arm-spe: Add support for synthetic events

2020-05-29 Thread Leo Yan
On Fri, May 29, 2020 at 01:18:30PM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, May 29, 2020 at 11:28:01PM +0800, Leo Yan escreveu: > > Hi James, > > > > On Fri, May 29, 2020 at 03:58:23PM +0100, James Clark wrote: > > > Hi Will and Leo, > > > > > > I've tested this on an Arm N1 machine and

[PATCH] lib: make a test module with get_count_order/long

2020-05-29 Thread Wei Yang
A test module to make sure get_count_order/long returns the correct result. Signed-off-by: Wei Yang --- lib/Kconfig.debug | 13 ++ lib/Makefile | 2 + lib/test_getorder.c| 64 ++

Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-05-29 Thread Vadym Kochan
Hi David, On Fri, May 29, 2020 at 05:18:39PM -0700, David Miller wrote: > > Please remove all of the __packed attributes. > > I looked at your data structures and all of them use fixed sized types > and are multiples of 4 so the __packed attribute is completely > unnecessary. > > The alignment

Re: [PATCH] HID: usbhid: do not sleep when opening device

2020-05-29 Thread Guenter Roeck
On Fri, May 29, 2020 at 4:50 PM Nicolas Boichat wrote: > > On Sat, May 30, 2020 at 3:59 AM Dmitry Torokhov > wrote: > > > > usbhid tries to give the device 50 milliseconds to drain its queues > > when opening the device, but does it naively by simply sleeping in open > > handler, which slows

[PATCH v11 0/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC

2020-05-29 Thread Ramuthevar,Vadivel MuruganX
This patch adds the new IP of Nand Flash Controller(NFC) support on Intel's Lightning Mountain(LGM) SoC. DMA is used for burst data transfer operation, also DMA HW supports aligned 32bit memory address and aligned data access by default. DMA burst of 8 supported. Data register used to support the

[PATCH v11 1/2] dt-bindings: mtd: Add Nand Flash Controller support for Intel LGM SoC

2020-05-29 Thread Ramuthevar,Vadivel MuruganX
From: Ramuthevar Vadivel Murugan Add YAML file for dt-bindings to support NAND Flash Controller on Intel's Lightning Mountain SoC. Signed-off-by: Ramuthevar Vadivel Murugan --- .../devicetree/bindings/mtd/intel,lgm-nand.yaml| 99 ++ 1 file changed, 99 insertions(+)

Re: [PATCH 1/2] objtool: Rename rela to reloc

2020-05-29 Thread Matt Helsley
On Fri, May 29, 2020 at 06:22:00PM -0500, Josh Poimboeuf wrote: > On Fri, May 29, 2020 at 02:01:13PM -0700, Matt Helsley wrote: > > Before supporting additional relocation types rename the relevant > > types and functions from "rela" to "reloc". This work be done with > > the following regex: > >

[PATCH v11 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC

2020-05-29 Thread Ramuthevar,Vadivel MuruganX
From: Ramuthevar Vadivel Murugan This patch adds the new IP of Nand Flash Controller(NFC) support on Intel's Lightning Mountain(LGM) SoC. DMA is used for burst data transfer operation, also DMA HW supports aligned 32bit memory address and aligned data access by default. DMA burst of 8

Re: [PATCH v2 0/2] fix missing handling of __user in nommu's uaccess()

2020-05-29 Thread Greg Ungerer
Hi Luc, On 30/5/20 5:02 am, Luc Van Oostenryck wrote: I received a bug report for an unrelated patch when used with m68k-nommu. It appears that the origin of the problem is that __get_user() and __put_user() doesn't handle correctly __user. These 2 patches fix this. Note: this is only minimaly

RE: [PATCH] usb: gadget: f_acm: don't disable disabled EP

2020-05-29 Thread Peter Chen
> > > @@ -425,9 +425,11 @@ static int acm_set_alt(struct usb_function *f, > > > unsigned > intf, unsigned alt) > > > /* we know alt == 0, so this is an activation or a reset */ > > > > > > if (intf == acm->ctrl_id) { > > > - dev_vdbg(>gadget->dev, > > > -

Re: [PATCH] HID: usbhid: do not sleep when opening device

2020-05-29 Thread Dmitry Torokhov
On Fri, May 29, 2020 at 05:48:26PM -0700, Guenter Roeck wrote: > On Fri, May 29, 2020 at 4:50 PM Nicolas Boichat wrote: > > > > On Sat, May 30, 2020 at 3:59 AM Dmitry Torokhov > > wrote: > > > > > > usbhid tries to give the device 50 milliseconds to drain its queues > > > when opening the

[PATCH net-next 0/6] net: hns3: adds some cleanups for -next

2020-05-29 Thread Huazhong Tan
There are some cleanups for the HNS3 ethernet driver, fix an incorrect print format, an incorrect comment and some coding style issues, also remove some unused codes and macros. Huazhong Tan (6): net: hns3: fix a print format issue in hclge_mac_mdio_config() net: hns3: remove an unused macro

[PATCH net-next 1/6] net: hns3: fix a print format issue in hclge_mac_mdio_config()

2020-05-29 Thread Huazhong Tan
Use %d to print int variable 'ret' in hclge_mac_mdio_config(). Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c

[PATCH net-next 5/6] net: hns3: fix two coding style issues in hclgevf_main.c

2020-05-29 Thread Huazhong Tan
Remove a redundant blank line in hclgevf_cmd_set_promisc_mode(), and fix a reverse xmas tree coding style issue in hclgevf_set_rss_tc_mode(). Reported-by: Jian Shen Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 3 +-- 1 file changed, 1

[PATCH net-next 2/6] net: hns3: remove an unused macro hclge_is_csq

2020-05-29 Thread Huazhong Tan
Macro hclge_is_csq defined in hcgle_cmd.c has not been used, so remove it. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c

[PATCH net-next 3/6] net: hns3: remove two unused macros in hclgevf_cmd.c

2020-05-29 Thread Huazhong Tan
Macro hclgevf_ring_to_dma_dir and hclgevf_is_csq defined in hclgevf_cmd.c, but not used, so remove them. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH net-next 6/6] net: hns3: remove some unused codes in hns3_nic_set_features()

2020-05-29 Thread Huazhong Tan
NETIF_F_HW_VLAN_CTAG_FILTER is not set in netdev->hw_feature for the HNS3 driver, so the handler of NETIF_F_HW_VLAN_CTAG_FILTER in hns3_nic_set_features() won't be called, remove it. Reported-by: Jian Shen Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 6

[PATCH net-next 4/6] net: hns3: fix an incorrect comment for num_tqps in struct hclgevf_dev

2020-05-29 Thread Huazhong Tan
struct hclgevf_dev stands for VF device, its field num_tqps indicates the number of VF's task queue pairs, so the comment is incorrect, replace 'PF' with 'VF'. Reported-by: Jian Shen Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h | 2 +- 1 file

Re: [PATCH v2 2/3] seccomp: Introduce addfd ioctl to seccomp user notifier

2020-05-29 Thread Sargun Dhillon
On Fri, May 29, 2020 at 12:31:37AM -0700, Kees Cook wrote: > On Thu, May 28, 2020 at 04:08:57AM -0700, Sargun Dhillon wrote: > > This adds a seccomp notifier ioctl which allows for the listener to "add" > > file descriptors to a process which originated a seccomp user > > notification. This allows

RE: [PATCH v2] virtio_vsock: Fix race condition in virtio_transport_recv_pkt

2020-05-29 Thread Justin He
Hi Stefano > -Original Message- > From: Stefano Garzarella > Sent: Saturday, May 30, 2020 12:34 AM > To: Justin He > Cc: Stefan Hajnoczi ; David S. Miller > ; Jakub Kicinski ; > k...@vger.kernel.org; virtualizat...@lists.linux-foundation.org; > net...@vger.kernel.org;

Darowizna

2020-05-29 Thread SHANE MISSLER
Nazywam się SHANE MISSLER, wygrałem loterię o wartości 451 milionów dolarów i postanowiłem przekazać tobie kwotę 5500 000,00 €. Przekazuję wam tę darowiznę za miłość, którą mam dla ludzkości i za pomoc osobom dotkniętym pandemią w waszym kraju.Skontaktuj się ze mną, aby odebrać tę

Re: [PATCH 1/2] rtc: snvs: Make SNVS clock always prepared

2020-05-29 Thread Alexandre Belloni
On Fri, 22 May 2020 10:19:55 +0800, Anson Huang wrote: > In IRQ handler, ONLY clock enable/disable is called due to > clock prepare can NOT be called in interrupt context, but > clock enable/disable will return failure if prepare count > is 0, to fix this issue, just make SNVS clock always

Re: [PATCH] HID: usbhid: do not sleep when opening device

2020-05-29 Thread Guenter Roeck
On Fri, May 29, 2020 at 6:09 PM Dmitry Torokhov wrote: > > On Fri, May 29, 2020 at 05:48:26PM -0700, Guenter Roeck wrote: > > On Fri, May 29, 2020 at 4:50 PM Nicolas Boichat > > wrote: > > > > > > On Sat, May 30, 2020 at 3:59 AM Dmitry Torokhov > > > wrote: > > > > > > > > usbhid tries to give

Re: 28307d938f ("percpu: make pcpu_alloc() aware of current gfp .."): BUG: kernel reboot-without-warning in boot stage

2020-05-29 Thread Philip Li
On Fri, May 29, 2020 at 01:32:28PM +0100, Filipe Manana wrote: > > > On 29/05/20 08:16, kernel test robot wrote: > > Greetings, > > > > 0day kernel testing robot got the below dmesg and the first bad commit is > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >

Re: [PATCH net-next v2] hinic: add set_channels ethtool_ops support

2020-05-29 Thread luobin (L)
On 2020/5/30 1:44, Jakub Kicinski wrote: On Thu, 28 May 2020 18:36:33 + Luo bin wrote: add support to change TX/RX queue number with ethtool -L Signed-off-by: Luo bin Luo bin, your patches continue to come with Date: header being in the past. Also suspiciously no time zone offset. Can

Re: [PATCH] Revert "f2fs: fix quota_sync failure due to f2fs_lock_op"

2020-05-29 Thread Chao Yu
On 2020/5/30 6:34, Jaegeuk Kim wrote: > On 05/29, Chao Yu wrote: >> Under heavy fsstress, we may triggle panic while issuing discard, >> because __check_sit_bitmap() detects that discard command may earse >> valid data blocks, the root cause is as below race stack described, >> since we removed

Re: [PATCH 1/2] rtc: goldfish: Use correct return value for goldfish_rtc_probe()

2020-05-29 Thread Alexandre Belloni
On Mon, 25 May 2020 09:39:47 +0800, Tiezhu Yang wrote: > When call function devm_platform_ioremap_resource(), we should use IS_ERR() > to check the return value and return PTR_ERR() if failed. Applied, thanks! [1/2] rtc: goldfish: Use correct return value for goldfish_rtc_probe() commit:

Re: [PATCH] HID: usbhid: do not sleep when opening device

2020-05-29 Thread Dmitry Torokhov
On Fri, May 29, 2020 at 06:22:49PM -0700, Guenter Roeck wrote: > On Fri, May 29, 2020 at 6:09 PM Dmitry Torokhov > wrote: > > > > On Fri, May 29, 2020 at 05:48:26PM -0700, Guenter Roeck wrote: > > > On Fri, May 29, 2020 at 4:50 PM Nicolas Boichat > > > wrote: > > > > > > > > On Sat, May 30,

[PATCH v3] virtio_vsock: Fix race condition in virtio_transport_recv_pkt

2020-05-29 Thread Jia He
When client on the host tries to connect(SOCK_STREAM, O_NONBLOCK) to the server on the guest, there will be a panic on a ThunderX2 (armv8a server): [ 463.718844] Unable to handle kernel NULL pointer dereference at virtual address [ 463.718848] Mem abort info: [ 463.718849]

<    8   9   10   11   12   13   14   >