RE: [PATCH] vdpa/mlx5: Fix erroneous null pointer checks

2020-08-09 Thread Eli Cohen
After all this patch is not fixing it all. If we get to default of the switch statement we will free invalid pointer so removing ack-ed by me. The previous patch by Colin King fixes it. -Original Message- From: Eli Cohen Sent: Sunday, August 9, 2020 8:53 AM To: Alex Dewar Cc:

Re: [PATCH][next] vdpa/mlx5: fix memory allocation failure checks

2020-08-09 Thread Eli Cohen
On Thu, Aug 06, 2020 at 05:08:28PM +0100, Colin King wrote: Acked by: Eli Cohen > From: Colin Ian King > > The memory allocation failure checking for in and out is currently > checking if the pointers are valid rather than the contents of what > they point to. Hence the null check on failed

[PATCH] dma-buf.rst: repair length of title underline

2020-08-09 Thread Lukas Bulwahn
With commit 72b6ede73623 ("dma-buf.rst: Document why indefinite fences are a bad idea"), document generation warns: Documentation/driver-api/dma-buf.rst:182: \ WARNING: Title underline too short. Repair length of title underline to remove warning. Fixes: 72b6ede73623 ("dma-buf.rst: Document

RE: [PATCH] vdpa/mlx5: Fix pointer math in mlx5_vdpa_get_config()

2020-08-09 Thread Eli Cohen
Acked-by: Eli Cohen BTW, vdpa_sim has the same bug. -Original Message- From: Dan Carpenter Sent: Saturday, August 8, 2020 12:33 PM To: Michael S. Tsirkin ; Eli Cohen Cc: Jason Wang ; Parav Pandit ; virtualizat...@lists.linux-foundation.org; linux-kernel@vger.kernel.org;

Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get()

2020-08-09 Thread Leon Romanovsky
On Sat, Aug 08, 2020 at 03:57:33PM -0700, Jack Leadford wrote: > Hello! > > Thanks to Jason for getting this conversation back on track. > > Yes: in general, {} or a partial initializer /will/ zero padding bits. > > However, there is a bug in some versions of GCC where {} will /not/ zero > padding

Re: [PATCH] fix arm64 build with lack of __cpu_logical_map exported

2020-08-09 Thread Greg Kroah-Hartman
On Sat, Aug 08, 2020 at 07:29:08PM +0100, Catalin Marinas wrote: > On Sat, Aug 08, 2020 at 05:29:58PM +0200, Greg Kroah-Hartman wrote: > > On Sat, Aug 08, 2020 at 04:05:00PM +0100, Catalin Marinas wrote: > > > On Sat, Aug 08, 2020 at 02:42:42PM +0200, Greg Kroah-Hartman wrote: > > > > diff --git

Re: realpath "No such file or directory" warnings when building

2020-08-09 Thread Greg Kroah-Hartman
On Sat, Aug 08, 2020 at 01:28:22PM -0700, Rustam Kovhaev wrote: > tags from KBUILD_OUTPUT directory > Reply-To: > > running 'make ARCH=x86_64 COMPILED_SOURCE=1 cscope tags' in > KBUILD_OUTPUT directory produces lots of "No such file or directory" > warnings from realpath > > it seems like

[PATCH] watchdog: pcwd_usb: Avoid GFP_ATOMIC where it is not needed

2020-08-09 Thread Christophe JAILLET
There is no need to use GFP_ATOMIC here. It is a probe function, no spinlock is taken and GFP_KERNEL is used just before and just after this 'usb_alloc_coherent()' call. Signed-off-by: Christophe JAILLET --- drivers/watchdog/pcwd_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH 1/2] arm: dts: mt7623: move more display-related nodes to mt7623n.dtsi

2020-08-09 Thread Frank Wunderlich
Am 9. August 2020 02:16:59 MESZ schrieb Chun-Kuang Hu : > >I would like to put all device in mt7623.dtsi with some device's >status is "disabled" and change its status in platform dtsi. >I would like to see all device in mt7623.dtsi because of its name. If >you move some device to platform

[PATCH 0/4] Infiniband Subsystem: Remove pci-dma-compat wrapper APIs.

2020-08-09 Thread Suraj Upadhyay
Hii Developers, This patch series will replace all the legacy pci-dma-compat wrappers with the dma-mapping APIs directly in the INFINIBAND Subsystem. This task is done through a coccinelle script which is described in each commit message. The changes are compile tested. Thanks, Suraj

[PATCH] drivers: bluetooth: btintel.c: fixed format issue.

2020-08-09 Thread YourName
From: argoz1701 Fixed a coding style issue. Signed-off-by: Daniel West --- drivers/bluetooth/btintel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c index 5fa5be3c5598..d0512506fa05 100644 ---

[PATCH 1/4] IB/hfi1: Remove pci-dma-compat wrapper APIs

2020-08-09 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested. -

[PATCH] usb: gadget: tegra-xudc: Avoid GFP_ATOMIC where it is not needed

2020-08-09 Thread Christophe JAILLET
There is no need to use GFP_ATOMIC here. It is a probe function, no spinlock is taken. Signed-off-by: Christophe JAILLET --- drivers/usb/gadget/udc/tegra-xudc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/tegra-xudc.c

[PATCH 2/4] IB/mthca: Remove pci-dma-compat wrapper APIs

2020-08-09 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested. -

[PATCH 3/4] RDMA/qib: Remove pci-dma-compat wrapper APIs

2020-08-09 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested. -

[PATCH 4/4] RDMA/pvrdma: Remove pci-dma-compat wrapper APIs

2020-08-09 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested. -

Re: drivers/crypto/sa2ul.c:1349:33: warning: cast from pointer to integer of different size

2020-08-09 Thread Geert Uytterhoeven
/sha512 support > date: 2 weeks ago > config: m68k-randconfig-r002-20200809 (attached as .config) > compiler: m68k-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O > ~/bin

[PATCH 5/4] RDMA/efa : Remove pci-dma-compat wrapper APIs

2020-08-09 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested. -

[PATCH] iio: documentation: light: Add as73211 sysfs documentation

2020-08-09 Thread Christian Eggers
The driver for the as73211 light sensor provides the following not yet documented sysfs entries: - in_intensity_(x|y|z)_raw - in_intensity_(x|y|z)_scale - in_intensity_sampling_frequency(_available) - in_intensity_hardwaregain(_available) - in_intensity_integration_time Signed-off-by: Christian

drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device_queue_manager.c:172:15: sparse: sparse: incorrect type in initializer (different address spaces)

2020-08-09 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 06a81c1c7db9bd5de0bd38cd5acc44bb22b99150 commit: 9555152beb1143c85c03f9b9de59863cbbe89f4b Merge tag 'amd-drm-next-5.9-2020-07-01' of git://people.freedesktop.org/~agd5f/linux into drm-next date: 5 weeks

[PATCH v3 1/2] x86/cpufeatures: Enumerate TSX suspend load address tracking instructions

2020-08-09 Thread Cathy Zhang
From: Kyung Min Park Intel TSX suspend load tracking instructions aim to give a way to choose which memory accesses do not need to be tracked in the TSX read set. Add TSX suspend load tracking CPUID feature flag TSXLDTRK for enumeration. A processor supports Intel TSX suspend load address

[PATCH v3 0/2] Expose new features for Intel processor

2020-08-09 Thread Cathy Zhang
This patchset is to expose two new features, SERIALIZE and TSX suspend load tracking to KVM CPUID for processors which support them. KVM reports this information and guest can make use of them finally. Detailed information on the instructions and CPUID feature flags can be found in the latest

[PATCH v3 2/2] x86/kvm: Expose new features for supported cpuid

2020-08-09 Thread Cathy Zhang
Expose the SERIALIZE and TSX Suspend Load Address Tracking features in KVM CPUID, so when running on processors which support them, KVM could pass this information to guests and they can make use of these features accordingly. SERIALIZE is a faster serializing instruction which does not modify

fs/zonefs/super.c:1110:6: warning: Variable 'ret' is reassigned a value before the old one has been used.

2020-08-09 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 06a81c1c7db9bd5de0bd38cd5acc44bb22b99150 commit: 8dcc1a9d90c10fa4143e5c17821082e5e60e46a1 fs: New zonefs file system date: 6 months ago compiler: alpha-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly

Re: [PATCH 5/4] RDMA/efa : Remove pci-dma-compat wrapper APIs

2020-08-09 Thread Joe Perches
On Sun, 2020-08-09 at 13:15 +0530, Suraj Upadhyay wrote: > The legacy API wrappers in include/linux/pci-dma-compat.h > should go away as it creates unnecessary midlayering > for include/linux/dma-mapping.h APIs. > > Instead use dma-mapping.h APIs directly. > > The patch has been generated with

Re: linux-next: build failure after merge of the thunderbolt tree

2020-08-09 Thread Stephen Rothwell
Hi Linus, On Tue, 30 Jun 2020 16:03:46 +1000 Stephen Rothwell wrote: > > After merging the thunderbolt tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > > Caused by commit > > 54509f5005ca ("thunderbolt: Add KUnit tests for path walking") > > interacting with

Re: [PATCH 0/4] Infiniband Subsystem: Remove pci-dma-compat wrapper APIs.

2020-08-09 Thread Gal Pressman
On 09/08/2020 10:24, Suraj Upadhyay wrote: > Hii Developers, > > This patch series will replace all the legacy pci-dma-compat wrappers > with the dma-mapping APIs directly in the INFINIBAND Subsystem. > > This task is done through a coccinelle script which is described in each > commit >

Re: [PATCH v2 5/6] openrisc: signal: Fix sparse address space warnings

2020-08-09 Thread Stafford Horne
On Sun, Aug 09, 2020 at 01:08:42AM +0200, Luc Van Oostenryck wrote: > On Sun, Aug 09, 2020 at 07:48:22AM +0900, Stafford Horne wrote: > > On Thu, Aug 06, 2020 at 09:04:49PM +0200, Luc Van Oostenryck wrote: > > > On Thu, Aug 06, 2020 at 06:07:24AM +0900, Stafford Horne wrote: > > > > --- > > > >

Re: [PATCH 0/4] Infiniband Subsystem: Remove pci-dma-compat wrapper APIs.

2020-08-09 Thread Suraj Upadhyay
On Sun, Aug 09, 2020 at 11:35:51AM +0300, Gal Pressman wrote: > On 09/08/2020 10:24, Suraj Upadhyay wrote: > > Hii Developers, > > > > This patch series will replace all the legacy pci-dma-compat wrappers > > with the dma-mapping APIs directly in the INFINIBAND Subsystem. > > > > This task

Re: [PATCH] arch/arm: use simple i2c probe function

2020-08-09 Thread Krzysztof Kozlowski
On Fri, Aug 07, 2020 at 05:31:00PM +0200, Stephen Kitt wrote: > The i2c probe functions here don't use the id information provided in > their second argument, so the single-parameter i2c probe function > ("probe_new") can be used instead. > > This avoids scanning the identifier tables during

Re: linux-next: manual merge of the f2fs tree with the fscrypt tree

2020-08-09 Thread Stephen Rothwell
Hi all, On Wed, 8 Jul 2020 10:38:58 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the f2fs tree got a conflict in: > > Documentation/filesystems/f2fs.rst > > between commit: > > 38dff4e50c12 ("f2fs: add inline encryption support") > > from the fscrypt tree and commit: >

Re: [PATCH v2 09/41] usb: gadget: s3c-hsudc: remove platform header dependency

2020-08-09 Thread Krzysztof Kozlowski
On Fri, Aug 07, 2020 at 07:42:30PM +0200, Arnd Bergmann wrote: > On Fri, Aug 7, 2020 at 3:59 PM Felipe Balbi wrote: > > Krzysztof Kozlowski writes: > > > > +#include > > > + > > > #define S3C2443_CLKREG(x)((x) + S3C24XX_VA_CLKPWR) > > > > > > #define S3C2443_PLLCON_MDIVSHIFT

Re: [PATCH net] drivers/net/wan/lapbether: Added needed_tailroom

2020-08-09 Thread Willem de Bruijn
On Sat, Aug 8, 2020 at 7:53 PM Xie He wrote: > > The underlying Ethernet device may request necessary tailroom to be > allocated by setting needed_tailroom. This driver should also set > needed_tailroom to request the tailroom needed by the underlying > Ethernet device to be allocated. > > Cc:

Re: linux-next: manual merge of the spi tree with the mtd tree

2020-08-09 Thread Stephen Rothwell
Hi all, On Wed, 8 Jul 2020 14:37:59 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the spi tree got conflicts in: > > drivers/memory/Kconfig > drivers/memory/Makefile > > between commit: > > 66b8173a197f ("memory: stm32-fmc2-ebi: add STM32 FMC2 EBI controller > driver")

Re: linux-next: manual merge of the kvm-arm tree with the kvm tree

2020-08-09 Thread Stephen Rothwell
Hi all, On Mon, 13 Jul 2020 14:39:35 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the kvm-arm tree got conflicts in: > > arch/arm64/include/asm/kvm_coproc.h > arch/arm64/kvm/handle_exit.c > > between commit: > > 74cc7e0c35c1 ("KVM: arm64: clean up redundant 'kvm_run'

Re: linux-next: manual merge of the kvm-arm tree with the kvm tree

2020-08-09 Thread Stephen Rothwell
Hi all, On Mon, 13 Jul 2020 14:40:36 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the kvm-arm tree got a conflict in: > > arch/arm64/kvm/mmu.c > > between commit: > > c1a33aebe91d ("KVM: arm64: Use common KVM implementation of MMU memory > caches") > > from the kvm

Re: linux-next: manual merge of the set_fs tree with the powerpc tree

2020-08-09 Thread Stephen Rothwell
Hi all, On Fri, 17 Jul 2020 19:09:31 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the set_fs tree got a conflict in: > > arch/powerpc/mm/numa.c > > between commit: > > c30f931e891e ("powerpc/numa: remove ability to enable topology updates") > > from the powerpc tree

[PATCH] ASoC: intel: Fix memleak in sst_media_open

2020-08-09 Thread Dinghao Liu
When power_up_sst() fails, stream needs to be freed just like when try_module_get() fails. However, current code is returning directly and ends up leaking memory. Fixes: 0121327c1a68b ("ASoC: Intel: mfld-pcm: add control for powering up/down dsp") Signed-off-by: Dinghao Liu ---

Re: linux-next: manual merge of the set_fs tree with the battery tree

2020-08-09 Thread Stephen Rothwell
Hi all, On Mon, 27 Jul 2020 21:01:37 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the set_fs tree got a conflict in: > > drivers/power/supply/da9030_battery.c > > between commit: > > 9d832cd36c60 ("power: Convert to DEFINE_SHOW_ATTRIBUTE") > > from the battery tree and

Re: linux-next: manual merge of the set_fs tree with the tip tree

2020-08-09 Thread Stephen Rothwell
Hi all, On Mon, 27 Jul 2020 21:04:44 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the set_fs tree got a conflict in: > > lib/debugobjects.c > > between commit: > > 0f85c4805184 ("debugobjects: Convert to DEFINE_SHOW_ATTRIBUTE") > > from the tip tree and commit: > >

Re: [RFC] memory: exynos5422-dmc: Document mutex scope

2020-08-09 Thread Krzysztof Kozlowski
On Tue, Aug 04, 2020 at 11:40:07AM +0100, Lukasz Luba wrote: > Hi Krzysztof, > > On 7/24/20 7:08 PM, Krzysztof Kozlowski wrote: > > Document scope of the mutex used by driver. > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > It seems mutex was introduced to protect: > > 1. setting

Re: [PATCH net] drivers/net/wan/x25_asy: Added needed_headroom and a skb->len check

2020-08-09 Thread Willem de Bruijn
On Sun, Aug 9, 2020 at 4:36 AM Xie He wrote: > > 1. Added a skb->len check > > This driver expects upper layers to include a pseudo header of 1 byte > when passing down a skb for transmission. This driver will read this > 1-byte header. This patch added a skb->len check before reading the >

Re: [PATCH] scsi: sd: add runtime pm to open / release

2020-08-09 Thread Martin Kepplinger
On 08.08.20 17:05, Alan Stern wrote: > On Sat, Aug 08, 2020 at 08:59:09AM +0200, Martin Kepplinger wrote: >> On 07.08.20 16:30, Alan Stern wrote: >>> On Fri, Aug 07, 2020 at 11:51:21AM +0200, Martin Kepplinger wrote: it's really strange: below is the change I'm trying. Of course that's

[PATCH] mwifiex: Do not use GFP_KERNEL in atomic context

2020-08-09 Thread Christophe JAILLET
A possible call chain is as follow: mwifiex_sdio_interrupt(sdio.c) --> mwifiex_main_process(main.c) --> mwifiex_process_cmdresp (cmdevt.c) --> mwifiex_process_sta_cmdresp (sta_cmdresp.c)

Re: [TEGRA194_CPUFREQ PATCH v6 3/3] cpufreq: Add Tegra194 cpufreq driver

2020-08-09 Thread Catalin Marinas
On Sat, Aug 08, 2020 at 05:40:09PM -0700, Guenter Roeck wrote: > On Wed, Jul 15, 2020 at 07:01:25PM +0530, Sumit Gupta wrote: > > Add support for CPU frequency scaling on Tegra194. The frequency > > of each core can be adjusted by writing a clock divisor value to > > a MSR on the core. The range

[PATCH v6 2/4] SFH: PCIe driver to add support of AMD sensor fusion

2020-08-09 Thread Sandeep Singh
From: Sandeep Singh AMD SFH uses HID over PCIe bus.SFH fw is part of MP2 processor (MP2 which is an ARM® Cortex-M4 core based co-processor to x86) and it runs on MP2 where in driver resides on X86. This part of module will communicate with MP2 FW and provide that data into DRAM Signed-off-by:

[PATCH v6 4/4] SFH: Create HID report to Enable support of AMD sensor fusion Hub (SFH)

2020-08-09 Thread Sandeep Singh
From: Sandeep Singh This part of module will define the data into HID reports. Get data from PCIe layer and populate that data into reports. HID core communication between devices and HID core is mostly done via HID reports. Signed-off-by: Nehal Shah Signed-off-by: Sandeep Singh ---

[PATCH v6 3/4] SFH: Transport Driver to add support of AMD Sensor Fusion Hub (SFH)

2020-08-09 Thread Sandeep Singh
From: Sandeep Singh This part of module will provide the interaction between HID framework and client layer.This modules will registered client layer with HID framework. Signed-off-by: Nehal Shah Signed-off-by: Sandeep Singh --- drivers/hid/amd-sfh-hid/amdsfh_hid.c| 175

[PATCH v6 0/4] SFH: Add Support for AMD Sensor Fusion Hub

2020-08-09 Thread Sandeep Singh
From: Sandeep Singh AMD SFH(Sensor Fusion Hub) is HID based driver.SFH FW is part of MP2 processor (MP2 which is an ARM® Cortex-M4 core based co-processor to x86) and it runs on MP2 where in driver resides on X86.The driver functionalities are divided into three parts:- 1: amd-mp2-pcie:- This

[PATCH v6 1/4] SFH: Add maintainers and documentation for AMD SFH based on HID framework

2020-08-09 Thread Sandeep Singh
From: Sandeep Singh Add Maintainers for AMD SFH(SENSOR FUSION HUB) Solution and work flow document. Signed-off-by: Nehal Shah Signed-off-by: Sandeep Singh --- Documentation/hid/amd-sfh-hid.rst | 153 ++ MAINTAINERS | 8 ++ 2 files changed,

Re: [PATCH][next] habanalabs: fix incorrect check on failed workqueue create

2020-08-09 Thread Oded Gabbay
On Fri, Jul 31, 2020 at 9:21 AM Greg Kroah-Hartman wrote: > > On Thu, Jul 30, 2020 at 01:51:48PM +0300, Oded Gabbay wrote: > > On Thu, Jul 30, 2020 at 11:20 AM Colin King > > wrote: > > > > > > From: Colin Ian King > > > > > > The null check on a failed workqueue create is currently null

[PATCH] staging: ks7010: Do not use GFP_KERNEL in atomic context

2020-08-09 Thread Christophe JAILLET
A possible call chain is as follow: ks_wlan_start_xmit(ks_wlan_net.c) --> hostif_data_request (ks_hostif.c) --> michael_mic (ks_hostif.c) 'ks_wlan_start_xmit()' is a '.ndo_start_xmit()' function (see net_device_ops structure). Such

[PATCH] MAINTAINERS: Change OmniKey CM40xx drivers to Orphan state

2020-08-09 Thread laforge
From: Harald Welte I haven't been doing any work on those drivers in ages, neither do I even use any related devices. Signed-off-by: Harald Welte --- MAINTAINERS | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [PATCH] Coccinelle: Reduce duplicate code for patch rules of memdup_user.cocci

2020-08-09 Thread Julia Lawall
On Sun, 9 Aug 2020, Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 9 Aug 2020 11:11:20 +0200 > > Another patch rule was added. A bit of code was copied from a previous > SmPL rule for this change specification. > > * Thus reduce duplicate code by using another SmPL disjunction. I

Re: [PATCH] iio: documentation: light: Add as73211 sysfs documentation

2020-08-09 Thread Jonathan Cameron
On Sun, 9 Aug 2020 09:43:35 +0200 Christian Eggers wrote: > The driver for the as73211 light sensor provides the following not yet > documented sysfs entries: > - in_intensity_(x|y|z)_raw > - in_intensity_(x|y|z)_scale > - in_intensity_sampling_frequency(_available) > -

Re: [PATCH] iio:temperature:mlx90632: Some stylefixing leftovers

2020-08-09 Thread Jonathan Cameron
On Thu, 6 Aug 2020 23:21:39 +0200 Crt Mori wrote: > There is some inconsistency and whitespace cleanup performed in this > patch. It was done on top of my other patches, but I can rebase to head > of the togreg branch if it would go in sooner. > > Signed-off-by: Crt Mori If not already done

Re: [PATCH] iio: adc: rockchip_saradc: select IIO_TRIGGERED_BUFFER

2020-08-09 Thread Jonathan Cameron
On Mon, 03 Aug 2020 13:59:12 +0200 Heiko Stuebner wrote: > Am Montag, 3. August 2020, 10:30:01 CEST schrieb Michael Walle: > > The kernel fails to compile due to undefined reference to > > devm_iio_triggered_buffer_setup() if IIO_TRIGGERED_BUFFER is not > > enabled. The original patch [1] had

Non-deterministically boot into dark screen with `amdgpu`

2020-08-09 Thread Ignat Insarov
Hello! This is an issue report. I am not familiar with the Linux kernel development procedure, so please direct me to a more appropriate or specialized medium if this is not the right avenue. My laptop (Ryzen 7 Pro CPU/GPU) boots into dark screen more often than not. Screen blackness correlates

[PATCH 2/4] habanalabs: set clock gating according to mask

2020-08-09 Thread Oded Gabbay
From: Ofir Bitton Once clock gating is set we enable clock gating according to mask, we should also disable clock gating according to relevant bits. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/gaudi/gaudi.c | 44

[PATCH 1/4] habanalabs: verify user input in cs_ioctl_signal_wait

2020-08-09 Thread Oded Gabbay
From: Ofir Bitton User input must be validated before using it to access internal structures. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/command_submission.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH 4/4] habanalabs: set max power according to card type

2020-08-09 Thread Oded Gabbay
In Gaudi, the default max power setting is different between PCI and PMC cards. Therefore, the driver need to set the default after knowing what is the card type. The current code has a bug where it limits the maximum power of the PMC card to 200W after a reset occurs. Signed-off-by: Oded Gabbay

[PATCH 3/4] habanalabs: proper handling of alloc size in coresight

2020-08-09 Thread Oded Gabbay
From: Ofir Bitton Allocation size can go up to 64bit but truncated to 32bit, we should make sure it is not truncated and validate no address overflow. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/habanalabs.h | 2 +-

Re: [PATCH v6 2/4] SFH: PCIe driver to add support of AMD sensor fusion

2020-08-09 Thread kernel test robot
in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sandeep-Singh/SFH-Add-Support-for-AMD-Sensor-Fusion-Hub/20200809-182729 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 06a81c1c7db9bd5de0bd38cd5acc44bb22b99150 config: riscv

Re: [PATCH] drivers: bluetooth: btintel.c: fixed format issue.

2020-08-09 Thread kernel test robot
' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/YourName/drivers-bluetooth-btintel-c-fixed-format-issue/20200809-152614 base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master config: i386-randconfig

[PATCH] habanalabs: print the queue id in case of an error

2020-08-09 Thread Oded Gabbay
From: Dotan Barak If there is a failure during the testing of a queue, to ease up debugging - print the queue id. Signed-off-by: Dotan Barak Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/gaudi/gaudi.c | 9 ++--- drivers/misc/habanalabs/goya/goya.c | 9

Re: [PATCH][next] habanalabs: fix incorrect check on failed workqueue create

2020-08-09 Thread Greg Kroah-Hartman
On Sun, Aug 09, 2020 at 02:02:18PM +0300, Oded Gabbay wrote: > On Fri, Jul 31, 2020 at 9:21 AM Greg Kroah-Hartman > wrote: > > > > On Thu, Jul 30, 2020 at 01:51:48PM +0300, Oded Gabbay wrote: > > > On Thu, Jul 30, 2020 at 11:20 AM Colin King > > > wrote: > > > > > > > > From: Colin Ian King >

Re: [PATCH][next] habanalabs: fix incorrect check on failed workqueue create

2020-08-09 Thread Oded Gabbay
On Sun, Aug 9, 2020 at 3:02 PM Greg Kroah-Hartman wrote: > > On Sun, Aug 09, 2020 at 02:02:18PM +0300, Oded Gabbay wrote: > > On Fri, Jul 31, 2020 at 9:21 AM Greg Kroah-Hartman > > wrote: > > > > > > On Thu, Jul 30, 2020 at 01:51:48PM +0300, Oded Gabbay wrote: > > > > On Thu, Jul 30, 2020 at

Re: [PATCH] gpu/drm: Remove TTM_PL_FLAG_WC of VRAM to fix writecombine issue for Loongson64

2020-08-09 Thread Christian König
Am 08.08.20 um 15:50 schrieb Jiaxun Yang: 在 2020/8/8 下午9:41, Thomas Bogendoerfer 写道: On Sat, Aug 08, 2020 at 03:25:02PM +0800, Tiezhu Yang wrote: Loongson processors have a writecombine issue that maybe failed to write back framebuffer used with ATI Radeon or AMD GPU at times, after commit

fs/f2fs/file.c:761:9: warning: Identical condition 'err', second condition is always false

2020-08-09 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 06a81c1c7db9bd5de0bd38cd5acc44bb22b99150 commit: 3265d3db1f16395cfc6b8ea9b31b4001d98d05ef f2fs: support partial truncation on compressed inode date: 3 months ago compiler: xtensa-linux-gcc (GCC) 9.3.0 If

[PATCH 2/9] ufs: ufs-qcom: Fix race conditions caused by func ufs_qcom_testbus_config

2020-08-09 Thread Can Guo
If ufs_qcom_dump_dbg_regs() calls ufs_qcom_testbus_config() from ufshcd_suspend/resume and/or clk gate/ungate context, pm_runtime_get_sync() and ufshcd_hold() will cause racing problems. Fix this by removing the unnecessary calls of pm_runtime_get_sync() and ufshcd_hold(). Signed-off-by: Can Guo

[PATCH 6/9] scsi: ufs: Recover hba runtime PM error in error handler

2020-08-09 Thread Can Guo
Current error handler cannot work well or recover hba runtime PM error if ufshcd_suspend/resume has failed due to UFS errors, e.g. hibern8 enter/exit error or SSU cmd error. When this happens, error handler may fail doing full reset and restore because error handler always assumes that powers,

[PATCH 3/9] scsi: ufs-qcom: Remove testbus dump in ufs_qcom_dump_dbg_regs

2020-08-09 Thread Can Guo
Dumping testbus registers is heavy enough to cause stability issues sometime, just remove them as of now. Signed-off-by: Can Guo Reviewed-by: Hongwu Su Reviewed-by: Avri Altman Reviewed-by: Bean Huo Reviewed-by: Asutosh Das diff --git a/drivers/scsi/ufs/ufs-qcom.c

[PATCH 1/9] scsi: ufs: Add checks before setting clk-gating states

2020-08-09 Thread Can Guo
Clock gating features can be turned on/off selectively which means its state information is only important if it is enabled. This change makes sure that we only look at state of clk-gating if it is enabled. Signed-off-by: Can Guo Reviewed-by: Avri Altman Reviewed-by: Hongwu Su Reviewed-by:

[PATCH 7/9] scsi: ufs: Move dumps in IRQ handler to error handler

2020-08-09 Thread Can Guo
Sometime dumps in IRQ handler are heavy enough to cause system stability issues, move them to error handler and only print basic host regs here. Signed-off-by: Can Guo Reviewed-by: Bean Huo Reviewed-by: Asutosh Das diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index

[PATCH 5/9] scsi: ufs: Fix concurrency of error handler and other error recovery paths

2020-08-09 Thread Can Guo
Error recovery can be invoked from multiple paths, including hibern8 enter/exit (from ufshcd_link_recovery), ufshcd_eh_host_reset_handler and eh_work scheduled from IRQ context. Ultimately, these paths are trying to invoke ufshcd_reset_and_restore, in either sync or async manner. Having both sync

[PATCH 8/9] scsi: ufs: Fix a racing problem btw error handler and runtime PM ops

2020-08-09 Thread Can Guo
Current IRQ handler blocks scsi requests before scheduling eh_work, when error handler calls pm_runtime_get_sync, if ufshcd_suspend/resume sends a scsi cmd, most likely the SSU cmd, since scsi requests are blocked, pm_runtime_get_sync() will never return because ufshcd_suspend/reusme is blocked by

[PATCH 9/9] scsi: ufs: Properly release resources if a task is aborted successfully

2020-08-09 Thread Can Guo
In current UFS task abort hook, namely ufshcd_abort(), if one task is aborted successfully, clk_gating.active_reqs held by this task is not decreased, which makes clk_gating.active_reqs stay above zero forever, thus clock gating would never happen. Instead of releasing resources of one task

[PATCH 4/9] scsi: ufs: Add some debug infos to ufshcd_print_host_state

2020-08-09 Thread Can Guo
The infos of the last interrupt status and its timestamp are very helpful when debug system stability issues, e.g. IRQ starvation, so add them to ufshcd_print_host_state. Meanwhile, UFS device infos like model name and its FW version also come in handy during debug. In addition, this change makes

Re: [PATCH v6 4/4] SFH: Create HID report to Enable support of AMD sensor fusion Hub (SFH)

2020-08-09 Thread kernel test robot
in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sandeep-Singh/SFH-Add-Support-for-AMD-Sensor-Fusion-Hub/20200809-182729 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 06a81c1c7db9bd5de0bd38cd5acc44bb22b99150 config: riscv

Re: Your Assistance For Investment.

2020-08-09 Thread Mr.Dickson Nsebeh
Dear Friend, Please, I come to you with good reason. My name is Mr.Dickson Nsebeh, a banker by profession, with position of ( Assistant Manager ) I will be going on retirement end of September 2020. Please can i trust you to release the sum of $9.3 Million Dollars, to you for safe keeping in

[PATCH] usb: musb: Fix runtime PM race in musb_queue_resume_work

2020-08-09 Thread Paul Cercueil
musb_queue_resume_work() would call the provided callback if the runtime PM status was 'active'. Otherwise, it would enqueue the request if the hardware was still suspended (musb->is_runtime_suspended is true). This causes a race with the runtime PM handlers, as it is possible to be in the case

RE: [PATCH] tools/thermal: tmon: include pthread and time headers in tmon.h

2020-08-09 Thread Alejandro González
> > -Original Message- > > From: Florian Fainelli > > Sent: Thursday, June 18, 2020 8:23 AM > > To: Markus Mayer ; Daniel Lezcano > > ; Pawnikar, Sumeet R > > ; Zhang, Rui ; Brian > > Norris > > Cc: Broadcom Kernel List ; Linux > > Kernel Mailing List > > Subject: Re: [PATCH]

[GIT PULL] pin control changes for the v5.9 kernel cycle

2020-08-09 Thread Linus Walleij
Hi Linus, here is the big bulk of pin control changes for the v5.9 kernel cycle, nothing is particularly interesting. I expect you to see two conflicts: drivers/pinctrl/intel/pinctrl-baytrail.c - no idea what this is about as both HEAD and mine look the same to human eyes, I suppose whitespace.

Re: [PATCH v4 1/3] iio: accel: adxl372: Add support for FIFO peak mode

2020-08-09 Thread Jonathan Cameron
On Mon, 3 Aug 2020 20:22:17 +0300 wrote: > From: Stefan Popa > > By default, if all three channels (x, y, z) are enabled, sample sets of > concurrent 3-axis data is stored in the FIFO. This patch adds the option > to configure the FIFO to store peak acceleration (x, y and z) of every >

Re: [PATCH v4 2/3] iio: accel: adxl372: add event interface

2020-08-09 Thread Jonathan Cameron
On Mon, 3 Aug 2020 20:22:18 +0300 wrote: > From: Alexandru Tachici > > Currently the driver configures adxl372 to work in loop mode. > The inactivity and activity timings decide how fast the chip > will loop through the awake and waiting states and the > thresholds on x,y,z axis decide when

Re: [PATCH net-next RFC 01/13] devlink: Add reload level option to devlink reload command

2020-08-09 Thread Moshe Shemesh
On 8/6/2020 9:25 PM, Jakub Kicinski wrote: On Wed, 5 Aug 2020 13:02:58 +0200 Jiri Pirko wrote: Tue, Aug 04, 2020 at 10:39:46PM CEST, k...@kernel.org wrote: AFAIU the per-driver default is needed because we went too low level with what the action constitutes. We need maintain the higher level

Re: [PATCH v4 3/3] docs: iio: Add adxl372 documentation

2020-08-09 Thread Jonathan Cameron
On Mon, 3 Aug 2020 20:22:19 +0300 wrote: > From: Alexandru Tachici > > Add documentation for adxl372 3-axis accelerometer. > > Signed-off-by: Alexandru Tachici This is ABI docs, so I'd normally expect them in Documentation/ABI/testing/sysfs-bus-iio-accel-adxl372 rather than as part of the

Documentation: build failure with sphinx >= 3.0.0: exception: cannot import name 'c_funcptr_sig_re' from 'sphinx.domains.c' (was: Re: Kernel build failed ...SPHINX extension error)

2020-08-09 Thread Salvatore Bonaccorso
Hi On Thu, Apr 09, 2020 at 05:04:54AM +0530, Bhaskar Chowdhury wrote: > On 13:25 Wed 08 Apr 2020, Jonathan Corbet wrote: > > On Wed, 8 Apr 2020 17:07:05 +0530 > > Bhaskar Chowdhury wrote: > > > > > Extension error: > > > Could not import extension cdomain (exception: cannot import name > > >

[PATCH v3 02/18] gpio: uapi: define uAPI v2

2020-08-09 Thread Kent Gibson
Add a new version of the uAPI to address existing 32/64-bit alignment issues, add support for debounce and event sequence numbers, allow requested lines with different configurations, and provide some future proofing by adding padding reserved for future use. The alignment issue relates to the

[PATCH v3 04/18] gpiolib: add build option for CDEV v1 ABI

2020-08-09 Thread Kent Gibson
Add a build option to allow the removal of the CDEV v1 ABI. Suggested-by: Bartosz Golaszewski Signed-off-by: Kent Gibson --- This patch is before the v2 implementation, and is non-functional until that patch, as some parts of that patch would be written slightly differently if removing v1 was

[PATCH v3 05/18] gpiolib: cdev: support GPIO_V2_GET_LINE_IOCTL and GPIO_V2_LINE_GET_VALUES_IOCTL

2020-08-09 Thread Kent Gibson
Add support for requesting lines using the GPIO_V2_GET_LINE_IOCTL, and returning their current values using GPIO_V2_LINE_GET_VALUES_IOCTL. Signed-off-by: Kent Gibson --- The struct line implementation is based on the v1 struct linehandle implementation. The line_ioctl() is a simple wrapper

[PATCH v3 00/18] gpio: cdev: add uAPI v2

2020-08-09 Thread Kent Gibson
This patchset defines and implements adds a new version of the GPIO CDEV uAPI to address existing 32/64-bit alignment issues, add support for debounce, event sequence numbers, and allowing for requested lines with different configurations. It provides some future proofing by adding optional

[PATCH v3 06/18] gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL

2020-08-09 Thread Kent Gibson
Add support for GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL. Signed-off-by: Kent Gibson --- The core of this change is the event kfifo switching to contain struct gpioline_info_changed_v2, instead of v1 as v2 is richer. The two uAPI versions are mostly independent - other

[PATCH v3 01/18] gpio: uapi: define GPIO_MAX_NAME_SIZE for array sizes

2020-08-09 Thread Kent Gibson
Replace constant array sizes with a macro constant to clarify the source of array sizes, provide a place to document any constraints on the size, and to simplify array sizing in userspace if constructing structs from their composite fields. Signed-off-by: Kent Gibson ---

[PATCH v3 03/18] gpiolib: make cdev a build option

2020-08-09 Thread Kent Gibson
Make the gpiolib-cdev module a build option. This allows the CDEV interface to be removed from the kernel to reduce kernel size in applications where is it not required, and provides the parent for other other CDEV interface specific build options to follow. Suggested-by: Bartosz Golaszewski

[PATCH v3 10/18] gpiolib: cdev: support setting debounce

2020-08-09 Thread Kent Gibson
Add support for setting debounce on a line via the GPIO uAPI. Where debounce is not supported by hardware, a software debounce is provided. Signed-off-by: Kent Gibson --- The implementation of the software debouncer waits for the line to be stable for the debounce period before determining if a

[PATCH v3 11/18] gpio: uapi: document uAPI v1 as deprecated

2020-08-09 Thread Kent Gibson
Update uAPI documentation to deprecate v1 structs and ioctls. Signed-off-by: Kent Gibson --- include/uapi/linux/gpio.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/include/uapi/linux/gpio.h b/include/uapi/linux/gpio.h index 82e8744b8c3b..286f5522378c 100644

[PATCH v3 07/18] gpiolib: cdev: support edge detection for uAPI v2

2020-08-09 Thread Kent Gibson
Add support for edge detection to lines requested using GPIO_V2_GET_LINE_IOCTL. Signed-off-by: Kent Gibson --- The edge_detector implementation is based on the v1 lineevent implementation. drivers/gpio/gpiolib-cdev.c | 316 +++- drivers/gpio/gpiolib.c |

[PATCH v3 12/18] tools: gpio: port lsgpio to v2 uAPI

2020-08-09 Thread Kent Gibson
Port the lsgpio tool to the latest GPIO uAPI. Signed-off-by: Kent Gibson --- tools/gpio/lsgpio.c | 60 - 1 file changed, 38 insertions(+), 22 deletions(-) diff --git a/tools/gpio/lsgpio.c b/tools/gpio/lsgpio.c index b08d7a5e779b..deda38244026 100644

[PATCH v3 14/18] tools: gpio: rename nlines to num_lines

2020-08-09 Thread Kent Gibson
Rename nlines to num_lines to be consistent with other usage for fields describing the number of entries in an array. Signed-off-by: Kent Gibson --- tools/gpio/gpio-hammer.c | 26 +- tools/gpio/gpio-utils.c | 20 ++-- tools/gpio/gpio-utils.h | 6 +++---

  1   2   3   4   >