[PATCH v14 23/26] ELF: Introduce arch_setup_elf_property()

2020-10-12 Thread Yu-cheng Yu
An ELF file's .note.gnu.property indicates arch features supported by the file. These features are extracted by arch_parse_elf_property() and stored in 'arch_elf_state'. Introduce arch_setup_elf_property() for enabling such features. The first use-case of this function is shadow stack. ARM64

[PATCH v14 10/26] x86/mm: Update pte_modify for _PAGE_COW

2020-10-12 Thread Yu-cheng Yu
Pte_modify() changes a PTE to 'newprot'. It doesn't use the pte_*() helpers that a previous patch fixed up, so we need a new site. Introduce fixup_dirty_pte() to set the dirty bits based on _PAGE_RW, and apply the same changes to pmd_modify(). Signed-off-by: Yu-cheng Yu ---

Re: [tip: objtool/core] x86/insn: Support big endian cross-compiles

2020-10-12 Thread Josh Poimboeuf
On Mon, Oct 12, 2020 at 09:12:36AM +0900, Masami Hiramatsu wrote: > On Sat, 10 Oct 2020 12:44:15 -0500 > Josh Poimboeuf wrote: > > > On Fri, Oct 09, 2020 at 10:49:21PM +0200, Borislav Petkov wrote: > > > On Fri, Oct 09, 2020 at 10:38:22PM +0200, Peter Zijlstra wrote: > > > > On Wed, Oct 07, 2020

[PATCH v14 25/26] x86/cet/shstk: Add arch_prctl functions for shadow stack

2020-10-12 Thread Yu-cheng Yu
arch_prctl(ARCH_X86_CET_STATUS, u64 *args) Get CET feature status. The parameter 'args' is a pointer to a user buffer. The kernel returns the following information: *args = shadow stack/IBT status *(args + 1) = shadow stack base address *(args + 2) = shadow stack size

[PATCH v14 19/26] mm: Re-introduce vm_flags to do_mmap()

2020-10-12 Thread Yu-cheng Yu
There was no more caller passing vm_flags to do_mmap(), and vm_flags was removed from the function's input by: commit 45e55300f114 ("mm: remove unnecessary wrapper function do_mmap_pgoff()"). There is a new user now. Shadow stack allocation passes VM_SHSTK to do_mmap(). Re-introduce

[PATCH v14 21/26] x86/cet/shstk: Handle signals for shadow stack

2020-10-12 Thread Yu-cheng Yu
To deliver a signal, create a shadow stack restore token and put a restore token and the signal restorer address on the shadow stack. For sigreturn, verify the token and restore the shadow stack pointer. Introduce WRUSS, which is a kernel-mode instruction but writes directly to user shadow

[PATCH v14 15/26] mm: Fixup places that call pte_mkwrite() directly

2020-10-12 Thread Yu-cheng Yu
A shadow stack page is made writable by pte_mkwrite_shstk(), which sets _PAGE_DIRTY_HW. There are a few places that call pte_mkwrite() directly and miss the maybe_mkwrite() fixup in the previous patch. Fix them with maybe_mkwrite(): - do_anonymous_page() and migrate_vma_insert_page() check

[PATCH v14 22/26] binfmt_elf: Define GNU_PROPERTY_X86_FEATURE_1_AND properties

2020-10-12 Thread Yu-cheng Yu
An ELF file's .note.gnu.property indicates architecture features of the file.. Introduce feature definitions for Shadow Stack and Indirect Branch Tracking. Signed-off-by: Yu-cheng Yu --- include/uapi/linux/elf.h | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH v14 26/26] mm: Introduce PROT_SHSTK for shadow stack

2020-10-12 Thread Yu-cheng Yu
There are three possible options to create a shadow stack allocation API: an arch_prctl, a new syscall, or adding PROT_SHSTK to mmap()/mprotect(). Each has its advantages and compromises. An arch_prctl() is the least intrusive. However, the existing x86 arch_prctl() takes only two parameters.

[PATCH v14 18/26] mm: Update can_follow_write_pte() for shadow stack

2020-10-12 Thread Yu-cheng Yu
Can_follow_write_pte() ensures a read-only page is COWed by checking the FOLL_COW flag, and uses pte_dirty() to validate the flag is still valid. Like a writable data page, a shadow stack page is writable, and becomes read-only during copy-on-write, but it is always dirty. Thus, in the

[PATCH v14 12/26] mm: Introduce VM_SHSTK for shadow stack memory

2020-10-12 Thread Yu-cheng Yu
A Shadow Stack PTE must be read-only and have _PAGE_DIRTY set. However, read-only and Dirty PTEs also exist for copy-on-write (COW) pages. These two cases are handled differently for page faults. Introduce VM_SHSTK to track shadow stack VMAs. Signed-off-by: Yu-cheng Yu Reviewed-by: Kees Cook

Re: [PATCH 02/18] dt-bindings: usb: usb-hcd: Add "wireless" maximum-speed property value

2020-10-12 Thread Greg Kroah-Hartman
On Sun, Oct 11, 2020 at 08:53:33PM +0300, Serge Semin wrote: > On Sun, Oct 11, 2020 at 04:42:36PM +0200, Greg Kroah-Hartman wrote: > > On Sun, Oct 11, 2020 at 01:41:05AM +0300, Serge Semin wrote: > > > It appears that the "maximum-speed" property can also accept the > > > "wireless" value. Add it

[PATCH v14 14/26] x86/mm: Update maybe_mkwrite() for shadow stack

2020-10-12 Thread Yu-cheng Yu
Shadow stack memory is writable, but its VMA has VM_SHSTK instead of VM_WRITE. Update maybe_mkwrite() to include the shadow stack. Signed-off-by: Yu-cheng Yu --- arch/x86/Kconfig| 4 arch/x86/mm/pgtable.c | 18 ++ include/linux/mm.h | 2 ++

[PATCH v14 08/26] x86/mm: Introduce _PAGE_COW

2020-10-12 Thread Yu-cheng Yu
There is essentially no room left in the x86 hardware PTEs on some OSes (not Linux). That left the hardware architects looking for a way to represent a new memory type (shadow stack) within the existing bits. They chose to repurpose a lightly-used state: Write=0,Dirty=1. The reason it's lightly

[PATCH v14 02/26] x86/cpufeatures: Add CET CPU feature flags for Control-flow Enforcement Technology (CET)

2020-10-12 Thread Yu-cheng Yu
Add CPU feature flags for Control-flow Enforcement Technology (CET). CPUID.(EAX=7,ECX=0):ECX[bit 7] Shadow stack CPUID.(EAX=7,ECX=0):EDX[bit 20] Indirect Branch Tracking Signed-off-by: Yu-cheng Yu Reviewed-by: Borislav Petkov Reviewed-by: Kees Cook --- arch/x86/include/asm/cpufeatures.h

[PATCH v14 00/26] Control-flow Enforcement: Shadow Stack

2020-10-12 Thread Yu-cheng Yu
Control-flow Enforcement (CET) is a new Intel processor feature that blocks return/jump-oriented programming attacks. Details are in "Intel 64 and IA-32 Architectures Software Developer's Manual" [1]. CET can protect applications and the kernel. This series enables only application-level

[PATCH v14 03/26] x86/fpu/xstate: Introduce CET MSR XSAVES supervisor states

2020-10-12 Thread Yu-cheng Yu
Control-flow Enforcement Technology (CET) adds five MSRs. Introduce them and their XSAVES supervisor states: MSR_IA32_U_CET (user-mode CET settings), MSR_IA32_PL3_SSP (user-mode Shadow Stack pointer), MSR_IA32_PL0_SSP (kernel-mode Shadow Stack pointer), MSR_IA32_PL1_SSP

[PATCH v14 11/26] x86/mm: Update ptep_set_wrprotect() and pmdp_set_wrprotect() for transition from _PAGE_DIRTY_HW to _PAGE_COW

2020-10-12 Thread Yu-cheng Yu
When shadow stack is introduced, [R/O + _PAGE_DIRTY_HW] PTE is reserved for shadow stack. Copy-on-write PTEs have [R/O + _PAGE_COW]. When a PTE goes from [R/W + _PAGE_DIRTY_HW] to [R/O + _PAGE_COW], it could become a transient shadow stack PTE in two cases: The first case is that some

[PATCH v14 01/26] Documentation/x86: Add CET description

2020-10-12 Thread Yu-cheng Yu
Explain no_user_shstk/no_user_ibt kernel parameters, and introduce a new document on Control-flow Enforcement Technology (CET). Signed-off-by: Yu-cheng Yu Reviewed-by: Kees Cook --- .../admin-guide/kernel-parameters.txt | 6 + Documentation/x86/index.rst | 1 +

Re: [PATCH 0/5] tracing: Synthetic event dynamic string fixes

2020-10-12 Thread Tom Zanussi
Hi Steve, On Mon, 2020-10-12 at 11:13 -0400, Steven Rostedt wrote: > On Fri, 9 Oct 2020 10:17:06 -0500 > Tom Zanussi wrote: > > > These patches provide fixes for the problems observed by Masami in > > the > > new synthetic event dynamic string patchset. > > > > The first patch (tracing: Don't

Re: [PATCH] kthread: Add kthread_work tracepoints

2020-10-12 Thread Steven Rostedt
On Mon, 12 Oct 2020 08:14:50 -0700 Rob Clark wrote: > > DEFINE_EVENT(sched_kthread_work_execute_template, > > sched_kthread_work_execute_start, > > TP_PROTO(struct kthread_work *work), > > TP_ARGS(work)); > > > > DEFINE_EVENT(sched_kthread_work_execute_template, > >

Re: [PATCH 1/5] tracing: Don't show dynamic string internals in synthetic event description

2020-10-12 Thread Tom Zanussi
Hi Masami, On Sun, 2020-10-11 at 00:03 +0900, Masami Hiramatsu wrote: > Hi Tom, > > On Fri, 9 Oct 2020 10:17:07 -0500 > Tom Zanussi wrote: > > > For synthetic event dynamic fields, the type contains "__data_loc", > > which is basically an internal part of the type which is only meant > > to >

Re: [PATCH v3 0/2] nvmem: skip nodes with compatibles other than "nvmem-cell"

2020-10-12 Thread Ahmad Fatoum
Hello Rob, Hello Srini, On 5/12/20 4:18 PM, Rob Herring wrote: > On Tue, Apr 28, 2020 at 01:18:25PM +0200, Ahmad Fatoum wrote: >> The nvmem cell binding applies to all objects which match "^.*@[0-9a-f]+$", >> without taking a compatible into account. This precludes extension of e.g. >> eeprom

Re: [PATCH v7 2/2] PCI: dwc: Fix MSI page leakage in suspend/resume

2020-10-12 Thread Vidya Sagar
On 10/12/2020 5:07 PM, Robin Murphy wrote: External email: Use caution opening links or attachments On 2020-10-09 08:55, Jisheng Zhang wrote: Currently, dw_pcie_msi_init() allocates and maps page for msi, then program the PCIE_MSI_ADDR_LO and PCIE_MSI_ADDR_HI. The Root Complex may lose

Re: [PATCH] ARM: dts: sun8i: h2+: Enable optional SPI flash on Orange Pi Zero board

2020-10-12 Thread Maxime Ripard
On Thu, Oct 08, 2020 at 07:40:44PM +0200, Michal Suchánek wrote: > On Thu, Oct 08, 2020 at 07:14:54PM +0200, Maxime Ripard wrote: > > On Thu, Oct 08, 2020 at 06:02:19PM +0200, Michal Suchánek wrote: > > > On Thu, Oct 08, 2020 at 05:13:15PM +0200, Maxime Ripard wrote: > > > > Hi, > > > > > > > >

Re: [PATCH v2 1/3] objtool: check: Fully validate the stack frame

2020-10-12 Thread Josh Poimboeuf
On Mon, Oct 12, 2020 at 11:21:49AM +0100, Julien Thierry wrote: > On 9/29/20 8:18 PM, Josh Poimboeuf wrote: > > "Stack frame" has more than one meaning now, I suppose. i.e. it could > > also include the callee-saved registers and any other stack space > > allocated by the function. > > > > Would

Re: [PATCH] x86/boot/64: Initialize 5-level paging variables earlier

2020-10-12 Thread Arvind Sankar
On Mon, Oct 12, 2020 at 05:08:30PM +0300, Kirill A. Shutemov wrote: > On Sat, Oct 10, 2020 at 03:26:24PM -0400, Arvind Sankar wrote: > > On Sat, Oct 10, 2020 at 03:11:10PM -0400, Arvind Sankar wrote: > > > Commit > > > ca0e22d4f011 ("x86/boot/compressed/64: Always switch to own page table") > >

[GIT PULL] core/build changes for v5.10: Add orphan section checking for x86, ARM and ARM64

2020-10-12 Thread Ingo Molnar
Linus, Please pull the latest core/build git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core-build-2020-10-12 # HEAD: 6e0bf0e0e55000742a53c5f3b58f8669e0091a11 x86/boot/compressed: Warn on orphan section placement Orphan link sections were a long-standing

Re: [PATCH RFC 2/2] kbuild: use interpreters to invoke scripts

2020-10-12 Thread Masahiro Yamada
On Sun, Oct 4, 2020 at 12:21 AM Ujjwal Kumar wrote: > > We cannot rely on execute bits to be set on files in the repository. > The build script should use the explicit interpreter when invoking any > script from the repository. > > Link: >

Re: [PATCH v2 1/4] dt-bindings: usb: convert usb-device.txt to YAML schema

2020-10-12 Thread Rob Herring
On Sat, 10 Oct 2020 16:43:11 +0800, Chunfeng Yun wrote: > Convert usb-device.txt to YAML schema usb-device.yaml > > Signed-off-by: Chunfeng Yun > --- > v2: new patch suggested by Rob > --- > .../devicetree/bindings/usb/usb-device.txt| 102 -- >

Re: linux-next: Tree for Oct 12 (drivers/staging/media/atomisp/)

2020-10-12 Thread Randy Dunlap
On 10/12/20 2:59 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20201009: > on x86_64: In file included from ../drivers/staging/media/atomisp//pci/ia_css_control.h:25:0, from ../drivers/staging/media/atomisp//pci/ia_css.h:28, from

Re: [PATCH 4/5] tracing: Add synthetic event error logging

2020-10-12 Thread Tom Zanussi
Hi Masami, On Sat, 2020-10-10 at 23:57 +0900, Masami Hiramatsu wrote: > On Fri, 9 Oct 2020 10:17:10 -0500 > Tom Zanussi wrote: > > > Add support for synthetic event error logging, which entails adding > > a > > logging function for it, a way to save the synthetic event command, > > and a set

re: RDMA/rxe: Fix skb lifetime in rxe_rcv_mcast_pkt()

2020-10-12 Thread Colin Ian King
Hi, Static analysis with Coverity has detected a potential issue with the following commit: commit e7ec96fc7932f48a6d6cdd05bf82004a1a04285b Author: Bob Pearson Date: Thu Oct 8 15:36:52 2020 -0500 RDMA/rxe: Fix skb lifetime in rxe_rcv_mcast_pkt() The analysis is as follows: 16.

Re: [ANNOUNCE] libtraceevent.git

2020-10-12 Thread Sudip Mukherjee
On Mon, Oct 12, 2020 at 4:19 PM Steven Rostedt wrote: > > On Mon, 12 Oct 2020 12:12:08 +0200 > Jiri Olsa wrote: > > > On Wed, Oct 07, 2020 at 01:07:50PM -0400, Steven Rostedt wrote: > > > I split out tools/lib/traceevent from the kernel tree using "git subtree", > > > which recreates all the

KINDEST MESSAGE.

2020-10-12 Thread Tofil Bama
Dear, My name is Mr Tofil Bama, I am the Bill and Exchange assistant Manager in Bank of Africa Ouagadougou Burkina Faso. In my department I discovered an abandoned sum of eighteen million three hundred thousand United State of American dollars (18.3MILLION USA DOLLARS) in an account that belongs

Re: [PATCH] drm/panel: rm68200: fix mode to 50fps

2020-10-12 Thread Philippe CORNU
On 9/25/20 4:16 PM, Yannick Fertre wrote: > Compute new timings to get a framerate of 50fps with a pixel clock > @54Mhz. > > Signed-off-by: Yannick Fertre > --- > drivers/gpu/drm/panel/panel-raydium-rm68200.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff

Re: [PATCH 08/13] m68k: m68328: use legacy_timer_tick()

2020-10-12 Thread Arnd Bergmann
On Mon, Oct 12, 2020 at 3:15 PM Geert Uytterhoeven wrote: > > Given this feature is SoC-specific, not platform-specific, perhaps > it makes sense to move the selects to the M68{,EZ,VZ}328 symbols? > > Regardless: > Reviewed-by: Geert Uytterhoeven Ok, folded in the change blow, using one less

Re: [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property

2020-10-12 Thread Neil Armstrong
On 12/10/2020 17:13, Serge Semin wrote: > On Mon, Oct 12, 2020 at 05:01:43PM +0200, Neil Armstrong wrote: >> Hi, >> >> On 12/10/2020 16:22, Serge Semin wrote: >>> On Mon, Oct 12, 2020 at 09:54:25AM +0200, Neil Armstrong wrote: Hi, On 11/10/2020 00:41, Serge Semin wrote: > An

Re: [PATCHv3] selftests: rtnetlink: load fou module for kci_test_encap_fou() test

2020-10-12 Thread Jakub Kicinski
On Mon, 12 Oct 2020 13:56:15 +0800 Po-Hsu Lin wrote: > Is there any update on this patch? You received feedback. Don't remove modules after tests, something else could be using them.

[PATCH v2 2/2] dt-bindings: extcon: add binding for TUSB320

2020-10-12 Thread Michael Auchter
Add a device tree binding for the TI TUSB320. Signed-off-by: Michael Auchter --- Changes since v1: - use tusb320 instead of extcon in the unit name .../bindings/extcon/extcon-usbc-tusb320.yaml | 41 +++ 1 file changed, 41 insertions(+) create mode 100644

Re: [PATCH] perf c2c: Update usage for showing memory events

2020-10-12 Thread Ian Rogers
On Mon, Oct 12, 2020 at 2:13 AM Jiri Olsa wrote: > > On Sun, Oct 11, 2020 at 08:10:22PM +0800, Leo Yan wrote: > > Since commit b027cc6fdf1b ("perf c2c: Fix 'perf c2c record -e list' to > > show the default events used"), "perf c2c" tool can show the memory > > events properly, it's no reason to

Re: [PATCH v2 2/5] of/address: Introduce of_dma_lower_bus_limit()

2020-10-12 Thread Rob Herring
On Sat, Oct 10, 2020 at 10:12 AM Nicolas Saenz Julienne wrote: > > The function provides the CPU physical address addressable by the most > constrained bus in the system. It might be useful in order to > dynamically set up memory zones during boot. > > Signed-off-by: Nicolas Saenz Julienne > ---

[PATCH v3] kcov, usb: specify contexts for remote coverage sections

2020-10-12 Thread Andrey Konovalov
Currently there's a KCOV remote coverage collection section in __usb_hcd_giveback_urb(). Initially that section was added based on the assumption that usb_hcd_giveback_urb() can only be called in interrupt context as indicated by a comment before it. This is what happens when syzkaller is fuzzing

Re: [linux-safety] [PATCH] usb: host: ehci-sched: add comment about find_tt() not returning error

2020-10-12 Thread Sudip Mukherjee
Hi Lukas, On Mon, Oct 12, 2020 at 3:11 PM Lukas Bulwahn wrote: > > > > On Sun, 11 Oct 2020, Sudip Mukherjee wrote: > > > Add a comment explaining why find_tt() will not return error even though > > find_tt() is checking for NULL and other errors. > > > > Signed-off-by: Sudip Mukherjee > > I get

Re: [RFC PATCH] checkpatch: add shebang check to EXECUTE_PERMISSIONS

2020-10-12 Thread Joe Perches
On Mon, 2020-10-12 at 16:16 +0200, Lukas Bulwahn wrote: > On Mon, 12 Oct 2020, Ujjwal Kumar wrote: > > On 12/10/20 11:47 am, Joe Perches wrote: > > > On Mon, 2020-10-12 at 11:19 +0530, Ujjwal Kumar wrote: > > > > checkpatch.pl checks for invalid EXECUTE_PERMISSIONS on source > > > > files. The

Re: [v4 PATCH 0/2] fix scrolling of panel with small hfp or hbp

2020-10-12 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年10月10日 週六 下午3:09寫道: > > Changes since v3: > - Revert v2, for v2 will cause some bridge ic no output. the cause >the video linetime doesn't match display mode from get mode. > - Make sure the horizontal_frontporch_byte and horizontal_backporch_byte >are > 0.

Re: [PATCH] mm: Make allocator take care of memoryless numa node

2020-10-12 Thread Christopher Lameter
On Mon, 12 Oct 2020, Xianting Tian wrote: > In architecture like powerpc, we can have cpus without any local memory > attached to it. In such cases the node does not have real memory. > > In many places of current kernel code, it doesn't judge whether the node is > memoryless numa node before

[GIT PULL] EFI changes for v5.10

2020-10-12 Thread Ingo Molnar
Linus, Please pull the latest efi/core git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git efi-core-2020-10-12 # HEAD: 4d0a4388ccdd9482fef6b26f879d0f6099143f80 Merge branch 'efi/urgent' into efi/core, to pick up fixes EFI changes for v5.10: - Preliminary RISC-V

Re: [ANNOUNCE] libtraceevent.git

2020-10-12 Thread Steven Rostedt
On Mon, 12 Oct 2020 12:12:08 +0200 Jiri Olsa wrote: > On Wed, Oct 07, 2020 at 01:07:50PM -0400, Steven Rostedt wrote: > > I split out tools/lib/traceevent from the kernel tree using "git subtree", > > which recreates all the commits of a directory and makes that directory a > > stand alone. I

[PATCH] checkpatch: improve EXECUTE_PERMISSIONS tests

2020-10-12 Thread Ujjwal Kumar
1. Use group capture regexp for file mode test to improve code readability. 2. The 'scripts/' directory test on filenames can be excluded as it has become obsolete because there are many source files that are not scripts in this directory and its subdirectories. 3. Replace

Re: [linux-safety] [PATCH] usb: host: ehci-sched: add comment about find_tt() not returning error

2020-10-12 Thread Greg Kroah-Hartman
On Mon, Oct 12, 2020 at 05:10:21PM +0200, Lukas Bulwahn wrote: > And for the static analysis finding, we need to find a way to ignore this > finding without simply ignoring all findings or new findings that just > look very similar to the original finding, but which are valid. Then I suggest

Re: [PATCH] net: ethernet: ixgbe: don't propagate -ENODEV from ixgbe_mii_bus_init()

2020-10-12 Thread Jakub Kicinski
On Mon, 12 Oct 2020 14:20:16 +0200 Bartosz Golaszewski wrote: > On Mon, Sep 28, 2020 at 9:17 AM Bartosz Golaszewski wrote: > > > > From: Bartosz Golaszewski > > > > It's a valid use-case for ixgbe_mii_bus_init() to return -ENODEV - we > > still want to finalize the registration of the ixgbe

Re: [PATCH] kthread: Add kthread_work tracepoints

2020-10-12 Thread Rob Clark
On Mon, Oct 12, 2020 at 6:59 AM Steven Rostedt wrote: > > On Sat, 10 Oct 2020 11:03:22 -0700 > Rob Clark wrote: > > > /** > > + * sched_kthread_work_execute_start - called immediately before the work > > callback > > + * @work:pointer to struct kthread_work > > + * > > + * Allows to track

Re: [PATCH 0/5] tracing: Synthetic event dynamic string fixes

2020-10-12 Thread Steven Rostedt
On Fri, 9 Oct 2020 10:17:06 -0500 Tom Zanussi wrote: > These patches provide fixes for the problems observed by Masami in the > new synthetic event dynamic string patchset. > > The first patch (tracing: Don't show dynamic string internals in > synthetic event description) removes the

Re: [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property

2020-10-12 Thread Serge Semin
On Mon, Oct 12, 2020 at 05:01:43PM +0200, Neil Armstrong wrote: > Hi, > > On 12/10/2020 16:22, Serge Semin wrote: > > On Mon, Oct 12, 2020 at 09:54:25AM +0200, Neil Armstrong wrote: > >> Hi, > >> > >> On 11/10/2020 00:41, Serge Semin wrote: > >>> An empty snps,quirk-frame-length-adjustment won't

Re: [PATCH 1/1] tracing/boot: Add ftrace.instance.*.alloc_snapshot option

2020-10-12 Thread Steven Rostedt
On Sun, 11 Oct 2020 00:28:09 +0900 Masami Hiramatsu wrote: > Add ftrace.instance.*.alloc_snapshot option. > > This option has been described in Documentation/trace/boottime-trace.rst > but not implemented yet. > > ftrace.[instance.INSTANCE.]alloc_snapshot >Allocate snapshot buffer. > >

Re: [linux-safety] [PATCH] usb: host: ehci-sched: add comment about find_tt() not returning error

2020-10-12 Thread Lukas Bulwahn
On Mon, 12 Oct 2020, Alan Stern wrote: > On Mon, Oct 12, 2020 at 04:11:38PM +0200, Lukas Bulwahn wrote: > > > > > > On Sun, 11 Oct 2020, Sudip Mukherjee wrote: > > > > > Add a comment explaining why find_tt() will not return error even though > > > find_tt() is checking for NULL and other

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-12 Thread Guillaume Tucker
On 12/10/2020 15:40, Willy Tarreau wrote: > On Mon, Oct 12, 2020 at 04:32:12PM +0200, Borislav Petkov wrote: >> On Mon, Oct 12, 2020 at 11:22:10AM +0100, Guillaume Tucker wrote: >>> However, it was found while adding some x86 Chromebooks[1] to >>> KernelCI that x86_64_defconfig lacked some basic

Re: [PATCH] trace: Fix some typos in comment

2020-10-12 Thread Steven Rostedt
On Sat, 10 Oct 2020 22:09:24 +0800 Qiujun Huang wrote: > s/wihin/within/ > s/retrieven/retrieved/ > s/suppport/support/ > s/wil/will/ > s/accidently/accidentally/ > s/if the if the/if the/ > > Signed-off-by: Qiujun Huang Thanks, I queued this up. -- Steve

Re: [PATCH v2 22/22] drm/msm: Don't implicit-sync if only a single ring

2020-10-12 Thread Rob Clark
On Mon, Oct 12, 2020 at 7:40 AM Daniel Vetter wrote: > > On Sun, Oct 11, 2020 at 07:09:49PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > Any cross-device sync use-cases *must* use explicit sync. And if there > > is only a single ring (no-preemption), everything is FIFO order and > >

Re: [RFC PATCH] checkpatch: add shebang check to EXECUTE_PERMISSIONS

2020-10-12 Thread Joe Perches
On Mon, 2020-10-12 at 19:22 +0530, Ujjwal Kumar wrote: > On 12/10/20 11:47 am, Joe Perches wrote: > > On Mon, 2020-10-12 at 11:19 +0530, Ujjwal Kumar wrote: > > > checkpatch.pl checks for invalid EXECUTE_PERMISSIONS on source > > > files. The script leverages filename extensions and its path in >

Re: [PATCH] mm: Make allocator take care of memoryless numa node

2020-10-12 Thread Michal Hocko
On Mon 12-10-20 16:27:39, Xianting Tian wrote: > In architecture like powerpc, we can have cpus without any local memory > attached to it. In such cases the node does not have real memory. Yes, this is normal (unfortunately). > In many places of current kernel code, it doesn't judge whether the

Re: [PATCH -v3] checkpatch: Check for .byte-spelled insn opcodes documentation on x86

2020-10-12 Thread Joe Perches
On Mon, 2020-10-12 at 16:23 +0200, Borislav Petkov wrote: > From: Borislav Petkov [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -408,6 +408,7 @@ our $Lval = qr{$Ident(?:$Member)*}; > our $Int_type= qr{(?i)llu|ull|ll|lu|ul|l|u}; > our $Binary =

Re: Missing [GIT PULL] request for

2020-10-12 Thread Sedat Dilek
On Mon, Oct 12, 2020 at 3:42 PM Ingo Molnar wrote: > > > * Sedat Dilek wrote: > > > Hi, > > > > yesterday, I saw Ingo tagged "locking-urgent-2020-10-11" in tip Git. > > > > Did you drop it or was this for Linux v5.9 final and the git-pull > > request was simply forgotten? > > > > Just curious. >

Re: [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property

2020-10-12 Thread Neil Armstrong
Hi, On 12/10/2020 16:22, Serge Semin wrote: > On Mon, Oct 12, 2020 at 09:54:25AM +0200, Neil Armstrong wrote: >> Hi, >> >> On 11/10/2020 00:41, Serge Semin wrote: >>> An empty snps,quirk-frame-length-adjustment won't cause any change >>> performed by the driver. Moreover the DT schema validation

Re: [PATCH] checkpatch: Check for .byte-spelled insn opcodes documentation on x86

2020-10-12 Thread Joe Perches
On Mon, 2020-10-12 at 16:21 +0200, Borislav Petkov wrote: > On Sat, Oct 10, 2020 at 09:47:59AM -0700, Joe Perches wrote: > > > '/\s*\.byte\s+(?:0x[0-9a-f]{1,2}[\s,]*){2,}/i' > > ^^^ ^ > > now useless without the " > > There are \.byte specifications

Re: [PATCH v3 2/2] media: mtk-vcodec: fix build breakage when one of VPU or SCP is enabled

2020-10-12 Thread Randy Dunlap
On 10/11/20 10:35 PM, Alexandre Courbot wrote: > The addition of MT8183 support added a dependency on the SCP remoteproc > module. However the initial patch used the "select" Kconfig directive, > which may result in the SCP module to not be compiled if remoteproc was > disabled. In such a case,

Re: LPC 2020 Hackroom Session: summary and next steps for isolated user namespaces

2020-10-12 Thread Serge E. Hallyn
On Mon, Oct 12, 2020 at 12:01:09AM -0500, Eric W. Biederman wrote: > Andy Lutomirski writes: > > > On Sun, Oct 11, 2020 at 1:53 PM Josh Triplett wrote: > >> > >> On Fri, Oct 09, 2020 at 11:26:06PM -0500, Serge E. Hallyn wrote: > >> > > 3. Find a way to allow setgroups() in a user namespace

Re: [PATCH v3 11/15] MIPS: generic: Add support for Ingenic SoCs

2020-10-12 Thread Paul Cercueil
Hi Guenter, Le lun. 12 oct. 2020 à 7:33, Guenter Roeck a écrit : On Sun, Sep 06, 2020 at 09:29:31PM +0200, Paul Cercueil wrote: Add support for Ingenic SoCs in arch/mips/generic/. The Kconfig changes are here to ensure that it is possible to compile either a generic kernel that supports

[PATCH v2 1/2] extcon: add driver for TI TUSB320

2020-10-12 Thread Michael Auchter
This patch adds an extcon driver for the TI TUSB320 USB Type-C device. This can be used to detect whether the port is configured as a downstream or upstream facing port. Signed-off-by: Michael Auchter --- Changes since v1: - Drop license text that's redundant with SPDX tag - Cleanup, sort list

Re: [linux-safety] [PATCH] usb: host: ehci-sched: add comment about find_tt() not returning error

2020-10-12 Thread Alan Stern
On Mon, Oct 12, 2020 at 04:11:38PM +0200, Lukas Bulwahn wrote: > > > On Sun, 11 Oct 2020, Sudip Mukherjee wrote: > > > Add a comment explaining why find_tt() will not return error even though > > find_tt() is checking for NULL and other errors. > > > > Signed-off-by: Sudip Mukherjee > > I

Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call

2020-10-12 Thread Sinan Kaya
On 10/12/2020 1:13 AM, Kuppuswamy, Sathyanarayanan wrote: > Hi Sinan, > > On 9/28/20 11:32 AM, Kuppuswamy, Sathyanarayanan wrote: >> >> >> On 9/28/20 11:25 AM, Sinan Kaya wrote: >>> On 9/28/2020 2:02 PM, Sinan Kaya wrote: Since there is no state restoration for FATAL errors, I am wondering

general protection fault in scsi_queue_rq

2020-10-12 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:e4fb79c7 Add linux-next specific files for 20201008 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=125c9a9f90 kernel config: https://syzkaller.appspot.com/x/.config?x=568d41fe4341ed0f dashboard

[PATCH 3/3] selftests: Add VRF route leaking tests

2020-10-12 Thread Mathieu Desnoyers
From: Michael Jeanson The objective of the tests is to check that ICMP errors generated while crossing between VRFs are properly routed back to the source host. The first ttl test sends a ping with a ttl of 1 from h1 to h2 and parses the output of the command to check that a ttl expired error

Re: [PATCH v4 1/2] PCI/ERR: Call pci_bus_reset() before calling ->slot_reset() callback

2020-10-12 Thread Sinan Kaya
On 10/12/2020 1:03 AM, sathyanarayanan.nkuppusw...@gmail.com wrote: > From: Kuppuswamy Sathyanarayanan > > Currently if report_error_detected() or report_mmio_enabled() > functions requests PCI_ERS_RESULT_NEED_RESET, current > pcie_do_recovery() implementation does not do the requested >

[PATCH 2/3] ipv6/icmp: l3mdev: Perform icmp error route lookup on source device routing table (v2)

2020-10-12 Thread Mathieu Desnoyers
As per RFC4443, the destination address field for ICMPv6 error messages is copied from the source address field of the invoking packet. In configurations with Virtual Routing and Forwarding tables, looking up which routing table to use for sending ICMPv6 error messages is currently done by using

[PATCH 1/3] ipv4/icmp: l3mdev: Perform icmp error route lookup on source device routing table (v2)

2020-10-12 Thread Mathieu Desnoyers
As per RFC792, ICMP errors should be sent to the source host. However, in configurations with Virtual Routing and Forwarding tables, looking up which routing table to use is currently done by using the destination net_device. commit 9d1a6c4ea43e ("net: icmp_route_lookup should use rt dev to

[PATCH 0/3] l3mdev icmp error route lookup fixes

2020-10-12 Thread Mathieu Desnoyers
Hi, Here is a series of fixes for ipv4 and ipv6 which ensure the route lookup is performed on the right routing table in VRF configurations when sending TTL expired icmp errors (useful for traceroute). It includes tests for both ipv4 and ipv6. These fixes address specifically address the code

Re: [PATCH v4 2/2] PCI/ERR: Split the fatal and non-fatal error recovery handling

2020-10-12 Thread Sinan Kaya
On 10/12/2020 1:03 AM, sathyanarayanan.nkuppusw...@gmail.com wrote: > From: Kuppuswamy Sathyanarayanan > > Commit bdb5ac85777d ("PCI/ERR: Handle fatal error recovery") > merged fatal and non-fatal error recovery paths, and also made > recovery code depend on hotplug handler for "remove affected

[GIT PULL] printk for 5.10 (includes lockless ringbuffer)

2020-10-12 Thread Petr Mladek
Linus, please pull the latest printk changes from git://git.kernel.org/pub/scm/linux/kernel/git/printk/linux tags/printk-for-5.10 - Fully lockless ringbuffer implementation, including the support for continuous lines. It will allow to store and read messages

Re: [PATCH 2/2] dt-bindings: arm: sunxi: Fix Orange Pi Zero bindings

2020-10-12 Thread Maxime Ripard
On Thu, Oct 08, 2020 at 08:40:06PM +0200, Michal Suchanek wrote: > There are two models of Orange Pi zero which are confusingly marketed > under the same name. Old model comes without a flash memory and current > model does have a flash memory. Add bindings for each model. > > Signed-off-by:

Re: [PATCH v3 1/2] tracing: support "bool" type in synthetic trace events

2020-10-12 Thread Steven Rostedt
On Mon, 12 Oct 2020 09:26:13 -0500 Tom Zanussi wrote: > Hi Steve, > > Looks ok to me. > > Acked-by: Tom Zanussi Great! I'll pull this patch into my tree. It doesn't look like patch 2/2 is dependent on this and these two can go through different trees. Is everyone OK if I take this patch

Re: [PATCH] trace: Return ENOTCONN instead of EBADF

2020-10-12 Thread Steven Rostedt
On Mon, 12 Oct 2020 14:26:48 + "Enderborg, Peter" wrote: > On 10/12/20 3:53 PM, Steven Rostedt wrote: > > On Mon, 12 Oct 2020 10:26:42 +0200 > > Peter Enderborg wrote: > > > >> When there is no clients listening on event the trace return > >> EBADF. The file is not a bad file descriptor

Re: [PATCH v2 08/17] s390/pci: Remove races against pte updates

2020-10-12 Thread Niklas Schnelle
... snip ... >>> Cc: linux-me...@vger.kernel.org >>> Cc: Niklas Schnelle >>> Cc: Gerald Schaefer >>> Cc: linux-s...@vger.kernel.org >>> -- >>> v2: Move VM_IO | VM_PFNMAP checks around so they keep returning EINVAL >>> like before (Gerard) >> >> I think the above should go before the

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-12 Thread Willy Tarreau
On Mon, Oct 12, 2020 at 04:32:12PM +0200, Borislav Petkov wrote: > On Mon, Oct 12, 2020 at 11:22:10AM +0100, Guillaume Tucker wrote: > > However, it was found while adding some x86 Chromebooks[1] to > > KernelCI that x86_64_defconfig lacked some basic things for > > anyone to be able to boot a

Re: [PATCH v2 22/22] drm/msm: Don't implicit-sync if only a single ring

2020-10-12 Thread Daniel Vetter
On Sun, Oct 11, 2020 at 07:09:49PM -0700, Rob Clark wrote: > From: Rob Clark > > Any cross-device sync use-cases *must* use explicit sync. And if there > is only a single ring (no-preemption), everything is FIFO order and > there is no need to implicit-sync. > > Mesa should probably just

Re: [tip:x86/pti] BUILD SUCCESS WITH WARNING 767d46ab566dd489733666efe48732d523c8c332

2020-10-12 Thread Borislav Petkov
On Mon, Oct 12, 2020 at 05:16:54PM +0800, Rong Chen wrote: > We have added the reported links in the report, you can find it in the > latest tip report: > > [tip:master] BUILD REGRESSION 820e6f502f021417140bc8ee11f9c7be148ea844 > >

Re: [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-10-12 Thread Daniel Vetter
On Sun, Oct 11, 2020 at 07:09:34PM -0700, Rob Clark wrote: > From: Rob Clark > > Unfortunately, due to an dev_pm_opp locking interaction with > mm->mmap_sem, we need to do pm get before aquiring obj locks, > otherwise we can have anger lockdep with the chain: tbh this sounds like a bug in that

Re: Missing [GIT PULL] request for

2020-10-12 Thread Sedat Dilek
On Mon, Oct 12, 2020 at 3:42 PM Ingo Molnar wrote: > > > * Sedat Dilek wrote: > > > Hi, > > > > yesterday, I saw Ingo tagged "locking-urgent-2020-10-11" in tip Git. > > > > Did you drop it or was this for Linux v5.9 final and the git-pull > > request was simply forgotten? > > > > Just curious. >

Re: [PATCH] trace: Return ENOTCONN instead of EBADF

2020-10-12 Thread Enderborg, Peter
On 10/12/20 3:53 PM, Steven Rostedt wrote: > On Mon, 12 Oct 2020 10:26:42 +0200 > Peter Enderborg wrote: > >> When there is no clients listening on event the trace return >> EBADF. The file is not a bad file descriptor and to get the >> userspace able to do a proper error handling it need a

Re: [PATCH v3 11/15] MIPS: generic: Add support for Ingenic SoCs

2020-10-12 Thread Guenter Roeck
On Sun, Sep 06, 2020 at 09:29:31PM +0200, Paul Cercueil wrote: > Add support for Ingenic SoCs in arch/mips/generic/. > > The Kconfig changes are here to ensure that it is possible to compile > either a generic kernel that supports Ingenic SoCs, or a Ingenic-only > kernel, both using the same code

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-12 Thread Borislav Petkov
On Mon, Oct 12, 2020 at 11:22:10AM +0100, Guillaume Tucker wrote: > However, it was found while adding some x86 Chromebooks[1] to > KernelCI that x86_64_defconfig lacked some basic things for > anyone to be able to boot a kernel with a serial console enabled > on those. Hold on, those are

Re: [PATCH v9 1/6] fpga: dfl: fix the definitions of type & feature_id for dfl devices

2020-10-12 Thread Greg KH
On Mon, Oct 12, 2020 at 07:07:55AM -0700, Tom Rix wrote: > > On 10/11/20 7:41 PM, Xu Yilun wrote: > > On Sat, Oct 10, 2020 at 08:07:07AM -0700, Tom Rix wrote: > >> On 10/10/20 12:09 AM, Xu Yilun wrote: > >>> The value of the field dfl_device.type comes from the 12 bits register > >>> field DFH_ID

[GIT PULL] hwmon updates for v5.10

2020-10-12 Thread Guenter Roeck
Hi Linus, Please pull hwmon updates for Linux v5.10 from signed tag: git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-for-v5.10 Thanks, Guenter -- The following changes since commit ba4f184e126b751d1bffad5897f263108befc780: Linux 5.9-rc6 (2020-09-20

Re: [PATCH v2] leds: lm3697: Rename struct into more appropriate name

2020-10-12 Thread Dan Murphy
Pavel On 10/10/20 4:50 PM, Marek Behun wrote: On Sat, 10 Oct 2020 20:57:00 +0200 Pavel Machek wrote: On Fri 2020-10-09 15:51:35, Gabriel David wrote: The mentioned struct, lm3697_led, was renamed to lm3697_bank since the structure is representing the control banks. This name, in my opinion,

Re: [RFC PATCH 0/3] l3mdev icmp error route lookup fixes

2020-10-12 Thread David Ahern
On 10/12/20 7:10 AM, Mathieu Desnoyers wrote: > - On Oct 12, 2020, at 9:45 AM, David Ahern dsah...@gmail.com wrote: > >> On 10/12/20 5:57 AM, Mathieu Desnoyers wrote: >>> OK, do you want to pick up the RFC patch series, or should I re-send it >>> without RFC tag ? >> >> you need to re-send

Re: [PATCH v3 1/2] tracing: support "bool" type in synthetic trace events

2020-10-12 Thread Tom Zanussi
Hi Steve, Looks ok to me. Acked-by: Tom Zanussi Thanks, Tom On Mon, 2020-10-12 at 10:15 -0400, Steven Rostedt wrote: > Tom, > > Can you ack this patch for me? > > -- Steve > > > On Fri, 9 Oct 2020 15:05:23 -0700 > Axel Rasmussen wrote: > > > It's common [1] to define tracepoint

Re: [PATCH][next] io_uring: Fix sizeof() mismatch

2020-10-12 Thread Jens Axboe
On 10/12/20 8:03 AM, Colin King wrote: > From: Colin Ian King > > An incorrect sizeof() is being used, sizeof(file_data->table) is not > correct, it should be sizeof(*file_data->table). Thanks, should be a no-op, which is why KASAN didn't complain in my testing. I'll queue this up, thanks. --

Re: [PATCH v2 1/5] arm64: mm: Move zone_dma_bits initialization into zone_sizes_init()

2020-10-12 Thread Ard Biesheuvel
On Mon, 12 Oct 2020 at 13:37, Catalin Marinas wrote: > > On Sat, Oct 10, 2020 at 05:12:31PM +0200, Nicolas Saenz Julienne wrote: > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c > > index f6902a2b4ea6..0eca5865dcb1 100644 > > --- a/arch/arm64/mm/init.c > > +++ b/arch/arm64/mm/init.c >

Re: [PATCH 2/2] mm: introduce vma_set_file function v4

2020-10-12 Thread kernel test robot
Hi "Christian, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on staging/staging-testing linus/master v5.9 next-20201012] [cannot apply to mmotm/master] [If your patch is applied to the wrong git tree, kindly dr

<    3   4   5   6   7   8   9   10   11   12   >