[patch V2 14/18] mm/highmem: Remove the old kmap_atomic cruft

2020-10-29 Thread Thomas Gleixner
All users gone. Signed-off-by: Thomas Gleixner --- include/linux/highmem.h | 61 ++-- mm/highmem.c| 28 ++ 2 files changed, 27 insertions(+), 62 deletions(-) --- a/include/linux/highmem.h +++

[patch V2 03/18] highmem: Provide generic variant of kmap_atomic*

2020-10-29 Thread Thomas Gleixner
The kmap_atomic* interfaces in all architectures are pretty much the same except for post map operations (flush) and pre- and post unmap operations. Provide a generic variant for that. Signed-off-by: Thomas Gleixner Cc: Andrew Morton Cc: linux...@kvack.org --- V2: Address review comments from

[patch V2 12/18] sparc/mm/highmem: Switch to generic kmap atomic

2020-10-29 Thread Thomas Gleixner
No reason having the same code in every architecture Signed-off-by: Thomas Gleixner Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org --- arch/sparc/Kconfig |1 arch/sparc/include/asm/highmem.h |7 +- arch/sparc/mm/Makefile |3 - arch/sparc/mm/highmem.c

[patch V2 09/18] mips/mm/highmem: Switch to generic kmap atomic

2020-10-29 Thread Thomas Gleixner
No reason having the same code in every architecture Signed-off-by: Thomas Gleixner Cc: Thomas Bogendoerfer Cc: linux-m...@vger.kernel.org diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index 8f328298f8cc..ed6b3de944a8 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -2654,6

[patch V2 08/18] microblaze/mm/highmem: Switch to generic kmap atomic

2020-10-29 Thread Thomas Gleixner
No reason having the same code in every architecture. Signed-off-by: Thomas Gleixner Cc: Michal Simek diff --git a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig index d262ac0c8714..186a0526564c 100644 --- a/arch/microblaze/Kconfig +++ b/arch/microblaze/Kconfig @@ -170,6 +170,7 @@ config

[patch V2 10/18] nds32/mm/highmem: Switch to generic kmap atomic

2020-10-29 Thread Thomas Gleixner
The mapping code is odd and looks broken. See FIXME in the comment. Signed-off-by: Thomas Gleixner Cc: Nick Hu Cc: Greentime Hu Cc: Vincent Chen diff --git a/arch/nds32/Kconfig.cpu b/arch/nds32/Kconfig.cpu index f88a12fdf0f3..c7add11ea36e 100644 --- a/arch/nds32/Kconfig.cpu +++

[patch V2 00/18] mm/highmem: Preemptible variant of kmap_atomic & friends

2020-10-29 Thread Thomas Gleixner
Following up to the discussion in: https://lore.kernel.org/r/20200914204209.256266...@linutronix.de and the initial version of this: https://lore.kernel.org/r/20200919091751.06...@linutronix.de this series provides a preemptible variant of kmap_atomic & related interfaces. Now that

[patch V2 13/18] xtensa/mm/highmem: Switch to generic kmap atomic

2020-10-29 Thread Thomas Gleixner
No reason having the same code in every architecture Signed-off-by: Thomas Gleixner Cc: Chris Zankel Cc: Max Filippov Cc: linux-xte...@linux-xtensa.org --- arch/xtensa/Kconfig |1 arch/xtensa/include/asm/highmem.h |9 +++ arch/xtensa/mm/highmem.c | 44

[patch V2 17/18] mm/highmem: Provide kmap_local*

2020-10-29 Thread Thomas Gleixner
Now that the kmap atomic index is stored in task struct provide a preemptible variant. On context switch the maps of an outgoing task are removed and the map of the incoming task are restored. That's obviously slow, but highmem is slow anyway. The kmap_local.*() functions can be invoked from both

Re: [RFC PATCH v3 9/9] ipu3-cio2: Add functionality allowing software_node connections to sensors on platforms designed for Windows

2020-10-29 Thread Dan Scally
Hi both On 29/10/2020 20:17, Laurent Pinchart wrote: > Hi Andy, > > On Mon, Oct 26, 2020 at 06:05:49PM +0200, Andy Shevchenko wrote: >> On Mon, Oct 26, 2020 at 08:20:14AM +, Dan Scally wrote: >>> On 24/10/2020 23:36, Laurent Pinchart wrote: On Sat, Oct 24, 2020 at 11:28:06PM +0100,

Re: [PATCH 6/9] mfd: stmfx: remove unnecessary CONFIG_PM_SLEEP

2020-10-29 Thread kernel test robot
Hi Coiby, Thank you for the patch! Yet something to improve: [auto build test ERROR on lee-mfd/for-mfd-next] [also build test ERROR on chanwoo-extcon/extcon-next v5.10-rc1 next-20201029] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

[PATCH v2] libbpf hashmap: Fix undefined behavior in hash_bits

2020-10-29 Thread Ian Rogers
If bits is 0, the case when the map is empty, then the >> is the size of the register which is undefined behavior - on x86 it is the same as a shift by 0. Fix by handling the 0 case explicitly and guarding calls to hash_bits for empty maps in hashmap__for_each_key_entry and

[tip:core/entry] BUILD SUCCESS WITH WARNING 45ff510517f3b1354a3d9c273ad5e5e8d08312cb

2020-10-29 Thread kernel test robot
Warning ids grouped by kconfigs: gcc_recent_errors |-- i386-randconfig-m021-20201029 | `-- kernel-entry-common.c-handle_signal_work()-warn:bitwise-AND-condition-is-false-here `-- x86_64-randconfig-m001-20201029 `-- kernel-entry-common.c-handle_signal_work()-warn:bitwise-AND-condition

Re: [PATCH v2] libbpf hashmap: Fix undefined behavior in hash_bits

2020-10-29 Thread Andrii Nakryiko
On Thu, Oct 29, 2020 at 3:38 PM Ian Rogers wrote: > > If bits is 0, the case when the map is empty, then the >> is the size of > the register which is undefined behavior - on x86 it is the same as a > shift by 0. Fix by handling the 0 case explicitly and guarding calls to > hash_bits for empty

[PATCH] clk: imx: remove redundant assignment to pointer np

2020-10-29 Thread Colin King
From: Colin Ian King Pointer np is being initialized with a value that is never read and it is being updated with a value later on. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/clk/imx/clk-imx8mp.c | 2 +- 1

[Build fail] i386 & nvdimm is unhappy

2020-10-29 Thread Thomas Gleixner
Dan, x86 32bit build fails with the config below with this: ERROR: modpost: "phys_to_target_node" [drivers/nvdimm/nd_e820.ko] undefined! Thanks, tglx --- # # Automatically generated file; DO NOT EDIT. # Linux/i386 5.10.0-rc1 Kernel Configuration # CONFIG_CC_VERSION_TEXT="gcc

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-10-29 Thread Arnd Bergmann
On Sun, Oct 18, 2020 at 11:44 PM Syed Nayyar Waris wrote: > > This patch reimplements the xgpio_set_multiple() function in > drivers/gpio/gpio-xilinx.c to use the new generic functions: > bitmap_get_value() and bitmap_set_value(). The code is now simpler > to read and understand. Moreover,

Re: [PATCH v19 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-29 Thread Mathieu Poirier
Hi Ben, On Mon, Oct 19, 2020 at 03:40:07PM -0700, Ben Levinsky wrote: > R5 is included in Xilinx Zynq UltraScale MPSoC so by adding this > remotproc driver, we can boot the R5 sub-system in different 2 > configurations - > * split > * lock-step > > The Xilinx R5 Remoteproc Driver

Re: [PATCH v19 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-10-29 Thread Mathieu Poirier
On Mon, Oct 19, 2020 at 03:40:06PM -0700, Ben Levinsky wrote: > Add binding for ZynqMP R5 OpenAMP. > > Represent the RPU domain resources in one device node. Each RPU > processor is a subnode of the top RPU domain node. > > Signed-off-by: Jason Wu > Signed-off-by: Wendy Liang > Signed-off-by:

Re: [RFC PATCH v3 9/9] ipu3-cio2: Add functionality allowing software_node connections to sensors on platforms designed for Windows

2020-10-29 Thread Laurent Pinchart
Hi Andy, On Fri, Oct 30, 2020 at 12:22:15AM +0200, Andy Shevchenko wrote: > On Thu, Oct 29, 2020 at 11:29:30PM +0200, Laurent Pinchart wrote: > > On Thu, Oct 29, 2020 at 10:26:56PM +0200, Andy Shevchenko wrote: > > > On Thu, Oct 29, 2020 at 10:21 PM Laurent Pinchart wrote: > > > > On Mon, Oct 26,

Re: [Build fail] i386 & nvdimm is unhappy

2020-10-29 Thread Dan Williams
On Thu, Oct 29, 2020 at 3:44 PM Thomas Gleixner wrote: > > Dan, > > x86 32bit build fails with the config below with this: > > ERROR: modpost: "phys_to_target_node" [drivers/nvdimm/nd_e820.ko] > undefined! Acknowledged, I'm on it. Wonder how 0-day missed this or I missed the 0-day report?

Re: [PATCH v19 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-29 Thread Mathieu Poirier
On Mon, Oct 19, 2020 at 03:40:07PM -0700, Ben Levinsky wrote: > R5 is included in Xilinx Zynq UltraScale MPSoC so by adding this > remotproc driver, we can boot the R5 sub-system in different 2 > configurations - > * split > * lock-step > > The Xilinx R5 Remoteproc Driver boots the

Re: [PATCH v2] libbpf hashmap: Fix undefined behavior in hash_bits

2020-10-29 Thread Song Liu
> On Oct 29, 2020, at 3:38 PM, Andrii Nakryiko > wrote: > > On Thu, Oct 29, 2020 at 3:38 PM Ian Rogers wrote: >> >> If bits is 0, the case when the map is empty, then the >> is the size of >> the register which is undefined behavior - on x86 it is the same as a >> shift by 0. Fix by

Re: [PATCH -next] net: stmmac: platform: remove useless if/else

2020-10-29 Thread Jakub Kicinski
On Thu, 29 Oct 2020 13:34:45 +0100 Andrew Lunn wrote: > On Thu, Oct 29, 2020 at 10:33:52AM +0800, Zou Wei wrote: > > Fix the following coccinelle report: > > > > ./drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:233:6-8: > > WARNING: possible condition with no effect (if == else) > > > >

Re: [PATCH v4 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-29 Thread Lukasz Stelmach
It was <2020-10-29 czw 18:27>, when Marc Kleine-Budde wrote: > On 10/28/20 10:40 PM, Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> >> The driver has

Re: [PATCH net-next v3 1/4] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

2020-10-29 Thread Xie He
On Thu, Oct 29, 2020 at 10:00 AM Willem de Bruijn wrote: > > This does change rx_dropped count on errors. Not sure how important > that is. But perhaps good to call out in the commit explicitly if it's > intentional. Yes, this is intentional, because I think we need to count it as a "drop"

Re: [patch V2 00/18] mm/highmem: Preemptible variant of kmap_atomic & friends

2020-10-29 Thread Linus Torvalds
On Thu, Oct 29, 2020 at 3:32 PM Thomas Gleixner wrote: > > > Though I wanted to share the current state of affairs before investigating > that further. If there is consensus in going forward with this, I'll have a > deeper look into this issue. Me likee. I think this looks like the right thing

Re: [Build fail] i386 & nvdimm is unhappy

2020-10-29 Thread Philip Li
On Thu, Oct 29, 2020 at 03:52:42PM -0700, Dan Williams wrote: > On Thu, Oct 29, 2020 at 3:44 PM Thomas Gleixner wrote: > > > > Dan, > > > > x86 32bit build fails with the config below with this: > > > > ERROR: modpost: "phys_to_target_node" [drivers/nvdimm/nd_e820.ko] > > undefined! > >

Re: [PATCH 1/4] tools/power/cpupower: Read energy_perf_bias from sysfs

2020-10-29 Thread Borislav Petkov
On Thu, Oct 29, 2020 at 04:32:43PM -0600, Shuah Khan wrote: > if (numwritten < 1) { > +perror("write failed"); > > Please add filename to the error message. Yes, you said so already and will do that in the next version. -- Regards/Gruss, Boris.

Re: [PATCH bpf-next 1/5] bpf: Implement task local storage

2020-10-29 Thread Andrii Nakryiko
On Wed, Oct 28, 2020 at 9:17 AM KP Singh wrote: > > From: KP Singh > > Similar to bpf_local_storage for sockets and inodes add local storage > for task_struct. > > The life-cycle of storage is managed with the life-cycle of the > task_struct. i.e. the storage is destroyed along with the owning

Re: [Build fail] i386 & nvdimm is unhappy

2020-10-29 Thread Randy Dunlap
On 10/29/20 4:09 PM, Philip Li wrote: > On Thu, Oct 29, 2020 at 03:52:42PM -0700, Dan Williams wrote: >> On Thu, Oct 29, 2020 at 3:44 PM Thomas Gleixner wrote: >>> >>> Dan, >>> >>> x86 32bit build fails with the config below with this: >>> >>> ERROR: modpost: "phys_to_target_node"

Re: [PATCH net-next v3 2/4] net: hdlc_fr: Change the use of "dev" in fr_rx to make the code cleaner

2020-10-29 Thread Xie He
On Thu, Oct 29, 2020 at 9:58 AM Willem de Bruijn wrote: > > No need for dev at all then? Right, there's no need for "dev" at all actually. I kept "dev" just to keep the code for updating "dev->stats" simpler, because otherwise we need to write "skb->dev->stats" instead, and there are 3 lines

Re: [PATCH 0/4] arch, mm: improve robustness of direct map manipulation

2020-10-29 Thread Edgecombe, Rick P
On Thu, 2020-10-29 at 10:12 +0200, Mike Rapoport wrote: > This series goal was primarily to separate dependincies and make it > clearer what DEBUG_PAGEALLOC and what SET_DIRECT_MAP are. As it > turned > out, there is also some lack of consistency between architectures > that > implement either of

Re: [PATCH 2/4] PM: hibernate: improve robustness of mapping pages in the direct map

2020-10-29 Thread Edgecombe, Rick P
On Thu, 2020-10-29 at 09:54 +0200, Mike Rapoport wrote: > __kernel_map_pages() on arm64 will also bail out if rodata_full is > false: > void __kernel_map_pages(struct page *page, int numpages, int enable) > { > if (!debug_pagealloc_enabled() && !rodata_full) > return; > >

Re: [PATCH v3 2/2] vhost-vdpa: fix page pinning leakage in error path

2020-10-29 Thread si-wei liu
On 10/29/2020 2:53 PM, Michael S. Tsirkin wrote: On Thu, Oct 15, 2020 at 01:17:14PM -0700, si-wei liu wrote: On 10/15/2020 6:11 AM, Michael S. Tsirkin wrote: On Thu, Oct 15, 2020 at 02:15:32PM +0800, Jason Wang wrote: On 2020/10/14 上午7:42, si-wei liu wrote: So what I suggest is to fix the

Re: [PATCH bpf-next 1/5] bpf: Implement task local storage

2020-10-29 Thread Song Liu
On Wed, Oct 28, 2020 at 9:17 AM KP Singh wrote: > > From: KP Singh > > Similar to bpf_local_storage for sockets and inodes add local storage > for task_struct. > > The life-cycle of storage is managed with the life-cycle of the > task_struct. i.e. the storage is destroyed along with the owning

Re: [Build fail] i386 & nvdimm is unhappy

2020-10-29 Thread Randy Dunlap
On 10/29/20 4:13 PM, Randy Dunlap wrote: > On 10/29/20 4:09 PM, Philip Li wrote: >> On Thu, Oct 29, 2020 at 03:52:42PM -0700, Dan Williams wrote: >>> On Thu, Oct 29, 2020 at 3:44 PM Thomas Gleixner wrote: Dan, x86 32bit build fails with the config below with this:

Re: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset

2020-10-29 Thread Tony Krowiak
On 10/27/20 2:48 AM, Halil Pasic wrote: On Thu, 22 Oct 2020 13:11:56 -0400 Tony Krowiak wrote: The queues assigned to a matrix mediated device are currently reset when: * The VFIO_DEVICE_RESET ioctl is invoked * The mdev fd is closed by userspace (QEMU) * The mdev is removed from sysfs.

Geschäftsvorschlag 29.10.2020

2020-10-29 Thread WILLIAM YUN
-- Ich habe einen Geschäftsvorschlag, den ich mit Ihnen besprechen möchte. Für weitere Informationen wenden Sie sich bitte per E-Mail an: williamyun1...@gmail.com Grüße, William Yun Geschäftsführer, & Leiter Personal Banking, Hang Seng Bank, Hongkong. E-Mail: williamyun1...@gmail.com

Re: [patch V2 00/18] mm/highmem: Preemptible variant of kmap_atomic & friends

2020-10-29 Thread Thomas Gleixner
On Thu, Oct 29 2020 at 16:11, Linus Torvalds wrote: > On Thu, Oct 29, 2020 at 3:32 PM Thomas Gleixner wrote: >> >> Though I wanted to share the current state of affairs before investigating >> that further. If there is consensus in going forward with this, I'll have a >> deeper look into this

Re: INFO: rcu detected stall in security_file_open (3)

2020-10-29 Thread syzbot
syzbot suspects this issue was fixed by commit: commit 1d0e850a49a5b56f8f3cb51e74a11e2fedb96be6 Author: David Howells Date: Fri Oct 16 12:21:14 2020 + afs: Fix cell removal bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=14bc220a50 start commit: fb0155a0 Merge tag

Re: [Build fail] i386 & nvdimm is unhappy

2020-10-29 Thread Dan Williams
On Thu, Oct 29, 2020 at 4:29 PM Randy Dunlap wrote: > > On 10/29/20 4:13 PM, Randy Dunlap wrote: > > On 10/29/20 4:09 PM, Philip Li wrote: > >> On Thu, Oct 29, 2020 at 03:52:42PM -0700, Dan Williams wrote: > >>> On Thu, Oct 29, 2020 at 3:44 PM Thomas Gleixner > >>> wrote: > > Dan, >

Re: [PATCH net-next v2 4/4] net: hdlc_fr: Add support for any Ethertype

2020-10-29 Thread Xie He
On Thu, Oct 29, 2020 at 10:24 AM Willem de Bruijn wrote: > > > Also add skb_reset_mac_header before we pass an skb (received on normal > > PVC devices) to upper layers. Because we don't use header_ops for normal > > PVC devices, we should hide the header from upper layer code in this case. > >

Re: [PATCH v6 2/4] remoteproc: coredump: Add minidump functionality

2020-10-29 Thread Siddharth Gupta
On 10/26/2020 2:09 PM, Bjorn Andersson wrote: On Fri 02 Oct 21:05 CDT 2020, Siddharth Gupta wrote: This change adds a new kind of core dump mechanism which instead of dumping entire program segments of the firmware, dumps sections of the remoteproc memory which are sufficient to allow

Re: [PATCH 1/9] arm64: dts: ls1088a: add external MDIO device nodes

2020-10-29 Thread Shawn Guo
On Fri, Sep 25, 2020 at 04:24:55PM +0300, Ioana Ciornei wrote: > Add the external MDIO device nodes found in the WRIOP global memory > region. This is needed for management of external PHYs. > > Signed-off-by: Ioana Ciornei > --- > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 18

Re: [PATCH v4 0/5] Bluetooth: Add new MGMT interface for advertising add

2020-10-29 Thread Luiz Augusto von Dentz
Hi Daniel, On Thu, Oct 29, 2020 at 3:25 PM Daniel Winkler wrote: > > Hi Luiz, > > Thank you for the feedback regarding mgmt-tester. I intended to use > the tool, but found that it had a very high rate of test failure even > before I started adding new tests. If you have a strong preference for >

Re: [PATCH] ASoC: bcm2835: Add enable/disable clock functions

2020-10-29 Thread Allen Martin
On Wed, Oct 28, 2020 at 10:39:12AM +0100, Matthias Reichl wrote: On Wed, Oct 28, 2020 at 01:18:33AM -0700, Allen Martin wrote: Hi, just checking if you had a chance to review this patch. On Sat, Oct 10, 2020 at 12:26 PM Allen Martin wrote: > Add functions to control enable/disable of BCLK

linux-next: build failure after merge of the drm-misc tree

2020-10-29 Thread Stephen Rothwell
=implicit-function-declaration] 320 | need_swiotlb = !!swiotlb_nr_tbl(); | ^~ Caused by commit ee5d2a8e549e ("drm/ttm: wire up the new pool as default one v2") I have used the drm-misc tree from next-20201029 for today. -- Cheers, Stephe

Re: [PATCH 2/9] arm64: dts: ls1088ardb: add QSGMII PHY nodes

2020-10-29 Thread Shawn Guo
On Fri, Sep 25, 2020 at 04:24:56PM +0300, Ioana Ciornei wrote: > Annotate the external MDIO1 node and describe the 8 QSGMII PHYs found on > the LS1088ARDB board and add phy-handles for DPMACs 3-10 to its > associated PHY. Also, add the internal PCS MDIO nodes for the internal > MDIO buses found

Re: [PATCH 2/3] Driver core: platform: Add platform_get_irqs_affinity()

2020-10-29 Thread kernel test robot
Hi John, I love your patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on scsi/for-next tip/irq/core driver-core/driver-core-testing linus/master v5.10-rc1 next-20201029] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH 5/9] arm64: dts: ls2088ardb: add PHY nodes for the CS4340 PHYs

2020-10-29 Thread Shawn Guo
On Fri, Sep 25, 2020 at 04:24:59PM +0300, Ioana Ciornei wrote: > Annotate the EMDIO1 node and describe the 4 10GBASER PHYs found on the > LS2088ARDB board. Also, add phy-handles for DPMACs 1-4 to their > associated PHY. > > Signed-off-by: Ioana Ciornei > --- >

[PATCH] remoteproc: qcom: Add notification timeouts

2020-10-29 Thread Rishabh Bhatnagar
Clients can register their callbacks for power-on/off notifications of remote processors. While executing the notifier chain sometimes these callbacks may get stuck or take a long time which is not desired. To detect such cases this patch introduces a timeout and prints out a warning indicating

[PATCH] z2ram: MODULE_LICENSE update and neatening

2020-10-29 Thread Joe Perches
Additional style neatenings. Miscellanea: o Make MODULE_LICENSE match the actual license text o Comment neatening o alloc failure message removals as there is already a dump_stack() o Add pr_fmt() and convert printks to pr_ o Unindent code blocks by using continue o Return early z2open when

Re: [PATCH] ARM: imx: Add revision support for i.MX7ULP revision 2.2

2020-10-29 Thread Shawn Guo
On Sun, Sep 27, 2020 at 03:03:13PM +0800, Anson Huang wrote: > On i.MX7ULP revision 2.2, the value is 3, so add support for this > revision, otherwise, it will use default revision of 1.0 which is > incorrect. > > Signed-off-by: Anson Huang Applied, thanks.

Re: [PATCH 3/5] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM

2020-10-29 Thread Matteo Scordino
Hello Paul, Thanks for reviewing! It seems from the comments in [PATCH 4/5] that the consensus would be to drop allwinner,sun8i-s3 and keep sochip,s3 (I guess due to the fact that the S3 is distributed by Sochip). And yes, you're right that it makes sense to add allwinner,sun8i-v3 at the end.

[tip:x86/apic] BUILD SUCCESS WITH WARNING 2e008ffe426f927b1697adb4ed10c1e419927ae4

2020-10-29 Thread kernel test robot
: invalid access past the end of 'entry' (4 8) Warning ids grouped by kconfigs: gcc_recent_errors `-- i386-randconfig-s002-20201029 `-- arch-x86-kernel-apic-io_apic.c:sparse:sparse:invalid-access-past-the-end-of-entry-(-) elapsed time: 1167m configs tested: 146 configs skipped: 2 gcc

Re: [PATCH 4/5] dt-bindings: arm: sunxi: add Elimo bindings

2020-10-29 Thread Matteo Scordino
Hello, thank you both for reviewing. I didn't realise the file was kept in alphabetical order, I will fix that. And I agree that board/som + "sochip,s3, allwinner,sun8i-v3" makes sense, I will resubmit the patch with those (and sync them with the dt bindings file). Should I submit a patch to

Re: [PATCH 5/5] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC

2020-10-29 Thread Matteo Scordino
On Thu, 2020-10-29 at 11:10 +0100, Paul Kocialkowski wrote: > Hi, > > On Thu 29 Oct 20, 02:20, Matteo Scordino wrote: > > The Elimo Engineering Initium is an Open Source Hardware Single Board > > Computer based on the Elimo Impetus SoM. > > > > It is meant as the first development platform for

Re: [PATCH 1/6] arm64: dts: imx8mm-var-som: fix missing PMIC's interrupt line pull-up

2020-10-29 Thread Shawn Guo
On Sun, Sep 27, 2020 at 06:59:42PM +0200, Krzysztof Kozlowski wrote: > The PMIC's interrupt is level low and should be pulled up. The PMIC's > device node had pinctrl-0 property but it lacked pinctrl-names which > is required to apply the pin configuration. The actual problem in DTS > was

RE: [PATCH] nios32: add support for TIF_NOTIFY_SIGNAL

2020-10-29 Thread Tan, Ley Foon
> -Original Message- > From: Jens Axboe > Sent: Friday, October 30, 2020 12:18 AM > To: Tan, Ley Foon ; linux-kernel@vger.kernel.org > Subject: [PATCH] nios32: add support for TIF_NOTIFY_SIGNAL > > Wire up TIF_NOTIFY_SIGNAL handling for nios32. > > Cc: Ley Foon Tan > Signed-off-by:

Re: [PATCH v2 1/2] bpf: don't rely on GCC __attribute__((optimize)) to disable GCSE

2020-10-29 Thread Nick Desaulniers
On Wed, Oct 28, 2020 at 4:20 PM Alexei Starovoitov wrote: > > On Thu, Oct 29, 2020 at 12:10:52AM +0100, Ard Biesheuvel wrote: > > On Wed, 28 Oct 2020 at 23:59, Alexei Starovoitov > > wrote: > > > > > > I'm totally fine with making > > > #define __no_fgcse > > >

Re: [PATCH] mm/compaction: count pages and stop correctly during page isolation.

2020-10-29 Thread Andrew Morton
On Thu, 29 Oct 2020 17:31:28 -0400 Zi Yan wrote: > > > > Shall you add Fixes tag to commit > > 1da2f328fa643bd72197dfed0c655148af31e4eb? And may cc stable. > > Sure. > > Fixes: 1da2f328fa64 (“mm,thp,compaction,cma: allow THP migration for CMA > allocations”) > > stable cc'ed. A think a

Re: [PATCH] arm64: dts: imx8mn-evk: Add cpu-supply to enable cpufreq

2020-10-29 Thread Shawn Guo
On Mon, Sep 28, 2020 at 10:21:43AM +0800, Anson Huang wrote: > PMIC driver is ready on i.MX8MN EVK board, assign cpu-supply for > each A53 and restore the operating points table to enable cpufreq. > > Signed-off-by: Anson Huang Applied, thanks.

Re: [PATCH v2] arm64: dts: fix endianness issue of rcpm

2020-10-29 Thread Shawn Guo
On Tue, Sep 29, 2020 at 09:30:21AM +0800, Ran Wang wrote: > From: Biwen Li > > Add little-endian property to RCPM node (for ls1028a,ls1088a,ls208xa), > otherwise RCPM driver will program hardware with incorrect setting, > causing system (such as LS1028ARDB) failed to be waked by wakeup source. >

Re: [PATCH v2 1/2] bpf: don't rely on GCC __attribute__((optimize)) to disable GCSE

2020-10-29 Thread Nick Desaulniers
On Wed, Oct 28, 2020 at 10:15 AM Ard Biesheuvel wrote: > > Commit 3193c0836 ("bpf: Disable GCC -fgcse optimization for > ___bpf_prog_run()") introduced a __no_fgcse macro that expands to a > function scope __attribute__((optimize("-fno-gcse"))), to disable a > GCC specific optimization that was

Re: [PATCH v2 1/2] dt-bindings: watchdog: fsl-imx: document NXP compatibles

2020-10-29 Thread Shawn Guo
On Thu, Oct 29, 2020 at 05:21:32PM +0100, Krzysztof Kozlowski wrote: > Document all ARMv5, ARMv6, ARMv7 and ARMv8 NXP (i.MX, Layerscape) > compatibles used in DTSes (even though driver binds only to > fsl,imx21-wdt) to fix dtbs_check warnings like: > > arch/arm/boot/dts/imx53-qsb.dt.yaml:

Re: [PATCH v2 2/2] ARM: dts: freescale: align watchdog node name with dtschema

2020-10-29 Thread Shawn Guo
On Thu, Oct 29, 2020 at 05:21:33PM +0100, Krzysztof Kozlowski wrote: > The dtschema expects watchdog device node name to be "watchdog": > > arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dt.yaml: wdog@2ad: > $nodename:0: 'wdog@2ad' does not match '^watchdog(@.*|-[0-9a-f])?$' > >

Re: [RFC 13/13] m68k: mac: convert to generic clockevent

2020-10-29 Thread Finn Thain
On Fri, 23 Oct 2020, Arnd Bergmann wrote: > On Sun, Oct 18, 2020 at 2:55 AM Finn Thain > wrote: > > On Thu, 15 Oct 2020, Arnd Bergmann wrote: > > > On Thu, Oct 15, 2020 at 3:19 AM Finn Thain > > > wrote: > > > > On Sat, 10 Oct 2020, Arnd Bergmann wrote: > > > > That configuration still

Re: [PATCH 0/2] vsock: minor clean up of ioctl error handling

2020-10-29 Thread Jakub Kicinski
On Tue, 27 Oct 2020 09:09:40 + Colin King wrote: > From: Colin Ian King > > Two minor changes to the ioctl error handling. Applied, thanks!

Re: [PATCH net-next v2 4/4] net: hdlc_fr: Add support for any Ethertype

2020-10-29 Thread Xie He
On Thu, Oct 29, 2020 at 4:53 PM Xie He wrote: > > > Does it make sense to define a struct snap_hdr instead of manually > > casting all these bytes? > > > And macros or constant integers to self document these kinds of fields. > > Yes, we can define a struct snap_hdr, like this: > > struct

Re: [PATCH] memory: pl353-smc: fix compile test on !ARM_AMBA

2020-10-29 Thread Nick Desaulniers
+ authors/reviewers of commit fee10bd22678 ("memory: pl353: Add driver for arm pl353 static memory controller") On Thu, Oct 29, 2020 at 12:34 PM Krzysztof Kozlowski wrote: > > The pl353-smc driver uses module_amba_driver so it has a build > dependency on CONFIG_ARM_AMBA: > >

Re: [PATCH net-next v2 4/4] net: hdlc_fr: Add support for any Ethertype

2020-10-29 Thread Willem de Bruijn
On Thu, Oct 29, 2020 at 7:53 PM Xie He wrote: > > On Thu, Oct 29, 2020 at 10:24 AM Willem de Bruijn > wrote: > > > > > Also add skb_reset_mac_header before we pass an skb (received on normal > > > PVC devices) to upper layers. Because we don't use header_ops for normal > > > PVC devices, we

Re: [PATCH net-next v2 4/4] net: hdlc_fr: Add support for any Ethertype

2020-10-29 Thread Willem de Bruijn
On Thu, Oct 29, 2020 at 8:49 PM Xie He wrote: > > On Thu, Oct 29, 2020 at 4:53 PM Xie He wrote: > > > > > Does it make sense to define a struct snap_hdr instead of manually > > > casting all these bytes? > > > > > And macros or constant integers to self document these kinds of fields. > > > >

Re: [PATCH 1/3] arm64: dts: imx8mm: adjust GIC CPU mask to match number of CPUs

2020-10-29 Thread Shawn Guo
On Tue, Sep 29, 2020 at 10:40:13AM +0200, Krzysztof Kozlowski wrote: > i.MX 8M Mini has four Cortex-A CPUs, not six. Using higher value is > harmless but adjust it to match real HW. > > Signed-off-by: Krzysztof Kozlowski Applied all, thanks.

Re: [PATCH v2 5/5] firmware: QCOM_SCM: Allow qcom_scm driver to be loadable as a permenent module

2020-10-29 Thread John Stultz
On Wed, Oct 28, 2020 at 7:51 AM Robin Murphy wrote: > Hmm, perhaps I'm missing something here, but even if the config options > *do* line up, what prevents arm-smmu probing before qcom-scm and > dereferencing NULL in qcom_scm_qsmmu500_wait_safe_toggle() before __scm > is initialised? Oh man,

Re: [PATCH v3 4/9] perf mem: Only initialize memory event for recording

2020-10-29 Thread Ian Rogers
On Tue, Oct 27, 2020 at 11:38 PM Leo Yan wrote: > > It's needless to initialize memory events for reporting, this patch > moves memory event initialization for only recording. Furthermore, > the change allows to parse perf data on cross platforms, e.g. perf > tool can report result properly even

Re: [PATCH] z2ram: MODULE_LICENSE update and neatening

2020-10-29 Thread James Bottomley
On Thu, 2020-10-29 at 17:11 -0700, Joe Perches wrote: > This file still does not have an SPDX line. What should it be? It's old style MIT with a slight variation: https://fedoraproject.org/wiki/Licensing:MIT#Old_Style James

Re: [PATCH v3 9/9] perf mem: Document event type 'ldst'

2020-10-29 Thread Ian Rogers
On Tue, Oct 27, 2020 at 11:39 PM Leo Yan wrote: > > The event type 'ldst' is added for recording both load and store memory > operations, this patch documents for the new event type. > > Signed-off-by: Leo Yan > --- > tools/perf/Documentation/perf-mem.txt | 6 +- > 1 file changed, 5

[PATCH v2 3/4] drm/bridge: ti-sn65dsi86: Read EDID blob over DDC

2020-10-29 Thread Stephen Boyd
Use the DDC connection to read the EDID from the eDP panel instead of relying on the panel to tell us the modes. Reviewed-by: Douglas Anderson Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: Sean Paul Signed-off-by: Stephen Boyd --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 20

[PATCH v2 1/4] drm/bridge: ti-sn65dsi86: Combine register accesses in ti_sn_aux_transfer()

2020-10-29 Thread Stephen Boyd
These register reads and writes are sometimes directly next to each other in the register address space. Let's use regmap bulk read/write APIs to get the data with one transfer instead of multiple i2c transfers. This helps cut down on the number of transfers in the case of something like reading

[PATCH v2 4/4] drm/bridge: ti-sn65dsi86: Update reply on aux failures

2020-10-29 Thread Stephen Boyd
We should be setting the drm_dp_aux_msg::reply field if a NACK or a SHORT reply happens. Update the error bit handling logic in ti_sn_aux_transfer() to handle these cases and notify upper layers that such errors have happened. This helps the retry logic understand that a timeout has happened, or

[PATCH v2 2/4] drm/bridge: ti-sn65dsi86: Make polling a busy loop

2020-10-29 Thread Stephen Boyd
There's no reason we need to wait here to poll a register over i2c. The i2c bus is inherently slow and delays are practically part of the protocol because we have to wait for the device to respond to any request for a register. Let's rely on the sleeping of the i2c controller instead of adding any

[PATCH v2 0/4] drm/bridge: ti-sn65dsi86: Support EDID reading

2020-10-29 Thread Stephen Boyd
This patch series cleans up the DDC code a little bit so that it is more efficient time wise and supports grabbing the EDID of the eDP panel over the aux channel. I timed this on a board I have on my desk and it takes about 20ms to grab the EDID out of the panel and make sure it is valid. The

Re: [PATCH 1/4] drm/bridge: ti-sn65dsi86: Combine register accesses in ti_sn_aux_transfer()

2020-10-29 Thread Stephen Boyd
Quoting Stephen Boyd (2020-10-28 18:11:51) > @@ -72,6 +74,7 @@ > #define SN_AUX_ADDR_19_16_REG 0x74 > #define SN_AUX_ADDR_15_8_REG 0x75 > #define SN_AUX_ADDR_7_0_REG0x76 > +#define SN_AUX_ADDR_MASK GENMASK(19, 0) >

Re: [PATCH] mm/compaction: count pages and stop correctly during page isolation.

2020-10-29 Thread Zi Yan
On 29 Oct 2020, at 20:28, Andrew Morton wrote: > On Thu, 29 Oct 2020 17:31:28 -0400 Zi Yan wrote: > >>> >>> Shall you add Fixes tag to commit >>> 1da2f328fa643bd72197dfed0c655148af31e4eb? And may cc stable. >> >> Sure. >> >> Fixes: 1da2f328fa64 (“mm,thp,compaction,cma: allow THP migration for

Re: [PATCH] z2ram: MODULE_LICENSE update and neatening

2020-10-29 Thread Joe Perches
On Thu, 2020-10-29 at 18:01 -0700, James Bottomley wrote: > On Thu, 2020-10-29 at 17:11 -0700, Joe Perches wrote: > > This file still does not have an SPDX line. What should it be? > > It's old style MIT with a slight variation: > > https://fedoraproject.org/wiki/Licensing:MIT#Old_Style Yes,

Re: [RFC] Have insn decoder functions return success/failure

2020-10-29 Thread Masami Hiramatsu
Hi, On Thu, 29 Oct 2020 13:42:31 +0100 Borislav Petkov wrote: > Hi Masami, > > On Sat, Oct 24, 2020 at 01:27:41AM +0200, Borislav Petkov wrote: > > @@ -230,14 +231,20 @@ void insn_get_prefixes(struct insn *insn) > > * If necessary, first collects any preceding (prefix) bytes. > > * Sets

Re: [PATCH 0/2] vdpasim: allow to set MAC address

2020-10-29 Thread Jason Wang
On 2020/10/29 下午8:20, Laurent Vivier wrote: This series starts by fixing a bug: vdpa_sim generates a MAC address that is never show to upper layer, and thus virtio-net generates another random MAC address, that changes each time virtio-net is loaded (even if vdpa_sim is not unloaded). Then it

Re: [Build fail] i386 & nvdimm is unhappy

2020-10-29 Thread Dan Williams
On Thu, Oct 29, 2020 at 4:49 PM Dan Williams wrote: > > On Thu, Oct 29, 2020 at 4:29 PM Randy Dunlap wrote: > > > > On 10/29/20 4:13 PM, Randy Dunlap wrote: > > > On 10/29/20 4:09 PM, Philip Li wrote: > > >> On Thu, Oct 29, 2020 at 03:52:42PM -0700, Dan Williams wrote: > > >>> On Thu, Oct 29,

Re: [PATCH] iommu/rockchip: check return value of of_find_device_by_node() in rk_iommu_of_xlate()

2020-10-29 Thread yukuai (C)
On 2020/10/29 21:51, Robin Murphy wrote: On 2020-10-29 13:19, yukuai (C) wrote: On 2020/10/29 18:08, Robin Murphy wrote: On 2020-10-29 09:22, Yu Kuai wrote: If of_find_device_by_node() failed in rk_iommu_of_xlate(), null pointer dereference will be triggered. Thus return error code if

[PATCH] mmc: moxart: replace spin_lock_irqsave by spin_lock in hard IRQ

2020-10-29 Thread Tian Tao
The code has been in a irq-disabled context since it is hard IRQ. There is no necessity to do it again. Signed-off-by: Tian Tao --- drivers/mmc/host/moxart-mmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/moxart-mmc.c

[PATCH] media: usb: dvb-usb-v2: zd1301: fix missing platform_device_unregister()

2020-10-29 Thread Qinglang Miao
Add the missing platform_device_unregister() before return from zd1301_frontend_attach in the error handling case when pdev->dev.driver is empty. There's an error handling route named err_platform_device_unregister , so just reuse it. Signed-off-by: Qinglang Miao ---

[PATCH] drm/tegra: sor: fix missing clk_disable_unprepare() on error in tegra_sor_init

2020-10-29 Thread Qinglang Miao
Fix the missing clk_disable_unprepare() before return from tegra_sor_init() in the error handling case. Signed-off-by: Qinglang Miao --- drivers/gpu/drm/tegra/sor.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tegra/sor.c

[PATCH] PCI: v3: fix missing clk_disable_unprepare() on error in v3_pci_probe

2020-10-29 Thread Qinglang Miao
Fix the missing clk_disable_unprepare() before return from v3_pci_probe() in the error handling case. Signed-off-by: Qinglang Miao --- drivers/pci/controller/pci-v3-semi.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/pci-v3-semi.c

Re: [PATCH v9 01/14] ASoC: sun4i-i2s: Change set_chan_cfg() params

2020-10-29 Thread Samuel Holland
On 10/27/20 4:43 PM, Clément Péron wrote: > Hi Pierre-Louis, > > On Tue, 27 Oct 2020 at 19:59, Pierre-Louis Bossart > wrote: >> >> >>> @@ -452,11 +454,11 @@ static int sun8i_i2s_set_chan_cfg(const struct >>> sun4i_i2s *i2s, >>> case SND_SOC_DAIFMT_DSP_B: >>> case

Re: [f2fs-dev] [PATCH v5 2/2] f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl

2020-10-29 Thread Daeho Jeong
Chao, got it on f2fs_is_compress_algorithm_valid(). I also agree on Eric's opinion on that error value. 2020년 10월 30일 (금) 오전 12:54, Eric Biggers 님이 작성: > > On Thu, Oct 29, 2020 at 03:29:17PM +0800, Chao Yu wrote: > > > +static int f2fs_ioc_set_compress_option(struct file *filp, unsigned long > >

Re: [PATCH v3 9/9] perf mem: Document event type 'ldst'

2020-10-29 Thread Leo Yan
Hi Ian, On Thu, Oct 29, 2020 at 06:10:40PM -0700, Ian Rogers wrote: > On Tue, Oct 27, 2020 at 11:39 PM Leo Yan wrote: > > > > The event type 'ldst' is added for recording both load and store memory > > operations, this patch documents for the new event type. > > > > Signed-off-by: Leo Yan > >

linux-next: build failure after merge of the pinctrl tree

2020-10-29 Thread Stephen Rothwell
Hi all, After merging the pinctrl tree, today's linux-next build (x86_64 allmodconfig) failed like this: ERROR: modpost: "irq_gc_set_wake" [drivers/pinctrl/pinctrl-rockchip.ko] undefined! Caused by commit 6c684f5e79ea ("pinctrl: rockchip: make driver be tristate module") I have reverted

[PATCH v2 12/12] bus: mhi: core: Remove MHI event ring IRQ handlers when powering down

2020-10-29 Thread Bhaumik Bhatt
While powering down, the device may or may not acknowledge an MHI RESET issued by host for a graceful shutdown scenario and end up sending an incoming data packet after tasklets have been killed. If a rogue device sends this interrupt for a data transfer event ring update, it can result in a

[PATCH v2 03/12] bus: mhi: core: Skip device wake in error or shutdown states

2020-10-29 Thread Bhaumik Bhatt
MHI client drivers can request a device wake even if the device may be in an error state or undergoing a shutdown. To prevent unnecessary device wake processing, check for the device state and bail out early so that the clients are made aware of the device state sooner. Signed-off-by: Bhaumik

<    1   2   3   4   5   6   7   8   9   10   >