Re: [PATCH v3 25/34] misc: Add Keem Bay VPU manager

2021-01-31 Thread Randy Dunlap
On 1/29/21 6:20 PM, mgr...@linux.intel.com wrote: > diff --git a/drivers/misc/vpumgr/Kconfig b/drivers/misc/vpumgr/Kconfig > new file mode 100644 > index ..bb82ff83afd3 > --- /dev/null > +++ b/drivers/misc/vpumgr/Kconfig > @@ -0,0 +1,9 @@ > +config VPUMGR > + tristate "VPU Manager"

Re: [External] [PATCH] misc: pvpanic: sysfs_emit uses should have a newline

2021-01-31 Thread zhenwei pi
On 1/30/21 3:08 AM, Joe Perches wrote: Add newline terminations to the sysfs_emit uses added by -next commit 8d6da6575ffe ("misc: pvpanic: introduce events device attribue") Signed-off-by: Joe Perches --- drivers/misc/pvpanic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: linux-next: build warning after merge of the drm tree

2021-01-31 Thread Stephen Rothwell
Hi all, On Fri, 22 Jan 2021 11:59:18 +1100 Stephen Rothwell wrote: > > After merging the drm tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > WARNING: unmet direct dependencies detected for DRM_I915_WERROR > Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] &&

Re: [PATCH 2/3] usb: xhci-mtk: fix UAS issue by XHCI_BROKEN_STREAMS quirk

2021-01-31 Thread Chunfeng Yun
On Sun, 2021-01-31 at 15:13 +0100, Matthias Brugger wrote: > > On 24/12/2020 08:18, Chunfeng Yun wrote: > > On Wed, 2020-12-16 at 19:43 -0800, Rosen Penev wrote: > >> On Wed, Dec 16, 2020 at 6:29 PM Chunfeng Yun > >> wrote: > >>> > >>> On Wed, 2020-12-16 at 20:28 +0800, Nicolas Boichat wrote: >

[PATCH] lib/cmdline: remove an unneeded local variable in next_arg()

2021-01-31 Thread Masahiro Yamada
The local variable 'next' is unneeded because you can simply advance the existing pointer 'args'. Signed-off-by: Masahiro Yamada --- lib/cmdline.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/cmdline.c b/lib/cmdline.c index b390dd03363b..f9844ea417c0 100644

Re: [PATCH] cxl: Simplify bool conversion

2021-01-31 Thread Andrew Donnellan
On 29/1/21 7:25 pm, Yang Li wrote: Fix the following coccicheck warning: ./drivers/misc/cxl/sysfs.c:181:48-53: WARNING: conversion to bool not needed here Reported-by: Abaci Robot Signed-off-by: Yang Li Reviewed-by: Andrew Donnellan Thanks! --- drivers/misc/cxl/sysfs.c | 2 +- 1 file

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-01-31 Thread Willem de Bruijn
On Sun, Jan 31, 2021 at 10:32 AM Alex Elder wrote: > > On 1/31/21 8:52 AM, Willem de Bruijn wrote: > > On Sat, Jan 30, 2021 at 11:29 PM Alex Elder wrote: > >> > >> On 1/30/21 9:25 AM, Willem de Bruijn wrote: > >>> On Fri, Jan 29, 2021 at 3:29 PM Alex Elder wrote: > > The channel stop

Re: [PATCH] scripts: switch some more scripts explicitly to Python 3

2021-01-31 Thread Nathan Chancellor
On Mon, Feb 01, 2021 at 10:08:18AM +0900, Masahiro Yamada wrote: > For the same reason as commit 51839e29cb59 ("scripts: switch explicitly > to Python 3"), switch some more scripts, which I tested and confirmed > working on Python 3. > > Signed-off-by: Masahiro Yamada Acked-by: Nathan

linux-next: manual merge of the drm tree with Linus' tree

2021-01-31 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h between commit: a119f87b86bc ("Revert "drm/amdgpu/swsmu: drop set_fan_speed_percent (v2)"") from Linus' tree and commit: d8a0b8dd690b ("drm/amd/pm: add pptable_funcs

Re: [PATCH v1] ARM: imx: avic: Convert to using IRQCHIP_DECLARE

2021-01-31 Thread Fabio Estevam
Hi Saravana, On Sun, Jan 31, 2021 at 5:56 PM Saravana Kannan wrote: > +static int __init imx_avic_init(struct device_node *node, > + struct device_node *parent) > +{ > + void __iomem *avic_base; > + > + avic_base = of_iomap(node, 0); > +

Re: [PATCH] powerpc: fix AKEBONO build failures

2021-01-31 Thread Michael Ellerman
Randy Dunlap writes: > On 1/21/21 5:14 PM, Michael Ellerman wrote: >> Randy Dunlap writes: >>> On 1/20/21 1:29 PM, Yury Norov wrote: Hi all, I found the power pc build broken on today's linux-next (647060f3b592). >>> >>> Darn, I was building linux-5.11-rc4. >>> >>> I'll try

Re: [PATCH] hugetlbfs: show pagesize in unit of GB if possible

2021-01-31 Thread Miaohe Lin
Hi: On 2021/1/31 6:07, David Rientjes wrote: > On Sat, 30 Jan 2021, Miaohe Lin wrote: > >> Hugepage size in unit of GB is supported. We could show pagesize in unit of >> GB to make it more friendly to read. Also rework the calculation code of >> page size unit to make it more readable. >> >>

Re: [PATCH v3 bpf-next 1/4] bpf: enable task local storage for tracing programs

2021-01-31 Thread KP Singh
On Thu, Jan 28, 2021 at 1:20 AM Song Liu wrote: > > To access per-task data, BPF programs usually creates a hash table with > pid as the key. This is not ideal because: > 1. The user need to estimate the proper size of the hash table, which may > be inaccurate; > 2. Big hash tables are

Re: [PATCH v5] tracepoint: Do not fail unregistering a probe due to memory failure

2021-01-31 Thread Alexey Kardashevskiy
On 31/01/2021 01:42, Steven Rostedt wrote: On Sat, 30 Jan 2021 09:36:26 -0500 Steven Rostedt wrote: Do you still have the same crash with v3 (that's the one I'm going to go with for now.) https://lore.kernel.org/r/20201118093405.7a6d2...@gandalf.local.home Just curious, does the

Re: [PATCH] ARM: dts: imx6qdl-wandboard: add scl/sda gpios definitions for i2c bus recovery

2021-01-31 Thread Fabio Estevam
On Sun, Jan 31, 2021 at 12:55 PM Dima Azarkin wrote: > > The i2c bus on imx6qdl-wandboard has intermittent issues where SDA can freeze > on low level at the end of transaction so the bus can no longer work. This > impacts reading of EDID data leading to incorrect TV resolution and no audio. > >

Re: [PATCH v5 0/4] Scan for an idle sibling in a single pass

2021-01-31 Thread Li, Aubrey
On 2021/1/27 21:51, Mel Gorman wrote: > Changelog since v4 > o Avoid use of intermediate variable during select_idle_cpu > > Changelog since v3 > o Drop scanning based on cores, SMT4 results showed problems > > Changelog since v2 > o Remove unnecessary parameters > o Update nr during scan only

Re: [PATCH 1/3] MIPS: ftrace: Fix N32 save registers

2021-01-31 Thread Jinyang He
On 01/31/2021 06:38 PM, Jiaxun Yang wrote: On Sun, Jan 31, 2021, at 4:14 PM, Jinyang He wrote: CONFIG_64BIT is confusing. N32 also pass parameters by a0~a7. Do we have NEW kernel build? CONFIG_64BIT assumed N64 as kernel ABI. -Jiaxun Hi, Jiaxun, Thank you for your reply, and now I know.

[PATCH] scripts: switch some more scripts explicitly to Python 3

2021-01-31 Thread Masahiro Yamada
For the same reason as commit 51839e29cb59 ("scripts: switch explicitly to Python 3"), switch some more scripts, which I tested and confirmed working on Python 3. Signed-off-by: Masahiro Yamada --- scripts/clang-tools/gen_compile_commands.py | 2 +- scripts/clang-tools/run-clang-tools.py

Re: [PATCH] Updates Documentation/Makefile to use Python3 as fallback

2021-01-31 Thread Masahiro Yamada
On Sat, Jan 30, 2021 at 9:15 AM Jonathan Corbet wrote: > > Noa Sakurajin writes: > > [CC += kbuild maintainers] > > > Before the command python was needed for the documentation to build. > > This patch checks if python is available and uses python3 as > > fallback. > > > > This is needed

[PATCH v2] exfat: improve performance of exfat_free_cluster when using dirsync mount option

2021-01-31 Thread Hyeongseok Kim
There are stressful update of cluster allocation bitmap when using dirsync mount option which is doing sync buffer on every cluster bit clearing. This could result in performance degradation when deleting big size file. Fix to update only when the bitmap buffer index is changed would make less

[PATCH] kbuild: remove PYTHON variable

2021-01-31 Thread Masahiro Yamada
Python retired in 2020, and some distributions do not provide the 'python' command any more. As in commit 51839e29cb59 ("scripts: switch explicitly to Python 3"), we need to use more specific 'python3' to invoke scripts even if they are written in a way compatible with both Python 2 and 3. This

[PATCH] f2fs: prevent setting ioprio of thread not in merge mode

2021-01-31 Thread Daeho Jeong
From: Daeho Jeong It causes a crash to change the ioprio of checkpoint thread not in checkpoint=merge. I fixed that to prevent setting the ioprio of the thread when checkpoint=merge is not enabled. Signed-off-by: Daeho Jeong --- fs/f2fs/sysfs.c | 8 ++-- 1 file changed, 6 insertions(+), 2

Re: [Patch v3 net-next 0/7] ethtool support for fec and link configuration

2021-01-31 Thread Willem de Bruijn
On Sun, Jan 31, 2021 at 8:11 AM Hariprasad Kelam wrote: > > This series of patches add support for forward error correction(fec) and > physical link configuration. Patches 1&2 adds necessary mbox handlers for fec > mode configuration request and to fetch stats. Patch 3 registers driver >

Re: [PATCH v2] ext4: Enable code path when DX_DEBUG is set

2021-01-31 Thread Nathan Chancellor
On Mon, Feb 01, 2021 at 12:31:25AM +, Vinicius Tinti wrote: > By enabling -Wunreachable-code-aggressive on Clang the following code > paths are unreachable. > > This has been present since commit ac27a0ec112a ("[PATCH] ext4: initial > copy of files from ext3") and fs/ext3 had it present at

[PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-01-31 Thread Giancarlo Ferrari
machine_kexec() need to set rw permission in text and rodata sections to assign some variables (e.g. kexec_start_address). To do that at the end (after flushing pdm in memory, etc.) it needs to invalidate TLB [section] entries. If during the TLB invalidation an interrupt occours, which might

Re: [PATCH for -next] docs: hwmon: rectify table in max16601.rst

2021-01-31 Thread Guenter Roeck
On 1/30/21 11:54 PM, Lukas Bulwahn wrote: > Commit 90b0f71d62df ("hwmon: (pmbus/max16601) Determine and use number of > populated phases") adjusts content in the table of > ./Documentation/hwmon/max16601.rst, but one row went beyond the column's > length. > > Hence, make htmldocs warns: > >

[PATCH v2] ext4: Enable code path when DX_DEBUG is set

2021-01-31 Thread Vinicius Tinti
By enabling -Wunreachable-code-aggressive on Clang the following code paths are unreachable. This has been present since commit ac27a0ec112a ("[PATCH] ext4: initial copy of files from ext3") and fs/ext3 had it present at the beginning of git history. It has not been changed since. Clang warns:

ERROR: modpost: "__aeabi_unwind_cpp_pr0" undefined!

2021-01-31 Thread kernel test robot
Hi Nathan, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 1048ba83fb1c00cd24172e23e8263972f6b5d9ac commit: c39866f268f89868df17724cd2262d121552d8c9 arm/build: Always handle .ARM.exidx and .ARM.extab sections

Re: [PATCH] drm/i915: Remove unreachable code

2021-01-31 Thread Vinicius Tinti
On Sat, Jan 30, 2021 at 9:45 AM Chris Wilson wrote: > > Quoting Vinicius Tinti (2021-01-30 12:34:11) > > On Fri, Jan 29, 2021 at 08:55:54PM +, Chris Wilson wrote: > > > Quoting Vinicius Tinti (2021-01-29 18:15:19) > > > > By enabling -Wunreachable-code-aggressive on Clang the following code >

[PATCH] f2fs: fix checkpoint mount option wrong combination

2021-01-31 Thread Daeho Jeong
From: Daeho Jeong As checkpoint=merge comes in, mount option setting related to checkpoint had been mixed up. Fixed it. Signed-off-by: Daeho Jeong --- fs/f2fs/super.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index

s390-linux-ld: ll_temac_main.c:undefined reference to `devm_platform_ioremap_resource_byname'

2021-01-31 Thread kernel test robot
Hi Wang, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 1048ba83fb1c00cd24172e23e8263972f6b5d9ac commit: bd69058f50d5ffa659423bcfa6fe6280ce9c760a net: ll_temac: Use devm_platform_ioremap_resource_byname() date:

Re: [PATCH V2 11/13] devfreq: tegra30: Migrate to dev_pm_opp_set_opp()

2021-01-31 Thread Chanwoo Choi
On 1/27/21 6:10 PM, Viresh Kumar wrote: > dev_pm_opp_set_bw() is getting removed and dev_pm_opp_set_opp() should > be used instead. Migrate to the new API. > > We don't want the OPP core to manage the clk for this driver, migrate to > dev_pm_opp_of_add_table_noclk() to make sure

Re: [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken

2021-01-31 Thread Linus Torvalds
On Sun, Jan 31, 2021 at 3:35 PM Linus Torvalds wrote: > > I wonder if the simple solution is to just > > (a) always set one of the SYSCALL_WORK_EXIT bits on the child in > ptrace (exactly to catch the child on system call exit) > > (b) basically revert 299155244770 ("entry: Drop usage of TIF

Re: [net-next 00/14] Add Marvell CN10K support

2021-01-31 Thread Willem de Bruijn
On Sat, Jan 30, 2021 at 12:04 PM Geetha sowjanya wrote: > > The current admin function (AF) driver and the netdev driver supports > OcteonTx2 silicon variants. The same OcteonTx2's Resource Virtualization Unit > (RVU) > is carried forward to the next-gen silicon ie OcteonTx3, with some changes >

RPi4 DWC2 gadget doesn't copy data to a buffer in ep0 SETUP + DATA OUT transaction

2021-01-31 Thread Ruslan Bilovol
Hi Minas and other USB experts, I'm currently developing new features for UAC1/UAC2 audio gadgets like Volume/Mute controls which use Control SETUP + DATA OUT transactions through ep0. While it works fine on BeagleBone black board with MUSB UDC, on Raspberry Pi 4 with DWC2 UDC there is an issue.

Re: [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken

2021-01-31 Thread Andy Lutomirski
On Sun, Jan 31, 2021 at 3:39 PM Kyle Huey wrote: > > On Sun, Jan 31, 2021 at 3:36 PM Andy Lutomirski wrote: > > > The odd system call tracing part I have no idea who depends on it > > > (apparently "rr", which I assume is some replay thing), and I suspect > > > our semantics for it has been

Re: [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken

2021-01-31 Thread Kyle Huey
On Sun, Jan 31, 2021 at 3:36 PM Andy Lutomirski wrote: > > The odd system call tracing part I have no idea who depends on it > > (apparently "rr", which I assume is some replay thing), and I suspect > > our semantics for it has been basically random historical one, and > > it's apparently what

Re: [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken

2021-01-31 Thread Andy Lutomirski
> On Jan 31, 2021, at 2:57 PM, Linus Torvalds > wrote: > > On Sun, Jan 31, 2021 at 2:20 PM Andy Lutomirski wrote: >> >> A smallish test that we could stick in selftests would be great if that’s >> straightforward. > > Side note: it would be good to have a test-case for the interaction >

Re: [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken

2021-01-31 Thread Linus Torvalds
On Sun, Jan 31, 2021 at 3:18 PM Kyle Huey wrote: > > The key to triggering this bug is to enter a ptrace syscall stop and > then use PTRACE_SINGLESTEP to exit it. On a good kernel this will not > result in any userspace code execution in the tracee because on the > way out of the kernel's syscall

[PATCH v6 1/4] crypto: Add support for ECDSA signature verification

2021-01-31 Thread Stefan Berger
Add support for parsing the parameters of a NIST P256 or NIST P192 key. Enable signature verification using these keys. The new module is enabled with CONFIG_ECDSA: Elliptic Curve Digital Signature Algorithm (NIST P192, P256 etc.) is A NIST cryptographic standard algorithm. Only signature

[PATCH v6 4/4] ima: Support EC keys for signature verification

2021-01-31 Thread Stefan Berger
Add support for IMA signature verification for EC keys. Since SHA type of hashes can be used by RSA and ECDSA signature schemes we need to look at the key and derive from the key which signature scheme to use. Since this can be applied to all types of keys, we change the selection of the encoding

[PATCH v6 0/4] Add support for x509 certs with NIST p256 and p192 keys

2021-01-31 Thread Stefan Berger
This series of patches adds support for x509 certificates signed by a CA that uses NIST p256 or p192 keys for signing. It also adds support for certificates where the public key is a NIST p256 or p192 key. The math for ECDSA signature verification is also added. Since self-signed certificates are

[PATCH v6 3/4] x509: Add support for parsing x509 certs with ECDSA keys

2021-01-31 Thread Stefan Berger
This patch adds support for parsing of x509 certificates that contain ECDSA keys, such as NIST P256, that have been signed by a CA using any of the current SHA hash algorithms. Signed-off-by: Stefan Berger Cc: David Howells Cc: keyri...@vger.kernel.org --- crypto/asymmetric_keys/public_key.c

[PATCH v6 2/4] x509: Detect sm2 keys by their parameters OID

2021-01-31 Thread Stefan Berger
Detect whether a key is an sm2 type of key by its OID in the parameters array rather than assuming that everything under OID_id_ecPublicKey is sm2, which is not the case. Signed-off-by: Stefan Berger Cc: David Howells Cc: keyri...@vger.kernel.org --- crypto/asymmetric_keys/x509_cert_parser.c |

[PATCH v3] misc: bcm-vk: only support ttyVK if CONFIG_TTY is set

2021-01-31 Thread Scott Branden
Correct compile issue if CONFIG_TTY is not set by only adding ttyVK devices if CONFIG_BCM_VK_TTY is set. Reported-by: Randy Dunlap Signed-off-by: Scott Branden --- Changes since v2: - add CONFIG_BCM_VK_TTY - add function and stub for bcm_vk_tty_set_irq_enabled Changes since v1: - add function

Re: [PATCH v18 05/25] x86/fpu/xstate: Introduce CET MSR and XSAVES supervisor states

2021-01-31 Thread Dave Hansen
On 1/29/21 2:35 PM, Yu, Yu-cheng wrote: >> Andy Cooper just mentioned on IRC about this nugget in the spec: >> >> XRSTORS on CET state will do reserved bit and canonicality >> checks on the state in similar manner as done by the WRMSR to >> these state elements. >> >> We're using

[PATCH 02/11] x86/fault: Fold mm_fault_error() into do_user_addr_fault()

2021-01-31 Thread Andy Lutomirski
mm_fault_error() is logically just the end of do_user_addr_fault(). Combine the functions. This makes the code easier to read. Most of the churn here is from renaming hw_error_code to error_code in do_user_addr_fault(). This makes no difference at all to the generated code (objdump -dr) as

[PATCH 06/11] x86/fault: Improve kernel-executing-user-memory handling

2021-01-31 Thread Andy Lutomirski
Right now we treat the case of the kernel trying to execute from user memory more or less just like the kernel getting a page fault on a user access. In the failure path, we check for erratum #93, try to otherwise fix up the error, and then oops. If we manage to jump to the user address space,

Re: linux-next: manual merge of the pidfd tree with the overlayfs tree

2021-01-31 Thread Stephen Rothwell
Hi all, On Mon, 25 Jan 2021 16:23:36 +1100 Stephen Rothwell wrote: > > Today's linux-next merge of the pidfd tree got a conflict in: > > fs/ecryptfs/inode.c > > between commit: > > 176cfe865da6 ("ecryptfs: fix uid translation for setxattr on > security.capability") > > from the

Re: [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken

2021-01-31 Thread Kyle Huey
On Sun, Jan 31, 2021 at 2:27 PM Kyle Huey wrote: > > On Sun, Jan 31, 2021 at 2:20 PM Andy Lutomirski wrote: > > > > > > > > > On Jan 31, 2021, at 2:08 PM, Kyle Huey wrote: > > > > > > On Sun, Jan 31, 2021 at 2:04 PM Andy Lutomirski > > > wrote: > > >> Indeed, and I have tests for this. > > >

Re: [GIT PULL] arm64 fixes for 5.11-rc6

2021-01-31 Thread Ard Biesheuvel
On Sun, 31 Jan 2021 at 19:55, Catalin Marinas wrote: > > On Fri, Jan 29, 2021 at 02:09:05PM -0800, Linus Torvalds wrote: > > On Fri, Jan 29, 2021 at 11:03 AM Catalin Marinas > > wrote: > > > > > > arm64 fixes: > > > > > > - Fix the virt_addr_valid() returning true for < PAGE_OFFSET addresses. >

[PATCH 5/5] entry/kvm: Explicitly flush pending rcuog wakeup before last rescheduling point

2021-01-31 Thread Frederic Weisbecker
Following the idle loop model, cleanly check for pending rcuog wakeup before the last rescheduling point upon resuming to guest mode. This way we can avoid to do it from rcu_user_enter() with the last resort self-IPI hack that enforces rescheduling. Suggested-by: Peter Zijlstra Signed-off-by:

[PATCH 4/5] entry: Explicitly flush pending rcuog wakeup before last rescheduling point

2021-01-31 Thread Frederic Weisbecker
Following the idle loop model, cleanly check for pending rcuog wakeup before the last rescheduling point on resuming to user mode. This way we can avoid to do it from rcu_user_enter() with the last resort self-IPI hack that enforces rescheduling. Signed-off-by: Frederic Weisbecker Cc: Peter

Re: [PATCH] drm/msm/mdp5: Fix wait-for-commit for cmd panels

2021-01-31 Thread Luca Weiss
Hi Iskren, On Mittwoch, 27. Jänner 2021 16:24:40 CET Iskren Chernev wrote: > Before the offending commit in msm_atomic_commit_tail wait_flush was > called once per frame, after the commit was submitted. After it > wait_flush is also called at the beginning to ensure previous > potentially async

[PATCH 3/5] rcu/nocb: Trigger self-IPI on late deferred wake up before user resume

2021-01-31 Thread Frederic Weisbecker
Entering RCU idle mode may cause a deferred wake up of an RCU NOCB_GP kthread (rcuog) to be serviced. Unfortunately the call to rcu_user_enter() is already past the last rescheduling opportunity before we resume to userspace or to guest mode. We may escape there with the woken task ignored. The

[PATCH 1/5] rcu: Pull deferred rcuog wake up to rcu_eqs_enter() callers

2021-01-31 Thread Frederic Weisbecker
Deferred wakeup of rcuog kthreads upon RCU idle mode entry is going to be handled differently whether initiated by idle, user or guest. Prepare with pulling that control up to rcu_eqs_enter() callers. Signed-off-by: Frederic Weisbecker Cc: Paul E. McKenney Cc: Rafael J. Wysocki Cc: Peter

[PATCH 0/5] rcu/sched: Fix ignored rescheduling after rcu_eqs_enter() v4

2021-01-31 Thread Frederic Weisbecker
So, here is a hopefully improved version with the following changes: * No more late wake up debugging, objtool should debug that later with noinstr code calling into the scheduler (Peter suggestion) * Dropped the double rdp fetch patch, just keep the fix part for now * Properly protect irq

[PATCH 2/5] rcu/nocb: Perform deferred wake up before last idle's need_resched() check

2021-01-31 Thread Frederic Weisbecker
Entering RCU idle mode may cause a deferred wake up of an RCU NOCB_GP kthread (rcuog) to be serviced. Usually a local wake up happening while running the idle task is handled in one of the need_resched() checks carefully placed within the idle loop that can break to the scheduler. Unfortunately

Re: [PATCH 1/3] perf tools: Use /proc//task//status for synthesis

2021-01-31 Thread Jiri Olsa
On Fri, Jan 29, 2021 at 02:48:59PM +0900, Namhyung Kim wrote: > To save memory usage, it needs to reduce number of entries in the proc > filesystem. It's using /proc//task directory to traverse threads > in the process and then kernel creates /proc//task/ entries. > > After that it checks the

arch/arm/mach-s3c/irq-s3c24xx.c:1034:13: warning: no previous prototype for function 's3c2442_init_irq'

2021-01-31 Thread kernel test robot
Hi Arnd, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: ac8c6edd20bcb965b22ceb36752499b3d5cf5dd4 commit: 71b9114d2c13a648fbe6523dd859e611c316ad90 ARM: s3c: move into a common directory date: 5 months ago

Re: [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken

2021-01-31 Thread Linus Torvalds
On Sun, Jan 31, 2021 at 2:20 PM Andy Lutomirski wrote: > > A smallish test that we could stick in selftests would be great if that’s > straightforward. Side note: it would be good to have a test-case for the interaction with the "block step" code too. I hate our name for it ("block step"?),

Re: [PATCH] drm/msm/mdp5: Fix wait-for-commit for cmd panels

2021-01-31 Thread Brian Masney
On Wed, Jan 27, 2021 at 05:24:40PM +0200, Iskren Chernev wrote: > Before the offending commit in msm_atomic_commit_tail wait_flush was > called once per frame, after the commit was submitted. After it > wait_flush is also called at the beginning to ensure previous > potentially async commits are

Re: [PATCH 2/3] perf tools: Skip MMAP record synthesis for kernel threads

2021-01-31 Thread Jiri Olsa
On Fri, Jan 29, 2021 at 02:49:00PM +0900, Namhyung Kim wrote: > To synthesize information to resolve sample IPs, it needs to scan task > and mmap info from the /proc filesystem. For each process, it > opens (and reads) status and maps file respectively. But as kernel > threads don't have memory

Re: [PATCH v2 0/3] perf tools: Minor improvements in event synthesis

2021-01-31 Thread Jiri Olsa
On Fri, Jan 29, 2021 at 02:48:58PM +0900, Namhyung Kim wrote: > Hello, > > This is to optimize the event synthesis during perf record. > > The first patch is to reduce memory usage when many threads are used. > The second is to avoid unncessary syscalls for kernel threads. And > the last one is

Re: [PATCH v9] perf stat: Fix wrong skipping for per-die aggregation

2021-01-31 Thread Jiri Olsa
On Thu, Jan 28, 2021 at 09:34:17AM +0800, Jin Yao wrote: > Uncore becomes die-scope on Xeon Cascade Lake-AP and perf has supported > --per-die aggregation yet. > > One issue is found in check_per_pkg() for uncore events running on > AP system. On cascade Lake-AP, we have: > > S0-D0 > S0-D1 >

Re: [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken

2021-01-31 Thread Kyle Huey
On Sun, Jan 31, 2021 at 2:20 PM Andy Lutomirski wrote: > > > > > On Jan 31, 2021, at 2:08 PM, Kyle Huey wrote: > > > > On Sun, Jan 31, 2021 at 2:04 PM Andy Lutomirski > > wrote: > >> Indeed, and I have tests for this. > > > > Do you mean you already have a test case or that you would like a >

Re: [PATCH net] net: dsa: mv88e6xxx: override existent unicast portvec in port_fdb_add

2021-01-31 Thread Vladimir Oltean
On Sun, Jan 31, 2021 at 09:13:15AM +0800, DENG Qingfang wrote: > This bug is exposed when I try your patch series on kernel 5.4 > https://lore.kernel.org/netdev/20210106095136.224739-1-olte...@gmail.com/ > https://lore.kernel.org/netdev/20210116012515.3152-1-tob...@waldekranz.com/ > > Without this

Re: [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken

2021-01-31 Thread Andy Lutomirski
> On Jan 31, 2021, at 2:08 PM, Kyle Huey wrote: > > On Sun, Jan 31, 2021 at 2:04 PM Andy Lutomirski wrote: >> Indeed, and I have tests for this. > > Do you mean you already have a test case or that you would like a > minimized test case? A smallish test that we could stick in selftests

[PATCH 05/11] x86/fault: Correct a few user vs kernel checks wrt WRUSS

2021-01-31 Thread Andy Lutomirski
In general, page fault errors for WRUSS should be just like get_user(), etc. Fix three bugs in this area: We have a comment that says that, if we can't handle a page fault on a user address due to OOM, we will skip the OOM-kill-and-retry logic. The code checked kernel *privilege*, not kernel

[PATCH 11/11] x86/fault: Don't look for extable entries for SMEP violations

2021-01-31 Thread Andy Lutomirski
If we get a SMEP violation or a fault that would have been a SMEP violation if we had SMEP, we shouldn't run fixups. Just OOPS. Cc: Dave Hansen Cc: Peter Zijlstra Signed-off-by: Andy Lutomirski --- arch/x86/mm/fault.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken

2021-01-31 Thread Kyle Huey
On Sun, Jan 31, 2021 at 2:04 PM Andy Lutomirski wrote: > Indeed, and I have tests for this. Do you mean you already have a test case or that you would like a minimized test case? - Kyle

Re: [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken

2021-01-31 Thread Andy Lutomirski
> On Jan 31, 2021, at 1:30 PM, Linus Torvalds > wrote: > > Btw Kyle, do you have a good simple test-case for this? Clearly this > is some weird special case use, and regular single-stepping works > fine. > > Indeed, and I have tests for this. TBH, the TIF_SINGLESTEP code makes no sense,

Linux 5.11-rc6

2021-01-31 Thread Linus Torvalds
Things look a little calmer than last week, and over-all very average for rc6. So - like always this late in the release schedule - I'd certainly have liked things to be even calmer, but nothing here really stands out. The diffstat is quite flat, meaning lots of small fixes, with the exception of

[PATCH RESEND v2] dt-bindings: mfd: Convert rn5t618 to json-schema

2021-01-31 Thread Andreas Kemnade
Convert the RN5T618 binding to DT schema format. Also clearly state which regulators are available. Signed-off-by: Andreas Kemnade Reviewed-by: Rob Herring --- https://lore.kernel.org/lkml/cal_jsqjwt91+azwaweuvjobqgsyw6gbhqmohwu_t5qzabxx...@mail.gmail.com/ Changes in v2: - drop irq description

Re: [PATCH v4 1/2] x86/setup: always add the beginning of RAM as memblock.memory

2021-01-31 Thread Linus Torvalds
On Sun, Jan 31, 2021 at 12:04 AM Mike Rapoport wrote: > > > > > That's *particularly* true when the very line above it did a > > "memblock_reserve()" of the exact same range that the memblock_add() > > "adds". > > The most correct thing to do would have been to > > memblock_add(0,

Re: [PATCH v1 0/2] Make fw_devlink=on more forgiving

2021-01-31 Thread Saravana Kannan
On Fri, Jan 29, 2021 at 8:03 PM Saravana Kannan wrote: > > This patch series solves two general issues with fw_devlink=on > > Patch 1/2 addresses the issue of firmware nodes that look like they'll > have struct devices created for them, but will never actually have > struct devices added for

Re: [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken

2021-01-31 Thread Linus Torvalds
Btw Kyle, do you have a good simple test-case for this? Clearly this is some weird special case use, and regular single-stepping works fine. Linus

Re: [PATCH v5] gpiolib: Bind gpio_device to a driver to enable fw_devlink=on by default

2021-01-31 Thread Saravana Kannan
On Sat, Jan 30, 2021 at 9:39 AM Dmitry Osipenko wrote: > > 22.01.2021 22:35, Saravana Kannan пишет: > > There are multiple instances of GPIO device tree nodes of the form: > > > > foo { > > compatible = "acme,foo"; > > ... > > > > gpio0: gpio0@ { > >

Re: [PATCH] openrisc: use device tree to determine present cpus

2021-01-31 Thread Stafford Horne
On Sun, Jan 31, 2021 at 09:22:31AM +0100, Jan Henrik Weinstock wrote: > On 31/01/2021 00:03, Stafford Horne wrote: > > > This looks good, one small comment below. Can you send the next patch as a > > v2? > > > > Using 'git format-patch -v2 ...' > > Sorry, was not aware of that, will do better

Re: [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken

2021-01-31 Thread Linus Torvalds
On Sun, Jan 31, 2021 at 12:20 PM Gabriel Krisman Bertazi wrote: > > > I think we should migrate TIF_SINGLESTEP to a SYSCALL_WORK flag as that > is just a simple refactor. That makes no sense at all to me. A single-step has absolutely nothing to do with system calls, and it's also not what any

Re: [PATCH v2 0/2] of: property: Add fw_devlink support for more props

2021-01-31 Thread Saravana Kannan
On Sun, Jan 31, 2021 at 8:38 AM Martin Kaiser wrote: > > Dear all, > > Thus wrote Saravana Kannan (sarava...@google.com): > > > Sending again because I messed up the To/Cc for the coverletter. > > > This series combines two patches [1] [2] that'd conflict. > > > Greg, > > > Can you please pull

[PATCH 08/11] x86/fault: Bypass no_context() for implicit kernel faults from usermode

2021-01-31 Thread Andy Lutomirski
We can drop an indentation level and remove the last user_mode(regs) == true caller of no_context() by directly OOPSing for implicit kernel faults from usermode. Cc: Dave Hansen Cc: Peter Zijlstra Signed-off-by: Andy Lutomirski --- arch/x86/mm/fault.c | 59

Re: [PATCH] platform/x86: dell-wmi-sysman: fix a NULL pointer dereference

2021-01-31 Thread Hans de Goede
Hi, On 1/31/21 3:04 PM, Limonciello, Mario wrote: > > >> -Original Message- >> From: Hans de Goede >> Sent: Saturday, January 30, 2021 15:44 >> To: Limonciello, Mario; Mark Gross >> Cc: LKML; platform-driver-...@vger.kernel.org >> Subject: Re: [PATCH] platform/x86: dell-wmi-sysman: fix

[PATCH v1] ARM: imx: avic: Convert to using IRQCHIP_DECLARE

2021-01-31 Thread Saravana Kannan
Remove a lot of boilerplate code. Also address boot issues on imx25 with fw_devlink=on that were reported by Martin. Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Reported-by: Martin Kaiser Signed-off-by: Saravana Kannan --- I've compile tested this for imx25 and imx27. But

[PATCH] Staging: wimax: i2400m: fixing several coding style issues.

2021-01-31 Thread dev . dragon
From: Dmitrii Wolf Fixed a coding style issues. Signed-off-by: Dmitrii Wolf --- drivers/staging/wimax/i2400m/debugfs.c | 2 +- drivers/staging/wimax/i2400m/netdev.c | 2 +- drivers/staging/wimax/i2400m/rx.c | 23 +++ drivers/staging/wimax/i2400m/usb.c | 2 +-

Re: [RFC PATCH v4 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

2021-01-31 Thread Cristian Marussi
Hi a clarification down below regarding something I pointed out in the other thread (just to be sure I have not pointed out something plain wrong :D) Thanks Cristian On Sun, Jan 31, 2021 at 01:11:41PM +, Jonathan Cameron wrote: > On Fri, 29 Jan 2021 22:18:18 + > Jyoti Bhayana wrote: >

Re: [PATCH 2/3] hid-sensor-common: Add relative sensitivity check

2021-01-31 Thread Srinivas Pandruvada
On Sun, 2021-01-31 at 11:26 +, Jonathan Cameron wrote: > On Fri, 29 Jan 2021 00:35:49 +0800 > "Ye, Xiang" wrote: > > > Hi Srinivas andd Jonathan > > > > Thanks for the review. > > > > On Sun, Jan 24, 2021 at 08:20:12AM -0800, Srinivas Pandruvada > > wrote: > > > On Sun, 2021-01-24 at 13:14

Re: [RFC 08/20] mm: store completed TLB generation

2021-01-31 Thread Andy Lutomirski
On Sat, Jan 30, 2021 at 4:16 PM Nadav Amit wrote: > > From: Nadav Amit > > To detect deferred TLB flushes in fine granularity, we need to keep > track on the completed TLB flush generation for each mm. > > Add logic to track for each mm the tlb_gen_completed, which tracks the > completed TLB

Re: [RFC PATCH v4 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

2021-01-31 Thread Cristian Marussi
Hi Jyoti a few remarks down below, but beside those, while testing this series on a JUNO board (so lacking any GYRO/ACCEL sensor, a limited test case for now) I spotted that you missed in this series to add a matching device to the SCMI core. (as spotted by Jonathan too in his v4 review) In

Re: [PATCH 2/2] security.capability: fix conversions on getxattr

2021-01-31 Thread Eric W. Biederman
"Serge E. Hallyn" writes: > On Fri, Jan 29, 2021 at 04:55:29PM -0600, Eric W. Biederman wrote: >> "Serge E. Hallyn" writes: >> >> > On Thu, Jan 28, 2021 at 02:19:13PM -0600, Eric W. Biederman wrote: >> >> "Serge E. Hallyn" writes: >> >> >> >> > On Tue, Jan 19, 2021 at 07:34:49PM -0600, Eric

Re: [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken

2021-01-31 Thread Gabriel Krisman Bertazi
Linus Torvalds writes: > On Sun, Jan 31, 2021 at 10:54 AM Yuxuan Shui wrote: >> >> But renaming the definition in x86 is not enough, as TIF_SINGLESTEP is >> set in current_thread_info()->flags, and the same commit has removed the >> code that checks those flags. We have to also migrate

Re: [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken

2021-01-31 Thread Linus Torvalds
On Sun, Jan 31, 2021 at 10:54 AM Yuxuan Shui wrote: > > But renaming the definition in x86 is not enough, as TIF_SINGLESTEP is > set in current_thread_info()->flags, and the same commit has removed the > code that checks those flags. We have to also migrate TIF_SINGLESTEP from > thread info flags

Re: [v2] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu driver

2021-01-31 Thread Rob Clark
On Fri, Dec 18, 2020 at 2:27 AM Kalyan Thota wrote: > > Set the flag vblank_disable_immediate = true to turn off vblank irqs > immediately as soon as drm_vblank_put is requested so that there are > no irqs triggered during idle state. This will reduce cpu wakeups > and help in power saving. > >

Re: [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken

2021-01-31 Thread Yuxuan Shui
I didn't understand Kyle's point at first, so I asked for clarification and will record my understanding below for posterity. ARCH_SYSCALL_EXIT_WORK was a flag that was checked by various functions (via SYSCALL_EXIT_WORK) before calling syscall_exit_work, which is what reports single steps.

Re: [GIT PULL] Please pull NFS client bugfixes for 5.11

2021-01-31 Thread Linus Torvalds
On Sun, Jan 31, 2021 at 8:59 AM Trond Myklebust wrote: > > git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-5.11-3 Merged. However, it looks like you won't get a pr-tracker-bot reply because I'm not seeing this email on lore. So I'm doing these manual replies for now, it

Re: [GIT PULL] arm64 fixes for 5.11-rc6

2021-01-31 Thread Catalin Marinas
On Fri, Jan 29, 2021 at 02:09:05PM -0800, Linus Torvalds wrote: > On Fri, Jan 29, 2021 at 11:03 AM Catalin Marinas > wrote: > > > > arm64 fixes: > > > > - Fix the virt_addr_valid() returning true for < PAGE_OFFSET addresses. > > That's a really odd fix. > > It went from an incorrect bitwise

Re: [PATCH 2/2] vdpa/mlx5: Restore the hardware used index after change map

2021-01-31 Thread Eli Cohen
On Fri, Jan 29, 2021 at 11:49:45AM +0800, Jason Wang wrote: > > On 2021/1/28 下午9:41, Eli Cohen wrote: > > When a change of memory map occurs, the hardware resources are destroyed > > and then re-created again with the new memory map. In such case, we need > > to restore the hardware available and

Re: [PATCH 3/3] power: supply: max8997_charger: Switch to new binding

2021-01-31 Thread Krzysztof Kozlowski
On Sat, Jan 30, 2021 at 05:30:14PM +, Timon Baetz wrote: > Get regulator from parent device's node and extcon by name. > > Signed-off-by: Timon Baetz > --- > drivers/power/supply/max8997_charger.c | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git

Re: [bug] 5.11-rc5 brought page allocation failure issue [ttm][amdgpu]

2021-01-31 Thread Christian König
Am 31.01.21 um 02:03 schrieb David Rientjes: On Sat, 30 Jan 2021, David Rientjes wrote: On Sun, 31 Jan 2021, Mikhail Gavrilov wrote: The 5.11-rc5 (git 76c057c84d28) brought a new issue. Now the kernel log is flooded with the message "page allocation failure". Trace: msedge:cs0: page

[PATCH 04/13] staging: most: Switch from strlcpy to strscpy

2021-01-31 Thread Kumar Kartikeya Dwivedi
strlcpy is marked as deprecated in Documentation/process/deprecated.rst, and there is no functional difference when the caller expects truncation (when not checking the return value). strscpy is relatively better as it also avoids scanning the whole source string. This silences the related

<    1   2   3   4   5   6   >