Re: [PATCH 1/5] drivers: net: usb: rtl8150: bug fixing and cleanup

2013-05-19 Thread Petko Manolov
On Sun, 19 May 2013, Francois Romieu wrote: > Which one ? > - share it through the kernel or with userspace > - personal choice .c split It is obviously not the former. I think that in general constant and other definitions (in their majority) should be in a header file. I definitely like th

Re: NOHZ: WARNING: at arch/x86/kernel/smp.c:123 native_smp_send_reschedule, round 2

2013-05-19 Thread Michael Wang
On 05/20/2013 02:47 PM, Borislav Petkov wrote: > On Mon, May 20, 2013 at 02:23:37PM +0800, Michael Wang wrote: >> On 05/20/2013 12:50 PM, Borislav Petkov wrote: >>> On Mon, May 20, 2013 at 11:16:33AM +0800, Michael Wang wrote: I suppose the reason is that the cpu we passed to mod_delayed_

Re: [PATCH net-next] x86: bpf_jit_comp: secure bpf jit against spraying attacks

2013-05-19 Thread David Miller
From: Eric Dumazet Date: Fri, 17 May 2013 19:37:03 -0700 > From: Eric Dumazet > > hpa bringed into my attention some security related issues > with BPF JIT on x86. > > This patch makes sure the bpf generated code is marked read only, > as other kernel text sections. > > It also splits the unu

Re: [PATCH net-next] x86: bpf_jit_comp: secure bpf jit against spraying attacks

2013-05-19 Thread David Miller
From: Daniel Borkmann Date: Sun, 19 May 2013 19:02:46 +0200 > Probably other archs could later on follow-up with setting to > read-only, too. Only s390 and x86 support this facility. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@

Re: [lm-sensors] [PATCH] MAINTAINERS: Add myself as maintainer for LM95234 and TMP401 drivers

2013-05-19 Thread Jean Delvare
On Sun, 19 May 2013 20:48:35 -0700, Guenter Roeck wrote: > I wrote the LM95234 driver and extended the TMP401 driver substantially, > and I have hardware to test both, so it makes sense to explicitly > maintain them. > > Signed-off-by: Guenter Roeck > --- > MAINTAINERS | 14 ++ > 1

[PATCH v1 3/3] spi: s3c64xx: Added support for exynos5440 spi

2013-05-19 Thread Girish K S
From: Girish K S This patch adds support for the exynos5440 spi controller. The integration of the spi IP in exynos5440 is different from other SoC's. The I/O pins are no more configured via gpio, they have dedicated pins. Signed-off-by: Girish K S --- drivers/spi/spi-s3c64xx.c | 12

Re: [RFC PATCH 4/6] ARM: spear: use the core cpu hotplug functions

2013-05-19 Thread Viresh Kumar
Please write spear as SPEAr. On 20 May 2013 12:03, Sanjay Singh Rawat wrote: > Generic arm cpu hotplug related functions are moved to core hotplug code, > remove the functions from the platform code. > > Signed-off-by: Sanjay Singh Rawat > --- > arch/arm/mach-spear/hotplug.c | 37 +---

[PATCH v1 2/3] spi: s3c64xx: Added provision for dedicated cs pin

2013-05-19 Thread Girish K S
From: Girish K S The existing driver supports gpio based /cs signal. For controller's that have one device per controller, the slave device's /cs signal might be internally controlled by the chip select bit of slave select register. They are not externally asserted/deasserted using gpio pin. Thi

[PATCH v1 1/3] spi: s3c64xx: added support for polling mode

2013-05-19 Thread Girish K S
From: Girish K S The 64xx spi driver supports partial polling mode. Only the last chunk of the transfer length is transferred or recieved in polling mode. Some SoC's that adopt this controller might not have have dma interface. This patch adds support for complete polling mode and gives flexibit

[PATCH v1 0/3] Polling support for s3c64xx spi controller

2013-05-19 Thread Girish K S
This patch series adds support for the polling mode only. Also 2nd patch in the series adds support for dedicated cs pin. After Thomas's patch for using default gpio is merged(commit id: 00ab539), one of the patch in this series is dropped and new series is generated. Girish K S (3): spi: s3c64x

[PATCH 1/2] net/9p: Make 9P2000.L the default protocol for 9p file system

2013-05-19 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" If we dont' specify a protocol version default to 9P2000.L. 9P2000.L have better support for posix semantic and is where all the recent development is happening. Signed-off-by: Aneesh Kumar K.V --- net/9p/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 2/2] net/9p: Use virtio transpart as the default transport

2013-05-19 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" Make the default 9p experience better by defaulting to virtio transport if present. These days most of the users are using 9p in a virtualized setup Signed-off-by: Aneesh Kumar K.V --- net/9p/client.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/9p/clien

[PATCH] arm64: kernel: compiling issue, need 'EXPORT_SYMBOL_GPL(read_current_timer)'

2013-05-19 Thread Chen Gang
Need 'EXPORT_SYMBOL_GPL(read_current_timer)' if build with allmodconfig. The related error: ERROR: "read_current_timer" [lib/rbtree_test.ko] undefined! ERROR: "read_current_timer" [lib/interval_tree_test.ko] undefined! ERROR: "read_current_timer" [fs/ext4/ext4.ko] undefined! ERROR: "read_

Re: [PATCH 1/1] 6lowpan: Fix fragmentation with link-local compressed addresses

2013-05-19 Thread Alexander Aring
Hi David, I will try to figure out why link-layer address doesn't work on my setup. On Mon, May 20, 2013 at 12:14:48AM +0200, David Hauweele wrote: > Hello, > > There is a patch which fixes link-local address uncompression: > > http://permalink.gmane.org/gmane.linux.network.zigbee.devel/1717 >

Re: NOHZ: WARNING: at arch/x86/kernel/smp.c:123 native_smp_send_reschedule, round 2

2013-05-19 Thread Borislav Petkov
On Mon, May 20, 2013 at 02:23:37PM +0800, Michael Wang wrote: > On 05/20/2013 12:50 PM, Borislav Petkov wrote: > > On Mon, May 20, 2013 at 11:16:33AM +0800, Michael Wang wrote: > >> I suppose the reason is that the cpu we passed to > >> mod_delayed_work_on() has a chance to become offline before we

mm: Remove duplicated call of get_pfn_range_for_nid

2013-05-19 Thread Zhang Yanfei
When calculating pages in a node, for each zone in that node, we will have zone_spanned_pages_in_node --> get_pfn_range_for_nid zone_absent_pages_in_node --> get_pfn_range_for_nid That is to say, we call the get_pfn_range_for_nid to get start_pfn and end_pfn of the node for MAX_NR_ZONE

RE: [PATCH 1/3] Thermal: core: Ask .get_trip_temp() to register thermal zone device.

2013-05-19 Thread R, Durgadoss
> -Original Message- > From: linux-pm-ow...@vger.kernel.org [mailto:linux-pm- > ow...@vger.kernel.org] On Behalf Of Jonghwa Lee > Sent: Saturday, May 18, 2013 3:20 PM > To: linux...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Zhang, Rui; Eduardo Valentin; Amit Dinel > Kachhap; Jongh

[PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume

2013-05-19 Thread Naveen Krishna Chatradhi
The exynos_adc device structure was wrongly extracted from the dev* correcting the same. Using the regular conversion of struct device* -> struct platform_device* -> struct exynos_adc* seems wrong. Instead we should be doing struct device* -> struct iio_dev* -> struct exynos_adc* Signed-off-by: N

Re: [PATCH v2, part 1 8/9] PCI: make PCI host bridge/bus creating and destroying logic symmetric

2013-05-19 Thread Gu Zheng
On 05/14/2013 12:08 AM, Jiang Liu wrote: > This patch makes PCI host bridge/bus creating and destroying logic > symmetric by using device_initialize()/device_add()/device_del()/put_device() > pairs as discussed in thread at: > http://comments.gmane.org/gmane.linux.kernel.pci/22073 > > It also fi

[RFC PATCH 4/6] ARM: spear: use the core cpu hotplug functions

2013-05-19 Thread Sanjay Singh Rawat
Generic arm cpu hotplug related functions are moved to core hotplug code, remove the functions from the platform code. Signed-off-by: Sanjay Singh Rawat --- arch/arm/mach-spear/hotplug.c | 37 + 1 file changed, 1 insertion(+), 36 deletions(-) diff --git a/a

[RFC PATCH 2/6] ARM: imx: use the core cpu hotplug functions

2013-05-19 Thread Sanjay Singh Rawat
Generic arm cpu hotplug related functions are moved to core hotplug code, remove the functions from the platform code. Signed-off-by: Sanjay Singh Rawat --- arch/arm/mach-imx/hotplug.c | 22 +- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/arch/arm/mach-imx/

[RFC PATCH 5/6] ARM: vexpress: use the core cpu hotplug functions

2013-05-19 Thread Sanjay Singh Rawat
Generic arm cpu hotplug related functions are moved to core hotplug code, remove the functions from the platform code. Signed-off-by: Sanjay Singh Rawat --- arch/arm/mach-vexpress/hotplug.c | 38 +- 1 file changed, 1 insertion(+), 37 deletions(-) diff --git

[RFC PATCH 6/6] ARM: EXYNOS: use the core cpu hotplug functions

2013-05-19 Thread Sanjay Singh Rawat
Generic arm cpu hotplug related functions are moved to core hotplug code, Exynos-4 is having Cortex-A9, remove the functions from the platform code. Signed-off-by: Sanjay Singh Rawat --- arch/arm/mach-exynos/hotplug.c | 40 ++-- 1 file changed, 2 insertions(

[RFC PATCH 3/6] ARM: RealView: use the core cpu hotplug functions

2013-05-19 Thread Sanjay Singh Rawat
Generic arm cpu hotplug related functions are moved to core hotplug code, remove the functions from the platform code. Signed-off-by: Sanjay Singh Rawat --- arch/arm/mach-realview/hotplug.c | 37 + 1 file changed, 1 insertion(+), 36 deletions(-) diff --git

[RFC PATCH 0/6] ARM: cpuhotplug: move common functions to core

2013-05-19 Thread Sanjay Singh Rawat
Various SoCs with arm processors define their own platform hotplug related functions. These functions can be defined as part of the core cpu hotplug functions, this will avoid the duplication. This patchset is intended to address this issue. This patchset covers arm-Cortex-A9 of exynos, imx, realv

[RFC PATCH 1/6] ARM: cpuhotplug: move common hotplug related functions to core

2013-05-19 Thread Sanjay Singh Rawat
Add function which prepare arm processors to enter the low power for hotplug functionality and handle the return path. Signed-off-by: Sanjay Singh Rawat --- arch/arm/include/asm/hotplug.h | 24 +++ arch/arm/kernel/Makefile |1 + arch/arm/kernel/cpuhotplug.c | 64 +

Re: NOHZ: WARNING: at arch/x86/kernel/smp.c:123 native_smp_send_reschedule, round 2

2013-05-19 Thread Michael Wang
On 05/20/2013 12:50 PM, Borislav Petkov wrote: > On Mon, May 20, 2013 at 11:16:33AM +0800, Michael Wang wrote: >> I suppose the reason is that the cpu we passed to >> mod_delayed_work_on() has a chance to become offline before we >> disabled irq, what about check it before send resched ipi? like: >

Re: [PATCH v6 05/10 fix] mtd: get the ECC info from the Extended Parameter Page

2013-05-19 Thread Brian Norris
Hi Huang, Vikram, On 05/19/2013 07:08 PM, Huang Shijie wrote: ... + /* +* From section 5.7.2.2, we know that the Extened Param Page is valid +* when two or more bytes of the signatrue are valid. s/signatrue/signature +* So we only check the first two bytes here.

[PATCH] ASoC: max98090: request IRQF_ONESHOT interrupt

2013-05-19 Thread Andrew Bresticker
request_threaded_irq() rejects calls which both do not specify a handler (indicating that the primary IRQ handler should be used) and do not set IRQF_ONESHOT because the combination is unsafe with level-triggered interrupts. It is safe in this case, though, since max98090 IRQs are edge-triggered a

[PATCH] arm64: kernel: need extern variable 'screen_info' for related driver using.

2013-05-19 Thread Chen Gang
Add the extern variable 'screen_info' according to arm32 has done. The related error: drivers/video/console/vgacon.c:1305: undefined reference to `screen_info' Signed-off-by: Chen Gang --- arch/arm64/kernel/setup.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff

Re: [PATCH 07/18] cpufreq: s3c24xx: move cpufreq driver to drivers/cpufreq

2013-05-19 Thread Viresh Kumar
On 14 May 2013 18:30, Rafael J. Wysocki wrote: > On Tuesday, May 14, 2013 09:36:42 PM Kukjin Kim wrote: >> Viresh Kumar wrote: >> > >> > On 13 May 2013 16:21, Rafael J. Wysocki wrote: >> > > That doesn't matter I suppose. I can take it, but please rebase it on >> > top >> > > of current linux-ne

[PATCH] lib/mpi/mpicoder.c: looping issue, need stop when equal to zero, found by 'EXTRA_FLAGS=-W'.

2013-05-19 Thread Chen Gang
For 'while' looping, need stop when 'nbytes == 0', or will cause issue. ('nbytes' is size_t which is always bigger or equal than zero). The related warning: (with EXTRA_CFLAGS=-W) lib/mpi/mpicoder.c:40:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] Signed-o

Re: kernel 3.10-rc1 p-state/cpuidle panic

2013-05-19 Thread Borislav Petkov
Hmm, divide by 0, it seems. + Dirk Brandewie. On Sun, May 19, 2013 at 01:25:41PM +0200, Tommy Apel Hansen wrote: > Hello guys, I'm getting this with the current 3.10-rc1, I've enabled the new > full-NOHZ > I'm not sure though if that has something to do with this or if something is > changed i

Re: NOHZ: WARNING: at arch/x86/kernel/smp.c:123 native_smp_send_reschedule, round 2

2013-05-19 Thread Borislav Petkov
On Mon, May 20, 2013 at 11:16:33AM +0800, Michael Wang wrote: > I suppose the reason is that the cpu we passed to > mod_delayed_work_on() has a chance to become offline before we > disabled irq, what about check it before send resched ipi? like: I think this is only addressing the symptoms - what

linux-next: Tree for May 20

2013-05-19 Thread Stephen Rothwell
Hi all, Changes since 20130517: The usb.current tree gained a conflict against Linus' tree. The rr-fixes tree gained a build failure so I used the version from next-20130515. The akpm tree gained conflicts against Linus' and the net-next tree. --

RE: [v2, 3/3] ARM: dts: AM33XX: Add NAND flash device tree data to am335x-evm

2013-05-19 Thread Gupta, Pekon
> > > > > > > > am33xx_pinmux: pinmux@44e10800 { > > > > pinctrl-names = "default"; > > > > - pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0>; > > > > + pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0 > > > > + &nandflash_pi

RE: Regression in 3735ba8db8e6ea22ad3ff524328926d8d780a884 with Freescale P1020

2013-05-19 Thread Mehresh Ramneek-B31383
Hi Shengzhou/Braun, We changed the controller init sequence to make this work. I'll submit the patch upstream soon. Regards, Ramneek -Original Message- From: Liu Shengzhou-B36685 Sent: Monday, May 20, 2013 9:07 AM To: Michael Braun; Mehresh Ramneek-B31383 Cc: projekt-w...@fem.tu-ilmena

Re: [PATCH 17/18] cpufreq: powerpc: move cpufreq driver to drivers/cpufreq

2013-05-19 Thread Viresh Kumar
On 13 May 2013 11:34, Viresh Kumar wrote: > On 22 April 2013 12:19, Viresh Kumar wrote: >> On 9 April 2013 14:05, Viresh Kumar wrote: >>> On 5 April 2013 12:16, Viresh Kumar wrote: On 4 April 2013 18:24, Viresh Kumar wrote: > This patch moves cpufreq driver of powerpc platform to driv

Re: [PATCH 2/2] cpufreq: Don't create empty /sys/devices/system/cpu/cpufreq directory

2013-05-19 Thread Viresh Kumar
On 20 May 2013 00:13, Francesco Lavra wrote: > On 05/17/2013 01:26 PM, Viresh Kumar wrote: >> +EXPORT_SYMBOL(get_cpufreq_global_kobject); >> +EXPORT_SYMBOL(put_cpufreq_global_kobject); > > Global symbol names should begin with a sensible prefix; in this case, > it looks like cpufreq_get_global_kob

[PATCH] arm64: compiling issue for allmodconfig, need "asm/parport.h" by "drivers/parport/parport_pc.c"

2013-05-19 Thread Chen Gang
Need add the default file in 'asm/Kbuild' just like arm has done. The build command is: make EXTRA_CFLAGS=-W ARCH=arm64 allmodconfig make EXTRA_CFLAGS=-W ARCH=arm64 menuconfig set "aarch64-linux-gnu-" as cross compiling prefix. make EXTRA_CFLAGS=-W ARCH=arm64 The related error: drive

Re: [PATCH 2/2] cpufreq: Don't create empty /sys/devices/system/cpu/cpufreq directory

2013-05-19 Thread Viresh Kumar
On 20 May 2013 00:13, Francesco Lavra wrote: > On 05/17/2013 01:26 PM, Viresh Kumar wrote: >> +EXPORT_SYMBOL(get_cpufreq_global_kobject); >> +EXPORT_SYMBOL(put_cpufreq_global_kobject); > > Global symbol names should begin with a sensible prefix; in this case, > it looks like cpufreq_get_global_kob

Re: linux-next: manual merge of the usb.current tree with Linus' tree

2013-05-19 Thread Greg KH
On Mon, May 20, 2013 at 10:21:59AM +1000, Stephen Rothwell wrote: > Hi Greg, > > Today's linux-next merge of the usb.current tree got a conflict in > drivers/usb/host/ohci-nxp.c between commit bb522812a1a6 > ("drivers/usb/host: don't check resource with devm_ioremap_resource") > from Linus' tree a

linux-next: manual merge of the akpm tree with the net-next tree

2013-05-19 Thread Stephen Rothwell
Hi Andrew, Today's linux-next merge of the akpm tree got a conflict in arch/x86/net/bpf_jit_comp.c between commit 650c8496702f ("x86: bpf_jit_comp: can call module_free() from any context") from the net-next tree and commit "bpf: add comments explaining the schedule_work() operation" from the akpm

linux-next: manual merge of the akpm tree with the net-next tree

2013-05-19 Thread Stephen Rothwell
Hi Andrew, Today's linux-next merge of the akpm tree got a conflict in arch/sparc/net/bpf_jit_comp.c between commit 5199dfe531db ("sparc: bpf_jit_comp: can call module_free() from any context") from the net-next tree and commit "bpf: add comments explaining the schedule_work() operation" from the

linux-next: manual merge of the akpm tree with Linus' tree

2013-05-19 Thread Stephen Rothwell
Hi Andrew, Today's linux-next merge of the akpm tree got conflicts in fs/btrfs/inode.c and fs/btrfs/volumes.c between commit 9be3395bcd4a ("Btrfs: use a btrfs bioset instead of abusing bio internals") from Linus' tree and commit "block: prep work for batch completion" from the akpm tree. I fixed

[PATCH] MAINTAINERS: Add myself as maintainer for LM95234 and TMP401 drivers

2013-05-19 Thread Guenter Roeck
I wrote the LM95234 driver and extended the TMP401 driver substantially, and I have hardware to test both, so it makes sense to explicitly maintain them. Signed-off-by: Guenter Roeck --- MAINTAINERS | 14 ++ 1 file changed, 14 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS i

RE: Regression in 3735ba8db8e6ea22ad3ff524328926d8d780a884 with Freescale P1020

2013-05-19 Thread Liu Shengzhou-B36685
Hi Braun, At that time I had an P4080DS board which had the same issue and had been fixed with this patch. I didn't test it on P1020 due to the absence of P1020. I think P1020 will need a new patch besides this one. Later Ramneek took this issue on P1020 for more investigation. Hello Ramneek, a

[PATCH 02/15] f2fs: remove unnecessary flag set

2013-05-19 Thread Jaegeuk Kim
If an inode is recovered with its dentry, it will not invoke __f2fs_add_link, since the recovery routine checks its dentry before calling __f2fs_add_link. Signed-off-by: Jaegeuk Kim --- fs/f2fs/recovery.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/f2fs/recovery.c

[PATCH 01/15] f2fs: remove redundant assignment

2013-05-19 Thread Jaegeuk Kim
We don't need to assign a value redundantly. Signed-off-by: Jaegeuk Kim --- fs/f2fs/recovery.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c index 60c8a50..2941987 100644 --- a/fs/f2fs/recovery.c +++ b/fs/f2fs/recovery.c @@ -126,

[PATCH 05/15] f2fs: remove unnecessary por_doing check

2013-05-19 Thread Jaegeuk Kim
This por_doing check is totally not related to the recovery process. Signed-off-by: Jaegeuk Kim --- fs/f2fs/namei.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index 47abc97..729b285 100644 --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@

[PATCH 03/15] f2fs: fix por_doing variable coverage

2013-05-19 Thread Jaegeuk Kim
The reason of using sbi->por_doing is to alleviate data writes during the recovery. The find_fsync_dnodes() produces some dirty dentry pages, so we should cover it too with sbi->por_doing. Signed-off-by: Jaegeuk Kim --- fs/f2fs/recovery.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 08/15] f2fs: update inode page after creation

2013-05-19 Thread Jaegeuk Kim
I found a bug when testing power-off-recovery as follows. [Bug Scenario] 1. create a file 2. fsync the file 3. reboot w/o any sync 4. try to recover the file - found its fsync mark - found its dentry mark : try to recover its dentry - get its file name - get its parent inode number

[PATCH 06/15] f2fs: skip get_node_page if locked node page is passed

2013-05-19 Thread Jaegeuk Kim
If get_dnode_of_data gets a locked node page, let's skip redundant get_node_page calls. This is for the futher enhancement. Signed-off-by: Jaegeuk Kim --- fs/f2fs/node.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 9641534..f6

[PATCH 04/15] f2fs: fix BUG_ON during f2fs_evict_inode(dir)

2013-05-19 Thread Jaegeuk Kim
During the dentry recovery routine, recover_inode() triggers __f2fs_add_link with its directory inode. In the following scenario, a bug is captured. 1. dir = f2fs_iget(pino) 2. __f2fs_add_link(dir, name) 3. iput(dir) -> f2fs_evict_inode() faces with BUG_ON(atomic_read(fi->dirty_dents)) Kerne

[PATCH 07/15] f2fs: change get_new_data_page to pass a locked node page

2013-05-19 Thread Jaegeuk Kim
This patch is for passing a locked node page to get_dnode_of_data. Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 12 +++- fs/f2fs/dir.c | 4 ++-- fs/f2fs/f2fs.h | 2 +- fs/f2fs/file.c | 2 +- 4 files changed, 11 insertions(+), 9 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/d

[PATCH 09/15] f2fs: add debug msgs in the recovery routine

2013-05-19 Thread Jaegeuk Kim
This patch adds some trivial debugging messages in the recovery process. Signed-off-by: Jaegeuk Kim --- fs/f2fs/node.c | 1 - fs/f2fs/recovery.c | 44 +--- 2 files changed, 25 insertions(+), 20 deletions(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.

Re: [PATCH] virtio-net: Reporting traffic queue distribution statistics through ethtool

2013-05-19 Thread Jason Wang
On 05/20/2013 06:56 AM, Narasimhan, Sriram wrote: > Hi Michael, > > Comments inline... > > -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Sunday, May 19, 2013 1:03 PM > To: Narasimhan, Sriram > Cc: ru...@rustcorp.com.au; virtualizat...@lists.linux-foundation

RE: [PATCH v3] clocksource: add MVF600 pit timer support

2013-05-19 Thread Lu Jingchang-B35083
>-Original Message- >From: Shawn Guo [mailto:shawn@linaro.org] >Sent: Monday, May 20, 2013 11:21 AM >To: Lu Jingchang-B35083 >Cc: linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; >john.stu...@linaro.org; t...@linutronix.de; s.ha...@pengutronix.de >Subject: Re: [PATC

Re: [PATCH v3] clocksource: add MVF600 pit timer support

2013-05-19 Thread Shawn Guo
On Mon, May 20, 2013 at 03:08:54AM +, Lu Jingchang-B35083 wrote: > [Lu Jingchang-B35083] > I am not sure MVF5xx and MVF7xx have the same PIT block, if you have > information that it is the same on other Vybrid SoCs, it is ok to change the > driver name to mvf. Thanks! Even the PIT block o

[PATCH 1/2] f2fs: remove unnecessary kmap/kunmap operations

2013-05-19 Thread Jaegeuk Kim
The allocated page used by the recovery is not on HIGHMEM, so that we don't need to use kmap/kunmap. Signed-off-by: Jaegeuk Kim --- fs/f2fs/recovery.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c index 774efdb..5fcdd08 100644

[PATCH 2/2] f2fs: fix to unlock page before exit

2013-05-19 Thread Jaegeuk Kim
If we got an error after lock_page, we should unlock it before exit. Signed-off-by: Jaegeuk Kim --- fs/f2fs/recovery.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c index 5fcdd08..edb89a3 100644 --- a/fs/f2fs/recovery.c +++ b/fs/

Re: NOHZ: WARNING: at arch/x86/kernel/smp.c:123 native_smp_send_reschedule, round 2

2013-05-19 Thread Michael Wang
Hi, Borislav On 05/17/2013 09:56 PM, Borislav Petkov wrote: [snip] > [ 51.737378] [] native_smp_send_reschedule+0x58/0x60 > [ 51.744013] [] wake_up_nohz_cpu+0x2d/0xa0 I suppose the reason is that the cpu we passed to mod_delayed_work_on() has a chance to become offline before we disabled ir

RE: [PATCH v3] clocksource: add MVF600 pit timer support

2013-05-19 Thread Lu Jingchang-B35083
>-Original Message- >From: Shawn Guo [mailto:shawn@linaro.org] >Sent: Monday, May 20, 2013 10:28 AM >To: Lu Jingchang-B35083 >Cc: linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; >john.stu...@linaro.org; t...@linutronix.de; s.ha...@pengutronix.de >Subject: Re: [PATC

Re: linux-next: build failure after merge of the rr-fixes tree

2013-05-19 Thread Rusty Russell
Stephen Rothwell writes: > Hi Rusty, > > After merging the rr-fixes tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/dma/iovlock.c: In function 'dma_pin_iovec_pages': > drivers/dma/iovlock.c:98:21: error: dereferencing pointer to incomplete type >down_read(¤

NIST SP800-138 availibility using kernel crypto APIs for SMB3.0 MAC generation

2013-05-19 Thread Shirish Pargaonkar
With the recent patches added to kernel crypto for improving AES support, adding aesni etc, it seems like it is time to add AES CMAC to the cifs kernel module (for the popular SMB3 signing and per-share encryption) but needed for an implementation for SP800-138 in kernel crypto codebase. Was specif

Re: [Consult] Why need we call device_remove_file() firstly before call device_unregister() ?

2013-05-19 Thread Chen Gang
On 05/20/2013 10:20 AM, Greg Kroah-Hartman wrote: > On Mon, May 20, 2013 at 10:12:41AM +0800, Chen Gang wrote: >> > I mean that if no reply by any other members within a week, I will know >> > it is correct that "we need not call device_remove_file() firstly before >> > call device_unregister()" (a

Re: [PATCHv2] virtio_pci: better macro exported in uapi

2013-05-19 Thread Rusty Russell
"Michael S. Tsirkin" writes: > Macro VIRTIO_PCI_CONFIG assumes that userspace actually has a structure > with a field named msix_enabled. Add VIRTIO_PCI_CONFIG_OFF that gets > the msix_enabled by value instead, to make it useful for userspace. We > still keep VIRTIO_PCI_CONFIG around for now, i

Re: [PATCH] virtio_pci: fix macro exported in uapi

2013-05-19 Thread Rusty Russell
David Howells writes: > Rusty Russell wrote: > >> Macro still isn't usable, because userspace can't know whether it's the >> new or old. >> >> We need to either remove it from UAPI, or rename it to >> VIRTIO_PCI_CONFIG_OFF. > > Surely, if userspace is using it as is, you can't remove it, rename

Re: [patch v7 0/21] sched: power aware scheduling

2013-05-19 Thread Preeti U Murthy
Hi Alex, On 05/20/2013 06:31 AM, Alex Shi wrote: > >> Which are the workloads where 'powersaving' mode hurts workload >> performance measurably? >> >> I ran ebizzy on a 2 socket, 16 core, SMT 4 Power machine. > > Is this a 2 * 16 * 4 LCPUs PowerPC machine? This is a 2 * 8 * 4 LCPUs Pow

[PATCH 2/3] x86: asus-laptop: fix invalid point access

2013-05-19 Thread Libo Chen
asus->name is null or point to const string,so it is not suitable to kfree it. Signed-off-by: Libo Chen --- drivers/platform/x86/asus-laptop.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index 0eea09c..8e268da 10064

[PATCH 3/3] x86 platform drivers: fix gpio leak

2013-05-19 Thread Libo Chen
when request_irq faild, we should release gpiochip Signed-off-by: Libo Chen --- drivers/platform/x86/intel_pmic_gpio.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) mode change 100644 => 100755 drivers/platform/x86/intel_pmic_gpio.c diff --git a/drivers/platform/x86/intel_pmic_gpi

[PATCH 0/3] fix x86 driver memleak

2013-05-19 Thread Libo Chen
fix memleak or invalite point acesss about x86 platform drivers Libo Chen (3): x86: msi-laptop: fix memleak x86: asus-laptop: fix invalid point access x86 platform drivers: fix gpio leak drivers/platform/x86/asus-laptop.c | 1 - drivers/platform/x86/intel_pmic_gpio.c | 5 - driv

[PATCH 1/3] x86: msi-laptop: fix memleak

2013-05-19 Thread Libo Chen
1. fix two visible mistakes: * when load_scm_model_init faild, we should call platform_device_del(msipf_device) * msipf_attribute_group should be remove in err case 2. change some tags, give them real meaning. Signed-off-by: Libo Chen --- drivers/platform/x86/msi-laptop.c | 24 +++

Re: [PATCH v3] clocksource: add MVF600 pit timer support

2013-05-19 Thread Shawn Guo
On Thu, May 16, 2013 at 02:15:24PM +0800, Jingchang Lu wrote: > Add Freescale Vybrid MVF600 period interrupt timer support. > > Signed-off-by: Jingchang Lu > --- > v3: > move the pit driver to drivers/clocksource. > > drivers/clocksource/Kconfig| 5 + > drivers/clocksource/Makef

[PATCH v6 05/10 fix] mtd: get the ECC info from the Extended Parameter Page

2013-05-19 Thread Huang Shijie
Since the ONFI 2.1, the onfi spec adds the Extended Parameter Page to store the ECC info. The onfi spec tells us that if the nand chip's recommended ECC codeword size is not 512 bytes, then the @ecc_bits is 0xff. The host _SHOULD_ then read the Extended ECC information that is part of the extended

Re: [Consult] Why need we call device_remove_file() firstly before call device_unregister() ?

2013-05-19 Thread Greg Kroah-Hartman
On Mon, May 20, 2013 at 10:12:41AM +0800, Chen Gang wrote: > I mean that if no reply by any other members within a week, I will know > it is correct that "we need not call device_remove_file() firstly before > call device_unregister()" (at least, one member's reply supports this > conclusion). > >

Re: [Consult] Why need we call device_remove_file() firstly before call device_unregister() ?

2013-05-19 Thread Chen Gang
On 05/20/2013 09:45 AM, Greg Kroah-Hartman wrote: > On Mon, May 20, 2013 at 09:03:27AM +0800, Chen Gang wrote: >> > On 05/18/2013 07:06 PM, Ming Lei wrote: >>> > > Hi, >>> > > >>> > > On Fri, May 17, 2013 at 1:43 PM, Chen Gang >>> > > wrote: > >> Hello All: > >> > >> I searched 'a

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-19 Thread Asias He
On Fri, May 17, 2013 at 04:25:49PM +0930, Rusty Russell wrote: > Randy Dunlap writes: > > On 05/16/13 16:42, Rusty Russell wrote: > >> Joe Perches writes: > >>> On Thu, 2013-05-16 at 13:04 +0930, Rusty Russell wrote: > Asias He writes: > > On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty

RE: [PATCH 3.9-stable] NTB: variable dereferenced before check

2013-05-19 Thread Jonghwan Choi
Jon Mason agrees that this could also be applied to the 3.9 "Yes, please do. I'll respond to each of the patch series, but please apply them all. Also, one patch was omitted from these, titled NTB: variable dereferenced before check Please include that patch in 3.9 stable as well. " Thanks. B

[PATCH 3.9-stable] NTB: variable dereferenced before check

2013-05-19 Thread Jonghwan Choi
This patch looks like it should be in the 3.9-stable tree, should we apply it? -- From: "Jon Mason " commit 186f27ff9f9ec5c110739ced88ce9f8fca053882 upstream Correct instances of variable dereferencing before checking its value on the functions exported to the client drivers. A

Re: [Consult] Why need we call device_remove_file() firstly before call device_unregister() ?

2013-05-19 Thread Greg Kroah-Hartman
On Mon, May 20, 2013 at 09:03:27AM +0800, Chen Gang wrote: > On 05/18/2013 07:06 PM, Ming Lei wrote: > > Hi, > > > > On Fri, May 17, 2013 at 1:43 PM, Chen Gang wrote: > >> Hello All: > >> > >> I searched 'arch/*' and 'drivers/*' sub-directory, all of them are 'obey > >> this rule', even in device

[PATCH] cdrom: gdrom: fix device number leak

2013-05-19 Thread Libo Chen
"repost with Jens Axboe added" suggest by Tejun Heo without this patch, gdrom_major will leak when gd.cd_info alloc faild Signed-off-by: Libo Chen --- drivers/cdrom/gdrom.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom

Re: [PATCH] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove()

2013-05-19 Thread Simon Horman
On Sun, May 19, 2013 at 04:22:21PM +0200, Laurent Pinchart wrote: > Hi Axel, > > Thank you for the patch. > > On Sunday 19 May 2013 13:45:31 Axel Lin wrote: > > Signed-off-by: Axel Lin > > --- > > drivers/pwm/pwm-renesas-tpu.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > d

[PATCH] ARM: at91: Fix: Change internal SRAM memory type to "MT_MEMORY_SO"

2013-05-19 Thread Wenyou Yang
Signed-off-by: Wenyou Yang --- arch/arm/mach-at91/setup.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-at91/setup.c b/arch/arm/mach-at91/setup.c index e2f4bdd..d68be6c 100644 --- a/arch/arm/mach-at91/setup.c +++ b/arch/arm/mach-at91/setup.c @@ -80,7 +80,7 @

[PATCH] Change internal SRAM memory type to "MT_MEMORY_SO"

2013-05-19 Thread Wenyou Yang
Hi Russell, This patch is to change the internal SRAM memory type to "MT_MEMORY_SO", the right type. It tested on sama5d3xek boards. It based on v3.10-rc1. Best Regards, Wenyou Yang Wenyou Yang (1): ARM: at91: Fix: Change internal SRAM memory type to "MT_MEMORY_SO" arch/arm/mach-at91/setu

Re: [Consult] Why need we call device_remove_file() firstly before call device_unregister() ?

2013-05-19 Thread Chen Gang
On 05/18/2013 07:06 PM, Ming Lei wrote: > Hi, > > On Fri, May 17, 2013 at 1:43 PM, Chen Gang wrote: >> Hello All: >> >> I searched 'arch/*' and 'drivers/*' sub-directory, all of them are 'obey >> this rule', even in device_unregister() itself, it also firstly calls >> device_remove_file(), then c

Re: [patch v7 0/21] sched: power aware scheduling

2013-05-19 Thread Alex Shi
> Which are the workloads where 'powersaving' mode hurts workload > performance measurably? > > I ran ebizzy on a 2 socket, 16 core, SMT 4 Power machine. Is this a 2 * 16 * 4 LCPUs PowerPC machine? > The power efficiency drops significantly with the powersaving policy of > this patch,ov

linux-next: build failure after merge of the rr-fixes tree

2013-05-19 Thread Stephen Rothwell
Hi Rusty, After merging the rr-fixes tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/dma/iovlock.c: In function 'dma_pin_iovec_pages': drivers/dma/iovlock.c:98:21: error: dereferencing pointer to incomplete type down_read(¤t->mm->mmap_sem); ^

Re: [PATCH] leds: leds-gpio: reserve gpio before using it

2013-05-19 Thread Jingoo Han
Friday, May 17, 2013 4:49 PM, Timo Teras wrote: > > This reverts commit a99d76f (leds: leds-gpio: use gpio_request_one) > and commit 2d7c22f (leds: leds-gpio: set devm_gpio_request_one() > flags param correctly) which was a fix of the first one. > > The conversion to devm_gpio_request in commit e

linux-next: manual merge of the usb.current tree with Linus' tree

2013-05-19 Thread Stephen Rothwell
Hi Greg, Today's linux-next merge of the usb.current tree got a conflict in drivers/usb/host/ohci-nxp.c between commit bb522812a1a6 ("drivers/usb/host: don't check resource with devm_ioremap_resource") from Linus' tree and commit b3517d5de80e ("usb: ohci: fix goto wrong tag in err case") from the

[PATCH testing] mrf24j40: Move INIT_COMPLETION to before the packet is sent

2013-05-19 Thread Alan Ott
This avoids a race condition where the tx_complete interrupt could happen before the completion is initialized. --- David H, Try this out and see if it changes anything for you. I put a bunch of schedule_timeout()s in mrf24j40_tx() to basically guarantee that a reception will happen during mrf24

linux-next: question about the pwm tree

2013-05-19 Thread Stephen Rothwell
Hi Thierry, I noticed that you changed the email address for the maintainer of the pwm tree in the MAINTAINERS file. should I use this new address as your contact for linux-next as well? -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpI7a6E0qm98.pgp Description: PGP si

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-19 Thread Seth Jennings
On Fri, May 17, 2013 at 05:54:18PM +0100, Mel Gorman wrote: > On Mon, May 13, 2013 at 07:40:02AM -0500, Seth Jennings wrote: > > zswap is a thin compression backend for frontswap. It receives pages from > > frontswap and attempts to store them in a compressed memory pool, resulting > > in > > an e

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-19 Thread Rusty Russell
Randy Dunlap writes: > On 05/16/13 16:42, Rusty Russell wrote: >> Joe Perches writes: >>> On Thu, 2013-05-16 at 13:04 +0930, Rusty Russell wrote: Asias He writes: > On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote: >>> [] > Other users are using memcpy_fromiovec and fri

pipe/fifo, set exception for select() when read end is not open

2013-05-19 Thread Neal Murphy
I've been looking at the gule hacks I have to use to get inotifywait to work in shell scripts. So I figgered I would hack inotifywait to look at exceptions in its select() loop. No joy. inotifywait loops using select() to look for changes to at least one inotify FD. Whenever it sees a change, i

Re: [Linux-zigbee-devel] [PATCH 2/2] mrf24j40: Keep the interrupt line enabled

2013-05-19 Thread Alan Ott
On 05/16/2013 05:34 PM, David Hauweele wrote: > I have seen the interrupt line going low forever with heavy traffic. Hi David, I've been doing some testing today and I can reproduce your issue if I ping -f both ways simultaneously (after about 3-4 minutes usually). I think it has more to do with

RE: [PATCH] virtio-net: Reporting traffic queue distribution statistics through ethtool

2013-05-19 Thread Narasimhan, Sriram
Hi Michael, Comments inline... -Original Message- From: Michael S. Tsirkin [mailto:m...@redhat.com] Sent: Sunday, May 19, 2013 1:03 PM To: Narasimhan, Sriram Cc: ru...@rustcorp.com.au; virtualizat...@lists.linux-foundation.org; k...@vger.kernel.org; net...@vger.kernel.org; linux-kernel@

[PATCH] ipc,sem: move restart loop to do_smart_update

2013-05-19 Thread Rik van Riel
On Sat, 18 May 2013 15:48:06 +0200 Manfred Spraul wrote: > Hi Rik, > > I like your change to the ipc/sem locking: > A scheme with a per-semaphore lock and without the overhead of always > acquiring both the global and the per-semaphore lock. > > But: > 1) I found one bug with your sem locking

Re: [PATCH 1/1] 6lowpan: Fix fragmentation with link-local compressed addresses

2013-05-19 Thread David Hauweele
Hello, There is a patch which fixes link-local address uncompression: http://permalink.gmane.org/gmane.linux.network.zigbee.devel/1717 I came across a similar solution but didn't submit it as another patch already existed. This patch instead focus on fragmented packet with link-local address com

Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-19 Thread Seth Jennings
On Fri, May 17, 2013 at 04:48:37PM +0100, Mel Gorman wrote: > On Mon, May 13, 2013 at 07:40:01AM -0500, Seth Jennings wrote: > > zbud is an special purpose allocator for storing compressed pages. It is > > designed to store up to two compressed pages per physical page. While this > > design limits

  1   2   >