[PATCH net-next 7/7] net: hns3: Cleanup for non-static function in hns3 driver

2017-10-08 Thread Yunsheng Lin
This patch fixes the following warning from sparse: warning: symbol 'hns3_set_multicast_list' was not declared. Should it be static. hns3_set_multicast_list turns out to be not used, so delete it. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c | 4 ++-- ..

Re: [PATCH] leds: tca6507: Remove unnecessary reg check

2017-10-08 Thread Pavel Machek
On Sun 2017-10-08 19:55:05, Christos Gkekas wrote: > Variable reg is unsigned so checking whether it is less than zero is not > necessary. > > Signed-off-by: Christos Gkekas Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff

[PATCH net-next 6/7] net: hns3: Cleanup for endian issue in hns3 driver

2017-10-08 Thread Yunsheng Lin
This patch fixes a lot of endian issues detected by sparse. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c | 8 +- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 10 +- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 206 - ..

[PATCH net-next 5/7] net: hns3: Cleanup for struct that used to send cmd to firmware

2017-10-08 Thread Yunsheng Lin
The hclge_tm module has already added _cmd to the end of struct that used to send cmd to firmware. This will help us finding the endian issues. This patch adds the _cmd to the end of struct that used to send cmd to firmware in hclge_main module. Signed-off-by: Yunsheng Lin --- .../net/ethernet/h

[PATCH net-next 3/7] net: hns3: Cleanup indentation for Kconfig in the the hisilicon folder

2017-10-08 Thread Yunsheng Lin
This patch fixes a few indentation for Kconfig file in the hisilicon folder. Signed-off-by: Yunsheng Lin --- drivers/net/ethernet/hisilicon/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/Kconfig b/drivers/net/ethernet/hisilicon/K

[PATCH net-next 4/7] net: hns3: Consistently using GENMASK in hns3 driver

2017-10-08 Thread Yunsheng Lin
This patch uses GENMASK to generate bit mask whenever possible in hns3 driver. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 48 +++--- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.h| 4 +- 2 files changed, 26 insertions(+), 26 deletio

Re: [PATCH 1/3] mmc: dw_mmc: cancel the CTO timer after a voltage switch

2017-10-08 Thread Shawn Lin
On 2017/9/28 4:56, Douglas Anderson wrote: When running with the commit 03de19212ea3 ("mmc: dw_mmc: introduce timer for broken command transfer over scheme") I found this message in the log: Unexpected command timeout, state 7 It turns out that we weren't properly cancelling the new CTO time

Re: [ANNOUNCE] fsperf: a simple fs/block performance testing framework

2017-10-08 Thread Eryu Guan
On Mon, Oct 09, 2017 at 04:17:31PM +1100, Dave Chinner wrote: > On Sun, Oct 08, 2017 at 10:25:10PM -0400, Josef Bacik wrote: > > On Mon, Oct 09, 2017 at 11:51:37AM +1100, Dave Chinner wrote: > > > On Fri, Oct 06, 2017 at 05:09:57PM -0400, Josef Bacik wrote: > > > > Hello, > > > > > > > > One thing

Re: [PATCH v2 0/5] Switch arm64 over to qrwlock

2017-10-08 Thread Peter Zijlstra
On Mon, Oct 09, 2017 at 12:30:52AM +0300, Yury Norov wrote: > The bottomline of discussion [1] was that queued locks are more > effective when SoC has many CPUs. And 4 is not many. qspinlock, yes. qrwlock not, as it fully depends on arch_spinlock_t for the queueing. qrwlock is just a generic rwloc

Re: [PATCH] drm/rockchip: Fix memory leak in rockchip_drm_sys_resume()

2017-10-08 Thread jeffy
Hi Sean, On 09/28/2017 11:16 AM, jeffy wrote: Hi Sean, On 09/28/2017 04:27 AM, Sean Paul wrote: >@@ -299,6 +300,7 @@ static int rockchip_drm_sys_resume(struct device *dev) > > priv = drm->dev_private; > drm_atomic_helper_resume(drm, priv->state); >+drm_atomic_state_put(priv->stat

Re: [RFC PATCH] mm: shm: round up tmpfs size to huge page size when huge=always

2017-10-08 Thread Michal Hocko
On Sun 08-10-17 15:56:51, Kirill A. Shutemov wrote: > On Sat, Oct 07, 2017 at 04:22:10AM +0800, Yang Shi wrote: > > When passing "huge=always" option for mounting tmpfs, THP is supposed to > > be allocated all the time when it can fit, but when the available space is > > smaller than the size of TH

[PATCH v2] drm/atomic: Unref duplicated drm_atomic_state in drm_atomic_helper_resume()

2017-10-08 Thread Jeffy Chen
Kmemleak reported memory leak after suspend and resume: unreferenced object 0xffc0e31d8880 (size 128): comm "bash", pid 181, jiffies 4294763583 (age 24.694s) hex dump (first 32 bytes): 01 00 00 00 00 00 00 00 00 20 a2 eb c0 ff ff ff . .. 01 00 00 00 00 00 00 00 80 87 1d

[PATCH] powerpc/powernv: Add kernel cmdline parameter to disable imc

2017-10-08 Thread Anju T Sudhakar
Add a kernel command line parameter option to disable In-Memory Collection (IMC) counters and add documentation. This helps in debug. Signed-off-by: Anju T Sudhakar Reviewed-By: Madhavan Srinivasan --- Documentation/admin-guide/kernel-parameters.txt | 7 + arch/powerpc/platforms/powernv/o

Re: [PATCH] net/core: Fix BUG to BUG_ON conditionals.

2017-10-08 Thread kbuild test robot
Hi Tim, [auto build test ERROR on net-next/master] [also build test ERROR on v4.14-rc4 next-20170929] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Tim-Hansen/net-core-Fix-BUG-to-BUG_ON-conditi

Re: [PATCH v2] kconfig: Remove menu_end_entry()

2017-10-08 Thread kbuild test robot
Hi Ulf, [auto build test ERROR on linus/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ulf-Magnusson/kconfig-Remove-menu_end_entry/20171009-140245 config: x86_64-randconfig-x018-201741 c

Re: [alsa-devel] [PATCH] sound/pci/riptide or drivers/base/firmware: Fix a possible sleep-in-atomic bug

2017-10-08 Thread Takashi Iwai
On Mon, 09 Oct 2017 04:13:16 +0200, Jia-Ju Bai wrote: > > The riptide driver may sleep under a spinlock, and the function call path is: > snd_riptide_prepare (acquire the spinlock) > setsampleformat > sendcmd > riptide_reset > try_to_load_firmware > request_firmware >

Re: [RFC] workqueue: Fix irq inversion deadlock in manage_workers()

2017-10-08 Thread Peter Zijlstra
On Sun, Oct 08, 2017 at 12:03:47PM -0700, Tejun Heo wrote: > So, if I'm not mistaken, this is a regression caused by b9c16a0e1f73 > ("locking/mutex: Fix lockdep_assert_held() fail") which seems to > replace irqsave operations inside mutex to unconditional irq ones. No, it existed before that. You'

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-08 Thread Julia Lawall
> > I put kbuild in CC. I don't know what is the criterion for including > > semantic patches. > > We may have 3 options: > > 1) push this patch to upstream, so that all users can run the check > (with obvious cost) I tried on my laptop with only one core and no indexing. In this case, Coccine

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-08 Thread Michal Hocko
On Mon 09-10-17 08:33:16, Michal Hocko wrote: > On Sat 07-10-17 00:37:55, Yang Shi wrote: > > > > > > On 10/6/17 2:37 AM, Michal Hocko wrote: > > > On Thu 05-10-17 05:29:10, Yang Shi wrote: > [...] > > > > + list_for_each_entry_safe(s, s2, &slab_caches, list) { > > > > + if (!

Re: [PATCH v3] mm, sysctl: make NUMA stats configurable

2017-10-08 Thread kemi
On 2017年10月03日 17:23, Michal Hocko wrote: > On Thu 28-09-17 14:11:41, Kemi Wang wrote: >> This is the second step which introduces a tunable interface that allow >> numa stats configurable for optimizing zone_statistics(), as suggested by >> Dave Hansen and Ying Huang. >> >> =

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-08 Thread Michal Hocko
On Sat 07-10-17 00:37:55, Yang Shi wrote: > > > On 10/6/17 2:37 AM, Michal Hocko wrote: > > On Thu 05-10-17 05:29:10, Yang Shi wrote: [...] > > > + list_for_each_entry_safe(s, s2, &slab_caches, list) { > > > + if (!is_root_cache(s) || (s->flags & SLAB_RECLAIM_ACCOUNT)) > > > +

Re: [alsa-devel] [PATCH] opl3: Fix a possible sleep-in-atomic bug in snd_opl3_find_patch

2017-10-08 Thread Clemens Ladisch
Jia-Ju Bai wrote: > The driver may sleep under a spinlock, and the function call path is: > snd_opl3_note_on (acquire the spinlock) > snd_opl3_find_patch > kzalloc(GFP_KERNEL) --> may sleep This call path is not possible because create_patch is not set. Regards, Clemens

[PATCH] KVM: remove printing of vcpu address

2017-10-08 Thread Tobin C. Harding
Code currently prints the address of the kvm_vcpu structure in an error message. It is not immediately clear what value this address adds to the error string, we can use the vcpu ID instead. Printing unnecessary kernel addresses to dmesg poses a security risk. Remove the address from error message

[PATCH] KVM: remove printing of token address

2017-10-08 Thread Tobin C. Harding
KVM currently prints the address of the consumer token. It is not immediately clear what benefit it is to see this address. Printing this address leaks kernel pointers into dmesg and is a security risk. Remove the consumer token address from error message output. Signed-off-by: Tobin C. Harding

Re: [PATCH] fs, mm: account filp and names caches to kmemcg

2017-10-08 Thread Michal Hocko
On Fri 06-10-17 12:33:03, Shakeel Butt wrote: > >> names_cachep = kmem_cache_create("names_cache", PATH_MAX, 0, > >> - SLAB_HWCACHE_ALIGN|SLAB_PANIC, NULL); > >> + SLAB_HWCACHE_ALIGN|SLAB_PANIC|SLAB_ACCOUNT, NULL); > > > > I might be wrong but isn't nam

Re: [PATCH 1/2] lib/test: Delete five error messages for a failed memory allocation

2017-10-08 Thread Michal Hocko
On Sat 07-10-17 19:48:37, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 7 Oct 2017 17:34:23 +0200 > > Omit extra messages for a memory allocation failure in these functions. > > This issue was detected by using the Coccinelle software. Yes this makes sense. None of those really e

Re: [PATCH v3 1/1] mtd: nand: pxa3xx: Set FORCE_CSX bit to ARMADA370 variants.

2017-10-08 Thread Miquel RAYNAL
Hello Kalyan, On Mon, 9 Oct 2017 02:31:30 + Kalyan Kinthada wrote: > On 05/10/17 20:41, Miquel RAYNAL wrote: > > Hello Kalyan, > > > > On Thu, 28 Sep 2017 13:57:56 +1300 > > Kalyan Kinthada wrote: > > > >> When the arbitration between NOR and NAND flash is enabled > >> the field bit[21]

Re: [PATCH 10/12] net/mlx4: replace with

2017-10-08 Thread Leon Romanovsky
On Mon, Oct 09, 2017 at 02:56:56PM +0900, Masahiro Yamada wrote: > 2017-10-09 3:55 GMT+09:00 Leon Romanovsky : > > On Mon, Oct 09, 2017 at 02:29:15AM +0900, Masahiro Yamada wrote: > >> 2017-10-09 2:00 GMT+09:00 David Miller : > >> > From: Masahiro Yamada > >> > Date: Mon, 9 Oct 2017 01:10:11 +090

Re: [PATCH v2 1/1] mm: only dispaly online cpus of the numa node

2017-10-08 Thread Leizhen (ThunderTown)
On 2017/10/3 21:56, Michal Hocko wrote: > On Tue 03-10-17 14:47:26, Will Deacon wrote: >> On Mon, Oct 02, 2017 at 02:54:46PM -0700, Andrew Morton wrote: >>> On Mon, 2 Oct 2017 11:38:07 +0100 Will Deacon wrote: >>> > When I executed numactl -H(which read > /sys/devices/system/node/nodeX/

Re: [for-next][PATCH 15/16] ftrace: Add freeing algorithm to free ftrace_mod_maps

2017-10-08 Thread Joel Fernandes
Hi Steve, On Sun, Oct 8, 2017 at 11:42 AM, Steven Rostedt wrote: >> > "Joel Fernandes (Google)" wrote: >> > Also could you let me know what is the correct behavior of the filters >> > after a module being traced is unloaded, are the filters supposed to >> > be setup again after the module is unl

Re: [PATCH 00/12] radix-tree: split out struct radix_tree_root out to

2017-10-08 Thread Leon Romanovsky
On Mon, Oct 09, 2017 at 02:58:58PM +0900, Masahiro Yamada wrote: > 2017-10-09 3:52 GMT+09:00 Leon Romanovsky : > > On Mon, Oct 09, 2017 at 01:10:01AM +0900, Masahiro Yamada wrote: > > > > <...> > >> > >> By splitting out the radix_tree_root definition, > >> we can reduce the header file dependency.

Re: [for-next][PATCH 15/16] ftrace: Add freeing algorithm to free ftrace_mod_maps

2017-10-08 Thread Joel Fernandes
Hi Steve, On Sat, Oct 7, 2017 at 9:52 PM, Joel Fernandes (Google) wrote: [..] >>> >>> On Fri, Oct 6, 2017 at 11:07 AM, Steven Rostedt wrote: >>> > From: "Steven Rostedt (VMware)" >>> > >>> > The ftrace_mod_map is a descriptor to save module init function names in >>> > case they were traced, an

Re: [PATCH 00/12] radix-tree: split out struct radix_tree_root out to

2017-10-08 Thread Masahiro Yamada
2017-10-09 3:52 GMT+09:00 Leon Romanovsky : > On Mon, Oct 09, 2017 at 01:10:01AM +0900, Masahiro Yamada wrote: > > <...> >> >> By splitting out the radix_tree_root definition, >> we can reduce the header file dependency. >> >> Reducing the header dependency will help for speeding the kernel >> buil

Re: [PATCH 10/12] net/mlx4: replace with

2017-10-08 Thread Masahiro Yamada
2017-10-09 3:55 GMT+09:00 Leon Romanovsky : > On Mon, Oct 09, 2017 at 02:29:15AM +0900, Masahiro Yamada wrote: >> 2017-10-09 2:00 GMT+09:00 David Miller : >> > From: Masahiro Yamada >> > Date: Mon, 9 Oct 2017 01:10:11 +0900 >> > >> >> The headers >> >> - include/linux/mlx4/device.h >> >> - driv

Re: [PATCH 3/3] ARM: dts: gr-peach: Add ETHER pin group

2017-10-08 Thread Simon Horman
On Fri, Oct 06, 2017 at 02:25:23PM +0200, jacopo mondi wrote: > Hi Simon, > > On Thu, Oct 05, 2017 at 10:58:20AM +0200, Jacopo Mondi wrote: > > Add pin configuration subnode for ETHER pin group and enable the interface. > > > > Signed-off-by: Jacopo Mondi > > --- > > arch/arm/boot/dts/r7s72100-g

Re: [PATCH 10/12] net/mlx4: replace with

2017-10-08 Thread Masahiro Yamada
2017-10-09 2:32 GMT+09:00 Joe Perches : > On Mon, 2017-10-09 at 02:29 +0900, Masahiro Yamada wrote: >> The idea is simple; include necessary headers explicitly. > > Try that for kernel.h > > There's a reason aggregation of #includes is useful. > We should use a common sense for the balance betwee

Re: [PATCH V1] pinctrl: qcom: spmi-gpio: Update GPIO EN_CTL when setting pin config

2017-10-08 Thread Bjorn Andersson
On Sun 08 Oct 22:34 PDT 2017, Fenglin Wu wrote: > On 10/6/2017 12:27 AM, Bjorn Andersson wrote: > > On Mon 11 Sep 17:32 PDT 2017, fengl...@codeaurora.org wrote: > > > > > From: Fenglin Wu > > > > > > GPIO is expected to be disabled iff PIN_CONFIG_BIAS_HIGH_IMPEDANCE is > > > configured. Update

Re: [PATCH] dt-bindings: irqchip: renesas-irqc: Document R-Car M3-W, V3M, D3 support

2017-10-08 Thread Simon Horman
On Fri, Oct 06, 2017 at 01:51:32PM +0200, Geert Uytterhoeven wrote: > Document support for the Interrupt Controller for Externel Devices > (INTC-EX) in the Renesas M3-W (r8a7796), V3M (r8a77970), and D3 > (r8a77995) SoCs. > > No driver update is needed. > > Signed-off-by: Geert Uytterhoeven Ack

[PATCH 1/2] ARM: dts: dra7: Increase max-voltage of pbias regulator

2017-10-08 Thread Kishon Vijay Abraham I
From: Ravikumar Kattekola As per recent TRM, PBIAS cell on dra7 devices supports 3.3v and not 3.0v as documented earlier. Update PBIAS regulator max voltage to match this. Document reference: SPRUI30C – DRA75x, DRA74x Technical reference manual- November 2016 Tested on: DRA75x PG 2.0 REV H EVM

[PATCH 0/2] dra7/omap5: Increase max-voltage of pbias to 3.3v

2017-10-08 Thread Kishon Vijay Abraham I
Max voltage of pbias was set to 3.0v because of an error in TRM in omap5/dra7 SoCs. It's now corrected to be 3.3v. Corresponding change in pbias regulator driver is already merged in ulf -next commit 27eae9d4b9d4cd9c204ef81f46078d91362ed41c Author: Ravikumar Kattekola Date: Thu Aug 31 15:48:45

[PATCH 2/2] ARM: dts: omap5: Increase max-voltage of pbias regulator

2017-10-08 Thread Kishon Vijay Abraham I
From: Ravikumar Kattekola As per recent TRM, PBIAS cell on omap5 devices supports 3.3v and not 3.0v as documented earlier. Update PBIAS regulator max voltage to match this. Document reference: SWPU249AF - OMAP543x Technical reference manual August 2016 Signed-off-by: Ravikumar Kattekola Signe

Re: [PATCH 13/14] netfilter/ipvs: Use %pS printk format for direct addresses

2017-10-08 Thread Simon Horman
On Wed, Sep 06, 2017 at 10:28:00PM +0200, Helge Deller wrote: > The debug and error printk functions in ipvs uses wrongly the %pF instead of > the %pS printk format specifier for printing symbols for the address returned > by _builtin_return_address(0). Fix it for the ia64, ppc64 and parisc64 > arc

Re: [PATCH v3 3/5] media: atmel-isc: Enable the clocks during probe

2017-10-08 Thread Yang, Wenyou
Hi Sakari, Sorry for late answer, because I was in vacation last week. On 2017/9/29 5:25, Sakari Ailus wrote: Hi Wenyou, On Thu, Sep 28, 2017 at 04:18:26PM +0800, Wenyou Yang wrote: To meet the relationship, enable the HCLOCK and ispck during the device probe, "isc_pck frequency is less than

[PATCH] page_alloc.c: inline __rmqueue()

2017-10-08 Thread Aaron Lu
__rmqueue() is called by rmqueue_bulk() and rmqueue() under zone->lock and that lock can be heavily contended with memory intensive applications. Since __rmqueue() is a small function, inline it can save us some time. With the will-it-scale/page_fault1/process benchmark, when using nr_cpu processe

Re: [PATCH 1/2] arm: dts: Add support for National Instruments Project Sulfur SDRs

2017-10-08 Thread Michal Simek
On 6.10.2017 18:18, Moritz Fischer wrote: > On Fri, Oct 06, 2017 at 01:49:44PM +0200, Michal Simek wrote: >> On 26.9.2017 20:15, Philip Balister wrote: >>> On 09/26/2017 02:06 PM, Michal Simek wrote: On 26.9.2017 19:58, Philip Balister wrote: > On 09/26/2017 01:50 PM, Moritz Fischer wrote:

Re: [BUG] vt6655: A possible sleep-in-atomic bug in vt6655_suspend

2017-10-08 Thread Greg KH
On Mon, Oct 09, 2017 at 09:10:28AM +0800, Jia-Ju Bai wrote: > According to device_main.c, the driver may sleep under a spinlock, > and the function call path is: > vt6655_suspend (acquire the spinlock) > pci_set_power_state > __pci_start_power_transition (drivers/pci/pci.c) > msleep -->

Re: [PATCH V1] pinctrl: qcom: spmi-gpio: Update GPIO EN_CTL when setting pin config

2017-10-08 Thread Fenglin Wu
On 10/6/2017 12:27 AM, Bjorn Andersson wrote: On Mon 11 Sep 17:32 PDT 2017, fengl...@codeaurora.org wrote: From: Fenglin Wu GPIO is expected to be disabled iff PIN_CONFIG_BIAS_HIGH_IMPEDANCE is configured. Update is_enabled flag in config_set() so that it can reflect GPIO status correctly. Al

Re: [ANNOUNCE] fsperf: a simple fs/block performance testing framework

2017-10-08 Thread Dave Chinner
On Sun, Oct 08, 2017 at 10:25:10PM -0400, Josef Bacik wrote: > On Mon, Oct 09, 2017 at 11:51:37AM +1100, Dave Chinner wrote: > > On Fri, Oct 06, 2017 at 05:09:57PM -0400, Josef Bacik wrote: > > > Hello, > > > > > > One thing that comes up a lot every LSF is the fact that we have no > > > general

RE: [RFC v5 7/8] platform/x86: intel_pmc_ipc: Use generic Intel IPC device calls

2017-10-08 Thread Chakravarty, Souvik K
> From: sathyanarayanan.kuppusw...@linux.intel.com > [mailto:sathyanarayanan.kuppusw...@linux.intel.com] > Sent: Sunday, October 8, 2017 3:50 AM > To: a.zu...@towertech.it; x...@kernel.org; w...@iguana.be; > mi...@redhat.com; alexandre.bell...@free-electrons.com; Zha, Qipeng > ; h...@zytor.com; dvh

RE: [RFC v5 6/8] platform/x86: intel_punit_ipc: Use generic intel ipc device calls

2017-10-08 Thread Chakravarty, Souvik K
> From: sathyanarayanan.kuppusw...@linux.intel.com > [mailto:sathyanarayanan.kuppusw...@linux.intel.com] > Sent: Sunday, October 8, 2017 3:50 AM > To: a.zu...@towertech.it; x...@kernel.org; w...@iguana.be; > mi...@redhat.com; alexandre.bell...@free-electrons.com; Zha, Qipeng > ; h...@zytor.com; dvh

Re: [BUG] mm/vmalloc: ___might_sleep is called under a spinlock in __purge_vmap_area_lazy

2017-10-08 Thread Jia-Ju Bai
Thanks for your reply and explanation :) I will improve my analysis. Thanks, Jia-Ju Bai On 2017/10/9 12:10, Kirill A. Shutemov wrote: On Mon, Oct 09, 2017 at 12:00:33PM +0800, Jia-Ju Bai wrote: The ___might_sleep is called under a spinlock, and the function call graph is: __purge_vmap_area_laz

Re: linux-4.14-rc3/arch/powerpc/perf/imc-pmu.c:599: pointless test ?

2017-10-08 Thread Michael Ellerman
David Binderman writes: > Hello there, > > linux-4.14-rc3/arch/powerpc/perf/imc-pmu.c:599]: (style) Unsigned variable > 'ncpu' can't be negative so it is unnecessary to test it. > > Source code is > > if (ncpu >= 0 && ncpu < nr_cpu_ids) { > > but > > unsigned int ncpu, core_id; > > Sugges

RE: [RFC v5 4/8] platform: x86: Add generic Intel IPC driver

2017-10-08 Thread Chakravarty, Souvik K
> From: sathyanarayanan.kuppusw...@linux.intel.com > [mailto:sathyanarayanan.kuppusw...@linux.intel.com] > Sent: Sunday, October 8, 2017 3:50 AM > To: a.zu...@towertech.it; x...@kernel.org; w...@iguana.be; > mi...@redhat.com; alexandre.bell...@free-electrons.com; Zha, Qipeng > ; h...@zytor.com; dvh

[PATCH] x86/mm/64: Fix reboot interaction with CR4.PCIDE

2017-10-08 Thread Andy Lutomirski
Trying to reboot via real mode fails with PCID on: long mode cannot be exited while CR4.PCIDE is set. (No, I have no idea why, but the SDM and actual CPUs are in agreement here.) The result is a GPF and a hang instead of a reboot. I didn't catch this in testing because neither my computer nor my

Re: Linux 4.14-rc4

2017-10-08 Thread Joe Perches
On Sun, 2017-10-08 at 21:18 -0700, Linus Torvalds wrote: > Another week, another -rc. Any idea if you want to break up MAINTAINERS?

Re: netlink backwards compatibility in userspace tools

2017-10-08 Thread David Miller
From: "Jason A. Donenfeld" Date: Fri, 29 Sep 2017 12:22:42 +0200 > One handy aspect of Netlink is that it's backwards compatible. This > means that you can run old userspace utilities on new kernels, even if > the new kernel supports new features and netlink attributes. The wire > format is stabl

Re: [PATCH v3 3/5] sparc64: SPARC optimised fls function

2017-10-08 Thread David Miller
From: Vijay Kumar Date: Fri, 6 Oct 2017 10:54:51 -0600 > +#define LXCNT_O0_G2 \ > + .word 0x85b002e8 > + > + .text > + .register %g2, #scratch > + .register %g3, #scratch > + > +ENTRY(NG4fls) > + LXCNT_O0_G2 !lzcnt %o0, %g2 Agreed with others that you sho

Re: [PATCH V5 4/7] blk-mq: introduce blk_mq_dequeue_from_ctx()

2017-10-08 Thread Ming Lei
On Tue, Oct 03, 2017 at 02:01:09AM -0700, Christoph Hellwig wrote: > On Sat, Sep 30, 2017 at 06:27:17PM +0800, Ming Lei wrote: > > This function is introduced for dequeuing request > > from sw queue so that we can dispatch it in > > scheduler's way. > > > > More importantly, some SCSI devices may

Re: [PATCH V5 8/8] blk-mq: improve bio merge from blk-mq sw queue

2017-10-08 Thread Ming Lei
On Tue, Oct 03, 2017 at 02:21:43AM -0700, Christoph Hellwig wrote: > This looks generally good to me, but I really worry about the impact > on very high iops devices. Did you try this e.g. for random reads > from unallocated blocks on an enterprise NVMe SSD? Looks no such impact, please see the f

Re: [PATCH] qed: Delete redundant check on dcb_app priority

2017-10-08 Thread David Miller
From: Christos Gkekas Date: Sun, 8 Oct 2017 23:46:47 +0100 > dcb_app priority is unsigned thus checking whether it is less than zero > is redundant. > > Signed-off-by: Christos Gkekas Applied to net-next.

Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

2017-10-08 Thread David Miller
From: Tim Hansen Date: Sun, 8 Oct 2017 16:03:38 -0400 > Mistakenly sent the patch previously with a missing semicolon. > Apologies. > > Fix BUG() calls to use BUG_ON(conditional) macros. > > This was found using make coccicheck M=net/core on linux next > tag next-20170929 > > Signed-off-by: Ti

Re: [PATCH] net: ethernet: stmmac: Clean up dead code

2017-10-08 Thread David Miller
From: Christos Gkekas Date: Sun, 8 Oct 2017 20:13:49 +0100 > Many macros in dwmac-ipq806x are unused and should be removed. > Moreover gmac->id is an unsigned variable and therefore checking > whether it is less than zero is redundant. > > Signed-off-by: Christos Gkekas Applied.

Linux 4.14-rc4

2017-10-08 Thread Linus Torvalds
Another week, another -rc. This release does seem to continue to be more active in the rc's than usual, but it actually feels like it's calming down. So rc4 is larger than an rc4 release usually is (about 400 non-merge commits, when usually at this stage we should be at ~300), but at the same time

Re: [BUG] mm/vmalloc: ___might_sleep is called under a spinlock in __purge_vmap_area_lazy

2017-10-08 Thread Kirill A. Shutemov
On Mon, Oct 09, 2017 at 12:00:33PM +0800, Jia-Ju Bai wrote: > The ___might_sleep is called under a spinlock, and the function call graph > is: > __purge_vmap_area_lazy (acquire the spinlock) > cond_resched_lock > ___might_sleep > > In this situation, ___might_sleep may prints error log messa

Re: [RFC PATCH] mm: shm: round up tmpfs size to huge page size when huge=always

2017-10-08 Thread Kirill A. Shutemov
On Mon, Oct 09, 2017 at 03:51:06AM +0800, Yang Shi wrote: > > > On 10/8/17 5:56 AM, Kirill A. Shutemov wrote: > > On Sat, Oct 07, 2017 at 04:22:10AM +0800, Yang Shi wrote: > > > When passing "huge=always" option for mounting tmpfs, THP is supposed to > > > be allocated all the time when it can fi

[BUG] mm/vmalloc: ___might_sleep is called under a spinlock in __purge_vmap_area_lazy

2017-10-08 Thread Jia-Ju Bai
The ___might_sleep is called under a spinlock, and the function call graph is: __purge_vmap_area_lazy (acquire the spinlock) cond_resched_lock ___might_sleep In this situation, ___might_sleep may prints error log message because a spinlock is held. A possible fix is to remove ___might_sl

[PATCH] timers: avoid an unnecessory iteration in __run_timers()

2017-10-08 Thread Zhenzhong Duan
When we know next expired timer is later than current jiffies, we don't need to call collect_expired_timers() again checking empty hlists. Signed-off-by: Zhenzhong Duan --- kernel/time/timer.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/kernel/time/timer.c b/kernel

[PATCH v2] kbuild: comments cleanup in Makefile.lib

2017-10-08 Thread Cao jin
It has: 1. Move comments close to what it want to comment. 2. Comments cleanup & improvement. Signed-off-by: Cao jin --- scripts/Makefile.lib | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 5e975fe..580e

Re: [ANNOUNCE] fsperf: a simple fs/block performance testing framework

2017-10-08 Thread Theodore Ts'o
On Sun, Oct 08, 2017 at 10:25:10PM -0400, Josef Bacik wrote: > > Probably should have led with that shouldn't I have? There's nothing keeping > me > from doing it, but I didn't want to try and shoehorn in a python thing into > fstests. I need python to do the sqlite and the json parsing to dump

Re: [PATCH] kbuild: comments cleanup in Makefile.lib

2017-10-08 Thread Cao jin
Masahiro-san, On 10/04/2017 12:58 PM, Masahiro Yamada wrote: > Hi Cao, > > > 2017-09-19 20:36 GMT+09:00 Cao jin : >> It has: >> 1. Move comments close to what it want to comment. >> 2. Comments cleanup & improvement. >> >> Signed-off-by: Cao jin >> >> -# if $(foo-objs) exists, foo.o is a comp

[RESEND PATCH] media: uvcvideo: Fix memory leak of uvc resources

2017-10-08 Thread Jeffy Chen
The refcount would be inited to 1 in kref_init(), so we don't need to increase it at the end of uvc_register_video(). Fixes: 9d15cd958c17 ("media: uvcvideo: Convert from using an atomic variable to a reference count") Signed-off-by: Jeffy Chen --- drivers/media/usb/uvc/uvc_driver.c | 1 - 1 fi

[PATCH] media: uvcvideo: Fix memory leak of uvc resources

2017-10-08 Thread Jeffy Chen
The refcount would be inited to 1 in kref_init(), so we don't need to increase it at the end of uvc_probe(). Fixes: 9d15cd958c17 ("media: uvcvideo: Convert from using an atomic variable to a reference count") Signed-off-by: Jeffy Chen --- drivers/media/usb/uvc/uvc_driver.c | 1 - 1 file change

Re: [PATCH v3 12/33] tracing: Add variable support to hist triggers

2017-10-08 Thread Namhyung Kim
Hi Tom, On Fri, Sep 22, 2017 at 02:59:52PM -0500, Tom Zanussi wrote: > Add support for saving the value of a current event's event field by > assigning it to a variable that can be read by a subsequent event. > > The basic syntax for saving a variable is to simply prefix a unique > variable name

Re: [PATCH 12/12] dt-bindings: usb: mtu3: remove optional pinctrls

2017-10-08 Thread Chunfeng Yun
On Thu, 2017-10-05 at 17:33 -0500, Rob Herring wrote: > On Thu, Sep 28, 2017 at 08:17:20AM +0800, Chunfeng Yun wrote: > > Remove optional pinctrls due to using FORCE/RG_IDDIG to implement > > manual switch function. > > Another not backwards compatible change. Please explain why that is > okay. T

Re: [RFC] workqueue: Fix irq inversion deadlock in manage_workers()

2017-10-08 Thread Boqun Feng
On Sun, Oct 08, 2017 at 07:03:47PM +, Tejun Heo wrote: > Hello, Boqun. > Hi Tejun, > On Sun, Oct 08, 2017 at 05:02:23PM +0800, Boqun Feng wrote: > > Josef reported a HARDIRQ-safe -> HARDIRQ-unsafe lock order detected by > > lockdep: > > > > | [ 1270.472259] WARNING: HARDIRQ-safe -> HARDIRQ-

RE: [PATCH v6 3/3] eeprom: at24: enable runtime pm support

2017-10-08 Thread Mohandass, Divagar
Hi Tomasz, >-Original Message- >From: sakari.ai...@iki.fi [mailto:sakari.ai...@iki.fi] >Sent: Tuesday, October 03, 2017 7:21 PM >To: Tomasz Figa >Cc: Mani, Rajmohan ; Mohandass, Divagar >; robh...@kernel.org; >mark.rutl...@arm.com; w...@the-dreams.de; devicet...@vger.kernel.org; >linux-..

[PATCH] fs/cachefiles: Fix a possible sleep-in-atomic bug in cachefiles_printk_object

2017-10-08 Thread Jia-Ju Bai
The kernel may sleep under a write spinlock, and the function call path is: cachefiles_mark_object_active (acquire the spinlock) cachefiles_printk_object kmalloc(GFP_NOIO) --> may sleep To fix it, GFP_NOIO is replaced with GFP_ATOMIC. This bug is found by my static analysis tool and my code

[PATCH] lib/vsprintf: add default case to 'i' specifier

2017-10-08 Thread Tobin C. Harding
%pi leaks kernel addresses if incorrectly specified. Currently the printk specifier %pi (%pI) contains a switch statement without a default clause. The %pi specifier requires a subsequent character (4, 6, or S) controlling the output. If the specifier is incomplete the switch statement will fall t

Re: [PATCH v7 3/6] coresight: of: Use of_cpu_node_to_id helper

2017-10-08 Thread Leo Yan
Hi Suzuki, On Fri, Oct 06, 2017 at 11:36:07AM +0100, Suzuki K Poulose wrote: > Reuse the new generic helper, of_cpu_node_to_id() to map a > given CPU phandle to a logical CPU number. > > Cc: Leo Yan > Acked-by: Mathieu Poirier > Signed-off-by: Suzuki K Poulose Tested-by: Leo Yan BTW, I thin

[PATCH] xen/vcpu: Use a unified name about cpu hotplug state for pv and pvhvm

2017-10-08 Thread Zhenzhong Duan
As xen_cpuhp_setup is called by PV and PVHVM, the name of "x86/xen/hvm_guest" is confusing. Signed-off-by: Zhenzhong Duan --- arch/x86/xen/enlighten.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index 0e7ef69..d6

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-08 Thread Fengguang Wu
On Thu, Oct 05, 2017 at 09:40:51PM +0200, Julia Lawall wrote: On Thu, 5 Oct 2017, Liam Breck wrote: Hi Julia, On Thu, Oct 5, 2017 at 12:25 PM, Julia Lawall wrote: > > > On Thu, 5 Oct 2017, Liam Breck wrote: > >> Hi, sorry for slow reply... >> >> Can we patch something to make this script ru

Re: [PATCH 10/12] dt-bindings: usb: mtu3: add a optional property to disable u3ports

2017-10-08 Thread Chunfeng Yun
On Thu, 2017-10-05 at 17:31 -0500, Rob Herring wrote: > On Thu, Sep 28, 2017 at 08:17:18AM +0800, Chunfeng Yun wrote: > > Add a new optional property to disable u3ports > > > > Signed-off-by: Chunfeng Yun > > --- > > .../devicetree/bindings/usb/mediatek,mtu3.txt |2 ++ > > 1 file change

[BUG] sound/core/seq: A possible sleep-in-atomic bug in snd_virmidi_dev_receive_event

2017-10-08 Thread Jia-Ju Bai
According to seq_virmidi.c, the driver may sleep under a read spinlock. The function call path is: snd_virmidi_dev_receive_event (acquire the spinlock) snd_seq_dump_var_event copy_from_user --> may sleep This bug is found by my static analysis tool and my code review. Thanks, Jia-Ju Bai

Re: [PATCH 9/9] arm64: dts: register Hi3660's thermal sensor

2017-10-08 Thread Wangtao (Kevin, Kirin)
on 2017/10/3 3:06, Daniel Lezcano wrote: On 22/09/2017 11:42, Tao Wang wrote: From: Kevin Wangtao add binding for tsensor on H3660, this tsensor is used for SoC thermal control, it supports alarm interrupt. Signed-off-by: Kevin Wangtao I'm not able to apply this patch. Does it rely on an

[PATCH] opl3: Fix a possible sleep-in-atomic bug in snd_opl3_find_patch

2017-10-08 Thread Jia-Ju Bai
The driver may sleep under a spinlock, and the function call path is: snd_opl3_note_on (acquire the spinlock) snd_opl3_find_patch kzalloc(GFP_KERNEL) --> may sleep To fix it, GFP_KERNEL is replaced with GFP_ATOMIC. This bug is found by my static analysis tool and my code review. Signed-off-

Re: [PATCH v3 1/1] mtd: nand: pxa3xx: Set FORCE_CSX bit to ARMADA370 variants.

2017-10-08 Thread Kalyan Kinthada
On 05/10/17 20:41, Miquel RAYNAL wrote: > Hello Kalyan, > > On Thu, 28 Sep 2017 13:57:56 +1300 > Kalyan Kinthada wrote: > >> When the arbitration between NOR and NAND flash is enabled >> the field bit[21] in the Data Flash Control Register >> needs to be set to 1 according to guidleine GL-5830741

Re: [ANNOUNCE] fsperf: a simple fs/block performance testing framework

2017-10-08 Thread Josef Bacik
On Mon, Oct 09, 2017 at 11:51:37AM +1100, Dave Chinner wrote: > On Fri, Oct 06, 2017 at 05:09:57PM -0400, Josef Bacik wrote: > > Hello, > > > > One thing that comes up a lot every LSF is the fact that we have no general > > way > > that we do performance testing. Every fs developer has a set of

Re: [PATCH v3] mm, sysctl: make NUMA stats configurable

2017-10-08 Thread kemi
On 2017年09月29日 15:03, Vlastimil Babka wrote: > On 09/28/2017 08:11 AM, Kemi Wang wrote: >> This is the second step which introduces a tunable interface that allow >> numa stats configurable for optimizing zone_statistics(), as suggested by >> Dave Hansen and Ying Huang. >> >>

Re: [PATCH 01/12] mmc: dt-bindings: update Mediatek MMC bindings

2017-10-08 Thread Chaotian Jing
On Mon, 2017-10-02 at 08:53 +0200, Ulf Hansson wrote: > [...] > > >> > >> > Required properties: > >> > >> > -- compatible: Should be "mediatek,mt8173-mmc","mediatek,mt8135-mmc" > >> > >> > +- compatible: value should be either of the following. > >> > >> > + "mediatek,mt8135-mmc": for mmc host

Re: [PATCH 8/9] dt-bindings: usb: mtk-xhci: add a optional property to disable u3ports

2017-10-08 Thread Chunfeng Yun
On Thu, 2017-10-05 at 17:16 -0500, Rob Herring wrote: > On Wed, Sep 27, 2017 at 05:23:04PM +0800, Chunfeng Yun wrote: > > Add a new optional property to disable u3ports > > > > Signed-off-by: Chunfeng Yun > > --- > > .../devicetree/bindings/usb/mediatek,mtk-xhci.txt |2 ++ > > 1 file change

[PATCH] sound/pci/riptide or drivers/base/firmware: Fix a possible sleep-in-atomic bug

2017-10-08 Thread Jia-Ju Bai
The riptide driver may sleep under a spinlock, and the function call path is: snd_riptide_prepare (acquire the spinlock) setsampleformat sendcmd riptide_reset try_to_load_firmware request_firmware _request_firmware (drivers/base/firmware_class.c)

GOOD DAY

2017-10-08 Thread Unistar Credit And Finance Corporation
CONTACT US TODAY FOR BUSINESS OR PERSONAL LOAN.

Re: [PATCH] ceph: Fix bool initialization/comparison

2017-10-08 Thread Yan, Zheng
> On 7 Oct 2017, at 22:02, Thomas Meyer wrote: > > Bool initializations should use true and false. Bool tests don't need > comparisons. > > Signed-off-by: Thomas Meyer > --- > > diff -u -p a/fs/ceph/caps.c b/fs/ceph/caps.c > --- a/fs/ceph/caps.c > +++ b/fs/ceph/caps.c > @@ -1711,7 +1711,7 @@

Re: [f2fs-dev] [PATCH] f2fs: Fix bool initialization/comparison

2017-10-08 Thread Chao Yu
On 2017/10/8 3:30, Joe Perches wrote: > On Sat, 2017-10-07 at 23:33 +0900, Ju Hyung Park wrote: >> Isn't this bogus? >> >> "bool" type in Linux kernel is a typedef to "_Bool" >> and true/false is defined as 1 and 0 by enum at include/linux/stddef.h. > > Bogus? Well, not really. It's just a neate

Re: [PATCH v1 1/4] perf annotate: create a new hists to manage multiple events samples

2017-10-08 Thread Jin, Yao
On 10/7/2017 2:54 AM, Arnaldo Carvalho de Melo wrote: > Em Sat, Oct 07, 2017 at 12:31:37AM +0800, Jin, Yao escreveu: >> On 10/5/2017 9:21 PM, Arnaldo Carvalho de Melo wrote: >>> Em Wed, Aug 16, 2017 at 06:18:33PM +0800, Jin Yao escreveu: An issue is found during using perf annotate. >

RE: [PATCH] qed: Delete redundant check on dcb_app priority

2017-10-08 Thread Tayar, Tomer
> dcb_app priority is unsigned thus checking whether it is less than zero > is redundant. > > Signed-off-by: Christos Gkekas Thanks Acked-By: Tomer Tayar

Re: [PATCH v2 1/2] uio: dt-bindings: document binding for uio-pdrv-genirq

2017-10-08 Thread Rob Herring
On Sun, Oct 8, 2017 at 4:03 PM, Chris Packham wrote: > Hi Rob, Greg, > > On 04/10/17 10:38, Rob Herring wrote: >> On Fri, Sep 22, 2017 at 03:48:13AM +1200, Chris Packham wrote: >>> Document the device tree bindings for the uio-prv-genirq driver. Provide >>> some examples on how it can be used. >>>

[BUG] ssb: Possible sleep-in-atomic bugs in ssb_pcmcia_read8

2017-10-08 Thread Jia-Ju Bai
According to pcmcia.c, the driver may sleep under a spinlock. The function call paths are: ssb_pcmcia_read8 (acquire the spinlock) select_core_and_segment ssb_pcmcia_switch_segment ssb_pcmcia_cfg_write pcmcia_write_config_byte pcmcia_access_config (drivers/pcmcia/pcmc

Re: [PATCH v2 4/4] mm:swap: skip swapcache for swapin of synchronous device

2017-10-08 Thread huang ying
On Fri, Sep 29, 2017 at 4:51 PM, huang ying wrote: > On Wed, Sep 20, 2017 at 1:43 PM, Minchan Kim wrote: [snip] >> diff --git a/mm/memory.c b/mm/memory.c >> index ec4e15494901..163ab2062385 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -2842,7 +2842,7 @@ EXPORT_SYMBOL(unmap_mapping_ran

Re: [PATCH] Added default implementation for of_find_all_nodes(). This function is used by board.c from the board module (drivers/staging/board).

2017-10-08 Thread Rob Herring
On Sun, Oct 8, 2017 at 11:28 AM, Artur Lorincz wrote: > Signed-off-by: Artur Lorincz > --- > include/linux/of.h | 5 + > 1 file changed, 5 insertions(+) I replied to you on the previous version[1]. Why are you sending this again? Rob [1] https://lkml.org/lkml/2017/10/6/805

  1   2   3   4   >