Re: ipv6 redefinition build issue with 4.15-rc8

Hi Neil, On 01/16/2018 07:51 PM, Neil MacLeod wrote: Since this commit in 4.15-rc8: https://github.com/torvalds/linux/commit/6926e041a8920c8ec27e4e155efa760aa01551fd building connman 1.35 with glibc 2.26 now fails as follows: http://ix.io/EbP I'm not sure if this is a kernel issue, a glibc

Re: ipv6 redefinition build issue with 4.15-rc8

Hi Neil, On 01/16/2018 07:51 PM, Neil MacLeod wrote: Since this commit in 4.15-rc8: https://github.com/torvalds/linux/commit/6926e041a8920c8ec27e4e155efa760aa01551fd building connman 1.35 with glibc 2.26 now fails as follows: http://ix.io/EbP I'm not sure if this is a kernel issue, a glibc

linux-next: Tree for Jan 17

Hi all, Changes since 20180116: The arm64 tree gained conflicts against Linus' tree. The net-next tree gained conflicts against the net tree. The rdma tree gained a conflict against the rdma-fixes tree. The block tree gained a conflict against the dma-mapping tree. The kvm tree gained

linux-next: Tree for Jan 17

Hi all, Changes since 20180116: The arm64 tree gained conflicts against Linus' tree. The net-next tree gained conflicts against the net tree. The rdma tree gained a conflict against the rdma-fixes tree. The block tree gained a conflict against the dma-mapping tree. The kvm tree gained

Re: [PATCH v2 12/13] iommu/rockchip: Add runtime PM support

Hi Tomasz, On 01/17/2018 03:38 PM, Tomasz Figa wrote: >>Don't we need to check here (and in _shutdown() too) if we have a >>domain attached? > >hmmm, right, the startup might been called by resume, so should check >iommu->domain here. > >but the shutdown would be called at the end of detach or

Re: [PATCH v2 12/13] iommu/rockchip: Add runtime PM support

Hi Tomasz, On 01/17/2018 03:38 PM, Tomasz Figa wrote: >>Don't we need to check here (and in _shutdown() too) if we have a >>domain attached? > >hmmm, right, the startup might been called by resume, so should check >iommu->domain here. > >but the shutdown would be called at the end of detach or

Re: [BUG 4.15-rc7] IRQ matrix management errors

On Wed, Jan 17, 2018 at 08:34:22AM +0100, Thomas Gleixner wrote: > Can you trace the matrix allocations from the very beginning or tell me how > to reproduce. I'd like to figure out why this is happening. Sure, I'll get the irq_matrix events. I reproduce this on a machine with 112 CPUs and 3

Re: [BUG 4.15-rc7] IRQ matrix management errors

On Wed, Jan 17, 2018 at 08:34:22AM +0100, Thomas Gleixner wrote: > Can you trace the matrix allocations from the very beginning or tell me how > to reproduce. I'd like to figure out why this is happening. Sure, I'll get the irq_matrix events. I reproduce this on a machine with 112 CPUs and 3

Re: [PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically

On 01/17/2018 03:30 PM, Tomasz Figa wrote: >but it's possible the probe failed after calling iommu_device_set_fwnode, so >i'll try to add some checks here, and maybe adjust probe() to prevent it >too. I think iommu_device_set_fwnode() is not enough for of_iommu_xlate() to find the IOMMU. The

Re: [PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically

On 01/17/2018 03:30 PM, Tomasz Figa wrote: >but it's possible the probe failed after calling iommu_device_set_fwnode, so >i'll try to add some checks here, and maybe adjust probe() to prevent it >too. I think iommu_device_set_fwnode() is not enough for of_iommu_xlate() to find the IOMMU. The

Re: [PATCH v2 1/2] nvme: add tracepoint for nvme_setup_cmd

On Tue, Jan 16, 2018 at 05:49:54PM +0100, Christoph Hellwig wrote: > > + trace_seq_printf(p, "slba=%llu, length=%u, control=0x%x, dsmgmt=%u, > > reftag=%u", > > Overly long line. > > > +(unsigned long long)le64_to_cpu(rw.slba), > > u64 now always is an unsigned long long,

Re: [PATCH v2 1/2] nvme: add tracepoint for nvme_setup_cmd

On Tue, Jan 16, 2018 at 05:49:54PM +0100, Christoph Hellwig wrote: > > + trace_seq_printf(p, "slba=%llu, length=%u, control=0x%x, dsmgmt=%u, > > reftag=%u", > > Overly long line. > > > +(unsigned long long)le64_to_cpu(rw.slba), > > u64 now always is an unsigned long long,

Re: [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe()

Hi Tomasz, On 01/17/2018 03:16 PM, Tomasz Figa wrote: >> >>This lacks consistency. of_irq_count() is used for counting, but >>platform_get_irq() is used for getting. Either platform_ or of_ API >>should be used for both and I'd lean for platform_, since it's more >>general. > >hmmm, right, i

Re: [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe()

Hi Tomasz, On 01/17/2018 03:16 PM, Tomasz Figa wrote: >> >>This lacks consistency. of_irq_count() is used for counting, but >>platform_get_irq() is used for getting. Either platform_ or of_ API >>should be used for both and I'd lean for platform_, since it's more >>general. > >hmmm, right, i

Re: Power domain clock warnings on recent next

On Wed, Jan 17, 2018 at 7:25 AM, Marek Szyprowski wrote: > Hi Krzysztof, > > On 2018-01-16 21:07, Krzysztof Kozlowski wrote: >> >> Hi everyone, >> >> Anyone already noticed or started bisecting warnings coming from >> clk_core_disable_lock/exynos_pd_power on recent

Re: Power domain clock warnings on recent next

On Wed, Jan 17, 2018 at 7:25 AM, Marek Szyprowski wrote: > Hi Krzysztof, > > On 2018-01-16 21:07, Krzysztof Kozlowski wrote: >> >> Hi everyone, >> >> Anyone already noticed or started bisecting warnings coming from >> clk_core_disable_lock/exynos_pd_power on recent linux-next? > > > Yes, I've

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

It looks good to me. Reviewed-by: Changwei Ge On 2017/12/14 13:16, Gang He wrote: > As you know, ocfs2 has support trim the underlying disk via > fstrim command. But there is a problem, ocfs2 is a shared disk > cluster file system, if the user configures a scheduled fstrim

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

It looks good to me. Reviewed-by: Changwei Ge On 2017/12/14 13:16, Gang He wrote: > As you know, ocfs2 has support trim the underlying disk via > fstrim command. But there is a problem, ocfs2 is a shared disk > cluster file system, if the user configures a scheduled fstrim > job on each file

Re: [Ocfs2-devel] [PATCH v2 1/2] ocfs2: add trimfs dlm lock resource

It looks good to me. Reviewed-by: Changwei Ge On 2017/12/14 13:16, Gang He wrote: > Introduce a new dlm lock resource, which will be used to > communicate during fstrim a ocfs2 device from cluster nodes. > > Signed-off-by: Gang He > --- >

Re: [Ocfs2-devel] [PATCH v2 1/2] ocfs2: add trimfs dlm lock resource

It looks good to me. Reviewed-by: Changwei Ge On 2017/12/14 13:16, Gang He wrote: > Introduce a new dlm lock resource, which will be used to > communicate during fstrim a ocfs2 device from cluster nodes. > > Signed-off-by: Gang He > --- > fs/ocfs2/dlmglue.c | 86 >

Re: WARNING in can_rcv

On Wed, Jan 17, 2018 at 8:12 AM, Eric Biggers wrote: > On Wed, Jan 17, 2018 at 07:39:24AM +0100, Oliver Hartkopp wrote: >> >> >> On 01/16/2018 07:11 PM, Dmitry Vyukov wrote: >> > On Tue, Jan 16, 2018 at 7:07 PM, Marc Kleine-Budde >> > wrote: >> > > On

Re: WARNING in can_rcv

On Wed, Jan 17, 2018 at 8:12 AM, Eric Biggers wrote: > On Wed, Jan 17, 2018 at 07:39:24AM +0100, Oliver Hartkopp wrote: >> >> >> On 01/16/2018 07:11 PM, Dmitry Vyukov wrote: >> > On Tue, Jan 16, 2018 at 7:07 PM, Marc Kleine-Budde >> > wrote: >> > > On 01/16/2018 06:58 PM, syzbot wrote: >> > > >

Re: [PATCH v2 12/13] iommu/rockchip: Add runtime PM support

On Wed, Jan 17, 2018 at 4:26 PM, JeffyChen wrote: > Hi Tomasz, > > Thanks for your reply. > > On 01/17/2018 02:20 PM, Tomasz Figa wrote: >> >> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen >> [snip] >>> >>> +static int rk_iommu_startup(struct

Re: [PATCH v2 12/13] iommu/rockchip: Add runtime PM support

On Wed, Jan 17, 2018 at 4:26 PM, JeffyChen wrote: > Hi Tomasz, > > Thanks for your reply. > > On 01/17/2018 02:20 PM, Tomasz Figa wrote: >> >> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen >> [snip] >>> >>> +static int rk_iommu_startup(struct rk_iommu *iommu) >>> { >>> - struct rk_iommu

Re: [PATCH v3] retpoline: Add retpoline tag to VERMAGIC

On Tue, 16 Jan 2018, Andi Kleen wrote: > On Tue, Jan 16, 2018 at 10:24:53PM +0100, Thomas Gleixner wrote: > > On Tue, 16 Jan 2018, Andi Kleen wrote: > > > > > From: Andi Kleen > > > > > > Add a marker for retpoline to the module VERMAGIC. This catches > > > the case when

Re: [PATCH v3] retpoline: Add retpoline tag to VERMAGIC

On Tue, 16 Jan 2018, Andi Kleen wrote: > On Tue, Jan 16, 2018 at 10:24:53PM +0100, Thomas Gleixner wrote: > > On Tue, 16 Jan 2018, Andi Kleen wrote: > > > > > From: Andi Kleen > > > > > > Add a marker for retpoline to the module VERMAGIC. This catches > > > the case when a non RETPOLINE

[PATCH] x86/apic: Replace the redundant macros with an empty stub

The X86_LOCAL_APIC is depended on CONFIG X86_64, that means if CONFIG_X86_64=y, the X86_LOCAL_APIC must be y too. So, using if defined(CONFIG_X86_64) || defined(CONFIG_X86_LOCAL_APIC) ... is redundant. Remove the redundant macros and add an empty stub instead. also add some comments for

[PATCH] x86/apic: Replace the redundant macros with an empty stub

The X86_LOCAL_APIC is depended on CONFIG X86_64, that means if CONFIG_X86_64=y, the X86_LOCAL_APIC must be y too. So, using if defined(CONFIG_X86_64) || defined(CONFIG_X86_LOCAL_APIC) ... is redundant. Remove the redundant macros and add an empty stub instead. also add some comments for

Re: [PATCH 32/32] aio: implement io_pgetevents

On Tue, Jan 16, 2018 at 07:41:24PM -0500, Jeff Moyer wrote: > I'd be willing to bet the issue is in your io_syscall6 implementation. > You pass in arg5 where arg6 should be used. Don't feel bad, it took me > the better part of today to figure that out. :) > > Here's an incremental diff on top

Re: [PATCH 32/32] aio: implement io_pgetevents

On Tue, Jan 16, 2018 at 07:41:24PM -0500, Jeff Moyer wrote: > I'd be willing to bet the issue is in your io_syscall6 implementation. > You pass in arg5 where arg6 should be used. Don't feel bad, it took me > the better part of today to figure that out. :) > > Here's an incremental diff on top

Re: [PATCH v5 1/2] printk: Add console owner and waiter logic to load balance console writes

On 1/17/2018 11:19 AM, Byungchul Park wrote: On 1/10/2018 10:24 PM, Petr Mladek wrote: From: Steven Rostedt From: Steven Rostedt (VMware) This patch implements what I discussed in Kernel Summit. I added lockdep annotation (hopefully correctly), and

Re: [PATCH v5 1/2] printk: Add console owner and waiter logic to load balance console writes

On 1/17/2018 11:19 AM, Byungchul Park wrote: On 1/10/2018 10:24 PM, Petr Mladek wrote: From: Steven Rostedt From: Steven Rostedt (VMware) This patch implements what I discussed in Kernel Summit. I added lockdep annotation (hopefully correctly), and it hasn't had any splats (since I fixed

Re: [BUG 4.15-rc7] IRQ matrix management errors

On Tue, 16 Jan 2018, Keith Busch wrote: > On Tue, Jan 16, 2018 at 12:20:18PM +0100, Thomas Gleixner wrote: > > 8<-- > > diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c > > index f8b03bb8e725..3cc471beb50b 100644 > > --- a/arch/x86/kernel/apic/vector.c

Re: [BUG 4.15-rc7] IRQ matrix management errors

On Tue, 16 Jan 2018, Keith Busch wrote: > On Tue, Jan 16, 2018 at 12:20:18PM +0100, Thomas Gleixner wrote: > > 8<-- > > diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c > > index f8b03bb8e725..3cc471beb50b 100644 > > --- a/arch/x86/kernel/apic/vector.c

Re: [PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically

On Wed, Jan 17, 2018 at 4:20 PM, JeffyChen wrote: > Hi Tomasz, > > Thanks for your reply. > > > On 01/17/2018 01:44 PM, Tomasz Figa wrote: >> >> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen >> wrote: >>> >>> Converts the rockchip-iommu driver

Re: [PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically

On Wed, Jan 17, 2018 at 4:20 PM, JeffyChen wrote: > Hi Tomasz, > > Thanks for your reply. > > > On 01/17/2018 01:44 PM, Tomasz Figa wrote: >> >> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen >> wrote: >>> >>> Converts the rockchip-iommu driver to use the OF_IOMMU infrastructure, >>> which allows

kexec reboot fails with extra wbinvd introduced for AME SME

[Modify the subject since this is a new problem, original io vector issue has been fixed with one commit from Thomas] Add more cc according to below old discussion: https://lkml.org/lkml/2017/7/27/574 Tom, I'm not sure why you finally did not dynamically run wbinvd? On 01/04/18 at 11:15am, Dave

kexec reboot fails with extra wbinvd introduced for AME SME

[Modify the subject since this is a new problem, original io vector issue has been fixed with one commit from Thomas] Add more cc according to below old discussion: https://lkml.org/lkml/2017/7/27/574 Tom, I'm not sure why you finally did not dynamically run wbinvd? On 01/04/18 at 11:15am, Dave

Re: [PATCH v2 05/13] iommu/rockchip: Fix error handling in init

On Wed, Jan 17, 2018 at 4:14 PM, JeffyChen wrote: > Hi Tomasz, > > On 01/17/2018 01:26 PM, Tomasz Figa wrote: >> >> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen >> wrote: >>> >>> It's hard to undo bus_set_iommu() in the error path, so move it

Re: [PATCH v2 05/13] iommu/rockchip: Fix error handling in init

On Wed, Jan 17, 2018 at 4:14 PM, JeffyChen wrote: > Hi Tomasz, > > On 01/17/2018 01:26 PM, Tomasz Figa wrote: >> >> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen >> wrote: >>> >>> It's hard to undo bus_set_iommu() in the error path, so move it to the >>> end of rk_iommu_probe(). >> >> >> Does

Re: [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe()

On Wed, Jan 17, 2018 at 4:08 PM, JeffyChen wrote: > Hi Tomasz, > > Thanks for your reply. > > On 01/17/2018 12:21 PM, Tomasz Figa wrote: >> >> Hi Jeffy, >> >> Thanks for the patch. Please see my comments inline. >> >> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen

Re: [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe()

On Wed, Jan 17, 2018 at 4:08 PM, JeffyChen wrote: > Hi Tomasz, > > Thanks for your reply. > > On 01/17/2018 12:21 PM, Tomasz Figa wrote: >> >> Hi Jeffy, >> >> Thanks for the patch. Please see my comments inline. >> >> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen >> wrote: >> >> Please add patch

Re: WARNING in can_rcv

On Wed, Jan 17, 2018 at 07:39:24AM +0100, Oliver Hartkopp wrote: > > > On 01/16/2018 07:11 PM, Dmitry Vyukov wrote: > > On Tue, Jan 16, 2018 at 7:07 PM, Marc Kleine-Budde > > wrote: > > > On 01/16/2018 06:58 PM, syzbot wrote: > > > > Hello, > > > > > > > > syzkaller hit

Re: WARNING in can_rcv

On Wed, Jan 17, 2018 at 07:39:24AM +0100, Oliver Hartkopp wrote: > > > On 01/16/2018 07:11 PM, Dmitry Vyukov wrote: > > On Tue, Jan 16, 2018 at 7:07 PM, Marc Kleine-Budde > > wrote: > > > On 01/16/2018 06:58 PM, syzbot wrote: > > > > Hello, > > > > > > > > syzkaller hit the following crash on

Re: [PATCH 32/32] aio: implement io_pgetevents

On Wed, Jan 17, 2018 at 04:27:21AM +, Al Viro wrote: > On Tue, Jan 16, 2018 at 07:41:24PM -0500, Jeff Moyer wrote: > > if (sigmask) { > > - if (copy_from_user(, sigmask, sizeof(ksigmask))) > > + if (!access_ok(VERIFY_READ, sigmask, > > +

Re: [PATCH 32/32] aio: implement io_pgetevents

On Wed, Jan 17, 2018 at 04:27:21AM +, Al Viro wrote: > On Tue, Jan 16, 2018 at 07:41:24PM -0500, Jeff Moyer wrote: > > if (sigmask) { > > - if (copy_from_user(, sigmask, sizeof(ksigmask))) > > + if (!access_ok(VERIFY_READ, sigmask, > > +

Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

Hi Florian for gmac4.x and gmac3.x series the ACS bit is the Automatic Pad or CRC Stripping, so the core strips the Pad or FCS on frames if the value of the length field is < 1536 bytes. For MAC10-100 there is the Bit 8 (ASTP) of the reg0 that does the same if len is < 46bytes. In your patch

Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

Hi Florian for gmac4.x and gmac3.x series the ACS bit is the Automatic Pad or CRC Stripping, so the core strips the Pad or FCS on frames if the value of the length field is < 1536 bytes. For MAC10-100 there is the Bit 8 (ASTP) of the reg0 that does the same if len is < 46bytes. In your patch

[PATCH v5 01/17] ASoC: fsl_ssi: Redefine RX and TX macros

The RX and TX macros were defined implicitly and there was a potential risk if someone changes their values. Since they were defined to index the array ssi->regvals[2], this patch moves these two macros to fsl_ssi.c, closer to its owner ssi->regvals. And it also puts some comments here to limit

[PATCH v5 01/17] ASoC: fsl_ssi: Redefine RX and TX macros

The RX and TX macros were defined implicitly and there was a potential risk if someone changes their values. Since they were defined to index the array ssi->regvals[2], this patch moves these two macros to fsl_ssi.c, closer to its owner ssi->regvals. And it also puts some comments here to limit

[PATCH v5 04/17] ASoC: fsl_ssi: Maintain a mask of active streams

Checking TE and RE bits in SCR register doesn't work for AC97 mode which enables SSIEN, TE and RE in the fsl_ssi_setup_ac97() that's called during probe(). So when running into the trigger(), it will always get the result of both TE and RE being enabled already, even if actually there is no

[PATCH v5 04/17] ASoC: fsl_ssi: Maintain a mask of active streams

Checking TE and RE bits in SCR register doesn't work for AC97 mode which enables SSIEN, TE and RE in the fsl_ssi_setup_ac97() that's called during probe(). So when running into the trigger(), it will always get the result of both TE and RE being enabled already, even if actually there is no

[PATCH v5 05/17] ASoC: fsl_ssi: Rename fsl_ssi_disable_val macro

The define of fsl_ssi_disable_val is not so clear as it mixes two steps of calculations together. And those parameter names are also a bit long to read. Since it just tries to exclude the shared bits from the regvals of current stream while the opposite stream is active, it's better to use

[PATCH v5 03/17] ASoC: fsl_ssi: Clean up set_dai_tdm_slot()

This patch replaces the register read with ssi->i2s_net for simplification. It also removes masking SSIEN from scr value since it's handled later by regmap_update_bits() to set this scr value back. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome ---

[PATCH v5 05/17] ASoC: fsl_ssi: Rename fsl_ssi_disable_val macro

The define of fsl_ssi_disable_val is not so clear as it mixes two steps of calculations together. And those parameter names are also a bit long to read. Since it just tries to exclude the shared bits from the regvals of current stream while the opposite stream is active, it's better to use

[PATCH v5 03/17] ASoC: fsl_ssi: Clean up set_dai_tdm_slot()

This patch replaces the register read with ssi->i2s_net for simplification. It also removes masking SSIEN from scr value since it's handled later by regmap_update_bits() to set this scr value back. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- sound/soc/fsl/fsl_ssi.c | 7 ++- 1

[PATCH v5 06/17] ASoC: fsl_ssi: Clear FIFO directly in fsl_ssi_config()

The FIFO clear helper function is just one line of code now. So it could be cleaned up by removing it and calling regmap directly. Meanwhile, FIFO clear could be applied to all use cases, not confined to AC97. So this patch also moves FIFO clear in the trigger() to fsl_ssi_config() and removes

[PATCH v5 06/17] ASoC: fsl_ssi: Clear FIFO directly in fsl_ssi_config()

The FIFO clear helper function is just one line of code now. So it could be cleaned up by removing it and calling regmap directly. Meanwhile, FIFO clear could be applied to all use cases, not confined to AC97. So this patch also moves FIFO clear in the trigger() to fsl_ssi_config() and removes

[PATCH v5 08/17] ASoC: fsl_ssi: Add DAIFMT define for AC97

The _fsl_ssi_set_dai_fmt() bypasses an undefined format for AC97 mode. However, it's not really necessary if AC97 has its complete format defined. So this patch adds a DAIFMT macro of complete format including a clock direction and polarity. Signed-off-by: Nicolin Chen

[PATCH v5 08/17] ASoC: fsl_ssi: Add DAIFMT define for AC97

The _fsl_ssi_set_dai_fmt() bypasses an undefined format for AC97 mode. However, it's not really necessary if AC97 has its complete format defined. So this patch adds a DAIFMT macro of complete format including a clock direction and polarity. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome

[PATCH v5 02/17] ASoC: fsl_ssi: Keep ssi->i2s_net updated

The hw_params() overwrites i2s_net settings for special cases like mono-channel support, however, it doesn't update ssi->i2s_net as set_dai_fmt() does. This patch removes the local i2s_net variable and directly updates ssi->i2s_net in the hw_params() so that the driver can simply look up the

[PATCH v5 02/17] ASoC: fsl_ssi: Keep ssi->i2s_net updated

The hw_params() overwrites i2s_net settings for special cases like mono-channel support, however, it doesn't update ssi->i2s_net as set_dai_fmt() does. This patch removes the local i2s_net variable and directly updates ssi->i2s_net in the hw_params() so that the driver can simply look up the

[PATCH v5 10/17] ASoC: fsl_ssi: Set xFEN0 and xFEN1 together

It'd be safer to enable both FIFOs for TX or RX at the same time. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- sound/soc/fsl/fsl_ssi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c

[PATCH v5 10/17] ASoC: fsl_ssi: Set xFEN0 and xFEN1 together

It'd be safer to enable both FIFOs for TX or RX at the same time. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- sound/soc/fsl/fsl_ssi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index

[PATCH v5 09/17] ASoC: fsl_ssi: Clean up fsl_ssi_setup_regvals()

This patch cleans fsl_ssi_setup_regvals() by following changes: 1) Moving DBG bits to the first lines. 2) Setting SSIE, RE/TE as default and cleaning it for AC97 Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- sound/soc/fsl/fsl_ssi.c | 17

[PATCH v5 09/17] ASoC: fsl_ssi: Clean up fsl_ssi_setup_regvals()

This patch cleans fsl_ssi_setup_regvals() by following changes: 1) Moving DBG bits to the first lines. 2) Setting SSIE, RE/TE as default and cleaning it for AC97 Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- sound/soc/fsl/fsl_ssi.c | 17 ++--- 1 file changed, 6

[PATCH v5 12/17] ASoC: fsl_ssi: Move one-time configurations to probe()

The probe() could handle some one-time configurations since they will not be changed once being configured. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- Changelog v2 * Moved all to fsl_ssi_hw_init() in platform probe()

[PATCH v5 07/17] ASoC: fsl_ssi: Clean up helper functions of trigger()

The trigger() calls fsl_ssi_tx_config() and fsl_ssi_rx_config(), and both of them jump to fsl_ssi_config(). And fsl_ssi_config() later calls another fsl_ssi_rxtx_config(). However, the whole routine, especially fsl_ssi_config() function, is too complicated because of the folowing reasons: 1) It

[PATCH v5 12/17] ASoC: fsl_ssi: Move one-time configurations to probe()

The probe() could handle some one-time configurations since they will not be changed once being configured. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- Changelog v2 * Moved all to fsl_ssi_hw_init() in platform probe() sound/soc/fsl/fsl_ssi.c | 39

[PATCH v5 07/17] ASoC: fsl_ssi: Clean up helper functions of trigger()

The trigger() calls fsl_ssi_tx_config() and fsl_ssi_rx_config(), and both of them jump to fsl_ssi_config(). And fsl_ssi_config() later calls another fsl_ssi_rxtx_config(). However, the whole routine, especially fsl_ssi_config() function, is too complicated because of the folowing reasons: 1) It

[PATCH v5 13/17] ASoC: fsl_ssi: Setup AC97 in fsl_ssi_hw_init()

AC97 configures most of registers earlier to start a communication with CODECs in order to successfully initialize CODEC. Currently, _fsl_ssi_set_dai_fmt() and fsl_ssi_setup_ac97() are called to get all SSI registers properly set. Since now the driver has a fsl_ssi_hw_init() to handle all

[PATCH v5 13/17] ASoC: fsl_ssi: Setup AC97 in fsl_ssi_hw_init()

AC97 configures most of registers earlier to start a communication with CODECs in order to successfully initialize CODEC. Currently, _fsl_ssi_set_dai_fmt() and fsl_ssi_setup_ac97() are called to get all SSI registers properly set. Since now the driver has a fsl_ssi_hw_init() to handle all

[PATCH v5 17/17] ASoC: fsl_ssi: Use ssi->streams instead of reading register

Since ssi->streams is being updated along with SCR register and its SSIEN bit, it's simpler to use it instead. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- sound/soc/fsl/fsl_ssi.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-)

[PATCH v5 17/17] ASoC: fsl_ssi: Use ssi->streams instead of reading register

Since ssi->streams is being updated along with SCR register and its SSIEN bit, it's simpler to use it instead. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- sound/soc/fsl/fsl_ssi.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c

[PATCH v5 14/17] ASoC: fsl_ssi: Clean up _fsl_ssi_set_dai_fmt()

The _fsl_ssi_set_dai_fmt() is a helper function being called from fsl_ssi_set_dai_fmt() as an ASoC operation and fsl_ssi_hw_init() mainly for AC97 format initialization. This patch cleans the _fsl_ssi_set_dai_fmt() in following ways: * Removing *dev pointer in the parameters as it's included in

[PATCH v5 16/17] ASoC: fsl_ssi: Move DT related code to a separate probe()

This patch cleans up probe() function by moving all Device Tree related code into a separate function. It allows the probe() to be Device Tree independent. This will be very useful for future integration of imx-ssi driver which has similar functionalities while exists only because it supports

[PATCH v5 16/17] ASoC: fsl_ssi: Move DT related code to a separate probe()

This patch cleans up probe() function by moving all Device Tree related code into a separate function. It allows the probe() to be Device Tree independent. This will be very useful for future integration of imx-ssi driver which has similar functionalities while exists only because it supports

[PATCH v5 14/17] ASoC: fsl_ssi: Clean up _fsl_ssi_set_dai_fmt()

The _fsl_ssi_set_dai_fmt() is a helper function being called from fsl_ssi_set_dai_fmt() as an ASoC operation and fsl_ssi_hw_init() mainly for AC97 format initialization. This patch cleans the _fsl_ssi_set_dai_fmt() in following ways: * Removing *dev pointer in the parameters as it's included in

[PATCH v5 11/17] ASoC: fsl_ssi: Use snd_soc_init_dma_data instead

Since there is a helper function, use it to help readability. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- sound/soc/fsl/fsl_ssi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c

[PATCH v5 11/17] ASoC: fsl_ssi: Use snd_soc_init_dma_data instead

Since there is a helper function, use it to help readability. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- sound/soc/fsl/fsl_ssi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index ba06e94..e1fe511

[PATCH v5 15/17] ASoC: fsl_ssi: Add bool synchronous to mark synchronous mode

Using symmetric_rates in the cpu_dai_drv is a bit implicit, so this patch adds a bool synchronous instead. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- Changelog v3 * Removed all cpu_dai_drv changes sound/soc/fsl/fsl_ssi.c | 13 -

[PATCH v5 15/17] ASoC: fsl_ssi: Add bool synchronous to mark synchronous mode

Using symmetric_rates in the cpu_dai_drv is a bit implicit, so this patch adds a bool synchronous instead. Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- Changelog v3 * Removed all cpu_dai_drv changes sound/soc/fsl/fsl_ssi.c | 13 - 1 file changed, 8 insertions(+), 5

[PATCH v5 00/17] ASoC: fsl_ssi: Clean up - program flow level

[ Maciej, could you please send your Tested-by/Reviewed-by for AC97 once you confirm this series? And Caleb, this version does not need a test for non-AC97 cases. Thanks both! ] ==Change log== v5 * Reworked the series by taking suggestions from Maciej for AC97 + Fixed SSI lockup

[PATCH v5 00/17] ASoC: fsl_ssi: Clean up - program flow level

[ Maciej, could you please send your Tested-by/Reviewed-by for AC97 once you confirm this series? And Caleb, this version does not need a test for non-AC97 cases. Thanks both! ] ==Change log== v5 * Reworked the series by taking suggestions from Maciej for AC97 + Fixed SSI lockup

[PATCH] MIPS: use generic GCC library routines from lib/

The commit b35cd9884fa5 ("lib: Add shared copies of some GCC library routines") makes it possible to share generic GCC library routines by several architectures. This commit removes several generic GCC library routines from arch/mips/lib/ in favour of similar routines from lib/. Signed-off-by:

[PATCH] MIPS: use generic GCC library routines from lib/

The commit b35cd9884fa5 ("lib: Add shared copies of some GCC library routines") makes it possible to share generic GCC library routines by several architectures. This commit removes several generic GCC library routines from arch/mips/lib/ in favour of similar routines from lib/. Signed-off-by:

Re: [PATCH v3 8/9] x86: use __uaccess_begin_nospec and ASM_IFENCE in get_user paths

On Tue, Jan 16, 2018 at 10:28 PM, Al Viro wrote: > On Tue, Jan 16, 2018 at 08:30:17PM -0800, Dan Williams wrote: >> On Tue, Jan 16, 2018 at 2:23 PM, Dan Williams >> wrote: >> > On Sat, Jan 13, 2018 at 11:33 AM, Linus Torvalds >> [..] >> > I'll

Re: [PATCH v3 8/9] x86: use __uaccess_begin_nospec and ASM_IFENCE in get_user paths

On Tue, Jan 16, 2018 at 10:28 PM, Al Viro wrote: > On Tue, Jan 16, 2018 at 08:30:17PM -0800, Dan Williams wrote: >> On Tue, Jan 16, 2018 at 2:23 PM, Dan Williams >> wrote: >> > On Sat, Jan 13, 2018 at 11:33 AM, Linus Torvalds >> [..] >> > I'll respin this set along those lines, and drop the

[tip:x86/pti] x86/cpufeature: Move processor tracing out of scattered features

Commit-ID: 4fdec2034b7540dda461c6ba33325dfcff345c64 Gitweb: https://git.kernel.org/tip/4fdec2034b7540dda461c6ba33325dfcff345c64 Author: Paolo Bonzini AuthorDate: Tue, 16 Jan 2018 16:42:25 +0100 Committer: Ingo Molnar CommitDate: Wed, 17 Jan 2018

[tip:x86/pti] x86/cpufeature: Move processor tracing out of scattered features

Commit-ID: 4fdec2034b7540dda461c6ba33325dfcff345c64 Gitweb: https://git.kernel.org/tip/4fdec2034b7540dda461c6ba33325dfcff345c64 Author: Paolo Bonzini AuthorDate: Tue, 16 Jan 2018 16:42:25 +0100 Committer: Ingo Molnar CommitDate: Wed, 17 Jan 2018 07:38:39 +0100 x86/cpufeature: Move

Re: [PATCH 1/2] powerpc: export thread-tidr interfaces

Hi, diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c index 2010e4c..f20c1ad 100644 --- a/arch/powerpc/kernel/process.c +++ b/arch/powerpc/kernel/process.c @@ -1560,6 +1560,7 @@ void clear_thread_tidr(struct task_struct *t) free_thread_tidr(t->thread.tidr);

Re: [PATCH 1/2] powerpc: export thread-tidr interfaces

Hi, diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c index 2010e4c..f20c1ad 100644 --- a/arch/powerpc/kernel/process.c +++ b/arch/powerpc/kernel/process.c @@ -1560,6 +1560,7 @@ void clear_thread_tidr(struct task_struct *t) free_thread_tidr(t->thread.tidr);

Re: WARNING in can_rcv

On 01/16/2018 07:11 PM, Dmitry Vyukov wrote: On Tue, Jan 16, 2018 at 7:07 PM, Marc Kleine-Budde wrote: On 01/16/2018 06:58 PM, syzbot wrote: Hello, syzkaller hit the following crash on a8750ddca918032d6349adbf9a4b6555e7db20da

Re: WARNING in can_rcv

On 01/16/2018 07:11 PM, Dmitry Vyukov wrote: On Tue, Jan 16, 2018 at 7:07 PM, Marc Kleine-Budde wrote: On 01/16/2018 06:58 PM, syzbot wrote: Hello, syzkaller hit the following crash on a8750ddca918032d6349adbf9a4b6555e7db20da

Re: general protection fault in __crypto_alg_lookup

On Tue, Dec 19, 2017 at 11:49:02PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: general protection fault in __crypto_alg_lookup

On Tue, Dec 19, 2017 at 11:49:02PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: BUG: unable to handle kernel NULL pointer dereference in crypto_alg_tested

On Fri, Dec 22, 2017 at 11:33:02PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: BUG: unable to handle kernel NULL pointer dereference in crypto_alg_tested

On Fri, Dec 22, 2017 at 11:33:02PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: general protection fault in crypto_remove_spawns

On Mon, Nov 27, 2017 at 10:56:46AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 1ea8d039f9edcfefb20d8ddfe136930f6e551529 > git://git.cmpxchg.org/linux-mmots.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. > C

Re: general protection fault in crypto_remove_spawns

On Mon, Nov 27, 2017 at 10:56:46AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 1ea8d039f9edcfefb20d8ddfe136930f6e551529 > git://git.cmpxchg.org/linux-mmots.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. > C

  1   2   3   4   5   6   7   8   9   10   >