Re: [PATCH 01/12] mfd: dt-bindings: Add wcd9335 mfd bindings

2018-07-23 Thread Vinod
On 23-07-18, 16:53, Srinivas Kandagatla wrote: > Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC, supports > Qualcomm Technologies, Inc. (QTI) multimedia solutions, including > the MSM8996, MSM8976, and MSM8956 chipsets. It has in-build in-built perhaps? -- ~Vinod

Re: [PATCH] drm/tegra: hdmi: probe deferral error reporting

2018-07-23 Thread Marcel Ziswiler
On July 23, 2018 10:49:15 PM GMT+02:00, Lucas Stach wrote: >Am Freitag, den 20.07.2018, 09:55 +0200 schrieb Marcel Ziswiler: >> From: Marcel Ziswiler >> >> Actually report the error code from devm_regulator_get() which may as >> well just be a probe deferral. > >This is still noisy, so while

Re: KASAN: use-after-free Read in link_path_walk

2018-07-23 Thread DaeRyong Jeong
Because our fuzzer has a problem, I don't have a C reproducer so far. I reported the crash becasue I saw the crash repeatedly in our fuzzer and I hoped the report is helpful. But it seems not enough. If I was wrong and I made you confused, I am really sorry for that. Could you give me a second? I

Re: [PATCH 00/12] mfd: Add support to WCD9335 Audio Codec

2018-07-23 Thread Vinod
On 23-07-18, 16:53, Srinivas Kandagatla wrote: > Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC. > It is integrated in multiple Qualcomm SoCs like: MSM8996, MSM8976, > and MSM8956 chipsets. > > WCD9335 had multiple functional blocks, like: Soundwire controller, > interrupt mux, pin

RE: [PATCH V4] mmc: core: improve reasonableness of bus width setting for HS400es

2018-07-23 Thread 方洪杰
> mmc_select_hs400es() calls mmc_select_bus_width() which will continue > to set 4bit transfer mode if fail to set 8bit mode. The bus width > should not be set to 4bit in HS400es. > > When fail to set 8bit mode, need return error directly for HS400es. > > Signed-off-by: Hongjie Fang > --- >

Re: [PATCH v2] mtd/maps: fix solutionengine.c printk format warnings

2018-07-23 Thread Boris Brezillon
On Sun, 22 Jul 2018 16:28:52 -0700 Randy Dunlap wrote: > From: Randy Dunlap > > Fix 2 printk format warnings (this driver is currently only used by > arch/sh/) by using "%pap" instead of "%lx". > (or we could just cast the physical addresses to unsigned int) > > Fixes these build warnings: >

Re: [PATCH] hexagon: switch to NO_BOOTMEM

2018-07-23 Thread Mike Rapoport
On Mon, Jul 23, 2018 at 04:23:39PM -0500, Richard Kuo wrote: > > On Mon, Jul 16, 2018 at 10:43:18AM +0300, Mike Rapoport wrote: > > This patch adds registration of the system memory with memblock, eliminates > > bootmem initialization and converts early memory reservations from bootmem > > to

Re: [PATCH 2/3] dt-bindings: arm: syna: add support for the AS370 SoC

2018-07-23 Thread Jisheng Zhang
Hi Rob On Fri, 20 Jul 2018 09:15:29 -0600 Rob Herring wrote: > On Fri, Jul 13, 2018 at 05:24:57PM +0800, Jisheng Zhang wrote: > > The AS370 SoC is a new derivative of the berlin family. The only > > difference is the SoC isn't named as berlin*. > > So is it a derivative or just rebranded? A

[PATCH 2/5] fsi: sbefifo: Convert to use the new chardev

2018-07-23 Thread Benjamin Herrenschmidt
This converts FSI sbefifo to use the new fsi-core controlled chardev allocator and use a real cdev instead of a miscdev. One side effect is to fix the object lifetime by removing the use of devm_kzalloc() for something that contains kobjects, and using proper reference counting. Signed-off-by:

Re: [PATCH] Staging: octeon: Apply Licence and resolves warnings according to TODO list. There are also a few "checks" that probably should revised but i think most of them could be resolved by breaki

2018-07-23 Thread Greg KH
On Tue, Jul 24, 2018 at 01:21:17AM +0300, Georgios Tsotsos wrote: > Signed-off-by: Georgios Tsotsos > --- > drivers/staging/octeon-usb/octeon-hcd.c | 55 > ++--- > drivers/staging/octeon-usb/octeon-hcd.h | 1 + Hi, This is the friendly patch-bot of Greg

Re: KASAN: use-after-free Read in link_path_walk

2018-07-23 Thread Al Viro
On Tue, Jul 24, 2018 at 06:17:26AM +0100, Al Viro wrote: > On Tue, Jul 24, 2018 at 12:45:42PM +0900, Dae R. Jeong wrote: > > Diagnosis: > > We think that it is possible that link_path_walk() dereferences a > > freed pointer when cleanup_mnt() is executed between path_init() and > >

Re: [PATCH 5/7] x86/vdso: Add vDSO functions for direct store instructions

2018-07-23 Thread Andy Lutomirski
On Mon, Jul 23, 2018 at 8:42 PM, Fenghua Yu wrote: > On Mon, Jul 23, 2018 at 06:48:00PM -0700, Andy Lutomirski wrote: >> On 07/23/2018 05:55 AM, Fenghua Yu wrote: >> >The instructions can be implemented in intrinsic functions in future >> >GCC. But the vDSO interfaces are available to user

[PATCH 5/5] fsi: Prevent multiple concurrent rescans

2018-07-23 Thread Benjamin Herrenschmidt
The bus scanning process isn't terribly good at parallel attempts at rescanning the same bus. Let's have a per-master mutex protecting the scanning process. Signed-off-by: Benjamin Herrenschmidt --- drivers/fsi/fsi-core.c | 16 ++-- drivers/fsi/fsi-master.h | 2 ++ 2 files

[PATCH 4/5] fsi: Add cfam char devices

2018-07-23 Thread Benjamin Herrenschmidt
This aims to deprecate the "raw" sysfs file used for directly accessing the CFAM and instead use a char device like the other sub drivers. Since it reworks the slave creation code and adds a cfam device type, we also use the opportunity to convert the attributes to attribute groups and add a

Re: KASAN: use-after-free Read in link_path_walk

2018-07-23 Thread Al Viro
On Tue, Jul 24, 2018 at 12:45:42PM +0900, Dae R. Jeong wrote: > Diagnosis: > We think that it is possible that link_path_walk() dereferences a > freed pointer when cleanup_mnt() is executed between path_init() and > link_path_walk(). > > Since I'm not an expert on a file system and don't fully

[PATCH 1/5] fsi: Add new central chardev support

2018-07-23 Thread Benjamin Herrenschmidt
The various FSI devices (sbefifo, occ, scom, more to come) currently use misc devices. This is problematic as the minor device space for misc is limited and there can be a lot of them. Also it limits our ability to move them to a dedicated /dev/fsi directory or to be smart about device naming and

[PATCH 3/5] fsi: scom: Convert to use the new chardev

2018-07-23 Thread Benjamin Herrenschmidt
This converts FSI scom to use the new fsi-core controlled chardev allocator and use a real cdev instead of a miscdev. Signed-off-by: Benjamin Herrenschmidt --- drivers/fsi/fsi-scom.c | 130 + 1 file changed, 80 insertions(+), 50 deletions(-) diff --git

[PATCH 0/5] fsi: Convert misc devs to proper chardevs and more

2018-07-23 Thread Benjamin Herrenschmidt
This converts the various FSI devices from misc dev to chardev, as there can potentially be too much of them for misc devs limited minors, and because there are some lifetime issues with the current support. This provide a common infrastructure to allocate an FSI major and distribute minors in a

Re: m68k allmodconfig build errors

2018-07-23 Thread Finn Thain
On Mon, 23 Jul 2018, Randy Dunlap wrote: > On 07/20/2018 12:20 AM, Andreas Schwab wrote: > > On Jul 19 2018, Randy Dunlap wrote: > > > >> block/partitions/ldm.o: In function `ldm_partition': > >> ldm.c:(.text+0x1900): undefined reference to `strcmp' > >> ldm.c:(.text+0x1964): undefined

Urgent Reply

2018-07-23 Thread Xu Shiqing
-- Greetings, There is an urgent matter and mutual offer i would want to bring to your attention privately and i would appreciate your swift response here (xu.shiq...@aol.com) for further communication. Await your swift response. Regards,

[GIT PULL] FSI updates round 3 for 4.19

2018-07-23 Thread Benjamin Herrenschmidt
Hi Greg ! This adds support for offloading the FSI low level bitbanging to the ColdFire coprocessor of the Aspeed SoCs. All the pre-requisites have already been merged, this is the final piece in the puzzle. This branch also pull gpio/ib-aspeed which is a topic branch already in gpio/for-next

Re: KASAN: use-after-free Read in link_path_walk

2018-07-23 Thread DaeRyong Jeong
I think that below two crashes are also related to the same race issue. KASAN: use-after-free Read in nd_jump_root, found in v4.17-rc1 KASAN: use-after-free in set_root, found in v4.18-rc3 == BUG: KASAN: use-after-free in

Re: [PATCH 2/4] phy: socionext: add USB3 PHY driver for UniPhier SoC

2018-07-23 Thread Kishon Vijay Abraham I
Hi, On Tuesday 17 July 2018 04:57 PM, Kunihiko Hayashi wrote: > Hi Kishon, > > On Fri, 13 Jul 2018 12:45:06 +0530 wrote: > >> Hi, >> >> On Wednesday 11 July 2018 05:35 PM, Kunihiko Hayashi wrote: >>> On Mon, 9 Jul 2018 20:23:19 +0900 wrote: >>> Hi Kishon, Thank you for your

Re: WARNING in port_delete

2018-07-23 Thread DaeRyong Jeong
I just realized that the crash has been spotted by Syzkaller a few days before. (https://syzkaller.appspot.com/bug?id=3490860a465e6b39227c6906f0ef2d40ad4d5bb1) I'm CC'ing Syzkaller's mailing list. Best regards, DaeRyong Jeong On Tue, Jul 24, 2018 at 12:36 PM, Dae R. Jeong wrote: > Reporting

Re: [PATCH v2] phy: Add driver for Cadence MHDP DisplayPort SD0801 PHY

2018-07-23 Thread Kishon Vijay Abraham I
Hi, On Friday 20 July 2018 06:11 PM, Scott Telford wrote: > Add driver for the Cadence SD0801 "Torrent" PHY used with the Cadence MHDP > DisplayPort Tx controller. > > Integration with the MHDP driver will be the subject of another commit. > > Signed-off-by: Scott Telford > --- >

KASAN: use-after-free Read in link_path_walk

2018-07-23 Thread Dae R. Jeong
Reporting the crash: KASAN: use-after-free Read in link_path_walk This crash has been found in v4.17-rc1 using RaceFuzzer (a modified version of Syzkaller), which we describe more at the end of this report. Our analysis shows that the race occurs when invoking two syscalls concurrently, open()

Re: [PATCH] cpufreq: qcom-kryo: add NULL entry to the end of_device_id array

2018-07-23 Thread Viresh Kumar
On 23-07-18, 20:34, YueHaibing wrote: > Make sure of_device_id tables are NULL terminated > Found by coccinelle spatch "misc/of_table.cocci" > > Signed-off-by: YueHaibing > --- > drivers/cpufreq/qcom-cpufreq-kryo.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH 5/7] x86/vdso: Add vDSO functions for direct store instructions

2018-07-23 Thread Fenghua Yu
On Mon, Jul 23, 2018 at 06:48:00PM -0700, Andy Lutomirski wrote: > On 07/23/2018 05:55 AM, Fenghua Yu wrote: > >The instructions can be implemented in intrinsic functions in future > >GCC. But the vDSO interfaces are available to user without the > I'm not convinced that any of this belongs in the

WARNING in port_delete

2018-07-23 Thread Dae R. Jeong
Reporting the crash: WARNING in port_delete This crash has been found in v4.18-rc3 using RaceFuzzer (a modified version of Syzkaller), which we descrbie more at the end of this report. Our analysis shows that the race occurs when invoking two close syscalls concurrently. The executed program is

Re: [PATCH v6 3/6] Uprobes: Support SDT markers having reference count (semaphore)

2018-07-23 Thread Ravi Bangoria
Hi Oleg, On 07/23/2018 09:56 PM, Oleg Nesterov wrote: > I have a mixed feeling about this series... I'll try to summarise my thinking > tomorrow, but I do not see any obvious problem so far. Although I have some > concerns about 5/6, I need to re-read it after sleep. Sure. > > > On 07/16,

Re: [PATCH v2 2/2] clk: qcom: Add qspi (Quad SPI) clocks for sdm845

2018-07-23 Thread Doug Anderson
Hi, On Mon, Jul 23, 2018 at 7:22 PM, Taniya Das wrote: > > > On 7/24/2018 3:24 AM, Douglas Anderson wrote: >> >> Add both the interface and core clock. >> >> Signed-off-by: Douglas Anderson >> --- >> >> Changes in v2: >> - Only 19.2, 100, 150, and 300 MHz now. >> - All clocks come from MAIN

[PATCH 19/20] fork: Have new threads join on-going signal group stops

2018-07-23 Thread Eric W. Biederman
There are only two signals that are delivered to every member of a signal group: SIGSTOP and SIGKILL. Signal delivery requires every signal appear to be delivered either before or after a clone syscall. SIGKILL terminates the clone so does not need to be considered. Which leaves only SIGSTOP

[PATCH 15/20] signal: Push pid type down into complete_signal.

2018-07-23 Thread Eric W. Biederman
This is the bottom and by pushing this down it simplifies the callers and otherwise leaves things as is. This is in preparation for allowing fork to implement better handling of signals set to groups of processes. Signed-off-by: "Eric W. Biederman" --- kernel/signal.c | 8 1 file

[PATCH 14/20] signal: Push pid type down into __send_signal

2018-07-23 Thread Eric W. Biederman
This information is already available in the callers and by pushing it down it makes the code a little clearer, and allows implementing better handling of signales set to a group of processes in fork. Signed-off-by: "Eric W. Biederman" --- kernel/signal.c | 12 ++-- 1 file changed, 6

[PATCH 13/20] signal: Push pid type down into send_signal

2018-07-23 Thread Eric W. Biederman
This information is already available in the callers and by pushing it down it makes the code a little clearer, and allows better group signal behavior in fork. Signed-off-by: "Eric W. Biederman" --- kernel/signal.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 16/20] fork: Move and describe why the code examines PIDNS_ADDING

2018-07-23 Thread Eric W. Biederman
Normally this would be something that would be handled by handling signals that are sent to a group of processes but in this case the forking process is not a member of the group being signaled. Thus special code is needed to prevent a race with pid namespaces exiting, and fork adding new

[PATCH 11/20] signal: Pass pid type into send_sigio_to_task & send_sigurg_to_task

2018-07-23 Thread Eric W. Biederman
This information is already present and using it directly simplifies the logic of the code. Signed-off-by: "Eric W. Biederman" --- fs/fcntl.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/fs/fcntl.c b/fs/fcntl.c index 1523588fd759..5d596a00f40b

[PATCH 20/20] signal: Don't restart fork when signals come in.

2018-07-23 Thread Eric W. Biederman
Wen Yang and majiang report that a periodic signal received during fork can cause fork to continually restart preventing an application from making progress. The code was being overly pesimistic. Fork needs to guarantee that a signal sent to multiple processes is logically delivered before the

[PATCH 12/20] signal: Pass pid type into do_send_sig_info

2018-07-23 Thread Eric W. Biederman
This passes the information we already have at the call sight into do_send_sig_info. Ultimately allowing for better handling of signals sent to a group of processes during fork. Signed-off-by: "Eric W. Biederman" --- drivers/tty/sysrq.c| 2 +- fs/fcntl.c | 6 +++---

[PATCH 18/20] signal: Add calculate_sigpending()

2018-07-23 Thread Eric W. Biederman
Add a function calculate_sigpending to test to see if any signals are pending for a new task immediately following fork. Signals have to happen either before or after fork. Today our practice is to push all of the signals to before the fork, but that has the downside that frequent or periodic

[PATCH 17/20] fork: Unconditionally exit if a fatal signal is pending

2018-07-23 Thread Eric W. Biederman
In practice this does not change anything as testing for fatal_signal_pending and exiting for with an error code duplicates the work of the next clause which recalculates pending signals and then exits fork if any are pending. In both cases the pending signal will trigger the slow path when

[PATCH 08/20] posix-timers: Noralize good_sigevent

2018-07-23 Thread Eric W. Biederman
In good_sigevent directly compute the default return value as "task_tgid(current)". This is exactly the same as "task_pid(current->group_leader)" but written more clearly. In the thread case first compute the thread's pid. Then veify that attached to that pid is a thread of the current thread

[PATCH 07/20] signal: Use PIDTYPE_TGID to clearly store where file signals will be sent

2018-07-23 Thread Eric W. Biederman
When f_setown is called a pid and a pid type are stored. Replace the use of PIDTYPE_PID with PIDTYPE_TGID as PIDTYPE_TGID goes to the entire thread group. Replace the use of PIDTYPE_MAX with PIDTYPE_PID as PIDTYPE_PID now is only for a thread. Update the users of __f_setown to use PIDTYPE_TGID

[PATCH 09/20] signal: Pass pid and pid type into send_sigqueue

2018-07-23 Thread Eric W. Biederman
Make the code more maintainable by performing more of the signal related work in send_sigqueue. A quick inspection of do_timer_create will show that this code path does not lookup a thread group by a thread's pid. Making it safe to find the task pointed to by it_pid with "pid_task(it_pid,

[PATCH 06/20] pid: Implement PIDTYPE_TGID

2018-07-23 Thread Eric W. Biederman
Everywhere except in the pid array we distinguish between a tasks pid and a tasks tgid (thread group id). Even in the enumeration we want that distinction sometimes so we have added __PIDTYPE_TGID. With leader_pid we almost have an implementation of PIDTYPE_TGID in struct signal_struct. Add

[PATCH 10/20] signal: Pass pid type into group_send_sig_info

2018-07-23 Thread Eric W. Biederman
This passes the information we already have at the call sight into group_send_sig_info. Ultimatelly allowing for to better handle signals sent to a group of processes. Signed-off-by: "Eric W. Biederman" --- include/linux/signal.h | 4 +++- kernel/exit.c | 3 ++- kernel/signal.c

[PATCH 01/20] pids: Initialize leader_pid in init_task

2018-07-23 Thread Eric W. Biederman
This is cheap and no cost so we might as well. Signed-off-by: "Eric W. Biederman" --- init/init_task.c | 1 + 1 file changed, 1 insertion(+) diff --git a/init/init_task.c b/init/init_task.c index 74f60baa2799..7914ffb8dc73 100644 --- a/init/init_task.c +++ b/init/init_task.c @@ -33,6 +33,7 @@

[PATCH 02/20] pids: Move task_pid_type into sched/signal.h

2018-07-23 Thread Eric W. Biederman
The function is general and inline so there is no need to hide it inside of exit.c Signed-off-by: "Eric W. Biederman" --- include/linux/sched/signal.h | 8 kernel/exit.c| 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH 03/20] pids: Compute task_tgid using signal->leader_pid

2018-07-23 Thread Eric W. Biederman
The cost is the the same and this removes the need to worry about complications that come from de_thread and group_leader changing. __task_pid_nr_ns has been updated to take advantage of this change. Signed-off-by: "Eric W. Biederman" --- arch/ia64/kernel/asm-offsets.c | 2 +-

[PATCH 05/20] pids: Move the pgrp and session pid pointers from task_struct to signal_struct

2018-07-23 Thread Eric W. Biederman
To access these fields the code always has to go to group leader so going to signal struct is no loss and is actually a fundamental simplification. This saves a little bit of memory by only allocating the pid pointer array once instead of once for every thread, and even better this removes a few

[PATCH 04/20] kvm: Don't open code task_pid in kvm_vcpu_ioctl

2018-07-23 Thread Eric W. Biederman
Signed-off-by: "Eric W. Biederman" --- virt/kvm/kvm_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index ada21f47f22b..4c593acc4510 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -2560,7 +2560,7 @@ static long

[PATCH 00/20] PIDTYPE_TGID removal of fork restarts

2018-07-23 Thread Eric W. Biederman
This took longer than I thought to address all of the issues and double check I am not missing something. I have split of a few of the patches so now the patch series appears longer. It now covers less ground. I realized while reviewing the group signals that for none of them is siginfo

Re: [PATCH v2 2/2] PCI: NVMe device specific reset quirk

2018-07-23 Thread Alex Williamson
On Mon, 23 Jul 2018 19:20:41 -0700 Sinan Kaya wrote: > On 7/23/18, Alex Williamson wrote: > > On Mon, 23 Jul 2018 17:40:02 -0700 > > Sinan Kaya wrote: > > > >> On 7/23/2018 5:13 PM, Alex Williamson wrote: > >> > + * The NVMe specification requires that controllers support PCIe FLR, > >> >

[PATCH V4 4/7] mmc: sdhci: add 32-bit block count support for v4 mode

2018-07-23 Thread Chunyan Zhang
Host Controller Version 4.10 re-defines SDMA System Address register as 32-bit Block Count for v4 mode, and SDMA uses ADMA System Address register (05Fh-058h) instead if v4 mode is enabled. Also when using 32-bit block count, 16-bit block count register need to be set to zero. Signed-off-by:

Re: Zram writeback feature unstable with heavy swap utilization - BUG: Bad page state in process...

2018-07-23 Thread Sergey Senozhatsky
On (07/24/18 10:03), Minchan Kim wrote: > On Mon, Jul 23, 2018 at 02:29:32PM +0200, Tino Lehnig wrote: > > Hello, > > > > after enabling the writeback feature in zram, I encountered the kernel bug > > below with heavy swap utilization. There is one specific workload that > > triggers the bug

[PATCH V4 2/7] mmc: sdhci: Change SDMA address register for v4 mode

2018-07-23 Thread Chunyan Zhang
According to the SD host controller specification version 4.10, when Host Version 4 is enabled, SDMA uses ADMA System Address register (05Fh-058h) instead of using SDMA System Address register to support both 32-bit and 64-bit addressing. Signed-off-by: Chunyan Zhang ---

Re: [PATCH] input: pxrc - do not store USB device in private struct

2018-07-23 Thread Dmitry Torokhov
Hi Marcus, On Mon, Jul 16, 2018 at 04:40:14PM +0200, Marcus Folkesson wrote: > The USB device is only needed during setup, so put it back after > initialization and do not store it in our private struct. > > Also, the USB device is a parent of USB interface so our driver > model rules ensure

Re: [linux-sunxi] Re: [PATCH 3/3] arm64: allwinner: dts: h6: add Wi-Fi support for Pine H64 model A/B

2018-07-23 Thread Chen-Yu Tsai
On Tue, Jul 24, 2018 at 10:28 AM, Icenowy Zheng wrote: > > > 于 2018年7月24日 GMT+08:00 上午10:26:02, Chen-Yu Tsai 写到: >>On Tue, Jul 24, 2018 at 10:23 AM, Icenowy Zheng >>wrote: >>> >>> >>> 于 2018年7月24日 GMT+08:00 上午10:21:59, Chen-Yu Tsai 写到: On Tue, Jul 24, 2018 at 9:15 AM, Icenowy Zheng

Re: [RFC 1/2] x86/entry/64: Use the TSS sp2 slot for rsp_scratch

2018-07-23 Thread Andy Lutomirski
On Mon, Jul 23, 2018 at 5:38 AM, Dave Hansen wrote: > On 07/22/2018 10:45 AM, Andy Lutomirski wrote: >> + /* >> + * sp2 is scratch space used by the SYSCALL64 handler. Linux does >> + * not use rung 2, so sp2 is not otherwise needed. >> + */ >> u64

[PATCH 2/5] Input: pxrc - fix freeing URB on device teardown

2018-07-23 Thread Dmitry Torokhov
URB is the only resource that is not managed, and thus is destroyed too early, before we unregister input device and stop URB in pxrc_close(). To fix it let's install custom devm handler to free the URB at the right time in devm unwind sequence. Signed-off-by: Dmitry Torokhov ---

[PATCH 3/5] Input: pxrc - move module device table closer to where it is used

2018-07-23 Thread Dmitry Torokhov
There is no need to have the device table first in the file. Signed-off-by: Dmitry Torokhov --- drivers/input/joystick/pxrc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/input/joystick/pxrc.c b/drivers/input/joystick/pxrc.c index

[PATCH 1/5] Input: pxrc - do not store USB device in private struct

2018-07-23 Thread Dmitry Torokhov
From: Marcus Folkesson The USB device is only needed during setup, so put it back after initialization and do not store it in our private struct. Also, the USB device is a parent of USB interface so our driver model rules ensure that USB device should not disappear while interface device is

[PATCH 4/5] Input: pxrc - do not store unneeded data in driver structure

2018-07-23 Thread Dmitry Torokhov
There is no need to store data buffer size, pointer to the buffer, or endpoint address in pxrc structure, as they are either only needed during setup, or are available from elsewhere. Signed-off-by: Dmitry Torokhov --- drivers/input/joystick/pxrc.c | 35 +-- 1

[PATCH 5/5] Input: pxrc - flatten probe code

2018-07-23 Thread Dmitry Torokhov
Instead of splitting probe code into separate USB and input setup, flatten it. This allows for easier inspection of order of set up steps, since the probe code is reasonably small. Move input-related initialization (phys) from USB block to input block. Signed-off-by: Dmitry Torokhov ---

Re: [PATCH 2/3] [BUGFIX] ring_buffer: tracing: Inherit the tracing setting to next ring buffer

2018-07-23 Thread Steven Rostedt
On Sat, 14 Jul 2018 01:28:15 +0900 Masami Hiramatsu wrote: > Inherit the tracing on/off setting on ring_buffer to next > trace buffer when taking a snapshot. > > Taking a snapshot is done by swapping with backup ring buffer > (max_tr_buffer). But since the tracing on/off setting is set > in the

RE: Enquiry on unbalanced memory throughput for dual-Cortex A9 core.

2018-07-23 Thread Ooi, Tzy Way
> -Original Message- > From: Russell King - ARM Linux > Sent: Friday, July 20, 2018 6:36 PM > To: Ooi, Tzy Way > Cc: linux-kernel@vger.kernel.org; See, Chin Liang > ; Tan, Ley Foon ; > Nguyen, Dinh ; Aw, Khai Liang > > Subject: Re: Enquiry on unbalanced memory throughput for dual-Cortex

Re: [PATCH] dt-bindings: remove 'interrupt-parent' from bindings

2018-07-23 Thread Rob Herring
On Mon, Jul 23, 2018 at 5:20 PM Vladimir Zapolskiy wrote: > > Hi Rob, > > On 07/24/2018 01:13 AM, Rob Herring wrote: > > 'interrupt-parent' is often documented as part of define bindings, but > > it is really outside the scope of a device binding. It's never required > > in a given node as it is

Re: [PATCH v2 2/2] clk: qcom: Add qspi (Quad SPI) clocks for sdm845

2018-07-23 Thread Taniya Das
On 7/24/2018 3:24 AM, Douglas Anderson wrote: Add both the interface and core clock. Signed-off-by: Douglas Anderson --- Changes in v2: - Only 19.2, 100, 150, and 300 MHz now. - All clocks come from MAIN rather than EVEN. - Use parent map 0 instead of new parent map 9.

Re: [PATCH v2 2/2] PCI: NVMe device specific reset quirk

2018-07-23 Thread Sinan Kaya
On 7/23/18, Alex Williamson wrote: > On Mon, 23 Jul 2018 17:40:02 -0700 > Sinan Kaya wrote: > >> On 7/23/2018 5:13 PM, Alex Williamson wrote: >> > + * The NVMe specification requires that controllers support PCIe FLR, >> > but >> > + * but some Samsung SM961/PM961 controllers fail to recover

[PATCH] init/Kconfig: fix its typos

2018-07-23 Thread Randy Dunlap
From: Randy Dunlap Correct typos of "it's" to "its. Signed-off-by: Randy Dunlap Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Masahiro Yamada Cc: Andrew Morton --- init/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-next-20180723.orig/init/Kconfig

Re: [PATCH 6/7] x86/vdso: Add vDSO functions for user wait instructions

2018-07-23 Thread Andy Lutomirski
On 07/23/2018 05:55 AM, Fenghua Yu wrote: User wants to query if user wait instructions (umonitor, umwait, and tpause) are supported and use the instructions. The vDSO functions provides fast interface for user to check the support and use the instructions. waitpkg_supported and its alias

Re: [PATCH 1/3] [BUGFIX] tracing: Fix double free of event_trigger_data

2018-07-23 Thread Steven Rostedt
On Sat, 14 Jul 2018 01:27:47 +0900 Masami Hiramatsu wrote: > Fix a double free bug of event_trigger_data caused by > calling unregister_trigger() from register_snapshot_trigger(). > This kicks a kernel BUG if double free checker is enabled > as below; > > kernel BUG at

Re: [PATCH] tpm: add support for partial reads

2018-07-23 Thread Jason Gunthorpe
On Mon, Jul 23, 2018 at 04:42:38PM -0700, Tadeusz Struk wrote: > On 07/23/2018 03:08 PM, Jason Gunthorpe wrote: > > On Mon, Jul 23, 2018 at 03:00:20PM -0700, Tadeusz Struk wrote: > >> On 07/23/2018 02:56 PM, Jason Gunthorpe wrote: > >>> The proposed patch doesn't clear the data_pending if the

Re: [PATCH 2/2 v2] Add support for CPCAP regulators on Tegra devices.

2018-07-23 Thread Peter Geis
On 07/23/2018 08:27 PM, Dmitry Osipenko wrote: On Monday, 23 July 2018 22:38:48 MSK Peter Geis wrote: Added support for the CPCAP power management regulator functions on Tegra devices. Added sw2_sw4 value tables, which provide power to the Tegra core and aux devices. Added the Tegra init

Re: [PATCH v2 2/2] PCI: NVMe device specific reset quirk

2018-07-23 Thread Alex Williamson
On Mon, 23 Jul 2018 17:40:02 -0700 Sinan Kaya wrote: > On 7/23/2018 5:13 PM, Alex Williamson wrote: > > + * The NVMe specification requires that controllers support PCIe FLR, but > > + * but some Samsung SM961/PM961 controllers fail to recover after FLR (-1 > > + * config space) unless the

Re: [PATCH 3/3] microblaze: add endianness options to LDFLAGS instead of LD

2018-07-23 Thread Masahiro Yamada
Hi Michal, Ping? 2018-07-03 10:22 GMT+09:00 Masahiro Yamada : > With the recent syntax extension, Kconfig is now able to evaluate the > compiler / toolchain capability. > > However, accumulating flags to 'LD' is not compatible with the way > it works; 'LD' must be passed to Kconfig to call

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

2018-07-23 Thread NeilBrown
On Tue, Jul 24 2018, Boris Brezillon wrote: > On Tue, 24 Jul 2018 08:46:33 +1000 > NeilBrown wrote: > >> On Mon, Jul 23 2018, Brian Norris wrote: >> >> > Hi Boris, >> > >> > On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon >> > wrote: >> >> On Mon, 23 Jul 2018 11:13:50 -0700 >> >> Brian

Re: m68k allmodconfig build errors

2018-07-23 Thread Randy Dunlap
On 07/20/2018 12:20 AM, Andreas Schwab wrote: > On Jul 19 2018, Randy Dunlap wrote: > >> block/partitions/ldm.o: In function `ldm_partition': >> ldm.c:(.text+0x1900): undefined reference to `strcmp' >> ldm.c:(.text+0x1964): undefined reference to `strcmp' >> drivers/rtc/rtc-proc.o: In function

Re: m68k allmodconfig build errors

2018-07-23 Thread Randy Dunlap
On 07/19/2018 10:17 PM, Finn Thain wrote: > On Thu, 19 Jul 2018, Randy Dunlap wrote: > >> Hi Geert, >> >> I am seeing a few errors when cross-building m68k on x86_64, using the >> toolchain at https://mirrors.edge.kernel.org/pub/tools/crosstool/ >> (thanks, Arnd). (so this is gcc 8.1.0) >> >>

Re: [PATCH 5/7] x86/vdso: Add vDSO functions for direct store instructions

2018-07-23 Thread Andy Lutomirski
On 07/23/2018 05:55 AM, Fenghua Yu wrote: User wants to query if direct store instructions are supported and use the instructions. The vDSO functions provides fast interface for user to query the support and use the instructions. movdiri_supported and its alias __vdso_movdiri_supported check if

Re: [PATCH v2] perf/core: fix a possible deadlock scenario

2018-07-23 Thread Cong Wang
On Mon, Jul 23, 2018 at 6:35 PM Cong Wang wrote: > > Hi, Peter, Andi > > While reviewing the deadlock, I find out it looks like we could have the > following infinite recursion too: > > perf_event_account_interrupt() > __perf_event_account_interrupt() > perf_adjust_period() > event->pmu->stop >

Re: [PATCH 4/7] x86/umwait_contro: Set global umwait maximum time limit and umwait C0.2 state

2018-07-23 Thread Andy Lutomirski
On 07/23/2018 05:55 AM, Fenghua Yu wrote: UMWAIT or TPAUSE called by user process makes processor to reside in a light-weight power/performance optimized state (C0.1 state) or an improved power/performance optimized state (C0.2 state). IA32_UMWAIT_CONTROL MSR register allows OS to set global

Re: [PATCH v2] perf/core: fix a possible deadlock scenario

2018-07-23 Thread Cong Wang
Hi, Peter, Andi While reviewing the deadlock, I find out it looks like we could have the following infinite recursion too: perf_event_account_interrupt() __perf_event_account_interrupt() perf_adjust_period() event->pmu->stop x86_pmu_stop() x86_pmu.disable() intel_pmu_disable_event()

Re: [PATCH] stop_machine: Disable preemption after queueing stopper threads

2018-07-23 Thread isaacm
Hi all, Are there any comments about this patch? Thanks, Isaac Manjarres On 2018-07-17 12:35, Isaac J. Manjarres wrote: This commit: 9fb8d5dc4b64 ("stop_machine, Disable preemption when waking two stopper threads") does not fully address the race condition that can occur as follows: On one

Re: [PATCH] sched/numa: do not balance tasks onto isolated cpus

2018-07-23 Thread jiang.biao2
> > On Mon, Jul 23, 2018 at 01:39:30PM +0800, Chen Lin wrote: >> From: Chen Lin >> >> NUMA balancing has not taken *isolcpus(isolated cpus)* into >> consideration. It may migrate tasks onto isolated cpus and the >> migrated tasks will never escape from the isolated cpus, which will >> break the

Re: [PATCH v5 1/2] leds: core: Introduce generic pattern interface

2018-07-23 Thread Bjorn Andersson
On Mon 16 Jul 04:10 PDT 2018, Baolin Wang wrote: > From: Bjorn Andersson > > Some LED controllers have support for autonomously controlling > brightness over time, according to some preprogrammed pattern or > function. > > This adds a new optional operator that LED class drivers can implement

Re: Zram writeback feature unstable with heavy swap utilization - BUG: Bad page state in process...

2018-07-23 Thread Minchan Kim
Hi Tino, Thanks for the report. On Mon, Jul 23, 2018 at 02:29:32PM +0200, Tino Lehnig wrote: > Hello, > > after enabling the writeback feature in zram, I encountered the kernel bug > below with heavy swap utilization. There is one specific workload that > triggers the bug reliably and that is

Re: [PATCH v3 1/2] leds: core: Introduce generic pattern interface

2018-07-23 Thread Bjorn Andersson
On Fri 20 Jul 12:11 PDT 2018, Jacek Anaszewski wrote: > Hi David, > > On 07/18/2018 07:00 PM, David Lechner wrote: > > > > > > On 7/18/18 7:08 AM, Pavel Machek wrote: > > > On Wed 2018-07-18 19:32:01, Baolin Wang wrote: > > > > On 18 July 2018 at 15:56, Pavel Machek wrote: > > > > > Hi! > > >

Re: [PATCH] MIPS: jz4740: Bump zload address

2018-07-23 Thread Paul Burton
Hi Paul, On Sun, Jul 08, 2018 at 05:07:12PM +0200, Paul Cercueil wrote: > Having the zload address at 0x8060. means the size of the > uncompressed kernel cannot be bigger than around 6 MiB, as it is > deflated at address 0x8001.. > > This limit is too small; a kernel with some built-in

Re: [PATCH v2 2/2] PCI: NVMe device specific reset quirk

2018-07-23 Thread Sinan Kaya
On 7/23/2018 5:13 PM, Alex Williamson wrote: + * The NVMe specification requires that controllers support PCIe FLR, but + * but some Samsung SM961/PM961 controllers fail to recover after FLR (-1 + * config space) unless the device is quiesced prior to FLR. Does disabling the memory bit in PCI

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-23 Thread Ian Kent
On Mon, 2018-07-23 at 09:31 -0700, Casey Schaufler wrote: > On 7/23/2018 8:25 AM, David Howells wrote: > > Hi Al, > > > > Here's a set of patches to add a general variable-length notification queue > > concept and to add sources of events for: > > Overall I approve. The interface is a bit

Re: [PATCH v3 1/2] leds: core: Introduce generic pattern interface

2018-07-23 Thread Bjorn Andersson
On Mon 16 Jul 14:56 PDT 2018, Pavel Machek wrote: > Hi! > > > >>>echo pattern > trigger > > >>>echo "1 2 3 4 5 6 7 8" > somewhere > > >> > > >>s/somewhere/pattern/ > > >> > > >>pattern trigger should create "pattern" file similarly how ledtrig-timer > > >>creates delay_{on|off} files. > > >> > >

Re: [PATCH RFC] debugobjects: Make stack check warning more informative

2018-07-23 Thread Waiman Long
On 07/23/2018 05:25 PM, Joel Fernandes wrote: > From: "Joel Fernandes (Google)" > > Recently we debugged an issue where debugobject tracking was telling > us of an annotation issue. Turns out the issue was due to the object in > concern being on a different stack which was due to another issue. >

Re: [PATCH 2/2 v2] Add support for CPCAP regulators on Tegra devices.

2018-07-23 Thread Dmitry Osipenko
On Monday, 23 July 2018 22:38:48 MSK Peter Geis wrote: > Added support for the CPCAP power management regulator functions on > Tegra devices. > Added sw2_sw4 value tables, which provide power to the Tegra core and > aux devices. > Added the Tegra init tables and device tree compatibility match. >

Re: linux-next: build warning after merge of the arm64 tree

2018-07-23 Thread AKASHI Takahiro
On Tue, Jul 24, 2018 at 09:05:45AM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the arm64 tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: Where can I find this specific branch? > drivers/acpi/Kconfig:6:error: recursive dependency detected! >

Re: [PATCH v2] fs: ceph: Adding new return type vm_fault_t

2018-07-23 Thread Yan, Zheng
> On Jul 24, 2018, at 00:02, Souptick Joarder wrote: > > Use new return type vm_fault_t for page_mkwrite > and fault handler. > > Signed-off-by: Souptick Joarder > Reviewed-by: Matthew Wilcox > --- > v2: Fixed kbuild warning > > fs/ceph/addr.c | 62

Re: [PATCH v3 1/2] leds: core: Introduce generic pattern interface

2018-07-23 Thread Bjorn Andersson
On Sun 15 Jul 18:00 PDT 2018, David Lechner wrote: > On 07/15/2018 07:22 AM, Jacek Anaszewski wrote: > > On 07/15/2018 12:39 AM, Pavel Machek wrote: > > > On Sun 2018-07-15 00:29:25, Pavel Machek wrote: > > > > On Sun 2018-07-15 00:02:57, Jacek Anaszewski wrote: > > > > > Hi Pavel, > > > > > > >

[PATCH v2 2/2] PCI: NVMe device specific reset quirk

2018-07-23 Thread Alex Williamson
Take advantage of NVMe devices using a standard interface to quiesce the controller prior to reset, including device specific delays before and after that reset. This resolves several NVMe device assignment scenarios with two different vendors. The Intel DC P3700 controller has been shown to

[PATCH v2 0/2] PCI: NVMe reset quirk

2018-07-23 Thread Alex Williamson
v2: Add bug link, use Samsung vendor ID, add spec references As discussed in the 2nd patch, at least one NVMe controller sometimes doesn't like being reset while enabled and another will timeout during a subsequent re-enable if it happens too quickly after reset. Introduce a device specific reset

[PATCH v2 1/2] PCI: Export pcie_has_flr()

2018-07-23 Thread Alex Williamson
pcie_flr() suggests pcie_has_flr() to ensure that PCIe FLR support is present prior to calling. pcie_flr() is exported while pcie_has_flr() is not. Resolve this. Signed-off-by: Alex Williamson --- drivers/pci/pci.c |3 ++- include/linux/pci.h |1 + 2 files changed, 3 insertions(+),

  1   2   3   4   5   6   7   8   9   10   >