Re: [PATCH v4 2/2] x86/speculation: Enable cross-hyperthread spectre v2 STIBP mitigation

2018-09-07 Thread Thomas Gleixner
On Fri, 7 Sep 2018, Jiri Kosina wrote: > On Fri, 7 Sep 2018, Thomas Gleixner wrote: > > > > + * The read-modify-write of the MSR doesn't need any race protection > > > here, > > > + * as we're running in atomic context. > > > + */ > > > +static void enable_stibp(void *info) > > > +{ > > > + u64

[PATCH] dma: idma64: replace spin_lock_irqsave with spin_lock

2018-09-07 Thread Zhaoxiong Yuan
idma64_chan_irq() is invoked in hardirq handle function, it is unnecessary to call spin_lock_irqsave. Signed-off-by: Zhaoxiong Yuan --- drivers/dma/idma64.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/dma/idma64.c b/drivers/dma/idma64.c index 1fbf9cb..5b9c156

Re: [PATCH v2 3/3] x86/pti/64: Remove the SYSCALL64 entry trampoline

2018-09-07 Thread Thomas Gleixner
On Fri, 7 Sep 2018, Andy Lutomirski wrote: > On Fri, Sep 7, 2018 at 5:04 PM, Linus Torvalds > wrote: > > Virtual mapping tricks may be cool, but in the end, not having to use > > them is better still, I think. > > > > If (and this is a *big* if) all the percpu data is within 2GB of the > entry te

Re: [PATCH v2 3/3] x86/pti/64: Remove the SYSCALL64 entry trampoline

2018-09-07 Thread Thomas Gleixner
On Fri, 7 Sep 2018, Linus Torvalds wrote: > On Fri, Sep 7, 2018 at 12:54 PM Thomas Gleixner wrote: > > > > > - We execute from an extra page and read from another extra page > > > during the syscall. (The latter is because we need to use a relative > > > addressing mode to find sp1 -- it's the s

Re: [PATCH 3.18 00/29] 3.18.122-stable review

2018-09-07 Thread Harsh 'Shandilya
On 8 September 2018 2:40:21 AM IST, Greg Kroah-Hartman wrote: >This is the start of the stable review cycle for the 3.18.122 release. >There are 29 patches in this series, all will be posted as a response >to this one. If anyone has any issues with these being applied, please >let me know. > >Re

Re: [PATCH v8 1/2] leds: core: Introduce LED pattern trigger

2018-09-07 Thread Bjorn Andersson
On Tue 04 Sep 04:01 PDT 2018, Baolin Wang wrote: > diff --git a/Documentation/ABI/testing/sysfs-class-led-trigger-pattern > b/Documentation/ABI/testing/sysfs-class-led-trigger-pattern [..] > +What:/sys/class/leds//hw_pattern > +Date:September 2018 > +KernelVersion:

[PATCH v2] asm-generic: bug: unify hints for BUG_ON()

2018-09-07 Thread Igor Stoppa
If BUG_ON() is used instead of BUG(), it means that probably the preferred outcome is to not BUG(), therefore the condition tested should be unlikely(). However, when CONFIG_PROFILE_ANNOTATED_BRANCHES is enabled, the hint is disabled, to avoid generating false-positive warnings caused by -Wmaybe-u

Re: [PATCH v2 3/3] x86/pti/64: Remove the SYSCALL64 entry trampoline

2018-09-07 Thread Andy Lutomirski
On Fri, Sep 7, 2018 at 9:40 AM, Josh Poimboeuf wrote: > On Mon, Sep 03, 2018 at 03:59:44PM -0700, Andy Lutomirski wrote: >> The SYSCALL64 trampoline has a couple of nice properties: >> >> - The usual sequence of SWAPGS followed by two GS-relative accesses to >>set up RSP is somewhat slow beca

Re: [PATCH v2 3/3] x86/pti/64: Remove the SYSCALL64 entry trampoline

2018-09-07 Thread Andy Lutomirski
On Fri, Sep 7, 2018 at 5:04 PM, Linus Torvalds wrote: > On Fri, Sep 7, 2018 at 12:54 PM Thomas Gleixner wrote: >> >> > - We execute from an extra page and read from another extra page >> > during the syscall. (The latter is because we need to use a relative >> > addressing mode to find sp1 -- i

Re: [PATCH] asm-generic: bug: add unlikely() to BUG_ON()

2018-09-07 Thread Igor Stoppa
On 07/09/18 23:41, Arnd Bergmann wrote: Could you add a comment about -Wmaybe-uninitialized next to the definition? Otherwise that is easily lost. Also, I see that the file has two separate definitions of BUG_ON(), and the other one does have an unlikely() in it already. Can you change both

Re: Plumbers 2018 - Performance and Scalability Microconference

2018-09-07 Thread John Hubbard
On 9/4/18 2:28 PM, Daniel Jordan wrote: > Pavel Tatashin, Ying Huang, and I are excited to be organizing a performance > and scalability microconference this year at Plumbers[*], which is happening > in Vancouver this year.  The microconference is scheduled for the morning of > the second day (W

Re: linux-next: build warnings from the build of Linus' tree

2018-09-07 Thread Masami Hiramatsu
On Fri, 7 Sep 2018 14:50:59 +0200 Peter Oberparleiter wrote: > On 06.09.2018 18:42, Masami Hiramatsu wrote: > > Peter Oberparleiter wrote: > >> I've attached a quick fix that should address both problems. I'd > >> appreciate if this patch could get some testing before I post proper fix > >> patc

Re: [PATCH V3 06/26] csky: Cache and TLB routines

2018-09-07 Thread Guo Ren
On Fri, Sep 07, 2018 at 04:13:35PM +0200, Arnd Bergmann wrote: > On Fri, Sep 7, 2018 at 2:55 PM Guo Ren wrote: > > > > On Fri, Sep 07, 2018 at 10:14:38AM +0200, Arnd Bergmann wrote: > > > On Fri, Sep 7, 2018 at 5:04 AM Guo Ren wrote: > > > > On Thu, Sep 06, 2018 at 04:31:16PM +0200, Arnd Bergmann

[Patch v3 02/16] CIFS: Use offset when reading pages

2018-09-07 Thread Long Li
From: Long Li With offset defined in rdata, transport functions need to look at this offset when reading data into the correct places in pages. Signed-off-by: Long Li --- fs/cifs/cifsproto.h | 4 +++- fs/cifs/cifssmb.c | 1 + fs/cifs/connect.c | 5 +++-- fs/cifs/file.c | 52 +++

[Patch v3 05/16] CIFS: Calculate the correct request length based on page offset and tail size

2018-09-07 Thread Long Li
From: Long Li It's possible that the page offset is non-zero in the pages in a request, change the function to calculate the correct data buffer length. Signed-off-by: Long Li --- fs/cifs/transport.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/fs/c

[Patch v3 03/16] CIFS: Add support for direct pages in wdata

2018-09-07 Thread Long Li
From: Long Li Add a function to allocate wdata without allocating pages for data transfer. This gives the caller an option to pass a number of pages that point to the data buffer to write to. wdata is reponsible for free those pages after it's done. Signed-off-by: Long Li --- fs/cifs/cifsglob

[Patch v3 16/16] CIFS: Add direct I/O functions to file_operations

2018-09-07 Thread Long Li
From: Long Li With direct read/write functions implemented, add them to file_operations. Dircet I/O is used under two conditions: 1. When mounting with "cache=none", CIFS uses direct I/O for all user file data transfer. 2. When opening a file with O_DIRECT, CIFS uses direct I/O for all data tran

[Patch v3 04/16] CIFS: pass page offset when issuing SMB write

2018-09-07 Thread Long Li
From: Long Li When issuing SMB writes, pass along the write data page offset to transport. Signed-off-by: Long Li --- fs/cifs/cifssmb.c | 1 + fs/cifs/smb2pdu.c | 1 + 2 files changed, 2 insertions(+) diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index 503e0ed..0a57c61 100644 --- a/fs/ci

[Patch v3 08/16] CIFS: SMBD: Support page offset in RDMA send

2018-09-07 Thread Long Li
From: Long Li The RDMA send function needs to look at offset in the request pages, and send data starting from there. Signed-off-by: Long Li --- fs/cifs/smbdirect.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/fs/cifs/smbdirect.c b/fs/cifs/sm

[Patch v3 14/16] CIFS: Add support for direct I/O read

2018-09-07 Thread Long Li
From: Long Li With direct I/O read, we transfer the data directly from transport layer to the user data buffer. Change in v3: added support for kernel AIO Signed-off-by: Long Li --- fs/cifs/cifsfs.h | 1 + fs/cifs/cifsglob.h | 5 ++ fs/cifs/file.c | 209 +

[Patch v3 12/16] CIFS: Pass page offset for calculating signature

2018-09-07 Thread Long Li
From: Long Li When calculating signature for the packet, it needs to read into the correct page offset for the data. Signed-off-by: Long Li --- fs/cifs/cifsencrypt.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c index

[Patch v3 13/16] CIFS: Pass page offset for encrypting

2018-09-07 Thread Long Li
From: Long Li Encryption function needs to read data starting page offset from input buffer. This doesn't affect decryption path since it allocates its own page buffers. Signed-off-by: Long Li --- fs/cifs/smb2ops.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) d

[Patch v3 01/16] CIFS: Add support for direct pages in rdata

2018-09-07 Thread Long Li
From: Long Li Add a function to allocate rdata without allocating pages for data transfer. This gives the caller an option to pass a number of pages that point to the data buffer. rdata is reponsible for free those pages after it's done. Signed-off-by: Long Li --- fs/cifs/cifsglob.h | 3 +--

[Patch v3 09/16] CIFS: SMBD: Support page offset in RDMA recv

2018-09-07 Thread Long Li
From: Long Li RDMA recv function needs to place data to the correct place starting at page offset. Signed-off-by: Long Li --- fs/cifs/smbdirect.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/fs/cifs/smbdirect.c b/fs/cifs/smbdirect.c index 6141e3c..ba5

[Patch v3 07/16] CIFS: When sending data on socket, pass the correct page offset

2018-09-07 Thread Long Li
From: Long Li It's possible that the offset is non-zero in the page to send, change the function to pass this offset to socket. Signed-off-by: Long Li --- fs/cifs/transport.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/fs/cifs/transport.c b/fs/cifs/transp

[Patch v3 10/16] CIFS: SMBD: Do not call ib_dereg_mr on invalidated memory registration

2018-09-07 Thread Long Li
From: Long Li It is not necessary to deregister a memory registration after it has been successfully invalidated. Signed-off-by: Long Li --- fs/cifs/smbdirect.c | 82 ++--- 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/fs/cifs/s

[Patch v3 06/16] CIFS: Introduce helper function to get page offset and length in smb_rqst

2018-09-07 Thread Long Li
From: Long Li Introduce a function rqst_page_get_length to return the page offset and length for a given page in smb_rqst. This function is to be used by following patches. Signed-off-by: Long Li --- fs/cifs/cifsproto.h | 3 +++ fs/cifs/misc.c | 17 + 2 files changed, 20

[Patch v3 00/16] CIFS: add support for direct I/O

2018-09-07 Thread Long Li
From: Long Li This patch set implements direct I/O. In normal code path (even with cache=none), CIFS copies I/O data from user-space to kernel-space for security reasons of possible protocol required signing and encryption on user data. With this patch set, CIFS passes the I/O data directly fro

[Patch v3 11/16] CIFS: SMBD: Support page offset in memory registration

2018-09-07 Thread Long Li
From: Long Li Change code to pass the correct page offset during memory registration for RDMA read/write. Signed-off-by: Long Li --- fs/cifs/smb2pdu.c | 18 -- fs/cifs/smbdirect.c | 29 + fs/cifs/smbdirect.h | 2 +- 3 files changed, 34 insertions(

[Patch v3 15/16] CIFS: Add support for direct I/O write

2018-09-07 Thread Long Li
From: Long Li With direct I/O write, user supplied buffers are pinned to the memory and data are transferred directly from user buffers to the transport layer. Change in v3: added support for kernel AIO Signed-off-by: Long Li --- fs/cifs/cifsfs.h | 1 + fs/cifs/file.c | 195 ++

Re: [PATCH V3 21/26] dt-bindings: interrupt-controller: C-SKY APB intc

2018-09-07 Thread Guo Ren
On Fri, Sep 07, 2018 at 10:13:13AM -0500, Rob Herring wrote: > On Thu, Sep 6, 2018 at 8:05 AM Arnd Bergmann wrote: > > > > On Thu, Sep 6, 2018 at 4:13 AM Guo Ren wrote: > > > > > > On Wed, Sep 05, 2018 at 07:43:10PM -0500, Rob Herring wrote: > > > > On Wed, Sep 5, 2018 at 7:10 AM Guo Ren wrote:

Re: [PATCH] Input: reserve 2 events code because of HID

2018-09-07 Thread Peter Hutterer
On Fri, Sep 07, 2018 at 10:51:15AM +0200, Benjamin Tissoires wrote: > From: Benjamin Tissoires > > Prior to commit 190d7f02ce8e ("HID: input: do not increment usages when > a duplicate is found") from the v4.18 kernel, HID used to shift the > event codes if a duplicate usage was found. This ended

RE: [PATCH v2 6/8] perf/x86/intel/lbr: guest requesting KVM for lbr stack save/restore

2018-09-07 Thread Wang, Wei W
On Saturday, September 8, 2018 4:05 AM, Andi Kleen wrote: > > How would you realize the function of saving/restoring the lbr stack on the > host? > > > > Here, we create a perf event on the host (please see > guest_lbr_event_create on patch 7), which essentially satisfies all the > conditions (e.g.

Re: [RFC][PATCH 7/8] x86/mm/vsyscall: consider vsyscall page part of user address space

2018-09-07 Thread Jann Horn
On Sat, Sep 8, 2018 at 2:28 AM Dave Hansen wrote: > The vsyscall page is weird. It is in what is traditionally part of the > kernel address space. But, it has user permissions and we handle faults > on it like we would on a user page: interrupts on. > > Right now, we handle vsyscall emulation in

Re: [RFC][PATCH 6/8] x86/mm: add vsyscall address helper

2018-09-07 Thread Jann Horn
On Sat, Sep 8, 2018 at 2:25 AM Dave Hansen wrote: > We will shortly be using this check in two locations. Put it in > a helper before we do so. [...] > +/* > + * The (legacy) vsyscall page is the long page in the kernel portion > + * of the address space that has user-accessible permissions. > +

Re: [RFC][PATCH 5/8] x86/mm: fix exception table comments

2018-09-07 Thread Jann Horn
On Sat, Sep 8, 2018 at 2:22 AM Dave Hansen wrote: > +* Kernel-mode access to the user address space should only occur > +* inside well-defined areas of code listed in the exception Actually, not areas, but single whitelisted instructions. It would probably be nice to say that more

Re: [PATCH RFC LKMM 1/7] tools/memory-model: Add extra ordering for locks and remove it for ordinary release/acquire

2018-09-07 Thread Daniel Lustig
On 9/7/2018 10:38 AM, Alan Stern wrote: > On Fri, 7 Sep 2018, Daniel Lustig wrote: > >> On 9/7/2018 9:09 AM, Will Deacon wrote: >>> On Fri, Sep 07, 2018 at 12:00:19PM -0400, Alan Stern wrote: On Thu, 6 Sep 2018, Andrea Parri wrote: >> Have you noticed any part of the generic code tha

Re: [PATCH v2 3/3] x86/pti/64: Remove the SYSCALL64 entry trampoline

2018-09-07 Thread Linus Torvalds
On Fri, Sep 7, 2018 at 12:54 PM Thomas Gleixner wrote: > > > - We execute from an extra page and read from another extra page > > during the syscall. (The latter is because we need to use a relative > > addressing mode to find sp1 -- it's the same *cacheline* we'd use > > anyway, but we're acces

Re: [PATCH] apparmor: Fix network performance issue in aa_label_sk_perm

2018-09-07 Thread Tony Jones
On 09/07/2018 09:37 AM, John Johansen wrote: > hey Tony, > > thanks for the patch, I am curious did you're investigation look > into what parts of DEFINE_AUDIT_SK are causing the issue? Hi JJ. Attached are the perf annotations for DEFINE_AUDIT_SK (percentages are relative to the fn). Our ke

Re: [Patch] acpi_power_meter: remove 'ignoring unsafe software power cap' message

2018-09-07 Thread Darrick J. Wong
On Fri, Sep 07, 2018 at 10:07:39PM +, Max Asbock wrote: > At boot time the acpi_power_meter driver greets users of non-IBM systems with > the message: > > "Ignoring unsafe software power cap". > > This message is generally interpreted as meaning: The system is > operating under an un

Re: [RFC][PATCH 7/8] x86/mm/vsyscall: consider vsyscall page part of user address space

2018-09-07 Thread Andy Lutomirski
> On Sep 7, 2018, at 12:49 PM, Dave Hansen wrote: > > > From: Dave Hansen > > The vsyscall page is weird. It is in what is traditionally part of the > kernel address space. But, it has user permissions and we handle faults > on it like we would on a user page: interrupts on. > > Right no

[PATCH] afs: Fix cell specification to permit an empty address list

2018-09-07 Thread David Howells
Fix the cell specification mechanism to allow cells to be pre-created without having to specify at least one address (the addresses will be upcalled for). This allows the cell information preload service to avoid the need to issue loads of DNS lookups during boot to get the addresses for each cell

Re: [PATCH 2/2] f2fs: fix to avoid quota inode leak in ->put_super

2018-09-07 Thread Chao Yu
I can see it in dev, thanks for merging. ;) On 2018/9/8 6:38, Jaegeuk Kim wrote: > I merged as one. Please check dev. :) > > On 09/06, Chao Yu wrote: >> generic/019 reports below error: >> >> __quota_error: 1160 callbacks suppressed >> Quota error (device zram1): write_blk: dquota write failed

Re: kselftests for memory.oom.group

2018-09-07 Thread Shuah Khan
On 09/07/2018 03:34 PM, jgka...@fb.com wrote: > Here is the third version of the patchset. > > Changes since the last patchset: > - Updated commit message of first patch to clarify fixes > - Add ack from Roman > > There should be no code changes since the last patchset. > > Let me know if any im

Re: [RFC][PATCH 1/8] x86/mm: clarify hardware vs. software "error_code"

2018-09-07 Thread Andy Lutomirski
> On Sep 7, 2018, at 12:48 PM, Dave Hansen wrote: > > > From: Dave Hansen > > We pass around a variable called "error_code" all around the page > fault code. Sounds simple enough, especially since "error_code" looks > like it exactly matches the values that the hardware gives us on the > s

Re: [PATCH 3.18 00/29] 3.18.122-stable review

2018-09-07 Thread Nathan Chancellor
On Fri, Sep 07, 2018 at 11:10:21PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 3.18.122 release. > There are 29 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me kno

Re: [PATCH 4.4 00/47] 4.4.155-stable review

2018-09-07 Thread Nathan Chancellor
On Fri, Sep 07, 2018 at 11:09:56PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.155 release. > There are 47 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: [RFC][PATCH 2/8] x86/mm: break out kernel address space handling

2018-09-07 Thread Dave Hansen
On 09/07/2018 03:21 PM, Andy Lutomirski wrote: >> +static void >> +do_kern_addr_space_fault(struct pt_regs *regs, unsigned long hw_error_code, >> + unsigned long address) >> +{ > > Can you add a comment above this documenting *when* it’s called? Is > it all faults, !user_mode faults, or

Re: [PATCH 4.14 00/89] 4.14.69-stable review

2018-09-07 Thread Nathan Chancellor
On Fri, Sep 07, 2018 at 11:08:54PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.69 release. > There are 89 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

[PATCH] ring-buffer: Allow for rescheduling when removing pages

2018-09-07 Thread Vaibhav Nagarnaik
When reducing ring buffer size, pages are removed by scheduling a work item on each CPU for the corresponding CPU ring buffer. After the pages are removed from ring buffer linked list, the pages are free()d in a tight loop. The loop does not give up CPU until all pages are removed. In a worst case

Re: [PATCH] arm64: add NUMA emulation support

2018-09-07 Thread Shuah Khan
On 09/07/2018 02:34 AM, Michal Hocko wrote: > On Thu 06-09-18 15:53:34, Shuah Khan wrote: > [...] >> A few critical allocations could be satisfied and root cgroup prevails. It >> is not the >> intent to have exclusivity at the expense of the kernel. > > Well, it is not "few critical allocations".

Re: [RFC][PATCH 2/8] x86/mm: break out kernel address space handling

2018-09-07 Thread Andy Lutomirski
> On Sep 7, 2018, at 12:48 PM, Dave Hansen wrote: > > > From: Dave Hansen > > The page fault handler (__do_page_fault()) basically has two sections: > one for handling faults in the kernel porttion of the address space > and another for faults in the user porttion of the address space. >

[PATCH] include/linux/compiler*.h: add version detection to asm_volatile_goto

2018-09-07 Thread Nick Desaulniers
The comment above asm_volatile_goto mentions working around a GCC bug, and links to a bug report that claims this has been fixed in newer versions of GCC. Testing shows that this was resolved in GCC 4.8.2. asm_volatile_goto should also be defined for other compilers that support asm goto. Signed-

Re: [PATCH 1/2] of/fdt: Allow architectures to override CONFIG_CMDLINE logic

2018-09-07 Thread Rob Herring
On Fri, Sep 7, 2018 at 4:01 PM Paul Burton wrote: > > Hi Rob, > > On Fri, Sep 07, 2018 at 03:29:03PM -0500, Rob Herring wrote: > > On Fri, Sep 7, 2018 at 1:55 PM Paul Burton wrote: > > > The CONFIG_CMDLINE-related logic in early_init_dt_scan_chosen() falls > > > back to copying CONFIG_CMDLINE int

[Patch] acpi_power_meter: remove 'ignoring unsafe software power cap' message

2018-09-07 Thread Max Asbock
At boot time the acpi_power_meter driver greets users of non-IBM systems with the message: "Ignoring unsafe software power cap". This message is generally interpreted as meaning: The system is operating under an unsafe power cap and Linux is ignoring this fact, thus living dangerousl

[PATCH 4.14 11/89] block: really disable runtime-pm for blk-mq

2018-09-07 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Ming Lei commit b233f127042dba991229e3882c6217c80492f6ef upstream. Runtime PM isn't ready for blk-mq yet, and commit 765e40b675a9 ("block: disable runtime-pm for blk-mq") tried to disable it.

[PATCH 4.14 37/89] iio: ad9523: Fix displayed phase

2018-09-07 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Lars-Peter Clausen commit 5a4e33c1c53ae7d4425f7d94e60e4458a37b349e upstream. Fix the displayed phase for the ad9523 driver. Currently the most significant decimal place is dropped and all othe

RE: linux-next: build failure after merge of the net-next tree

2018-09-07 Thread Keller, Jacob E
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Friday, September 07, 2018 10:31 AM > To: Keller, Jacob E > Cc: s...@canb.auug.org.au; net...@vger.kernel.org; linux-n...@vger.kernel.org; > linux-kernel@vger.kernel.org; Kirsher, Jeffrey T > ; > Bowers, Andrew

Re: [PATCH] mips: bug: add unlikely() to BUG_ON()

2018-09-07 Thread Paul Burton
Hi Igor, On Fri, Sep 07, 2018 at 09:03:02PM +0300, Igor Stoppa wrote: > diff --git a/arch/mips/include/asm/bug.h b/arch/mips/include/asm/bug.h > index 745dc160a069..02101b54aec2 100644 > --- a/arch/mips/include/asm/bug.h > +++ b/arch/mips/include/asm/bug.h > @@ -31,7 +31,7 @@ static inline void _

[PATCH 4.14 44/89] rtc: omap: fix potential crash on power off

2018-09-07 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Johan Hovold commit 5c8b84f410b3819d14cb1ebf32e4b3714b5a6e0b upstream. Do not set the system power-off callback and omap power-off rtc pointer until we're done setting up our device to avoid l

[PATCH 4.18 014/145] block: blk_init_allocated_queue() set q->fq as NULL in the fail case

2018-09-07 Thread Greg Kroah-Hartman
4.18-stable review patch. If anyone has any objections, please let me know. -- From: xiao jin commit 54648cf1ec2d7f4b6a71767799c45676a138ca24 upstream. We find the memory use-after-free issue in __blk_drain_queue() on the kernel 4.14. After read the latest kernel 4.18-rc6 we t

[PATCH 4.18 016/145] blkcg: Introduce blkg_root_lookup()

2018-09-07 Thread Greg Kroah-Hartman
4.18-stable review patch. If anyone has any objections, please let me know. -- From: Bart Van Assche commit 6bad9b210a228d2fe0e0efe26d9b115348529cee upstream. This new function will be used in a later patch to verify whether a queue has been dissociated from the cgroup control

[PATCH 4.18 018/145] block: Ensure that a request queue is dissociated from the cgroup controller

2018-09-07 Thread Greg Kroah-Hartman
4.18-stable review patch. If anyone has any objections, please let me know. -- From: Bart Van Assche commit 24ecc3585348b616993a3c4d6dc2c6b8007e358c upstream. Several block drivers call alloc_disk() followed by put_disk() if something fails before device_add_disk() is called w

[PATCH 4.18 015/145] block: really disable runtime-pm for blk-mq

2018-09-07 Thread Greg Kroah-Hartman
4.18-stable review patch. If anyone has any objections, please let me know. -- From: Ming Lei commit b233f127042dba991229e3882c6217c80492f6ef upstream. Runtime PM isn't ready for blk-mq yet, and commit 765e40b675a9 ("block: disable runtime-pm for blk-mq") tried to disable it.

Re: [PATCH 4.9 03/63] 9p/net: Fix zero-copy path in the 9p virtio transport

2018-09-07 Thread Guenter Roeck
On Fri, Sep 7, 2018 at 2:54 PM Guenter Roeck wrote: > > On Fri, Sep 7, 2018 at 2:34 PM Greg Kroah-Hartman > wrote: > > > > 4.9-stable review patch. If anyone has any objections, please let me know. > > > > Do your scripts have a bad hair day ? The subject says 4.18. > Hmm, I suspect it is the gm

Re: [PATCH 4.9 03/63] 9p/net: Fix zero-copy path in the 9p virtio transport

2018-09-07 Thread Guenter Roeck
On Fri, Sep 7, 2018 at 2:34 PM Greg Kroah-Hartman wrote: > > 4.9-stable review patch. If anyone has any objections, please let me know. > Do your scripts have a bad hair day ? The subject says 4.18. Guenter > -- > > From: Chirantan Ekbote > > commit d28c756caee6e414d9ba367d0b9

[RFC 00/60] Coscheduling for Linux

2018-09-07 Thread Jan H . Schönherr
This patch series extends CFS with support for coscheduling. The implementation is versatile enough to cover many different coscheduling use-cases, while at the same time being non-intrusive, so that behavior of legacy workloads does not change. Peter Zijlstra once called coscheduling a "scalabili

[RFC 01/60] sched: Store task_group->se[] pointers as part of cfs_rq

2018-09-07 Thread Jan H . Schönherr
Move around the storage location of the scheduling entity references of task groups. Instead of linking them from the task_group struct, link each SE from the CFS runqueue itself with a new field "my_se". This resembles the "my_q" field that is already available, just in the other direction. Adju

[PATCH 4.4 06/47] drm/i915/userptr: reject zero user_size

2018-09-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Matthew Auld commit c11c7bfd213495784b22ef82a69b6489f8d0092f upstream. Operating on a zero sized GEM userptr object will lead to explosions. Fixes: 5cc9ed4b9a7a ("drm/i915: Introduce mapping o

[RFC 06/60] sched: Add a lock-free variant of resched_cpu()

2018-09-07 Thread Jan H . Schönherr
Add resched_cpu_locked(), which still works as expected, when it is called while we already hold a runqueue lock from a different CPU. There is some optimization potential by merging the logic of resched_curr() and resched_cpu_locked() to avoid IPIs when calls to both functions happen. Signed-off

[PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

2018-09-07 Thread Cedric Roux
The mini2440 computer uses "active high" to signal that the "write protect" of the inserted MMC is set. The current code uses the opposite, leading to a wrong detection of write protection. The solution is simply to use ".wprotect_invert = 1" in the description of the MMC. Signed-off-by: Cedric Ro

Re: [PATCH] r8169: set TxConfig register after TX / RX is enabled, just like RxConfig

2018-09-07 Thread David Miller
From: "Maciej S. Szmigiero" Date: Fri, 7 Sep 2018 20:15:22 +0200 > Commit 3559d81e76bf ("r8169: simplify rtl_hw_start_8169") changed order of > two register writes: > 1) Caused RxConfig to be written before TX / RX is enabled, > 2) Caused TxConfig to be written before TX / RX is enabled. > > At

[RFC 14/60] sched: Refactor sync_throttle() to accept a CFS runqueue as argument

2018-09-07 Thread Jan H . Schönherr
Prepare for future changes and refactor sync_throttle() to work with a different set of arguments. Signed-off-by: Jan H. Schönherr --- kernel/sched/fair.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 5cad364e3a8

[RFC 15/60] sched: Introduce parent_cfs_rq() and use it

2018-09-07 Thread Jan H . Schönherr
Factor out the logic to retrieve the parent CFS runqueue of another CFS runqueue into its own function and replace open-coded variants. Signed-off-by: Jan H. Schönherr --- kernel/sched/fair.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/kernel/sched/fai

[PATCH v3 1/2] ARM: s3c24xx: formatting cleanup in mach-mini2440.c

2018-09-07 Thread Cedric Roux
Running: scripts/checkpatch.pl -f arch/arm/mach-s3c24xx/mach-mini2440.c revealed several errors and warnings. They were all removed, except one which is an #if 0 around the declaration of a gpio pin. This needs some more investigation and I prefer to let it here. This is not some dead code. '

[RFC 26/60] cosched: Construct runqueue hierarchy

2018-09-07 Thread Jan H . Schönherr
With scheduling domains sufficiently prepared, we can now initialize the full hierarchy of runqueues and link it with the already existing bottom level, which we set up earlier. Signed-off-by: Jan H. Schönherr --- kernel/sched/core.c| 1 + kernel/sched/cosched.c | 76 +++

[RFC 22/60] cosched: Add config option for coscheduling support

2018-09-07 Thread Jan H . Schönherr
Scheduled task groups will bring coscheduling to Linux. The actual functionality will be added successively. Signed-off-by: Jan H. Schönherr --- init/Kconfig | 11 +++ kernel/sched/Makefile | 1 + kernel/sched/cosched.c | 9 + 3 files changed, 21 insertions(+) creat

Re: [RFC][PATCH 2/8] x86/mm: break out kernel address space handling

2018-09-07 Thread Dave Hansen
On 09/07/2018 02:06 PM, Sean Christopherson wrote: >> The page fault handler (__do_page_fault())  basically has two sections: >> one for handling faults in the kernel porttion of the address space >> and another for faults in the user porttion of the address space. > %s/porttion/portion Fixed, tha

[PATCH 4.4 40/47] fb: fix lost console when the user unplugs a USB adapter

2018-09-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Mikulas Patocka commit 8c5b044299951acd91e830a688dd920477ea1eda upstream. I have a USB display adapter using the udlfb driver and I use it on an ARM board that doesn't have any graphics card. W

[PATCH 4.4 38/47] ubifs: Fix synced_i_size calculation for xattr inodes

2018-09-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Richard Weinberger commit 59965593205fa4044850d35ee3557cf0b7edcd14 upstream. In ubifs_jnl_update() we sync parent and child inodes to the flash, in case of xattrs, the parent inode (AKA host in

[RFC 30/60] cosched: Disallow share modification on task groups for now

2018-09-07 Thread Jan H . Schönherr
The code path is not yet adjusted for coscheduling. Disable it for now. Signed-off-by: Jan H. Schönherr --- kernel/sched/fair.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 30e5ff30f442..8504790944bf 100644 --- a/kernel/sched/fai

Re: [PATCH net-next] net: dsa: Expose tagging protocol to user-space

2018-09-07 Thread David Miller
From: Florian Fainelli Date: Fri, 7 Sep 2018 11:09:02 -0700 > There is no way for user-space to know what a given DSA network device's > tagging protocol is. Expose this information through a dsa/tagging > attribute which reflects the tagging protocol currently in use. > > This is helpful for c

Re: [RFC][PATCH 5/8] x86/mm: fix exception table comments

2018-09-07 Thread Dave Hansen
>> + * Only do the expensive exception table search when we might be at >> + * risk of a deadlock: >> + * 1. We failed to acquire mmap_sem, and >> + * 2. The access was an explicit kernel-mode access >> + *(X86_PF_USER=0). > > Might be worth reminding the reader that X86_

[RFC 37/60] cosched: Use hrq_of() for (indirect calls to) ___update_load_sum()

2018-09-07 Thread Jan H . Schönherr
The cpu argument supplied to all callers of ___update_load_sum() is used in accumulate_sum() to scale load values according to the CPU capacity. While we should think about that at some point, it is out-of-scope for now. Also, it does not matter on homogeneous system topologies. Update all callers

[PATCH 4.4 44/47] perf auxtrace: Fix queue resize

2018-09-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Adrian Hunter commit 99cbbe56eb8bede625f410ab62ba34673ffa7d21 upstream. When the number of queues grows beyond 32, the array of queues is resized but not all members were being copied. Fix by a

[RFC 39/60] cosched: Adjust task group management for hierarchical runqueues

2018-09-07 Thread Jan H . Schönherr
Provide variants of the task group CFS traversal constructs that also reach the hierarchical runqueues. Adjust task group management functions where necessary. The most changes are in alloc_fair_sched_group(), where we now need to be a bit more careful during initialization. Signed-off-by: Jan H.

[RFC 34/60] cosched: Add rq_of() variants for different use cases

2018-09-07 Thread Jan H . Schönherr
The rq_of() function is used everywhere. With the introduction of hierarchical runqueues, we could modify rq_of() to return the corresponding queue. In fact, no change would be necessary for that. However, many code paths do not handle a hierarchical runqueue adequately. Thus, we introduce variant

[PATCH 4.4 42/47] getxattr: use correct xattr length

2018-09-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Christian Brauner commit 82c9a927bc5df6e06b72d206d24a9d10cced4eb5 upstream. When running in a container with a user namespace, if you call getxattr with name = "system.posix_acl_access" and siz

[RFC 45/60] cosched: Continue to account all load on per-CPU runqueues

2018-09-07 Thread Jan H . Schönherr
Even with coscheduling, we define the fields rq->nr_running and rq->load of per-CPU runqueues to represent the total amount of tasks and the total amount of load on that CPU, respectively, so that existing code continues to work as expected. Make sure to still account load changes on per-CPU runqu

[RFC 43/60] cosched: Add for_each_sched_entity() variant for owned entities

2018-09-07 Thread Jan H . Schönherr
Add a new loop constuct for_each_owned_sched_entity(), which iterates over all owned scheduling entities, stopping when it encounters a leader change. This allows relatively straight-forward adaptations of existing code, where the leader only handles that part of the hierarchy it actually owns. I

[RFC 49/60] cosched: Adjust locking for enqueuing and dequeueing

2018-09-07 Thread Jan H . Schönherr
Enqueuing and dequeuing of tasks (or entities) are a general activities that span across leader boundaries. They start from the bottom of the runqueue hierarchy and bubble upwards, until they hit their terminating condition (for example, enqueuing stops when the parent entity is already enqueued).

RE: [PATCH v3 1/2] net: ethernet: i40e: fix build error

2018-09-07 Thread Keller, Jacob E
> -Original Message- > From: Wang, Dongsheng [mailto:dongsheng.w...@hxt-semitech.com] > Sent: Friday, September 07, 2018 5:41 AM > To: Kirsher, Jeffrey T ; > sergei.shtyl...@cogentembedded.com > Cc: Keller, Jacob E ; da...@davemloft.net; intel- > wired-...@lists.osuosl.org; net...@vger.k

[RFC 50/60] cosched: Propagate load changes across hierarchy levels

2018-09-07 Thread Jan H . Schönherr
The weight of an SD-SE is defined to be the average weight of all runqueues that are represented by the SD-SE. Hence, its weight should change whenever one of the child runqueues changes its weight. However, as these are two different hierarchy levels, they are protected by different locks. To redu

[RFC 47/60] cosched: Adjust SE traversal and locking for common leader activities

2018-09-07 Thread Jan H . Schönherr
Modify some of the core scheduler paths, which function as entry points into the CFS scheduling class and which are activities where the leader operates on behalf of the group. There are (a) handling the tick, (b) picking the next task from the runqueue, (c) setting a task to be current, and (d) p

[RFC 51/60] cosched: Hacky work-around to avoid observing zero weight SD-SE

2018-09-07 Thread Jan H . Schönherr
The aggregated SD-SE weight is updated lock-free to avoid contention on the higher level. This also means, that we have to be careful with intermediate values as another CPU could pick up the value and perform actions based on it. Within reweight_entity() there is such a place, where weight is rem

[RFC 16/60] sched: Preparatory code movement

2018-09-07 Thread Jan H . Schönherr
Move struct rq_flags around to keep future commits crisp. Signed-off-by: Jan H. Schönherr --- kernel/sched/sched.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index b8c8dfd0e88d..cd3a32ce8fc6 100644

[RFC 24/60] cosched: Do minimal pre-SMP coscheduler initialization

2018-09-07 Thread Jan H . Schönherr
The scheduler is operational before we have the necessary information about scheduling domains, which would allow us to set up the runqueue hierarchy. Because of that, we have to postpone the "real" initialization a bit. We cannot not totally skip all initialization, though, because all the adapted

[RFC 38/60] cosched: Skip updates on non-CPU runqueues in cfs_rq_util_change()

2018-09-07 Thread Jan H . Schönherr
The function cfs_rq_util_change() notifies frequency governors of utilization changes, so that they can be scheduler driven. This is coupled to per CPU runqueue statistics. So, don't do anything when called for non-CPU runqueues. Signed-off-by: Jan H. Schönherr --- kernel/sched/fair.c | 11 +

[PATCH 3.18 20/29] userns; Correct the comment in map_write

2018-09-07 Thread Greg Kroah-Hartman
3.18-stable review patch. If anyone has any objections, please let me know. -- From: Eric W. Biederman commit 36476beac4f8ca9dc7722790b2e8ef0e8e51034e upstream. It is important that all maps are less than PAGE_SIZE or else setting the last byte of the buffer to '0' could write

[RFC 11/60] locking/lockdep: Increase number of supported lockdep subclasses

2018-09-07 Thread Jan H . Schönherr
With coscheduling the number of required classes is twice the depth of the scheduling domain hierarchy. For a 256 CPU system, there are eight levels at most. Adjust the number of subclasses, so that lockdep can still be used on such systems. Signed-off-by: Jan H. Schönherr --- include/linux/lock

  1   2   3   4   5   6   7   8   9   10   >