[PATCH v2] perf annotate/report: Remove hist__account_cycles from callback

2019-03-14 Thread Jin Yao
The hist__account_cycles is executed when the hist_iter__branch_callback is called. But it looks it's not necessary. In hist__account_cycles, it already walks on all branch entries. This patch moves the hist__account_cycles out of callback, now the data processing is much faster than before.

Re: [PATCH] scripts/spelling.txt: add more typos to spelling.txt and sort

2019-03-14 Thread Like Xu
On 2019/3/15 11:07, Finn Thain wrote: Does it makes sense to list every typo that is simply a transposition of characters or a character omitted? This file will become very large very quickly if we do that. We are consistent in one thing: typo hurt eyes. Those typos are exactly generated

Re: [PATCH] tty: 8250: fix a missing check for pci_ioremap_bar

2019-03-14 Thread Jiri Slaby
On 15. 03. 19, 5:56, Kangjie Lu wrote: > pci_ioremap_bar could fail. The fix captures the failure and > pass an error code upstream. This can avoid potential NULL > pointer dereferences in the future. > > Signed-off-by: Kangjie Lu > --- > drivers/tty/serial/8250/8250_lpss.c | 13 - >

Re: [PATCH] greybus: audio_manager: fix a missing check of ida_simple_get

2019-03-14 Thread Vaibhav Agarwal
On Thu, Mar 14, 2019 at 12:15 PM Kangjie Lu wrote: > > ida_simple_get could fail. The fix inserts a check for its > return value. > > Signed-off-by: Kangjie Lu > --- > drivers/staging/greybus/audio_manager.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [PATCH 5/5] ocxl: Remove some unused exported symbols

2019-03-14 Thread Andrew Donnellan
On 15/3/19 3:49 pm, Andrew Donnellan wrote: On 13/3/19 3:07 pm, Alastair D'Silva wrote: From: Alastair D'Silva Remove some unused exported symbols. Signed-off-by: Alastair D'Silva See comments on v1 Also a couple of sparse warnings at

[PATCH] pci: endpoint: fix a potential NULL pointer dereference

2019-03-14 Thread Kangjie Lu
In case alloc_workqueue, the fix returns -ENOMEM to avoid potential NULL pointer dereferences. Signed-off-by: Kangjie Lu --- drivers/pci/endpoint/functions/pci-epf-test.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c

[PATCH] tty: 8250: fix a missing check for pci_ioremap_bar

2019-03-14 Thread Kangjie Lu
pci_ioremap_bar could fail. The fix captures the failure and pass an error code upstream. This can avoid potential NULL pointer dereferences in the future. Signed-off-by: Kangjie Lu --- drivers/tty/serial/8250/8250_lpss.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff

tty: uartlite: GP fault when calling tty_unregister_driver()

2019-03-14 Thread Randy Dunlap
This is on v5.0-11053-gebc551f2b8f9 on x86_64. (March 12, 2019) Just load uartlite module and then unload it. [ 75.334373] calling ulite_init+0x0/0x1000 [uartlite] @ 1655 [ 75.334634] initcall ulite_init+0x0/0x1000 [uartlite] returned 0 after 223 usecs [ 80.145544] kasan:

Re: [PATCH 5/5] ocxl: Remove some unused exported symbols

2019-03-14 Thread Andrew Donnellan
On 13/3/19 3:07 pm, Alastair D'Silva wrote: From: Alastair D'Silva Remove some unused exported symbols. Signed-off-by: Alastair D'Silva See comments on v1 --- drivers/misc/ocxl/config.c| 2 -- drivers/misc/ocxl/ocxl_internal.h | 23 +++

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-14 Thread Daniel Colascione
On Thu, Mar 14, 2019 at 8:16 PM Steven Rostedt wrote: > > On Thu, 14 Mar 2019 13:49:11 -0700 > Sultan Alsawaf wrote: > > > Perhaps I'm missing something, but if you want to know when a process has > > died > > after sending a SIGKILL to it, then why not just make the SIGKILL optionally > >

Re: [PATCH 4/5] lib/list_sort: Simplify and remove MAX_LIST_LENGTH_BITS

2019-03-14 Thread George Spelvin
On Thu, 14 Mar 2019 at 11:10:41 +0200, Andy Shevchenko wrote: > On Tue, Mar 05, 2019 at 03:06:44AM +, George Spelvin wrote: >> +for (bit = 1; count & bit; bit <<= 1) { >> +cur = merge(priv, (cmp_func)cmp, pending, cur); >> +pending =

Re: [PATCH] perf annotate: Remove hist__account_cycles from callback

2019-03-14 Thread Jin, Yao
On 3/14/2019 10:17 PM, Jin, Yao wrote: On 3/14/2019 8:04 PM, Jiri Olsa wrote: On Wed, Mar 13, 2019 at 04:22:54AM +0800, Jin Yao wrote: The hist__account_cycles is executed when the hist_iter__branch_callback is called. But it looks it's not necessary. In hist__account_cycles, it already

[PATCH] security: inode: fix a missing check for securityfs_create_file

2019-03-14 Thread Kangjie Lu
securityfs_create_file may fail. The fix checks its status and returns EFAULT upstream if it fails. Signed-off-by: Kangjie Lu --- security/inode.c | 5 + 1 file changed, 5 insertions(+) diff --git a/security/inode.c b/security/inode.c index b7772a9b315e..11d9a6bc2161 100644 ---

[PATCH] sound: sb8: add a check for request_region

2019-03-14 Thread Kangjie Lu
In case request_region fails, the fix returns an error code to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu --- sound/isa/sb/sb8.c | 4 1 file changed, 4 insertions(+) diff --git a/sound/isa/sb/sb8.c b/sound/isa/sb/sb8.c index aa2a83eb81a9..dc27a480c2d9 100644 ---

[PATCH] sound: echoaudio: add a check for ioremap_nocache

2019-03-14 Thread Kangjie Lu
In case ioremap_nocache fails, the fix releases chip and returns an error code upstream to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu --- sound/pci/echoaudio/echoaudio.c | 5 + 1 file changed, 5 insertions(+) diff --git a/sound/pci/echoaudio/echoaudio.c

[PATCH] futex:fix robust futex alignment exception

2019-03-14 Thread chenjie6
From: chen jie trinity test bug fix: /tmp/trinity --children 4 --quiet -N 1000 --logging=off -X -x perf_event_open --enable-fds=testfile [1542.195981] Task track: trinity-c3(6911)>trinity-main(28313)>sh(839)>bash(824)>sshd(820)>sshd(662)>init(1) [11542.214694] Alignment trap: not handling

[PATCH] sound: cs43130: fix a NULL pointer dereference

2019-03-14 Thread Kangjie Lu
In case create_singlethread_workqueue fails, the fix returns -ENOMEM to avoid potential NULL pointer dereference. Signed-off-by: Kangjie Lu --- sound/soc/codecs/cs43130.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/cs43130.c b/sound/soc/codecs/cs43130.c index

[PATCH] sound: rt5645: fix a NULL pointer dereference

2019-03-14 Thread Kangjie Lu
devm_kcalloc() may fail and return NULL. The fix returns ENOMEM in case it fails to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu --- sound/soc/codecs/rt5645.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index

[PATCH] sound: soc-pcm: add a check to avoid NULL pointer dereference

2019-03-14 Thread Kangjie Lu
In case debugfs_create_u32 fails, the fix frees memory and returns an error to notify callers. Signed-off-by: Kangjie Lu --- sound/soc/soc-pcm.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-14 Thread Sultan Alsawaf
On Thu, Mar 14, 2019 at 11:16:41PM -0400, Steven Rostedt wrote: > How would you implement such a method in userspace? kill() doesn't take > any parameters but the pid of the process you want to send a signal to, > and the signal to send. This would require a new system call, and be > quite a bit

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-14 Thread Sultan Alsawaf
On Thu, Mar 14, 2019 at 10:54:48PM -0400, Joel Fernandes wrote: > I'm not sure if that makes much semantic sense for how the signal handling is > supposed to work. Imagine a parent sends SIGKILL to its child, and then does > a wait(2). Because the SIGKILL blocks in your idea, then the wait cannot

Re: [PATCH 1/5] lib/sort: Make swap functions more generic

2019-03-14 Thread George Spelvin
>> swap_bytes / swap_4byte_words / swap_8byte_words >> swap_bytes / swap_ints / swap_longs >> swap_1 / swap_4 / swap_8 >> Pistols at dawn? On Thu, 14 Mar 2019 at 22:59:55 +0300, Andrey Abramov wrote: > Yes, in my opinion, swap_bytes / swap_ints / swap_longs are the > most readable because we have

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-14 Thread Steven Rostedt
On Thu, 14 Mar 2019 13:49:11 -0700 Sultan Alsawaf wrote: > Perhaps I'm missing something, but if you want to know when a process has died > after sending a SIGKILL to it, then why not just make the SIGKILL optionally > block until the process has died completely? It'd be rather trivial to just >

Re: [PATCH] scripts/spelling.txt: add more typos to spelling.txt and sort

2019-03-14 Thread Finn Thain
Does it makes sense to list every typo that is simply a transposition of characters or a character omitted? This file will become very large very quickly if we do that. Such errors can be found algorithmically where the correct spelling is known. E.g. the file contains 'algorithm' so

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-14 Thread Joel Fernandes
On Thu, Mar 14, 2019 at 01:49:11PM -0700, Sultan Alsawaf wrote: > On Thu, Mar 14, 2019 at 10:47:17AM -0700, Joel Fernandes wrote: > > About the 100ms latency, I wonder whether it is that high because of > > the way Android's lmkd is observing that a process has died. There is > > a gap between

RE: [RFC PATCH 0/3] Add support of busfreq

2019-03-14 Thread Aisheng Dong
+Jacky and Leonard, Ranjani Hi Alexandre, > From: Alexandre Bailon [mailto:abai...@baylibre.com] > > This series implements busfreq, a framework used in MXP's tree to scale the > interconnect and dram frequencies. > In the vendor tree, device's driver request for a performance level, which is >

[PATCH] perf tools: return errcode in cs_etm__process_auxtrace_info

2019-03-14 Thread Yue Haibing
From: YueHaibing 'err' is set in err path, but it's not returned to callers. Also fix a pass zero to PTR_ERR issue. Fixes: cd8bfd8c973e ("perf tools: Add processing of coresight metadata") Signed-off-by: YueHaibing --- tools/perf/util/cs-etm.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [RFC 1/2] dt-bindings: imx6q-pcie: Add support for i.MX8QM/QXP PCIe

2019-03-14 Thread Andrey Smirnov
On Wed, Mar 13, 2019 at 2:15 AM Richard Zhu wrote: > > Add codes needed to support i.MX8QM/QXP PCIe. > - HSIO(High Speed IO) subsystem is new defined on i.MX8QM/QXP. > The PCIe and SATA modules are contained in the HSIO subsystem. There > are two PCIe, one SATA controllers and three mixed

Re: [RFC 2/2] PCI: imx6: Add support for i.MX8QM/QXP PCIe

2019-03-14 Thread Andrey Smirnov
On Thu, Mar 14, 2019 at 2:18 AM Richard Zhu wrote: > > Hi Andrey: > Thanks a lot for your review comments. > > Best Regards > Richard Zhu > Office: 86-21-28937189 > Mobile: 86-13386059786 > > > > -Original Message- > > From: Andrey Smirnov [mailto:andrew.smir...@gmail.com] > > Sent:

[PATCH] scripts/spelling.txt: add more typos to spelling.txt and sort

2019-03-14 Thread Like Xu
Here are some of the more common spelling mistakes and typos that I've found while fixing up spelling mistakes in the kernel. Signed-off-by: Like Xu --- scripts/spelling.txt | 579 +++ 1 file changed, 492 insertions(+), 87 deletions(-) diff --git

RE: [RFC 1/2] dt-bindings: imx6q-pcie: Add support for i.MX8QM/QXP PCIe

2019-03-14 Thread Richard Zhu
Hi Lucas: Thanks for your reivew. > -Original Message- > From: Lucas Stach [mailto:l.st...@pengutronix.de] > Sent: 2019年3月14日 17:31 > To: Richard Zhu ; bhelg...@google.com; > lorenzo.pieral...@arm.com; andrew.smir...@gmail.com > Cc: linux-...@vger.kernel.org;

[PATCH] checkpatch: fix camel case seeding when run with --root

2019-03-14 Thread Jacob Keller
checkpatch.pl avoids warning about camel case of some definitions by seeding a file that tracks all of the currently committed camel case definitions. To build this seed file, checkpatch.pl decides between using git or the --root parameter. This works as long as you don't run checkpatch.pl from

[PATCH v3 mailbox+firmware 6/6] dt-bindings: firmware: Document cznic,turris-mox-rwtm binding

2019-03-14 Thread Marek Behún
This adds device tree binding documentation for the driver communicating with the rWTM firmware on Turris Mox. Signed-off-by: Marek Behún Cc: Rob Herring Cc: devicet...@vger.kernel.org --- .../firmware/cznic,turris-mox-rwtm.txt| 19 +++ 1 file changed, 19 insertions(+)

[PATCH v3 mailbox+firmware 2/6] dt-bindings: mailbox: Document armada-3700-rwtm-mailbox binding

2019-03-14 Thread Marek Behún
This adds device tree binding documentation for the rWTM BIU mailbox driver on the Armada 37xx SOC (EspressoBin, Turris Mox). Signed-off-by: Marek Behún Reviewed-by: Rob Herring --- .../mailbox/marvell,armada-3700-rwtm-mailbox.txt | 16 1 file changed, 16 insertions(+) create

[PATCH v3 mailbox+firmware 3/6] arm64: dts: marvell: armada-37xx: add mailbox node

2019-03-14 Thread Marek Behún
This adds the rWTM BIU mailbox node for communication with the secure processor. Signed-off-by: Marek Behún --- arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi

[PATCH v3 mailbox+firmware 1/6] mailbox: Add support for Armada 37xx rWTM mailbox

2019-03-14 Thread Marek Behún
This adds support for the mailbox via which the kernel can communicate with the firmware running on the secure processor of the Armada 37xx SOC. The rWTM secure processor has access to internal eFuses and cryptographic circuits, such as the Entropy Bit Generator to generate true random numbers.

[PATCH v3 mailbox+firmware 0/6] Armada 37xx mailbox + Turris Mox secure firmware support

2019-03-14 Thread Marek Behún
Hello, this is the third version of my patches to add support for rWTM mailbox of Marvell A3700 compatible devices, this time also with turris-mox-rwtm firmware driver. I would like to ask you guys for reviews, since I didn't get any review for the first patch (adding mailbox support) yet.

[PATCH v3 mailbox+firmware 4/6] firmware: Add Turris Mox rWTM firmware driver

2019-03-14 Thread Marek Behún
This adds a driver to communicate with the firmware running on the secure processor of the Turris Mox router, enabling the kernel to retrieve true random numbers from the Entropy Bit Generator and to sign messages with the ECDSA private key burned into each Turris Mox device when manufacturing.

[PATCH v3 mailbox+firmware 5/6] firmware: turris-mox-rwtm: Add sysfs documentation

2019-03-14 Thread Marek Behún
Add sysfs ABI documentation for the sysfs files created by the turris-mox-rwtm driver. Signed-off-by: Marek Behún --- .../testing/sysfs-firmware-turris-mox-rwtm| 60 +++ 1 file changed, 60 insertions(+) create mode 100644

[PATCH V4 4/5] ARM: dts: imx7ulp: Add pwm0 support

2019-03-14 Thread Anson Huang
Add i.MX7ULP EVK board PWM0 support. Signed-off-by: Anson Huang --- No changes. --- arch/arm/boot/dts/imx7ulp-evk.dts | 12 arch/arm/boot/dts/imx7ulp.dtsi| 10 ++ 2 files changed, 22 insertions(+) diff --git a/arch/arm/boot/dts/imx7ulp-evk.dts

[PATCH V4 5/5] ARM: dts: imx7ulp-evk: Add backlight support

2019-03-14 Thread Anson Huang
This patch adds i.MX7ULP EVK board MIPI-DSI backlight support. Signed-off-by: Anson Huang --- No changes. --- arch/arm/boot/dts/imx7ulp-evk.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/imx7ulp-evk.dts b/arch/arm/boot/dts/imx7ulp-evk.dts index

[PATCH V4 2/5] pwm: Add i.MX TPM PWM driver support

2019-03-14 Thread Anson Huang
i.MX7ULP has TPM(Low Power Timer/Pulse Width Modulation Module) inside, add TPM PWM driver support. Signed-off-by: Anson Huang --- Changes since V3: - use "PWM_IMX_" as macro definition prefix and "pwm_imx_" as function prefix; - improve the limitation txt; - return

[PATCH V4 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding

2019-03-14 Thread Anson Huang
Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM binding. Signed-off-by: Anson Huang --- No changes. --- Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt | 19 +++ 1 file changed, 19 insertions(+) create mode 100644

[PATCH V4 3/5] ARM: imx_v6_v7_defconfig: Add TPM PWM support by default

2019-03-14 Thread Anson Huang
Select CONFIG_PWM_IMX_TPM by default to support i.MX7ULP TPM PWM. Signed-off-by: Anson Huang --- No changes. --- arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index

[PATCH V4 0/5] Add i.MX7ULP EVK PWM backlight support

2019-03-14 Thread Anson Huang
i.MX7ULP EVK board has MIPI-DSI display, its backlight is supplied by TPM PWM module, this patch set enables i.MX7ULP TPM PWM driver support and also add backlight support for MIPI-DSI display. Anson Huang (5): dt-bindings: pwm: Add i.MX TPM PWM binding pwm: Add i.MX TPM PWM driver support

Re: WARN ON at kernel/sched/deadline.c task_non_contending

2019-03-14 Thread chengjian (D)
On 2019/3/13 22:49, luca abeni wrote: Hi, After looking at the patch a little bit more and running some tests, I suspect this solution might be racy: when the timer is already active, (and hrtimer_start() fails), it relies on its handler to decrease the running bw (by setting

PCI: BUG in pci_epf_remove_cfs() from pci-epf-test

2019-03-14 Thread Randy Dunlap
This is Linux v5.0-11053-gebc551f2b8f9 from March 12, on x86_64. Just load and unload the pci-epf-test module. [ 78.942581] calling pci_epf_test_init+0x0/0x1000 [pci_epf_test] @ 1650 [ 78.945926] initcall pci_epf_test_init+0x0/0x1000 [pci_epf_test] returned 0 after 3216 usecs [

Re: [PATCH 4/4] ubifs: Implement new mount option, fscrypt_key_required

2019-03-14 Thread James Bottomley
On Thu, 2019-03-14 at 19:42 -0400, Theodore Ts'o wrote: > On Thu, Mar 14, 2019 at 04:15:11PM -0700, James Bottomley wrote: > > On Thu, 2019-03-14 at 18:15 +0100, Richard Weinberger wrote: > > > Usually fscrypt allows limited access to encrypted files even > > > if no key is available. > > >

[PATCH] kbuild: Make NOSTDINC_FLAGS a simply expanded variable

2019-03-14 Thread Douglas Anderson
During a simple no-op (nothing changed) build I saw 39 invocations of the C compiler with the argument "-print-file-name=include". We don't need to call the C compiler 39 times for this--one time will suffice. Let's change NOSTDINC_FLAGS to a simply expanded variable to avoid this since there

Re: [PATCH 4/4] ubifs: Implement new mount option, fscrypt_key_required

2019-03-14 Thread Theodore Ts'o
On Thu, Mar 14, 2019 at 04:15:11PM -0700, James Bottomley wrote: > On Thu, 2019-03-14 at 18:15 +0100, Richard Weinberger wrote: > > Usually fscrypt allows limited access to encrypted files even > > if no key is available. > > Encrypted filenames are shown and based on this names users > > can

Re: [PATCH] tracing: initialize variable in create_dyn_event()

2019-03-14 Thread Masami Hiramatsu
Hi Frank and Steve, Thank you for pointing it out :) On Thu, 14 Mar 2019 18:19:08 -0400 Steven Rostedt wrote: > On Thu, 14 Mar 2019 14:05:02 -0700 > Frank Rowand wrote: > > > Hi Steve, > > > > Ping. > > Thanks, this got buried. > > > > static int create_dyn_event(int argc, char **argv) >

[PATCH] iio: adc: fix indentation issue, remove extra tab

2019-03-14 Thread Colin King
From: Colin Ian King A return statement is indented one level too deeply; clean this up by removing a tab. Signed-off-by: Colin Ian King --- drivers/iio/adc/ad7124.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c index

Re: [PATCH v2 2/9] mfd: mt6397: extract irq related code from core driver

2019-03-14 Thread Nicolas Boichat
On Mon, Mar 11, 2019 at 11:48 AM Hsin-Hsiung Wang wrote: > > In order to support different types of irq design, we decide to add > separate irq drivers for different design and keep mt6397 mfd core > simple and reusable to all generations of PMICs so far. > > Signed-off-by: Hsin-Hsiung Wang >

[PATCH] iio: adc: fix indentation issue, remove extra tab

2019-03-14 Thread Colin King
From: Colin Ian King A return statement is indented one level too deeply; clean this up by removing a tab. Signed-off-by: Colin Ian King --- drivers/iio/adc/ad7124.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c index

Re: [PATCH v5 2/9] clk: mediatek: Add new clkmux register API

2019-03-14 Thread Nicolas Boichat
On Tue, Mar 5, 2019 at 1:06 PM Weiyi Lu wrote: > > From: Owen Chen > > On both MT8183 & MT6765, there add "set/clr" register for > each clkmux setting, and one update register to trigger value change. > It is designed to prevent read-modify-write racing issue. > The sw design need to add a new

[PATCH] pata_serverworks: clean up misaligned indentation

2019-03-14 Thread Colin King
From: Colin Ian King There are several lines that are indented by one space too many; clean these up. Also re-work comment block to clean up cppcheck warnings Signed-off-by: Colin Ian King --- drivers/ata/pata_serverworks.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-)

Re: [PATCH 4/4] ubifs: Implement new mount option, fscrypt_key_required

2019-03-14 Thread James Bottomley
On Thu, 2019-03-14 at 18:15 +0100, Richard Weinberger wrote: > Usually fscrypt allows limited access to encrypted files even > if no key is available. > Encrypted filenames are shown and based on this names users > can unlink and move files. Shouldn't they be able to read/write and create as well

[PATCH] x86/lib: fix indentation issue, remove extra tab

2019-03-14 Thread Colin King
From: Colin Ian King The increment of buff is indented one level too deeply, clean this up by removing a tab. Signed-off-by: Colin Ian King --- arch/x86/lib/csum-partial_64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/lib/csum-partial_64.c

Re: [PATCH 4/4] ubifs: Implement new mount option, fscrypt_key_required

2019-03-14 Thread Theodore Ts'o
Richard --- stepping back for a moment, in your use case, are you assuming that the encryption key is always going to be present while the system is running? Ubifs can't use dm-crypt, since it doesn't have a block device, but if you could, is much more like dm-crypt, in that you have the key

Re: [PATCH v3 3/3] Drivers: hv: vmbus: Fix race condition with new ring_buffer_info mutex

2019-03-14 Thread Stephen Hemminger
On Thu, 14 Mar 2019 13:05:15 -0700 "Kimberly Brown" wrote: > Fix a race condition that can result in a ring buffer pointer being set > to null while a "_show" function is reading the ring buffer's data. This > problem was discussed here: >

Re: [PATCH] tracing: initialize variable in create_dyn_event()

2019-03-14 Thread Steven Rostedt
On Thu, 14 Mar 2019 14:05:02 -0700 Frank Rowand wrote: > Hi Steve, > > Ping. Thanks, this got buried. > > static int create_dyn_event(int argc, char **argv) > > { > > struct dyn_event_operations *ops; > > - int ret; > > + int ret = 0; Probably should be ret = -ENODEV; As if ret

Re: [PATCH] percpu/module resevation: change resevation size iff X86_VSMP is set

2019-03-14 Thread Paul E. McKenney
On Thu, Mar 14, 2019 at 10:36:19AM -0700, Tejun Heo wrote: > On Wed, Mar 13, 2019 at 04:11:55PM -0700, Paul E. McKenney wrote: > > commit 34f67df09cc0c6bf082a7cfca435373caeeb8d82 > > Author: Paul E. McKenney > > Date: Wed Mar 13 16:06:22 2019 -0700 > > > > srcu: Forbid

Re: [Regression] Re: Linux 5.0.2

2019-03-14 Thread Alan J. Wylie
Greg KH writes: > On Thu, Mar 14, 2019 at 02:52:50PM -0700, Greg KH wrote: >> On Thu, Mar 14, 2019 at 08:43:14PM +, Alan J. Wylie wrote: >> > >> > (Adding Linus, since his tree is also broken) >> >> Again, can you try running 'git bisect' to find the offending commit? > > Ah, looks like

[PATCH v4] x86/boot: clean up headers

2019-03-14 Thread Nick Desaulniers
The inclusion of was causing issue as the definition of __arch_hweight64 from arch/x86/include/asm/arch_hweight.h eventually gets included. The definition is problematic when compiled with -m16 (all code in arch/x86/boot/ is) as the "D" inline assembly constraint is rejected by both compilers

Re: [PATCH] [RESEND] Do not modify perf bias performance setting by default at boot

2019-03-14 Thread Rafael J. Wysocki
On Thu, Mar 14, 2019 at 3:42 PM Thomas Renninger wrote: > > This is a revert of mainline git commits: > commit b51ef52df71cb28e9d90cd1d48b79bf19f0bab06 > commit 17edf2d79f1ea6dfdb4c444801d928953b9f98d6 > commit abe48b108247e9b90b4c6739662a2e5c765ed114 I'm not quite convinced that reverting these

Re: [PATCH 1/2] elf: simpler check for -EEXIST

2019-03-14 Thread Tetsuo Handa
On 2019/03/15 5:42, Alexey Dobriyan wrote: > PTR_ERR((void *)map_addr) == -EEXIST > > is a very complicated way of doing the obvious. Michal suggested me to explicitly use PTR_ERR() for documentation purpose in a reply mail to https://lkml.kernel.org/r/20180418115546.gz17...@dhcp22.suse.cz

Re: [PATCH] EDAC, {skx|i10nm}_edac: Fix randconfig build error

2019-03-14 Thread Luck, Tony
On Thu, Mar 14, 2019 at 12:04:13PM +0100, Borislav Petkov wrote: > On Thu, Mar 14, 2019 at 08:09:06AM +0100, Arnd Bergmann wrote: > > > So where should we go. Proposed solutions are piling up: > > > > > > 1) Make skx_common a module > > > [downside: have to EXPORT everything in it] > > >

Re: [Regression] Re: Linux 5.0.2

2019-03-14 Thread Greg KH
On Thu, Mar 14, 2019 at 02:52:50PM -0700, Greg KH wrote: > On Thu, Mar 14, 2019 at 08:43:14PM +, Alan J. Wylie wrote: > > > > (Adding Linus, since his tree is also broken) > > Again, can you try running 'git bisect' to find the offending commit? Ah, looks like Guenter found it, nevermind...

Re: [Regression] Re: Linux 5.0.2

2019-03-14 Thread Greg KH
On Thu, Mar 14, 2019 at 08:43:14PM +, Alan J. Wylie wrote: > > (Adding Linus, since his tree is also broken) Again, can you try running 'git bisect' to find the offending commit? thanks, greg k-h

[PATCH -manpage 2/2] memfd_create.2: Update manpage with new memfd F_SEAL_FUTURE_WRITE seal

2019-03-14 Thread Joel Fernandes (Google)
More details of the seal can be found in the LKML patch: https://lore.kernel.org/lkml/20181120052137.74317-1-j...@joelfernandes.org/T/#t Signed-off-by: Joel Fernandes (Google) --- man2/memfd_create.2 | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git

[PATCH -manpage 1/2] fcntl.2: Update manpage with new memfd F_SEAL_FUTURE_WRITE seal

2019-03-14 Thread Joel Fernandes (Google)
More details of the seal can be found in the LKML patch: https://lore.kernel.org/lkml/20181120052137.74317-1-j...@joelfernandes.org/T/#t Signed-off-by: Joel Fernandes (Google) --- man2/fcntl.2 | 15 +++ 1 file changed, 15 insertions(+) diff --git a/man2/fcntl.2 b/man2/fcntl.2 index

[PATCH -manpage 0/2]

2019-03-14 Thread Joel Fernandes (Google)
This documentation is for F_SEAL_FUTURE_WRITE patches that are in linux-next. Joel Fernandes (Google) (2): fcntl.2: Update manpage with new memfd F_SEAL_FUTURE_WRITE seal memfd_create.2: Update manpage with new memfd F_SEAL_FUTURE_WRITE seal man2/fcntl.2| 15 +++

Re: [PATCH tip/core/rcu 06/19] rcu: Add warning to detect half-interrupts

2019-03-14 Thread Joel Fernandes
On Thu, Mar 14, 2019 at 09:37:46AM -0400, Steven Rostedt wrote: > On Thu, 14 Mar 2019 09:36:57 -0400 > Steven Rostedt wrote: > > > On Thu, 14 Mar 2019 08:31:59 -0400 > > Joel Fernandes wrote: > > > > > Oh thanks for pointing that out. Yes it does work for me. I agree with the > > > lockdep API

Re: [PATCH] perf/x86/intel: Make cpuc allocations consistent

2019-03-14 Thread Guenter Roeck
Hi, On Tue, Mar 05, 2019 at 10:23:15PM +0100, Peter Zijlstra (Intel) wrote: > The cpuc data structure allocation is different between fake and real > cpuc's; use the same code to init/free both. > > Signed-off-by: Peter Zijlstra (Intel) > Signed-off-by: Thomas Gleixner With

Re: [PATCH] tracing: initialize variable in create_dyn_event()

2019-03-14 Thread Frank Rowand
Hi Steve, Ping. -Frank On 1/24/19 6:17 PM, frowand.l...@gmail.com wrote: > From: Frank Rowand > > Fix compile warning in create_dyn_event(): 'ret' may be used uninitialized > in this function [-Wuninitialized]. > > Fixes: 5448d44c3855 ("tracing: Add unified dynamic event framework") > >

Re: Regression causes a hang on boot with a Comtrol PCI card

2019-03-14 Thread Jesse Hathaway
> > 1302fcf0d03e (refs/bisect/bad) PCI: Configure *all* devices, not just > > hot-added ones > > 1c3c5eab1715 sched/core: Enable might_sleep() and smp_processor_id() > > checks early > > How did you narrow it down to *two* commits, and do you have to revert > both of them to avoid the hang?

Re: [PATCH 4/4] ubifs: Implement new mount option, fscrypt_key_required

2019-03-14 Thread Richard Weinberger
Eric, Am Donnerstag, 14. März 2019, 18:49:14 CET schrieb Eric Biggers: > Hi Richard, > > On Thu, Mar 14, 2019 at 06:15:59PM +0100, Richard Weinberger wrote: > > Usually fscrypt allows limited access to encrypted files even > > if no key is available. > > Encrypted filenames are shown and based

general protection fault in ebitmap_destroy (2)

2019-03-14 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:ebc551f2 Merge tag 'nfsd-5.1' of git://linux-nfs.org/~bfie.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=105c28d720 kernel config: https://syzkaller.appspot.com/x/.config?x=f05902bca21d8935

Re: [PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c

2019-03-14 Thread Joe Perches
On Thu, 2019-03-14 at 15:07 +0100, Jean Delvare wrote: > My principle is that if a script > is present in the kernel tree then it can and should be maintained. If > it is deemed not worth the maintenance effort then it should be > deleted. I've suggested deleting Lindent in the past.

[PATCH] elf: delete trailing "return;" in functions returning "void"

2019-03-14 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan --- fs/binfmt_elf.c |4 1 file changed, 4 deletions(-) --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -1456,8 +1456,6 @@ static void fill_elf_header(struct elfhdr *elf, int segs, elf->e_ehsize = sizeof(struct elfhdr); elf->e_phentsize =

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-14 Thread Sultan Alsawaf
On Thu, Mar 14, 2019 at 10:47:17AM -0700, Joel Fernandes wrote: > About the 100ms latency, I wonder whether it is that high because of > the way Android's lmkd is observing that a process has died. There is > a gap between when a process memory is freed and when it disappears > from the

[PATCH] elf: free PT_INTERP filename ASAP

2019-03-14 Thread Alexey Dobriyan
There is no reason for PT_INTERP filename to linger till the end of the whole loading process. Signed-off-by: Alexey Dobriyan --- fs/binfmt_elf.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -686,7 +686,6 @@

Re: [PATCH v3 3/7] slob: Use slab_list instead of lru

2019-03-14 Thread Tobin C. Harding
On Thu, Mar 14, 2019 at 06:52:25PM +, Roman Gushchin wrote: > On Thu, Mar 14, 2019 at 04:31:31PM +1100, Tobin C. Harding wrote: > > Currently we use the page->lru list for maintaining lists of slabs. We > > have a list_head in the page structure (slab_list) that can be used for > > this

[PATCH] elf: make scope of "pos" variable smaller

2019-03-14 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan --- fs/binfmt_elf.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -703,7 +703,6 @@ static int load_elf_binary(struct linux_binprm *bprm) struct elfhdr interp_elf_ex; } *loc;

[PATCH 1/2] x86/CPU: Use correct macros for Cyrix calls on Geode processors

2019-03-14 Thread Matthew Whitehead
There are comments in processor-cyrix.h advising you to _not_ make calls using the deprecated macros in this style: setCx86_old(CX86_CCR4, getCx86_old(CX86_CCR4) | 0x80); This is because it expands the macro into a non-functioning calling sequence. The calling order must be: outb(CX86_CCR2,

[PATCH 2/2] x86/CPU: Remove {get,set}Cx86_old macros used for Cyrix processors

2019-03-14 Thread Matthew Whitehead
The getCx86_old() and setCx86_old() macros have been replaced with correctly working getCx86() and setCx86(), so remove these unused macros. Signed-off-by: Matthew Whitehead --- arch/x86/include/asm/processor-cyrix.h | 21 - 1 file changed, 21 deletions(-) diff --git

[PATCH 0/2] x86/CPU: Use correct Cyrix-specific macros

2019-03-14 Thread Matthew Whitehead
Replace the incorrect Cyrix-specific macro calls with the correct setCx86() and getCx86() calls. Also remove the unused setCx86_old(), getCx86_old() and their related comments in the code. Matthew Whitehead (2): x86/CPU: Use correct macros for Cyrix calls on Geode processors x86/CPU: Remove

[PATCH 2/2] elf: print userspace address with %lx

2019-03-14 Thread Alexey Dobriyan
Use %lx, save a cast. "addr" is userspace address so using (and mangling) pointer was never necessary. Signed-off-by: Alexey Dobriyan --- fs/binfmt_elf.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -376,8 +376,8 @@ static

Re: [PATCH] checkpatch: add %pt as a valid vsprintf extension

2019-03-14 Thread Joe Perches
On Thu, 2019-03-14 at 21:37 +0100, Alexandre Belloni wrote: > Commit 4d42c44727a0 ("lib/vsprintf: Print time and date in human readable > format via %pt") introduced a new extension, %pt. Add it in the list of > valid extensions. Thanks. Andrew, can you please pick this up? > Signed-off-by:

Re: [Regression] Re: Linux 5.0.2

2019-03-14 Thread Alan J. Wylie
(Adding Linus, since his tree is also broken) Greg KH writes: > On Thu, Mar 14, 2019 at 07:59:00PM +, Alan J. Wylie wrote: >> Greg KH writes: >> >> > I'm announcing the release of the 5.0.2 kernel. >> >> There is a regression for AMD-only builds. > > Adding the stable list, which

Re: [PATCH v3 3/7] slob: Use slab_list instead of lru

2019-03-14 Thread Tobin C. Harding
On Fri, Mar 15, 2019 at 07:38:09AM +1100, Tobin C. Harding wrote: > On Thu, Mar 14, 2019 at 06:52:25PM +, Roman Gushchin wrote: > > On Thu, Mar 14, 2019 at 04:31:31PM +1100, Tobin C. Harding wrote: > > > Currently we use the page->lru list for maintaining lists of slabs. We > > > have a

[PATCH 1/2] elf: simpler check for -EEXIST

2019-03-14 Thread Alexey Dobriyan
PTR_ERR((void *)map_addr) == -EEXIST is a very complicated way of doing the obvious. Signed-off-by: Alexey Dobriyan --- fs/binfmt_elf.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -375,8 +375,7 @@ static unsigned long

Re: [PATCH v3 3/7] slob: Use slab_list instead of lru

2019-03-14 Thread Tobin C. Harding
On Thu, Mar 14, 2019 at 06:52:25PM +, Roman Gushchin wrote: > On Thu, Mar 14, 2019 at 04:31:31PM +1100, Tobin C. Harding wrote: > > Currently we use the page->lru list for maintaining lists of slabs. We > > have a list_head in the page structure (slab_list) that can be used for > > this

[PATCH] checkpatch: add %pt as a valid vsprintf extension

2019-03-14 Thread Alexandre Belloni
Commit 4d42c44727a0 ("lib/vsprintf: Print time and date in human readable format via %pt") introduced a new extension, %pt. Add it in the list of valid extensions. Signed-off-by: Alexandre Belloni --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v3 0/1] mm: introduce put_user_page*(), placeholder versions

2019-03-14 Thread John Hubbard
On 3/14/19 1:25 PM, William Kucharski wrote: On Mar 14, 2019, at 7:30 AM, Jan Kara wrote: Well I have some crash reports couple years old and they are not from QA departments. So I'm pretty confident there are real users that use this in production... and just reboot their machine in case

Re: [PATCH v3 0/1] mm: introduce put_user_page*(), placeholder versions

2019-03-14 Thread William Kucharski
> On Mar 14, 2019, at 7:30 AM, Jan Kara wrote: > > Well I have some crash reports couple years old and they are not from QA > departments. So I'm pretty confident there are real users that use this in > production... and just reboot their machine in case it crashes. Do you know what the use

Re: [Regression] Re: Linux 5.0.2

2019-03-14 Thread Greg KH
On Thu, Mar 14, 2019 at 07:59:00PM +, Alan J. Wylie wrote: > Greg KH writes: > > > I'm announcing the release of the 5.0.2 kernel. > > There is a regression for AMD-only builds. Adding the stable list, which people should do... > > See also Alec Ari's report: >

Re: [PATCH 1/5] lib/sort: Make swap functions more generic

2019-03-14 Thread Andrey Abramov
> Pistols at dawn? > swap_bytes > swap_4byte_words > swap_8byte_words or >  swap_bytes / swap_ints / swap_longs >  swap_1 / swap_4 / swap_8 Yes, in my opinion, swap_bytes / swap_ints / swap_longs are the most readable because we have both swap_ints and swap_longs functions (in one file near

[PATCH v3 2/3] Drivers: hv: vmbus: Set ring_info field to 0 and remove memset

2019-03-14 Thread Kimberly Brown
Set "ring_info->priv_read_index" to 0. Now, all of ring_info's fields are explicitly set in this function. The memset() call is no longer necessary, so remove it. Signed-off-by: Kimberly Brown --- drivers/hv/ring_buffer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH v3 0/3] Drivers: hv: vmbus: Fix a race condition in "_show" functions

2019-03-14 Thread Kimberly Brown
This patchset fixes a race condition in the "_show" functions that access the channel ring buffers. Changes in v3: Patch 1: Drivers: hv: vmbus: Refactor chan->state if statement - Added the “reviewed-by” line from v2. Patch 2: Drivers: hv: vmbus: Set ring_info field to 0 and remove memset -

  1   2   3   4   5   6   >