Re: [RFC PATCH 3/5] documention: leds: Add multicolor class documentation

2019-04-01 Thread Marek Behun
On Mon, 1 Apr 2019 23:27:10 +0200 Pavel Machek wrote: > One was discussed before -- have single file which contains > coefficients for r/g/b channels. That would somehow break the rule one file/one value. Although you could consider the whole color one value, that way it would not be broken...

[PATCH v4] arm/mach-at91/pm : fix possible object reference leak

2019-04-01 Thread Peng Hao
of_find_device_by_node() takes a reference to the struct device when it finds a match via get_device. When returning error we should call put_device. Reviewed-by: Mukesh Ojha Signed-off-by: Peng Hao --- arch/arm/mach-at91/pm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH v5] HID: intel-ish-hid: ISH firmware loader client driver

2019-04-01 Thread Rushikesh S Kadam
This driver adds support for loading Intel Integrated Sensor Hub (ISH) firmware from host file system to ISH SRAM and start execution. At power-on, the ISH subsystem shall boot to an interim Shim loader-firmware, which shall expose an ISHTP loader device. The driver implements an ISHTP client

Applied "ASoC: dpcm: skip missing substream while applying symmetry" to the asoc tree

2019-04-01 Thread Mark Brown
The patch ASoC: dpcm: skip missing substream while applying symmetry has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24

Applied "regulator: bcm590xx: Convert to use simplified DT parsing" to the regulator tree

2019-04-01 Thread Mark Brown
The patch regulator: bcm590xx: Convert to use simplified DT parsing has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next

Re: [RFC PATCH 5/5] leds: multicolor: Introduce a multicolor class definition

2019-04-01 Thread Marek Behun
Hi Dan, On Mon, 1 Apr 2019 12:34:00 -0500 Dan Murphy wrote: > +static ssize_t sync_store(struct device *dev, > + struct device_attribute *sync_attr, > + const char *buf, size_t size) > +{ > + struct led_classdev_mc_data *data =

Re: [BUG] gpiolib: spi chip select legacy support breaks modern chip select and whitens the GTA04 LCD panel

2019-04-01 Thread Mark Brown
On Tue, Apr 02, 2019 at 07:05:35AM +0200, H. Nikolaus Schaller wrote: > > Am 02.04.2019 um 06:02 schrieb Linus Walleij : Please delete unneeded context from mails when replying. Doing this makes it much easier to find your reply in the message, helping ensure it won't be missed by people

Re: [PATCH 2/2] iio: counter: Add support for Milbeaut Updown Counter

2019-04-01 Thread Kanematsu , Shinji/兼松 伸次
Hi Jonathan, Thank you for your review. On 2019/03/31 3:43, Jonathan Cameron wrote: On Tue, 26 Mar 2019 15:33:32 +0900 Shinji Kanematsu wrote: Add support for Milbeaut Updown Counter, that can be used as counter or quadrature encoder. Signed-off-by: Shinji Kanematsu A few minor comments

[PATCH V1] mmc: tegra: add sdhci tegra suspend and resume

2019-04-01 Thread Sowjanya Komatineni
This patch adds suspend and resume PM ops for tegra SDHCI. Signed-off-by: Sowjanya Komatineni --- drivers/mmc/host/sdhci-tegra.c | 45 +- 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-tegra.c

Re: [PATCH] lib: Fix possible incorrect result from rational fractions helper

2019-04-01 Thread Andrew Morton
On Sat, 30 Mar 2019 13:58:55 -0700 Trent Piepho wrote: > In some cases the previous algorithm would not return the closest > approximation. This would happen when a semi-convergent was the > closest, as the previous algorithm would only consider convergents. > > As an example, consider an

Re: [PATCHv3] x86/boot/KASLR: skip the specified crashkernel region

2019-04-01 Thread Chao Fan
On Tue, Apr 02, 2019 at 12:10:46PM +0800, Pingfan Liu wrote: >crashkernel=x@y or or =range1:size1[,range2:size2,...]@offset option may or or? >fail to reserve the required memory region if KASLR puts kernel into the >region. To avoid this uncertainty, asking KASLR to skip the required >region. >

Re: [PATCH] vfio/type1: Limit DMA mappings per container

2019-04-01 Thread Peter Xu
On Mon, Apr 01, 2019 at 10:34:13PM -0600, Alex Williamson wrote: > On Tue, 2 Apr 2019 10:41:15 +0800 > Peter Xu wrote: > > > On Mon, Apr 01, 2019 at 02:16:52PM -0600, Alex Williamson wrote: > > > > [...] > > > > > @@ -1081,8 +1088,14 @@ static int vfio_dma_do_map(struct vfio_iommu > > >

Re: linux-next: build failure after merge of the sound-asoc tree

2019-04-01 Thread Mark Brown
On Mon, Apr 01, 2019 at 10:11:44PM +1100, Michael Ellerman wrote: > Anyway I think what you've done in next, make the code depend on > COMMON_CLOCK, is the best option. If anyone cares about that driver on > powerpc platforms that don't support COMMON_CLOCK they should speak up. It's probably

Re: [PATCH v3] mfd: cros_ec: instantiate properly CrOS ISH MCU device

2019-04-01 Thread Lee Jones
On Fri, 01 Mar 2019, Rushikesh S Kadam wrote: > Integrated Sensor Hub (ISH) is also a MCU running EC > having feature bit EC_FEATURE_ISH. Instantiate it as > a special CrOS EC device with device name 'cros_ish'. > > Signed-off-by: Rushikesh S Kadam > --- > v3 > - Dropped "Intel" in commments in

Re: [PATCH v1] mfd: Add support for Merrifield Basin Cove PMIC

2019-04-01 Thread Lee Jones
On Mon, 18 Mar 2019, Andy Shevchenko wrote: > Add an mfd driver for Intel Merrifield Basin Cove PMIC. Nit: s/mfd/MFD/ > Signed-off-by: Andy Shevchenko > --- > drivers/mfd/Kconfig | 11 ++ > drivers/mfd/Makefile | 1 + >

Re: [PATCH 2/2] ASoC: rt5677: make ACPI property names match _DSD

2019-04-01 Thread Mark Brown
On Mon, Apr 01, 2019 at 02:55:19PM -0600, Fletcher Woodruff wrote: > The rt5677 driver is using the wrong property names to read from ACPI. > Update the property names to match those from _DSD, so that the correct > GPIO pin numbers are read and that plug-detection works. > With this patch,

Re: [BUG] gpiolib: spi chip select legacy support breaks modern chip select and whitens the GTA04 LCD panel

2019-04-01 Thread H. Nikolaus Schaller
Hi Linus, > Am 02.04.2019 um 06:02 schrieb Linus Walleij : > > (CC Kumar and Wolfgang who came up with spi-active-low, I think.) > > On Sun, Mar 24, 2019 at 1:56 PM H. Nikolaus Schaller > wrote: >>> Am 24.03.2019 um 05:15 schrieb Linus Walleij : > >>> But I fixed it in that case by

Re: [PATCH 1/2] ASoC: rt5677: allow multiple interrupt sources

2019-04-01 Thread Mark Brown
On Mon, Apr 01, 2019 at 02:55:18PM -0600, Fletcher Woodruff wrote: > From: Ben Zhang > > This patch allows headphone plug detect and mic present > detect to be enabled at the same time. This patch implements > an irq_chip with irq_domain directly instead of using > regmap_irq, so that interrupt

Re: MSI number limit for PCI hotplug under PCI bridge on ARM platform

2019-04-01 Thread Marc Zyngier
On Mon, 01 Apr 2019 14:55:52 +0100, Heyi Guo wrote: > > Hi folks, > > In current kernel implementation for ARM platform, all devices under > one PCI bridge share a same device ID and the total number of MSI > interrupts is fixed at the first time any child device is allocating > MSI. However,

Re: [RESEND PATCH] mfd: sc27xx: Use SoC compatible string for PMIC devices

2019-04-01 Thread Lee Jones
On Mon, 18 Mar 2019, Baolin Wang wrote: > We should use SoC compatible string in stead of wildcard string for > PMIC child devices. > > Signed-off-by: Baolin Wang > --- > Hi Lee, > > Could you merge this patch into v5.1-rc if no objection from you? > Since our DTS patches had been merged into

Re: [LKP] [btrfs] 70d28b0e4f: BUG:kernel_reboot-without-warning_in_early-boot_stage, last_printk:Probing_EDD(edd=off_to_disable)...ok

2019-04-01 Thread Qu Wenruo
On 2019/4/2 上午11:14, Rong Chen wrote: > > On 4/1/19 11:40 PM, David Sterba wrote: >> On Mon, Apr 01, 2019 at 11:02:37PM +0800,  Chen, Rong A  wrote: >>> On 4/1/2019 10:29 PM, Qu Wenruo wrote: On 2019/4/1 下午10:02,  Chen, Rong A  wrote: > On 4/1/2019 9:28 PM, Nikolay Borisov wrote:

Re: Applied "ASoC: es8316: Add support for inverted jack detect" to the asoc tree

2019-04-01 Thread Mark Brown
On Mon, Apr 01, 2019 at 07:57:19PM +0200, Paul Cercueil wrote: Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being

Re: [PATCH 01/17] fpga: dfl-fme-mgr: fix FME_PR_INTFC_ID register address.

2019-04-01 Thread Wu Hao
On Mon, Apr 01, 2019 at 12:54:47PM -0700, Moritz Fischer wrote: > Hi Wu, > > On Mon, Mar 25, 2019 at 11:07:28AM +0800, Wu Hao wrote: > > FME_PR_INTFC_ID is used as compat_id for fpga manager and region, > > but high 64 bits and low 64 bits of the compat_id are swapped by > > mistake. This patch

Re: [PATCH V1 24/26] spi: tegra114: de-assert CS before SPI mode is reset to its default

2019-04-01 Thread Mark Brown
On Mon, Apr 01, 2019 at 06:07:45PM +, Sowjanya Komatineni wrote: > I see you have applied some patches in V1 series so should I re-send > again those as well along with feedback changes in next version or > just only the patches that are not applied. Please don't resend already applied

Re: [PATCH V1 19/26] DT bindings: spi: add spi client device properties

2019-04-01 Thread Mark Brown
On Mon, Apr 01, 2019 at 05:59:57PM +, Sowjanya Komatineni wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > > > +spi-client device controller properties: > > >

Re: [PATCH v2 3/4] Makefile: lld: tell clang to use lld

2019-04-01 Thread Masahiro Yamada
Hi Nick, On Tue, Apr 2, 2019 at 12:54 PM Nick Desaulniers wrote: > > On Sat, Feb 16, 2019 at 10:09 AM Masahiro Yamada > wrote: > > > > On Thu, Feb 14, 2019 at 8:08 AM Nick Desaulniers > > wrote: > > > > > > On Wed, Feb 13, 2019 at 6:59 AM Masahiro Yamada > > > wrote: > > > > > > > > On Tue,

Re: [PATCH v3] gcov: fix when CONFIG_MODULES is not set

2019-04-01 Thread Randy Dunlap
On 4/1/19 8:09 PM, tr...@android.com wrote: > From: Tri Vo > > Fixes: 8c3d220cb6b5 ("gcov: clang support") > > Cc: Greg Hackmann > Cc: Peter Oberparleiter > Cc: linux...@kvack.org > Cc: kbuild-...@01.org > Reported-by: Randy Dunlap > Reported-by: kbuild test robot > Link:

Re: Nested events with zero deltas, can use absolute timestamps instead?

2019-04-01 Thread Jason Behmer
On Mon, Apr 1, 2019 at 7:21 PM Steven Rostedt wrote: > > On Mon, 1 Apr 2019 15:54:20 -0700 > Jason Behmer wrote: > > > The concurrency model is still a little bit unclear to me as I'm new > > to this codebase. So I'm having some trouble reasoning about what > > operations are safe at one point

Re: [PATCH v2 0/2] arm64: meson-gxm: Add support for the Mali T820 GPU

2019-04-01 Thread Kevin Hilman
Neil Armstrong writes: > On 15/03/2019 14:56, Neil Armstrong wrote: >> This patchset adds : >> - Optional reset properties in the midgard bindings >> - Mali T820 Node in Amlogic Meson GXM DTSI >> >> Changes since v1: >> - Updated midgard DT wording following the recently submitted >> bifrost

Re: [PATCH 2/6] kbuild: allow Kbuild to start from any directory

2019-04-01 Thread Kieran Bingham
Hi Yamada-san, Thank you for the patches, I like the direction this series is taking. Small spelling error spotted below... But as I've now gone through all of it I'll offer Reviewed-by: Kieran Bingham On 30/03/2019 12:04, Masahiro Yamada wrote: > Kbuild always runs in the top of the output

Re: [PATCH 1/1] slob: Only use list functions when safe to do so

2019-04-01 Thread Andrew Morton
On Tue, 2 Apr 2019 14:29:57 +1100 "Tobin C. Harding" wrote: > Currently we call (indirectly) list_del() then we manually try to combat > the fact that the list may be in an undefined state by getting 'prev' > and 'next' pointers in a somewhat contrived manner. It is hard to > verify that this

Re: [PATCH] drivers: gpio: Kconfig: pedantic formatting cleanups

2019-04-01 Thread Linus Walleij
On Tue, Mar 5, 2019 at 7:35 AM Enrico Weigelt, metux IT consult wrote: > Align the Kconfig formatting with the vast majority of the Kconfig > files, to make it a bit easier / more pleasant to read ;-) > > Signed-off-by: Enrico Weigelt, metux IT consult Patch applied. Yours, Linus Walleij

Re: [PATCH] ASoC: soc-core: Fix probe deferral following prelink failure

2019-04-01 Thread Mark Brown
On Mon, Apr 01, 2019 at 01:22:09PM +0100, Jon Hunter wrote: > FYI, I am seeing that the deferral of soundcards failing with v5.1-rc3 > because the above has not been merged yet. Just wanted to let you know > in case this one was not marked for v5.1. I don't have this patch at all AFAICT.

Re: [PATCH] vfio/type1: Limit DMA mappings per container

2019-04-01 Thread Alex Williamson
On Tue, 2 Apr 2019 10:41:15 +0800 Peter Xu wrote: > On Mon, Apr 01, 2019 at 02:16:52PM -0600, Alex Williamson wrote: > > [...] > > > @@ -1081,8 +1088,14 @@ static int vfio_dma_do_map(struct vfio_iommu *iommu, > > goto out_unlock; > > } > > > > + if

Re: [PATCH v2] spi: tegra20-slink: change chip select action order

2019-04-01 Thread Mark Brown
On Fri, Mar 29, 2019 at 06:44:11PM +0100, Randolph Maaßen wrote: > To transfer via SPI the tegra20-slink driver first sets the command > register, which contains the chip select value, and after that the > command2 register, which contains the chip select line. This leads to a > small spike in the

Re: [PATCH v3] HID: intel-ish-hid: ISH firmware loader client driver

2019-04-01 Thread Rushikesh S Kadam
Hi Nick, Joe thanks for your comments Regards Rushikesh On Mon, Apr 01, 2019 at 03:17:13PM -0600, Nick Crews wrote: > I tried to send the last message from my phone, and surprise it wasn't > formatted correctly, so it may have been marked as spam. repeating > myself again... > > Ah, I guess I

Re: [Letux-kernel] [BUG] gpiolib: spi chip select legacy support breaks modern chip select and whitens the GTA04 LCD panel

2019-04-01 Thread Linus Walleij
On Sun, Mar 31, 2019 at 1:33 AM Andreas Kemnade wrote: > > > But I fixed it in that case by introducing a spi-cs-high into the DTS > > > file: > > > https://marc.info/?l=linux-arm-kernel=155292310015309=2 > > > > Yes, that of course works and is our temporary solution. > > > > And I see that

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-04-01 Thread Kai Heng Feng
On Apr 2, 2019, at 5:37 AM, wrote: -Original Message- From: Andy Shevchenko Sent: Thursday, March 21, 2019 4:48 AM To: Kai-Heng Feng; Limonciello, Mario Cc: Hans de Goede; Benjamin Tissoires; hotwater...@tutanota.com; Jiri Kosina; Stephen Boyd; Sebastian Andrzej Siewior;

linux-next: Tree for Apr 2

2019-04-01 Thread Stephen Rothwell
Hi all, Changes since 20190401: New tree: nand-fixes The nand tree gained a build failure so I used the version from next-20190401. The drm-misc tree gained a build failure due to an interaction with a change in Linus' tree for which I applied a merge fix patch. Non-merge commits (relative

[PATCHv3] x86/boot/KASLR: skip the specified crashkernel region

2019-04-01 Thread Pingfan Liu
crashkernel=x@y or or =range1:size1[,range2:size2,...]@offset option may fail to reserve the required memory region if KASLR puts kernel into the region. To avoid this uncertainty, asking KASLR to skip the required region. Signed-off-by: Pingfan Liu Cc: Thomas Gleixner Cc: Ingo Molnar Cc:

Re: [PATCH 068/114] drivers: mfd: Kconfig: pedantic formatting

2019-04-01 Thread Lee Jones
On Mon, 11 Mar 2019, Enrico Weigelt, metux IT consult wrote: > Formatting of Kconfig files doesn't look so pretty, so let the > Great White Handkerchief come around and clean it up. > > Signed-off-by: Enrico Weigelt, metux IT consult > --- > drivers/mfd/Kconfig | 62 >

Re: [PATCH] mfd: cros_ec_dev: Add a poll handler to receive MKBP events

2019-04-01 Thread Lee Jones
On Fri, 08 Mar 2019, Enric Balletbo i Serra wrote: > From: Vincent Palatin > > Allow to poll on the cros_ec device to receive the MKBP events. > > The /dev/cros_[ec|fp|..] file operations now implements the poll > operation. The userspace can now receive specific MKBP events by doing the >

[PATCH v5 6/9] mtd: rawnand: denali_pci: rename goto labels

2019-04-01 Thread Masahiro Yamada
As Documentation/process/coding-style.rst says, choose label names which say what the goto does. The out_ label style is already used in denali_dt.c. Rename likewise for denali_pci.c Signed-off-by: Masahiro Yamada --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2:

[PATCH v5 8/9] mtd: rawnand: denali: remove DENALI_NR_BANKS macro

2019-04-01 Thread Masahiro Yamada
Use the runtime-detected denali->nbanks instead of hard-coded DENALI_NR_BANKS (=4). The actual number of banks depends on the IP configuration, and can be less than DENALI_NR_BANKS. It is pointless to touch registers of unsupported banks. Signed-off-by: Masahiro Yamada --- Changes in v5: None

[PATCH v5 2/9] mtd: rawnand: denali: refactor raw page accessors

2019-04-01 Thread Masahiro Yamada
The Denali IP adopts the syndrome page layout (payload and ECC are interleaved). The *_page_raw() and *_oob() callbacks are complicated because they must hide the underlying layout used by the hardware, and always return contiguous in-band and out-of-band data. The Denali IP cannot reuse

[PATCH v5 1/9] mtd: rawnand: denali: use more nand_chip pointers for internal functions

2019-04-01 Thread Masahiro Yamada
With the recent refactoring, the NAND driver hooks now take a pointer to nand_chip. Add to_denali() in order to convert (struct nand_chip *) to (struct denali_nand_info *) directly. It is more useful than the current mtd_to_denali(). I changed some helper functions to take (struct nand_chip *).

[PATCH v5 5/9] mtd: rawnand: denali: use bool type instead of int where appropriate

2019-04-01 Thread Masahiro Yamada
Use 'bool' type for the following boolean parameters. - write (write or read?) - dma_avail (DMA engine available or not?) Signed-off-by: Masahiro Yamada --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: - Use bool for dma_avail as well

[PATCH v5 7/9] mtd: rawnand: denali: decouple controller and NAND chips

2019-04-01 Thread Masahiro Yamada
Currently, this driver sticks to the legacy NAND model because it was upstreamed before commit 2d472aba15ff ("mtd: nand: document the NAND controller/NAND chip DT representation"). However, relying on the dummy_controller is already deprecated. Switch over to the new controller/chip

[PATCH v5 3/9] mtd: rawnand: denali: remove unneeded casts in denali_{read,write}_pio

2019-04-01 Thread Masahiro Yamada
Since (u32 *) can accept an opaque pointer, the explicit casting from (void *) to (u32 *) is redundant. Change the function argument type to remove the casts. Signed-off-by: Masahiro Yamada --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None

[PATCH v5 0/9] mtd: rawnand: denali: exec_op(), controller/chip separation, and cleanups

2019-04-01 Thread Masahiro Yamada
I took time for the Denali driver to catch up with the latest framework. - switch over to exec_op() and remove legacy hooks - separate controller/chips - various cleanups Major changes in v5: - Passing both nand_chip and denali is redundant. Pass only nand_chip to local helpers.

[PATCH v5 9/9] mtd: rawnand: denali: clean up coding style

2019-04-01 Thread Masahiro Yamada
Eliminate the following reports from 'scripts/checkpatch.pl --strict'. CHECK: Prefer kernel type 'u8' over 'uint8_t' CHECK: Prefer kernel type 'u32' over 'uint32_t' CHECK: Alignment should match open parenthesis I slightly changed denali_check_erased_page() to shorten it. Signed-off-by:

[PATCH v5 4/9] mtd: rawnand: denali: switch over to ->exec_op() from legacy hooks

2019-04-01 Thread Masahiro Yamada
Implement ->exec_op(), and remove the deprecated hooks. Signed-off-by: Masahiro Yamada --- Changes in v5: None Changes in v4: - add denali_exec_in() and denali_exec_out() - avoid ternary operator to select function Changes in v3: - Fix byte-swap in denali_exec_in16() Changes in v2: None

Re: [BUG] gpiolib: spi chip select legacy support breaks modern chip select and whitens the GTA04 LCD panel

2019-04-01 Thread Linus Walleij
(CC Kumar and Wolfgang who came up with spi-active-low, I think.) On Sun, Mar 24, 2019 at 1:56 PM H. Nikolaus Schaller wrote: > > Am 24.03.2019 um 05:15 schrieb Linus Walleij : > > But I fixed it in that case by introducing a spi-cs-high into the DTS file: > >

Re: [PATCH 2/2] mfd: cros_ec: instantiate properly CrOS Touchpad MCU device

2019-04-01 Thread Lee Jones
On Thu, 07 Mar 2019, Enric Balletbo i Serra wrote: > From: Wei-Ning Huang > > Support Touchpad MCU as a special of CrOS EC devices. The current > Touchpad MCU is used on Eve Chromebook and used the same protocol as > other CrOS EC devices. > > When a MCU has touchpad support (aka

Re: [PATCH 1/2] mfd: cros_ec: instantiate properly CrOS FP MCU device

2019-04-01 Thread Lee Jones
On Thu, 07 Mar 2019, Enric Balletbo i Serra wrote: > From: Vincent Palatin > > Support Fingerprint MCU as a special of CrOS EC devices. The current FP > MCU uses the same EC SPI protocol v3 as other CrOS EC devices on a SPI > bus. > > When a MCU has fingerprint support (aka

Re: [PATCH v2 3/4] Makefile: lld: tell clang to use lld

2019-04-01 Thread Nick Desaulniers
On Sat, Feb 16, 2019 at 10:09 AM Masahiro Yamada wrote: > > On Thu, Feb 14, 2019 at 8:08 AM Nick Desaulniers > wrote: > > > > On Wed, Feb 13, 2019 at 6:59 AM Masahiro Yamada > > wrote: > > > > > > On Tue, Feb 12, 2019 at 5:42 AM wrote: > > > > > > > > This is needed because clang doesn't

Re: [PATCH] mfd: sm501: Fix potential NULL pointer dereference

2019-04-01 Thread Lee Jones
On Sat, 02 Mar 2019, Aditya Pakki wrote: > lookup variable on failure of allocating memory via devm_kzalloc > can cause a NULL pointer dereference. This patch avoids such a scenario. > > Signed-off-by: Aditya Pakki > --- > drivers/mfd/sm501.c | 3 +++ > 1 file changed, 3 insertions(+)

Re: [PATCH] mfd: twl-core: disable irq while suspended

2019-04-01 Thread Lee Jones
On Sat, 23 Feb 2019, Andreas Kemnade wrote: > Since commit > 6e2bd956936 ("i2c: omap: Use noirq system sleep pm ops to idle device for > suspend") > on gta04 we have handle_twl4030_pih() called in situations where > pm_runtime_get() > in i2c-omap.c returns -EACCES. > [ 86.474365] Freezing

Re: [PATCH v4 1/9] mtd: rawnand: denali: use nand_chip pointer more for internal functions

2019-04-01 Thread Masahiro Yamada
On Tue, Apr 2, 2019 at 2:14 AM Miquel Raynal wrote: > > Hi Masahiro, > > Boris Brezillon wrote on Sat, 30 Mar > 2019 15:23:23 +0100: > > > On Fri, 29 Mar 2019 16:28:13 +0900 > > Masahiro Yamada wrote: > > > > > With the recent refactoring, the NAND driver hooks now take a pointer > > > to

Re: [PATCH] regulator: wm8400: Get rid of wm8400_block_read/wm8400_set_bits functions

2019-04-01 Thread Lee Jones
On Wed, 27 Feb 2019, Axel Lin wrote: > The only user of wm8400_block_read/wm8400_set_bits functions is the > wm8400 regulator driver. At the context of all the callers, we can > use regmap_bulk_read/regmap_update_bits directly. > Thus remove wm8400_block_read/wm8400_set_bits functions. > >

Re: [PATCH] io_uring: introduce inline reqs for IORING_SETUP_IOPOLL & direct_io

2019-04-01 Thread Jens Axboe
On 4/1/19 9:10 PM, Jianchao Wang wrote: > For the IORING_SETUP_IOPOLL & direct_io case, all of the submission > and completion are handled under ctx->uring_lock or in SQ poll thread > context, so io_get_req and io_put_req has been serialized well. > > Based on this, we introduce the preallocated

Re: [PATCH v5] mfd: cros_ec_dev: Register cros_ec_accel_legacy driver as a subdevice

2019-04-01 Thread Lee Jones
On Wed, 27 Feb 2019, Gwendal Grignou wrote: > From: Enric Balletbo i Serra > > With this patch, the cros_ec_ctl driver will register the legacy > accelerometer driver (named cros_ec_accel_legacy) if it fails to > register sensors through the usual path cros_ec_sensors_register(). > This legacy

Re: [PATCH v8 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-04-01 Thread Andrew Jeffery
Hi Patrick, I held off on reviewing this until we'd hashed out what we needed in the driver. I have some comments below. On Sat, 30 Mar 2019, at 01:40, Patrick Venture wrote: > Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. > > Signed-off-by: Patrick Venture >

Re: [PATCH v8 2/2] drivers/misc: Add Aspeed P2A control driver

2019-04-01 Thread Andrew Jeffery
On Thu, 28 Mar 2019, at 07:52, Patrick Venture wrote: > The ASPEED AST2400, and AST2500 in some configurations include a > PCI-to-AHB MMIO bridge. This bridge allows a server to read and write > in the BMC's physical address space. This feature is especially useful > when using this bridge to

[PATCH 0/1] slob: Fix list_head bug during allocation

2019-04-01 Thread Tobin C. Harding
Hi Andrew, This patch is in response to an email from the 0day kernel test robot subject: 340d3d6178 ("mm/slob.c: respect list_head abstraction layer"): kernel BUG at lib/list_debug.c:31! This patch applies on top of linux-next tag: next-20190401 It fixes a patch that was merge

Re: [LKP] [btrfs] 70d28b0e4f: BUG:kernel_reboot-without-warning_in_early-boot_stage, last_printk:Probing_EDD(edd=off_to_disable)...ok

2019-04-01 Thread Qu Wenruo
On 2019/4/2 上午11:14, Rong Chen wrote: > > On 4/1/19 11:40 PM, David Sterba wrote: >> On Mon, Apr 01, 2019 at 11:02:37PM +0800,  Chen, Rong A  wrote: >>> On 4/1/2019 10:29 PM, Qu Wenruo wrote: On 2019/4/1 下午10:02,  Chen, Rong A  wrote: > On 4/1/2019 9:28 PM, Nikolay Borisov wrote:

[PATCH 1/1] slob: Only use list functions when safe to do so

2019-04-01 Thread Tobin C. Harding
Currently we call (indirectly) list_del() then we manually try to combat the fact that the list may be in an undefined state by getting 'prev' and 'next' pointers in a somewhat contrived manner. It is hard to verify that this works for all initial states of the list. Clearly the author (me) got

Re: [mt76] c1e0d2be0a: BUG:pagefault_on_kernel_address#in_non-whitelisted_uaccess

2019-04-01 Thread Jann Horn
On Tue, Apr 2, 2019 at 5:10 AM kernel test robot wrote: > FYI, we noticed the following commit (built with gcc-7): > > commit: c1e0d2be0acff5e99a59ddcc5af415e48abc6c5e ("mt76: mmio: introduce > mt76x02_check_tx_hang watchdog") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git

Re: [BUG/PATCH 0/4] gpiolib: fix issues with legacy spi-cs-high handling

2019-04-01 Thread Linus Walleij
On Mon, Apr 1, 2019 at 11:59 PM H. Nikolaus Schaller wrote: > I learned just some minutes ago that a new patch for gpiolib > came through 5.1-rc3 which does fix this in almost the same way > as I proposed. I am sorry for not being very attentive, I have been travelling. I collected the most

Re: [LKP] [btrfs] 70d28b0e4f: BUG:kernel_reboot-without-warning_in_early-boot_stage, last_printk:Probing_EDD(edd=off_to_disable)...ok

2019-04-01 Thread Rong Chen
On 4/1/19 11:40 PM, David Sterba wrote: On Mon, Apr 01, 2019 at 11:02:37PM +0800, Chen, Rong A wrote: On 4/1/2019 10:29 PM, Qu Wenruo wrote: On 2019/4/1 下午10:02, Chen, Rong A wrote: On 4/1/2019 9:28 PM, Nikolay Borisov wrote: On 1.04.19 г. 16:24 ч., kernel test robot wrote: FYI, we

[PATCH v3] gcov: fix when CONFIG_MODULES is not set

2019-04-01 Thread trong
From: Tri Vo Fixes: 8c3d220cb6b5 ("gcov: clang support") Cc: Greg Hackmann Cc: Peter Oberparleiter Cc: linux...@kvack.org Cc: kbuild-...@01.org Reported-by: Randy Dunlap Reported-by: kbuild test robot Link: https://marc.info/?l=linux-mm=155384681109231=2 Signed-off-by: Nick Desaulniers

[PATCH] clocksource/drivers/tegra: rework for compensation of suspend time

2019-04-01 Thread Joseph Lo
Since the clocksource framework has the support for suspend time compensation. Re-work the driver to use that, so we can reduce the duplicate code. Suggested-by: Daniel Lezcano Signed-off-by: Joseph Lo --- drivers/clocksource/timer-tegra20.c | 63 + 1 file changed,

Re: [PATCH 4.9 00/56] 4.9.167-stable review

2019-04-01 Thread Naresh Kamboju
On Mon, 1 Apr 2019 at 22:58, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.9.167 release. > There are 56 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

Re: [PATCH 4.4 000/131] 4.4.178-stable review

2019-04-01 Thread Naresh Kamboju
://git.linaro.org/lkft/arm64-stable-rc.git git branch: 4.4.178-rc1-hikey-20190401-414 git commit: 2d75babf7185cfb2ecd3c49eb62339fbf6e01ae1 git describe: 4.4.178-rc1-hikey-20190401-414 Test details: https://qa-reports.linaro.org/lkft/linaro-hikey-stable-rc-4.4-oe/build/4.4.178-rc1-hikey-20190401-414

Re: [PATCH v2] gcov: fix when CONFIG_MODULES is not set

2019-04-01 Thread Nick Desaulniers
On Sun, Mar 31, 2019 at 6:57 AM Tri Vo wrote: > > On Fri, Mar 29, 2019 at 1:53 PM Randy Dunlap wrote: > > > > On 3/29/19 11:18 AM, Nick Desaulniers wrote: > > > Fixes commit 8c3d220cb6b5 ("gcov: clang support") > > > > There is a certain format for Fixes: and that's not quite it. :( Looks like

[PATCH v2 8/8] livepatch: Replace klp_ktype_patch's default_attrs with groups

2019-04-01 Thread Kimberly Brown
The kobj_type default_attrs field is being replaced by the default_groups field. Replace klp_ktype_patch's default_attrs field with default_groups and use the ATTRIBUTE_GROUPS macro to create klp_patch_groups. This patch was tested by loading the livepatch-sample module and verifying that the

[PATCH v2 5/8] irqdesc: Replace irq_kobj_type's default_attrs field with groups

2019-04-01 Thread Kimberly Brown
The kobj_type default_attrs field is being replaced by the default_groups field. Replace irq_kobj_type's default_attrs field with default_groups and use the ATTRIBUTE_GROUPS macro to create irq_groups. This patch was tested by verifying that the sysfs files for the attributes in the default

[PATCH v2 7/8] cpufreq: schedutil: Replace default_attrs field with groups

2019-04-01 Thread Kimberly Brown
The kobj_type default_attrs field is being replaced by the default_groups field. Replace sugov_tunables_ktype's default_attrs field with default groups. Change "sugov_attributes" to "sugov_attrs" and use the ATTRIBUTE_GROUPS macro to create sugov_groups. This patch was tested by setting the

[PATCH v2 2/8] samples/kobject: Replace foo_ktype's default_attrs field with groups

2019-04-01 Thread Kimberly Brown
The kobj_type default_attrs field is being replaced by the default_groups field. Replace foo_ktype's default_attrs field with default_groups and use the ATTRIBUTE_GROUPS macro to create foo_default_groups. This patch was tested by loading the kset-example module and verifying that the sysfs files

[PATCH v2 1/8] kobject: Add support for default attribute groups to kobj_type

2019-04-01 Thread Kimberly Brown
kobj_type currently uses a list of individual attributes to store default attributes. Attribute groups are more flexible than a list of attributes because groups provide support for attribute visibility. So, add support for default attribute groups to kobj_type. In future patches, the existing

Re: [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function.

2019-04-01 Thread Life is hard, and then you die
On Thu, Mar 28, 2019 at 12:29:52PM +0100, Greg Kroah-Hartman wrote: > On Thu, Mar 28, 2019 at 03:27:55AM -0700, Life is hard, and then you die > wrote: > > > > On Thu, Mar 28, 2019 at 06:29:17AM +0100, Greg Kroah-Hartman wrote: > > > On Wed, Mar 27, 2019 at 05:28:17PM -0700, Life is hard, and

Re: [PATCH 1/2] printk: Add an option to flush all messages on panic

2019-04-01 Thread Feng Tang
Hi Mukesh, On Mon, Apr 01, 2019 at 05:20:33PM +0530, Mukesh Ojha wrote: > > On 4/1/2019 4:18 PM, Feng Tang wrote: > > Current console_flush_on_panic() will only dump the new messages > > in buffer, and users may need an opportunity to check all the > > messages on panic which could help

Re: [PATCH] vfio/type1: Limit DMA mappings per container

2019-04-01 Thread Peter Xu
On Mon, Apr 01, 2019 at 02:16:52PM -0600, Alex Williamson wrote: [...] > @@ -1081,8 +1088,14 @@ static int vfio_dma_do_map(struct vfio_iommu *iommu, > goto out_unlock; > } > > + if (!atomic_add_unless(>dma_avail, -1, 0)) { > + ret = -ENOSPC; > +

[mt76] c1e0d2be0a: BUG:pagefault_on_kernel_address#in_non-whitelisted_uaccess

2019-04-01 Thread kernel test robot
FYI, we noticed the following commit (built with gcc-7): commit: c1e0d2be0acff5e99a59ddcc5af415e48abc6c5e ("mt76: mmio: introduce mt76x02_check_tx_hang watchdog") https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master in testcase: trinity with following parameters:

Re: [PATCH 1/2] printk: Add an option to flush all messages on panic

2019-04-01 Thread Sergey Senozhatsky
On (04/02/19 10:28), Feng Tang wrote: > > So my first thought was - let's not add a `bool flag', but instead add > > an `enum' with clear flag names, e.g. DUMP_ALL/DUMP_PENDING, etc. Something > > similar to what ftrace_dump(DUMP_ALL) does. And we already have panic_print > > bit-mask and

Re: [PATCH 1/2] printk: Add an option to flush all messages on panic

2019-04-01 Thread Feng Tang
Hi Sergey, Thanks for the review. On Tue, Apr 02, 2019 at 11:14:19AM +0900, Sergey Senozhatsky wrote: > On (04/01/19 18:48), Feng Tang wrote: > > diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c > > index 1fd45a8..58d9580 100644 > > --- a/arch/powerpc/kernel/traps.c > > +++

Re: Nested events with zero deltas, can use absolute timestamps instead?

2019-04-01 Thread Steven Rostedt
On Mon, 1 Apr 2019 15:54:20 -0700 Jason Behmer wrote: > The concurrency model is still a little bit unclear to me as I'm new > to this codebase. So I'm having some trouble reasoning about what > operations are safe at one point on the ring buffer.It seems like > we can't be preempted in

Re: [PATCH 1/2] printk: Add an option to flush all messages on panic

2019-04-01 Thread Sergey Senozhatsky
On (04/01/19 18:48), Feng Tang wrote: > diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c > index 1fd45a8..58d9580 100644 > --- a/arch/powerpc/kernel/traps.c > +++ b/arch/powerpc/kernel/traps.c > @@ -179,7 +179,7 @@ extern void panic_flush_kmsg_end(void) >

Re: [PATCH 0/2] Add Updown Counter support for Milbeaut M10V SoC

2019-04-01 Thread Kanematsu , Shinji/兼松 伸次
Hi Jonathan, On 2019/03/31 3:36, Jonathan Cameron wrote: On Tue, 26 Mar 2019 15:32:34 +0900 Shinji Kanematsu wrote: This is a series of patch which adds Updown Counter support on Milbeaut M10V SoC. The Updown Counter counts input pulse signal from external quadrature encoder. It also has

Re: [PATCH v1 1/2] dt-bindings: mmc: sdhci-fujitsu.txt: add miilbeaut driver

2019-04-01 Thread orito.takao
Hi > On Tue, Mar 26, 2019 at 02:53:37PM +0900, Takao Orito wrote: > > Add new compatible description for Milbeaut SoC. Socionext > > inherits F_SDH30 IP from Fujitsu. Then new Soc series "Milbeaut" > > has F_SDH30 controller specified by "socionext,milbeaut-m10v-sdhci-3.0". > > Subject is

Re: [PATCH v2] avia-hx711.yaml: transform DT binding to YAML

2019-04-01 Thread Rob Herring
On Mon, Apr 1, 2019 at 12:34 PM Andreas Klinger wrote: > > replace avia-hx711.txt by avia-hx711.yaml as yaml devicetree > documentation for avia hx711 iio adc sensor > > Signed-off-by: Andreas Klinger > --- > .../devicetree/bindings/iio/adc/avia-hx711.txt | 24 >

Re: [PATCH v2] bmp085.yaml: transform DT documentation of iio sensor into YAML

2019-04-01 Thread Rob Herring
On Mon, Apr 1, 2019 at 12:32 PM Andreas Klinger wrote: > > use bmp085.txt and change it into yaml format > > fix links to datasheets in replaced documentation > > Signed-off-by: Andreas Klinger > --- > .../devicetree/bindings/iio/pressure/bmp085.txt| 27 - >

Re: [PATCH v4] HID: intel-ish-hid: ISH firmware loader client driver

2019-04-01 Thread Srinivas Pandruvada
On Sat, 2019-03-30 at 16:53 +0530, Rushikesh S Kadam wrote: > This driver adds support for loading Intel Integrated > Sensor Hub (ISH) firmware from host file system to ISH > SRAM and start execution. > > At power-on, the ISH subsystem shall boot to an interim > Shim loader-firmware, which shall

[PATCH] au0828: Fix NULL pointer dereference in au0828_analog_stream_enable()

2019-04-01 Thread Shuah Khan
Fix au0828_analog_stream_enable() to check if device is in the right state first. When unbind happens while bind is in progress, usbdev pointer could be invalid in au0828_analog_stream_enable() and a call to usb_ifnum_to_if() will result in the null pointer dereference. This problem is found with

Re: [PATCH v4] HID: intel-ish-hid: ISH firmware loader client driver

2019-04-01 Thread Srinivas Pandruvada
On Mon, 2019-04-01 at 17:13 -0600, Nick Crews wrote: > Looks good to me! Thanks for the work! > So I assume, Rushikesh can add your Reviewed-by. Thanks, Srinivas > On Sat, Mar 30, 2019 at 5:23 AM Rushikesh S Kadam > wrote: > > > > This driver adds support for loading Intel Integrated > >

Re: [rcu:dev.2019.03.20b 54/83] drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c:50:1: error: type defaults to 'int' in declaration of 'DEFINE_SRCU'

2019-04-01 Thread Rong Chen
On 3/28/19 3:57 AM, Paul E. McKenney wrote: On Mon, Mar 25, 2019 at 02:34:27AM +0800, kbuild test robot wrote: tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2019.03.20b head: 6d4434b4b4df791620743178e1419de882b44c7b commit:

Re: [PATCH v5 00/11] tracing: common error_log for ftrace

2019-04-01 Thread Masami Hiramatsu
On Mon, 01 Apr 2019 08:31:08 -0500 Tom Zanussi wrote: > > > BTW, could you also add a testcase which tests all (or most of) > > error cases of hist_err() ? > > That will be good to find regressions in future changes. > > > > I was going to, but there are a lot of error cases and a lot of them

Re: [RFCv2] string: Use faster alternatives when constant arguments are used

2019-04-01 Thread Sultan Alsawaf
On Mon, Apr 01, 2019 at 10:43:13PM +0200, Rasmus Villemoes wrote: > Consider your patch replacing !strcmp(buf, "123") by !memcmp(buf, "123", > 4). buf is known to point to a nul-terminated string. But it may point > at, say, the second-last byte in a page, with the last byte in that page > being a

Re: [PATCH v3] tpm: Actually fail on TPM errors during "get random"

2019-04-01 Thread Jarkko Sakkinen
On Mon, Apr 01, 2019 at 12:06:07PM -0700, Kees Cook wrote: > A "get random" may fail with a TPM error, but those codes were returned > as-is to the caller, which assumed the result was the number of bytes > that had been written to the target buffer, which could lead to a kernel > heap memory

Re: linux-next: build failure after merge of the nand tree

2019-04-01 Thread Paul Cercueil
tree from next-20190401 for today. That makes no sense to me; from the offsets of the errors in the ingenic_ecc.h file, it seems that CONFIG_MTD_NAND_INGENIC_ECC is not set, and in this case ingenic_ecc.c should not be compiled at all. -Paul

  1   2   3   4   5   6   7   8   9   10   >