[PATCH] staging: ks7010: Remove initialisation

2019-05-23 Thread Nishka Dasgupta
As the initial value of the return variable result is never used, it can be removed. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c

Re: [PATCH] ALSA: Use struct_size() helper

2019-05-23 Thread Takashi Iwai
On Thu, 23 May 2019 22:29:17 +0200, Gustavo A. R. Silva wrote: > > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes, in particular in the > context in which this code is being used. > > So, replace the following form: > >

Re: Please cherrypick 592acbf1682128 to 3.18.y and 4.4.y

2019-05-23 Thread Greg KH
On Thu, May 23, 2019 at 01:49:27PM -0700, Mark Salyzyn wrote: > Cherry pick security-related fix 592acbf16821288ecdc4192c47e3774a4c48bb64 > ("ext4: zero out the unused memory region in the extent tree block") to > 3.18.y and 4.4.y > > The cherry-pick is clean and requires no back-porting. Is

Re: [PATCH] staging: mt7621-pci: pci-mt7621: Remove unneeded variable err

2019-05-23 Thread Sergio Paracuellos
Hi Hariprasad, On Thu, May 23, 2019 at 8:35 PM Hariprasad Kelam wrote: > > devm_request_pci_bus_resources function will return -EBUSY/-ENOMEM > in fail case and returns 0 on success. > > So no need to store return value in err variable. > > Signed-off-by: Hariprasad Kelam > --- >

RE: [PATCH 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling

2019-05-23 Thread Anson Huang
Hi, Shawn > -Original Message- > From: Shawn Guo [mailto:shawn...@kernel.org] > Sent: Thursday, May 23, 2019 8:41 PM > To: Anson Huang > Cc: s.ha...@pengutronix.de; ker...@pengutronix.de; feste...@gmail.com; > Leonard Crestez ; Abel Vesa > ; viresh.ku...@linaro.org; linux-arm- >

Re: [PATCH 4.14 00/77] 4.14.122-stable review

2019-05-23 Thread Greg Kroah-Hartman
On Fri, May 24, 2019 at 09:28:05AM +0900, Nobuhiro Iwamatsu wrote: > Hi. > > 2019年5月24日(金) 4:11 Greg Kroah-Hartman : > > > > This is the start of the stable review cycle for the 4.14.122 release. > > There are 77 patches in this series, all will be posted as a response > > to this one. If anyone

[PATCH] staging: ks7010: Remove initialisation

2019-05-23 Thread Nishka Dasgupta
The initial value of return variable ret is never used, so it can be removed. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/ks7010/ks_hostif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_hostif.c

Re: [PATCH v1 0/5] Solve postboot supplier cleanup and optimize probe ordering

2019-05-23 Thread Greg Kroah-Hartman
On Thu, May 23, 2019 at 06:01:11PM -0700, Saravana Kannan wrote: > Add a generic "depends-on" property that allows specifying mandatory > functional dependencies between devices. Add device-links after the > devices are created (but before they are probed) by looking at this > "depends-on"

RE: [PATCH 3/3] arm64: dts: imx8mq: add clock for SNVS RTC node

2019-05-23 Thread Anson Huang
Hi, Shawn > -Original Message- > From: Shawn Guo [mailto:shawn...@kernel.org] > Sent: Thursday, May 23, 2019 9:03 AM > To: Anson Huang > Cc: robh...@kernel.org; mark.rutl...@arm.com; s.ha...@pengutronix.de; > ker...@pengutronix.de; feste...@gmail.com; mturque...@baylibre.com; >

mainline/master boot bisection: v5.2-rc1-172-g4dde821e4296 on meson-g12a-x96-max

2019-05-23 Thread kernelci.org bot
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the

Re: 答复: 答复: 答复: [PATCH] input: alps-fix the issue the special alps trackpoint do not work.

2019-05-23 Thread Hui Wang
On 2019/5/24 下午1:36, Peter Hutterer wrote: On Fri, May 24, 2019 at 01:25:52PM +0800, Hui Wang wrote: On 2019/5/23 下午2:01, Peter Hutterer wrote: On Wed, May 22, 2019 at 09:40:30AM +0200, Pali Rohár wrote: On Wednesday 22 May 2019 07:30:43 Xiaoxiao Liu wrote: Hi Pali, Ok, and cannot you set

[PATCH RESEND 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling

2019-05-23 Thread Anson . Huang
From: Anson Huang of_node_put() is called after of_match_node() successfully called, then in the following error handling, of_node_put() is called again which is unnecessary, this patch adjusts the location of of_node_put() to avoid such scenario. Signed-off-by: Anson Huang Reviewed-by:

[PATCH RESEND 2/2] soc: imx: soc-imx8: Correct return value of error handle

2019-05-23 Thread Anson . Huang
From: Anson Huang Current implementation of i.MX8 SoC driver returns -ENODEV for all cases of error during initialization, this is incorrect. This patch fixes them using correct return value according to different errors. Signed-off-by: Anson Huang Reviewed-by: Leonard Crestez ---

Re: [PATCH v1 5/5] driver core: Add sync_state driver/bus callback

2019-05-23 Thread Greg Kroah-Hartman
On Thu, May 23, 2019 at 06:01:16PM -0700, Saravana Kannan wrote: > This sync_state driver/bus callback is called once all the consumers > of a supplier have probed successfully. > > This allows the supplier device's driver/bus to sync the supplier > device's state to the software state with the

Re: [PATCH v1 2/5] driver core: Add device links support for pending links to suppliers

2019-05-23 Thread Greg Kroah-Hartman
On Thu, May 23, 2019 at 06:01:13PM -0700, Saravana Kannan wrote: > When consumer devices are added, they might not have a supplier device > to link to despite needing mandatory resources/functionality from one > or more suppliers. Add a waiting_for_suppliers list to track such > consumers and add

Re: [PATCH V3 2/4] arm64/mm: Hold memory hotplug lock while walking for kernel page table dump

2019-05-23 Thread Anshuman Khandual
On 05/23/2019 02:10 PM, David Hildenbrand wrote: > On 16.05.19 13:16, Michal Hocko wrote: >> On Thu 16-05-19 16:36:12, Anshuman Khandual wrote: >>> On 05/16/2019 03:53 PM, Mark Rutland wrote: Hi Michal, On Wed, May 15, 2019 at 06:58:47PM +0200, Michal Hocko wrote: > On Tue

[PATCH RESEND] arm64: dts: imx8mq: add clock for SNVS RTC node

2019-05-23 Thread Anson . Huang
From: Anson Huang i.MX8MQ has clock gate for SNVS module, add clock info to SNVS RTC node for clock management. Signed-off-by: Anson Huang --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi

[PATCH] clocksource: arc_timer: use BIT() instead of _BITUL()

2019-05-23 Thread Masahiro Yamada
This is in-kernel C code, so there is no reason to use _BITUL(). Replace it with equivalent BIT(). I added #include explicitly although it has been included by other headers eventually. Signed-off-by: Masahiro Yamada --- drivers/clocksource/arc_timer.c | 3 ++- 1 file changed, 2

Re: [v4 PATCH 1/2] mm: vmscan: remove double slab pressure by inc'ing sc->nr_scanned

2019-05-23 Thread Yang Shi
On 5/24/19 12:15 PM, Hillf Danton wrote: On Thu, 23 May 2019 10:27:37 +0800 Yang Shi wrote: The commit 9092c71bb724 ("mm: use sc->priority for slab shrink targets") has broken up the relationship between sc->nr_scanned and slab pressure. The sc->nr_scanned can't double slab pressure anymore.

Re: 答复: 答复: 答复: [PATCH] input: alps-fix the issue the special alps trackpoint do not work.

2019-05-23 Thread Peter Hutterer
On Fri, May 24, 2019 at 01:25:52PM +0800, Hui Wang wrote: > > On 2019/5/23 下午2:01, Peter Hutterer wrote: > > On Wed, May 22, 2019 at 09:40:30AM +0200, Pali Rohár wrote: > > > On Wednesday 22 May 2019 07:30:43 Xiaoxiao Liu wrote: > > > > Hi Pali, > > > > > > > > Ok, and cannot you set

Re: [PATCH] net: ll_temac: Fix compile error

2019-05-23 Thread David Miller
From: Esben Haabendal Date: Fri, 24 May 2019 07:24:42 +0200 > Fixes: 1b3fa5cf859b ("net: ll_temac: Cleanup multicast filter on change") > Signed-off-by: Esben Haabendal Applied.

Re: [PATCH 4.9 00/53] 4.9.179-stable review

2019-05-23 Thread kernelci.org bot
stable-rc/linux-4.9.y boot: 107 boots: 0 failed, 94 passed with 13 offline (v4.9.178-54-gf6bc31d8c3be) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.9.y/kernel/v4.9.178-54-gf6bc31d8c3be/ Full Build Summary:

bpf build error

2019-05-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:e6f6cd0d bpf: sockmap, fix use after free from sleep in ps.. git tree: bpf console output: https://syzkaller.appspot.com/x/log.txt?x=16f116e4a0 kernel config: https://syzkaller.appspot.com/x/.config?x=fc045131472947d7

Re: [RFC PATCH 00/11] bpf, trace, dtrace: DTrace BPF program type implementation and sample use

2019-05-23 Thread Kris Van Hees
On Thu, May 23, 2019 at 07:08:51PM -0700, Alexei Starovoitov wrote: > On Thu, May 23, 2019 at 09:57:37PM -0400, Steven Rostedt wrote: > > On Thu, 23 May 2019 17:31:50 -0700 > > Alexei Starovoitov wrote: > > > > > > > > Now from what I'm reading, it seams that the Dtrace layer may be > > > >

Re: 答复: 答复: 答复: [PATCH] input: alps-fix the issue the special alps trackpoint do not work.

2019-05-23 Thread Hui Wang
On 2019/5/23 下午2:01, Peter Hutterer wrote: On Wed, May 22, 2019 at 09:40:30AM +0200, Pali Rohár wrote: On Wednesday 22 May 2019 07:30:43 Xiaoxiao Liu wrote: Hi Pali, Ok, and cannot you set ALPS_DUALPOINT flag based on that alps_check_is_trackpoint() result and then update

[PATCH] net: ll_temac: Fix compile error

2019-05-23 Thread Esben Haabendal
Fixes: 1b3fa5cf859b ("net: ll_temac: Cleanup multicast filter on change") Signed-off-by: Esben Haabendal --- drivers/net/ethernet/xilinx/ll_temac_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c

Re: [PATCH 2/3] firmware: add offset to request_firmware_into_buf

2019-05-23 Thread Greg Kroah-Hartman
On Thu, May 23, 2019 at 10:01:38PM -0700, Scott Branden wrote: > > On 2019-05-23 9:54 a.m., Greg Kroah-Hartman wrote: > > On Thu, May 23, 2019 at 09:36:02AM -0700, Scott Branden wrote: > > > Hi Greg, > > > > > > On 2019-05-22 10:52 p.m., Greg Kroah-Hartman wrote: > > > > On Wed, May 22, 2019 at

Re: [RFC PATCH 00/11] bpf, trace, dtrace: DTrace BPF program type implementation and sample use

2019-05-23 Thread Kris Van Hees
On Thu, May 23, 2019 at 07:02:43PM -0400, Steven Rostedt wrote: > On Thu, 23 May 2019 14:13:31 -0700 > Alexei Starovoitov wrote: > > > > In DTrace, people write scripts based on UAPI-style interfaces and they > > > don't > > > have to concern themselves with e.g. knowing how to get the value of

Re: [PATCH v7 3/3] i2c-ocores: sifive: add polling mode workaround for FU540-C000 SoC.

2019-05-23 Thread Sagar Kadam
On Thu, May 23, 2019 at 7:23 PM Wolfram Sang wrote: > > > > Ok, Great. Do we need to write to him about this patchset? > > Nope. Hint: You can dig in the mail archives studying older patches to > see how things work. I do this as well because things may work > differently per subsystem. > Thanks

Re: [PATCH net 4/4] net/udpgso_bench_tx: audit error queue

2019-05-23 Thread Willem de Bruijn
On Thu, May 23, 2019 at 9:27 PM Fred Klassen wrote: > > Willem, this is only my 2nd patch, and my last one was a one liner. > I’ll try to work through this, but let me know if I am doing a rookie > mistake (learning curve and all). Not at all. The fix makes perfect sense. The test patches 2 and

Re: need company for kernel upgrade

2019-05-23 Thread Theodore Ts'o
On Thu, May 23, 2019 at 09:29:11AM +0200, walter harms wrote: > > No, > the company i am working for has a custom build arm-board. > We bought the kernel from the assembler but found it has > some problems that need fixing. > Basically we want to improve the linux-kernel so it can run > native on

Re: [PATCH 2/3] firmware: add offset to request_firmware_into_buf

2019-05-23 Thread Scott Branden
On 2019-05-23 9:54 a.m., Greg Kroah-Hartman wrote: On Thu, May 23, 2019 at 09:36:02AM -0700, Scott Branden wrote: Hi Greg, On 2019-05-22 10:52 p.m., Greg Kroah-Hartman wrote: On Wed, May 22, 2019 at 07:51:12PM -0700, Scott Branden wrote: Add offset to request_firmware_into_buf to allow for

Re: [PATCH 1/2] net/macb: bindings doc: add sifive fu540-c000 binding

2019-05-23 Thread Yash Shah
On Fri, May 24, 2019 at 2:20 AM Rob Herring wrote: > > On Thu, May 23, 2019 at 6:46 AM Yash Shah wrote: > > > > Add the compatibility string documentation for SiFive FU540-C > > interface. > > On the FU540, this driver also needs to read and write registers in a > > management IP block that

Re: PSA: Do not use "Reported-By" without reporter's approval

2019-05-23 Thread Theodore Ts'o
On Wed, May 22, 2019 at 03:58:04PM -0400, Konstantin Ryabitsev wrote: > > If the report is public, and lists like vger are public, > > then using a Reported-by: and/or a Link: are simply useful > > history and tracking information. > > I'm perfectly fine with Link:, however Reported-By: usually

Re: [PATCH 0/2] net: macb: Add support for SiFive FU540-C000

2019-05-23 Thread Yash Shah
On Thu, May 23, 2019 at 9:58 PM David Miller wrote: > > > Please be consistent in your subsystem prefixes used in your Subject lines. > You use "net: macb:" then "net/macb:" Really, plain "macb: " is sufficient. Sure, Will take care of this in the next revision of this patch. Thanks for your

Re: [PATCH net 1/4] net/udp_gso: Allow TX timestamp with UDP GSO

2019-05-23 Thread Willem de Bruijn
On Thu, May 23, 2019 at 9:38 PM Fred Klassen wrote: > > > Thanks for the report. > > > > Zerocopy notification reference count is managed in skb_segment. That > > should work. > > > > Support for timestamping with the new GSO feature is indeed an > > oversight. The solution is similar to how TCP

[PATCH] MIPS: replace MBIT_ULL() with BIT_ULL()

2019-05-23 Thread Masahiro Yamada
Commit 8bd9cb51daac ("locking/atomics, asm-generic: Move some macros from to a new file") moved BIT_ULL() into . It only includes , so there is no longer "include file recursion hell". Signed-off-by: Masahiro Yamada --- arch/mips/include/asm/cpu.h | 125 +---

Re: [PATCH V4 3/4] arm64/mm: Hold memory hotplug lock while walking for kernel page table dump

2019-05-23 Thread Anshuman Khandual
On 05/21/2019 03:44 PM, Michal Hocko wrote: > On Mon 20-05-19 10:48:35, Anshuman Khandual wrote: >> The arm64 page table dump code can race with concurrent modification of the >> kernel page tables. When a leaf entries are modified concurrently, the dump >> code may log stale or inconsistent

Re: [PATCH 2/2] net: macb: Add support for SiFive FU540-C000

2019-05-23 Thread Yash Shah
On Thu, May 23, 2019 at 8:24 PM Andrew Lunn wrote: > > > +static int fu540_macb_tx_set_rate(struct clk_hw *hw, unsigned long rate, > > + unsigned long parent_rate) > > +{ > > + rate = fu540_macb_tx_round_rate(hw, rate, _rate); > > + iowrite32(rate !=

Re: [PATCH 0/2] net: macb: Add support for SiFive FU540-C000

2019-05-23 Thread Yash Shah
Hi Andreas, On Thu, May 23, 2019 at 6:19 PM Andreas Schwab wrote: > > On Mai 23 2019, Yash Shah wrote: > > > On FU540, the management IP block is tightly coupled with the Cadence > > MACB IP block. It manages many of the boundary signals from the MACB IP > > This patchset controls the tx_clk

linux-next: Fixes tag needs some work in the cifs tree

2019-05-23 Thread Stephen Rothwell
Hi all, In commit f875253b5fe6 ("fs/cifs/smb2pdu.c: fix buffer free in SMB2_ioctl_free") Fixes tag Fixes: 2c87d6a ("cifs: Allocate memory for all iovs in smb2_ioctl") has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or more)

Re: [PATCH 2/2] auxdisplay/ht16k33.c: Convert to use vm_map_pages_zero()

2019-05-23 Thread Miguel Ojeda
On Thu, May 23, 2019 at 2:58 PM Miguel Ojeda wrote: > > Taking a quick look now, by the way, why does vm_map_pages_zero() (and > __vm_map_pages() etc.) get a pointer to an array instead of a pointer > to the first element? Also, in __vm_map_pages(), semantically w.r.t. to the comment, shouldn't

drivers/net//ethernet/hisilicon/hns/hns_dsaf_main.c:2597:1: warning: the frame size of 10976 bytes is larger than 8192 bytes

2019-05-23 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4dde821e4296e156d133b98ddc4c45861935a4fb commit: 81a56f6dcd20325607d6008f4bb560c96f4c821a gcc-plugins: structleak: Generalize to all variable types date: 3 months ago config: s390-allmodconfig (attached

linux-next: Tree for May 24

2019-05-23 Thread Stephen Rothwell
Hi all, News: there will be no linux-next release on Monday. Changes since 20190523: The input-current tree gained a build failure so I reverted a commit. The drm-fixes tree gained a build failure so I reverted a commit. The v4l-dvb tree gained a conflict against Linus' tree. Non-merge

Re: [RFC PATCH 00/11] bpf, trace, dtrace: DTrace BPF program type implementation and sample use

2019-05-23 Thread Kris Van Hees
On Thu, May 23, 2019 at 02:13:31PM -0700, Alexei Starovoitov wrote: > On Thu, May 23, 2019 at 01:46:10AM -0400, Kris Van Hees wrote: > > > > I think there is a difference between a solution and a good solution. > > Adding > > a lot of knowledge in the userspace component about how things are >

Re: [PATCH] tracing: silence GCC 9 array bounds warning

2019-05-23 Thread Miguel Ojeda
On Fri, May 24, 2019 at 4:12 AM Steven Rostedt wrote: > > On Thu, 23 May 2019 14:45:35 +0200 > Miguel Ojeda wrote: > > I still prefer the typecast of void *, as that's used a bit more in the > kernel, but since char * is also used (not as much), I'll leave it. But > the parenthesis around iter

Re: [PATCH] mm/swap: Fix release_pages() when releasing devmap pages

2019-05-23 Thread Dan Williams
On Thu, May 23, 2019 at 3:37 PM wrote: > > From: Ira Weiny > > Device pages can be more than type MEMORY_DEVICE_PUBLIC. > > Handle all device pages within release_pages() > > This was found via code inspection while determining if release_pages() > and the new put_user_pages() could be

Re: [PATCH 4.19 000/114] 4.19.46-stable review

2019-05-23 Thread kernelci.org bot
stable-rc/linux-4.19.y boot: 125 boots: 0 failed, 112 passed with 13 offline (v4.19.45-115-g071ff9cc9849) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.19.y/kernel/v4.19.45-115-g071ff9cc9849/ Full Build Summary:

Re: [PATCH v2] initramfs: Fix a missing-chek bug in dir_add()teven.pr...@arm.com、

2019-05-23 Thread Gen Zhang
On Thu, May 23, 2019 at 08:35:23PM -0700, Andrew Morton wrote: > On Fri, 24 May 2019 11:30:45 +0800 Gen Zhang wrote: > > > In dir_add() and do_name(), de->name and vcollected are allocated by > > kstrdup(). And de->name and vcollected are dereferenced in the following > > codes. However, memory

[PATCH v2] ASoC: drop COMPILE_TEST for sound/soc/intel/boards/ that use X86_INTEL_LPSS

2019-05-23 Thread Randy Dunlap
From: Randy Dunlap This is a partial revert of 164a263bf8d0, which causes build errors on non-X86 platforms (specifically seen on IA64) when COMPILE_TEST is set/enabled. Fixes these build errors (on ia64): i../sound/soc/intel/boards/bxt_da7219_max98357a.c:19:10: fatal error:

Re: [PATCH v2] initramfs: Fix a missing-chek bug in dir_add()

2019-05-23 Thread Andrew Morton
On Fri, 24 May 2019 11:30:45 +0800 Gen Zhang wrote: > In dir_add() and do_name(), de->name and vcollected are allocated by > kstrdup(). And de->name and vcollected are dereferenced in the following > codes. However, memory allocation functions such as kstrdup() may fail. > Dereferencing this

[PATCH 1/2] media: add generic device allocate interface to media-dev-allocator

2019-05-23 Thread Shuah Khan
Media Device Allocator API supports just USB devices. Enhance it adding a genetic device allocate interface to support other media drivers. The new interface takes pointer to struct device instead and creates media device. This interface allows a group of drivers that have a common root device to

[PATCH 0/2] Use Media Dev Allocator to fix vimc dev lifetime bugs

2019-05-23 Thread Shuah Khan
media_device is embedded in struct vimc_device and when vimc is removed vimc_device and the embedded media_device goes with it, while the active stream and vimc_capture continue to access it. Fix the media_device lifetime problem by changing vimc to create shared media_device using Media Device

[PATCH v2] initramfs: Fix a missing-chek bug in dir_add()

2019-05-23 Thread Gen Zhang
In dir_add() and do_name(), de->name and vcollected are allocated by kstrdup(). And de->name and vcollected are dereferenced in the following codes. However, memory allocation functions such as kstrdup() may fail. Dereferencing this null pointer may cause the kernel go wrong. Thus we should check

[PATCH 2/2] vimc: fix BUG: unable to handle kernel NULL pointer dereference

2019-05-23 Thread Shuah Khan
If vimc module is removed while streaming is active, vimc_exit runs into NULL pointer dereference error when streaming thread tries to access and lock graph_mutex in the struct media_device. media_device is embedded in struct vimc_device and when vimc is removed vimc_device and the embedded

[PATCH] staging: iio: adis16240: add of_match_table entry

2019-05-23 Thread Rodrigo Ribeiro
This patch adds of_match_table entry in device driver in order to enable spi fallback probing. Signed-off-by: Rodrigo Ribeiro Reviewed-by: Marcelo Schmitt --- drivers/staging/iio/accel/adis16240.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/iio/accel/adis16240.c

[PATCH] ip_sockglue: Fix missing-check bug in ip_ra_control()

2019-05-23 Thread Gen Zhang
In function ip_ra_control(), the pointer new_ra is allocated a memory space via kmalloc(). And it is used in the following codes. However, when there is a memory allocation error, kmalloc() fails. Thus null pointer dereference may happen. And it will cause the kernel to crash. Therefore, we

RE: [PATCH v2 09/10] Input: elan_i2c - correct the width/size base value

2019-05-23 Thread 廖崇榮
Hi Benjamin, Thanks so much for all you do for Elan touchpad. For the width_*, I have a question for it. Our antenna sensors fully occupied the whole touchpad PCB. The Gap between 2 sensors are 7.5 mil (0.19mm). That's why we did not minus one trace. Thanks KT -Original Message- From:

RE: [EXT] Re: [PATCH] dt-bindings: thermal: Make cooling-maps property optional

2019-05-23 Thread Andy Tang
> -Original Message- > From: Eduardo Valentin > Sent: 2019年5月24日 10:50 > To: Andy Tang > Cc: rui.zh...@intel.com; robh...@kernel.org; daniel.lezc...@linaro.org; > mark.rutl...@arm.com; linux...@vger.kernel.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [EXT]

[PATCH] ipv6_sockglue: Fix a missing-check bug in ip6_ra_control()

2019-05-23 Thread Gen Zhang
In function ip6_ra_control(), the pointer new_ra is allocated a memory space via kmalloc(). And it is used in the following codes. However, when there is a memory allocation error, kmalloc() fails. Thus null pointer dereference may happen. And it will cause the kernel to crash. Therefore, we

Re: [PATCH v18 1/3] proc: add /proc//arch_status

2019-05-23 Thread Andrew Morton
On Thu, 25 Apr 2019 22:32:17 +0800 Aubrey Li wrote: > The architecture specific information of the running processes > could be useful to the userland. Add /proc//arch_status > interface support to examine process architecture specific > information externally. I'll give this an Acked-by:

[PATCH] arm64: break while loop if task had been rescheduled

2019-05-23 Thread tengfeif
When task isn't current task, this task's state have chance to be changed during printing this task's backtrace, so it is possible that task's fp and fp+8 have the same vaule, so cannot break the while loop. To fix this issue, we first save the task's state, sp and fp, then we will get the task's

Re: [PATCHv2] kernel/crash: make parse_crashkernel()'s return value more indicant

2019-05-23 Thread Pingfan Liu
Matthias, ping? Any suggestions? Thanks, Pingfan On Thu, May 2, 2019 at 2:22 PM Pingfan Liu wrote: > > On Thu, Apr 25, 2019 at 4:20 PM Pingfan Liu wrote: > > > > On Wed, Apr 24, 2019 at 4:31 PM Matthias Brugger wrote: > > > > > > > > [...] > > > > @@ -139,6 +141,8 @@ static int __init

Re: [PATCH RFC v8 01/10] namei: obey trailing magic-link DAC permissions

2019-05-23 Thread Aleksa Sarai
On 2019-05-23, Aleksa Sarai wrote: > On 2019-05-22, Andy Lutomirski wrote: > > What are actual examples of uses for this exception? Breaking > > selftests is not, in and of itself, a huge problem. > > Not as far as I know. All of the re-opening users I know of do re-opens > of O_PATH or are

Re: [PATCH 5.0 000/139] 5.0.19-stable review

2019-05-23 Thread kernelci.org bot
stable-rc/linux-5.0.y boot: 133 boots: 0 failed, 118 passed with 14 offline, 1 untried/unknown (v5.0.18-140-gc7802929531b) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-5.0.y/kernel/v5.0.18-140-gc7802929531b/ Full Build Summary:

Re: [PATCH 4.14 00/77] 4.14.122-stable review

2019-05-23 Thread kernelci.org bot
stable-rc/linux-4.14.y boot: 125 boots: 2 failed, 108 passed with 15 offline (v4.14.121-78-g64cb9b0bb7de) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.14.y/kernel/v4.14.121-78-g64cb9b0bb7de/ Full Build Summary:

Re: [RFC] Allowing modules to control tracing subsystem

2019-05-23 Thread Steven Rostedt
On Tue, 02 Apr 2019 08:44:31 +0300 Felipe Balbi wrote: > Hi, > > Felipe Balbi writes: Hi Felipe, I somehow missed both your original email and this gentle reminder. > > Hi guys, > > > > I've been thinking about turning my f-trace.c USB function [1] into an > > implementation of the USB

[PATCH] i2c: layerscape: use PIO when fail to request dma channel

2019-05-23 Thread Qiang Zhao
When fail to request DMA TX/RX channel, use PIO instead for layerscape. Signed-off-by: Zhao Qiang --- drivers/i2c/busses/i2c-imx.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index 98b278613cf2..39a5ab4cf332 100644

Re: [PATCH selftests 0/2] Add checkbashisms meta-testcase

2019-05-23 Thread shuah
On 5/23/19 8:31 PM, Steven Rostedt wrote: Shuah, Want to take this or would you want me to? -- Steve I can take them through my tree. thanks, -- Shuah

Re: [PATCH v2] staging: kpc2000: Add dependency on MFD_CORE to kconfig symbol 'KPC2000'

2019-05-23 Thread Geordan Neukum
On Fri, May 24, 2019 at 2:38 AM Geordan Neukum wrote: > + depends on MFD_CORE In order for this to work in menuconfig, this either needs to be a select or I need to add a prompt to MFD_CORE. I don't have strong feelings either way, but all other Kconfig options which are related to the

[PATCH] wlcore: spi: Fix a memory leaking bug in wl1271_probe()

2019-05-23 Thread Gen Zhang
In wl1271_probe(), 'glue->core' is allocated by platform_device_alloc(), when this allocation fails, ENOMEM is returned. However, 'pdev_data' and 'glue' are allocated by devm_kzalloc() before 'glue->core'. When platform_device_alloc() returns NULL, we should also free 'pdev_data' and 'glue' before

Re: [alsa-devel] [PATCH] ASoc: fix sound/soc/intel/skylake/slk-ssp-clk.c build error on IA64

2019-05-23 Thread Randy Dunlap
On 5/23/19 4:28 AM, Pierre-Louis Bossart wrote: > > > On 5/22/19 10:58 PM, Randy Dunlap wrote: >> From: Randy Dunlap >> >> skl-ssp-clk.c does not build on IA64 because the driver >> uses the common clock interface, so make the driver depend >> on COMMON_CLK. >> >> Fixes this build error: >>

Re: Correct commit mask for page data size

2019-05-23 Thread Steven Rostedt
On Mon, 1 Apr 2019 06:49:07 -0700 Jason Behmer wrote: Hi Jason, I just noticed this email. I know it's a late response, but since you Cc'd LKML, I figured I would respond anyway, and at least have an answer in the archives ;-) > Hi Steven, > We're wondering what the correct number of bits to

Re: BUG: spinlock bad magic in rhashtable_walk_enter

2019-05-23 Thread hujunwei
On 2019/5/24 9:58, syzbot wrote: > syzbot has bisected this bug to: > > commit 7e27e8d6130c5e88fac9ddec4249f7f2337fe7f8 > Author: Junwei Hu > Date:   Thu May 16 02:51:15 2019 + > >     tipc: switch order of device registration to fix a crash> > bisection log: 

[PATCH v1] ipvs: add checksum support for gue encapsulation

2019-05-23 Thread Jacky Hu
Add checksum support for gue encapsulation with the tun_flags parameter, which could be one of the values below: IP_VS_TUNNEL_ENCAP_FLAG_NOCSUM IP_VS_TUNNEL_ENCAP_FLAG_CSUM IP_VS_TUNNEL_ENCAP_FLAG_REMCSUM Signed-off-by: Jacky Hu --- include/net/ip_vs.h | 2 +

Re: [PATCH 5/7] lib: rework bitmap_parse()

2019-05-23 Thread Andrew Morton
On Thu, 9 May 2019 19:26:33 -0700 Yury Norov wrote: > Hi Andy, > > Thanks for thorough review. > > On Wed, May 08, 2019 at 11:46:32AM +0300, Andy Shevchenko wrote: > > On Tue, Apr 30, 2019 at 06:06:34PM -0700, Yury Norov wrote: > > > bitmap_parse() is ineffective and full of opaque variables

Re: [PATCH] dt-bindings: thermal: Make cooling-maps property optional

2019-05-23 Thread Eduardo Valentin
On Wed, May 15, 2019 at 05:36:47PM +0800, Yuantian Tang wrote: > There may be no cooling device on system, or there are no enough > cooling devices for each thermal zone in multiple thermal zone > cases since cooling devices can't be shared. > So make this property optional to remove such

Re: [PATCH] thermal/drivers/of: Add a get_temp_id callback function

2019-05-23 Thread Andrey Smirnov
On Mon, Apr 29, 2019 at 9:51 AM Daniel Lezcano wrote: > > On 24/04/2019 01:08, Daniel Lezcano wrote: > > On 23/04/2019 17:44, Eduardo Valentin wrote: > >> Hello, > >> > >> On Tue, Apr 16, 2019 at 07:22:03PM +0200, Daniel Lezcano wrote: > >>> Currently when we register a sensor, we specify the

[PATCH] md: md.c: Return -ENODEV when mddev is NULL in rdev_attr_show

2019-05-23 Thread Marcos Paulo de Souza
Commit c42d3240990814eec1e4b2b93fa0487fc4873aed ("md: return -ENODEV if rdev has no mddev assigned") changed rdev_attr_store to return -ENODEV when rdev->mddev is NULL, now do the same to rdev_attr_show. Signed-off-by: Marcos Paulo de Souza --- drivers/md/md.c | 2 +- 1 file changed, 1

[PATCH v2] wlcore: sdio: Fix a memory leaking bug in wl1271_probe()

2019-05-23 Thread Gen Zhang
In wl1271_probe(), 'glue->core' is allocated by platform_device_alloc(), when this allocation fails, ENOMEM is returned. However, 'pdev_data' and 'glue' are allocated by devm_kzalloc() before 'glue->core'. When platform_device_alloc() returns NULL, we should also free 'pdev_data' and 'glue' before

Re: [PATCH i2c/slave-mqueue v5] i2c: slave-mqueue: add a slave backend to receive and queue messages

2019-05-23 Thread Wang, Haiyue
Thanks for interest, the design idea is from: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/i2c/i2c-slave-eeprom.c?h=v5.2-rc1 and https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/i2c/slave-interface Then you will get the

Re: [RFC PATCH 00/11] bpf, trace, dtrace: DTrace BPF program type implementation and sample use

2019-05-23 Thread Steven Rostedt
[ Added Linus and Al ] On Thu, 23 May 2019 19:08:51 -0700 Alexei Starovoitov wrote: > > > > > > > > I wish that was totally true, but tracepoints *can* be an abi. I had > > > > code reverted because powertop required one to be a specific > > > > format. To this day, the wakeup event has a

Re: [GIT PULL] Thermal-SoC management changes for v5.2-rc1

2019-05-23 Thread Eduardo Valentin
On Thu, May 23, 2019 at 11:46:47AM +0200, Tomeu Vizoso wrote: > Hi Eduardo, > > I saw that for 5.1 [0] you included a kernelci boot report for your > tree, but not for 5.2. Have you found anything that should be improved > in KernelCI for it to be more useful to maintainers like you? Honestly, I

[PATCH v2] staging: kpc2000: Add dependency on MFD_CORE to kconfig symbol 'KPC2000'

2019-05-23 Thread Geordan Neukum
The kpc2000 core makes calls against functions conditionally exported upon selection of the kconfig symbol MFD_CORE. Therefore, the kpc2000 core depends upon the mfd_core, and that dependency must be tracked in Kconfig to avoid potential build issues. Signed-off-by: Geordan Neukum --- v2 changes

Re: [GIT PULL] Thermal-SoC management changes for v5.2-rc1

2019-05-23 Thread Eduardo Valentin
On Thu, May 16, 2019 at 09:55:33AM -0700, Guenter Roeck wrote: > On 5/16/19 8:07 AM, Linus Torvalds wrote: > >On Wed, May 15, 2019 at 9:43 PM Eduardo Valentin wrote: > >> > >>- thermal core has a new devm_* API for registering cooling devices, thanks > >>to Guenter R. > >> I took the entire

Re: [PATCH selftests 0/2] Add checkbashisms meta-testcase

2019-05-23 Thread Steven Rostedt
Shuah, Want to take this or would you want me to? -- Steve On Sat, 23 Mar 2019 19:27:46 +0900 Masami Hiramatsu wrote: > Hi Shuah, > > Could you pick this to your tree? I think this can prevent further > simillar errors before release... > > Thank you, > > On Fri, 22 Feb 2019 10:26:27

[PATCH v3] vt: Fix a missing-check bug in con_init()

2019-05-23 Thread Gen Zhang
In function con_init(), the pointer variable vc_cons[currcons].d, vc and vc->vc_screenbuf is allocated a memory space via kzalloc(). And they are used in the following codes. However, when there is a memory allocation error, kzalloc() can fail. Thus null pointer (vc_cons[currcons].d, vc and

Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

2019-05-23 Thread Eduardo Valentin
On Thu, May 23, 2019 at 09:34:37AM +0800, elaine.zhang wrote: > hi, Heiko & Enric: > > 在 2019/5/22 下午8:27, Heiko Stuebner 写道: > >Hi Enric, > > > >Am Montag, 20. Mai 2019, 15:38:32 CEST schrieb Enric Balletbo Serra: > >>Hi all, > >> > >>As pointed by [1] and [2] this commit, that now is upstream,

Re: Getting empty callchain from perf_callchain_kernel()

2019-05-23 Thread Kairui Song
On Fri, May 24, 2019 at 1:27 AM Josh Poimboeuf wrote: > > On Fri, May 24, 2019 at 12:41:59AM +0800, Kairui Song wrote: > > On Thu, May 23, 2019 at 11:24 PM Josh Poimboeuf > > wrote: > > > > > > On Thu, May 23, 2019 at 10:50:24PM +0800, Kairui Song wrote: > > > > > > Hi Josh, this still won't

Re: [PATCH] Revert "thermal: rockchip: fix up the tsadc pinctrl setting error"

2019-05-23 Thread Eduardo Valentin
On Wed, May 22, 2019 at 08:34:34AM -0700, Doug Anderson wrote: > Hi, > > On Wed, May 22, 2019 at 7:12 AM Heiko Stuebner wrote: > > > > This reverts commit 28694e009e512451ead5519dd801f9869acb1f60. > > > > The commit causes multiple issues in that: > > - the added call to ->control does

RE: [PATCH net-next v2, 0/4] ENETC: support hardware timestamping

2019-05-23 Thread Y.b. Lu
> -Original Message- > From: Richard Cochran > Sent: Thursday, May 23, 2019 9:49 PM > To: Y.b. Lu > Cc: net...@vger.kernel.org; David Miller ; Claudiu > Manoil ; Shawn Guo ; Rob > Herring ; Alexandru Marginean > ; devicet...@vger.kernel.org; > linux-arm-ker...@lists.infradead.org;

[PATCH v2] consolemap: Fix a memory leaking bug in con_insert_unipair()

2019-05-23 Thread Gen Zhang
In function con_insert_unipair(), when allocation for p2 and p1[n] fails, ENOMEM is returned, but previously allocated p1 is not freed, remains as leaking memory. Thus we should free p1 as well when this allocation fails. Signed-off-by: Gen Zhang Reviewed-by: Kees Cook --- diff --git

Re: [PATCH] PCI: altera: Fix no return warning for altera_pcie_irq_teardown()

2019-05-23 Thread Ley Foon Tan
On Fri, May 24, 2019 at 10:15 AM Ley Foon Tan wrote: > > Fix compilation warning caused by patch "PCI: altera: Allow building as > module". > > drivers/pci/controller/pcie-altera.c: In function ‘altera_pcie_irq_teardown’: > drivers/pci/controller/pcie-altera.c:723:1: warning: no return statement

[PATCH] PCI: altera: Fix no return warning for altera_pcie_irq_teardown()

2019-05-23 Thread Ley Foon Tan
Fix compilation warning caused by patch "PCI: altera: Allow building as module". drivers/pci/controller/pcie-altera.c: In function ‘altera_pcie_irq_teardown’: drivers/pci/controller/pcie-altera.c:723:1: warning: no return statement in function returning non-void [-Wreturn-type] }

Re: [Ocfs2-devel] [PATCH V3 2/2] ocfs2: add locking filter debugfs file

2019-05-23 Thread Gang He
Hello Wengang, This patch is used to add a filter attribute(the default value is 0), the kernel module can use this attribute value to filter the lock resources dumping. By default(the value is 0), the kernel module does not filter any lock resources dumping, the behavior is like before. If the

Re: [PATCH v2] consolemap: Fix a memory leaking bug in drivers/tty/vt/consolemap.c

2019-05-23 Thread Gen Zhang
On Thu, May 23, 2019 at 09:54:18AM -0700, Kees Cook wrote: > On Thu, May 23, 2019 at 08:34:52AM +0800, Gen Zhang wrote: > > In function con_insert_unipair(), when allocation for p2 and p1[n] > > fails, ENOMEM is returned, but previously allocated p1 is not freed, > > remains as leaking memory.

[PATCH] pcm030-audio-fabric: Fix a memory leaking bug in pcm030_fabric_probe()

2019-05-23 Thread Gen Zhang
In pcm030_fabric_probe(), 'pdata->codec_device' is allocated by platform_device_alloc(). When this allocation fails, ENOMEM is returned. However, 'pdata' is allocated by devm_kzalloc() before this site. We should free 'pdata' before function ends to prevent memory leaking. Similarly, we should

Re: [PATCH] tracing: silence GCC 9 array bounds warning

2019-05-23 Thread Steven Rostedt
On Thu, 23 May 2019 14:45:35 +0200 Miguel Ojeda wrote: > +/* > + * Reset the state of the trace_iterator so that it can read consumed data. > + * Normally, the trace_iterator is used for reading the data when it is not > + * consumed, and must retain state. > + */ > +static __always_inline void

Re: [PATCH] signal: reorder struct sighand_struct

2019-05-23 Thread Andrew Morton
On Sat, 4 May 2019 19:33:02 -0400 Michal Hocko wrote: > CCing Oleg. > > On Fri 03-05-19 22:28:00, Alexey Dobriyan wrote: > [...] > > add/remove: 0/0 grow/shrink: 8/68 up/down: 49/-1147 (-1098) > [...] > > --- a/include/linux/sched/signal.h > > +++ b/include/linux/sched/signal.h > > @@ -15,10

Re: [PATCH net 2/4] net/udpgso_bench_tx: options to exercise TX CMSG

2019-05-23 Thread Fred Klassen
> > To ensure that we do not regress, when adding options, please consider > (just a general suggestion, not a strong request for this patch set) > updating the kselftest to run a variant of the test with the new code > coverage. In this case, make the code pass/fail instead of only user >

  1   2   3   4   5   6   7   8   9   10   >