rcu_read_lock lost its compiler barrier

2019-06-01 Thread Herbert Xu
Digging up an old email because I was not aware of this previously but Paul pointed me to it during another discussion. On Mon, Sep 21, 2015 at 01:43:27PM -0700, Paul E. McKenney wrote: > On Mon, Sep 21, 2015 at 09:30:49PM +0200, Frederic Weisbecker wrote: > > > > diff --git

Re: ss: Checking efficient analysis for network connections

2019-06-01 Thread Markus Elfring
> If you use netlink operations directly, Thanks for such feedback. Should this programming interface become better known? > you can have the kernel filter on various criteria > and only get the socket entries you are interested in. This is good to know. > This whole discussion has zero to

Re: [PATCH v2] arm64: dts: rockchip: Add missing configuration pwr amd rst for PCIe

2019-06-01 Thread Anand Moon
Hi Manivannan, Thanks for your review comment. On Sat, 1 Jun 2019 at 15:21, Manivannan Sadhasivam wrote: > > Hi, > > On Fri, May 31, 2019 at 08:19:13PM +, Anand Moon wrote: > > This patch add missing PCIe gpio pin (#PCIE_PWR) for vcc3v3_pcie power > > regulator node also add missing reset

Re: [PATCH] ceph: use ceph_evict_inode to cleanup inode's resource

2019-06-01 Thread Al Viro
On Sun, Jun 02, 2019 at 10:25:46AM +0800, Yan, Zheng wrote: > remove_session_caps() relies on __wait_on_freeing_inode(), to wait for > freezing inode to remove its caps. But VFS wakes freeing inode waiters > before calling destroy_inode(). *blink* Which tree is that against? > -static void

[PATCH] ceph: use ceph_evict_inode to cleanup inode's resource

2019-06-01 Thread Yan, Zheng
remove_session_caps() relies on __wait_on_freeing_inode(), to wait for freezing inode to remove its caps. But VFS wakes freeing inode waiters before calling destroy_inode(). Signed-off-by: "Yan, Zheng" --- fs/ceph/inode.c | 25 ++--- fs/ceph/super.c | 1 + fs/ceph/super.h |

Re: [PATCH net-next 0/5] PTP support for the SJA1105 DSA driver

2019-06-01 Thread Richard Cochran
On Sat, Jun 01, 2019 at 03:06:59PM +0300, Vladimir Oltean wrote: > PTP frames will reconstruct the full timestamp without waiting for any > meta (they are the meta), while other MAC-trapped frames (STP etc) > will just carry a meaningless skb->cb when passed up the stack. > In retrospect, it would

Re: [PATCH net-next 0/5] PTP support for the SJA1105 DSA driver

2019-06-01 Thread Richard Cochran
On Sat, Jun 01, 2019 at 01:31:34PM +0300, Vladimir Oltean wrote: > If I dress the meta frame into a PTP frame (btw is there any > preferable event message for this purpose?) I would just make a L2 PTP event message from a specific source address, just like the phyter does. Use Ethertype

RE: [EXT] Re: [PATCH] mwifiex: check for null return from skb_copy

2019-06-01 Thread Ganapathi Bhat
Hi Dan, > > > > if (is_multicast_ether_addr(ra)) { > > > > skb_uap = skb_copy(skb, GFP_ATOMIC); > > > > + if (!skb_uap) > > > > + return -ENOMEM; > > > > > > I think we would want to free dev_kfree_skb_any(skb) before returning. > > I

[PATCH 4/7] scsi: mac_scsi: Increase PIO/PDMA transfer length threshold

2019-06-01 Thread Finn Thain
Some targets introduce delays when handshaking the response to certain commands. For example, a disk may send a 96-byte response to an INQUIRY command (or a 24-byte response to a MODE SENSE command) too slowly. Apparently the first 12 or 14 bytes are handshaked okay but then the system bus error

[PATCH 7/7] scsi: mac_scsi: Treat Last Byte Sent time-out as failure

2019-06-01 Thread Finn Thain
A system bus error during a PDMA send operation can result in bytes being lost. Theoretically that could cause the target to remain in DATA OUT phase and the initiator (expecting a phase change) would time-out waiting for the Last Byte Sent flag. Should that happen, fail the transfer so the core

[PATCH 0/7] NCR5380 drivers: fixes and improvements

2019-06-01 Thread Finn Thain
Among other improvements, this patch series fixes a data corruption bug in the mac_scsi driver and a bug in the EH abort routine in the core 5380 driver. For consistency I have ignored certain checkpatch.pl complaints about the indentation in mac_scsi.c. The remaining complaints seem to be false

[PATCH 3/7] scsi: NCR5380: Handle PDMA failure reliably

2019-06-01 Thread Finn Thain
A PDMA error is handled in the core driver by setting the device's 'borken' flag and aborting the command. Unfortunately, do_abort() is not dependable. Perform a SCSI bus reset instead, to make sure that the command fails and gets retried. Cc: Michael Schmitz Cc: sta...@vger.kernel.org # v4.20+

[PATCH 1/7] Revert "scsi: ncr5380: Increase register polling limit"

2019-06-01 Thread Finn Thain
This reverts commit 4822827a69d7cd3bc5a07b7637484ebd2cf88db6. The purpose of that commit was to suppress a timeout warning message which appeared to be caused by target latency. But suppressing the warning is undesirable as the warning may indicate a messed up transfer count. Another problem

[PATCH 6/7] scsi: mac_scsi: Enable PDMA on Mac IIfx

2019-06-01 Thread Finn Thain
Add support for Apple's custom "SCSI DMA" chip. This patch doesn't make use of its DMA capability. Just the PDMA capability is sufficient to improve sequential read throughput by a factor of 5. Cc: Michael Schmitz Cc: Joshua Thompson Cc: Geert Uytterhoeven Tested-by: Stan Johnson

[PATCH 5/7] scsi: mac_scsi: Fix pseudo DMA implementation, take 2

2019-06-01 Thread Finn Thain
A system bus error during a PDMA transfer can mess up the calculation of the transfer residual (the PDMA handshaking hardware lacks a byte counter). This results in data corruption. The algorithm in this patch anticipates a bus error by starting each transfer with a MOVE.B instruction. If a bus

[PATCH 2/7] scsi: NCR5380: Always re-enable reselection interrupt

2019-06-01 Thread Finn Thain
The reselection interrupt gets disabled during selection and must be re-enabled when hostdata->connected becomes NULL. If it isn't re-enabled a disconnected command may time-out or the target may wedge the bus while trying to reselect the host. This can happen after a command is aborted. Fix this

Re: fix controller busy issue and add 24bits segment support

2019-06-01 Thread Chaotian Jing
Hi Ulf, Gentle ping for this patch. On Sun, 2019-05-19 at 15:57 +0800, Chaotian Jing wrote: > the below 2 patches fix controller busy issue when plug out SD card > and add 24bits segment size support. > > Chaotian Jing (2): > mmc: mediatek: fix controller busy when plug out SD > mmc:

[PATCH HACK RFC] cpu: Prevent late-arriving interrupts from disrupting offline

2019-06-01 Thread Paul E. McKenney
Scheduling-clock interrupts can arrive late in the CPU-offline process, after idle entry and the subsequent call to cpuhp_report_idle_dead(). Once execution passes the call to rcu_report_dead(), RCU is ignoring the CPU, which results in lockdep complaints when the interrupt handler uses RCU:

[PATCH v1 3/4] Bluetooth: btmtkuart: add an implementation for boot-gpios property

2019-06-01 Thread sean.wang
From: Sean Wang Not every platform has the pinctrl device integrates the GPIO the function such as MT7621 whose pinctrl and GPIO are separate hardware so the driver adds additional boot-gpios to let the MT766[3,8]U can enter the proper boot mode by gpiod for such platform. Signed-off-by: Sean

[PATCH v1 1/4] dt-bindings: net: bluetooth: add boot-gpios property to UART-based device

2019-06-01 Thread sean.wang
From: Sean Wang Not every platform has the pinctrl device integrates the GPIO the function such as MT7621 whose pinctrl and GPIO are separate hardware so adding an additional boot-gpios property for such platform allows them to bring up the device. Signed-off-by: Sean Wang ---

[PATCH v1 2/4] dt-bindings: net: bluetooth: add clock property to UART-based device

2019-06-01 Thread sean.wang
From: Sean Wang Some board requires explicitily control external osscilator via GPIO. So, add a clock property for an external oscillator for the device. Signed-off-by: Sean Wang --- Documentation/devicetree/bindings/net/mediatek-bluetooth.txt | 4 1 file changed, 4 insertions(+) diff

[PATCH v1 4/4] Bluetooth: btmtkuart: add an implementation for clock osc property

2019-06-01 Thread sean.wang
From: Sean Wang Some board requires explicitily control external osscilator via GPIO. So, add an implementation of a clock property for an external oscillator to the device. Signed-off-by: Sean Wang --- drivers/bluetooth/btmtkuart.c | 21 ++--- 1 file changed, 18

[PATCH v1 0/4] add boot-gpios and clock property to btmtkuart

2019-06-01 Thread sean.wang
From: Sean Wang Update dt-binding and the corresponding implmentation of boot-gpios and clock property to btmtkuart. Sean Wang (4): dt-bindings: net: bluetooth: add boot-gpios property to UART-based device dt-bindings: net: bluetooth: add clock property to UART-based device Bluetooth:

Re: [PATCH] drbd: fix discard_zeroes_if_aligned regression

2019-06-01 Thread Eric Wheeler
On Tue, 28 May 2019, Lars Ellenberg wrote: > On Fri, May 10, 2019 at 05:36:32PM +, Eric Wheeler wrote: > > Hi Lars, > > > > We just tried 4.19.x and this bugs still exists. We applied the patch > > which was originally submitted to this thread and it still applies cleanly > > and seems to

Re: [PATCH] ext4: remove unnecessary gotos in ext4_xattr_set_entry

2019-06-01 Thread Theodore Ts'o
On Fri, May 31, 2019 at 03:46:54PM -0600, Andreas Dilger wrote: > On May 31, 2019, at 6:10 AM, Pavel Tikhomirov > wrote: > > > > In the "out" label we only iput old/new_ea_inode-s, in all these places > > these variables are always NULL so there is no point in goto to "out". > > > >

[PATCH v7 0/2] Bluetooth: btusb: Add protocol support for MediaTek USB devices

2019-06-01 Thread sean.wang
From: Sean Wang v7: * rebase to latest code base. v6: * fix drivers/bluetooth/btusb.c:2683:2-3: Unneeded semicolon based reported by [1] * update power-on sequence with adding neccesary tci sleep comand to set up low-power environmnet and a delay to wait the device to be stable. * sort

[PATCH v7 1/2] Bluetooth: btusb: Add protocol support for MediaTek MT7668U USB devices

2019-06-01 Thread sean.wang
From: Sean Wang This adds the support of enabling MT7668U Bluetooth function running on the top of btusb driver. The information in /sys/kernel/debug/usb/devices about the Bluetooth device is listed as the below. T: Bus=02 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=5000 MxCh= 0 D: Ver= 3.00

[PATCH v7 2/2] Bluetooth: btusb: Add protocol support for MediaTek MT7663U USB devices

2019-06-01 Thread sean.wang
From: Sean Wang This adds the support of enabling MT7663U Bluetooth function running on the top of btusb driver. The information in /sys/kernel/debug/usb/devices about the Bluetooth device is listed as the below. T: Bus=04 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 5 Spd=5000 MxCh= 0 D: Ver= 3.00

Re: ss: Checking efficient analysis for network connections

2019-06-01 Thread David Miller
From: Markus Elfring Date: Sat, 1 Jun 2019 10:36:40 +0200 > I imagine then that it would be also nicer to perform filtering based on > configurable constraints at the data source directly. > How much can Linux help more in this software area? > How do you think about such ideas? If you use

Re: RFC: switch the remaining architectures to use generic GUP v2

2019-06-01 Thread David Miller
From: Christoph Hellwig Date: Sat, 1 Jun 2019 09:49:43 +0200 > below is a series to switch mips, sh and sparc64 to use the generic > GUP code so that we only have one codebase to touch for further > improvements to this code. I don't have hardware for any of these > architectures, and

[GIT PULL] Thermal-SoC management fixes for v5.2-rc3

2019-06-01 Thread Eduardo Valentin
Please consider the following thermal soc changes for v5.2-rc3. This is really a single revert, detected to cause issues on the tsens driver. The following changes since commit cd6c84d8f0cdc911df435bb075ba22ce3c605b07: Linux 5.2-rc2 (2019-05-26 16:49:19 -0700) are available in the git

with due respect

2019-06-01 Thread Mr Duna Wattara
Dear Friend, I know that this mail will come to you as a surprise as we have never met before, but need not to worry as I am contacting you independently of my investigation and no one is informed of this communication. I need your urgent assistance in transferring the sum of $11.3million

RE: [PATCH] PCI: hv: Fix build error without CONFIG_SYSFS

2019-06-01 Thread Michael Kelley
From: YueHaibing Sent: Friday, May 31, 2019 8:09 AM > > while building without CONFIG_SYSFS, fails as below: > > drivers/pci/controller/pci-hyperv.o: In function 'hv_pci_assign_slots': > pci-hyperv.c:(.text+0x40a): undefined reference to 'pci_create_slot' > drivers/pci/controller/pci-hyperv.o:

Re: [RFC PATCH 4/5] media: ov6650: Fix frame scaling not reset on crop

2019-06-01 Thread Sakari Ailus
Hi Janusz, On Fri, May 31, 2019 at 07:56:33PM +0200, Janusz Krzysztofik wrote: > Hi Sakari, > > On Friday, May 31, 2019 1:42:58 PM CEST Sakari Ailus wrote: > > Hi Janusz, > > > > On Sun, May 26, 2019 at 10:47:57PM +0200, Janusz Krzysztofik wrote: > > > According to V4L2 subdevice interface

Re: [RFC PATCH 5/5] media: ov6650: Add .init_cfg() pad operation callback

2019-06-01 Thread Sakari Ailus
Hi Janusz, On Sun, May 26, 2019 at 10:47:58PM +0200, Janusz Krzysztofik wrote: > The driver now supports V4L2_SUBDEV_FORMAT_TRY operation mode only in > .get/set_fmt() pad operation callbacks. That means only .try_format > member of pad config is maintained. As a consequence, active crop >

[RFC 4/6] workqueue: Convert for_each_wq to use built-in list check

2019-06-01 Thread Joel Fernandes (Google)
list_for_each_entry_rcu now has support to check for RCU reader sections as well as lock. Just use the support in it, instead of explictly checking in the caller. Signed-off-by: Joel Fernandes (Google) --- kernel/workqueue.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[RFC 3/6] driver/core: Convert to use built-in RCU list checking

2019-06-01 Thread Joel Fernandes (Google)
list_for_each_entry_rcu has built-in RCU and lock checking. Make use of it in driver core. Signed-off-by: Joel Fernandes (Google) --- drivers/base/base.h | 1 + drivers/base/core.c | 10 ++ drivers/base/power/runtime.c | 15 ++- 3 files changed, 21

[RFC 0/6] Harden list_for_each_entry_rcu() and family

2019-06-01 Thread Joel Fernandes (Google)
Hi, Please consider this as an RFC / proof-of-concept to gather some feedback. This series aims to provide lockdep checking to RCU list macros. RCU has a number of primitives for "consumption" of an RCU protected pointer. Most of the time, these consumers make sure that such accesses are under a

[RFC 5/6] x86/pci: Pass lockdep condition to pcm_mmcfg_list iterator

2019-06-01 Thread Joel Fernandes (Google)
The pcm_mmcfg_list is traversed with list_for_each_entry_rcu without a reader-lock held, because the pci_mmcfg_lock is already held. Make this known to the list macro so that it fixes new lockdep warnings that trigger due to lockdep checks added to list_for_each_entry_rcu(). Signed-off-by: Joel

[RFC 1/6] rcu: Add support for consolidated-RCU reader checking

2019-06-01 Thread Joel Fernandes (Google)
This patch adds support for checking RCU reader sections in list traversal macros. Optionally, if the list macro is called under SRCU or other lock/mutex protection, then appropriate lockdep expressions can be passed to make the checks pass. Existing list_for_each_entry_rcu() invocations don't

[RFC 6/6] acpi: Use built-in RCU list checking for acpi_ioremaps list

2019-06-01 Thread Joel Fernandes (Google)
list_for_each_entry_rcu has built-in RCU and lock checking. Make use of it for acpi_ioremaps list traversal. Signed-off-by: Joel Fernandes (Google) --- drivers/acpi/osl.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c index

[RFC 2/6] ipv4: add lockdep condition to fix for_each_entry

2019-06-01 Thread Joel Fernandes (Google)
Signed-off-by: Joel Fernandes (Google) --- net/ipv4/fib_frontend.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index b298255f6fdb..ef7c9f8e8682 100644 --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c @@ -127,7

Re: BUG: gpio: pca953x: 24 bit expanders broken since v5.2-rc1

2019-06-01 Thread Linus Walleij
On Fri, May 31, 2019 at 7:06 PM H. Nikolaus Schaller wrote: > Now, this was not a (visible) problem until patch > > 8b9f9d4dc511 regmap: verify if register is writeable before writing > operations > > enforces to check the register number before invoking the > callback

Re: [PATCH v3] dt-bindings: arm: Convert Atmel board/soc bindings to json-schema

2019-06-01 Thread Alexandre Belloni
On 17/05/2019 10:39:11-0500, Rob Herring wrote: > Convert Atmel SoC bindings to DT schema format using json-schema. > > Cc: Mark Rutland > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: devicet...@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Signed-off-by: Rob Herring

[PATCH] counter: ftm-quaddec: needs HAS_IOMEM

2019-06-01 Thread Thomas Meyer
the driver fails for UML with: drivers/counter/ftm-quaddec.c:301: undefined reference to `devm_ioremap' Fix it by depending on HAS_IOMEM --- drivers/counter/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig index

Re: 5.1.0-next-20190520 -- emacs segfaults on 32-bit machine Re: 5.2-rc0.8: emacs segfaults?! x220, with 32-bit userland

2019-06-01 Thread Pavel Machek
On Mon 2019-05-27 15:08:48, Sebastian Andrzej Siewior wrote: > On 2019-05-27 15:03:17 [+0200], Pavel Machek wrote: > > > could you please send me (offlist) your .config? Also, what kind of > > > userland do you run? Something like Debian stable? > > > > Yep, debian stable. > > Since we had a

Re: [PATCH V7 4/4] rtc: imx-sc: add rtc alarm support

2019-06-01 Thread Alexandre Belloni
On 09/04/2019 05:00:07+, Anson Huang wrote: > Add i.MX system controller RTC alarm support, the RTC alarm > is implemented via SIP(silicon provider) runtime service call > and ARM-Trusted-Firmware will communicate with system controller > via MU(message unit) IPC to set RTC alarm. When RTC

Re: [EXT] Re: [PATCH] mwifiex: check for null return from skb_copy

2019-06-01 Thread Dan Carpenter
On Sat, Jun 01, 2019 at 05:29:26PM +, Ganapathi Bhat wrote: > Hi Dan, > > > > if (is_multicast_ether_addr(ra)) { > > > skb_uap = skb_copy(skb, GFP_ATOMIC); > > > + if (!skb_uap) > > > + return -ENOMEM; > > > > I think we would want to free

Re: [PATCH 1/1] rtc: rv3028: check return value

2019-06-01 Thread Alexandre Belloni
Hello, On 29/05/2019 15:22:20+0800, Xidong Wang wrote: > In rv3028_probe(), the return value of devm_regmap_init_i2c() should > be checked before it is used. > > Signed-off-by: Xidong Wang > --- > drivers/rtc/rtc-rv3028.c | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [PATCH 0/3] rtc: tegra: Dust off and deferred probe support

2019-06-01 Thread Alexandre Belloni
On 27/05/2019 12:13:56+0200, Thierry Reding wrote: > From: Thierry Reding > > The NVIDIA Tegra RTC driver has accumulated a bit of dust over the > years. Make a pass over it, addressing checkpatch warnings and fixing > some inconsistencies in comments and kernel messages as well as in > variable

Re: [PATCH] tty/serial: digicolor: Fix digicolor-usart already registered warning

2019-06-01 Thread Baruch Siach
Hi Kefeng, On Fri, May 31 2019, Kefeng Wang wrote: > When modprobe/rmmod/modprobe module, if platform_driver_register() fails, > the kernel complained, > > proc_dir_entry 'driver/digicolor-usart' already registered > WARNING: CPU: 1 PID: 5636 at fs/proc/generic.c:360 proc_register+0x19d/0x270

[GIT PULL 1/1] bcm2835-dt-next-2019-06-01

2019-06-01 Thread Stefan Wahren
Hi Florian, the following changes since commit a188339ca5a396acc588e5851ed7e19f66b0ebd9: Linux 5.2-rc1 (2019-05-19 15:47:09 -0700) are available in the git repository at: git://github.com/anholt/linux tags/bcm2835-dt-next-2019-06-01 for you to fetch changes up to

Re: [PATCH 8/8] staging: rtl8712: Fixed CamelCase in struct _adapter from drv_types.h

2019-06-01 Thread Joe Perches
On Sun, 2019-06-02 at 00:13 +0530, Deepak Mishra wrote: > This patch fixes CamelCase blnEnableRxFF0Filter by renaming it > to bln_enable_rx_ff0_filter in drv_types.h and related files rtl871x_cmd.c > xmit_linux.c One could also improve this by removing the hungarian like bln_ prefix and simplify

Re: [RFC 0/2] Support for buttons on newer MS Surface devices

2019-06-01 Thread Maximilian Luz
Hi, any comments on this? I should also mention that this has been tested via https://github.com/jakeday/linux-surface. Maximilian On 5/16/19 4:25 PM, Maximilian Luz wrote: This series adds suport for power and volume buttons on 5th and 6th generation Microsoft Surface devices.

[PATCH 2/8] staging: rtl8712: Fixed CamelCase in struct _adapter from drv_types.h

2019-06-01 Thread Deepak Mishra
This patch fixes CamelCase ImrContent from struct _adapter and in related files drv_types.h, rtl871x_eeprom.c, usb_intf.c CHECK: Avoid CamelCase: Signed-off-by: Deepak Mishra --- drivers/staging/rtl8712/drv_types.h | 2 +- drivers/staging/rtl8712/rtl871x_eeprom.c | 6 +++---

[PATCH 0/8] staging: rtl8712: Fixed CamelCase in struct _adapter from drv_types.h

2019-06-01 Thread Deepak Mishra
This patchset fixes CamelCase checks in struct _adapter in drv_types.h and in files where struct _adapter is used by renaming the variables without camel case. These check were reported by checkpatch.pl Deepak Mishra (8): staging: rtl8712: Fixed CamelCase in struct _adapter from drv_types.h

[PATCH 4/8] staging: rtl8712: Fixed CamelCase in struct _adapter from drv_types.h

2019-06-01 Thread Deepak Mishra
This patch fixes CamelCase evtThread in struct _adapter as reported by checkpatch.pl CHECK: Avoid CamelCase: Signed-off-by: Deepak Mishra --- drivers/staging/rtl8712/drv_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/drv_types.h

[PATCH 6/8] staging: rtl8712: Fixed CamelCase in struct _adapter from drv_types.h

2019-06-01 Thread Deepak Mishra
This patch fixes CamelCase as reported by checkpatch.pl xmitThread renamed to xmit_thread recvThread renamed to recv_thread Signed-off-by: Deepak Mishra --- drivers/staging/rtl8712/drv_types.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 8/8] staging: rtl8712: Fixed CamelCase in struct _adapter from drv_types.h

2019-06-01 Thread Deepak Mishra
This patch fixes CamelCase blnEnableRxFF0Filter by renaming it to bln_enable_rx_ff0_filter in drv_types.h and related files rtl871x_cmd.c xmit_linux.c It was reported by checkpatch.pl Signed-off-by: Deepak Mishra --- drivers/staging/rtl8712/drv_types.h | 2 +-

[PATCH 1/8] staging: rtl8712: Fixed CamelCase in struct _adapter from drv_types.h

2019-06-01 Thread Deepak Mishra
This patch fixes CamelCase ImrContent from struct _adapter and in related files drv_types.h, rtl871x_mp_ioctl.c, rtl871x_pwrctrl.h CHECK: Avoid CamelCase: Signed-off-by: Deepak Mishra --- drivers/staging/rtl8712/drv_types.h| 2 +- drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 2 +-

[PATCH 7/8] staging: rtl8712: Fixed CamelCase in struct _adapter from drv_types.h

2019-06-01 Thread Deepak Mishra
This patch renames CamelCase variable wkFilterRxFF0 to wk_filter_rx_ff0 in drv_types.h and related files rtl871x_xmit.c and xmit_linux.c as reported by checkpatch.pl Signed-off-by: Deepak Mishra --- drivers/staging/rtl8712/drv_types.h| 2 +- drivers/staging/rtl8712/rtl871x_xmit.c | 2 +-

[PATCH 5/8] staging: rtl8712: Fixed CamelCase in struct _adapter from drv_types.h

2019-06-01 Thread Deepak Mishra
This patch fixes CamelCase IsrContent to isr_content as suggested by checkpatch.pl Signed-off-by: Deepak Mishra --- drivers/staging/rtl8712/drv_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h

[PATCH 3/8] staging: rtl8712: Fixed CamelCase in struct _adapter from drv_types.h

2019-06-01 Thread Deepak Mishra
This patch fixes CamelCase cmdThread from struct _adapter and in related files drv_types.h,os_intfs.c CHECK: Avoid CamelCase: Signed-off-by: Deepak Mishra --- drivers/staging/rtl8712/drv_types.h | 2 +- drivers/staging/rtl8712/os_intfs.c | 6 +++--- 2 files changed, 4 insertions(+), 4

[PATCH] PCI: hv: Detect and fix Hyper-V PCI domain number collision

2019-06-01 Thread Sasha Levin
From: Haiyang Zhang Due to Azure host agent settings, the device instance ID's bytes 8 and 9 are no longer unique. This causes some of the PCI devices not showing up in VMs with multiple passthrough devices, such as GPUs. So, as recommended by Azure host team, we now use the bytes 4 and 5 which

Re: [PATCH] drivers: hid: Add a module description line to the hid_hyperv driver

2019-06-01 Thread Sasha Levin
On Sat, Jun 01, 2019 at 12:19:11AM +0200, Jiri Kosina wrote: On Thu, 30 May 2019, Sasha Levin wrote: From: Joseph Salisbury This patch only adds a MODULE_DESCRIPTION statement to the driver. This change is only cosmetic, so there should be no runtime impact. Signed-off-by: Joseph Salisbury

[GIT PULL] LED fix for 5.2-rc3

2019-06-01 Thread Jacek Anaszewski
Hi Linus, Please pull LED fix for recent change in LED core, that didn't take into account the possibility of calling led_blink_setup() from atomic context. The following changes since commit cd6c84d8f0cdc911df435bb075ba22ce3c605b07: Linux 5.2-rc2 (2019-05-26 16:49:19 -0700) are available in

RE: [EXT] INFO: trying to register non-static key in del_timer_sync (2)

2019-06-01 Thread Ganapathi Bhat
Hi syzbot, > > syzbot found the following crash on: > As per the link(https://syzkaller.appspot.com/bug?extid=dc4127f950da51639216), the issue is fixed; Is it OK? Let us know if we need to do something? Regards, Ganapathi

Re: [PATCH 2/2] gpio: max732x: use devm_gpiochip_add_data()

2019-06-01 Thread Linus Walleij
On Tue, May 21, 2019 at 11:03 AM Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > We can simplify the code a bit with a resource managed variant of > gpiochip_add_data(). > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 1/2] gpio: max732x: use i2c_new_dummy_device()

2019-06-01 Thread Linus Walleij
On Tue, May 28, 2019 at 5:53 PM Bartosz Golaszewski wrote: > wt., 21 maj 2019 o 11:03 Bartosz Golaszewski napisał(a): > > > > From: Bartosz Golaszewski > > > > We now have a resource managed version of i2c_new_dummy_device() that > > also returns an actual error code instead of a NULL-pointer.

Re: [PATCH v2 0/2] pinctrl: mediatek: mt8183: Add support for wake sources

2019-06-01 Thread Linus Walleij
On Wed, May 8, 2019 at 9:33 AM Nicolas Boichat wrote: > This adds support for wake sources in pinctrl-mtk-common-v2, and > pinctrl-mt8183. Without this patch, all interrupts that are left > enabled on suspend act as wake sources (and wake sources without > interrupt enabled do not). > > Changes

Re: [PATCH 0/5] pinctrl: meson: gpio: update with SPDX Licence identifier

2019-06-01 Thread Linus Walleij
On Mon, May 20, 2019 at 4:41 PM Neil Armstrong wrote: > Update the SPDX Licence identifier for the Amlogic Pinctrl drivers and > the corresponding GPIO dt-bindings headers. > > Neil Armstrong (5): All 5 patches applied, I took a quick look in mainline and it appears those files were not hit by

Re: [PATCH 1/5] pinctrl: meson: update with SPDX Licence identifier

2019-06-01 Thread Linus Walleij
On Mon, May 20, 2019 at 4:41 PM Neil Armstrong wrote: > Signed-off-by: Neil Armstrong Patch applied with Martin's review tag. Yours, Linus Walleij

RE: [EXT] Re: [PATCH] mwifiex: check for null return from skb_copy

2019-06-01 Thread Ganapathi Bhat
Hi Dan, > > if (is_multicast_ether_addr(ra)) { > > skb_uap = skb_copy(skb, GFP_ATOMIC); > > + if (!skb_uap) > > + return -ENOMEM; > > I think we would want to free dev_kfree_skb_any(skb) before returning. I think if the pointer is NULL, no need to free

Re: [PATCH V3 4/4] soc/tegra: select pinctrl for Tegra194

2019-06-01 Thread Linus Walleij
On Thu, May 16, 2019 at 1:53 PM Krishna Yarlagadda wrote: > Select PINCTRL_TEGRA194 by default for Tegra194 SOC needed > for dynamically controlling PCIe pins > > Signed-off-by: Krishna Yarlagadda Reviewed-by: Linus Walleij I guess this needs to be applied by the Tegra SoC maintainers and go

Re: [PATCH V3 3/4] pinctrl: tegra: Add Tegra194 pinmux driver

2019-06-01 Thread Linus Walleij
On Thu, May 16, 2019 at 1:54 PM Krishna Yarlagadda wrote: > Tegra194 has PCIE L5 rst and clkreq pins which need to be controlled > dynamically at runtime. This driver supports change pinmux for these > pins. Pinmux for rest of the pins is set statically by bootloader and > will not be changed by

Re: [PATCH V3 2/4] pinctrl: tegra: Support 32 bit register access

2019-06-01 Thread Linus Walleij
On Thu, May 16, 2019 at 1:53 PM Krishna Yarlagadda wrote: > Tegra194 chip has 32 bit pinctrl registers. Existing register defines in > header are only 16 bit. > Modified common pinctrl-tegra driver to support 32 bit registers of > Tegra 194 and later chips. > > Signed-off-by: Krishna Yarlagadda

Re: [PATCH V3 1/4] dt-binding: Tegra194 pinctrl support

2019-06-01 Thread Linus Walleij
On Thu, May 16, 2019 at 1:53 PM Krishna Yarlagadda wrote: > Add binding doc for Tegra 194 pinctrl driver > > Signed-off-by: Krishna Yarlagadda > --- > Changes in V3: > remove optional fields not supported by pins published here Patch applied with the tags. Yours, Linus Walleij

Re: KASAN: user-memory-access Read in ip6_hold_safe (3)

2019-06-01 Thread David Ahern
On 6/1/19 12:05 AM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:    dfb569f2 net: ll_temac: Fix compile error > git tree:   net-next syzbot team: Is there any way to know the history of syzbot runs to determine that crash X did not happen at commit Y but

Re: [PATCH 00/12] Secure Virtual Machine Enablement

2019-06-01 Thread Thiago Jung Bauermann
Hello, Thiago Jung Bauermann writes: > This series enables Secure Virtual Machines (SVMs) on powerpc. SVMs use the > Protected Execution Facility (PEF) and request to be migrated to secure > memory during prom_init() so by default all of their memory is inaccessible > to the hypervisor. There

Re: [PATCH] treewide: fix typos of SPDX-License-Identifier

2019-06-01 Thread Greg KH
On Sat, Jun 01, 2019 at 12:22:42PM +0900, Masahiro Yamada wrote: > Prior to the adoption of SPDX, it was difficult for tools to determine > the correct license due to incomplete or badly formatted license text. > The SPDX solves this issue, assuming people can correctly spell >

Re: [PATCH 08/16] sparc64: add the missing pgd_page definition

2019-06-01 Thread Linus Torvalds
Both sparc64 and sh had this pattern, but now that I look at it more closely, I think your version is wrong, or at least nonoptimal. On Sat, Jun 1, 2019 at 12:50 AM Christoph Hellwig wrote: > > +#define pgd_page(pgd) virt_to_page(__va(pgd_val(pgd))) Going through the virtual

Re: [PATCH AUTOSEL 4.4 50/56] tty: pty: Fix race condition between release_one_tty and pty_write

2019-06-01 Thread Greg Kroah-Hartman
On Sat, Jun 01, 2019 at 09:25:54AM -0400, Sasha Levin wrote: > From: Sahara > > [ Upstream commit b9ca5f8560af244489b4a1bc1ae88b341f24bc95 ] > > Especially when a linked tty is used such as pty, the linked tty > port's buf works have not been cancelled while master tty port's > buf work has

Re: [PATCH AUTOSEL 4.4 50/56] tty: pty: Fix race condition between release_one_tty and pty_write

2019-06-01 Thread Greg Kroah-Hartman
On Sat, Jun 01, 2019 at 09:17:07AM -0700, Greg Kroah-Hartman wrote: > On Sat, Jun 01, 2019 at 09:25:54AM -0400, Sasha Levin wrote: > > From: Sahara > > > > [ Upstream commit b9ca5f8560af244489b4a1bc1ae88b341f24bc95 ] > > > > Especially when a linked tty is used such as pty, the linked tty > >

Re: [PATCH v3 16/16] fpga: dfl: fme: add performance reporting support

2019-06-01 Thread Greg KH
On Sat, Jun 01, 2019 at 05:11:47PM +0800, Wu Hao wrote: > On Thu, May 30, 2019 at 12:03:05PM -0700, Greg KH wrote: > > On Mon, May 27, 2019 at 01:22:26PM +0800, Wu Hao wrote: > > > --- /dev/null > > > +++ b/drivers/fpga/dfl-fme-perf.c > > > @@ -0,0 +1,962 @@ > > > +// SPDX-License-Identifier:

Re: [PATCH 03/16] mm: simplify gup_fast_permitted

2019-06-01 Thread Linus Torvalds
On Sat, Jun 1, 2019 at 12:50 AM Christoph Hellwig wrote: > > Pass in the already calculated end value instead of recomputing it, and > leave the end > start check in the callers instead of duplicating them > in the arch code. Good cleanup, except it's wrong. > - if (nr_pages <= 0) > +

Re: [PATCH 09/25] vfs: Allow mount information to be queried by fsinfo() [ver #13]

2019-06-01 Thread Joel Fernandes
On Tue, May 28, 2019 at 04:12:15PM +0100, David Howells wrote: [snip] > + > +/* > + * Store a mount record into the fsinfo buffer. > + */ > +static void store_mount_fsinfo(struct fsinfo_kparams *params, > +struct fsinfo_mount_child *child) > +{ > + unsigned int

Re: [PATCH -next] pwm: pca9685: Remove set but not used variable 'pwm'

2019-06-01 Thread Uwe Kleine-König
Hello Sven, On Sat, Jun 01, 2019 at 09:03:09AM -0400, Sven Van Asbroeck wrote: > Hi YueHaibing, > > On Fri, May 31, 2019 at 11:49 PM YueHaibing wrote: > > > > mutex_lock(>lock); > > - pwm = >chip.pwms[offset]; > > mutex_unlock(>lock); > > Thanks for noticing this issue.

Re: memory leak in sctp_send_reset_streams

2019-06-01 Thread Marcelo Ricardo Leitner
On Sat, Jun 01, 2019 at 08:26:15PM +0800, Hillf Danton wrote: > > Hi Hi, > > On Fri, May 31, 2019 at 02:18:06PM -0700, syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:036e3431 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. > > git tree:

[PATCH] media: i2c: Fix Unnecessary Semicolon Warning Reported by coccicheck

2019-06-01 Thread Shobhit Kukreti
Removed the warning from the following files: drivers/media/i2c/ov13858.c drivers/media/i2c/ov2685.c drivers/media/i2c/ov5695.c Signed-off-by: Shobhit Kukreti --- drivers/media/i2c/ov13858.c | 4 ++-- drivers/media/i2c/ov2685.c | 2 +-

Re: [PATCH 4.19 130/276] block: fix use-after-free on gendisk

2019-06-01 Thread Bart Van Assche
On 6/1/19 12:27 AM, Pavel Machek wrote: > Hi! > >> +++ b/block/genhd.c >> @@ -518,6 +518,18 @@ void blk_free_devt(dev_t devt) >> } >> } >> >> +/** >> + * We invalidate devt by assigning NULL pointer for devt in idr. >> + */ >> +void blk_invalidate_devt(dev_t devt) >> +{ >> +if

How to inject fwnode/oftree/acpi data by platform driver ?

2019-06-01 Thread Enrico Weigelt, metux IT consult
Hi folks, I'm looking for a way to inject fwnode data from a platform driver, in order to initialize generic drivers w/ board specific configuration. The idea is getting rid of passing driver specific pdata structs (which, IIRC, seem to be deprecated). An example usecase is the APUv2/3 board,

Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-06-01 Thread Jacek Anaszewski
Dan, On 6/1/19 12:41 AM, Dan Murphy wrote: Jacek On 5/31/19 4:57 PM, Jacek Anaszewski wrote: Dan, On 5/31/19 11:07 PM, Dan Murphy wrote: Hello On 5/31/19 2:44 PM, Jacek Anaszewski wrote: On 5/31/19 8:23 AM, Lee Jones wrote: On Thu, 30 May 2019, Jacek Anaszewski wrote: On 5/30/19 9:38

[PATCH AUTOSEL 5.1 008/186] drm/pl111: Initialize clock spinlock early

2019-06-01 Thread Sasha Levin
From: Guenter Roeck [ Upstream commit 3e01ae2612bdd7975c74ec7123d7f8f5e6eed795 ] The following warning is seen on systems with broken clock divider. INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 0

[PATCH AUTOSEL 5.1 024/186] thermal: rcar_gen3_thermal: disable interrupt in .remove

2019-06-01 Thread Sasha Levin
From: Jiada Wang [ Upstream commit 63f55fcea50c25ae5ad45af92d08dae3b84534c2 ] Currently IRQ remains enabled after .remove, later if device is probed, IRQ is requested before .thermal_init, this may cause IRQ function be called before device is initialized. this patch disables interrupt in

[PATCH AUTOSEL 5.1 010/186] ARM: prevent tracing IPI_CPU_BACKTRACE

2019-06-01 Thread Sasha Levin
From: Arnd Bergmann [ Upstream commit be167862ae7dd85c56d385209a4890678e1b0488 ] Patch series "compiler: allow all arches to enable CONFIG_OPTIMIZE_INLINING", v3. This patch (of 11): When function tracing for IPIs is enabled, we get a warning for an overflow of the ipi_types array with the

[PATCH AUTOSEL 5.1 007/186] drm/msm: correct attempted NULL pointer dereference in debugfs

2019-06-01 Thread Sasha Levin
From: Brian Masney [ Upstream commit 90f94660e53189755676543954101de78c26253b ] msm_gem_describe() would attempt to dereference a NULL pointer via the address space pointer when no IOMMU is present. Correct this by adding the appropriate check. Signed-off-by: Brian Masney Fixes: 575f0485508b

[PATCH AUTOSEL 5.1 017/186] mm/compaction.c: fix an undefined behaviour

2019-06-01 Thread Sasha Levin
From: Qian Cai [ Upstream commit dd7ef7bd14640f11763b54f55131000165f48321 ] In a low-memory situation, cc->fast_search_fail can keep increasing as it is unable to find an available page to isolate in fast_isolate_freepages(). As the result, it could trigger an error below, so just compare with

[PATCH AUTOSEL 5.1 016/186] initramfs: free initrd memory if opening /initrd.image fails

2019-06-01 Thread Sasha Levin
From: Christoph Hellwig [ Upstream commit 54c7a8916a887f357088f99e9c3a7720cd57d2c8 ] Patch series "initramfs tidyups". I've spent some time chasing down behavior in initramfs and found plenty of opportunity to improve the code. A first stab on that is contained in this series. This patch (of

[PATCH AUTOSEL 5.1 026/186] mfd: tps65912-spi: Add missing of table registration

2019-06-01 Thread Sasha Levin
From: Daniel Gomez [ Upstream commit 9e364e87ad7f2c636276c773d718cda29d62b741 ] MODULE_DEVICE_TABLE(of, should be called to complete DT OF mathing mechanism and register it. Before this patch: modinfo drivers/mfd/tps65912-spi.ko | grep alias alias: spi:tps65912 After this patch:

[PATCH AUTOSEL 5.1 034/186] objtool: Don't use ignore flag for fake jumps

2019-06-01 Thread Sasha Levin
From: Josh Poimboeuf [ Upstream commit e6da9567959e164f82bc81967e0d5b10dee870b4 ] The ignore flag is set on fake jumps in order to keep add_jump_destinations() from setting their jump_dest, since it already got set when the fake jump was created. But using the ignore flag is a bit of a hack.

  1   2   3   4   5   >