Re: [PATCH] drm: fix double free for gbo in drm_gem_vram_init and drm_gem_vram_create

Hi Thanks for the patch and apologies for being late with the review. The fix is good, but I'd like to see different approach. I'd rather have drm_gem_vram_init() being integrated into drm_gem_vram_create(). Do you prefer to make the patch or shall I type up something? Would you be able to test?

Re: [PATCH 4.9 00/59] 4.9.226-rc2 review

On Tue, Jun 30, 2020 at 11:46:34PM +0200, Pavel Machek wrote: > Hi! > > > >FWIW, if we need/want to use unified assembler in v4.9.y, shouldn't all > > >unified > > >assembler patches be applied ? > > > > We don't - I took 71f8af111010 as a dependency rather than on its own > > merit. > > Would

Re: [RFC] Restrict the untrusted devices, to bind to only a set of "whitelisted" drivers

On Tue, Jun 30, 2020 at 11:45:59PM +0200, Pavel Machek wrote: > Hi! > > > Yes such drivers should be fixed, no doubt. But without lots of > > fuzzing (we're working on this) and testing we'd like to avoid > > exposing that attack surface at all. > > > > I think your suggestion to disable driver

Re: [PATCH] usb: gadget: f_acm: don't disable disabled EP

Michał Mirosław writes: > On Sat, May 30, 2020 at 01:03:17AM +, Peter Chen wrote: >> >> > > > @@ -425,9 +425,11 @@ static int acm_set_alt(struct usb_function *f, >> > > > unsigned >> > intf, unsigned alt) >> > > >/* we know alt == 0, so this is an activation or a reset */ >> > > >

RE: [PATCH] usb: gadget: f_acm: don't disable disabled EP

Peter Chen writes: > >> > > @@ -425,9 +425,11 @@ static int acm_set_alt(struct usb_function *f, >> > > unsigned >> intf, unsigned alt) >> > > /* we know alt == 0, so this is an activation or a reset */ >> > > >> > > if (intf == acm->ctrl_id) { >> > > -dev_vdbg

Re: [RESEND PATCH v10 2/2] phy: samsung-ufs: add UFS PHY driver for samsung SoC

Hi Alim, On 25-06-20, 05:26, Alim Akhtar wrote: > +int samsung_ufs_phy_wait_for_lock_acq(struct phy *phy) static ? > +{ > + struct samsung_ufs_phy *ufs_phy = get_samsung_ufs_phy(phy); > + const unsigned int timeout_us = 10; > + const unsigned int sleep_us = 10; > + u32 val;

Re: [PATCH] usb: cdns3: fix possible buffer overflow caused by bad DMA value

Peter Chen writes: > On 20-05-30 11:24:00, Jia-Ju Bai wrote: >> In cdns3_ep0_setup_phase(): >> struct usb_ctrlrequest *ctrl = priv_dev->setup_buf; >> >> Because priv_dev->setup_buf (allocated in cdns3_gadget_start) is stored >> in DMA memory, and thus ctrl is a DMA value. >> >> cdns3_ep0_set

Re: [PATCH v2 1/1] drivers: mtd: spi-nor: update read capabilities for w25q64 and s25fl064k

On 5/29/20 10:16 AM, Rayagonda Kokatanur wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Both w25q64 and s25fl064k nor flash support QUAD and DUAL read > command, hence update the same in flash_info table. > > This is tested on Broadcom S

Re: [PATCH v2] dt-bindings: display: Convert connectors to DT schema

On Tue, Jun 30, 2020 at 02:02:16PM -0600, Rob Herring wrote: > Convert the analog TV, DVI, HDMI, and VGA connector bindings to DT schema > format. > > Cc: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Maxime Ripard > Signed-off-by: Rob Herring Reviewed-by: Maxime Ripard Thanks! Maxime signatu

Re: [PATCH] USB: Fix up terminology

On Wed, Jul 01, 2020 at 06:40:20AM +, Peter Chen wrote: > > > > > On Wed, Jul 01, 2020 at 02:02:00PM +0800, Peter Chen wrote: > > > > index 3a7179e90f4e..1a12aab208b4 100644 > > > > --- a/drivers/usb/gadget/udc/Kconfig > > > > +++ b/drivers/usb/gadget/udc/Kconfig > > > > @@ -474,7 +474,7 @@

[PATCH v4 2/3] selftests: add clone3() CAP_CHECKPOINT_RESTORE test

This adds a test that changes its UID, uses capabilities to get CAP_CHECKPOINT_RESTORE and uses clone3() with set_tid to create a process with a given PID as non-root. Signed-off-by: Adrian Reber --- tools/testing/selftests/clone3/Makefile | 4 +- .../clone3/clone3_cap_checkpoint_restore

[PATCH v4 3/3] prctl: Allow ptrace capable processes to change /proc/self/exe

From: Nicolas Viennot Previously, the current process could only change the /proc/self/exe link with local CAP_SYS_ADMIN. This commit relaxes this restriction by permitting such change with CAP_CHECKPOINT_RESTORE, and the ability to use ptrace. With access to ptrace facilities, a process can do

Re: [PATCH] USB: Fix up terminology

On Wed, Jul 01, 2020 at 09:36:58AM +0300, Felipe Balbi wrote: > Greg Kroah-Hartman writes: > > > USB is a HOST/DEVICE protocol, as per the specification and all > > documentation. Fix up terms that are not applicable to make things > > match up with the terms used through the rest of the USB sta

[PATCH v4 1/3] capabilities: Introduce CAP_CHECKPOINT_RESTORE

This patch introduces CAP_CHECKPOINT_RESTORE, a new capability facilitating checkpoint/restore for non-root users. Over the last years, The CRIU (Checkpoint/Restore In Userspace) team has been asked numerous times if it is possible to checkpoint/restore a process as non-root. The answer usually wa

[PATCH v4 0/3] capabilities: Introduce CAP_CHECKPOINT_RESTORE

This is v4 of the 'Introduce CAP_CHECKPOINT_RESTORE' patchset. There is only one change from v3 to address Jann's comment on patch 3/3 (That is not necessarily true in the presence of LSMs like SELinux: You'd have to be able to FILE__EXECUTE_NO_TRANS the target executable according to the syste

Re: [PATCH] ALSA: hda/realtek: Serialize setting GPIO LED

On Wed, 01 Jul 2020 07:21:35 +0200, Kai-Heng Feng wrote: > > If a system has two GPIO controlled LED, one for mute and another one > for micmute, and both of them are on before system suspend, sometimes > one of them won't be turned off by system suspend. > > The codec doesn't seem to be able to

Re: [PATCH v3] HID: i2c-hid: Enable touchpad wakeup from Suspend-to-Idle

> On Jun 19, 2020, at 17:56, Hans de Goede wrote: > > Hi, > > On 6/19/20 6:16 AM, Kai-Heng Feng wrote: >> Hi, >>> On Jun 18, 2020, at 23:28, Hans de Goede wrote: >>> >>> Hi, >>> >>> On 6/18/20 4:55 PM, Kai-Heng Feng wrote: Many laptops can be woken up from Suspend-to-Idle by touchpad.

Re: [PATCH v3 7/7] x86/boot: Check that there are no runtime relocations

On Wed, 1 Jul 2020 at 01:28, Arvind Sankar wrote: > > On Tue, Jun 30, 2020 at 03:00:43PM -0700, Fangrui Song wrote: > > * Ard Biesheuvel > > > On Tue, 30 Jun 2020 at 01:34, Fangrui Song wrote: > > > > If the executable is purely static, it does not need to have PLT. All > > calls to a PLT can be

Re: [PATCH 4.9 026/191] ALSA: usb-audio: Improve frames size computation

On Tue, 30 Jun 2020 20:33:28 +0200, Greg KH wrote: > > On Tue, Jun 30, 2020 at 12:54:07PM -0400, Sasha Levin wrote: > > On Tue, Jun 30, 2020 at 01:49:50PM +0300, Alexander Tsoy wrote: > > > В Пн, 29/06/2020 в 11:37 -0400, Sasha Levin пишет: > > > > From: Alexander Tsoy > > > > > > > > [ Upstream

Re: [PATCH v9 1/2] of_graph: add of_graph_is_present()

01.07.2020 08:45, Laurent Pinchart пишет: > Hi Dmitry, > > Thank you for the patch. > > On Wed, Jul 01, 2020 at 05:16:16AM +0300, Dmitry Osipenko wrote: >> In some case, like a DRM display code for example, it's useful to silently >> check whether port node exists at all in a device-tree before p

Re: UART/TTY console deadlock

On 6/30/2020 11:32 PM, Tony Lindgren wrote: * Sergey Senozhatsky [200630 13:06]: On (20/06/30 14:22), Petr Mladek wrote: ... @@ -2284,8 +2289,6 @@ int serial8250_do_startup(struct uart_port *port) * allow register changes to become visible. */

RE: [PATCH] USB: Fix up terminology

> > On Wed, Jul 01, 2020 at 02:02:00PM +0800, Peter Chen wrote: > > > index 3a7179e90f4e..1a12aab208b4 100644 > > > --- a/drivers/usb/gadget/udc/Kconfig > > > +++ b/drivers/usb/gadget/udc/Kconfig > > > @@ -474,7 +474,7 @@ config USB_DUMMY_HCD > > > help > > > This host controll

[PATCH v2 2/5] soundwire: stream: add helper to startup/shutdown streams

From: Pierre-Louis Bossart To handle streams at the dailink level, expose two helpers that will be called from machine drivers. Reviewed-by: Ranjani Sridharan Reviewed-by: Guennadi Liakhovetski Reviewed-by: Kai Vehmanen Signed-off-by: Pierre-Louis Bossart Signed-off-by: Bard Liao --- Docum

[PATCH v2 1/5] soundwire: intel: implement get_sdw_stream() operations

From: Pierre-Louis Bossart This is needed to retrieve the information when the stream is allocated at the dai_link level. Signed-off-by: Pierre-Louis Bossart Signed-off-by: Bard Liao --- drivers/soundwire/intel.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/

[PATCH v2 0/5] soundwire: handle stream at the dailink level

Currently, stream is handled at the dai level. But we have to handle stream at the dailink level in the multi-cpu dailink usage. changes in v2: - Add kernel doc - Use single line trace log Pierre-Louis Bossart (5): soundwire: intel: implement get_sdw_stream() operations soundwire: stream: a

[PATCH v2 3/5] soundwire: intel: remove stream allocation/free

From: Pierre-Louis Bossart To support streaming across multiple links, the stream allocation/free needs to be at the dailink level, not the dai. Signed-off-by: Pierre-Louis Bossart Signed-off-by: Bard Liao --- drivers/soundwire/intel.c | 57 +-- 1 file chan

[PATCH v2 4/5] soundwire: cadence: allocate/free dma_data in set_sdw_stream

From: Pierre-Louis Bossart The current memory allocation is somewhat strange: the dma_data is allocated in set_sdw_stream, but released in the intel DAI shutdown. This no longer works with the multi-cpu implementation, since the dma_data is released in the dai shutdown which takes place before th

[PATCH v2 5/5] soundwire: intel: don't free dma_data in DAI shutdown

From: Pierre-Louis Bossart Now that the DMA data is allocated/freed in set_sdw_stream(), remove free operations. Signed-off-by: Pierre-Louis Bossart Signed-off-by: Bard Liao --- drivers/soundwire/intel.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/soundwire/intel.c b/dri

Re: [PATCH] USB: Fix up terminology

Greg Kroah-Hartman writes: > USB is a HOST/DEVICE protocol, as per the specification and all > documentation. Fix up terms that are not applicable to make things > match up with the terms used through the rest of the USB stack. > > Signed-off-by: Greg Kroah-Hartman Do you want me to pick this

Re: [f2fs-dev] [PATCH] f2fs: add symbolic link to kobject in sysfs

Hi Daeho, On 2020/6/30 8:56, Daeho Jeong wrote: > From: Daeho Jeong > > Added a symbolic link to directory of sysfs. It will > create a symbolic link such as "mount_0" and "mount_1" to > each f2fs mount in the order of mounting filesystem. It will > provide easy access to sysfs node even if not

Re: [PATCH v9 00/11] Genericize DW MIPI DSI bridge and add i.MX 6 driver

Hi Neil, On Mon, 29 Jun 2020, Neil Armstrong wrote: Hi Adrian, On 09/06/2020 19:49, Adrian Ratiu wrote: [Re-submitting to cc dri-devel, sorry about the noise] Hello all, v9 cleanly applies on top of latest next-20200609 tree. v9 does not depend on other patches as the last binding doc ha

Re: [PATCH] USB: Fix up terminology

On Wed, Jul 01, 2020 at 02:02:00PM +0800, Peter Chen wrote: > > index 3a7179e90f4e..1a12aab208b4 100644 > > --- a/drivers/usb/gadget/udc/Kconfig > > +++ b/drivers/usb/gadget/udc/Kconfig > > @@ -474,7 +474,7 @@ config USB_DUMMY_HCD > > help > > This host controller driver emulates

Re: [PATCH] spi: Avoid setting the chip select if we don't need to

On Mon, 2020-06-29 at 16:41 -0700, Douglas Anderson wrote: > [External] > > On some SPI controllers (like spi-geni-qcom) setting the chip select > is a heavy operation. For instance on spi-geni-qcom, with the current > code, is was measured as taking upwards of 20 us. Even on SPI > controllers t

[PATCH 5/9] usb: cdns3: Improvement: changed return type from int to bool

Patch changes return type from int to bool for cdns3_is_host and cdns3_is_device functions. Signed-off-by: Pawel Laszczak --- drivers/usb/cdns3/drd.c | 16 drivers/usb/cdns3/drd.h | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/usb/cdns3/drd.c

[PATCH 2/9] usb: cdns3: Improvement: removed not needed variables initialization

Patch remove some variables initialization from core.c and drd.c file. Signed-off-by: Pawel Laszczak --- drivers/usb/cdns3/core.c | 4 ++-- drivers/usb/cdns3/drd.c | 19 +-- 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/

[PATCH 6/9] usb: cdns3: Added CDNS3_ID_PERIPHERAL and CDNS3_ID_HOST

Patch adds 2 definitions that make it easier to understand the code. Signed-off-by: Pawel Laszczak --- drivers/usb/cdns3/drd.c | 4 ++-- drivers/usb/cdns3/drd.h | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c index 6fe092c

[PATCH 4/9] usb: cdns3: Improvement: return IRQ_NONE explicitly.

IRQ_NONE can be returned indirect. Signed-off-by: Pawel Laszczak --- drivers/usb/cdns3/drd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c index 6d2da504ad49..05a9f7d54c46 100644 --- a/drivers/usb/cdns3/drd.c +++ b/drive

[PATCH 1/9] usb: cdns3: Improvement: removed cdns3_get_current_role_driver function.

Function is not used in driver so it can be removed. Signed-off-by: Pawel Laszczak --- drivers/usb/cdns3/core.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c index 19bbb5b7e6b6..eaafa6bd2a50 100644 --- a/drivers/usb/cdns3/core.c +++

[PATCH 0/9] usb: cdns3: Improvements for cdns3 DRD code

Series introduce some improvements to drd.c, drd.h and core.c files of cdns3 driver. Except for the first (1/9) patch that removes not needed function, the rest patches make improvements suggested by Dan Carpenter during reviewing CDNSP driver. CDNSP is the next Cadence USBSSP driver which will

[PATCH 8/9] usb: cdns3: Improvement: removed overwriting some error code

Some error code can be preserved, so we can remove overwriting error code returned by some functions. Signed-off-by: Pawel Laszczak --- drivers/usb/cdns3/core.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c index 5

[PATCH 7/9] usb: cdns3: Improvement: removed 'goto not_otg'

Patch removes 'goto not_otg' instruction from cdnsp_hw_role_state_machine function. Signed-off-by: Pawel Laszczak --- drivers/usb/cdns3/core.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c index c3da

[PATCH 3/9] usb: cnds3: Improvement: deleted !=

Patch deletes unnecessary != from condition statement ini cdns3_drd_init function. Signed-off-by: Pawel Laszczak --- drivers/usb/cdns3/drd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c index 4939a568d8a2..6d2da504ad49 1006

[PATCH 9/9] usb: cdns3: Impovement: simplify *switch_gadet and *switch_host

Patch split function cdns3_drd_switch_gadget and cdns3_drd_switch_host into: - cdns3_drd_host_on - cdns3_drd_host_off - cdns3_drd_gadget_on - cdns3_drd_gadgett_off These functions don't have any shared code so it's better to have smaller, faster and easier functions. Signed-off-by: Pawel Laszczak

[PATCH v2] modpost: remove use of non-standard strsep() in HOSTCC code

strsep() is neither standard C nor POSIX and used outside the kernel code here. Using it here requires that the build host supports it out of the box which is e.g. not true for a Darwin build host and using a cross-compiler. This leads to: scripts/mod/modpost.c:145:2: warning: implicit declaration

Re: [PATCH v6 1/6] mm/vmscan: make active/inactive ratio as 1:1 for anon lru

2020년 7월 1일 (수) 오전 2:27, Vlastimil Babka 님이 작성: > > On 6/17/20 7:26 AM, js1...@gmail.com wrote: > > From: Joonsoo Kim > > > > Current implementation of LRU management for anonymous page has some > > problems. Most important one is that it doesn't protect the workingset, > > that is, pages on the a

[PATCH v2 4/4] ARM: dts: rockchip: Add Radxa Rock Pi N8 initial support

Rock Pi N8 is a Rockchip RK3288 based SBC, which has - VMARC RK3288 SOM (as per SMARC standard) from Vamrs. - Compatible carrier board from Radxa. VAMRC RK3288 SOM need to mount on top of radxa dalang carrier board for making Rock Pi N8 SBC. So, add initial support for Rock Pi N8 by including rk3

[PATCH v2 3/4] ARM: dts: rockchip: Add VMARC RK3288 SOM initial support

VMARC RK3288 SOM is a standard SMARC SOM design with Rockchip RK3288 SoC, which is designed by Vamrs. Specification: - Rockchip RK3288 - PMIC: RK808 - eMMC: 16GB/32GB/64GB - SD slot - 2xUSB-2.0, 1xUSB3.0 - USB-C for power supply - Ethernet - HDMI, MIPI-DSI/CSI, eDP Add initial support for VMARC R

[PATCH v2 0/4] ARM: dts: rockchip: Radxa Rock Pi N8 initial support

Rock Pi N8 is a Rockchip RK3288 based SBC, which has - VMARC RK3288 SOM (as per SMARC standard) from Vamrs. - Compatible carrier board from Radxa. VMARC RK3288 SOM need to mount on top of dalang carrier board for making Rock PI N8 SBC. This series fixs few trivial changes related to properties m

[PATCH v2 2/4] dt-bindings: arm: rockchip: Add Rock Pi N8 binding

Rock Pi N8 is a Rockchip RK3288 based SBC, which has - VMARC RK3288 SOM (as per SMARC standard) from Vamrs. - Compatible carrier board from Radxa. VMARC RK3288 SOM need to mount on top of dalang carrier board for making Rock PI N8 SBC. Add dt-bindings for it. Signed-off-by: Jagan Teki --- Chang

[PATCH v2 1/4] arm64: dts: rockchip: Trivial cleanups for RockPI N10

Radxa dalang carrier boards are used to mount vmarc SoM's of rk3399pro and rk3288 to make complete SBC. So, this patch adds trivial changes to properties. - move common properties into radxa dalang carrier dtsi. - maintain ascending order for nodes, properties. - change the order of dtsi include s

[net-next PATCH v2 2/3] Documentation: ACPI: DSD: Document MDIO PHY

Introduce ACPI mechanism to get PHYs registered on a MDIO bus and provide them to be connected to MAC. An ACPI node property "mdio-handle" is introduced to reference the MDIO bus on which PHYs are registered with autoprobing method used by mdiobus_register(). Signed-off-by: Calvin Johnson --- C

[net-next PATCH v2 3/3] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

Modify dpaa2_mac_connect() to support ACPI along with DT. Modify dpaa2_mac_get_node() to get the dpmac fwnode from either DT or ACPI. Replace of_get_phy_mode with fwnode_get_phy_mode to get phy-mode for a dpmac_node. Define and use helper function find_phy_device() to find phy_dev that is later con

[net-next PATCH v2 1/3] net: phy: introduce find_phy_device()

The PHYs on a mdiobus are probed and registered using mdiobus_register(). Later, for connecting these PHYs to MAC, the PHYs registered on the mdiobus have to be referenced. For each MAC node, a property "mdio-handle" is used to reference the MDIO bus on which the PHYs are registered. On getting ho

[net-next PATCH v2 0/3] ACPI support for dpaa2 MAC driver.

This patch series provides ACPI support for dpaa2 MAC driver. This also introduces ACPI mechanism to get PHYs registered on a MDIO bus and provide them to be connected to MAC. This patchset is dependent on the review patches available on: https://git.kernel.org/pub/scm/linux/kernel/git/lpieral

[PATCH v3 4/4] staging: kpc2000: kpc_dma: Remove additional goto statements

As 3 goto level referring to same common code, those can be accomodated with a single goto level and renameing it to unpin_pages. Set the -ERRNO when returning partial mapped pages in more appropriate place. When dma_map_sg() failed, the previously allocated memory was not freed properly. This is

[PATCH v3 0/4] staging: kpc2000: kpc_dma: Few clean up and Convert to pin_user_pages()

This series contains few clean up, minor bug fixes and Convert get_user_pages() to pin_user_pages(). I'm compile tested this, but unable to run-time test, so any testing help is much appriciated. v2: Address Dan's review comments to return -ERRNO for partially mapped pages and cha

[PATCH v3 2/4] staging: kpc2000: kpc_dma: Convert set_page_dirty() --> set_page_dirty_lock()

First, convert set_page_dirty() to set_page_dirty_lock() Second, there is an interval in there after set_page_dirty() and before put_page(), in which the device could be running and setting pages dirty. Moving set_page_dirty_lock() after dma_unmap_sg(). Signed-off-by: Souptick Joarder Suggested-

[PATCH v3 3/4] staging: kpc2000: kpc_dma: Convert get_user_pages() --> pin_user_pages()

In 2019, we introduced pin_user_pages*() and now we are converting get_user_pages*() to the new API as appropriate. [1] & [2] could be referred for more information. This is case 2 as per document [1]. [1] Documentation/core-api/pin_user_pages.rst [2] "Explicit pinning of user-space pages":

[PATCH v3 1/4] staging: kpc2000: kpc_dma: Unpin partial pinned pages

There is a bug, when get_user_pages() failed but partially pinned pages are not unpinned and positive numbers are returned instead of -ERRNO. Fixed it. Also, int is more appropriate type for rv. Changed it. Signed-off-by: Souptick Joarder Cc: John Hubbard Cc: Dan Carpenter Cc: Bharath Vedartha

Re: How do you investigate the cause of total hang? Is there some information that I should pay attention to in order to get some hint?

On Tue, Jun 30, 2020 at 7:49 PM 孙世龙 sunshilong wrote: > > Hi, list > > My x86 machine(linux4.19) sometimes hangs, suddenly not responding in > any way to the mouse or the keyboard. > > How can I investigate why it hung up? Is there extra information I can > find for a clue? Is there anything less

alternative to xa_for_each?

Hi Matthew, I'm just reviewing a patch adding an xarray user, and I'm wondering if we could just replace xa_for_each with a loop on xa_find_after with a magic index to start from the beginning? That would always seem like more readable code than the magic looping macro. And while we're at it: i

Re: [PATCH] USB: Fix up terminology

> index 3a7179e90f4e..1a12aab208b4 100644 > --- a/drivers/usb/gadget/udc/Kconfig > +++ b/drivers/usb/gadget/udc/Kconfig > @@ -474,7 +474,7 @@ config USB_DUMMY_HCD > help > This host controller driver emulates USB, looping all data transfer > requests back to a USB "gadge

Re: [PATCH 1/2] kbuild: remove cc-option test of -fno-stack-protector

On Sat, Jun 27, 2020 at 03:59AM +0900, Masahiro Yamada wrote: > Some Makefiles already pass -fno-stack-protector unconditionally. > For example, arch/arm64/kernel/vdso/Makefile, arch/x86/xen/Makefile. > No problem report so far about hard-coding this option. So, we can > assume all supported compil

Re: [PATCH 8/9] soundwire: intel: add wake interrupt support

On 30-06-20, 12:18, Pierre-Louis Bossart wrote: > > > + return 0; > > > + } > > > + > > > + shim = sdw->link_res->shim; > > > + wake_sts = intel_readw(shim, SDW_SHIM_WAKESTS); > > > + > > > + if (!(wake_sts & BIT(sdw->instance))) > > > + return 0; > > > + > > > + /* disable WAKEEN i

Re: [PATCH 6/6] mm: Add memalloc_nowait

On Wed 01-07-20 05:12:03, Matthew Wilcox wrote: > On Tue, Jun 30, 2020 at 08:34:36AM +0200, Michal Hocko wrote: > > On Mon 29-06-20 22:28:30, Matthew Wilcox wrote: > > [...] > > > The documentation is hard to add a new case to, so I rewrote it. What > > > do you think? (Obviously I'll split this

Re: [PATCH v2] dt-bindings: display: Convert connectors to DT schema

Hi Rob, Thank you for the patch. On Tue, Jun 30, 2020 at 02:02:16PM -0600, Rob Herring wrote: > Convert the analog TV, DVI, HDMI, and VGA connector bindings to DT schema > format. > > Cc: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Maxime Ripard > Signed-off-by: Rob Herring Reviewed-by: Laure

Re: linux-next: manual merge of the rcu tree with the kbuild tree

On Wed, 1 Jul 2020 at 03:34, Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the rcu tree got a conflict in: > > kernel/kcsan/Makefile > > between commit: > > f7c28e224da6 ("kbuild: remove cc-option test of -fno-stack-protector") Is it possible that this patch drops the KC

Re: [PATCH 2/2] watchdog: rti: tweak min_hw_heartbeat_ms to match initial allowed window

On 30/06/2020 23:23, Guenter Roeck wrote: On Thu, Jun 25, 2020 at 08:04:50PM +0300, Tero Kristo wrote: On 25/06/2020 16:35, Guenter Roeck wrote: On 6/25/20 1:32 AM, Tero Kristo wrote: On 24/06/2020 18:24, Jan Kiszka wrote: On 24.06.20 13:45, Tero Kristo wrote: If the RTI watchdog has been st

Re: [PATCH] cpuidle: change enter_s2idle() prototype

On 01/07/2020 04:39, Neal Liu wrote: > On Mon, 2020-06-29 at 17:17 +0200, Rafael J. Wysocki wrote: >> On Monday, June 29, 2020 11:05:40 AM CEST Neal Liu wrote: >>> Control Flow Integrity(CFI) is a security mechanism that disallows >>> changes to the original control flow graph of a compiled binary,

Re: [PATCH v1] orinoco: use generic power management

On Wed, 24 Jun 2020 at 23:14, Vaibhav Gupta wrote: > > With the support of generic PM callbacks, drivers no longer need to use > legacy .suspend() and .resume() in which they had to maintain PCI states > changes and device's power state themselves. The required operations are > done by PCI core. >

linux-next: Tree for Jul 1

Hi all, Changes since 20200630: My fixes tree contains: dbf24e30ce2e ("device_cgroup: Fix RCU list debugging warning") b236d81d9e4f ("powerpc/boot/dts: Fix dtc "pciex" warnings") The tip tree still had one build failure for which I reverted a commit. The rcu

Re: [PATCH v9 1/2] of_graph: add of_graph_is_present()

Hi Dmitry, Thank you for the patch. On Wed, Jul 01, 2020 at 05:16:16AM +0300, Dmitry Osipenko wrote: > In some case, like a DRM display code for example, it's useful to silently > check whether port node exists at all in a device-tree before proceeding > with parsing of the graph. > > This patch

Re: [PATCH 7/9] soundwire: intel/cadence: merge Soundwire interrupt handlers/threads

On 30-06-20, 11:46, Pierre-Louis Bossart wrote: > > Is this called from irq context or irq thread or something else? > > from IRQ thread, hence the name, see pointers above. > > The key part is that we could only make the hardware work as intended by > using a single thread for all interrupt so

Re: [RFC][PATCH 3/8] mm/vmscan: Attempt to migrate page in lieu of discard

On Tue, 30 Jun 2020, Yang Shi wrote: > > > From: Dave Hansen > > > > > > If a memory node has a preferred migration path to demote cold pages, > > > attempt to move those inactive pages to that migration node before > > > reclaiming. This will better utilize available memory, provide a faster >

Re: [PATCH 2/5] soundwire: stream: add helper to startup/shutdown streams

On 30-06-20, 11:58, Pierre-Louis Bossart wrote: > > > +int sdw_startup_stream(void *sdw_substream) > > > > Can we have kernel doc style Documentation for exported APIs? > > yes, that's a miss indeed. > > Though if we follow the existing examples it's not going to be very > informative, e.g. Yea

Re: PCI: Replace lkml.org, spinics, gmane with lore.kernel.org

On Tue, 2020-06-30 at 14:04 -0600, Jonathan Corbet wrote: > On Tue, 30 Jun 2020 13:09:17 -0500 > Bjorn Helgaas wrote: > > > PCI: Replace lkml.org, spinics, gmane with lore.kernel.org > > > > The lkml.org, spinics.net, and gmane.org archives are not very reliable > > and, in some cases, not even

Re: [RFC v2] fpga: dfl: RFC PCI config

On Tue, Jun 30, 2020 at 11:49:50AM -0700, t...@redhat.com wrote: > From: Tom Rix > > Create some top level configs the map to dfl pci cards. > > Autoselect the parts of fpga that are needed to run these cards > as well as the defining the other subsystem dependencies. > > Signed-off-by: Tom Rix

[PATCH V2] arm64/cpufeature: Validate feature bits spacing in arm64_ftr_regs[]

arm64_feature_bits for a register in arm64_ftr_regs[] are in a descending order as per their shift values. Validate that these features bits are defined correctly and do not overlap with each other. This check protects against any inadvertent erroneous changes to the register definitions. Cc: Cata

[PATCH] ALSA: hda/realtek: Serialize setting GPIO LED

If a system has two GPIO controlled LED, one for mute and another one for micmute, and both of them are on before system suspend, sometimes one of them won't be turned off by system suspend. The codec doesn't seem to be able to control multiple GPIO LEDs at the same time, so introduce a new mutex

RE: [PATCH V3 02/10] init.h: Fix the __setup_param() macro for module build

Hi, Arnd > Subject: Re: [PATCH V3 02/10] init.h: Fix the __setup_param() macro for > module build > > On Mon, Jun 29, 2020 at 1:40 PM Anson Huang > wrote: > > > Subject: Re: [PATCH V3 02/10] init.h: Fix the __setup_param() macro > > > for module build > > > > > > On Mon, Jun 29, 2020 at 8:06 AM

Re: [RFC v2] fpga: dfl: RFC PCI config

On Tue, Jun 30, 2020 at 11:49:50AM -0700, t...@redhat.com wrote: > From: Tom Rix > > Create some top level configs the map to dfl pci cards. > > Autoselect the parts of fpga that are needed to run these cards > as well as the defining the other subsystem dependencies. > > Signed-off-by: Tom Rix

mmotm 2020-06-30-21-52 uploaded

The mm-of-the-moment snapshot 2020-06-30-21-52 has been uploaded to http://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: http://www.ozlabs.org/~akpm/mmotm/ This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week. You wi

Re: [PATCH v3] cpufreq: CPPC: simply the code access 'highest_perf' value in cppc_perf_caps struct

On 01-07-20, 12:20, Xin Hao wrote: > The 'caps' variable has been defined, so there is no need to get > 'highest_perf' value through 'cpu->caps.highest_perf', you can use > 'caps->highest_perf' instead. > > Signed-off-by: Xin Hao > --- > drivers/cpufreq/cppc_cpufreq.c | 4 ++-- > 1 file chang

Re: [PATCH] pinctrl: initialise nsp-mux earlier.

On 6/30/2020 9:37 PM, Mark Tomlinson wrote: > On Tue, 2020-06-30 at 20:14 -0700, Florian Fainelli wrote: >> Sorry, it looks like I made a mistake in my testing (or I was lucky), >>> and this patch doesn't fix the issue. What is happening is: >>> 1) nsp-pinmux driver is registered (arch_initcall)

[PATCH V3] arm64/hugetlb: Reserve CMA areas for gigantic pages on 16K and 64K configs

Currently 'hugetlb_cma=' command line argument does not create CMA area on ARM64_16K_PAGES and ARM64_64K_PAGES based platforms. Instead, it just ends up with the following warning message. Reason being, hugetlb_cma_reserve() never gets called for these huge page sizes. [ 64.255669] hugetlb_cma:

Re: [PATCH v3 1/2] remoteproc: Add remoteproc character device interface

On Tue 30 Jun 00:43 PDT 2020, Arnaud POULIQUEN wrote: > > > On 6/30/20 7:38 AM, Siddharth Gupta wrote: > > > > On 6/17/2020 1:44 AM, Arnaud POULIQUEN wrote: > >> > >> On 6/16/20 9:56 PM, risha...@codeaurora.org wrote: > >>> On 2020-04-30 01:30, Arnaud POULIQUEN wrote: > Hi Rishabh, >

Re: [git pull] drm for 5.8-rc1

This implies something is trying to use one of the old DRM_FORMAT_MOD_NVIDIA_16BX2_BLOCK format modifiers with DRM-KMS without first checking whether it is supported by the kernel. I had tried to force an Xorg+Mesa stack without my userspace patches to hit this error when testing, but must hav

Re: [PATCH] pinctrl: initialise nsp-mux earlier.

On Tue, 2020-06-30 at 20:14 -0700, Florian Fainelli wrote: > Sorry, it looks like I made a mistake in my testing (or I was lucky), > > and this patch doesn't fix the issue. What is happening is: > > 1) nsp-pinmux driver is registered (arch_initcall). > > 2) nsp-gpio-a driver is registered (arch_ini

Re: [PATCH] Revert "serial: 8250: Fix max baud limit in generic 8250 port"

On Tue, Jun 30, 2020 at 04:42:11PM -0700, Daniel Winkler wrote: > This reverts commit 0eeaf62981ecc79e8395ca8caa1570eaf3a12257. That is not an upstream commit. You probably mean: commit 7b668c064ec33f3d687c3a413d05e355172e6c92 Author: Serge Semin Date: Thu May 7 02:31:32 2020 +030

[RFC PATCH] interconnect: qcom: add functions to query addr/cmds for a path

The a6xx GMU can vote for ddr and cnoc bandwidth, but it needs to be able to query the interconnect driver for bcm addresses and commands. I'm not sure what is the best way to go about implementing this, this is what I came up with. I included a quick example of how this can be used by the a6xx d

Re: [PATCH 1/2] f2fs: split f2fs_allocate_new_segments()

On 07/01, Chao Yu wrote: > Jaegeuk, could you please help to change __allocate_new_segment() to static > in your tree? Sure. :) > > On 2020/6/30 4:19, Jaegeuk Kim wrote: > > On 06/22, Chao Yu wrote: > >> to two independent functions: > >> - f2fs_allocate_new_segment() for specified type segment

[PATCH v3] cpufreq: CPPC: simply the code access 'highest_perf' value in cppc_perf_caps struct

The 'caps' variable has been defined, so there is no need to get 'highest_perf' value through 'cpu->caps.highest_perf', you can use 'caps->highest_perf' instead. Signed-off-by: Xin Hao --- drivers/cpufreq/cppc_cpufreq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

Re: [EXTERNAL] Re: [PATCH v14 4/4] power: supply: bq25150 introduce the bq25150

On 6/30/20 6:33 PM, Sebastian Reichel wrote: Hi, On Tue, Jun 30, 2020 at 04:54:26PM -0500, Ricardo Rivera-Matos wrote: Introduce the bq2515x family of chargers. The BQ2515X family of devices are highly integrated battery management ICs that integrate the most common functions for wearable de

Re: [RFC PATCH 0/6] Support raw event and DT for perf on RISC-V

On Wed, Jul 1, 2020 at 6:48 AM Alan Kao wrote: > > On Mon, Jun 29, 2020 at 11:19:09AM +0800, Zong Li wrote: > > This patch set adds raw event support on RISC-V. In addition, we > > introduce the DT mechanism to make our perf more generic and common. > > > > Currently, we set the hardware events by

Re: [f2fs-dev] [PATCH] f2fs: add GC_URGENT_LOW mode in gc_urgent

Yes, it's correct. 2020년 7월 1일 (수) 오후 12:35, Chao Yu 님이 작성: > > On 2020/6/30 8:54, Daeho Jeong wrote: > > From: Daeho Jeong > > > > Added a new gc_urgent mode, GC_URGENT_LOW, in which mode > > F2FS will lower the bar of checking idle in order to > > process outstanding discard commands and GC a l

[PATCH] drm/msm/dpu: fix wrong return value in dpu_encoder_init()

A positive value ENOMEM is returned here. I thinr this is a typo error. It is necessary to return a negative error value. Signed-off-by: Tianjia Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1

Re: [PATCH v2] cpufreq: CPPC: fix some unreasonable codes in cppc_cpufreq_perf_to_khz()

On 01-07-20, 11:26, Xin Hao wrote: > The 'caps' variable has been defined, so there is no need to get > 'highest_perf' value through 'cpu->caps.highest_perf', you can use > 'caps->highest_perf' instead. > > Signed-off-by: Xin Hao > --- > drivers/cpufreq/cppc_cpufreq.c | 2 +- > 1 file changed

Re: [PATCH 6/6] mm: Add memalloc_nowait

On Tue, Jun 30, 2020 at 08:34:36AM +0200, Michal Hocko wrote: > On Mon 29-06-20 22:28:30, Matthew Wilcox wrote: > [...] > > The documentation is hard to add a new case to, so I rewrote it. What > > do you think? (Obviously I'll split this out differently for submission; > > this is just what I ha

[PATCH] ARM: dts: imx6ul: Add ASRC device node

Add ASRC device node. Signed-off-by: Shengjiu Wang --- arch/arm/boot/dts/imx6ul.dtsi | 25 + 1 file changed, 25 insertions(+) diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi index 5379a03391bd..d10d5eb55a88 100644 --- a/arch/arm/boot/dts/imx6ul

Re: [regression] TCP_MD5SIG on established sockets

On Tue, Jun 30, 2020 at 08:36:51PM -0700, Eric Dumazet wrote: > > If I knew so many people were excited about TCP / MD5, I would have > posted all my patches on lkml ;) > > Without the smp_wmb() we would still need something to prevent KMSAN > from detecting that we read uninitialized bytes, > if

  1   2   3   4   5   6   7   8   9   10   >