Re: [PATCH] spi: Fix use-after-free with devm_spi_alloc_*

2021-04-08 Thread Joel Stanley
On Wed, 7 Apr 2021 at 09:55, William A. Kennington III wrote: > > We can't rely on the contents of the devres list during > spi_unregister_controller(), as the list is already torn down at the > time we perform devres_find() for devm_spi_release_controller. This > causes devices registered with de

Re: [PATCH v4] lib/string: Introduce sysfs_streqcase

2021-04-08 Thread Greg Kroah-Hartman
On Thu, Apr 08, 2021 at 11:51:32PM -0700, Andrew Morton wrote: > On Fri, 9 Apr 2021 08:44:39 +0200 Greg Kroah-Hartman > wrote: > > > On Thu, Apr 08, 2021 at 10:05:02PM -0700, Andrew Morton wrote: > > > On Thu, 8 Apr 2021 15:06:05 +0200 Gioh Kim wrote: > > > > > > > As the name shows, it check

Re: [PATCH V5 16/25] perf/x86: Register hybrid PMUs

2021-04-08 Thread Peter Zijlstra
On Mon, Apr 05, 2021 at 08:10:58AM -0700, kan.li...@linux.intel.com wrote: > @@ -2089,9 +2119,46 @@ static int __init init_hw_perf_events(void) > if (err) > goto out1; > > - err = perf_pmu_register(&pmu, "cpu", PERF_TYPE_RAW); > - if (err) > - goto out2; >

linux-next: manual merge of the drivers-x86 tree with the battery tree

2021-04-08 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drivers-x86 tree got a conflict in: MAINTAINERS between commit: 167f77f7d0b3 ("power: supply: Add battery driver for Surface Aggregator Module") from the battery tree and commit: 1d609992832e ("platform/surface: Add DTX driver") from the drivers

Re: [PATCH v4 2/2] iio: temperature: add driver support for ti tmp117

2021-04-08 Thread Lars-Peter Clausen
On 4/7/21 8:21 PM, Puranjay Mohan wrote: TMP117 is a Digital temperature sensor with integrated Non-Volatile memory. Add support for tmp117 driver in iio subsystem. Datasheet: https://www.ti.com/lit/gpn/tmp117 Signed-off-by: Puranjay Mohan Reviewed-by: Andy Shevchenko Looks good to me, thank

[PATCH v7] RISC-V: enable XIP

2021-04-08 Thread Alexandre Ghiti
From: Vitaly Wool Introduce XIP (eXecute In Place) support for RISC-V platforms. It allows code to be executed directly from non-volatile storage directly addressable by the CPU, such as QSPI NOR flash which can be found on many RISC-V platforms. This makes way for significant optimization of RAM

Re: [PATCH -next] ARM: spear: Fix build error with CONFIG_ARCH_SPEAR3XX

2021-04-08 Thread chenlifu
在 2021/4/9 12:03, Viresh Kumar 写道: On 09-04-21, 09:55, Chen Lifu wrote: commit 77f983a9df42 ("spi: pl022: Use GPIOs looked up by the core") deleted 'struct pl022_ssp_controller' member 'num_chipselect'. We get build error when CONFIG_ARCH_SPEAR3XX is set: arch/arm/mach-spear/spear3xx.c:42:3: e

Re: [PATCH v4] lib/string: Introduce sysfs_streqcase

2021-04-08 Thread Andrew Morton
On Fri, 9 Apr 2021 08:44:39 +0200 Greg Kroah-Hartman wrote: > On Thu, Apr 08, 2021 at 10:05:02PM -0700, Andrew Morton wrote: > > On Thu, 8 Apr 2021 15:06:05 +0200 Gioh Kim wrote: > > > > > As the name shows, it checks if strings are equal in case insensitive > > > manner. > > > > Peh. Who w

Re: [next] drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared (first use in this function)

2021-04-08 Thread Naresh Kamboju
On Fri, 9 Apr 2021 at 12:02, Chaitanya Kulkarni wrote: > > On 4/8/21 23:24, Naresh Kamboju wrote: > >> bio_offset(req->bio), > >> GDROM_DMA_STARTADDR_REG); > >> __raw_writel(block_cnt * GDROM_HARD_SECTOR, GDROM_DMA_LENGTH_REG); > >> __raw_writel(1, GDROM_DMA

[PATCH] arm: mach-s3c: Remove unnecessary break

2021-04-08 Thread Wan Jiabing
There is a return above the break. The break here is unnecessary. Remove it. Signed-off-by: Wan Jiabing --- arch/arm/mach-s3c/mach-rx1950.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-s3c/mach-rx1950.c b/arch/arm/mach-s3c/mach-rx1950.c index 6e19add158a9..9da94686001a 100644

Re: [RFC 0/4] Fix machine check recovery for copy_from_user

2021-04-08 Thread Aili Yao
On Thu, 8 Apr 2021 14:39:09 + "Luck, Tony" wrote: > > I have one scenario, may you take into account: > > > > If one copyin case occurs, write() returned by your patch, the user process > > may > > check the return values, for errors, it may exit the process, then the > > error page > > wil

Re: [PATCH] clk: uniphier: Fix potential infinite loop

2021-04-08 Thread Masahiro Yamada
On Thu, Apr 8, 2021 at 12:25 AM Colin King wrote: > > From: Colin Ian King > > The for-loop iterates with a u8 loop counter i and compares this > with the loop upper limit of num_parents that is an int type. > There is a potential infinite loop if num_parents is larger than > the u8 loop counter.

Re: [PATCH v2 0/2] USB:ehci:fix the no SRBN register problem

2021-04-08 Thread Greg KH
On Fri, Apr 09, 2021 at 10:42:35AM +0800, liulongfang wrote: > On 2021/4/8 22:53, Alan Stern wrote: > > On Thu, Apr 08, 2021 at 09:49:18PM +0800, Longfang Liu wrote: > >> (1) Add a whitelist for EHCI devices without SBRN registers. > >> (2) Add Kunpeng920's EHCI device to the whitelist. > >> > >> C

Re: [PATCH v2 16/21] ipmi: kcs_bmc: Add a "raw" character device interface

2021-04-08 Thread Andrew Jeffery
On Fri, 9 Apr 2021, at 14:47, Zev Weiss wrote: > On Fri, Mar 19, 2021 at 01:27:47AM CDT, Andrew Jeffery wrote: > >The existing IPMI chardev encodes IPMI behaviours as the name suggests. > >However, KCS devices are useful beyond IPMI (or keyboards), as they > >provide a means to generate IRQs and

[PATCH -next] media: sunxi: sun8i-rotate: fix PM reference leak in rotate_start_streaming()

2021-04-08 Thread Xiang Yang
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Xiang Yang --- .../platform/sunxi/

Re: [PATCH v3 1/2] USB:ehci:Add a whitelist for EHCI controllers

2021-04-08 Thread Greg KH
On Fri, Apr 09, 2021 at 11:00:14AM +0800, Longfang Liu wrote: > Some types of EHCI controllers do not have SBRN registers. > By comparing the white list, the operation of reading the SBRN > registers is skipped. > > Subsequent EHCI controller types without SBRN registers can be > directly added to

Re: [PATCH v4] lib/string: Introduce sysfs_streqcase

2021-04-08 Thread Greg Kroah-Hartman
On Thu, Apr 08, 2021 at 10:05:02PM -0700, Andrew Morton wrote: > On Thu, 8 Apr 2021 15:06:05 +0200 Gioh Kim wrote: > > > As the name shows, it checks if strings are equal in case insensitive > > manner. > > Peh. Who would die if we simply made sysfs_streq() case-insensitive? I doubt anyone, l

Re: [PATCH 02/11] mm/page_alloc: Convert per-cpu list protection to local_lock

2021-04-08 Thread Peter Zijlstra
On Thu, Apr 08, 2021 at 06:42:44PM +0100, Mel Gorman wrote: > On Thu, Apr 08, 2021 at 12:52:07PM +0200, Peter Zijlstra wrote: > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > > index a68bacddcae0..e9e60d1a85d4 100644 > > > --- a/mm/page_alloc.c > > > +++ b/mm/page_alloc.c > > > @@ -112,6 +1

Re: [PATCH net-next v3 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 06:59:19PM +, Min Li wrote: > > > > But what does that have to do with the misc device? > > > > Hi Greg, MFD driver is the start of everything. Once MFD driver is loading, > it will spawn 2 devices, > one is for phc driver, which is under /driver/ptp and the other

[PATCH -next v2] clocksource/drivers/qcom: add missing iounmap() on error in msm_dt_timer_init()

2021-04-08 Thread Yang Yingliang
base and cpu0_base are not unmapped on error path, add the missing iounmap() before return msm_dt_timer_init() in the error handling cases. Fixes: 6e3321631ac2 ("ARM: msm: Add DT support to msm_timer") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Reviewed-by: Manivannan Sadhasivam ---

[PATCH -next] powerpc/powernv: make symbol 'mpipl_kobj' static

2021-04-08 Thread Bixuan Cui
The sparse tool complains as follows: arch/powerpc/platforms/powernv/opal-core.c:74:16: warning: symbol 'mpipl_kobj' was not declared. This symbol is not used outside of opal-core.c, so marks it static. Reported-by: Hulk Robot Signed-off-by: Bixuan Cui --- arch/powerpc/platforms/powernv/opal

Re: [PATCH v2 14/21] ipmi: kcs_bmc: Allow clients to control KCS IRQ state

2021-04-08 Thread Andrew Jeffery
On Fri, 9 Apr 2021, at 14:07, Zev Weiss wrote: > On Fri, Mar 19, 2021 at 01:27:45AM CDT, Andrew Jeffery wrote: > >Add a mechanism for controlling whether the client associated with a > >KCS device will receive Input Buffer Full (IBF) and Output Buffer Empty > >(OBE) events. This enables an abstr

Re: [PATCH 17/17] bit_spinlock: Track bit spin locks with lockdep

2021-04-08 Thread kernel test robot
Hi "Matthew, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20210408] [cannot apply to s390/features tip/x86/core dm/for-next gfs2/for-next block/for-next linus/master hnaz-linux-mm/master v5.12-rc6 v5.12-rc5 v5.12-rc4 v5.12-rc6] [If your patch is appli

Re: [PATCH 09/20] kbuild: arm64: use common install script

2021-04-08 Thread Greg Kroah-Hartman
On Thu, Apr 08, 2021 at 08:08:18PM -0700, Kees Cook wrote: > On Wed, Apr 07, 2021 at 07:34:08AM +0200, Greg Kroah-Hartman wrote: > > The common scripts/install.sh script will now work for arm65, no changes > > nit: arm64 Hah! Thanks for the reviews, I'll be doing a new series soon based on Masah

Re: [PATCH 3/4] mm/hugeltb: fix potential wrong gbl_reserve value for hugetlb_acct_memory()

2021-04-08 Thread Miaohe Lin
On 2021/4/9 12:37, Mike Kravetz wrote: > On 4/8/21 8:01 PM, Miaohe Lin wrote: >> On 2021/4/9 6:53, Mike Kravetz wrote: >>> >>> Yes, add a comment to hugetlb_unreserve_pages saying that !resv_map >>> implies freed == 0. >>> >> >> Sounds good! >> >>> It would also be helpful to check for (chg - freed

[Outreachy kernel] [PATCH v5] staging: rtl8723bs: Remove camelcase in several files

2021-04-08 Thread Fabio M. De Francesco
Remove camelcase in bFwCurrentInPSMode, a variable used by code of several subdirectories/files of the driver. Issue detected by checkpatch.pl. Delete the unnecessary "b" (that stands for "byte") from the beginning of the name. Signed-off-by: Fabio M. De Francesco --- Changes from v4: Mention th

Re: [PATCH v5 3/4] drivers/tty/serial/8250: add aspeed, lpc-io-reg and aspeed, lpc-interrupts DT properties

2021-04-08 Thread Zev Weiss
On Fri, Apr 09, 2021 at 12:14:54AM CDT, Andrew Jeffery wrote: Hi Zev, A couple of minor comments: On Thu, 8 Apr 2021, at 10:46, Zev Weiss wrote: These allow describing all the Aspeed VUART attributes currently available via sysfs. aspeed,sirq aspeed,lpc-interrupts now Ah right, thanks.

Re: [PATCH -next] mmc: sdhci-msm: Remove unnecessary error log

2021-04-08 Thread Manivannan Sadhasivam
On Fri, Apr 09, 2021 at 09:54:24AM +0800, Jia Yang wrote: > devm_ioremap_resource() has recorded error log, so it's > unnecessary to record log again. > > Reported-by: Hulk Robot > Signed-off-by: Jia Yang Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/mmc/host/sdhci-msm.c |

Re: [PATCH] staging: rtl8712: fix wrong function output

2021-04-08 Thread Greg KH
On Fri, Apr 09, 2021 at 01:45:27AM +0200, Sergei Krainov wrote: > Function r8712_find_network() were returning wlan_network even if it > didn't match required address. This happened due to not checking if > list end was reached and returning last processed wlan_network. > > Signed-off-by: Sergei K

Re: [PATCH -next] clocksource/drivers/qcom: add missing iounmap() on error in msm_dt_timer_init()

2021-04-08 Thread Manivannan Sadhasivam
On Fri, Apr 09, 2021 at 12:56:57PM +0800, Yang Yingliang wrote: > base and cpu0_base are not unmapped on error path, add the missing > iounmap() before return msm_dt_timer_init() in the error handling > cases. > > Fixes: 6e3321631ac2 ("ARM: msm: Add DT support to msm_timer") > Reported-by: Hulk Ro

[PATCH v5 3/3] KVM: nVMX: Add CET entry/exit load bits to evmcs unsupported list

2021-04-08 Thread Yang Weijiang
Nested guest doesn't support CET when KVM is running as an intermediate layer between two Hyper-Vs for now, so mask out related CET entry/exit load bits. Relevant enabling patches will be posted as a separate patch series. Suggested-by: Paolo Bonzini Suggested-by: Vitaly Kuznetsov Reviewed-by: V

Re: [next] drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared (first use in this function)

2021-04-08 Thread Chaitanya Kulkarni
On 4/8/21 23:24, Naresh Kamboju wrote: >> bio_offset(req->bio), >> GDROM_DMA_STARTADDR_REG); >> __raw_writel(block_cnt * GDROM_HARD_SECTOR, GDROM_DMA_LENGTH_REG); >> __raw_writel(1, GDROM_DMA_DIRECTION_REG); > Thanks for your patch. > After applying this typo

[PATCH v5 1/3] KVM: nVMX: Sync L2 guest CET states between L1/L2

2021-04-08 Thread Yang Weijiang
These fields are rarely updated by L1 QEMU/KVM, sync them when L1 is trying to read/write them and after they're changed. If CET guest entry-load bit is not set by L1 guest, migrate them to L2 manaully. Opportunistically remove one blank line in previous patch. Suggested-by: Sean Christopherson

[PATCH v5 2/3] KVM: nVMX: Set X86_CR4_CET in cr4_fixed1_bits if CET IBT is enabled

2021-04-08 Thread Yang Weijiang
CET SHSTK and IBT are independently controlled by kernel, set X86_CR4_CET bit in cr4_fixed1_bits if either of them is enabled so that nested guest can enjoy the feature. Reviewed-by: Sean Christopherson Signed-off-by: Yang Weijiang --- arch/x86/kvm/vmx/vmx.c | 1 + 1 file changed, 1 insertion(+

[PATCH v5 0/3] CET fix patches for nested guest

2021-04-08 Thread Yang Weijiang
This patch series is to fix a few issues found during patch review and testing on Linux, also including a patch to explictly disable CET support in nested guest over Hyper-V(s). change in v5: - Changed condition to snapshot CET state to vmcs01 per Sean's feedback. - Remove mixed fix code for MPX.

Re: [PATCH v2 10/21] ipmi: kcs_bmc: Turn the driver data-structures inside-out

2021-04-08 Thread Zev Weiss
On Fri, Apr 09, 2021 at 12:59:09AM CDT, Andrew Jeffery wrote: > > >On Fri, 9 Apr 2021, at 13:27, Zev Weiss wrote: >> On Fri, Mar 19, 2021 at 01:27:41AM CDT, Andrew Jeffery wrote: >> >Make the KCS device drivers responsible for allocating their own memory. >> > >> >Until now the private data for the

Re: [PATCH v4] binder: tell userspace to dump current backtrace when detected oneway spamming

2021-04-08 Thread Greg KH
On Fri, Apr 09, 2021 at 02:21:58PM +0800, Hang Lu wrote: > On 4/9/2021 2:08 PM, Greg KH wrote: > > On Fri, Apr 09, 2021 at 11:40:57AM +0800, Hang Lu wrote: > >> When async binder buffer got exhausted, some normal oneway transactions > >> will also be discarded and may cause system or application fa

Re: [PATCH v2 13/21] ipmi: kcs_bmc: Decouple the IPMI chardev from the core

2021-04-08 Thread Andrew Jeffery
On Fri, 9 Apr 2021, at 14:05, Zev Weiss wrote: > On Fri, Mar 19, 2021 at 01:27:44AM CDT, Andrew Jeffery wrote: > >Now that we have untangled the data-structures, split the userspace > >interface out into its own module. Userspace interfaces and drivers are > >registered to the KCS BMC core to su

[PATCH] staging: comedi: cb_pcidas64: remove useless function

2021-04-08 Thread Jiapeng Chong
Fix the following gcc warning: drivers/staging/comedi/drivers/cb_pcidas64.c:232:19: warning: unused function 'analog_trig_low_threshold_bits' [-Wunused-function]. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/staging/comedi/drivers/cb_pcidas64.c | 5 - 1 file changed, 5

Re: [next] drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared (first use in this function)

2021-04-08 Thread Naresh Kamboju
Hi Chaitanya, On Fri, 9 Apr 2021 at 11:01, Chaitanya Kulkarni wrote: > > On 4/8/21 22:21, Naresh Kamboju wrote: > > Linux next tag 20210408 architecture sh builds failed due to these errors. > > > > # to reproduce this build locally: > > > > make --sile

Re: [PATCH -next] clk: qcom: Add missing MODULE_DEVICE_TABLE

2021-04-08 Thread Manivannan Sadhasivam
On Thu, Apr 08, 2021 at 09:55:09PM +0800, Chen Hui wrote: > Add missing MODULE_DEVICE_TABLE entries to support module autoloading, > as these drivers can be compiled as external modules. > > Signed-off-by: Chen Hui Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/clk/qcom/a53-

Re: [PATCH v1 1/1] kernel.h: Split out panic and oops helpers

2021-04-08 Thread Andrew Morton
On Wed, 7 Apr 2021 11:46:37 +0300 Andy Shevchenko wrote: > On Wed, Apr 7, 2021 at 11:17 AM Kees Cook wrote: > > > > On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote: > > > kernel.h is being used as a dump for all kinds of stuff for a long time. > > > Here is the attempt to start

Re: [PATCH v4] binder: tell userspace to dump current backtrace when detected oneway spamming

2021-04-08 Thread Hang Lu
On 4/9/2021 2:08 PM, Greg KH wrote: > On Fri, Apr 09, 2021 at 11:40:57AM +0800, Hang Lu wrote: >> When async binder buffer got exhausted, some normal oneway transactions >> will also be discarded and may cause system or application failures. By >> that time, the binder debug information we dump may

Re: [PATCH 11/17] s390: Add airq_iv_lock

2021-04-08 Thread kernel test robot
Hi "Matthew, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20210408] [cannot apply to s390/features tip/x86/core dm/for-next gfs2/for-next block/for-next linus/master hnaz-linux-mm/master v5.12-rc6 v5.12-rc5 v5.12-rc4 v5.12-rc6] [If your patch is appli

[PATCH v4 3/3] riscv: Prepare ptdump for vm layout dynamic addresses

2021-04-08 Thread Alexandre Ghiti
This is a preparatory patch for sv48 support that will introduce dynamic PAGE_OFFSET. Dynamic PAGE_OFFSET implies that all zones (vmalloc, vmemmap, fixaddr...) whose addresses depend on PAGE_OFFSET become dynamic and can't be used to statically initialize the array used by ptdump to identify the d

[PATCH v4 2/3] Documentation: riscv: Add documentation that describes the VM layout

2021-04-08 Thread Alexandre Ghiti
This new document presents the RISC-V virtual memory layout and is based one the x86 one: it describes the different limits of the different regions of the virtual address space. Signed-off-by: Alexandre Ghiti --- Documentation/riscv/index.rst | 1 + Documentation/riscv/vm-layout.rst | 63 +

Re: [PATCH -next] hwrng: exynos - fix PM reference leak in exynos_trng_probe()

2021-04-08 Thread Krzysztof Kozlowski
On Fri, 9 Apr 2021 at 08:11, Ye Weihua wrote: > > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. > > Reported-by: Hul

[PATCH v4 1/3] riscv: Move kernel mapping outside of linear mapping

2021-04-08 Thread Alexandre Ghiti
This is a preparatory patch for relocatable kernel and sv48 support. The kernel used to be linked at PAGE_OFFSET address therefore we could use the linear mapping for the kernel mapping. But the relocated kernel base address will be different from PAGE_OFFSET and since in the linear mapping, two d

Re: [PATCH v2 12/21] ipmi: kcs_bmc: Strip private client data from struct kcs_bmc

2021-04-08 Thread Andrew Jeffery
On Fri, 9 Apr 2021, at 13:37, Zev Weiss wrote: > On Fri, Mar 19, 2021 at 01:27:43AM CDT, Andrew Jeffery wrote: > >Move all client-private data out of `struct kcs_bmc` into the KCS client > >implementation. > > > >With this change the KCS BMC core code now only concerns itself with > >abstract `s

[PATCH v4 0/3] Move kernel mapping outside the linear mapping

2021-04-08 Thread Alexandre Ghiti
I decided to split sv48 support in small series to ease the review. This patchset pushes the kernel mapping (modules and BPF too) to the last 4GB of the 64bit address space, this allows to: - implement relocatable kernel (that will come later in another patchset) that requires to move the kernel

Re: [v2] ceph: support getting ceph.dir.rsnaps vxattr

2021-04-08 Thread Yanhu Cao
ping @jeff @Ilya On Fri, Aug 28, 2020 at 9:29 AM Yanhu Cao wrote: > > It's easy to know how many snapshots have been created. > > Link: https://tracker.ceph.com/issues/47168 > Signed-off-by: Yanhu Cao > --- > fs/ceph/inode.c | 1 + > fs/ceph/mds_client.c | 9 - > fs/ceph/mds_client

[PATCH -next] hwrng: exynos - fix PM reference leak in exynos_trng_probe()

2021-04-08 Thread Ye Weihua
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Ye Weihua --- drivers/char/hw_rand

Re: [PATCH v4] binder: tell userspace to dump current backtrace when detected oneway spamming

2021-04-08 Thread Greg KH
On Fri, Apr 09, 2021 at 11:40:57AM +0800, Hang Lu wrote: > When async binder buffer got exhausted, some normal oneway transactions > will also be discarded and may cause system or application failures. By > that time, the binder debug information we dump may not be relevant to > the root cause. And

[PATCH] ASoC: Intel: bytcr_wm5102: remove useless variable

2021-04-08 Thread Jiapeng Chong
Fix the following gcc warning: sound/soc/intel/boards/bytcr_wm5102.c:216:40: warning: ‘byt_wm5102_dai_params’ defined but not used. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- sound/soc/intel/boards/bytcr_wm5102.c | 8 1 file changed, 8 deletions(-) diff --git a/sound/s

Re: [PATCH v3 2/2] scsi: pm8001: clean up for open brace

2021-04-08 Thread Jinpu Wang
On Thu, Apr 8, 2021 at 2:56 PM Luo Jiaxing wrote: > > There are few error about open brace is reported by checkpatch.pl: > > ERROR: that open brace { should be on the previous line > +static struct error_fw flash_error_table[] = > +{ > > So fix them all. > > Signed-off-by: Jianqin Xie > Signed-of

Re: [PATCH v3 1/2] scsi: pm8001: clean up for white space

2021-04-08 Thread Jinpu Wang
On Thu, Apr 8, 2021 at 2:56 PM Luo Jiaxing wrote: > > Some errors are found like below when run checkpatch.pl > > ERROR: space prohibited before that ',' (ctx:WxW) > +int pm8001_mpi_general_event(struct pm8001_hba_info *pm8001_ha , void > *piomb); > > It all about white space, so fix them. > > Si

Re: [PATCH v2 11/21] ipmi: kcs_bmc: Split headers into device and client

2021-04-08 Thread Andrew Jeffery
On Fri, 9 Apr 2021, at 13:31, Zev Weiss wrote: > On Fri, Mar 19, 2021 at 01:27:42AM CDT, Andrew Jeffery wrote: > >Strengthen the distinction between code that abstracts the > >implementation of the KCS behaviours (device drivers) and code that > >exploits KCS behaviours (clients). Neither needs

Re: [PATCH V11 3/5] kbuild: Allow .dtso format for overlay source files

2021-04-08 Thread Masahiro Yamada
On Tue, Mar 16, 2021 at 5:01 PM Geert Uytterhoeven wrote: > > Hi Frank, > > On Tue, Mar 16, 2021 at 6:39 AM Frank Rowand wrote: > > On 3/15/21 5:12 PM, Laurent Pinchart wrote: > > > On Tue, Mar 16, 2021 at 02:43:45AM +0900, Masahiro Yamada wrote: > > >> But how can we fix drivers/gpu/drm/rcar-du/

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-08 Thread Thomas Weißschuh
On Do, 2021-04-08T08:00-0700, Guenter Roeck wrote: > On 4/8/21 2:36 AM, Hans de Goede wrote: > > On 4/7/21 9:43 PM, Thomas Weißschuh wrote: > >> On Mi, 2021-04-07T17:54+0200, Hans de Goede wrote: > > Jean, Guenter, > > > > Thomas has been working on a WMI driver to expose various motherboard > > t

Re: [PATCH v2 10/21] ipmi: kcs_bmc: Turn the driver data-structures inside-out

2021-04-08 Thread Andrew Jeffery
On Fri, 9 Apr 2021, at 13:27, Zev Weiss wrote: > On Fri, Mar 19, 2021 at 01:27:41AM CDT, Andrew Jeffery wrote: > >Make the KCS device drivers responsible for allocating their own memory. > > > >Until now the private data for the device driver was allocated internal > >to the private data for the

[PATCH] mm/page_alloc: Ensure that HUGETLB_PAGE_ORDER is less than MAX_ORDER

2021-04-08 Thread Anshuman Khandual
pageblock_order must always be less than MAX_ORDER, otherwise it might lead to an warning during boot. A similar problem got fixed on arm64 platform with the commit 79cc2ed5a716 ("arm64/mm: Drop THP conditionality from FORCE_MAX_ZONEORDER"). Assert the above condition before HUGETLB_PAGE_ORDER gets

[PATCH v2 1/1] kernel/cpu: to track which CPUHP callback is failed

2021-04-08 Thread Dongli Zhang
During bootup or cpu hotplug, the cpuhp_up_callbacks() or cpuhp_down_callbacks() call many CPUHP callbacks (e.g., perf, mm, workqueue, RCU, kvmclock and more) for each cpu to online/offline. It may roll back to its previous state if any of callbacks is failed. As a result, the user will not be able

About add an A64FX cache control function into resctrl

2021-04-08 Thread tan.shaop...@fujitsu.com
Hello I'm Tan Shaopeng from Fujitsu Limited. I’m trying to implement Fujitsu A64FX’s cache related features. It is a cache partitioning function we called sector cache function that using the value of the tag that is upper 8 bits of the 64bit address and the value of the sector cache registe

linux-next: manual merge of the irqchip tree with the arm-soc tree

2021-04-08 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the irqchip tree got conflicts in: drivers/irqchip/Kconfig drivers/irqchip/Makefile between commit: 76cde2639411 ("irqchip/apple-aic: Add support for the Apple Interrupt Controller") from the arm-soc tree and commits: fead4dd49663 ("irqchip: Add dr

[PATCH 2/2] selinux:Delete selinux_xfrm_policy_lookup() useless argument

2021-04-08 Thread  Zhongjun Tan
From: Zhongjun Tan seliunx_xfrm_policy_lookup() is hooks of security_xfrm_policy_lookup(). The dir argument is uselss in security_xfrm_policy_lookup(). So remove the dir argument from selinux_xfrm_policy_lookup() and security_xfrm_policy_lookup(). Signed-off-by: Zhongjun Tan --- include/linux/

Re: [PATCH v2] char: tpm: fix error return code in tpm_cr50_i2c_tis_recv()

2021-04-08 Thread Jarkko Sakkinen
On Fri, Apr 09, 2021 at 09:12:01AM +0800, Zhihao Cheng wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 3a253caaad11 ("char: tpm: add i2c driver for cr50") > Reported-by: Hulk Robot > Signed-off-by: Zhihao Che

Re: [PATCH v2 09/21] ipmi: kcs_bmc: Split out kcs_bmc_cdev_ipmi

2021-04-08 Thread Andrew Jeffery
On Fri, 9 Apr 2021, at 13:26, Zev Weiss wrote: > On Fri, Mar 19, 2021 at 01:27:40AM CDT, Andrew Jeffery wrote: > >Take steps towards defining a coherent API to separate the KCS device > >drivers from the userspace interface. Decreasing the coupling will > >improve the separation of concerns and

Re: [PATCH] ext4: add a configurable parameter to prevent endless loop in ext4_mb_discard_group_p

2021-04-08 Thread riteshh
On 21/04/09 02:50AM, Wen Yang wrote: > > On Apr 7, 2021, at 5:16 AM, riteshh wrote: > >> > >> On 21/04/07 03:01PM, Wen Yang wrote: > >>> From: Wen Yang > >>> > >>> The kworker has occupied 100% of the CPU for several days: > >>> PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND > >>> 680

Re: [PATCH 4/6] usb: xhci-mtk: add support runtime PM

2021-04-08 Thread Ikjoon Jang
On Thu, Apr 8, 2021 at 5:35 PM Chunfeng Yun wrote: > > A dedicated wakeup irq will be used to handle runtime suspend/resume, > we use dev_pm_set_dedicated_wake_irq API to take care of requesting > and attaching wakeup irq, then the suspend/resume framework will help > to enable/disable wakeup irq.

Re: [PATCH 2/3] fpga: dfl: Add DFL bus driver for Altera SPI Master

2021-04-08 Thread Xu Yilun
On Fri, Apr 09, 2021 at 12:02:47PM +0800, Wu, Hao wrote: > > > > > > > > > + > > > > > > > > > +static void dfl_spi_altera_remove(struct dfl_device *dfl_dev) > > > > > > > > > +{ > > > > > > > > > +struct dfl_altera_spi *aspi = dev_get_drvdata(&dfl_dev->dev); > > > > > > > > > + > > > > > > > > > +

Re: [PATCH v2 17/21] dt-bindings: ipmi: Convert ASPEED KCS binding to schema

2021-04-08 Thread Zev Weiss
On Fri, Apr 09, 2021 at 12:33:10AM CDT, Andrew Jeffery wrote: > > >On Fri, 9 Apr 2021, at 14:45, Zev Weiss wrote: >> On Fri, Mar 19, 2021 at 01:27:48AM CDT, Andrew Jeffery wrote: >> >Given the deprecated binding, improve the ability to detect issues in >> >the platform devicetrees. Further, a subse

Re: [PATCH 04/10] mm/migrate: make migrate_pages() return nr_succeeded

2021-04-08 Thread Wei Xu
I agree that it is a good further improvement to make nr_succeeded an optional output argument of migrate_pages() given that most callers don't need it. IMHO, the most important thing in this matter is to ensure that nr_succeeded only returns (when its return value is needed) the successfully migr

Re: [syzbot] memory leak in ext4_multi_mount_protect

2021-04-08 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:4fa56ad0 Merge tag 'for-linus' of git://git.kernel.org/pub.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=12390a96d0 kernel config: https://syzkaller.appspot.com/x/.config?x=b8dbd3c

Re: [PATCH] iommu/vt-d: Force to flush iotlb before creating superpage

2021-04-08 Thread Lu Baolu
Hi Longpeng, On 4/8/21 3:37 PM, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: Hi Baolu, -Original Message- From: Lu Baolu [mailto:baolu...@linux.intel.com] Sent: Thursday, April 8, 2021 12:32 PM To: Longpeng (Mike, Cloud Infrastructure Service Product Dept.) ; io.

Re: [PATCH v2 20/21] ipmi: kcs_bmc_aspeed: Fix IBFIE typo from datasheet

2021-04-08 Thread Zev Weiss
On Fri, Mar 19, 2021 at 01:27:51AM CDT, Andrew Jeffery wrote: >Input Buffer Full Interrupt Enable (IBFIE) is typoed as IBFIF for some >registers in the datasheet. Fix the driver to use the sensible acronym. > >Signed-off-by: Andrew Jeffery Reviewed-by: Zev Weiss

Re: [PATCH 1/6] PM: runtime: enable wake irq after runtime_suspend hook called

2021-04-08 Thread Tony Lindgren
* Ikjoon Jang [210409 05:33]: > Hi Chunfeng, > > On Thu, Apr 8, 2021 at 5:35 PM Chunfeng Yun wrote: > > > > When the dedicated wake irq is level trigger, enable it before > > calling runtime_suspend, will trigger an interrupt. > > > > e.g. > > for a low level trigger type, it's low level at runn

Re: [PATCH v2 00/21] ipmi: Allow raw access to KCS devices

2021-04-08 Thread Andrew Jeffery
On Fri, 9 Apr 2021, at 13:37, Joel Stanley wrote: > On Thu, 8 Apr 2021 at 23:47, Andrew Jeffery wrote: > > On Thu, 8 Apr 2021, at 21:44, Corey Minyard wrote: > > > On Thu, Apr 08, 2021 at 10:27:46AM +0930, Andrew Jeffery wrote: > > > > > > 1. It begins with patches 1-5 put together by Chia-Wei, w

Re: [PATCH 1/6] PM: runtime: enable wake irq after runtime_suspend hook called

2021-04-08 Thread Tony Lindgren
* Chunfeng Yun [210409 01:54]: > On Thu, 2021-04-08 at 19:41 +0200, Rafael J. Wysocki wrote: > > On Thu, Apr 8, 2021 at 11:35 AM Chunfeng Yun > > wrote: > > > > > > When the dedicated wake irq is level trigger, enable it before > > > calling runtime_suspend, will trigger an interrupt. > > > > >

[PATCH] PCI: cadence: LTSSM Detect Quiet state minimum delay setting.

2021-04-08 Thread Nadeem Athani
Adding a quirk flag "quirk_detect_quiet_flag" to program the minimum time that LTSSM waits on entering Detect.Quiet state. Setting this to 2ms for TI j721e SOC as a workaround to resolve a bug in IP. In future revisions this setting will not be required. As per PCIe specification, all Receivers mu

[PATCH 1/1] drm/bridge: anx7625: send DPCD command to downstream

2021-04-08 Thread Xin Ji
Send DPCD command to downstream before anx7625 power down, tell downstream into standby mode. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 75 +++ 1 file changed, 75 insertions(+) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/

Re: [next] drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared (first use in this function)

2021-04-08 Thread Chaitanya Kulkarni
Naresh, On 4/8/21 22:31, Chaitanya Kulkarni wrote: > On 4/8/21 22:21, Naresh Kamboju wrote: >> Linux next tag 20210408 architecture sh builds failed due to these errors. >> >> # to reproduce this build locally: >> >> make --silent --keep-going --jobs=8 >> O

[PATCH 13/14] phy: cadence-torrent: Add debug information for PHY configuration

2021-04-08 Thread Swapnil Jakhade
Display information in probe regarding PHY configuration parameters like single link or multilink protocol information along with number of lanes used for each protocol link. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 32 +-- 1 file changed

[PATCH 11/14] phy: cadence-torrent: Add multilink DP support

2021-04-08 Thread Swapnil Jakhade
Add multilink support for DP. This needs changes in functions configuring default single link DP with master lane 0 to support non-zero master lane values and associated PLL configurations. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 498 +-

[PATCH 04/14] phy: cadence-torrent: Select register configuration based on PHY reference clock

2021-04-08 Thread Swapnil Jakhade
Add PHY input reference clock frequency as a new dimension to select proper register configuration. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 830 +++--- 1 file changed, 422 insertions(+), 408 deletions(-) diff --git a/drivers/phy/cadence/phy

[PATCH 05/14] phy: cadence-torrent: Add PHY registers for DP in array format

2021-04-08 Thread Swapnil Jakhade
Add PHY registers for single link DP in array format to simplify code and to improve readability. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 450 +- 1 file changed, 274 insertions(+), 176 deletions(-) diff --git a/drivers/phy/cadence/phy-c

[PATCH 14/14] phy: cadence-torrent: Check PIPE mode PHY status to be ready for operation

2021-04-08 Thread Swapnil Jakhade
PIPE PHY status is used to communicate the completion of several PHY functions. Check if PHY is ready for operation while configured for PIPE mode during startup. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 60 +++ 1 file changed, 60 inserti

[PATCH 03/14] phy: cadence-torrent: Add enum to support different input reference clocks

2021-04-08 Thread Swapnil Jakhade
Torrent PHY supports different input reference clock frequencies. Register configurations will be different based on reference clock value. Prepare driver to support register configs for multiple reference clocks. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 51

[PATCH 06/14] phy: cadence-torrent: Reorder functions to avoid function declarations

2021-04-08 Thread Swapnil Jakhade
Reorder some functions to avoid function declarations. Also, remove unnecessary line breaks while moving. No functional change. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 305 +- 1 file changed, 121 insertions(+), 184 deletions(-) diff --g

[PATCH 07/14] phy: cadence-torrent: Reorder functions to avoid function declarations

2021-04-08 Thread Swapnil Jakhade
Reorder some functions to avoid function declarations. No functional change. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 250 +++--- 1 file changed, 123 insertions(+), 127 deletions(-) diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/d

[PATCH 02/14] phy: cadence-torrent: Reorder few functions to remove function declarations

2021-04-08 Thread Swapnil Jakhade
Reorder some functions to avoid function declarations. No functional change. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 474 +++--- 1 file changed, 229 insertions(+), 245 deletions(-) diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/d

[PATCH 00/14] PHY: Add multilink DP support in Cadence Torrent PHY driver

2021-04-08 Thread Swapnil Jakhade
This patch series enables Torrent PHY driver to support different input reference clock frequencies. It also adds support for multilink multiprotocol DisplayPort configuration. Currently, PCIe + DP multilink register sequences are added. Swapnil Jakhade (14): phy: cadence-torrent: Remove use of

[PATCH 08/14] phy: cadence-torrent: Add PHY configuration for DP with 100MHz ref clock

2021-04-08 Thread Swapnil Jakhade
Add PHY configuration registers for DP with 100MHz ref clock and NO_SSC. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 162 ++ 1 file changed, 162 insertions(+) diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/drivers/phy/cadence/phy

[PATCH 09/14] phy: cadence-torrent: Add separate functions for reusable code

2021-04-08 Thread Swapnil Jakhade
Torrent PHY driver currently supports single link DP configuration. Prepare driver to support multilink DP configurations by adding separate functions for common initialization sequence. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 53 +++ 1

[PATCH 10/14] phy: cadence-torrent: Add function to get PLL to be configured for DP

2021-04-08 Thread Swapnil Jakhade
Torrent PHY PLL0 or PLL1 is used for DP depending on the single link or multilink protocol configuration for which PHY is configured. In multilink configurations with other protocols, either PLL0 or PLL1 will be used for DP. For single link DP, both PLLs need to be configured at POR. Signed-off-by

[PATCH 12/14] phy: cadence-torrent: Add PCIe + DP multilink configuration

2021-04-08 Thread Swapnil Jakhade
Add PCIe + DP no SSC multilink configuration sequences. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 131 ++ 1 file changed, 131 insertions(+) diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/drivers/phy/cadence/phy-cadence-torrent.

[PATCH 01/14] phy: cadence-torrent: Remove use of CamelCase to fix checkpatch CHECK message

2021-04-08 Thread Swapnil Jakhade
Script checkpatch with --strict option gives message: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Fix this by removing CamelCase usage. No functional change. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 24 +++ 1 file changed, 12 insert

Re: [PATCH v2 08/21] ipmi: kcs_bmc: Rename {read, write}_{status, data}() functions

2021-04-08 Thread Zev Weiss
On Fri, Mar 19, 2021 at 01:27:39AM CDT, Andrew Jeffery wrote: >Rename the functions in preparation for separating the IPMI chardev out >from the KCS BMC core. > >Signed-off-by: Andrew Jeffery Reviewed-by: Zev Weiss

Re: [PATCH v2 17/21] dt-bindings: ipmi: Convert ASPEED KCS binding to schema

2021-04-08 Thread Andrew Jeffery
On Fri, 9 Apr 2021, at 14:45, Zev Weiss wrote: > On Fri, Mar 19, 2021 at 01:27:48AM CDT, Andrew Jeffery wrote: > >Given the deprecated binding, improve the ability to detect issues in > >the platform devicetrees. Further, a subsequent patch will introduce a > >new interrupts property for specify

Re: [PATCH v2 07/21] ipmi: kcs_bmc: Make status update atomic

2021-04-08 Thread Zev Weiss
On Fri, Mar 19, 2021 at 01:27:38AM CDT, Andrew Jeffery wrote: >Enable more efficient implementation of read-modify-write sequences. >Both device drivers for the KCS BMC stack use regmaps. The new callback >allows us to exploit regmap_update_bits(). > >Signed-off-by: Andrew Jeffery Reviewed-by: Ze

Re: [PATCH 01/10] mm/numa: node demotion data structure and lookup

2021-04-08 Thread Wei Xu
It makes sense to start with a simple node tiering model like this change, which looks good to me. I do want to mention a likely usage scenario that motivates the need for a list of nodes as the demotion target of a source node. Access to a cross-socket DRAM node is still fast enough. So to mini

  1   2   3   4   5   6   7   8   9   10   >