Re: [PATCH v3 09/25] media: i2c: imx258: Add support for running on 2 CSI data lanes

2024-04-05 Thread Luis Garcia
On 4/3/24 12:45, Pavel Machek wrote: > Hi! > >> +/* >> + * 4208x3120 @ 30 fps needs 1267Mbps/lane, 4 lanes. >> + * To avoid further computation of clock settings, adopt the same per >> + * lane data rate when using 2 lanes, thus allowing a maximum of 15fps. >> + */ >> +static const struct

Re: [PATCH v3 21/25] drivers: media: i2c: imx258: Use macros

2024-04-05 Thread Luis Garcia
On 4/5/24 08:11, Tommaso Merciai wrote: > Hi Luis, > > On Fri, Apr 05, 2024 at 04:33:38AM -0600, Luis Garcia wrote: >> On 4/4/24 00:46, Sakari Ailus wrote: >>> On Wed, Apr 03, 2024 at 01:17:26PM -0600, Luigi311 wrote: On 4/3/24 10:23, Sakari Ailus wrote: > Hi Luis, > > On Wed,

Re: [PATCH v3 05/25] media: i2c: imx258: Add regulator control

2024-04-05 Thread Luis Garcia
On 4/3/24 12:44, Pavel Machek wrote: > Hi! > >> The device tree bindings define the relevant regulators for the >> sensor, so update the driver to request the regulators and control >> them at the appropriate times. > >> @@ -995,9 +1007,19 @@ static int imx258_power_on(struct device *dev) >>

Re: [PATCH] ftrace: make extra rcu_is_watching() validation check optional

2024-04-05 Thread Google
On Tue, 2 Apr 2024 22:21:00 -0700 Andrii Nakryiko wrote: > On Tue, Apr 2, 2024 at 9:00 PM Andrii Nakryiko > wrote: > > > > On Tue, Apr 2, 2024 at 5:52 PM Steven Rostedt wrote: > > > > > > On Wed, 3 Apr 2024 09:40:48 +0900 > > > Masami Hiramatsu (Google) wrote: > > > > > > > OK, for me, this

Re: [PATCHv2 1/3] uprobe: Add uretprobe syscall to speed up return probe

2024-04-05 Thread Google
On Fri, 5 Apr 2024 13:02:30 +0200 Oleg Nesterov wrote: > On 04/05, Jiri Olsa wrote: > > > > On Fri, Apr 05, 2024 at 10:22:03AM +0900, Masami Hiramatsu wrote: > > > > > > I think this expects setjmp/longjmp as below > > > > > > foo() { <- retprobe1 > > > setjmp() > > > bar() { <- retprobe2 >

Re: [PATCH fs/proc/bootconfig] remove redundant comments from /proc/bootconfig

2024-04-05 Thread Google
On Thu, 4 Apr 2024 21:25:41 -0700 "Paul E. McKenney" wrote: > On Fri, Apr 05, 2024 at 11:57:45AM +0900, Masami Hiramatsu wrote: > > On Fri, 5 Apr 2024 10:23:24 +0900 > > Masami Hiramatsu (Google) wrote: > > > > > On Thu, 4 Apr 2024 10:43:14 -0700 > > > "Paul E. McKenney" wrote: > > > > > > >

Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-05 Thread Ho-Ren (Jack) Chuang
On Fri, Apr 5, 2024 at 7:03 AM Jonathan Cameron wrote: > > On Fri, 5 Apr 2024 00:07:06 + > "Ho-Ren (Jack) Chuang" wrote: > > > The current implementation treats emulated memory devices, such as > > CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory > >

Re: [RFC PATCH v3 0/7] DAMON based tiered memory management for CXL memory

2024-04-05 Thread SeongJae Park
Hello Honggyu, On Fri, 5 Apr 2024 15:08:49 +0900 Honggyu Kim wrote: > There was an RFC IDEA "DAMOS-based Tiered-Memory Management" previously > posted at [1]. > > It says there is no implementation of the demote/promote DAMOS action > are made. This RFC is about its implementation for

Re: [RFC PATCH v3 7/7] mm/damon: Add "damon_migrate_{hot,cold}" vmstat

2024-04-05 Thread SeongJae Park
On Fri, 5 Apr 2024 15:08:56 +0900 Honggyu Kim wrote: > This patch adds "damon_migrate_{hot,cold}" under node specific vmstat > counters at the following location. > > /sys/devices/system/node/node*/vmstat > > The counted values are accumulcated to the global vmstat so it also > introduces

Re: [RFC PATCH v3 6/7] mm/damon/paddr: introduce DAMOS_MIGRATE_HOT action for promotion

2024-04-05 Thread SeongJae Park
On Fri, 5 Apr 2024 15:08:55 +0900 Honggyu Kim wrote: > From: Hyeongtak Ji > > This patch introduces DAMOS_MIGRATE_HOT action, which is similar to > DAMOS_MIGRATE_COLD, but it is targeted to migrate hot pages. My understanding of our last discussion was that 'HOT/COLD' here is only for

Re: [RFC PATCH v3 5/7] mm/damon/paddr: introduce DAMOS_MIGRATE_COLD action for demotion

2024-04-05 Thread SeongJae Park
On Fri, 5 Apr 2024 16:55:57 +0900 Hyeongtak Ji wrote: > On Fri, 5 Apr 2024 15:08:54 +0900 Honggyu Kim wrote: > > ...snip... > > > +static unsigned long damon_pa_migrate_pages(struct list_head *folio_list, > > + enum migration_mode mm, > > +

Re: [RFC PATCH v3 5/7] mm/damon/paddr: introduce DAMOS_MIGRATE_COLD action for demotion

2024-04-05 Thread SeongJae Park
On Fri, 5 Apr 2024 15:08:54 +0900 Honggyu Kim wrote: > This patch introduces DAMOS_MIGRATE_COLD action, which is similar to > DAMOS_PAGEOUT, but migrate folios to the given 'target_nid' in the sysfs > instead of swapping them out. > > The 'target_nid' sysfs knob is created by this patch to

Re: [RFC PATCH v3 4/7] mm/migrate: add MR_DAMON to migrate_reason

2024-04-05 Thread SeongJae Park
On Fri, 5 Apr 2024 15:08:53 +0900 Honggyu Kim wrote: > The current patch series introduces DAMON based migration across NUMA > nodes so it'd be better to have a new migrate_reason in trace events. > > Signed-off-by: Honggyu Kim Reviewed-by: SeongJae Park Thanks, SJ > --- >

Re: [RFC PATCH v3 2/7] mm: make alloc_demote_folio externally invokable for migration

2024-04-05 Thread SeongJae Park
On Fri, 5 Apr 2024 15:08:51 +0900 Honggyu Kim wrote: > The alloc_demote_folio can be used out of vmscan.c so it'd be better to > remove static keyword from it. > > This function can also be used for both demotion and promotion so it'd > be better to rename it from alloc_demote_folio to

Re: [RFC PATCH v3 1/7] mm/damon/paddr: refactor DAMOS_PAGEOUT with migration_mode

2024-04-05 Thread SeongJae Park
On Fri, 5 Apr 2024 15:08:50 +0900 Honggyu Kim wrote: > This is a preparation patch that introduces migration modes. > > The damon_pa_pageout is renamed to damon_pa_migrate and it receives an > extra argument for migration_mode. I personally think keeping damon_pa_pageout() as is and adding a

Re: [RFC PATCH v3 0/7] DAMON based tiered memory management for CXL memory

2024-04-05 Thread Gregory Price
On Fri, Apr 05, 2024 at 03:08:49PM +0900, Honggyu Kim wrote: > There was an RFC IDEA "DAMOS-based Tiered-Memory Management" previously > posted at [1]. > > 1. YCSB zipfian distribution read only workload > memory pressure with cold memory on node0 with 512GB of local DRAM. >

[PATCH] ftrace: riscv: move from REGS to ARGS

2024-04-05 Thread Puranjay Mohan
This commit replaces riscv's support for FTRACE_WITH_REGS with support for FTRACE_WITH_ARGS. This is required for the ongoing effort to stop relying on stop_machine() for RISCV's implementation of ftrace. The main relevant benefit that this change will bring for the above use-case is that now we

Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-05 Thread Jonathan Cameron
On Fri, 5 Apr 2024 00:07:06 + "Ho-Ren (Jack) Chuang" wrote: > The current implementation treats emulated memory devices, such as > CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory > (E820_TYPE_RAM). However, these emulated devices have different > characteristics

Re: [RFC PATCH] ftrace: riscv: move from REGS to ARGS

2024-04-05 Thread Puranjay Mohan
On Wed, Apr 3, 2024 at 6:02 AM Masami Hiramatsu wrote: > > On Tue, 02 Apr 2024 15:02:41 +0200 > Björn Töpel wrote: > > > Puranjay Mohan writes: > > > > > This commit replaces riscv's support for FTRACE_WITH_REGS with support > > > for FTRACE_WITH_ARGS. This is required for the ongoing effort to

Re: [PATCH v11 1/2] memory tier: dax/kmem: introduce an abstract layer for finding, allocating, and putting memory types

2024-04-05 Thread Jonathan Cameron
On Fri, 5 Apr 2024 00:07:05 + "Ho-Ren (Jack) Chuang" wrote: > Since different memory devices require finding, allocating, and putting > memory types, these common steps are abstracted in this patch, > enhancing the scalability and conciseness of the code. > > Signed-off-by: Ho-Ren (Jack)

[PATCH 4/4] mm: replace set_pte_at_notify() with just set_pte_at()

2024-04-05 Thread Paolo Bonzini
With the demise of the .change_pte() MMU notifier callback, there is no notification happening in set_pte_at_notify(). It is a synonym of set_pte_at() and can be replaced with it. Signed-off-by: Paolo Bonzini --- include/linux/mmu_notifier.h | 2 -- kernel/events/uprobes.c | 5 ++---

[PATCH 0/4] KVM, mm: remove the .change_pte() MMU notifier and set_pte_at_notify()

2024-04-05 Thread Paolo Bonzini
The .change_pte() MMU notifier callback was intended as an optimization and for this reason it was initially called without a surrounding mmu_notifier_invalidate_range_{start,end}() pair. It was only ever implemented by KVM (which was also the original user of MMU notifiers) and the rules on when

[PATCH 3/4] mmu_notifier: remove the .change_pte() callback

2024-04-05 Thread Paolo Bonzini
The scope of set_pte_at_notify() has reduced more and more through the years. Initially, it was meant for when the change to the PTE was not bracketed by mmu_notifier_invalidate_range_{start,end}(). However, that has not been so for over ten years. During all this period the only implementation

[PATCH 1/4] KVM: delete .change_pte MMU notifier callback

2024-04-05 Thread Paolo Bonzini
The .change_pte() MMU notifier callback was intended as an optimization. The original point of it was that KSM could tell KVM to flip its secondary PTE to a new location without having to first zap it. At the time there was also an .invalidate_page() callback; both of them were *not* bracketed by

[PATCH 2/4] KVM: remove unused argument of kvm_handle_hva_range()

2024-04-05 Thread Paolo Bonzini
The only user was kvm_mmu_notifier_change_pte(), which is now gone. Signed-off-by: Paolo Bonzini --- virt/kvm/kvm_main.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 2fcd9979752a..970111ad 100644 ---

Re: [PATCHv2 1/3] uprobe: Add uretprobe syscall to speed up return probe

2024-04-05 Thread Oleg Nesterov
On 04/05, Jiri Olsa wrote: > > On Fri, Apr 05, 2024 at 10:22:03AM +0900, Masami Hiramatsu wrote: > > > > I think this expects setjmp/longjmp as below > > > > foo() { <- retprobe1 > > setjmp() > > bar() { <- retprobe2 > > longjmp() > > } > > } <- return to trampoline > > > >

Re: [PATCH v3 21/25] drivers: media: i2c: imx258: Use macros

2024-04-05 Thread Luis Garcia
On 4/4/24 00:46, Sakari Ailus wrote: > On Wed, Apr 03, 2024 at 01:17:26PM -0600, Luigi311 wrote: >> On 4/3/24 10:23, Sakari Ailus wrote: >>> Hi Luis, >>> >>> On Wed, Apr 03, 2024 at 09:03:50AM -0600, g...@luigi311.com wrote: From: Luis Garcia Use understandable macros instead of

Re: [RFC PATCH v2 0/7] DAMON based 2-tier memory management for CXL memory

2024-04-05 Thread Honggyu Kim
Hi SeongJae, On Tue, 26 Mar 2024 16:03:09 -0700 SeongJae Park wrote: > On Mon, 25 Mar 2024 15:53:03 -0700 SeongJae Park wrote: > > > On Mon, 25 Mar 2024 21:01:04 +0900 Honggyu Kim wrote: > [...] > > > On Fri, 22 Mar 2024 09:32:23 -0700 SeongJae Park wrote: > > > > On Fri, 22 Mar 2024

Re: [PATCHv2 1/3] uprobe: Add uretprobe syscall to speed up return probe

2024-04-05 Thread Jiri Olsa
On Fri, Apr 05, 2024 at 10:22:03AM +0900, Masami Hiramatsu wrote: > On Thu, 4 Apr 2024 18:11:09 +0200 > Oleg Nesterov wrote: > > > On 04/05, Masami Hiramatsu wrote: > > > > > > Can we make this syscall and uprobe behavior clearer? As you said, if > > > the application use sigreturn or longjump,

Re: [PATCH 00/64] i2c: reword i2c_algorithm according to newest specification

2024-04-05 Thread Wolfram Sang
Hi Andi, hi everyone, thank you for reviewing and waiting. I had a small personal hiatus over Easter but now I am back. This series needs another cycle, so no need to hurry. I will address some of the review comments but not all. The conversion (and API improvements) are some bigger tasks, so

Re: [RFC PATCH v3 5/7] mm/damon/paddr: introduce DAMOS_MIGRATE_COLD action for demotion

2024-04-05 Thread Hyeongtak Ji
On Fri, 5 Apr 2024 15:08:54 +0900 Honggyu Kim wrote: ...snip... > +static unsigned long damon_pa_migrate_pages(struct list_head *folio_list, > + enum migration_mode mm, > + int target_nid) > +{ > + int nid; > +

[RFC PATCH v3 6/7] mm/damon/paddr: introduce DAMOS_MIGRATE_HOT action for promotion

2024-04-05 Thread Honggyu Kim
From: Hyeongtak Ji This patch introduces DAMOS_MIGRATE_HOT action, which is similar to DAMOS_MIGRATE_COLD, but it is targeted to migrate hot pages. It migrates pages inside the given region to the 'target_nid' NUMA node in the sysfs. Here is one of the example usage of this 'migrate_hot'

[RFC PATCH v3 7/7] mm/damon: Add "damon_migrate_{hot,cold}" vmstat

2024-04-05 Thread Honggyu Kim
This patch adds "damon_migrate_{hot,cold}" under node specific vmstat counters at the following location. /sys/devices/system/node/node*/vmstat The counted values are accumulcated to the global vmstat so it also introduces the same counter at /proc/vmstat as well. Signed-off-by: Honggyu Kim

[RFC PATCH v3 5/7] mm/damon/paddr: introduce DAMOS_MIGRATE_COLD action for demotion

2024-04-05 Thread Honggyu Kim
This patch introduces DAMOS_MIGRATE_COLD action, which is similar to DAMOS_PAGEOUT, but migrate folios to the given 'target_nid' in the sysfs instead of swapping them out. The 'target_nid' sysfs knob is created by this patch to inform the migration target node ID. Here is one of the example

[RFC PATCH v3 3/7] mm/damon/sysfs-schemes: add target_nid on sysfs-schemes

2024-04-05 Thread Honggyu Kim
From: Hyeongtak Ji This patch adds target_nid under /sys/kernel/mm/damon/admin/kdamonds//contexts//schemes// The 'target_nid' can be used as the destination node for DAMOS actions such as DAMOS_MIGRATE_{HOT,COLD} in the follow up patches. Signed-off-by: Hyeongtak Ji Signed-off-by: Honggyu

[RFC PATCH v3 4/7] mm/migrate: add MR_DAMON to migrate_reason

2024-04-05 Thread Honggyu Kim
The current patch series introduces DAMON based migration across NUMA nodes so it'd be better to have a new migrate_reason in trace events. Signed-off-by: Honggyu Kim --- include/linux/migrate_mode.h | 1 + include/trace/events/migrate.h | 3 ++- 2 files changed, 3 insertions(+), 1

Re: [PATCH] [v3] module: don't ignore sysfs_create_link() failures

2024-04-05 Thread Greg Kroah-Hartman
On Tue, Mar 26, 2024 at 03:57:18PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The sysfs_create_link() return code is marked as __must_check, but the > module_add_driver() function tries hard to not care, by assigning the > return code to a variable. When building with 'make W=1', gcc

[RFC PATCH v3 1/7] mm/damon/paddr: refactor DAMOS_PAGEOUT with migration_mode

2024-04-05 Thread Honggyu Kim
This is a preparation patch that introduces migration modes. The damon_pa_pageout is renamed to damon_pa_migrate and it receives an extra argument for migration_mode. No functional changes applied. Signed-off-by: Honggyu Kim --- mm/damon/paddr.c | 18 +++--- 1 file changed, 15

[RFC PATCH v3 2/7] mm: make alloc_demote_folio externally invokable for migration

2024-04-05 Thread Honggyu Kim
The alloc_demote_folio can be used out of vmscan.c so it'd be better to remove static keyword from it. This function can also be used for both demotion and promotion so it'd be better to rename it from alloc_demote_folio to alloc_migrate_folio. Signed-off-by: Honggyu Kim --- mm/internal.h | 1

[RFC PATCH v3 0/7] DAMON based tiered memory management for CXL memory

2024-04-05 Thread Honggyu Kim
There was an RFC IDEA "DAMOS-based Tiered-Memory Management" previously posted at [1]. It says there is no implementation of the demote/promote DAMOS action are made. This RFC is about its implementation for physical address space. Changes from RFC v2: 1. Rename DAMOS_{PROMOTE,DEMOTE}