Re: [RFC] security: smack: add hash table for smack for quick label searching

2013-04-12 Thread Łukasz Stelmach
ret_fast_syscall [ less than 2.5% per entry ] --8---cut here---end---8--- -- Łukasz Stelmach Software wizzard Samsung Poland RD Center Al. Armii Ludowej 26, 00-609 Warszawa http://www.rd.samsung.pl -- To unsubscribe from this list: send the line

[PATCH v2] smack: introduce a special case for tmpfs in smack_d_instantiate()

2014-12-16 Thread Łukasz Stelmach
Files created with __shmem_file_stup() appear to have somewhat fake dentries which make them look like root directories and not get the label the current process or (*) star meant for tmpfs files. Signed-off-by: Łukasz Stelmach l.stelm...@samsung.com --- security/smack/smack_lsm.c | 16

[PATCH] mfd: Fix a typo in Kconfig

2015-03-27 Thread Łukasz Stelmach
--- drivers/mfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 38356e3..4890e27 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -1362,7 +1362,7 @@ config MFD_WM8994 depends on I2C help

[PATCH v2] mfd: Fix a typo in Kconfig

2015-03-27 Thread Łukasz Stelmach
Signed-off-by: Łukasz Stelmach stl...@poczta.fm --- drivers/mfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 38356e3..4890e27 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -1362,7 +1362,7 @@ config

Re: [GIT PULL] kdbus for 4.1-rc1

2015-04-30 Thread Łukasz Stelmach
-free. Kind regards, -- Łukasz Stelmach Samsung RD Institute Poland Samsung Electronics signature.asc Description: PGP signature

Re: [GIT PULL] kdbus for 4.1-rc1

2015-04-30 Thread Łukasz Stelmach
It was 2015-04-30 czw 11:12, when Richard Weinberger wrote: Am 30.04.2015 um 11:05 schrieb Łukasz Stelmach: Regardless, of initrd issues I feel there is a need of a local IPC that is more capable than UDS. Linus Torvalds is probably right that dbus-daemon is everything but effictient. I

Re: [GIT PULL] kdbus for 4.1-rc1

2015-04-30 Thread Łukasz Stelmach
It was 2015-04-30 czw 12:40, when Richard Weinberger wrote: Am 30.04.2015 um 12:19 schrieb Łukasz Stelmach: It was 2015-04-30 czw 11:12, when Richard Weinberger wrote: Am 30.04.2015 um 11:05 schrieb Łukasz Stelmach: Regardless, of initrd issues I feel there is a need of a local IPC

Re: [GIT PULL] kdbus for 4.1-rc1

2015-04-30 Thread Łukasz Stelmach
It was 2015-04-30 czw 14:23, when Richard Weinberger wrote: Am 30.04.2015 um 14:16 schrieb Łukasz Stelmach: It was 2015-04-30 czw 12:40, when Richard Weinberger wrote: Am 30.04.2015 um 12:19 schrieb Łukasz Stelmach: It was 2015-04-30 czw 11:12, when Richard Weinberger wrote: Am 30.04.2015 um

Re: [GIT PULL] kdbus for 4.1-rc1

2015-04-30 Thread Łukasz Stelmach
It was 2015-04-30 czw 14:45, when Richard Weinberger wrote: Am 30.04.2015 um 14:40 schrieb Łukasz Stelmach: It was 2015-04-30 czw 14:23, when Richard Weinberger wrote: Am 30.04.2015 um 14:16 schrieb Łukasz Stelmach: It was 2015-04-30 czw 12:40, when Richard Weinberger wrote: Am 30.04.2015 um

[PATCH v2] asus-laptop: Add key found on Asus F3M

2015-07-29 Thread Łukasz Stelmach
not support WMI so the commit does not update key mappings in the asus-nb-wmi.c file. I have not tested this mapping on any other Asus laptop. Signed-off-by: Łukasz Stelmach stl...@poczta.fm --- drivers/platform/x86/asus-laptop.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform

[PATCH] asus-laptop: Add key found on Asus F3M

2015-07-24 Thread Łukasz Stelmach
Signed-off-by: Łukasz Stelmach stl...@poczta.fm --- drivers/platform/x86/asus-laptop.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index 58d29c4..f2b5d0a 100644 --- a/drivers/platform/x86/asus-laptop.c +++ b/drivers

Re: A new, fast and "unbreakable" encryption algorithm

2015-11-19 Thread Łukasz Stelmach
it correctly makes a memory access depending on secret data. Because memory accesses are note constant time operations due to cache one might try (and succeed?) learning about secrets by measuring time required to encrypt or decrypt data. -- Łukasz Stelmach Samsung R Institute Poland Samsung

Re: A new, fast and "unbreakable" encryption algorithm

2015-11-19 Thread Łukasz Stelmach
It was <2015-11-19 czw 13:31>, when Ismail Kizir wrote: > On Thu, Nov 19, 2015 at 2:12 PM, Łukasz Stelmach <l.stelm...@samsung.com> > wrote: >> It was <2015-11-18 śro 06:25>, when Ismail Kizir wrote: >>> Hello, >>> >>> I've develo

counting file descriptors with a cgroup controller

2017-02-17 Thread Łukasz Stelmach
of user-land code, + enables other process (e.g. init) to be notified and apply policy. Kind regards, -- Łukasz Stelmach Samsung R Institute Poland Samsung Electronics signature.asc Description: PGP signature

[PATCH 1/3] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings

2017-11-23 Thread Łukasz Stelmach
Add binding documentation for the True Random Number Generator found on Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- .../devicetree/bindings/rng/samsung,exynos5250-trng.txt | 17 + 1 file changed, 17 insertions(+) create mode

[PATCH 0/3] True RNG driver for Samsung Exynos 5250+ SoCs

2017-11-23 Thread Łukasz Stelmach
for Exynos SoCs. Łukasz Stelmach (3): dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings hwrng: exynos - add Samsung Exynos True RNG driver ARM: dts: exynos: Add nodes for True Random Number Generator .../bindings/rng/samsung,exynos5250-trng.txt | 17 ++ MAINTAINERS

[PATCH 3/3] ARM: dts: exynos: Add nodes for True Random Number Generator

2017-11-23 Thread Łukasz Stelmach
Add nodes for the True Random Number Generator found in Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- arch/arm/boot/dts/exynos5.dtsi| 5 + arch/arm/boot/dts/exynos5250.dtsi | 5 + arch/arm/boot/dts/exynos5410.dtsi | 5 + arch/arm/bo

[PATCH 2/3] hwrng: exynos - add Samsung Exynos True RNG driver

2017-11-23 Thread Łukasz Stelmach
Add support for True Random Number Generator found in Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- MAINTAINERS | 7 + drivers/char/hw_random/Kconfig | 12 ++ drivers/char/hw_random/Makefile | 1 + driver

Re: [PATCH 2/3] hwrng: exynos - add Samsung Exynos True RNG driver

2017-11-26 Thread Łukasz Stelmach
;> + u32 val; >> + >> + max = max > (EXYNOS_TRNG_FIFO_LEN * 4) ? >> + (EXYNOS_TRNG_FIFO_LEN * 4) : max; > > max is always > 32. This condition is not required. No, it is not. http://elixir.free-electrons.com/linux/latest/source/drivers/ch

[PATCH v2 3/3] ARM: dts: exynos: Add nodes for True Random Number Generator

2017-11-27 Thread Łukasz Stelmach
Add nodes for the True Random Number Generator found in Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- arch/arm/boot/dts/exynos5.dtsi| 5 + arch/arm/boot/dts/exynos5250.dtsi | 5 + arch/arm/boot/dts/exynos5410.dtsi | 5 + arch/arm/bo

[PATCH v2 0/3] True RNG driver for Samsung Exynos 5250+ SoCs

2017-11-27 Thread Łukasz Stelmach
t/lists/linux-samsung-soc/msg61253.html https://patchwork.kernel.org/patch/10072967/ https://patchwork.kernel.org/patch/10072971/ https://patchwork.kernel.org/patch/10072963/ Łukasz Stelmach (3): dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings hwrng: exynos - add Samsung Exynos Tr

[PATCH v2 2/3] hwrng: exynos - add Samsung Exynos True RNG driver

2017-11-27 Thread Łukasz Stelmach
Add support for True Random Number Generator found in Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- MAINTAINERS | 7 + drivers/char/hw_random/Kconfig | 12 ++ drivers/char/hw_random/Makefile | 1 + driver

[PATCH v2 1/3] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings

2017-11-27 Thread Łukasz Stelmach
Add binding documentation for the True Random Number Generator found on Samsung Exynos 5250+ SoCs. Acked-by: Rob Herring <r...@kernel.org> Reviewed-by: Krzysztof Kozlowski <k...@kernel.org> Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- .../devicetree/bindings/rng/

Re: [PATCH 2/3] hwrng: exynos - add Samsung Exynos True RNG driver

2017-11-23 Thread Łukasz Stelmach
It was <2017-11-23 czw 17:31>, when Krzysztof Kozlowski wrote: > On Thu, Nov 23, 2017 at 4:09 PM, Łukasz Stelmach <l.stelm...@samsung.com> > wrote: >> Add support for True Random Number Generator found in Samsung Exynos >> 5250+ SoCs. >> >> Signed-off-b

Re: [PATCH v3 1/3] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings

2017-12-05 Thread Łukasz Stelmach
It was <2017-12-04 pon 14:13>, when Krzysztof Kozlowski wrote: > On Mon, Dec 4, 2017 at 1:53 PM, Łukasz Stelmach <l.stelm...@samsung.com> > wrote: >> Add binding documentation for the True Random Number Generator >> found on Samsung Exynos 5250+ SoCs. >> >&g

[PATCH v3 0/4] Assorted changes for Exynos PRNG driver

2017-12-12 Thread Łukasz Stelmach
rom an error path. - Removed dev_info() reporting hardware presence from exynos_rng_probe(). Łukasz Stelmach (4): crypto: exynos - Support Exynos5250+ SoCs crypto: exynos - Improve performance of PRNG crypto: exynos - Reseed PRNG after generating 2^16 random bytes crypto: exynos - Introduce mu

[PATCH v3 3/4] crypto: exynos - Reseed PRNG after generating 2^16 random bytes

2017-12-12 Thread Łukasz Stelmach
entropy, but it helps preventing backtracking the internal state of the device from its output sequence, and hence, prevents potential attacker from predicting numbers to be generated. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> Reviewed-by: Stephan Mueller <smuel...@c

[PATCH v3 4/4] crypto: exynos - Introduce mutex to prevent concurrent access to hardware

2017-12-12 Thread Łukasz Stelmach
() function enables switching between different threads waiting for the driver to generate random numbers for them. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> Reviewed-by: Krzysztof Kozlowski <k...@kernel.org> --- drivers/crypto/exynos-rng.c | 21 + 1

[PATCH v3 1/4] crypto: exynos - Support Exynos5250+ SoCs

2017-12-12 Thread Łukasz Stelmach
Add support for PRNG in Exynos5250+ SoCs. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- .../bindings/crypto/samsung,exynos-rng4.txt| 4 +++- drivers/crypto/exynos-rng.c| 27 -- 2 files changed, 28 insertions(+), 3 del

[PATCH v3 2/4] crypto: exynos - Improve performance of PRNG

2017-12-12 Thread Łukasz Stelmach
Use memcpy_fromio() instead of custom exynos_rng_copy_random() function to retrieve generated numbers from the registers of PRNG. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- drivers/crypto/exynos-rng.c | 31 ++- 1 file changed, 2 insertions(

[PATCH] crypto: exynos - Icrease the priority of the driver

2017-12-05 Thread Łukasz Stelmach
in the kernel command line). Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- Thank you Stephan Mueller for explanations. drivers/crypto/exynos-rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/exynos-rng.c b/drivers/crypto/exynos-rng.c index 4b2ed1

Re: [PATCH 2/3] crypto: exynos - Improve performance of PRNG

2017-12-05 Thread Łukasz Stelmach
It was <2017-12-05 wto 14:54>, when Stephan Mueller wrote: > Am Dienstag, 5. Dezember 2017, 13:35:57 CET schrieb Łukasz Stelmach: > > Hi Łukasz, > >> Use memcpy_fromio() instead of custom exynos_rng_copy_random() function >> to retrieve generated numbers from the re

[PATCH v3 1/3] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings

2017-12-04 Thread Łukasz Stelmach
Add binding documentation for the True Random Number Generator found on Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- .../devicetree/bindings/rng/samsung,exynos5250-trng.txt | 17 + 1 file changed, 17 insertions(+) create mode

[PATCH v3 2/3] hwrng: exynos - add Samsung Exynos True RNG driver

2017-12-04 Thread Łukasz Stelmach
Add support for True Random Number Generator found in Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- MAINTAINERS | 7 + drivers/char/hw_random/Kconfig | 12 ++ drivers/char/hw_random/Makefile | 1 + driver

[PATCH v3 0/3] True RNG driver for Samsung Exynos 5250+ SoCs

2017-12-04 Thread Łukasz Stelmach
Hello. The following patches add support for the true random number generator found in Samsung Exynos 5250+ SoCs. Patch #1 adds documentation for devicetree bindings. Patch #2 introduces the driver and appropriate changes in Makefile and Kconfig. Patch #3 adds nodes in devicetree files for

[PATCH v3 3/3] ARM: dts: exynos: Add nodes for True Random Number Generator

2017-12-04 Thread Łukasz Stelmach
Add nodes for the True Random Number Generator found in Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- arch/arm/boot/dts/exynos5.dtsi| 5 + arch/arm/boot/dts/exynos5250.dtsi | 5 + arch/arm/boot/dts/exynos5410.dtsi | 5 + arch/arm/bo

Re: [PATCH 1/3] crypto: exynos - Support Exynos5250+ SoCs

2017-12-07 Thread Łukasz Stelmach
It was <2017-12-06 śro 16:28>, when Krzysztof Kozlowski wrote: > On Wed, Dec 6, 2017 at 3:53 PM, Łukasz Stelmach <l.stelm...@samsung.com> > wrote: >> It was <2017-12-06 śro 15:05>, when Krzysztof Kozlowski wrote: >>> On Wed, Dec 6, 2017 at 2:42 PM,

[PATCH v2 4/4] crypto: exynos - Introduce mutex to prevent concurrent access to hardware

2017-12-11 Thread Łukasz Stelmach
om accessing the hardware at the same time. The sequence of mutex_lock() and mutex_unlock() in the exynos_rng_reseed() function enables switching between different threads waiting for the driver to generate random numbers for them. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> -

[PATCH v2 2/4] crypto: exynos - Improve performance of PRNG

2017-12-11 Thread Łukasz Stelmach
h worse than in a loop without cpu_relax(). Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- drivers/crypto/exynos-rng.c | 36 +--- 1 file changed, 5 insertions(+), 31 deletions(-) diff --git a/drivers/crypto/exynos-rng.c b/drivers/crypto/exynos-rng.c

[PATCH v2 1/4] crypto: exynos - Support Exynos5250+ SoCs

2017-12-11 Thread Łukasz Stelmach
Cc: Marek Szyprowski <m.szyprow...@samsung.com>, Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> Add support for PRNG in Exynos5250+ SoCs. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- .../bindings/crypto/samsung,exynos-rng4.txt| 4 ++- drivers/c

[PATCH v2 0/4] Assorted changes for Exynos PRNG driver

2017-12-11 Thread Łukasz Stelmach
enum and a define according to Krzysztof Kozłowski's recommendations. - Brought back cpu_relax() in a rearranged loop in exynos_rng_get_random(). - Moved an assignment of the read valuea away from an error path. - Removed dev_info() reporting hardware presence from exynos_rng_probe(). Łukasz

[PATCH v2 3/4] crypto: exynos - Reseed PRNG after generating 2^16 random bytes

2017-12-11 Thread Łukasz Stelmach
but it helps preventing backtracking the internal state of the device from its output sequence, and hence, prevents potential attacker from predicting numbers to be generated. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> Reviewed-by: Stephan Mueller <smuel...@chronox.de> --- dri

Re: [PATCH 2/3] crypto: exynos - Improve performance of PRNG

2017-12-06 Thread Łukasz Stelmach
It was <2017-12-05 wto 19:06>, when Krzysztof Kozlowski wrote: > On Tue, Dec 5, 2017 at 6:53 PM, Krzysztof Kozlowski <k...@kernel.org> wrote: >> On Tue, Dec 05, 2017 at 05:43:10PM +0100, Łukasz Stelmach wrote: >>> It was <2017-12-05 wto 14:54>, when Stepha

[PATCH 2/3] crypto: exynos - Improve performance of PRNG

2017-12-05 Thread Łukasz Stelmach
Use memcpy_fromio() instead of custom exynos_rng_copy_random() function to retrieve generated numbers from the registers of PRNG. Remove unnecessary invocation of cpu_relax(). Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- drivers/crypto/exynos-rng.

[PATCH 1/3] crypto: exynos - Support Exynos5250+ SoCs

2017-12-05 Thread Łukasz Stelmach
Add support for PRNG in Exynos5250+ SoCs. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- .../bindings/crypto/samsung,exynos-rng4.txt| 4 ++- drivers/crypto/exynos-rng.c| 36 -- 2 files changed, 36 insertions(+), 4 del

[PATCH 3/3] crypto: exynos - Reseed PRNG after generating 2^16 random bytes

2017-12-05 Thread Łukasz Stelmach
Reseed PRNG after reading 65 kB of randomness. Although this may reduce performance, in most casese the loss is not noticable. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- drivers/crypto/exynos-rng.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-)

[PATCH 0/3] Assorted changes for Exynos PRNG driver

2017-12-05 Thread Łukasz Stelmach
output performance by using memcpy() rather than a custom function to retriev random bytes from registers. Patch #3 Reseed the PRNG after reading 2^16 bytes. Simmilar approach is implemented in DRBG. (Thanks Stephan Mueller) Łukasz Stelmach (3): crypto: exynos - Support Exynos5250+ SoCs crypto

[RFC] crypto: exynos - Icrease the priority of the driver

2017-12-05 Thread Łukasz Stelmach
exynos-rng is one of many implementations of stdrng. With priority as low as 100 it isn't selected, if software implementations (DRBG) are available. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- If not 1000, what is the best value, what is the policy? drivers/crypto/

Re: [PATCH 2/3] crypto: exynos - Improve performance of PRNG

2017-12-06 Thread Łukasz Stelmach
It was <2017-12-06 śro 12:37>, when Krzysztof Kozlowski wrote: > On Wed, Dec 6, 2017 at 12:32 PM, Łukasz Stelmach <l.stelm...@samsung.com> > wrote: >> It was <2017-12-05 wto 19:06>, when Krzysztof Kozlowski wrote: >>> On Tue, Dec 5, 2017 at 6:53 PM, Krzy

Re: [PATCH 1/3] crypto: exynos - Support Exynos5250+ SoCs

2017-12-06 Thread Łukasz Stelmach
It was <2017-12-05 wto 14:34>, when Krzysztof Kozlowski wrote: > On Tue, Dec 5, 2017 at 1:35 PM, Łukasz Stelmach <l.stelm...@samsung.com> > wrote: >> Add support for PRNG in Exynos5250+ SoCs. >> >> Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com&

[PATCH v4] ARM: dts: exynos: Add nodes for True Random Number Generator

2017-12-12 Thread Łukasz Stelmach
Add nodes for the True Random Number Generator found in Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- Changes since v3: - Rebased accroding to Krzysztof Kozłowski's request arch/arm/boot/dts/exynos5.dtsi| 5 + arch/arm/boot/dts/exynos525

Re: [PATCH v2 2/4] crypto: exynos - Improve performance of PRNG

2017-12-12 Thread Łukasz Stelmach
It was <2017-12-11 pon 15:54>, when Krzysztof Kozlowski wrote: > On Mon, Dec 11, 2017 at 3:06 PM, Łukasz Stelmach <l.stelm...@samsung.com> > wrote: >> Cc: Marek Szyprowski <m.szyprow...@samsung.com>, Bartlomiej >> Zolnierkiewicz <b.zolnier...@samsu

Re: [PATCH v2 4/4] crypto: exynos - Introduce mutex to prevent concurrent access to hardware

2017-12-12 Thread Łukasz Stelmach
It was <2017-12-11 pon 16:03>, when Krzysztof Kozlowski wrote: > On Mon, Dec 11, 2017 at 3:06 PM, Łukasz Stelmach <l.stelm...@samsung.com> > wrote: >> Cc: Marek Szyprowski <m.szyprow...@samsung.com>, Bartlomiej Zolnierkiewicz >> <b.zolnier...@samsung.com&

Re: [PATCH v3 3/3] ARM: dts: exynos: Add nodes for True Random Number Generator

2017-12-12 Thread Łukasz Stelmach
It was <2017-12-11 pon 19:49>, when Krzysztof Kozlowski wrote: > On Mon, Dec 04, 2017 at 01:53:51PM +0100, Łukasz Stelmach wrote: >> Add nodes for the True Random Number Generator found in Samsung Exynos >> 5250+ SoCs. >> >> Signed-off-by: Łukasz Stelmach <l.s

Re: [PATCH 1/3] crypto: exynos - Support Exynos5250+ SoCs

2017-12-06 Thread Łukasz Stelmach
It was <2017-12-06 śro 15:05>, when Krzysztof Kozlowski wrote: > On Wed, Dec 6, 2017 at 2:42 PM, Łukasz Stelmach <l.stelm...@samsung.com> > wrote: >> It was <2017-12-05 wto 14:34>, when Krzysztof Kozlowski wrote: >>> On Tue, Dec 5, 2017 at 1:35 PM,

Re: [PATCH][next] hwrng: exynos: check for -ve error return from readl_poll_timeout

2018-01-29 Thread Łukasz Stelmach
*trng; > - u32 val; > + int val; > > max = min_t(size_t, max, (EXYNOS_TRNG_FIFO_LEN * 4)); Fixed. https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=a8bc71d4960391f732ec0307ebd69e4a25aaf4d3 -- Łukasz Stelmach Samsung R Institute Poland Samsung Electronics signature.asc Description: PGP signature

Re: [PATCH v3 2/3] hwrng: exynos - add Samsung Exynos True RNG driver

2017-12-22 Thread Łukasz Stelmach
It was <2017-12-22 pią 09:35>, when Herbert Xu wrote: > On Fri, Dec 22, 2017 at 09:29:38AM +0100, Marek Szyprowski wrote: >> Hi, >> >> On 2017-12-22 09:24, Herbert Xu wrote: >> >On Mon, Dec 04, 2017 at 01:53:50PM +0100, Łukasz Stelmach wrote: >> >

[PATCH v4] hwrng: exynos - add Samsung Exynos True RNG driver

2017-12-22 Thread Łukasz Stelmach
Add support for True Random Number Generator found in Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> Reviewed-by: Krzysztof Kozlowski <k...@kernel.org> --- Changes since v3: - Fixed typo in the secongd argument of MODULE_DEVICE_TABLE (Thanks

Re: [PATCH v4] hwrng: exynos - add Samsung Exynos True RNG driver

2017-12-22 Thread Łukasz Stelmach
It was <2017-12-22 pią 14:34>, when Philippe Ombredanne wrote: > Łukasz, > > On Fri, Dec 22, 2017 at 2:23 PM, Łukasz Stelmach <l.stelm...@samsung.com> > wrote: >> Add support for True Random Number Generator found in Samsung Exynos >> 5250+ SoCs. >>

[PATCH v5] hwrng: exynos - add Samsung Exynos True RNG driver

2017-12-22 Thread Łukasz Stelmach
Add support for True Random Number Generator found in Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> Reviewed-by: Krzysztof Kozlowski <k...@kernel.org> --- Changes since v4: - SPDX license header instead of the traditional blurb. - MODULE_LIC

Re: [PATCH v4] hwrng: exynos - add Samsung Exynos True RNG driver

2017-12-27 Thread Łukasz Stelmach
It was <2017-12-22 pią 19:30>, when Philippe Ombredanne wrote: > On Fri, Dec 22, 2017 at 5:38 PM, Łukasz Stelmach <l.stelm...@samsung.com> > wrote: >> It was <2017-12-22 pią 14:34>, when Philippe Ombredanne wrote: >>> Łukasz, >>> >>>

[PATCH] ARM: decompressor: restore r1 and r2 just before jumping to the kernel

2018-04-04 Thread Łukasz Stelmach
Hypervisor setup before __enter_kernel destroys the value sotred in r1. The value needs to be restored just before the jump. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- arch/arm/boot/compressed/head.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] ARM: decompressor: add a missing parameter to the addruart macro

2018-03-23 Thread Łukasz Stelmach
In commit 639da5ee374b an additional temporary register was added to the addruart macro, but the decompressor code wasn't updated. Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> --- arch/arm/boot/compressed/head.S | 16 1 file changed, 8 insertions(+), 8 del

Re: Bad MAINTAINERS pattern in section 'SAMSUNG EXYNOS TRUE RANDOM NUMBER GENERATOR (TRNG) DRIVER'

2018-10-01 Thread Łukasz Stelmach
It was <2018-09-29 sob 00:03>, when Joe Perches wrote: > Please fix this defect appropriately. > > linux-next MAINTAINERS section: > > 12851 SAMSUNG EXYNOS TRUE RANDOM NUMBER GENERATOR (TRNG) DRIVER > 12852 M: Łukasz Stelmach > 12

[PATCH] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings

2018-10-02 Thread Łukasz Stelmach
Add binding documentation for the True Random Number Generator found on Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach --- .../bindings/rng/samsung,exynos5250-trng.txt| 17 + 1 file changed, 17 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v5.1] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings

2018-10-04 Thread Łukasz Stelmach
Add binding documentation for the True Random Number Generator found on Samsung Exynos 5250+ SoCs. Acked-by: Rob Herring Reviewed-by: Krzysztof Kozlowski Signed-off-by: Łukasz Stelmach --- This time with proper tags, as requested. Kind regards, ŁS .../bindings/rng/samsung,exynos5250

Re: [RFC] security: smack: add hash table for smack for quick label searching

2013-04-12 Thread Łukasz Stelmach
3.45% [.] 0x118c 2.94% [.] strncpy 2.67% [.] vfprintf 2.44% [k] strcmp | --- smk_find_entry smk_import_entry smk_import

[PATCH] ARM: decompressor: add a missing parameter to the addruart macro

2018-03-23 Thread Łukasz Stelmach
In commit 639da5ee374b an additional temporary register was added to the addruart macro, but the decompressor code wasn't updated. Signed-off-by: Łukasz Stelmach --- arch/arm/boot/compressed/head.S | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm

Re: [PATCH v3 1/3] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings

2017-12-05 Thread Łukasz Stelmach
It was <2017-12-04 pon 14:13>, when Krzysztof Kozlowski wrote: > On Mon, Dec 4, 2017 at 1:53 PM, Łukasz Stelmach > wrote: >> Add binding documentation for the True Random Number Generator >> found on Samsung Exynos 5250+ SoCs. >> >> Signed-off-by: Łukasz

[PATCH 0/3] Assorted changes for Exynos PRNG driver

2017-12-05 Thread Łukasz Stelmach
output performance by using memcpy() rather than a custom function to retriev random bytes from registers. Patch #3 Reseed the PRNG after reading 2^16 bytes. Simmilar approach is implemented in DRBG. (Thanks Stephan Mueller) Łukasz Stelmach (3): crypto: exynos - Support Exynos5250+ SoCs crypto

[PATCH 1/3] crypto: exynos - Support Exynos5250+ SoCs

2017-12-05 Thread Łukasz Stelmach
Add support for PRNG in Exynos5250+ SoCs. Signed-off-by: Łukasz Stelmach --- .../bindings/crypto/samsung,exynos-rng4.txt| 4 ++- drivers/crypto/exynos-rng.c| 36 -- 2 files changed, 36 insertions(+), 4 deletions(-) diff --git a/Documentation

[PATCH 3/3] crypto: exynos - Reseed PRNG after generating 2^16 random bytes

2017-12-05 Thread Łukasz Stelmach
Reseed PRNG after reading 65 kB of randomness. Although this may reduce performance, in most casese the loss is not noticable. Signed-off-by: Łukasz Stelmach --- drivers/crypto/exynos-rng.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/crypto

[PATCH 2/3] crypto: exynos - Improve performance of PRNG

2017-12-05 Thread Łukasz Stelmach
Use memcpy_fromio() instead of custom exynos_rng_copy_random() function to retrieve generated numbers from the registers of PRNG. Remove unnecessary invocation of cpu_relax(). Signed-off-by: Łukasz Stelmach --- drivers/crypto/exynos-rng.c | 36 +--- 1 file

[RFC] crypto: exynos - Icrease the priority of the driver

2017-12-05 Thread Łukasz Stelmach
exynos-rng is one of many implementations of stdrng. With priority as low as 100 it isn't selected, if software implementations (DRBG) are available. Signed-off-by: Łukasz Stelmach --- If not 1000, what is the best value, what is the policy? drivers/crypto/exynos-rng.c | 2 +- 1 file changed

[PATCH] crypto: exynos - Icrease the priority of the driver

2017-12-05 Thread Łukasz Stelmach
in the kernel command line). Signed-off-by: Łukasz Stelmach --- Thank you Stephan Mueller for explanations. drivers/crypto/exynos-rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/exynos-rng.c b/drivers/crypto/exynos-rng.c index 4b2ed1d178af..5a37397fb1c5 100644

Re: [PATCH 2/3] crypto: exynos - Improve performance of PRNG

2017-12-05 Thread Łukasz Stelmach
It was <2017-12-05 wto 14:54>, when Stephan Mueller wrote: > Am Dienstag, 5. Dezember 2017, 13:35:57 CET schrieb Łukasz Stelmach: > > Hi Łukasz, > >> Use memcpy_fromio() instead of custom exynos_rng_copy_random() function >> to retrieve generated numbers from the re

Re: [PATCH 2/3] crypto: exynos - Improve performance of PRNG

2017-12-06 Thread Łukasz Stelmach
It was <2017-12-05 wto 19:06>, when Krzysztof Kozlowski wrote: > On Tue, Dec 5, 2017 at 6:53 PM, Krzysztof Kozlowski wrote: >> On Tue, Dec 05, 2017 at 05:43:10PM +0100, Łukasz Stelmach wrote: >>> It was <2017-12-05 wto 14:54>, when Stephan Mueller wrote: >>>

Re: [PATCH 2/3] crypto: exynos - Improve performance of PRNG

2017-12-06 Thread Łukasz Stelmach
It was <2017-12-06 śro 12:37>, when Krzysztof Kozlowski wrote: > On Wed, Dec 6, 2017 at 12:32 PM, Łukasz Stelmach > wrote: >> It was <2017-12-05 wto 19:06>, when Krzysztof Kozlowski wrote: >>> On Tue, Dec 5, 2017 at 6:53 PM, Krzysztof Kozlowski wrote: >&g

Re: [PATCH 1/3] crypto: exynos - Support Exynos5250+ SoCs

2017-12-06 Thread Łukasz Stelmach
It was <2017-12-05 wto 14:34>, when Krzysztof Kozlowski wrote: > On Tue, Dec 5, 2017 at 1:35 PM, Łukasz Stelmach > wrote: >> Add support for PRNG in Exynos5250+ SoCs. >> >> Signed-off-by: Łukasz Stelmach >> --- >> .../bindings/crypto/samsung,exynos-r

Re: [PATCH 1/3] crypto: exynos - Support Exynos5250+ SoCs

2017-12-06 Thread Łukasz Stelmach
It was <2017-12-06 śro 15:05>, when Krzysztof Kozlowski wrote: > On Wed, Dec 6, 2017 at 2:42 PM, Łukasz Stelmach > wrote: >> It was <2017-12-05 wto 14:34>, when Krzysztof Kozlowski wrote: >>> On Tue, Dec 5, 2017 at 1:35 PM, Łukasz Stelmach >>> wrot

Re: [PATCH v3 2/3] hwrng: exynos - add Samsung Exynos True RNG driver

2017-12-22 Thread Łukasz Stelmach
It was <2017-12-22 pią 09:35>, when Herbert Xu wrote: > On Fri, Dec 22, 2017 at 09:29:38AM +0100, Marek Szyprowski wrote: >> Hi, >> >> On 2017-12-22 09:24, Herbert Xu wrote: >> >On Mon, Dec 04, 2017 at 01:53:50PM +0100, Łukasz Stelmach wrote: >> >

[PATCH v4] hwrng: exynos - add Samsung Exynos True RNG driver

2017-12-22 Thread Łukasz Stelmach
Add support for True Random Number Generator found in Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach Reviewed-by: Krzysztof Kozlowski --- Changes since v3: - Fixed typo in the secongd argument of MODULE_DEVICE_TABLE (Thanks, Herbert Xu) MAINTAINERS | 7

Re: [PATCH v4] hwrng: exynos - add Samsung Exynos True RNG driver

2017-12-22 Thread Łukasz Stelmach
It was <2017-12-22 pią 14:34>, when Philippe Ombredanne wrote: > Łukasz, > > On Fri, Dec 22, 2017 at 2:23 PM, Łukasz Stelmach > wrote: >> Add support for True Random Number Generator found in Samsung Exynos >> 5250+ SoCs. >> >> Signed-off-by: Łukasz Ste

[PATCH v5] hwrng: exynos - add Samsung Exynos True RNG driver

2017-12-22 Thread Łukasz Stelmach
Add support for True Random Number Generator found in Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach Reviewed-by: Krzysztof Kozlowski --- Changes since v4: - SPDX license header instead of the traditional blurb. - MODULE_LICENSE("GPL v2") instead of "GPL"

Re: [PATCH v4] hwrng: exynos - add Samsung Exynos True RNG driver

2017-12-27 Thread Łukasz Stelmach
It was <2017-12-22 pią 19:30>, when Philippe Ombredanne wrote: > On Fri, Dec 22, 2017 at 5:38 PM, Łukasz Stelmach > wrote: >> It was <2017-12-22 pią 14:34>, when Philippe Ombredanne wrote: >>> Łukasz, >>> >>> On Fri, Dec 22, 2017 at 2:23 PM, Łuk

[PATCH] ARM: decompressor: restore r1 and r2 just before jumping to the kernel

2018-04-04 Thread Łukasz Stelmach
Hypervisor setup before __enter_kernel destroys the value sotred in r1. The value needs to be restored just before the jump. Signed-off-by: Łukasz Stelmach --- arch/arm/boot/compressed/head.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/compressed/head.S

Re: [PATCH 1/3] crypto: exynos - Support Exynos5250+ SoCs

2017-12-07 Thread Łukasz Stelmach
It was <2017-12-06 śro 16:28>, when Krzysztof Kozlowski wrote: > On Wed, Dec 6, 2017 at 3:53 PM, Łukasz Stelmach > wrote: >> It was <2017-12-06 śro 15:05>, when Krzysztof Kozlowski wrote: >>> On Wed, Dec 6, 2017 at 2:42 PM, Łukasz Stelmach >>> wrote

[PATCH v3 2/3] hwrng: exynos - add Samsung Exynos True RNG driver

2017-12-04 Thread Łukasz Stelmach
Add support for True Random Number Generator found in Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach --- MAINTAINERS | 7 + drivers/char/hw_random/Kconfig | 12 ++ drivers/char/hw_random/Makefile | 1 + drivers/char/hw_random/exynos-trng.c

[PATCH v3 0/3] True RNG driver for Samsung Exynos 5250+ SoCs

2017-12-04 Thread Łukasz Stelmach
Hello. The following patches add support for the true random number generator found in Samsung Exynos 5250+ SoCs. Patch #1 adds documentation for devicetree bindings. Patch #2 introduces the driver and appropriate changes in Makefile and Kconfig. Patch #3 adds nodes in devicetree files for

[PATCH v3 3/3] ARM: dts: exynos: Add nodes for True Random Number Generator

2017-12-04 Thread Łukasz Stelmach
Add nodes for the True Random Number Generator found in Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach --- arch/arm/boot/dts/exynos5.dtsi| 5 + arch/arm/boot/dts/exynos5250.dtsi | 5 + arch/arm/boot/dts/exynos5410.dtsi | 5 + arch/arm/boot/dts/exynos5420.dtsi | 5

[PATCH v3 1/3] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings

2017-12-04 Thread Łukasz Stelmach
Add binding documentation for the True Random Number Generator found on Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach --- .../devicetree/bindings/rng/samsung,exynos5250-trng.txt | 17 + 1 file changed, 17 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v2 3/4] crypto: exynos - Reseed PRNG after generating 2^16 random bytes

2017-12-11 Thread Łukasz Stelmach
from its output sequence, and hence, prevents potential attacker from predicting numbers to be generated. Signed-off-by: Łukasz Stelmach Reviewed-by: Stephan Mueller --- drivers/crypto/exynos-rng.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/crypto

[PATCH v2 2/4] crypto: exynos - Improve performance of PRNG

2017-12-11 Thread Łukasz Stelmach
of PRNG. The do {} while () loop decrements the retry variable only once, which means, the time required for cpu_relax() is long enough to for the PRNG to provide results. On the other hand, performance in this arrangement isn't much worse than in a loop without cpu_relax(). Signed-off-by: Łukasz

[PATCH v2 1/4] crypto: exynos - Support Exynos5250+ SoCs

2017-12-11 Thread Łukasz Stelmach
Cc: Marek Szyprowski , Bartlomiej Zolnierkiewicz Add support for PRNG in Exynos5250+ SoCs. Signed-off-by: Łukasz Stelmach --- .../bindings/crypto/samsung,exynos-rng4.txt| 4 ++- drivers/crypto/exynos-rng.c| 32 -- 2 files changed, 33

[PATCH v2 0/4] Assorted changes for Exynos PRNG driver

2017-12-11 Thread Łukasz Stelmach
enum and a define according to Krzysztof Kozłowski's recommendations. - Brought back cpu_relax() in a rearranged loop in exynos_rng_get_random(). - Moved an assignment of the read valuea away from an error path. - Removed dev_info() reporting hardware presence from exynos_rng_probe(). Łukasz

[PATCH v2 4/4] crypto: exynos - Introduce mutex to prevent concurrent access to hardware

2017-12-11 Thread Łukasz Stelmach
of mutex_lock() and mutex_unlock() in the exynos_rng_reseed() function enables switching between different threads waiting for the driver to generate random numbers for them. Signed-off-by: Łukasz Stelmach --- drivers/crypto/exynos-rng.c | 21 + 1 file changed, 21 insertions(+) diff

Re: [PATCH v2 4/4] crypto: exynos - Introduce mutex to prevent concurrent access to hardware

2017-12-12 Thread Łukasz Stelmach
It was <2017-12-11 pon 16:03>, when Krzysztof Kozlowski wrote: > On Mon, Dec 11, 2017 at 3:06 PM, Łukasz Stelmach > wrote: >> Cc: Marek Szyprowski , Bartlomiej Zolnierkiewicz >> >> >> Hardware operations like reading random numbers and setting a seed need &

Re: [PATCH v3 3/3] ARM: dts: exynos: Add nodes for True Random Number Generator

2017-12-12 Thread Łukasz Stelmach
It was <2017-12-11 pon 19:49>, when Krzysztof Kozlowski wrote: > On Mon, Dec 04, 2017 at 01:53:51PM +0100, Łukasz Stelmach wrote: >> Add nodes for the True Random Number Generator found in Samsung Exynos >> 5250+ SoCs. >> >> Signed-off-by: Łukasz Stelmach >

[PATCH 0/3] True RNG driver for Samsung Exynos 5250+ SoCs

2017-11-23 Thread Łukasz Stelmach
for Exynos SoCs. Łukasz Stelmach (3): dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings hwrng: exynos - add Samsung Exynos True RNG driver ARM: dts: exynos: Add nodes for True Random Number Generator .../bindings/rng/samsung,exynos5250-trng.txt | 17 ++ MAINTAINERS

[PATCH 1/3] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings

2017-11-23 Thread Łukasz Stelmach
Add binding documentation for the True Random Number Generator found on Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach --- .../devicetree/bindings/rng/samsung,exynos5250-trng.txt | 17 + 1 file changed, 17 insertions(+) create mode 100644 Documentation/devicetree

  1   2   3   >