[2.6 patch] dvb/frontends/xc5000.c: make a struct static

2008-01-28 Thread Adrian Bunk
struct XC5000_Standard[] can become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- e1f9c8304c807ecce026156ee2185925295fe835 diff --git a/drivers/media/dvb/frontends/xc5000.c b/drivers/media/dvb/frontends/xc5000.c index f642ca2..a5094b7 100644 --- a/drivers/media/dvb/frontends/xc5000

[2.6 patch] stk-sensor.c: make 2 functions static

2008-01-28 Thread Adrian Bunk
This patch makes the following needlessly global functions static: - stk_sensor_outb() - stk_sensor_inb() Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/media/video/stk-sensor.c |4 ++-- drivers/media/video/stk-webcam.h |2 -- 2 files changed, 2 insertions(+), 4 deletions

[2.6 patch] make tuner-core.c:tuner_list static

2008-01-28 Thread Adrian Bunk
tuner_list can become static - and it's anyway a way too generic name for a global variable - see commit b00ef4b8d8c29bfb5f6f92ee60bc04b604f36ef2 for a completely different global variable of the same name I just made static... Signed-off-by: Adrian Bunk [EMAIL PROTECTED

[2.6 patch] tuner-xc2028.c: make a function static

2008-01-28 Thread Adrian Bunk
dump_firm_type_and_int_freq() can become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- ca482dc248480ecc87fb342df548f086c3e67663 diff --git a/drivers/media/video/tuner-xc2028.c b/drivers/media/video/tuner-xc2028.c index f191f6a..33a51fa 100644 --- a/drivers/media/video/tuner-xc2028.c

[2.6 patch] make gfs2_glock_hold() static

2008-01-28 Thread Adrian Bunk
gfs2_glock_hold() can now become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- fs/gfs2/glock.c |2 +- fs/gfs2/glock.h |1 - 2 files changed, 1 insertion(+), 2 deletions(-) f04fbd054a051a564a3138e0e02b7423acf45a06 diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index 80e09c5

[2.6 patch] fs/ocfs2/: possible cleanups

2008-01-28 Thread Adrian Bunk
: - heartbeat.c:ocfs2_node_map_is_only() Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- fs/ocfs2/dlmglue.c |4 ++-- fs/ocfs2/dlmglue.h |2 -- fs/ocfs2/heartbeat.c | 26 +- fs/ocfs2/heartbeat.h |5 - 4 files changed, 15 insertions(+), 22 deletions

media/radio/radio-si470x.c: check-after-use

2008-01-28 Thread Adrian Bunk
The Coverity checker spotted the following check-after-use in drivers/media/radio/radio-si470x.c: -- snip -- ... static void si470x_usb_driver_disconnect(struct usb_interface *intf) { struct si470x_device *radio = usb_get_intfdata(intf); del_timer_sync(radio-timer);

Re: [2.6 patch] let LOG_BUF_SHIFT default to 17

2008-01-28 Thread Adrian Bunk
On Tue, Jan 29, 2008 at 07:35:00AM +0100, Andi Kleen wrote: Adrian Bunk [EMAIL PROTECTED] writes: 16 kB is often no longer enough for a normal boot of an UP system. Better would be to just disable by default/remove noisy messages to make the kernel boot output shorter. I think we got

Re: 2.6.25 regression: VIDEO_DEV=y/m, I2C=n compile error

2008-01-28 Thread Adrian Bunk
On Sun, Jan 27, 2008 at 10:33:34PM -0200, Mauro Carvalho Chehab wrote: Hi Adrian and Marcin, On Sun, 27 Jan 2008 20:52:16 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: Commit 8ffbc6559493c64d6194c92d856196fdaeb8a5fb causes the following compile error with CONFIG_VIDEO_DEV=y/m, CONFIG_I2C

Re: [v4l-dvb-maintainer] 2.6.25 regression: VIDEO_DEV=y/m, I2C=n compile error

2008-01-28 Thread Adrian Bunk
On Mon, Jan 28, 2008 at 09:49:12AM -0200, Mauro Carvalho Chehab wrote: Maybe the kernel headers should provide a couple macros for testing configs, since people get it wrong over and over again? #define CONFIG_ON(x) (defined(CONFIG_##x) || defined(CONFIG_##x##_MODULE)) #define

Re: [v4l-dvb-maintainer] 2.6.25 regression: VIDEO_DEV=y/m, I2C=n compile error

2008-01-28 Thread Adrian Bunk
On Mon, Jan 28, 2008 at 01:17:10PM +0100, Jan Engelhardt wrote: On Jan 28 2008 01:05, Trent Piepho wrote: Maybe the kernel headers should provide a couple macros for testing configs, since people get it wrong over and over again? #define CONFIG_ON(x) (defined(CONFIG_##x) ||

Re: 2.6.24 regression: Wake On Lan in sky2 broken on Mac mini

2008-01-28 Thread Adrian Bunk
On Mon, Jan 28, 2008 at 02:43:05PM +0100, Tino Keitel wrote: On Mon, Jan 28, 2008 at 14:37:38 +0100, Mikael Pettersson wrote: [...] However, it _is_ a fact that there is a proliferation of specialized mailing lists, and it is also a fact that many developers _only_ read those lists.

2.6.25 regression: VIDEO_DEV=y/m, I2C=n compile error

2008-01-27 Thread Adrian Bunk
Commit 8ffbc6559493c64d6194c92d856196fdaeb8a5fb causes the following compile error with CONFIG_VIDEO_DEV=y/m, CONFIG_I2C=n: <-- snip --> ... MODPOST 26 modules ERROR: "i2c_attach_client" [drivers/media/video/v4l2-common.ko] undefined! make[2]: *** [__modpost] Error 1 <-- snip --> cu

Linux 2.6.16.60

2008-01-27 Thread Adrian Bunk
/kernel/git/stable/linux-2.6.16.y.git RSS feed of the git tree: http://www.kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.16.y.git;a=rss Changes since 2.6.16.59: Adrian Bunk (3): drivers/scsi/BusLogic.c: #ifdef MODULE BusLogic_pci_tbl[] Linux 2.6.16.60-rc1 Linux 2.6.16.60 Al

Linux 2.6.16.60

2008-01-27 Thread Adrian Bunk
/kernel/git/stable/linux-2.6.16.y.git RSS feed of the git tree: http://www.kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.16.y.git;a=rss Changes since 2.6.16.59: Adrian Bunk (3): drivers/scsi/BusLogic.c: #ifdef MODULE BusLogic_pci_tbl[] Linux 2.6.16.60-rc1 Linux 2.6.16.60 Al

2.6.25 regression: VIDEO_DEV=y/m, I2C=n compile error

2008-01-27 Thread Adrian Bunk
Commit 8ffbc6559493c64d6194c92d856196fdaeb8a5fb causes the following compile error with CONFIG_VIDEO_DEV=y/m, CONFIG_I2C=n: -- snip -- ... MODPOST 26 modules ERROR: i2c_attach_client [drivers/media/video/v4l2-common.ko] undefined! make[2]: *** [__modpost] Error 1 -- snip -- cu Adrian

Re: The latest linus tree can't build

2008-01-26 Thread Adrian Bunk
On Sat, Jan 26, 2008 at 06:38:45PM +0800, WANG Cong wrote: > > Hi, Sam! > > When I built the latest linus tree, I got this error: > > ... > CC sound/oss/msnd.o > make[2]: *** No rule to make target `/etc/sound/msndperm.bin', needed by > `sound/oss/msndperm.c'. Stop. > make[1]: ***

Re: The latest linus tree can't build

2008-01-26 Thread Adrian Bunk
On Sat, Jan 26, 2008 at 06:38:45PM +0800, WANG Cong wrote: Hi, Sam! When I built the latest linus tree, I got this error: ... CC sound/oss/msnd.o make[2]: *** No rule to make target `/etc/sound/msndperm.bin', needed by `sound/oss/msndperm.c'. Stop. make[1]: *** [sound/oss]

Re: [PATCH 5/9] bfs: move function prototype to the proper header file

2008-01-25 Thread Adrian Bunk
On Thu, Jan 24, 2008 at 11:22:21PM +, Tigran Aivazian wrote: > On Fri, 25 Jan 2008, Dmitri Vorobiev wrote: > >> Heikki Orsila пишет: +extern void dump_imap(const char *, struct super_block *); + >>> >>> Functions should not be externed, remove extern keyword. >>> >> >> Care to

Re: [PATCH 5/9] bfs: move function prototype to the proper header file

2008-01-25 Thread Adrian Bunk
On Thu, Jan 24, 2008 at 11:22:21PM +, Tigran Aivazian wrote: On Fri, 25 Jan 2008, Dmitri Vorobiev wrote: Heikki Orsila пишет: +extern void dump_imap(const char *, struct super_block *); + Functions should not be externed, remove extern keyword. Care to explain why? because

Re: [RFC] Parallelize IO for e2fsck

2008-01-24 Thread Adrian Bunk
On Thu, Jan 24, 2008 at 06:32:15PM +0100, Bodo Eggert wrote: > Alan Cox <[EMAIL PROTECTED]> wrote: > > >> I'd tried to advocate SIGDANGER some years ago as well, but none of > >> the kernel maintainers were interested. It definitely makes sense > >> to have some sort of mechanism like this. At

Re: [PATCH for mm] Remove iBCS support

2008-01-24 Thread Adrian Bunk
On Fri, Jan 25, 2008 at 04:25:24AM +1030, David Newall wrote: > Adrian Bunk wrote: > > Removing dead code makes: > > - the kernel smaller, > > - the kernel faster and > > - makes it easier to maintain the non-dead code. > > The performance benefi

Re: [PATCH for mm] Remove iBCS support

2008-01-24 Thread Adrian Bunk
On Fri, Jan 25, 2008 at 03:34:17AM +1030, David Newall wrote: > Adrian Bunk wrote: > > But Linux kernel development is not driven by people producing hot air > > about what they wish to see in the future, Linux kernel development is > > driven by people sending patches.

Re: [PATCH] x86: fix?unconditional?arch/x86/kernel/pcspeaker.c?compiling

2008-01-24 Thread Adrian Bunk
On Wed, Jan 23, 2008 at 11:30:11PM +0100, Michael Opdenacker wrote: > On Friday 18 January 2008, Matt Mackall wrote: > > > > Probably makes sense to define it right next to INPUT_PCSPKR in > > drivers/input/Kconfig. > > > > Then do the appropriate fix for all arches mentioned in INPUT_PCSPKR. >

Re: [PATCH] x86: fix?unconditional?arch/x86/kernel/pcspeaker.c?compiling

2008-01-24 Thread Adrian Bunk
On Wed, Jan 23, 2008 at 11:30:11PM +0100, Michael Opdenacker wrote: On Friday 18 January 2008, Matt Mackall wrote: Probably makes sense to define it right next to INPUT_PCSPKR in drivers/input/Kconfig. Then do the appropriate fix for all arches mentioned in INPUT_PCSPKR. For

Re: [PATCH for mm] Remove iBCS support

2008-01-24 Thread Adrian Bunk
On Fri, Jan 25, 2008 at 03:34:17AM +1030, David Newall wrote: Adrian Bunk wrote: But Linux kernel development is not driven by people producing hot air about what they wish to see in the future, Linux kernel development is driven by people sending patches. Removal of code

Re: [RFC] Parallelize IO for e2fsck

2008-01-24 Thread Adrian Bunk
On Thu, Jan 24, 2008 at 06:32:15PM +0100, Bodo Eggert wrote: Alan Cox [EMAIL PROTECTED] wrote: I'd tried to advocate SIGDANGER some years ago as well, but none of the kernel maintainers were interested. It definitely makes sense to have some sort of mechanism like this. At the time I

[2.6 patch] kconfig: remove "enable"

2008-01-22 Thread Adrian Bunk
Kconfig had a synonym "enable" for "select" that was neither documented nor used. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- scripts/kconfig/zconf.gperf |1 - scripts/kconfig/zconf.hash.c_shipped | 14 +++--- 2 files changed, 7

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-22 Thread Adrian Bunk
On Tue, Jan 22, 2008 at 08:18:32PM +0100, Wilco Beekhuizen wrote: > 2.6.24-rc8 (possibly lower rc's too) has usb_find_device removed from > usb.c. This causes problems when compiling modules that need > usb_find_device. > This patch puts the symbol back in place. Unless someone has a good >

Linux 2.6.16.60-rc1

2008-01-22 Thread Adrian Bunk
://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.16.y.git RSS feed of the git tree: http://www.kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.16.y.git;a=rss Changes since 2.6.16.59: Adrian Bunk (2): drivers/scsi/BusLogic.c: #ifdef MODULE BusLogic_pci_tbl[] Linux 2.6.16.60

Re: [PATCH for mm] Remove iBCS support

2008-01-22 Thread Adrian Bunk
On Wed, Jan 23, 2008 at 01:43:30AM +1030, David Newall wrote: > Ingo Molnar wrote: > > * David Newall <[EMAIL PROTECTED]> wrote: > > > >> Andi Kleen wrote: > >> > >>> You seem to be under the illusion that iBCS2 support works currently > >>> in mainline and that only this patch would break

Re: [PATCH for mm] Remove iBCS support

2008-01-22 Thread Adrian Bunk
On Wed, Jan 23, 2008 at 01:36:27AM +1030, David Newall wrote: > Karl Kiniger wrote: > > on http://www.feise.com/~jfeise/Downloads/linux-abi/ > > > > a patch named linux-abi-2.6.22.3_3.diff.bz2 can be found. > > Thankyou for that. > > Matter of interest: if it works, why isn't it in the

Re: [PATCH for mm] Remove iBCS support

2008-01-22 Thread Adrian Bunk
On Wed, Jan 23, 2008 at 01:36:27AM +1030, David Newall wrote: Karl Kiniger wrote: on http://www.feise.com/~jfeise/Downloads/linux-abi/ a patch named linux-abi-2.6.22.3_3.diff.bz2 can be found. Thankyou for that. Matter of interest: if it works, why isn't it in the mainline? This you

Re: [PATCH for mm] Remove iBCS support

2008-01-22 Thread Adrian Bunk
On Wed, Jan 23, 2008 at 01:43:30AM +1030, David Newall wrote: Ingo Molnar wrote: * David Newall [EMAIL PROTECTED] wrote: Andi Kleen wrote: You seem to be under the illusion that iBCS2 support works currently in mainline and that only this patch would break it. I

Linux 2.6.16.60-rc1

2008-01-22 Thread Adrian Bunk
://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.16.y.git RSS feed of the git tree: http://www.kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.16.y.git;a=rss Changes since 2.6.16.59: Adrian Bunk (2): drivers/scsi/BusLogic.c: #ifdef MODULE BusLogic_pci_tbl[] Linux 2.6.16.60

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-22 Thread Adrian Bunk
On Tue, Jan 22, 2008 at 08:18:32PM +0100, Wilco Beekhuizen wrote: 2.6.24-rc8 (possibly lower rc's too) has usb_find_device removed from usb.c. This causes problems when compiling modules that need usb_find_device. This patch puts the symbol back in place. Unless someone has a good reason not

Re: kbuild: improved Section mismatch detection

2008-01-21 Thread Adrian Bunk
On Mon, Jan 21, 2008 at 09:31:17PM +0100, Sam Ravnborg wrote: > On Mon, Jan 21, 2008 at 12:27:54AM +0200, Adrian Bunk wrote: > > On Sun, Jan 20, 2008 at 09:05:27PM +0100, Sam Ravnborg wrote: > > >... > > > Adrian reminded us that KCFLAGS=-fno-inline told > > &

Re: kbuild: improved Section mismatch detection

2008-01-21 Thread Adrian Bunk
On Mon, Jan 21, 2008 at 09:31:17PM +0100, Sam Ravnborg wrote: On Mon, Jan 21, 2008 at 12:27:54AM +0200, Adrian Bunk wrote: On Sun, Jan 20, 2008 at 09:05:27PM +0100, Sam Ravnborg wrote: ... Adrian reminded us that KCFLAGS=-fno-inline told another story with more than 100 Section mismatch

Re: kbuild: improved Section mismatch detection

2008-01-20 Thread Adrian Bunk
On Sun, Jan 20, 2008 at 09:05:27PM +0100, Sam Ravnborg wrote: >... > Adrian reminded us that KCFLAGS=-fno-inline told > another story with more than 100 Section mismatch > warnings on 64 bit x86 with an allyesconfig build. >... Not -fno-inline but -fno-inline-functions-called-once (completely

RFC: Removal of the v850 port?

2008-01-20 Thread Adrian Bunk
in the future if someone will start getting it back into a usable state, but in it's current state it is simply useless. cu Adrian - Forwarded message from Adrian Bunk <[EMAIL PROTECTED]> - Date: Tue, 1 Jan 2008 15:50:21 +0200 From: Adrian Bunk <[EMAIL PROTECTED]> To: Miles B

[2.6 patch] make BINFMT_FLAT a bool

2008-01-20 Thread Adrian Bunk
I have not yet seen anyone saying he has a reasonable use case for using BINFMT_FLAT modular on his embedded device. Considering that fs/binfmt_flat.c even lacks a MODULE_LICENSE() I really doubt there is any, and this patch therefore makes BINFMT_FLAT a bool. Signed-off-by: Adrian Bunk

[2.6 patch] the scheduled 'time' option removal

2008-01-20 Thread Adrian Bunk
On Tue, Jan 01, 2008 at 06:07:51PM -0800, Randy Dunlap wrote: > On Tue, 1 Jan 2008 15:46:56 +0200 Adrian Bunk wrote: > > > This patch contains the scheduled removal of the 'time' option. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > Thanks.

[2.6 patch] the scheduled 'time' option removal

2008-01-20 Thread Adrian Bunk
On Tue, Jan 01, 2008 at 06:07:51PM -0800, Randy Dunlap wrote: On Tue, 1 Jan 2008 15:46:56 +0200 Adrian Bunk wrote: This patch contains the scheduled removal of the 'time' option. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Thanks. Looks good except that Documentation/kernel

[2.6 patch] make BINFMT_FLAT a bool

2008-01-20 Thread Adrian Bunk
I have not yet seen anyone saying he has a reasonable use case for using BINFMT_FLAT modular on his embedded device. Considering that fs/binfmt_flat.c even lacks a MODULE_LICENSE() I really doubt there is any, and this patch therefore makes BINFMT_FLAT a bool. Signed-off-by: Adrian Bunk [EMAIL

RFC: Removal of the v850 port?

2008-01-20 Thread Adrian Bunk
in the future if someone will start getting it back into a usable state, but in it's current state it is simply useless. cu Adrian - Forwarded message from Adrian Bunk [EMAIL PROTECTED] - Date: Tue, 1 Jan 2008 15:50:21 +0200 From: Adrian Bunk [EMAIL PROTECTED] To: Miles Bader [EMAIL

Re: kbuild: improved Section mismatch detection

2008-01-20 Thread Adrian Bunk
On Sun, Jan 20, 2008 at 09:05:27PM +0100, Sam Ravnborg wrote: ... Adrian reminded us that KCFLAGS=-fno-inline told another story with more than 100 Section mismatch warnings on 64 bit x86 with an allyesconfig build. ... Not -fno-inline but -fno-inline-functions-called-once (completely

Re: [lguest build regression fix] Re: 2.6.24-rc8-git1: Reported regressions from 2.6.23

2008-01-19 Thread Adrian Bunk
On Sun, Jan 20, 2008 at 10:24:47AM +1100, Rusty Russell wrote: > On Sunday 20 January 2008 05:06:04 Ingo Molnar wrote: > > x86 randconfig testing found the following build failure: > > > > arch/x86/lguest/boot.c: In function 'lazy_hcall': > > arch/x86/lguest/boot.c:151: error: implicit

Linux 2.6.16.59

2008-01-19 Thread Adrian Bunk
pub/linux/kernel/v2.6/ git tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.16.y.git RSS feed of the git tree: http://www.kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.16.y.git;a=rss Changes since 2.6.16.58: Adrian Bunk (3): struct input_device_id must

[2.6 patch] atm/suni.c: fix section mismatch

2008-01-19 Thread Adrian Bunk
EXPORT_SYMBOL'ed code mustn't be __*init. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- --- linux-2.6/drivers/atm/suni.c.old2008-01-19 12:16:41.0 +0200 +++ linux-2.6/drivers/atm/suni.c2008-01-19 12:17:23.0 +0200 @@ -275,35 +275,35 @@ static int suni_stop(

[2.6 patch] atm/idt77105.c: fix section mismatch

2008-01-19 Thread Adrian Bunk
EXPORT_SYMBOL'ed code mustn't be __*init. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- --- linux-2.6/drivers/atm/idt77105.c.old2008-01-19 11:19:53.0 +0200 +++ linux-2.6/drivers/atm/idt77105.c2008-01-19 11:20:10.0 +0200 @@ -354,13 +354,13 @@ static const

[2.6 patch] atm/idt77105.c: fix section mismatch

2008-01-19 Thread Adrian Bunk
EXPORT_SYMBOL'ed code mustn't be __*init. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- --- linux-2.6/drivers/atm/idt77105.c.old2008-01-19 11:19:53.0 +0200 +++ linux-2.6/drivers/atm/idt77105.c2008-01-19 11:20:10.0 +0200 @@ -354,13 +354,13 @@ static const struct

[2.6 patch] atm/suni.c: fix section mismatch

2008-01-19 Thread Adrian Bunk
EXPORT_SYMBOL'ed code mustn't be __*init. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- --- linux-2.6/drivers/atm/suni.c.old2008-01-19 12:16:41.0 +0200 +++ linux-2.6/drivers/atm/suni.c2008-01-19 12:17:23.0 +0200 @@ -275,35 +275,35 @@ static int suni_stop(struct

Linux 2.6.16.59

2008-01-19 Thread Adrian Bunk
/linux/kernel/v2.6/ git tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.16.y.git RSS feed of the git tree: http://www.kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.16.y.git;a=rss Changes since 2.6.16.58: Adrian Bunk (3): struct input_device_id mustn't

Re: [lguest build regression fix] Re: 2.6.24-rc8-git1: Reported regressions from 2.6.23

2008-01-19 Thread Adrian Bunk
On Sun, Jan 20, 2008 at 10:24:47AM +1100, Rusty Russell wrote: On Sunday 20 January 2008 05:06:04 Ingo Molnar wrote: x86 randconfig testing found the following build failure: arch/x86/lguest/boot.c: In function 'lazy_hcall': arch/x86/lguest/boot.c:151: error: implicit declaration of

Re: [2.6.24 patch] x86: allow 64bit setting in Kconfig

2008-01-18 Thread Adrian Bunk
On Fri, Jan 18, 2008 at 10:06:33PM +0100, Ingo Molnar wrote: > > * Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > > thx, i've added this to x86.git. > > > > > > this broke "make ARCH=i386 randconfig" from working when there's a > >

Re: [2.6.24 patch] x86: allow 64bit setting in Kconfig

2008-01-18 Thread Adrian Bunk
On Fri, Jan 18, 2008 at 06:00:37PM +0100, Ingo Molnar wrote: > > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > > * Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > > # Select 32 or 64 bit > > > config 64BIT > > >

Re: [2.6.24 patch] x86: allow 64bit setting in Kconfig

2008-01-18 Thread Adrian Bunk
On Fri, Jan 18, 2008 at 01:02:48PM +0100, Ingo Molnar wrote: > > * Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > > Style question, would the following be preferred? > > > > > > config 64BIT > > > def_bool ARCH = "x86_64" > > > prompt "64-bit kernel" > > > help... > > > > No. > > It is

Re: [2.6.24 patch] x86: allow 64bit setting in Kconfig

2008-01-18 Thread Adrian Bunk
On Fri, Jan 18, 2008 at 01:02:48PM +0100, Ingo Molnar wrote: * Sam Ravnborg [EMAIL PROTECTED] wrote: Style question, would the following be preferred? config 64BIT def_bool ARCH = x86_64 prompt 64-bit kernel help... No. It is most common to let the prompt

Re: [2.6.24 patch] x86: allow 64bit setting in Kconfig

2008-01-18 Thread Adrian Bunk
On Fri, Jan 18, 2008 at 06:00:37PM +0100, Ingo Molnar wrote: * Ingo Molnar [EMAIL PROTECTED] wrote: * Adrian Bunk [EMAIL PROTECTED] wrote: # Select 32 or 64 bit config 64BIT - bool 64-bit kernel if ARCH = x86 + bool 64-bit kernel default ARCH = x86_64 help

Re: Linux 2.6.16.58

2008-01-17 Thread Adrian Bunk
On Thu, Jan 17, 2008 at 10:12:05PM +0100, Willy Tarreau wrote: > Hi Adrian, > > On Thu, Jan 17, 2008 at 10:34:16PM +0200, Adrian Bunk wrote: > > do you insist on hearing the truth ("Sorry, I forgot to push."), or can > > I tell you "I just wanted to

[2.6.24 patch] x86: allow 64bit setting in Kconfig

2008-01-17 Thread Adrian Bunk
to have the Kconfig default and the defconfig based on whether you are on a 32bit or a 64bit machine, but it's complete nonsense to not offer the Kconfig variable unless you had explicitely given ARCH=x86 (in which case you could as well immediately set the ARCH to i386 or x86_64). Signed-off-by:

Linux 2.6.16.59-rc1

2008-01-17 Thread Adrian Bunk
pub/linux/kernel/people/bunk/linux-2.6.16.y/testing/ git tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.16.y.git RSS feed of the git tree: http://www.kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.16.y.git;a=rss Changes since 2.6.16.58: Adrian Bunk (2): str

Re: Linux 2.6.16.58

2008-01-17 Thread Adrian Bunk
On Wed, Jan 16, 2008 at 05:04:17PM +0100, Jiri Kosina wrote: > On Wed, 16 Jan 2008, Adrian Bunk wrote: > > > RSS feed of the git tree: > > http://www.kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.16.y.git;a=rss > > Changes since 2.6.16.57: > > A

Linux 2.6.16.59-rc1

2008-01-17 Thread Adrian Bunk
/linux/kernel/people/bunk/linux-2.6.16.y/testing/ git tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.16.y.git RSS feed of the git tree: http://www.kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.16.y.git;a=rss Changes since 2.6.16.58: Adrian Bunk (2): struct

Re: Linux 2.6.16.58

2008-01-17 Thread Adrian Bunk
On Wed, Jan 16, 2008 at 05:04:17PM +0100, Jiri Kosina wrote: On Wed, 16 Jan 2008, Adrian Bunk wrote: RSS feed of the git tree: http://www.kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.16.y.git;a=rss Changes since 2.6.16.57: Adrian Bunk (3): ipv4/arp.c:arp_process(): remove

Re: Linux 2.6.16.58

2008-01-17 Thread Adrian Bunk
On Thu, Jan 17, 2008 at 10:12:05PM +0100, Willy Tarreau wrote: Hi Adrian, On Thu, Jan 17, 2008 at 10:34:16PM +0200, Adrian Bunk wrote: do you insist on hearing the truth (Sorry, I forgot to push.), or can I tell you I just wanted to see whether anyone notices. instead? ;-) :-) I

[2.6.24 patch] x86: allow 64bit setting in Kconfig

2008-01-17 Thread Adrian Bunk
default and the defconfig based on whether you are on a 32bit or a 64bit machine, but it's complete nonsense to not offer the Kconfig variable unless you had explicitely given ARCH=x86 (in which case you could as well immediately set the ARCH to i386 or x86_64). Signed-off-by: Adrian Bunk [EMAIL

Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU

2008-01-15 Thread Adrian Bunk
On Tue, Jan 15, 2008 at 11:14:09PM +0100, Ingo Molnar wrote: > > * Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > make ARCH=x86_64 allyesconfig > > > will set CONFIG_64BIT for you - no? > > > > Yes. > > > > But this still leaves

Linux 2.6.16.58

2008-01-15 Thread Adrian Bunk
://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.16.y.git RSS feed of the git tree: http://www.kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.16.y.git;a=rss Changes since 2.6.16.57: Adrian Bunk (3): ipv4/arp.c:arp_process(): remove bogus #ifdef mess Linux 2.6.16.58-rc1

Re: [PATCH] CRIS v10: vmlinux.lds.S Fix kernel oops on boot and use common defines

2008-01-15 Thread Adrian Bunk
On Tue, Jan 15, 2008 at 12:35:15PM -0800, Andrew Morton wrote: > On Tue, 15 Jan 2008 14:36:24 +0100 Jesper Nilsson <[EMAIL PROTECTED]> wrote: > > > - Move alignment to page size of init data outside ifdef for BLK_DEV_INITRD. > > The reservation up to page size of memory after init data was

Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU

2008-01-15 Thread Adrian Bunk
On Tue, Jan 15, 2008 at 07:21:42PM +0100, Sam Ravnborg wrote: >... > > > And I will add a config option to: > > > - set -fno-unit-at-a-time > > > > I was told future gcc versions would remove that. Why do you > > want it? > Are there any better way to tell gcc no to inline so agressively? I

Re: Fwd: Re: [2.6.24 patch] restore ARMv6 OProfile support

2008-01-15 Thread Adrian Bunk
On Tue, Jan 15, 2008 at 05:49:48PM +, Russell King wrote: >... > So blackfin also needs fixing. I don't know if blackfin people are > aware of this. They are: http://lkml.org/lkml/2007/12/28/100 > Russell King cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly

Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU

2008-01-15 Thread Adrian Bunk
On Tue, Jan 15, 2008 at 06:11:46PM +0100, Andi Kleen wrote: > On Tue, Jan 15, 2008 at 05:25:13PM +0100, Sam Ravnborg wrote: > > On Tue, Jan 15, 2008 at 04:17:42PM +0100, Ingo Molnar wrote: > > > > > > * Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > > > > > > find below the current set of

Re: Fwd: Re: [2.6.24 patch] restore ARMv6 OProfile support

2008-01-15 Thread Adrian Bunk
different from what my patches did and that's not a problem for me (his patches are also OK). What went wrong that his regression fixes did not land in Linus' tree? cu Adrian <-- snip --> This patch restores the ARMv6 OProfile support that was killed by commit 09cadedbdc01f1a4bea1f427

Re: Fwd: Re: [2.6.24 patch] restore ARMv6 OProfile support

2008-01-15 Thread Adrian Bunk
not land in Linus' tree? cu Adrian -- snip -- This patch restores the ARMv6 OProfile support that was killed by commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- kernel/Kconfig.instrumentation | 19 +++ 1 file changed, 19

Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU

2008-01-15 Thread Adrian Bunk
On Tue, Jan 15, 2008 at 06:11:46PM +0100, Andi Kleen wrote: On Tue, Jan 15, 2008 at 05:25:13PM +0100, Sam Ravnborg wrote: On Tue, Jan 15, 2008 at 04:17:42PM +0100, Ingo Molnar wrote: * Sam Ravnborg [EMAIL PROTECTED] wrote: find below the current set of warnings on -git. There

Re: Fwd: Re: [2.6.24 patch] restore ARMv6 OProfile support

2008-01-15 Thread Adrian Bunk
On Tue, Jan 15, 2008 at 05:49:48PM +, Russell King wrote: ... So blackfin also needs fixing. I don't know if blackfin people are aware of this. They are: http://lkml.org/lkml/2007/12/28/100 Russell King cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly out

Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU

2008-01-15 Thread Adrian Bunk
On Tue, Jan 15, 2008 at 07:21:42PM +0100, Sam Ravnborg wrote: ... And I will add a config option to: - set -fno-unit-at-a-time I was told future gcc versions would remove that. Why do you want it? Are there any better way to tell gcc no to inline so agressively? I haven't tested it,

Re: [PATCH] CRIS v10: vmlinux.lds.S Fix kernel oops on boot and use common defines

2008-01-15 Thread Adrian Bunk
On Tue, Jan 15, 2008 at 12:35:15PM -0800, Andrew Morton wrote: On Tue, 15 Jan 2008 14:36:24 +0100 Jesper Nilsson [EMAIL PROTECTED] wrote: - Move alignment to page size of init data outside ifdef for BLK_DEV_INITRD. The reservation up to page size of memory after init data was previously

Linux 2.6.16.58

2008-01-15 Thread Adrian Bunk
://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.16.y.git RSS feed of the git tree: http://www.kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.16.y.git;a=rss Changes since 2.6.16.57: Adrian Bunk (3): ipv4/arp.c:arp_process(): remove bogus #ifdef mess Linux 2.6.16.58-rc1

Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU

2008-01-15 Thread Adrian Bunk
On Tue, Jan 15, 2008 at 11:14:09PM +0100, Ingo Molnar wrote: * Adrian Bunk [EMAIL PROTECTED] wrote: make ARCH=x86_64 allyesconfig will set CONFIG_64BIT for you - no? Yes. But this still leaves the fact that when someone says 'allyesconfig' it's no longer clear which

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-14 Thread Adrian Bunk
On Mon, Jan 14, 2008 at 03:52:26PM -0700, Matthew Wilcox wrote: > On Sun, Jan 13, 2008 at 09:01:08AM -0800, Arjan van de Ven wrote: >... > > > - pci_conf1_read(0, 0, PCI_DEVFN(0,0), 0xce, 2, ); > > > + pci_direct_conf1.read(0, 0, PCI_DEVFN(0,0), 0xce, 2, ); > > > > couldn't this (at least in

Re: [BUG] skge 0000:02:05: read data parity error

2008-01-14 Thread Adrian Bunk
On Mon, Jan 14, 2008 at 10:41:52PM +0100, Oliver Pinter (Pintér Olivér) wrote: > On 1/14/08, Adrian Bunk <[EMAIL PROTECTED]> wrote: > > On Mon, Jan 14, 2008 at 10:31:03PM +0100, Oliver Pinter (Pintér Olivér) > > wrote: > > > I think, it is a potential security

Re: [BUG] skge 0000:02:05: read data parity error

2008-01-14 Thread Adrian Bunk
On Mon, Jan 14, 2008 at 10:31:03PM +0100, Oliver Pinter (Pintér Olivér) wrote: > I think, it is a potential security breakpoint, when applications with > root permission its read, then a machine is freezed, or only i thin > it's? When you are root there are infinite ways to kill your machine, so

fs/hfs/btree.c: new NULL dereference

2008-01-14 Thread Adrian Bunk
The Coverity checker spotted the following NULL dereference introduced by commit cf0594625083111ae522496dc1c256f7476939c2: <-- snip --> ... struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id, btree_keycmp keycmp) { ... if (!tree->inode) goto free_tree;

libata-scsi.c: new check-after-use

2008-01-14 Thread Adrian Bunk
Commit 9b8e8de7e59b3a2dab3113d620b52dc8ba890fb3 did: --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -872,7 +872,8 @@ int ata_scsi_slave_config(struct scsi_device *sdev) ata_scsi_sdev_config(sdev); - sdev->manage_start_stop = 1; + if (dev->class ==

Re: [BUG] skge 0000:02:05: read data parity error

2008-01-14 Thread Adrian Bunk
On Mon, Jan 14, 2008 at 12:52:00PM -0800, Stephen Hemminger wrote: > On Mon, 14 Jan 2008 20:57:49 +0100 > "Oliver Pinter (Pintér Olivér)" <[EMAIL PROTECTED]> wrote: > > > Hi All! > > > > It is fully reproductable under 2.6.22.15, 2.6.23.13 (all tainted and > > not tainted [4 different kernel] )

Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU

2008-01-14 Thread Adrian Bunk
On Mon, Jan 14, 2008 at 09:27:40PM +0100, Sam Ravnborg wrote: > > > > Can you fix the bug that menuconfig does not let me enable CONFIG_64BIT? > > > > > > make ARCH=x86_64 allyesconfig > > > will set CONFIG_64BIT for you - no? > > > > Yes. > > > > But this still leaves the fact that when

Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU

2008-01-14 Thread Adrian Bunk
On Mon, Jan 14, 2008 at 09:01:26PM +0100, Sam Ravnborg wrote: > On Mon, Jan 14, 2008 at 09:52:58PM +0200, Adrian Bunk wrote: > > On Mon, Jan 14, 2008 at 08:10:09PM +0100, Ingo Molnar wrote: > > > > > > * Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > >

Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU

2008-01-14 Thread Adrian Bunk
On Mon, Jan 14, 2008 at 08:10:09PM +0100, Ingo Molnar wrote: > > * Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > for example, in current -git, could you tell me why this triggers: > > > > > > WARNING: vmlinux.o(.text+0x87e2a): Section mismatch

Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU

2008-01-14 Thread Adrian Bunk
On Mon, Jan 14, 2008 at 04:01:03PM +0100, Ingo Molnar wrote: > > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > Would be great to have them automated - just dunno how to do it. Do > > > you see a feasible way to do it? > > > > a good starting point would be to make the warnings a lot more >

Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU

2008-01-14 Thread Adrian Bunk
On Mon, Jan 14, 2008 at 03:58:54PM +0100, Ingo Molnar wrote: >... > a good way i see is to: >... > - quickly reach a close-to-100%-perfect stage, brute-force. Drop >__init* annotations en masse if they are not perfectly layered. >Whoever reintroduces them will then have to do it

Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU

2008-01-14 Thread Adrian Bunk
On Mon, Jan 14, 2008 at 02:52:40PM +0100, Ingo Molnar wrote: >... > but longer-term, shouldnt these annotations be automated? We'll see a > constant stream of them, all around the clock as people regularly get it > wrong (because it's not intuitive). Definitely. Even more when you looking at

Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU

2008-01-14 Thread Adrian Bunk
On Mon, Jan 14, 2008 at 02:52:40PM +0100, Ingo Molnar wrote: ... but longer-term, shouldnt these annotations be automated? We'll see a constant stream of them, all around the clock as people regularly get it wrong (because it's not intuitive). Definitely. Even more when you looking at what

Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU

2008-01-14 Thread Adrian Bunk
On Mon, Jan 14, 2008 at 08:10:09PM +0100, Ingo Molnar wrote: * Adrian Bunk [EMAIL PROTECTED] wrote: for example, in current -git, could you tell me why this triggers: WARNING: vmlinux.o(.text+0x87e2a): Section mismatch: reference to .init.text: (between 'process_zones

Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU

2008-01-14 Thread Adrian Bunk
On Mon, Jan 14, 2008 at 09:01:26PM +0100, Sam Ravnborg wrote: On Mon, Jan 14, 2008 at 09:52:58PM +0200, Adrian Bunk wrote: On Mon, Jan 14, 2008 at 08:10:09PM +0100, Ingo Molnar wrote: * Adrian Bunk [EMAIL PROTECTED] wrote: for example, in current -git, could you tell me why

Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU

2008-01-14 Thread Adrian Bunk
On Mon, Jan 14, 2008 at 09:27:40PM +0100, Sam Ravnborg wrote: Can you fix the bug that menuconfig does not let me enable CONFIG_64BIT? make ARCH=x86_64 allyesconfig will set CONFIG_64BIT for you - no? Yes. But this still leaves the fact that when someone says 'allyesconfig'

libata-scsi.c: new check-after-use

2008-01-14 Thread Adrian Bunk
Commit 9b8e8de7e59b3a2dab3113d620b52dc8ba890fb3 did: --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -872,7 +872,8 @@ int ata_scsi_slave_config(struct scsi_device *sdev) ata_scsi_sdev_config(sdev); - sdev-manage_start_stop = 1; + if (dev-class ==

Re: [BUG] skge 0000:02:05: read data parity error

2008-01-14 Thread Adrian Bunk
On Mon, Jan 14, 2008 at 12:52:00PM -0800, Stephen Hemminger wrote: On Mon, 14 Jan 2008 20:57:49 +0100 Oliver Pinter (Pintér Olivér) [EMAIL PROTECTED] wrote: Hi All! It is fully reproductable under 2.6.22.15, 2.6.23.13 (all tainted and not tainted [4 different kernel] ) and 2 different

fs/hfs/btree.c: new NULL dereference

2008-01-14 Thread Adrian Bunk
The Coverity checker spotted the following NULL dereference introduced by commit cf0594625083111ae522496dc1c256f7476939c2: -- snip -- ... struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id, btree_keycmp keycmp) { ... if (!tree-inode) goto free_tree; ...

<    3   4   5   6   7   8   9   10   11   12   >