port_dma_req structure members are initialized in
> rio_dma_transfer() immediately after the request structure gets
> allocated.
>
> Signed-off-by: Ioan Nicu <ioan.nicu....@nokia.com>
Tested-by: Alexander Sverdlin <alexander.sverd...@nokia.com>
> ---
> drivers/rapidio/devices
Signed-off-by: Alexander Sverdlin <alexander.sverd...@nokia.com>
---
scripts/recordmcount.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
index 16e086d..a4888e9 100644
--- a/scripts/recordmcount.c
+++ b/scripts/recordmcount
)
[] (load_module) from [] (SyS_finit_module+0x59/0x84)
[] (SyS_finit_module) from [] (ret_fast_syscall+0x1/0x18)
---[ end trace e1b64ced7a89adcd ]---
ftrace failed to modify [] 0xe9ef7006
actual: 02:f0:3b:fa
ftrace record flags: 0
(0) expected tramp: c0314265
Signed-off-by: Alexander Sverdlin <alexander.sv
code
if ARRAY_SIZE(fixed_plts) == 0
v3:
* Only extend struct dyn_arch_ftrace when ARM_MODULE_PLTS is enabled
v2:
* As suggested by Steven Rostedt, refrain from tree-wide API modification,
save module pointer in struct dyn_arch_ftrace instead (PowerPC way)
Alexander Sverdlin (3):
ARM: PLT: Mov
No functional change, later it will be re-used in several files.
Signed-off-by: Alexander Sverdlin <alexander.sverd...@nokia.com>
---
arch/arm/include/asm/module.h | 9 +
arch/arm/kernel/module-plts.c | 9 -
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/ar
Hello Ard,
On 13/03/18 18:32, Alexander Sverdlin wrote:
>>>>> u32 get_module_plt(struct module *mod, unsigned long loc, Elf32_Addr val)
>>>>> {
>>>>> struct mod_plt_
at if it
> is not needed.
Will include it into the next version.
Thanks for the review!
--
Best regards,
Alexander Sverdlin.
)
[] (load_module) from [] (SyS_finit_module+0x59/0x84)
[] (SyS_finit_module) from [] (ret_fast_syscall+0x1/0x18)
---[ end trace e1b64ced7a89adcd ]---
ftrace failed to modify [] 0xe9ef7006
actual: 02:f0:3b:fa
ftrace record flags: 0
(0) expected tramp: c0314265
Signed-off-by: Alexander Sverdlin <alexander.sv
from tree-wide API modification,
save module pointer in dyn ftrace entry struct instead (PowerPC way)
Alexander Sverdlin (2):
ARM: PLT: Move struct plt_entries definition to header
ARM: ftrace: Add MODULE_PLTS support
arch/arm/include/asm/ftrace.h | 1 +
arch/arm/include/asm/module.h | 10
No functional change, later it will be re-used in several files.
Signed-off-by: Alexander Sverdlin <alexander.sverd...@nokia.com>
---
arch/arm/include/asm/module.h | 9 +
arch/arm/kernel/module-plts.c | 9 -
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/ar
Hi!
On 09/10/2018 02:54, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo
>
> The auxtrace.h header references BITS_PER_LONG without including the
> header where it is defined, getting it by luck from some other header,
> fix it.
>
> Cc: Adrian Hunter
>
d if any adjustment
> needs to be done to the tools/{include,arch}/ copies.
>
> Cc: Adrian Hunter
> Cc: Alexander Sverdlin
> Cc: David Ahern
> Cc: Jiri Olsa
> Cc: Namhyung Kim
> Cc: Wang Nan
> Link: https://lkml.kernel.org/n/tip-y1sqyydvfzo0bjjoj4zsl...@gi
t not opposite.
> I'll try and get one for building a x86_64 tools/perf,
> tools/lib/{api,bpf,traceevent} to see if I manage to reproduce the
> problem you're reporting.
--
Best regards,
Alexander Sverdlin.
Hello Arnaldo,
>>>> Em Wed, Sep 12, 2018 at 07:02:32PM +0200, Alexander Sverdlin escreveu:
>>>>> CC .../tools/objtool/builtin-check.o
>>>>> ...
>>>>> In file included from
>>>>> .../tools/arch/x86/include/uapi/a
test building all tools in tools/
>
> This broke make -C tools/perf/
I agree, this brakes perf, so we need to work further on that...
--
Best regards,
Alexander Sverdlin.
On 12/09/2018 21:21, Arnaldo Carvalho de Melo wrote:
> Em Wed, Sep 12, 2018 at 04:01:07PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Wed, Sep 12, 2018 at 07:02:32PM +0200, Alexander Sverdlin escreveu:
>>> CC .../tools/objtool/builtin-check.o
>>> ..
]
#define BITS_PER_LONG (__CHAR_BIT__ * __SIZEOF_LONG__)
Include instead as other headers do.
Signed-off-by: Alexander Sverdlin
---
Seen during x86_64 build. Seems that most of the compilers do not define
__SIZEOF_LONG__, but my does.
tools/include/linux/bitops.h | 5 +
1 file changed, 1
pting to do so on the nodes from FDT -- they are not allocated via
> kzmalloc().
>
> Signed-off-by: Wladislav Wiebe
Acked-by: Alexander Sverdlin
> ---
> drivers/of/fdt.c |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/of/fdt.c b/d
is flag in
> the same way regmap_bulk_read() does, but I think this is pretty ugly.
>
> What do you think about moving the check to use_single_rw inside
> _regmap_raw_read(), right where the bus accesses are done?
>
> Something like in the following patch:
Acked-by: Alexander Sver
1275 of: fdt: fix memory initialization for expanded DT
0640332e of: Fix missing memory initialization on FDT unflattening
92d31610 of/fdt: Remove duplicate memory clearing on FDT unflattening
?
--
Best regards,
Alexander Sverdlin.
--
To unsubscribe from this list: send the line "unsubscrib
Will test the whole series on our MIPS64 platforms
(currently old patchset from bbxm tree is successfully used for a while).
--
Best regards,
Alexander Sverdlin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
which is the case in
overlay_proc_release(), I suppose.
So the call to of_node_clear_flag() is superfluous, but doesn't hurt.
> On Nov 6, 2013, at 10:46 AM, Alexander Sverdlin wrote:
>
>> Hello Pantelis,
>>
>> On 05/11/13 21:03, ext Pantelis Antoniou wrote:
>>> On Nov 5,
on each device to a function.
>
> Signed-off-by: Pantelis Antoniou
We use the "same" patch since kernel 3.10.0, so:
Acked-by: Alexander Sverdlin
Tested-by: Alexander Sverdlin
> ---
> drivers/i2c/i2c-core.c | 99
> +++---
> i
as they are since July on our MIPS64 platforms. So,
for all 5 patches:
Tested-by: Alexander Sverdlin
Reviewed-by: Alexander Sverdlin
> drivers/of/Makefile | 2 +-
> drivers/of/base.c | 77
> drivers/of/util.c | 253
> +
ntoniou
Reviewed-by: Alexander Sverdlin
> ---
> .../devicetree/dynamic-resolution-notes.txt| 25 ++
> drivers/of/Kconfig | 9 +
> drivers/of/Makefile| 1 +
> drivers/of/resolver.c
s.
>
> Note that the I2C client devices are 'special', as in they're not platform
> devices. They need to be registered with an I2C specific method.
>
> In general I2C is just no good platform device citizen and needs
> special casing.
>
> Signed-off-by: Pantelis Antoni
developers. This gives them a way to do so without
> having to recompile the kernel and/or reboot while tinkering.
>
>> Sebastian
>
> Regards
>
> -- Pantelis
>
>
>
--
Best regards,
Alexander Sverdlin.
--
To unsubscribe from this list: send the line "u
rk the property as dynamic */
> + of_property_set_flag(propn, OF_DYNAMIC);
> +
> + return propn;
> +
> +err_fail_value:
> + kfree(propn->name);
> +err_fail_name:
> + kfree(propn);
> + return NULL;
> +}
> +
...
--
Best regards,
Alexander Sver
mark the property as dynamic */
>>> +of_property_set_flag(propn, OF_DYNAMIC);
>>> +
>>> +return propn;
>>> +
>>> +err_fail_value:
>>> +kfree(propn->name);
>>> +err_fail_name:
>>> +kfree(propn);
>>> +re
mply pollute the library and not really satisfy anyone?
I was also irritated re-inventing the wheel here, but the problem is --
millions of people out there have their startup scripts and uboot environments
for phram, who expect this just to work with the next kernel upgrade...
--
Best regards,
Alexan
e
array. Otherwise node will not be correctly assigned and i2c-mux will
have problems selecting right adapter for the multiplexed devices.
> Signed-off-by: Ionut Nicu
So, for the code itself
Acked-by: Alexander Sverdlin
> ---
> drivers/i2c/muxes/i2c-mux-gpio.c |4 ++--
> 1 files c
+struct property *__of_copy_property(const struct property *prop,
> + gfp_t allocflags, unsigned long propflags);
> +struct device_node *__of_create_empty_node(const char *name,
> + const char *type, const char *full_name,
> + phandle phandle, gfp_t allo
return 0;
> }
> [...]
>
> A node is identified as an interrupt controller if it has a zero-length
> property
> called "interrupt-controller" but with a non-NULL value.
>
> My proposed fix for this was to remove the if () condition. prop
ool()
> which returns true or false when the value is defined.
No, it's not bool... It's an existence of a void property.
> The use of of_get_property is a bug here. It is perfectly valid for a
> property to have a
> NULL value when length = 0.
of_find_property() would be really
)
[] (load_module) from [] (SyS_finit_module+0x59/0x84)
[] (SyS_finit_module) from [] (ret_fast_syscall+0x1/0x18)
---[ end trace e1b64ced7a89adcd ]---
ftrace failed to modify [] 0xe9ef7006
actual: 02:f0:3b:fa
ftrace record flags: 0
(0) expected tramp: c0314265
Signed-off-by: Alexander Sverdlin
---
arch/arm
from tree-wide API modification,
save module pointer in dyn ftrace entry struct instead (PowerPC way)
Alexander Sverdlin (2):
ARM: PLT: Move struct plt_entries definition to header
ARM: ftrace: Add MODULE_PLTS support
arch/arm/include/asm/ftrace.h | 1 +
arch/arm/include/asm/module.h | 10
No functional change, later it will be re-used in several files.
Signed-off-by: Alexander Sverdlin
---
arch/arm/include/asm/module.h | 9 +
arch/arm/kernel/module-plts.c | 9 -
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm/include/asm/module.h b/arch
)
[] (load_module) from [] (SyS_finit_module+0x59/0x84)
[] (SyS_finit_module) from [] (ret_fast_syscall+0x1/0x18)
---[ end trace e1b64ced7a89adcd ]---
ftrace failed to modify [] 0xe9ef7006
actual: 02:f0:3b:fa
ftrace record flags: 0
(0) expected tramp: c0314265
Signed-off-by: Alexander Sverdlin
---
arch/arm
modification,
save module pointer in struct dyn_arch_ftrace instead (PowerPC way)
Alexander Sverdlin (2):
ARM: PLT: Move struct plt_entries definition to header
ARM: ftrace: Add MODULE_PLTS support
arch/arm/include/asm/ftrace.h | 3 +++
arch/arm/include/asm/module.h | 10 +++
arch/arm
No functional change, later it will be re-used in several files.
Signed-off-by: Alexander Sverdlin
---
arch/arm/include/asm/module.h | 9 +
arch/arm/kernel/module-plts.c | 9 -
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm/include/asm/module.h b/arch
e.
>> + if (!pltsec->plt_count)
>> + prealloc_fixed(pltsec, plt);
I'll prepare v5 based on your other comments.
--
Best regards,
Alexander Sverdlin.
;
> This means that you are relying on get_module_plt() being called at
> least once at module load time, which is not guaranteed.
This is indeed guaranteed. For FTRACE use case. If it's being called from
FTRACE in
run time, this would mean there were long calls in this module section, which in
turn means, get_module_plt() was called at least once for this module and this
section.
This doesn't hold in general, though.
In any case, if you insist, I can try to rework the whole stuff implementing
module_finalize().
--
Best regards,
Alexander Sverdlin.
On 13/03/18 18:39, Ard Biesheuvel wrote:
> if (IS_ENABLED(CONFIG_ARM_MODULE_PLTS))
> module_plt_alloc_fixed();
Do you consider this a legal C code if without module-plts.o the function would
not exist at all?
That's too much relying on optimizer I think...
--
Best regards,
Ale
bol
references, etc). Thus, you still have to use an #ifdef if the code inside the
block references symbols that will not exist if the condition is not met."
But we can of course ignore it.
--
Best regards,
Alexander Sverdlin.
n any case, if you insist, I can try to rework the whole stuff implementing
>> module_finalize().
>>
> I think it would be much better to use the module_finalize() hook for
> this, given that it is only called once already, and all the data you
> need is still available.
No problem, but some kind of (*) block would still be required, because
get_module_plt() has to work after module_finalize() as well as *before* it.
So before module_finalize() we would have to dereference pltsec->plt->sh_addr
conditionally.
> Note that ARM already has such a function, so you'll need to add a
> call there, i.e.,
>
> if (IS_ENABLED(CONFIG_ARM_MODULE_PLTS))
> module_plt_alloc_fixed();
>
> or something like that. The CONFIG_FTRACE dependency can be kept local
> to module-plts.c
>
--
Best regards,
Alexander Sverdlin.
Hello Ard,
On 13/03/18 18:32, Alexander Sverdlin wrote:
>>>>> u32 get_module_plt(struct module *mod, unsigned long loc, Elf32_Addr val)
>>>>> {
>>>>> struct mod_plt_
)
[] (load_module) from [] (SyS_finit_module+0x59/0x84)
[] (SyS_finit_module) from [] (ret_fast_syscall+0x1/0x18)
---[ end trace e1b64ced7a89adcd ]---
ftrace failed to modify [] 0xe9ef7006
actual: 02:f0:3b:fa
ftrace record flags: 0
(0) expected tramp: c0314265
Signed-off-by: Alexander Sverdlin
---
arch/arm
ARM_MODULE_PLTS is enabled
v2:
* As suggested by Steven Rostedt, refrain from tree-wide API modification,
save module pointer in struct dyn_arch_ftrace instead (PowerPC way)
Alexander Sverdlin (2):
ARM: PLT: Move struct plt_entries definition to header
ARM: ftrace: Add MODULE_PLTS support
No functional change, later it will be re-used in several files.
Change-Id: Icfa32669b3582d713b3ad680c25620d3d4844bdd
Signed-off-by: Alexander Sverdlin
---
arch/arm/include/asm/module.h | 9 +
arch/arm/kernel/module-plts.c | 9 -
2 files changed, 9 insertions(+), 9 deletions
+ plt = pltsec->plt_ent;
>>
>> - struct plt_entries *plt = (struct plt_entries *)pltsec->plt->sh_addr;
>> - int idx = 0;
>> + idx = ARRAY_SIZE(fixed_plts);
>> + while (idx)
>> + if (plt->lit[--idx] == val)
>> + return (u32)>ldr[idx];
>>
> Same here.
--
Best regards,
Alexander Sverdlin.
> Thus remove them.
>
> Signed-off-by: Markus Elfring
Reviewed-by: Alexander Sverdlin
> ---
> arch/cris/arch-v32/drivers/cryptocop.c | 14 --
> 1 file changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/arch/cris/arch-v32/drivers/cryptocop.c
> b/a
n tickless core and with following applied:
>
> sched/nohz: add debugfs control over sched_tick_max_deferment
> https://lkml.org/lkml/2013/9/16/499
>
> Signed-off-by: Matija Glavinic Pecotic
Reviewed-by: Alexander Sverdlin
> ---
> kernel/time/timer.c | 2 +-
apper), GFP_KERNEL);
> if (!wrapper) {
> - printk(KERN_ERR "Unable to allocate CRISv32 NAND MTD "
> - "device structure.\n");
> err = -ENOMEM;
> return NULL;
> }
--
Alexander Sverdlin.
On 04/10/17 20:45, SF Markus Elfring wrote:
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring
Reviewed-by: Alexander Sverdlin
> ---
> arch/cris/arc
On 04/10/17 20:48, SF Markus Elfring wrote:
> The local variable "err" was never read in this function.
> Thus remove it.
>
> Signed-off-by: Markus Elfring
Reviewed-by: Alexander Sverdlin
> ---
> arch/cris/arch-v32/drivers/mach-a3/nandflash.c | 6 +-
> arc
Hello Markus,
On 04/10/17 20:50, SF Markus Elfring wrote:
> * Split a condition check for failed calls of the function "ioremap"
> so that the return value in the variable "write_cs" will also be
> immediately checked.
>
> * Adjust jump targets according to the Linux coding style convention.
till possess the Octeon MIPS64
> platform to test the patchset?
yes, I'd like to test such a serious change on Octeon2. Please include me in
the distribution list.
--
Best regards,
Alexander Sverdlin.
Hi!
On Wed Dec 20 13:50:28 2017 Arnd Bergmann wrote:
> I'm generally more interested in the multiplatform conversion than
> the DT conversion, and I think converting this one to multiplatform
> isn't actually that hard, and doesn't have a significant risk for
> regressions, the main work is to
Hi Arnd!
On Wed Dec 20 14:14:07 2017 Arnd Bergmann wrote:
> > If it will be still possible to build the binary kernel of the same
> > size after the conversion, I'm in for testing, otherwise it will not
> > fit into Flash any more...
>
> I think there is an increase in code size that comes
Hi!
On Mon Dec 18 12:55:40 2017 Arnd Bergmann wrote:
> > GCC 7.2 is working
>
> Ah wait, this is still for ep93xx, which is always at least armv4t,
> right? So it won't have a problem with the armv4 deprecation anyway, even
Correct.
--
Alex.
Hello Lukasz!
On 17/11/17 00:22, Lukasz Majewski wrote:
> This patch series adds support for Liebherr's BK3 board, being
> a derivative of TS72XX design.
>
> This patchset consists of following patches:
>
> - ts72xx.[c|h] cosmetic cleanup/improvement
> - Move the common code for ts72xx and BK3
port_dma_req structure members are initialized in
> rio_dma_transfer() immediately after the request structure gets
> allocated.
>
> Signed-off-by: Ioan Nicu
Tested-by: Alexander Sverdlin
> ---
> drivers/rapidio/devices/rio_mport_cdev.c | 19 +--
> 1 file change
)
[] (load_module) from [] (SyS_finit_module+0x59/0x84)
[] (SyS_finit_module) from [] (ret_fast_syscall+0x1/0x18)
---[ end trace e1b64ced7a89adcd ]---
ftrace failed to modify [] 0xe9ef7006
actual: 02:f0:3b:fa
ftrace record flags: 0
(0) expected tramp: c0314265
Signed-off-by: Alexander Sverdlin
---
arch/arm
code
if ARRAY_SIZE(fixed_plts) == 0
v3:
* Only extend struct dyn_arch_ftrace when ARM_MODULE_PLTS is enabled
v2:
* As suggested by Steven Rostedt, refrain from tree-wide API modification,
save module pointer in struct dyn_arch_ftrace instead (PowerPC way)
Alexander Sverdlin (3):
ARM: PLT: Mov
No functional change, later it will be re-used in several files.
Signed-off-by: Alexander Sverdlin
---
arch/arm/include/asm/module.h | 9 +
arch/arm/kernel/module-plts.c | 9 -
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm/include/asm/module.h b/arch
Signed-off-by: Alexander Sverdlin
---
scripts/recordmcount.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
index 16e086d..a4888e9 100644
--- a/scripts/recordmcount.c
+++ b/scripts/recordmcount.c
@@ -53,6 +53,10 @@
#define R_A
No functional change, later it will be re-used in several files.
Signed-off-by: Alexander Sverdlin
---
arch/arm/include/asm/module.h | 9 +
arch/arm/kernel/module-plts.c | 9 -
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm/include/asm/module.h b/arch
: ftrace: don't validate branch via PLT in ftrace_make_nop()
But the presented ARM variant has just a half of the footprint in terms of
the changed LoCs. It also retains the code validation-before-modification
instead of switching it off.
Alexander Sverdlin (3):
ftrace: Add module
)
[] (load_module) from [] (SyS_finit_module+0x59/0x84)
[] (SyS_finit_module) from [] (ret_fast_syscall+0x1/0x18)
---[ end trace e1b64ced7a89adcd ]---
ftrace failed to modify [] 0xe9ef7006
actual: 02:f0:3b:fa
ftrace record flags: 0
(0) expected tramp: c0314265
Signed-off-by: Alexander Sverdlin
---
arch/arm
ARM support for modules' PLTs will require a module pointer in
ftrace_make_call() exactly as ftrace_make_nop() has it. Change the function
signature without functional change for now.
Signed-off-by: Alexander Sverdlin
---
arch/arm/kernel/ftrace.c | 3 ++-
arch/arm64/kernel/ftrace.c
On 01/02/18 17:24, SF Markus Elfring wrote:
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring
Reviewed-by: Alexander Sverdlin
> ---
> drivers/i2c/mu
at if it
> is not needed.
Will include it into the next version.
Thanks for the review!
--
Best regards,
Alexander Sverdlin.
4/1: ep93xx: initial implementation of the
> clk_* API")
> Cc: Hartley Sweeten
> Cc: Alexander Sverdlin
> Cc: Russell King
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Reported-by: Mathias Kresin
> Signed-off-by: Jonas Gorski
Acked-by: A
to hardcode the address anyway.
>
> Signed-off-by: Arnd Bergmann
Acked-by: Alexander Sverdlin
> ---
> arch/arm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index d6e6f40addf6..db856355bd24 100
Hello Hartley,
On 05/12/17 19:14, Hartley Sweeten wrote:
>> This patch series adds support for Liebherr's BK3 board, being a derivative
>> of TS72XX design.
>>
>> This patchset consists of following patches:
>>
>> - ts72xx.[c|h] cosmetic cleanup/improvement
>> - Rewrite ts72xx.c to be reusable
Hi!
On 21/11/17 15:31, Lukasz Majewski wrote:
> This commit cleans up the code by using dedicated macros instead of
> full definitions.
>
> Signed-off-by: Lukasz Majewski
Acked-by: Alexander Sverdlin
> ---
> Changes for v2:
> - None
> ---
> arch/ar
Hi!
On 21/11/17 15:32, Lukasz Majewski wrote:
> This commit adds include file guards to ts72xx.h
>
> Signed-off-by: Lukasz Majewski
Acked-by: Alexander Sverdlin
> ---
> Changes for v2:
> - None
> ---
> arch/arm/mach-ep93xx/ts72xx.h | 4
> 1 file changed, 4 in
Hi!
On 21/11/17 15:32, Lukasz Majewski wrote:
> The map IO common code has been excluded to be reused by other ts72xx
> clones.
>
> Signed-off-by: Lukasz Majewski
Acked-by: Alexander Sverdlin
>
> ---
> Changes for v2:
> - New patch
> ---
> arch
Hello Lukasz,
some nitpicking below...
On 21/11/17 15:32, Lukasz Majewski wrote:
> The BK3 board is a derivative of the ts72xx reference design.
>
> Signed-off-by: Lukasz Majewski
> ---
> Changes for v2:
> - Place bk3 support code to the ts72xx.c file
> ---
> arch/arm/mach-ep93xx/Kconfig |
Hi!
On 21/11/17 15:32, Lukasz Majewski wrote:
> This commit extend the ts72xx_register_flash() to accept passed parameters,
> which makes it more reusable.
>
> Now it is possible to accept ep93xx flash start address and partitions.
>
> Signed-off-by: Lukasz Majewski
A
t...
>
> Even more. checkpatch.pl did not complained
checkpatch.pl wouldn't complain, as there are basically two styles,
some people do not align the individual assignments in the structures at all.
But I was quite confident in the beginning and now even applied your v3 to
the code. And indeed it's unaligned... I even checked with emacs. Still
unaligned.
--
Alexander Sverdlin.
t; +**/
>
> There is also something funny with the patch. The lines above appear to be
> getting split incorrectly.
That's definitely not the case, I can apply the patch to 4.14 just fine and
there is no funny wrapping. But you are right about the rest, it should be
re-based.
--
Alexander Sverdlin.
mmit 681fbec881 brought a
regression, rendering 20fb654ae fix ineffective.
But this is not related to your change, which I believe is correct:
Reviewed-by: Alexander Sverdlin
> ---
> tools/include/linux/lockdep.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/t
Hello Linus!
On Wed Dec 13 08:34:22 2017 Linus Walleij wrote:
> On Tue, Dec 12, 2017 at 12:36 AM, Lukasz Majewski wrote:
> Out of curiosity: Liebherr is obviously doing heavy-duty industrial
> control systems. Likewise Hartley is doing similar business over
> at Vision Engravings.
>
> Is the
Hello Tudor,
On 07/10/2020 10:48, tudor.amba...@microchip.com wrote:
>> From: Alexander Sverdlin
>>
>> spi_nor_parse_sfdp() modifies the passed structure so that it points to
>> itself (params.erase_map.regions to params.erase_map.uniform_region). This
>> makes i
access of MDR1. After removing the
read access from omap_8250_mdr1_errataset() the data corruption never
happened any more.
Link: https://www.ti.com/lit/er/sprz360i/sprz360i.pdf
Fixes: 61929cf0169d ("tty: serial: Add 8250-core based omap driver")
Cc: sta...@vger.kernel.org
Signed-off-by: Ale
eck_kernel_sections_mem() method can be removed. But it
> should be done carefully. We at least need to try to find all the
> platforms, which rely on its functionality.
Thanks for looking into this! I agree with your analysis, I'll try to rework,
removing check_kernel_sections_mem().
--
Best regards,
Alexander Sverdlin.
at's why we only noticed recently, that
is breaks Octeon platform.
--
Best regards,
Alexander Sverdlin.
atforms this patch is required for?
--
Best regards,
Alexander Sverdlin.
Hello Serge, Thomas,
On 13/11/2020 10:17, Alexander Sverdlin wrote:
>> So IMHO what could be the best conclusion in the framework of this patch:
>> 1) As Thomas said any platform-specific reservation should be done in the
>> platform-specific code. That means if octeon needs
em()).
As I understood, the issue is that memblock API operates internally on the
page granularity (at least there are many ROUND_DOWN() inside for the size
or upper boundary), so for request_resource() to success one has to claim
the rest of the .bss last page. And with current memblock API
memblock_reserve() must appear somewhere, being this ARCH or platform code.
--
Best regards,
Alexander Sverdlin.
ims
the rest of the last page,
and I'm going to fix this).
--
Best regards,
Alexander Sverdlin.
s390-linux-ld: drivers/char/hw_random/ks-sa-rng.o: in function
>> `ks_sa_rng_probe':
>>>> ks-sa-rng.c:(.text+0x2fa): undefined reference to
>>>> `devm_platform_ioremap_resource'
>
> ---8<---
> This patch adds a dependency for KEYSTONE on HAS_IOMEM and OF
Hello Wang!
On Fri, 2020-11-06 at 09:46 +0800, Wang Qing wrote:
> The input parameter of clk_get_rate() is checked with IS_ERR(),
> so here we need to check null on clk.
Thank you for the patch!
> Signed-off-by: Wang Qing
Acked-by: Alexander Sverdlin
> ---
> arch/arm/mach-ep9
emblock
allocator and re-used somewhere in Linux is in MIPS-generic
check_kernel_sections_mem().
I personally will be fine with repairing Octeon only as I don't have other MIPS
targets to care about, but maybe someone else in the MIPS community will find
this fix useful...
--
Best regards,
Alexander Sverdlin.
Hi Thomas,
On 09/11/2020 11:34, Alexander Sverdlin wrote:
>>> Linux doesn't own the memory immediately after the kernel image. On Octeon
>>> bootloader places a shared structure right close after the kernel _end,
>>> refer to "struct cvmx_bootinfo *octeon_bo
+ for (i = 0; i < ARRAY_SIZE(girq->parents); i++) {
Why do you use ARRAY_SIZE() here instead of ->num_parents like above?
> + girq->parents[i] = platform_get_irq(pdev, i +
> 1);
> gpio_irq = EP93XX_GPIO_F_IRQ_BASE + i;
> irq_set_chip_data(gpio_irq, >gc[5]);
> irq_set_chip_and_handler(gpio_irq,
--
Alexander Sverdlin.
Hi!
On Wed, 2021-01-27 at 13:46 +0300, Nikita Shubin wrote:
> Fix typo in comment.
>
> Signed-off-by: Nikita Shubin
Acked-by: Alexander Sverdlin
> ---
> drivers/gpio/gpio-ep93xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio
Hi!
On Wed, 2021-01-27 at 13:46 +0300, Nikita Shubin wrote:
> As ->to_irq is redefined in gpiochip_add_irqchip, having it defined
> in
> driver is useless, so let's drop it.
>
> Signed-off-by: Nikita Shubin
Reviewed-by: Alexander Sverdlin
> ---
> drivers/gpio/gpio-
.
This option can probably simplify the handling of the names
for irq chips as well.
> 28.01.2021, 19:19, "Alexander Sverdlin" :
> > Hello Nikita,
> >
> > On Thu, 2021-01-28 at 18:11 +0200, Andy Shevchenko wrote:
> > > > +/*
> > > > + * F Port
101 - 200 of 318 matches
Mail list logo
