Re: [PATCH 1/4] ARM: dts: exynos: Add missing used PMIC regulators on Exynos5422 Odroid boards

hi Krzysztof, On Mon, 13 Aug 2018 at 12:43, Krzysztof Kozlowski wrote: > > On 13 August 2018 at 08:37, Anand Moon wrote: > > Hi Krzysztof, > > > > On Sun, 12 Aug 2018 at 18:55, Krzysztof Kozlowski wrote: > >> > >> On 11 August 2018 at 08:

Re: [PATCH 1/4] ARM: dts: exynos: Add missing used PMIC regulators on Exynos5422 Odroid boards

hi Krzysztof, On Mon, 13 Aug 2018 at 12:43, Krzysztof Kozlowski wrote: > > On 13 August 2018 at 08:37, Anand Moon wrote: > > Hi Krzysztof, > > > > On Sun, 12 Aug 2018 at 18:55, Krzysztof Kozlowski wrote: > >> > >> On 11 August 2018 at 08:

Re: [PATCH 1/4] ARM: dts: exynos: Add missing used PMIC regulators on Exynos5422 Odroid boards

Hi Krzysztof, On Sun, 12 Aug 2018 at 18:55, Krzysztof Kozlowski wrote: > > On 11 August 2018 at 08:39, Anand Moon wrote: > > Hi Krzysztof, > > > > These patches should also be ported to u-boot to enable PMIC. > > > > I was just looking into S2MPS11B dat

Re: [PATCH 1/4] ARM: dts: exynos: Add missing used PMIC regulators on Exynos5422 Odroid boards

Hi Krzysztof, On Sun, 12 Aug 2018 at 18:55, Krzysztof Kozlowski wrote: > > On 11 August 2018 at 08:39, Anand Moon wrote: > > Hi Krzysztof, > > > > These patches should also be ported to u-boot to enable PMIC. > > > > I was just looking into S2MPS11B dat

Re: [PATCH 1/4] ARM: dts: exynos: Add missing used PMIC regulators on Exynos5422 Odroid boards

Hi Krzysztof, These patches should also be ported to u-boot to enable PMIC. I was just looking into S2MPS11B data sheet According to the 1.2 Key Features of S2MPS11 BUCK1, BUCK2, BUCK3, BUCK4, BUCK6 have (0.65 V to 1.6 V) min /max range. BUCK5 have (0.65 V to 2.0 V) min /max range. BUCK7 have

Re: [PATCH 1/4] ARM: dts: exynos: Add missing used PMIC regulators on Exynos5422 Odroid boards

Hi Krzysztof, These patches should also be ported to u-boot to enable PMIC. I was just looking into S2MPS11B data sheet According to the 1.2 Key Features of S2MPS11 BUCK1, BUCK2, BUCK3, BUCK4, BUCK6 have (0.65 V to 1.6 V) min /max range. BUCK5 have (0.65 V to 2.0 V) min /max range. BUCK7 have

Re: [PATCH v2 4/4] ARM: exynos: Fix imprecise abort during Exynos5422 suspend to RAM

Hi Krzysztof, On 26 July 2018 at 12:10, Krzysztof Kozlowski wrote: > On 26 July 2018 at 08:22, Anand Moon wrote: >> Hi Krzysztof, >> >> On 24 July 2018 at 22:19, Krzysztof Kozlowski wrote: >>> Suspend to RAM on Odroid XU3/XU4/HC1 family (Exynos54

Re: [PATCH v2 4/4] ARM: exynos: Fix imprecise abort during Exynos5422 suspend to RAM

Hi Krzysztof, On 26 July 2018 at 12:10, Krzysztof Kozlowski wrote: > On 26 July 2018 at 08:22, Anand Moon wrote: >> Hi Krzysztof, >> >> On 24 July 2018 at 22:19, Krzysztof Kozlowski wrote: >>> Suspend to RAM on Odroid XU3/XU4/HC1 family (Exynos54

Re: [PATCH 1/5] thermal: exynos: enable core tmu clk on exynos platform

Hi Krzysztof, On 18 July 2018 at 15:36, Krzysztof Kozlowski wrote: > On 18 July 2018 at 11:24, Anand Moon wrote: >> Hi Krzysztof >> >> On 18 July 2018 at 11:47, Krzysztof Kozlowski wrote: >>> On 17 July 2018 at 22:23, Anand Moon wrote: >>>> Hi Kr

Re: [PATCH 1/5] thermal: exynos: enable core tmu clk on exynos platform

Hi Krzysztof, On 18 July 2018 at 15:36, Krzysztof Kozlowski wrote: > On 18 July 2018 at 11:24, Anand Moon wrote: >> Hi Krzysztof >> >> On 18 July 2018 at 11:47, Krzysztof Kozlowski wrote: >>> On 17 July 2018 at 22:23, Anand Moon wrote: >>>> Hi Kr

Re: [PATCHv2] ARM: dts: exynos5: add missing interrupts for pwm node

Hi Krzysztof, On 18 July 2018 at 19:25, Krzysztof Kozlowski wrote: > On 18 July 2018 at 14:59, Anand Moon wrote: >> Add missing GIC interrupts property for pwm nodes. >> >> Signed-off-by: Anand Moon >> --- >> Fixed the patch indentation issue with all tabs. >

Re: [PATCHv2] ARM: dts: exynos5: add missing interrupts for pwm node

Hi Krzysztof, On 18 July 2018 at 19:25, Krzysztof Kozlowski wrote: > On 18 July 2018 at 14:59, Anand Moon wrote: >> Add missing GIC interrupts property for pwm nodes. >> >> Signed-off-by: Anand Moon >> --- >> Fixed the patch indentation issue with all tabs. >

Re: [PATCH] ARM: dts: exynos5: add missing interrupts for pwm node

Hi Krzysztof On 18 July 2018 at 17:25, Krzysztof Kozlowski wrote: > On 18 July 2018 at 12:50, Anand Moon wrote: >> Hi Krzysztof, >> >> On 18 July 2018 at 16:03, Krzysztof Kozlowski wrote: >>> On 18 July 2018 at 12:30, Anand Moon wrote: >>>> Hi >

Re: [PATCH] ARM: dts: exynos5: add missing interrupts for pwm node

Hi Krzysztof On 18 July 2018 at 17:25, Krzysztof Kozlowski wrote: > On 18 July 2018 at 12:50, Anand Moon wrote: >> Hi Krzysztof, >> >> On 18 July 2018 at 16:03, Krzysztof Kozlowski wrote: >>> On 18 July 2018 at 12:30, Anand Moon wrote: >>>> Hi >

[PATCHv2] ARM: dts: exynos5: add missing interrupts for pwm node

Add missing GIC interrupts property for pwm nodes. Signed-off-by: Anand Moon --- Fixed the patch indentation issue with all tabs. sorry checkpatch could not figure out the error. --- arch/arm/boot/dts/exynos5.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts

[PATCHv2] ARM: dts: exynos5: add missing interrupts for pwm node

Add missing GIC interrupts property for pwm nodes. Signed-off-by: Anand Moon --- Fixed the patch indentation issue with all tabs. sorry checkpatch could not figure out the error. --- arch/arm/boot/dts/exynos5.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts

Re: [PATCH] ARM: dts: exynos5: add missing interrupts for pwm node

Hi Krzysztof, On 18 July 2018 at 16:03, Krzysztof Kozlowski wrote: > On 18 July 2018 at 12:30, Anand Moon wrote: >> Hi >> >> On 18 July 2018 at 15:27, Krzysztof Kozlowski wrote: >>> On 18 July 2018 at 11:34, Anand Moon wrote: >>>> Add mis

Re: [PATCH] ARM: dts: exynos5: add missing interrupts for pwm node

Hi Krzysztof, On 18 July 2018 at 16:03, Krzysztof Kozlowski wrote: > On 18 July 2018 at 12:30, Anand Moon wrote: >> Hi >> >> On 18 July 2018 at 15:27, Krzysztof Kozlowski wrote: >>> On 18 July 2018 at 11:34, Anand Moon wrote: >>>> Add mis

Re: [PATCH] ARM: dts: exynos5: add missing interrupts for pwm node

Hi On 18 July 2018 at 15:27, Krzysztof Kozlowski wrote: > On 18 July 2018 at 11:34, Anand Moon wrote: >> Add missing GIC interrupts property for pwm nodes. >> >> Signed-off-by: Anand Moon >> --- >> arch/arm/boot/dts/exynos5.dtsi | 5 + >> 1 file ch

Re: [PATCH] ARM: dts: exynos5: add missing interrupts for pwm node

Hi On 18 July 2018 at 15:27, Krzysztof Kozlowski wrote: > On 18 July 2018 at 11:34, Anand Moon wrote: >> Add missing GIC interrupts property for pwm nodes. >> >> Signed-off-by: Anand Moon >> --- >> arch/arm/boot/dts/exynos5.dtsi | 5 + >> 1 file ch

[PATCH] ARM: dts: exynos5: add missing interrupts for pwm node

Add missing GIC interrupts property for pwm nodes. Signed-off-by: Anand Moon --- arch/arm/boot/dts/exynos5.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi index 5d2f0a0..9406108 100644 --- a/arch/arm/boot/dts/exynos5

[PATCH] ARM: dts: exynos5: add missing interrupts for pwm node

Add missing GIC interrupts property for pwm nodes. Signed-off-by: Anand Moon --- arch/arm/boot/dts/exynos5.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi index 5d2f0a0..9406108 100644 --- a/arch/arm/boot/dts/exynos5

Re: [PATCH 1/5] thermal: exynos: enable core tmu clk on exynos platform

Hi Krzysztof On 18 July 2018 at 11:47, Krzysztof Kozlowski wrote: > On 17 July 2018 at 22:23, Anand Moon wrote: >> Hi Krzysztof >> >> On 17 July 2018 at 17:50, Krzysztof Kozlowski wrote: >>> Hi Anand, >>> >>> Thanks for patch. >

Re: [PATCH 1/5] thermal: exynos: enable core tmu clk on exynos platform

Hi Krzysztof On 18 July 2018 at 11:47, Krzysztof Kozlowski wrote: > On 17 July 2018 at 22:23, Anand Moon wrote: >> Hi Krzysztof >> >> On 17 July 2018 at 17:50, Krzysztof Kozlowski wrote: >>> Hi Anand, >>> >>> Thanks for patch. >

Re: [PATCH 1/5] thermal: exynos: enable core tmu clk on exynos platform

Hi Krzysztof On 17 July 2018 at 17:50, Krzysztof Kozlowski wrote: > Hi Anand, > > Thanks for patch. > > On 17 July 2018 at 12:12, Anand Moon wrote: >> clk_summary do not show tmu_apbif clk enable, so replace >> the clk_prepare with clk_prepare_enables to enable tmu

Re: [PATCH 1/5] thermal: exynos: enable core tmu clk on exynos platform

Hi Krzysztof On 17 July 2018 at 17:50, Krzysztof Kozlowski wrote: > Hi Anand, > > Thanks for patch. > > On 17 July 2018 at 12:12, Anand Moon wrote: >> clk_summary do not show tmu_apbif clk enable, so replace >> the clk_prepare with clk_prepare_enables to enable tmu

Re: [PATCH 2/5] thermal: exynos: cleanup of clk err check for exynos_tmu_work

Hi Krzysztof, On 17 July 2018 at 17:54, Krzysztof Kozlowski wrote: > On 17 July 2018 at 12:12, Anand Moon wrote: >> cleanup err check in exynos_tmu_work as clk internal >> framework will perform if clk is enable/disable >> so drop the double check of IS_ERR and other such

Re: [PATCH 2/5] thermal: exynos: cleanup of clk err check for exynos_tmu_work

Hi Krzysztof, On 17 July 2018 at 17:54, Krzysztof Kozlowski wrote: > On 17 July 2018 at 12:12, Anand Moon wrote: >> cleanup err check in exynos_tmu_work as clk internal >> framework will perform if clk is enable/disable >> so drop the double check of IS_ERR and other such

Re: [PATCH 3/5] thermal: exynos: increase the number of trips for exynos542x

Hi Krzysztof, On 17 July 2018 at 17:55, Krzysztof Kozlowski wrote: > On 17 July 2018 at 12:12, Anand Moon wrote: >> increase the number of trips to support more polling modes, >> changes help supress following warning. >> >> [4.231731] thermal thermal_zone0: fail

Re: [PATCH 3/5] thermal: exynos: increase the number of trips for exynos542x

Hi Krzysztof, On 17 July 2018 at 17:55, Krzysztof Kozlowski wrote: > On 17 July 2018 at 12:12, Anand Moon wrote: >> increase the number of trips to support more polling modes, >> changes help supress following warning. >> >> [4.231731] thermal thermal_zone0: fail

Re: [PATCH 4/5] thermal: exynos: fixed the efuse min/max value for exynos5422

Hi Krzysztof, On 17 July 2018 at 17:58, Krzysztof Kozlowski wrote: > On 17 July 2018 at 12:12, Anand Moon wrote: >> e-fuse range min~max range is 16~76. if e-fuse value is out of > > s/e-fuse/Fuse/ > s/if/If/ > > Can you share the sources confirming that fuse valu

Re: [PATCH 4/5] thermal: exynos: fixed the efuse min/max value for exynos5422

Hi Krzysztof, On 17 July 2018 at 17:58, Krzysztof Kozlowski wrote: > On 17 July 2018 at 12:12, Anand Moon wrote: >> e-fuse range min~max range is 16~76. if e-fuse value is out of > > s/e-fuse/Fuse/ > s/if/If/ > > Can you share the sources confirming that fuse valu

Re: [PATCH 5/5] ARM: dts: exynos: add tmu aliases nodes

Hi On 17 July 2018 at 17:59, Krzysztof Kozlowski wrote: > On 17 July 2018 at 12:12, Anand Moon wrote: >> add tmuctrl aliases node for exynos542x > > Please use full sentence, starting with capital letter and ending with > a dot. Also please explain why you need tmuctrl aliases

Re: [PATCH 5/5] ARM: dts: exynos: add tmu aliases nodes

Hi On 17 July 2018 at 17:59, Krzysztof Kozlowski wrote: > On 17 July 2018 at 12:12, Anand Moon wrote: >> add tmuctrl aliases node for exynos542x > > Please use full sentence, starting with capital letter and ending with > a dot. Also please explain why you need tmuctrl aliases

[PATCH 2/5] thermal: exynos: cleanup of clk err check for exynos_tmu_work

cleanup err check in exynos_tmu_work as clk internal framework will perform if clk is enable/disable so drop the double check of IS_ERR and other such references. CC: Bartlomiej Zolnierkiewicz Signed-off-by: Anand Moon --- drivers/thermal/samsung/exynos_tmu.c | 19 ++- 1 file

[PATCH 3/5] thermal: exynos: increase the number of trips for exynos542x

) CC: Bartlomiej Zolnierkiewicz Signed-off-by: Anand Moon --- drivers/thermal/samsung/exynos_tmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 2dbde97..4a2733c 100644 --- a/drivers/thermal

[PATCH 5/5] ARM: dts: exynos: add tmu aliases nodes

add tmuctrl aliases node for exynos542x CC: Bartlomiej Zolnierkiewicz Signed-off-by: Anand Moon --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 8 arch/arm/boot/dts/exynos5420.dtsi | 20 arch/arm/boot/dts/exynos5422-odroid-core.dtsi

[PATCH 1/5] thermal: exynos: enable core tmu clk on exynos platform

clk_summary do not show tmu_apbif clk enable, so replace the clk_prepare with clk_prepare_enables to enable tmu clk. simplify the enable of tmu_triminfo_apbif clk, also fixed the order of goto error for failed cases. CC: Bartlomiej Zolnierkiewicz Signed-off-by: Anand Moon --- before: cat /sys

[PATCH 2/5] thermal: exynos: cleanup of clk err check for exynos_tmu_work

cleanup err check in exynos_tmu_work as clk internal framework will perform if clk is enable/disable so drop the double check of IS_ERR and other such references. CC: Bartlomiej Zolnierkiewicz Signed-off-by: Anand Moon --- drivers/thermal/samsung/exynos_tmu.c | 19 ++- 1 file

[PATCH 3/5] thermal: exynos: increase the number of trips for exynos542x

) CC: Bartlomiej Zolnierkiewicz Signed-off-by: Anand Moon --- drivers/thermal/samsung/exynos_tmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 2dbde97..4a2733c 100644 --- a/drivers/thermal

[PATCH 5/5] ARM: dts: exynos: add tmu aliases nodes

add tmuctrl aliases node for exynos542x CC: Bartlomiej Zolnierkiewicz Signed-off-by: Anand Moon --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 8 arch/arm/boot/dts/exynos5420.dtsi | 20 arch/arm/boot/dts/exynos5422-odroid-core.dtsi

[PATCH 1/5] thermal: exynos: enable core tmu clk on exynos platform

clk_summary do not show tmu_apbif clk enable, so replace the clk_prepare with clk_prepare_enables to enable tmu clk. simplify the enable of tmu_triminfo_apbif clk, also fixed the order of goto error for failed cases. CC: Bartlomiej Zolnierkiewicz Signed-off-by: Anand Moon --- before: cat /sys

[PATCH 4/5] thermal: exynos: fixed the efuse min/max value for exynos5422

e-fuse range min~max range is 16~76. if e-fuse value is out of this range, then thermal sensor may not sense thermal data properly. CC: Bartlomiej Zolnierkiewicz Signed-off-by: Anand Moon --- drivers/thermal/samsung/exynos_tmu.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions

[PATCH 4/5] thermal: exynos: fixed the efuse min/max value for exynos5422

e-fuse range min~max range is 16~76. if e-fuse value is out of this range, then thermal sensor may not sense thermal data properly. CC: Bartlomiej Zolnierkiewicz Signed-off-by: Anand Moon --- drivers/thermal/samsung/exynos_tmu.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions

Re: [PATCH] ARM: dts: exynos: Add missing CPU clocks to secondary CPUs on Exynos542x

Hi Krzysztof, On 30 May 2018 at 22:19, Krzysztof Kozlowski wrote: > Secondary CPUs should have the same information in DeviceTree as booting > CPU from both correctness point of view and for possible hotplug > scenarios. > > Suggested-by: Viresh Kumar > Signed-off-by: Krzysztof Kozlowski >

Re: [PATCH] ARM: dts: exynos: Add missing CPU clocks to secondary CPUs on Exynos542x

Hi Krzysztof, On 30 May 2018 at 22:19, Krzysztof Kozlowski wrote: > Secondary CPUs should have the same information in DeviceTree as booting > CPU from both correctness point of view and for possible hotplug > scenarios. > > Suggested-by: Viresh Kumar > Signed-off-by: Krzysztof Kozlowski >

Re: [PATCH 1/2] ARM64: dts: meson-gxbb: odroidc2: enable sdcard UHS modes

Hi Jerome On 14 May 2018 at 19:18, Jerome Brunet <jbru...@baylibre.com> wrote: > On Wed, 2018-05-02 at 00:29 +0530, Anand Moon wrote: >> Enable UHS modes for sdcard, on odroidc2. >> >> Signed-off-by: Anand Moon <linux.am...@gmail.com> >> --- >> arch/a

Re: [PATCH 1/2] ARM64: dts: meson-gxbb: odroidc2: enable sdcard UHS modes

Hi Jerome On 14 May 2018 at 19:18, Jerome Brunet wrote: > On Wed, 2018-05-02 at 00:29 +0530, Anand Moon wrote: >> Enable UHS modes for sdcard, on odroidc2. >> >> Signed-off-by: Anand Moon >> --- >> arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 5 +

[PATCH 1/2] ARM64: dts: meson-gxbb: odroidc2: enable sdcard UHS modes

Enable UHS modes for sdcard, on odroidc2. Signed-off-by: Anand Moon <linux.am...@gmail.com> --- arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic

[PATCH 1/2] ARM64: dts: meson-gxbb: odroidc2: enable sdcard UHS modes

Enable UHS modes for sdcard, on odroidc2. Signed-off-by: Anand Moon --- arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts index

[PATCH 2/2] ARM64: dts: meson: update maximum frequency for sdcard to 200MHz

update the maximum frequency of the sdcard to 200Mhz to support high speed read/write with uhs mode. Signed-off-by: Anand Moon <linux.am...@gmail.com> --- odroid@odroid64:~$ sudo cat /sys/kernel/debug/mmc1/ios [sudo] password for odroid: clock: 2 Hz actual clock: 20

[PATCH 2/2] ARM64: dts: meson: update maximum frequency for sdcard to 200MHz

update the maximum frequency of the sdcard to 200Mhz to support high speed read/write with uhs mode. Signed-off-by: Anand Moon --- odroid@odroid64:~$ sudo cat /sys/kernel/debug/mmc1/ios [sudo] password for odroid: clock: 2 Hz actual clock: 2 Hz vdd:21 (3.3

Re: [PATCH] crypto: s5p-sss.c: Fix kernel Oops in AES-ECB mode

Hi Kamil On 6 February 2018 at 22:40, Kamil Konieczny <k.koniec...@partner.samsung.com> wrote: > > On 06.02.2018 17:48, Anand Moon wrote: >> Hi Kamil, >> >> Thanks for providing the fix to this issue. >> >> On 5 February 2018 at 23:10, Kamil Konieczny

Re: [PATCH] crypto: s5p-sss.c: Fix kernel Oops in AES-ECB mode

Hi Kamil On 6 February 2018 at 22:40, Kamil Konieczny wrote: > > On 06.02.2018 17:48, Anand Moon wrote: >> Hi Kamil, >> >> Thanks for providing the fix to this issue. >> >> On 5 February 2018 at 23:10, Kamil Konieczny >> wrote: >>> >>

Re: [PATCH] crypto: s5p-sss.c: Fix kernel Oops in AES-ECB mode

Hi Kamil, Thanks for providing the fix to this issue. On 5 February 2018 at 23:10, Kamil Konieczny <k.koniec...@partner.samsung.com> wrote: > > In AES-ECB mode crypt is done with key only, so any use of IV > can cause kernel Oops, as reported by Anand Moon. If possible could you

Re: [PATCH] crypto: s5p-sss.c: Fix kernel Oops in AES-ECB mode

Hi Kamil, Thanks for providing the fix to this issue. On 5 February 2018 at 23:10, Kamil Konieczny wrote: > > In AES-ECB mode crypt is done with key only, so any use of IV > can cause kernel Oops, as reported by Anand Moon. If possible could you avoid the name in commit message.

Re: [RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

Hi Vivek, On 10 October 2017 at 11:57, Vivek Gautam <vivek.gau...@codeaurora.org> wrote: > > > On 10/08/2017 06:06 PM, Anand Moon wrote: >> >> Hi Krzysztof, >> >> On 6 October 2017 at 12:08, Krzysztof Kozlowski <k...@kernel.org> wrote: >>> &g

Re: [RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

Hi Vivek, On 10 October 2017 at 11:57, Vivek Gautam wrote: > > > On 10/08/2017 06:06 PM, Anand Moon wrote: >> >> Hi Krzysztof, >> >> On 6 October 2017 at 12:08, Krzysztof Kozlowski wrote: >>> >>> On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon wrot

Re: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

hi Krzysztof, On 9 October 2017 at 02:37, Anand Moon <linux.am...@gmail.com> wrote: > Hi Krzysztof, > > On 8 October 2017 at 21:20, Krzysztof Kozlowski <k...@kernel.org> wrote: >> On Sun, Oct 08, 2017 at 06:11:12PM +0530, Anand Moon wrote: >>> Hi Krzysztof

Re: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

hi Krzysztof, On 9 October 2017 at 02:37, Anand Moon wrote: > Hi Krzysztof, > > On 8 October 2017 at 21:20, Krzysztof Kozlowski wrote: >> On Sun, Oct 08, 2017 at 06:11:12PM +0530, Anand Moon wrote: >>> Hi Krzysztof, >>> >>> On 6 October 2017 at 12:12

Re: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

Hi Krzysztof, On 8 October 2017 at 21:20, Krzysztof Kozlowski <k...@kernel.org> wrote: > On Sun, Oct 08, 2017 at 06:11:12PM +0530, Anand Moon wrote: >> Hi Krzysztof, >> >> On 6 October 2017 at 12:12, Krzysztof Kozlowski <k...@kernel.org> wrote: >> >

Re: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

Hi Krzysztof, On 8 October 2017 at 21:20, Krzysztof Kozlowski wrote: > On Sun, Oct 08, 2017 at 06:11:12PM +0530, Anand Moon wrote: >> Hi Krzysztof, >> >> On 6 October 2017 at 12:12, Krzysztof Kozlowski wrote: >> > On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon w

Re: [RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

Hi Krzysztof, On 8 October 2017 at 21:17, Krzysztof Kozlowski <k...@kernel.org> wrote: > On Sun, Oct 08, 2017 at 06:06:19PM +0530, Anand Moon wrote: >> Hi Krzysztof, >> >> On 6 October 2017 at 12:08, Krzysztof Kozlowski <k...@kernel.org> wrote: >> >

Re: [RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

Hi Krzysztof, On 8 October 2017 at 21:17, Krzysztof Kozlowski wrote: > On Sun, Oct 08, 2017 at 06:06:19PM +0530, Anand Moon wrote: >> Hi Krzysztof, >> >> On 6 October 2017 at 12:08, Krzysztof Kozlowski wrote: >> > On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon wrote

Re: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

Hi Krzysztof, On 6 October 2017 at 12:12, Krzysztof Kozlowski <k...@kernel.org> wrote: > On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon <linux.am...@gmail.com> wrote: >> remove the disable and enable of phy clk. >> phy clk is needed to tune the phy controller. > >

Re: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

Hi Krzysztof, On 6 October 2017 at 12:12, Krzysztof Kozlowski wrote: > On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon wrote: >> remove the disable and enable of phy clk. >> phy clk is needed to tune the phy controller. > > Drivers should in general enable and disable the

Re: [RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

Hi Krzysztof, On 6 October 2017 at 12:08, Krzysztof Kozlowski <k...@kernel.org> wrote: > On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon <linux.am...@gmail.com> wrote: >> update the usbdrd link control and phy contol clks. > > The commit title and especially commit mes

Re: [RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

Hi Krzysztof, On 6 October 2017 at 12:08, Krzysztof Kozlowski wrote: > On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon wrote: >> update the usbdrd link control and phy contol clks. > > The commit title and especially commit message should explain why you > are doing this and

[RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

sclk_usbd301222400 0 0 dout_usbphy301 112400 0 0 sclk_usbphy301 222400 0 0 Signed-off-by: Anand Moon <linux.am...@gmail.

[RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

sclk_usbd301222400 0 0 dout_usbphy301 112400 0 0 sclk_usbphy301 222400 0 0 Signed-off-by: Anand Moon --- drivers/phy/samsung

[RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

update the usbdrd link control and phy contol clks. Signed-off-by: Anand Moon <linux.am...@gmail.com> --- Tested on Odroid XU4 and Odroid HC1 develpment board. Did not test Odroid XU develpment board. --- arch/arm/boot/dts/exynos5410.dtsi | 4 ++-- arch/arm/boot/dts/exynos5420.dtsi | 4 +

[RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

update the usbdrd link control and phy contol clks. Signed-off-by: Anand Moon --- Tested on Odroid XU4 and Odroid HC1 develpment board. Did not test Odroid XU develpment board. --- arch/arm/boot/dts/exynos5410.dtsi | 4 ++-- arch/arm/boot/dts/exynos5420.dtsi | 4 ++-- 2 files changed, 4

Re: [PATCH] ARM: dts: exynos: Exynos5422 Odroid-XU* incomplete thermal-zones definition

Hi Krzysztof, On 25 June 2017 at 22:49, Krzysztof Kozlowski <k...@kernel.org> wrote: > On Sun, Jun 25, 2017 at 10:25:32PM +0530, Anand Moon wrote: >> Hi Krzysztof >> >> On 25 June 2017 at 20:59, Krzysztof Kozlowski <k...@kernel.org> wrote: >> > On Sun, Ju

Re: [PATCH] ARM: dts: exynos: Exynos5422 Odroid-XU* incomplete thermal-zones definition

Hi Krzysztof, On 25 June 2017 at 22:49, Krzysztof Kozlowski wrote: > On Sun, Jun 25, 2017 at 10:25:32PM +0530, Anand Moon wrote: >> Hi Krzysztof >> >> On 25 June 2017 at 20:59, Krzysztof Kozlowski wrote: >> > On Sun, Jun 25, 2017 at 08:48:13PM +0530, Anand

Re: [PATCH] ARM: dts: exynos: Exynos5422 Odroid-XU* incomplete thermal-zones definition

Hi Krzysztof On 25 June 2017 at 20:59, Krzysztof Kozlowski <k...@kernel.org> wrote: > On Sun, Jun 25, 2017 at 08:48:13PM +0530, Anand Moon wrote: >> Hi Krzystof, >> >> 2: We should also increase the tips from 4 to 8 to support different >> >> cluster of c

Re: [PATCH] ARM: dts: exynos: Exynos5422 Odroid-XU* incomplete thermal-zones definition

Hi Krzysztof On 25 June 2017 at 20:59, Krzysztof Kozlowski wrote: > On Sun, Jun 25, 2017 at 08:48:13PM +0530, Anand Moon wrote: >> Hi Krzystof, >> >> 2: We should also increase the tips from 4 to 8 to support different >> >> cluster of cpu's. >> > >&g

Re: [PATCH] ARM: dts: exynos: Exynos5422 Odroid-XU* incomplete thermal-zones definition

Hi Krzystof, On 25 June 2017 at 19:01, Krzysztof Kozlowski <k...@kernel.org> wrote: > On Sun, Jun 25, 2017 at 06:53:24PM +0530, Anand Moon wrote: >> Hi Willy, >> >> On 24 June 2017 at 02:39, Willy Wolff <willy.mh.wo...@gmail.com> wrote: >> > Odroid XU*-

Re: [PATCH] ARM: dts: exynos: Exynos5422 Odroid-XU* incomplete thermal-zones definition

Hi Krzystof, On 25 June 2017 at 19:01, Krzysztof Kozlowski wrote: > On Sun, Jun 25, 2017 at 06:53:24PM +0530, Anand Moon wrote: >> Hi Willy, >> >> On 24 June 2017 at 02:39, Willy Wolff wrote: >> > Odroid XU*-familly boards has thermal sensors per A15 cores, but

Re: [PATCH] ARM: dts: exynos: Exynos5422 Odroid-XU* incomplete thermal-zones definition

_cpu1: handle cpu[0-3] cpufreq mapping. tmu_cpu2: handle cpu[4-7] cpufreq mapping. tmu_gpu: handle gpu (mali) cpu throttle. Please share your thought on this new approach. I generally test using linaro's pm-qa and most of the time the test case fails # git clone git://git.linaro.org/tools/pm-qa.git # make -C thermal check -Best Regards -Anand Moon

Re: [PATCH] ARM: dts: exynos: Exynos5422 Odroid-XU* incomplete thermal-zones definition

pping. tmu_cpu2: handle cpu[4-7] cpufreq mapping. tmu_gpu: handle gpu (mali) cpu throttle. Please share your thought on this new approach. I generally test using linaro's pm-qa and most of the time the test case fails # git clone git://git.linaro.org/tools/pm-qa.git # make -C thermal check -Best Regards -Anand Moon

Re: [PATCH 1/4] ARM: exynos_defconfig: Enable Bluetooth, mac80211, NFC and more USB drivers

E_UB6250=m > +CONFIG_USB_UAS=m > CONFIG_USB_DWC3=y > CONFIG_USB_DWC2=y > CONFIG_USB_HSIC_USB3503=y > @@ -209,7 +265,6 @@ CONFIG_LEDS_GPIO=y > CONFIG_LEDS_PWM=y > CONFIG_LEDS_MAX77693=y > CONFIG_LEDS_MAX8997=y > -CONFIG_LEDS_TRIGGERS=y > CONFIG_LEDS_TRIGGER_HEARTBEAT=y > CONFIG_RTC_CLASS=y > CONFIG_RTC_DRV_MAX8997=y For whole series. Reviewed-by: Anand Moon <linux.am...@gmail.com> Best Regards -Anand Moon

Re: [PATCH 1/4] ARM: exynos_defconfig: Enable Bluetooth, mac80211, NFC and more USB drivers

G_USB_DWC2=y > CONFIG_USB_HSIC_USB3503=y > @@ -209,7 +265,6 @@ CONFIG_LEDS_GPIO=y > CONFIG_LEDS_PWM=y > CONFIG_LEDS_MAX77693=y > CONFIG_LEDS_MAX8997=y > -CONFIG_LEDS_TRIGGERS=y > CONFIG_LEDS_TRIGGER_HEARTBEAT=y > CONFIG_RTC_CLASS=y > CONFIG_RTC_DRV_MAX8997=y For whole series. Reviewed-by: Anand Moon Best Regards -Anand Moon

Re: [PATCH] ARM64: dts: meson-gxbb-odroidc2: enable USB Host Nodes

Hi Martin, On 10 March 2017 at 01:06, Martin Blumenstingl <martin.blumensti...@googlemail.com> wrote: > Hi Anand, > > On Thu, Mar 9, 2017 at 6:58 PM, Anand Moon <linux.am...@gmail.com> wrote: >>> Hi Anand, >>> >>> For this specific use case, the

Re: [PATCH] ARM64: dts: meson-gxbb-odroidc2: enable USB Host Nodes

Hi Martin, On 10 March 2017 at 01:06, Martin Blumenstingl wrote: > Hi Anand, > > On Thu, Mar 9, 2017 at 6:58 PM, Anand Moon wrote: >>> Hi Anand, >>> >>> For this specific use case, the only way to manage this is to use the >>> Work-In-Progress >

Re: [PATCH] ARM64: dts: meson-gxbb-odroidc2: enable USB Host Nodes

Hi Neil, On 9 March 2017 at 18:43, Neil Armstrong <narmstr...@baylibre.com> wrote: > On 03/08/2017 06:22 PM, Anand Moon wrote: >> Hi All, >> >> On 8 March 2017 at 02:06, Anand Moon <linux.am...@gmail.com> wrote: >>> From: Anand Moon <linux.am...@g

Re: [PATCH] ARM64: dts: meson-gxbb-odroidc2: enable USB Host Nodes

Hi Neil, On 9 March 2017 at 18:43, Neil Armstrong wrote: > On 03/08/2017 06:22 PM, Anand Moon wrote: >> Hi All, >> >> On 8 March 2017 at 02:06, Anand Moon wrote: >>> From: Anand Moon >>> >>> update the regulator supply nodes for usb host to >

Re: [PATCH] ARM64: dts: meson-gxbb-odroidc2: enable USB Host Nodes

Hi All, On 8 March 2017 at 02:06, Anand Moon <linux.am...@gmail.com> wrote: > From: Anand Moon <linux.am...@gmail.com> > > update the regulator supply nodes for usb host to > enable usb host on odroid-c2 > > Signed-off-by: Anand Moon <linux.am...@gmail.co

Re: [PATCH] ARM64: dts: meson-gxbb-odroidc2: enable USB Host Nodes

Hi All, On 8 March 2017 at 02:06, Anand Moon wrote: > From: Anand Moon > > update the regulator supply nodes for usb host to > enable usb host on odroid-c2 > > Signed-off-by: Anand Moon > --- > root@odroid64:/usr/src/odroidxu3-4.y-devel# lsusb -t > /: Bus 01.Po

[PATCH] ARM64: dts: meson-gxbb-odroidc2: enable USB Host Nodes

From: Anand Moon <linux.am...@gmail.com> update the regulator supply nodes for usb host to enable usb host on odroid-c2 Signed-off-by: Anand Moon <linux.am...@gmail.com> --- root@odroid64:/usr/src/odroidxu3-4.y-devel# lsusb -t /: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=d

[PATCH] ARM64: dts: meson-gxbb-odroidc2: enable USB Host Nodes

From: Anand Moon update the regulator supply nodes for usb host to enable usb host on odroid-c2 Signed-off-by: Anand Moon --- root@odroid64:/usr/src/odroidxu3-4.y-devel# lsusb -t /: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=dwc2/1p, 480M |__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub

Re: [PATCH] ARM: dts: exynos: Use thermal fuse value for thermal zone 0 on Exynos5420

Peach Pi >> >> TMU0 = 44 >> TMU1 = 46 >> TMU2 = 36 >> TMU3 = 53 >> TMU3 = 46 >> >> The fused value for TMU2 is < 40 so that explains the weird temperature >> level for thermal zone 2 in Peach. So after your patch, makes more sense: >> &

Re: [PATCH] ARM: dts: exynos: Use thermal fuse value for thermal zone 0 on Exynos5420

U1 = 46 >> TMU2 = 36 >> TMU3 = 53 >> TMU3 = 46 >> >> The fused value for TMU2 is < 40 so that explains the weird temperature >> level for thermal zone 2 in Peach. So after your patch, makes more sense: >> >> # cat /sys/class/thermal/thermal_zon

Re: [PATCH] ARM: dts: exynos: Use thermal fuse value for thermal zone 0 on Exynos5420

Hi Krzysztof, On 13 February 2017 at 17:29, Krzysztof Kozlowski <k...@kernel.org> wrote: > On Mon, Feb 13, 2017 at 1:38 PM, Anand Moon <linux.am...@gmail.com> wrote: >> Hi Krzysztof, >> >> >> >> On 12 February 2017 at 01:44, Krzysztof Kozlowski &l

Re: [PATCH] ARM: dts: exynos: Use thermal fuse value for thermal zone 0 on Exynos5420

Hi Krzysztof, On 13 February 2017 at 17:29, Krzysztof Kozlowski wrote: > On Mon, Feb 13, 2017 at 1:38 PM, Anand Moon wrote: >> Hi Krzysztof, >> >> >> >> On 12 February 2017 at 01:44, Krzysztof Kozlowski wrote: >>> In Odroid XU3 Lite board, the temperat

Re: [PATCH] ARM: dts: exynos: Use thermal fuse value for thermal zone 0 on Exynos5420

Hi Krzysztof, On 12 February 2017 at 01:44, Krzysztof Kozlowski wrote: > In Odroid XU3 Lite board, the temperature levels reported for thermal > zone 0 were weird. In warm room: > /sys/class/thermal/thermal_zone0/temp:32000 >

Re: [PATCH] ARM: dts: exynos: Use thermal fuse value for thermal zone 0 on Exynos5420

Hi Krzysztof, On 12 February 2017 at 01:44, Krzysztof Kozlowski wrote: > In Odroid XU3 Lite board, the temperature levels reported for thermal > zone 0 were weird. In warm room: > /sys/class/thermal/thermal_zone0/temp:32000 > /sys/class/thermal/thermal_zone1/temp:51000 >

Re: Exynos5422 EHCI (USB 2.0) - Odroid XU4 - port 1 resume error -110

Hi Krzysztof, On 29 January 2017 at 19:05, Krzysztof Kozlowski wrote: > Hi, > > On Odroid XU4 with an external usb2514 hub (evaluation board from SMSC > or TI) connected to the USB2.0 port of EHCI controller, whenever I > plug some USB device into the usb2514 hub I see errors

Re: Exynos5422 EHCI (USB 2.0) - Odroid XU4 - port 1 resume error -110

Hi Krzysztof, On 29 January 2017 at 19:05, Krzysztof Kozlowski wrote: > Hi, > > On Odroid XU4 with an external usb2514 hub (evaluation board from SMSC > or TI) connected to the USB2.0 port of EHCI controller, whenever I > plug some USB device into the usb2514 hub I see errors like: > [

Re: [PATCH] ARM: dts: Odroid XU4: fix USB3.0 ports

Hi Krzysztof, On 25 January 2017 at 19:47, Krzysztof Kozlowski <k...@kernel.org> wrote: > On Wed, Jan 25, 2017 at 3:48 PM, Marek Szyprowski > <m.szyprow...@samsung.com> wrote: >> Hi Krzysztof, >> >> On 2017-01-25 08:55, Krzysztof Kozlowski wrote: >>&g

Re: [PATCH] ARM: dts: Odroid XU4: fix USB3.0 ports

Hi Krzysztof, On 25 January 2017 at 19:47, Krzysztof Kozlowski wrote: > On Wed, Jan 25, 2017 at 3:48 PM, Marek Szyprowski > wrote: >> Hi Krzysztof, >> >> On 2017-01-25 08:55, Krzysztof Kozlowski wrote: >>> >>> On Wed, Jan 25, 2017 at 7:51 AM, Anand

<    1   2   3   4   5   6   7   >