[RFC PATCH] NFC: st21nfcb: Avoid use of skb after free

2015-01-15 Thread Anda-Maria Nicolae
Do not insert in send queue the skb that contains unknown Packet Control Byte Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- Only compile tested, please have a look drivers/nfc/st21nfcb/ndlc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nfc

[PATCH 1/2] bq2415x_charger: Remove unnecessary else after return

2015-03-05 Thread Anda-Maria Nicolae
Fix coding style to comply with checkpatch.pl Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- drivers/power/bq2415x_charger.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/power/bq2415x_charger.c b/drivers/power

[PATCH 2/2] bq2415x_charger: Add support for bq24157s

2015-03-05 Thread Anda-Maria Nicolae
This patch adds bq24157s charger in the list of supported chargers. bq24157s is similar to bq24158, except for Bit6 from Special Charger Voltage/Enable Pin Status register, but this register is currently not used by bq2415x_charger. Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com

[PATCH 0/2] bq2415x_charger: Fix coding style issues and add new charger in the list of supported chargers

2015-03-05 Thread Anda-Maria Nicolae
Hello, First patch from patchset fixes coding style issues: removes unnecessary else after return. This way, the coding style complies with checkpatch.pl. Second patch from patchset updates bq2415x driver to support bq24157s charger. Thanks, Anda Anda-Maria Nicolae (2): bq2415x_charger

[PATCH] power_supply: Add support for Richtek rt9455 battery charger

2015-04-24 Thread Anda-Maria Nicolae
Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- .../devicetree/bindings/power/rt9455_charger.txt | 38 + .../devicetree/bindings/vendor-prefixes.txt|1 + drivers/power/Kconfig

[PATCH] power_supply: Add ACPI support to bq2415x battery charger

2015-04-24 Thread Anda-Maria Nicolae
Replace of_property_read_u32() function call with device_property_read_u32(), which is a wrapper over ACPI and devicetree enumeration methods. Fix minor existing coding style issues reported by checkpatch.pl. Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- drivers/power

[PATCHv2] power_supply: Add support for Richtek rt9455 battery charger

2015-04-29 Thread Anda-Maria Nicolae
{RTK9455, 0} with { RTK9455, 0 } - removed .owner = THIS_MODULE Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- .../devicetree/bindings/power/rt9455_charger.txt | 43 + .../devicetree/bindings/vendor-prefixes.txt|1 + drivers/power/Kconfig

Re: [PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-06 Thread Anda-Maria Nicolae
Hi Laurentiu, Inline are the answers to your comments. Thanks, Anda On 05/06/2015 02:40 PM, Laurentiu Palcu wrote: On Tue, May 05, 2015 at 07:32:10PM +0300, Anda-Maria Nicolae wrote: Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria

[PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-05 Thread Anda-Maria Nicolae
Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- Updates from v2 version: - removed unused masks and keep the used ones. I have tried to access mask field from struct regmap_field, but I have

[PATCH v5] power_supply: Add support for Richtek rt9455 battery charger

2015-05-08 Thread Anda-Maria Nicolae
Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- Updates from v4 version: - replaced depends on REGMAP_I2C with select REGMAP_I2C - got

Re: [PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-06 Thread Anda-Maria Nicolae
On 05/06/2015 10:58 AM, Krzysztof Kozłowski wrote: 2015-05-06 1:32 GMT+09:00 Anda-Maria Nicolae anda-maria.nico...@intel.com: Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- Updates from v2

[PATCH v4] power_supply: Add support for Richtek rt9455 battery charger

2015-05-08 Thread Anda-Maria Nicolae
Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- Updates from v3 version: - added depends on REGMAP_I2C in Kconfig - removed MASK* macros and used GET_MASK as per Laurentiu's suggestion

[PATCH 0/2] power_supply: bq2415x_charger: Fix coding style issues add ACPI support

2015-05-12 Thread Anda-Maria Nicolae
Hi all, The following 2 patches do the following to bq2415x_charger: - first patch fixes pre-existing coding style issues reported by checkpatch.pl - second patch adds ACPI enumeration support Thanks, Anda Anda-Maria Nicolae (2): power_supply: bq2415x_charger: Fix coding style issues

[PATCH 2/2] power_supply: bq2415x_charger: Add ACPI support

2015-05-12 Thread Anda-Maria Nicolae
that is connected to. Input current may be updated via sysfs. Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- drivers/power/bq2415x_charger.c | 73 +-- 1 file changed, 55 insertions(+), 18 deletions(-) diff --git a/drivers/power

[PATCH 1/2] power_supply: bq2415x_charger: Fix coding style issues

2015-05-12 Thread Anda-Maria Nicolae
braces, add braces to the other arms of the respective statement, too - match alignment with open parenthesis Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- drivers/power/bq2415x_charger.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions

[PATCH] power_supply: rt9455_charger: Check if CONFIG_USB_PHY is enabled

2015-06-03 Thread Anda-Maria Nicolae
notifications are received in this case. Also, since rt9455_set_boost_voltage_before_boost_mode() function is called only if USB_EVENT_ID notification is received, this function should also be defined only if CONFIG_USB_PHY is enabled. Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com

[PATCH] power_supply: rt9455_charger: Fix error reported by static analysis tool

2015-06-12 Thread Anda-Maria Nicolae
The result of container_of macro cannot be NULL, so there is no need to check whether info is NULL. Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- drivers/power/rt9455_charger.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/power/rt9455_charger.c b/drivers

[PATCH] power_supply: rt9455_charger: Properly notify userspace about charging events

2015-06-17 Thread Anda-Maria Nicolae
. Also, call power_supply_changed() after the battery is reconnected to the charger, to notify userspace that the battery is no longer absent. Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- drivers/power/rt9455_charger.c | 16 ++-- 1 file changed, 14 insertions

[PATCH 2/3] Documentation: devicetree: Add Richtek RT9455 bindings

2015-05-29 Thread Anda-Maria Nicolae
Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- .../devicetree/bindings/power/rt9455_charger.txt | 46 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/rt9455_charger.txt diff --git a/Documentation/devicetree

[PATCH v7 0/3] Add support for Richtek RT9455 battery charger

2015-05-29 Thread Anda-Maria Nicolae
(). - used devm_power_supply_register() and removed power_supply_unregister() from rt9455_remove(). Anda-Maria Nicolae (3): of: Add vendor prefix for Richtek Technology Corporation Documentation: devicetree: Add Richtek RT9455 bindings power_supply: Add support for Richtek RT9455 battery charger

[PATCH 3/3] power_supply: Add support for Richtek RT9455 battery charger

2015-05-29 Thread Anda-Maria Nicolae
Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- drivers/power/Kconfig |7 + drivers/power/Makefile |1 + drivers/power/rt9455_charger.c | 1751

[PATCH 1/3] of: Add vendor prefix for Richtek Technology Corporation

2015-05-29 Thread Anda-Maria Nicolae
Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- .../devicetree/bindings/vendor-prefixes.txt|1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 8033919

Re: [PATCH] power_supply: rt9455_charger: Properly notify userspace about charging events

2015-07-02 Thread Anda-Maria Nicolae
the battery is reconnected (i.e. BATAB interrupt bit is cleared). This is why in this patch, in rt9455_batt_presence_work_callback(), power_supply_changed() is called. On 07/02/2015 03:49 AM, Krzysztof Kozlowski wrote: 2015-06-18 1:28 GMT+09:00 Anda-Maria Nicolae anda-maria.nico...@intel.com: Do

[PATCH 0/3] Add support for Richtek RT9455 battery charger

2015-05-25 Thread Anda-Maria Nicolae
Hello, The next 3 patches do the following: - first patch adds Richtek Technology Corporation in the vendor-prefixes list - second patch adds device tree binding example for Richtek RT9455 battery charger - third patch adds the driver for Richtek RT9455 battery charger Thanks, Anda Anda-Maria

[PATCH 3/3] power_supply: Add support for Richtek RT9455 battery charger

2015-05-25 Thread Anda-Maria Nicolae
Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- drivers/power/Kconfig |7 + drivers/power/Makefile |1 + drivers/power/rt9455_charger.c | 1821

[PATCH 1/3] of: Add vendor prefix for Richtek Technology Corporation

2015-05-25 Thread Anda-Maria Nicolae
Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- .../devicetree/bindings/vendor-prefixes.txt|1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 8033919

[PATCH 2/3] Documentation: devicetree: Add Richtek RT9455 bindings

2015-05-25 Thread Anda-Maria Nicolae
Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- .../devicetree/bindings/power/rt9455_charger.txt | 46 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/rt9455_charger.txt diff --git a/Documentation/devicetree

[PATCH v2] power_supply: rt9455_charger: Properly notify userspace about charging events

2015-07-07 Thread Anda-Maria Nicolae
-Maria Nicolae anda-maria.nico...@intel.com --- Updates from v1 version: - I have followed Kzrysztof's suggestion and I have added explanations in the commit message so that the change is more clear - Code is the same as in v1 drivers/power/rt9455_charger.c | 16 ++-- 1 file changed

[PATCH 0/3] Add support for Richtek RT9455 battery charger

2015-05-25 Thread Anda-Maria Nicolae
Hello, The next 3 patches do the following: - first patch adds Richtek Technology Corporation in the vendor-prefixes list - second patch adds device tree binding example for Richtek RT9455 battery charger - third patch adds the driver for Richtek RT9455 battery charger Thanks, Anda Anda-Maria

[PATCH 3/3] power_supply: Add support for Richtek RT9455 battery charger

2015-05-25 Thread Anda-Maria Nicolae
Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae --- drivers/power/Kconfig |7 + drivers/power/Makefile |1 + drivers/power/rt9455_charger.c | 1821 3 files

[PATCH 1/3] of: Add vendor prefix for Richtek Technology Corporation

2015-05-25 Thread Anda-Maria Nicolae
Signed-off-by: Anda-Maria Nicolae --- .../devicetree/bindings/vendor-prefixes.txt|1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 8033919..7b8c129 100644

[PATCH 2/3] Documentation: devicetree: Add Richtek RT9455 bindings

2015-05-25 Thread Anda-Maria Nicolae
Signed-off-by: Anda-Maria Nicolae --- .../devicetree/bindings/power/rt9455_charger.txt | 46 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/rt9455_charger.txt diff --git a/Documentation/devicetree/bindings/power

[PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-05 Thread Anda-Maria Nicolae
Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae --- Updates from v2 version: - removed unused masks and keep the used ones. I have tried to access mask field from struct regmap_field, but I have received the following

[PATCH 0/2] power_supply: bq2415x_charger: Fix coding style issues && add ACPI support

2015-05-12 Thread Anda-Maria Nicolae
Hi all, The following 2 patches do the following to bq2415x_charger: - first patch fixes pre-existing coding style issues reported by checkpatch.pl - second patch adds ACPI enumeration support Thanks, Anda Anda-Maria Nicolae (2): power_supply: bq2415x_charger: Fix coding style issues

[PATCH 2/2] power_supply: bq2415x_charger: Add ACPI support

2015-05-12 Thread Anda-Maria Nicolae
that is connected to. Input current may be updated via sysfs. Signed-off-by: Anda-Maria Nicolae --- drivers/power/bq2415x_charger.c | 73 +-- 1 file changed, 55 insertions(+), 18 deletions(-) diff --git a/drivers/power/bq2415x_charger.c b/drivers/power

[PATCH 1/2] power_supply: bq2415x_charger: Fix coding style issues

2015-05-12 Thread Anda-Maria Nicolae
ement uses braces, add braces to the other arms of the respective statement, too - match alignment with open parenthesis Signed-off-by: Anda-Maria Nicolae --- drivers/power/bq2415x_charger.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git

[PATCHv2] power_supply: Add support for Richtek rt9455 battery charger

2015-04-29 Thread Anda-Maria Nicolae
placed {"RTK9455", 0} with { "RTK9455", 0 } - removed .owner = THIS_MODULE Signed-off-by: Anda-Maria Nicolae --- .../devicetree/bindings/power/rt9455_charger.txt | 43 + .../devicetree/bindings/vendor-prefixes.txt|1 + drivers/power/Kconfig

[RFC PATCH] NFC: st21nfcb: Avoid use of skb after free

2015-01-15 Thread Anda-Maria Nicolae
Do not insert in send queue the skb that contains unknown Packet Control Byte Signed-off-by: Anda-Maria Nicolae --- Only compile tested, please have a look drivers/nfc/st21nfcb/ndlc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nfc/st21nfcb/ndlc.c b/drivers

[PATCH] power_supply: rt9455_charger: Fix error reported by static analysis tool

2015-06-12 Thread Anda-Maria Nicolae
The result of container_of macro cannot be NULL, so there is no need to check whether info is NULL. Signed-off-by: Anda-Maria Nicolae --- drivers/power/rt9455_charger.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/power/rt9455_charger.c b/drivers/power/rt9455_charger.c index

[PATCH] power_supply: rt9455_charger: Properly notify userspace about charging events

2015-06-17 Thread Anda-Maria Nicolae
. Also, call power_supply_changed() after the battery is reconnected to the charger, to notify userspace that the battery is no longer absent. Signed-off-by: Anda-Maria Nicolae --- drivers/power/rt9455_charger.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] power_supply: rt9455_charger: Properly notify userspace about charging events

2015-07-02 Thread Anda-Maria Nicolae
the battery is reconnected (i.e. BATAB interrupt bit is cleared). This is why in this patch, in rt9455_batt_presence_work_callback(), power_supply_changed() is called. On 07/02/2015 03:49 AM, Krzysztof Kozlowski wrote: 2015-06-18 1:28 GMT+09:00 Anda-Maria Nicolae : Do not call power_supply_changed

[PATCH] power_supply: rt9455_charger: Check if CONFIG_USB_PHY is enabled

2015-06-03 Thread Anda-Maria Nicolae
notifications are received in this case. Also, since rt9455_set_boost_voltage_before_boost_mode() function is called only if USB_EVENT_ID notification is received, this function should also be defined only if CONFIG_USB_PHY is enabled. Signed-off-by: Anda-Maria Nicolae --- drivers/power

[PATCH 2/3] Documentation: devicetree: Add Richtek RT9455 bindings

2015-05-29 Thread Anda-Maria Nicolae
Signed-off-by: Anda-Maria Nicolae --- .../devicetree/bindings/power/rt9455_charger.txt | 46 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/rt9455_charger.txt diff --git a/Documentation/devicetree/bindings/power

[PATCH v7 0/3] Add support for Richtek RT9455 battery charger

2015-05-29 Thread Anda-Maria Nicolae
get(). - used devm_power_supply_register() and removed power_supply_unregister() from rt9455_remove(). Anda-Maria Nicolae (3): of: Add vendor prefix for Richtek Technology Corporation Documentation: devicetree: Add Richtek RT9455 bindings power_supply: Add support for Richtek RT9455 battery char

[PATCH 1/3] of: Add vendor prefix for Richtek Technology Corporation

2015-05-29 Thread Anda-Maria Nicolae
Signed-off-by: Anda-Maria Nicolae --- .../devicetree/bindings/vendor-prefixes.txt|1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 8033919..7b8c129 100644

[PATCH 3/3] power_supply: Add support for Richtek RT9455 battery charger

2015-05-29 Thread Anda-Maria Nicolae
Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae --- drivers/power/Kconfig |7 + drivers/power/Makefile |1 + drivers/power/rt9455_charger.c | 1751 3 files

[PATCH v2] power_supply: rt9455_charger: Properly notify userspace about charging events

2015-07-07 Thread Anda-Maria Nicolae
-Maria Nicolae --- Updates from v1 version: - I have followed Kzrysztof's suggestion and I have added explanations in the commit message so that the change is more clear - Code is the same as in v1 drivers/power/rt9455_charger.c | 16 ++-- 1 file changed, 14 insertions(+), 2

Re: [PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-06 Thread Anda-Maria Nicolae
Hi Laurentiu, Inline are the answers to your comments. Thanks, Anda On 05/06/2015 02:40 PM, Laurentiu Palcu wrote: On Tue, May 05, 2015 at 07:32:10PM +0300, Anda-Maria Nicolae wrote: Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria

Re: [PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-06 Thread Anda-Maria Nicolae
On 05/06/2015 10:58 AM, Krzysztof Kozłowski wrote: 2015-05-06 1:32 GMT+09:00 Anda-Maria Nicolae : Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae --- Updates from v2 version: - removed unused masks and keep the used ones

[PATCH] power_supply: Add support for Richtek rt9455 battery charger

2015-04-24 Thread Anda-Maria Nicolae
Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae --- .../devicetree/bindings/power/rt9455_charger.txt | 38 + .../devicetree/bindings/vendor-prefixes.txt|1 + drivers/power/Kconfig

[PATCH] power_supply: Add ACPI support to bq2415x battery charger

2015-04-24 Thread Anda-Maria Nicolae
Replace of_property_read_u32() function call with device_property_read_u32(), which is a wrapper over ACPI and devicetree enumeration methods. Fix minor existing coding style issues reported by checkpatch.pl. Signed-off-by: Anda-Maria Nicolae --- drivers/power/bq2415x_charger.c | 76

[PATCH v4] power_supply: Add support for Richtek rt9455 battery charger

2015-05-08 Thread Anda-Maria Nicolae
Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae --- Updates from v3 version: - added "depends on REGMAP_I2C" in Kconfig - removed MASK* macros and used GET_MASK as per Laurentiu's suggestion - removed charger_set_p

[PATCH v5] power_supply: Add support for Richtek rt9455 battery charger

2015-05-08 Thread Anda-Maria Nicolae
Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae --- Updates from v4 version: - replaced depends on REGMAP_I2C with select REGMAP_I2C - got the latest version

[PATCH 2/2] bq2415x_charger: Add support for bq24157s

2015-03-05 Thread Anda-Maria Nicolae
This patch adds bq24157s charger in the list of supported chargers. bq24157s is similar to bq24158, except for Bit6 from Special Charger Voltage/Enable Pin Status register, but this register is currently not used by bq2415x_charger. Signed-off-by: Anda-Maria Nicolae --- drivers/power

[PATCH 0/2] bq2415x_charger: Fix coding style issues and add new charger in the list of supported chargers

2015-03-05 Thread Anda-Maria Nicolae
Hello, First patch from patchset fixes coding style issues: removes unnecessary else after return. This way, the coding style complies with checkpatch.pl. Second patch from patchset updates bq2415x driver to support bq24157s charger. Thanks, Anda Anda-Maria Nicolae (2): bq2415x_charger

[PATCH 1/2] bq2415x_charger: Remove unnecessary else after return

2015-03-05 Thread Anda-Maria Nicolae
Fix coding style to comply with checkpatch.pl Signed-off-by: Anda-Maria Nicolae --- drivers/power/bq2415x_charger.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/power/bq2415x_charger.c b/drivers/power/bq2415x_charger.c index e384844