Re: [PATCH] arm64/crypto: fix makefile rule for aes-glue-%.o

Ard Biesheuvel writes: > On 24 July 2014 15:26, Andreas Schwab wrote: >> You are not using CONFIG_MODVERSIONS. >> > > I am No, you aren't, since you say that your .cmd contains a command to create aes-glue-ce.o, which with CONFIG_MODVERSIONS it doesn't. Andreas.

Re: [PATCH] arm64/crypto: fix makefile rule for aes-glue-%.o

You are not using CONFIG_MODVERSIONS. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH] arm64/crypto: fix makefile rule for aes-glue-%.o

Ard Biesheuvel writes: > On 30 June 2014 15:56, Andreas Schwab wrote: >> Ard Biesheuvel writes: >> >>> Out of curiosity, how did you trigger this failure? I have build this >>> code numerous times (and so have others) and I have never seen this >>>

Re: [PATCH, RFC] random: introduce getrandom(2) system call

Theodore Ts'o writes: > ERRORS > EINVAL The buflen value was invalid. Also on unknown flags? Without that it would be impossible to probe for implemented flags. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D

Re: ls -l /proc/1/exe -> Permission denied

Richard Weinberger writes: > On Sun, Jul 20, 2014 at 12:55 PM, Andreas Schwab > wrote: >> Joakim Tjernlund writes: >> >>> Andreas Schwab wrote on 2014/07/19 22:21:59: >>>> >>>> Joakim Tjernlund writes: >>>> >&g

Re: ls -l /proc/1/exe -> Permission denied

Joakim Tjernlund writes: > Andreas Schwab wrote on 2014/07/19 22:21:59: >> >> Joakim Tjernlund writes: >> >> > Trying to real /proc//exe I noticed I could not read links not >> > belonging to my user such as: >> > jocke > ls -l /proc/1/

Re: ls -l /proc/1/exe -> Permission denied

is considered private. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: [PATCH] Fixes q40_irq_startup to return -ENXIO

case 9: > case 11: case 12: case 13: > printk("%s: ISA IRQ %d not implemented by HW\n", __func__, irq); > - /* FIXME return -ENXIO; */ > + return -ENXIO; There must be more to it, given the FIXME. Andreas. -- Andreas Schwab, sch.

Re: [PATCH] arm64/crypto: fix makefile rule for aes-glue-%.o

Ard Biesheuvel writes: > Out of curiosity, how did you trigger this failure? I have build this > code numerous times (and so have others) and I have never seen this > failure. Did you ever start with a clean tree? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fi

[PATCH] arm64/crypto: fix makefile rule for aes-glue-%.o

o] Error 1 Makefile:893: recipe for target 'arch/arm64/crypto' failed make: *** [arch/arm64/crypto] Error 2 The $(obj)/aes-glue-%.o rule only creates $(obj)/.tmp_aes-glue-ce.o, it should use if_changed_rule instead of if_changed_dep. Signed-off-by: Andreas Schwab --- arch/arm64/crypt

Re: [PATCH] tell gcc optimizer to never introduce new data races

Dan Carpenter writes: > Adding "--param allow-store-data-races=0" to the GCC options for the > kernel breaks C=1 because Sparse isn't expecting a GCC option with that > format. Please try --param=allow-store-data-races=0 instead. Andreas. -- Andreas Schwab, SUSE Labs

Re: [RFC 01/32] fs: introduce new 'struct inode_time'

Geert Uytterhoeven writes: > "int" is signed, right? Or do you mean a bitfield needs an explicit "signed" > keyword to be signed? Yes, see 6.7.2#5. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 2

Re: [RFC 03/32] fs: introduce sys_utimens64at

Arnd Bergmann writes: > +asmlinkage long sys_utimens64at(int dfd, const char __user *filename, All existing syscall names have the 64 suffix last, including the *at variants, so sys_utimensat64 would be more in line. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerpr

Re: [RFC 01/32] fs: introduce new 'struct inode_time'

numbers there, but storing a large > positive number will become negative on read out, won't it? Only if the int bitfield is signed. Bitfields are weird, aren't they? :-) Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B

Re: [PATCH] powerpc: fix typo 'CONFIG_PMAC'

Paul Bolle writes: > Do you want to know how to test this patch on a 32 bit powermac? Ie, see > if it has any effect, and whether that effect improves things or make > things worse. Yes. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1

Re: [PATCH] powerpc: fix typo 'CONFIG_PMAC'

ent: Reduce latency of calling > perf_event_do_pending") > Signed-off-by: Paul Bolle > --- > Untested. Needs testing on 32 bit powermac, I guess. > > This typo was introduced in v2.6.36. No one noticed because very few > people still use 32 bit powermacs? How does that bug manifest itself?

Re: Support for netconsole as default tty/console?

One Thousand Gnomes writes: > It's however implemented and present. The rest is between you and the > relevant Kconfig maintainer. I'm sure you count as an expert ;-) Indeed. http://lists.opensuse.org/opensuse-kernel/2014-03/msg00071.html Andreas. -- Andreas Schwab

Re: Support for netconsole as default tty/console?

s typically not avaiable. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: Support for netconsole as default tty/console?

Struan Bartlett writes: > Thank you. I've begun investigating the sources in drivers/tty. Am I > correct in thinking that this only needs a tty driver, and not also a > serial driver? See arch/m68k/emu/nfcon.c for a somewhat minimal example (only output). Andreas. -- Andre

Re: Support for netconsole as default tty/console?

is there an independent > solution to this problem? It should not be hard to add a tty driver to netconsole, there are many examples to borrow from. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something

Re: [PATCH 39/48] powerpc: Replace __get_cpu_var uses

e to find one that isn't a steaming pile ... :-) Gnus. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscri

Re: 3.13-rc1: eth0 hw csum failure on powerpc

/3.13-rc1/ > > Oh, this has already been reported earlier this week: > > https://lists.ozlabs.org/pipermail/linuxppc-dev/2013-November/113584.html No solution yet, though, 3.13-rc2 is still broken. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53

Re: [PATCH/RFC] m68k/amiga: Fix specifying multiple debug= parameters

b. Skip console registration in case of a non-NULL .write() method >> => only the last debug console will be used, >> 3. Atari has a similar issue, with even more (4) debug consoles. 2b is backward compatible. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG

Re: [patch 1/6] hardirq: Make hardirq bits generic

filters out the I1 bit, which makes irq level 4 and level 6 look the same (all MFP interrupts are at level 6). Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: [QUERY] Building and testing Aarch64

can extract the config from /proc/config.gz. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [QUERY] Building and testing Aarch64

Ramkumar Ramachandra writes: > Is there a bug in the Kconfig dependency tree? Sounds like VIRTIO_MMIO > requires some vga (?) drivers to be compiled in as well. I don't have any VGA option enabled. You should use a serial console with CONFIG_SERIAL_AMBA_PL011_CONSOLE. Andreas.

Re: [QUERY] Building and testing Aarch64

ilesystem.cpio.gz, and where is it going to > be used? It is the optional initrd. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this lis

Re: [patch 1/6] hardirq: Make hardirq bits generic

Thomas Gleixner writes: > + /* > + * Only the last interrupt leaving the kernel goes through the > + * various exception return checks. > + */ > + cmpl#0, %d0 tstl%d0 Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint =

Re: [PATCH] cpufreq: Fix wrong time unit conversion

See also <http://permalink.gmane.org/gmane.linux.kernel.cpufreq/11672>. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this lis

Re: btrfs zero divide

Andreas Schwab writes: > Josef Bacik writes: > >> So stripe_len shouldn't be 0, if it is you have bigger problems :). > > The bigger problem is that stripe_nr is u64, this is completely bogus. > The first operand of do_div must be u32. This goes through the whole

Re: btrfs zero divide

Josef Bacik writes: > So stripe_len shouldn't be 0, if it is you have bigger problems :). The bigger problem is that stripe_nr is u64, this is completely bogus. The first operand of do_div must be u32. This goes through the whole file. Andreas. -- Andreas Schwab, sch...@linux-m68k

Re: [PATCH] m68k/uaccess: Fix asm constraints for userspace access

e in __constant_copy_from_user and __constant_copy_to_user. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] doc: avoid strncpy in accounting tool

Kees Cook writes: > Avoid strncpy anti-pattern. Use strdup() instead, as already done for > the logfile optarg. There should be no need to copy the string, option arguments are stable. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D

Re: [PATCH] dtc: Ensure #line directives don't consume data from the next line

Stephen Warren writes: > Fix this by replacing {WS} with [ \t] so that it can't match line-breaks. I think the other uses of {WS} shouldn't span lines either. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276

Re: [PATCH] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero.

p_roundint(struct fp_ext *dest, int mode) > return; > break; > case 0x401e: > - if (!(oldmant.m32[1] >= 0)) > + if (!((long)oldmant.m32[1] >= 0)) if (oldmant.m32[1] & 0

Re: Build errors caused by modalias generation patch

definition of struct usb_device_id in mod_devicetable.h What are the contents of devicetable-offsets.[sh]? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsub

Re: Build errors caused by modalias generation patch

Please try the patch in <http://marc.info/?l=linux-kbuild&m=136767800809256&w=2>. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe

[PATCH] Fix cleaning in scripts/mod

Make sure devicetable-offsets.h is cleaned in the scripts/mod directory Signed-off-by: Andreas Schwab --- scripts/mod/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/mod/Makefile b/scripts/mod/Makefile index 9415b56..75d59fc 100644 --- a/scripts/mod/Makefile +++ b/scripts

[PATCH] kbuild: generate generic headers before recursing into scripts

The headers are now needed inside scripts/mod since 6543bec ("mod/file2alias: make modalias generation safe for cross compiling"). Signed-off-by: Andreas Schwab --- Prabhakar Lad writes: > Whats the status of it ? I think it has sufficiently been tested by now. Andreas. ---

Re: [ANNOUNCE] Git v1.8.1.6

JUKuxUn3sDEGkuvbqJ1EZj7r bkuFF7S8JTsRxJ92hdctDVAjCA9fW23t8smBmmQ1PQka+wzawNeV/wAmMJ9Um51h 8ut8jnfWbZNsJfwYnpo3AB6iqT/gRZ5fTjhAwXcr9da/FG05OWk9RpkwI3vbTvw+ 7YDSrBDgS59rnhXKjJrVQ6vMsKttvt3LPl7Cr2uMjxAtZuvUCnjLxfSbF8axE5SU KtGfnAbYvCQYBfIKKSwS =kNrb -END PGP SIGNATURE- Note the missing newline before "-BEGIN PGP SIGNATURE-

Re: [BUG] mod/file2alias: build error in devicetable-offsets.c [was: asm/types.h Header file wont get generated while building uImage ?]

l PHONY += scripts -scripts: scripts_basic include/config/auto.conf include/config/tristate.conf +scripts: scripts_basic include/config/auto.conf include/config/tristate.conf \ +asm-generic $(Q)$(MAKE) $(build)=$(@) # Objects we will link into vmlinux / subdirs we need to visit A

[PATCH] scripts/tags.sh: Fix regex syntax for etags

Signed-off-by: Andreas Schwab --- scripts/tags.sh | 50 +- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/scripts/tags.sh b/scripts/tags.sh index 08f06c0..4c53b7d 100755 --- a/scripts/tags.sh +++ b/scripts/tags.sh @@ -201,34

Re: Missing tags in my local stable git repo

/linux/kernel/git/stable/linux-stable.git > fetch = +refs/heads/*:refs/heads/* This is your problem. When fetching from origin all references (including tags) not part of origin are removed. When you mirror a repo you cannot have another remote in the same repo. Andreas. -- Andreas Schwa

Re: [PATCH] binfmt_script: do not leave interp on stack

Kees Cook writes: > + /* > + * Since bprm is already modified, we cannot continue if the the s/the the/the/ Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely differ

Re: [kbuild bug] /bin/sh: -c: line 0: syntax error near unexpected token `;'

s only defined in Makefile.build. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

[tip:timers/urgent] time: Fix casting issue in timekeeping_forward_now

Commit-ID: 85dc8f05c93c8105987de9d7e7cebf15a72ff4ec Gitweb: http://git.kernel.org/tip/85dc8f05c93c8105987de9d7e7cebf15a72ff4ec Author: Andreas Schwab AuthorDate: Tue, 21 Aug 2012 20:30:47 -0400 Committer: Thomas Gleixner CommitDate: Wed, 22 Aug 2012 10:42:13 +0200 time: Fix casting

Re: [PATCH 4/8] time: Condense timekeeper.xtime into xtime_sec

); > } Yes, that does it. Failure to normalize is always bad. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "uns

Re: [PATCH 4/8] time: Condense timekeeper.xtime into xtime_sec

John Stultz writes: > Huh. Yea, that looks fine. And without the > __timekeeping_inject_sleeptime() call, the system resumed ok? Yes, it does. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now fo

Re: [PATCH 4/8] time: Condense timekeeper.xtime into xtime_sec

pend_time: 1345491706:0 resume_time: 1345491737:0 JDB: Trying to add: 31:0 (Looks reasonable.) Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this

Re: [PATCH 4/8] time: Condense timekeeper.xtime into xtime_sec

k (PowerBook6,7). The fact that the add-on commit is needed to uncover the bug might give a hint, but I'm unable to decipher it. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something complete

[PATCH] time: Fix casting issue in timekeeping_forward_now

arch_gettimeoffset returns a u32 value which when shifted by tk->shift can overflow. Cast it to u64 first. Signed-off-by: Andreas Schwab --- Found this by inspection, I don't know if any existing users of ARCH_USES_GETTIMEOFFSET are affected. In other words, this is untested, but look

Re: Regression: Spurious "^A" in UML output

Joe Perches writes: > Perhaps it's better to change the um STR macro instead The STR macro is only used to turn the expansion into a C string to be parsed by the compiler. The real problem is that the expansion now contains spaces, which makes the output ambigous. Andreas. -- Andrea

Re: [PATCH] ACPI: replace strlen("string") with sizeof("string") -1

that builtin strlen isn't disabled. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-ker

Re: Is iommu_num_pages() broken ?

gt; The above code will align the start before adding the len which is wrong addr & (io_page_size - 1) computes the offset into the page pointed to by addr. Looks right to me. addr & ~(io_page_size - 1) would round addr down to the start of the page. Andreas. -- Andreas Schwab, sch

Re: [PATCH] powerpc: fix personality handling in ppc64_personality()

PER_LINUX; That only "works" because PER_LINUX is 0. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line &qu

Re: [PATCH] posix_types.h: make __NFDBITS match glibc definition

Linus Torvalds writes: > But even before they were removed, they were inside #ifdef __KERNEL__ > protection, so it wasn't available to user code. They used to be exported for __GLIBC__ < 2, but that was removed in 2008. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG K

Re: [PATCH v2] posix_types.h: make __NFDBITS compatible with glibc definition

some kind of implies or header chain, the second is used. Look at the end of misc/sys/select.h. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe

Re: [Regression][Revert request] Excessive delay or hang during resume from system suspend due to a hrtimer commit

"Rafael J. Wysocki" writes: > On Monday, July 16, 2012, Thomas Gleixner wrote: >> Does the following patch fix the problem for you ? > > Yes, it does, thanks! Works for me as well. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7

Re: [PATCH 6/6] hrtimer: Update hrtimer base offsets each hrtimer_interrupt

Andreas Schwab writes: > This breaks resume on the iBook G4 (PowerBook6,7). Apparently during or > before noirq resume the system is hanging by the same amount of time as > the system was sleeping. The point where the time is wasted actually appears to be _after_ resume (the elapsed

Re: [PATCH 6/6] hrtimer: Update hrtimer base offsets each hrtimer_interrupt

This breaks resume on the iBook G4 (PowerBook6,7). Apparently during or before noirq resume the system is hanging by the same amount of time as the system was sleeping. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5

Re: 2.6.25-rc1/2 CD/DVD burning broken

Borislav Petkov <[EMAIL PROTECTED]> writes: > On Mon, Feb 25, 2008 at 11:08:55PM +0100, Andreas Schwab wrote: >> Borislav Petkov <[EMAIL PROTECTED]> writes: >> >> > On Mon, Feb 25, 2008 at 08:38:22PM +0100, Andreas Schwab wrote: >> >> "Kiyoshi

Re: 2.6.25-rc1/2 CD/DVD burning broken

Borislav Petkov <[EMAIL PROTECTED]> writes: > On Mon, Feb 25, 2008 at 08:38:22PM +0100, Andreas Schwab wrote: >> "Kiyoshi Ueda" <[EMAIL PROTECTED]> writes: >> >> > I'm looking at this problem, but currently no idea why the conversion >>

Re: 2.6.25-rc1/2 CD/DVD burning broken

"Kiyoshi Ueda" <[EMAIL PROTECTED]> writes: > I'm looking at this problem, but currently no idea why the conversion > to blk_end_request causes it. cdrom_newpc_intr apparently never sets rq->sense_len. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTE

Re: 2.6.25-rc1/2 CD/DVD burning broken

from kernel like "DMA error" when > the problem happens? Never. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something

Re: 2.6.25-rc1/2 CD/DVD burning broken

Borislav Petkov <[EMAIL PROTECTED]> writes: > burning a dvd here with growisofs works just fine. You probably don't have a Pioneer. > However, my strace -v won't dereference the struct pointer passed to > the ioctl: I use strace 4.5.16. Andreas. -- Andreas

Re: 2.6.25-rc1/2 CD/DVD burning broken

that resid always equals dxfer_len even when the transfer was successful, although growisofs does not seem to care. With 2.6.24.2 resid is only non-zero when a sense error occurred. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnber

Re: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div()

do_div(utemp64, mtemp); > freq_adj += temp64; Same. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 &

Re: 2.6.25-rc1/2 CD/DVD burning broken

> > This patch brings back the rq->data_len = 0. Looks good, I was successfully able to burn a CD-RW. Thanks, Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01

Re: [PATCH] next-20080218 build failure at pmac_ide_macio_attach ()

cio_dev * > int irq, rc; > hw_regs_t hw; > > - pmif = (struct pmac_ide_hwif)kzalloc(sizeof(*pmif), GFP_KERNEL); > + pmif = (struct pmac_ide_hwif*)kzalloc(sizeof(*pmif), GFP_KERNEL); Just remove the cast. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL

Re: [RFC][PATCH 7/7] CGroup API: Update cpusets to use cgroup structured file API

type > +echo > memory.control_type Looks like you stripped too much here. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for somet

Re: 2.6.25-rc1/2 CD/DVD burning broken

Mark Lord <[EMAIL PROTECTED]> writes: > Andreas Schwab wrote: >> Jeff Garzik <[EMAIL PROTECTED]> writes: >> >>> Andreas Schwab wrote: >>>> Since commit aaa04c28cb9a1efd42541fdb7ab648231c2a2263 [blk_end_request: >>>> changing ide

Re: 2.6.25-rc1/2 CD/DVD burning broken

Jeff Garzik <[EMAIL PROTECTED]> writes: > Andreas Schwab wrote: >> Since commit aaa04c28cb9a1efd42541fdb7ab648231c2a2263 [blk_end_request: >> changing ide-cd (take 4)] I cannot burn any CD/DVD any more, getting the >> following error from wodim: >> >> Errno:

2.6.25-rc1/2 CD/DVD burning broken

Bytes: 70 00 05 00 00 00 00 0E 00 00 00 00 21 02 00 00 Sense Key: 0x5 Illegal Request, Segment 0 Sense Code: 0x21 Qual 0x02 (invalid address for write) Fru 0x0 Sense flags: Blk 0 (not valid) resid: 63488 Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH

Re: Linux i386 clone(): %ebx 'frobbing' ?

"Ahmed S. Darwish" <[EMAIL PROTECTED]> writes: > Hi Andreas, > > On Fri, Feb 15, 2008, Andreas Schwab wrote: >> "Ahmed S. Darwish" <[EMAIL PROTECTED]> writes: >> >> > I don't understand how the `fn' argument reached the c

Re: Linux i386 clone(): %ebx 'frobbing' ?

what does that mean ? See "popl %ebx" after "int $0x80". Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something com

Re: [Patch] Elf loader crash while zero-filling .bss

It would, however, be valid to the kernel to round it up >> to the next boundary. > > I wasn't immediately sure if there is nothing in ELF specification that > would forbid that. The only requirement for a loadable segment is that its address is congruent modulo alignmen

Re: Elf loader crash while zero-filling .bss

nce the .bss section does not occupy any file space the other sections can be put directly behind it in the file. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 4

Re: [PATCH] Add explanation of I_DIRTY_DATASYNC bit

RTY_DATASYNC Data-related inode changes pending. We keep track of > + * ` these changes separately from I_DIRTY_SYNC so that we ^ Looks like a typo. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürn

Re: [RFT 1/1] single_chip test

t; - (srev >= AR5K_SREV_VER_AR2424)) { > - ah->ah_single_chip = true; > - } else { > - ah->ah_single_chip = false; > - } > + ah->ah_single_chip = !!(srev >= AR5K_SREV_VER_AR2424 && ^^ This is useless. Andreas

Re: Q: linux failed to execute /init?

t > <6>/sbin/init exit code: -14 > > Just wondering what do those different exit codes mean? #define EFAULT 14 /* Bad address */ Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fi

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

t work with -traditional. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubsc

Re: umount -l , getcwd and /proc//cwd inconsistent

ected string > but "/proc//cwd" returns an empty string. Builtin pwd just prints $PWD. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "

Re: strace, accept(), ERESTARTSYS and EINTR

that to > user-space, and that this modified return value is not reported by strace? Yes, assuming there was a signal handler and it wasn't registered with SA_RESTART. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, G

Re: strace, accept(), ERESTARTSYS and EINTR

"Phil Endecott" <[EMAIL PROTECTED]> writes: > Andreas Schwab wrote: >> "Phil Endecott" <[EMAIL PROTECTED]> writes: >> >>> However, there's a lot of code and I know that there are bugs in it. I >>> just want to focus on the ker

Re: strace, accept(), ERESTARTSYS and EINTR

up > (corrupts its stack, runs out of FDs/VM/threads etc), I don't think that I > should see in the strace output that accept() has returned > ERESTARTSYS. strace always sees the raw return value, before the signal handler is executed and before the check for syscall restart is do

Re: [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles

ude2 is only for O=... builds so to keep current > behaviour removing $(TOPDIR)/ would do it. Shouldn't that use $(LINUXINCLUDE), or $(KBUILD_CPPFLAGS)? Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprin

Re: [PATCH] pci: Fix bus resource assignment on 32 bits with 64b resources

t specs. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send

Re: Question regarding mutex locking

nlock() When two CPUs may enter the critical region at the same time, what is the point of the mutex? Also, the first CPU may unlock the mutex while the second one is still inside the critical region. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfelds

Re: m68k build failure

from >> easy. > > There are some ugly options: > > Cross compile a test object containing nothing but > > struct whatever fred; > > then dump it with the relevant cross nm Everything would be much easier if all those driver_data members of the device table stru

Re: m68k build failure

ize. A size of 10 is > just weird as the unpadded size is 9 bytes. Could you dump the > __mod_sdio_device_table section so we can determine if it is cropped or just > oddly padded. A size of 10 is correct. On m68k no type is aligned to more than 2 bytes. Andreas. -- Andreas Schwab, SuSE

Re: [patch 04/14] ia64: Remove the __SMALL_ADDR_AREA attribute for per cpu access

Christoph Lameter <[EMAIL PROTECTED]> writes: > On Tue, 27 Nov 2007, Andreas Schwab wrote: > >> Christoph Lameter <[EMAIL PROTECTED]> writes: >> >> > The model(small) attribute is not supported by gcc 4.X. >> >> Which gcc 4.X are you talking a

Re: [patch] timer_list should use signed numbers for relative times

>> >(unsigned long long)ktime_to_ns(timer->expires), >> >(unsigned long long)(ktime_to_ns(timer->expires) - now)); >> >> Perhaps change the cast as well. > > Well, that seems to be absolute time, so %Lu makes some sense... I don&#

Re: [patch] timer_list should use signed numbers for relative times

\n"); > - SEQ_printf(m, " # expires at %Lu nsecs [in %Lu nsecs]\n", > + SEQ_printf(m, " # expires at %Lu nsecs [in %Ld nsecs]\n", > (unsigned long long)ktime_to_ns(timer->expires), > (unsigned long long)(ktime_to_ns(timer->expires) -

Re: [patch 04/14] ia64: Remove the __SMALL_ADDR_AREA attribute for per cpu access

Christoph Lameter <[EMAIL PROTECTED]> writes: > The model(small) attribute is not supported by gcc 4.X. Which gcc 4.X are you talking about? Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerpri

Re: [KERNEL]: Avoid divide in IS_ALIGN

) - 1)) == 0) > > int main() > { > int i; > long p = 0x12345678; > for(i=1; i< 0x11; i++) > printf("Old = %d, new = %d\n", IS_ALIGNED(p, i), _IS_ALIGNED(p, i)); Alignment is only defined for powers of two. Andreas. -- Andreas Schwab, SuSE Lab

Re: top lies ?

gt; this case) mysqld process is 1.2g ? SWAP is just VIRT - RES. It means that 1.2g of the allocated virtual address space is not resident, but it does not mean that all of it is written to the swap space, it can also be part of a file based mapping. Andreas. -- Andreas Schwab, SuSE Lab

Re: [PATCH] Include header required for INT_MAX

"Robert P. J. Day" <[EMAIL PROTECTED]> writes: > On Mon, 12 Nov 2007, Andreas Schwab wrote: > >> Jan Engelhardt <[EMAIL PROTECTED]> writes: >> >> > No, because I be damn sure that some developers try compiling programs >> > in non-linux

Re: [PATCH] Include header required for INT_MAX

ery C compiler has . Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe f

Re: compat_sys_times() bogus until jiffies >= 0.

the ticks since process start time, which delays the wrap around much further. POSIX only demands consistency within the same process. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6

Re: compat_sys_times() bogus until jiffies >= 0.

return -EFAULT; > } > - return compat_jiffies_to_clock_t(jiffies); > + return compat_jiffies_to_clock_t((jiffies + INITIAL_JIFFIES) & > + LONG_MAX); Are you sure you want LONG_MAX here, not 0x7fff? And

<    1   2   3   4   5   6   >