Re: [RESEND PATCH 5/6] ASoC: cdn-dp: Add cdn DP codec driver

king on getting their code accepted in main > line. I have been trying to get my tda998x patches reviewed for some > time now, but not lately, because I have been busy with my other tasks. > > The two others are Philipp Zabel and Arnaud Pouliquen, both in cc. Not > sure if they

Re: [PATCH v4 17/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes

On 05/25/2016 06:06 PM, Peter Griffin wrote: > This patch adds the DT node for the uniperif reader > IP block found on STiH407 family silicon. > > Signed-off-by: Peter Griffin > --- > arch/arm/boot/dts/stih407-family.dtsi | 28 > 1 file

Re: [PATCH v4 15/18] ARM: STi: DT: STiH407: Add sti-sasg-codec dt node

On 05/25/2016 06:06 PM, Peter Griffin wrote: > This patch adds the dt node for the internal audio > codec IP. > > Signed-off-by: Peter Griffin > --- > arch/arm/boot/dts/stih407-family.dtsi | 9 + > 1 file changed, 9 insertions(+) > > diff --git

Re: [PATCH v4 11/18] ARM: multi_v7_defconfig: Enable STi and simple-card drivers.

Hi Peter, On 05/25/2016 06:06 PM, Peter Griffin wrote: > This patch enables the STi ALSA drivers found on STi platforms > as well as the simple-card driver which is a dependency to have > working sound. > > Signed-off-by: Peter Griffin > Cc: arnaud.pouliq...@st.com >

Re: [PATCH v4 16/18] ARM: STi: DT: STiH407: Add uniperif player dt nodes

On 05/25/2016 06:06 PM, Peter Griffin wrote: > This patch adds the DT nodes for the uniperif player > IP blocks found on STiH407 family silicon. > > Signed-off-by: Peter Griffin > --- > arch/arm/boot/dts/stih407-family.dtsi | 76 > +++

Re: [PATCH v4 18/18] ARM: DT: STi: stihxxx-b2120: Add DT nodes for STi audio card

On 05/25/2016 06:06 PM, Peter Griffin wrote: > This patch enables the uniperif players 2 & 3 for b2120 boards > and also adds the "simple-audio-card" device node to interconnect > the SoC sound device and the codec. > > Signed-off-by: Peter Griffin > --- >

Re: [PATCH 00/11] Clock improvement for video playback

Hello Gabriel, Tested with success on stih407 family platforms Reviewed-by: Arnaud Pouliquen <arnaud.pouliq...@st.com> Tested-by: Arnaud Pouliquen <arnaud.pouliq...@st.com> Regards Arnaud On 05/18/2016 10:41 AM, Gabriel Fernandez wrote: > This serie allows to increase vi

Re: [PATCH 09/18] ASoC: sti: Update DT example to match the driver code

On 04/26/2016 01:02 PM, Peter Griffin wrote: > Hi Mark, > > On Thu, 21 Apr 2016, Mark Brown wrote: > >> On Thu, Apr 21, 2016 at 12:04:26PM +0100, Peter Griffin wrote: >>> uniperiph-id, version and mode are ST specific bindings and >>> need the 'st,' prefix. Update the examples, as otherwise

Re: [PATCH 09/18] ASoC: sti: Update DT example to match the driver code

hello Arnd, peter, On 04/26/2016 01:44 PM, Arnd Bergmann wrote: > On Tuesday 26 April 2016 12:15:32 Peter Griffin wrote: >>> If not what would you recommend instead? >>> >>> It's still not clear to me what that bit in the syscfg register >>> is for. Given the error message about

Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes

016, Peter Griffin wrote: >>> >>>> This patch adds the DT node for the uniperif reader >>>> IP block found on STiH407 family silicon. >>>> >>>> Signed-off-by: Arnaud Pouliquen <arnaud.pouliq...@st.com> >>>> Signed-off-by:

Re: [PATCH -next] ASoC: sti: fix missing clk_disable_unprepare() on error in uni_player_start()

Hello Wei, Acked-by: Arnaud Pouliquen <arnaud.pouliq...@st.com> Thanks! On 09/17/2016 03:34 AM, Wei Yongjun wrote: > From: Wei Yongjun <weiyongj...@huawei.com> > > Fix the missing clk_disable_unprepare() before return > from uni_player_start() in the error handli

Re: [alsa-devel] [PATCH v2 2/2] drm/bridge: adv7511: restrict audio sample sizes

Hello Srinivas, On 08/01/2017 12:49 AM, srinivas.kandaga...@linaro.org wrote: > From: Srinivas Kandagatla > > ADV7533 only supports audio samples word width from 16-24 bits. > This patch restricts the audio sample sizes to the supported ones, > so that sound card

Re: [alsa-devel] [PATCH v2 2/2] drm/bridge: adv7511: restrict audio sample sizes

Hello Srinivas, On 08/01/2017 02:52 PM, Srinivas Kandagatla wrote: As example, if you configure bus in Left justified format with 24 bits sample length, 32 bits application samples should be truncated to 24 bits samples at ADV7533 I2S interface level (LSB dropped). >> >>> May be we

Re: [PATCH v2 1/2] ASoC: codec: use enable pin to control dmic start and stop

Hello Lin, Sorry for this late answer. I'm not maintainer, just a contributor... but as some update seems strange for me, so i prefer to highlight it to clarify them. On 08/17/2017 04:24 AM, Lin Huang wrote: > From: huang lin > > on some board use enable pin to control

Re: [PATCH v4 3/5] remoteproc: Pass type of shutdown to subdev remove

On 12/05/2017 07:46 AM, Bjorn Andersson wrote: > On Fri 01 Dec 06:50 PST 2017, Arnaud Pouliquen wrote: > >> hello Bjorn, >> >> Sorry for these late remarks/questions >> > > No worries, I'm happy to see you reading the patch! > >> >

Re: [PATCH v4 3/5] remoteproc: Pass type of shutdown to subdev remove

hello Bjorn, Sorry for these late remarks/questions On 11/30/2017 02:16 AM, Bjorn Andersson wrote: > remoteproc instances can be stopped either by invoking shutdown or by an > attempt to recover from a crash. For some subdev types it's expected to > clean up gracefully during a shutdown, but

Re: [PATCH v4 3/5] remoteproc: Pass type of shutdown to subdev remove

On 12/06/2017 10:53 PM, Bjorn Andersson wrote: > On Wed 06 Dec 00:55 PST 2017, Arnaud Pouliquen wrote: > >> Hello, >> >> I saw your new version but i 'm answering to this one to continue >> discussion. >> > > That's fine. > >> On 12/05/2017

Re: [PATCH v4 3/5] remoteproc: Pass type of shutdown to subdev remove

Hello, I saw your new version but i 'm answering to this one to continue discussion. On 12/05/2017 06:17 PM, Bjorn Andersson wrote: > On Tue 05 Dec 02:54 PST 2017, Arnaud Pouliquen wrote: > >> >> >> On 12/05/2017 07:46 AM, Bjorn Andersson wrote: >>> On

Re: [BUG] soc/sti: a possible sleep-in-atomic bug in uni_player_ctl_iec958_put

Hello Jia-Ju, On 12/12/2017 03:27 PM, Jia-Ju Bai wrote: > According to sound/soc/sti/uniperif_player.c, the driver may sleep under > a spinlock. > The function call path is: > uni_player_ctl_iec958_put (acquire the spinlock) >   uni_player_set_channel_status >     mutex_lock --> may sleep > > I

Re: [alsa-devel] [PATCH 0/3] ASoC: stm32: sai: add support of iec958 controls

On 06/05/2018 08:29 PM, Takashi Iwai wrote: > On Tue, 05 Jun 2018 17:50:57 +0200, > Arnaud Pouliquen wrote: >> >> Hi Takashi, >> >> On 04/17/2018 01:17 PM, Mark Brown wrote: >> > On Tue, Apr 17, 2018 at 08:29:17AM +, Olivier MOYSAN wrote:

Re: [alsa-devel] [PATCH 0/3] ASoC: stm32: sai: add support of iec958 controls

On 06/06/2018 11:47 AM, Takashi Iwai wrote: > On Wed, 06 Jun 2018 11:31:45 +0200, > Arnaud Pouliquen wrote: >> >> >> >> On 06/05/2018 08:29 PM, Takashi Iwai wrote: >> > On Tue, 05 Jun 2018 17:50:57 +0200, >> > Arnaud Pouliquen wrote: >>

Re: [PATCH 5/5] remoteproc: Introduce prepare and unprepare for subdevices

Hello Alex, On 05/15/2018 10:53 PM, Alex Elder wrote: > From: Bjorn Andersson > > On rare occasions a subdevice might need to prepare some hardware > resources before a remote processor is booted, and clean up some > state after it has been shut down. > > One such example is the IP

Re: [PATCH 4/5] remoteproc: rename subdev probe and remove functions

Hello Alex We have the same needs (prepare unprepare steps) on our platform. We tested you core patches and they answers to our need. Just a remark below On 05/15/2018 10:53 PM, Alex Elder wrote: > Rename functions used when subdevices are started and stopped to > reflect the new naming

Re: [PATCH 5/5] remoteproc: Introduce prepare and unprepare for subdevices

On 05/29/2018 01:51 PM, Alex Elder wrote: > On 05/29/2018 04:16 AM, Arnaud Pouliquen wrote: > . . . > >>> +unroll_preparation: >>> + list_for_each_entry_continue_reverse(subdev, >subdevs, node) { >>> + if (subdev->unprepare) >&g

Re: [PATCH 2/3] ASoC: stm32: sai: add iec958 controls support

Hi Olivier, On 03/13/2018 05:27 PM, Olivier MOYSAN wrote: > Add support of iec958 controls for STM32 SAI. > > Signed-off-by: Olivier Moysan > --- >  sound/core/pcm_iec958.c   |   1 + >  sound/soc/stm/Kconfig |   1 + >  sound/soc/stm/stm32_sai_sub.c | 101 >

Re: [alsa-devel] [PATCH 0/3] ASoC: stm32: sai: add support of iec958 controls

Hi Takashi, On 04/17/2018 01:17 PM, Mark Brown wrote: > On Tue, Apr 17, 2018 at 08:29:17AM +, Olivier MOYSAN wrote: > >> I guess the blocking patch in this patchset is the patch "add IEC958 >> channel status control helper". This patch has been reviewed several >> times, but did not get a

Re: [PATCH 5/5] remoteproc: Introduce prepare and unprepare for subdevices

Hi Fabien, Please , could you add your "Tested-by" as you test it on ST platform? Thanks Arnaud On 05/15/2018 10:53 PM, Alex Elder wrote: > From: Bjorn Andersson > > On rare occasions a subdevice might need to prepare some hardware > resources before a remote processor is booted, and clean up

Re: [PATCH v3 4/6] rpmsg: Guard against null endpoint ops in destroy

Hello Chris, On 04/27/2018 12:59 AM, Chris Lew wrote: > In RPMSG GLINK the chrdev device will allocate an ept as part of the > rpdev creation. This device will not register endpoint ops even though > it has an allocated ept. Protect against the case where the device is > being destroyed. > >

Re: [PATCH v3 4/6] rpmsg: Guard against null endpoint ops in destroy

On 04/30/2018 10:36 AM, Arnaud Pouliquen wrote: > Hello Chris, > > On 04/27/2018 12:59 AM, Chris Lew wrote: >> In RPMSG GLINK the chrdev device will allocate an ept as part of the >> rpdev creation. This device will not register endpoint ops even though >> it ha

Re: [PATCH] IIO: ADC: stm32-dfsdm: avoid unused-variable warning

On 01/11/2018 03:27 PM, Robin Murphy wrote: > On 11/01/18 10:34, Arnd Bergmann wrote: >> Building with CONFIG_OF disabled produces a compiler warning: >> >> drivers/iio/adc/stm32-dfsdm-core.c: In function 'stm32_dfsdm_probe': >> drivers/iio/adc/stm32-dfsdm-core.c:245:22: error: unused variable

Re: [PATCH] ASoC: codecs: dmic: Use channel map for configs with a single mic

Hello Matthias, Please find comments in line On 01/04/2018 08:54 PM, Matthias Kaehlcke wrote: > + Brian & Dylan > > El Thu, Jan 04, 2018 at 11:48:48AM -0800 Matthias Kaehlcke ha dit: > >> The DMIC DAI driver specifies a number of 1 to 8 channels for each DAI. >> The actual number of mics can

Re: [RFC] rpmsg: virtio rpmsg: Add RPMsg char driver support

Hi Wendy, Few remarks on your patch. On 01/05/2018 12:18 AM, Wendy Liang wrote: > virtio rpmsg was not implemented to use RPMsg char driver. > Each virtio ns announcement will create a new RPMsg device which > is supposed to bound to a RPMsg driver. It doesn't support > dynamic endpoints with

Re: [PATCH] ASoC: codecs: dmic: Make number of channels configurable

Hello Mathias, Next time could you add patch version in your mail subject ( [PATCH vX]) easier to follow versions :-). otherwise, Acked-by: Arnaud Pouliquen <arnaud.pouliq...@st.com> Regards, Arnaud On 01/05/2018 09:39 PM, Matthias Kaehlcke wrote: > The DMIC DAI driver specifies a nu

Re: [RFC] rpmsg: virtio rpmsg: Add RPMsg char driver support

On 01/05/2018 11:10 PM, Jiaying Liang wrote: > > >> -Original Message----- >> From: Arnaud Pouliquen [mailto:arnaud.pouliq...@st.com] >> Sent: Friday, January 05, 2018 6:48 AM >> To: Jiaying Liang <jli...@xilinx.com>; o...@wizery.com; >> bjorn

Re: [PATCH] IIO: ADC: stm32-dfsdm: remove unused variable

Hi Arnd, On 01/17/2018 03:46 PM, Arnd Bergmann wrote: > A cleanup left one variable behind that is no longer needed and > can be removed, as shown by the gcc warning: > > drivers/iio/adc/stm32-dfsdm-core.c: In function 'stm32_dfsdm_probe': > drivers/iio/adc/stm32-dfsdm-core.c:245:29: error:

Re: [PATCH] dt-bindings: iio: adc: sd-modulator: fix io-channel-cells

Hello, Acked-by: Arnaud Pouliquen <arnaud.pouliq...@st.com> Regards, Arnaud On 02/23/2018 12:07 PM, Fabrice Gasnier wrote: > io-channel-cells should be <0> since sigma delta modulator exports only > one channel, as described in ../iio/iio-bindings.txt "IIO providers"

Re: [PATCH] dt-bindings: iio: adc: stm32-dfsdm: fix types, add missing pinctrl

Hello, Acked-by: Arnaud Pouliquen <arnaud.pouliq...@st.com> Regards, Arnaud On 02/23/2018 12:11 PM, Fabrice Gasnier wrote: > - Add missing pinctrl description. Support is made optional as dfsdm > may use internal sources (e.g. via registers) > - Fix typo in IIO STM32 DFSDM

Re: [PATCH 0/7] iio: adc: stm32-dfsdm: misc fixes and improvements

Hello, For the series: Acked-by: Arnaud Pouliquen <arnaud.pouliq...@st.com> Thanks, Arnaud On 02/23/2018 01:50 PM, Fabrice Gasnier wrote: > This series brings some fixes and improvements to STM32 DFSDM driver. > > Fabrice Gasnier (7): > iio: adc: stm32-dfsdm: fix compatibl

Re: [PATCH 0/2] iio: stm32-dfsdm-adc: fix filter & rate setting

Hello, For the series: Acked-by: Arnaud Pouliquen <arnaud.pouliq...@st.com> Thanks, Arnaud On 03/13/2018 03:23 PM, Fabrice Gasnier wrote: > This series brings fixes to STM32 DFSDM ADC driver. > > Fabrice Gasnier (2): > iio: adc: stm32-dfsdm: fix successive oversampling set

[PATCH] remoteproc: fix crashed parameter logic on stop call.

Fix rproc_add_subdev parameter name and inverse the crashed logic. Fixes: "remoteproc: Pass type of shutdown to subdev remove" Signed-off-by: Arnaud Pouliquen <arnaud.pouliq...@st.com> --- drivers/remoteproc/remoteproc_core.c | 4 ++-- include/linux/remoteproc.h

Re: [PATCH] remoteproc: rename "crashed" parameter

Hello Alex, I have already proposed it few weeks ago. https://lkml.org/lkml/2018/4/10/192 could you ack it, if you test it on your side? Thanks, Arnaud On 04/25/2018 03:36 PM, Alex Elder wrote: > The last commit to "remoteproc_core.c": > 880f5b388252 remoteproc: eAPass type of shutdown to

Re: [PATCH V4 0/4] Add TIOCM Signals support for RPMSG char devices

Hi Arun, Bjorn, On 10/08/2018 08:38 AM, Arun Kumar Neelakantam wrote: > Glink transport support signals to exchange state notification between > local and remote side clients. Adding support to send/receive the signal > command and notify the clients through callback and POLL notification.

Re: [PATCH V4 0/4] Add TIOCM Signals support for RPMSG char devices

On 10/09/2018 08:27 PM, Bjorn Andersson wrote: > On Tue 09 Oct 09:02 PDT 2018, Arnaud Pouliquen wrote: > >> hello Bjorn, >> >> On 10/08/2018 06:23 PM, Bjorn Andersson wrote: >>> On Mon 08 Oct 06:08 PDT 2018, Arnaud Pouliquen wrote: >>> >>>>

Re: [alsa-devel] [PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

Hello Rohit, On 11/2/18 1:06 PM, Rohit Kumar wrote: > > On 11/2/2018 1:12 PM, Takashi Iwai wrote: >> On Thu, 01 Nov 2018 13:38:49 +0100, >> Rohit kumar wrote: >>> Remove no_pcm check to invoke pcm_new() for backend dai-links >>> too. This fixes crash in hdmi codec driver during

Re: linux-4.20-rc1/sound/soc/stm/stm32_sai_sub.c:343: Faulty error check

Hello David, On 11/5/18 2:33 PM, David Binderman wrote: > Hello there, > > linux-4.20-rc1/sound/soc/stm/stm32_sai_sub.c:343]: (style) Checking if > unsigned variable 'div' is less than zero. > > Source code is > >     div = stm32_sai_get_clk_div(sai, parent_rate, rate); >     if (div <

Re: [alsa-devel] [PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

Hello Rohit On 11/5/18 7:14 PM, Rohit Kumar wrote: > Hello Arnaud, > > > On 11/5/2018 4:43 PM, Arnaud Pouliquen wrote: >> Hello Rohit, >> >> On 11/2/18 1:06 PM, Rohit Kumar wrote: >>> On 11/2/2018 1:12 PM, Takashi Iwai wrote: >>>> On Thu,

Re: [PATCH V4 0/4] Add TIOCM Signals support for RPMSG char devices

hello Bjorn, On 10/08/2018 06:23 PM, Bjorn Andersson wrote: > On Mon 08 Oct 06:08 PDT 2018, Arnaud Pouliquen wrote: > >> Hi Arun, Bjorn, >> >> On 10/08/2018 08:38 AM, Arun Kumar Neelakantam wrote: >>> Glink transport support signals to exchange state notifica

Re: [PATCH 1/5] remoteproc: Fix unbalanced boot with sysfs for no auto-boot rprocs

; > rproc_shutdown(rproc); > + if (!rproc->auto_boot) > + module_put(dev->parent->driver->owner); > } else { > dev_err(>dev, "Unrecognised option: %s\n", buf); > ret = -EINVAL; > Looks good for me, i tested on ST platform and did not detect any regression. Acked-by: Arnaud Pouliquen Regards Arnaud

Re: [PATCH 4/5] remoteproc: Introduce deny_sysfs_ops flag

Hi Suman, On 09/15/2018 02:37 AM, Suman Anna wrote: > The remoteproc framework provides sysfs interfaces for changing > the firmware name and for starting/stopping a remote processor > through the sysfs files 'state' and 'firmware'. These interfaces > are currently allowed irrespective of how the

Re: [PATCH 2/5] remoteproc: Check for NULL firmwares in sysfs interface

t it is relevant, as it treats only a part of the problem. But it's fine with me if it is accepted. Tested-by: Arnaud Pouliquen Regards Arnaud > > p = kstrndup(buf, len, GFP_KERNEL); > if (!p) { >

Re: [PATCH] rpmsg: core: add support to power domains for devices

Hi Suman, On 09/25/2018 09:02 PM, Suman Anna wrote: > Hi Arnaud, > >> On 09/25/2018 02:25 AM, Suman Anna wrote: >>> Hi Srinivas, >>> >>> On 06/15/2018 04:59 AM, Srinivas Kandagatla wrote: Some of the rpmsg devices need to switch on power domains to communicate with remote processor.

Re: [PATCH] rpmsg: core: add support to power domains for devices

Hi Suman On 09/25/2018 02:25 AM, Suman Anna wrote: > Hi Srinivas, > > On 06/15/2018 04:59 AM, Srinivas Kandagatla wrote: >> Some of the rpmsg devices need to switch on power domains to communicate >> with remote processor. For example on Qualcomm DB820c platform LPASS >> power domain needs to

Re: [PATCH 0/2] iio: stm32-dfsdm-adc: fix filter & rate setting

Hello, For the series: Acked-by: Arnaud Pouliquen Thanks, Arnaud On 03/13/2018 03:23 PM, Fabrice Gasnier wrote: > This series brings fixes to STM32 DFSDM ADC driver. > > Fabrice Gasnier (2): > iio: adc: stm32-dfsdm: fix successive oversampling settings > iio: adc: stm32-df

Re: [PATCH v3 4/6] rpmsg: Guard against null endpoint ops in destroy

Hello Chris, On 04/27/2018 12:59 AM, Chris Lew wrote: > In RPMSG GLINK the chrdev device will allocate an ept as part of the > rpdev creation. This device will not register endpoint ops even though > it has an allocated ept. Protect against the case where the device is > being destroyed. > >

Re: [PATCH v3 4/6] rpmsg: Guard against null endpoint ops in destroy

On 04/30/2018 10:36 AM, Arnaud Pouliquen wrote: > Hello Chris, > > On 04/27/2018 12:59 AM, Chris Lew wrote: >> In RPMSG GLINK the chrdev device will allocate an ept as part of the >> rpdev creation. This device will not register endpoint ops even though >> it ha

Re: [PATCH] remoteproc: rename "crashed" parameter

Hello Alex, I have already proposed it few weeks ago. https://lkml.org/lkml/2018/4/10/192 could you ack it, if you test it on your side? Thanks, Arnaud On 04/25/2018 03:36 PM, Alex Elder wrote: > The last commit to "remoteproc_core.c": > 880f5b388252 remoteproc: eAPass type of shutdown to

Re: [alsa-devel] [PATCH v2 2/2] drm/bridge: adv7511: restrict audio sample sizes

Hello Srinivas, On 08/01/2017 12:49 AM, srinivas.kandaga...@linaro.org wrote: > From: Srinivas Kandagatla > > ADV7533 only supports audio samples word width from 16-24 bits. > This patch restricts the audio sample sizes to the supported ones, > so that sound card does not report wrong list of

Re: [alsa-devel] [PATCH v2 2/2] drm/bridge: adv7511: restrict audio sample sizes

Hello Srinivas, On 08/01/2017 02:52 PM, Srinivas Kandagatla wrote: As example, if you configure bus in Left justified format with 24 bits sample length, 32 bits application samples should be truncated to 24 bits samples at ADV7533 I2S interface level (LSB dropped). >> >>> May be we

Re: [PATCH] ASoC: codecs: dmic: Make number of channels configurable

Hello Mathias, Next time could you add patch version in your mail subject ( [PATCH vX]) easier to follow versions :-). otherwise, Acked-by: Arnaud Pouliquen Regards, Arnaud On 01/05/2018 09:39 PM, Matthias Kaehlcke wrote: > The DMIC DAI driver specifies a number of 1 to 8 channels for e

Re: [RFC] rpmsg: virtio rpmsg: Add RPMsg char driver support

On 01/05/2018 11:10 PM, Jiaying Liang wrote: > > >> -Original Message----- >> From: Arnaud Pouliquen [mailto:arnaud.pouliq...@st.com] >> Sent: Friday, January 05, 2018 6:48 AM >> To: Jiaying Liang ; o...@wizery.com; >> bjorn.anders...@linaro.org >

Re: [PATCH] IIO: ADC: stm32-dfsdm: avoid unused-variable warning

On 01/11/2018 03:27 PM, Robin Murphy wrote: > On 11/01/18 10:34, Arnd Bergmann wrote: >> Building with CONFIG_OF disabled produces a compiler warning: >> >> drivers/iio/adc/stm32-dfsdm-core.c: In function 'stm32_dfsdm_probe': >> drivers/iio/adc/stm32-dfsdm-core.c:245:22: error: unused variable

Re: [PATCH] ASoC: codecs: dmic: Use channel map for configs with a single mic

Hello Matthias, Please find comments in line On 01/04/2018 08:54 PM, Matthias Kaehlcke wrote: > + Brian & Dylan > > El Thu, Jan 04, 2018 at 11:48:48AM -0800 Matthias Kaehlcke ha dit: > >> The DMIC DAI driver specifies a number of 1 to 8 channels for each DAI. >> The actual number of mics can

Re: [RFC] rpmsg: virtio rpmsg: Add RPMsg char driver support

Hi Wendy, Few remarks on your patch. On 01/05/2018 12:18 AM, Wendy Liang wrote: > virtio rpmsg was not implemented to use RPMsg char driver. > Each virtio ns announcement will create a new RPMsg device which > is supposed to bound to a RPMsg driver. It doesn't support > dynamic endpoints with

Re: [PATCH v4 3/5] remoteproc: Pass type of shutdown to subdev remove

On 12/05/2017 07:46 AM, Bjorn Andersson wrote: > On Fri 01 Dec 06:50 PST 2017, Arnaud Pouliquen wrote: > >> hello Bjorn, >> >> Sorry for these late remarks/questions >> > > No worries, I'm happy to see you reading the patch! > >> >

Re: [PATCH v4 3/5] remoteproc: Pass type of shutdown to subdev remove

Hello, I saw your new version but i 'm answering to this one to continue discussion. On 12/05/2017 06:17 PM, Bjorn Andersson wrote: > On Tue 05 Dec 02:54 PST 2017, Arnaud Pouliquen wrote: > >> >> >> On 12/05/2017 07:46 AM, Bjorn Andersson wrote: >>> On

Re: [PATCH v2 1/2] ASoC: codec: use enable pin to control dmic start and stop

Hello Lin, Sorry for this late answer. I'm not maintainer, just a contributor... but as some update seems strange for me, so i prefer to highlight it to clarify them. On 08/17/2017 04:24 AM, Lin Huang wrote: > From: huang lin > > on some board use enable pin to control dmic start and stop, >

[PATCH] remoteproc: fix crashed parameter logic on stop call.

Fix rproc_add_subdev parameter name and inverse the crashed logic. Fixes: "remoteproc: Pass type of shutdown to subdev remove" Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 4 ++-- include/linux/remoteproc.h | 2 +- 2 files changed, 3 insert

Re: [PATCH] dt-bindings: iio: adc: sd-modulator: fix io-channel-cells

Hello, Acked-by: Arnaud Pouliquen Regards, Arnaud On 02/23/2018 12:07 PM, Fabrice Gasnier wrote: > io-channel-cells should be <0> since sigma delta modulator exports only > one channel, as described in ../iio/iio-bindings.txt "IIO providers" > section. Only the pha

Re: [PATCH] dt-bindings: iio: adc: stm32-dfsdm: fix types, add missing pinctrl

Hello, Acked-by: Arnaud Pouliquen Regards, Arnaud On 02/23/2018 12:11 PM, Fabrice Gasnier wrote: > - Add missing pinctrl description. Support is made optional as dfsdm > may use internal sources (e.g. via registers) > - Fix typo in IIO STM32 DFSDM filter "MANCH_F" descr

Re: [PATCH 0/7] iio: adc: stm32-dfsdm: misc fixes and improvements

Hello, For the series: Acked-by: Arnaud Pouliquen Thanks, Arnaud On 02/23/2018 01:50 PM, Fabrice Gasnier wrote: > This series brings some fixes and improvements to STM32 DFSDM driver. > > Fabrice Gasnier (7): > iio: adc: stm32-dfsdm: fix compatible data use > iio: adc: s

Re: [PATCH v4 3/5] remoteproc: Pass type of shutdown to subdev remove

On 12/06/2017 10:53 PM, Bjorn Andersson wrote: > On Wed 06 Dec 00:55 PST 2017, Arnaud Pouliquen wrote: > >> Hello, >> >> I saw your new version but i 'm answering to this one to continue >> discussion. >> > > That's fine. > >> On 12/05/2017

Re: [PATCH v4 3/5] remoteproc: Pass type of shutdown to subdev remove

hello Bjorn, Sorry for these late remarks/questions On 11/30/2017 02:16 AM, Bjorn Andersson wrote: > remoteproc instances can be stopped either by invoking shutdown or by an > attempt to recover from a crash. For some subdev types it's expected to > clean up gracefully during a shutdown, but

Re: [BUG] soc/sti: a possible sleep-in-atomic bug in uni_player_ctl_iec958_put

Hello Jia-Ju, On 12/12/2017 03:27 PM, Jia-Ju Bai wrote: > According to sound/soc/sti/uniperif_player.c, the driver may sleep under > a spinlock. > The function call path is: > uni_player_ctl_iec958_put (acquire the spinlock) >   uni_player_set_channel_status >     mutex_lock --> may sleep > > I

Re: [PATCH v2 00/16] introduce generic IOCTL interface for RPMsg channels management

Hi Mathieu, On 1/13/21 9:31 PM, Mathieu Poirier wrote: > Hi Arnaud, > > [...] > >> >> Arnaud Pouliquen (16): >> rpmsg: introduce RPMsg control driver for channel creation >> rpmsg: add RPMsg control API to register service >> rpmsg: add overr

Re: [Linux-stm32] [PATCH] rpmsg: char: return an error if device already open

Hi Bjorn, On 1/25/21 4:31 PM, Bjorn Andersson wrote: > On Fri 15 Jan 03:13 CST 2021, Arnaud POULIQUEN wrote: > >> Hi Mathieu, >> >> >> On 1/14/21 8:05 PM, Mathieu Poirier wrote: >>> On Wed, Jan 06, 2021 at 02:37:14PM +0100, Arnaud Pouliquen wrote: >&g

Re: [PATCH v2 04/16] rpmsg: ctrl: implement the ioctl function to create device

Hi Mathieu, On 1/22/21 9:59 PM, Mathieu Poirier wrote: > On Fri, Jan 22, 2021 at 02:05:27PM +0100, Arnaud POULIQUEN wrote: >> Hi Mathieu, >> >> On 1/22/21 12:52 AM, Mathieu Poirier wrote: >>> On Tue, Dec 22, 2020 at 11:57:14AM +0100, Arnaud Pouliquen wrote: >

Re: [PATCH v2 04/16] rpmsg: ctrl: implement the ioctl function to create device

Hi Mathieu, On 1/22/21 12:52 AM, Mathieu Poirier wrote: > On Tue, Dec 22, 2020 at 11:57:14AM +0100, Arnaud Pouliquen wrote: >> Implement the ioctl function that parses the list of >> rpmsg drivers registered to create an associated device. >> To be ISO user

[PATCH] rpmsg: char: return an error if device already open

point interface") Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_char.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c index 4bbbacdbf3bb..360a1ab0a9c4 100644 --- a/drivers/rpmsg/rpmsg_char.c +++ b/drivers/rpmsg/rp

Re: [Linux-stm32] [PATCH] rpmsg: char: return an error if device already open

Hi Mathieu, On 1/14/21 8:05 PM, Mathieu Poirier wrote: > On Wed, Jan 06, 2021 at 02:37:14PM +0100, Arnaud Pouliquen wrote: >> The rpmsg_create_ept function is invoked when the device is opened. >> As only one endpoint must be created per device. It is not >> possible to

Re: [PATCH v6 0/3] Move recovery/coredump configuration to sysfs

On 9/29/20 4:33 PM, Bjorn Andersson wrote: > On Tue 29 Sep 03:44 CDT 2020, Arnaud POULIQUEN wrote: > >> >> >> On 9/29/20 12:17 AM, Rishabh Bhatnagar wrote: >>> From Android R onwards Google has restricted access to debugfs in user >>> and user-d

Re: [PATCH v6 2/3] remoteproc: Move recovery configuration to sysfs

On 9/29/20 12:17 AM, Rishabh Bhatnagar wrote: > Move recovery configuration from debugfs to sysfs.This will > allow usage of this configuration feature in production > devices where access to debugfs might be limited. > > Signed-off-by: Rishabh Bhatnagar > --- >

Re: [PATCH v6 2/3] remoteproc: Move recovery configuration to sysfs

On 9/30/20 10:11 AM, Arnaud POULIQUEN wrote: > > > On 9/29/20 12:17 AM, Rishabh Bhatnagar wrote: >> Move recovery configuration from debugfs to sysfs.This will >> allow usage of this configuration feature in production >> devices where access to debugfs might b

Re: [PATCH 02/10] rpmsg: core: Add channel creation internal API

On 9/30/20 8:35 AM, Guennadi Liakhovetski wrote: > On Mon, Sep 21, 2020 at 06:09:52PM -0600, Mathieu Poirier wrote: >> From: Arnaud Pouliquen >> >> Add the channel creation API as a first step to be able to define the >> name service announcement as a rpmsg driver

Re: [PATCH 06/10] rpmsg: Turn name service into a stand alone driver

On 9/30/20 9:09 AM, Guennadi Liakhovetski wrote: > On Mon, Sep 21, 2020 at 06:09:56PM -0600, Mathieu Poirier wrote: >> From: Arnaud Pouliquen >> >> Make the RPMSG name service announcement a stand alone driver so that it >> can be reused by other subsystems.

Re: [PATCH v2 2/9] rpmsg: Introduce __rpmsg{16|32|64} types

@@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Follows implementation found in linux/virtio_byteorder.h > + */ > +#ifndef _LINUX_RPMSG_BYTEORDER_H > +#define _LINUX_RPMSG_BYTEORDER_H > +#include > +#include > + > +static inline bool rpmsg_is_little_endian(v

Re: [PATCH v2 3/9] rpmsg: virtio: Move from virtio to rpmsg byte conversion

On 10/14/20 1:25 AM, Mathieu Poirier wrote: > Use rpmsg byte conversion functions in order for the RPMSG > headers and generic functions to be used by external entities. > > Signed-off-by: Mathieu Poirier > --- > drivers/rpmsg/virtio_rpmsg_bus.c | 60 +++- > 1

Re: [PATCH v2 4/9] rpmsg: Move rpmsg_hr and rpmsg_ns_msg to header file

Hi Mathieu, On 10/14/20 1:25 AM, Mathieu Poirier wrote: > Move structures rpmsg_hdr and rpmsg_ns_msg to their own header file > so that they can be used by other entities. > > Signed-off-by: Mathieu Poirier > --- > drivers/rpmsg/virtio_rpmsg_bus.c | 58 ++ >

Re: [PATCH v2 8/9] rpmsg: Make rpmsg_{register|unregister}_device() public

nregister_rpmsg_device(struct rpmsg_device *dev) > +static inline int rpmsg_unregister_device(struct device *parent, > + struct rpmsg_channel_info *chinfo) > { > /* This shouldn't be possible */ > WARN_ON(1); > + > + return -ENXIO; > } > > static inline int __register_rpmsg_driver(struct rpmsg_driver *drv, > Reviewed-by: Arnaud Pouliquen Thanks, Arnaud

Re: [PATCH v2 1/9] rpmsg: Move rpmsg_endpoint_ops to rpmsg.h

@ -59,8 +79,6 @@ struct rpmsg_device { > const struct rpmsg_device_ops *ops; > }; > > -typedef int (*rpmsg_rx_cb_t)(struct rpmsg_device *, void *, int, void *, > u32); > - > /** > * struct rpmsg_endpoint - binds a local rpmsg address to its user > * @rpdev: rpmsg channel device > Reviewed-by: Arnaud Pouliquen Thanks, Arnaud

Re: [PATCH v2 2/9] rpmsg: Introduce __rpmsg{16|32|64} types

On 10/15/20 9:32 PM, Mathieu Poirier wrote: > Good day, > > On Wed, Oct 14, 2020 at 06:31:49PM +0200, Arnaud POULIQUEN wrote: >> Hi Mathieu, >> >> On 10/14/20 1:25 AM, Mathieu Poirier wrote: >>> Introduce __rpmsg{16|32|64} types along with byte

Re: [PATCH v2 4/9] rpmsg: Move rpmsg_hr and rpmsg_ns_msg to header file

On 10/15/20 10:19 PM, Mathieu Poirier wrote: > On Thu, Oct 15, 2020 at 10:33:25AM +0200, Arnaud POULIQUEN wrote: >> Hi Mathieu, >> >> On 10/14/20 1:25 AM, Mathieu Poirier wrote: >>> Move structures rpmsg_hdr and rpmsg_ns_msg to their own header file >>

Re: [PATCH 8/9] rpmsg: virtio: use rpmsg_ns driver to manage ns announcement

On 8/27/20 12:10 AM, Mathieu Poirier wrote: > I had another very long look at this... I haven't had the time to look in > your > next serie so the end result is not yet clear in my head. But... > > In __rpmsg_create_channel() the new code is testing for VIRTIO_RPMSG_F_NS in > order to

[PATCH 2/3] dt-bindings: remoteproc: stm32_rproc: update for firmware synchronization

Add new properties description used to attach to a pre-loaded firmware according to the commit 9276536f455b3 ("remoteproc: stm32: Parse syscon that will manage M4 synchronisation") which updates the driver part. Signed-off-by: Arnaud Pouliquen --- .../bindings/remoteproc/st,stm32-

[PATCH 1/3] dt-bindings: arm: stm32: Add compatible for syscon tamp node

Since commit ad440432d1f9 ("dt-bindings: mfd: Ensure 'syscon' has a more specific compatible") It is required to provide at least 2 compatibles string for syscon node. This patch documents the new compatible for stm32 SoC to support TAMP registers access. Signed-off-by: Arnaud

[PATCH 3/3] ARM: dts: stm32: update stm32mp151 for remote proc synchronisation support

9276536f455b3 ("remoteproc: stm32: Parse syscon that will manage M4 synchronisation"). Signed-off-by: Arnaud Pouliquen --- arch/arm/boot/dts/stm32mp151.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi index bf

[PATCH 0/3] ARM: stm32: add DT properties for remote proc synchronisation

This series implements the DT part associated to the commit 9276536f455b3 ("remoteproc: stm32: Parse syscon that will manage M4 synchronisation") Arnaud Pouliquen (3): dt-bindings: arm: stm32: Add compatible for syscon tamp node dt-bindings: remoteproc: stm32_rproc: update fo

Re: [PATCH] remoteproc: stm32: Fix pointer assignement

-by: Mathieu Poirier Acked-by: Arnaud Pouliquen Thanks, Arnaud > --- > drivers/remoteproc/stm32_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/stm32_rproc.c > b/drivers/remoteproc/stm32_rproc.c > index f4da42fc0ee

Re: [PATCH 00/13] remoteproc: Add support for detaching from rproc

Hi Mathieu, On 8/26/20 6:45 PM, Mathieu Poirier wrote: > Following the work done here [1] this set provides support for the > remoteproc core to release resources associated with a remote processor > without having to switch it off. That way a platform driver can be removed > or the applcation

Re: [PATCH v2 5/8] rpmsg: introduce reserved rpmsg driver for ns announcement

Hi mathieu, On 9/19/20 1:10 AM, Mathieu Poirier wrote: > Hey Arnaud, > > On Tue, Aug 25, 2020 at 06:49:04PM +0200, Arnaud Pouliquen wrote: >> The name service announcement should not be linked to the RPMsg virtio bus >> but to the RPMsg protocol itself. >> >

Re: [PATCH 2/3] dt-bindings: remoteproc: stm32_rproc: update for firmware synchronization

Hi Rob, On 9/9/20 10:22 PM, Rob Herring wrote: > On Thu, Aug 27, 2020 at 09:21:00AM +0200, Arnaud Pouliquen wrote: >> Add new properties description used to attach to a pre-loaded >> firmware according to the commit 9276536f455b3 >> ("remoteproc: stm32: Parse

  1   2   3   4   5   6   >