[PATCH] PCI: pci_bus_add_device() should succeed even if creating sysfs files fails

2013-04-17 Thread Artem Savkov
9e4164edb7144ba6 ]--- [0.319015] swapper/0 (1) used greatest stack depth: 5720 bytes left [0.320011] Kernel panic - not syncing: Attempted to kill init! exitcode=0x000b [0.320011] Signed-off-by: Artem Savkov artem.sav...@gmail.com --- drivers/pci/bus.c |4 +--- drivers/pci/pci.h

Re: [PATCH] PCI: pci_bus_add_device() should succeed even if creating sysfs files fails

2013-04-17 Thread Artem Savkov
On Wed, Apr 17, 2013 at 10:42:12AM -0600, Bjorn Helgaas wrote: On Wed, Apr 17, 2013 at 9:54 AM, Bjorn Helgaas bhelg...@google.com wrote: On Wed, Apr 17, 2013 at 5:06 AM, Artem Savkov artem.sav...@gmail.com wrote: Introduced in cc8f7f9e4e79a0940af6b4b6fdfbcf18a03aa9f4 (PCI: Fix

[PATCH] acpi/video: lcd_get_level_current doen't return current level

2013-03-30 Thread Artem Savkov
acpi_video_device_lcd_get_level_current() called acpi_video_bqc_value_to_level() with *level as a second argument, resulting in level being returned based on initial input, not current brightness, breaking backlight controls. Signed-off-by: Artem Savkov artem.sav...@gmail.com --- drivers/acpi

[PATCH] net/wireless/sme: sched_scan_mtx lock in cfg80211_conn_work()

2013-03-30 Thread Artem Savkov
+0x94/0xa0 [ 51.996812] [c106] ? profiling_show+0x10/0x30 [ 51.996823] [c170c277] ret_from_kernel_thread+0x1b/0x28 [ 51.996830] [c105a330] ? __init_kthread_worker+0x60/0x60 [ 51.996835] ---[ end trace 6c56f7f4ff21820b ]--- Signed-off-by: Artem Savkov artem.sav...@gmail.com --- net

Re: [PATCH] acpi/video: lcd_get_level_current doen't return current level

2013-03-31 Thread Artem Savkov
On Sun, Mar 31, 2013 at 08:15:14AM +0200, Danny Baumann wrote: Artem Savkov artem.sav...@gmail.com schrieb: acpi_video_device_lcd_get_level_current() called acpi_video_bqc_value_to_level() with *level as a second argument, resulting in level being returned based on initial input, not current

Re: [PATCH] acpi/video: lcd_get_level_current doen't return current level

2013-03-31 Thread Artem Savkov
On Sun, Mar 31, 2013 at 09:04:21AM +0200, Danny Baumann wrote: Hi, Artem Savkov artem.sav...@gmail.com schrieb: On Sun, Mar 31, 2013 at 08:15:14AM +0200, Danny Baumann wrote: Artem Savkov artem.sav...@gmail.com schrieb: acpi_video_device_lcd_get_level_current() called

Re: [PATCH] acpi/video: lcd_get_level_current doen't return current level

2013-03-31 Thread Artem Savkov
On Sun, Mar 31, 2013 at 06:07:57PM +0800, Aaron Lu wrote: On 03/31/2013 04:16 PM, Artem Savkov wrote: On Sun, Mar 31, 2013 at 09:04:21AM +0200, Danny Baumann wrote: Hi, Artem Savkov artem.sav...@gmail.com schrieb: On Sun, Mar 31, 2013 at 08:15:14AM +0200, Danny Baumann wrote: Artem

[PATCH] dmi_scan: proper buf type in dmi_present()

2013-03-12 Thread Artem Savkov
or invalid. Introduced in dmi_scan: refactor dmi_scan_machine(), {smbios,dmi}_present() Signed-off-by: Artem Savkov artem.sav...@gmail.com --- drivers/firmware/dmi_scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c index

[PATCH] workqueue: missing idr_preload_end() in worker_pool_assign_id()

2013-03-13 Thread Artem Savkov
/0xd0 [0.171133] [c1695b37] ret_from_kernel_thread+0x1b/0x28 [0.171234] [c1676960] ? rest_init+0xd0/0xd0 Introduced in workqueue: convert to idr_alloc() Signed-off-by: Artem Savkov artem.sav...@gmail.com --- kernel/workqueue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel

Re: [PATCH] thinkpad-acpi: fix potential suspend blocking issue

2013-03-06 Thread Artem Savkov
On Wed, Mar 06, 2013 at 04:50:39PM +0100, Oleg Nesterov wrote: On 03/05, Andrew Morton wrote: Basically the same as http://ozlabs.org/~akpm/mmots/broken-out/drivers-platform-x86-thinkpad_acpic-move-hotkey_thread_mutex-lock-after-set_freezable.patch. I think Artem's patch is a little

Re: [PATCH 0/4] CPUFreq Fixes for 3.9

2013-02-07 Thread Artem Savkov
On Thu, Feb 07, 2013 at 03:57:42PM +0530, Viresh Kumar wrote: Hi Rafael, This is another unplanned patchset for all the platforms that i broke. :) Okay, there are two important fixes (1 4) and two general cleanups (2 3). I hope most of the issues would be resolved by these and we would

Re: [PATCH 0/4] CPUFreq Fixes for 3.9

2013-02-07 Thread Artem Savkov
(data-cpus); Tested-by: Artem Savkov artem.sav...@gmail.com -- Kind regards, Artem -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

[PATCH] drm: missing idr_preload_end in drm_gem_flink_ioctl

2013-02-10 Thread Artem Savkov
Added missing idr_preload_end calls in drm_gem_flink_ioctl(). Without those preemption stays disabled resulting in lots of scheduling while atomic BUGs. Introduced in 4e486fae707d9a79c76f1be6dcacffc4a721cc1b (linux-next.git) Signed-off-by: Artem Savkov artem.sav...@gmail.com --- drivers/gpu/drm

[PATCH] cpufreq: 64bit divide in intel_pstate_calc_busy()

2013-02-11 Thread Artem Savkov
intel_pstate.c won't compile on i686 because of a linking error: drivers/cpufreq/intel_pstate.c:459: undefined reference to `__udivdi3' Signed-off-by: Artem Savkov artem.sav...@gmail.com --- drivers/cpufreq/intel_pstate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[BUG] cpufreq: sleeping function called from invalid context at kernel/workqueue.c:2811

2013-02-06 Thread Artem Savkov
I get the following BUG on suspend using systemd-sleep(this doesn't happen with pm-suspend). This seems to be introduced by some of the Viresh's patches. [ 94.908046] Disabling non-boot CPUs ... [ 94.908416] BUG: sleeping function called from invalid context at kernel/workqueue.c:2811 [

Re: [BUG] cpufreq: sleeping function called from invalid context at kernel/workqueue.c:2811

2013-02-06 Thread Artem Savkov
On Thu, Feb 07, 2013 at 01:41:57AM +0100, Rafael J. Wysocki wrote: On Wednesday, February 06, 2013 10:11:25 PM Rafael J. Wysocki wrote: On Thursday, February 07, 2013 12:25:13 AM Artem Savkov wrote: I get the following BUG on suspend using systemd-sleep(this doesn't happen with pm-suspend

[PATCH] asmlinkage tag for sys_iopl

2013-02-03 Thread Artem Savkov
asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in 9e0b2428bc6a6c6df90bb701ca843820727cadf0. Signed-off-by: Artem Savkov artem.sav...@gmail.com --- arch/x86/include/asm/syscalls.h | 2 +- arch

Re: [PATCH] asmlinkage tag for sys_iopl

2013-02-03 Thread Artem Savkov
On Sun, Feb 03, 2013 at 07:04:35PM +, Al Viro wrote: On Sun, Feb 03, 2013 at 07:59:12PM +0100, Ingo Molnar wrote: * Artem Savkov artem.sav...@gmail.com wrote: asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl syscalls unusable, i.e. every call returns

Re: [PATCH] thinkpad_acpi: moved hotkey_thread_mutex lock after set_freezable()

2013-02-25 Thread Artem Savkov
On Mon, Feb 25, 2013 at 03:54:45PM -0800, Andrew Morton wrote: On Sun, 24 Feb 2013 13:22:02 +0400 Artem Savkov artem.sav...@gmail.com wrote: set_freezable() checks freezing during which no locks should be held. hotkey_thread_mutex lock should be moved closer to where it is actually

[PATCH] thinkpad_acpi: moved hotkey_thread_mutex lock after set_freezable()

2013-02-24 Thread Artem Savkov
set_freezable() checks freezing during which no locks should be held. hotkey_thread_mutex lock should be moved closer to where it is actually needed. Signed-off-by: Artem Savkov artem.sav...@gmail.com --- drivers/platform/x86/thinkpad_acpi.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: BUG: unable to handle kernel paging request at 00010016

2012-08-19 Thread Artem Savkov
On Sat, Aug 18, 2012 at 11:25:43PM -0500, Shaun Ruffell wrote: Adding linux-net to the CC list. On Fri, Aug 17, 2012 at 11:57:56PM +0100, Dave Haywood wrote: [1.] One line summary of the problem: BUG: unable to handle kernel paging request at 00010016 System boots then crashes a

[PATCH] n_tty: release atomic_read_lock before calling schedule_timeout()

2013-07-30 Thread Artem Savkov
] [816a3bb6] tty_read+0x86/0xf0 [ 16.822058] [811f21d3] vfs_read+0xc3/0x130 [ 16.822058] [811f2702] SyS_read+0x62/0xa0 [ 16.822058] [815e24ee] ? trace_hardirqs_on_thunk+0x3a/0x3f [ 16.822058] [81d45259] system_call_fastpath+0x16/0x1b Signed-off-by: Artem Savkov

Re: [PATCH] n_tty: release atomic_read_lock before calling schedule_timeout()

2013-07-31 Thread Artem Savkov
On Tue, Jul 30, 2013 at 12:39:54PM -0400, Peter Hurley wrote: On 07/30/2013 11:35 AM, Artem Savkov wrote: ldata-atomic_read_lock should be released before scheduling as well as tty-termios_rwsem, otherwise there is a potential deadlock detected by lockdep False positive. Introduced

[PATCH] non-swapcache pages in end_swap_bio_read()

2013-06-07 Thread Artem Savkov
8b 07 55 48 89 e5 a9 00 00 01 00 74 12 e8 3d RIP [811462eb] page_swap_info+0xab/0xb0 RSP 88001ec03c78 Signed-off-by: Artem Savkov artem.sav...@gmail.com --- mm/page_io.c | 68 +--- 1 file changed, 38 insertions(+), 30 deletions

[BUG] non-swapcache page in end_swap_bio_read()

2013-06-07 Thread Artem Savkov
Hello all, I'm hitting the following BUG_ON during boot when CONFIG_PM_STD_PARTITION or resume kernel boot option are set. Looks like this issue was introduced in (or brought up to light by) mm: remove compressed copy from zram in-memory (84e5bb4f06e6d6f0c4dfc033b4700702ed8aaccc in

[BUG] trying to lock tailpage in page_fault path

2013-09-06 Thread Artem Savkov
Hi All, Since the thp-mm-locking-tail-page-is-a-bug-fix patch (c6d04b4502a07b040b9e8cce835f899913961248 in linux-next.git) from Andrew's tree I get the following trace on pulseaudio start: [ 147.191296] [ cut here ] [ 147.192017] kernel BUG at

Re: 3.11.0-next-20130905: kernel BUG at include/linux/pagemap.h:343

2013-09-06 Thread Artem Savkov
On Fri, Sep 06, 2013 at 03:26:18PM +0800, Baoquan He wrote: [ 30.438555] [ cut here ] [ 30.443385] kernel BUG at include/linux/pagemap.h:343! Seems to be the same one I reported here: http://www.spinics.net/lists/kernel/msg1597973.html -- Regards, Artem -- To

[PATCH] aio: rcu_read_lock protection for new rcu_dereference calls

2013-09-08 Thread Artem Savkov
] SyS_io_setup+0x89c/0xc70 [ 471.737806] [c119b8dd] ? SyS_io_setup+0x4fd/0xc70 [ 471.741689] [c10cf684] ? __audit_syscall_entry+0x94/0xe0 [ 471.746080] [c18b1fcc] syscall_call+0x7/0xb [ 471.749723] [c108] ? task_fork_fair+0x240/0x260 Signed-off-by: Artem Savkov artem.sav...@gmail.com

Re: [tip:timers/core] hrtimers: Support resuming with two or more CPUs online (but stopped)

2013-07-05 Thread Artem Savkov
This commit brings up a warning about a potential deadlock in smp_call_function_many() discussed previously: https://lkml.org/lkml/2013/4/18/546 [ 4363.082047] PM: Restoring platform NVS memory [ 4363.082471] [ cut here ] [ 4363.083800] WARNING: CPU: 0 PID: 3977 at

Re: [tip:timers/core] hrtimers: Support resuming with two or more CPUs online (but stopped)

2013-07-05 Thread Artem Savkov
:( On 05/07/13 10:30, Artem Savkov wrote: This commit brings up a warning about a potential deadlock in smp_call_function_many() discussed previously: https://lkml.org/lkml/2013/4/18/546 Can we just avoid the wait in clock_was_set()? Something like this? 8

Re: [tip:timers/core] hrtimers: Support resuming with two or more CPUs online (but stopped)

2013-07-05 Thread Artem Savkov
On Fri, Jul 05, 2013 at 12:36:50PM +0200, Thomas Gleixner wrote: On Fri, 5 Jul 2013, Thomas Gleixner wrote: On Fri, 5 Jul 2013, David Vrabel wrote: You failed to CC Artem :( Second thought. Where is that warning? Can't find it in neither in Linus tree nor in tip [ 4363.083800] WARNING:

[PATCH] drm: i915_gem_inactive_scan: insufficient nr_to_scan size

2013-07-23 Thread Artem Savkov
shrinkers to new count/scan API (383e4f4a4cdeb2dd552e90811089bcb4d41eb32e in linux-next.git) Signed-off-by: Artem Savkov artem.sav...@gmail.com --- drivers/gpu/drm/i915/i915_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915

Re: [PATCH] drm: i915_gem_inactive_scan: insufficient nr_to_scan size

2013-07-23 Thread Artem Savkov
On Tue, Jul 23, 2013 at 11:18:06PM +0400, Artem Savkov wrote: nr_to_scan needs to be (unsigned) long, not int, otherwise we get negative values on 32bit systems during shrink resulting in lots of messages like one below. [ 4078.989603] shrink_slab: i915_gem_inactive_scan+0x0/0xc0 negative

Re: [PATCH tty-next] n_tty: Fix termios_rwsem lockdep false positive

2013-08-12 Thread Artem Savkov
be dropped and reacquired without triggering lockdep. Works fine, thanks. Reported-and-tested-by: Artem Savkov artem.sav...@gmail.com Reported-by: Artem Savkov artem.sav...@gmail.com Reported-by: Sergey Senozhatsky sergey.senozhat...@gmail.com Signed-off-by: Peter Hurley pe...@hurleysoftware.com

[BUG]: missing shinfo with netlink_alloc_large_skb

2013-06-27 Thread Artem Savkov
Hello, I ran into a bug while running trinity with write/writev syscalls. Seems like it has been introduced by netlink: allow large data transfers from user-space commit. nf_fib_input calls skb_clone which expects skb_shinfo to be allocated, but netlink_alloc_large_skb doesn't do that, should

[PATCH] mfd: rt5033: MFD_RT5033 needs to select REGMAP_IRQ

2015-03-05 Thread Artem Savkov
Since commit 0b2712585(linux-next.git) this driver uses regmap_irq and so needs to select REGMAP_IRQ. This fixes the following compilation errors: ERROR: regmap_irq_get_domain [drivers/mfd/rt5033.ko] undefined! ERROR: regmap_add_irq_chip [drivers/mfd/rt5033.ko] undefined! Signed-off-by: Artem

Re: [PATCHv12 14/37] futex, thp: remove special case for THP in get_futex_key

2015-10-22 Thread Artem Savkov
On Tue, Oct 06, 2015 at 06:23:41PM +0300, Kirill A. Shutemov wrote: > With new THP refcounting, we don't need tricks to stabilize huge page. > If we've got reference to tail page, it can't split under us. > > This patch effectively reverts a5b338f2b0b1. > > Signed-off-by: Kirill A. Shutemov

Re: [PATCHv12 14/37] futex, thp: remove special case for THP in get_futex_key

2015-10-22 Thread Artem Savkov
On Thu, Oct 22, 2015 at 12:49:45PM +0300, Kirill A. Shutemov wrote: > On Thu, Oct 22, 2015 at 10:24:33AM +0200, Artem Savkov wrote: > > On Tue, Oct 06, 2015 at 06:23:41PM +0300, Kirill A. Shutemov wrote: > > > With new THP refcounting, we don't need tricks to stabilize huge pa

[PATCH] rcuperf: Do not wake up shutdown wait queue if "shutdown" is false.

2016-02-07 Thread Artem Savkov
erence". Fix by checking "shutdown" param before waking up the queue. Signed-off-by: Artem Savkov <artem.sav...@gmail.com> --- kernel/rcu/rcuperf.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c index 09ffa36..f

[PATCH] X.509: Fix double free in x509_cert_parse().

2016-08-11 Thread Artem Savkov
Patch "crypto: KEYS: convert public key and digsig asym to the akcipher api" introduced double freeing of cert->pub->key. There is no need to free it in error_decode label as it is later freed in x509_free_certificate(). Signed-off-by: Artem Savkov <asav...@redhat.com> ---

[PATCH v3] Fix NULL pointer dereference in bl_free_device().

2016-07-21 Thread Artem Savkov
in a wrong pointer dereference. Fixing this by setting bdev in struct pnfs_block_dev only if we didn't get an error from blkdev_get_by_*(). Signed-off-by: Artem Savkov <asav...@redhat.com> --- fs/nfs/blocklayout/dev.c | 22 +- 1 file changed, 13 insertions(+), 9 del

[PATCH] Fix NULL pointer dereference in bl_free_device().

2016-07-19 Thread Artem Savkov
in a wrong pointer dereference. Fixing this by making sure bdev is not an error code in bl_free_device(). Signed-off-by: Artem Savkov <asav...@redhat.com> --- fs/nfs/blocklayout/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/blocklayout/dev.c b/fs/nfs/block

[PATCH v2] Fix NULL pointer dereference in bl_free_device().

2016-07-19 Thread Artem Savkov
in a wrong pointer dereference. Fixing this by making sure bdev is not an error code in bl_free_device(). Signed-off-by: Artem Savkov <asav...@redhat.com> --- fs/nfs/blocklayout/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/blocklayout/dev.c b/fs/nfs/block

[PATCH] Make __xfs_xattr_put_listen preperly report errors.

2016-08-23 Thread Artem Savkov
y check seen_enough. This results in a failed assertion: XFS: Assertion failed: context->count >= 0, file: fs/xfs/xfs_xattr.c, line: 175 in insufficient buffer size case. Signed-off-by: Artem Savkov <asav...@redhat.com> --- fs/xfs/xfs_xattr.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

2016-08-25 Thread Artem Savkov
On Thu, Aug 25, 2016 at 10:24:08AM +1000, Dave Chinner wrote: > On Wed, Aug 24, 2016 at 10:08:33AM +0200, Artem Savkov wrote: > > On Wed, Aug 24, 2016 at 11:55:51AM +1000, Dave Chinner wrote: > > > On Tue, Aug 23, 2016 at 05:54:13PM +0200, Artem Savkov wrote: > > >

[PATCH] security/keys: make BIG_KEYS dependent on stdrng.

2016-09-05 Thread Artem Savkov
Signed-off-by: Artem Savkov <asav...@redhat.com> --- security/keys/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/keys/Kconfig b/security/keys/Kconfig index f826e87..d942c7c 100644 --- a/security/keys/Kconfig +++ b/security/keys/Kconfig @@ -41,7 +41,7 @@

Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng.

2016-09-06 Thread Artem Savkov
On Tue, Sep 06, 2016 at 01:58:49PM +0100, David Howells wrote: > Artem Savkov <asav...@redhat.com> wrote: > > > - select CRYPTO > > + depends on (CRYPTO_ANSI_CPRNG = y || CRYPTO_DRBG = y) > > Should those be "==" not "="? Accodring to D

Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng.

2016-09-06 Thread Artem Savkov
On Tue, Sep 06, 2016 at 02:11:56PM +0100, David Howells wrote: > Artem Savkov <asav...@redhat.com> wrote: > > > > > - select CRYPTO > > > > + depends on (CRYPTO_ANSI_CPRNG = y || CRYPTO_DRBG = y) > > > > > > Should those be &q

Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng.

2016-10-06 Thread Artem Savkov
On Tue, Sep 06, 2016 at 07:16:13PM +0100, David Howells wrote: > Kirill Marinushkin <k.marinush...@gmail.com> wrote: > > > IMO, the preferable fix depends on your future plan. > > If you plan to continue using both ANSI X9.31 DRNG and DRBG - I agree with > > th

[PATCH] Use proper lock in fscache_objlist_config.

2016-10-04 Thread Artem Savkov
fscache_objlist_config doesn't hold rkey->sem when calling user_key_payload, that can result in a "suspicious RCU usage" warning. It does hold rcu_read_lock, so it either needs to use unprotected rcu_dereference, or take rkey->sem instead of rcu_read_lock. Signed-off-by: Ar

[PATCH] Fix suspicious RCU usage in nfs_idmap_get_key.

2016-10-04 Thread Artem Savkov
nfs_idmap_get_key doesn't hold rkey->sem when calling user_key_payload resulting in a "suspicious RCU usage" lockdep splat. It does, however hold rcu_read_lock, so it either needs to use unprotected rcu_dereference, or take rkey->sem instead of rcu_read_lock. Signed-off-by: Ar

Re: [PATCH] Fix suspicious RCU usage in nfs_idmap_get_key.

2016-10-04 Thread Artem Savkov
On Tue, Oct 04, 2016 at 04:45:14PM +0100, David Howells wrote: > Artem Savkov <asav...@redhat.com> wrote: > > > nfs_idmap_get_key doesn't hold rkey->sem when calling user_key_payload > > resulting in a "suspicious RCU usage" lockdep splat. It does, however

Re: [PATCH] Use proper lock in fscache_objlist_config.

2016-10-04 Thread Artem Savkov
On Tue, Oct 04, 2016 at 04:43:31PM +0100, David Howells wrote: > Artem Savkov <asav...@redhat.com> wrote: > > > fscache_objlist_config doesn't hold rkey->sem when calling user_key_payload, > > that can result in a "suspicious RCU usage" warning. It does hold &

Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

2016-08-26 Thread Artem Savkov
On Fri, Aug 26, 2016 at 08:42:15AM +1000, Dave Chinner wrote: > On Thu, Aug 25, 2016 at 10:21:09AM +0200, Artem Savkov wrote: > > On Thu, Aug 25, 2016 at 10:24:08AM +1000, Dave Chinner wrote: > > > On Wed, Aug 24, 2016 at 10:08:33AM +0200, Artem Savkov wrote: > > > >

Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

2016-08-24 Thread Artem Savkov
On Wed, Aug 24, 2016 at 11:55:51AM +1000, Dave Chinner wrote: > On Tue, Aug 23, 2016 at 05:54:13PM +0200, Artem Savkov wrote: > > Commit "xfs: only return -errno or success from attr ->put_listent" changes > > the > > Please quote commits in --oneline format

[PATCH v2] Make __xfs_xattr_put_listen preperly report errors.

2016-08-29 Thread Artem Savkov
ed at (context->alist - 1). Signed-off-by: Artem Savkov <asav...@redhat.com> --- fs/xfs/xfs_xattr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/xfs/xfs_xattr.c b/fs/xfs/xfs_xattr.c index ea62245..6290093 100644 --- a/fs/xfs/xfs_xattr.c +++ b/fs/xfs/xfs_xattr.c @@ -147,6

Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng.

2016-10-25 Thread Artem Savkov
On Mon, Oct 24, 2016 at 03:50:54PM +0100, David Howells wrote: > Artem Savkov <asav...@redhat.com> wrote: > > > > > IMO, the preferable fix depends on your future plan. > > > > If you plan to continue using both ANSI X9.31 DRNG and DRBG - I agree > > >

Re: arm64 build failure with CONFIG_ARM64_LSE_ATOMICS=y

2016-11-03 Thread Artem Savkov
On Thu, Nov 03, 2016 at 10:39:43AM +, Suzuki K Poulose wrote: > On 02/11/16 23:28, Will Deacon wrote: > > Hi Artem, > > > > On Wed, Nov 02, 2016 at 05:44:27PM +0100, Artem Savkov wrote: > > > Hello Catalin, > > > > > > Looks like your patch

Re: arm64 build failure with CONFIG_ARM64_LSE_ATOMICS=y

2016-11-04 Thread Artem Savkov
On Thu, Nov 03, 2016 at 06:46:25PM +, Catalin Marinas wrote: > On Thu, Nov 03, 2016 at 12:12:38PM +0100, Artem Savkov wrote: > > On Thu, Nov 03, 2016 at 10:39:43AM +, Suzuki K Poulose wrote: > > > On 02/11/16 23:28, Will Deacon wrote: > > > > On Wed, Nov 02, 2

arm64 build failure with CONFIG_ARM64_LSE_ATOMICS=y

2016-11-02 Thread Artem Savkov
Hello Catalin, Looks like your patch "efd9e03 arm64: Use static keys for CPU features" breaks arm64 build with "CONFIG_ARM64_LSE_ATOMICS=y" because it creates a circular dependency for asm/lse.h through jump_label.h: CC arch/arm64/kernel/asm-offsets.s In file included from

Re: [PATCH] ip6_offload: check segs for NULL in ipv6_gso_segment.

2016-12-01 Thread Artem Savkov
On Thu, Dec 01, 2016 at 06:34:07AM -0800, Eric Dumazet wrote: > On Thu, 2016-12-01 at 14:06 +0100, Artem Savkov wrote: > > segs needs to be checked for being NULL in ipv6_gso_segment() before calling > > skb_shinfo(segs), otherwise kernel can run into a NULL-pointer dereference: &

[PATCH] ip6_offload: check segs for NULL in ipv6_gso_segment.

2016-12-01 Thread Artem Savkov
2d78d0 ]--- Signed-off-by: Artem Savkov <asav...@redhat.com> --- net/ipv6/ip6_offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c index 1fcf61f..89c59e6 100644 --- a/net/ipv6/ip6_offload.c +++ b/net/ipv6/ip6_offload.c @@

Re: [PATCH] ip6_offload: check segs for NULL in ipv6_gso_segment.

2016-12-02 Thread Artem Savkov
On Thu, Dec 01, 2016 at 09:47:17PM -0500, Don Bowman wrote: > I have been having this problem (4.9rc6). > I applied this patch. > I still have the problem. > > My stack trace (attached as image, i did not get it in text) is: > > ipv6_gso_segment > skb_mac_gso_segment > __skb_gso_segment >

[PATCH] nfs/filelayout: fix NULL pointer dereference in fl_pnfs_update_layout()

2017-04-21 Thread Artem Savkov
1] RIP: pnfs_put_lseg+0x29/0x100 [nfsv4] RSP: c9ff39b8 [ 3000.672462] CR2: 003c Signed-off-by: Artem Savkov <asav...@redhat.com> --- fs/nfs/filelayout/filelayout.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/nfs/filelayout/filelayout.c b/fs/nfs/filelayout/filela

Re: possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem

2017-08-16 Thread Artem Savkov
On Wed, Aug 16, 2017 at 03:39:14PM +0200, Laurent Dufour wrote: > On 15/08/2017 21:01, Paul E. McKenney wrote: > > On Mon, Aug 07, 2017 at 04:09:47PM +0200, Artem Savkov wrote: > >> Hello, > >> > >> After commit fc8dffd "cpu/hotplug: Convert hotplug lo

amd-iommu/x2apic: sleeping function called from invalid context

2017-07-25 Thread Artem Savkov
Hi, Commit 1c3c5ea "sched/core: Enable might_sleep() and smp_processor_id() checks early" seem to have uncovered an issue with amd-iommu/x2apic. Starting with that commit the following warning started to show up on AMD systems during boot: [0.140480] smpboot: Max logical packages: 6 [

Re: [PATCH] iommu/amd: Fix schedule-while-atomic BUG in initialization code

2017-07-26 Thread Artem Savkov
On Wed, Jul 26, 2017 at 02:26:14PM +0200, Joerg Roedel wrote: > Hi Artem, Thomas, > > On Wed, Jul 26, 2017 at 12:42:49PM +0200, Thomas Gleixner wrote: > > On Tue, 25 Jul 2017, Artem Savkov wrote: > > > > > Hi, > > > > > > Commit 1c3c5ea "

[PATCH v2] nfs/filelayout: fix NULL pointer dereference in fl_pnfs_update_layout()

2017-04-21 Thread Artem Savkov
t_lseg+0x29/0x100 [nfsv4] RSP: c9ff39b8 [ 3000.672462] CR2: 003c Signed-off-by: Artem Savkov <asav...@redhat.com> --- fs/nfs/filelayout/filelayout.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/nfs/filelayout/filelayout.c b/fs/nfs/filelayout/

[PATCH] iommu/arm-smmu: fix null-pointer dereference in arm_smmu_add_device

2017-08-08 Thread Artem Savkov
is a NULL-pointer dereference panic during boot on some hosts. Signed-off-by: Artem Savkov <asav...@redhat.com> --- drivers/iommu/arm-smmu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index b97188a..95f1c86 100644 --- a/drivers/

[PATCH v2] iommu/arm-smmu: fix null-pointer dereference in arm_smmu_add_device

2017-08-08 Thread Artem Savkov
is a NULL-pointer dereference panic during boot on some hosts. Signed-off-by: Artem Savkov <asav...@redhat.com> --- drivers/iommu/arm-smmu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index b97188a..2d80fa8 100644 --- a/d

possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem

2017-08-07 Thread Artem Savkov
Hello, After commit fc8dffd "cpu/hotplug: Convert hotplug locking to percpu rwsem" the following lockdep splat started showing up on some systems while running ltp's madvise06 test (right after first dirty_pages call [1]). [1]

[PATCH v2] Use ctlr directly in rdac_failover_get()

2017-05-20 Thread Artem Savkov
..@vger.kernel.org Signed-off-by: Artem Savkov <asav...@redhat.com> --- drivers/scsi/device_handler/scsi_dh_rdac.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/device_handler/scsi_dh_rdac.c b/drivers/scsi/device_handler/scsi_dh_rdac.c index

[PATCH] Use ctlr directly in rdac_failover_get()

2017-05-19 Thread Artem Savkov
[ 18.436192] CR2: 0790 [ 18.436198] ---[ end trace 40f3e4dca1ffabdd ]--- [ 18.436199] Kernel panic - not syncing: Fatal exception [ 18.436222] Kernel Offset: disabled [-- MARK -- Thu May 18 11:45:00 2017] Signed-off-by: Artem Savkov <asav...@redhat.com> --- dri

MADV_FREE is broken

2017-09-20 Thread Artem Savkov
Hi All, We recently started noticing madvise09[1] test from ltp failing strangely. The test does the following: maps 32 pages, sets MADV_FREE for the range it got, dirties 2 of the pages, creates memory pressure and check that nondirty pages are free. The test hanged while accessing the last 4

Re: MADV_FREE is broken

2017-09-21 Thread Artem Savkov
On Wed, Sep 20, 2017 at 03:37:33PM -0700, Shaohua Li wrote: > On Wed, Sep 20, 2017 at 11:01:47AM +0200, Artem Savkov wrote: > > Hi All, > > > > We recently started noticing madvise09[1] test from ltp failing strangely. > > The > > test does the followi

[PATCH v2] ebtables: fix race condition in frame_filter_net_init()

2017-09-26 Thread Artem Savkov
It is possible for ebt_in_hook to be triggered before ebt_table is assigned resulting in a NULL-pointer dereference. Make sure hooks are registered as the last step. Fixes: aee12a0a3727 ebtables: remove nf_hook_register usage Signed-off-by: Artem Savkov <asav...@redhat.com> --- include

[PATCH v3] ebtables: fix race condition in frame_filter_net_init()

2017-09-26 Thread Artem Savkov
-by: Artem Savkov <asav...@redhat.com> --- include/linux/netfilter_bridge/ebtables.h | 7 --- net/bridge/netfilter/ebtable_broute.c | 4 ++-- net/bridge/netfilter/ebtable_filter.c | 4 ++-- net/bridge/netfilter/ebtable_nat.c| 4 ++-- net/bridge/netfilter/ebta

[PATCH] ebtables: fix race condition in frame_filter_net_init()

2017-09-26 Thread Artem Savkov
It is possible for ebt_in_hook to be triggered before ebt_table is assigned resulting in a NULL-pointer dereference. Make sure hooks are registered as the last step. Fixes: aee12a0a3727 ebtables: remove nf_hook_register usage Signed-off-by: Artem Savkov <asav...@redhat.com> --- include

Re: [PATCH] ebtables: fix race condition in frame_filter_net_init()

2017-09-26 Thread Artem Savkov
On Tue, Sep 26, 2017 at 02:42:11PM +0200, Florian Westphal wrote: > Artem Savkov <asav...@redhat.com> wrote: > > It is possible for ebt_in_hook to be triggered before ebt_table is assigned > > resulting in a NULL-pointer dereference. Make sure hooks are > > registered a

[PATCH] xfrm: don't call xfrm_policy_cache_flush under xfrm_state_lock

2017-09-27 Thread Artem Savkov
c14a8 xfrm: add xdst pcpu cache Signed-off-by: Artem Savkov <asav...@redhat.com> --- net/xfrm/xfrm_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c index 0dab1cd79ce4..12213477cd3a 100644 --- a/net/xfrm/xfrm_state.c +

Re: possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem

2017-08-31 Thread Artem Savkov
Hi Michal, On Wed, Aug 30, 2017 at 05:43:15PM +0200, Michal Hocko wrote: > The previous patch is insufficient. drain_all_stock can still race with > the memory offline callback and the underlying memcg disappear. So we > need to be more careful and pin the css on the memcg. This patch >

Re: possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem

2017-08-31 Thread Artem Savkov
On Thu, Aug 31, 2017 at 02:09:51PM +0200, Michal Hocko wrote: > On Thu 31-08-17 13:10:06, Artem Savkov wrote: > > Hi Michal, > > > > On Wed, Aug 30, 2017 at 05:43:15PM +0200, Michal Hocko wrote: > > > The previous patch is insufficient. drain_all_stock can still race

[PATCH] xfrm: init skb_head lock for transport-mode packets

2018-01-04 Thread Artem Savkov
f __skb_queue_head_init() to properly initialize said lock. Signed-off-by: Artem Savkov <asav...@redhat.com> --- net/xfrm/xfrm_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c index 26b10eb7a206..d5389b9dbbb9 100644 --- a/ne

[PATCH 1/2] sun4i_ss_prng: fix return value of sun4i_ss_prng_generate

2018-02-06 Thread Artem Savkov
According to crypto/rng.h generate function should return 0 on success and < 0 on error. Fixes: b8ae5c7387ad ("crypto: sun4i-ss - support the Security System PRNG") Signed-off-by: Artem Savkov <artem.sav...@gmail.com> --- drivers/crypto/sunxi-ss/sun4i-ss-prng.c | 2 +-

[PATCH 2/2] sun4i_ss_prng: convert lock to _bh in sun4i_ss_prng_generate

2018-02-06 Thread Artem Savkov
Lockdep detects a possible deadlock in sun4i_ss_prng_generate() and throws an "inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage" warning. Disabling softirqs to fix this. Fixes: b8ae5c7387ad ("crypto: sun4i-ss - support the Security System PRNG") Signed-off-by:

[PATCH 0/2] sun4i_ss_prng fixes

2018-02-06 Thread Artem Savkov
IPSec hasn't been working on my a10 board since 4.14 and it turned out to be caused by sun4i_ss_rng driver. Artem Savkov (2): sun4i_ss_prng: fix return value of sun4i_ss_prng_generate sun4i_ss_prng: convert lock to _bh in sun4i_ss_prng_generate drivers/crypto/sunxi-ss/sun4i-ss-prng.c | 6

Re: [PATCH 1/2] sun4i_ss_prng: fix return value of sun4i_ss_prng_generate

2018-02-07 Thread Artem Savkov
On Wed, Feb 07, 2018 at 10:56:59AM +0100, Corentin Labbe wrote: > On Tue, Feb 06, 2018 at 10:20:21PM +0100, Artem Savkov wrote: > > According to crypto/rng.h generate function should return 0 on success > > and < 0 on error. > > > > Fixes: b8ae5c7387ad ("cryp

Re: [PATCH] xfrm: init skb_head lock for transport-mode packets

2018-01-04 Thread Artem Savkov
On Thu, Jan 04, 2018 at 10:01:32PM +1100, Herbert Xu wrote: > On Thu, Jan 04, 2018 at 11:36:28AM +0100, Artem Savkov wrote: > > Commit acf568ee859f "xfrm: Reinject transport-mode packets through tasklet" > > adds an sk_buff_head queue, but never initializes trans->q

[PATCH] kprobes: fix trace_probe flags in enable_trace_kprobe

2018-07-25 Thread Artem Savkov
every probe to be disabled. Signed-off-by: Artem Savkov --- kernel/trace/trace_kprobe.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 21f718472942..fb887ced5056 100644 --- a/kernel/trace

[PATCH v2] tracing/kprobes: Fix trace_probe flags on enable_trace_kprobe() failure

2018-07-25 Thread Artem Savkov
every probe to be disabled. Signed-off-by: Artem Savkov --- kernel/trace/trace_kprobe.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 21f718472942..27ace4513c43 100644 --- a/kernel/trace

Re: [PATCH] objtool: fix .cold. functions parent symbols search

2018-11-07 Thread Artem Savkov
On Wed, Nov 07, 2018 at 11:08:56AM -0600, Josh Poimboeuf wrote: > On Wed, Nov 07, 2018 at 03:05:59PM +0100, Artem Savkov wrote: > > The way it is currently done it is possible for read_symbols() to find the > > same symbol as parent for ".cold" functions. >

[PATCH v2] objtool: fix .cold. functions parent symbols search

2018-11-07 Thread Artem Savkov
ace. Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 6dbb9fae0f9d..781c8afb29b9 100644 --- a/tools/objtool/elf.c +++ b/tools/objtool/elf.c @@ -298,6 +298,7 @@ static int rea

Re: [PATCH v2] objtool: fix .cold. functions parent symbols search

2018-11-10 Thread Artem Savkov
On Fri, Nov 09, 2018 at 11:23:09AM -0600, Josh Poimboeuf wrote: > On Wed, Nov 07, 2018 at 10:45:15PM +0100, Artem Savkov wrote: > > Because find_symbol_by_name() traverses the same lists as read_symbols() > > changing sym->name in place without copying it

[PATCH v3 2/2] objtool: fix .cold functions parent symbols search

2018-11-12 Thread Artem Savkov
in place. Fixes: 13810435b9a7 "objtool: Support GCC 8's cold subfunctions" Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 3decd43477df..15d9acfb2c97 100644

[PATCH v3 1/2] objtool: fix failed cold symbol doublefree

2018-11-12 Thread Artem Savkov
ons" Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 6dbb9fae0f9d..3decd43477df 100644 --- a/tools/objtool/elf.c +++ b/tools/objtool/elf.c @@ -312,7 +312,7 @@ static int rea

[PATCH v3 0/2] objtool: read_symbols() fixes

2018-11-12 Thread Artem Savkov
The series started with 'parent symbol search' patch, but I found another issue in read_symbols() while testing the failure-path. Artem Savkov (2): objtool: fix failed cold symbol doublefree objtool: fix .cold functions parent symbols search tools/objtool/elf.c | 22

[PATCH] objtool: fix .cold. functions parent symbols search

2018-11-07 Thread Artem Savkov
t in place. Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 6dbb9fae0f9d..781c8afb29b9 100644 --- a/tools/objtool/elf.c +++ b/tools/objtool/elf.c @@ -298,6 +298,7 @@

[PATCH] x86/tools/relocs: fix big section header tables

2018-11-29 Thread Artem Savkov
of e_shstrndx. This case is easily reproducible with KCFLAGS="-ffunction-sections", bzImage build fails with "String table index out of bounds" error. Signed-off-by: Artem Savkov --- arch/x86/tools/relocs.c | 58 + 1 file changed, 41 inserti

[PATCH v2] x86/tools/relocs: fix big section header tables

2018-11-29 Thread Artem Savkov
of e_shstrndx. This case is easily reproducible with KCFLAGS="-ffunction-sections", bzImage build fails with "String table index out of bounds" error. Signed-off-by: Artem Savkov --- arch/x86/tools/relocs.c | 58 + 1 file changed, 41 inserti

Re: [PATCH] x86/tools/relocs: fix big section header tables

2018-11-29 Thread Artem Savkov
On Thu, Nov 29, 2018 at 08:23:12AM -0600, Josh Poimboeuf wrote: > On Thu, Nov 29, 2018 at 02:51:33PM +0100, Artem Savkov wrote: > > In case when the number of entries in the section header table is larger > > then or equal to SHN_LORESERVE the size of the table is held in the sh_

  1   2   3   >