[PATCH] irqchip: irq-bcm2835: Add terminating entry for of_device_id table

2012-11-01 Thread Axel Lin
The of_device_id table is supposed to be zero-terminated. Signed-off-by: Axel Lin --- drivers/irqchip/irq-bcm2835.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-bcm2835.c b/drivers/irqchip/irq-bcm2835.c index dc670cc..16c78f1 100644 --- a/drivers

[PATCH] pinctrl: exynos: Add terminating entry for of_device_id table

2012-11-02 Thread Axel Lin
The of_device_id table is supposed to be zero-terminated. Signed-off-by: Axel Lin --- drivers/pinctrl/pinctrl-exynos.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/pinctrl-exynos.c b/drivers/pinctrl/pinctrl-exynos.c index 73a0aa2..b023254 100644 --- a/drivers/pinctrl

[PATCH] pinctrl: nomadik: Add terminating entry for platform_device_id table

2012-11-04 Thread Axel Lin
The platform_device_id table is supposed to be zero-terminated. Signed-off-by: Axel Lin --- drivers/pinctrl/pinctrl-nomadik.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/pinctrl-nomadik.c b/drivers/pinctrl/pinctrl-nomadik.c index f2fd99b..22f6937 100644 --- a/drivers

[PATCH] tty: serial: max310x: Add terminating entry for spi_device_id table

2012-11-04 Thread Axel Lin
The spi_device_id table is supposed to be zero-terminated. Signed-off-by: Axel Lin --- drivers/tty/serial/max310x.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c index 2bc28a5..1ab1d2c 100644 --- a/drivers/tty/serial/max310x.c

[PATCH] crypto: picoxcell: Add terminating entry for platform_device_id table

2012-11-04 Thread Axel Lin
The platform_device_id table is supposed to be zero-terminated. Signed-off-by: Axel Lin --- drivers/crypto/picoxcell_crypto.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/picoxcell_crypto.c b/drivers/crypto/picoxcell_crypto.c index 410a03c..f4d3d8f 100644 --- a/drivers

[PATCH] pinctrl: at91: Staticize non-exported symbols

2012-11-05 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/pinctrl/pinctrl-at91.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c index 65f066c..b9e2cbd 100644 --- a/drivers/pinctrl/pinctrl-at91.c +++ b

[PATCH] pinctrl: u300: Staticize non-exported symbols

2012-11-05 Thread Axel Lin
Staticize u300_pin_config_get() and u300_pin_config_set() functions. Signed-off-by: Axel Lin --- drivers/pinctrl/pinctrl-u300.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/pinctrl-u300.c b/drivers/pinctrl/pinctrl-u300.c index 2e9825e..d756cce

[PATCH] pinctrl: sirf: Staticize non-exported symbol

2012-11-05 Thread Axel Lin
Staticize sirfsoc_gpio_irq_map() function. Signed-off-by: Axel Lin --- drivers/pinctrl/pinctrl-sirf.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-sirf.c b/drivers/pinctrl/pinctrl-sirf.c index 9ecacf3..e3b2c53 100644 --- a/drivers/pinctrl

[PATCH] pinctrl: samsung: Add ifdef CONFIG_OF_GPIO guard for gc->of_node

2012-11-05 Thread Axel Lin
ke: *** [drivers] Error 2 This patch also removes unused variable 'prop' to silence the build warning. Signed-off-by: Axel Lin --- drivers/pinctrl/pinctrl-samsung.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/p

[PATCH v2] pinctrl: samsung: Add ifdef CONFIG_OF_GPIO guard for gc->of_node

2012-11-05 Thread Axel Lin
vers/pinctrl/pinctrl-samsung.c: In function 'samsung_gpiolib_register': drivers/pinctrl/pinctrl-samsung.c:797:5: error: 'struct gpio_chip' has no member named 'of_node' make[2]: *** [drivers/pinctrl/pinctrl-samsung.o] Error 1 make[1]: *** [drivers/pinctrl] Error 2 ma

[PATCH RFT 1/2] gpio: gpio-ml-ioh: Use spinlock for register access protection

2012-07-28 Thread Axel Lin
gpio_chip.can_sleep is 0, but current code uses mutex in ioh_gpio_set, ioh_gpio_get and ioh_gpio_direction_input functions. Thus those functions are not callable from interrupt context. This patch converts mutex into spinlock. Signed-off-by: Axel Lin --- drivers/gpio/gpio-ml-ioh.c | 20

[PATCH RFT 2/2] gpio: gpio-pch: Use spinlock for register access protection

2012-07-28 Thread Axel Lin
gpio_chip.can_sleep is 0, but current code uses mutex in pch_gpio_set pch_gpio_get and pch_gpio_direction_input functions. Thus those functions are not callable from interrupt context. This patch converts mutex into spinlock. Signed-off-by: Axel Lin --- drivers/gpio/gpio-pch.c | 22

[PATCH] regulator: core: Fix argument to _notifier_call_chain call

2012-07-29 Thread Axel Lin
g: cast to pointer from integer of different size [-Wint-to-pointer-cast] Signed-off-by: Axel Lin --- drivers/regulator/core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index f092588..37ce62b 100644 --- a/drivers

[PATCH] regulator: core: Add intermediate cast to uintptr_t before casting to pointer

2012-07-29 Thread Axel Lin
ned-off-by: Axel Lin --- drivers/regulator/core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index f092588..41cbd74 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -2180,7 +2180,7 @@

Re: [PATCH] regulator: core: Add intermediate cast to uintptr_t before casting to pointer

2012-07-30 Thread Axel Lin
於 一,2012-07-30 於 16:33 +0100,Mark Brown 提到: > On Mon, Jul 30, 2012 at 07:47:13AM +0800, Axel Lin wrote: > > > _notifier_call_chain(rdev, REGULATOR_EVENT_VOLTAGE_CHANGE, > > -(void *)best_val); > > +

[PATCH] regulator: wm831x-ldo: Check return value of wm831x_reg_read()

2012-07-31 Thread Axel Lin
wm831x_reg_read() returns negative error code on failure. This prevents using the error code as the value read. Signed-off-by: Axel Lin --- drivers/regulator/wm831x-ldo.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/regulator/wm831x-ldo.c b/drivers/regulator/wm831x-ldo.c

Re: [PATCH] regulator: core: Add intermediate cast to uintptr_t before casting to pointer

2012-07-31 Thread Axel Lin
於 二,2012-07-31 於 16:41 +0100,Mark Brown 提到: > On Tue, Jul 31, 2012 at 10:21:56AM +0800, Axel Lin wrote: > > 於 一,2012-07-30 於 16:33 +0100,Mark Brown 提到: > > > On Mon, Jul 30, 2012 at 07:47:13AM +0800, Axel Lin wrote: > > > > >

[PATCH] leds: lm3642: Use regmap_update_bits() in lm3642_chip_init()

2012-09-21 Thread Axel Lin
Use regmap_update_bits() to replace regmap_read() + regmap_write(). With this patch, we only show the error message when regmap_update_bits() fails. Signed-off-by: Axel Lin --- drivers/leds/leds-lm3642.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a

[PATCH] memory: emif: Add ifdef CONFIG_DEBUG_FS guard for emif_debugfs_[init|exit]

2012-09-24 Thread Axel Lin
Add ifdef CONFIG_DEBUG_FS guard for emif_debugfs_[init|exit], and adds stub functions for the case CONFIG_DEBUG_FS is not set. When CONFIG_DEBUG_FS is enabled, debugfs_create_dir and debugfs_create_file return NULL on failure, fix it. Signed-off-by: Axel Lin --- drivers/memory/emif.c | 23

[PATCH RFT] leds: blinkm: Avoid calling INIT_WORK in blinkm_led_common_set()

2012-10-26 Thread Axel Lin
blinkm_led in struct blinkm_work, and embedded struct blinkm_work in blinkm_data. With this change, we don't need to allocate and free memory for bl_work in blinkm_led_common_set() and led_work(). Signed-off-by: Axel Lin --- Hi Jan-Simon, I don't have this hardware, can you help review a

[PATCH] iio: hid-sensor: Use __devexit annotation for remove()

2012-10-27 Thread Axel Lin
Use __devexit rather than __devinit annotation for remove(). Also adds __devexit_p around remove callback. Signed-off-by: Axel Lin --- drivers/iio/accel/hid-sensor-accel-3d.c |4 ++-- drivers/iio/gyro/hid-sensor-gyro-3d.c |4 ++-- drivers/iio/light/hid-sensor-als.c

[PATCH] iio: hid-sensor: Return proper error if kmemdup fails

2012-10-27 Thread Axel Lin
Return -ENOMEM instead of 0 if kmemdup fails. Signed-off-by: Axel Lin --- drivers/iio/accel/hid-sensor-accel-3d.c |6 +++--- drivers/iio/gyro/hid-sensor-gyro-3d.c |6 +++--- drivers/iio/light/hid-sensor-als.c|5 ++--- drivers/iio/magnetometer/hid-sensor

[PATCH RFT] leds: blinkm: Don't init a workqueue per brightness_set call

2012-10-28 Thread Axel Lin
brightness_set call. Signed-off-by: Axel Lin --- This patch is v2 of "[PATCH RFT] leds: blinkm: Avoid calling INIT_WORK in blinkm_led_common_set()" I think the new subject line is better for the reason I sent the patch. v2: Now we have a workqueue per blinkm led. I think the code can be simpl

[PATCH] hwmon: da9055: Fix chan_mux[DA9055_ADC_ADCIN3] setting

2012-10-29 Thread Axel Lin
Set chan_mux[DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN3. Signed-off-by: Axel Lin --- Hi, This looks like a typo, but I don't have a hardware to test it. Axel drivers/hwmon/da9055-hwmon.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/da9055-hwmo

[PATCH] backlight: lm3639_bl: Fix up world writable sysfs file

2012-10-29 Thread Axel Lin
We don't need the sysfs file to be world writable or group writable. This file is write-only, change it to S_IWUSR (0200). Signed-off-by: Axel Lin --- drivers/video/backlight/lm3639_bl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/lm3639

[PATCH] gpio: em: Fix build errors

2012-10-31 Thread Axel Lin
'=', ',', ';', 'asm' or '__attribute__' before ':' token drivers/gpio/gpio-em.c:342: error: expected '=', ',', ';', 'asm' or '__attribute__' before ':' token drivers/gpio/gp

[PATCH] pinctrl: rockchip: Implement .request() and .free() callbacks on the GPIO chips

2013-08-27 Thread Axel Lin
Implement .request() and .free() callbacks on the GPIO chips to inform pinctrl when a GPIO is requested or freed. Signed-off-by: Axel Lin --- drivers/pinctrl/pinctrl-rockchip.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers

Re: [PATCH] pinctrl: rockchip: Implement .request() and .free() callbacks on the GPIO chips

2013-08-28 Thread Axel Lin
2013/8/28 Linus Walleij : > On Tue, Aug 27, 2013 at 4:30 PM, Axel Lin wrote: > >> Implement .request() and .free() callbacks on the GPIO chips to inform >> pinctrl >> when a GPIO is requested or freed. >> >> Signed-off-by: Axel Lin >> --- > > Ohh

[PATCH] pinctrl: pinconf-generic: Remove ti prefix in dev_err messages

2013-08-28 Thread Axel Lin
It does not make sense to show ti prefix in pinconf_generic_dt_subnode_to_map() dev_err messages. Signed-off-by: Axel Lin --- drivers/pinctrl/pinconf-generic.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf

[RFT][PATCH 1/2] regulator: as3722: Fix equation to calculate max_uV in regulator_lin_range macro

2013-10-01 Thread Axel Lin
Fix off-by-one in the equation to calculate max_uV. Signed-off-by: Axel Lin --- Hi, I don't have the datasheet and h/w. Just found this issue while reading the code. (Only compile test). Axel drivers/regulator/as3722-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[RFT][PATCH 2/2] regulator: as3722: Fix off-by-one n_voltages setting for SDx

2013-10-01 Thread Axel Lin
AS3722_SDx_VSEL_MAX means the maximum selector, the n_voltages should be AS3722_SDx_VSEL_MAX + 1. Signed-off-by: Axel Lin --- drivers/regulator/as3722-regulator.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/regulator/as3722-regulator.c b/drivers

Re: [RFT][PATCH 1/2] regulator: as3722: Fix equation to calculate max_uV in regulator_lin_range macro

2013-10-02 Thread Axel Lin
2013/10/2 Laxman Dewangan : > On Tuesday 01 October 2013 09:03 PM, Axel Lin wrote: >> >> Fix off-by-one in the equation to calculate max_uV. >> >> Signed-off-by: Axel Lin >> --- >> Hi, >> I don't have the datasheet and h/w. >> Just fou

[PATCH v2 1/2] regulator: as3722: Fix equation to calculate max_uV in regulator_lin_range macro

2013-10-02 Thread Axel Lin
code. Fix it based on the datasheet. Signed-off-by: Axel Lin --- drivers/regulator/as3722-regulator.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/regulator/as3722-regulator.c b/drivers/regulator/as3722-regulator.c index 16a5d26..01a8b17 100644 --- a

[PATCH] regulator: stw481x-vmmc: Set missing .of_match_table to stw481x_vmmc_match

2013-10-02 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/stw481x-vmmc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/stw481x-vmmc.c b/drivers/regulator/stw481x-vmmc.c index 5ae72a8..f78857b 100644 --- a/drivers/regulator/stw481x-vmmc.c +++ b/drivers/regulator/stw481x-vmmc.c

[PATCH v2 2/2] regulator: as3722: Fix off-by-one n_voltages setting for SDx

2013-10-02 Thread Axel Lin
AS3722_SDx_VSEL_MAX means the maximum selecter, the n_voltages should be AS3722_SDx_VSEL_MAX + 1. Signed-off-by: Axel Lin Acked-by: Laxman Dewangan --- v2: no code change, add Laxman's Ack. drivers/regulator/as3722-regulator.c | 14 +++--- 1 file changed, 7 insertions(+), 7 dele

[RFT][PATCH 1/2] irqchip: vt8500: Fix implementation for irq_ack and irq_mask

2013-07-08 Thread Axel Lin
interrupt enable bit for all interrupt trigger mode. According to the datasheet, the Interrupt Status Register is written one to clear(Write 0 has no effect). So we don't need a read-modify-write operation for clearing a bit in interrupt status register. Signed-off-by: Axel Lin --- Hi Tony, I don&#

[RFT][PATCH 2/2] irqchip: vt8500: Support 'rising and falling edge' trigger mode

2013-07-08 Thread Axel Lin
'posedge and negedge trigger' mode. Signed-off-by: Axel Lin --- Current code does not correctly handle the case if a driver request irq with "IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING" flag. I'm not sure if we have such use case in current code. drivers/irqchip/irq-

[PATCH] regulator: palmas: Drop regulator_unregister while using devm_regulator_register

2013-09-04 Thread Axel Lin
Commmit af40a94aba "regulator: palmas: Use devm_regulator_register" missed removing a regulator_unregister() call if palmas_extreg_init falis. Fix it. Signed-off-by: Axel Lin --- drivers/regulator/palmas-regulator.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH] regulator: palmas: Remove wrong comment for the equation calculating num_voltages

2013-09-11 Thread Axel Lin
Current equation on the comment is wrong. For linear mapping starting from 0, the equation is (maxV-minV)/stepV + 1. Since the linear mapping for PALMAS is not all starting from 0, the equation on the comment is not useful and misleading. Thus remove it. Signed-off-by: Axel Lin --- drivers

Re: [PATCH] pinctrl: pinctrl-adi2: GPIO output value should be set after the GPIO interrupt is disabled.

2013-10-08 Thread Axel Lin
2013/10/8 Sonic Zhang : > From: Sonic Zhang > > Use BIT macro as well. > > Signed-off-by: Sonic Zhang > --- > drivers/pinctrl/pinctrl-adi2.c | 14 -- > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-adi2.c b/drivers/pinctrl/pinctrl-adi2.c > i

[PATCH 1/2] regulator: Remove max_uV from struct regulator_linear_range

2013-10-10 Thread Axel Lin
linear ranges means each range has linear voltage settings. So we can calculate max_uV for each linear range in regulator core rather than set the max_uV field in drivers. Signed-off-by: Axel Lin Cc: Yi Zhang Cc: Chao Xie Cc: Guennadi Liakhovetski Cc: Laxman Dewangan Cc: Eric Miao Cc

[PATCH 2/2] regulator: Add REGULATOR_LINEAR_RANGE macro

2013-10-10 Thread Axel Lin
Add REGULATOR_LINEAR_RANGE macro and convert regulator drivers to use it. Signed-off-by: Axel Lin Cc: Yi Zhang Cc: Chao Xie Cc: Guennadi Liakhovetski Cc: Laxman Dewangan Cc: Eric Miao Cc: Margarita Olaya --- drivers/regulator/88pm800.c| 10 -- drivers/regulator/as3711

[PATCH] pinctrl: sunxi: Fix off-by-one for valid offset range checking

2013-08-30 Thread Axel Lin
The valid offset range should be 0 ... chip->ngpio - 1. Signed-off-by: Axel Lin --- drivers/pinctrl/pinctrl-sunxi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-sunxi.c b/drivers/pinctrl/pinctrl-sunxi.c index b20df31..0ffd4c0 100644 --- a/driv

[RFT][PATCH RESEND] regulator: tps65217: Convert to use linear ranges

2013-08-30 Thread Axel Lin
separates the range 25~52 in tps65217_uv1_ranges table to two linear ranges: 25~30 and 31~52. This change makes it possible to reuse the same linear_ranges table for DCDCx. Signed-off-by: Axel Lin --- This patch was sent on https://lkml.org/lkml/2013/7/20/18. I think there is no behavior change

[PATCH 1/2] regulator: da9063: Optimize da9063_set_current_limit implementation

2013-08-30 Thread Axel Lin
All the current limit tables have the values in ascend order. So we can slightly optimize the for loop iteration because the first match is the minimal value. Signed-off-by: Axel Lin --- drivers/regulator/da9063-regulator.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions

[PATCH 2/2] regulator: da9063: Use IS_ERR to check return value of regulator_register()

2013-08-30 Thread Axel Lin
regulator_register() does not return NULL, it returns ERR_PTR on error. Signed-off-by: Axel Lin --- drivers/regulator/da9063-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c index f29e729

regulator: da9063: Question about irq_uvov

2013-08-30 Thread Axel Lin
regulators->irq_uvov is not used, and thus is never requested. In da9063_regulator_remove(), why current code calls free_irq(regulators->irq_uvov, regulators); Regards, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@v

[PATCH] regulator: lp872x: Make REGULATOR_LP872X depend on I2C rather than I2C=y

2013-08-30 Thread Axel Lin
lp872x regulator driver can be built a module after commit 631a1fc "regulator: build: Allow most regulators to be built as modules". Make REGULATOR_LP872X depend on I2C to allow building lp872x module when I2C=m. Signed-off-by: Axel Lin --- drivers/regulator/Kconfig | 2 +- 1 file

[PATCH] regulator: da9063: Statize da9063_ldo_lim_event

2013-08-31 Thread Axel Lin
da9063_ldo_lim_event() is only referenced in this driver, make it static. Signed-off-by: Axel Lin --- drivers/regulator/da9063-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c index

[PATCH] regulator: core: Refactor devm_regulator_get* APIs

2013-08-31 Thread Axel Lin
. Signed-off-by: Axel Lin --- drivers/regulator/core.c | 127 +++ 1 file changed, 62 insertions(+), 65 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index a01b8b3..39e550a 100644 --- a/drivers/regulator/core.c +++ b

[PATCH 1/8] regulator: 88pm8607: Convert to devm_regulator_register

2013-09-02 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/88pm8607.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/regulator/88pm8607.c b/drivers/regulator/88pm8607.c index 8a7cb1f..e006e7e 100644 --- a/drivers/regulator/88pm8607.c +++ b/drivers/regulator/88pm8607

[PATCH 2/8] regulator: aat2870: Convert to devm_regulator_register

2013-09-02 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/aat2870-regulator.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/regulator/aat2870-regulator.c b/drivers/regulator/aat2870-regulator.c index 8b58763..1ca60ac 100644 --- a/drivers/regulator/aat2870

[PATCH 3/8] regulator: ad5398: Convert to devm_regulator_register

2013-09-02 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/ad5398.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/regulator/ad5398.c b/drivers/regulator/ad5398.c index 6b981b5..92f42fd 100644 --- a/drivers/regulator/ad5398.c +++ b/drivers/regulator/ad5398.c

[PATCH 4/8] regulator: as3711: Convert to devm_regulator_register

2013-09-02 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/as3711-regulator.c | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/drivers/regulator/as3711-regulator.c b/drivers/regulator/as3711-regulator.c index 3da6bd6..101fc2e 100644 --- a/drivers/regulator/as3711

[PATCH 5/8] regulator: da903x: Convert to devm_regulator_register

2013-09-02 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/da903x.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/regulator/da903x.c b/drivers/regulator/da903x.c index 2afa573..6de6885 100644 --- a/drivers/regulator/da903x.c +++ b/drivers/regulator/da903x.c @@ -488,7

[PATCH 6/8] regulator: da9052: Convert to devm_regulator_register

2013-09-02 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/da9052-regulator.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/regulator/da9052-regulator.c b/drivers/regulator/da9052-regulator.c index 96b569a..25d3e47 100644 --- a/drivers/regulator/da9052

[PATCH 7/8] regulator: da9055: Convert to devm_regulator_register

2013-09-02 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/da9055-regulator.c | 24 +--- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/drivers/regulator/da9055-regulator.c b/drivers/regulator/da9055-regulator.c index 3022109..9565a35 100644 --- a/drivers/regulator/da9055

[PATCH 8/8] regulator: fan53555: Convert to devm_regulator_register

2013-09-02 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/fan53555.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/regulator/fan53555.c b/drivers/regulator/fan53555.c index f0e1ae5..3ce9663 100644 --- a/drivers/regulator/fan53555.c +++ b/drivers/regulator/fan53555.c

Re: [PATCH V3 12/14] regulator: tps6524x: use devm_regulator_register()

2013-09-26 Thread Axel Lin
2013/9/26 Jingoo Han : > Use devm_regulator_register() to make cleanup paths simpler. > > Signed-off-by: Jingoo Han > --- > drivers/regulator/tps6524x-regulator.c |7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/regulator/tps6524x-regulator.c > b/drivers

Re: [PATCH V3 12/14] regulator: tps6524x: use devm_regulator_register()

2013-09-26 Thread Axel Lin
> Hi Axel, > > I really appreciate your comment. > > Then, you mean the following. > If I am wrong, please let me know. :-) > Thank you. Then you can remove pmic_remove() function,like below diff. With these change, you can add Reviewed-by: Axel Lin diff --git a/drive

[PATCH] regulator: wm831x-ldo: Fix max_uV for gp_ldo and aldo linear range settings

2013-09-23 Thread Axel Lin
00mV steps max_uV for the first linear range should be 160 rather than 165. Fix it. Signed-off-by: Axel Lin --- drivers/regulator/wm831x-ldo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/wm831x-ldo.c b/drivers/regulator/wm831x-ldo.c index 2

[PATCH 1/2] pinctrl: adi2: Convert to devm_ioremap_resource

2013-09-24 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/pinctrl/pinctrl-adi2.c | 38 ++ 1 file changed, 6 insertions(+), 32 deletions(-) diff --git a/drivers/pinctrl/pinctrl-adi2.c b/drivers/pinctrl/pinctrl-adi2.c index 7a24e59..f2aa877 100644 --- a/drivers/pinctrl/pinctrl-adi2

[PATCH 2/2] pinctrl: adi2: Fix dead lock in adi_gpio_direction_output

2013-09-24 Thread Axel Lin
Current code hold port->lock spinlock and then try to grab the lock again in adi_gpio_set_value(). Fix it. Signed-off-by: Axel Lin --- drivers/pinctrl/pinctrl-adi2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-adi2.c b/drivers/pinctrl/pinc

Re: [PATCH] ARM: ep93xx: Fix build error due to 'SZ_32M' undeclared

2012-09-06 Thread Axel Lin
> Hi Axel, > > The patch looks fine. I notice that the other ep93xx boards are also > using the SZ_ defines, but are indirectly including linux/sizes.h via > asm/memory.h, which in turn is indirectly included via asm/io.h. That Seems this is also true for other platforms ( e.g. mach-pxa, mach-ux500

regulator: fan53555: vsel_max does not match with the max voltage?

2012-09-09 Thread Axel Lin
Hi Yunfan, Just found below issue while reading the code: For FAN53555_CHIP_ID_04, di->vsel_min = 603000; di->vsel_max = 1411000; di->vsel_step = 12826; So we have below voltage list for FAN53555_CHIP_ID_04: volt[0] = 603000 volt[1] = 615826 volt[2] = 628652 volt[3] = 641

Re: [PATCH] regulator: fan53555: remove vsel_max not used

2012-09-09 Thread Axel Lin
2012/9/10 Yunfan Zhang : > The max voltage will be bounded by min_uV, uV_step and n_voltages, so > remove it to avoid confusing. > > Signed-off-by: Yunfan Zhang Acked-by: Axel Lin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH] regulator: fan53555: remove vsel_max not used

2012-09-10 Thread Axel Lin
2012/9/10 Mark Brown : > On Mon, Sep 10, 2012 at 11:53:55AM +0800, Axel Lin wrote: >> 2012/9/10 Yunfan Zhang : >> > The max voltage will be bounded by min_uV, uV_step and n_voltages, so >> > remove it to avoid confusing. > > Applied, thanks. > >> Acked-

[PATCH] mfd: Remove incorrect Kconfig help text for MFD_TPS6586X, MFD_SMSC and MFD_DA9055

2012-10-07 Thread Axel Lin
For MFD_TPS6586X, MFD_SMSC and MFD_DA9055, these drivers can only be built as built-in, thus remove incorrect help text in Kconfig entries. Signed-off-by: Axel Lin --- drivers/mfd/Kconfig |9 - 1 file changed, 9 deletions(-) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig

[PATCH] ARM: OMAP: Fix dependency for OMAP_DEBUG_LEDS

2012-10-07 Thread Axel Lin
-in.o:arch/arm/plat-omap/debug-leds.c:113: more undefined references to `led_classdev_register' follow make: *** [vmlinux] Error 1 Signed-off-by: Axel Lin --- Hi Bryan, I think this issue is introduced by commit dafbead "ARM: mach-omap1: retire custom LED code". Regards, Axel arch/ar

[PATCH v2] ARM: OMAP: Fix dependency for OMAP_DEBUG_LEDS

2012-10-07 Thread Axel Lin
#x27; arch/arm/plat-omap/built-in.o:arch/arm/plat-omap/debug-leds.c:113: more undefined references to `led_classdev_register' follow make: *** [vmlinux] Error 1 Signed-off-by: Axel Lin --- arch/arm/plat-omap/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/plat-omap/K

[PATCH] regulator: wm831x-dcdc: Add MODULE_ALIAS for wm831x-boostp

2012-11-30 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/wm831x-dcdc.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/wm831x-dcdc.c b/drivers/regulator/wm831x-dcdc.c index bce2565..731b701 100644 --- a/drivers/regulator/wm831x-dcdc.c +++ b/drivers/regulator/wm831x-dcdc.c @@ -993,4

[PATCH] irqchip: irq-sunxi: Add terminating entry for sunxi_irq_dt_ids

2012-12-02 Thread Axel Lin
The of_device_id table is supposed to be zero-terminated. Signed-off-by: Axel Lin --- drivers/irqchip/irq-sunxi.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-sunxi.c b/drivers/irqchip/irq-sunxi.c index eef41a4..10974fa 100644 --- a/drivers

[PATCH] clocksource: sunxi_timer: Add terminating entry for sunxi_timer_dt_ids

2012-12-02 Thread Axel Lin
The of_device_id table is supposed to be zero-terminated. Signed-off-by: Axel Lin --- drivers/clocksource/sunxi_timer.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clocksource/sunxi_timer.c b/drivers/clocksource/sunxi_timer.c index 3c46434..3cd1bd3 100644 --- a/drivers

[PATCH] ARM: sunxi: Include linux/delay.h

2012-12-02 Thread Axel Lin
eated as errors make[1]: *** [arch/arm/mach-sunxi/sunxi.o] Error 1 make: *** [arch/arm/mach-sunxi] Error 2 Signed-off-by: Axel Lin --- arch/arm/mach-sunxi/sunxi.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-sunxi/sunxi.c b/arch/arm/mach-sunxi/sunxi.c index dc634ae..fba8d

[PATCH] regulator: gpio-regulator: Add ifdef CONFIG_OF guard for regulator_gpio_of_match

2012-12-03 Thread Axel Lin
Use of_match_ptr and add ifdef CONFIG_OF guard for regulator_gpio_of_match. Signed-off-by: Axel Lin --- drivers/regulator/gpio-regulator.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c index

[PATCH RFT] spi: spi-xcomm: Fix wrong setting for SPI_XCOMM_SETTINGS_CPHA

2012-12-03 Thread Axel Lin
The logic of setting SPI_XCOMM_SETTINGS_CPHA bit is reversed. Signed-off-by: Axel Lin --- Hi Lars, The logic of setting SPI_XCOMM_SETTINGS_CPHA bit looks wrong to me. Can you check if this patch works? Thanks, Axel drivers/spi/spi-xcomm.c |4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] mfd: tps80031: Add terminating entry for tps80031_id_table

2012-12-05 Thread Axel Lin
The i2c_device_id table is supposed to be zero-terminated. Signed-off-by: Axel Lin --- drivers/mfd/tps80031.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/tps80031.c b/drivers/mfd/tps80031.c index f64005e..10b51f7 100644 --- a/drivers/mfd/tps80031.c +++ b/drivers/mfd

[PATCH] mfd: tps80031: MFD_TPS80031 needs to select REGMAP_IRQ

2012-12-05 Thread Axel Lin
.c:512: undefined reference to `regmap_del_irq_chip' make: *** [vmlinux] Error 1 Signed-off-by: Axel Lin --- drivers/mfd/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 09d43a9..1c0abd4 100644 --- a/drivers/mf

[PATCH] regulator: tps80031: Convert tps80031_ldo_ops to linear_min_sel and list_voltage_linear

2012-12-05 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/tps80031-regulator.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/regulator/tps80031-regulator.c b/drivers/regulator/tps80031-regulator.c index 50f89b0..b15d711 100644 --- a/drivers/regulator/tps80031

[PATCH] regulator: lp8788-ldo: Remove val array in lp8788_config_ldo_enable_mode

2012-12-06 Thread Axel Lin
To clear the mask bit, setting data argument to be 0 with proper mask setting for lp8788_update_bits. We don't need the var array here. Signed-off-by: Axel Lin --- drivers/regulator/lp8788-ldo.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/regu

[PATCH 1/2] regulator: lp8788-buck: Remove val array in lp8788_init_dvs

2012-12-07 Thread Axel Lin
All elements of val array are zero. Simply set data argument to be 0 in lp8788_update_bits call and remove the val array. Signed-off-by: Axel Lin --- drivers/regulator/lp8788-buck.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/lp8788-buck.c b

[PATCH 2/2] regulator: lp8788-buck: Kill _gpio_request function

2012-12-07 Thread Axel Lin
Simply use devm_gpio_request_one() instead. Signed-off-by: Axel Lin --- drivers/regulator/lp8788-buck.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/regulator/lp8788-buck.c b/drivers/regulator/lp8788-buck.c index d33b81a..369b034 100644 --- a

[PATCH] regulator: lp872x: Kill _rdev_to_offset() function

2012-12-07 Thread Axel Lin
There is only one user calling _rdev_to_offset() function. Remove _rdev_to_offset() makes the code simpler. Signed-off-by: Axel Lin --- drivers/regulator/lp872x.c | 36 +++- 1 file changed, 7 insertions(+), 29 deletions(-) diff --git a/drivers/regulator

[PATCH RFT 1/2] regulator: anatop: Use linear_min_sel with linear mapping

2012-12-08 Thread Axel Lin
By setting linear_min_sel to anatop_reg->min_bit_val, we can avoid adjust the anatop_reg->min_bit_val offset in [set|get]_voltage_sel. With this chance we can refactor this driver to use regulator_[get|set]_voltage_sel_regmap. Signed-off-by: Axel Lin --- drivers/regulator/anatop-regul

[PATCH RFT 2/2] regulator: anatop: Use regulator_[get|set]_voltage_sel_regmap

2012-12-08 Thread Axel Lin
Call regulator_[get|set]_voltage_sel_regmap instead of open code. Signed-off-by: Axel Lin --- drivers/regulator/anatop-regulator.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/regulator/anatop-regulator.c b/drivers/regulator/anatop

[PATCH RFT] regulator: 88pm8607: Update update_bit for BUCK2 in pm8607_set_voltage_sel

2012-12-08 Thread Axel Lin
BUCK2 has the update_bit setting, but current code does not set update_bit in pm8607_set_voltage_sel. Signed-off-by: Axel Lin --- Hi Haojian, I don't have the datasheet, can you check if this patch is correct or not? Thanks, Axel drivers/regulator/88pm8607.c |1 + 1 file chang

[PATCH] mfd: tps6507x: Convert to devm_kzalloc

2012-12-09 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/mfd/tps6507x.c | 21 - 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/mfd/tps6507x.c b/drivers/mfd/tps6507x.c index 1b20349..409afa2 100644 --- a/drivers/mfd/tps6507x.c +++ b/drivers/mfd/tps6507x.c @@ -86,9 +86,9

[PATCH] gpio: samsung: Add terminating entry for exynos_pinctrl_ids

2012-12-09 Thread Axel Lin
The of_device_id table is supposed to be zero-terminated. Signed-off-by: Axel Lin --- drivers/gpio/gpio-samsung.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c index 01f7fe9..9e251be 100644 --- a/drivers/gpio/gpio-samsung.c

[PATCH 1/2] regulator: lp3971: Convert to get_voltage_sel

2012-12-10 Thread Axel Lin
regulator_list_voltage_table() returns -EINVAL if selector >= n_voltages. Thus we don't need to check if reg is greater than BUCK_TARGET_VOL_MAX_IDX in lp3971_dcdc_get_voltage_sel. BUCK_TARGET_VOL_MIN_IDX and BUCK_TARGET_VOL_MAX_IDX are not used, remove them. Signed-off-by:

[PATCH 2/2] regulator: lp3972: Convert to get_voltage_sel

2012-12-10 Thread Axel Lin
regulator_list_voltage_table() returns -EINVAL if selector >= n_voltages. Thus we don't need to check if reg is greater than LP3972_BUCK_VOL_MAX_IDX in lp3972_dcdc_get_voltage_sel. LP3972_BUCK_VOL_MIN_IDX and LP3972_BUCK_VOL_MAX_IDX are not used, remove them. Signed-off-by:

[PATCH] regulator: vexpress: Add missing n_voltages setting

2012-12-11 Thread Axel Lin
Otherwise regulator_can_change_voltage() return 0 for this driver. Signed-off-by: Axel Lin --- drivers/regulator/vexpress.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/vexpress.c b/drivers/regulator/vexpress.c index 4668c7f..9bb3aa0 100644

[PATCH] mfd: vexpress-config: Export __vexpress_config_func_get and vexpress_config_func_put

2012-12-11 Thread Axel Lin
** [modules] Error 2 Signed-off-by: Axel Lin --- drivers/mfd/vexpress-config.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/vexpress-config.c b/drivers/mfd/vexpress-config.c index fae15d8..e6b8cbc 100644 --- a/drivers/mfd/vexpress-config.c +++ b/drivers/mfd/vexpress-confi

[PATCH] regulator: core: Fix logic to determinate if regulator can change voltage

2012-12-11 Thread Axel Lin
Having a linear_min_sel setting means the first linear_min_sel selectors are invalid. We need to subtract linear_min_sel when use n_voltages to determinate if regulator can change voltage. Signed-off-by: Axel Lin --- drivers/regulator/core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH RFC/RFT] regulator: core: Fix continuous_voltage_range case in regulator_can_change_voltage

2012-12-11 Thread Axel Lin
Regulator drivers with continuous_voltage_range flag set allows not setting n_voltages. Thus if continuous_voltage_range is set, check the constraint range instead. Signed-off-by: Axel Lin --- drivers/regulator/core.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff

[PATCH v2 1/2] pinctrl: tegra: Make PINCTRL_TEGRA select PINMUX && PINCONF

2012-11-11 Thread Axel Lin
Then we can remove "select PINMUX && PINCONF" from PINCTRL_TEGRA{20,30}. This simplifies the dependency. Signed-off-by: Axel Lin --- drivers/pinctrl/Kconfig |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/Kconfig b/drivers/pin

[PATCH v2 2/2] pinctrl: mxs: Make PINCTRL_MXS select PINMUX && PINCONF

2012-11-11 Thread Axel Lin
Then we can remove "select PINMUX && PINCONF" from PINCTRL_IMX{23,28}. This simplifies the dependency. Signed-off-by: Axel Lin Acked-by: Shawn Guo --- drivers/pinctrl/Kconfig |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/Kconfig

[PATCH] ARM: select PINCTRL for ARCH_MMP

2012-11-11 Thread Axel Lin
This makes PINCTRL related config options visible. Otherwise there is no way to build pinctrl drivers for MMP2, PXA168 and PXA910. Signed-off-by: Axel Lin --- arch/arm/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 48eea16..24e9339

[PATCH] pinctrl: Drop selecting PINCONF for MMP2, PXA168 and PXA910

2012-11-11 Thread Axel Lin
These drivers do not need to select PINCONF. Signed-off-by: Axel Lin --- drivers/pinctrl/Kconfig |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 6d5a50b..1d61d89 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig

[PATCH 1/2] pinctrl: pxa3xx: Use devm_request_and_ioremap

2012-11-11 Thread Axel Lin
Use managed resources API to simplify the code. Also ensure we do request mem_region before ioremap. Signed-off-by: Axel Lin --- drivers/pinctrl/pinctrl-pxa3xx.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/pinctrl-pxa3xx.c b/drivers/pinctrl

[PATCH 2/2] pinctrl: pxa3xx: Remove phy_base and phy_size from struct pxa3xx_pinmux_info

2012-11-11 Thread Axel Lin
They are not used, remove them. Signed-off-by: Axel Lin --- drivers/pinctrl/pinctrl-pxa3xx.c |2 -- drivers/pinctrl/pinctrl-pxa3xx.h |2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-pxa3xx.c b/drivers/pinctrl/pinctrl-pxa3xx.c index 43e3dd0..51f8a38 100644

<    1   2   3   4   5   6   7   8   9   10   >