Re: [PATCH 04/14] devicetree: Add hardware rng entry to qcom-apq8064.dtsi

2015-10-26 Thread Bjorn Andersson
t; Cc: devicet...@vger.kernel.org Reviewed-by: Bjorn Andersson > Reviewed-by: Stephen Boyd > Signed-off-by: John Stultz Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo in

Re: [PATCH] Bluetooth: hci_smd: Qualcomm WCNSS HCI driver

2015-10-01 Thread Bjorn Andersson
On Wed 30 Sep 23:54 PDT 2015, Marcel Holtmann wrote: > Hi Bjorn, > > > The Qualcomm WCNSS chip provides two SMD channels to the BT core; one > > for command and one for event packets. This driver exposes the two > > channels as a hci device. > > [..] > > diff --git a/drivers/bluetooth/Makefile b

Re: [PATCH] input: gpio_keys: Make pdev vs dev usage more consistent

2015-10-02 Thread Bjorn Andersson
On Fri 02 Oct 10:47 PDT 2015, Dmitry Torokhov wrote: > On Mon, Jul 27, 2015 at 06:50:18PM -0700, Bjorn Andersson wrote: > > As gpio_keys_setup_key() only operates on the device, pass a pointer to > > this from the probe instead of a platform_device and make the usage > >

Re: [PATCH v2 1/2] leds: core: Introduce LED pattern trigger

2018-08-02 Thread Bjorn Andersson
On Thu 02 Aug 14:21 PDT 2018, Jacek Anaszewski wrote: > On 08/01/2018 11:01 AM, Baolin Wang wrote: [..] > > diff --git a/drivers/leds/trigger/ledtrig-pattern.c > > b/drivers/leds/trigger/ledtrig-pattern.c [..] > > +static ssize_t pattern_trig_store_pattern(struct device *dev, > > +

Re: [PATCH] remoteproc: q6v5: Add support to vote for rpmh power domains

2018-08-06 Thread Bjorn Andersson
On Fri 29 Jun 03:20 PDT 2018, Rajendra Nayak wrote: > With rpmh ARC resources being modelled as power domains with > performance state, add support to proxy vote on these for SDM845. > Add support to vote on multiple of them, now that genpd supports > associating multiple power domains to a device

Re: [RFC PATCH v2 1/2] interconnect: qcom: Add sdm845 interconnect provider driver

2018-08-06 Thread Bjorn Andersson
On Wed 18 Jul 19:36 PDT 2018, David Dai wrote: > diff --git a/drivers/interconnect/qcom/sdm845.c > b/drivers/interconnect/qcom/sdm845.c [..] > +DEFINE_QNODE(ipa_core_master, MASTER_IPA_CORE, 1, 8, 1, SLAVE_IPA_CORE); [..] > +DEFINE_QNODE(ipa_core_slave, SLAVE_IPA_CORE, 1, 8, 0); As discussed befo

[PATCH] rpmsg: char: Migrate to iter versions of read and write

2018-08-07 Thread Bjorn Andersson
In order to be able to use the aio interface for writing to a rpmsg_char the write_iter function must be implemented, so migrate to iter version for read and write functions. Regular read and write uses the iter methods if present and is as such unaffected. Signed-off-by: Bjorn Andersson

Re: [PATCH] dt-bindings: soc: qcom: Fix default clock-freq for qcom,geni-i2c

2018-06-22 Thread Bjorn Andersson
27;ll assume this is an OK > "incompatible" device tree change. > > Signed-off-by: Douglas Anderson Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > > Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH] soc: qcom: geni: Make version macros simpler

2018-06-22 Thread Bjorn Andersson
subramanian > Cc: Sagar Dharia > Cc: Girish Mahadevan > Signed-off-by: Stephen Boyd I was expecting that someone referenced this macro, but I guess that's coming? Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > include/linux/qcom-geni-se.h | 13 - > 1

Re: [PATCH] arm64: dts: qcom: Add pmu node to sdm845

2018-06-22 Thread Bjorn Andersson
On Mon 21 May 23:23 PDT 2018, Stephen Boyd wrote: > Add the CPU PMU on sdm845 to get perf support for hardware events. > > Signed-off-by: Stephen Boyd Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 + > 1 file cha

Re: [PATCH] arm64: dts: qcom: Add pm8005 and pm8998 support

2018-06-22 Thread Bjorn Andersson
On Wed 13 Jun 08:20 PDT 2018, Stephen Boyd wrote: > Add basic support for the pm8005 and pm8998 PMICs. For now just support > the GPIO controllers. > > Signed-off-by: Stephen Boyd Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > arch/arm64/boot/dts/qco

Re: [PATCH] drivers: qcom: rpmh-rsc: Check cmd_db_ready() to help children

2018-06-22 Thread Bjorn Andersson
On Mon 18 Jun 10:22 PDT 2018, Douglas Anderson wrote: > Children of RPMh will need access to cmd_db. Rather than having each > child have code to check if cmd_db is ready let's add the check to > RPMh. > > Suggested-by: Stephen Boyd > Signed-off-by: Douglas Anders

Re: [PATCH v2 1/2] arm64: dts: sdm845: Add rpmh-rsc node

2018-06-22 Thread Bjorn Andersson
On Mon 18 Jun 14:50 PDT 2018, Douglas Anderson wrote: > This adds the rpmh-rsc node to sdm845 based on the examples in the > bindings. > > Signed-off-by: Douglas Anderson Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > > Changes in v2: > - Fixed ordering o

Re: [PATCH v2 2/2] arm64: dts: sdm845: Add rpmh-clk node

2018-06-22 Thread Bjorn Andersson
On Mon 18 Jun 14:50 PDT 2018, Douglas Anderson wrote: > This adds the rpmh-clk node to sdm845 based on the examples in the > bindings. > > Signed-off-by: Douglas Anderson Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > NOTE: to apply this patch cleanly, apply it at

Re: [PATCH v13 00/10] drivers/qcom: add RPMH communication support

2018-06-22 Thread Bjorn Andersson
On Wed 20 Jun 06:26 PDT 2018, Raju P L S S S N wrote: > From: "Raju P.L.S.S.S.N" > Acked-by: Bjorn Andersson Regards, Bjorn > Changes in v13: > - Add missing Signed-off-by in commit text > > Changes in v12: > - Rename ctrlr to client in rsc_drv > - Fix

Re: [PATCH v8 1/2] dt-bindings: Documentation for qcom, llcc

2018-06-22 Thread Bjorn Andersson
iewed-by: Rob Herring Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > .../devicetree/bindings/arm/msm/qcom,llcc.txt | 26 > ++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt > > diff --g

Re: [PATCH v8 2/2] drivers: soc: Add LLCC driver

2018-06-22 Thread Bjorn Andersson
nnagoud Kadabi > Signed-off-by: Rishabh Bhatnagar > Reviewed-by: Evan Green > Reviewed-by: Rob Herring Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/soc/qcom/Kconfig | 17 ++ > drivers/soc/qcom/Makefile | 2 + > drivers/soc/qcom/llcc-sdm

Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-22 Thread Bjorn Andersson
On Thu 21 Jun 08:14 PDT 2018, Stephen Boyd wrote: > Quoting Bjorn Andersson (2018-06-19 23:45:09) > > On Mon 18 Jun 13:52 PDT 2018, Stephen Boyd wrote: > > > @@ -647,6 +660,10 @@ static void msm_gpio_irq_unmask(struct irq_data *d) > > > raw_spin_lock_

Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-06-22 Thread Bjorn Andersson
uest_enable() for this pinctrl driver to mux out the GPIO > function when the gpio is use from gpiolib. > > Cc: Bjorn Andersson Reviewed-by: Bjorn Andersson Regards, Bjorn > Cc: Doug Anderson > Signed-off-by: Stephen Boyd > --- > drivers/pinctrl/qcom/pinctrl-msm.c | 16 ++

Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-06-22 Thread Bjorn Andersson
On Fri 22 Jun 10:58 PDT 2018, Bjorn Andersson wrote: > On Mon 18 Jun 13:52 PDT 2018, Stephen Boyd wrote: > > > We rely on devices to use pinmuxing configurations in DT to select the > > GPIO function (function 0) if they're going to use the gpio in GPIO > > mode. Let

Re: [PATCH v5 1/8] dt-bindings: reset: Add AOSS reset bindings for SDM845 SoCs

2018-06-22 Thread Bjorn Andersson
On Mon 21 May 10:27 PDT 2018, Sibi Sankar wrote: > Add SDM845 AOSS (always on subsystem) reset controller binding > I think it would be better if you made the binding represent the entire clock controller, rather than only the reset-related portion of it. As I can't find anything in the downstr

Re: [PATCH v5 2/8] reset: qcom: AOSS (always on subsystem) reset controller

2018-06-22 Thread Bjorn Andersson
the DT binding patch (compatible and register offsets) you have my: Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/reset/Kconfig | 9 +++ > drivers/reset/Makefile | 1 + > drivers/reset/reset-qcom-aoss.c | 133 > 3

Re: [PATCH v3 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-08-26 Thread Bjorn Andersson
errupt after we ack it. We don't do this for edge type interrupts > because it seems that toggling the raw status enable bit for edge type > interrupts causes spurious edge interrupts. > > Cc: Bjorn Andersson > Cc: Doug Anderson > Signed-off-by: Stephen Boyd Reviewed-by: B

Re: [PATCH v3 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-08-26 Thread Bjorn Andersson
uest_enable() for this pinctrl driver to mux out the GPIO > function when the gpio is use from gpiolib. > > Cc: Bjorn Andersson > Cc: Doug Anderson > Signed-off-by: Stephen Boyd Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/pinctrl/qcom/pinctrl-msm.c | 16 ++

Re: [PATCH v3 3/3] pinctrl: msm: Configure interrupts as input and gpio mode

2018-08-26 Thread Bjorn Andersson
far, we've relied on pinmux configurations in DT to handle this, but > let's explicitly configure this in the code so that DT implementers > don't have to get this part right. > > Cc: Bjorn Andersson > Cc: Doug Anderson > Signed-off-by: Stephen Boyd Reviewed-by:

Re: [PATCH v2 1/5] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-27 Thread Bjorn Andersson
On Mon 27 Aug 09:56 PDT 2018, Lina Iyer wrote: > On Sun, Aug 26 2018 at 08:33 -0600, Linus Walleij wrote: > > On Fri, Aug 17, 2018 at 6:39 PM Lina Iyer wrote: > > > > > QCOM SoC's that have Power Domain Controller (PDC) chip in the always-on > > > domain can wakeup the SoC, when interrupts and G

Re: [PATCH v2 4/5] drivers: pinctrl: qcom: sdm845: support GPIO wakeup from suspend

2018-08-27 Thread Bjorn Andersson
On Fri 24 Aug 13:01 PDT 2018, Lina Iyer wrote: > Enable TLMM IRQs to be sensed by PDC when we enter suspend. It is > possible that the TLMM may be powered off and not detect GPIOs that are > configured as wake up interrupts. By hooking into suspend callbacks, we > allow PDC IRQs to take over and w

Re: [PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for SDM845 SoCs

2018-08-27 Thread Bjorn Andersson
On Fri 24 Aug 06:18 PDT 2018, Sibi Sankar wrote: > Add PDC Global(Power Domain Controller) binding for SDM845 SoCs. > > Signed-off-by: Sibi Sankar Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > .../bindings/reset/qcom,pdc-global.txt| 52 ++

Re: [PATCH v2 2/6] reset: qcom: PDC Global (Power Domain Controller) reset controller

2018-08-27 Thread Bjorn Andersson
On Mon 27 Aug 17:22 PDT 2018, Matthias Kaehlcke wrote: > On Fri, Aug 24, 2018 at 06:48:56PM +0530, Sibi Sankar wrote: > > diff --git a/drivers/reset/reset-qcom-pdc.c b/drivers/reset/reset-qcom-pdc.c [..] > > +struct qcom_pdc_desc { > > + const struct regmap_config *config; > > + const struct qc

Re: [PATCH] rpmsg: Convert to using %pOFn instead of device_node.name

2018-08-27 Thread Bjorn Andersson
On Mon 27 Aug 18:52 PDT 2018, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Ohad Ben-Cohen > Cc: Bjorn Andersson > Cc: linux-remotep...@vger.kernel.org > Signe

Re: [PATCH v2 1/5] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-27 Thread Bjorn Andersson
On Mon 27 Aug 18:46 PDT 2018, Lina Iyer wrote: > On Mon, Aug 27 2018 at 18:26 -0600, Bjorn Andersson wrote: > > On Mon 27 Aug 09:56 PDT 2018, Lina Iyer wrote: [..] > > > Thanks, I will look into Hans's RFCv2. But what would help me would be > > > to avoid creatin

[PATCH] soc: qcom: rmtfs-mem: Validate that scm is available

2018-08-27 Thread Bjorn Andersson
Signed-off-by: Bjorn Andersson --- drivers/soc/qcom/rmtfs_mem.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/soc/qcom/rmtfs_mem.c b/drivers/soc/qcom/rmtfs_mem.c index 8a3678c2e83c..97bb5989aa21 100644 --- a/drivers/soc/qcom/rmtfs_mem.c +++ b/drivers/soc/qcom/rmtfs_mem.c @@ -212

[PATCH] remoteproc: qcom: Rename Hexagon v5 PAS driver

2018-08-27 Thread Bjorn Andersson
The Hexagon v5 ADSP driver is used for more than only the ADSP and there's an upcoming non-PAS ADSP PIL for SDM845, so rename the driver to qcom_q6v5_pas in order to better suite this. Cc: Rohit kumar Signed-off-by: Bjorn Andersson --- drivers/remoteproc/Kconfig

[PATCH] arm64: defconfig: Enable Qualcomm QRTR

2018-08-27 Thread Bjorn Andersson
The QRTR packet family is used for a wide range of communication between services in Qualcomm platforms. Examples of services using this transport for communication are remoteproc management, modem control, positioning, power management and WiFi. Signed-off-by: Bjorn Andersson --- arch/arm64

[PATCH] arm64: dts: msm8996: Transition smp2p and smd to mailbox

2018-08-27 Thread Bjorn Andersson
The smd and smp2p drivers now support accessing the APCS GLOBAL IPC register through the mailbox framework, so migrate the msm8996 dts to use this and remove the syscon based APCS node. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 13 - 1 file changed

Re: [PATCH v2] remoteproc: qcom: Introduce Non-PAS ADSP PIL driver

2018-08-27 Thread Bjorn Andersson
On Fri 29 Jun 02:20 PDT 2018, Rohit kumar wrote: > This adds APSS based ADSP PIL driver for QCOM SoCs. > Added initial support for SDM845 with ADSP bootup and > shutdown operation handled from Application Processor > SubSystem(APSS). > Hi Rohit, I've submitted a patch that renames the PAS based

[PATCH] arm64: dts: qcom: sdm845: Add smp2p nodes

2018-08-28 Thread Bjorn Andersson
Add the SMP2P nodes for the remoteproc states for adsp, cdsp, mpss and slpi. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 88 1 file changed, 88 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom

[PATCH] remoteproc: qcom: adsp: Add SDM845 ADSP and CDSP support

2018-08-28 Thread Bjorn Andersson
Add support for booting the Audio and Compute DSPs found in Qualcomm's SDM845 platform. As with the previous platforms the power rail handling needs to be updated once the appropriate support lands upstream. Signed-off-by: Bjorn Andersson --- .../devicetree/bindings/remoteproc/qcom,ads

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-28 Thread Bjorn Andersson
On Sat 25 Aug 00:51 PDT 2018, Baolin Wang wrote: > On 25 August 2018 at 04:44, Jacek Anaszewski > wrote: > > On 08/24/2018 10:12 PM, Pavel Machek wrote: > >> On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: > >>> Hi Pavel, > >>> > >>> On 08/24/2018 12:11 PM, Pavel Machek wrote: [..] > >>> +

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-28 Thread Bjorn Andersson
On Tue 28 Aug 13:25 PDT 2018, Jacek Anaszewski wrote: > On 08/25/2018 09:51 AM, Baolin Wang wrote: > > On 25 August 2018 at 04:44, Jacek Anaszewski > > wrote: > >> On 08/24/2018 10:12 PM, Pavel Machek wrote: > >>> On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: > Hi Pavel, > >

[PATCH 0/3] firmware: qcom: scm: Improve clock handling

2018-08-29 Thread Bjorn Andersson
e qcom,scm still pick up specified clocks in this case but won't require them. This makes it possible to add new platforms by simply add the new compatible to the list in the DT binding, but no changes needs to be done in the driver. Which is what is done in patch 3. Bjorn Andersson (3): dt-bin

[PATCH 3/3] dt-bindings: firmware: scm: Add MSM8998 and SDM845

2018-08-29 Thread Bjorn Andersson
Now that the compatible/clock handling is reworked add compatibles for MSM8998 and SDM845 to the SCM binding. Signed-off-by: Bjorn Andersson --- Documentation/devicetree/bindings/firmware/qcom,scm.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings

[PATCH 2/3] firmware: qcom: scm: Refactor clock handling

2018-08-29 Thread Bjorn Andersson
be use the fallback compatible of "qcom,scm". Signed-off-by: Bjorn Andersson --- drivers/firmware/qcom_scm.c | 74 + 1 file changed, 42 insertions(+), 32 deletions(-) diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index e778af766

[PATCH 1/3] dt-bindings: firmware: scm: Refactor compatibles and clocks

2018-08-29 Thread Bjorn Andersson
e added. Signed-off-by: Bjorn Andersson --- .../devicetree/bindings/firmware/qcom,scm.txt | 31 --- 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt b/Documentation/devicetree/bindings/firmware/qcom,scm.tx

Re: [PATCH v8 0/5] Support for Qualcomm UFS QMP PHY on SDM845

2018-08-29 Thread Bjorn Andersson
ans that pointing UFSHCD to this phy implementation results in a kernel panic. I do however think this series is good in itself and would like to see it merged. As any fix for this problem would be done on top of the patches in this series. Tested-by: Bjorn Andersson Regards, Bjorn

Re: [PATCH] remoteproc: q6v5: Add support to vote for rpmh power domains

2018-08-08 Thread Bjorn Andersson
On Wed 08 Aug 09:20 PDT 2018, Rajendra Nayak wrote: > On 8/6/2018 10:18 PM, Bjorn Andersson wrote: > > On Fri 29 Jun 03:20 PDT 2018, Rajendra Nayak wrote: [..] > > > +static int q6v5_powerdomain_enable(struct device *dev, struct device > > > **devs, > > > +

[PATCH v2] clk: qcom: Add some missing gcc clks for msm8996

2018-08-09 Thread Bjorn Andersson
From: Rajendra Nayak Add a few missing gcc clks for msm8996 Signed-off-by: Rajendra Nayak [bjorn: omit aggre0_noc_qosgen_extref_clk] Signed-off-by: Bjorn Andersson --- Changes since v1: - Dropped LPASS SMMU clocks already introduced by Srinivas drivers/clk/qcom/gcc-msm8996.c

Re: [PATCH v2] clk: qcom: Add some missing gcc clks for msm8996

2018-08-13 Thread Bjorn Andersson
On Fri 10 Aug 08:11 PDT 2018, Stephen Boyd wrote: > Quoting Bjorn Andersson (2018-08-09 15:01:19) > > From: Rajendra Nayak > > > > Add a few missing gcc clks for msm8996 > > > > Signed-off-by: Rajendra Nayak > > [bjorn: omit aggre0_noc_qosgen_extref_

Re: [PATCH] remoteproc/davinci: Mark error recovery as disabled

2018-08-13 Thread Bjorn Andersson
On Mon 13 Aug 08:11 PDT 2018, Suman Anna wrote: > Hi Bjorn, > > On 07/23/2018 06:27 PM, Suman Anna wrote: > > The Davinci remoteproc driver does not support error recovery at > > present, so mark the corresponding remoteproc flag appropriately > > so that the debugfs flag shows the value as 'disa

Re: [PATCH v2 1/5] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-20 Thread Bjorn Andersson
On Fri 17 Aug 09:38 PDT 2018, Lina Iyer wrote: Thanks Lina, I think this looks like a very reasonable approach! > QCOM SoC's that have Power Domain Controller (PDC) chip in the always-on > domain can wakeup the SoC, when interrupts and GPIOs are routed to the > its interrupt controller. Only sele

Re: [PATCH 1/4] dt-bindings: reset: Add PDC reset binding for SDM845 SoCs

2018-08-21 Thread Bjorn Andersson
On Fri 27 Jul 08:28 PDT 2018, Sibi Sankar wrote: > Add SDM845 PDC (Power Domain Controller) reset controller binding > Even though this is currently describing only a reset controller I think this binding better be talking about the "PDC Global" hardware. > Signed-off-by: Sibi Sankar > --- >

Re: [PATCH 2/4] reset: qcom: PDC (Power Domain Controller) reset controller

2018-08-21 Thread Bjorn Andersson
On Fri 27 Jul 08:28 PDT 2018, Sibi Sankar wrote: > Add reset controller for SDM845 SoC to control reset signals > provided by PDC for Modem, Compute, Display, GPU, Debug, AOP, > Sensors, Audio, SP and APPS > > Signed-off-by: Sibi Sankar > --- > drivers/reset/Kconfig | 9 +++ > driver

Re: [PATCH 4/4] remoteproc: qcom: q6v5-pil: Add PDC restart for modem on SDM845 SoCs

2018-08-21 Thread Bjorn Andersson
On Fri 27 Jul 08:28 PDT 2018, Sibi Sankar wrote: > In the presence of a PDC block working with subsystem RSC, > assert/deassert PDC restart in modem start/stop path. > > Signed-off-by: Sibi Sankar > --- > .../bindings/remoteproc/qcom,q6v5.txt | 4 +++ > drivers/remoteproc/qcom_q6v5_pil

Re: [PATCH v2 1/3] thermal: tsens: Rename variable

2018-07-26 Thread Bjorn Andersson
On Thu 26 Jul 03:33 PDT 2018, Amit Kucheria wrote: > We're actually reading the temperature from the status register. Fix the > variable name to reflect that. > > Signed-off-by: Amit Kucheria > Reviewed-by: Matthias Kaehlcke Reviewed-by: Bjorn Andersson Regards, Bjo

Re: [PATCH v2 2/3] thermal: tsens: switch from of_iomap() to devm_ioremap_resource()

2018-07-26 Thread Bjorn Andersson
: Amit Kucheria > Reviewed-by: Matthias Kaehlcke Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/thermal/qcom/tsens-common.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens-common.c > b/drivers

Re: [PATCH v2 3/3] thermal: tsens: Fix negative temperature reporting

2018-07-26 Thread Bjorn Andersson
by: Matthias Kaehlcke Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/thermal/qcom/tsens-v2.c | 13 + > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens-v2.c b/drivers/thermal/qcom/tsens-v2.c > index 90

Re: [PATCH] power: reset: msm: Add support for download-mode control

2018-07-18 Thread Bjorn Andersson
On Wed 18 Jul 22:18 PDT 2018, Rajendra Nayak wrote: > commit '8c1b7dc9b: firmware: qcom: scm: Expose download-mode control' > added support for download-mode control using the scm firmware > driver for platforms which require a secure call to write the magic > cookie into the tcsr location. > > F

Re: [PATCH 1/2] leds: core: Introduce LED pattern trigger

2018-07-30 Thread Bjorn Andersson
On Mon 30 Jul 05:29 PDT 2018, Baolin Wang wrote: > Some LED controllers have support for autonomously controlling > brightness over time, according to some preprogrammed pattern or > function. > > This patch adds pattern trigger that LED device can configure the > pattern and trigger it. > > Sig

Re: [PATCH] hwspinlock: Fix incorrect return pointers

2018-07-30 Thread Bjorn Andersson
On Mon 30 Jul 04:34 PDT 2018, Baolin Wang wrote: > Hi Bjorn, > > On 28 June 2018 at 10:32, Baolin Wang wrote: > > The commit 4f1acd758b08 ("hwspinlock: Add devm_xxx() APIs to request/free > > hwlock") introduces one bug, that will return one error pointer if failed > > to request one hwlock, but

Re: [PATCH] remoteproc: Reset table_ptr in rproc_start() failure paths

2018-07-30 Thread Bjorn Andersson
On Thu 26 Jul 18:15 PDT 2018, Suman Anna wrote: > Unwind the modified table_ptr and restore it to the local copy > upon any subsequent failures in the rproc_start() function. This > keeps the function to remain balanced on failures without the need > to balance any modified variables elsewhere. >

Re: [PATCH] remoteproc: qcom: fix Q6V5_WCSS dependencies

2018-07-30 Thread Bjorn Andersson
On Wed 18 Jul 04:16 PDT 2018, Arnd Bergmann wrote: > A new driver got added that depends on QCOM_SMD and fails to link > as built-in with CONFIG_QCOM_SMD=m: > > drivers/remoteproc/qcom_common.o: In function `smd_subdev_stop': > qcom_common.c:(.text+0x674): undefined reference to `qcom_smd_unregis

Re: [PATCH v7 1/4] remoteproc/davinci: use the reset framework

2018-07-30 Thread Bjorn Andersson
On Thu 21 Jun 00:37 PDT 2018, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Switch to using the reset framework instead of handcoded reset routines > we used so far. > > Signed-off-by: Bartosz Golaszewski > Reviewed-by: Sekhar Nori > Reviewed-by: Philipp

Re: [PATCH v7 0/4] ARM: davinci: complete the conversion to using the reset framework

2018-07-30 Thread Bjorn Andersson
On Mon 02 Jul 05:08 PDT 2018, Sekhar Nori wrote: > Hi Bjorn, > > On Thursday 21 June 2018 05:11 PM, Bartosz Golaszewski wrote: > > 2018-06-21 12:52 GMT+02:00 Sekhar Nori : > >> Hi Bartosz, > >> > >> On Thursday 21 June 2018 01:07 PM, Bartosz Golaszewski wrote: > >>> From: Bartosz Golaszewski > >

Re: [PATCH] ARM: dts: qcom: msm8974-hammerhead: increase load on l20 for sdhci

2018-07-31 Thread Bjorn Andersson
device to boot normally. > > Signed-off-by: Bhushan Shah > Suggested-by: Bjorn Andersson > Tested-by: Brian Masney Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts | 2 ++ > 1 file changed, 2 insertions(+) > > d

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-01 Thread Bjorn Andersson
On Wed 01 Aug 12:45 PDT 2018, Lina Iyer wrote: > Thanks for the feedback, Marc. > > On Wed, Aug 01 2018 at 00:31 -0600, Marc Zyngier wrote: > > On Wed, 01 Aug 2018 03:00:18 +0100, > > Lina Iyer wrote: [..] > > Why isn't that the case? And if that's because the HW is broken and > > doesn't buffer

Re: [PATCH v3 1/2] leds: core: Introduce generic pattern interface

2018-07-23 Thread Bjorn Andersson
On Sun 15 Jul 18:00 PDT 2018, David Lechner wrote: > On 07/15/2018 07:22 AM, Jacek Anaszewski wrote: > > On 07/15/2018 12:39 AM, Pavel Machek wrote: > > > On Sun 2018-07-15 00:29:25, Pavel Machek wrote: > > > > On Sun 2018-07-15 00:02:57, Jacek Anaszewski wrote: > > > > > Hi Pavel, > > > > > > >

Re: [PATCH v3 1/2] leds: core: Introduce generic pattern interface

2018-07-23 Thread Bjorn Andersson
On Mon 16 Jul 14:56 PDT 2018, Pavel Machek wrote: > Hi! > > > >>>echo pattern > trigger > > >>>echo "1 2 3 4 5 6 7 8" > somewhere > > >> > > >>s/somewhere/pattern/ > > >> > > >>pattern trigger should create "pattern" file similarly how ledtrig-timer > > >>creates delay_{on|off} files. > > >> > >

Re: [PATCH v3 1/2] leds: core: Introduce generic pattern interface

2018-07-23 Thread Bjorn Andersson
On Fri 20 Jul 12:11 PDT 2018, Jacek Anaszewski wrote: > Hi David, > > On 07/18/2018 07:00 PM, David Lechner wrote: > > > > > > On 7/18/18 7:08 AM, Pavel Machek wrote: > > > On Wed 2018-07-18 19:32:01, Baolin Wang wrote: > > > > On 18 July 2018 at 15:56, Pavel Machek wrote: > > > > > Hi! > > >

Re: [PATCH v5 1/2] leds: core: Introduce generic pattern interface

2018-07-23 Thread Bjorn Andersson
On Mon 16 Jul 04:10 PDT 2018, Baolin Wang wrote: > From: Bjorn Andersson > > Some LED controllers have support for autonomously controlling > brightness over time, according to some preprogrammed pattern or > function. > > This adds a new optional operator that LED class

Re: [PATCH v6 2/7] thermal: tsens: Add support to split up register address space into two

2018-07-11 Thread Bjorn Andersson
ts for the TM register bank so that the > old DTs will continue to function correctly. > > Signed-off-by: Amit Kucheria Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/thermal/qcom/tsens-8996.c | 2 +- > drivers/thermal/qcom/tsens-common.c | 11 +++ &g

Re: [PATCH v6 3/7] dt: qcom: 8996: thermal: Move to DT initialisation

2018-07-11 Thread Bjorn Andersson
SoC families. > > Since tsens-common.c/init_common() currently only registers one address > space, the order is important (TM before SROT). This is OK since the code > doesn't really use the SROT functionality yet. > > Signed-off-by: Amit Kucheria Reviewed-by: Bjorn Andersson

Re: [PATCH v6 4/7] thermal: tsens: Rename tsens-8996 to tsens-v2 for reuse

2018-07-11 Thread Bjorn Andersson
; > Signed-off-by: Amit Kucheria Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/thermal/qcom/Makefile | 2 +- > drivers/thermal/qcom/{tsens-8996.c => tsens-v2.c} | 26 > --- > 2 files changed, 10 insertions(+), 18 de

Re: [PATCH v6 5/7] thermal: tsens: Add generic support for TSENS v2 IP

2018-07-11 Thread Bjorn Andersson
: Amit Kucheria Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/thermal/qcom/tsens-v2.c | 6 +- > drivers/thermal/qcom/tsens.c| 3 +++ > drivers/thermal/qcom/tsens.h| 5 - > 3 files changed, 12 insertions(+), 2 deletions(-) > > diff --git a/drive

Re: [PATCH v6 7/7] arm64: dts: sdm845: Add tsens nodes

2018-07-11 Thread Bjorn Andersson
On Mon 09 Jul 04:43 PDT 2018, Amit Kucheria wrote: > SDM845 has two tsens blocks, one with 13 sensors and the other with 8 > sensors. It uses version 2 of the TSENS IP, so use the fallback property to > allow more common code. > > Signed-off-by: Amit Kucheria Reviewed-by:

Re: [PATCH v6 6/7] dt: thermal: tsens: Document the fallback DT property for v2 of TSENS IP

2018-07-11 Thread Bjorn Andersson
on. > > It is also necessary to split out the memory regions for the TM and SROT > register banks because their offsets are not constant across SoC families. > > Signed-off-by: Amit Kucheria Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > .../devicetree/

Re: [PATCH] phy: qcom-ufs: add MODULE_LICENSE tag

2018-01-24 Thread Bjorn Andersson
did most of the work since. > > Signed-off-by: Arnd Bergmann Acked-by: Bjorn Andersson Regards, Bjorn > --- > drivers/phy/qualcomm/phy-qcom-ufs.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-ufs.c > b/drivers/phy/qua

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-12 Thread Bjorn Andersson
On Wed 10 May 19:07 PDT 2017, Jassi Brar wrote: > On Thu, May 11, 2017 at 12:30 AM, Bjorn Andersson > wrote: > > On Tue 09 May 19:33 PDT 2017, Jassi Brar wrote: [..] > > So please let me know what you think about [1], if you don't like it > > I'll fix the thin

Re: [PATCH 2/2] ARM: dts: nexus7: Add regulator tweaks and wcnss entry to support wifi

2017-05-13 Thread Bjorn Andersson
On Fri 12 May 14:18 PDT 2017, John Stultz wrote: > lvs7 { > bias-pull-down; > + regulator-always-on; > }; Looking at the downstream regulator definition lvs7 is id

Re: [PATCH 1/2] ARM: dts: qcom-apq8064: Collapse usb support into one node

2017-05-13 Thread Bjorn Andersson
MSM wrapper we can collapse the three nodes into one USB device > node, reflecting the true nature of the hardware. > > Since we're here, we also mark the irq trigger flags correctly, > as IRQ_TYPE_LEVEL_HIGH instead of IRQ_TYPE_NONE. > > Cc: Bjorn Andersson Acked-by: Bjorn Andersson Regards, Bjorn

Re: [PATCH 1/1] remoteproc: fix elf_loader da_to_va translation and writing beyond segment

2017-05-13 Thread Bjorn Andersson
On Thu 11 May 09:12 PDT 2017, Henri Roosen wrote: > On 05/11/2017 02:05 AM, Bjorn Andersson wrote: > > On Wed 03 May 05:12 PDT 2017, Henri Roosen wrote: > > > > > Consider a system with 2 memory regions: > > > 0x1fff8000 - 0x1fff: iram > >

Re: [PATCH v2 1/5] pinctrl: qcom: Add ipq8074 pinctrl driver

2017-05-13 Thread Bjorn Andersson
On Thu 11 May 03:33 PDT 2017, Varadarajan Narayanan wrote: > > > On 5/11/2017 4:13 AM, Bjorn Andersson wrote: > > On Thu 04 May 04:53 PDT 2017, Varadarajan Narayanan wrote: > > [..] > > > +enum ipq8074_functions { > > > > Please

[PATCH v2 1/2] dt-bindings: pinctrl: Add Qualcomm SDM845 TLMM binding

2018-01-10 Thread Bjorn Andersson
This adds the DeviceTree binding for the Qualcomm SDM845 TLMM block. Signed-off-by: Bjorn Andersson --- Changes since v1: - Added qspi related functions .../bindings/pinctrl/qcom,sdm845-pinctrl.txt | 176 + 1 file changed, 176 insertions(+) create mode 100644

[PATCH v2 2/2] pinctrl: qcom: Add sdm845 pinctrl driver

2018-01-10 Thread Bjorn Andersson
From: Kyle Yan This adds the pinctrl definitions for the TLMM of SDM845. Signed-off-by: Kyle Yan Signed-off-by: Rajendra Nayak Signed-off-by: Bjorn Andersson --- Changes since v1: - Corrected the authorship of the patch - Updated pin list to v2 hardware drivers/pinctrl/qcom/Kconfig

Re: [PATCH][V2] wcn36xx: fix incorrect assignment to msg_body.min_ch_time

2018-01-04 Thread Bjorn Andersson
On Fri 29 Dec 01:07 PST 2017, Colin King wrote: > From: Colin Ian King > > The second assignment to msg_body.min_ch_time is incorrect, it > should actually be to msg_body.max_ch_time. > > Thanks to Bjorn Andersson for identifying the correct way to fix > this as my origi

Re: [PATCH 7/8] remoteproc: Drop dangling find_rsc_table dummies

2018-01-05 Thread Bjorn Andersson
On Fri 05 Jan 08:53 PST 2018, Loic PALLARDY wrote: > > > > -Original Message- > > From: linux-remoteproc-ow...@vger.kernel.org [mailto:linux-remoteproc- > > ow...@vger.kernel.org] On Behalf Of Bjorn Andersson > > Sent: Wednesday, December 13, 2017 11:41 PM

[PATCH v2 2/8] remoteproc: Cache resource table size

2018-01-05 Thread Bjorn Andersson
We don't re-read the resource table during a recovery, so it is possible in the recovery path that the resource table has a different size than cached_table. Store the original size of cached_table to avoid these getting out of sync. Signed-off-by: Bjorn Andersson --- Changes since v1: -

[PATCH v2 4/8] remoteproc: Merge rproc_ops and rproc_fw_ops

2018-01-05 Thread Bjorn Andersson
the "load" operation is assumed to want the full ELF-loader suit of functions. Signed-off-by: Bjorn Andersson --- Changes since v1: - Fill load, sanity_check and get_boot_addr for st_slim drivers/remoteproc/qcom_adsp_pil.c | 9 ++ drivers/remoteproc/qcom_q6v

[PATCH v2 6/8] remoteproc: Move resource table load logic to find

2018-01-05 Thread Bjorn Andersson
table. This leaves the custom, dummy, find_rsc_table implementations found in some drivers dangling. Signed-off-by: Bjorn Andersson --- Changes since v1: - None drivers/remoteproc/remoteproc_core.c | 32 ++ drivers/remoteproc/remoteproc_elf_loader.c | 37

[PATCH v2 8/8] remoteproc: Reset table_ptr on stop

2018-01-05 Thread Bjorn Andersson
The installed resource table is no longer accessible after stopping the remote, so update table_ptr to point to the local copy. Signed-off-by: Bjorn Andersson --- Changes since v1: - None drivers/remoteproc/remoteproc_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers

[PATCH v2 7/8] remoteproc: Drop dangling find_rsc_table dummies

2018-01-05 Thread Bjorn Andersson
As the core now deals with the lack of a resource table, remove the dangling custom dummy implementations of find_rsc_table from drivers. Signed-off-by: Bjorn Andersson --- Changes since v1: - None drivers/remoteproc/qcom_adsp_pil.c | 1 - drivers/remoteproc/qcom_common.c | 19

[PATCH v2 5/8] remoteproc: Don't handle empty resource table

2018-01-05 Thread Bjorn Andersson
Allow a NULL table_ptr to have the same meaning as a table with 0 entries, allowing a subsequent patch to skip the assignment step. A few other places in the implementation does dereference table_ptr, but they are currently all coming from rproc_handle_resources(). Signed-off-by: Bjorn Andersson

[PATCH v2 0/8] Remoteproc cleanups

2018-01-05 Thread Bjorn Andersson
provided by drivers. Then finally the last patch ensures that table_ptr isn't left pointing into memory of a stopped remoteproc. Bjorn Andersson (8): remoteproc: Remove depricated crash completion remoteproc: Cache resource table size remoteproc: Clone rproc_ops in rproc_alloc() remot

[PATCH v2 3/8] remoteproc: Clone rproc_ops in rproc_alloc()

2018-01-05 Thread Bjorn Andersson
In order to allow rproc_alloc() to, in a future patch, update entries in the "ops" struct we need to make a local copy of it. Signed-off-by: Bjorn Andersson --- Changes since v1: - None drivers/remoteproc/remoteproc_core.c | 9 - include/linux/remoteproc.h | 2 +

[PATCH v2 1/8] remoteproc: Remove depricated crash completion

2018-01-05 Thread Bjorn Andersson
The crash handling now happens in a single execution context, so there's no longer a need for a completion to synchronize this. Signed-off-by: Bjorn Andersson --- Changes since v1: - None drivers/remoteproc/remoteproc_core.c | 10 -- include/linux/remoteproc.h | 2

[PATCH v3 4/4] remoteproc: qcom: Register segments for core dump

2018-01-05 Thread Bjorn Andersson
From: Sarangdhar Joshi Register MDT segments with the remoteproc core dump functionality in order to include them in a core dump, in case of a recovery of the remote processor. Signed-off-by: Sarangdhar Joshi Signed-off-by: Bjorn Andersson --- Changes since v2: - None Changes since v1

[PATCH v3 2/4] remoteproc: Rename "load_rsc_table" to "parse_fw"

2018-01-05 Thread Bjorn Andersson
The resource table is just one possible source of information that can be extracted from the firmware file. Generalize this interface to allow drivers to override this with parsers of other types of information. Signed-off-by: Bjorn Andersson --- Changes since v2: - Improved comment by call to

[PATCH v3 3/4] soc: qcom: mdt-loader: Return relocation base

2018-01-05 Thread Bjorn Andersson
In order to implement support for grabbing core dumps in remoteproc it's necessary to know the relocated base of the image, as the offsets from the virtual memory base might not be based on the physical address. Return the adjusted physical base address to the caller. Signed-off-by:

[PATCH v3 1/4] remoteproc: Add remote processor coredump support

2018-01-05 Thread Bjorn Andersson
the remote has stopped and before the restart sequence has begun in the recovery path. The remoteproc framework builds the core dump in memory and use devcoredump to expose this to user space. Signed-off-by: Sarangdhar Joshi [bjorn: Use vmalloc instead of composing the ELF on the fly] Signed-off

[PATCH v3 0/4] Remoteproc core dump support

2018-01-05 Thread Bjorn Andersson
n the case of a crash of the remote processor. Bjorn Andersson (2): remoteproc: Rename "load_rsc_table" to "parse_fw" soc: qcom: mdt-loader: Return relocation base Sarangdhar Joshi (2): remoteproc: Add remote processor coredump support remoteproc: qcom: Register segme

[PATCH 1/2] dt-bindings: pinctrl: Add Qualcomm SDM845 TLMM binding

2018-01-05 Thread Bjorn Andersson
This adds the DeviceTree binding for the Qualcomm SDM845 TLMM block. Signed-off-by: Bjorn Andersson --- .../bindings/pinctrl/qcom,sdm845-pinctrl.txt | 176 + 1 file changed, 176 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sdm845

<    1   2   3   4   5   6   7   8   9   10   >