Re: [LINUX PATCH v18 1/2] mtd: rawnand: nand_micron: Do not over write driver's read_page()/write_page()

2019-07-17 Thread Boris Brezillon
On Wed, 17 Jul 2019 10:21:56 +0200 Boris Brezillon wrote: > On Wed, 17 Jul 2019 09:55:25 +0200 > Boris Brezillon wrote: > > > On Wed, 17 Jul 2019 05:33:35 + > > Naga Sureshkumar Relli wrote: > > > > > Hi Boris, > > > > > > >

Re: [LINUX PATCH v18 1/2] mtd: rawnand: nand_micron: Do not over write driver's read_page()/write_page()

2019-07-17 Thread Boris Brezillon
On Wed, 17 Jul 2019 09:55:25 +0200 Boris Brezillon wrote: > On Wed, 17 Jul 2019 05:33:35 + > Naga Sureshkumar Relli wrote: > > > Hi Boris, > > > > > -Original Message----- > > > From: Boris Brezillon > > > Sent: Tuesday, July 1

Re: [LINUX PATCH v18 1/2] mtd: rawnand: nand_micron: Do not over write driver's read_page()/write_page()

2019-07-17 Thread Boris Brezillon
On Wed, 17 Jul 2019 05:33:35 + Naga Sureshkumar Relli wrote: > Hi Boris, > > > -Original Message- > > From: Boris Brezillon > > Sent: Tuesday, July 16, 2019 1:15 PM > > To: Naga Sureshkumar Relli > > Cc: miquel.ray...@bootlin.com; bbrezil..

Re: [PATCH v4 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-07-16 Thread Boris Brezillon
On Tue, 16 Jul 2019 13:22:25 + Vitor Soares wrote: > Hi Boris, > > From: Boris Brezillon > Date: Fri, Jul 12, 2019 at 21:03:20 > > > On Fri, 12 Jul 2019 18:40:14 + > > Vitor Soares wrote: > > > > > From: Boris Brezillon

Re: [LINUX PATCH v18 1/2] mtd: rawnand: nand_micron: Do not over write driver's read_page()/write_page()

2019-07-16 Thread Boris Brezillon
On Tue, 16 Jul 2019 09:31:37 +0200 Boris Brezillon wrote: > On Mon, 15 Jul 2019 23:30:51 -0600 > Naga Sureshkumar Relli wrote: > > > Add check before assigning chip->ecc.read_page() and chip->ecc.write_page() > > > > Signed-off-by: Naga Sureshkumar

Re: [LINUX PATCH v18 1/2] mtd: rawnand: nand_micron: Do not over write driver's read_page()/write_page()

2019-07-16 Thread Boris Brezillon
> + chip->ecc.write_page = > micron_nand_write_page_on_die_ecc; > Seriously?! I told you this was inappropriate and you keep sending this patch. So let's make it clear: Nacked-by: Boris Brezillon Fix your controller driver instead of adding hacks

Re: [PATCH v4 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-07-12 Thread Boris Brezillon
On Fri, 12 Jul 2019 18:40:14 + Vitor Soares wrote: > From: Boris Brezillon > Date: Fri, Jul 12, 2019 at 17:43:23 > > > On Fri, 12 Jul 2019 16:28:02 + > > Vitor Soares wrote: > > > > > From: Boris Brezillon > > > Date: Fri, Jul 12, 201

Re: [PATCH v4 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-07-12 Thread Boris Brezillon
On Fri, 12 Jul 2019 16:28:02 + Vitor Soares wrote: > From: Boris Brezillon > Date: Fri, Jul 12, 2019 at 17:14:29 > > > On Fri, 12 Jul 2019 13:53:30 +0200 > > Vitor Soares wrote: > > > > > For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR s

Re: [PATCH v4 2/3] i3c: move i3c_device_match_id to device.c and export it

2019-07-12 Thread Boris Brezillon
On Fri, 12 Jul 2019 16:21:49 + Vitor Soares wrote: > > > > You're missing a kerneldoc here. > > I will do that. Can you clarify why we need that? > So the function is properly documented here [1]. > > > > > +const struct i3c_device_id * > > > +i3c_device_match_id(struct i3c_device *

Re: [PATCH v4 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-07-12 Thread Boris Brezillon
On Fri, 12 Jul 2019 13:53:30 +0200 Vitor Soares wrote: > For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in > spi and i2c mode. > > The LSM6DSO and LSM6DSR are also i3c capable so lets give i3c support to > them. > > Signed-off-by: Vitor Soares > Acked-by: Lorenzo Bianc

Re: [PATCH v4 2/3] i3c: move i3c_device_match_id to device.c and export it

2019-07-12 Thread Boris Brezillon
On Fri, 12 Jul 2019 13:53:29 +0200 Vitor Soares wrote: > The i3c device driver needs the i3c_device_id table. "Some I3C device drivers need to know which entry matches the i3c_device object passed to the probe function" > Lets move to device.c and export it to be used. "Let's move i3c_device

Re: [PATCH v4 1/3] regmap: add i3c bus support

2019-07-12 Thread Boris Brezillon
On Fri, 12 Jul 2019 13:53:28 +0200 Vitor Soares wrote: > Add basic support for i3c bus. > This is a simple implementation that only give support > for SDR Read and Write commands. > This patch has been applied by Mark already. Please make sure to drop already applied patches when submitting a n

Re: [PATCH v4 0/3] Add ST lsm6dso i3c support

2019-07-12 Thread Boris Brezillon
On Fri, 12 Jul 2019 13:53:27 +0200 Vitor Soares wrote: > This patch series add i3c support for STM LSM6DSO and LSM6DSR sensors. > > It is also introduced i3c support on regmap api. Due the lack of > i3c devices HDR capables on the market the support for now is only for > i3c sdr mode by using i3

[GIT PULL] i3c: Changes for 5.3

2019-07-06 Thread Boris Brezillon
Hello Linus, Here is the I3C PR for 5.3. Regards, Boris The following changes since commit a188339ca5a396acc588e5851ed7e19f66b0ebd9: Linux 5.2-rc1 (2019-05-19 15:47:09 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/i3c/linux.git tags/i3c/for-

Re: [PATCH 3/9] media: hantro: Constify the control array

2019-07-05 Thread Boris Brezillon
On Fri, 05 Jul 2019 13:05:10 -0300 Ezequiel Garcia wrote: > On Wed, 2019-06-19 at 14:15 +0200, Boris Brezillon wrote: > > controls[] is not supposed to be modified at runtime, let's make it > > explicit by adding a const specifier. > > > > Signed-off-by: Boris

Re: [PATCH v2 1/2] media: uapi: Add VP8 stateless decoder API

2019-07-04 Thread Boris Brezillon
On Thu, 04 Jul 2019 10:00:33 -0300 Ezequiel Garcia wrote: > > Oops, this is just an internal note, it seems I forgot to remove this one. > > > I am right to think that this is basically the size in bits of the > > frame header ? Maybe it could be another way to formulate it ? I'm just > > tryi

Re: [PATCH v2 2/2] media: hantro: Add support for VP8 decoding on rk3288

2019-07-04 Thread Boris Brezillon
On Thu, 04 Jul 2019 09:32:13 -0300 Ezequiel Garcia wrote: > On Thu, 2019-07-04 at 09:19 +0200, Boris Brezillon wrote: > > +Kees for the safe-array-iteratio question. > > > > On Wed, 03 Jul 2019 16:26:46 +0200 > > Philipp Zabel wrote: > > > > > Hi E

Re: [PATCH v2 1/2] dt-bindings: i3c: Document MediaTek I3C master bindings

2019-07-04 Thread Boris Brezillon
On Wed, 26 Jun 2019 13:36:27 +0800 Qii Wang wrote: > Document MediaTek I3C master DT bindings. > You forgot to Cc the DT maintainers/ML. > Signed-off-by: Qii Wang > --- > .../devicetree/bindings/i3c/mtk,i3c-master.txt | 47 > > 1 file changed, 47 insertions(+) >

Re: [PATCH v2 2/2] media: hantro: Add support for VP8 decoding on rk3288

2019-07-04 Thread Boris Brezillon
t; > > Signed-off-by: ZhiChao Yu > > Signed-off-by: Tomasz Figa > > Signed-off-by: Boris Brezillon > > Signed-off-by: Ezequiel Garcia > > I have just tried this (with broken userspace) and got a crash in > cfg_parts, see below for details: > >

Re: [PATCH v2 2/2] media: hantro: Add support for VP8 decoding on rk3288

2019-07-03 Thread Boris Brezillon
eight = 48, > + .max_height = 2160, > + .step_height = 16, Can you define VP8_MB_DIM and use if for step_{width,height} (as done for MPEG2 and H264)? Looks good otherwise: Reviewed-by: Boris Brezillon > + }, > + }, > };

Re: [PATCH v2 1/2] media: uapi: Add VP8 stateless decoder API

2019-07-03 Thread Boris Brezillon
-off-by: Pawel Osciak > Signed-off-by: Ezequiel Garcia Reviewed-by: Boris Brezillon > -- > Changes from v1: > * Move 1-bit fields to flags in the respective structures. > * Add padding fields to make all structures 8-byte aligned. > * Reorder fields where needed to avoid padding as

Re: [LINUX PATCH v17 2/2] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface

2019-07-03 Thread Boris Brezillon
On Wed, 3 Jul 2019 11:29:49 + Naga Sureshkumar Relli wrote: > Hi Boris, > > > -Original Message- > > From: Boris Brezillon > > Sent: Wednesday, July 3, 2019 4:37 PM > > To: Naga Sureshkumar Relli > > Cc: miquel.ray...@bootlin.com; helmut.gro..

Re: [LINUX PATCH v17 2/2] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface

2019-07-03 Thread Boris Brezillon
On Wed, 3 Jul 2019 08:57:57 + Naga Sureshkumar Relli wrote: > Hi Boris, > > Thanks for the review. > > > -Original Message----- > > From: Boris Brezillon > > Sent: Wednesday, July 3, 2019 11:56 AM > > To: Naga Sureshkumar Relli > >

Re: [LINUX PATCH v17 2/2] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface

2019-07-02 Thread Boris Brezillon
On Mon, 24 Jun 2019 22:46:30 -0600 Naga Sureshkumar Relli wrote: > + > +/** > + * pl353_nand_exec_op_cmd - Send command to NAND device > + * @chip:Pointer to the NAND chip info structure > + * @subop: Pointer to array of instructions > + * Return: Always return zero > + */ > +static int

Re: nvmem creates multiple devices with the same name

2019-07-02 Thread Boris Brezillon
On Tue, 21 May 2019 10:56:41 +0200 Sascha Hauer wrote: > Hi all, > > nvmem derives the device name directly from the partition name of the > underlying device. IMO this is wrong since it's not possible to create > two partitions with the same name on different devices. In my case I > have a NAND

Re: [PATCH v2 1/2] dt-bindings: i3c: Document MediaTek I3C master bindings

2019-06-26 Thread Boris Brezillon
On Wed, 26 Jun 2019 13:36:27 +0800 Qii Wang wrote: > Document MediaTek I3C master DT bindings. > > Signed-off-by: Qii Wang > --- > .../devicetree/bindings/i3c/mtk,i3c-master.txt | 47 > > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetre

Re: [LINUX PATCH v17 1/2] mtd: rawnand: nand_micron: Do not over write driver's read_page()/write_page()

2019-06-26 Thread Boris Brezillon
On Wed, 26 Jun 2019 12:12:47 + Naga Sureshkumar Relli wrote: > Hi Boris, > > > -Original Message- > > From: Boris Brezillon > > Sent: Wednesday, June 26, 2019 5:34 PM > > To: Naga Sureshkumar Relli > > Cc: miquel.ray...@bootlin.com; helmut.gro..

Re: [LINUX PATCH v17 1/2] mtd: rawnand: nand_micron: Do not over write driver's read_page()/write_page()

2019-06-26 Thread Boris Brezillon
On Wed, 26 Jun 2019 11:51:12 + Naga Sureshkumar Relli wrote: > Hi Boris, > > > -Original Message- > > From: Boris Brezillon > > Sent: Wednesday, June 26, 2019 4:57 PM > > To: Naga Sureshkumar Relli > > Cc: miquel.ray...@bootlin.com; helmut.gro..

Re: [LINUX PATCH v17 1/2] mtd: rawnand: nand_micron: Do not over write driver's read_page()/write_page()

2019-06-26 Thread Boris Brezillon
On Wed, 26 Jun 2019 11:22:33 + Naga Sureshkumar Relli wrote: > Hi Boris, > > > -Original Message- > > From: Boris Brezillon > > Sent: Wednesday, June 26, 2019 12:18 PM > > To: Naga Sureshkumar Relli > > Cc: miquel.ray...@bootlin.com; helm

Re: [LINUX PATCH v17 1/2] mtd: rawnand: nand_micron: Do not over write driver's read_page()/write_page()

2019-06-25 Thread Boris Brezillon
On Mon, 24 Jun 2019 22:46:29 -0600 Naga Sureshkumar Relli wrote: > Add check before assigning chip->ecc.read_page() and chip->ecc.write_page() > > Signed-off-by: Naga Sureshkumar Relli > --- > drivers/mtd/nand/raw/nand_micron.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) >

Re: [PATCH v2] mtd: spinand: read return badly if the last page has bitflips

2019-06-20 Thread Boris Brezillon
last page read returns with 0. > > Signed-off-by: liaoweixiong Reviewed-by: Boris Brezillon > --- > drivers/mtd/nand/spi/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c > index 556b

Re: [PATCH] mtd: spinand: fix error read return value

2019-06-19 Thread Boris Brezillon
On Wed, 19 Jun 2019 14:02:14 + Schrempf Frieder wrote: > On 19.06.19 15:46, Boris Brezillon wrote: > > Hi liaoweixiong, > > > > On Wed, 19 Jun 2019 21:13:24 +0800 > > liaoweixiong wrote: > > > >> In function spinand_mtd_read, if the last page

Re: [PATCH] mtd: spinand: fix error read return value

2019-06-19 Thread Boris Brezillon
Hi liaoweixiong, On Wed, 19 Jun 2019 21:13:24 +0800 liaoweixiong wrote: > In function spinand_mtd_read, if the last page to read occurs bitflip, > this function will return error value because veriable ret not equal to 0. Actually, that's exactly what the MTD core expects (see [1]), so you're t

Re: [PATCH 0/9] media: hantro: Add support for H264 decoding

2019-06-19 Thread Boris Brezillon
On Wed, 19 Jun 2019 14:15:31 +0200 Boris Brezillon wrote: > Hello, > > This patch series adds support H264 decoding support to the hantro > driver and doing some consilidation cleanup in the driver along the > way. > > Some details about the patches forming this patch

[PATCH 2/9] media: hantro: Move copy_metadata() before doing a decode operation

2019-06-19 Thread Boris Brezillon
starting the decode operation. Suggested-by: Jonas Karlman Signed-off-by: Boris Brezillon --- drivers/staging/media/hantro/hantro_drv.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/hantro/hantro_drv.c b/drivers/staging/media/hantro

[PATCH 8/9] media: hantro: Add support for H264 decoding on G1

2019-06-19 Thread Boris Brezillon
From: Hertz Wong Add the G1 specific bits to support H264 decoding. Signed-off-by: Hertz Wong Signed-off-by: Boris Brezillon --- drivers/staging/media/hantro/Makefile | 1 + .../staging/media/hantro/hantro_g1_h264_dec.c | 295 ++ drivers/staging/media/hantro

[PATCH 1/9] lib/sort.c: implement sort() variant taking context argument

2019-06-19 Thread Boris Brezillon
that will eliminate the indirect comparison calls in common cases. Requested-by: Boris Brezillon Signed-off-by: Rasmus Villemoes Signed-off-by: Boris Brezillon Cc: Andrew Morton --- Hi all, Andrew, you acked the first version of this patch, but Rasmus proposed a better solution and posted a v2

[PATCH 5/9] media: hantro: Add hantro_get_{src,dst}_buf() helpers

2019-06-19 Thread Boris Brezillon
And replace all calls to v4l2_m2m_next_{src,dst}_buf() by hantro_get_{src,dst}_buf() one. Signed-off-by: Boris Brezillon --- drivers/staging/media/hantro/hantro.h | 13 + drivers/staging/media/hantro/hantro_drv.c | 4 ++-- drivers/staging/media/hantro

[PATCH 3/9] media: hantro: Constify the control array

2019-06-19 Thread Boris Brezillon
controls[] is not supposed to be modified at runtime, let's make it explicit by adding a const specifier. Signed-off-by: Boris Brezillon --- drivers/staging/media/hantro/hantro_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/hantro/hantro_drv

[PATCH 6/9] media: hantro: Add helpers to prepare/finish a run

2019-06-19 Thread Boris Brezillon
And use them where appropriate. Signed-off-by: Boris Brezillon --- We might want to move those hantro_{prepare,finish}_run() calls to device_run() and have a 2-step approach similar to cedrus (prepare + trigger) at some point, but let's keep that for later. --- drivers/staging/media/h

[PATCH 7/9] media: hantro: Add core bits to support H264 decoding

2019-06-19 Thread Boris Brezillon
From: Hertz Wong Add helpers and patch hantro_{drv,v4l2}.c to prepare addition of H264 decoding support. Signed-off-by: Hertz Wong Signed-off-by: Boris Brezillon --- drivers/staging/media/hantro/Makefile | 1 + drivers/staging/media/hantro/hantro.h | 9 +- drivers/staging/media

[PATCH 9/9] media: hantro: Enable H264 decoding on rk3288

2019-06-19 Thread Boris Brezillon
From: Hertz Wong Now that the generic bits have been added, we can activate H264 decoding on rk3288. Signed-off-by: Hertz Wong Signed-off-by: Boris Brezillon --- drivers/staging/media/hantro/rk3288_vpu_hw.c | 21 +++- 1 file changed, 20 insertions(+), 1 deletion(-) diff

[PATCH 4/9] media: hantro: Simplify the controls creation logic

2019-06-19 Thread Boris Brezillon
v4l2_ctrl_new_custom() should work for any kind of control, including standard ones. With that change, we automatically get support for menu controls. Signed-off-by: Boris Brezillon --- drivers/staging/media/hantro/hantro.h | 2 -- drivers/staging/media/hantro/hantro_drv.c | 28

[PATCH 0/9] media: hantro: Add support for H264 decoding

2019-06-19 Thread Boris Brezillon
uiel's VP8 work [1]. * It depends on [2] which defines/described the H264 decoding mode control. * Depends on [3] since I'm using vb2_get_buffer() to retrieve a reference buffer * The final dep is a fix I sent this morning allowing me to simplify the ctrl initialization logic Re

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-06-19 Thread Boris Brezillon
On Wed, 19 Jun 2019 16:55:52 +0800 masonccy...@mxic.com.tw wrote: > Hi Boris, > > > > > > > > > Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND > controller > > > > > > > > On Tue,

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-06-19 Thread Boris Brezillon
On Wed, 19 Jun 2019 16:04:43 +0800 masonccy...@mxic.com.tw wrote: > Hi Boris, > > > > > Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller > > > > On Tue, 18 Jun 2019 08:14:36 +0200 > > Boris Brezillon wrote: > > > > >

Re: [PATCH] lib/sort.c: implement sort() variant taking context argument

2019-06-18 Thread Boris Brezillon
sily predicted branch to each comparison call. > > Aside from introducing support for the context argument, this also > serves as preparation for patches that will eliminate the indirect > comparison calls in common cases. > > Requested-by: Boris Brezillon > Signed-off-by: Rasmus V

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-06-18 Thread Boris Brezillon
On Tue, 18 Jun 2019 08:14:36 +0200 Boris Brezillon wrote: > > > > > > > > > > > > How to make all #CS keep high for NAND to enter > > > > > > low-power standby mode if driver don't use "legacy.select_chip()" > > >

Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

2019-06-17 Thread Boris Brezillon
Hi Mason, On Tue, 18 Jun 2019 09:24:14 +0800 masonccy...@mxic.com.tw wrote: > Hi Miquel, > > > > > > > > > > > > +static void mxic_nand_select_chip(struct nand_chip *chip, > int > > > > > > > > chipnr) > > > > > > > > > > > > > > > > _select_target() is preferred now > > > > > >

Re: [PATCH] lib/sort: Add the sort_r() variant

2019-06-17 Thread Boris Brezillon
Hello Rasmus, On Fri, 24 May 2019 17:09:37 +0200 Boris Brezillon wrote: > Hello Rasmus, > > On Thu, 23 May 2019 22:04:35 +0200 > Rasmus Villemoes wrote: > > > On 22/05/2019 13.25, Boris Brezillon wrote: > > > Some users might need extra context to compare 2 e

Re: [PATCH v3 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-06-12 Thread Boris Brezillon
On Wed, 12 Jun 2019 13:37:53 + Vitor Soares wrote: > From: Boris Brezillon > Date: Wed, Jun 12, 2019 at 12:37:27 > > > On Wed, 12 Jun 2019 11:16:34 + > > Vitor Soares wrote: > > > > > From: Boris Brezillon > > > Date: Wed, Jun 12, 201

Re: [PATCH v3 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-06-12 Thread Boris Brezillon
On Wed, 12 Jun 2019 11:16:34 + Vitor Soares wrote: > From: Boris Brezillon > Date: Wed, Jun 12, 2019 at 07:15:33 > > > On Tue, 11 Jun 2019 16:06:43 +0200 > > Vitor Soares wrote: > > > > > Currently the I3C framework limits SCL frequency to FM speed

Re: [PATCH v3 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-06-11 Thread Boris Brezillon
mixed slow mode and was erroneously using FM+ speed as the > max I2C speed when operating in mixed fast mode. > > Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure") > Signed-off-by: Vitor Soares > Cc: Boris Brezillon > Cc: > Cc: > --- > Changes in v3

Re: [PATCH 2/2] i3c: master: Add driver for MediaTek IP

2019-06-11 Thread Boris Brezillon
On Tue, 11 Jun 2019 20:25:22 +0800 Qii Wang wrote: > On Tue, 2019-06-04 at 20:26 +0800, Qii Wang wrote: > > On Tue, 2019-06-04 at 09:58 +0200, Boris Brezillon wrote: > > > On Mon, 3 Jun 2019 11:51:03 +0800 > > > Qii Wang wrote: > > > > > > &g

Re: [PATCH v2 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-06-06 Thread Boris Brezillon
On Thu, 6 Jun 2019 18:08:11 + Vitor Soares wrote: > From: Boris Brezillon > Date: Thu, Jun 06, 2019 at 18:35:40 > > > On Thu, 6 Jun 2019 17:16:55 + > > Vitor Soares wrote: > > > > > From: Boris Brezillon > > > Date: Thu, Jun 06, 201

Re: [PATCH v2 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-06-06 Thread Boris Brezillon
On Thu, 6 Jun 2019 17:16:55 + Vitor Soares wrote: > From: Boris Brezillon > Date: Thu, Jun 06, 2019 at 15:18:44 > > > On Thu, 6 Jun 2019 16:00:01 +0200 > > Vitor Soares wrote: > > > > > Currently the I3C framework limits SCL frequency to FM speed

Re: [PATCH v2 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-06-06 Thread Boris Brezillon
On Thu, 6 Jun 2019 17:12:04 +0200 Vitor Soares wrote: > For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in > spi and i2c mode. > > The LSM6DSO and LSM6DSR are also i3c capable so lets give i3c support to > them. > > Signed-off-by: Vitor Soares > --- > Changes in v2: >

Re: [PATCH v2 2/3] i3c: add i3c_get_device_id helper

2019-06-06 Thread Boris Brezillon
On Thu, 6 Jun 2019 17:12:03 +0200 Vitor Soares wrote: > This helper return the i3c_device_id structure in order the client > have access to the driver data. > > Signed-off-by: Vitor Soares > --- > Changes in v2: > move this function to drivers/i3c/device.c > > drivers/i3c/device.c |

Re: [PATCH v2 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-06-06 Thread Boris Brezillon
mixed slow mode and was erroneously using FM+ speed as the > max I2C speed when operating in mixed fast mode. > > Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure") > Signed-off-by: Vitor Soares > Cc: Boris Brezillon > Cc: > Cc: > --- > Changes in

Re: [EXT] Re: [PATCH v3 04/12] mtd: rawnand: introduce struct onfi_helper

2019-06-04 Thread Boris Brezillon
On Tue, 4 Jun 2019 12:02:28 + "Shivamurthy Shastri (sshivamurthy)" wrote: > Hi Boris, > > > > Create onfi_helper object. This is base to turn ONFI code to generic. > > > > > > Signed-off-by: Shivamurthy Shastri > > > --- > > > include/linux/mtd/nand.h | 21 + > > > 1 fi

Re: [PATCH 2/2] i3c: master: Add driver for MediaTek IP

2019-06-04 Thread Boris Brezillon
On Mon, 3 Jun 2019 11:51:03 +0800 Qii Wang wrote: > +static int mtk_i3c_master_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct mtk_i3c_master *master; > + struct resource *res; > + int ret, irqnr; > + > + master = devm_kzalloc(dev, siz

Re: [PATCH 1/3] mtd: nand: raw: brcmnand: Refactored code and introduced inline functions

2019-06-03 Thread Boris Brezillon
On Mon, 3 Jun 2019 10:11:20 -0400 Kamal Dasu wrote: > Boris, > > On Sat, Jun 1, 2019 at 3:57 AM Boris Brezillon > wrote: > > > > On Thu, 30 May 2019 17:20:35 -0400 > > Kamal Dasu wrote: > > > > > Refactored NAND ECC and CMD address con

Re: [PATCH v3 04/12] mtd: rawnand: introduce struct onfi_helper

2019-06-03 Thread Boris Brezillon
Hi Shivamurthy, On Mon, 3 Jun 2019 12:43:28 + "Shivamurthy Shastri (sshivamurthy)" wrote: > Create onfi_helper object. This is base to turn ONFI code to generic. > > Signed-off-by: Shivamurthy Shastri > --- > include/linux/mtd/nand.h | 21 + > 1 file changed, 21 insert

Re: [PATCH] i3c: master: Use struct_size() helper

2019-06-01 Thread Boris Brezillon
On Fri, 31 May 2019 12:35:32 -0500 "Gustavo A. R. Silva" wrote: > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes, in particular in the > context in which this code is being used. > > So, replace the following form: > > sizeo

Re: [PATCH 1/3] mtd: nand: raw: brcmnand: Refactored code and introduced inline functions

2019-06-01 Thread Boris Brezillon
On Thu, 30 May 2019 17:20:35 -0400 Kamal Dasu wrote: > Refactored NAND ECC and CMD address configuration code to use inline > functions. I'd expect the compiler to be smart enough to decide when inlining is appropriate. Did you check that adding the inline specifier actually makes a difference?

Re: [PATCH] lib/sort: Add the sort_r() variant

2019-05-24 Thread Boris Brezillon
Hello Rasmus, On Thu, 23 May 2019 22:04:35 +0200 Rasmus Villemoes wrote: > On 22/05/2019 13.25, Boris Brezillon wrote: > > Some users might need extra context to compare 2 elements. This patch > > adds the sort_r() which is similar to the qsort_r() variant of qsort(). > &g

Re: [PATCH] lib/sort: Add the sort_r() variant

2019-05-23 Thread Boris Brezillon
Hi Andrew, On Wed, 22 May 2019 11:33:15 -0700 Andrew Morton wrote: > On Wed, 22 May 2019 13:25:50 +0200 Boris Brezillon > wrote: > > > Some users might need extra context to compare 2 elements. This patch > > adds the sort_r() which is similar to the qsort

Re: [PATCH] mtd: onenand_base: Avoid fall-through warnings

2019-05-22 Thread Boris Brezillon
On Wed, 22 May 2019 14:30:11 -0700 Kees Cook wrote: > Sorry for being late to speaking up on this. I missed something in the > code the first time I read the thread, that now stood out to me. Notes > below... > > On Wed, May 22, 2019 at 01:04:46PM -0500, Gustavo A. R. Silva wrote: > > diff --git

Re: [PATCH] mtd: onenand_base: Avoid fall-through warnings

2019-05-22 Thread Boris Brezillon
On Wed, 22 May 2019 13:04:46 -0500 "Gustavo A. R. Silva" wrote: > NOTICE THAT: > > "...we don't know whether we need fallthroughs or breaks there and this > is just a change to avoid having new warnings when switching to > -Wimplicit-fallthrough but this change might be entirely wrong."[1] > >

[PATCH] lib/sort: Add the sort_r() variant

2019-05-22 Thread Boris Brezillon
Some users might need extra context to compare 2 elements. This patch adds the sort_r() which is similar to the qsort_r() variant of qsort(). Signed-off-by: Boris Brezillon --- Hello, A few more details about this patch. Even though I post it as a standalone patch, I do intend to use it in a

Re: [PATCH] media: vimc: fix component match compare

2019-05-21 Thread Boris Brezillon
On Tue, 21 May 2019 15:39:00 -0300 Ezequiel Garcia wrote: > On Tue, 2019-05-21 at 14:55 +0200, Boris Brezillon wrote: > > On Fri, 17 May 2019 14:20:11 -0300 > > Helen Koike wrote: > > > > > If the system has other devices being registered in the componen

Re: [PATCH] media: vimc: fix component match compare

2019-05-21 Thread Boris Brezillon
evice it self. vimc-core is the one who creates them, we know in > advance exactly which object to expect in the match. > > Fixes: 4a29b7090749 ("[media] vimc: Subdevices as modules") > Signed-off-by: Helen Koike Reviewed-by: Boris Brezillon Tested-by: Boris Brezillon &

Re: [PATCH] media: vimc: fix component match compare

2019-05-21 Thread Boris Brezillon
On Fri, 17 May 2019 14:20:11 -0300 Helen Koike wrote: > If the system has other devices being registered in the component > framework, the compare function will be called with a device that > doesn't belong to vimc. > This device is not necessarily a platform_device, nor have a > platform_data (w

[GIT PULL] i3c: Changes for 5.2

2019-05-05 Thread Boris Brezillon
Hello Linus, Here is the I3C PR for 5.2. Regards, Boris The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b: Linux 5.1-rc1 (2019-03-17 14:22:26 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/i3c/linux.git tags/i3c/for-

Re: [PATCH 4/5] dt-binding: mtd: onenand/samsung: Add device tree support

2019-05-02 Thread Boris Brezillon
On Thu, 2 May 2019 15:58:24 +0900 Tomasz Figa wrote: > 2019年5月2日(木) 15:55 Boris Brezillon : > > > > On Thu, 2 May 2019 15:42:59 +0900 > > Tomasz Figa wrote: > > > > > 2019年5月2日(木) 15:36 Boris Brezillon : > > > > > > > >

Re: [PATCH 4/5] dt-binding: mtd: onenand/samsung: Add device tree support

2019-05-01 Thread Boris Brezillon
On Thu, 2 May 2019 15:42:59 +0900 Tomasz Figa wrote: > 2019年5月2日(木) 15:36 Boris Brezillon : > > > > Hi Tomasz, > > > > On Thu, 2 May 2019 15:23:33 +0900 > > Tomasz Figa wrote: > > > > > 2019年5月2日(木) 10:54 Rob Herring : > > > > &g

Re: [PATCH 4/5] dt-binding: mtd: onenand/samsung: Add device tree support

2019-05-01 Thread Boris Brezillon
Hi Tomasz, On Thu, 2 May 2019 15:23:33 +0900 Tomasz Figa wrote: > 2019年5月2日(木) 10:54 Rob Herring : > > > > On Fri, Apr 26, 2019 at 06:42:23PM +0200, Paweł Chmiel wrote: > > > From: Tomasz Figa > > > > > > This patch adds dt-bindings for Samsung OneNAND driver. > > > > > > Signed-off-by: Tomas

Re: [PATCH 1/3] remap: Add I3C bus support

2019-04-23 Thread Boris Brezillon
On Tue, 23 Apr 2019 14:58:06 + Vitor Soares wrote: > Hi Mark, > > From: Mark Brown > Date: Tue, Apr 16, 2019 at 16:39:48 > > > On Mon, Apr 15, 2019 at 09:19:39PM +0200, Vitor Soares wrote: > > > > > +++ b/drivers/base/regmap/regmap-i3c.c > > > @@ -0,0 +1,62 @@ > > > +// SPDX-License-Ide

Re: [PATCH 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-04-22 Thread Boris Brezillon
On Mon, 22 Apr 2019 17:54:29 + Vitor Soares wrote: > > > > > > > > > > > > > { > > > > > > > i3cbus->mode = mode; > > > > > > > > > > > > > > - if (!i3cbus->scl_rate.i3c) > > > > > > > - i3cbus->scl_rate.i3c = I3C_BUS_TYP_I3C_SCL_RATE; > > > > > > > - > > > > > > > - if (!

Re: [PATCH 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-04-22 Thread Boris Brezillon
On Mon, 22 Apr 2019 15:54:33 + Vitor Soares wrote: > > > > > > > > > { > > > > > i3cbus->mode = mode; > > > > > > > > > > - if (!i3cbus->scl_rate.i3c) > > > > > - i3cbus->scl_rate.i3c = I3C_BUS_TYP_I3C_SCL_RATE; > > > > > - > > > > > - if (!i3cbus->scl_rate.

[GIT PULL] i3c: Fixes for 5.1-rc6

2019-04-20 Thread Boris Brezillon
designware driver - Fix I3C entry in MAINTAINERS Boris Brezillon (1): MAINTAINERS: Fix the I3C entry Vitor Soares (2): i3c: Fix the verification of random PID i3c: dw: Fix dw_i3c_master_disable controller by using

Re: [PATCH] mtd: rawnand: Add Macronix NAND read retry and randomizer support

2019-04-17 Thread Boris Brezillon
On Wed, 17 Apr 2019 10:46:57 +0800 masonccy...@mxic.com.tw wrote: > Hi Boris, > > > > > > > > > > Subject > > > > > > > > > > > > > > > > Re: [PATCH] mtd: rawnand: Add Macronix NAND read retry and > > > > > randomizer > > > > > > > support > > > > > > > > > > > > > > > > On Tue, 9 A

Re: [PATCH 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-04-16 Thread Boris Brezillon
On Tue, 16 Apr 2019 14:24:57 + Vitor Soares wrote: > Hi Boris, > > From: Boris Brezillon > Date: Tue, Apr 16, 2019 at 06:50:41 > > > On Mon, 15 Apr 2019 20:46:41 +0200 > > Vitor Soares wrote: > > > > > Currently in case of mixed slow bus topo

Re: [PATCH 3/3] iio: imu: st_lsm6dsx: Add i3c basic support

2019-04-16 Thread Boris Brezillon
On Tue, 16 Apr 2019 09:58:33 +0200 Lorenzo Bianconi wrote: > > > > On Mon, 15 Apr 2019 21:19:41 +0200 > > Vitor Soares wrote: > > > > > For today the st_lsm6dsx driver support lsm6dso sensor only in > > > spi and i2c mode. > > > > > > The lsm6dso is also i3c capable so lets give i3c support to

Re: [PATCH 0/3] Add ST lsm6dso i3c suppport

2019-04-15 Thread Boris Brezillon
Hi Vitor, On Mon, 15 Apr 2019 21:19:38 +0200 Vitor Soares wrote: I like the very detailed description in your cover letter :P. Anyway, glad to see I3C support added to regmap. Also happy to have a new driver for an I3C device. Thanks for working on that. Boris > Vitor Soares (3): > remap: A

Re: [PATCH 3/3] iio: imu: st_lsm6dsx: Add i3c basic support

2019-04-15 Thread Boris Brezillon
On Mon, 15 Apr 2019 21:19:41 +0200 Vitor Soares wrote: > For today the st_lsm6dsx driver support lsm6dso sensor only in > spi and i2c mode. > > The lsm6dso is also i3c capable so lets give i3c support to it. > > Signed-off-by: Vitor Soares > --- > drivers/iio/imu/st_lsm6dsx/Kconfig |

Re: [PATCH 2/3] i3c: Add i3c_get_device_id helper

2019-04-15 Thread Boris Brezillon
On Mon, 15 Apr 2019 21:19:40 +0200 Vitor Soares wrote: > This helper return the i3c_device_id structure in order the client > have access to the driver data. > > Signed-off-by: Vitor Soares > --- > drivers/i3c/device.c | 8 > include/linux/i3c/device.h | 1 + > 2 files changed,

Re: [PATCH 1/3] remap: Add I3C bus support

2019-04-15 Thread Boris Brezillon
Typo in the subject: s/remap/regmap/ On Mon, 15 Apr 2019 21:19:39 +0200 Vitor Soares wrote: > Add basic support for I3C bus. > This is a simple implementation that only give support > for Read and Write commands. > > Signed-off-by: Vitor Soares > --- > drivers/base/regmap/Kconfig | 6 ++

Re: [PATCH 3/3] i3c: dw: Add limited bus mode support

2019-04-15 Thread Boris Brezillon
+Przemek On Mon, 15 Apr 2019 20:46:43 +0200 Vitor Soares wrote: > This patch add limited bus mode support for DesignWare i3c master > > Signed-off-by: Vitor Soares > Cc: Boris Brezillon > Cc: > --- > drivers/i3c/master/dw-i3c-master.c | 1 + > 1 file changed, 1 inse

Re: [PATCH 2/3] i3c: add mixed limited bus mode

2019-04-15 Thread Boris Brezillon
gned-off-by: Vitor Soares > Cc: Boris Brezillon > Cc: > --- > drivers/i3c/master.c | 5 + > include/linux/i3c/master.h | 5 + > 2 files changed, 10 insertions(+) > > diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c > index 1c4a86a..46d3774 100644

Re: [PATCH 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-04-15 Thread Boris Brezillon
^ with the max I2C rate. > > Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure") > Signed-off-by: Vitor Soares > Cc: Boris Brezillon > Cc: > Cc: > --- > drivers/i3c/master.c | 39 +-- > 1 f

Re: [PATCH 1/2] mtd: nandsim: Embed struct nand_chip in struct nandsim

2019-04-14 Thread Boris Brezillon
> Signed-off-by: Richard Weinberger Reviewed-by: Boris Brezillon > --- > drivers/mtd/nand/raw/nandsim.c | 49 +- > 1 file changed, 24 insertions(+), 25 deletions(-) > > diff --git a/drivers/mtd/nand/raw/nandsim.c b/drivers/mtd/nand/raw/nandsi

Re: [PATCH 2/2] mtd: nandsim: switch to exec_op interface

2019-04-14 Thread Boris Brezillon
s.ce is always 1, since there's no point executing a NAND operation if the CS pin is not asserted. BTW, in case you ever consider supporting multi-CS chips, the CS line to select is passed through op->cs (you should not use nand->cur_cs). The rest of the patch looks good. Once this tiny

Re: [PATCH] mtd: nand: Fix build error while CONFIG_MTD_NAND_ECC_SW_BCH is set to module

2019-04-12 Thread Boris Brezillon
On Fri, 12 Apr 2019 22:28:57 +0800 YueHaibing wrote: > On 2019/4/11 1:03, Boris Brezillon wrote: > > On Wed, 10 Apr 2019 18:18:43 +0200 > > Miquel Raynal wrote: > > > >> Hi YueHaibing, > >> > >> YueHaibing wrote on Wed, 10 Apr 2019 23:03:24 &g

Re: [PATCH] mtd: rawnand: Add Macronix NAND read retry and randomizer support

2019-04-11 Thread Boris Brezillon
On Thu, 11 Apr 2019 17:24:09 +0800 masonccy...@mxic.com.tw wrote: > Hi Boris, > > > > > > > > Subject > > > > > > > > > > > > Re: [PATCH] mtd: rawnand: Add Macronix NAND read retry and > > > randomizer > > > > > support > > > > > > > > > > > > On Tue, 9 Apr 2019 17:35:39 +0800 > > >

Re: [PATCH] mtd: rawnand: Add Macronix NAND read retry and randomizer support

2019-04-10 Thread Boris Brezillon
On Thu, 11 Apr 2019 12:23:11 +0800 masonccy...@mxic.com.tw wrote: > Hi Boris, > > > > > > Subject > > > > > > > > Re: [PATCH] mtd: rawnand: Add Macronix NAND read retry and > randomizer > > > support > > > > > > > > On Tue, 9 Apr 2019 17:35:39 +0800 > > > > masonccy...@mxic.com.tw wrot

Re: [PATCH] mtd: nand: Fix build error while CONFIG_MTD_NAND_ECC_SW_BCH is set to module

2019-04-10 Thread Boris Brezillon
On Wed, 10 Apr 2019 18:18:43 +0200 Miquel Raynal wrote: > Hi YueHaibing, > > YueHaibing wrote on Wed, 10 Apr 2019 23:03:24 > +0800: > > > On 2019/4/10 22:29, Boris Brezillon wrote: > > > On Wed, 10 Apr 2019 22:22:16 +0800 > > > YueHaibing wrote: >

Re: [PATCH] mtd: nand: Fix build error while CONFIG_MTD_NAND_ECC_SW_BCH is set to module

2019-04-10 Thread Boris Brezillon
On Wed, 10 Apr 2019 22:22:16 +0800 YueHaibing wrote: > On 2019/4/10 21:58, Boris Brezillon wrote: > > On Wed, 10 Apr 2019 15:39:28 +0200 > > Boris Brezillon wrote: > > > >> On Wed, 10 Apr 2019 21:07:47 +0800 > >> Yue Haibing wrote: > >> &

Re: [PATCH] mtd: nand: Fix build error while CONFIG_MTD_NAND_ECC_SW_BCH is set to module

2019-04-10 Thread Boris Brezillon
On Wed, 10 Apr 2019 15:58:56 +0200 Boris Brezillon wrote: > On Wed, 10 Apr 2019 15:39:28 +0200 > Boris Brezillon wrote: > > > On Wed, 10 Apr 2019 21:07:47 +0800 > > Yue Haibing wrote: > > > > > From: YueHaibing > > > > > > Fix gcc bui

Re: [PATCH] mtd: nand: Fix build error while CONFIG_MTD_NAND_ECC_SW_BCH is set to module

2019-04-10 Thread Boris Brezillon
On Wed, 10 Apr 2019 15:39:28 +0200 Boris Brezillon wrote: > On Wed, 10 Apr 2019 21:07:47 +0800 > Yue Haibing wrote: > > > From: YueHaibing > > > > Fix gcc build error while CONFIG_MTD_NAND_ECC_SW_BCH > > is set to module: > > > > drivers/mtd/na

<    1   2   3   4   5   6   7   8   9   10   >