Re: [RESEND PATCH 0/3] Add MEMREMAP_WC to fix dma_init_coherent_memory

2016-01-29 Thread Brian Starkey
Hi, Are there any comments on these? Without them dma-coherent can't be used on arm64 so it would be good to get them merged if there are no objections. I can resend with Michal's ack for patch 2 if needed. Thanks, Brian On Tue, Jan 05, 2016 at 04:41:25PM +0000, Brian Starkey

[PATCH] genirq: fix trigger flags check for shared irqs

2016-01-26 Thread Brian Starkey
Signed-off-by: Brian Starkey Reviewed-by: Marc Zyngier --- kernel/irq/manage.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index a79d267..032c8fa 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@

[RESEND PATCH 0/3] Add MEMREMAP_WC to fix dma_init_coherent_memory

2016-01-05 Thread Brian Starkey
/pipermail/linux-arm-kernel/2015-December/390857.html [2] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/397163.html Brian Starkey (3): memremap: add MEMREMAP_WC flag drivers: dma-coherent: use MEMREMAP_WC for DMA_MEMORY_MAP drivers: dma-coherent: use memset_io for

[RESEND PATCH 3/3] drivers: dma-coherent: use memset_io for DMA_MEMORY_IO mappings

2016-01-05 Thread Brian Starkey
-by: Brian Starkey Reviewed-by: Catalin Marinas --- drivers/base/dma-coherent.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/base/dma-coherent.c b/drivers/base/dma-coherent.c index f98359a..4e4ad30 100644 --- a/drivers/base/dma-coherent.c +++ b/drivers/base/dma

[RESEND PATCH 2/3] drivers: dma-coherent: use MEMREMAP_WC for DMA_MEMORY_MAP

2016-01-05 Thread Brian Starkey
When the DMA_MEMORY_MAP flag is used, memory which can be accessed directly should be returned, so use memremap(..., MEMREMAP_WC) to provide a writecombine mapping. Signed-off-by: Brian Starkey Reviewed-by: Catalin Marinas --- drivers/base/dma-coherent.c | 20 1 file

[RESEND PATCH 1/3] memremap: add MEMREMAP_WC flag

2016-01-05 Thread Brian Starkey
Add a flag to memremap() for writecombine mappings. Mappings satisfied by this flag will not be cached, however writes may be delayed or combined into more efficient bursts. This is most suitable for buffers written sequentially by the CPU for use by other DMA devices. Signed-off-by: Brian

Re: [PATCH v3 0/7] dma-buf: Performance improvements for system heap & a system-uncached implementation

2020-10-08 Thread Brian Starkey
Hi John, On Sat, Oct 03, 2020 at 04:02:50AM +, John Stultz wrote: > Hey All, ... > > I did add to this series a reworked version of my uncached > system heap implementation I was submitting a few weeks back. > Since it duplicated a lot of the now reworked system heap code, > I realized it w

Re: [PATCH v3 7/7] dma-buf: system_heap: Add a system-uncached heap re-using the system heap

2020-10-08 Thread Brian Starkey
+/1399519 > - Visibly improves performance over the system heap > * AOSP Codec2 (possibly, needs more review): > - > https://android-review.googlesource.com/c/platform/frameworks/av/+/1360640/17/media/codec2/vndk/C2DmaBufAllocator.cpp#325 > > Cc: Sumit Semwal > Cc: Liam Mark >

Re: [PATCH v2] drm/fourcc: Add AXBXGXRX106106106106 format

2020-10-09 Thread Brian Starkey
formatting of the table as a whole. If Joe feels strongly about having it split, I don't think that should hurt grep-ability much for the common cases (grep for format name, or grep for format parameters). So either way you can add: Reviewed-by: Brian Starkey Thanks! -Brian >

Re: [PATCH] kselftests: dmabuf-heaps: Fix confused return value on expected error testing

2020-05-13 Thread Brian Starkey
Khan > Cc: Sumit Semwal > Cc: Benjamin Gaignard > Cc: Brian Starkey > Cc: Laura Abbott > Cc: "Andrew F. Davis" > Cc: linux-kselft...@vger.kernel.org > Signed-off-by: John Stultz > --- > tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c | 1 + > 1 fi

Re: [RFC][PATCH 3/4] dma-buf: cma_heap: Extend logic to export CMA regions tagged with "linux,cma-heap"

2020-05-13 Thread Brian Starkey
Hi Rob, On Tue, May 12, 2020 at 11:37:14AM -0500, Rob Herring wrote: > On Mon, May 04, 2020 at 10:06:28AM +0100, Brian Starkey wrote: > > On Fri, May 01, 2020 at 12:01:40PM -0700, John Stultz wrote: > > > On Fri, May 1, 2020 at 4:08 AM Robin Murphy wrote: > > > >

Re: [RFC][PATCH 3/4] dma-buf: cma_heap: Extend logic to export CMA regions tagged with "linux,cma-heap"

2020-05-15 Thread Brian Starkey
On Thu, May 14, 2020 at 09:52:35AM -0500, Rob Herring wrote: > On Wed, May 13, 2020 at 5:44 AM Brian Starkey wrote: > > > > Hi Rob, > > > > On Tue, May 12, 2020 at 11:37:14AM -0500, Rob Herring wrote: > > > On Mon, May 04, 2020 at 10:06:28AM +0100, Brian S

Re: [PATCH 1/2] drm: drm_fourcc: add NV20 YUV format

2020-06-08 Thread Brian Starkey
, .hsub = 2, > + .vsub = 1, .is_yuv = true }, That looks how I would expect, so: Reviewed-by: Brian Starkey Cheers, -Brian > { .format = DRM_FORMAT_Q410,.depth = 0, > .num_planes = 3, .char_per_block = { 2, 2, 2 }, >

Re: [RFC][PATCH] dma-heap: Add proper kref handling on dma-buf heaps

2020-08-13 Thread Brian Starkey
ew F. Davis > Cc: Benjamin Gaignard > Cc: Liam Mark > Cc: Laura Abbott > Cc: Brian Starkey > Cc: linux-me...@vger.kernel.org > Cc: dri-de...@lists.freedesktop.org > Signed-off-by: John Stultz > --- > drivers/dma-buf/dma-heap.c | 31 +++ &

Re: [PATCH] dma-buf: heaps: Remove Unneeded variable "ret" in dma_heap_dma_buf_begin_cpu_access()

2020-05-06 Thread Brian Starkey
Hi Jason, On Wed, May 06, 2020 at 02:18:51PM +0800, Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/dma-buf/heaps/heap-helpers.c:203:5-8: Unneeded variable: "ret". > Return "0" on line 216 > > Signed-off-by: Jason Yan LGTM. Revie

Re: [RFC PATCH v3 0/6] Introduce writeback connectors

2017-04-18 Thread Brian Starkey
Hi Boris, On Fri, Apr 14, 2017 at 11:35:17AM +0200, Boris Brezillon wrote: Hi Brian, On Fri, 25 Nov 2016 16:48:58 + Brian Starkey wrote: Hi, This is v3 of my series introducing a new connector type: DRM_MODE_CONNECTOR_WRITEBACK See v1 and v2 here: [1] [2] Writeback connectors are

Re: [PATCH 1/6] drm: Add writeback connector type

2017-04-18 Thread Brian Starkey
Hi Boris, On Fri, Apr 14, 2017 at 12:08:23PM +0200, Boris Brezillon wrote: On Fri, 25 Nov 2016 16:48:59 + Brian Starkey wrote: diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index b5c6a8e..6bbd93f 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b

Re: [PATCH 2/6] drm: writeback: Add out-fences for writeback connectors

2017-04-18 Thread Brian Starkey
On Fri, Apr 14, 2017 at 12:11:14PM +0200, Boris Brezillon wrote: On Fri, 25 Nov 2016 16:49:00 + Brian Starkey wrote: Add the OUT_FENCE_PTR property to writeback connectors, to enable userspace to get a fence which will signal once the writeback is complete. It is not allowed to request an

Re: [PATCH 6/6] drm: mali-dp: Add writeback connector

2017-04-18 Thread Brian Starkey
On Fri, Apr 14, 2017 at 11:47:00AM +0200, Boris Brezillon wrote: On Fri, 25 Nov 2016 16:49:04 + Brian Starkey wrote: +static int +malidp_mw_encoder_atomic_check(struct drm_encoder *encoder, + struct drm_crtc_state *crtc_state

Re: [PATCH 1/6] drm: Add writeback connector type

2017-04-19 Thread Brian Starkey
On Tue, Apr 18, 2017 at 09:57:17PM +0200, Boris Brezillon wrote: Hi Brian, On Tue, 18 Apr 2017 18:34:43 +0100 Brian Starkey wrote: >> @@ -214,6 +214,19 @@ struct drm_connector_state { >>struct drm_encoder *best_encoder; >> >>struct

Re: [PATCH 1/6] drm: Add writeback connector type

2017-04-19 Thread Brian Starkey
On Wed, Apr 19, 2017 at 01:34:34PM +0200, Boris Brezillon wrote: On Wed, 19 Apr 2017 10:51:23 +0100 Brian Starkey wrote: [snip] Could you expand a bit on how you think planes fit better? Just had the impression that the writeback feature was conceptually closer to a plane object (which is

Re: [PATCH v3 00/15] V4L2 Explicit Synchronization support

2017-10-02 Thread Brian Starkey
Hi Gustavo, On Thu, Sep 07, 2017 at 03:42:11PM -0300, Gustavo Padovan wrote: From: Gustavo Padovan Hi, Refer to the documentation on the first patch for the details. The previous iteration is here: https://www.mail-archive.com/linux-media@vger.kernel.org/msg118077.html The 2nd patch propose

Re: [PATCH v3 02/15] [media] vb2: add explicit fence user API

2017-10-02 Thread Brian Starkey
Hi, On Thu, Sep 07, 2017 at 03:42:13PM -0300, Gustavo Padovan wrote: From: Gustavo Padovan Turn the reserved2 field into fence_fd that we will use to send an in-fence to the kernel and return an out-fence from the kernel to userspace. Two new flags were added, V4L2_BUF_FLAG_IN_FENCE, that sho

Re: [PATCH v3 04/15] [media] vb2: add in-fence support to QBUF

2017-10-02 Thread Brian Starkey
Hi, On Thu, Sep 07, 2017 at 03:42:15PM -0300, Gustavo Padovan wrote: From: Gustavo Padovan Receive in-fence from userspace and add support for waiting on them before queueing the buffer to the driver. Buffers are only queued to the driver once they are ready. A buffer is ready when its in-fenc

Re: [PATCH v3 10/15] [media] vb2: add 'ordered' property to queues

2017-10-02 Thread Brian Starkey
Hi, On Thu, Sep 07, 2017 at 03:42:21PM -0300, Gustavo Padovan wrote: From: Gustavo Padovan For explicit synchronization (and soon for HAL3/Request API) we need the v4l2-driver to guarantee the ordering in which the buffers were queued by userspace. This is already true for many drivers, but we

Re: [PATCH v3 00/15] V4L2 Explicit Synchronization support

2017-10-12 Thread Brian Starkey
Hi, On Wed, Oct 04, 2017 at 05:08:55PM -0300, Gustavo Padovan wrote: Hi Brian, On Mon, 2017-10-02 at 14:41 +0100, Brian Starkey wrote: Hi Gustavo, On Thu, Sep 07, 2017 at 03:42:11PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Hi, > > Refer to the documentati

Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-20 Thread Brian Starkey
On Fri, Nov 17, 2017 at 11:19:05AM -0200, Mauro Carvalho Chehab wrote: Em Fri, 17 Nov 2017 11:08:01 -0200 Gustavo Padovan escreveu: 2017-11-17 Mauro Carvalho Chehab : > Em Fri, 17 Nov 2017 15:49:23 +0900 > Alexandre Courbot escreveu: > > > > @@ -178,6 +179,12 @@ static int vb2_queue_or_prepa

Re: [RFC PATCH 00/11] Introduce writeback connectors

2016-10-14 Thread Brian Starkey
Hi Archit, On Fri, Oct 14, 2016 at 04:20:14PM +0530, Archit Taneja wrote: Hi Brian, On 10/11/2016 08:23 PM, Brian Starkey wrote: Hi, This RFC series introduces a new connector type: DRM_MODE_CONNECTOR_WRITEBACK It is a follow-on from a previous discussion: [1] Writeback connectors are used

Re: [PATCHv2 1/4] staging: android: ion: Drop heap type masks

2016-09-05 Thread Brian Starkey
Hi, On Fri, Sep 02, 2016 at 12:36:25PM -0700, Laura Abbott wrote: On 09/02/2016 06:41 AM, Brian Starkey wrote: Hi Laura, On Thu, Sep 01, 2016 at 03:40:41PM -0700, Laura Abbott wrote: There is no advantage to having heap types be a mask. The ion client has long since dropped the mask. Drop

[PATCH] drm/atomic: mode_set encoders when routing changes

2016-09-06 Thread Brian Starkey
s CRTC and encoder have not changed before skipping its encoder's mode_set. Signed-off-by: Brian Starkey --- drivers/gpu/drm/drm_atomic_helper.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.

<    1   2   3