On Thu, Aug 27, 2020 at 12:56 PM wrote:
> Are you Ok with the License I put on it, GPLv2 or BDS-2 ?
Yes, both GPLv2 and BSD-2 (my personal favourite) are fine.
iled cmpxchg;
does the atomic_fetch_add following that not have acquire semantics?
Cameron
l be blindly overwritten at
that point.
Cameron
On Fri, Aug 28, 2020 at 10:29 PM Cameron wrote:
> I thought about this some more, and actually, it should be safe.
Although I should note that it's important that the flags/refcount are
not overwritten
even after the node is taken off the freelist.
Cameron
s and that point, there are no memory effects
that need to be synchronized, and so it could be safely replaced with
a relaxed operation.
> Cosmetic, but why not atomic_fetch_dec() ?
This is just one of my idiosyncrasies. I prefer exclusively using
atomic add, I find it easier to read. Feel free t
From: Stephen M. Cameron [EMAIL PROTECTED]
Signed-off-by: Stephen M. Cameron [EMAIL PROTECTED]
Document how to detect drive failures for cciss
---
Documentation/cciss.txt | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff -puN Documentation/cciss.txt
/2007 11:22 AM
To: Miller, Mike (OS Dev)
Cc: Hisashi Hifumi; [EMAIL PROTECTED]; [EMAIL PROTECTED];
linux-kernel@vger.kernel.org; [EMAIL PROTECTED]; Cameron, Steve
Subject: RE: [PATCH] cciss: Fix warnings during compilation under
32bitenvironment
On Thu, 2007-04-19 at 16:12 +, Miller, Mike (OS
Hannes Reinecke wrote:
this patch adds the SG_IO ioctl to the cciss driver.
As the driver is capable of sending SCSI CDBs to the controller there is
no reason why we shouldn't exploit it.
This way we get to use all the nice sg_utils for the cciss driver.
And a persistent device name for
--- Christoph Hellwig [EMAIL PROTECTED] wrote:
Also is there a reason you don't want to pass down the various
other ioctls scsi_cmd_ioctl can handle to it?
Didn't think about it, SG_IO is the one people were
clamoring for.
SG_GET_VERSION_NUM:
easily doable.
SCSI_IOCTL_GET_IDLUN:
Hmm, cciss
I am running the latest FC5-i686-smp kernel, 2.6.20, on a machine with
8Gb of RAM, and 2 Xeon processors. The system has a 750Mb ramdisk,
and one process allocating and deallocating memory that is also
writing lots of files to the ramdisk. The process also reads and
writes from the network.
Andrew Morton wrote:
All of ZONE_NORMAL got used by ramdisk, and networking wants to
allocate a page from ZONE_NORMAL. An oom-killing is the correct
response, although probably not effective.
ramdisk is a nasty thing - cannot you use ramfs or tmpfs?
Sure enough, changing the ramdisk to a
Message-
From: James Bottomley [mailto:[EMAIL PROTECTED]
Sent: Thu 4/12/2007 5:07 PM
To: Mike Miller (OS Dev)
Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED];
Cameron, Steve
Subject: Re: [PATCH 1/1] cciss: kconfig patch to make cciss dependent onscsi
for SG_IO ioctl
Hmm, now that I look again, those ioctls it's complaining
about are ones for which we just return ENOTTY, so I guess
we don't really need them listed explicitly, and if they
weren't, the Kconfig patch would be unnecessary.
-- steve
-Original Message-
From: Cameron, Steve
Sent: Fri 4
Make cciss unconditionally include scsi/scsi.h
From: Stephen M. Cameron [EMAIL PROTECTED]
Signed-off-by: Stephen M. Cameron [EMAIL PROTECTED]
---
drivers/block/cciss.c |1 +
drivers/block/cciss_scsi.c |1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/block
Andrew Morton [mailto:[EMAIL PROTECTED] wrote:
On Fri, 13 Apr 2007 09:23:12 -0500
Stephen Cameron [EMAIL PROTECTED] wrote:
Make cciss unconditionally include scsi/scsi.h
For what reason?
Because the use of:
case SCSI_IOCTL_GET_IDLUN:
case SCSI_IOCTL_GET_BUS_NUMBER
Is there a reason why I would not want to run a production system with
CONFIG_PROFILING enabled?
I am wondering if there are any reasons associated with performance,
stability or security that I should worry about when CONFIG_PROFILING is
enabled.
Thanks,
Cam
-
To unsubscribe from this
should be moved into the SPI framework. It wouldn't be polite if
such LCD drivers could only work on Blackfin boards. :)
I am not sure whether this LCD needs cs_chg_udelay on other boards.
It is found by Cameron Barfield. Maybe it is some timing requirement for
specific hardware.
-Bryan Wu
On 10/22/2012 08:57 AM, Kirill A. Shutemov wrote:
From: Kirill A. Shutemov kirill.shute...@linux.intel.com
It's non-sense to use tristate for the option, it's bool.
Good point.
Applied to fixes-togreg branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
Thanks,
Jonathan
On 11/02/2012 07:28 AM, Kumar Amit Mehta wrote:
remove unnecessary semicolon from the macro definition
Signed-off-by: Kumar Amit Mehta gmate.a...@gmail.com
Thanks, added to togreg branch of iio.git
---
drivers/staging/iio/adc/ad7280a.c |2 +-
1 file changed, 1 insertion(+), 1
On 11/01/2012 03:24 PM, Pantelis Antoniou wrote:
The MFD parent device now uses a regmap, instead of direct
memory access. Use the same method in the sub devices to avoid
nasty surprises.
Please not that this driver can't really deal with the case of the regmap
call failing in anyway. So
On 10/21/2012 11:52 AM, Julia Lawall wrote:
From: Julia Lawall julia.law...@lip6.fr
The function __iio_add_event_config_attrs is only called once, by the
function iio_device_register_eventset. If the call fails,
iio_device_register_eventset calls __iio_remove_event_config_attrs. There
is
On 10/25/2012 12:39 AM, Bryan Freed wrote:
The driver leaves the device in power-down state anyway,
so there is nothing to do on suspend.
On resume, we just have to make sure the range and ADC
values are updated in the device since it may have been
powered down in suspend.
Signed-off-by:
On 10/27/2012 03:48 PM, Axel Lin wrote:
Use __devexit rather than __devinit annotation for remove().
Also adds __devexit_p around remove callback.
Signed-off-by: Axel Lin axel@ingics.com
Added to fixes-togreg branch of iio.git
oops on this one. Should have picked that up in review.
On 10/27/2012 04:03 PM, Axel Lin wrote:
Return -ENOMEM instead of 0 if kmemdup fails.
Signed-off-by: Axel Lin axel@ingics.com
Added to fixes-togreg branch of iio.git
Thanks
---
drivers/iio/accel/hid-sensor-accel-3d.c |6 +++---
drivers/iio/gyro/hid-sensor-gyro-3d.c |
this all looks fine to me.
Acked-by: Jonathan Cameron ji...@kernel.org
But there is one issue, but this is not necessarily related to this patch,
more inline.
---
drivers/power/lp8788-charger.c | 26 +++---
1 file changed, 7 insertions(+), 19 deletions(-)
diff --git
-by: Jonathan Cameron ji...@kernel.org
I'll take this patch as soon as I know the mfd part
has been accepted (just in case any interfaces change!)
---
Changes in v2:
Addressed review comments from Matthias Kaehlcke
Changes in v3:
Addressed review comments from Jonathan Cameron
Acked-by: Jonathan Cameron ji...@kernel.org
As there is a clear dependence on the mfd elements here this should
probably go though Samuel's tree once people are happy with the other elements.
---
drivers/iio/adc/Kconfig |7 ++
drivers/iio/adc/Makefile |1 +
drivers/iio
().
Signed-off-by: Milo(Woogyom) Kim milo@ti.com
Acked-by: Jonathan Cameron ji...@kernel.org
---
drivers/power/lp8788-charger.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/power/lp8788-charger.c b/drivers/power/lp8788-charger.c
index e852d12..614e6aa
On 10/18/2012 07:11 AM, Kim, Milo wrote:
LP8788 IIO ADC driver and platform data have specific naming convention
for ADC channels. That is using prefix 'lp8788_'.
To keep this rule, ADC channel names are changed.
It's a little unusual to name the consumer side of the map so specifically.
On 09/29/2012 04:03 PM, Arnd Bergmann wrote:
On Saturday 29 September 2012, Jonathan Cameron wrote:
On 09/28/2012 10:36 PM, Arnd Bergmann wrote:
The driver has not been building for some time after the
irq_to_gpio function has been removed from the kernel.
The only board in the upstream
On 13/11/12 05:51, Stephen Rothwell wrote:
Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
In file included from drivers/power/lp8788-charger.c:15:0:
include/linux/iio/consumer.h:76:21: error: unknown type name 'u8'
This fixes a problem with the way cciss was filling out the errors
field of the request structure upon completion of requests.
Previously, it just put a 1 or a 0 in there and used the negation
of this as the uptodate parameter to one of the functions in the
block layer, being a block
Any feedback on my patch?
Anybody know what the msg_byte in include/scsi/scsi.h
is for?
scsi.h says:
* msg_byte= return status from host adapter itself.
So, it's ok to use the msg_byte for device specific error codes?
-- steve
-
To unsubscribe from this list: send the line
in the
latest kernel and i haven't had enough time to work out how to specify
it.
--
Cameron Harris
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
stuck in it. umounting the cifs
filesystem didn't even wake up the process, I had to reboot (which
didn't work right because something was stuck with a file open).
Anyone got any ideas on how this could be fixed?
Thanks
--
Cameron Harris
-
To unsubscribe from this list: send the line unsubscribe
again, even when the filesystem is umounted.
--
Cameron Harris
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On 04/18/2013 04:38 PM, Alexandre Belloni wrote:
The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable
gain and sampling rates.
Signed-off-by: Alexandre Belloni alexandre.bell...@free-electrons.com
Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com
A few bits and
On 04/08/2013 06:54 PM, Luck, Tony wrote:
I think it is a good idea to switch directly to strtobool. But anyway, if you
don't want to respin the patch it is fine as it is.
I didn't know that strtobool() existed ... but now that I do I agree that it
would
be better to use it here. But ...
On 03/27/2013 06:46 PM, Doug Anderson wrote:
Hi,
On Wed, Mar 27, 2013 at 11:40 AM, Lars-Peter Clausen l...@metafoo.de wrote:
On 03/27/2013 07:35 PM, Naveen Krishna Ch wrote:
On 13 March 2013 13:39, Doug Anderson diand...@chromium.org wrote:
The exynos ADC won't work without a regulator
On 03/15/2013 06:09 PM, Doug Anderson wrote:
Naveen,
On Fri, Mar 15, 2013 at 9:23 AM, Naveen Krishna Chatradhi
ch.nav...@samsung.com wrote:
As the exynos_adc driver only supports device tree registration.
Making driver depend on CONFIG_OF solves possible errors during probe.
On 03/20/2013 03:52 PM, Guenter Roeck wrote:
So far, all instances of iio_hwmon set their hwmon name attribute
to iio_hwmon, which is not very descriptive. Set it to the device tree
node name if available, and only revert to iio_hwmon otherwise.
Signed-off-by: Guenter Roeck
Doug Anderson diand...@chromium.org wrote:
Hi,
On Wed, Mar 27, 2013 at 11:40 AM, Lars-Peter Clausen l...@metafoo.de
wrote:
On 03/27/2013 07:35 PM, Naveen Krishna Ch wrote:
On 13 March 2013 13:39, Doug Anderson diand...@chromium.org wrote:
The exynos ADC won't work without a regulator called
On 02/07/2013 05:09 PM, Guenter Roeck wrote:
Provide bindings and parse OF data during initialization.
Signed-off-by: Guenter Roeck li...@roeck-us.net
Applied to the togreg branch of iio.git with a small edit wrt
to removing the WIP line in the binding documenation.
I thought about putting
On 02/13/2013 09:20 AM, Jonathan Cameron wrote:
On 13/02/13 09:19, Lars-Peter Clausen wrote:
On 02/13/2013 07:47 AM, Christophe Leroy wrote:
This patch adds support for Analog Devices AD7923 ADC in the IIO Subsystem.
Signed-off-by: Patrick Vasseur patrick.vass...@c-s.fr
Signed-off
On 02/15/2013 01:35 PM, Naveen Krishna Ch wrote:
On 15 February 2013 18:56, Lars-Peter Clausen l...@metafoo.de wrote:
On 02/15/2013 02:17 PM, Naveen Krishna Ch wrote:
On 15 February 2013 18:43, Lars-Peter Clausen l...@metafoo.de wrote:
On 02/15/2013 07:56 AM, Naveen Krishna Chatradhi wrote:
On 07/02/13 17:09, Guenter Roeck wrote:
Provide bindings and parse OF data during initialization.
Signed-off-by: Guenter Roeck li...@roeck-us.net
Looks fine to me. Will give it a few more days to see what others
have to say.
Thanks Guenter
---
v5:
- Updated examples in bindings.
v4:
- Fixed
On 02/05/2013 02:07 PM, Grant Likely wrote:
On Sun, 27 Jan 2013 03:33:59 +, Mark Brown
broo...@opensource.wolfsonmicro.com wrote:
On Wed, Jan 09, 2013 at 06:31:09PM +0100, Lars-Peter Clausen wrote:
The second function spi_sync_transfer() takes a SPI device and an array of
spi_transfers.
On 02/06/2013 07:20 PM, Jonathan Cameron wrote:
On 02/05/2013 02:07 PM, Grant Likely wrote:
On Sun, 27 Jan 2013 03:33:59 +, Mark Brown
broo...@opensource.wolfsonmicro.com wrote:
On Wed, Jan 09, 2013 at 06:31:09PM +0100, Lars-Peter Clausen wrote:
The second function spi_sync_transfer
On 13/02/13 09:19, Lars-Peter Clausen wrote:
On 02/13/2013 07:47 AM, Christophe Leroy wrote:
This patch adds support for Analog Devices AD7923 ADC in the IIO Subsystem.
Signed-off-by: Patrick Vasseur patrick.vass...@c-s.fr
Signed-off-by: Christophe Leroy christophe.le...@c-s.fr
Looks good,
On 02/05/2013 02:07 PM, Grant Likely wrote:
On Sun, 27 Jan 2013 03:33:59 +, Mark Brown
broo...@opensource.wolfsonmicro.com wrote:
On Wed, Jan 09, 2013 at 06:31:09PM +0100, Lars-Peter Clausen wrote:
The second function spi_sync_transfer() takes a SPI device and an array of
spi_transfers.
On 01/23/2013 11:41 PM, Randy Dunlap wrote:
On 01/23/13 15:23, Herbert Xu wrote:
On Wed, Jan 23, 2013 at 03:10:01PM -0800, Randy Dunlap wrote:
On 01/22/13 22:43, Stephen Rothwell wrote:
Hi all,
Changes since 20130122:
on i386:
ERROR: crc32_le [drivers/mtd/ubi/ubi.ko] undefined!
ERROR:
On 01/24/2013 04:58 AM, Naveen Krishna Chatradhi wrote:
This patch adds driver for ADC IP found on EXYNOS5250 and EXYNOS5410
from Samsung. Also adds the Documentation for device tree bindings.
Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
Just a quick general comment on patch
On 01/17/2013 12:47 PM, Alexander Holler wrote:
Am 17.01.2013 02:49, schrieb Axel Lin:
Thanks, yes, I missed it the initialization of the spinlock.
Below is my ack.
Regards,
Alexander
Signed-off-by: Axel Lin axel@ingics.com
Acked-by: Alexander Holler hol...@ahsoftware.de
On 01/21/2013 09:14 PM, Peter Huewe wrote:
found with coccicheck
sizeof when applied to a pointer typed expression gives the size of
the pointer
The semantic patch that makes this output is available
in scripts/coccinelle/misc/noderef.cocci.
More information about semantic patching is
On 01/21/2013 10:09 AM, Thierry Reding wrote:
Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.
Signed-off-by: Thierry Reding thierry.red...@avionic-design.de
Cc: Jonathan Cameron ji...@cam.ac.uk
Cc
On 01/18/2013 11:02 PM, Getz, Robin wrote:
On Thu 17 Jan 2013 12:36, Lars-Peter Clausen pondered:
On 01/17/2013 06:11 PM, Alessandro Rubini wrote:
[...]
But yes, you are right. I'm working on another I/O subsystem. We are
gong to release zio-1.0 in a few days, because the thing is mature
Greg KH gre...@linuxfoundation.org wrote:
On Fri, Feb 15, 2013 at 04:48:33PM +0530, Priyaranjan Das wrote:
Hi Greg,
On Thu, Jan 31, 2013 at 11:09 AM, Priyaranjan Das
priyaranjan456...@gmail.com wrote:
Hi Greg,
On Tue, Jan 29, 2013 at 7:03 PM, Greg KH
gre...@linuxfoundation.org wrote:
Guenter Roeck li...@roeck-us.net wrote:
On Fri, Feb 08, 2013 at 08:30:48AM +, Jonathan Cameron wrote:
On 07/02/13 17:09, Guenter Roeck wrote:
Provide bindings and parse OF data during initialization.
Signed-off-by: Guenter Roeck li...@roeck-us.net
Looks fine to me. Will give it a few
Guenter Roeck li...@roeck-us.net wrote:
On Wed, Feb 20, 2013 at 11:38:22AM -0600, Rob Herring wrote:
On 02/07/2013 11:09 AM, Guenter Roeck wrote:
Provide bindings and parse OF data during initialization.
Signed-off-by: Guenter Roeck li...@roeck-us.net
---
v5:
- Updated examples in
On 02/20/2013 07:24 PM, Guenter Roeck wrote:
On Wed, Feb 20, 2013 at 06:51:08PM +, Jonathan Cameron wrote:
Guenter Roeck li...@roeck-us.net wrote:
On Wed, Feb 20, 2013 at 11:38:22AM -0600, Rob Herring wrote:
On 02/07/2013 11:09 AM, Guenter Roeck wrote:
Provide bindings and parse
On 02/21/2013 02:50 PM, Rob Herring wrote:
On 02/20/2013 01:24 PM, Guenter Roeck wrote:
On Wed, Feb 20, 2013 at 06:51:08PM +, Jonathan Cameron wrote:
Guenter Roeck li...@roeck-us.net wrote:
On Wed, Feb 20, 2013 at 11:38:22AM -0600, Rob Herring wrote:
On 02/07/2013 11:09 AM, Guenter
On Mon, Aug 29, 2005 at 05:10:34PM -0500, Matt Domsch wrote:
I've asked James Cameron, pptp project lead, to try a test to force
the server side to issue a CCP DOWN, to make sure the client-side
kernel ppp_generic module does the right thing and drops packets.
I'm still working on this; tried
My problems with ENOPROTOOPT were due to lack of coffee. They were
caused by ICMP protocol unreachable responses from the test server
because I'd taken away it's pppd. My mistake.
On Mon, Aug 29, 2005 at 05:10:34PM -0500, Matt Domsch wrote:
I've asked James Cameron, pptp project lead, to try
On 02/09/12 16:39, anish kumar wrote:
From: anish kumar anish198519851...@gmail.com
This patch is to use IIO to write a generic batttery driver.
battery
There are some inherent assumptions here:
1.User is having both main battery and backup battery.
Seems rather like that could be easily
On 09/05/2012 08:55 PM, Bryan Freed wrote:
The Industrial IO framework supports scaling ADC values by fractions,
but most drivers default to using whole numbers.
This change turns on fractional scaling in the isl29018 driver.
Signed-off-by: Bryan Freed bfr...@chromium.org
add to togreg
On 09/08/2012 08:10 AM, anish kumar wrote:
Thanks for your time.
On Fri, 2012-09-07 at 08:52 +0100, Jonathan Cameron wrote:
On 02/09/12 16:39, anish kumar wrote:
From: anish kumar anish198519851...@gmail.com
This patch is to use IIO to write a generic batttery driver.
battery
On 09/08/2012 08:30 AM, anish kumar wrote:
On Fri, 2012-09-07 at 10:49 +0200, Lars-Peter Clausen wrote:
On 09/02/2012 05:39 PM, anish kumar wrote:
From: anish kumar anish198519851...@gmail.com
This patch is to use IIO to write a generic batttery driver.
There are some inherent assumptions
On 09/07/2012 09:51 AM, Kim, Milo wrote:
Mostly looks fine. A small confusion has occured with the consumer
interface though and the read_raw needs a bit of reorganizing.
Nearly there!
TI LP8788 PMU provides regulators, battery charger, ADC,
RTC, backlight driver and current sinks.
This
On 09/09/2012 10:46 AM, Lars-Peter Clausen wrote:
On 09/09/2012 11:32 AM, anish kumar wrote:
+channels = iio_channel_get_all(dev_name(pdev-dev));
I would give these explicit names and get the two individual channels by
name. I think it will give you cleaner code.
Yes, now it will be
On 10/09/12 09:02, Kim, Milo wrote:
Use kzalloc() rathern than kmalloc() for initializing iio_dev and
iio_chan_spec.
Please state why. I'm sure I can track it down, but it ought to be
in the commit comment.
Signed-off-by: Milo(Woogyom) Kim milo@ti.com
---
drivers/iio/inkern.c |
On 10/09/12 09:02, Kim, Milo wrote:
The datasheet name is defined in the IIO driver.
On the other hand, the adc_channel_label is configured in
the platform machine side.
If the datasheet name is not matched with any adc_channel_label,
the iio_channel_get() should be returned as error
On 09/17/2012 09:44 AM, Kim, Milo wrote:
The datasheet name is defined in the IIO driver.
On the other hand, the adc_channel_label is configured in
the platform side.
If the datasheet name is not matched with any adc_channel_label,
the iio_channel_get() should be returned as error for
On 09/17/2012 10:57 AM, Kim, Milo wrote:
drivers/iio/inkern.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
index 13748c0..aff034b 100644
--- a/drivers/iio/inkern.c
+++ b/drivers/iio/inkern.c
@@ -132,7 +132,7 @@
On 09/18/2012 09:19 AM, Lars-Peter Clausen wrote:
On 09/17/2012 11:35 AM, Kim, Milo wrote:
TI LP8788 PMU provides regulators, battery charger, ADC,
RTC, backlight driver and current sinks.
This patch enables the LP8788 ADC functions.
The LP8788 ADC has several ADC input selection and
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/12/2012 07:07 AM, Stephen Rothwell wrote:
Hi Greg,
After merging the staging tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/hid/hid-sensor-hub.c: In function 'sensor_hub_probe':
On 09/18/2012 05:55 AM, Kim, Milo wrote:
The reference count of the IIO device is increased if the IIO map has
matched consumer name.
After then, it tries to allocate the iio_channel which is used by the
consumer.
If it fails to allocate memory, the reference count should be decreased.
On 09/18/2012 05:56 AM, Kim, Milo wrote:
When the IIO consumer tries to get specific IIO channel,
few error cases can be happened.
(a) Memory allocation failure
(b) No matched ADC channel error
(c) Invalid input arguments
This patch enables cleaning up error handling in case of (a) and
On 09/18/2012 09:18 PM, Jonathan Cameron wrote:
On 09/18/2012 09:19 AM, Lars-Peter Clausen wrote:
On 09/17/2012 11:35 AM, Kim, Milo wrote:
TI LP8788 PMU provides regulators, battery charger, ADC,
RTC, backlight driver and current sinks.
This patch enables the LP8788 ADC functions
On 09/21/2012 11:52 PM, Anton Vorontsov wrote:
On Fri, Sep 21, 2012 at 09:40:14PM +0530, anish kumar wrote:
From: anish kumar anish198519851...@gmail.com
In last version:
Addressed concerns raised by lars:
a. made the adc_bat per device.
b. get the IIO channel using hardcoded channel names.
On 09/22/2012 09:10 AM, Lars-Peter Clausen wrote:
On 09/22/2012 04:13 AM, Peter Hüwe wrote:
Hi,
loading iio_dummy results in kernel panic as the call to
iio_buffer_register in iio_dummy_probe is performed with indio_dev-buffer
==
NULL and thus the access to indio_dev-buffer-attrs results
On 09/18/2012 08:19 PM, Swapnil TIWARI wrote:
Add STMicroelectronics L3GD20 gyroscope device driver
Signed-off-by: Swapnil Tiwari swapnil.tiw...@st.com
mailto:swapnil.tiw...@st.com
Hi, couple of standard bits first.
1) Make sure your code passes checkpatch.pl with no warnings
(only
number (any one it support would
do) to avoid a clash in future with a new touch screen adc from TI.
Bit late for that though I guess ;)
Jonathan
---
Changes in v2:
Addressed review comments from Matthias Kaehlcke
Changes in v3:
Addressed review comments from Jonathan Cameron
Couple of nitpicks in line to add to Lars-Peter's ones.
TI LP8788 PMU provides regulators, battery charger, ADC,
RTC, backlight driver and current sinks.
This patch enables the LP8788 ADC functions.
The LP8788 ADC has 13 ADC input selection and supports 12-bit resolution.
Internal
Thanks Lars, all of your comments are valid and I will accordingly update.
I am waiting for some more review comments if there is any and will send
the updated code.
Beware of that strategy as I for one am guilty of the old approach of
'oh look someone else has commented, I'll wait for the
On 09/08/2012 08:42 PM, anish kumar wrote:
From: anish kumar anish198519851...@gmail.com
This commit- 314be14bb renamed the _st_ functions to loose the bit
that was meant for staging version but forgot to change
the documentation which still have _st_ sprinkled in some of the
places.
On 09/13/2012 05:16 PM, anish kumar wrote:
From: anish kumar anish198519851...@gmail.com
In this version:
Addressed concerns raised by lars:
a. made the adc_bat per device.
b. get the IIO channel using hardcoded channel names.
Couple of bits related to this inline..
c. Minor issues related
On 14/09/12 07:00, Patil, Rachna wrote:
On Thu, Sep 13, 2012 at 17:43:30, Jonathan Cameron wrote:
On 13/09/12 11:40, Patil, Rachna wrote:
This patch adds support for TI's ADC driver.
This is a multifunctional device.
Analog input lines are provided on which voltage measurements can be
carried
On 14/09/12 01:59, Kim, Milo wrote:
On 10/09/12 09:02, Kim, Milo wrote:
The datasheet name is defined in the IIO driver.
On the other hand, the adc_channel_label is configured in
the platform machine side.
If the datasheet name is not matched with any adc_channel_label,
the
On 09/15/2012 01:15 AM, Kim, Milo wrote:
The LP8788 has 13 ADC input selection.
ADC selection:
Battery voltage, general ADC1 and so on.
ADC result:
Result = MAX_VALUE * (raw + 0.5) / 4095 except ADC is the charger
voltage
If the ADC input is the charger voltage,
Result = MAX_VALUE *
On 09/14/2012 02:24 AM, Kim, Milo wrote:
Use kzalloc() rather than kmalloc() for initializing the iio_channel
structure.
This patch enables the iio_dev and iio_chan_spec are set to NULL.
This may prevent the page fault problem because the pointer of iio_chan_spec
is initialized as NULL.
On 08/30/2012 08:38 AM, Patil, Rachna wrote:
This patch adds support for TI's ADC driver.
This is a multifunctional device.
Analog input lines are provided on which
voltage measurements can be carried out.
You can have upto 8 input lines.
Nice concise driver.
A few comments and questions
On 08/02/2012 11:10 AM, Axel Lin wrote:
Fix below build warnings:
CC [M] drivers/iio/light/lm3533-als.o
drivers/iio/light/lm3533-als.c:667:8: warning: initialization from
incompatible pointer type [enabled by default]
drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for
Lars-Peter,
Are you happy with this updated version? Can't immediately find any response
from you to it.
Jonathan
From: Julia Lawall julia.law...@lip6.fr
The various devm_ functions allocate memory that is released when a driver
detaches. This patch uses these functions for data that is
On 08/10/2012 08:06 AM, Kim, Milo wrote:
Patch v2.
(a) Use iio_priv() for private data rather than allocating data
(b) Support raw and scale inferface for iio consumer
(c) Make inline function for lp8788_adc_read_raw()
(d) For better readability, use fixed number for shift and mask
Kim, Milo milo@ti.com wrote:
+ switch (mask) {
+ case IIO_CHAN_INFO_RAW:
+ *val = result;
+ return IIO_VAL_INT;
+ case IIO_CHAN_INFO_SCALE:
+ *val = adc_const[id] * ((result * 1000 + 500) / 1000);
This looks wrong. The IIO_CHAN_INFO_SCALE
On 16/08/12 09:19, Lars-Peter Clausen wrote:
On 08/16/2012 09:39 AM, Kim, Milo wrote:
This allows the iio consumer to get the offset of the channel.
The value of offset can be used when calculating the result such
as 'result = raw * scale + offset'.
result = (raw + offset) * scale
Otherwise
On 08/16/2012 08:49 AM, Kim, Milo wrote:
int iio_read_channel_scale(struct iio_channel *chan, int *val,
int *val2);
+/**
+ * iio_read_channel_offset() - read offset from a given channel
+ * @channel: The channel being queried.
the parameter is 'chan',
On 08/15/2012 10:20 AM, Julia Lawall wrote:
devm_request_and_ioremap will already print a error messages on it's own if
something goes wrong. So strictly speaking this one is redundant, but I don't
think it is necessary to do a resend just for this, maybe you can remove the
extra dev_err when
On 08/09/2012 09:22 AM, Kim, Milo wrote:
TI LP8788 has ADC function.
The result of LP878 ADC is used in the LP8788 power supply driver.
(such like getting the battery voltage, temperature and etc)
Hi,
This is mostly fine though things have gotten a little confused
wrt to the handling
On 08/08/2012 02:04 AM, anish kumar wrote:
From: anish kumar anish198519851...@gmail.com
External connector devices that decides connection information based on
ADC values may use adc-jack device driver. The user simply needs to
provide a table of adc range and connection states. Then, extcon
1 - 100 of 11002 matches
Mail list logo
