f-by: Lin Huang
>> Signed-off-by: MyngJoo Ham
>> Reviewed-by: Chanwoo Choi
>> ---
>
> [...]
>
>> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
>> new file mode 100644
>> index 000..54d65f2
>> --- /dev/null
>>
y the DFI, must be "pclk_ddr_mon";
> +
> +Example:
> + dfi: dfi@0xff63 {
> + reg = <0x00 0xff63 0x00 0x4000>;
> + compatible = "rockchip,rk3399-dfi";
As I already commented, you need to reorder between compatible and reg
ible = "operating-points-v2";
> +
> + opp00 {
> + opp-hz = /bits/ 64 <3>;
> + opp-microvolt = <90>;
> + };
> + opp01 {
> + opp-hz = /bits/ 64 <66600>;
> + opp-microvolt = <90>;
> + };
> + };
> +
> + dmc: dmc {
> + compatible = "rockchip,rk3399-dmc";
> + devfreq-events = <&dfi>;
> + interrupts = ;
> + clocks = <&cru SCLK_DDRCLK>;
> + clock-names = "dmc_clk";
> + operating-points-v2 = <&dmc_opp_table>;
> + center-supply = <&ppvar_centerlogic>;
> + upthreshold = <15>;
> + downdifferential = <10>;
> + status = "disabled";
> + };
> +
>
--
Best Regards,
Chanwoo Choi
On 2016년 08월 28일 01:33, Krzysztof Kozlowski wrote:
> On Thu, Aug 25, 2016 at 03:57:18PM +0900, Chanwoo Choi wrote:
>> This patch sets the clock rate for DREX (DRAM Express) block
>> on exynos5422-odroidxu3 board. In the exynos5422 TRM,
>> DRAM clocks use BPLL clock and CMU_C
On 2016년 08월 27일 01:14, Krzysztof Kozlowski wrote:
> On Wed, Aug 24, 2016 at 10:49:09PM +0900, Chanwoo Choi wrote:
>> This patch adds new Exynos5433 dtsi to support 64-bit Exynos5433 SoC based on
>> Octa-core CPUs (quad Cortex-A57 and quad Cortex-A53). And Exynos5433 supports
>&
Hi Javier,
On 2016년 08월 27일 02:49, Javier Martinez Canillas wrote:
> Hello Chanwoo,
>
> The patch looks good to me, I just have a few minor comments:
>
> On 08/24/2016 09:49 AM, Chanwoo Choi wrote:
>
> [snip]
>
>> +
>> +reboot: syscon-reboot {
>>
regulator-off-in-suspend;
>> +};
>> +};
>> +
>> +buck3_reg: BUCK3 {
>> +regulator-name = "VDD_KFC_1.0V_AP";
>
> Same, maybe using "VDD_APL_1.0V_AP" since the big cluster is Apollo?
ditto.
The KFC (King Fisher) means the little cores.
>
>> +regulator-min-microvolt = <80>;
>> +regulator-max-microvolt = <120>;
>> +regulator-always-on;
>> +regulator-state-mem {
>> +regulator-off-in-suspend;
>> +};
>> +};
>> +
>
> Used by the big and LITTLE clusters respectively, although for these two
> I'm not that sure if it would be safe to remove the always-on property.
>
> Reviewed-by: Javier Martinez Canillas
Thanks for your review.
>
> [0]: http://www.spinics.net/lists/arm-kernel/msg419747.html
>
> Best regards,
>
--
Best Regards,
Chanwoo Choi
Hi Guenter,
On 2016년 08월 04일 23:47, Guenter Roeck wrote:
> On Thu, Aug 4, 2016 at 3:57 AM, Chanwoo Choi wrote:
>> Hi Guenter and Roger,
>>
>> On 2016년 08월 04일 17:49, Roger Quadros wrote:
>>> On 04/08/16 07:09, Guenter Roeck wrote:
>>>> On Wed, A
: Chris Zhong
Signed-off-by: Chanwoo Choi
Tested-by: Chris Zhong
Tested-by: Guenter Roeck
Reviewed-by: Guenter Roeck
---
drivers/extcon/extcon.c | 5 +
include/linux/extcon.h | 8 +++-
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon.c b/drivers/extcon
- EXTCON_TYPE_DISP : Display connector
- EXTCON_TYPE_MISC : Miscellaneous connector
Also, each external connector is possible to belong to one more extcon type.
In caes of EXTCON_CHG_USB_SDP, it have the EXTCON_TYPE_CHG and EXTCON_TYPE_USB.
Signed-off-by: Chanwoo Choi
Tested-by: Chris Zhong
extcon_dev *edev,
unsigned int id, unsigned int prop);
- int extcon_set_property_capability(struct extcon_dev *edev,
unsigned int id, unsigned int prop);
Signed-off-by: Chanwoo Choi
Tested-by: Chris Zhong
Tested-by: Guenter
he old extcon_set/get_cable_state_() functions
to prevent the build break. After altering new APIs, remove the old APIs.
Signed-off-by: Chanwoo Choi
Tested-by: Chris Zhong
Tested-by: Guenter Roeck
Reviewed-by: Guenter Roeck
---
drivers/extcon/extcon.c | 28 +---
include
ynchronized the data.
extcon_set_property(edev, EXTCON_USB, EXTCON_PROP_USB_VBUS, 1);
extcon_sync(edev, EXTCON_USB);
case 4, change the property of external connector and synchronized the data.
extcon_set_property_sync(edev, EXTCON_USB, EXTCON_PROP_USB_VBUS, 0);
Chan
.
extcon_set_property_sync(edev, EXTCON_USB, EXTCON_PROP_USB_VBUS, 0);
Signed-off-by: Chanwoo Choi
Tested-by: Chris Zhong
Tested-by: Guenter Roeck
Reviewed-by: Guenter Roeck
---
drivers/extcon/extcon.c | 210 +++-
include/linux/extcon.h | 30
extcon_dev *edev, unsigned int id,
unsigned int prop,
union extcon_property_value prop_val)
Signed-off-by: Chanwoo Choi
Tested-by: Chris Zhong
Tested-by: Guenter Roeck
Reviewed-by: Guenter Roeck
---
drivers/extcon/extcon.c | 201
: Chanwoo Choi
---
drivers/extcon/extcon.c | 5 +
include/linux/extcon.h | 1 +
2 files changed, 6 insertions(+)
diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index a0a1eea18727..10ba876ea77a 100644
--- a/drivers/extcon/extcon.c
+++ b/drivers/extcon/extcon.c
@@ -162,6 +162,11
This patchs add the new EXTCON_CHG_WPT for Wireless Power Transfer[1].
The Wireless Power Transfer is the transmission of electronical energy
from a power source. The EXTCON_CHG_WPT has the EXTCON_TYPE_CHG.
[1] https://en.wikipedia.org/wiki/Wireless_power_transfer
Signed-off-by: Chanwoo Choi
On 2016년 08월 24일 13:43, Stephen Boyd wrote:
> On 08/23, Sylwester Nawrocki wrote:
>> On 08/23/2016 04:35 AM, Chanwoo Choi wrote:
>> I checked stripped object files and it seems with the patch there
>> is some saving of the kernel image size. Exactly 784 bytes, which
>>
Hi Tomasz,
I'm sorry for delay reply.
On 2016년 08월 19일 20:31, Tomasz Figa wrote:
> Hi Chanwoo,
>
> 2016-08-19 18:07 GMT+09:00 Chanwoo Choi :
>> Hi Tomasz Figa,
>>
>> Due to wrong setting of email client,
>> your reply is deleted on my email client at th
devices
- MSHC (Mobile Storae Host Controller) for eMMC device
6. misc devices
- gpio-keys (power, volume up/down, home key)
- PWM (Pulse Width Modulation Timer)
Signed-off-by: Chanwoo Choi
Signed-off-by: Jaehoon Chung
Signed-off-by: Seung-Woo Kim
Signed-off-by: Joonyoung Shim
Signed-off-by: Inki
This patch adds the Device Tree source for Exynos5433-based Samsung TM2E
board. TM2E board is the most similar with TM2 board. The exynos5433-tm2e.dts
include the difference between TM2 and TM2E.
Signed-off-by: Chanwoo Choi
Signed-off-by: Jaehoon Chung
Signed-off-by: Seung-Woo Kim
Signed-off
This patch adds the exynos5433 PMU compatible to support the access
of PMU (Power Management Unit) block.
Signed-off-by: Chanwoo Choi
Reviewed-by: Krzysztof Kozlowski
Acked-by: Rob Herring
---
Documentation/devicetree/bindings/arm/samsung/pmu.txt | 1 +
1 file changed, 1 insertion(+)
diff
devices
- UART device
- ADC (Analog Digital Converter)
- PWM (Pulse Width Modulation)
- ADMA (Advanced DMA) and PDMA (Peripheral DMA)
Signed-off-by: Chanwoo Choi
Signed-off-by: Jaehoon Chung
Signed-off-by: Seung-Woo Kim
Signed-off-by: Joonyoung Shim
Signed-off-by: Inki Dae
Signed-off-by: Jonghwa
Cc: Sylwester Nawrocki
Cc: Kukjin Kim
Cc: linux-g...@vger.kernel.org
Signed-off-by: Joonyoung Shim
Signed-off-by: Chanwoo Choi
[robh : Acked for binding documentation]
Acked-by: Rob Herring
---
Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt | 1 +
drivers/pinctrl/samsung/pinctrl
compatible to use generic cpufreq
driver
Chanwoo Choi (6):
clocksource: exynos_mct: Add the support for ARM64
Documentation: bindings: Add Exynos5433 PMU compatible
pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank
arm64: dts: exynos: Add dts files for Sam
Cc: Mark Rutland
Cc: Tomasz Figa
Cc: Krzysztof Kozlowski
Cc: Sylwester Nawrocki
Cc: Kukjin Kim
Cc: linux-g...@vger.kernel.org
Suggested-by: Tomasz Figa
Signed-off-by: Chanwoo Choi
---
.../bindings/pinctrl/samsung-pinctrl.txt | 17 +++
drivers/pinctrl/samsung/pinctrl-exynos.c
This patch adds the support for ARM 64bit. The delay_timer is only supported
on ARM 32bit.
Cc: Daniel Lezcano
Cc: Thomas Gleixner
Cc: Kukjin Kim
Cc: Krzysztof Kozlowski
Signed-off-by: Chanwoo Choi
---
drivers/clocksource/Kconfig | 2 +-
drivers/clocksource/exynos_mct.c | 4
2
source
group.
Signed-off-by: Chanwoo Choi
---
drivers/clk/samsung/clk-exynos5420.c | 37
1 file changed, 37 insertions(+)
diff --git a/drivers/clk/samsung/clk-exynos5420.c
b/drivers/clk/samsung/clk-exynos5420.c
index bb196ca21a77..8c8b495cbf0d 100644
--- a
This patch adds the new clock id for CMU_CDRES (DRAM Express Controller)
geneates the clocks for DRAM and NoC (Network on Chip) bus clock.
Signed-off-by: Chanwoo Choi
---
include/dt-bindings/clock/exynos5420.h | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a
0 8 0 0
Signed-off-by: Chanwoo Choi
---
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
index d56253049ccb
:
- Use the BPLL for DRAM clock to generate the 800MHz
- Add patch3 to assign the clock rate for DRAM clock
Chanwoo Choi (3):
dt-bindings: Add the clock id for CMU_CDREX (DRAM Express Controller)
clk: samsung: exynos5420: Add clocks for CMU_CDREX domain
ARM: dts: Set the clock rate for DREX
Hi Stephen,
On 2016년 08월 25일 09:11, Stephen Boyd wrote:
> On 08/24, Chanwoo Choi wrote:
>> On 2016년 08월 24일 13:43, Stephen Boyd wrote:
>>> On 08/23, Sylwester Nawrocki wrote:
>>>> So the saving is rather insignificant but the patch doesn't make
>>>
p;id=c2f9bf4e49c12a3d9fcbee2cd48c9f5d769d8cc8
If you resend it with rebase on devfreq.git,
Feel free to add my reviewed-by tag:
Reviewed-by: Chanwoo Choi
On 2016년 08월 25일 21:06, Jisheng Zhang wrote:
> Use tab rather than space to indent, and tab + two spaces to indent
> help message.
>
> Signed-off-b
> +
> Example: Examples of extcon-usb-gpio node in dra7-evm.dts as listed below:
> extcon_usb1 {
> compatible = "linux,extcon-usb-gpio";
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
)
> - info->debounce_jiffies = msecs_to_jiffies(USB_GPIO_DEBOUNCE_MS);
> + info->debounce_jiffies = msecs_to_jiffies(
> + info->gpio_debounce_timeout_ms);
>
> INIT_DELAYED_WORK(&info->wq_detcable, usb_extcon_detect_cable);
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi,
On 2017년 10월 17일 23:43, MyungJoo Ham wrote:
> On Fri, Oct 13, 2017 at 4:48 PM, Chanwoo Choi wrote:
>> The commit a76caf55e5b35 ("thermal: Add devfreq cooling") is able
>> to disable OPP as a cooling device. In result, both update_devfreq()
>> and {min|max}_f
Hi,
On 2017년 10월 18일 00:11, MyungJoo Ham wrote:
> On Fri, Oct 13, 2017 at 4:48 PM, Chanwoo Choi wrote:
>> This patch registers the Exynos Bus-Frequency scaling device
>> as a cooling device of thermal management.
>>
>> Signed-off-by: Chanwoo Choi
>> Cc: Kukji
On 2017년 10월 18일 10:31, Chanwoo Choi wrote:
> Hi,
>
> On 2017년 10월 17일 23:43, MyungJoo Ham wrote:
>> On Fri, Oct 13, 2017 at 4:48 PM, Chanwoo Choi wrote:
>>> The commit a76caf55e5b35 ("thermal: Add devfreq cooling") is able
>>> to disable OPP as a coo
gt; handling of ID and Vbus pins. There's some work happening on that[1].
These patch set[1] are related to connect/bind between provider driver
and consumer driver through OF graph.
Before, the provider driver should probe their job on the device driver.
This patch just add the debounce property of gpio during the probe time.
>
> Rob
>
> [1] https://www.spinics.net/lists/linux-usb/msg161106.html
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Dear Greg,
This is extcon-next pull request for v4.15. I add detailed description of
this pull request on below. Please pull extcon with following updates.
Best Regards,
Chanwoo Choi
The following changes since commit 2bd6bf03f4c1c59381d62c61d03f6cc3fe71f66e:
Linux 4.14-rc1 (2017-09-16 15
failed. You can check the
detailed reason on patch1[1].
[1] PM / devfreq: Fix memory leak when fail to register device
-
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9e14de1077e9c34f141cf98bdba60cdd5193d962
--
Best Regards,
Chanwoo Choi
Samsung Electronics
urn devfreq;
> }
>
> *ptr = devfreq;
>
Looks good to me.
Acked-by: Chanwoo Choi
But, you better to send this patch to the 'sta...@vger.kernel.org'
with the fixes information as following:
Fixes: 8cd84092d35e ("PM / devfreq: Add resource-managed f
Gently Ping.
Dear Kishon,
Could you please review this patch for 'drivers/phy/*'?
Regards,
Chanwoo Choi
On 2017년 10월 12일 12:40, Chanwoo Choi wrote:
> Dear Kishon,
>
> Could you please review this patch?
> After that, I'll make the immutable brand and then
n, as we will now fail to
> compile on !X86
> -Minor code style tweaks
> ---
> drivers/extcon/Kconfig| 3 +-
> drivers/extcon/extcon-intel-int3496.c | 59
> +++
> 2 files changed, 61 insertions(+), 1 deletion(-)
Acked-by: C
/extcon/extcon.c | 44 ++--
> include/linux/extcon.h | 6 ++
> 2 files changed, 40 insertions(+), 10 deletions(-)
Looks good to me. Just I added the minor comment.
Acked-by: Chanwoo Choi
>
> diff --git a/drivers/extcon/extcon.c b/drivers/ext
On 2017년 10월 18일 18:14, Hans de Goede wrote:
> Hi,
>
> On 18-10-17 04:33, Chanwoo Choi wrote:
>> Hi Hans,
>>
>> On 2017년 09월 23일 03:37, Hans de Goede wrote:
>>> Cherry Trail SoCs have a built-in USB-role mux for switching between
>>> the host and devi
Hi Marek,
Looks good to me. But, the patch subject is wrong as following:
- max88743 -> max77843
If you fix the subject, feel free to add my acked-tag.
Acked-by: Chanwoo Choi
Regards,
Chanwoo Choi
On 2017년 10월 18일 18:28, Marek Szyprowski wrote:
> Enabling power on VBUS micro-usb
Hi Marek,
Also, this patch need to fix the patch subject as following:
- max88743 -> max77843
If you fix the subject, feel free to add my acked-tag.
Acked-by: Chanwoo Choi
After finishing the review from MFD maintainer, I'll merge them.
Regards,
Chanwoo Choi
On 2017년 10월 18일 18:2
screen")
Cc: sta...@vger.kernel.org
Signed-off-by: Chanwoo Choi
---
drivers/input/touchscreen/stmfts.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/input/touchscreen/stmfts.c
b/drivers/input/touchscreen/stmfts.c
index 157fdb4bb2e8..8c6c6178ec12 100644
--- a/
usb-gpio node in dra7-evm.dts as listed below:
> extcon_usb1 {
> compatible = "linux,extcon-usb-gpio";
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
e_usecs * 1000);
>
> if (ret < 0)
> - info->debounce_jiffies = msecs_to_jiffies(USB_GPIO_DEBOUNCE_MS);
> + info->debounce_jiffies = msecs_to_jiffies(info->debounce_usecs);
ditto.
>
> INIT_DELAYED_WORK(&info->wq_detcable, usb_extcon_detect_cable);
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi,
On 2017년 10월 19일 13:47, Chanwoo Choi wrote:
> On 2017년 10월 19일 12:25, Raveendra Padasalagi wrote:
>> Add documentation on optional dt attribute "debounce-timeout-ms"
>> in extcon node to capture user specified timeout value for id
>> and vbus gpio detection.
On 2017년 10월 19일 13:59, Chanwoo Choi wrote:
> Hi,
>
> On 2017년 10월 19일 12:26, Raveendra Padasalagi wrote:
>> Add changes to capture optional dt attribute "debounce-timeout-ms"
>> provided in extcon node and used the same value if provided otherwise
>> default
pio_debounce_timeout_ms to debounce_usecs
>
> drivers/extcon/extcon-usb-gpio.c | 14 ++
> 1 file changed, 10 insertions(+), 4 deletions(-)
Looks good to me.
Acked-by: Chanwoo Choi
After completing the review of patch1 from DT maintainer,
I'll merge these patch sets.
&
nux kernel.
>>
>>>> +/* Display external connector */
>>>> +#define EXTCON_DISP_HDMI 40 /* High-Definition Multimedia
>>>> Interface */
>>>> +#define EXTCON_DISP_MHL41 /* Mobile High-Definition
>>>> Link */
>>>> +#define EXTCON_DISP_DVI42 /* Digital Visual
>>>> Interface */
>>>> +#define EXTCON_DISP_VGA43 /* Video Graphics Array */
>>>> +#define EXTCON_DISP_DP 44 /* Display Port */
>>>> +#define EXTCON_DISP_HMD45 /* Head-Mounted Display */
>>>
>>> We already have connector bindings for most of these. Use those as a
>>> model for whatever you want to do.
>>
>> I guess they are not in Documentation/devicetree/bindings/extcon/*
>>
>> Please point me in the right direction and I'll check it out.
>>
>> Yours,
>> Linus Walleij
>>
>>
>>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
phy %d", id);
>> +ret = PTR_ERR(instance_ptr->generic_phy);
>> +goto put_child;
>> +}
>> +
>> +vbus_name = devm_kzalloc(&instance_ptr->generic_phy->dev,
>> +MAX_REGULATOR_NAME_LEN,
>> +GFP_KERNEL);
>> +if (!vbus_name) {
>> +ret = -ENOMEM;
>> +goto put_child;
>> +}
>> +
>> +/* regulator use is optional */
>> +sprintf(vbus_name, "vbus-p%d", id);
>> +instance_ptr->vbus_supply =
>> +devm_regulator_get(&instance_ptr->generic_phy->dev,
>> +vbus_name);
>> +if (IS_ERR(instance_ptr->vbus_supply))
>> +instance_ptr->vbus_supply = NULL;
>> +devm_kfree(&instance_ptr->generic_phy->dev, vbus_name);
>> +phy_set_drvdata(instance_ptr->generic_phy, instance_ptr);
>> +}
>> +
>> +return 0;
>> +
>> +put_child:
>> +of_node_put(child);
>> +return ret;
>> +}
>> +
>> +static int cygnus_phy_probe(struct platform_device *pdev)
>> +{
>> +struct resource *res;
>> +struct cygnus_phy_driver *phy_driver;
>> +struct phy_provider *phy_provider;
>> +int i, ret;
>> +u32 reg_val;
>> +struct device *dev = &pdev->dev;
>> +struct device_node *node = dev->of_node;
>> +
>> +/* allocate memory for each phy instance */
>> +phy_driver = devm_kzalloc(dev, sizeof(struct cygnus_phy_driver),
>> + GFP_KERNEL);
>> +if (!phy_driver)
>> +return -ENOMEM;
>> +
>> +phy_driver->num_phys = of_get_child_count(node);
>> +
>> +if (phy_driver->num_phys == 0) {
>> +dev_err(dev, "PHY no child node\n");
>> +return -ENODEV;
>> +}
>> +
>> +phy_driver->instances = devm_kcalloc(dev, phy_driver->num_phys,
>> + sizeof(struct cygnus_phy_instance),
>> + GFP_KERNEL);
>> +phy_driver->pdev = pdev;
>> +platform_set_drvdata(pdev, phy_driver);
>> +
>> +ret = cygnus_phy_instance_create(phy_driver);
>> +if (ret)
>> +return ret;
>> +
>> +res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
>> + "crmu-usbphy-aon-ctrl");
>> +phy_driver->crmu_usbphy_aon_ctrl_regs = devm_ioremap_resource(dev, res);
>> +if (IS_ERR(phy_driver->crmu_usbphy_aon_ctrl_regs))
>> +return PTR_ERR(phy_driver->crmu_usbphy_aon_ctrl_regs);
>> +
>> +res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
>> + "cdru-usbphy");
>> +phy_driver->cdru_usbphy_regs = devm_ioremap_resource(dev, res);
>> +if (IS_ERR(phy_driver->cdru_usbphy_regs))
>> +return PTR_ERR(phy_driver->cdru_usbphy_regs);
>> +
>> +res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "usb2h-idm");
>> +phy_driver->usb2h_idm_regs = devm_ioremap_resource(dev, res);
>> +if (IS_ERR(phy_driver->usb2h_idm_regs))
>> +return PTR_ERR(phy_driver->usb2h_idm_regs);
>> +
>> +res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "usb2d-idm");
>> +phy_driver->usb2d_idm_regs = devm_ioremap_resource(dev, res);
>> +if (IS_ERR(phy_driver->usb2d_idm_regs))
>> +return PTR_ERR(phy_driver->usb2d_idm_regs);
>> +
>> +reg_val = readl(phy_driver->usb2d_idm_regs);
>> +writel((reg_val | USB2D_IDM_IDM_IO_SS_CLEAR_NAK_NEMPTY_EN_I),
>> + phy_driver->usb2d_idm_regs);
>> +phy_driver->idm_host_enabled = false;
>> +
>> +/*
>> + * Shutdown all ports. They can be powered up as
>> + * required
>> + */
>> +reg_val = readl(phy_driver->crmu_usbphy_aon_ctrl_regs +
>> +CRMU_USB_PHY_AON_CTRL_OFFSET);
>> +reg_val &= ~CRMU_USBPHY_P0_AFE_CORERDY_VDDC;
>> +reg_val &= ~CRMU_USBPHY_P0_RESETB;
>> +reg_val &= ~CRMU_USBPHY_P1_AFE_CORERDY_VDDC;
>> +reg_val &= ~CRMU_USBPHY_P1_RESETB;
>> +reg_val &= ~CRMU_USBPHY_P2_AFE_CORERDY_VDDC;
>> +reg_val &= ~CRMU_USBPHY_P2_RESETB;
>> +writel(reg_val, phy_driver->crmu_usbphy_aon_ctrl_regs +
>> +CRMU_USB_PHY_AON_CTRL_OFFSET);
>
> move the above to a separate function to make probe a lot cleaner.
>
> Thanks
> Kishon
>
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi,
On 2017년 10월 30일 14:02, Raveendra Padasalagi wrote:
> Hi Chanwoo,
>
> On Mon, Oct 30, 2017 at 5:32 AM, Chanwoo Choi wrote:
>> Hi,
>>
>> On 2017년 10월 27일 17:35, Kishon Vijay Abraham I wrote:
>>> +Chanwoo, for reviewing extcon
>>>
>>> Hi.
On 2015년 10월 05일 17:03, MyungJoo Ham wrote:
>>
>> This patch adds the support for Device tree bindings of extcon-gpio driver.
>> The extcon-gpio device tree node must include the both 'extcon-id' and
>> 'extcon-gpio' property.
>>
> []
>&
Roger,
On 2015년 10월 05일 19:49, Roger Quadros wrote:
> Chanwoo,
>
> On 05/10/15 12:04, Chanwoo Choi wrote:
>> Hi Roger,
>>
>> On 2015년 10월 05일 18:01, Chanwoo Choi wrote:
>>> Hi Roger,
>>>
>>> On 2015년 10월 05일 17:26, Roger Quadros wrote:
&
:
: EXTCON_CHG_USB_FAST -> EXTCON_CHG_USB_DCP_FAST
: EXTCON_CHG_USB_SLOW -> EXTCON_CHG_USB_DCP_SLOW
- Add the missing EXTCON_CHG_USB_ACA charger connector
- Add one more patch to support the EXTCON_CHG_USB when SDP port is connected
or not
Chanwoo Choi (2):
extcon: Modify the id and name of ex
data transmission.
- EXTCON_CHG_USB means the USB charger cable for battery charging.
This patch add the support of EXTCON_CHG_USB when USB SDP is attached or
detached.
Signed-off-by: Chanwoo Choi
---
drivers/extcon/extcon-max14577.c | 2 ++
drivers/extcon/extcon-max77693.c | 11
5efc8a18ce ("[PATCH] power_supply: Add types for USB chargers")
Signed-off-by: Chanwoo Choi
[ckeepax: For the Arizona changes]
Acked-by: Charles Keepax
---
drivers/extcon/extcon-arizona.c | 18 ++--
drivers/extcon/extcon-axp288.c | 12
drivers/extcon/ex
ging Port */
>> - EXTCON_CHG_USB_CDP /* Charging Downstream Port */
>> - EXTCON_CHG_USB_ACA /* Accessory Charger Adapter */
>>
>> [1] www.usb.org/developers/docs/devclass_docs/BCv1.2_070312.zip
>> [2] commit 85efc8a18ce ("[PATCH] power_supply: Add types for USB
Roger,
On 2015년 10월 06일 20:49, Roger Quadros wrote:
> Hi,
>
> On 06/10/15 14:21, Chanwoo Choi wrote:
>> The SDP (Standard Downstream Port) is one of various USB Charging ports. The
>> SDP
>> supports both the data transmission and the charging through USB connector a
Roger,
On 2015년 10월 06일 21:22, Roger Quadros wrote:
> Chanwoo,
>
> On 06/10/15 15:12, Chanwoo Choi wrote:
>> Roger,
>>
>> On 2015년 10월 06일 20:49, Roger Quadros wrote:
>>> Hi,
>>>
>>> On 06/10/15 14:21, Chanwoo Choi wrote:
>>>>
s")
Signed-off-by: Chanwoo Choi
[ckeepax: For the Arizona changes]
Acked-by: Charles Keepax
---
Changes from v2:
(https://lkml.org/lkml/2015/10/6/239)
- Remove the EXTCON_CHG_USB type to remove the possible confusion according to
Roger's comment and drop patch2 about EXTCON_CHG_USB
On 2015년 10월 07일 16:33, Roger Quadros wrote:
> On 07/10/15 03:48, Chanwoo Choi wrote:
>> This patch modifies the id and name of external connector with the
>> additional prefix to clarify both attribute and meaning of external
>> connector as following:
>> - EXTCON_CHG_*
On 2015년 10월 07일 16:50, Roger Quadros wrote:
> On 07/10/15 10:42, Chanwoo Choi wrote:
>> On 2015년 10월 07일 16:33, Roger Quadros wrote:
>>> On 07/10/15 03:48, Chanwoo Choi wrote:
>>>> This patch modifies the id and name of external connector with the
>>>> a
Roger,
On 2015년 10월 07일 16:59, Chanwoo Choi wrote:
> On 2015년 10월 07일 16:50, Roger Quadros wrote:
>> On 07/10/15 10:42, Chanwoo Choi wrote:
>>> On 2015년 10월 07일 16:33, Roger Quadros wrote:
>>>> On 07/10/15 03:48, Chanwoo Choi wrote:
>>>>> This patch m
Roger,
On 2015년 10월 07일 17:23, Roger Quadros wrote:
> Chanwoo,
>
> On 07/10/15 11:09, Chanwoo Choi wrote:
>> Roger,
>>
>> On 2015년 10월 07일 16:59, Chanwoo Choi wrote:
>>> On 2015년 10월 07일 16:50, Roger Quadros wrote:
>>>> On 07/10/15 10:42, Chanwoo
Roger,
On 2015년 10월 07일 17:52, Roger Quadros wrote:
> On 07/10/15 11:30, Chanwoo Choi wrote:
>> Roger,
>>
>> On 2015년 10월 07일 17:23, Roger Quadros wrote:
>>> Chanwoo,
>>>
>>> On 07/10/15 11:09, Chanwoo Choi wrote:
>>>> Roger,
>>
efc8a18ced ("power_supply: Add types for USB chargers")
Signed-off-by: Chanwoo Choi
[ckeepax: For the Arizona changes]
Acked-by: Charles Keepax
---
Changes from v3:
(https://lkml.org/lkml/2015/10/6/984)
- Modify the name of fast/slow charger connector as following:
: EXT
therwise I really don't see anyway to
> move this forward and would appreciate any suggestions?
I'm positive about your patches. After receiving the ack from MFD maintainer
I want to apply this patch-set on extcon git repository.
Also, I reviewed this patch on previous patch[1].
[1]https://lk
On 2015년 10월 12일 19:16, Chanwoo Choi wrote:
> Hi Charles,
>
> On 2015년 10월 12일 17:45, Charles Keepax wrote:
>> On Wed, Oct 07, 2015 at 01:26:42PM +0100, Lee Jones wrote:
>>> On Wed, 07 Oct 2015, Mark Brown wrote:
>>>
>>>> On Fri, Oct 02, 2015 at 05:2
Hi Mark,
On 2015년 10월 05일 20:13, Mark Rutland wrote:
> On Mon, Oct 05, 2015 at 03:58:19PM +0900, Chanwoo Choi wrote:
>> This patch adds the support for Device tree bindings of extcon-gpio driver.
>> The extcon-gpio device tree node must include the both 'extcon-id' and
On 2015년 10월 13일 17:03, Lee Jones wrote:
> On Mon, 12 Oct 2015, Chanwoo Choi wrote:
>
>> On 2015년 10월 12일 19:16, Chanwoo Choi wrote:
>>> Hi Charles,
>>>
>>> On 2015년 10월 12일 17:45, Charles Keepax wrote:
>>>> On Wed, Oct 07, 2015 at 01:26:42P
Hi Roger,
Don't you have any comment?
If possible, I would like you to review this patch.
Thanks,
Chanwoo Choi
On 2015년 10월 08일 18:24, Chanwoo Choi wrote:
> This patch modifies the id and name of external connector with the
> additional prefix to clarify both attribute and meaning
n't touch audio subsystems. I was treating jack detection
>> as an extcon thing and thus assuming that the extcon maintainer
>> would be sufficient, but perhaps that is an incorrect assumption.
>
> Now I know that jack detection is an Extcon thing and Extcon Ack will
> do ju
On 2015년 10월 13일 22:59, Chanwoo Choi wrote:
> Hi Lee,
>
> On 2015년 10월 13일 22:50, Lee Jones wrote:
>> On Tue, 13 Oct 2015, Charles Keepax wrote:
>>
>>> On Tue, Oct 13, 2015 at 09:02:18AM +0100, Lee Jones wrote:
>>>> On Mon, 12 Oct 2015, Mark Brown wrote
Hi Roger,
On 2015년 10월 14일 16:13, Roger Quadros wrote:
> Chanwoo,
>
> On 08/10/15 12:24, Chanwoo Choi wrote:
>> This patch modifies the id and name of external connector with the
>> additional prefix to clarify both attribute and meaning of external
>> connector as
gt; F: arch/arm/mach-s3c64xx/mach-crag6410*
> F: drivers/clk/clk-wm83*.c
> F: drivers/extcon/extcon-arizona.c
>
You should add the description of patch.
If you add the description, looks good to me and you can add my acked tag.
Acked-by: Chanwoo Choi
Thanks,
Chanwoo Choi
--
To un
Roger,
On 2015년 10월 15일 16:16, Roger Quadros wrote:
> Chanwoo,
>
> On 15/10/15 05:22, Chanwoo Choi wrote:
>> Hi Roger,
>>
>> On 2015년 10월 14일 16:13, Roger Quadros wrote:
>>> Chanwoo,
>>>
>>> On 08/10/15 12:24, Chanwoo Choi wrote:
>>
efc8a18ced ("power_supply: Add types for USB chargers")
Signed-off-by: Chanwoo Choi
[ckeepax: For the Arizona changes]
Acked-by: Charles Keepax
---
Changes from v4:
(https://lkml.org/lkml/2015/10/8/159)
- Restore the name of external connector to use the original name
Changes from v3:
(h
Dear Greg,
This is extcon-next full request for v4.4. I add detailed description of this
pull request on below. Please pull extcon with following updates.
Best Regards,
Chanwoo Choi
The following changes since commit 9ffecb10283508260936b96022d4ee43a7798b4c:
Linux 4.3-rc3 (2015-09-27 07:50
Hi Sergei,
I think this patch is too much delay. I recommend you better to develop
this driver based on latest extcon-next branch[1].
[1]
https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/log/?h=extcon-next
Thanks,
Chanwoo Choi
On 2015년 10월 21일 03:20, Sergei Shtylyov wrote
;;
debounce-ms = <50>; /* 50 millisecond */
wakeup-source;
}
&dwc3_usb {
extcon = <&usb_cable>;
};
&charger {
extcon = <&ta_cable>;
};
Signed-off-by: Chanwoo Cho
by: Javier Martinez Canillas
>
> ---
>
> drivers/extcon/extcon-rt8973a.c | 1 +
> drivers/extcon/extcon-sm5502.c | 1 +
> 2 files changed, 2 insertions(+)
Applied it.
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
p; 0x1) != ((new >> idx) & 0x1)) {
> - *attached = new ? true : false;
> + *attached = ((new >> idx) & 0x1) ? true : false;
> return true;
> }
>
>
Applied it.
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send t
>>>> +
>>>> +gpio = of_get_named_gpio(np, "maxim,id-gpio", 0);
>>
>>> Use of_get_gpio() or of_get_gpio_flags().
>>
>> OK, I'll use the first one.
>
>No, I won't due to not being able to use "gpios" anymo
Hi Rob,
First of all, thanks for your review.
On 2015년 10월 22일 07:35, Rob Herring wrote:
> On Tue, Oct 20, 2015 at 11:37 PM, Chanwoo Choi wrote:
>> This patch adds the support for Device tree bindings of extcon-gpio driver.
>> The extcon-gpio device tree node must include the
ARCH_EXYNOS5433)
> + else if (data->soc == SOC_ARCH_EXYNOS5433)
> emul_con = EXYNOS5433_TMU_EMUL_CON;
> else if (data->soc == SOC_ARCH_EXYNOS7)
> emul_con = EXYNOS7_TMU_REG_EMUL_CON;
>
Thanks for your point out. Looks good to me.
Reviewed-
_TA */
extcon-gpio = <&gpio3 2 GPIO_ACTIVE_LOW>;
debounce-ms = <50>; /* 50 millisecond */
wakeup-source;
}
&dwc3_usb {
extcon = <&usb_cable>;
};
&charger {
extcon =
e ("[PATCH] power_supply: Add types for USB chargers")
Signed-off-by: Chanwoo Choi
---
drivers/extcon/extcon-arizona.c | 18 ++--
drivers/extcon/extcon-axp288.c | 12
drivers/extcon/extcon-max14577.c | 18 ++--
drivers/extcon/extcon-max77693.c | 32 +++--
;;
debounce-ms = <50>; /* 50 millisecond */
wakeup-source;
}
&dwc3_usb {
extcon = <&usb_cable>;
};
&charger {
extcon = <&ta_cable>;
};
Signed-off-by: Cha
;;
debounce-ms = <50>; /* 50 millisecond */
wakeup-source;
}
&dwc3_usb {
extcon = <&usb_cable>;
};
&charger {
extcon = <&ta_cable>;
};
Signed-off-by: Chanwoo Choi
-
Hi Roger,
On 2015년 10월 05일 17:26, Roger Quadros wrote:
> Chanwoo,
>
> On 04/10/15 06:45, Chanwoo Choi wrote:
>> This patch modifies the id and name of external connector with the additional
>> prefix to clarify both attribute and meaning of external connector as
>>
Hi Roger,
On 2015년 10월 05일 18:01, Chanwoo Choi wrote:
> Hi Roger,
>
> On 2015년 10월 05일 17:26, Roger Quadros wrote:
>> Chanwoo,
>>
>> On 04/10/15 06:45, Chanwoo Choi wrote:
>>> This patch modifies the id and name of external connector with the
>>> ad
Hi Matthias,
On 2018년 08월 03일 08:13, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote:
>> Hi Matthias,
>>
>> On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote:
>>> Hi Chanwoo,
>>>
>>>
ward, do you
> want me to spin out these two patches so that they can get merged
> independently from the rest of the series?
How about resend the devfreq patches(patch1/2/3/4/6) which don't depend on
throttler core with my reviewed tag? Maybe, it is easy to merge them through
Myungjoo.
Hi Matthias,
On 2018년 07월 12일 17:38, Chanwoo Choi wrote:
> Hi Matthias,
>
> On 2018년 07월 07일 02:07, Matthias Kaehlcke wrote:
>> Hi,
>>
>> On Wed, Jul 04, 2018 at 11:51:30AM +0900, Chanwoo Choi wrote:
>>> Hi,
>>>
>>> On 2018년 07월 04일 08:46
301 - 400 of 3909 matches
Mail list logo
