Re: [reiserfs-list] major security bug in reiserfs (may affect SuSELinux)

2001-01-10 Thread Chris Mason
On Wednesday, January 10, 2001 12:47:17 AM -0500 Alexander Viro [EMAIL PROTECTED] wrote: However, actual code really looks like the end of filldir(). If that's the case we are deep in it - argument of filldir() gets screwed. buf, that is. Since it happens after we've already done

Re: [reiserfs-list] major security bug in reiserfs (may affect SuSE Linux)

2001-01-10 Thread Chris Mason
On Wednesday, January 10, 2001 07:02:08 PM +0300 "Vladimir V. Saveliev" [EMAIL PROTECTED] wrote: Hi Chris Mason wrote: On Wednesday, January 10, 2001 02:32:09 AM +0100 Marc Lehmann [EMAIL PROTECTED] wrote: EIP; c013f911 filldir+20b/221 = Trace; c013f706 fil

Re: [reiserfs-list] major security bug in reiserfs (may affect SuSELinux)

2001-01-10 Thread Chris Mason
On Wednesday, January 10, 2001 12:38:34 PM -0500 Alexander Viro [EMAIL PROTECTED] wrote: On Wed, 10 Jan 2001, Chris Mason wrote: In filldir, I don't like the line where we ((char *)dirent += reclen ; If reclen is much larger than the buffer sent from userspace, I don't see how we stay

Re: Possible deadlock with -writepaged version offlush_dirty_buffers() and 2.4.0

2001-01-11 Thread Chris Mason
On Wednesday, January 10, 2001 05:56:09 PM -0200 Marcelo Tosatti [EMAIL PROTECTED] wrote: Hi Chris, It seems there is a possible deadlock condition with your patch which changes flush_dirty_buffers() to use -writepage (something which we _definately_ want for 2.5). Take a look: Yes,

generic_file_write change in 2.4.0-ac8

2001-01-12 Thread Chris Mason
Hi guys, This code for generic_file_write calls vmtruncate without i_sem held. Is that intentional? It should cause problems for reiserfs at least... -chris diff -u --new-file --recursive --exclude-from /usr/src/exclude linux-2.4.0/mm/filemap.c linux.ac/mm/filemap.c ---

Re: generic_file_write change in 2.4.0-ac8

2001-01-12 Thread Chris Mason
On Friday, January 12, 2001 04:30:44 PM -0500 Alexander Viro [EMAIL PROTECTED] wrote: On Fri, 12 Jan 2001, Chris Mason wrote: Hi guys, This code for generic_file_write calls vmtruncate without i_sem held. Is that intentional? It should cause problems for reiserfs at least

Re: patch:reiserfs 3.6.25 + LVM(Fix oops reiserfs filesystem)

2001-01-15 Thread Chris Mason
On Saturday, January 13, 2001 11:41:51 PM -0800 hugang [EMAIL PROTECTED] wrote: [ patch ] Odd, the create_vi op should never be null, so the real fix is somewhere else. We'll look into this. -chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: More information on reiserfs bug

2001-01-16 Thread Chris Mason
On Tuesday, January 16, 2001 07:38:58 PM +0100 Jakob Borg [EMAIL PROTECTED] wrote: Hi again, It seems the problem occurs every time i start fetchmail... Attached are ksymoops output and .config (if i remember this time). If there is anything else I can do to help debug this, just tell me

Re: kernel BUG with 2.4.1-pre7 reiserfs

2001-01-16 Thread Chris Mason
On Tuesday, January 16, 2001 07:58:37 PM +0100 Jakob Borg [EMAIL PROTECTED] wrote: On Tue, Jan 16, 2001 at 10:36:43AM -0800, Linus Torvalds wrote: I seem to remember more possibly useful information scrolling by my screen, but it seems to not have made it to the logs, and I will shut

Re: Kernel 2.4.x and 2.4.1-preX - Higher latency then 2.2.xkernels?

2001-01-21 Thread Chris Mason
On Saturday, January 20, 2001 02:59:24 PM -0500 Gregory Maxwell [EMAIL PROTECTED] wrote: On Sat, Jan 20, 2001 at 02:50:16PM -0500, Shawn Starr wrote: It just seems that since using 2.4 ive noticed my poor Pentium 200Mhz slow down whether being in X or otherwise. It just seems that the

Re: 2.4.1-pre10 slowdown at boot.

2001-01-25 Thread Chris Mason
On Thursday, January 25, 2001 05:23:26 PM +0100 Ondrej Sury [EMAIL PROTECTED] wrote: 2.4.1-pre10 slows down after printing those (maybe ACPI or reiserfs issue), and even SysRQ-(s,u,b) is not imediate and waits several (two+) seconds before (syncing,remounting,booting). ACPI: System

Re: 2.4.1-pre10 slowdown at boot.

2001-01-25 Thread Chris Mason
On Thursday, January 25, 2001 06:51:33 PM +0100 Ondrej Sury [EMAIL PROTECTED] wrote: Chris Mason [EMAIL PROTECTED] writes: reiserfs: checking transaction log (device 03:04) ... Warning, log replay starting on readonly filesystem Here, reiserfs is telling you that it has started

Re: ACPI error in 2.4.1-pre10 @ via82c686 (Was: 2.4.1-pre10slowdown at boot.)

2001-01-25 Thread Chris Mason
On Thursday, January 25, 2001 07:37:16 PM +0100 Ondrej Sury [EMAIL PROTECTED] wrote: I have discovered that it wasn't reiserfs problem. I have disabled ACPI in BIOS and everything is ok. So I assume that something has changed in ACPI between pre9 and pre10 versions and that something is

Re: Kernel 2.4.x and 2.4.1-preX - Higher latency then 2.2.xkernels?

2001-01-28 Thread Chris Mason
On Sunday, January 28, 2001 02:29:09 PM +1100 Andrew Morton [EMAIL PROTECTED] wrote: Shawn Starr wrote: Andrew, the patch HAS made a difference. For example, while untaring glibc-2.2.1.tar.gz the system was not sluggish (mouse movements in X) etc. Seems to be a go for latency

Re: Renaming lost+found

2001-01-28 Thread Chris Mason
On Friday, January 26, 2001 01:19:49 PM -0500 James Lewis Nance [EMAIL PROTECTED] wrote: FWIW IBM's JFS file system does not have a lost+found directory. I dont remember if reiserfs does or not. reiserfsck creates it. -chris - To unsubscribe from this list: send the line "unsubscribe

Re: Reiserfs problem was: Re: Version 2.4.1 cannot be built.

2001-01-30 Thread Chris Mason
On Tuesday, January 30, 2001 03:42:36 PM -0800 "Brett G. Person" [EMAIL PROTECTED] wrote: Worked fine here but i am getting segfaults on my Reiser filesystems. I've been distracted by a project over the last few days. Is what I'm seeing a symptom of the fs corruption people were talking

Re: reiserfs, xfs, ext2, ext3

2001-05-11 Thread Chris Mason
On Friday, May 11, 2001 01:39:13 AM +0200 Matthias Andree [EMAIL PROTECTED] wrote: On Thu, 10 May 2001, Hans Reiser wrote: Hmm... Reiserfs is incompatible with knfsd? That might explain the we have a patch on our website. I'm always wondering why the patch hasn't been merged. Is it

Re: [reiserfs-dev] Re: reiserfs, xfs, ext2, ext3

2001-05-11 Thread Chris Mason
On Friday, May 11, 2001 12:07:08 PM -0700 Hans Reiser [EMAIL PROTECTED] wrote: Albert D. Cahalan wrote: Hans Reiser writes: Tell us what to code for, and so long as it doesn't involve looking up files by their 32 bit inode numbers we'll probably be happy to code to it. The Neil

Re: [PATCH] writepage method changes

2001-05-10 Thread Chris Mason
On Wednesday, May 09, 2001 10:51:17 PM -0300 Marcelo Tosatti [EMAIL PROTECTED] wrote: On Wed, 9 May 2001, Marcelo Tosatti wrote: Locked for the not wrote out case (I will fix my patch now, thanks) I just found out that there are filesystems (eg reiserfs) which write out data even

Re: [reiserfs-dev] Re: reiserfs, xfs, ext2, ext3

2001-05-13 Thread Chris Mason
On Friday, May 11, 2001 04:00:20 AM -0700 Hans Reiser [EMAIL PROTECTED] wrote: Alan Cox wrote: Are you referring to Neil Brown's nfs operations patch as being as ugly as hell, or something else? Just want to understand what you are saying before arguing. Andi has sent me some

Re: Reiserfs, Mongo and CPU question

2001-05-15 Thread Chris Mason
On Tuesday, May 15, 2001 01:41:01 PM +0200 Ricardo Galli [EMAIL PROTECTED] wrote: Hans and reiserfs developers, the same student of my university (http://www.cs.helsinki.fi/linux/linux-kernel/2001-18/0654.html) was carrying up the mongo benchmarks against reiser, xfs, jfs and ext2

Re: Re[2]: ReiserFS 2.4.4/3.x.0k-pre2

2001-05-15 Thread Chris Mason
On Tuesday, May 15, 2001 02:24:36 PM +0400 Samium Gromoff [EMAIL PROTECTED] wrote: Hello, I`m still experiencing file tail corruptions on subj. And more: after i had restored bblocked patrition (by relying on drive`s ability to remap bblks on write by wroting

Re: Getting FS access events

2001-05-15 Thread Chris Mason
On Tuesday, May 15, 2001 04:33:57 AM -0400 Alexander Viro [EMAIL PROTECTED] wrote: On Tue, 15 May 2001, Linus Torvalds wrote: Looks like there are 19 filesystems that use the buffer cache right now: grep -l bread fs/*/*.c | cut -d/ -f2 | sort -u | wc So quite a bit of work

Re: ReiserFs: Cosmetic problem in linux/Documentation/Changes[2.4.x]

2001-05-18 Thread Chris Mason
On Friday, May 18, 2001 01:26:01 PM +0200 Martin.Knoblauch [EMAIL PROTECTED] wrote: Martin.Knoblauch wrote: Hi, I submitted this a short while ago, only to realize later that the subject line was not very informative. Sorry. As a suggestion: maybe the reiser-tools should support

[PATCH] improve reiserfs 2.4.x O_SYNC and fsync speed

2001-05-12 Thread Chris Mason
Hi guys, This patch has been lightly tested, I'd appreciate it if some of you could try it out on data you don't care about. The idea is to improve fsync and O_SYNC performance by only doing a commit on the last transaction the file was actually involved in. The old code always forced a

Re: Dying disk and filesystem choice.

2001-05-25 Thread Chris Mason
On Friday, May 25, 2001 09:21:42 AM -0700 Hans Reiser [EMAIL PROTECTED] wrote: No, our policy is strictly in sync with and reflective of that of the rest of the linux-kernel. Since the ac series has a different policy, we can be different in regards to the ac series. Not really, our

Re: Dying disk and filesystem choice.

2001-05-25 Thread Chris Mason
On Thursday, May 24, 2001 11:16:58 PM +0100 Alan Cox [EMAIL PROTECTED] wrote: IMHO we are not that deep into code freeze anymore. Freevxfs got added in linux-2.4.5-pre*, so I think that a patch that adds a useful feature like badblock support would be OK. FreeVxFS changes precisely

Re: 2.4.5 Oops at boot

2001-05-30 Thread Chris Mason
On Wednesday, May 30, 2001 03:03:32 PM -0600 D. Stimits [EMAIL PROTECTED] wrote: [ snip ] RAMDISK: Compressed image found at block 0 Freeing initrd memory: 249k freed VFS: Mounted root (ext2 filesystem). Red Hat nash version 3.0.10 starting VFS: Mounted root (ext2 filesystem) readonly.

Re: reiserfs_read_inode2

2001-05-31 Thread Chris Mason
On Thursday, May 31, 2001 02:27:26 PM +0200 Lukasz Trabinski [EMAIL PROTECTED] wrote: Hello What it's means? portraits:~# dmesg vs-13042: reiserfs_read_inode2: [2299 593873 0x0 SD] not found vs-13048: reiserfs_iget: bad_inode. Stat data of (2299 593873) not found vs-13042:

Re: NULL characters in file on ReiserFS again.

2001-05-31 Thread Chris Mason
On Thursday, May 31, 2001 03:33:06 PM +0400 Andrej Borsenkow [EMAIL PROTECTED] wrote: This happened to me yesterday on kernel-2.4.4-6mdk (Mandrake cooker, based on 2.4.4-ac14), single reiser root filesystem, mounted with default options. Hardware - ASUS CUSL2 (i815e chipset), Fujitsu UDMA-4

Re: [RFC] yet another knfsd-reiserfs patch

2001-06-01 Thread Chris Mason
On Monday, April 23, 2001 10:45:14 AM -0400 Chris Mason [EMAIL PROTECTED] wrote: Hi guys, This patch is not meant to replace Neil Brown's knfsd ops stuff, the goal was to whip up something that had a chance of getting into 2.4.x, and that might be usable by the AFS guys too. Neil's

Re: [2.4.5 and all ac-Patches] massive file corruption with reiseror NFS

2001-06-02 Thread Chris Mason
On Saturday, June 02, 2001 02:41:04 PM +0200 Andreas Hartmann [EMAIL PROTECTED] wrote: Am Samstag, 2. Juni 2001 12:52 schrieb Rasmus Bøg Hansen: On Sat, 2 Jun 2001, Andreas Hartmann wrote: I got massive file corruptions with the kernels mentioned in the subject. I can reproduce it every

Re: [NFS] Re: [RFC] yet another knfsd-reiserfs patch

2001-06-02 Thread Chris Mason
On Saturday, June 02, 2001 12:19:59 AM +0200 Trond Myklebust [EMAIL PROTECTED] wrote: Hi Chris, Do you really need the parent inode in the filehandle? That screws rename up pretty badly, since the filehandle changes when you rename into a different directory. It means for instance

Re: [2.4.5 and all ac-Patches] massive file corruption with reiseror NFS

2001-06-02 Thread Chris Mason
On Saturday, June 02, 2001 08:13:44 PM +0200 Andreas Hartmann [EMAIL PROTECTED] wrote: Am Samstag, 2. Juni 2001 18:42 schrieben Sie: On Saturday, June 02, 2001 02:41:04 PM +0200 Andreas Hartmann [EMAIL PROTECTED] wrote: Am Samstag, 2. Juni 2001 12:52 schrieb Rasmus Bøg Hansen: On

Re: 2.4.0-test8-pre1 is quite bad / how about integrating Rik's VMnow?

2000-09-04 Thread Chris Mason
On 9/3/00, 3:20:01 AM, Alexander Viro [EMAIL PROTECTED] wrote regarding Re: 2.4.0-test8-pre1 is quite bad / how about integrating Rik's VM now?: On Sat, 2 Sep 2000, Linus Torvalds wrote: Not at all. In fact, I'd prefer it that way, because this same thing is obviously going to be useful

Re: Still ext2-corruption in test8-pre5 (incl. OOPS)

2000-09-06 Thread Chris Mason
--On 09/05/00 21:35:13 -0400 Chris Mason [EMAIL PROTECTED] wrote: Ok, hopefully this will make sense... __block_commit_write calls balance_dirty, which might wait on bdflush, running all the io on the page. The async_end_io handlers will unlock the page once io on all the buffer heads

Re: More on 2.2.18pre2aa2

2000-09-11 Thread Chris Mason
--On 09/11/00 07:45:16 -0400 Ed Tomlinson [EMAIL PROTECTED] wrote: Hi Chris, Something between bigmem and his big VM changes makes reiserfs uncompilable. [..] It's due LFS. Chris should have a reiserfs patch that compiles on top of 2.2.18pre2aa2, right? (if not Chris, I can sure find it

Re: The INN/mmap bug

2000-09-18 Thread Chris Mason
--On 09/17/00 20:30:29 -0700 Linus Torvalds [EMAIL PROTECTED] wrote: Basically, both "truncate()" and "write()" have this bug where they can end up re-reading stuff from disk even though the in-memory copy is newer. And because write() had this bug, the bug also got into

Re: The INN/mmap bug

2000-09-18 Thread Chris Mason
--On 09/18/00 13:19:27 -0400 Alexander Viro [EMAIL PROTECTED] wrote: On Mon, 18 Sep 2000, Chris Mason wrote: I'm not trying to put it all into a single get_block call, we have different get_block funcs for different purposes. What I'm really trying to do is squeeze

Re: [patchlet] Removing unneeded line in vmtruncate() (2.4.0-t8p1)

2000-09-05 Thread Chris Mason
On 9/5/00, 5:26:29 AM, Daniel Phillips wrote Alexander Viro wrote: On Fri, 1 Sep 2000, Tigran Aivazian wrote: Rasmus, you introduced a bug because you removed the code but left the comment around. now /* this should go into -truncate */ is there and very confusing - what

Re: [OOPS] 2.4.0-test10-pre1 and ReiserFS 3.6.17

2000-10-23 Thread Chris Mason
--On 10/12/00 00:24:48 +0200 Dewet Diener [EMAIL PROTECTED] wrote: Just experienced the following Oops: It's reproducible, the offender being netscape 4.75. Reverting back to 2.4.0-test9 fixes the problem. Both kernels were compiled with the same config. Do you have highmem turned on?

Re: reiserfs problem

2001-02-23 Thread Chris Mason
On Friday, February 23, 2001 05:03:40 PM + Patrick Mackinlay [EMAIL PROTECTED] wrote: When 2.4.1 was released I reported a kernel oops with reiserfs, I got no response. Hmmm, don't seem to have any other reiserfs mail from you. Sorry I missed it. [ ...] kernel oops report: EIP;

Re: reiserfs: still problems with tail conversion

2001-02-23 Thread Chris Mason
On Friday, February 23, 2001 10:18:56 PM +0100 Erik Mouw [EMAIL PROTECTED] wrote: Hi all, I am running linux-2.4.2-pre4 with Chris Mason's tailconversion bug fix applied, but I still have problems with null bytes in files. I wrote a little test program that clearly shows the problem:

Re: reiserfs: still problems with tail conversion

2001-02-24 Thread Chris Mason
On Saturday, February 24, 2001 04:45:04 PM +0100 Arjan Filius [EMAIL PROTECTED] wrote: Hello, I tried Erik's trigger-program. After some test i thing it's memory related, and it seems to match the other reports i saw on lkm. With my 384M ram i was not able te reproduce it. With

Re: reiserfs: still problems with tail conversion

2001-02-24 Thread Chris Mason
On Saturday, February 24, 2001 08:53:15 PM + Alan Cox [EMAIL PROTECTED] wrote: 32Mb. The test results vary depending on what else is on the partition, but in each case the last file affected is 01017 and there are sequences of previous_number+4, for up to 8 files (but next file after

Re: reiserfs: still problems with tail conversion

2001-02-25 Thread Chris Mason
Ok, found it. It is related to the last null byte problem in that it also only happens when the direct item is split between two blocks. This is more likely as the tail increases in size, which is why you saw it on larger small files. The bug is in the code that zeros the unused part of the

[PATCH] Re: reiserfs: still problems with tail conversion

2001-02-25 Thread Chris Mason
Hi guys, This patch should take care of the other cause for null bytes in small files. It has been through a few hours of testing, with some of the usual load programs + Erik's code concurrently. I'll let things run overnight to try and find more bugs. The patch is against 2.4.2, and does a

Re: [CFT][PATCH] Re: fat problem in 2.4.2

2001-03-01 Thread Chris Mason
On Thursday, March 01, 2001 12:05:50 PM -0800 Linus Torvalds [EMAIL PROTECTED] wrote: In article [EMAIL PROTECTED], Alexander Viro [EMAIL PROTECTED] wrote: Alan, fix is really quite simple. Especially if you have vmtruncate() returning int (ac1 used to do it, I didn't check later ones).

[PATCH] Documentation/filesystems/Locking

2001-03-02 Thread Chris Mason
filesystems need to grab the bkl on their own for fsync now: -chris --- linux/Documentation/filesystems/Locking.1 Fri Mar 2 11:20:18 2001 +++ linux/Documentation/filesystems/Locking Fri Mar 2 11:21:10 2001 @@ -229,7 +229,7 @@ open: maybe (see below) flush: yes

Re: scsi vs ide performance on fsync's

2001-03-02 Thread Chris Mason
On Friday, March 02, 2001 12:39:01 PM -0600 Steve Lord [EMAIL PROTECTED] wrote: [ file_fsync syncs all dirty buffers on the FS ] So it looks like fsync is going to cost more for bigger devices. Given the O_SYNC changes Stephen Tweedie did, couldnt fsync look more like this:

Re: scsi vs ide performance on fsync's

2001-03-02 Thread Chris Mason
On Friday, March 02, 2001 01:25:25 PM -0600 Steve Lord [EMAIL PROTECTED] wrote: For why ide is beating scsi in this benchmark...make sure tagged queueing is on (or increase the queue length?). For the xlog.c test posted, I would expect scsi to get faster than ide as the size of the write

Re: Kernel crash - reboot or hang

2001-03-08 Thread Chris Mason
On Thursday, March 08, 2001 04:17:23 PM +0200 Mircea Damian [EMAIL PROTECTED] wrote: Hello, I NEED TO TRACE THIS!!! I had two crashes with 2.4.2 and 2.4.2-pre2 on my local SMTP/POP3/SAMBA/WWW server (once under some load and the second one - with 2.4.2-pre2 - while it was almost

Re: 2.4.2-acX and reiserfs

2001-03-08 Thread Chris Mason
On Thursday, March 08, 2001 08:36:51 AM -0100 "[EMAIL PROTECTED]" [EMAIL PROTECTED] wrote: I'm 99.9% certain that those patches referred to have been merged with the latest 2.4.2-acX, but just to make it 100% certain I'm asking this question. At www.namesys.com, the reiserfs website, I

Re: scsi vs ide performance on fsync's

2001-03-08 Thread Chris Mason
On Wednesday, March 07, 2001 08:56:59 PM + "Stephen C. Tweedie" [EMAIL PROTECTED] wrote: Hi, On Wed, Mar 07, 2001 at 09:15:36PM +0100, Jens Axboe wrote: On Wed, Mar 07 2001, Stephen C. Tweedie wrote: For most fs'es, that's not an issue. The fs won't start writeback on the

2.4.2-ac calls FS truncate w/o BKL

2001-03-09 Thread Chris Mason
The added vmtruncate calls in the ac series trigger calls to the FS truncate without the BKL held. Easy enough to fix on the reiserfs side, but if other filesystems care we might want to change vmtruncate to grab the lock before calling truncate (and update the Locking doc ;-) -chris - To

Re: reiserfs-oops; kernel 2.4.3-pre4

2001-03-15 Thread Chris Mason
On Thursday, March 15, 2001 02:00:11 PM +0100 Andreas Klein [EMAIL PROTECTED] wrote: [ oops ] EIP; c016f090 comp_short_keys+10/40 = Trace; c0160046 reiserfs_iget+6a/a4 Trace; c015c8a8 reiserfs_lookup+94/c4 The machine is running linux-2.4.3-pre4 including the reiserfs-patches from

Re: [OOPS] report

2001-03-15 Thread Chris Mason
On Thursday, March 15, 2001 09:44:48 PM -0500 Alexander Viro [EMAIL PROTECTED] wrote: On Thu, 15 Mar 2001, David wrote: 2.4.2-ac4 Mar 15 18:02:49 Huntington-Beach kernel: end_request: I/O error, dev 16:41 (hdd), sector 9512 Mar 15 18:02:49 Huntington-Beach kernel: hdd: drive not

Re: [OOPS] report

2001-03-15 Thread Chris Mason
On Friday, March 16, 2001 01:03:20 AM -0500 Alexander Viro [EMAIL PROTECTED] wrote: Ok, I was more talking about the ugliness that is reiserfs_panic (how many times do we need a commented out for(;;)?). For panic() calling sys_sync, I think there non-filesystem related panics where we do

[PATCH] reiserfs tail bugs

2001-03-19 Thread Chris Mason
Hello everyone, This patch should close out the last known tail bug in my queue. If you've still got small reiserfs files with the wrong data in them, please start shouting. The patch isn't very big, but changes some sensitive areas, so I'm looking for more success reports on non-critical

Re: [reiserfs-list] VFS: brelse message in syslog, its due toReiserFS or kernel failure ?

2000-11-28 Thread Chris Mason
On Tuesday, November 28, 2000 14:29:34 +0100 Blizbor [EMAIL PROTECTED] wrote: Machine: P3 500 on ASUS P2B, WD 15GB IDE drive. System RH7 with upgraded glibc. When I'm using 2.2.17 with ReiserFS: Nov 26 00:05:05 localhost kernel: Linux version 2.2.17 ([EMAIL PROTECTED]) (gcc version

Re: Test12 ll_rw_block error.

2000-12-15 Thread Chris Mason
On Fri, 15 Dec 2000, Alexander Viro wrote: Just one: any fs that really cares about completion callback is very likely to be picky about the requests ordering. So sync_buffers() is very unlikely to be useful anyway. Somewhat. I guess there are at least two ways to do it. First flush the

Re: 2.4.0 + reiserfs + smp

2000-12-15 Thread Chris Mason
On Fri, 15 Dec 2000, David D.W. Downey wrote: I've been reading the thread regarding data corruption with 2.4.0-test12, reiserfs, and smp. Unfrotunately I've not seen any resolution announced about this. Is this still an issue or has this been fixed? reiserfs and test12 won't play

Re: [lkml]Re: VM problems still in 2.2.18

2000-12-16 Thread Chris Mason
On Fri, 15 Dec 2000, Alan Cox wrote: Yes, the same `current' context must run the down/up pair of calls and as you said it is legal to rely on it on all the places it's used. I assume thats not an issue to reiserfs ? I don't think so. There are two places reiserfs calls down/up. In

Re: Test12 ll_rw_block error.

2000-12-16 Thread Chris Mason
On Fri, 15 Dec 2000, Linus Torvalds wrote: [ writepage for anon buffers ] It might be 10 lines of change, and obviously correct. I'll give this a try, it will be interesting regardless of if it is simple enough for kernel inclusion. On a related note, I hit a snag porting reiserfs into

Re: Test12 ll_rw_block error.

2000-12-16 Thread Chris Mason
On Sat, 16 Dec 2000, Linus Torvalds wrote: Your patch looks fine, although I'd personally prefer this one even more: Yes, that looks better and works here. -chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please

Re: Test12 ll_rw_block error.

2000-12-17 Thread Chris Mason
On Sat, 16 Dec 2000, Russell Cattelan wrote: I'm curious about this. Does the mean reiserFS is doing all of it's own buffer management? This would seem a little redundant with what is already in the kernel? For metadata only reiserfs does its own write management. The buffers come

[PATCH] export submit_bh

2000-12-18 Thread Chris Mason
Hello everyone, Following patch against test13pre3 will export submit_bh, which reiserfs needs to work as a module. Seems like others would need it too... -chris --- linux-test13-3/kernel/ksyms.c.1 Tue Dec 19 05:08:37 2000 +++ linux-test13-3/kernel/ksyms.c Tue Dec 19 05:05:07 2000

Re: [2.2.18] VM: do_try_to_free_pages failed

2000-12-20 Thread Chris Mason
On Wednesday, December 20, 2000 13:03:00 +0100 Matthias Andree [EMAIL PROTECTED] wrote: Last night, one of your production machines got wedged, I caught a lot of kernel: VM: do_try_to_free_pages failed for ... for a whole range of processes, among them ypbind, klogd, syslogd, xntpd, cron,

[RFC] changes to buffer.c (was Test12 ll_rw_block error)

2000-12-21 Thread Chris Mason
Ok guys, I think I've taken Linus' suggestion to have buffer.c use its own writepage a bit too far. This patch marks pages dirty when the buffer head is marked dirty, and changes flush_dirty_buffers and sync_buffers to use writepage instead of ll_rw_block. The idea is to allow filesystems

Re: [RFC] changes to buffer.c (was Test12 ll_rw_block error)

2000-12-22 Thread Chris Mason
On Thursday, December 21, 2000 20:54:09 -0500 Alexander Viro [EMAIL PROTECTED] wrote: On Thu, 21 Dec 2000, Chris Mason wrote: Obvious bug, block_write_full_page zeros out the bits past the end of file every time. This should not be needed for normal file writes. Unfortunately

Re: [RFC] changes to buffer.c (was Test12 ll_rw_block error)

2000-12-22 Thread Chris Mason
On Thursday, December 21, 2000 22:38:04 -0200 Marcelo Tosatti [EMAIL PROTECTED] wrote: On Thu, 21 Dec 2000, Andreas Dilger wrote: Marcelo Tosatti writes: It seems your code has a problem with bh flush time. In flush_dirty_buffers(), a buffer may (if being called from kupdate)

Re: [RFC] changes to buffer.c (was Test12 ll_rw_block error)

2000-12-22 Thread Chris Mason
On Thursday, December 21, 2000 22:38:04 -0200 Marcelo Tosatti [EMAIL PROTECTED] wrote: Marcelo Tosatti writes: It seems your code has a problem with bh flush time. In flush_dirty_buffers(), a buffer may (if being called from kupdate) only be written in case its old enough.

Re: [RFC] changes to buffer.c (was Test12 ll_rw_block error)

2000-12-22 Thread Chris Mason
On Friday, December 22, 2000 17:45:57 +0100 Daniel Phillips [EMAIL PROTECTED] wrote: [ flushing a page at a time in bdflush ] Um. Why cater to the uncommon case of 1K blocks? Just let bdflush/kupdated deal with them in the normal way - it's pretty efficient. Only try to do the

Re: [RFC] changes to buffer.c (was Test12 ll_rw_block error)

2000-12-22 Thread Chris Mason
On Friday, December 22, 2000 17:52:28 -0200 Marcelo Tosatti [EMAIL PROTECTED] wrote: There is one more nasty issue to deal with. You only want to take into account the buffer flushtime if "check_flushtime" parameter is passed as true to flush_dirty_buffers (which is done by kupdate).

Re: [RFC] changes to buffer.c (was Test12 ll_rw_block error)

2000-12-23 Thread Chris Mason
On Friday, December 22, 2000 21:26:33 -0200 Marcelo Tosatti If we use ll_rw_block directly on buffers of anonymous pages (page-mapping == anon_space_mapping) instead using dirty_list_writepage() (which will end up calling block_write_anon_page) we can fix the buffer flushtime issue. Ok,

Re: [RFC] changes to buffer.c (was Test12 ll_rw_block error)

2000-12-23 Thread Chris Mason
On Saturday, December 23, 2000 11:02:53 -0800 Linus Torvalds [EMAIL PROTECTED] wrote: Which is why I prefer the higher layers handling the dirty/uptodate/xxx bits. Grin, I should have taken the hint when we talked about the buffer up to date checks for block_read_full_page, it made sense

Re: [RFC] changes to buffer.c (was Test12 ll_rw_block error)

2000-12-26 Thread Chris Mason
Hi guys, Here's my latest code, which uses ll_rw_block for anon pages (or pages without a writepage func) when flush_dirty_buffers, sync_buffers, or fsync_inode_buffers are flushing things. This seems to have fixed my slowdown on 1k buffer sizes, but I haven't done extensive benchmarks yet.

Re: [RFC] changes to buffer.c (was Test12 ll_rw_block error)

2000-12-27 Thread Chris Mason
On Wednesday, December 27, 2000 21:26:02 +0100 Daniel Phillips [EMAIL PROTECTED] wrote: Hi Chris. I took your patch for a test drive under dbench and it seems impressively stable under load, but there are performance problems. Test machine: 64 meg, 500 Mhz K6, IDE, Ext2,

Re: innd mmap bug in 2.4.0-test12

2000-12-28 Thread Chris Mason
On Thursday, December 28, 2000 16:15:48 +0100 Daniel Phillips [EMAIL PROTECTED] wrote: On Thu, 28 Dec 2000, Rik van Riel wrote: On Thu, 28 Dec 2000, Daniel Phillips wrote: It's logical that PageDirty should never be get for ramfs, No. Not setting PageDirty will cause the system to

Re: innd mmap bug in 2.4.0-test12

2000-12-28 Thread Chris Mason
On Thursday, December 28, 2000 15:51:24 -0200 Rik van Riel [EMAIL PROTECTED] wrote: On Thu, 28 Dec 2000, Chris Mason wrote: I think a dirty page without a writepage func seems a bit broken. How about we give ramfs a writepage func that just returns 1. That way nobody does any special

Re: [RFC] changes to buffer.c (was Test12 ll_rw_block error)

2000-12-28 Thread Chris Mason
On Thursday, December 28, 2000 16:49:14 +0100 Daniel Phillips [EMAIL PROTECTED] wrote: [ dbench 48 test on the anon space mapping patch ] This benchmark doesn't seem to suffer a lot from noise, so the 7% slowdown with your patch likely real. Ok, page_launder is supposed to run through

Re: [RFC] changes to buffer.c (was Test12 ll_rw_block error)

2000-12-29 Thread Chris Mason
On Thursday, December 28, 2000 11:29:01 AM -0800 Linus Torvalds [EMAIL PROTECTED] wrote: [ skipping io on the first walk in page_launder ] There are some arguments for starting the writeout early, but there are tons of arguments against it too (the main one being "avoid doing IO if you can

Re: [RFC] changes to buffer.c (was Test12 ll_rw_block error)

2001-01-02 Thread Chris Mason
On Friday, December 29, 2000 06:58:01 PM +0100 Daniel Phillips [EMAIL PROTECTED] wrote: Chris Mason wrote: BTW, the last anon space mapping patch I sent also works on test13-pre5. The block_truncate_page fix does help my patch, since I have bdflush locking pages ( thanks Marcelo ) Yes

Re: [RFC] Generic deferred file writing

2001-01-02 Thread Chris Mason
On Saturday, December 30, 2000 06:28:39 PM -0800 Linus Torvalds [EMAIL PROTECTED] wrote: There are only two real advantages to deferred writing: - not having to do get_block() at all for temp-files, as we never have to do the allocation if we end up removing the file. NOTE NOTE

Re: [PATCH] filemap_fdatasync related changes

2001-01-03 Thread Chris Mason
Hi guys, Just noticed the filemap_fdatasync code doesn't check the return value from writepage. Linus, would you take a patch that redirtied the page, puts it back onto the dirty list (at the tail), and unlocks the page when writepage returns 1? That would loop forever if the writepage func

Re: [PATCH] filemap_fdatasync related changes

2001-01-03 Thread Chris Mason
On Wednesday, January 03, 2001 10:28:05 AM -0800 Linus Torvalds [EMAIL PROTECTED] wrote: On Wed, 3 Jan 2001, Chris Mason wrote: Just noticed the filemap_fdatasync code doesn't check the return value from writepage. Linus, would you take a patch that redirtied the page, puts it back

Re: [PATCH] filemap_fdatasync related changes

2001-01-04 Thread Chris Mason
On Thursday, January 04, 2001 10:48:13 AM +0100 Christoph Rohland [EMAIL PROTECTED] wrote: Chris Mason [EMAIL PROTECTED] writes: Just noticed the filemap_fdatasync code doesn't check the return value from writepage. Linus, would you take a patch that redirtied the page, puts it back onto

Re: [PATCH] filemap_fdatasync related changes

2001-01-04 Thread Chris Mason
Ok, lets just fix filemap_fdatasync. We can tackle the msync/fsync interaction with screwed up FS writepages later, since all of the existing writepage funcs are safe. The problems I see with filemap_fdatasync when writepage returns 1: The page dirty bit is not reset. the page is never

[PATCH] fsync on unmounting root

2001-01-04 Thread Chris Mason
Hi guys, Looks like the prerelease, and at least test13 don't fsync the device when someone does an unmount on / mount -o remount works, just unmounting the root misses the fsync. This patch works for me: -chris --- linux/fs/super.c.1 Thu Jan 4 13:38:55 2001 +++ linux/fs/super.cThu Jan

Re: [PATCH] fsync on unmounting root

2001-01-04 Thread Chris Mason
On Thursday, January 04, 2001 01:58:47 PM -0500 Alexander Viro [EMAIL PROTECTED] wrote: On Thu, 4 Jan 2001, Chris Mason wrote: Looks like the prerelease, and at least test13 don't fsync the device when someone does an unmount on / mount -o remount works, just unmounting the root misses

reiserfs patch for 2.4.0-prerelease

2001-01-04 Thread Chris Mason
Hello everyone, This patch is meant to be applied on top of the reiserfs 3.6.23 patch to get everything working in the new prerelease kernels. The order is: untar linux-2.4.0-prerelease.tar.bz2 apply linux-2.4.0-test12-reiserfs-3.6.23.gz apply this patch apply the fs/super.c patch to make sure

Re: reiserfs patch for 2.4.0-final

2001-01-05 Thread Chris Mason
On Friday, January 05, 2001 02:04:08 PM +0100 Claas Langbehn [EMAIL PROTECTED] wrote: On Thu, Jan 04, 2001 at 04:52:49PM -0500, Chris Mason wrote: This patch is meant to be applied on top of the reiserfs 3.6.23 patch to get everything working in the new prerelease kernels. The order

Re: [RFC] changes to buffer.c (was Test12 ll_rw_block error)

2001-01-05 Thread Chris Mason
On Friday, January 05, 2001 01:43:07 PM -0200 Marcelo Tosatti [EMAIL PROTECTED] wrote: On Fri, 5 Jan 2001, Chris Mason wrote: Here's the latest version of the patch, against 2.4.0. The biggest open issues are what to do with bdflush, since page_launder could do everything bdflush

Re: Journaling: Surviving or allowing unclean shutdown?

2001-01-06 Thread Chris Mason
block in the journal, one should take the newest one that can be found in the last commited transaction. IMHO Chris Mason already wrote such code, at least he talked about it... Talked about it, but never wrote it. However, I know there was code to do this for grub, I'm not sure if it ever

Re: Oops in 2.4.0-ac2

2001-01-06 Thread Chris Mason
On Sunday, January 07, 2001 03:48:41 AM +0100 Daniel Phillips [EMAIL PROTECTED] wrote: A null buffer was passed by kupdate_one_transaction (looks like a Reiserfs function) to __refile_buffer. Chris? Known bug, there should be another reiserfs release soon that includes the fix. The

Re: ramfs problem... (unlink of sparse file in D state)

2001-01-08 Thread Chris Mason
On Monday, January 08, 2001 09:02:46 AM -0500 Alexander Viro [EMAIL PROTECTED] wrote: Alan, consider applying the patch below. Contents: [snip] + do { + if (buffer_mapped(bh)) { + bh-b_end_io = end_buffer_io_async; +

Re: ramfs problem... (unlink of sparse file in D state)

2001-01-08 Thread Chris Mason
On Monday, January 08, 2001 10:47:41 AM -0500 Alexander Viro [EMAIL PROTECTED] wrote: + do { + if (buffer_mapped(bh)) { + bh-b_end_io = end_buffer_io_async; + atomic_inc(bh-b_count); + set_bit(BH_Uptodate,

Re: [reiserfs-list] major security bug in reiserfs (may affect SuSE Linux)

2001-01-09 Thread Chris Mason
On Wednesday, January 10, 2001 02:32:09 AM +0100 Marc Lehmann [EMAIL PROTECTED] wrote: EIP; c013f911 filldir+20b/221 = Trace; c013f706 filldir+0/221 Trace; c0136e01 reiserfs_getblk+2a/16d The buffer reiserfs is sending to filldir is big enough for the huge file name, so I think the

Re: [reiserfs-list] major security bug in reiserfs (may affect SuSE Linux)

2001-01-09 Thread Chris Mason
On Wednesday, January 10, 2001 02:32:09 AM +0100 Marc Lehmann [EMAIL PROTECTED] wrote: EIP; c013f911 filldir+20b/221 = Trace; c013f706 filldir+0/221 Trace; c0136e01 reiserfs_getblk+2a/16d Here is a patch against our 2.4 code (3.6.25) that does the same as the patch posted for

Re: [reiserfs-list] major security bug in reiserfs (may affect SuSELinux)

2001-01-09 Thread Chris Mason
On Wednesday, January 10, 2001 12:42:01 AM +0100 Marc Lehmann [EMAIL PROTECTED] wrote: We are still investigating, but there seems to be a major security problem in at least some versions of reiserfs. Since reiserfs is shipped with newer versions of SuSE Linux and the problem is too easy to

  1   2   3   4   5   6   7   8   9   10   >