Re: [PATCH 4/5] KVM: add __kvm_request_needs_mb

2017-02-22 Thread Christian Borntraeger
On 02/22/2017 04:17 PM, Radim Krčmář wrote: > [...] > while (vcpu->arch.sie_block->prog0c & PROG_IN_SIE) > cpu_relax(); >} > And out of curiosity -- how many cycles does this loop usually take? A quick hack indicates something between 3 and 700ns. >> 2. Remote requests

v4.11-rc0: WARNING at kernel/sched/sched.h:812 set_next_entity on cpu hot(un)plug

2017-02-24 Thread Christian Borntraeger
While doing cpu hotunplug on s390 I got the following warning which indicates that Matts new check is either broken or finds real bugs. [ 190.608421] rq->clock_update_flags < RQCF_ACT_SKIP [ 190.608427] [ cut here ] [ 190.608434] WARNING: CPU: 29 PID: 153 at kernel/sch

Re: [PATCH] KVM: race-free exit from KVM_RUN without POSIX signals

2017-02-15 Thread Christian Borntraeger
On 02/15/2017 03:43 PM, Paolo Bonzini wrote: > The purpose of the KVM_SET_SIGNAL_MASK API is to let userspace "kick" > a VCPU out of KVM_RUN through a POSIX signal. A signal is attached > to a dummy signal handler; by blocking the signal outside KVM_RUN and > unblocking it inside, this possible ra

Re: [RFC] kasan stack overflow warnings again: READ_ONCE(), typecheck()

2017-02-15 Thread Christian Borntraeger
On 02/15/2017 05:18 PM, Christian Borntraeger wrote: > On 02/15/2017 12:03 AM, Arnd Bergmann wrote: >> >> -#define WRITE_ONCE(x, val) \ >> -({ \ >> -union { typeof(x) __val; char __c[1]; } __u = \ >> -

Re: [RFC] kasan stack overflow warnings again: READ_ONCE(), typecheck()

2017-02-15 Thread Christian Borntraeger
On 02/15/2017 12:03 AM, Arnd Bergmann wrote: > > -#define WRITE_ONCE(x, val) \ > -({ \ > - union { typeof(x) __val; char __c[1]; } __u = \ > - { .__val = (__force typeof(x)) (val) }; \ > - __write_once_size(&(x), __u.__c, size

Re: [PATCH 4/5] KVM: add __kvm_request_needs_mb

2017-02-17 Thread Christian Borntraeger
On 02/16/2017 08:49 PM, David Hildenbrand wrote: > Am 16.02.2017 um 17:04 schrieb Radim Krčmář: >> A macro to optimize requests that do not need a memory barrier because >> they have no dependencies. An architecture can implement a function >> that says which requests do not need memory barriers w

Re: [PATCH 4/5] KVM: add __kvm_request_needs_mb

2017-02-17 Thread Christian Borntraeger
On 02/17/2017 11:13 AM, David Hildenbrand wrote: > >>> This is really complicated stuff, and the basic reason for it (if I >>> remember correctly) is that s390x does reenable all interrupts when >>> entering the sie (see kvm-s390.c:__vcpu_run()). So the fancy smp-based >>> kicks don't work (as it

Re: [PATCH 4/5] KVM: add __kvm_request_needs_mb

2017-02-17 Thread Christian Borntraeger
On 02/17/2017 11:13 AM, David Hildenbrand wrote: > >>> This is really complicated stuff, and the basic reason for it (if I >>> remember correctly) is that s390x does reenable all interrupts when >>> entering the sie (see kvm-s390.c:__vcpu_run()). So the fancy smp-based >>> kicks don't work (as it

Re: [RFC PATCH] KVM: race-free exit from KVM_RUN without POSIX signals

2017-02-08 Thread Christian Borntraeger
On 02/08/2017 12:10 PM, Paolo Bonzini wrote: > The purpose of the KVM_SET_SIGNAL_MASK API is to let userspace "kick" > a VCPU out of KVM_RUN through a POSIX signal. A signal is attached > to a dummy signal handler; by blocking the signal outside KVM_RUN and > unblocking it inside, this possible ra

Re: [PATCH v8 1/1] crypto: add virtio-crypto driver

2017-01-12 Thread Christian Borntraeger
On 01/10/2017 01:56 PM, Christian Borntraeger wrote: > On 01/10/2017 01:36 PM, Gonglei (Arei) wrote: >> Hi, >> >>> >>> On 12/15/2016 03:03 AM, Gonglei wrote: >>> [...] >>>> + >>>> +static struct crypto_alg virtio_crypto_alg

Re: [PATCH 5/6] treewide: use kv[mz]alloc* rather than opencoded variants

2017-01-12 Thread Christian Borntraeger
) > - keys = vmalloc(sizeof(uint8_t) * args->count); > + keys = kvmalloc(sizeof(uint8_t) * args->count, GFP_KERNEL); > if (!keys) > return -ENOMEM; KVM/s390 parts Acked-by: Christian Borntraeger

Re: [PATCH v1 1/1] mm/ksm: improve deduplication of zero pages with colouring

2017-01-12 Thread Christian Borntraeger
On 01/12/2017 05:17 PM, Claudio Imbrenda wrote: > Some architectures have a set of zero pages (coloured zero pages) > instead of only one zero page, in order to improve the cache > performance. In those cases, the kernel samepage merger (KSM) would > merge all the allocated pages that happen to be

Re: [PATCH 0904/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Christian Borntraeger
In general, I find sending 1285 patches to lkml unfriendly without doing a precheck if the general idea is good. This is especially true as you did NOT provide a cover letter that would allow to hide this thread on lkml. Regarding this particular patch, I do not really like this change, as I find

Re: [GIT PULL] KVM changes for 4.8 merge window

2016-08-02 Thread Christian Borntraeger
On 08/02/2016 02:37 PM, Paolo Bonzini wrote: [snip] lots of conflicts all over the place [snip] looks like all architectures collected their merge conflicts for a year in one release... > - arch/s390: also messy. First is hypfs_diag.c where the KVM tree > moved some code and the s390 tree patc

Re: [GIT PULL] KVM changes for 4.8 merge window

2016-08-02 Thread Christian Borntraeger
On 08/02/2016 10:17 PM, Linus Torvalds wrote: > On Tue, Aug 2, 2016 at 2:42 PM, Linus Torvalds > wrote: >> >> No, I don't use the merge from linux-next directly. I just re-generate >> the merge myself, and if the pull request then includes a merge >> resolution (either as just a verbal description

Re: [PATCH] KVM: s390: fix build failure

2016-06-07 Thread Christian Borntraeger
On 06/07/2016 11:49 PM, Sudip Mukherjee wrote: > etr_ptff definitions are moved and renamed but we missed updating them > here and as a result s390 defconfig and allmodconfig was failing with > the error: > arch/s390/kvm/kvm-s390.c:230:45: error: 'ETR_PTFF_QAF' undeclared > > Fixes: cc8f94656487 (

Re: [Ksummit-discuss] 2016 Kernel Summit Planning Kickoff

2016-07-08 Thread Christian Borntraeger
On 07/08/2016 06:41 PM, Theodore Ts'o wrote: > Kernel Summit Planning Kickoff >Call for Topics / Attendees > > > The 16th annual Kernel Summit will be held October 31st through > November the 2nd, 2016, in Santa Fe, New Mexico, overlapping with the > Linux Pl

Re: [PATCH] virtio_balloon: fix PFN format for virtio-1

2016-06-13 Thread Christian Borntraeger
On 05/18/2016 02:38 PM, Michael S. Tsirkin wrote: > Everything should be LE when using virtio-1, but > the linux balloon driver does not seem to care about that. > > Cc: sta...@vger.kernel.org > Reported-by: Cornelia Huck > Signed-off-by: Michael S. Tsirkin The final commit in Linus tree does n

Re: [PATCH 0/3] KVM: do not use kvm->online_vcpus to check "has one VCPU been created?"

2016-06-13 Thread Christian Borntraeger
On 06/13/2016 03:25 PM, Paolo Bonzini wrote: > kvm->online_vcpus is only updated at the very end of KVM_CREATE_VCPU. > Thus, it can be racy to use it as a check for "has any VCPU been created > already?". While x86 detects the race through kvm_vcpu_compatible, > it is kinda hackish and s390 does n

Re: [PATCH] virtio_balloon: fix PFN format for virtio-1

2016-06-13 Thread Christian Borntraeger
On 06/13/2016 08:35 PM, Greg KH wrote: > On Mon, Jun 13, 2016 at 09:08:44PM +0300, Michael S. Tsirkin wrote: >> On Wed, May 18, 2016 at 03:38:53PM +0300, Michael S. Tsirkin wrote: >>> Everything should be LE when using virtio-1, but >>> the linux balloon driver does not seem to care about that. >>>

4.7-rc1/s390: WARNING: CPU: 5 PID: 1 at kernel/events/core.c:8485 perf_pmu_register+0x420/0x428

2016-06-06 Thread Christian Borntraeger
Peter, Hendrik, commit 26657848502b ("perf/core: Verify we have a single perf_hw_context PMU") seems to trigger the newly created warning on a z196. [2.202363] [ cut here ] [2.202372] WARNING: CPU: 5 PID: 1 at kernel/events/core.c:8485 perf_pmu_register+0x420/0

Re: 4.7-rc1/s390: WARNING: CPU: 5 PID: 1 at kernel/events/core.c:8485 perf_pmu_register+0x420/0x428

2016-06-06 Thread Christian Borntraeger
On 06/06/2016 12:29 PM, Peter Zijlstra wrote: > On Mon, Jun 06, 2016 at 11:29:36AM +0200, Hendrik Brueckner wrote: > Looks like perf_pmu_register does not like to be called twice (once for the counter and once for the sampling facility). >>> >>> Twice isn't the problem per se, its

Re: [PATCH v5 4/7] introduce post-init read-only memory

2016-03-07 Thread Christian Borntraeger
On 02/17/2016 11:41 PM, Kees Cook wrote: > One of the easiest ways to protect the kernel from attack is to reduce > the internal attack surface exposed when a "write" flaw is available. By > making as much of the kernel read-only as possible, we reduce the > attack surface. > > Many things are wri

Re: [RFC][PATCH] s390, postinit-readonly: implement post-init RO

2016-03-08 Thread Christian Borntraeger
On 03/08/2016 01:41 AM, Kees Cook wrote: >> --- a/arch/s390/kernel/vmlinux.lds.S >> +++ b/arch/s390/kernel/vmlinux.lds.S >> @@ -52,6 +52,12 @@ SECTIONS >> >> RW_DATA_SECTION(0x100, PAGE_SIZE, THREAD_SIZE) >> >> + . = ALIGN(PAGE_SIZE) missing ";" ? With that and your fixes, this

Re: [RFC PATCH 0/4] cgroup aware workqueues

2016-03-21 Thread Christian Borntraeger
On 03/18/2016 11:14 PM, Bandan Das wrote: [..] > Netperf: > Two guests running netperf in parallel. > Without patches With patches > > TCP_STREAM (10^6 bits/second) 975.45 978.88 > TCP_RR (Trans/second)

Re: [PATCH v2 2/5] mm/slub: query dynamic DEBUG_PAGEALLOC setting

2016-02-11 Thread Christian Borntraeger
p code, per Christian. > > Signed-off-by: Joonsoo Kim Reviewed-by: Christian Borntraeger > --- > mm/slub.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 606488b..a1874c2 100644 > --- a/mm/slub.c > +++ b/m

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-12 Thread Christian Borntraeger
On 02/12/2016 04:41 PM, Kirill A. Shutemov wrote: > On Thu, Feb 11, 2016 at 08:57:02PM +0100, Gerald Schaefer wrote: >> On Thu, 11 Feb 2016 21:09:42 +0200 >> "Kirill A. Shutemov" wrote: >> >>> On Thu, Feb 11, 2016 at 07:22:23PM +0100, Gerald Schaefer wrote: Hi, Sebastian Ott reporte

Re: [PATCH v2] futex: replace bare barrier() with a READ_ONCE()

2016-03-02 Thread Christian Borntraeger
On 03/02/2016 02:08 PM, Jianyu Zhan wrote: > Commit e91467ecd1ef ("bug in futex unqueue_me") introduces a barrier() > in unqueue_me(), to address below problem. > > The scenario is like this: > > > original code: > > retry: >lock_ptr = q->lock_ptr; >if (lock_

Re: [PATCH v7 1/4] perf,kvm/{x86,s390}: Remove dependency on uapi/kvm_perf.h

2015-09-28 Thread Christian Borntraeger
Am 24.09.2015 um 21:02 schrieb Hemant Kumar: > Its better to remove the dependency on uapi/kvm_perf.h to allow dynamic > discovery of kvm events (if its needed). To do this, some extern > variables have been introduced with which we can keep the generic > functions generic. > > Signed-off-by: Hema

Re: [PATCH 10/26] x86, pkeys: notify userspace about protection key faults

2015-09-28 Thread Christian Borntraeger
Am 24.09.2015 um 19:15 schrieb Dave Hansen: > Christian, can you tell us how big s390's storage protection keys are? > See the discussion below about siginfo... Dave, sorry for the late answer. s390 storage keys are 4bit for the protection key (and 1 bit for fetch protection, change and referenc

Re: [PATCH] macvtap: fix TUNSETSNDBUF values > 64k

2015-09-18 Thread Christian Borntraeger
IFF") > Reported-by: Mark A. Peloquin > Bisected-by: Matthew Rosato > Reported-by: Christian Borntraeger > Signed-off-by: Michael S. Tsirkin You can add Tested-by: Matthew Rosato as this looks identical to an early version of my patch which was tested, by Matt. (I send you the

Re: [PATCH v6 0/9] virtio DMA API, yet again

2016-02-02 Thread Christian Borntraeger
; - Minor cleanups. > > Andy Lutomirski (6): > vring: Introduce vring_use_dma_api() > virtio_ring: Support DMA APIs > virtio: Add improved queue allocation API > virtio_mmio: Use the DMA API if enabled > virtio_pci: Use the DMA API if enabled > vring: Use the DMA A

Re: [PATCH v3 2/3] x86: query dynamic DEBUG_PAGEALLOC setting

2016-02-02 Thread Christian Borntraeger
On 02/02/2016 10:51 PM, David Rientjes wrote: > On Thu, 28 Jan 2016, David Rientjes wrote: > >> On Thu, 28 Jan 2016, Christian Borntraeger wrote: >> >>> Indeed, I only touched the identity mapping and dump stack. >>> The question is do we really want to cha

Re: [PATCH v3 2/3] x86: query dynamic DEBUG_PAGEALLOC setting

2016-02-02 Thread Christian Borntraeger
On 02/02/2016 11:21 PM, Andrew Morton wrote: > On Tue, 2 Feb 2016 22:53:36 +0100 Christian Borntraeger > wrote: > >>>> I don't think we should have a CONFIG_DEBUG_PAGEALLOC that does some stuff >>>> and then a commandline parameter or CONFIG_DEBUG_PAGEALL

[PATCH/RFC] mm/swapfile: reduce kswapd overhead by not filling up disks

2015-12-11 Thread Christian Borntraeger
with all the same swap priorities, unless all disks are about 98% full. There is one issue with mythis approach: If there is a mix between same and different priorities, the code will loop too often due to the requeue, so and idea for a better fix is welcome. Signed-off-by: Christian Borntraeger

Re: [PATCH v3 2/3] x86: query dynamic DEBUG_PAGEALLOC setting

2016-01-28 Thread Christian Borntraeger
On 01/27/2016 11:17 PM, David Rientjes wrote: > On Wed, 27 Jan 2016, Christian Borntraeger wrote: > >> We can use debug_pagealloc_enabled() to check if we can map >> the identity mapping with 2MB pages. We can also add the state >> into the dump_stack output. >> &

Re: Regression: 4.5-rc1 (bisect: hugetlb: make mm and fs code explicitly non-modular vs CONFIG_TIMER_STATS)

2016-01-28 Thread Christian Borntraeger
On 01/28/2016 10:40 AM, Hillf Danton wrote: >> >> Paul, >> >> the commit 3e89e1c5ea842 ("hugetlb: make mm and fs code explicitly >> non-modular") >> triggers belows warning/oops, if CONFIG_TIMER_STATS is set. >> >> Looking at the patch the only "real" change is the init_call, >> and indeed >> ---

Re: Regression: 4.5-rc1 (bisect: hugetlb: make mm and fs code explicitly non-modular vs CONFIG_TIMER_STATS)

2016-01-29 Thread Christian Borntraeger
gt;> On 01/28/2016 07:05 AM, Mike Kravetz wrote: >>>> On 01/28/2016 06:37 AM, Paul Gortmaker wrote: >>>>> [Re: Regression: 4.5-rc1 (bisect: hugetlb: make mm and fs code explicitly >>>>> non-modular vs CONFIG_TIMER_STATS)] On 28/01/2016 (Thu 10:48) Christi

[PATCH 0/1] additional CONFIG_DEBUG_PAGEALLOC change

2016-01-29 Thread Christian Borntraeger
As suggested by David Rientjes, we should also change free_init_pages. Can be merged with "x86: query dynamic DEBUG_PAGEALLOC setting" or go as addon patch. Christian Borntraeger (1): x86: also use debug_pagealloc_enabled() for free_init_pages arch/x86/mm/i

[PATCH 1/1] x86: also use debug_pagealloc_enabled() for free_init_pages

2016-01-29 Thread Christian Borntraeger
we want to couple all debugging features with debug_pagealloc_enabled() and not with the config option CONFIG_DEBUG_PAGEALLOC. Suggested-by: David Rientjes Signed-off-by: Christian Borntraeger --- arch/x86/mm/init.c | 29 +++-- 1 file changed, 15 insertions(+), 14

[PATCH 0/1] additional CONFIG_DEBUG_PAGEALLOC change

2016-01-29 Thread Christian Borntraeger
As suggested by David Rientjes, we should also change free_init_pages. Can be merged with "x86: query dynamic DEBUG_PAGEALLOC setting" or go as addon patch. Christian Borntraeger (1): x86: also use debug_pagealloc_enabled() for free_init_pages arch/x86/mm/i

[PATCH 1/1] x86: also use debug_pagealloc_enabled() for free_init_pages

2016-01-29 Thread Christian Borntraeger
we want to couple all debugging features with debug_pagealloc_enabled() and not with the config option CONFIG_DEBUG_PAGEALLOC. Suggested-by: David Rientjes Signed-off-by: Christian Borntraeger --- arch/x86/mm/init.c | 29 +++-- 1 file changed, 15 insertions(+), 14

Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting

2016-01-27 Thread Christian Borntraeger
On 01/27/2016 01:59 AM, Joonsoo Kim wrote: > On Tue, Jan 26, 2016 at 04:36:11PM -0800, David Rientjes wrote: >> On Wed, 27 Jan 2016, Joonsoo Kim wrote: >> I'd agree if CONFIG_DEBUG_PAGEALLOC only did anything when debug_pagealloc_enabled() is true, but that doesn't seem to be the case.

[PATCH v2 0/3] Optimize CONFIG_DEBUG_PAGEALLOC

2016-01-27 Thread Christian Borntraeger
ith DEBUG_PAGEALLOC dump_stack for s390/x86 - add /* CONFIG_DEBUG_PAGEALLOC */ to else and endif Christian Borntraeger (3): mm: provide debug_pagealloc_enabled() without CONFIG_DEBUG_PAGEALLOC x86: query dynamic DEBUG_PAGEALLOC setting s390: query dynamic DEBUG_PAGEALLOC setting arch/s390/ker

[PATCH v2 2/3] x86: query dynamic DEBUG_PAGEALLOC setting

2016-01-27 Thread Christian Borntraeger
: Christian Borntraeger --- arch/x86/kernel/dumpstack.c | 5 ++--- arch/x86/mm/init.c | 7 --- arch/x86/mm/pageattr.c | 14 -- 3 files changed, 10 insertions(+), 16 deletions(-) diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c index 9c30acf..32e5699

[PATCH v2 1/3] mm: provide debug_pagealloc_enabled() without CONFIG_DEBUG_PAGEALLOC

2016-01-27 Thread Christian Borntraeger
We can provide debug_pagealloc_enabled() also if CONFIG_DEBUG_PAGEALLOC is not set. It will return false in that case. Signed-off-by: Christian Borntraeger Acked-by: David Rientjes --- include/linux/mm.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/include/linux

[PATCH v2 3/3] s390: query dynamic DEBUG_PAGEALLOC setting

2016-01-27 Thread Christian Borntraeger
We can use debug_pagealloc_enabled() to check if we can map the identity mapping with 1MB/2GB pages as well as to print the current setting in dump_stack. Signed-off-by: Christian Borntraeger --- arch/s390/kernel/dumpstack.c | 8 arch/s390/mm/vmem.c | 10 -- 2 files

[PATCH v3 3/3] s390: query dynamic DEBUG_PAGEALLOC setting

2016-01-27 Thread Christian Borntraeger
We can use debug_pagealloc_enabled() to check if we can map the identity mapping with 1MB/2GB pages as well as to print the current setting in dump_stack. Signed-off-by: Christian Borntraeger Reviewed-by: Heiko Carstens --- arch/s390/kernel/dumpstack.c | 6 +++--- arch/s390/mm/vmem.c

[PATCH v3 0/3] Optimize CONFIG_DEBUG_PAGEALLOC

2016-01-27 Thread Christian Borntraeger
eplace DEBUG_PAGEALLOC(disabled/enabled) with DEBUG_PAGEALLOC dump_stack for s390/x86 - add /* CONFIG_DEBUG_PAGEALLOC */ to else and endif Christian Borntraeger (3): mm: provide debug_pagealloc_enabled() without CONFIG_DEBUG_PAGEALLOC x86: query dynamic DEBUG_PAGEALLOC setting s390: query d

[PATCH v3 1/3] mm: provide debug_pagealloc_enabled() without CONFIG_DEBUG_PAGEALLOC

2016-01-27 Thread Christian Borntraeger
We can provide debug_pagealloc_enabled() also if CONFIG_DEBUG_PAGEALLOC is not set. It will return false in that case. Signed-off-by: Christian Borntraeger Acked-by: David Rientjes Acked-by: Thomas Gleixner --- include/linux/mm.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions

[PATCH v3 2/3] x86: query dynamic DEBUG_PAGEALLOC setting

2016-01-27 Thread Christian Borntraeger
: Christian Borntraeger Reviewed-by: Thomas Gleixner --- arch/x86/kernel/dumpstack.c | 5 ++--- arch/x86/mm/init.c | 7 --- arch/x86/mm/pageattr.c | 14 -- 3 files changed, 10 insertions(+), 16 deletions(-) diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel

Re: [PATCH 1/1] debugobjects: Allow bigger number of objects

2016-01-27 Thread Christian Borntraeger
On 01/26/2016 09:22 PM, Thomas Gleixner wrote: > On Fri, 22 Jan 2016, Christian Borntraeger wrote: > >> On my bigger s390 systems I always get >> "Out of memory. ODEBUG disabled". Since the number of objects >> is needed at compile time in the code, let&

Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting

2016-01-27 Thread Christian Borntraeger
On 01/27/2016 01:41 PM, Vlastimil Babka wrote: > On 01/27/2016 01:59 AM, Joonsoo Kim wrote: >> On Tue, Jan 26, 2016 at 04:36:11PM -0800, David Rientjes wrote: >>> >>> If we can convert existing users that only check for >>> CONFIG_DEBUG_PAGEALLOC to rather check for debug_pagealloc_enabled() and

Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting

2016-01-27 Thread Christian Borntraeger
On 01/27/2016 02:03 PM, Vlastimil Babka wrote: > On 01/27/2016 01:47 PM, Christian Borntraeger wrote: >> On 01/27/2016 01:41 PM, Vlastimil Babka wrote: >>> On 01/27/2016 01:59 AM, Joonsoo Kim wrote: >>> >>> I think it might be worth also to convert debug_pageall

[PATCH v2] debugobjects: Allow bigger number of objects

2016-01-27 Thread Christian Borntraeger
yway, this should be ok. Signed-off-by: Christian Borntraeger --- lib/debugobjects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/debugobjects.c b/lib/debugobjects.c index 547f7f9..519b5a1 100644 --- a/lib/debugobjects.c +++ b/lib/debugobjects.c @@ -21,7 +21,7 @

Regression: 4.5-rc1 (bisect: hugetlb: make mm and fs code explicitly non-modular vs CONFIG_TIMER_STATS)

2016-01-28 Thread Christian Borntraeger
Paul, the commit 3e89e1c5ea842 ("hugetlb: make mm and fs code explicitly non-modular") triggers belows warning/oops, if CONFIG_TIMER_STATS is set. Looking at the patch the only "real" change is the init_call, and indeed --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -2653,7 +2653,7 @@ static int __in

Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default

2016-01-25 Thread Christian Borntraeger
On 01/25/2016 07:41 AM, Joonsoo Kim wrote: > Hello, > > On Fri, Jan 22, 2016 at 12:44:40PM +0100, Christian Borntraeger wrote: >> since commit 031bc5743f158 ("mm/debug-pagealloc: make debug-pagealloc >> boottime configurable") CONFIG_DEBUG_PAGEALLOC is by default

[PATCH] mm/debug_pagealloc: Ask users for default setting of debug_pagealloc

2016-01-25 Thread Christian Borntraeger
ange the Kconfig description for CONFIG_DEBUG_PAGEALLOC, to indicate that it is ok to enable this by default. Cc: Joonsoo Kim Cc: Andrew Morton Signed-off-by: Christian Borntraeger --- mm/Kconfig.debug | 17 + mm/page_alloc.c | 6 +- 2 files changed, 22 insertions(+), 1 deletion(-) di

Re: [PATCH] mm/debug_pagealloc: Ask users for default setting of debug_pagealloc

2016-01-25 Thread Christian Borntraeger
On 01/25/2016 10:41 AM, Heiko Carstens wrote: > On Mon, Jan 25, 2016 at 10:19:48AM +0100, Christian Borntraeger wrote: >> since commit 031bc5743f158 ("mm/debug-pagealloc: make debug-pagealloc >> boottime configurable") CONFIG_DEBUG_PAGEALLOC is by default a no-op. >&

Re: [PATCH] mm/debug_pagealloc: Ask users for default setting of debug_pagealloc

2016-01-25 Thread Christian Borntraeger
On 01/25/2016 11:02 AM, Heiko Carstens wrote: > On Mon, Jan 25, 2016 at 10:45:50AM +0100, Christian Borntraeger wrote: >>>> +By default this option will be almost for free and can be activated >>>> +in distribution kernels. The overhead and the debugging

Re: [PATCH] mm/debug_pagealloc: Ask users for default setting of debug_pagealloc

2016-01-25 Thread Christian Borntraeger
On 01/25/2016 11:07 AM, Christian Borntraeger wrote: > On 01/25/2016 11:02 AM, Heiko Carstens wrote: >> On Mon, Jan 25, 2016 at 10:45:50AM +0100, Christian Borntraeger wrote: >>>>> + By default this option will be almost for free and can be activated >>>&g

[PATCH v2] mm/debug_pagealloc: Ask users for default setting of debug_pagealloc

2016-01-25 Thread Christian Borntraeger
o change the Kconfig description for CONFIG_DEBUG_PAGEALLOC, to indicate that there are two stages of overhead. Cc: Joonsoo Kim Cc: Andrew Morton Signed-off-by: Christian Borntraeger --- V1->V2: change Kconfig help to indicate, that CONFIG_DEBUG_PAGEALLOC is not for free, even

[PATCH v3] mm/debug_pagealloc: Ask users for default setting of debug_pagealloc

2016-01-25 Thread Christian Borntraeger
o change the Kconfig description for CONFIG_DEBUG_PAGEALLOC, to indicate that there are two stages of overhead. Cc: Joonsoo Kim Cc: Andrew Morton Signed-off-by: Christian Borntraeger --- v2 -> v3: tab/whitespace, off->n (Paul Bolle) remove "If unsure say no."

Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default

2016-01-25 Thread Christian Borntraeger
On 01/25/2016 08:38 PM, Dave Jones wrote: > Content preview: On Mon, Jan 25, 2016 at 02:22:10PM -0500, Dave Jones wrote: > > > A default mode would be ok for me as it makes things obvious. Will > send > > > a patch. > > The messaging around changing a default like this was > really >

[PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting

2016-01-26 Thread Christian Borntraeger
We can use debug_pagealloc_enabled() to check if we can map the identity mapping with 1MB/2GB pages as well as to print the current setting in dump_stack. Signed-off-by: Christian Borntraeger --- arch/s390/kernel/dumpstack.c | 4 +++- arch/s390/mm/vmem.c | 10 -- 2 files

[PATCH/RFC 2/3] x86: query dynamic DEBUG_PAGEALLOC setting

2016-01-26 Thread Christian Borntraeger
: Christian Borntraeger --- arch/x86/kernel/dumpstack.c | 4 +++- arch/x86/mm/init.c | 7 --- arch/x86/mm/pageattr.c | 14 -- 3 files changed, 11 insertions(+), 14 deletions(-) diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c index 9c30acf..7971638

[PATCH/RFC 0/3] Optimize CONFIG_DEBUG_PAGEALLOC

2016-01-26 Thread Christian Borntraeger
As CONFIG_DEBUG_PAGEALLOC can be enabled/disabled via kernel parameters we can optimize some cases by checking the enablement state. I have done s390 and x86 as examples. Other architecture can provide followup patches later on. Christian Borntraeger (3): mm: provide debug_pagealloc_enabled

[PATCH/RFC 1/3] mm: provide debug_pagealloc_enabled() without CONFIG_DEBUG_PAGEALLOC

2016-01-26 Thread Christian Borntraeger
We can provide debug_pagealloc_enabled() also if CONFIG_DEBUG_PAGEALLOC is not set. It will return false in that case. Signed-off-by: Christian Borntraeger --- include/linux/mm.h | 4 1 file changed, 4 insertions(+) diff --git a/include/linux/mm.h b/include/linux/mm.h index 7783073

[PATCH v4 0/4 (resend)] Optimize CONFIG_DEBUG_PAGEALLOC (x86 and s390)

2016-02-03 Thread Christian Borntraeger
architecture can follow as necessary. Christian Borntraeger (4): mm: provide debug_pagealloc_enabled() without CONFIG_DEBUG_PAGEALLOC x86: query dynamic DEBUG_PAGEALLOC setting s390: query dynamic DEBUG_PAGEALLOC setting x86: also use debug_pagealloc_enabled() for free_init_pages arch/s390

[PATCH v4 3/4] s390: query dynamic DEBUG_PAGEALLOC setting

2016-02-03 Thread Christian Borntraeger
We can use debug_pagealloc_enabled() to check if we can map the identity mapping with 1MB/2GB pages as well as to print the current setting in dump_stack. Signed-off-by: Christian Borntraeger Reviewed-by: Heiko Carstens --- arch/s390/kernel/dumpstack.c | 6 +++--- arch/s390/mm/vmem.c

[PATCH v4 1/4] mm: provide debug_pagealloc_enabled() without CONFIG_DEBUG_PAGEALLOC

2016-02-03 Thread Christian Borntraeger
We can provide debug_pagealloc_enabled() also if CONFIG_DEBUG_PAGEALLOC is not set. It will return false in that case. Signed-off-by: Christian Borntraeger Acked-by: David Rientjes Acked-by: Thomas Gleixner --- include/linux/mm.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions

[PATCH v4 0/4 (resend)] Optimize CONFIG_DEBUG_PAGEALLOC (x86 and s390)

2016-02-03 Thread Christian Borntraeger
architecture can follow as necessary. Christian Borntraeger (4): mm: provide debug_pagealloc_enabled() without CONFIG_DEBUG_PAGEALLOC x86: query dynamic DEBUG_PAGEALLOC setting s390: query dynamic DEBUG_PAGEALLOC setting x86: also use debug_pagealloc_enabled() for free_init_pages arch/s390

[PATCH v4 1/4] mm: provide debug_pagealloc_enabled() without CONFIG_DEBUG_PAGEALLOC

2016-02-03 Thread Christian Borntraeger
We can provide debug_pagealloc_enabled() also if CONFIG_DEBUG_PAGEALLOC is not set. It will return false in that case. Signed-off-by: Christian Borntraeger Acked-by: David Rientjes Acked-by: Thomas Gleixner --- include/linux/mm.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions

[PATCH v4 2/4] x86: query dynamic DEBUG_PAGEALLOC setting

2016-02-03 Thread Christian Borntraeger
: Christian Borntraeger Reviewed-by: Thomas Gleixner --- arch/x86/kernel/dumpstack.c | 5 ++--- arch/x86/mm/init.c | 7 --- arch/x86/mm/pageattr.c | 14 -- 3 files changed, 10 insertions(+), 16 deletions(-) diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel

[PATCH v4 4/4] x86: also use debug_pagealloc_enabled() for free_init_pages

2016-02-03 Thread Christian Borntraeger
we want to couple all debugging features with debug_pagealloc_enabled() and not with the config option CONFIG_DEBUG_PAGEALLOC. Suggested-by: David Rientjes Signed-off-by: Christian Borntraeger --- arch/x86/mm/init.c | 29 +++-- 1 file changed, 15 insertions(+), 14

[PATCH v4 4/4] x86: also use debug_pagealloc_enabled() for free_init_pages

2016-02-03 Thread Christian Borntraeger
we want to couple all debugging features with debug_pagealloc_enabled() and not with the config option CONFIG_DEBUG_PAGEALLOC. Suggested-by: David Rientjes Signed-off-by: Christian Borntraeger --- arch/x86/mm/init.c | 29 +++-- 1 file changed, 15 insertions(+), 14

[PATCH v4 3/4] s390: query dynamic DEBUG_PAGEALLOC setting

2016-02-03 Thread Christian Borntraeger
We can use debug_pagealloc_enabled() to check if we can map the identity mapping with 1MB/2GB pages as well as to print the current setting in dump_stack. Signed-off-by: Christian Borntraeger Reviewed-by: Heiko Carstens --- arch/s390/kernel/dumpstack.c | 6 +++--- arch/s390/mm/vmem.c

[PATCH v4 2/4] x86: query dynamic DEBUG_PAGEALLOC setting

2016-02-03 Thread Christian Borntraeger
: Christian Borntraeger Reviewed-by: Thomas Gleixner --- arch/x86/kernel/dumpstack.c | 5 ++--- arch/x86/mm/init.c | 7 --- arch/x86/mm/pageattr.c | 14 -- 3 files changed, 10 insertions(+), 16 deletions(-) diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel

Re: [PATCH 2/5] mm/slub: query dynamic DEBUG_PAGEALLOC setting

2016-02-04 Thread Christian Borntraeger
On 02/04/2016 06:56 AM, Joonsoo Kim wrote: > We can disable debug_pagealloc processing even if the code is complied > with CONFIG_DEBUG_PAGEALLOC. This patch changes the code to query > whether it is enabled or not in runtime. > > Signed-off-by: Joonsoo Kim > --- > mm/slub.c | 11 ++- >

Re: [PATCH 1/5] mm/vmalloc: query dynamic DEBUG_PAGEALLOC setting

2016-02-04 Thread Christian Borntraeger
On 02/04/2016 06:56 AM, Joonsoo Kim wrote: > We can disable debug_pagealloc processing even if the code is complied > with CONFIG_DEBUG_PAGEALLOC. This patch changes the code to query > whether it is enabled or not in runtime. > > Signed-off-by: Joonsoo Kim Reviewed-by: Christ

Re: [PATCH 3/4] KVM: renumber architecture-dependent requests

2016-01-07 Thread Christian Borntraeger
On 01/07/2016 03:17 PM, Paolo Bonzini wrote: > Leave room for 4 more arch-independent requests. > The patch subject is wrong. "renumber architecture-dependent requests" --> "renumber kvm requests" as we also renumber the architecture independent ones. -- To unsubscribe from this list: send t

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Christian Borntraeger
On 24.06.20 16:43, Christoph Hellwig wrote: > On Wed, Jun 24, 2020 at 01:11:54PM +0200, Christian Borntraeger wrote: >> Does anyone have an idea why "umh: fix processed error when UMH_WAIT_PROC is >> used" breaks the >> linux-bridge on s390? > > Are w

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Christian Borntraeger
On 24.06.20 18:09, Luis Chamberlain wrote: > On Wed, Jun 24, 2020 at 05:54:46PM +0200, Christian Borntraeger wrote: >> >> >> On 24.06.20 16:43, Christoph Hellwig wrote: >>> On Wed, Jun 24, 2020 at 01:11:54PM +0200, Christian Borntraeger wrote: >>>&

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Christian Borntraeger
On 24.06.20 19:58, Christian Borntraeger wrote: > > > On 24.06.20 18:09, Luis Chamberlain wrote: >> On Wed, Jun 24, 2020 at 05:54:46PM +0200, Christian Borntraeger wrote: >>> >>> >>> On 24.06.20 16:43, Christoph Hellwig wrote: >>>&g

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Christian Borntraeger
On 24.06.20 20:09, Christian Borntraeger wrote: > > > On 24.06.20 19:58, Christian Borntraeger wrote: >> >> >> On 24.06.20 18:09, Luis Chamberlain wrote: >>> On Wed, Jun 24, 2020 at 05:54:46PM +0200, Christian Borntraeger wrote: >>>> >

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Christian Borntraeger
On 24.06.20 20:32, Christian Borntraeger wrote: [...]> > So the translations look correct. But your change is actually a sematic change > if(ret) will only trigger if there is an error > if (KWIFEXITED(ret)) will always trigger when the process ends. So we will > always ov

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-25 Thread Christian Borntraeger
On 24.06.20 20:37, Christian Borntraeger wrote: > > > On 24.06.20 20:32, Christian Borntraeger wrote: > [...]> >> So the translations look correct. But your change is actually a sematic >> change >> if(ret) will only trigger if there is an error >> i

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-25 Thread Christian Borntraeger
On 26.06.20 04:54, Luis Chamberlain wrote: > On Wed, Jun 24, 2020 at 08:37:55PM +0200, Christian Borntraeger wrote: >> >> >> On 24.06.20 20:32, Christian Borntraeger wrote: >> [...]> >>> So the translations look correct. But your change is actually a se

Re: [PATCH v4 1/2] virtio: let arch validate VIRTIO features

2020-07-07 Thread Christian Borntraeger
+/* >> + * arch_needs_virtio_iommu_platform - provide arch specific hook when >> finalizing > > s/arch_needs_virtio_iommu_platform/arch_validate_virtio_features/ With the things from Conny fixed, Acked-by: Christian Borntraeger

Re: [PATCH v4 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-07 Thread Christian Borntraeger
On 07.07.20 10:44, Pierre Morel wrote: > S390, protecting the guest memory against unauthorized host access > needs to enforce VIRTIO I/O device protection through the use of > VIRTIO_F_VERSION_1 and VIRTIO_F_IOMMU_PLATFORM. > > Signed-off-by: Pierre Morel > --- > arch/s390/kernel/uv.c | 25 +

Re: [PATCH v8 04/16] s390/zcrypt: driver callback to indicate resource in use

2020-07-08 Thread Christian Borntraeger
On 05.06.20 23:39, Tony Krowiak wrote: > Introduces a new driver callback to prevent a root user from unbinding > an AP queue from its device driver if the queue is in use. The intent of > this callback is to provide a driver with the means to prevent a root user > from inadvertently taking a queue

linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-23 Thread Christian Borntraeger
Jens Markwardt reported a regression in the linux-next runs. with "umh: fix processed error when UMH_WAIT_PROC is used" (from linux-next) a linux bridge with an KVM guests no longer activates : without patch # ip addr show dev virbr1 6: virbr1: mtu 1500 qdisc noqueue state UP group default qlen

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-23 Thread Christian Borntraeger
On 23.06.20 16:11, Christian Borntraeger wrote: > Jens Markwardt reported a regression in the linux-next runs. with "umh: fix > processed error when UMH_WAIT_PROC is used" (from linux-next) a linux bridge > with an KVM guests no longer activates : > > without patch &g

Re: [PATCH v6 1/5] KVM: s390: clean up redundant 'kvm_run' parameters

2020-06-23 Thread Christian Borntraeger
On 23.06.20 15:14, Tianjia Zhang wrote: > In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' > structure. For historical reasons, many kvm-related function parameters > retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This > patch does a unified cleanup of

Fwd: [merged] usercopy-mark-dma-kmalloc-caches-as-usercopy-caches.patch removed from -mm tree

2020-06-15 Thread Christian Borntraeger
db-bbd0-d958-7732-76e36c667...@suse.cz/ [3] https://lore.kernel.org/kernel-hardening/CAG48ez1a4waGk9kB0WLaSbs4muSoK0AYAVk8=xyakj4_+6e...@mail.gmail.com/ Link: http://lkml.kernel.org/r/7d810f6d-8085-ea2f-7805-47ba3842d...@suse.cz Signed-off-by: Vlastimil Babka Acked-by: Christian Borntraeger Acked-by: Ji

Re: [PATCH v6 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-14 Thread Christian Borntraeger
27;s not the case, preventing a host error on access > attempt. > > Signed-off-by: Pierre Morel > Reviewed-by: Cornelia Huck > Acked-by: Halil Pasic We will probably move this (and other related code) into a new file, but we can do that later. As for now: Acked-by: Christian Borntraege

Re: [PATCH v4 2/2] s390/dasd: remove ioctl_by_bdev calls

2020-10-07 Thread Christian Borntraeger
On 19.05.20 16:22, Stefan Haberland wrote: > The IBM partition parser requires device type specific information only > available to the DASD driver to correctly register partitions. The > current approach of using ioctl_by_bdev with a fake user space pointer > is discouraged. > > Fix this by rep

Re: [PATCH v4 2/2] s390/dasd: remove ioctl_by_bdev calls

2020-10-07 Thread Christian Borntraeger
On 07.10.20 12:39, Christoph Hellwig wrote: > On Wed, Oct 07, 2020 at 11:34:17AM +0200, Christian Borntraeger wrote: >> >> On 19.05.20 16:22, Stefan Haberland wrote: >>> The IBM partition parser requires device type specific information only >>> availabl

Re: [PATCH v4 2/2] s390/dasd: remove ioctl_by_bdev calls

2020-10-07 Thread Christian Borntraeger
On 07.10.20 14:00, Christoph Hellwig wrote: > On Wed, Oct 07, 2020 at 12:44:55PM +0200, Christian Borntraeger wrote: >> >> >> On 07.10.20 12:39, Christoph Hellwig wrote: >>> On Wed, Oct 07, 2020 at 11:34:17AM +0200, Christian Borntraeger wrote: >>>> >

Re: [PATCH v4 2/2] s390/dasd: remove ioctl_by_bdev calls

2020-10-07 Thread Christian Borntraeger
On 07.10.20 14:14, Christoph Hellwig wrote: > On Wed, Oct 07, 2020 at 02:09:18PM +0200, Christian Borntraeger wrote: >> Unfortunately not. On insmodding virtio_blk I do get: > > Yeah, the symbol_put needs to be conditional as well. New version below: Yes, this works. > &g

<    4   5   6   7   8   9   10   11   >