I've looked through the scheduling code and searched pretty much
everywhere I could think of and I've found nothing on this, so it's
time to escalate :-).
The measurement of CPU usage and virtual itimers is crude at best.
It's actually possible to set a relatively short virtual itimer (say,
In the current version (and may previous versions) of the tulip driver
in media.c in the function tulip_select_media() with mleaf-type being
2 or 4, we have the following code:
if (p[1] 0x40) { /* SIA (CSR13-15) setup values are provided. */
csr13val = setup[0];
csr14val =
In the current version (and may previous versions) of the tulip driver
in media.c in the function tulip_select_media() with mleaf-type being
2 or 4, we have the following code:
if (p[1] 0x40) { /* SIA (CSR13-15) setup values are provided. */
csr13val = setup[0];
csr14val =
I have patches written to improve the accuracy of CPU measurement
(getrusage()) and virtual itimers. This lets the amount of CPU used
by a process be measured fairly accurately. The patches are on my web
page: http://members.home.com/minyard
This is if anyone is interested. I don't know if
interfaces for writing with the
addition of a poll call in the uart.
This is the first patch with the base changes and changes to the 8250
driver. It includes some changes to serial_core.h that are required
by other drivers later.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
Cc
Alan Cox wrote:
The basic reason for all this is to eventually allow the low-level
serial drivers to function without a uart_info structure being
allocated. This will allow the serial console, debuggers like kgdb,
and the IPMI serial driver to use one interface to the uart code and
This is fine with me; I don't see any problems in it and the mutex
is better. However, I cannot test this as I have no hardware
left capable of hosting the drive.
-corey
Matthias Kaehlcke wrote:
use mutex instead of binary semaphore in CDU-31A driver
Signed-off-by: Matthias Kaehlcke [EMAIL
Subject: Remove unnecessary include of linux/tty.h from a bunch of files
Including serial_core.h no longer requires including tty.h first, but
a lot of files still seem to have this in them. Remove all the
unnecessary references.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux
-kcs could be tested.
Signed-off-by: Christian Krafft [EMAIL PROTECTED]
Acked-by: Heiko J Schick [EMAIL PROTECTED]
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Acked-by: Arnd Bergmann [EMAIL PROTECTED]
Index: linux/drivers/char/ipmi/ipmi_si_intf.c
Add pci_remove handling to the driver, so it will clean up if
the device is hot-removed.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.19/drivers/char/ipmi/ipmi_si_intf.c
===
--- linux-2.6.19.orig/drivers/char
in.
It also adds testing that the IPMI NMI watchdog works.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.19-rc6/arch/i386/Kconfig.debug
===
--- linux-2.6.19-rc6.orig/arch/i386/Kconfig.debug
+++ linux-2.6.19-rc6
to not use disable_irq and enable_irq.
It instead sends the messages to the BMC to perform this operation.
It also makes sure interrupts are cleanly disabled when the interface
is shut down and cleans up some shutdown things that are no longer
necessary.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Cc
Andrew Morton wrote:
On Thu, 15 Feb 2007 15:05:56 +1100 Paul Mackerras [EMAIL PROTECTED] wrote:
Andrew Morton writes:
This is all fairly unpleasant.
What architecture is preventing us from using DIE_NMI_POST on all
architectures which support ipmi? ia64?
It would be better to
the
testing of it. Sorry, my bad.
New patch...
Add pci_remove handling to the driver, so it will clean up if
the device is hot-removed.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.20/drivers/char/ipmi/ipmi_si_intf.c
Andrew Morton wrote:
On Thu, 15 Feb 2007 09:49:15 -0600
Corey Minyard [EMAIL PROTECTED] wrote:
So I see the following options besides what's already there:
1) add asm/kdebug.h and DIE_NMI_POST to everything that might have an
IPMI implementation.
2) use CONFIG_X86 to tell if NMI will work
-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.20/drivers/char/ipmi/ipmi_si_intf.c
===
--- linux-2.6.20.orig/drivers/char/ipmi/ipmi_si_intf.c
+++ linux-2.6.20/drivers/char/ipmi/ipmi_si_intf.c
@@ -2191,12 +2191,15 @@ static int
On Thu, Feb 15, 2007 at 02:21:24PM -0800, Andrew Morton wrote:
On Thu, 15 Feb 2007 09:49:15 -0600
Corey Minyard [EMAIL PROTECTED] wrote:
So I see the following options besides what's already there:
1) add asm/kdebug.h and DIE_NMI_POST to everything that might have an
IPMI
Jiri, can you send me the output of lspci -x ?
-corey
Jiri Kosina wrote:
On Thu, 12 Apr 2007, Jiri Kosina wrote:
- try booting without any HID devices plugged in (i.e. usb mice, usb
keyboards) if the problem persists?
- recompile 2.6.21-rc6-mm1 with git-hid.patch reverted to see if it
Jiri Kosina wrote:
On Thu, 12 Apr 2007, Jiri Kosina wrote:
CONFIG_IPMI_SI=y
hangs upon boot on the already mentioned printk from ipmi_si. With
CONFIG_IPMI_SI=m
the boot succeeds. When manually trying to modprobe ipmi_si after that,
the modprobe itself hangs, but the machine remains usable
on PPC machines without a BMC.
Signed-off-by: Christian Krafft [EMAIL PROTECTED]
Acked-by: Michael Ellerman [EMAIL PROTECTED]
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux/drivers/char/ipmi/ipmi_si_intf.c
===
--- linux.orig
Yes, a good idea.
Acked-by: Corey Minyard [EMAIL PROTECTED]
Daniel Walker wrote:
Just converting this documentation semaphore reference, since we don't
want to promote semaphore usage.
Signed-off-by: Daniel Walker [EMAIL PROTECTED]
---
Documentation/kref.txt | 20 ++--
1
From: Corey Minyard [EMAIL PROTECTED]
Add the standard IOCTLs to the IPMI driver for setting and getting
the pretimeout. Tested by Benoît Guillon.
Signed off by: Corey Minyard [EMAIL PROTECTED]
Cc: Benoît Guillon [EMAIL PROTECTED]
---
Index: linux-2.6.23/drivers/char/ipmi/ipmi_watchdog.c
The watchdog is off by default, meaning that you have to have
something actually start resetting the watchdog before it will start
running. That's why you are seeing this behavior.
There is a start_now option that will start the watchdog when it is
loaded, but then it will reset the system
Yes, it's a problem, but wrong fix. Thanks, I'll send a patch for it.
-corey
Adrian Bunk wrote:
This patch removes obviously dead code spotted by the Coverity checker.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
include/linux/ipmi_smi.h | 10 ++
1 file changed, 2
From: Corey Minyard [EMAIL PROTECTED]
Coverity spotted some incorrect code in a recent change to the IPMI
driver; this patch make sure the data is really long enough to pull
the manufacturer id and product id out of a get device id message.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Cc
]
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
---
--- linux-2.6.24.orig/drivers/firmware/dmi_scan.c 2008-01-30
11:21:55.0 -0800
+++ linux-2.6.24/drivers/firmware/dmi_scan.c2008-01-30 11:18:05.0
-0800
@@ -219,7 +219,7 @@ static void __init dmi_save_ipmi_device(
dev
From: Konstantin Baydarov [EMAIL PROTECTED]
Atomics are a lot more efficient and neat than using a lock.
Signed-off-by: Konstantin Baydarov [EMAIL PROTECTED]
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
---
Index: linux-2.6.24/drivers/char/ipmi/ipmi_msghandler.c
From: Corey Minyard [EMAIL PROTECTED]
Enough bug fixes and changes that we need a new driver version.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.23/drivers/char/ipmi/ipmi_msghandler.c
===
--- linux-2.6.23.orig
From: Corey Minyard [EMAIL PROTECTED]
Hold handling of ATTN until the upper layer has reported that it is
ready.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Cc: Patrick Schoeller [EMAIL PROTECTED]
---
Index: linux-2.6.24/drivers/char/ipmi/ipmi_si_intf.c
From: Corey Minyard [EMAIL PROTECTED]
The run_to_completion mode was somewhat broken. Locks need to be
avoided in run_to_completion mode, and it shouldn't be used by normal
users, just internally for panic situations.
This patch removes locks in run_to_completion mode and removes the
user call
From: Konstantin Baydarov [EMAIL PROTECTED]
This patch prevents deadlocks in IPMI panic handler caused by msg_lock
in smi_info structure and waiting_msgs_lock in ipmi_smi structure.
Signed-off-by: Konstantin Baydarov [EMAIL PROTECTED]
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
---
Index
From: Corey Minyard [EMAIL PROTECTED]
Don't print out that the event queue is full on every event, only
print something out when it becomes full or becomes not full.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
---
Index: linux-2.6.23/drivers/char/ipmi/ipmi_msghandler.c
From: Corey Minyard [EMAIL PROTECTED]
Atomics are faster and neater than locked counters.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
---
Index: linux-2.6.24/drivers/char/ipmi/ipmi_si_intf.c
===
--- linux-2.6.24.orig/drivers
Andrew Morton wrote:
The code forgot to initialise all of these.
It just so happens that the all-bits-zero pattern works correctly for all
current architectures, so the code should work OK. But there is no reason
(I hope) why an architecture cannot implement atomic_t as
struct atomic_t {
Andrew Morton wrote:
On Wed, 13 Feb 2008 10:23:42 -0600
Corey Minyard [EMAIL PROTECTED] wrote:
From: Corey Minyard [EMAIL PROTECTED]
The run_to_completion mode was somewhat broken. Locks need to be
avoided in run_to_completion mode, and it shouldn't be used by normal
users, just
Andrew Morton wrote:
On Wed, 13 Feb 2008 10:30:48 -0600
Corey Minyard [EMAIL PROTECTED] wrote:
Enough bug fixes and changes that we need a new driver version.
Are none of them serious enough to warrant a 2.6.24.x backport?
No, nothing really terribly urgent. Just minor stuff
From: Konstantin Baydarov [EMAIL PROTECTED]
Atomics are a lot more efficient and neat than using a lock.
Signed-off-by: Konstantin Baydarov [EMAIL PROTECTED]
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
---
Index: linux-2.6.24/drivers/char/ipmi/ipmi_msghandler.c
From: Corey Minyard [EMAIL PROTECTED]
Change a barrier to cpu_relax(), which is more appropriate for a
polling loop.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
---
Index: linux-2.6.24/drivers/char/ipmi/ipmi_poweroff.c
From: Corey Minyard [EMAIL PROTECTED]
Atomics are faster and neater than locked counters.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
---
Index: linux-2.6.24/drivers/char/ipmi/ipmi_si_intf.c
===
--- linux-2.6.24.orig/drivers
From: Corey Minyard [EMAIL PROTECTED]
Remove some unnecessary barriers.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
---
This can be folded into ipmi-dont-grab-locks-in-run-to-completion-mode.patch
Index: linux-2.6.24/drivers/char/ipmi/ipmi_msghandler.c
Andrew Morton wrote:
+ for (i = 0; i IPMI_NUM_STATS; i++)
+ atomic_set(intf-stats[i], 0);
And this is why it would be very hard for any architecture to ever
implement atomic_t as
struct atomic_t {
int counter;
spinlock_t lock;
};
The interface
Peter Zijlstra wrote:
On Thu, 2008-02-14 at 12:30 -0600, Corey Minyard wrote:
+/* The command didn't have anyone waiting for it. */
+#define IPMI_STAT_unhandled_commands 23
+
+/* Invalid data in an event. */
+#define IPMI_STAT_invalid_events 24
On 09/26/2012 07:48 PM, Eric W. Biederman wrote:
I have fixed up Serge's email address and the linux-kernel email
address.
Corey Minyard cminy...@mvista.com writes:
On 09/26/2012 07:16 PM, Eric W. Biederman wrote:
miny...@acm.org writes:
From: Corey Minyard cminy...@mvista.com
Add
On 10/22/2012 06:49 PM, Andrew Morton wrote:
On Tue, 16 Oct 2012 15:53:39 -0500
miny...@acm.org wrote:
From: Corey Minyard cminy...@mvista.com
There was a spot where the compiler couldn't tell some variables
would be set. So initialize them to make the warning go away.
Signed-off-by: Corey
Thanks.
Acked-by: Corey Minyard [EMAIL PROTECTED]
[EMAIL PROTECTED] wrote:
Add file pattern to MAINTAINER entry
Signed-off-by: Joe Perches [EMAIL PROTECTED]
diff --git a/MAINTAINERS b/MAINTAINERS
index 4157218..c1a9131 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2524,6 +2524,9 @@ M
From: Mijo Safradin [EMAIL PROTECTED]
trivial change: fix warning
Signed-off-by: Mijo Safradin [EMAIL PROTECTED]
Acked-by: Christian Krafft [EMAIL PROTECTED]
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
---
Index: linux-2.6.22/drivers/char/ipmi/ipmi_si_intf.c
Paul E. McKenney wrote:
On Fri, Aug 17, 2007 at 09:56:45AM +0200, Peter Zijlstra wrote:
On Thu, 2007-08-16 at 09:01 -0700, Paul E. McKenney wrote:
On Thu, Aug 16, 2007 at 04:25:07PM +0200, Peter Zijlstra wrote:
There seem to be some unbalanced rcu_read_{,un}lock() issues of
From: Corey Minyard [EMAIL PROTECTED]
The removal of proc entries was done holding a lock, which is
no longer allowed. There is no need for the lock, only a mutex
is required, so switch over to a mutex.
Not needed for the stable kernel.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index
From: Corey Minyard [EMAIL PROTECTED]
Convert over to the new NMI handling for getting IPMI watchdog
timeouts via an NMI. This add config options to know if there
is the ability to receive NMIs and if it has an NMI post processing
call. Then it modifies the IPMI watchdog to take advantage
From: Corey Minyard [EMAIL PROTECTED]
Clean up IPMI documentation to remove references to high-res timers
and add info about the polling thread. Also fix an doc error for a
parameter.
Not needed for the stable kernel.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
---
Index: linux-2.6.21
From: Corey Minyard [EMAIL PROTECTED]
Lockdep was giving an error when loading the IPMI watchdog module. It
turns out that if you try to claim a lock in a parameter handling
routine, lockdep won't see that lock as static yet because the
module is not yet on the module list, so it will complain
From: Corey Minyard [EMAIL PROTECTED]
Add support for IPMI 0.9 systems to the IPMI driver. Just handle
a shorter get device ID command with less information.
Not needed for the stable kernel.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Cc: Stian Jordet [EMAIL PROTECTED]
Index: linux
From: Corey Minyard [EMAIL PROTECTED]
Patrick found a race at startup. Interrupts were being enabled for
the IPMI interface before the driver was really ready to handle them.
This could result in an oops if something was pending on the interface
at startup and interrupt were already enabled
From: Corey Minyard [EMAIL PROTECTED]
Currently the IPMI watchdog timer sets the watchdog timeout on a
panic, but it doesn't actually poll the interface to make sure the
message goes out.
Add an interface for polling the IPMI driver, and add code to the IPMI
watchdog timer to poll the interface
with low_latency causing re-entry into the driver under the
lock so its conceptually much easier to follow the locking
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Acked-by: Alan Cox [EMAIL PROTECTED]
drivers/serial/8250.c | 53 +++---
1 file changed, 33
Russell King wrote:
On Thu, Apr 26, 2007 at 03:51:03PM -0500, Corey Minyard wrote:
This time to lkml...
NAK. Did you read your own patch, let alone try to build it? It's
also utterly broken. See comments below.
The patch builds without error or warning and seems to work just
Corey Minyard wrote:
Russell King wrote:
Use of an uninitialised variable. The reason we use check_modem_status
to return the current status here is because reading the MSR _clears_
interrupts. So, repeatedly calling get_mctrl via an ioctl is a great
way to introduce a hardware race
I checked this out and it seems to work fine. This does seem a little
nicer than the way it was, so if this is the way the kernel is heading
I'll ack it.
-corey
Jan Engelhardt wrote:
Change Kconfig objects from menu, config into menuconfig so
that the user can disable the whole feature
-blocking interface in this area. Having
it in one place greatly simplifies the changes.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.12-rc1/drivers/i2c/i2c-core.c
===
--- linux-2.6.12-rc1.orig/drivers/i2c/i2c-core.c
[EMAIL PROTECTED] wrote:
Below is a patch to add power cycle functionality to the IPMI power
off module ipmi_poweroff.
A new module param is added to support this:
parmtype: do_power_cycle:int
parm: do_power_cycle: Set to 1 to enable power cycle instead
of power down. Power cycle
about what user operation causes
the power cycle. It would be nice if you could tie this to reset
instead of poweroff, but that's not a huge deal. It would take a while
to get that infrastructure into the kernel.
-Corey
Thanks,
-Chris Poblete
-Original Message-
From: Corey Minyard
versions for the IPMI configuration information.
This patch handles the differences between the two.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.11-rc3/drivers/char/ipmi/ipmi_si_intf.c
===
--- linux-2.6.11-rc3.orig
This is on top of the IPMI SMBus driver in the current mm kernel.
Thanks,
-Corey
Make the IPMI SMBus select I2C, not depend on it, so I2C gets
enabled properly when the IPMI SMBus is enabled.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.11-rc3/drivers/char/ipmi/Kconfig
Bukie Mabayoje wrote:
Corey Minyard wrote:
BTW, I'm also working with the person who had the trouble with the I2C
non-blocking driver updates, but we haven't figured it out yet.
Hopefully soon. (Though that has nothing to do with this patch.)
Thanks,
-Corey
I try to access the bttv device :
The I2C non-blocking patch would incorrectly return success in some
cases because it wasn't updating the proper result variable. This
patch fixes the problem. The bttv driver now works properly with
the I2C non-blocking patch.
Signed-off-by: Corey Minyard
Andrew Morton wrote:
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc3/2.6.11-rc3-mm2/
- Added the mlock and !SCHED_OTHER Linux Security Module for the audio guys.
It seems that nothing else is going to come along and this is completely
encapsulated.
- Various other stuff.
The size of LAN bridged messages was not being returned properly from
the function that calculated address sizes. This fixes the problem.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.11-rc3/drivers/char/ipmi/ipmi_msghandler.c
.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.11-mm1/drivers/char/ipmi/ipmi_devintf.c
===
--- linux-2.6.11-mm1.orig/drivers/char/ipmi/ipmi_devintf.c
+++ linux-2.6.11-mm1/drivers/char/ipmi/ipmi_devintf.c
@@ -44,6 +44,7
Greg KH wrote:
On Sat, Mar 12, 2005 at 10:57:24PM -0600, Corey Minyard wrote:
The IPMI driver has long needed to tie into the device model (and I've
long been hoping someone else would do it). I finally gave up and spent
the time to learn how to do it. I think this is right, it seems
Greg KH wrote:
On Wed, Mar 02, 2005 at 01:58:51PM -0600, Corey Minyard wrote:
This patch reorganizes the I2C SMBus formatting code to make it more
suitable for the upcoming non-blocking changes.
You are changing too much stuff here to claim it's just a
reorganization:
- variable name
This is not the right fix. I know of IPMI hardware on ppc and xscale
systems. There should be nothing general in the driver that limits it
to x86/ia64.
pm_power_off is defined in linux/pm.h. Shouldn't it be available
everywhere?
-Corey
Ivan Kokshaysky wrote:
On Tue, Mar 22, 2005 at
code that was in all three functions.
This is important for the non-blocking interfaces because they
will have to handle a non-blocking interface in this area. Having
it in one place greatly simplifies the changes.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.11-rc4/drivers/i2c
.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.11-mm1/drivers/i2c/i2c-core.c
===
--- linux-2.6.11-mm1.orig/drivers/i2c/i2c-core.c
+++ linux-2.6.11-mm1/drivers/i2c/i2c-core.c
@@ -1038,25 +1038,127
This patch adds an operation queue structure and converts over the
passing around of data to use the operation queue. The op queue
entry will be used for queueing in the non-blocking case.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.11-mm1/drivers/i2c/i2c-core.c
Bene Martin wrote:
Hi Adrian,
bmcsensors package (reading hardware sensors provided by intel boards
via ipmi) used to work fine with 2.6.10; no longer works with 2.6.11
because of removal of the ipmi_request function (+ exported symbol).
correct fix would be to use ipmi_request_settime with
Adrian Bunk wrote:
On Sat, Mar 05, 2005 at 10:41:31AM +0100, Bene Martin wrote:
Hi Adrian,
bmcsensors package (reading hardware sensors provided by intel boards
via ipmi) used to work fine with 2.6.10; no longer works with 2.6.11
because of removal of the ipmi_request function (+ exported
.
This is basically the same as the x86 patch at
http://marc.theaimsgroup.com/?l=linux-kernelm=110634968908435w=2
but for x86_64.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.11-rc5-mm1/include/asm-x86_64/mc146818rtc.h
as long as they can
correctly identify themselves as the watchdog source. This
is possible with nmi_watchdog=2 and oprofile, but not with
nmi_watchdog=1.
This is for both x86 and x86_64.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.11-mm1/arch/i386/kernel/i386_ksyms.c
Andi Kleen wrote:
Corey Minyard [EMAIL PROTECTED] writes:
This patch fixes a race between the CMOS clock setting and the NMI
code. The NMI code indiscriminatly sets index registers and values
in the same place the CMOS clock is set. If you are setting the
CMOS clock and an NMI occurs, Bad
the useless code.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.11-mm1/arch/x86_64/kernel/traps.c
===
--- linux-2.6.11-mm1.orig/arch/x86_64/kernel/traps.c
+++ linux-2.6.11-mm1/arch/x86_64/kernel/traps.c
@@ -620,15 +620,6
simplifies the changes.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.12-rc1/drivers/i2c/i2c-core.c
===
--- linux-2.6.12-rc1.orig/drivers/i2c/i2c-core.c
+++ linux-2.6.12-rc1/drivers/i2c/i2c-core.c
@@ -612,27 +612,17
-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.12-rc1/drivers/char/ipmi/ipmi_devintf.c
===
--- linux-2.6.12-rc1.orig/drivers/char/ipmi/ipmi_devintf.c
+++ linux-2.6.12-rc1/drivers/char/ipmi/ipmi_devintf.c
@@ -44,6 +44,7 @@
#include linux
Dmitry Torokhov wrote:
On Thursday 31 March 2005 22:02, Corey Minyard wrote:
+ snprintf(name, sizeof(name), ipmi%d, if_num);
+ class_device_create(ipmi_class, dev, NULL, name);
class_device_create(ipmi_class, dev, NULL, ipmi%d, if_num) ?
Yes, much better. Let's try again
The IPMI SMB driver, when running in run-to-completion mode
(done during panic time), would sometimes get locked up if
a timeout occurred because the timer would not get run
properly. This adds the timer handling to the run-to-completion
code.
Signed-off-by: Corey Minyard [EMAIL PROTECTED
This cleans up the IPMI documentation to fix some problems and
make it more accurate for the current drivers.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.11-rc4/Documentation/IPMI.txt
===
--- linux-2.6.11-rc4
general I2C things. Convert all the msg[] in functions
to *msg, fix some grammar, put () around all the #defines that
are compound to avoid nasty side-effects, and convert some
initializations to C99 versions to make them more change-resistant.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index
some general I2C things. Fix some grammar and put ()
around all the #defines that are compound to avoid nasty
side-effects.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.11-rc4/include/linux/i2c.h
===
--- linux
around (for now)
and will be used for queueing in the non-blocking case.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.11-rc4/drivers/i2c/i2c-core.c
===
--- linux-2.6.11-rc4.orig/drivers/i2c/i2c-core.c
+++ linux-2.6.11
This is one in a series of patches for adding a non-blocking interface
to the I2C driver for supporting the IPMI SMBus driver.
This patch adds handling of the op q to the I2C main code
in preparation for the non-blocking changes.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux
This is one in a series of patches for adding a non-blocking interface
to the I2C driver for supporting the IPMI SMBus driver.
This adds back in the i2c_smbus_read_block_data() function
which is needed by the IPMI SMB driver (coming soon).
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index
This is one in a series of patches for adding a non-blocking interface
to the I2C driver for supporting the IPMI SMBus driver.
Add a timer to the I2C layer. This doesn't do much until the
non-blocking code shows up.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.11-rc4/drivers
This patch didn't make it to the mailing list because my fat fingers
type lmkl instead of lkml. One more time...
This patch modifies the I801 SMBus driver to use the non-blocking
interface.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.11-rc2/drivers/i2c/busses/i2c-i801.c
by
the IPMI code so it can do things at panic time.
The non-blocking interface requires changes to the driver
below it. The current drivers will work as-is, but will not
be able to use the non-blocking interfaces.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.11-rc4/drivers/i2c
Greg KH wrote:
On Thu, Feb 24, 2005 at 05:27:25PM -0600, Corey Minyard wrote:
+
+ /* It's wierd, but we use a usecount to track if an q entry is
+ in use and when it should be reported back to the user. */
+ atomic_t usecount;
Please use a kref here instead of rolling your own
documentation to the Documentation
directory.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.11-rc4/include/linux/kref.h
===
--- linux-2.6.11-rc4.orig/include/linux/kref.h
+++ linux-2.6.11-rc4/include/linux/kref.h
@@ -28,5
Sergey Vlasov wrote:
On Sat, 26 Feb 2005 09:55:41 -0600 Corey Minyard wrote:
Greg,
This is the patch for krefs that we talked about. If you don't like it
but like the docs, feel free just to take the documentation and cut out
the stuff at the end about the new operation.
See below
Arjan van de Ven wrote:
On Tue, 2005-03-01 at 12:15 -0800, Greg KH wrote:
On Sat, Feb 26, 2005 at 04:23:04PM -0600, Corey Minyard wrote:
Add a routine to kref that allows the kref_put() routine to be
unserialized even when the get routine attempts to kref_get()
an object without first
Arjan van de Ven wrote:
Just doing an atomic operation is not faster than doing a lock, an
atomic operation, then an unlock? Am I missing something?
if the lock and the atomic are on the same cacheline they're the same
cost on most modern cpus...
Ah, I see. Not likely to ever be the
Nick Piggin wrote:
Corey Minyard wrote:
Arjan van de Ven wrote:
Just doing an atomic operation is not faster than doing a lock, an
atomic operation, then an unlock? Am I missing something?
if the lock and the atomic are on the same cacheline they're the same
cost on most modern cpus...
Ah
Greg,
Here is the documentation for krefs, with the kref_checked
stuff removed and a few other things cleaned up.
-Corey
Add some documentation for krefs.
Signed-off-by: Corey Minyard [EMAIL PROTECTED]
Index: linux-2.6.11-rc5-mm1/Documentation/kref.txt
1 - 100 of 1178 matches
Mail list logo
