Re: [PATCH] [v2] tools: testing: Remove duplicate includes

at line 19, so remove the > duplicate one at line 23. For this one I checked the file. Indeed there is another inttypes.h, so this is also correct. Again, all the automated checks pass. (although I don't think any of the automated builds include selftests.) So: Reviewed-by: Daniel Axtens Ki

Re: [PATCH] [v2] arch: powerpc: Remove duplicate includes

ate between hugetlb and THP during page walk"). How odd! Anyway, all of these look good to me, and the automated checks at http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210323062916.295346-1-wanjiab...@vivo.com/ have all passed. Reviewed-by: Daniel Axtens Kind regards, Daniel

Re: [PATCH -next] powerpc/eeh: Remove unused inline function eeh_dev_phb_init_dynamic()

Out of interest, what tool are you using to find these unused inlines? If there are many more, it might make sense to combine future patches removing them into a single patch, but I'm not sure. checkpatch likes this patch, so that's also good :) Reviewed-by: Daniel Axtens Kind regards, Daniel

Re: [PATCH -next] powerpc/smp: Remove unused inline functions

ework the secondary inhibit code") I don't think this warrants another revision, I think leaving the commit name on one line makes sense. Reviewed-by: Daniel Axtens Kind regards, Daniel > Signed-off-by: YueHaibing > --- > arch/powerpc/include/asm/smp.h | 2 -- > 1 file c

Re: [PATCH] selftests: powerpc: unmark non-kernel-doc comments

othing else we'd really want to clean up while you're doing cleanups. Reviewed-by: Daniel Axtens Kind regards, Daniel > > Signed-off-by: Randy Dunlap > Cc: Michael Ellerman > Cc: linuxppc-...@lists.ozlabs.org > --- > tools/testing/selftests/powerpc/tm/tm-trap.c |4 +

Re: [PATCH v2 07/15] powerpc/uaccess: Call might_fault() inconditionaly

Daniel Axtens writes: > Hi Christophe, > >> Commit 6bfd93c32a50 ("powerpc: Fix incorrect might_sleep in >> __get_user/__put_user on kernel addresses") added a check to not call >> might_sleep() on kernel addresses. This was to enable the use of >> __get_u

Re: [PATCH v2 07/15] powerpc/uaccess: Call might_fault() inconditionaly

ult_disabled()?) (But I haven't tested this yet, so it's possible I misunderstood something.) Do you expect any consequences if we've missed a case where __(get|put)_user is called on a kernel address because it hasn't been converted to use better helpers yet? Kind regards, Daniel > > Si

Re: [PATCH v2 06/15] powerpc/align: Don't use __get_user_instr() on kernel addresses

r userspace access. > > In alignment exception handler, use probe_kernel_read_inst() > instead of __get_user_instr() for reading instructions in kernel. > > This will allow to remove the is_kernel_addr() check in > __get/put_user() in a following patch. > Looks good to me! Reviewed-b

Re: [PATCH v2 05/15] powerpc/uaccess: Move get_user_instr helpers in asm/inst.h

of the other places in arch/powerpc/include that currently reference ppc_inst seem any better... If we do use asm/inst.h, I think maybe it makes sense to put the code towards the end rather than at the start, as uses structs and calls macros that are defined later on in the function. Kind reg

Re: [PATCH 3/3] mm: unexport follow_pfn

On Wed, Mar 24, 2021 at 08:17:10PM +0100, Daniel Vetter wrote: > On Wed, Mar 24, 2021 at 09:52:11AM -0300, Jason Gunthorpe wrote: > > On Tue, Mar 16, 2021 at 04:33:03PM +0100, Daniel Vetter wrote: > > > Both kvm (in bd2fae8da794 ("KVM: do not assume PTE is writable

Re: [PATCH v2 4/7] CMDLINE: powerpc: convert to generic builtin command line

On Wed, Mar 24, 2021 at 04:31:35PM +0100, Christophe Leroy wrote: > > > Le 09/03/2021 à 22:40, Daniel Walker a écrit : > > On Tue, Mar 09, 2021 at 08:56:47AM +0100, Christophe Leroy wrote: > > > > > > > > > Le 09/03/2021 à 01:02, Daniel Walker a écr

Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline

doesn't solve the needs of Cisco, I've stated many times your changes have little value. Please stop submitting them. Daniel

Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline

er, and it would override the PREPEND values. Can you imagine you have a default command line which makes root=/dev/issblk0 , but that doesn't work for you testing purpose. So you input into the boot loader root=/dev/sda1 , since you have the default input in the bootloader OVERRIDEABLE you can do this without re-compiling and just input the single root= command into the bootloader. Daniel

[PATCH] thermal/drivers/netlink: Add the temperature when crossing a trip point

violation notification. In order to be efficient, give the temperature which resulted in the trip violation. Signed-off-by: Daniel Lezcano --- drivers/thermal/thermal_core.c| 6 -- drivers/thermal/thermal_netlink.c | 11 ++- drivers/thermal/thermal_netlink.h | 8 include

Re: [PATCH v2] Bluetooth: Always call advertising disable before setting params

this race condition, so if the maintainers are happy with it, I can look into changing the test expectations to suit the new scenario. Please advise. Thanks in advance, Daniel On Wed, Mar 24, 2021 at 11:47 AM Daniel Winkler wrote: > > In __hci_req_enable_advertising, the HCI_LE_ADV hde

[PATCH] i2c: designware: Add base addr info

root@qt5222:~# i2cdetect -l | grep -i desig i2c-1 i2c Synopsys DesignWare I2C adapter at 0xfedc5000 I2C adapter i2c-0 i2c Synopsys DesignWare I2C adapter at 0xfedc4000 I2C adapter Signed-off-by: Daniel Gomez --- Hi, We think it might be interesting to add the physical

Re: [PATCH v5 5/6] backlight: rt4831: Adds support for Richtek RT4831 backlight

On Thu, Mar 25, 2021 at 04:22:11PM +0800, ChiYuan Huang wrote: > Dear reviewers: > >Didn't get any response about this backlight patch. > Is there any part need to be refined? Thanks for the reminders and sorry for the delay. Have just replied to the original message! Daniel.

Re: [PATCH v5 5/6] backlight: rt4831: Adds support for Richtek RT4831 backlight

t; + > + ret = device_property_read_u8(dev, "richtek,channel-use", ); > + if (ret) { > + dev_err(dev, "richtek,channel-use DT property missing\n"); > + return ret; > + } > + > + if (!(propval & RT4831_BLCH_MASK)) { > + dev_err(dev, "No channel specified\n"); > + return -EINVAL; > + } > + > + return regmap_update_bits(priv->regmap, RT4831_REG_ENABLE, > RT4831_BLCH_MASK, propval); > +} > + > +static int rt4831_bl_probe(struct platform_device *pdev) > +{ > + struct rt4831_priv *priv; > + struct backlight_properties bl_props = { .type = BACKLIGHT_RAW, }; In new drivers please make sure to correctly set props.scale so that the backlight slider can be mapped correctly (see Documentation/ABI/testing/sysfs-class-backlight for description of the options). Daniel.

[PATCH v2] ASoC: core: Don't set platform name when of_node is set

From: Daniel Baluta A DAI link has 3 components: * CPU * platform * codec(s) A component is specified via: * name * of_node * dai_name In order to avoid confusion when building a sound card we disallow matching by both name and of_node (1

[PATCH] kgdbts: Switch to do_sys_openat2() for breakpoint testing

address because this is more or less what kdb does in the same circumstances. Re-implement lookup_addr() to be based on kallsyms rather than function pointers. Signed-off-by: Daniel Thompson --- Notes: So less than a week ago I said I had nothing pending for kgdbts. That was entirely true

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

> > would benefit from better handling of this mismatch. > > > >> On top of this, unless we want to do the walk trying increasingly smaller > >> sizes of vmf_insert_xxx(), we'd have to use apply_to_page_range() and teach > >> it about transhuge page table

Re: [PATCH] drivers: gpu: drm: xen_drm_front_drm_info is declared twice

On Thu, Mar 25, 2021 at 10:16 AM Daniel Vetter wrote: > > On Thu, Mar 25, 2021 at 7:53 AM Oleksandr Andrushchenko > wrote: > > > > Hi, > > > > On 3/25/21 8:19 AM, Wan Jiabing wrote: > > > struct xen_drm_front_drm_info has been declared. > > > R

Re: [PATCH] drivers: gpu: drm: xen_drm_front_drm_info is declared twice

-i-apply-my-patch We need to hard-reset drm-misc-next-fixes back, please re-apply the patches (both of them) to drm-misc-fixes. Also adding drm-misc maintainers. -Daniel > > Thank you, > > Oleksandr > > > --- > > drivers/gpu/drm/xen/xen_drm_front_conn.h |

Re: [PATCH v2] drivers/clocksource/mediatek: Ack and disable interrupts on shutdown

On 25/03/2021 02:35, Evan Benn wrote: > set_state_shutdown is called during system suspend after interrupts have > been disabled. If the timer has fired in the meantime, there will be > a pending IRQ. So we ack that now and disable the timer. Without this > ARM trusted firmware will abort the

[PATCH] vfio/type1: Empty batch for pfnmap pages

pinning") Link: https://lkml.kernel.org/r/20210323133254.33ed9...@omen.home.shazbot.org/ Reported-by: Alex Williamson Suggested-by: Alex Williamson Signed-off-by: Daniel Jordan --- Alex, I couldn't immediately find a way to trigger this bug, but I can run your test case if you like. This i

Re: [PATCH 3/3] mm: unexport follow_pfn

On Wed, Mar 24, 2021 at 09:52:11AM -0300, Jason Gunthorpe wrote: > On Tue, Mar 16, 2021 at 04:33:03PM +0100, Daniel Vetter wrote: > > Both kvm (in bd2fae8da794 ("KVM: do not assume PTE is writable after > > follow_pfn")) and vfio (in 07956b6269d3 ("vfio/type1: Use

Re: [PATCH] Bluetooth: Always call advertising disable before setting params

Hello Marcel, Thank you for the feedback. I have just sent a V2 with a btmon snippet showing the HCI Set Advertising Parameters "Command Disallowed" failure that occurs as a result of this issue. I tried to provide some annotation for context. Please take a look. Thanks! Daniel On W

[PATCH v2] Bluetooth: Always call advertising disable before setting params

from Any (0x00) > HCI Event: Command Complete (0x0e) plen 4 #232 [hci0]04:06.005 LE Set Advertising Parameters (0x08|0x0006) ncmd 1 Status: Command Disallowed (0x0c) Reviewed-by: Miao-chen Chou Signed-off-by: Daniel Winkler --- Changes in v2: - Added btmon snippet showi

Re: [PATCH] i915_vma: Rename vma_lookup to i915_vma_lookup

ffling going on right now so unusal path, it should show up in linux-next through drm-next hopefully this week still. -Daniel > --- > drivers/gpu/drm/i915/i915_vma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_vma.c b/driv

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

tel.com > > > Hmm, yes with that patch it will obviously not work as intended. > > Given that, I think we'll need to disable the TTM huge pages for now until > we can sort out and agree on using a page table entry bit. Yeah :-/ I think going full pud/pmd_mkspecial shoul

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

ike this code to install "pte_special" huge pages does > > not belong in the drm subsystem.. > > I could add helpers in huge_memory.c: > > vmf_insert_pfn_pmd_prot_special() and > vmf_insert_pfn_pud_prot_special() The somewhat annoying thing is that we'd need an error code so we fall back to pte fault handling. That's at least my understanding of how pud/pmd fault handling works. Not sure how awkward that is going to be with the overall fault handling flow. But aside from that I think this makes tons of sense. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH v2 1/3] drm: bridge/panel: Cleanup connector on bridge detach

On Wed, Mar 24, 2021 at 04:15:37AM +0200, Laurent Pinchart wrote: > On Wed, Jan 20, 2021 at 06:38:03PM +0100, Daniel Vetter wrote: > > On Wed, Jan 20, 2021 at 6:12 PM Paul Cercueil wrote: > > > Le mer. 20 janv. 2021 à 17:03, Daniel Vetter a écrit : > > > > On Wed

Re: [PATCH v2 0/5] arm64: sunxi: Enable the sun4i timer

On 24/03/2021 04:51, Samuel Holland wrote: > On 3/22/21 9:18 AM, Daniel Lezcano wrote: >> On 22/03/2021 05:47, Samuel Holland wrote: >>> In preparation for adding CPU idle states, hook up the sun4i timer. >>> Having a non-c3stop clockevent source available is

Re: [PATCH v2 3/3] vfio/type1: Batch page pinning

; pfn++, pinned--) > put_pfn(pfn, dma->prot); > } > vfio_batch_unpin(batch, dma); > > (8) These calls to batch_unpin are rather precarious as well, any time > batch->size is > non-zero, we risk using the pages array for a pfnmap. We might actually > want the > above change in (7) moved into this exit path so that we can never return > a potential > pfnmap batch. Yes, the exit path seems like the right place for the fix. > > return ret; } > > return pinned; > } > > This is a regression that not only causes incorrect mapping for the > user, but also allows the user to trigger bad page counts, so we need > a fix for v5.12. Sure, I can test a fix after I get your thoughts on the above. Daniel

[PATCH] Bluetooth: Always call advertising disable before setting params

ctive. Reviewed-by: Miao-chen Chou Signed-off-by: Daniel Winkler --- net/bluetooth/hci_request.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c index 8ace5d34b01efe..2b4b99f4cedf21 100644 --- a/net/bluetooth/hci_

Re: [PATCH] powercap/drivers/dtpm: Add dtpm devfreq with energy model support

On 23/03/2021 16:56, Lukasz Luba wrote: > Hi Daniel, > > On 3/19/21 4:28 PM, Daniel Lezcano wrote: >> Currently the dtpm supports the CPUs via cpufreq and the energy >> model. This change provides the same for the device which supports >> devfreq. >> >> Ea

Re: [PATCH] powercap/drivers/dtpm: Add dtpm devfreq with energy model support

On 23/03/2021 16:56, Lukasz Luba wrote: > Hi Daniel, > > On 3/19/21 4:28 PM, Daniel Lezcano wrote: >> Currently the dtpm supports the CPUs via cpufreq and the energy >> model. This change provides the same for the device which supports >> devfreq. >> >> Ea

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

d error appears corrected but in fact is not. > > We need to understand what status are available and write the > appropriate vendor code. Ok. Glad we checked then :). Before sending again I will recheck how the ECC status is read and fix that up. Thanks, Daniel

Re: [RFC PATCH 2/2] mm,drm/ttm: Use VM_PFNMAP for TTM vmas

ld not be a performance difference anymore, but this > needs to be verified. > > Cc: Christian Koenig > Cc: David Airlie > Cc: Daniel Vetter > Cc: Andrew Morton > Cc: Jason Gunthorpe > Cc: linux...@kvack.org > Cc: dri-de...@lists.freedesktop.org > Cc: linux-kern

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

perations total): Page reads with 0 corrected bit errors: 845 Page reads with 1 corrected bit errors: 0 Page reads with 2 corrected bit errors: 0 Page reads with 3 corrected bit errors: 0 I guess this means ECC is there and it's working. Thanks, Daniel

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

to other graphis drivers moving forward as well. > > Cc: Christian Koenig > Cc: David Airlie > Cc: Daniel Vetter > Cc: Andrew Morton > Cc: Jason Gunthorpe > Cc: linux...@kvack.org > Cc: dri-de...@lists.freedesktop.org > Cc: linux-kernel@vger.kernel.org > Signed-off-b

Re: [PATCH 2/2] video: backlight: qcom-wled: Add PMI8994 compatible

On Tue, Mar 23, 2021 at 08:39:35AM +, Lee Jones wrote: > On Mon, 22 Mar 2021, Daniel Thompson wrote: > > > On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > > > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP. > > > >

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

ich triggered this discussion, > so I guess it's a good time to respin. I'll resend it. I've added support for the 2Gb version in the meantime so I need to resend it either way. Thanks, Daniel

Re: [PATCH] backlight: journada720: fix Wmisleading-indentation warning

c0d17 ("backlight: Adds HP Jornada 700 series backlight driver") > Signed-off-by: Arnd Bergmann I'm dubious that the re-indent matches the original authors intent... but it certainly does match what was actually written and tested so on that basis: Reviewed-by: Daniel Thompson Dani

Re: [PATCH] media: test-drivers: Remove duplicate include of string.h

Hi Wan, thanks for the patch! Unfortunately, however, a similar patch has already been accepted [1] [1] https://patchwork.linuxtv.org/project/linux-media/patch/20210306113255.217387-1-zhang.yun...@zte.com.cn/ -- thanks -- Daniel

Re: [PATCH v11 0/6] KASAN for powerpc64 radix

having a valid PACA, it doesn't mean that it's safe in any other sense. - KVM does indeed also run stuff with translations off but we can catch all of that by disabling instrumentation on the real-mode handlers: it doesn't seem to leak out to generic code. So you are right that

Re: [PATCH] kgdb: fix gcc-11 warning on indentation

! So, whilst I think you are probably right, v2printk() does appears in places such as the single step test loop which makes it pretty difficult to decide by inspection whether or not touching the watchdog is useful. It's something that could be further examined... but I'd be a little reluctant to combine it directly with a whitespace change! Daniel.

Re: [PATCH 1/2] clocksource/drivers/timer-ti-dm: Prepare to handle dra7 timer wrap issue

On 22/03/2021 17:33, Tony Lindgren wrote: > Hi, > > * Daniel Lezcano [210322 15:56]: >> On 04/03/2021 08:37, Tony Lindgren wrote: >>> There is a timer wrap issue on dra7 for the ARM architected timer. >>> In a typical clock configuration the timer fails to wra

Re: [PATCH] kgdb: fix gcc-11 warning on indentation

ndent it for readability. > > Fixes: e8d31c204e36 ("kgdb: add kgdb internal test suite") > Signed-off-by: Arnd Bergmann Acked-by: Daniel Thompson Which tree do you want to merge this one though? I've got nothing else pending for this file so I am very relaxed about the route..

Re: [PATCH V2] kernel: debug: Ordinary typo fixes in the file gdbstub.c

On Wed, Mar 17, 2021 at 04:16:58PM +0530, Bhaskar Chowdhury wrote: > s/overwitten/overwritten/ > s/procesing/processing/ > > Signed-off-by: Bhaskar Chowdhury Applied, Thanks! Daniel. > --- > Changes from V1: > As Daniel pointed out, I was misdoing a check,so correct

Re: [PATCH 2/2] video: backlight: qcom-wled: Add PMI8994 compatible

On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP. > > Signed-off-by: Konrad Dybcio Reviewed-by: Daniel Thompson Daniel. > --- > drivers/video/backlight/qcom-wled.c | 1 + > 1 file ch

Re: [PATCH 1/2] dt-bindings: leds: backlight: qcom-wled: Add PMI8994 compatible

On Sun, Feb 28, 2021 at 01:41:04PM +0100, Konrad Dybcio wrote: > Document the newly added PMI8994 compatible. > > Signed-off-by: Konrad Dybcio (For Lee) Acked-by: Daniel Thompson Daniel. > --- > Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml | 1 + >

Re: [PATCH v5] kdb: Simplify kdb commands registration

On Wed, Feb 24, 2021 at 12:38:27PM +0530, Sumit Garg wrote: > Simplify kdb commands registration via using linked list instead of > static array for commands storage. > > Signed-off-by: Sumit Garg Applied, thanks! > --- > > Changes in v5: > - Introduce new method: kdb_register_table() to

Re: [PATCH 1/2] clocksource/drivers/timer-ti-dm: Prepare to handle dra7 timer wrap issue

On 04/03/2021 08:37, Tony Lindgren wrote: > There is a timer wrap issue on dra7 for the ARM architected timer. > In a typical clock configuration the timer fails to wrap after 388 days. > > To work around the issue, we need to use timer-ti-dm timers instead. > > Let's prepare for adding support

Re: [PATCH v2 0/5] arm64: sunxi: Enable the sun4i timer

On 22/03/2021 05:47, Samuel Holland wrote: > In preparation for adding CPU idle states, hook up the sun4i timer. > Having a non-c3stop clockevent source available is necessary for all > CPUs to simultaneously enter a local-timer-stop idle state. Why simultaneously ? > Changes from v1: > -

Re: [PATCH 2/2] vgaarb: avoid -Wempty-body warnings

ied to drm-misc-next for 5.13, thanks for your patches. -Daniel > --- > include/linux/vgaarb.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h > index fc6dfeba04a5..dc6ddce92066 100644 > --- a/include

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

.1z..C.H| OOB Data: 52 05 b2 f1 65 64 59 22 79 50 ec 89 55 6b 6e 23 |R...edY"yP..Ukn#| I think this shows that the datasheet is right in that the complete 64 bytes of "spare area" is usable. I have no idea where it puts the ECC though. :) Thanks, Daniel

Re: drivers/clocksource/dw_apb_timer_of.c:66 timer_get_base_and_rate() warn: 'timer_clk' not released on lines: 64.

On 22/03/2021 13:21, Dinh Nguyen wrote: > Hi Daniel, > > 2/21 4:58 AM, Daniel Lezcano wrote: >> >> Dinh, >> >> is it possible to have a look at this issue? >> >> Thanks >> > > Sorry, but somehow I missed cc'ing you when I first sent the

Re: [PATCH 1/2] drivers/clocksource/mediatek: Split mediatek drivers into 2 files

Hi Evan, On 18/03/2021 06:04, Evan Benn wrote: > mtk_gpt and mtk_syst drivers for mt6577 and mt6765 devices were not > sharing any code. So split them into separate files. For the sake of consistency, keeping all in one is better. Thanks -- Daniel > Signed-off-by:

Re: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages

On Mon, 22 Mar 2021 at 11:34, Christian König wrote: > > Hi Daniel, > > Am 22.03.21 um 10:38 schrieb Daniel Gomez: > > On Fri, 19 Mar 2021 at 21:29, Felix Kuehling wrote: > >> This caused a regression in kfdtest in a large-buffer stress test after > >> me

Re: [PATCH 10/14] clocksource/drivers/npcm: Add support for WPCM450

On 20/03/2021 19:16, Jonathan Neuschäfer wrote: > Add a compatible string for WPCM450, which has essentially the same > timer controller. > > Signed-off-by: Jonathan Neuschäfer > --- Applied, thanks -- Linaro.org │ Open source software for ARM SoCs Follow Linaro:

Re: [PATCH 2/2] clocksource/drivers/timer-ti-dm: Handle dra7 timer wrap errata i940

On 04/03/2021 08:37, Tony Lindgren wrote: > There is a timer wrap issue on dra7 for the ARM architected timer. > In a typical clock configuration the timer fails to wrap after 388 days. > > To work around the issue, we need to use timer-ti-dm percpu timers instead. > > Let's configure dmtimer3

Re: [PATCH] clocksource/drivers/timer-mediatek: optimize systimer irq clear flow on Mediatek Socs

On 02/03/2021 08:28, Fengquan Chen wrote: > 1)ensure systimer is enabled before clear and disable interrupt, which only > for systimer in Mediatek Socs. > > 2)clear any pending timer-irq when shutdown to keep suspend flow clean, > when use systimer as tick-broadcast timer > > Change-Id:

Re: drivers/clocksource/dw_apb_timer_of.c:66 timer_get_base_and_rate() warn: 'timer_clk' not released on lines: 64.

Dinh, is it possible to have a look at this issue? Thanks -- Daniel On 22/02/2021 07:21, Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 55f62bc873477dae2c45bbbc30b86cf3e0982f3b

Re: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages

unction amdgpu_ttm_backend_unbind returns without trying to clear the userptr memory? Something like: amdgpu_ttm_backend_bind: if (gtt->userptr) { r = amdgpu_ttm_tt_pin_userptr(bdev, ttm); if (r) ... gtt->sg_table = true; } amdgpu_ttm_backend_unbind: if (gtt->sg

Re: [PATCH] thermal/drivers/cpuidle_cooling: Fix use after error

On 22/03/2021 04:29, Viresh Kumar wrote: > On 19-03-21, 21:25, Daniel Lezcano wrote: >> When the function successfully finishes it logs an information about >> the registration of the cooling device and use its name to build the >> message. Unfortunately it was freed right

Re: [PATCH v11 6/6] powerpc: Book3S 64-bit outline-only KASAN support

Balbir Singh writes: > On Mon, Mar 22, 2021 at 11:55:08AM +1100, Daniel Axtens wrote: >> Hi Balbir, >> >> > Could you highlight the changes from >> > https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170729140901.5887-1-bsinghar...@gmail.com/? >>

Re: [PATCH v11 6/6] powerpc: Book3S 64-bit outline-only KASAN support

e > #define VMEMMAP_END R_VMEMMAP_END > and ditto for hash we probably need > > BUILD_BUG_ON(VMEMMAP_END + KASAN_SHADOW_OFFSET != KASAN_SHADOW_END); Sorry, I'm not sure what this is supposed to be testing? In what situation would this trigger? Kind regards, Daniel > > Looks good otherwise, I've not been able to test it yet > > Balbir Singh.

Re: [PATCH v11 1/6] kasan: allow an architecture to disable inline instrumentation

Balbir Singh writes: > On Sat, Mar 20, 2021 at 01:40:53AM +1100, Daniel Axtens wrote: >> For annoying architectural reasons, it's very difficult to support inline >> instrumentation on powerpc64. > > I think we can expand here and talk about how in hash mode, the vm

Re: [PATCH 2/3] clocksource/drivers/timer-ti-dm: Remove extra of_node_put()

>> ? >> >> Oh right.. this is confusing.. Yeah we can ignore this patch. >> We should have the use count set for only the system timer(s) >> we claim. > > Daniel, would you like me to repost this series with this patch dropped? No, it is ok. I will take c

Re: [RESEND PATCH v4 1/2] dt-bindings: tsens: qcom: Document MDM9607 compatible

On 20/03/2021 20:01, Konrad Dybcio wrote: > Add the compatible for MDM9607. >> Signed-off-by: Konrad Dybcio >> --- >> v4: separate from the main patch >> >> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 2 ++ >> 1 file changed, 2 insertions(+) > > This change was previously a-b

[ANNOUNCE] 4.4.262-rt219

Enjoy! Daniel

Re: [PATCH v3] bpf: Fix memory leak in copy_process()

On 3/17/21 4:09 AM, qiang.zh...@windriver.com wrote: From: Zqiang The syzbot report a memleak follow: BUG: memory leak unreferenced object 0x888101b41d00 (size 120): comm "kworker/u4:0", pid 8, jiffies 4294944270 (age 12.780s) backtrace: [] alloc_pid+0x66/0x560 []

[PATCH] thermal/drivers/cpuidle_cooling: Fix use after error

. Fix this by freeing after the message happened. Fixes: 6fd1b186d900 ("thermal/drivers/cpuidle_cooling: Use device name instead of auto-numbering") Reported-by: Dan Carpenter Signed-off-by: Daniel Lezcano --- drivers/thermal/cpuidle_cooling.c | 8 +--- 1 file changed, 5 insert

[PATCH] thermal/drivers/devfreq_cooling: Fix wrong return on error path

oling: Use device name instead of auto-numbering") Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Daniel Lezcano --- drivers/thermal/devfreq_cooling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/devfreq_cooling.c b/drive

[PATCH] thermal: core: Fix memory leak in the error path

inter for the cooling device name") Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Daniel Lezcano --- drivers/thermal/thermal_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index c8d4010940ef..3566fd291

Re: [PATCH] dt: rockchip: rk3399: Add dynamic power coefficient for GPU

On 19/03/2021 19:05, Robin Murphy wrote: > On 2021-03-19 14:35, Daniel Lezcano wrote: >> >> Hi Robin, >> >> On 19/03/2021 13:17, Robin Murphy wrote: >>> On 2021-03-19 11:05, Daniel Lezcano wrote: >>>> The DTPM framework is looking for upstrea

Re: [RESEND 00/53] Rid GPU from W=1 warnings

On Fri, Mar 19, 2021 at 08:24:07AM +, Lee Jones wrote: > On Thu, 18 Mar 2021, Daniel Vetter wrote: > > > On Wed, Mar 17, 2021 at 9:32 PM Daniel Vetter wrote: > > > > > > On Wed, Mar 17, 2021 at 9:17 AM Lee Jones wrote: > > > > &g

Re: [PATCH v2] kdb: Get rid of custom debug heap allocator

On Mon, Mar 01, 2021 at 11:33:00AM +0530, Sumit Garg wrote: > On Fri, 26 Feb 2021 at 23:07, Daniel Thompson > wrote: > > > > On Fri, Feb 26, 2021 at 06:12:13PM +0530, Sumit Garg wrote: > > > On Fri, 26 Feb 2021 at 16:29, Daniel Thompson > > > wrote: > >

Re: [PATCH] kdb: Refactor kdb_defcmd implementation

gets registers using kdb_register_table() but it keeps the macro code all in once place: kdb_register_table(>cmd, 1); I think that is what I *meant* to suggest ;-) . It also avoids having to talk about sub-commands! BTW I'm open to giving defcmd_set a better name (kdb_macro?) but I don't see why we want to give all commands a macro list. Daniel.

[PATCH] powercap/drivers/dtpm: Add dtpm devfreq with energy model support

dtpm support: the QoS is used to aggregate the requests and the energy model gives the value of the instantaneous power consumption ponderated by the load of the device. Cc: Chanwoo Choi Cc: Lukasz Luba Cc: Kyungmin Park Cc: MyungJoo Ham Signed-off-by: Daniel Lezcano --- drivers/powercap

Re: [PATCH] MAINTAINERS: Add co-maintainer for Qualcomm tsens thermal drivers

On 19/03/2021 16:37, Thara Gopinath wrote: > Add myself as the maintainer for Qualcomm tsens drivers so that I > can help Daniel by taking care of/reviewing changes to these drivers. > > Signed-off-by: Thara Gopinath > --- Applied, thanks -- <http://www.linaro.org/> Lin

Re: linux-next: manual merge of the net-next tree with the net tree

On 3/19/21 4:33 PM, Alexei Starovoitov wrote: On Fri, Mar 19, 2021 at 8:17 AM Yonghong Song wrote: On 3/19/21 12:21 AM, Daniel Borkmann wrote: On 3/19/21 3:11 AM, Piotr Krysiuk wrote: Hi Daniel, On Fri, Mar 19, 2021 at 12:16 AM Stephen Rothwell wrote: diff --cc kernel/bpf/verifier.c

[PATCH v11 4/6] kasan: Document support on 32-bit powerpc

KASAN is supported on 32-bit powerpc and the docs should reflect this. Suggested-by: Christophe Leroy Reviewed-by: Christophe Leroy Signed-off-by: Daniel Axtens --- Documentation/dev-tools/kasan.rst | 8 ++-- Documentation/powerpc/kasan.txt | 12 2 files changed, 18

[PATCH v11 5/6] powerpc/mm/kasan: rename kasan_init_32.c to init_32.c

kasan is already implied by the directory name, we don't need to repeat it. Suggested-by: Christophe Leroy Signed-off-by: Daniel Axtens --- arch/powerpc/mm/kasan/Makefile | 2 +- arch/powerpc/mm/kasan/{kasan_init_32.c => init_32.c} | 0 2 files changed, 1 insertion(+)

[PATCH v11 6/6] powerpc: Book3S 64-bit outline-only KASAN support

future. Cc: Balbir Singh # ppc64 out-of-line radix version Cc: Aneesh Kumar K.V # ppc64 hash version Cc: Christophe Leroy # ppc32 version Signed-off-by: Daniel Axtens --- Documentation/dev-tools/kasan.rst| 11 +-- Documentation/powerpc/kasan.txt | 48 +- arch/

[PATCH v11 1/6] kasan: allow an architecture to disable inline instrumentation

disable stack instrumentation in this case as it does things that are functionally equivalent to inline instrumentation, namely adding code that touches the shadow directly without going through a C helper. Signed-off-by: Daniel Axtens --- lib/Kconfig.kasan | 8 1 file changed, 8

[PATCH v11 2/6] kasan: allow architectures to provide an outline readiness check

in outline mode, so an arch must specify ARCH_DISABLE_KASAN_INLINE if it requires this. Cc: Balbir Singh Cc: Aneesh Kumar K.V Suggested-by: Christophe Leroy Signed-off-by: Daniel Axtens -- I discuss the justfication for this later in the series. Also, both previous RFCs for ppc64 - by 2 different

[PATCH v11 3/6] kasan: define and use MAX_PTRS_PER_* for early shadow tables

at the moment, just define them in the kasan header, and have them default to PTRS_PER_* unless overridden in arch code. Suggested-by: Christophe Leroy Suggested-by: Balbir Singh Reviewed-by: Christophe Leroy Reviewed-by: Balbir Singh Signed-off-by: Daniel Axtens --- include/linux/kasan.h | 18

[PATCH v11 0/6] KASAN for powerpc64 radix

in arch/powerpc/kvm is instrumented. It's also potentially a bit fragile - if any real mode code paths call out to instrumented code, things will go boom. Kind regards, Daniel Daniel Axtens (6): kasan: allow an architecture to disable inline instrumentation kasan: allow architectures to provide

Re: [PATCH] dt: rockchip: rk3399: Add dynamic power coefficient for GPU

Hi Robin, On 19/03/2021 13:17, Robin Murphy wrote: > On 2021-03-19 11:05, Daniel Lezcano wrote: >> The DTPM framework is looking for upstream SoC candidates to share the >> power numbers. >> >> We can see around different numbers but the one which seems to be >>

Re: [PATCH v1 2/2] arm64: dts: qcom: sm8350: Add thermal zones and throttling support

On 19/03/2021 12:24, Robert Foss wrote: > On Fri, 19 Mar 2021 at 11:49, Robert Foss wrote: >> >> sm8350 has 29 thermal sensors split across two tsens controllers. Add >> the thermal zones to expose them and wireup the cpus to throttle their >> frequencies on crossing passive temperature

Re: [net-next PATCH v7 04/16] of: mdio: Refactor of_phy_find_device()

On Wed, Mar 17, 2021 at 02:15:20PM +0530, Calvin Johnson wrote: > Hi Daniel, > > On Tue, Mar 16, 2021 at 07:17:19PM +0000, Daniel Thompson wrote: > > On Thu, Mar 11, 2021 at 11:49:59AM +0530, Calvin Johnson wrote: > > > Refactor of_phy_find_device() to us

[PATCH] dt: rockchip: rk3399: Add dynamic power coefficient for GPU

The DTPM framework is looking for upstream SoC candidates to share the power numbers. We can see around different numbers but the one which seems to be consistent with the initial post for the values on the CPUs can be found in the patch https://lore.kernel.org/patchwork/patch/810159/ I don't

Re: [PATCH v2 1/9] units: Add the HZ macros

Hi Rafael, is it possible to merge this series through linux-pm ? On 25/02/2021 12:22, Andy Shevchenko wrote: > On Wed, Feb 24, 2021 at 03:42:11PM +0100, Daniel Lezcano wrote: >> The macros for the unit conversion for frequency are duplicated in >> different places. >> &g

[PATCH v2 2/2] ext4: Optimize match for casefolded encrypted dirs

Matching names with casefolded encrypting directories requires decrypting entries to confirm case since we are case preserving. We can avoid needing to decrypt if our hash values don't match. Signed-off-by: Daniel Rosenberg --- fs/ext4/ext4.h | 17 --- fs/ext4/namei.c | 55

[PATCH v2 1/2] ext4: Handle casefolding with encryption

. The hash is stored at the end of the directory entry for all entries inside of an encrypted and casefolded directory apart from those that deal with '.' and '..'. This way, the change is backwards compatible with existing ext4 filesystems. Signed-off-by: Daniel Rosenberg --- Documentation

[PATCH v2 0/2] Reconcile Encryption and Casefolding in Ext4

of position -Assume last entry in directory will be csum for __ext4_check_entry if csum enabled This means we don't need to pass along lblk all over the place -Don't use siphash value for find_group_orlov, just use regular hash Daniel Rosenberg (2): ext4: Handle

Re: linux-next: manual merge of the net-next tree with the net tree

On 3/19/21 3:11 AM, Piotr Krysiuk wrote: Hi Daniel, On Fri, Mar 19, 2021 at 12:16 AM Stephen Rothwell wrote: diff --cc kernel/bpf/verifier.c index 44e4ec1640f1,f9096b049cd6.. --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@@ -5876,10 -6056,22 +6060,23 @@@ static int

[PATCH] powercap/drivers/dtpm : Fix power limit initialization

When a DTPM node is registered its power limit must be initialized to the power max. Signed-off-by: Daniel Lezcano --- drivers/powercap/dtpm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/powercap/dtpm.c b/drivers/powercap/dtpm.c index a4784ac2f79b

<    1   2   3   4   5   6   7   8   9   10   >