From: Stefan Rompf [EMAIL PROTECTED]
Date: Thu, 6 Dec 2007 09:49:01 +0100
If the connection cannot be established immediately and O_NONBLOCK is set
for
the file descriptor for the socket, connect() shall fail and set errno to
[EINPROGRESS], but the connection request shall not be aborted,
From: Stefan Rompf [EMAIL PROTECTED]
Date: Thu, 6 Dec 2007 11:56:48 +0100
Am Donnerstag, 6. Dezember 2007 09:53 schrieb David Miller:
I think the words shall fail and immediately are quite clear.
They are, but the context in which they apply is vague.
socket is connection-mode
]
Cc: David Miller [EMAIL PROTECTED]
Signed-off-by: WANG Cong [EMAIL PROTECTED]
Normally I would let a patch like this sit in my mailbox
for a week and then delete it.
But this time I'll just let you know up front that I
don't see much value in this patch. It is not a clear
improvement
From: Stefan Rompf [EMAIL PROTECTED]
Date: Thu, 6 Dec 2007 12:35:05 +0100
Because you just will put enough RAM modules into you server when
setting up a scalable system.
This suggestion is avoiding the important semantic issue, and
won't lead to a real discussion of the core problem.
--
To
From: Jesper Nilsson [EMAIL PROTECTED]
Date: Fri, 30 Nov 2007 16:13:29 +0100
^^^
Any particular reason for the 6 day long delay in these mails going
out or is your clock simply wrong?
As co-postmaster, I am noticing that your postings are bouncing at a
lot of sites because of
From: Stefan Rompf [EMAIL PROTECTED]
Date: Thu, 6 Dec 2007 13:30:20 +0100
IMHO this is what developers expect, and is also consistent with the
fact that POSIX does not define O_NONBLOCK behaviour for local
files.
You keep ignoring the fact that, as Herbert and I discussed, not
blocking for
From: Richard Knutsson [EMAIL PROTECTED]
Date: Thu, 06 Dec 2007 15:37:46 +0100
David Miller wrote:
But this time I'll just let you know up front that I
don't see much value in this patch. It is not a clear
improvement to replace int's with bool's in my mind and
the other changes
From: Stefan Rompf [EMAIL PROTECTED]
Date: Thu, 6 Dec 2007 15:31:53 +0100
as far as I've understood Herbert's patch, at least TCP connect can be fixed
so that non blocking connect() will neither fail nor block, but just use the
first or second retransmission of the SYN packet to complete the
From: Chris Friesen [EMAIL PROTECTED]
Date: Thu, 06 Dec 2007 14:36:54 -0600
One problem we ran into was that there are only 32 multicast groups per
netlink protocol family.
I'm pretty sure we've removed this limitation.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
From: Chris Friesen [EMAIL PROTECTED]
Date: Thu, 06 Dec 2007 22:21:39 -0600
David Miller wrote:
From: Chris Friesen [EMAIL PROTECTED]
Date: Thu, 06 Dec 2007 14:36:54 -0600
One problem we ran into was that there are only 32 multicast groups per
netlink protocol family.
I'm
From: Denis Cheng [EMAIL PROTECTED]
Date: Fri, 7 Dec 2007 00:09:43 +0800
single list_head variable initialized with LIST_HEAD_INIT could almost
always can be replaced with LIST_HEAD declaration, this shrinks the code
and looks better.
Signed-off-by: Denis Cheng [EMAIL PROTECTED]
Applied.
From: Denis Cheng [EMAIL PROTECTED]
Date: Fri, 7 Dec 2007 00:07:19 +0800
single list_head variable initialized with LIST_HEAD_INIT could almost
always can be replaced with LIST_HEAD declaration, this shrinks the code
and looks better.
Signed-off-by: Denis Cheng [EMAIL PROTECTED]
Applied.
From: Denis Cheng [EMAIL PROTECTED]
Date: Fri, 7 Dec 2007 00:04:36 +0800
single list_head variable initialized with LIST_HEAD_INIT could almost
always can be replaced with LIST_HEAD declaration, this shrinks the code
and looks better.
Signed-off-by: Denis Cheng [EMAIL PROTECTED]
Applied.
From: Denis Cheng [EMAIL PROTECTED]
Date: Fri, 7 Dec 2007 00:07:18 +0800
single list_head variable initialized with LIST_HEAD_INIT could almost
always can be replaced with LIST_HEAD declaration, this shrinks the code
and looks better.
Signed-off-by: Denis Cheng [EMAIL PROTECTED]
Applied.
From: Denis Cheng [EMAIL PROTECTED]
Date: Fri, 7 Dec 2007 00:01:26 +0800
single list_head variable initialized with LIST_HEAD_INIT could almost
always can be replaced with LIST_HEAD declaration, this shrinks the code
and looks better.
Signed-off-by: Denis Cheng [EMAIL PROTECTED]
Applied.
From: Denis Cheng [EMAIL PROTECTED]
Date: Fri, 7 Dec 2007 00:13:25 +0800
these three list_head are all local variables, but can also use LIST_HEAD.
Signed-off-by: Denis Cheng [EMAIL PROTECTED]
Applied.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a
From: Benjamin Herrenschmidt [EMAIL PROTECTED]
Date: Tue, 20 Nov 2007 06:51:14 +1100
On Mon, 2007-11-19 at 00:38 -0800, David Miller wrote:
From: Benjamin Herrenschmidt [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 16:35:23 +1100
You could make a dma_cacheline_aligned and use
From: David Brownell [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 11:59:55 -0800
This addition certainly won't hurt. Did we ever get any feedback as to
whether it actually helped?
ISTR that davem refused to try it, after reporting an
intermittent failure on the original patch (which only
Because sourceforge just farted another bounce at me
because someone CC:'d the sourceforge linux-usb-devel
list on a thread I was a part of, I've created:
[EMAIL PROTECTED]
so we don't need to have a subscriber-only-posting
mailing list for USB stuff.
-
To unsubscribe from this list:
From: Greg KH [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 14:54:55 -0800
Woah, the [EMAIL PROTECTED] list is NOT a subscriber-only list at
all. It's wide open with a bunch of mailman rule filter to try to
handle the worst of the spam.
It does complain if you try to add too many cc:s to it,
From: Benjamin Herrenschmidt [EMAIL PROTECTED]
Date: Tue, 20 Nov 2007 11:34:24 +1100
Do you still think we should introduce this __dma_cacheline_aligned ? Do
you see other cases of drivers where it would be useful ? It tend to
agree with your earlier statement that drivers doing that are
From: Stephane Eranian [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 12:53:30 -0800
In anycase, I would be happy to integrate your sparc64 patches.
I sent these to Philip Mucci late last night, but in the meantime
I finished implementing breakpoint support as well for pfmon.
Let me clean up my
From: Benjamin Herrenschmidt [EMAIL PROTECTED]
Date: Tue, 20 Nov 2007 11:55:01 +1100
BTW. What is the status nowadays with skb's ?
Good question.
Some drivers are problematic (or were) because they put
DMA descriptor chaining information at the head of the
buffer, but those have been fixed
From: Stephane Eranian [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 14:48:46 -0800
Looks like we will have to use bytes (u8) instead. This may have some
performance impact as well. Several bitmaps are used in the context/interrupt
routines. Even with u8, there is still a problem with the
From: [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 17:11:32 -0800
Before:
mov%gs:0x8,%rdx Get smp_processor_id
movtableoffset,%rax Get table base
incq varoffset(%rax,%rdx,1) Perform the operation with a complex lookup
adding the
From: Kay Sievers [EMAIL PROTECTED]
Date: Tue, 20 Nov 2007 02:33:43 +0100
Sounds all good. If that migration works well, please let us do the
same for hotplug.
Tell me what you'd like the list at vger to be named and I can
create it now.
THanks.
-
To unsubscribe from this list: send the line
From: Christoph Lameter [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 17:59:33 -0800 (PST)
In that case the generic fallbacks can just provide what you already
have.
I understand, I was just letting you know why we probably won't
take advantage of this new stuff :-)
-
To unsubscribe from this list:
From: H. Peter Anvin [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 18:00:23 -0800
Christoph Lameter wrote:
Support fast cpu ops in x86_64 by providing a series of functions that
generate the proper instructions. Define CONFIG_FAST_CPU_OPS so that core
code
can exploit the availability of
From: Greg KH [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 18:29:15 -0800
[EMAIL PROTECTED] would be great to have.
Created, enjoy.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Greg KH [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 19:12:32 -0800
Actually, if we are going to stick with this new list, can we just call
it [EMAIL PROTECTED] instead of the -devel stuff?
Done.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
From: Andi Kleen [EMAIL PROTECTED]
Date: Tue, 20 Nov 2007 04:25:34 +0100
Although we have a per-cpu area base in a fixed global register
for addressing, the above isn't beneficial on sparc64 because
the atomic is much slower than doing a:
local_irq_disable();
From: David Brownell [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 19:26:02 -0800
On Monday 19 November 2007, David Miller wrote:
From: Greg KH [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 19:12:32 -0800
Actually, if we are going to stick with this new list, can we just call
it [EMAIL
From: Adrian Bunk [EMAIL PROTECTED]
Date: Thu, 8 Nov 2007 04:30:10 +0100
@davem:
Please look at net/ipv4/arp.c:arp_process()
Am I right that CONFIG_NET_ETHERNET=n and CONFIG_NETDEV_1000=y or
CONFIG_NETDEV_1=y will not be handled correctly there?
And the best solution is to nuke
From: Francois Romieu [EMAIL PROTECTED]
Date: Wed, 14 Nov 2007 23:11:19 +0100
Rainer Jochem [EMAIL PROTECTED] :
[...]
--- net/ipv4/ipconfig.c.orig2007-11-14 09:16:15.800566536 +0100
+++ net/ipv4/ipconfig.c 2007-11-14 10:34:22.471219274 +0100
@@ -139,6 +139,8 @@ __be32
From: WANG Cong [EMAIL PROTECTED]
Date: Tue, 20 Nov 2007 13:39:05 +0800
And you mean abs() is not in glibc, then where is it? Built in gcc?
And what's more, why not put it in glibc?
Because the compiler knows things about the inputs and can
thus apply optimizations that a static implementation
From: Erik de Castro Lopo [EMAIL PROTECTED]
Date: Tue, 20 Nov 2007 16:22:25 +1100
I've just compiled 2.6.23.8 from kernel.org sources and I getting a
bunch of these soft lockups detected.
Yes, this is getting hit by everyone, a fix is in the works.
-
To unsubscribe from this list: send the
From: Julia Lawall [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 09:02:22 +0100 (CET)
From: Julia Lawall [EMAIL PROTECTED]
There should be a pci_dev_put when breaking out of a loop that iterates
over calls to pci_get_device and similar functions.
..
Signed-off-by: Julia Lawall [EMAIL PROTECTED]
From: Joe Perches [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 23:48:36 -0800
On Mon, 2007-11-19 at 23:45 -0800, David Miller wrote:
From: Joe Perches [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 17:47:58 -0800
Signed-off-by: Joe Perches [EMAIL PROTECTED]
Please check your patches, for trailing
From: Joe Perches [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 17:53:41 -0800
Signed-off-by: Joe Perches [EMAIL PROTECTED]
Applied.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Joe Perches [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 17:53:42 -0800
Signed-off-by: Joe Perches [EMAIL PROTECTED]
Applied.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Joe Perches [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 17:53:37 -0800
Signed-off-by: Joe Perches [EMAIL PROTECTED]
Applied.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Joe Perches [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 17:53:38 -0800
Signed-off-by: Joe Perches [EMAIL PROTECTED]
Applied.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Joe Perches [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 17:47:59 -0800
Signed-off-by: Joe Perches [EMAIL PROTECTED]
Applied.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Joe Perches [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 17:47:58 -0800
Signed-off-by: Joe Perches [EMAIL PROTECTED]
Please check your patches, for trailing white space.
Adds trailing whitespace.
diff:10:prom_printf(PCIC: Error, cannot map
Adds trailing whitespace.
diff:19:
From: Joe Perches [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 17:53:39 -0800
Signed-off-by: Joe Perches [EMAIL PROTECTED]
Applied.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Joe Perches [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 17:53:40 -0800
Signed-off-by: Joe Perches [EMAIL PROTECTED]
Applied.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Joe Perches [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 17:53:43 -0800
Signed-off-by: Joe Perches [EMAIL PROTECTED]
Applied.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Bill Fink [EMAIL PROTECTED]
Date: Tue, 20 Nov 2007 00:16:07 -0500
On Mon, 19 Nov 2007, Alexey Kuznetsov wrote:
2. What's about your suggestion, I thought about this and I am going to
agree.
Arguments, which convinced me are:
- arping still works.
- any piece of
From: Ulrich Drepper [EMAIL PROTECTED]
Date: Tue, 20 Nov 2007 01:53:14 -0500
FWIW, I think this indirect syscall stuff is the most ugly interface
I've ever seen proposed for the kernel.
And I agree with all of the objections raised by both H. Pater Anvin
and Eric Dumazet.
This patch adds
From: [EMAIL PROTECTED]
Date: Tue, 20 Nov 2007 18:26:26 +0800
cpu0 calling netif_rx_schedule_prep(), cpu1 calling dev_close():
cpu0: testing __LINK_STATE_START, already set
cpu1: clear__LINK_STATE_START
cpu1: testing __LINK_STATE_RX_SCHED, not set
cpu0: set __LINK_STATE_RX_SCHED
cpu0:
From: Ulrich Drepper [EMAIL PROTECTED]
Date: Tue, 20 Nov 2007 08:04:53 -0800
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
David Miller wrote:
Where does this INDIRECT_PARAM() macro get defined? I do not
see it being defined anywhere in these patches.
Defined in linux/indirect.h
From: Zach Brown [EMAIL PROTECTED]
Date: Tue, 20 Nov 2007 13:55:56 -0800
Not to belabor this point, but it was:
http://lkml.org/lkml/2007/11/20/53
$ grep -l INDIRECT_PARAM .git/patches/master/*
.git/patches/master/indirect-v4-4.patch
.git/patches/master/indirect-v4-5.patch
From: Ingo Molnar [EMAIL PROTECTED]
Date: Tue, 20 Nov 2007 22:49:27 +0100
* Greg KH [EMAIL PROTECTED] wrote:
On Tue, Nov 20, 2007 at 09:39:19PM +0100, Ingo Molnar wrote:
* Greg KH [EMAIL PROTECTED] wrote:
but we only have cpu_clock() from v2.6.23 onwards - so we should not
From: Cyrill Gorcunov [EMAIL PROTECTED]
Date: Tue, 20 Nov 2007 20:28:33 +0300
From: Cyrill Gorcunov [EMAIL PROTECTED]
This patch adds checking for possible NULL pointer dereference
if of_find_property() failed.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
Applied, thanks.
-
To
From: Jonas Danielsson [EMAIL PROTECTED]
Date: Tue, 20 Nov 2007 17:28:22 +0100
Fix arp reply when received arp probe with sender ip 0.
Send arp reply with target ip address 0.0.0.0 and target hardware address
set to hardware address of requester. Previously sent reply with target
ip address
From: Jeff Garzik [EMAIL PROTECTED]
Date: Wed, 21 Nov 2007 07:45:32 -0500
SO_NO_CHECK support for IPv6 appeared to be missing. This is presented,
based on a reading of net/ipv4/udp.c.
I wonder if IPv4's CHECKSUM_PARTIAL check from udp_push_pending_frames()
also needs to be copied to IPv6?
From: Wagner Ferenc [EMAIL PROTECTED]
Date: Wed, 21 Nov 2007 23:16:59 +0100
Hmm, that would warrant nuking all the reference counts on every
driver.
That's not true. When packets are in flight, references go
to the device and the device cannot be unloaded until those
references get dropped.
From: Jeff Garzik [EMAIL PROTECTED]
Date: Wed, 21 Nov 2007 19:17:40 -0500
YOSHIFUJI Hideaki / 吉藤英明 wrote:
In article [EMAIL PROTECTED] (at Wed, 21 Nov 2007 07:45:32 -0500), Jeff
Garzik [EMAIL PROTECTED] says:
SO_NO_CHECK support for IPv6 appeared to be missing. This is presented,
Thanks you for working proactively on these problems.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: [EMAIL PROTECTED] (Renzo Davoli)
Date: Fri, 7 Dec 2007 22:18:05 +0100
I disagree. If you suspect we would be better using IP multicast, I think
your suspects are not supported.
Try the following exercises, please Can you provide better solutions
without IPN?
I personally have not
From: Andrew Morton [EMAIL PROTECTED]
Date: Sat, 8 Dec 2007 10:22:39 -0800
That's
J_ASSERT_BH(bh, !buffer_jbddirty(bh));
at the end of journal_unmap_buffer().
I don't recall seeing that before and I can't think of anything we've
done recently which could cause it, sorry.
If
From: Julia Lawall [EMAIL PROTECTED]
Date: Sun, 9 Dec 2007 21:02:31 +0100 (CET)
From: Julia Lawall [EMAIL PROTECTED]
Recently, Wang Chen submitted a patch
(d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb)
after a subsequent reference to skb, because netif_rx may
From: Julia Lawall [EMAIL PROTECTED]
Date: Sun, 9 Dec 2007 21:03:55 +0100 (CET)
From: Julia Lawall [EMAIL PROTECTED]
Recently, Wang Chen submitted a patch
(d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb)
after a subsequent reference to skb, because netif_rx may
From: Julia Lawall [EMAIL PROTECTED]
Date: Sun, 9 Dec 2007 21:05:30 +0100 (CET)
From: Julia Lawall [EMAIL PROTECTED]
Recently, Wang Chen submitted a patch
(d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb)
after a subsequent reference to skb, because netif_rx may
From: Andrew Morton [EMAIL PROTECTED]
Date: Fri, 7 Dec 2007 16:08:00 -0800
Or should this have been sys_nis_syscall()?
sys_nis_syscall() was used in cases on sparc where we wanted
to get a log of invocations of unimplemented syscalls, as it
aided debugging and anaylsis.
But the usefulness of
From: Joonwoo Park [EMAIL PROTECTED]
Date: Tue, 11 Dec 2007 18:13:34 +0900
Joonwoo-ssi annyoung haseyo,
[NET]: Fix Ooops of napi net_rx_action.
Before doing list_move_tail napi poll_list, it should be ensured
Signed-off-by: Joonwoo Park [EMAIL PROTECTED]
---
diff --git a/net/core/dev.c
From: Herbert Xu [EMAIL PROTECTED]
Date: Tue, 11 Dec 2007 20:36:21 +0800
David Miller [EMAIL PROTECTED] wrote:
How can the NAPI_STATE_SCHED bit be cleared externally yet we take
this list_move_tail() code path?
His driver is probably buggy. When we had two drivers beginning
with e100
From: Andi Kleen [EMAIL PROTECTED]
Date: Tue, 11 Dec 2007 19:53:17 +0100
Ok but saving oops is such a useful facility that we'll probably
need to think about implementing SOAP in the kernel.
Ummm, no.
UDP is stateless, a stripped down copy of TCP we simply
do not need. We also do not need
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Tue, 11 Dec 2007 21:46:34 -0800
Isn't this a better fix for all drivers, rather than peppering every
driver with the special case. This is how the logic worked up until
2.6.24.
Stephen this is not the problem.
The problem is that the driver is
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Tue, 11 Dec 2007 21:39:39 -0800
On Wed, 12 Dec 2007 13:01:27 +0900
Joonwoo Park [EMAIL PROTECTED] wrote:
[NETDEV]: tehuti Fix possible causing oops of net_rx_action
Signed-off-by: Joonwoo Park [EMAIL PROTECTED]
---
From: Joonwoo Park [EMAIL PROTECTED]
Date: Wed, 12 Dec 2007 13:01:27 +0900
@@ -305,6 +305,8 @@ static int bdx_poll(struct napi_struct *napi, int budget)
netif_rx_complete(dev, napi);
bdx_enable_interrupts(priv);
+ if (unlikely(work_done ==
From: Brandeburg, Jesse [EMAIL PROTECTED]
Date: Tue, 11 Dec 2007 16:38:37 -0800
@@ -3933,6 +3933,10 @@ quit_polling:
e1000_set_itr(adapter);
netif_rx_complete(poll_dev, napi);
e1000_irq_enable(adapter);
+ if (work_done ==
From: Joonwoo Park [EMAIL PROTECTED]
Date: Wed, 12 Dec 2007 15:05:26 +0900
Could you explain how it fix the problem?
IMHO I think your patch cannot solve the problem.
The drivers can call netif_rx_complete and net_rx_action can do
list_move_tail also.
Stephen is confused about what the bug
From: Andrew Gallatin [EMAIL PROTECTED]
Date: Wed, 12 Dec 2007 12:29:23 -0500
Is the netif_running() check even required?
No, it is not.
When a device is brought down, one of the first things
that happens is that we wait for all pending NAPI polls
to complete, then block any new polls from
From: Harvey Harrison [EMAIL PROTECTED]
Date: Wed, 12 Dec 2007 00:09:03 -0800
X86_32 was the last user of the FASTCALL macro, now that it
uses regparm(3) by default, this macro expands to nothing.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
Applied to net-2.6.25, thanks.
--
To
From: Andrew Gallatin [EMAIL PROTECTED]
Date: Wed, 12 Dec 2007 13:38:34 -0500
Remove the bogus netif_running() check from myri10ge_poll().
This eliminates any chance that myri10ge_poll() can trigger
an oops by calling netif_rx_complete() and returning
with work_done == budget.
From: Andrew Morton [EMAIL PROTECTED]
Date: Tue, 11 Dec 2007 16:57:00 -0800
On Sun, 9 Dec 2007 22:34:33 +0100
Marcin __lusarz [EMAIL PROTECTED] wrote:
fbcon: fix sparse warning about shadowing 'p' symbol
Please always quote error messages and warnings in the changelog when
fixing
From: Andrew Morton [EMAIL PROTECTED]
Date: Tue, 11 Dec 2007 16:44:45 -0800
So I'd propose this:
I've applied this to net-2.6, thanks Andrew.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Joonwoo Park [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 19:18:56 +0900
Just blowing netif_running up is not best solution I think, it makes
ifconfig down hang at least for e1000.
It hangs because the packet receive rate is so high that NAPI
poll never exits.
I think we need a cheap
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 14:49:53 +0100
As a matter of fact, since it's unlikely() in net_rx_action() anyway,
I wonder what is the main reason or gain of leaving such a tricky
exception, instead of letting drivers to always decide which is the
best moment
From: Andrew Gallatin [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 09:13:54 -0500
If the netif_running() check is indeed required to make a device break
out of napi polling and respond to an ifconfig down, then I think the
netif_running() check should be moved up into net_rx_action() to avoid
From: Tom \spot\ Callaway [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 11:21:40 -0500
gcc throws these warnings with:
CONFIG_ATM_FORE200E=m
# CONFIG_ATM_FORE200E_PCA is not set
drivers/atm/fore200e.c:2695: warning: 'fore200e_pca_detect' defined but
not used
drivers/atm/fore200e.c:2748:
From: Benjamin Thery [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 16:01:34 +0100
The problem comes from the new macro UDPX_INC_STATS_BH introduced
by Herbert, which was a nice addition to increment the correct
UDP MIB depending on the socket family, but unfortunately
the use of this macro from
From: Andrew Gallatin [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 14:02:25 -0500
Or perhaps we should just leave things as is.
We should probably add a disabling state bit to the
napi struct flags, this will be set by napi_disable()
before it loops trying to set the sched bit.
net_rx_action() can
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 21:16:12 +0100
I see in a nearby thread you would prefer to save some work to drivers
(like this netif_running() check), but I think this all is at the cost
of flexibility, and there will probably appear new problems, when a
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 11:35:07 -0800
How about allowing a return value of -1 from napi_poll and letting
device check itself.
It doesn't avoid the code duplication in the -poll() fast paths.
I don't care, on the other hand, if crap accumulates in
From: Adrian Bunk [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 23:20:44 +0100
My question is:
Is there anywhere in the kernel a case where __read_mostly brings a
measurable improvement or can it be removed?
Yes, on SMP when read-mostly objects share cache lines
with other objects which are
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 23:28:41 +0100
...I'm afraid I can't understand: I mean doing the same but without
passing this info with 'work == weight': if driver sends this info,
why it can't instead call something like napi_continue() with
this
From: Greg KH [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 16:19:32 -0800
On Thu, Dec 13, 2007 at 03:55:51PM -0800, [EMAIL PROTECTED] wrote:
Forward port of coherent-mmap.patch and sysfs-bin-ioctl.patch to x86 tree.
TBD: Do we need the ioctl interface to sysfs or get the type attribute
From: guanxun mu [EMAIL PROTECTED]
Date: Fri, 14 Dec 2007 14:03:05 +0800
[PACTH APPLETALK]
This patch update proto_init process when register_snap_client failed
Signed-off-by: Michale Moore [EMAIL PROTECTED]
diff --git a/net/appletalk/aarp.c b/net/appletalk/aarp.c
index
From: Herbert Xu [EMAIL PROTECTED]
Date: Fri, 14 Dec 2007 10:08:07 +0800
[UDP]: Move udp_stats_in6 into net/ipv4/udp.c
Now that external users may increment the counters directly, we need to
ensure that udp_stats_in6 is always available. Otherwise we'd either
have to requrie the external
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Tue, 11 Dec 2007 15:42:22 -0800
Perhaps we should change the warning to identify the guilty device.
Applied.
Stephen, you often don't supply a proper signoff line
for one-off changes like this and I find it very irritating.
It doesn't cost you
From: Simon Horman [EMAIL PROTECTED]
Date: Wed, 26 Dec 2007 11:59:05 +0900
Recently the documentation in Documentation/nfsroot.txt was
update to note that in fact ip=off and ip=::off as the
latter is ignored and the default (on) is used.
This was certainly a step in the direction of
From: Mariusz Kozlowski [EMAIL PROTECTED]
Date: Wed, 26 Dec 2007 13:29:07 +0100
WARNING: vmlinux.o(.text+0x46b04): Section mismatch: reference to
.init.text:sun4v_ktsb_register (between 'smp_callin' and
'smp_fill_in_sib_core_maps')
Well known and I see them every build and so does everyone
From: [EMAIL PROTECTED]
Date: Thu, 27 Dec 2007 16:10:47 -0800
V1-V2:
- Use def_bool as suggested by Randy.
The use of the __GENERIC_PERCPU is a bit problematic since arches
may want to run their own percpu setup while using the generic
percpu definitions. Replace it through a kconfig
From: [EMAIL PROTECTED]
Date: Thu, 27 Dec 2007 16:10:48 -0800
V1-V2:
- Special consideration for IA64: Add the ability to specify
arch specific per cpu flags
The arch definitions are all the same. So move them into linux/percpu.h.
We cannot move DECLARE_PER_CPU since some include files
From: [EMAIL PROTECTED]
Date: Thu, 27 Dec 2007 16:10:49 -0800
V1-V2:
- add support for PER_CPU_ATTRIBUTES
Add the ability to use generic/percpu even if the arch needs to override
several aspects of its operations. This will enable the use of generic
percpu.h for all arches.
An arch may
of performing an array lookup.
Cc: David Miller [EMAIL PROTECTED]
Signed-off-by: Christoph Lameter [EMAIL PROTECTED]
Signed-off-by: Mike Travis [EMAIL PROTECTED]
Acked-by: David S. Miller [EMAIL PROTECTED]
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
From: Gui Jianfeng [EMAIL PROTECTED]
Date: Thu, 27 Dec 2007 15:26:46 +0800
I think the following code in fib6_del_route in the latest kernel is useless.
1125 if (fn-leaf == NULL fn-fn_flagsRTN_TL_ROOT)
1126 fn-leaf = ip6_null_entry;
ip6_null_entry will never be
From: Gui Jianfeng [EMAIL PROTECTED]
Date: Fri, 28 Dec 2007 13:58:21 +0800
I think the following code in fib6_del_route in the latest kernel is
useless.
1125 if (fn-leaf == NULL fn-fn_flagsRTN_TL_ROOT)
1126 fn-leaf = ip6_null_entry;
ip6_null_entry will never
501 - 600 of 27791 matches
Mail list logo
