Re: [PATCH] usb: gadget: f_phonet: mark expected switch fall-throughs

ave already sent you my pull request. If you want, I can prepare a part 2, otherwise: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH] usb: gadget: zero: Convert timers to use timer_setup()

h the timer global. > > Cc: Felipe Balbi <ba...@kernel.org> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: linux-...@vger.kernel.org > Signed-off-by: Kees Cook <keesc...@chromium.org> Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH] usb: gadget: zero: Convert timers to use timer_setup()

Kees Cook writes: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. Adds a static tracking variable to > match the timer global. > >

Re: [PATCH] usb: usbtest: Convert timers to use timer_setup()

roy_timer_on_stack(); > > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: Felipe Balbi <felipe.ba...@linux.intel.com> > Cc: Alan Stern <st...@rowland.harvard.edu> > Cc: "Gustavo A. R. Silva" <garsi...@embeddedor.com> > Cc: linux-...@vger.kernel.or

Re: [PATCH] usb: usbtest: Convert timers to use timer_setup()

Greg Kroah-Hartman > Cc: Felipe Balbi > Cc: Alan Stern > Cc: "Gustavo A. R. Silva" > Cc: linux-...@vger.kernel.org > Signed-off-by: Kees Cook Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH 25/25] usb/gadget/NCM: Replace tasklet with softirq hrtimer

as hrtimer base. > > Signed-off-by: Thomas Gleixner <t...@linutronix.de> > Signed-off-by: Anna-Maria Gleixner <anna-ma...@linutronix.de> > Cc: Felipe Balbi <ba...@kernel.org> > Cc: linux-...@vger.kernel.org Acked-by: Felipe Balbi <felipe.ba...@linus.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH 25/25] usb/gadget/NCM: Replace tasklet with softirq hrtimer

leixner > Signed-off-by: Anna-Maria Gleixner > Cc: Felipe Balbi > Cc: linux-...@vger.kernel.org Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [RESEND PATCH 1/3] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

Hi, Manu Gautam writes: > Hi Felipe, > > Let me know if patches in this series look fine to you. It does, I just don't have means to test this as intel's platform doesn't give SW access to PHYs. I was hoping someone from TI would give a tested-by, but it's too late.

Re: [RESEND PATCH 1/3] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

Hi, Manu Gautam writes: > Hi Felipe, > > Let me know if patches in this series look fine to you. It does, I just don't have means to test this as intel's platform doesn't give SW access to PHYs. I was hoping someone from TI would give a tested-by, but it's too late. We'll just take this

Re: [RFC 2/3] USB: dwc3: Modify dwc3 code for support usb of Hikey960

Hi, Yu Chen writes: > The usb controller of Kirin960 is DesignWare Cores SuperSpeed USB 3.0 > Controller. > The patch modifies dwc3 for support Kirin960 and adds codes for a USB Hub on > board Hikey960. > > Signed-off-by: Yu Chen > Signed-off-by:

Re: [RFC 2/3] USB: dwc3: Modify dwc3 code for support usb of Hikey960

Hi, Yu Chen writes: > The usb controller of Kirin960 is DesignWare Cores SuperSpeed USB 3.0 > Controller. > The patch modifies dwc3 for support Kirin960 and adds codes for a USB Hub on > board Hikey960. > > Signed-off-by: Yu Chen > Signed-off-by: Ning Fan > Signed-off-by: Di Yang >

Re: [PATCH v7 3/4] usb: dwc3: of-simple: Add support to get resets for the device

Hi, Philipp Zabel <p.za...@pengutronix.de> writes: > Hi Felipe, > > On Thu, 2017-10-19 at 12:38 +0300, Felipe Balbi wrote: >> Philipp Zabel <p.za...@pengutronix.de> writes: >> >> > From: Vivek Gautam <vivek.gau...@codeaurora.org> >>

Re: [PATCH v7 3/4] usb: dwc3: of-simple: Add support to get resets for the device

Hi, Philipp Zabel writes: > Hi Felipe, > > On Thu, 2017-10-19 at 12:38 +0300, Felipe Balbi wrote: >> Philipp Zabel writes: >> >> > From: Vivek Gautam >> > >> > Add support to get a list of resets available for the device. >> &g

Re: [PATCH v7 3/4] usb: dwc3: of-simple: Add support to get resets for the device

Hi, Philipp Zabel <p.za...@pengutronix.de> writes: > Hi Felipe, > > On Thu, 2017-10-19 at 12:38 +0300, Felipe Balbi wrote: >> Philipp Zabel <p.za...@pengutronix.de> writes: >> >> > From: Vivek Gautam <vivek.gau...@codeaurora.org> >>

Re: [PATCH v7 3/4] usb: dwc3: of-simple: Add support to get resets for the device

Hi, Philipp Zabel writes: > Hi Felipe, > > On Thu, 2017-10-19 at 12:38 +0300, Felipe Balbi wrote: >> Philipp Zabel writes: >> >> > From: Vivek Gautam >> > >> > Add support to get a list of resets available for the device. >> &g

Re: [PATCH v7 3/4] usb: dwc3: of-simple: Add support to get resets for the device

Philipp Zabel <p.za...@pengutronix.de> writes: > From: Vivek Gautam <vivek.gau...@codeaurora.org> > > Add support to get a list of resets available for the device. > These resets must be kept de-asserted until the device is > in use. > > Cc: Felipe Balbi <ba..

Re: [PATCH v7 3/4] usb: dwc3: of-simple: Add support to get resets for the device

Philipp Zabel writes: > From: Vivek Gautam > > Add support to get a list of resets available for the device. > These resets must be kept de-asserted until the device is > in use. > > Cc: Felipe Balbi > Signed-off-by: Vivek Gautam > [p.za...@pengutronix.de: switch to

Re: [PATCH v7 2/4] usb: dwc3: of-simple: Re-order resource handling in remove

Hi, Philipp Zabel <p.za...@pengutronix.de> writes: > From: Vivek Gautam <vivek.gau...@codeaurora.org> > > Move clock handling after of_platform_depopulate to achieve > a sequence that is reverse of the probe sequence. > > Cc: Felipe Balbi <ba...@kernel.o

Re: [PATCH v7 2/4] usb: dwc3: of-simple: Re-order resource handling in remove

Hi, Philipp Zabel writes: > From: Vivek Gautam > > Move clock handling after of_platform_depopulate to achieve > a sequence that is reverse of the probe sequence. > > Cc: Felipe Balbi > Signed-off-by: Vivek Gautam does this depend on the rest of the series? Does

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

s/usb/usbip/Makefile |1 + > drivers/usb/usbip/stub.h |2 ++ > drivers/usb/usbip/stub_dev.c |2 ++ > drivers/usb/usbip/stub_main.c |2 ++ > drivers/usb/usbip/stub_rx.c|2 ++ >

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

ip/stub_main.c |2 ++ > drivers/usb/usbip/stub_rx.c |2 ++ > drivers/usb/usbip/stub_tx.c|2 ++ > drivers/usb/usbip/usbip_common.c |2 ++ > drivers/usb/usbip/usbip_common.h |2 ++ > drivers/usb/usbip/usbip_event.c|2 ++ > drivers/usb/usbip/vhci.h |2 ++ > drivers/usb/usbip/vhci_hcd.c |2 ++ > drivers/usb/usbip/vhci_rx.c|2 ++ > drivers/usb/usbip/vhci_sysfs.c |2 ++ > drivers/usb/usbip/vhci_tx.c|2 ++ > drivers/usb/usbip/vudc.h |2 ++ > drivers/usb/usbip/vudc_dev.c |2 ++ > drivers/usb/usbip/vudc_main.c |2 ++ > drivers/usb/usbip/vudc_rx.c|2 ++ > drivers/usb/usbip/vudc_sysfs.c |2 ++ > drivers/usb/usbip/vudc_transfer.c |2 ++ > drivers/usb/usbip/vudc_tx.c|2 ++ > drivers/usb/wusbcore/Makefile |1 + > drivers/usb/wusbcore/cbaf.c|2 ++ > drivers/usb/wusbcore/crypto.c |2 ++ > drivers/usb/wusbcore/dev-sysfs.c |2 ++ > drivers/usb/wusbcore/devconnect.c |2 ++ > drivers/usb/wusbcore/mmc.c |2 ++ > drivers/usb/wusbcore/pal.c |2 ++ > drivers/usb/wusbcore/reservation.c |2 ++ > drivers/usb/wusbcore/rh.c |2 ++ > drivers/usb/wusbcore/security.c|2 ++ > drivers/usb/wusbcore/wa-hc.c |2 ++ > drivers/usb/wusbcore/wa-hc.h |2 ++ > drivers/usb/wusbcore/wa-nep.c |2 ++ > drivers/usb/wusbcore/wa-rpipe.c|2 ++ > drivers/usb/wusbcore/wa-xfer.c |2 ++ > drivers/usb/wusbcore/wusbhc.c |2 ++ > drivers/usb/wusbcore/wusbhc.h |2 ++ > 685 files changed, 1325 insertions(+), 6 deletions(-) ouch :-) For the stuff which concerns me: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: linux-next: manual merge of the usb-gadget tree with the usb tree

Hi, Kees Cook writes: > On Wed, Oct 18, 2017 at 7:42 AM, Mark Brown wrote: >> Hi Felipe, >> >> Today's linux-next merge of the usb-gadget tree got a conflict in: >> >> drivers/usb/gadget/udc/snps_udc_core.c >> >> between commit: >> >>

Re: linux-next: manual merge of the usb-gadget tree with the usb tree

Hi, Kees Cook writes: > On Wed, Oct 18, 2017 at 7:42 AM, Mark Brown wrote: >> Hi Felipe, >> >> Today's linux-next merge of the usb-gadget tree got a conflict in: >> >> drivers/usb/gadget/udc/snps_udc_core.c >> >> between commit: >> >> 29bce57723351f63d ("usb/gadget/snps_udc_core: Convert

Re: [PATCH] usb: isp1301-omap: Convert timers to use timer_setup()

from_timer() >> > to pass the timer pointer explicitly. >> > >> > Cc: Felipe Balbi <ba...@kernel.org> >> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> >> > Cc: linux-...@vger.kernel.org >> > Cc: linux-o...@vger.kernel.org >>

Re: [PATCH] usb: isp1301-omap: Convert timers to use timer_setup()

Hi, Greg Kroah-Hartman writes: >> Kees Cook writes: >> > In preparation for unconditionally passing the struct timer_list pointer to >> > all timer callbacks, switch to using the new timer_setup() and from_timer() >> > to pass the timer pointer explicitly. &g

Re: [PATCH v2 07/15] usb: gadget: configfs: make config_item_type const

; Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH v2 07/15] usb: gadget: configfs: make config_item_type const

Bhumika Goyal writes: > Make config_item_type structures const as they are either passed to a > function having the argument as const or stored in the const "ci_type" > field of a config_item structure. > > Done using Coccinelle. > > Signed-off-by: Bhumika

Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const

mbine all the followup patches and the constification > patches into a series. I'm assuming this depends on patch 1 of the series. In that case: Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const

patches into a series. I'm assuming this depends on patch 1 of the series. In that case: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH] usb: isp1301-omap: Convert timers to use timer_setup()

Hi, Kees Cook <keesc...@chromium.org> writes: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Felipe Balbi <ba..

Re: [PATCH] usb: isp1301-omap: Convert timers to use timer_setup()

Hi, Kees Cook writes: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Felipe Balbi > Cc: Greg Kroah-Ha

Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7

Hi, Felipe Balbi <felipe.ba...@linux.intel.com> writes: >>>> I thought that patches 1 and 2, as they are "driver" patches, had to be >>>> applied on USB tree (so Felipe's one), and the others (3 to 7) had to be >>>> applied on STM32-DT tree

Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7

Hi, Felipe Balbi writes: >>>> I thought that patches 1 and 2, as they are "driver" patches, had to be >>>> applied on USB tree (so Felipe's one), and the others (3 to 7) had to be >>>> applied on STM32-DT tree (Alex's one). Did I miss something? >

Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7

Hi, Alexandre Torgue <alexandre.tor...@st.com> writes: > Hi Felipe > > On 10/12/2017 10:43 AM, Felipe Balbi wrote: >> >> Hi, >> >>>>>>>> >>>>>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote: >>&g

Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7

Hi, Alexandre Torgue writes: > Hi Felipe > > On 10/12/2017 10:43 AM, Felipe Balbi wrote: >> >> Hi, >> >>>>>>>> >>>>>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote: >>>>>>>>> >>>&g

Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7

Hi, Amelie DELAUNAY <amelie.delau...@st.com> writes: > Hi Felipe, Alex, > > On 10/11/2017 04:38 PM, Alexandre Torgue wrote: >> >> >> On 10/11/2017 03:26 PM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Alexandre Torgue <a

Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7

Hi, Amelie DELAUNAY writes: > Hi Felipe, Alex, > > On 10/11/2017 04:38 PM, Alexandre Torgue wrote: >> >> >> On 10/11/2017 03:26 PM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Alexandre Torgue writes: >>>&

Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7

Hi, Alexandre Torgue <alexandre.tor...@st.com> writes: > Hi > > On 10/11/2017 01:50 PM, Felipe Balbi wrote: >> >> Hi, >> >> Alexandre Torgue <alexandre.tor...@st.com> writes: >>> Hi Felip >>> >>> On 10/11/2017 12:04 PM, F

Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7

Hi, Alexandre Torgue writes: > Hi > > On 10/11/2017 01:50 PM, Felipe Balbi wrote: >> >> Hi, >> >> Alexandre Torgue writes: >>> Hi Felip >>> >>> On 10/11/2017 12:04 PM, Felipe Balbi wrote: >>>> >>>> Hi, >

Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7

Hi, Alexandre Torgue <alexandre.tor...@st.com> writes: > Hi Felip > > On 10/11/2017 12:04 PM, Felipe Balbi wrote: >> >> Hi, >> >> Amelie Delaunay <amelie.delau...@st.com> writes: >>> The STM32F7 MCU family embeds two DWC2 USB OTG cores.

Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7

Hi, Alexandre Torgue writes: > Hi Felip > > On 10/11/2017 12:04 PM, Felipe Balbi wrote: >> >> Hi, >> >> Amelie Delaunay writes: >>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB >>> OTG FS and the other is USB OTG H

Re: [PATCH 1/3] usb: dwc2: Improve gadget state disconnection handling

Hi, John Stultz writes: > On Thu, Aug 17, 2017 at 12:03 PM, John Stultz wrote: >> In the earlier commit dad3f793f20f ("usb: dwc2: Make sure we >> disconnect the gadget state"), I was trying to fix up the >> fact that we somehow weren't

Re: [PATCH 1/3] usb: dwc2: Improve gadget state disconnection handling

Hi, John Stultz writes: > On Thu, Aug 17, 2017 at 12:03 PM, John Stultz wrote: >> In the earlier commit dad3f793f20f ("usb: dwc2: Make sure we >> disconnect the gadget state"), I was trying to fix up the >> fact that we somehow weren't disconnecting the gadget state, >> so that when the OTG

Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7

Hi, Amelie Delaunay writes: > The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB > OTG FS and the other is USB OTG HS. The USB FS core only works with its > internal phy whilst the USB HS core can work in HS with external ULPI phy > or in FS/LS with

Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7

Hi, Amelie Delaunay writes: > The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB > OTG FS and the other is USB OTG HS. The USB FS core only works with its > internal phy whilst the USB HS core can work in HS with external ULPI phy > or in FS/LS with the on-chip FS phy. > >

Re: [PATCH v2] extcon: Split out extcon header file for consumer and provider device

ance > : Register/unregister extcon device > : Set the state of each external connector > : Set the property value of each external connector > : Set the property capability of each external connector > > Cc: Felipe Balbi <ba...@kernel.org> Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi

Re: [PATCH v2] extcon: Split out extcon header file for consumer and provider device

egister extcon device > : Set the state of each external connector > : Set the property value of each external connector > : Set the property capability of each external connector > > Cc: Felipe Balbi Acked-by: Felipe Balbi -- balbi

Re: [PATCH] usb: dwc3: workaround: disable device-initiated U1/U2

Hi, Felipe Balbi <felipe.ba...@linux.intel.com> writes: > (first things first: use get-maintainer.pl. You should have Cc:ed linux-usb) apologies. Just now I noticed that you did Cc linux-usb. -- balbi signature.asc Description: PGP signature

Re: [PATCH] usb: dwc3: workaround: disable device-initiated U1/U2

Hi, Felipe Balbi writes: > (first things first: use get-maintainer.pl. You should have Cc:ed linux-usb) apologies. Just now I noticed that you did Cc linux-usb. -- balbi signature.asc Description: PGP signature

Re: [PATCH] usb: dwc3: workaround: disable device-initiated U1/U2

Hi, (first things first: use get-maintainer.pl. You should have Cc:ed linux-usb) > Issue: When the USB controller is configured as a USB device > mode, the device initiates low power when an ACK is pending for a > data packet (DP). When operating in SuperSpeed mode and when the > internal

Re: [PATCH] usb: dwc3: workaround: disable device-initiated U1/U2

Hi, (first things first: use get-maintainer.pl. You should have Cc:ed linux-usb) > Issue: When the USB controller is configured as a USB device > mode, the device initiates low power when an ACK is pending for a > data packet (DP). When operating in SuperSpeed mode and when the > internal

Re: [PATCH v2 16/31] usb/phy-isp1301-omap: Remove .data assignment

Hi, Kees Cook <keesc...@chromium.org> writes: > The .data assignment appears to be redundant to the WORK_STOP bit for > stopping the timer. Also, it appears this timer is entirely unused > as it is only ever started under #define VERBOSE, which is explicitly > undefined. > &

Re: [PATCH v2 27/31] usb/gadget/snps_udc_core: Remove struct timer_list.data use

struct timer_list. > > Cc: Felipe Balbi <ba...@kernel.org> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: Raviteja Garimella <raviteja.garime...@broadcom.com> > Cc: Michal Nazarewicz <min...@mina86.com> > Cc: "Gustavo A. R. Silva"

Re: [PATCH v2 16/31] usb/phy-isp1301-omap: Remove .data assignment

Hi, Kees Cook writes: > The .data assignment appears to be redundant to the WORK_STOP bit for > stopping the timer. Also, it appears this timer is entirely unused > as it is only ever started under #define VERBOSE, which is explicitly > undefined. > > Cc: Felipe Balbi > C

Re: [PATCH v2 27/31] usb/gadget/snps_udc_core: Remove struct timer_list.data use

Kees Cook writes: > If the probe fails, udc_remove() will not be called, so there is no > reason to make del_timer_sync() calls conditional. As a result, use of > the .data field can be dropped, in support of making removing this field > entirely from struct timer_list. > >

Re: [PATCH v1] usb: host: Implement workaround for Erratum A-007463

Hi, Alan Stern writes: > The Subject: line should specify which type of USB host controller the > patch is for. The kernel contains lots of different USB host > controller drivers. How are we supposed to know that Erratum A-007463 > applies to dwc3 xHCI

Re: [PATCH v1] usb: host: Implement workaround for Erratum A-007463

Hi, Alan Stern writes: > The Subject: line should specify which type of USB host controller the > patch is for. The kernel contains lots of different USB host > controller drivers. How are we supposed to know that Erratum A-007463 > applies to dwc3 xHCI controllers? > > The Subject: line

Re: [PATCH] usb: gadget: pch_udc: add checks for dma mapping errors

Hi, Alexey Khoroshilov writes: >>> diff --git a/drivers/usb/gadget/udc/pch_udc.c >>> b/drivers/usb/gadget/udc/pch_udc.c >>> index 84dcbcd756f0..a305f8392082 100644 >>> --- a/drivers/usb/gadget/udc/pch_udc.c >>> +++ b/drivers/usb/gadget/udc/pch_udc.c >>> @@ -1767,7

Re: [PATCH] usb: gadget: pch_udc: add checks for dma mapping errors

Hi, Alexey Khoroshilov writes: >>> diff --git a/drivers/usb/gadget/udc/pch_udc.c >>> b/drivers/usb/gadget/udc/pch_udc.c >>> index 84dcbcd756f0..a305f8392082 100644 >>> --- a/drivers/usb/gadget/udc/pch_udc.c >>> +++ b/drivers/usb/gadget/udc/pch_udc.c >>> @@ -1767,7 +1767,7 @@ static struct

Re: [PATCH] usb: dwc3: Fix the USB 3.0 hub detection bug after warm boot

Hi, gustavo panizzo writes: >>>gustavo panizzo writes: >>>--- >>>drivers/usb/dwc3/core.c | 33 + >>>1 file changed, 33 insertions(+) >>> >>>diff --git a/drivers/usb/dwc3/core.c

Re: [PATCH] usb: dwc3: Fix the USB 3.0 hub detection bug after warm boot

Hi, gustavo panizzo writes: >>>gustavo panizzo writes: >>>--- >>>drivers/usb/dwc3/core.c | 33 + >>>1 file changed, 33 insertions(+) >>> >>>diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c >>>index

Re: [PATCH] usb: dwc3: Fix the USB 3.0 hub detection bug after warm boot

Hi, gustavo panizzo writes: --- drivers/usb/dwc3/core.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 326b302fc440..f92dfe213d89

Re: [PATCH] usb: dwc3: Fix the USB 3.0 hub detection bug after warm boot

Hi, gustavo panizzo writes: --- drivers/usb/dwc3/core.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 326b302fc440..f92dfe213d89 100644 ---

Re: [PATCH] usb: dwc3: Initialize DMA ops/mask for xhci-hcd

Hi, Adam Wallis writes: > The dma ops from the parent DWC device are not getting passed to the > child xhci-hcd device. This patch makes use of > platform_device_register_full to set the DMA ops. For the DT/OF case, > dma_ops were still null after the the device

Re: [PATCH] usb: dwc3: Initialize DMA ops/mask for xhci-hcd

Hi, Adam Wallis writes: > The dma ops from the parent DWC device are not getting passed to the > child xhci-hcd device. This patch makes use of > platform_device_register_full to set the DMA ops. For the DT/OF case, > dma_ops were still null after the the device register, so > of_dma_configure

Re: [PATCH] usb: xhci: Renesas uPD720202 needs short TX quirk

Hi, Kai-Heng Feng writes: >>> When plugging Logitech C920 webcam, warning messages filled up dmesg: >>> [77117.655018] xhci_hcd :0c:00.0: WARN Successful completion on short >>> TX: needs XHCI_TRUST_TX_LENGTH quirk? >>> [77117.659018] xhci_hcd :0c:00.0:

Re: [PATCH] usb: xhci: Renesas uPD720202 needs short TX quirk

Hi, Kai-Heng Feng writes: >>> When plugging Logitech C920 webcam, warning messages filled up dmesg: >>> [77117.655018] xhci_hcd :0c:00.0: WARN Successful completion on short >>> TX: needs XHCI_TRUST_TX_LENGTH quirk? >>> [77117.659018] xhci_hcd :0c:00.0: WARN Successful completion on

Re: [PATCH] usb: xhci: Renesas uPD720202 needs short TX quirk

hi, Kai-Heng Feng writes: > When plugging Logitech C920 webcam, warning messages filled up dmesg: > [77117.655018] xhci_hcd :0c:00.0: WARN Successful completion on short TX: > needs XHCI_TRUST_TX_LENGTH quirk? > [77117.659018] xhci_hcd :0c:00.0: WARN

Re: [PATCH] usb: xhci: Renesas uPD720202 needs short TX quirk

hi, Kai-Heng Feng writes: > When plugging Logitech C920 webcam, warning messages filled up dmesg: > [77117.655018] xhci_hcd :0c:00.0: WARN Successful completion on short TX: > needs XHCI_TRUST_TX_LENGTH quirk? > [77117.659018] xhci_hcd :0c:00.0: WARN Successful completion on short TX:

Re: [PATCH v2 1/2] usb: dwc3: keystone: Add PM_RUNTIME Support to DWC3 Keystone USB driver

Hi, Franklin S Cooper Jr writes: >> Franklin S Cooper Jr writes: >>> For 66AK2Gx there is a requirement to use PM Runtime to properly manage >>> clocks and the power domains. Therefore, add PM runtime support. Remove >>> legacy clock api's calls since other

Re: [PATCH v2 1/2] usb: dwc3: keystone: Add PM_RUNTIME Support to DWC3 Keystone USB driver

Hi, Franklin S Cooper Jr writes: >> Franklin S Cooper Jr writes: >>> For 66AK2Gx there is a requirement to use PM Runtime to properly manage >>> clocks and the power domains. Therefore, add PM runtime support. Remove >>> legacy clock api's calls since other users of this driver worked without

Re: [PATCH v2 1/2] usb: dwc3: keystone: Add PM_RUNTIME Support to DWC3 Keystone USB driver

Hi, Franklin S Cooper Jr writes: > For 66AK2Gx there is a requirement to use PM Runtime to properly manage > clocks and the power domains. Therefore, add PM runtime support. Remove > legacy clock api's calls since other users of this driver worked without > these clock apis

Re: [PATCH v2 1/2] usb: dwc3: keystone: Add PM_RUNTIME Support to DWC3 Keystone USB driver

Hi, Franklin S Cooper Jr writes: > For 66AK2Gx there is a requirement to use PM Runtime to properly manage > clocks and the power domains. Therefore, add PM runtime support. Remove > legacy clock api's calls since other users of this driver worked without > these clock apis calls. > >

Re: Inconsistency in usb_add_gadget_udc_release() interface

Hi, Alexey Khoroshilov writes: > Hello, > > usb_add_gadget_udc_release() gets release() argument that allows to > release user resources. > > As far as I can see, the release() is called on error paths > of usb_add_gadget_udc_release() as a result of > put_device(>dev);

Re: Inconsistency in usb_add_gadget_udc_release() interface

Hi, Alexey Khoroshilov writes: > Hello, > > usb_add_gadget_udc_release() gets release() argument that allows to > release user resources. > > As far as I can see, the release() is called on error paths > of usb_add_gadget_udc_release() as a result of > put_device(>dev); > except for the only

Re: [PATCH] usb: gadget: udc: udc_stop before gadget unbind

Hi, Danilo Krummrich <danilokrummr...@dk-develop.de> writes: > thanks for reviewing. np :-) > On 2017-08-15 12:03, Felipe Balbi wrote: >> Hi, >> >> Danilo Krummrich <danilokrummr...@dk-develop.de> writes: >>> udc_stop needs to be called before

Re: [PATCH] usb: gadget: udc: udc_stop before gadget unbind

Hi, Danilo Krummrich writes: > thanks for reviewing. np :-) > On 2017-08-15 12:03, Felipe Balbi wrote: >> Hi, >> >> Danilo Krummrich writes: >>> udc_stop needs to be called before gadget driver unbind. Otherwise it >>> might happen that udc driv

Re: [PATCH] usb: gadget: udc: udc_stop before gadget unbind

Hi, Danilo Krummrich writes: > udc_stop needs to be called before gadget driver unbind. Otherwise it > might happen that udc drivers still call into the gadget driver (e.g. > to reset gadget after OTG event). If this happens it is likely to get > panics from

Re: [PATCH] usb: gadget: udc: udc_stop before gadget unbind

Hi, Danilo Krummrich writes: > udc_stop needs to be called before gadget driver unbind. Otherwise it > might happen that udc drivers still call into the gadget driver (e.g. > to reset gadget after OTG event). If this happens it is likely to get > panics from gadget driver dereferencing NULL

Re: [PATCH v4 0/3] Introduce USB charger support in USB phy

Hi, Baolin Wang writes: >> Currently the Linux kernel does not provide any standard integration of this >> feature that integrates the USB subsystem with the system power regulation >> provided by PMICs meaning that either vendors must add this in their kernels >> or USB

Re: [PATCH v4 0/3] Introduce USB charger support in USB phy

Hi, Baolin Wang writes: >> Currently the Linux kernel does not provide any standard integration of this >> feature that integrates the USB subsystem with the system power regulation >> provided by PMICs meaning that either vendors must add this in their kernels >> or USB gadget devices based on

Re: [PATCH v2 4/5] usb: gadget: udc: Replace the deprecated extcon API

Hi, Chanwoo Choi <cw00.c...@samsung.com> writes: > This patch replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Cc: Felipe Balbi <ba...@kernel.org> > Cc: Greg Kroah-Hartman <gre...@linuxfoundat

Re: [PATCH v2 4/5] usb: gadget: udc: Replace the deprecated extcon API

Hi, Chanwoo Choi writes: > This patch replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: Raviteja Garimella > Signed-off-by: Chanwoo Choi Do you want to take

Re: [PATCH 1/3] dts: usb3: Add configure-gfladj property to USB3 nod

Hi, yinbo@nxp.com writes: > From: "yinbo.zhu" > > Signed-off-by: yinbo.zhu > --- > arch/arm/boot/dts/ls1021a.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi > index

Re: [PATCH 1/3] dts: usb3: Add configure-gfladj property to USB3 nod

Hi, yinbo@nxp.com writes: > From: "yinbo.zhu" > > Signed-off-by: yinbo.zhu > --- > arch/arm/boot/dts/ls1021a.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi > index ffbf3cf..f525297 100644 > ---

Re: [PATCH 2/3] usb: dwc3 : Add support for USB snooping

Hi, yinbo@nxp.com writes: > From: Rajesh Bhagat > > Add support for USB3 snooping by asserting bits > in register DWC3_GSBUSCFG0 for data and descriptor you're doing WAAY more than that. Also, you don't tell me WHY you want/need snooping to be enabled, or

Re: [PATCH 2/3] usb: dwc3 : Add support for USB snooping

Hi, yinbo@nxp.com writes: > From: Rajesh Bhagat > > Add support for USB3 snooping by asserting bits > in register DWC3_GSBUSCFG0 for data and descriptor you're doing WAAY more than that. Also, you don't tell me WHY you want/need snooping to be enabled, or any of the other changes you

Re: f_hid.c conversion to the new function interface and crash due to race

Hi, (please break your lines at 80 columns) Variksla <varik...@gmail.com> writes: >> On Aug 9, 2017, at 2:56 AM, Felipe Balbi <felipe.ba...@linux.intel.com> >> wrote: > > Thanks for replying. >> >> >> Hi, >> >> noman pouigt <

Re: f_hid.c conversion to the new function interface and crash due to race

Hi, (please break your lines at 80 columns) Variksla writes: >> On Aug 9, 2017, at 2:56 AM, Felipe Balbi >> wrote: > > Thanks for replying. >> >> >> Hi, >> >> noman pouigt writes: >>> Hello, >>> >>> I am curre

Re: f_hid.c conversion to the new function interface and crash due to race

Hi, noman pouigt writes: > Hello, > > I am currently using 3.18 linux kernel and getting below return -EKERNELTOOOLD; Sorry, you're on your own. You should ask for support from whoever forces you to use 3.18 kernel. -- balbi signature.asc Description: PGP signature

Re: f_hid.c conversion to the new function interface and crash due to race

Hi, noman pouigt writes: > Hello, > > I am currently using 3.18 linux kernel and getting below return -EKERNELTOOOLD; Sorry, you're on your own. You should ask for support from whoever forces you to use 3.18 kernel. -- balbi signature.asc Description: PGP signature

Re: [PATCH v2 2/4] usb: common: Move u_serial from gadget/function to usb/common

Hi, Lu Baolu writes: >> Lu Baolu writes: >>> The component u_serial provides a glue layer between TTY layer >>> and a USB gadget device needed to provide a basic serial port >>> functionality. Currently, u_serial sits under gadget/function

Re: [PATCH v2 2/4] usb: common: Move u_serial from gadget/function to usb/common

Hi, Lu Baolu writes: >> Lu Baolu writes: >>> The component u_serial provides a glue layer between TTY layer >>> and a USB gadget device needed to provide a basic serial port >>> functionality. Currently, u_serial sits under gadget/function >>> and depends on CONFIG_USB_GADGET to be compiled

Re: [PATCH v2 2/4] usb: common: Move u_serial from gadget/function to usb/common

Hi, Lu Baolu writes: > The component u_serial provides a glue layer between TTY layer > and a USB gadget device needed to provide a basic serial port > functionality. Currently, u_serial sits under gadget/function > and depends on CONFIG_USB_GADGET to be compiled and

Re: [PATCH v2 2/4] usb: common: Move u_serial from gadget/function to usb/common

Hi, Lu Baolu writes: > The component u_serial provides a glue layer between TTY layer > and a USB gadget device needed to provide a basic serial port > functionality. Currently, u_serial sits under gadget/function > and depends on CONFIG_USB_GADGET to be compiled and used. > > Most of the

Re: [PATCH 2/2] MAINTAINERS: add entry for mediatek usb3 DRD IP driver

Hi, Chunfeng Yun writes: > Add myself as maintainer of MediaTek USB3 DRD IP driver > > Signed-off-by: Chunfeng Yun > --- > MAINTAINERS |7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index

Re: [PATCH 2/2] MAINTAINERS: add entry for mediatek usb3 DRD IP driver

Hi, Chunfeng Yun writes: > Add myself as maintainer of MediaTek USB3 DRD IP driver > > Signed-off-by: Chunfeng Yun > --- > MAINTAINERS |7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 205d397..0f0bcc7 100644 > --- a/MAINTAINERS > +++

Re: [PATCH v2 5/5] usb: xhci: Handle USB transaction error on address command

Hi, Lu Baolu writes: > Xhci driver handles USB transaction errors on transfer events, > but transaction errors are possible on address device command > completion events as well. > > The xHCI specification (section 4.6.5) says: A USB Transaction > Error Completion Code

Re: [PATCH v2 5/5] usb: xhci: Handle USB transaction error on address command

Hi, Lu Baolu writes: > Xhci driver handles USB transaction errors on transfer events, > but transaction errors are possible on address device command > completion events as well. > > The xHCI specification (section 4.6.5) says: A USB Transaction > Error Completion Code for an Address Device

Re: [PATCH] usb: dwc3: Fix the USB 3.0 hub detection bug after warm boot

Hi, gustavo panizzo writes: >>> On Wed, Jul 12, 2017 at 02:08:04PM +0800, Baolin Wang wrote: Hi, On 12 July 2017 at 11:52, gustavo panizzo wrote: > > The dwc3 could not release resources when the module is built-in > because

<    1   2   3   4   5   6   7   8   9   10   >