[PATCH 0/3] panic: improvements

2013-11-07 Thread Felipe Contreras
Hi, While debugging a hang after panic in my laptop (I cannot hard-reboot, or unplug the battery), I noticed the panic code has some areas of improvment. Only the first patch is really needed, the rest seem like good to have. Felipe Contreras (3): panic: setup panic_timeout early panic

[PATCH 1/3] panic: setup panic_timeout early

2013-11-07 Thread Felipe Contreras
Otherwise we might not reboot when the user needs it the most (early on). Signed-off-by: Felipe Contreras --- kernel/panic.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/kernel/panic.c b/kernel/panic.c index b6c482c..46e37ff 100644 --- a/kernel/panic.c

[PATCH 3/3] panic: enable local IRQs for restart timeout too

2013-11-07 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- kernel/panic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/panic.c b/kernel/panic.c index 5a0bdaa..e32919f 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -133,6 +133,8 @@ void panic(const char *fmt

[PATCH 2/3] panic: improve panic_timeout calculation

2013-11-07 Thread Felipe Contreras
We want to calculate the blinks per second, and instead of making it 5 (1000 / (3600 / 18)), let's make it 4, so the user can see two blinks per second. Signed-off-by: Felipe Contreras --- kernel/panic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/panic.c b

[PATCH 3/3] panic: enable local IRQs for restart timeout too

2013-11-07 Thread Felipe Contreras
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- kernel/panic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/panic.c b/kernel/panic.c index 5a0bdaa..e32919f 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -133,6 +133,8 @@ void panic(const char

[PATCH 2/3] panic: improve panic_timeout calculation

2013-11-07 Thread Felipe Contreras
We want to calculate the blinks per second, and instead of making it 5 (1000 / (3600 / 18)), let's make it 4, so the user can see two blinks per second. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- kernel/panic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 1/3] panic: setup panic_timeout early

2013-11-07 Thread Felipe Contreras
Otherwise we might not reboot when the user needs it the most (early on). Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- kernel/panic.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/kernel/panic.c b/kernel/panic.c index b6c482c..46e37ff 100644

[PATCH 0/3] panic: improvements

2013-11-07 Thread Felipe Contreras
Hi, While debugging a hang after panic in my laptop (I cannot hard-reboot, or unplug the battery), I noticed the panic code has some areas of improvment. Only the first patch is really needed, the rest seem like good to have. Felipe Contreras (3): panic: setup panic_timeout early panic

Re: [PATCH] staging: new asus fan driver

2013-11-05 Thread Felipe Contreras
On Tue, Nov 5, 2013 at 8:19 PM, Greg Kroah-Hartman wrote: > On Tue, Nov 05, 2013 at 01:54:51PM -0600, Felipe Contreras wrote: >> On Tue, Nov 5, 2013 at 9:16 AM, Greg Kroah-Hartman >> wrote: >> > On Tue, Nov 05, 2013 at 08:29:40AM -0600, Felipe Contreras wrote: >>

Re: [PATCH] staging: new asus fan driver

2013-11-05 Thread Felipe Contreras
On Tue, Nov 5, 2013 at 9:16 AM, Greg Kroah-Hartman wrote: > On Tue, Nov 05, 2013 at 08:29:40AM -0600, Felipe Contreras wrote: >> On Tue, Nov 5, 2013 at 6:52 AM, Greg Kroah-Hartman >> wrote: >> > On Tue, Nov 05, 2013 at 02:59:47AM -0600, Felipe Contreras wrote: >&

[PATCH v2] staging: new asus fan driver

2013-11-05 Thread Felipe Contreras
to be saved after it has been manually changed because it won't be reported properly until it goes back to 'auto' mode. [1] http://forum.notebookreview.com/asus/705656-fan-control-asus-prime-ux31-ux31a-ux32a-ux32vd.html Signed-off-by: Felipe Contreras --- Changes since v1: * Added a missing TODO

Re: [PATCH] staging: new asus fan driver

2013-11-05 Thread Felipe Contreras
On Tue, Nov 5, 2013 at 6:52 AM, Greg Kroah-Hartman wrote: > On Tue, Nov 05, 2013 at 02:59:47AM -0600, Felipe Contreras wrote: >> Simple driver to enable control of the fan in ASUS laptops. So far this >> has only been tested in ASUS Zenbook Prime UX31A, but according to some >

[PATCH] staging: new asus fan driver

2013-11-05 Thread Felipe Contreras
to be saved after it has been manually changed because it won't be reported properly until it goes back to 'auto' mode. [1] http://forum.notebookreview.com/asus/705656-fan-control-asus-prime-ux31-ux31a-ux32a-ux32vd.html Signed-off-by: Felipe Contreras --- Two incarnations of this code exists [1

[PATCH] staging: new asus fan driver

2013-11-05 Thread Felipe Contreras
to be saved after it has been manually changed because it won't be reported properly until it goes back to 'auto' mode. [1] http://forum.notebookreview.com/asus/705656-fan-control-asus-prime-ux31-ux31a-ux32a-ux32vd.html Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- Two

Re: [PATCH] staging: new asus fan driver

2013-11-05 Thread Felipe Contreras
On Tue, Nov 5, 2013 at 6:52 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Tue, Nov 05, 2013 at 02:59:47AM -0600, Felipe Contreras wrote: Simple driver to enable control of the fan in ASUS laptops. So far this has only been tested in ASUS Zenbook Prime UX31A, but according to some

[PATCH v2] staging: new asus fan driver

2013-11-05 Thread Felipe Contreras
to be saved after it has been manually changed because it won't be reported properly until it goes back to 'auto' mode. [1] http://forum.notebookreview.com/asus/705656-fan-control-asus-prime-ux31-ux31a-ux32a-ux32vd.html Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- Changes since

Re: [PATCH] staging: new asus fan driver

2013-11-05 Thread Felipe Contreras
On Tue, Nov 5, 2013 at 9:16 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Tue, Nov 05, 2013 at 08:29:40AM -0600, Felipe Contreras wrote: On Tue, Nov 5, 2013 at 6:52 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Tue, Nov 05, 2013 at 02:59:47AM -0600, Felipe

Re: [PATCH] staging: new asus fan driver

2013-11-05 Thread Felipe Contreras
On Tue, Nov 5, 2013 at 8:19 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Tue, Nov 05, 2013 at 01:54:51PM -0600, Felipe Contreras wrote: On Tue, Nov 5, 2013 at 9:16 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Tue, Nov 05, 2013 at 08:29:40AM -0600, Felipe

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-18 Thread Felipe Contreras
On Fri, Oct 18, 2013 at 5:43 AM, Stefan Hellermann wrote: > 2013/10/3 Felipe Contreras >> >> On Thu, Oct 3, 2013 at 12:13 PM, Felipe Contreras >> wrote: >> > More people have reported they need this for their machines to work >> > correctly. >> >

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-18 Thread Felipe Contreras
On Fri, Oct 18, 2013 at 5:43 AM, Stefan Hellermann ste...@the2masters.de wrote: 2013/10/3 Felipe Contreras felipe.contre...@gmail.com On Thu, Oct 3, 2013 at 12:13 PM, Felipe Contreras felipe.contre...@gmail.com wrote: More people have reported they need this for their machines to work

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-14 Thread Felipe Contreras
On Mon, Oct 14, 2013 at 6:34 PM, Matthew Garrett wrote: > On Mon, Oct 14, 2013 at 06:27:33PM -0500, Felipe Contreras wrote: >> On Mon, Oct 14, 2013 at 6:22 PM, Matthew Garrett wrote: >> > The easiest is to just do it from userspace. I think Intel have some >> > code fo

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-14 Thread Felipe Contreras
On Mon, Oct 14, 2013 at 6:22 PM, Matthew Garrett wrote: > On Mon, Oct 14, 2013 at 06:18:36PM -0500, Felipe Contreras wrote: >> On Mon, Oct 14, 2013 at 10:52 AM, Matthew Garrett >> wrote: >> > It wouldn't be appropriate to alter the firmware behaviour by default, >&g

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-14 Thread Felipe Contreras
On Mon, Oct 14, 2013 at 10:52 AM, Matthew Garrett wrote: > On Sun, Oct 13, 2013 at 09:31:25PM -0500, Felipe Contreras wrote: >> On Sun, Oct 13, 2013 at 10:17 AM, Matthew Garrett >> wrote: >> > The spec doesn't seem to constrain it to physical addresses (it just >>

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-14 Thread Felipe Contreras
On Mon, Oct 14, 2013 at 9:16 AM, Rafael J. Wysocki wrote: > On Monday, October 14, 2013 08:14:28 AM Felipe Contreras wrote: >> On Mon, Oct 14, 2013 at 6:58 AM, Rafael J. Wysocki wrote: >> > On Sunday, October 13, 2013 10:30:50 PM Felipe Contreras wrote: >> >> O

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-14 Thread Felipe Contreras
On Mon, Oct 14, 2013 at 6:58 AM, Rafael J. Wysocki wrote: > On Sunday, October 13, 2013 10:30:50 PM Felipe Contreras wrote: >> On Thu, Oct 3, 2013 at 12:13 PM, Felipe Contreras >> wrote: >> > More people have reported they need this for their machines to work >>

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-14 Thread Felipe Contreras
On Mon, Oct 14, 2013 at 6:58 AM, Rafael J. Wysocki r...@sisk.pl wrote: On Sunday, October 13, 2013 10:30:50 PM Felipe Contreras wrote: On Thu, Oct 3, 2013 at 12:13 PM, Felipe Contreras felipe.contre...@gmail.com wrote: More people have reported they need this for their machines to work

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-14 Thread Felipe Contreras
On Mon, Oct 14, 2013 at 9:16 AM, Rafael J. Wysocki r...@sisk.pl wrote: On Monday, October 14, 2013 08:14:28 AM Felipe Contreras wrote: On Mon, Oct 14, 2013 at 6:58 AM, Rafael J. Wysocki r...@sisk.pl wrote: On Sunday, October 13, 2013 10:30:50 PM Felipe Contreras wrote: On Thu, Oct 3, 2013

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-14 Thread Felipe Contreras
On Mon, Oct 14, 2013 at 10:52 AM, Matthew Garrett mj...@srcf.ucam.org wrote: On Sun, Oct 13, 2013 at 09:31:25PM -0500, Felipe Contreras wrote: On Sun, Oct 13, 2013 at 10:17 AM, Matthew Garrett mj...@srcf.ucam.org wrote: The spec doesn't seem to constrain it to physical addresses (it just

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-14 Thread Felipe Contreras
On Mon, Oct 14, 2013 at 6:22 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Mon, Oct 14, 2013 at 06:18:36PM -0500, Felipe Contreras wrote: On Mon, Oct 14, 2013 at 10:52 AM, Matthew Garrett mj...@srcf.ucam.org wrote: It wouldn't be appropriate to alter the firmware behaviour by default

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-14 Thread Felipe Contreras
On Mon, Oct 14, 2013 at 6:34 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Mon, Oct 14, 2013 at 06:27:33PM -0500, Felipe Contreras wrote: On Mon, Oct 14, 2013 at 6:22 PM, Matthew Garrett mj...@srcf.ucam.org wrote: The easiest is to just do it from userspace. I think Intel have some code

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-13 Thread Felipe Contreras
On Thu, Oct 3, 2013 at 12:13 PM, Felipe Contreras wrote: > More people have reported they need this for their machines to work > correctly. > > https://bugzilla.kernel.org/show_bug.cgi?id=60682 I see this was merged to the linux-next branch. Is there any reason why it's not propos

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-13 Thread Felipe Contreras
On Sun, Oct 13, 2013 at 10:17 AM, Matthew Garrett wrote: > On Sun, Oct 13, 2013 at 04:29:34AM -0500, Felipe Contreras wrote: > >> I don't see anything in acpi_ex_system_memory_space_handler() that >> takes into consideration virtual addresses. > > The spec doesn't seem to

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-13 Thread Felipe Contreras
- are we artificially limiting > SystemMemory opregions to physical addresses? I don't see anything in acpi_ex_system_memory_space_handler() that takes into consideration virtual addresses. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-13 Thread Felipe Contreras
On Thu, Oct 10, 2013 at 10:59 AM, Corentin Chary wrote: > > > > On Tue, Oct 8, 2013 at 1:48 PM, Felipe Contreras > wrote: >> >> Simple driver to enable control of the fan in ASUS laptops. So far this >> has only been tested in ASUS Zenbook Prime UX31A, but acco

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-13 Thread Felipe Contreras
On Thu, Oct 10, 2013 at 10:59 AM, Corentin Chary corentin.ch...@gmail.com wrote: On Tue, Oct 8, 2013 at 1:48 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Simple driver to enable control of the fan in ASUS laptops. So far this has only been tested in ASUS Zenbook Prime UX31A

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-13 Thread Felipe Contreras
SystemMemory opregions to physical addresses? I don't see anything in acpi_ex_system_memory_space_handler() that takes into consideration virtual addresses. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-13 Thread Felipe Contreras
On Sun, Oct 13, 2013 at 10:17 AM, Matthew Garrett mj...@srcf.ucam.org wrote: On Sun, Oct 13, 2013 at 04:29:34AM -0500, Felipe Contreras wrote: I don't see anything in acpi_ex_system_memory_space_handler() that takes into consideration virtual addresses. The spec doesn't seem to constrain

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-13 Thread Felipe Contreras
On Thu, Oct 3, 2013 at 12:13 PM, Felipe Contreras felipe.contre...@gmail.com wrote: More people have reported they need this for their machines to work correctly. https://bugzilla.kernel.org/show_bug.cgi?id=60682 I see this was merged to the linux-next branch. Is there any reason why it's

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-08 Thread Felipe Contreras
On Tue, Oct 8, 2013 at 7:48 AM, Felipe Contreras wrote: > Simple driver to enable control of the fan in ASUS laptops. So far this > has only been tested in ASUS Zenbook Prime UX31A, but according to some > online reference [1], it should work in other models as well. > > The

[PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-08 Thread Felipe Contreras
to be saved after it has been manually changed because it won't be reported properly until it goes back to 'auto' mode. [1] http://forum.notebookreview.com/asus/705656-fan-control-asus-prime-ux31-ux31a-ux32a-ux32vd.html Signed-off-by: Felipe Contreras --- drivers/platform/x86/asus-wmi.c | 105

[PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-08 Thread Felipe Contreras
to be saved after it has been manually changed because it won't be reported properly until it goes back to 'auto' mode. [1] http://forum.notebookreview.com/asus/705656-fan-control-asus-prime-ux31-ux31a-ux32a-ux32vd.html Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- drivers

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-08 Thread Felipe Contreras
On Tue, Oct 8, 2013 at 7:48 AM, Felipe Contreras felipe.contre...@gmail.com wrote: Simple driver to enable control of the fan in ASUS laptops. So far this has only been tested in ASUS Zenbook Prime UX31A, but according to some online reference [1], it should work in other models as well

[RESEND/PATCH 2/2] x86: asus-laptop: trivial style cleanups

2013-10-07 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- drivers/platform/x86/asus-laptop.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index 0e9c169..0210cf4 100644 --- a/drivers/platform/x86/asus-laptop.c +++ b

[RESEND/PATCH 1/2] acpi: fan: trivial style cleanup

2013-10-07 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- drivers/acpi/fan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c index 41ade65..ba3da88 100644 --- a/drivers/acpi/fan.c +++ b/drivers/acpi/fan.c @@ -168,7 +168,7 @@ static int acpi_fan_add(struct

[RESEND/PATCH 0/2] Trivial style cleanups

2013-10-07 Thread Felipe Contreras
Hi, Exactly the same as last time. Felipe Contreras (2): acpi: fan: trivial style cleanup x86: asus-laptop: trivial style cleanups drivers/acpi/fan.c | 2 +- drivers/platform/x86/asus-laptop.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) -- 1.8.4-fc

[RESEND/PATCH 0/2] Trivial style cleanups

2013-10-07 Thread Felipe Contreras
Hi, Exactly the same as last time. Felipe Contreras (2): acpi: fan: trivial style cleanup x86: asus-laptop: trivial style cleanups drivers/acpi/fan.c | 2 +- drivers/platform/x86/asus-laptop.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) -- 1.8.4-fc

[RESEND/PATCH 1/2] acpi: fan: trivial style cleanup

2013-10-07 Thread Felipe Contreras
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- drivers/acpi/fan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c index 41ade65..ba3da88 100644 --- a/drivers/acpi/fan.c +++ b/drivers/acpi/fan.c @@ -168,7 +168,7 @@ static

[RESEND/PATCH 2/2] x86: asus-laptop: trivial style cleanups

2013-10-07 Thread Felipe Contreras
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- drivers/platform/x86/asus-laptop.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index 0e9c169..0210cf4 100644 --- a/drivers/platform

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
fic semantics getting smashed. How about we worry about hypothetical issues when they arise? (which is probably going to be never). Personally I think this is more than enough: http://article.gmane.org/gmane.linux.acpi.devel/64243 -- Felipe Contreras -- To unsubscribe from this list: send th

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
On Sun, Oct 6, 2013 at 8:27 PM, Matthew Garrett wrote: > On Sun, Oct 06, 2013 at 08:01:34PM -0500, Felipe Contreras wrote: >> On Sun, Oct 6, 2013 at 7:53 PM, Matthew Garrett wrote: >> > No, it demonstrably doesn't. The comments that do exist refer to only a >> > subse

[PATCH] acpi: add missing win8 OSI comment to blacklist

2013-10-06 Thread Felipe Contreras
/1572459 Signed-off-by: Felipe Contreras --- drivers/acpi/blacklist.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c index 9515f18..42cccbe 100644 --- a/drivers/acpi/blacklist.c +++ b/drivers/acpi/blacklist.c @@ -273,6 +273,11 @@ static

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
On Sun, Oct 6, 2013 at 7:53 PM, Matthew Garrett wrote: > On Sun, Oct 06, 2013 at 07:50:18PM -0500, Felipe Contreras wrote: >> On Sun, Oct 6, 2013 at 7:32 PM, Matthew Garrett wrote: >> > I don't get the final >> > say in whether or not this patch gets merged, but t

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
On Sun, Oct 6, 2013 at 7:32 PM, Matthew Garrett wrote: > On Sun, Oct 06, 2013 at 07:27:48PM -0500, Felipe Contreras wrote: > >> If _you_ want to add comments for each entry in the list you can do so >> after this patch is applied. > > If you want to participate in a c

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
On Sun, Oct 6, 2013 at 6:57 PM, Matthew Garrett wrote: > On Sun, Oct 06, 2013 at 06:36:57PM -0500, Felipe Contreras wrote: >> On Sun, Oct 6, 2013 at 6:31 PM, Matthew Garrett wrote: >> > On Sun, Oct 06, 2013 at 06:27:28PM -0500, Felipe Contreras wrote: >> &g

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
On Sun, Oct 6, 2013 at 6:31 PM, Matthew Garrett wrote: > On Sun, Oct 06, 2013 at 06:27:28PM -0500, Felipe Contreras wrote: >> From acpi_osi_dmi_table: >> >> /* >> * BIOS invocation of _OSI(Linux) is almost always a BIOS bug. >> * Linux ignores it, except

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
On Sun, Oct 6, 2013 at 3:59 PM, Matthew Garrett wrote: > On Sun, Oct 06, 2013 at 03:51:05PM -0500, Felipe Contreras wrote: >> On Sun, Oct 6, 2013 at 3:45 PM, Matthew Garrett wrote: >> > On Sun, Oct 06, 2013 at 03:40:42PM -0500, Felipe Contreras wrote: >> > >> >

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
On Sun, Oct 6, 2013 at 3:45 PM, Matthew Garrett wrote: > On Sun, Oct 06, 2013 at 03:40:42PM -0500, Felipe Contreras wrote: > >> In case you didn't hear, the plan was to add an entry if a user >> reports the backlight not working correctly, and acpi_osi="!

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
On Sun, Oct 6, 2013 at 3:33 PM, Matthew Garrett wrote: > On Sun, Oct 06, 2013 at 03:29:10PM -0500, Felipe Contreras wrote: >> On Fri, Oct 4, 2013 at 11:12 AM, Matthew Garrett wrote: >> > On Thu, Oct 03, 2013 at 12:13:03PM -0500, Felipe Contreras wrote: >> >> More

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
On Fri, Oct 4, 2013 at 11:12 AM, Matthew Garrett wrote: > On Thu, Oct 03, 2013 at 12:13:03PM -0500, Felipe Contreras wrote: >> More people have reported they need this for their machines to work >> correctly. > > Can you add a comment to each indicating why they're being add

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
On Fri, Oct 4, 2013 at 11:12 AM, Matthew Garrett mj...@srcf.ucam.org wrote: On Thu, Oct 03, 2013 at 12:13:03PM -0500, Felipe Contreras wrote: More people have reported they need this for their machines to work correctly. Can you add a comment to each indicating why they're being added so we

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
On Sun, Oct 6, 2013 at 3:33 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Sun, Oct 06, 2013 at 03:29:10PM -0500, Felipe Contreras wrote: On Fri, Oct 4, 2013 at 11:12 AM, Matthew Garrett mj...@srcf.ucam.org wrote: On Thu, Oct 03, 2013 at 12:13:03PM -0500, Felipe Contreras wrote: More

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
On Sun, Oct 6, 2013 at 3:45 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Sun, Oct 06, 2013 at 03:40:42PM -0500, Felipe Contreras wrote: In case you didn't hear, the plan was to add an entry if a user reports the backlight not working correctly, and acpi_osi=!Windows 2012 fixing

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
On Sun, Oct 6, 2013 at 3:59 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Sun, Oct 06, 2013 at 03:51:05PM -0500, Felipe Contreras wrote: On Sun, Oct 6, 2013 at 3:45 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Sun, Oct 06, 2013 at 03:40:42PM -0500, Felipe Contreras wrote: In case

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
On Sun, Oct 6, 2013 at 6:31 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Sun, Oct 06, 2013 at 06:27:28PM -0500, Felipe Contreras wrote: From acpi_osi_dmi_table: /* * BIOS invocation of _OSI(Linux) is almost always a BIOS bug. * Linux ignores it, except for the machines enumerated below

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
On Sun, Oct 6, 2013 at 6:57 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Sun, Oct 06, 2013 at 06:36:57PM -0500, Felipe Contreras wrote: On Sun, Oct 6, 2013 at 6:31 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Sun, Oct 06, 2013 at 06:27:28PM -0500, Felipe Contreras wrote: From

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
On Sun, Oct 6, 2013 at 7:32 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Sun, Oct 06, 2013 at 07:27:48PM -0500, Felipe Contreras wrote: If _you_ want to add comments for each entry in the list you can do so after this patch is applied. If you want to participate in a collaborative

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
On Sun, Oct 6, 2013 at 7:53 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Sun, Oct 06, 2013 at 07:50:18PM -0500, Felipe Contreras wrote: On Sun, Oct 6, 2013 at 7:32 PM, Matthew Garrett mj...@srcf.ucam.org wrote: I don't get the final say in whether or not this patch gets merged

[PATCH] acpi: add missing win8 OSI comment to blacklist

2013-10-06 Thread Felipe Contreras
/1572459 Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- drivers/acpi/blacklist.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c index 9515f18..42cccbe 100644 --- a/drivers/acpi/blacklist.c +++ b/drivers/acpi/blacklist.c

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
On Sun, Oct 6, 2013 at 8:27 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Sun, Oct 06, 2013 at 08:01:34PM -0500, Felipe Contreras wrote: On Sun, Oct 6, 2013 at 7:53 PM, Matthew Garrett mj...@srcf.ucam.org wrote: No, it demonstrably doesn't. The comments that do exist refer to only

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-06 Thread Felipe Contreras
: http://article.gmane.org/gmane.linux.acpi.devel/64243 -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-03 Thread Felipe Contreras
On Thu, Oct 3, 2013 at 12:13 PM, Felipe Contreras wrote: > More people have reported they need this for their machines to work > correctly. > > https://bugzilla.kernel.org/show_bug.cgi?id=60682 Reported-by: Stefan Hellermann Reported-by: Benedikt Sauer Reported-by: Erno Kuuse

[PATCH] acpi: update win8 OSI blacklist

2013-10-03 Thread Felipe Contreras
More people have reported they need this for their machines to work correctly. https://bugzilla.kernel.org/show_bug.cgi?id=60682 Signed-off-by: Felipe Contreras --- drivers/acpi/blacklist.c | 48 1 file changed, 48 insertions(+) diff --git

[PATCH] acpi: update win8 OSI blacklist

2013-10-03 Thread Felipe Contreras
More people have reported they need this for their machines to work correctly. https://bugzilla.kernel.org/show_bug.cgi?id=60682 Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- drivers/acpi/blacklist.c | 48 1 file changed, 48

Re: [PATCH] acpi: update win8 OSI blacklist

2013-10-03 Thread Felipe Contreras
On Thu, Oct 3, 2013 at 12:13 PM, Felipe Contreras felipe.contre...@gmail.com wrote: More people have reported they need this for their machines to work correctly. https://bugzilla.kernel.org/show_bug.cgi?id=60682 Reported-by: Stefan Hellermann bugzilla.kernel@the2masters.de Reported

[PATCH] acpi: fan: trivial style cleanup

2013-08-30 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- drivers/acpi/fan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c index 5b02a0a..0898649 100644 --- a/drivers/acpi/fan.c +++ b/drivers/acpi/fan.c @@ -168,7 +168,7 @@ static int acpi_fan_add(struct

[PATCH] x86: asus-laptop: trivial style cleanups

2013-08-30 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- drivers/platform/x86/asus-laptop.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index 8e268da..81a5f26 100644 --- a/drivers/platform/x86/asus-laptop.c +++ b

[PATCH] x86: asus-laptop: trivial style cleanups

2013-08-30 Thread Felipe Contreras
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- drivers/platform/x86/asus-laptop.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index 8e268da..81a5f26 100644 --- a/drivers/platform

[PATCH] acpi: fan: trivial style cleanup

2013-08-30 Thread Felipe Contreras
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- drivers/acpi/fan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c index 5b02a0a..0898649 100644 --- a/drivers/acpi/fan.c +++ b/drivers/acpi/fan.c @@ -168,7 +168,7 @@ static

[PATCH] acpi: blacklist win8 OSI for buggy laptops

2013-08-25 Thread Felipe Contreras
ndows 2012"). Once the Intel backlight driver works correctly for all machines, this blacklist can be removed and that driver can be used instead. https://bugzilla.kernel.org/show_bug.cgi?id=60682 Signed-off-by: Felipe Contreras --- drivers/acpi/blackl

[PATCH] acpi: blacklist win8 OSI for buggy laptops

2013-08-25 Thread Felipe Contreras
2012). Once the Intel backlight driver works correctly for all machines, this blacklist can be removed and that driver can be used instead. https://bugzilla.kernel.org/show_bug.cgi?id=60682 Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- drivers/acpi/blacklist.c | 35

Re: [RESEND/PATCH] acpi: video: remove unused code

2013-08-22 Thread Felipe Contreras
On Thu, Aug 22, 2013 at 4:38 PM, Rafael J. Wysocki wrote: > On Thursday, August 22, 2013 01:31:11 PM Felipe Contreras wrote: >> _BCM_use_index and _BCL_use_index are never used and probably never will. >> >> Signed-off-by: Felipe Contreras > > I have this patch in the

[RESEND/PATCH] acpi: video: remove unused code

2013-08-22 Thread Felipe Contreras
_BCM_use_index and _BCL_use_index are never used and probably never will. Signed-off-by: Felipe Contreras --- drivers/acpi/video.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index e1284b8..e6be27e 100644 --- a/drivers/acpi

[RESEND/PATCH] acpi: video: remove unused code

2013-08-22 Thread Felipe Contreras
_BCM_use_index and _BCL_use_index are never used and probably never will. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- drivers/acpi/video.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index e1284b8..e6be27e 100644

Re: [RESEND/PATCH] acpi: video: remove unused code

2013-08-22 Thread Felipe Contreras
On Thu, Aug 22, 2013 at 4:38 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Thursday, August 22, 2013 01:31:11 PM Felipe Contreras wrote: _BCM_use_index and _BCL_use_index are never used and probably never will. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com I have this patch

Re: [PATCH] thermal: new asus driver

2013-08-21 Thread Felipe Contreras
On Thu, Aug 15, 2013 at 2:22 AM, Zhang Rui wrote: > On 二, 2013-08-06 at 17:48 -0500, Felipe Contreras wrote: >> Simple driver to enable control of the fan in ASUS laptops. So far this >> has only been tested in ASUS Zenbook Prime UX31A, but according to some >> online ref

Re: [PATCH] thermal: new asus driver

2013-08-21 Thread Felipe Contreras
On Thu, Aug 15, 2013 at 2:22 AM, Zhang Rui rui.zh...@intel.com wrote: On 二, 2013-08-06 at 17:48 -0500, Felipe Contreras wrote: Simple driver to enable control of the fan in ASUS laptops. So far this has only been tested in ASUS Zenbook Prime UX31A, but according to some online reference [1

[PATCH] thermal: new asus driver

2013-08-06 Thread Felipe Contreras
://forum.notebookreview.com/asus/705656-fan-control-asus-prime-ux31-ux31a-ux32a-ux32vd.html [2] http://www.mail-archive.com/acpi4asus-user@lists.sourceforge.net/msg00065.html Signed-off-by: Felipe Contreras --- I've never implemented a driver like this, so I've no idea if this is the right way to do it. drivers

[PATCH] thermal: new asus driver

2013-08-06 Thread Felipe Contreras
://forum.notebookreview.com/asus/705656-fan-control-asus-prime-ux31-ux31a-ux32a-ux32vd.html [2] http://www.mail-archive.com/acpi4asus-user@lists.sourceforge.net/msg00065.html Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- I've never implemented a driver like this, so I've no idea if this is the right

Re: Linux 3.11-rc4

2013-08-05 Thread Felipe Contreras
On Mon, Aug 5, 2013 at 12:43 PM, Felipe Contreras wrote: > On Mon, Aug 5, 2013 at 12:39 PM, Linus Torvalds > wrote: > >> That said, Felipe, can you double-check that it's not timing-related >> in some subtle way, and test multiple times with just that commit >>

Re: Linux 3.11-rc4

2013-08-05 Thread Felipe Contreras
But I'll double-check. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Linux 3.11-rc4

2013-08-05 Thread Felipe Contreras
On Mon, Aug 5, 2013 at 12:11 PM, Oleg Nesterov wrote: > On 08/05, Felipe Contreras wrote: >> >> On Mon, Aug 5, 2013 at 9:39 AM, Oleg Nesterov wrote: >> > >> > Hmm. It should not crash under strace... please see below. >> > >> >> 953 p

Re: Linux 3.11-rc4

2013-08-05 Thread Felipe Contreras
On Mon, Aug 5, 2013 at 9:39 AM, Oleg Nesterov wrote: > On 08/05, Felipe Contreras wrote: >> >> On Mon, Aug 5, 2013 at 8:29 AM, Oleg Nesterov wrote: >> > >> > Could you please run wine under strace >> > >> > strace -f -e ptrace -o LOG

Re: [PATCH] acpi: video: improve quirk check

2013-08-05 Thread Felipe Contreras
common denominator is what Windows expects (and that unfortunately > depends on the version of Windows too), because that's the functionality > which is likely to have been tested. Anything else is likely to be untested > and therefore most probably buggy. Maybe, or maybe we are doing

Re: Linux 3.11-rc4

2013-08-05 Thread Felipe Contreras
On Mon, Aug 5, 2013 at 8:29 AM, Oleg Nesterov wrote: > On 08/04, Felipe Contreras wrote: >> >> I found a regression while running all v3.11-rcX kernels; Starcract II >> through wine crashes. > > Thanks... just to clarify, Starcract crashes, wine or kernel? It's Sta

Re: Linux 3.11-rc4

2013-08-05 Thread Felipe Contreras
On Mon, Aug 5, 2013 at 8:29 AM, Oleg Nesterov o...@redhat.com wrote: On 08/04, Felipe Contreras wrote: I found a regression while running all v3.11-rcX kernels; Starcract II through wine crashes. Thanks... just to clarify, Starcract crashes, wine or kernel? It's Starcraft. In fact

Re: [PATCH] acpi: video: improve quirk check

2013-08-05 Thread Felipe Contreras
on the version of Windows too), because that's the functionality which is likely to have been tested. Anything else is likely to be untested and therefore most probably buggy. Maybe, or maybe we are doing something wrong. It's worth to try to find that out. -- Felipe Contreras -- To unsubscribe from

Re: Linux 3.11-rc4

2013-08-05 Thread Felipe Contreras
On Mon, Aug 5, 2013 at 9:39 AM, Oleg Nesterov o...@redhat.com wrote: On 08/05, Felipe Contreras wrote: On Mon, Aug 5, 2013 at 8:29 AM, Oleg Nesterov o...@redhat.com wrote: Could you please run wine under strace strace -f -e ptrace -o LOG wine ... and show the result? Sure

Re: Linux 3.11-rc4

2013-08-05 Thread Felipe Contreras
On Mon, Aug 5, 2013 at 12:11 PM, Oleg Nesterov o...@redhat.com wrote: On 08/05, Felipe Contreras wrote: On Mon, Aug 5, 2013 at 9:39 AM, Oleg Nesterov o...@redhat.com wrote: Hmm. It should not crash under strace... please see below. 953 ptrace(PTRACE_ATTACH, 1035, 0, 0) = -1 EPERM

Re: Linux 3.11-rc4

2013-08-05 Thread Felipe Contreras
to be a race. But I'll double-check. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Linux 3.11-rc4

2013-08-05 Thread Felipe Contreras
On Mon, Aug 5, 2013 at 12:43 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Aug 5, 2013 at 12:39 PM, Linus Torvalds torva...@linux-foundation.org wrote: That said, Felipe, can you double-check that it's not timing-related in some subtle way, and test multiple times with just

<    1   2   3   4   >