ode movement looks big if you
> don't do git renames (ie like the patches I upload).
I found a regression while running all v3.11-rcX kernels; Starcract II
through wine crashes. The culprit is fab840f (ptrace: PTRACE_DETACH
should do flush_ptrace_hw_breakpoint(child)), I revert that commit and
there's
breakpoints.
There is something wrong with this patch. I've bisected an issue I've
seen in v3.11-rcx kernels while running Starcraft II through wine,
it's crashes 100% of the time, I revert this patch, and there's no
crash any more.
--
Felipe Contreras
--
To unsubscribe from this list: send the line
On Sun, Aug 4, 2013 at 9:19 AM, Rafael J. Wysocki wrote:
> On Sunday, August 04, 2013 01:42:49 AM Felipe Contreras wrote:
>> Personally I think there are better ways to fix the code for the
>> synthetic case than what you patch does, which will also make _BQC
>> work. That c
On Sun, Aug 4, 2013 at 9:14 AM, Rafael J. Wysocki wrote:
> On Sunday, August 04, 2013 01:54:21 AM Felipe Contreras wrote:
>> But we cannot achieve either of those for v3.11, the only
>> possibilities seem to be either a) revert efaa14c, or b) keep it and
>> apply my patch.
On Sat, Aug 3, 2013 at 8:47 PM, Aaron Lu wrote:
> On Sun, Aug 4, 2013 at 6:20 AM, Felipe Contreras
> wrote:
>> On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki wrote:
>>> Do we still need to revert commit efaa14c if this patch is applied?
>>
>> I guess not.
On Sat, Aug 3, 2013 at 8:18 PM, Aaron Lu wrote:
> On 08/03/2013 07:34 PM, Rafael J. Wysocki wrote:
>> On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote:
>>> On 08/03/2013 07:47 AM, Rafael J. Wysocki wrote:
>>>> On Friday, August 02, 2013 02:37:09 PM Felipe Cont
On Sat, Aug 3, 2013 at 8:18 PM, Aaron Lu aaron@gmail.com wrote:
On 08/03/2013 07:34 PM, Rafael J. Wysocki wrote:
On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote:
On 08/03/2013 07:47 AM, Rafael J. Wysocki wrote:
On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote
On Sat, Aug 3, 2013 at 8:47 PM, Aaron Lu aaron@gmail.com wrote:
On Sun, Aug 4, 2013 at 6:20 AM, Felipe Contreras
felipe.contre...@gmail.com wrote:
On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki r...@sisk.pl wrote:
Do we still need to revert commit efaa14c if this patch is applied?
I
On Sun, Aug 4, 2013 at 9:14 AM, Rafael J. Wysocki r...@sisk.pl wrote:
On Sunday, August 04, 2013 01:54:21 AM Felipe Contreras wrote:
But we cannot achieve either of those for v3.11, the only
possibilities seem to be either a) revert efaa14c, or b) keep it and
apply my patch. Anything else
On Sun, Aug 4, 2013 at 9:19 AM, Rafael J. Wysocki r...@sisk.pl wrote:
On Sunday, August 04, 2013 01:42:49 AM Felipe Contreras wrote:
Personally I think there are better ways to fix the code for the
synthetic case than what you patch does, which will also make _BQC
work. That can be discussed
breakpoints.
There is something wrong with this patch. I've bisected an issue I've
seen in v3.11-rcx kernels while running Starcraft II through wine,
it's crashes 100% of the time, I revert this patch, and there's no
crash any more.
--
Felipe Contreras
--
To unsubscribe from this list: send the line
the patches I upload).
I found a regression while running all v3.11-rcX kernels; Starcract II
through wine crashes. The culprit is fab840f (ptrace: PTRACE_DETACH
should do flush_ptrace_hw_breakpoint(child)), I revert that commit and
there's no crash.
--
Felipe Contreras
--
To unsubscribe from
On Sat, Aug 3, 2013 at 6:27 PM, Igor Gnatenko
wrote:
> On Sat, 2013-08-03 at 15:21 -0500, Felipe Contreras wrote:
>> On Sat, Aug 3, 2013 at 11:08 AM, Igor Gnatenko
>> wrote:
>>
>> > I am opposed to this patch. On ThinkPad X230 I had problems with it.
>&
On Sat, Aug 3, 2013 at 5:38 PM, Rafael J. Wysocki wrote:
> On Saturday, August 03, 2013 05:20:33 PM Felipe Contreras wrote:
>> On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki wrote:
>> > On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote:
>> >>
On Sat, Aug 3, 2013 at 5:21 PM, Rafael J. Wysocki wrote:
> On Saturday, August 03, 2013 05:06:10 PM Felipe Contreras wrote:
>> On Sat, Aug 3, 2013 at 4:59 PM, Rafael J. Wysocki wrote:
>
> [...]
>
>> > Whatever you are thinking you will achieve this way, it doesn't wo
On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki wrote:
> On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote:
>> On Sat, Aug 3, 2013 at 6:34 AM, Rafael J. Wysocki wrote:
>> > On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote:
>>
>> >> Ye
On Sat, Aug 3, 2013 at 4:59 PM, Rafael J. Wysocki wrote:
> On Saturday, August 03, 2013 03:20:22 PM Felipe Contreras wrote:
>> On Sat, Aug 3, 2013 at 6:54 AM, Rafael J. Wysocki wrote:
>> > On Friday, August 02, 2013 08:48:09 PM Felipe Contreras wrote:
>>
>> >>
On Sat, Aug 3, 2013 at 6:38 AM, Rafael J. Wysocki wrote:
> On Friday, August 02, 2013 08:34:29 PM Felipe Contreras wrote:
>> On Fri, Aug 2, 2013 at 7:07 PM, Rafael J. Wysocki wrote:
>> > On Friday, August 02, 2013 12:52:18 PM Felipe Contreras wrote:
>> >> On Fri, Au
don't think his patch is needed though.
--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Sat, Aug 3, 2013 at 11:08 AM, Igor Gnatenko
wrote:
> I am opposed to this patch. On ThinkPad X230 I had problems with it.
> Felipe, come over to dark side. They have cookies.
And v3.11-rc3 works's fine out-of-the box?
--
Felipe Contreras
--
To unsubscribe from this list: send th
On Sat, Aug 3, 2013 at 6:54 AM, Rafael J. Wysocki wrote:
> On Friday, August 02, 2013 08:48:09 PM Felipe Contreras wrote:
>> Yes, that's fine, either the revert, or the patch I mentioned, or
>> something else, but something has to be done, and it was better to do
>> it in v3
On Sat, Aug 3, 2013 at 6:54 AM, Rafael J. Wysocki r...@sisk.pl wrote:
On Friday, August 02, 2013 08:48:09 PM Felipe Contreras wrote:
Yes, that's fine, either the revert, or the patch I mentioned, or
something else, but something has to be done, and it was better to do
it in v3.11-rc4 than
On Sat, Aug 3, 2013 at 11:08 AM, Igor Gnatenko
i.gnatenko.br...@gmail.com wrote:
I am opposed to this patch. On ThinkPad X230 I had problems with it.
Felipe, come over to dark side. They have cookies.
And v3.11-rc3 works's fine out-of-the box?
--
Felipe Contreras
--
To unsubscribe from
.
--
Felipe Contreras
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Sat, Aug 3, 2013 at 6:38 AM, Rafael J. Wysocki r...@sisk.pl wrote:
On Friday, August 02, 2013 08:34:29 PM Felipe Contreras wrote:
On Fri, Aug 2, 2013 at 7:07 PM, Rafael J. Wysocki r...@sisk.pl wrote:
On Friday, August 02, 2013 12:52:18 PM Felipe Contreras wrote:
On Fri, Aug 2, 2013 at 9
On Sat, Aug 3, 2013 at 4:59 PM, Rafael J. Wysocki r...@sisk.pl wrote:
On Saturday, August 03, 2013 03:20:22 PM Felipe Contreras wrote:
On Sat, Aug 3, 2013 at 6:54 AM, Rafael J. Wysocki r...@sisk.pl wrote:
On Friday, August 02, 2013 08:48:09 PM Felipe Contreras wrote:
Yes, that's fine
On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki r...@sisk.pl wrote:
On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote:
On Sat, Aug 3, 2013 at 6:34 AM, Rafael J. Wysocki r...@sisk.pl wrote:
On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote:
Yes, the patch is correct
On Sat, Aug 3, 2013 at 5:21 PM, Rafael J. Wysocki r...@sisk.pl wrote:
On Saturday, August 03, 2013 05:06:10 PM Felipe Contreras wrote:
On Sat, Aug 3, 2013 at 4:59 PM, Rafael J. Wysocki r...@sisk.pl wrote:
[...]
Whatever you are thinking you will achieve this way, it doesn't work
On Sat, Aug 3, 2013 at 5:38 PM, Rafael J. Wysocki r...@sisk.pl wrote:
On Saturday, August 03, 2013 05:20:33 PM Felipe Contreras wrote:
On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki r...@sisk.pl wrote:
On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote:
On Sat, Aug 3, 2013
On Sat, Aug 3, 2013 at 6:27 PM, Igor Gnatenko
i.gnatenko.br...@gmail.com wrote:
On Sat, 2013-08-03 at 15:21 -0500, Felipe Contreras wrote:
On Sat, Aug 3, 2013 at 11:08 AM, Igor Gnatenko
i.gnatenko.br...@gmail.com wrote:
I am opposed to this patch. On ThinkPad X230 I had problems
On Fri, Aug 2, 2013 at 5:21 PM, Rafael J. Wysocki wrote:
> On Friday, August 02, 2013 04:31:37 PM Felipe Contreras wrote:
>> On Fri, Aug 2, 2013 at 4:21 PM, Rafael J. Wysocki wrote:
>> > On Friday, August 02, 2013 02:12:49 PM Felipe Contreras wrote:
>>
>
On Fri, Aug 2, 2013 at 7:07 PM, Rafael J. Wysocki wrote:
> On Friday, August 02, 2013 12:52:18 PM Felipe Contreras wrote:
>> On Fri, Aug 2, 2013 at 9:05 AM, Rafael J. Wysocki wrote:
>> > On Thursday, August 01, 2013 11:15:38 PM Felipe Contreras wrote:
>> >> On Thu,
On Fri, Aug 2, 2013 at 8:19 PM, Rafael J. Wysocki wrote:
> On Friday, August 02, 2013 08:07:37 PM Felipe Contreras wrote:
>> On Fri, Aug 2, 2013 at 8:16 PM, Rafael J. Wysocki wrote:
>> > On Friday, August 02, 2013 08:04:52 PM Felipe Contreras wrote:
>> >> On Fri, Au
On Fri, Aug 2, 2013 at 7:01 PM, Rafael J. Wysocki wrote:
> On Friday, August 02, 2013 12:56:09 PM Felipe Contreras wrote:
>> On Fri, Aug 2, 2013 at 9:09 AM, Rafael J. Wysocki wrote:
>> > On Thursday, August 01, 2013 11:18:34 PM Felipe Contreras wrote:
>> >> On Thu,
On Fri, Aug 2, 2013 at 8:16 PM, Rafael J. Wysocki wrote:
> On Friday, August 02, 2013 08:04:52 PM Felipe Contreras wrote:
>> On Fri, Aug 2, 2013 at 6:47 PM, Rafael J. Wysocki wrote:
>> > On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote:
>> >> If
On Fri, Aug 2, 2013 at 6:47 PM, Rafael J. Wysocki wrote:
> On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote:
>> If the _BCL package is descending, the first level (br->levels[2]) will
>> be 0, and if the number of levels matches the number of steps, we might
>
On Fri, Aug 2, 2013 at 6:35 PM, Rafael J. Wysocki wrote:
> On Friday, August 02, 2013 01:58:55 PM Felipe Contreras wrote:
>> On Fri, Aug 2, 2013 at 9:03 AM, Rafael J. Wysocki wrote:
>> > On Friday, August 02, 2013 01:48:37 AM Felipe Contreras wrote:
>> >&g
On Fri, Aug 2, 2013 at 4:21 PM, Rafael J. Wysocki wrote:
> On Friday, August 02, 2013 02:12:49 PM Felipe Contreras wrote:
>> You forgot this patch:
>>
>> https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next=3706231332d57072e0e2c0e59975443f3f1
checked this issue with acpi_osi="!Windows 2012".
Please do.
--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
y increasing), as if it didn't remember previous value to
> standby mode.
>
> This was something that before didn't happen.
You mean with acpi_osi="!Windows 2012"? And when you say "before",
what do you mean?
--
Felipe Contreras
--
To unsubscribe from this list
10; xbacklight
-set 20; would flash to 90% and then slowly down to the desired level
(20).
The solution is simple; test anything other than the first level (e.g.
1).
Signed-off-by: Felipe Contreras
---
On top of this we might want to test yet another value, because br->levels[3]
might be the c
u forgot this patch:
https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next=3706231332d57072e0e2c0e59975443f3f18e673
Or do you think it's fine to boot these machines into a black screen?
--
Felipe Contreras
--
To unsubscribe from this list: send the line
On Fri, Aug 2, 2013 at 9:03 AM, Rafael J. Wysocki wrote:
> On Friday, August 02, 2013 01:48:37 AM Felipe Contreras wrote:
>> On Fri, Aug 2, 2013 at 1:25 AM, Josep Lladonosa wrote:
>> > Hello,
>> >
>> > I am using a Lenovo Edge E530 and, with ker
On Fri, Aug 2, 2013 at 9:09 AM, Rafael J. Wysocki wrote:
> On Thursday, August 01, 2013 11:18:34 PM Felipe Contreras wrote:
>> On Thu, Aug 1, 2013 at 8:55 PM, Aaron Lu wrote:
>> > On 08/02/2013 07:44 AM, Felipe Contreras wrote:
>> >> Signed-off-by: Felipe Contrera
On Fri, Aug 2, 2013 at 9:05 AM, Rafael J. Wysocki wrote:
> On Thursday, August 01, 2013 11:15:38 PM Felipe Contreras wrote:
>> On Thu, Aug 1, 2013 at 8:50 PM, Aaron Lu wrote:
>> > On 08/02/2013 07:43 AM, Felipe Contreras wrote:
>> >> Signed-off-by: Felipe Contrera
On Fri, Aug 2, 2013 at 3:25 AM, Aaron Lu wrote:
> On 08/02/2013 04:14 PM, Felipe Contreras wrote:
>> On Fri, Aug 2, 2013 at 3:06 AM, Aaron Lu wrote:
>>> On 08/02/2013 03:59 PM, Felipe Contreras wrote:
>>>> On Fri, Aug 2, 2013 at 1:56 AM, Aaron Lu wrote:
>&g
On Fri, Aug 2, 2013 at 3:06 AM, Aaron Lu wrote:
> On 08/02/2013 03:59 PM, Felipe Contreras wrote:
>> On Fri, Aug 2, 2013 at 1:56 AM, Aaron Lu wrote:
>>> On 08/02/2013 02:44 PM, Felipe Contreras wrote:
>>
>>>> The initial _BCM commands don't work, so t
On Fri, Aug 2, 2013 at 1:56 AM, Aaron Lu wrote:
> On 08/02/2013 02:44 PM, Felipe Contreras wrote:
>> The initial _BCM commands don't work, so the level remains at 100%.
>> Since the level is max_level, acpi_video_bqc_quirk() tries with the
>> first level, whic
y obvious that for the time being we need to
blacklist a ton of machines so they boot without this OSI. In fact, in
might make sense to simply remove the OSI completely for all machines
(for now).
--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe li
On Thu, Aug 1, 2013 at 11:59 PM, Aaron Lu wrote:
> On 08/02/2013 12:50 PM, Felipe Contreras wrote:
>> On Thu, Aug 1, 2013 at 11:30 PM, Aaron Lu wrote:
>>> Please see acpi_video_bqc_quirk, we set _BQC_use_index by revert the
>>> level on a reversed _BCL, so we will ne
On Fri, Aug 2, 2013 at 9:05 AM, Rafael J. Wysocki r...@sisk.pl wrote:
On Thursday, August 01, 2013 11:15:38 PM Felipe Contreras wrote:
On Thu, Aug 1, 2013 at 8:50 PM, Aaron Lu aaron@gmail.com wrote:
On 08/02/2013 07:43 AM, Felipe Contreras wrote:
Signed-off-by: Felipe Contreras
On Fri, Aug 2, 2013 at 9:09 AM, Rafael J. Wysocki r...@sisk.pl wrote:
On Thursday, August 01, 2013 11:18:34 PM Felipe Contreras wrote:
On Thu, Aug 1, 2013 at 8:55 PM, Aaron Lu aaron@gmail.com wrote:
On 08/02/2013 07:44 AM, Felipe Contreras wrote:
Signed-off-by: Felipe Contreras
On Fri, Aug 2, 2013 at 9:03 AM, Rafael J. Wysocki r...@sisk.pl wrote:
On Friday, August 02, 2013 01:48:37 AM Felipe Contreras wrote:
On Fri, Aug 2, 2013 at 1:25 AM, Josep Lladonosa jllad...@gmail.com wrote:
Hello,
I am using a Lenovo Edge E530 and, with kernel 3.11.0-rc3, I had to
change
/rafael/linux-pm.git/commit/?h=linux-nextid=3706231332d57072e0e2c0e59975443f3f18e673
Or do you think it's fine to boot these machines into a black screen?
--
Felipe Contreras
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
; xbacklight
-set 20; would flash to 90% and then slowly down to the desired level
(20).
The solution is simple; test anything other than the first level (e.g.
1).
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
On top of this we might want to test yet another value, because br-levels
(by increasing), as if it didn't remember previous value to
standby mode.
This was something that before didn't happen.
You mean with acpi_osi=!Windows 2012? And when you say before,
what do you mean?
--
Felipe Contreras
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
with acpi_osi=!Windows 2012.
Please do.
--
Felipe Contreras
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Fri, Aug 2, 2013 at 4:21 PM, Rafael J. Wysocki r...@sisk.pl wrote:
On Friday, August 02, 2013 02:12:49 PM Felipe Contreras wrote:
You forgot this patch:
https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-nextid=3706231332d57072e0e2c0e59975443f3f18e673
Or do
On Fri, Aug 2, 2013 at 6:35 PM, Rafael J. Wysocki r...@sisk.pl wrote:
On Friday, August 02, 2013 01:58:55 PM Felipe Contreras wrote:
On Fri, Aug 2, 2013 at 9:03 AM, Rafael J. Wysocki r...@sisk.pl wrote:
On Friday, August 02, 2013 01:48:37 AM Felipe Contreras wrote:
I think it's pretty
On Fri, Aug 2, 2013 at 6:47 PM, Rafael J. Wysocki r...@sisk.pl wrote:
On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote:
If the _BCL package is descending, the first level (br-levels[2]) will
be 0, and if the number of levels matches the number of steps, we might
confuse a returned
On Fri, Aug 2, 2013 at 8:16 PM, Rafael J. Wysocki r...@sisk.pl wrote:
On Friday, August 02, 2013 08:04:52 PM Felipe Contreras wrote:
On Fri, Aug 2, 2013 at 6:47 PM, Rafael J. Wysocki r...@sisk.pl wrote:
On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote:
If the _BCL package
On Fri, Aug 2, 2013 at 7:01 PM, Rafael J. Wysocki r...@sisk.pl wrote:
On Friday, August 02, 2013 12:56:09 PM Felipe Contreras wrote:
On Fri, Aug 2, 2013 at 9:09 AM, Rafael J. Wysocki r...@sisk.pl wrote:
On Thursday, August 01, 2013 11:18:34 PM Felipe Contreras wrote:
On Thu, Aug 1, 2013 at 8
On Fri, Aug 2, 2013 at 8:19 PM, Rafael J. Wysocki r...@sisk.pl wrote:
On Friday, August 02, 2013 08:07:37 PM Felipe Contreras wrote:
On Fri, Aug 2, 2013 at 8:16 PM, Rafael J. Wysocki r...@sisk.pl wrote:
On Friday, August 02, 2013 08:04:52 PM Felipe Contreras wrote:
On Fri, Aug 2, 2013 at 6
On Fri, Aug 2, 2013 at 7:07 PM, Rafael J. Wysocki r...@sisk.pl wrote:
On Friday, August 02, 2013 12:52:18 PM Felipe Contreras wrote:
On Fri, Aug 2, 2013 at 9:05 AM, Rafael J. Wysocki r...@sisk.pl wrote:
On Thursday, August 01, 2013 11:15:38 PM Felipe Contreras wrote:
On Thu, Aug 1, 2013 at 8
On Fri, Aug 2, 2013 at 5:21 PM, Rafael J. Wysocki r...@sisk.pl wrote:
On Friday, August 02, 2013 04:31:37 PM Felipe Contreras wrote:
On Fri, Aug 2, 2013 at 4:21 PM, Rafael J. Wysocki r...@sisk.pl wrote:
On Friday, August 02, 2013 02:12:49 PM Felipe Contreras wrote:
You forgot this patch
On Thu, Aug 1, 2013 at 11:59 PM, Aaron Lu aaron...@intel.com wrote:
On 08/02/2013 12:50 PM, Felipe Contreras wrote:
On Thu, Aug 1, 2013 at 11:30 PM, Aaron Lu aaron...@intel.com wrote:
Please see acpi_video_bqc_quirk, we set _BQC_use_index by revert the
level on a reversed _BCL, so we
we need to
blacklist a ton of machines so they boot without this OSI. In fact, in
might make sense to simply remove the OSI completely for all machines
(for now).
--
Felipe Contreras
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
On Fri, Aug 2, 2013 at 1:56 AM, Aaron Lu aaron...@intel.com wrote:
On 08/02/2013 02:44 PM, Felipe Contreras wrote:
The initial _BCM commands don't work, so the level remains at 100%.
Since the level is max_level, acpi_video_bqc_quirk() tries with the
first level, which is 0, and 0 happens
On Fri, Aug 2, 2013 at 3:06 AM, Aaron Lu aaron...@intel.com wrote:
On 08/02/2013 03:59 PM, Felipe Contreras wrote:
On Fri, Aug 2, 2013 at 1:56 AM, Aaron Lu aaron...@intel.com wrote:
On 08/02/2013 02:44 PM, Felipe Contreras wrote:
The initial _BCM commands don't work, so the level remains
On Fri, Aug 2, 2013 at 3:25 AM, Aaron Lu aaron...@intel.com wrote:
On 08/02/2013 04:14 PM, Felipe Contreras wrote:
On Fri, Aug 2, 2013 at 3:06 AM, Aaron Lu aaron...@intel.com wrote:
On 08/02/2013 03:59 PM, Felipe Contreras wrote:
On Fri, Aug 2, 2013 at 1:56 AM, Aaron Lu aaron...@intel.com
_BCM_use_index and _BCL_use_index are never used and probably never will.
Signed-off-by: Felipe Contreras
---
drivers/acpi/video.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 0ec434d..1a04dfe 100644
--- a/drivers/acpi
_BCM_use_index is never used and probably never will.
Signed-off-by: Felipe Contreras
---
drivers/acpi/video.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 0ec434d..54e2d4d 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi
On Thu, Aug 1, 2013 at 11:30 PM, Aaron Lu wrote:
> On 08/02/2013 12:11 PM, Felipe Contreras wrote:
>> On Thu, Aug 1, 2013 at 9:03 PM, Aaron Lu wrote:
>>> On 08/02/2013 07:34 AM, Felipe Contreras wrote:
>>>> Commit 1a7c618 (ACPI video: support _BQC/_BCL/_BCM meth
On Thu, Aug 1, 2013 at 8:55 PM, Aaron Lu wrote:
> On 08/02/2013 07:44 AM, Felipe Contreras wrote:
>> Signed-off-by: Felipe Contreras
>
> Change log please.
You mean a commit message? That's what it's called in Git lingo, and
it's right there:
acpi: video: trivial
On Thu, Aug 1, 2013 at 8:50 PM, Aaron Lu wrote:
> On 08/02/2013 07:43 AM, Felipe Contreras wrote:
>> Signed-off-by: Felipe Contreras
>
> Please add change log explaining what you have changed.
> It seems that the patch modify comment style only, some add a space and
> some
On Thu, Aug 1, 2013 at 9:03 PM, Aaron Lu wrote:
> On 08/02/2013 07:34 AM, Felipe Contreras wrote:
>> Commit 1a7c618 (ACPI video: support _BQC/_BCL/_BCM methods that use
>> index values) assumed that bl->levels were not reverted, but at this
>> point they already are, so t
Hi,
Here's a few patches to cleanup the code-style of acpi/video.c. Some were found
by checkpatch, and some just make sense.
Felipe Contreras (3):
acpi: video: trivial costmetic cleanups
acpi: video: trivial style cleanups
acpi: video: remove unnecessary casting
drivers/acpi/video.c
Signed-off-by: Felipe Contreras
---
drivers/acpi/video.c | 90 +++-
1 file changed, 40 insertions(+), 50 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index f021bf4..b07573f 100644
--- a/drivers/acpi/video.c
+++ b/drivers
Signed-off-by: Felipe Contreras
---
drivers/acpi/video.c | 114 +++
1 file changed, 61 insertions(+), 53 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 0ec434d..f021bf4 100644
--- a/drivers/acpi/video.c
+++ b/drivers
Signed-off-by: Felipe Contreras
---
drivers/acpi/video.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index b07573f..11bafbe 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -236,8 +236,7 @@ static int
On Tue, Jul 30, 2013 at 7:11 PM, Felipe Contreras
wrote:
> It is already broken in v3.11-rc3, in fact I just booted that to try
> it out and it booted with the screen completely black (fortunately I
> knew exactly what to type to change that).
>
> Also, each time I change the
&g
Commit 1a7c618 (ACPI video: support _BQC/_BCL/_BCM methods that use
index values) assumed that bl->levels were not reverted, but at this
point they already are, so there's no need to revert them yet again.
Signed-off-by: Felipe Contreras
---
drivers/acpi/video.c | 13 ++---
1 f
On Tue, Jul 30, 2013 at 9:22 PM, Aaron Lu wrote:
> On 07/31/2013 10:07 AM, Felipe Contreras wrote:
>> On Tue, Jul 30, 2013 at 8:36 PM, Aaron Lu wrote:
>>> On 07/31/2013 08:11 AM, Felipe Contreras wrote:
>>>> On Tue, Jul 30, 2013 at 6:13 PM, Rafael J. Wysocki wrot
On Thu, Aug 1, 2013 at 1:01 PM, Matthew Garrett wrote:
> On Thu, Aug 01, 2013 at 12:50:18PM -0500, Felipe Contreras wrote:
>> On Thu, Aug 1, 2013 at 12:42 PM, Matthew Garrett wrote:
>> > An interface that describes reality is better than one that doesn't. But
>> >
On Thu, Aug 1, 2013 at 12:42 PM, Matthew Garrett wrote:
> On Thu, Aug 01, 2013 at 12:37:04PM -0500, Felipe Contreras wrote:
>> On Wed, Jul 31, 2013 at 1:47 PM, Matthew Garrett wrote:
>> > If we can't make an interface 100% consistent, we shouldn't pretend that
>>
On Wed, Jul 31, 2013 at 1:47 PM, Matthew Garrett wrote:
> On Wed, Jul 31, 2013 at 01:07:57PM -0500, Felipe Contreras wrote:
>> If we can make the software behave consistently for 99% of the
>> machines out there instead of only 90%, that's better.
>
> If we can't make an inte
On Wed, Jul 31, 2013 at 1:47 PM, Matthew Garrett mj...@srcf.ucam.org wrote:
On Wed, Jul 31, 2013 at 01:07:57PM -0500, Felipe Contreras wrote:
If we can make the software behave consistently for 99% of the
machines out there instead of only 90%, that's better.
If we can't make an interface 100
On Thu, Aug 1, 2013 at 12:42 PM, Matthew Garrett mj...@srcf.ucam.org wrote:
On Thu, Aug 01, 2013 at 12:37:04PM -0500, Felipe Contreras wrote:
On Wed, Jul 31, 2013 at 1:47 PM, Matthew Garrett mj...@srcf.ucam.org wrote:
If we can't make an interface 100% consistent, we shouldn't pretend
On Thu, Aug 1, 2013 at 1:01 PM, Matthew Garrett mj...@srcf.ucam.org wrote:
On Thu, Aug 01, 2013 at 12:50:18PM -0500, Felipe Contreras wrote:
On Thu, Aug 1, 2013 at 12:42 PM, Matthew Garrett mj...@srcf.ucam.org wrote:
An interface that describes reality is better than one that doesn't
On Tue, Jul 30, 2013 at 9:22 PM, Aaron Lu aaron@gmail.com wrote:
On 07/31/2013 10:07 AM, Felipe Contreras wrote:
On Tue, Jul 30, 2013 at 8:36 PM, Aaron Lu aaron@gmail.com wrote:
On 07/31/2013 08:11 AM, Felipe Contreras wrote:
On Tue, Jul 30, 2013 at 6:13 PM, Rafael J. Wysocki r
Commit 1a7c618 (ACPI video: support _BQC/_BCL/_BCM methods that use
index values) assumed that bl-levels were not reverted, but at this
point they already are, so there's no need to revert them yet again.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
drivers/acpi/video.c | 13
On Tue, Jul 30, 2013 at 7:11 PM, Felipe Contreras
felipe.contre...@gmail.com wrote:
It is already broken in v3.11-rc3, in fact I just booted that to try
it out and it booted with the screen completely black (fortunately I
knew exactly what to type to change that).
Also, each time I change
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
drivers/acpi/video.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index b07573f..11bafbe 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -236,8
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
drivers/acpi/video.c | 90 +++-
1 file changed, 40 insertions(+), 50 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index f021bf4..b07573f 100644
--- a/drivers
Hi,
Here's a few patches to cleanup the code-style of acpi/video.c. Some were found
by checkpatch, and some just make sense.
Felipe Contreras (3):
acpi: video: trivial costmetic cleanups
acpi: video: trivial style cleanups
acpi: video: remove unnecessary casting
drivers/acpi/video.c
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
drivers/acpi/video.c | 114 +++
1 file changed, 61 insertions(+), 53 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 0ec434d..f021bf4 100644
--- a/drivers
On Thu, Aug 1, 2013 at 9:03 PM, Aaron Lu aaron@gmail.com wrote:
On 08/02/2013 07:34 AM, Felipe Contreras wrote:
Commit 1a7c618 (ACPI video: support _BQC/_BCL/_BCM methods that use
index values) assumed that bl-levels were not reverted, but at this
point they already are, so there's no need
On Thu, Aug 1, 2013 at 8:50 PM, Aaron Lu aaron@gmail.com wrote:
On 08/02/2013 07:43 AM, Felipe Contreras wrote:
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
Please add change log explaining what you have changed.
It seems that the patch modify comment style only, some add
On Thu, Aug 1, 2013 at 8:55 PM, Aaron Lu aaron@gmail.com wrote:
On 08/02/2013 07:44 AM, Felipe Contreras wrote:
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
Change log please.
You mean a commit message? That's what it's called in Git lingo, and
it's right there:
acpi: video
On Thu, Aug 1, 2013 at 11:30 PM, Aaron Lu aaron...@intel.com wrote:
On 08/02/2013 12:11 PM, Felipe Contreras wrote:
On Thu, Aug 1, 2013 at 9:03 PM, Aaron Lu aaron@gmail.com wrote:
On 08/02/2013 07:34 AM, Felipe Contreras wrote:
Commit 1a7c618 (ACPI video: support _BQC/_BCL/_BCM methods
201 - 300 of 360 matches
Mail list logo
