Re: [PATCH 1/2] dt-bindings: phy: add bcm63xx-usbh bindings

2020-06-16 Thread Florian Fainelli
On 6/16/2020 1:34 AM, Álvaro Fernández Rojas wrote: > Document BCM63xx USBH PHY bindings. > > Signed-off-by: Álvaro Fernández Rojas > --- > .../bindings/phy/brcm,bcm63xx-usbh-phy.yaml | 72 +++ > 1 file changed, 72 insertions(+) > create mode 100644 >

Re: [PATCH v3 2/4] spi: bcm63xx-spi: allow building for BMIPS

2020-06-16 Thread Florian Fainelli
On 6/16/2020 10:07 AM, Mark Brown wrote: > On Tue, Jun 16, 2020 at 09:02:21AM +0200, Álvaro Fernández Rojas wrote: >> bcm63xx-spi controller is present on several BMIPS SoCs (BCM6358, BCM6362, >> BCM6368 and BCM63268). > > Please do not submit new versions of already applied patches, please >

Re: [PATCH v3 3/4] spi: bcm63xx-hsspi: add reset support

2020-06-16 Thread Florian Fainelli
On 6/16/2020 12:02 AM, Álvaro Fernández Rojas wrote: > bcm63xx arch resets the HSSPI controller at early boot. However, bmips arch > needs to perform a reset when probing the driver. > > Signed-off-by: Álvaro Fernández Rojas > Reviewed-by: Philipp Zabel > --- Same comment as patch #1. --

Re: [PATCH v3 1/4] spi: bcm63xx-spi: add reset support

2020-06-16 Thread Florian Fainelli
t for you already. You can only do: if (IS_ERR(reset)) return PTR_ERR(reset); and that's it. With that fixed in v4, you can add: Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2] spi: bcm2835: Enable shared interrupt support

2020-06-15 Thread Florian Fainelli
On 6/15/2020 12:09 PM, Robin Murphy wrote: > On 2020-06-08 12:41, Lukas Wunner wrote: >> On Mon, Jun 08, 2020 at 12:11:11PM +0100, Robin Murphy wrote: >>> And all in code that has at least one obvious inefficiency left on >>> the table either way. >> >> Care to submit a patch to overcome that

Re: [PATCH v2] spi: bcm2835: Enable shared interrupt support

2020-06-15 Thread Florian Fainelli
On 6/15/2020 10:00 AM, Mark Brown wrote: > On Mon, Jun 15, 2020 at 09:34:58AM -0700, Florian Fainelli wrote: > >> OK, so this has been dropped for spi/for-next right? How do we move from >> there? > > Well, I actually have it queued up for applying so unless I pull it

Re: [PATCH v2] spi: bcm2835: Enable shared interrupt support

2020-06-15 Thread Florian Fainelli
On 6/8/2020 4:28 AM, Mark Brown wrote: > On Mon, Jun 08, 2020 at 12:11:11PM +0100, Robin Murphy wrote: > >> Again, 2 cycles. The overhead of a static key alone is at least 50% of that. >> And that's not even considering whether the change in code layout caused by >> doubling up the IRQ handler

Re: [PATCH v4] mtd: parsers: bcm63xx: simplify CFE detection

2020-06-15 Thread Florian Fainelli
On 6/15/2020 2:17 AM, Álvaro Fernández Rojas wrote: > Instead of trying to parse CFE version string, which is customized by some > vendors, let's just check that "CFE1" was passed on argument 3. > > Signed-off-by: Álvaro Fernández Rojas > Signed-off-by: Jonas Gors

Re: [PATCH v2 0/4] spi: bcm63xx: add BMIPS support

2020-06-15 Thread Florian Fainelli
Hi Alvaro, On 6/15/2020 2:09 AM, Álvaro Fernández Rojas wrote: > BCM63xx SPI and HSSPI controller are present on several BMIPS SoCs (BCM6318, > BCM6328, BCM6358, BCM6362, BCM6368 and BCM63268). > > v2: use devm_reset_control_get_exclusive We would also need to write a binding document for these

Re: [PATCH v2 2/4] spi: bcm63xx-spi: allow building for BMIPS

2020-06-15 Thread Florian Fainelli
On 6/15/2020 2:09 AM, Álvaro Fernández Rojas wrote: > bcm63xx-spi controller is present on several BMIPS SoCs (BCM6358, BCM6362, > BCM6368 and BCM63268). > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 4/4] spi: bcm63xx-hsspi: allow building for BMIPS

2020-06-15 Thread Florian Fainelli
On 6/15/2020 2:09 AM, Álvaro Fernández Rojas wrote: > bcm63xx-hsspi controller is present on several BMIPS SoCs (BCM6318, BCM6328, > BCM6362 and BCM63268). > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 1/4] spi: bcm63xx-spi: add reset support

2020-06-15 Thread Florian Fainelli
On 6/15/2020 2:09 AM, Álvaro Fernández Rojas wrote: > bcm63xx arch resets the SPI controller at early boot. However, bmips arch > needs to perform a reset when probing the driver. > > Signed-off-by: Álvaro Fernández Rojas > Reviewed-by: Philipp Zabel > --- > v2: use

Re: [PATCH v4 3/9] reset: add BCM6345 reset controller driver

2020-06-13 Thread Florian Fainelli
On 6/13/2020 1:38 AM, Álvaro Fernández Rojas wrote: > Add support for resetting blocks through the Linux reset controller > subsystem for BCM63xx SoCs. > > Signed-off-by: Álvaro Fernández Rojas With the kbuild robot error fixed: Reviewed-by: Florian Fainelli Thanks! -- Florian

Re: [PATCH v4 9/9] mips: bmips: add BCM6318 reset controller definitions

2020-06-13 Thread Florian Fainelli
On 6/13/2020 1:38 AM, Álvaro Fernández Rojas wrote: > BCM6318 SoCs have a reset controller for certain components. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH v4 8/9] mips: bmips: dts: add BCM63268 reset controller support

2020-06-13 Thread Florian Fainelli
On 6/13/2020 1:38 AM, Álvaro Fernández Rojas wrote: > BCM63268 SoCs have a reset controller for certain components. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH v4 9/9] mips: bmips: dts: add BCM63268 power domain support

2020-06-13 Thread Florian Fainelli
On 6/13/2020 1:21 AM, Álvaro Fernández Rojas wrote: > BCM63268 SoCs have a power domain controller to enable/disable certain > components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH v4 6/9] soc: bcm: add BCM63xx power domain driver

2020-06-13 Thread Florian Fainelli
On 6/13/2020 1:21 AM, Álvaro Fernández Rojas wrote: > BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller > to enable/disable certain components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v4 5/9] mips: bmips: add BCM6318 power domain definitions

2020-06-13 Thread Florian Fainelli
On 6/13/2020 1:21 AM, Álvaro Fernández Rojas wrote: > BCM6318 SoCs have a power domain controller to enable/disable certain > components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v4 4/9] mips: bmips: add BCM63268 power domain definitions

2020-06-13 Thread Florian Fainelli
On 6/13/2020 1:21 AM, Álvaro Fernández Rojas wrote: > BCM63268 SoCs have a power domain controller to enable/disable certain > components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v4 3/9] mips: bmips: add BCM6362 power domain definitions

2020-06-13 Thread Florian Fainelli
On 6/13/2020 1:21 AM, Álvaro Fernández Rojas wrote: > BCM6362 SoCs have a power domain controller to enable/disable certain > components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v4 2/9] mips: bmips: add BCM6328 power domain definitions

2020-06-13 Thread Florian Fainelli
On 6/13/2020 1:21 AM, Álvaro Fernández Rojas wrote: > BCM6328 SoCs have a power domain controller to enable/disable certain > components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 2/9] dt-bindings: reset: add BCM6345 reset controller bindings

2020-06-12 Thread Florian Fainelli
On 6/12/2020 2:57 PM, Rob Herring wrote: > On Wed, 10 Jun 2020 19:28:52 +0200, Álvaro Fernández Rojas wrote: >> Add device tree binding documentation for BCM6345 reset controller. >> >> Signed-off-by: Álvaro Fernández Rojas >> Reviewed-by: Florian Fainelli >>

Re: [PATCH v3 5/9] usb: xhci-pci: Add support for reset controllers

2020-06-12 Thread Florian Fainelli
: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 00/11] arm/arm64: Turning IPIs into normal interrupts

2020-06-12 Thread Florian Fainelli
On 6/12/2020 2:49 AM, Marc Zyngier wrote: > Hi Florian, > > On Tue, 19 May 2020 10:50:46 -0700 > Florian Fainelli wrote: > >> On 5/19/2020 9:17 AM, Marc Zyngier wrote: >>> For as long as SMP ARM has existed, IPIs have been handled as >>> something s

Re: [PATCH stable 4.9 00/21] Unbreak 32-bit DVB applications on 64-bit kernels

2020-06-11 Thread Florian Fainelli
On 6/5/2020 9:24 AM, Florian Fainelli wrote: > Hi all, > > This long patch series was motivated by backporting Jaedon's changes > which add a proper ioctl compatibility layer for 32-bit applications > running on 64-bit kernels. We have a number of Android TV-based products >

[PATCH stable 4.9] arm64: entry: Place an SB sequence following an ERET instruction

2020-06-11 Thread Florian Fainelli
at the point of an ERET, this could potentially be used as part of a side-channel attack. This patch emits an SB sequence after each ERET so that speculation is held up on exception return. Signed-off-by: Will Deacon [florian: Adjust hyp-entry.S to account for the label] Signed-off-by: Florian

Re: [PATCH v4 2/3] clk: bcm: Add BCM2711 DVP driver

2020-06-11 Thread Florian Fainelli
On 6/11/2020 9:52 AM, Maxime Ripard wrote: > Hi Stefan, > > On Thu, Jun 11, 2020 at 05:50:30PM +0200, Stefan Wahren wrote: >>> diff --git a/drivers/clk/bcm/clk-bcm2711-dvp.c >>> b/drivers/clk/bcm/clk-bcm2711-dvp.c >>> new file mode 100644 >>> index ..84dbc886e303 >>> --- /dev/null

Re: [PATCH v2] mtd: parsers: bcm63xx: simplify CFE detection

2020-06-11 Thread Florian Fainelli
On 6/11/2020 8:16 AM, Álvaro Fernández Rojas wrote: > Hi Miquel, > >> El 11 jun 2020, a las 9:55, Miquel Raynal >> escribió: >> >> Hi Álvaro, >> >> Álvaro Fernández Rojas wrote on Mon, 8 Jun 2020 >> 18:06:49 +0200: >> >>> Instead of trying to parse CFE version string, which is customized

Re: [PATCH 2/2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-10 Thread Florian Fainelli
On 6/10/2020 12:15 PM, Jonathan McDowell wrote: > This patch improves the handling of the SGMII interface on the QCA8K > devices. Previously the driver did no configuration of the port, even if > it was selected. We now configure it up in the appropriate > PHY/MAC/Base-X mode depending on what

Re: [PATCH 1/2] net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB

2020-06-10 Thread Florian Fainelli
On 6/10/2020 12:14 PM, Jonathan McDowell wrote: > Update the driver to use the new PHYLINK callbacks, removing the > legacy adjust_link callback. > > Signed-off-by: Jonathan McDowell This looks reasonable to me, Russell would be the person you want to get an Acked-by/Reviewed-by tag from. --

Re: [PATCH v2 2/6] soc: bcm: add BCM63xx power domain driver

2020-06-10 Thread Florian Fainelli
On 6/10/2020 9:32 AM, Álvaro Fernández Rojas wrote: > BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller > to enable/disable certain components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas Thanks for addressing the previous comments, this looks

Re: [PATCH v2 0/6] bmips: add BCM63xx power domain controller

2020-06-10 Thread Florian Fainelli
On 6/10/2020 9:32 AM, Álvaro Fernández Rojas wrote: > BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller > to enable/disable certain components in order to save power. > > v2: Introduce changes suggested by Florian: > - Add separate YAML file for dt-bindings. > -

Re: [PATCH v2 1/6] dt-bindings: soc: brcm: add BCM63xx power domain binding

2020-06-10 Thread Florian Fainelli
On 6/10/2020 9:32 AM, Álvaro Fernández Rojas wrote: > BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller > to enable/disable certain components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-10 Thread Florian Fainelli
On 6/9/2020 11:26 PM, Sascha Hauer wrote: > Hi Andrew, > > +Cc Maxime Chevallier > > On Tue, Jun 09, 2020 at 03:28:48PM +0200, Andrew Lunn wrote: >> On Tue, Jun 09, 2020 at 03:11:52PM +0200, Sascha Hauer wrote: >>> The Marvell MVNETA Ethernet controller supports a 2.5Gbps SGMII mode >>>

Re: [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support

2020-06-10 Thread Florian Fainelli
On 6/10/2020 1:29 AM, Philippe Mathieu-Daudé wrote: > Hi, > > On Wed, Jun 10, 2020 at 8:13 AM Álvaro Fernández Rojas > wrote: >> >> Hi Florian, >> >>> El 10 jun 2020, a las 4:27, Florian Fainelli >>> escribió: >>> >>> >&

Re: [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support

2020-06-09 Thread Florian Fainelli
{ .name = "mips", .bit = 13, .flags = CLK_IS_CRITICAL, }, > + { .name = "pcie", .bit = 14, }, > + { .name = "robosw250", .bit = 16, }, > + { .name = "robosw025", .bit = 17, }, > + { .name = "sdr", .bit = 19, .flags = CLK_IS_CRITICAL, }, > + { .name = "usb", .bit = 20, }, This should probably be "usbd" to indicate this is the USB device clock (not host) With that fixed: Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 4/4] mips: bmips: dts: add BCM6362 power domain support

2020-06-09 Thread Florian Fainelli
On 6/9/2020 3:52 AM, Álvaro Fernández Rojas wrote: > BCM6362 SoCs have a power domain controller to enable/disable certain > components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings

2020-06-09 Thread Florian Fainelli
On 6/9/2020 4:30 AM, Álvaro Fernández Rojas wrote: > Add BCM6318 to the binding documentation for the gated clock controllers found > on BCM63xx SoCs. > > Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH] clk: bcm63xx-gate: fix last clock availability

2020-06-09 Thread Florian Fainelli
On 6/9/2020 4:08 AM, Álvaro Fernández Rojas wrote: > In order to make the last clock available, maxbit has to be set to the > highest bit value plus 1. > > Fixes: 1c099779c1e2 ("clk: add BCM63XX gated clock controller driver") > Signed-off-by: Álvaro Fernández Roj

Re: [PATCH 4/4] mips: bmips: dts: add BCM6362 power domain support

2020-06-09 Thread Florian Fainelli
On 6/9/2020 3:52 AM, Álvaro Fernández Rojas wrote: > BCM6362 SoCs have a power domain controller to enable/disable certain > components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH 2/4] soc: bcm: add BCM63xx power domain driver

2020-06-09 Thread Florian Fainelli
On 6/9/2020 3:52 AM, Álvaro Fernández Rojas wrote: > BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller > to enable/disable certain components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas > --- > drivers/soc/bcm/Kconfig | 8 + >

Re: [PATCH 1/4] dt-bindings: soc: brcm: add BCM63xx power domain binding

2020-06-09 Thread Florian Fainelli
On 6/9/2020 3:52 AM, Álvaro Fernández Rojas wrote: > BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller > to enable/disable certain components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas > --- > .../devicetree/bindings/mips/brcm/soc.txt |

Re: [PATCH 3/4] mips: bmips: dts: add BCM6328 power domain support

2020-06-09 Thread Florian Fainelli
On 6/9/2020 3:52 AM, Álvaro Fernández Rojas wrote: > BCM6328 SoCs have a power domain controller to enable/disable certain > components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 2/7] dt-bindings: reset: add BCM6345 reset controller bindings

2020-06-09 Thread Florian Fainelli
to me though: Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 6/7] mips: bmips: dts: add BCM6362 reset controller support

2020-06-09 Thread Florian Fainelli
On 6/9/2020 9:02 AM, Álvaro Fernández Rojas wrote: > BCM6362 SoCs have a reset controller for certain components. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 7/7] mips: bmips: dts: add BCM6368 reset controller support

2020-06-09 Thread Florian Fainelli
On 6/9/2020 9:02 AM, Álvaro Fernández Rojas wrote: > BCM6368 SoCs have a reset controller for certain components. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 5/7] mips: bmips: dts: add BCM6358 reset controller support

2020-06-09 Thread Florian Fainelli
On 6/9/2020 9:02 AM, Álvaro Fernández Rojas wrote: > BCM6358 SoCs have a reset controller for certain components. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 4/7] mips: bmips: dts: add BCM6328 reset controller support

2020-06-09 Thread Florian Fainelli
On 6/9/2020 9:02 AM, Álvaro Fernández Rojas wrote: > BCM6328 SoCs have a reset controller for certain components. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli You should probably create include files under include/dt-bindings/ which designate the vari

Re: [PATCH v2 3/7] drivers: reset: simple: add BCM6345 reset support

2020-06-09 Thread Florian Fainelli
On 6/9/2020 9:02 AM, Álvaro Fernández Rojas wrote: > Add support for resetting blocks through the Linux reset controller > subsystem for BCM63xx SoCs. > > Signed-off-by: Álvaro Fernández Rojas This looks good to me, however in v1 there was a need for sleeping after the reset assertion, and

Re: [PATCH v2 1/7] mips: bmips: select ARCH_HAS_RESET_CONTROLLER

2020-06-09 Thread Florian Fainelli
On 6/9/2020 9:02 AM, Álvaro Fernández Rojas wrote: > This allows to add reset controllers support. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH 3/7] reset: add BCM6345 reset controller driver

2020-06-09 Thread Florian Fainelli
On 6/9/2020 9:41 AM, Álvaro Fernández Rojas wrote: If you can do without this, with I think this driver could be made to use reset-simple. >>> >>> Yes, but only if I can add reset support with a configurable sleep range to >>> reset-simple. Is this possible? >> >> I should have

Re: [PATCH v2 3/9] ARM: dts: bcm2711: Add firmware usb reset node

2020-06-09 Thread Florian Fainelli
On 6/9/2020 10:49 AM, Nicolas Saenz Julienne wrote: > Now that the reset driver exposing Raspberry Pi 4's firmware based USB > reset routine is available, let's add the device tree node exposing it. > > Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 4/9] ARM: dts: bcm2711: Add reset controller to xHCI node

2020-06-09 Thread Florian Fainelli
the relevant PCI device. > > Signed-off-by: Nicolas Saenz Julienne With the comment from patch #2 to move the reset identifiers to a shared header that can be referenced by this file: Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 8/9] Revert "firmware: raspberrypi: Introduce vl805 init routine"

2020-06-09 Thread Florian Fainelli
On 6/9/2020 10:50 AM, Nicolas Saenz Julienne wrote: > This reverts commit fbbc5ff3f7f9f4cad562e530ae2cf5d8964fe6d3. > > The vl805 init routine has moved into drivers/reset/reset-raspberrypi.c > > Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 9/9] Revert "PCI: brcmstb: Wait for Raspberry Pi's firmware when present"

2020-06-09 Thread Florian Fainelli
do it manually here. > > Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 2/9] reset: Add Raspberry Pi 4 firmware reset controller

2020-06-09 Thread Florian Fainelli
+ */ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +struct rpi_reset { > + struct reset_controller_dev rcdev; > + struct rpi_firmware *fw; > +}; > + > +enum rpi_reset_ids { > + RASPBERRYPI_FIRMWARE_RESET_ID_USB, You should probably move this to a header file under include/dt-bindings/reset/ in order to ensure that what gets referenced by the DTS is in sync with what the driver knows about. With that: Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 6/9] Revert "USB: pci-quirks: Add Raspberry Pi 4 quirk"

2020-06-09 Thread Florian Fainelli
rk. > > Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 5/9] usb: xhci-pci: Add support for reset controllers

2020-06-09 Thread Florian Fainelli
On 6/9/2020 10:49 AM, Nicolas Saenz Julienne wrote: > Some atypical users of xhci-pci might need to manually reset their xHCI > controller before starting the HCD setup. Check if a reset controller > device is available to the PCI bus and trigger a reset. > > Signed-off-by: Nicolas Saenz

Re: [PATCH v2 1/9] dt-bindings: reset: Add a binding for the RPi Firmware reset controller

2020-06-09 Thread Florian Fainelli
lls": > +const: 1 > +description: > Is this a stray '>' character? If so, with that fixed: Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 2/9] reset: Add Raspberry Pi 4 firmware USB reset controller

2020-06-08 Thread Florian Fainelli
On 6/8/2020 12:26 PM, Nicolas Saenz Julienne wrote: > The Raspberry Pi 4 gets its USB functionality from VL805, a PCIe chip > that implements the xHCI. After a PCI fundamental reset, VL805's > firmware may either be loaded directly from an EEPROM or, if not > present, by the SoC's co-processor,

Re: [PATCH 1/9] dt-bindings: reset: Add a binding for the RPi Firmware USB reset

2020-06-08 Thread Florian Fainelli
On 6/8/2020 12:26 PM, Nicolas Saenz Julienne wrote: > The firmware running on the RPi VideoCore can be used to reset and > initialize the board's xHCI controller. The reset controller is passed > to the PCI device through the DT, hence this binding. > > Signed-off-by: Nicolas Saenz Julienne >

Re: [PATCH 7/9] usb: host: pci-quirks: Bypass xHCI quirks for Raspberry Pi 4

2020-06-08 Thread Florian Fainelli
pci_dev > *pdev) >*/ > if (pdev->vendor == 0x184e) /* vendor Netlogic */ > return; > + > + /* > + * Bypass the Raspberry Pi 4 controller xHCI controller, things are > + * taken care by the board's co-processor. taken care of by. W

Re: [PATCH 5/9] usb: xhci-pci: Add support for reset controllers

2020-06-08 Thread Florian Fainelli
On 6/8/2020 12:26 PM, Nicolas Saenz Julienne wrote: > Some atypical users of xhci-pci might need to manually reset their xHCI > controller before starting the HCD setup. Check if a reset controller > device is available to the PCI bus and trigger a reset. > > Signed-off-by: Nicolas Saenz

Re: [RFC PATCH net-next 02/10] mlxsw: Move ethtool_ops to spectrum_ethtool.c

2020-06-07 Thread Florian Fainelli
On 6/7/2020 7:59 AM, Amit Cohen wrote: > Add spectrum_ethtool.c file for ethtool code. > Move ethtool_ops and the relevant code from spectrum.c to > spectrum_ethtool.c. > > Signed-off-by: Amit Cohen > Reviewed-by: Petr Machata > Reviewed-by: Jiri Pirko Reviewed

Re: [RFC PATCH net-next 03/10] mlxsw: spectrum_ethtool: Move mlxsw_sp_port_type_speed_ops structs

2020-06-07 Thread Florian Fainelli
On 6/7/2020 7:59 AM, Amit Cohen wrote: > Move mlxsw_sp1_port_type_speed_ops and mlxsw_sp2_port_type_speed_ops > with the relevant code from spectrum.c to spectrum_ethtool.c. > > Signed-off-by: Amit Cohen > Reviewed-by: Petr Machata > Reviewed-by: Jiri Pirko Reviewed-by

Re: [RFC PATCH net-next 01/10] mlxsw: spectrum_dcb: Rename mlxsw_sp_port_headroom_set()

2020-06-07 Thread Florian Fainelli
et() > in order to allow using the second function in several files, and not > only as static function in spectrum.c. > > Signed-off-by: Amit Cohen > Reviewed-by: Petr Machata > Reviewed-by: Jiri Pirko Reviewed-by: Florian Fainelli -- Florian

Re: [RFC PATCH net-next 05/10] Documentation: networking: ethtool-netlink: Add link extended state

2020-06-07 Thread Florian Fainelli
On 6/7/2020 7:59 AM, Amit Cohen wrote: > Add link extended state attributes. > > Signed-off-by: Amit Cohen > Reviewed-by: Petr Machata > Reviewed-by: Jiri Pirko If you need to resubmit, I would swap the order of patches #4 and #5 such that the documentation comes first. [snip] > >

Re: [RFC PATCH net-next 07/10] mlxsw: spectrum_ethtool: Add link extended state

2020-06-07 Thread Florian Fainelli
On 6/7/2020 7:59 AM, Amit Cohen wrote: > Implement .get_down_ext_state() as part of ethtool_ops. > Query link down reason from PDDR register and convert it to ethtool > ext_state. > > In case that more information than common ext_state is provided, > fill ext_substate also with the appropriate

Re: [RFC PATCH net-next 10/10] selftests: forwarding: Add tests for ethtool extended state

2020-06-07 Thread Florian Fainelli
hout > substate (No cable). > > Signed-off-by: Amit Cohen > Reviewed-by: Petr Machata The delays you have chosen make sense, and if we need to change them later on, we could always do that. Reviewed-by: Florian Fainelli -- Florian

Re: [RFC PATCH net-next 09/10] selftests: forwarding: forwarding.config.sample: Add port with no cable connected

2020-06-07 Thread Florian Fainelli
l_extended_state test. > > Signed-off-by: Amit Cohen > Reviewed-by: Petr Machata Reviewed-by: Florian Fainelli -- Florian

Re: [RFC PATCH net-next 08/10] selftests: forwarding: ethtool: Move different_speeds_get() to ethtool_lib

2020-06-07 Thread Florian Fainelli
t. > > Signed-off-by: Amit Cohen > Reviewed-by: Petr Machata Reviewed-by: Florian Fainelli -- Florian

Re: [RFC PATCH net-next 04/10] ethtool: Add link extended state

2020-06-07 Thread Florian Fainelli
On 6/7/2020 7:59 AM, Amit Cohen wrote: > Currently, drivers can only tell whether the link is up/down using > LINKSTATE_GET, but no additional information is given. > > Add attributes to LINKSTATE_GET command in order to allow drivers > to expose the user more information in addition to link

Re: [PATCH v2] spi: bcm2835: Enable shared interrupt support

2020-06-05 Thread Florian Fainelli
On 6/5/2020 7:41 AM, Robin Murphy wrote: > On 2020-06-05 14:46, Robin Murphy wrote: >> On 2020-06-05 14:20, Mark Brown wrote: >>> On Fri, Jun 05, 2020 at 12:34:36PM +0100, Robin Murphy wrote: >>>> On 2020-06-04 22:28, Florian Fainelli wrote: >>> >

Re: [PATCH v4 05/12] PCI: brcmstb: Add suspend and resume pm_ops

2020-06-05 Thread Florian Fainelli
On 6/5/2020 2:26 PM, Jim Quinlan wrote: > From: Jim Quinlan > > Broadcom Set-top (BrcmSTB) boards typically support S2, S3, and S5 suspend > and resume. Now the PCIe driver may do so as well. > > Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli -- Florian

Re: [PATCH net] net: dp83869: Reset return variable if PHY strap is read

2020-06-05 Thread Florian Fainelli
) > Signed-off-by: Dan Murphy Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net] net: phy: mscc: fix Serdes configuration in vsc8584_config_init

2020-06-05 Thread Florian Fainelli
PHYs inside the package, which leads to the Serdes still > being enabled on those ports. This patch fixes it. > > Fixes: deb04e9c0ff2 ("net: phy: mscc: use phy_package_shared") > Signed-off-by: Antoine Tenart Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net 3/4] net: marvell: Fix OF_MDIO config check

2020-06-05 Thread Florian Fainelli
lize > Marvell PHYs.") > Signed-off-by: Dan Murphy Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net 4/4] net: mscc: Fix OF_MDIO config check

2020-06-05 Thread Florian Fainelli
> PHYs.") > Signed-off-by: Dan Murphy Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net 1/4] net: dp83869: Fix OF_MDIO config check

2020-06-05 Thread Florian Fainelli
t; Signed-off-by: Dan Murphy Reviewed-by: Florian Fainelli -- Florian

[PATCH stable 4.9 03/21] media: dvb/frontend.h: move out a private internal structure

2020-06-05 Thread Florian Fainelli
. So, remove it from the header. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Florian Fainelli --- drivers/media/dvb-core/dvb_frontend.c | 11 +++ include/uapi/linux/dvb/frontend.h | 11 --- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/media

Re: [PATCH net 2/4] net: dp83867: Fix OF_MDIO config check

2020-06-05 Thread Florian Fainelli
t; Signed-off-by: Dan Murphy Reviewed-by: Florian Fainelli -- Florian

[PATCH stable 4.9 06/21] media: stv0288: get rid of set_property boilerplate

2020-06-05 Thread Florian Fainelli
From: Mauro Carvalho Chehab commit 473e4b4c1cf3046fc6b3437be9a9f3c89c2e61ef upstream This driver doesn't implement support for set_property(). Yet, it implements a boilerplate for it. Get rid of it. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Florian Fainelli --- drivers/media/dvb

[PATCH stable 4.9 10/21] media: dvb_frontend: cleanup dvb_frontend_ioctl_properties()

2020-06-05 Thread Florian Fainelli
. Reviewed-by: Shuah Khan Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Florian Fainelli --- drivers/media/dvb-core/dvb_frontend.c | 83 --- 1 file changed, 51 insertions(+), 32 deletions(-) diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core

[PATCH stable 4.9 07/21] media: stv6110: get rid of a srate dead code

2020-06-05 Thread Florian Fainelli
t make any sense. Thankfully, it seems that someone else discovered the issue in the past, as "srate" is currently not used anywhere! So, get rid of that really weird dead code logic. Reported-by: Honza Petrous Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Florian Fainelli --

[PATCH stable 4.9 11/21] media: dvb_frontend: cleanup ioctl handling logic

2020-06-05 Thread Florian Fainelli
-by: Shuah Khan Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Florian Fainelli --- drivers/media/dvb-core/dvb_frontend.c | 328 +- 1 file changed, 158 insertions(+), 170 deletions(-) diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core

[PATCH stable 4.9 19/21] media: dvb_frontend: Add commands implementation for compat ioct

2020-06-05 Thread Florian Fainelli
applications. Signed-off-by: Jaedon Shin Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Florian Fainelli --- drivers/media/dvb-core/dvb_frontend.c | 131 ++ 1 file changed, 131 insertions(+) diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core

[PATCH stable 4.9 15/21] media: dvb_frontend: dtv_property_process_set() cleanups

2020-06-05 Thread Florian Fainelli
to the entire struct dtv_property *tvp. Instead of having a generic dtv_property_dump(), added its own properties debug logic in the dtv_property_process_set(). Signed-off-by: Satendra Singh Thakur Reviewed-by: Shuah Khan Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Florian Fainelli

[PATCH stable 4.9 13/21] media: dvb_frontend: better document the -EPERM condition

2020-06-05 Thread Florian Fainelli
From: Mauro Carvalho Chehab commit da5516b5e81d45a96291823620f6c820178dc055 upstream Two readonly ioctls can't be allowed if the frontend device is opened in read only mode. Explain why. Reviewed by: Shuah Khan Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Florian Fainelli

[PATCH stable 4.9 21/21] media: dvb_frontend: fix return error code

2020-06-05 Thread Florian Fainelli
-to: Arnd Bergmann To make me revisit this code. Fixes: a9cb97c3e628 ("media: dvb_frontend: be sure to init dvb_frontend_handle_ioctl() return code") Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Florian Fainelli --- drivers/media/dvb-core/dvb_frontend.c | 2 +- 1 file changed, 1

[PATCH stable 4.9 08/21] media: friio-fe: get rid of set_property()

2020-06-05 Thread Florian Fainelli
, instead, at set_frontend() callback. So, get rid of it. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Florian Fainelli --- drivers/media/usb/dvb-usb/friio-fe.c | 24 1 file changed, 24 deletions(-) diff --git a/drivers/media/usb/dvb-usb/friio-fe.c b/drivers/media

[PATCH stable 4.9 18/21] media: dvb_frontend: Add compat_ioctl callback

2020-06-05 Thread Florian Fainelli
From: Jaedon Shin commit c2dfd2276cec63a0c6f6ce18ed83800d96fde542 upstream Adds compat_ioctl for 32-bit user space applications on a 64-bit system. [m.che...@osg.samsung.com: add missing include compat.h] Signed-off-by: Jaedon Shin Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Florian

[PATCH stable 4.9 14/21] media: dvb_frontend: fix return values for FE_SET_PROPERTY

2020-06-05 Thread Florian Fainelli
dating the documentation accordingly and removing the logic that would update the discarded tvp->result. Reviewed-by: Shuah Khan Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Florian Fainelli --- Documentation/media/uapi/dvb/fe-get-property.rst | 7 +-- drivers/media/dvb-core/dvb_f

[PATCH stable 4.9 09/21] media: dvb_frontend: get rid of set_property() callback

2020-06-05 Thread Florian Fainelli
From: Mauro Carvalho Chehab commit 6680e73b5226114992acfc11f9cf5730f706fb01 upstream Now that all clients of set_property() were removed, get rid of this callback. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Florian Fainelli --- drivers/media/dvb-core/dvb_frontend.c | 7

[PATCH stable 4.9 16/21] media: dvb_frontend: be sure to init dvb_frontend_handle_ioctl() return code

2020-06-05 Thread Florian Fainelli
a...@vger.kernel.org Signed-off-by: Mauro Carvalho Chehab Tested-by: Daniel Scheller Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Florian Fainelli --- drivers/media/dvb-core/dvb_frontend.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-core/dvb_f

[PATCH stable 4.9 12/21] media: dvb_frontend: get rid of property cache's state

2020-06-05 Thread Florian Fainelli
to indicate when the properties got flushed. So, just get rid of it for good. Reviewed-by: Shuah Khan Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Florian Fainelli --- drivers/media/dvb-core/dvb_frontend.c | 20 ++-- drivers/media/dvb-core/dvb_frontend.h | 5 - 2

[PATCH stable 4.9 05/21] media: dvb_frontend: get rid of get_property() callback

2020-06-05 Thread Florian Fainelli
of it. Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Michael Ira Krufky Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Florian Fainelli --- drivers/media/dvb-core/dvb_frontend.c | 9 + drivers/media/dvb-core/dvb_frontend.h | 3 --- drivers/media/dvb-frontends/lg2160.c | 14

[PATCH stable 4.9 20/21] media: dvb_frontend: fix wrong cast in compat_ioctl

2020-06-05 Thread Florian Fainelli
a pointer of 2nd or after item of 'struct compat_dtv_property' array. Signed-off-by: Katsuhiro Suzuki Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Florian Fainelli --- drivers/media/dvb-core/dvb_frontend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb

[PATCH stable 4.9 04/21] media: dvb/frontend.h: document the uAPI file

2020-06-05 Thread Florian Fainelli
comments. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Florian Fainelli --- include/uapi/linux/dvb/frontend.h | 580 +- 1 file changed, 498 insertions(+), 82 deletions(-) diff --git a/include/uapi/linux/dvb/frontend.h b/include/uapi/linux/dvb/frontend.h index

[PATCH stable 4.9 17/21] media: dvb_frontend: Add unlocked_ioctl in dvb_frontend.c

2020-06-05 Thread Florian Fainelli
From: Jaedon Shin commit a2282fd1fe2ebcda480426dbfaaa7c4e87e27399 upstream Adds unlocked ioctl function directly in dvb_frontend.c instead of using dvb_generic_ioctl(). Signed-off-by: Jaedon Shin Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Florian Fainelli --- drivers/media/dvb

[PATCH stable 4.9 00/21] Unbreak 32-bit DVB applications on 64-bit kernels

2020-06-05 Thread Florian Fainelli
Hi all, This long patch series was motivated by backporting Jaedon's changes which add a proper ioctl compatibility layer for 32-bit applications running on 64-bit kernels. We have a number of Android TV-based products currently running on the 4.9 kernel and this was broken for them. Thanks to

<    7   8   9   10   11   12   13   14   15   16   >