Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 03:53:38PM +0200, Fabio M. De Francesco wrote: > On Saturday, April 10, 2021 3:24:43 PM CEST Julia Lawall wrote: > > On Sat, 10 Apr 2021, Fabio M. De Francesco wrote: > > > On Saturday, April 10, 2021 2:12:28 PM CEST Julia Lawall wrote: > > > > On Sat, 10 Apr 2021, Fabio M.

Re: [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 07:07:08PM +0530, Mitali Borkar wrote: > On Sat, Apr 10, 2021 at 03:14:24PM +0200, Greg KH wrote: > > On Sat, Apr 10, 2021 at 06:30:38PM +0530, Mitali Borkar wrote: > > > Fixed Comparison to NULL can be written as '!...' by replacing it with >

Re: [Outreachy kernel] [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 03:23:35PM +0200, Julia Lawall wrote: > > > On Sat, 10 Apr 2021, Mitali Borkar wrote: > > > Fixed Comparison to NULL can be written as '!...' by replacing it with > > simpler form i.e. boolean expression. This makes code more readable > > alternative. > > Reported by chec

Re: [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 06:30:38PM +0530, Mitali Borkar wrote: > Fixed Comparison to NULL can be written as '!...' by replacing it with > simpler form i.e. boolean expression. This makes code more readable > alternative. > Reported by checkpatch. Checkpatch did not report this specific problem, Ju

[GIT PULL] Driver core fix for 5.12-rc7

2021-04-10 Thread Greg KH
The following changes since commit e49d033bddf5b565044e2abe4241353959bc9120: Linux 5.12-rc6 (2021-04-04 14:15:36 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tags/driver-core-5.12-rc7 for you to fetch changes up to eed6

[GIT PULL] USB/Thunderbolt driver fixes for 5.12-rc7

2021-04-10 Thread Greg KH
The following changes since commit e49d033bddf5b565044e2abe4241353959bc9120: Linux 5.12-rc6 (2021-04-04 14:15:36 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git tags/usb-5.12-rc7 for you to fetch changes up to bc2f3e4c662841dc19f7e

Re: [Outreachy kernel] [PATCH] staging: rtl8192e: replace comparison to NULL by bool

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 02:08:30PM +0200, Julia Lawall wrote: > > > On Sat, 10 Apr 2021, Mitali Borkar wrote: > > > Fixed Comparison to NULL can be written as '!...' by replacing it with > > simpler form i.e boolean expression. This makes code more readable > > alternative. > > Reported by chec

Re: [PATCH 3/3] staging: rtl8712: Use existing arc4 implementation

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 01:56:57PM +0200, Christophe JAILLET wrote: > Use functions provided by instead of hand writing them. > > The implementations are slightly different, but are equivalent. It has > been checked with a test program which compares the output of the 2 sets of > functions. > >

Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 01:23:21PM +0200, Fabio M. De Francesco wrote: > On Saturday, April 10, 2021 1:03:34 PM CEST Greg KH wrote: > > On Sat, Apr 10, 2021 at 12:58:06PM +0200, Fabio M. De Francesco wrote: > > > On Saturday, April 10, 2021 12:31:27 PM CEST Greg KH wrote: >

Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 12:58:06PM +0200, Fabio M. De Francesco wrote: > On Saturday, April 10, 2021 12:31:27 PM CEST Greg KH wrote: > > On Sat, Apr 10, 2021 at 11:56:48AM +0200, Fabio M. De Francesco wrote: > > > On Saturday, April 10, 2021 11:31:16 AM CEST Greg KH wrote: >

Re: [Outreachy kernel] [PATCH v7 1/3] staging: rtl8723bs: Remove camelcase in several files

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 11:45:18AM +0200, Fabio M. De Francesco wrote: > On Saturday, April 10, 2021 11:32:00 AM CEST Greg KH wrote: > > On Sat, Apr 10, 2021 at 11:22:29AM +0200, Fabio M. De Francesco wrote: > > > Remove camelcase in bFwCurrentInPSMode, a variable used by cod

Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 11:56:48AM +0200, Fabio M. De Francesco wrote: > On Saturday, April 10, 2021 11:31:16 AM CEST Greg KH wrote: > > On Sat, Apr 10, 2021 at 11:22:32AM +0200, Fabio M. De Francesco wrote: > > > Change the type of fw_current_in_ps_mode from u8 to bool, becaus

Re: [Outreachy kernel] [PATCH v7 1/3] staging: rtl8723bs: Remove camelcase in several files

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 11:22:29AM +0200, Fabio M. De Francesco wrote: > Remove camelcase in bFwCurrentInPSMode, a variable used by code > of several subdirectories/files of the driver. Issue detected by > checkpatch.pl. Delete the unnecessary "b" (that stands for "byte") from > the beginning of th

Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 11:22:32AM +0200, Fabio M. De Francesco wrote: > Change the type of fw_current_in_ps_mode from u8 to bool, because > it is used everywhere as a bool and, accordingly, it should be > declared as a bool. Shorten the controlling > expression of an 'if' statement. > > Signed-of

Re: [PATCH v27 07/13] mm/damon: Implement a debugfs-based user space interface

2021-04-10 Thread Greg KH
On Thu, Apr 08, 2021 at 01:48:48PM +, SeongJae Park wrote: > +static int dbgfs_fill_ctx_dir(struct dentry *dir, struct damon_ctx *ctx) > +{ > + const char * const file_names[] = {"attrs", "target_ids"}; > + const struct file_operations *fops[] = {&attrs_fops, &target_ids_fops}; > +

Re: [PATCH] tty: n_gsm: check error while registering tty devices

2021-04-10 Thread Greg KH
On Wed, Apr 07, 2021 at 04:21:30PM +0800, Hillf Danton wrote: > On Wed, 7 Apr 2021 07:37:53 Jiri Slaby wrote: > > > >Yes, the fix makes sense. > > Thanks for taking a look. > > >But could you elaborate in the commit log when this happens? > >I only wonder how real this is. I assume you inject fau

Re: [PATCH v6 3/6] w1: ds2438: fixed a coding style issue

2021-04-10 Thread Greg KH
On Fri, Apr 09, 2021 at 12:15:30AM -0300, Luiz Sampaio wrote: > Changed the permissions to preferred octal style. > > Signed-off-by: Luiz Sampaio > --- > drivers/w1/slaves/w1_ds2438.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/w1/slaves/w1_ds2438.c b/driver

Re: [PATCH 0/6] staging: rtl8192e: cleanup patchset for style issues

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 07:04:23AM +0530, Mitali Borkar wrote: > This patches fix the cleanup style issues. > > Mitali Borkar (6): > staging: rtl8192e: add spaces around binary operators > staging: rtl8192e: remove unnecessary blank line before brace > staging: rtl8192e: remove unncessary bl

Re: [Outreachy kernel] [Patch 0/3]

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 09:57:00AM +0200, Fabio M. De Francesco wrote: > On Saturday, April 10, 2021 9:29:29 AM CEST Greg KH wrote: > > On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote: > > > This patch series removes camelcases, changes the type and use o

Re: [Outreachy kernel] [Resend Patch 0/3] staging: rtl8723bs: Patchset for rtl8723bs

2021-04-10 Thread Greg KH
On Fri, Apr 09, 2021 at 06:39:31PM +0200, Fabio M. De Francesco wrote: > This patch series removes camelcase, changes the type and use of a > variable, and correct misspelled words. > > Patch 1/3: staging: rtl8723bs: Remove camelcase in several files I've again, dropped all patches from you fr

Re: [Outreachy kernel] [Patch 0/3]

2021-04-10 Thread Greg KH
On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote: > This patch series removes camelcases, changes the type and use of a > variable, and correct misspelled words. > > Patch 1/3: staging: rtl8723bs: Remove camelcase in several files > > drivers/staging/rtl8723bs/core/rtw_cmd.c

Re: [PATCH v2] usb: dwc2: Enable RPi in ACPI mode

2021-04-09 Thread Greg KH
On Fri, Apr 09, 2021 at 03:38:09PM -0500, Jeremy Linton wrote: > The dwc2 driver has everything we need to run > in ACPI mode except for the ACPI module device table > boilerplate. With that added and identified as "BCM2848", > an id in use by other OSs for this device, the dw2 > controller on the

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Change the type and use of a variable

2021-04-09 Thread Greg KH
On Thu, Apr 08, 2021 at 01:19:42PM +0200, Fabio M. De Francesco wrote: > Change the type of fw_current_in_ps_mode from u8 to bool, because > it is used everywhere as a bool and, accordingly, it should be > declared as a bool. Shorten the controlling > expression of an 'if' statement. > > Signed-of

Re: [PATCH] USB: serial: do not use tty class device for debugging

2021-04-09 Thread Greg KH
On Thu, Apr 08, 2021 at 05:08:59PM +0200, Johan Hovold wrote: > Use the port struct device rather than tty class device for debugging. > > Note that while USB serial doesn't support serdev yet (due to serdev not > handling hotplugging), serdev ttys do not have a corresponding class > device and wo

Re: [PATCH v2 2/2] docs: reporting-issues: make people CC the regressions list

2021-04-09 Thread Greg KH
On Fri, Apr 09, 2021 at 01:47:24PM +0200, Thorsten Leemhuis wrote: > Make people CC the recently created mailing list dedicated to Linux > kernel regressions when reporting one. Some paragraphs had to be > reshuffled and slightly rewritten during the process, as the text > otherwise would have gott

Re: [PATCH v2 1/2] MAINTAINERS: add regressions mailing list

2021-04-09 Thread Greg KH
On Fri, Apr 09, 2021 at 01:47:23PM +0200, Thorsten Leemhuis wrote: > Add the newly created regression mailing list finally created after it > already had been agreed on during the maintainers summit 2017 (see > https://lwn.net/Articles/738216/ ). The topic was recently discussed > again, where an i

Re: [PATCH] staging: rtl8712: fix wrong function output

2021-04-09 Thread Greg KH
On Fri, Apr 09, 2021 at 01:41:59PM +0200, Sergei Krainov wrote: > On Fri, Apr 09, 2021 at 08:33:23AM +0200, Greg KH wrote: > > On Fri, Apr 09, 2021 at 01:45:27AM +0200, Sergei Krainov wrote: > > > Function r8712_find_network() were returning wlan_network even if it > >

Re: [PATCH v2 0/2] USB:ehci:fix the no SRBN register problem

2021-04-08 Thread Greg KH
On Fri, Apr 09, 2021 at 10:42:35AM +0800, liulongfang wrote: > On 2021/4/8 22:53, Alan Stern wrote: > > On Thu, Apr 08, 2021 at 09:49:18PM +0800, Longfang Liu wrote: > >> (1) Add a whitelist for EHCI devices without SBRN registers. > >> (2) Add Kunpeng920's EHCI device to the whitelist. > >> > >> C

Re: [PATCH v3 1/2] USB:ehci:Add a whitelist for EHCI controllers

2021-04-08 Thread Greg KH
On Fri, Apr 09, 2021 at 11:00:14AM +0800, Longfang Liu wrote: > Some types of EHCI controllers do not have SBRN registers. > By comparing the white list, the operation of reading the SBRN > registers is skipped. > > Subsequent EHCI controller types without SBRN registers can be > directly added to

Re: [PATCH net-next v3 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 06:59:19PM +, Min Li wrote: > > > > But what does that have to do with the misc device? > > > > Hi Greg, MFD driver is the start of everything. Once MFD driver is loading, > it will spawn 2 devices, > one is for phc driver, which is under /driver/ptp and the other

Re: [PATCH] staging: rtl8712: fix wrong function output

2021-04-08 Thread Greg KH
On Fri, Apr 09, 2021 at 01:45:27AM +0200, Sergei Krainov wrote: > Function r8712_find_network() were returning wlan_network even if it > didn't match required address. This happened due to not checking if > list end was reached and returning last processed wlan_network. > > Signed-off-by: Sergei K

Re: [PATCH v4] binder: tell userspace to dump current backtrace when detected oneway spamming

2021-04-08 Thread Greg KH
On Fri, Apr 09, 2021 at 02:21:58PM +0800, Hang Lu wrote: > On 4/9/2021 2:08 PM, Greg KH wrote: > > On Fri, Apr 09, 2021 at 11:40:57AM +0800, Hang Lu wrote: > >> When async binder buffer got exhausted, some normal oneway transactions > >> will also be discarded and may

Re: [PATCH v4] binder: tell userspace to dump current backtrace when detected oneway spamming

2021-04-08 Thread Greg KH
On Fri, Apr 09, 2021 at 11:40:57AM +0800, Hang Lu wrote: > When async binder buffer got exhausted, some normal oneway transactions > will also be discarded and may cause system or application failures. By > that time, the binder debug information we dump may not be relevant to > the root cause. And

Re: [PATCH] export: Make CRCs robust to symbol trimming

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 06:01:05PM +, Quentin Perret wrote: > The CRC calculation done by genksyms is triggered when the parser hits > EXPORT_SYMBOL*() macros. At this point, genksyms recursively expands the > types, and uses that as the input for the CRC calculation. In the case > of forward-d

Re: [PATCH net-next v3 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 06:01:42PM +, Min Li wrote: > > > > That does not make sense, this is only one kernel module, with one .h file > > in > > this patch, I do not see those other files you are talking about... > > > > And if you have named registers that are identical, and yet you only w

Re: [PATCH net-next v3 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 05:26:40PM +, Min Li wrote: > > > > Again, please make this only one file. > > > Hi Greg, the 2 boards have some same named registers in idt82p33_reg.h and > idt8a340_reg.h > so if I put them all in the same file, there will be name conflicts. That does not make sen

Re: [PATCH 1/2] USB:ehci:Add a whitelist for EHCI controllers

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 09:04:17PM +0800, liulongfang wrote: > On 2021/4/8 17:22, Greg KH Wrote: > > On Thu, Apr 08, 2021 at 05:11:12PM +0800, Longfang Liu wrote: > >> Some types of EHCI controllers do not have SBRN registers. > >> By comparing the white list, the op

Re: [PATCH v2 1/2] USB:ehci:Add a whitelist for EHCI controllers

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 09:49:19PM +0800, Longfang Liu wrote: > Some types of EHCI controllers do not have SBRN registers. > By comparing the white list, the operation of reading the SBRN > registers is skipped. > > Subsequent EHCI controller types without SBRN registers can be > directly added to

Re: [Outreachy kernel] [PATCH] staging: rtl8712: added spaces around '+'

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 04:55:45PM +0530, Mitali Borkar wrote: > On Thu, Apr 08, 2021 at 10:30:09AM +0200, Julia Lawall wrote: > > The subject line should be in the imperative, so "add" instead of "added". > > > Ok Ma'am > > On Thu, 8 Apr 2021, Mitali Borkar wrote: > > > > > Clean up Check:spaces

Re: [PATCH] staging: ks7010: remove useless variable

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 05:51:19PM +0800, Jiapeng Chong wrote: > Fix the following gcc warning: > > drivers/staging/ks7010/ks_hostif.c:929:19: warning: variable ‘noise’ set > but not used [-Wunused-but-set-variable]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/s

Re: [PATCH] staging: rtl8723bs: remove unused variables

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 11:27:02AM +0200, Fabio Aiuto wrote: > remove declared and assigned unused variables You need to be a lot more specific here. > Reported-by: kernel test robot For all of these? > Signed-off-by: Fabio Aiuto > --- > drivers/staging/rtl8723bs/core/rtw_cmd.c | 3 ---

Re: [PATCH 1/2] USB:ehci:Add a whitelist for EHCI controllers

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 05:11:12PM +0800, Longfang Liu wrote: > Some types of EHCI controllers do not have SBRN registers. > By comparing the white list, the operation of reading the SBRN > registers is skipped. > > Subsequent EHCI controller types without SBRN registers can be > directly added to

Re: [PATCH 1/2] zram: fix crashes due to use of cpu hotplug multistate

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 10:35:17AM +0200, Jiri Kosina wrote: > On Thu, 8 Apr 2021, Greg KH wrote: > > > > If there is a driver/subsystem code that can't handle the reverse > > > operation to modprobe, it clearly can't handle error handling during > &g

Re: [PATCH] staging: rtl8712: remove unused variable from rtl871x_mlme.c

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 10:33:12AM +0200, Sergei Krainov wrote: > Remove unused variable from rtl871x_mlme.c. > > No side effects can be seen locally or in r8712_find_network() > > Signed-off-by: Sergei Krainov > --- > drivers/staging/rtl8712/rtl871x_mlme.c | 9 + > 1 file changed, 1 in

Re: [PATCH] staging: rtl8712: removed unnecessary blank line

2021-04-08 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove camelcase in several files

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 10:07:14AM +0200, Fabio M. De Francesco wrote: > Remove camelcase in a symbol that is used by several files. What symbol? > --- a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h > +++ b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h > @@ -203,7 +203,7 @@ struct pwrctrl_pr

Re: [PATCH 1/2] zram: fix crashes due to use of cpu hotplug multistate

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 10:01:23AM +0200, Jiri Kosina wrote: > On Thu, 8 Apr 2021, Greg KH wrote: > > > Removing a module from a system has always been "let's try it and see!" > > type of operation for a very long time. > > Which part of it? > > I

Re: [PATCH] staging: rtl8712: removed unnecessary blank line

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 01:17:49PM +0530, Mitali Borkar wrote: > Cleanup patch for CHECK: blank lines aren't necessary after an open > brace '{' > Reported by checkpatch But you did more than just the above in this patch, which is not ok :(

Re: [GIT PULL] extcon next for v5.13

2021-04-07 Thread Greg KH
On Thu, Apr 08, 2021 at 03:44:35PM +0900, Chanwoo Choi wrote: > Dear Greg, > > This is extcon-next pull request for v5.13. I add detailed description of > this pull request on below. Please pull extcon with following updates. > > Best Regards, > Chanwoo Choi > > > The following changes since co

Re: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 08:12:10PM +, Min Li wrote: > > > > Why not use the miscdev name field? > > > miscdev name field is just a char pointer and I need an static array to > manipulate the name with index Why? > > So it's a parent? Why not make this a real platform_device pointer and no

Re: [Outreachy kernel] [PATCH v3] staging: rtl8723bs: hal: Remove camelcase in sdio_ops.c

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 08:19:14PM +0200, Fabio M. De Francesco wrote: > Changes from v2: Remove unnecessary comment. Shortened a function name. > Changes from v1: No changes to the code but only to the subject for the > purpose to differentiate this patch because other removes of camelcase > have

Re: [PATCH] staging: rtl8712: remove unused variable from rtl871x_mlme.c

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 09:32:14PM +0200, Sergei Krainov wrote: > Remove unused variable from rtl871x_mlme.c > > Signed-off-by: Sergei Krainov > --- > drivers/staging/rtl8712/rtl871x_mlme.c | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/staging/rtl8712/

Re: [PATCH net-next v3 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 09:50:50PM -0400, min.li...@renesas.com wrote: > From: Min Li > > This driver is developed for the IDT ClockMatrix(TM) and 82P33xxx families > of timing and synchronization devices.It will be used by Renesas PTP Clock > Manager for Linux (pcm4l) software to provide support

Re: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 08:00:38PM +, Min Li wrote: > > > > Do you really meen "+" here? (sorry, have to ask.) > > > > I don't know. All of our Linux kernel code has GPL-2.0+ and I just blindly > inherit it. You should ask your managers :) > > > > +#define pr_fmt(fmt) KBUILD_MODNAME ":

Re: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 07:43:44PM +, Min Li wrote: > > > > Why do you need 4 files here? Can't you do this all in one? There's no > > need > > for such a small driver to be split up, that just causes added complexity > > and > > makes things harder to review and understand. > > > > We w

Re: [PATCH 1/2] zram: fix crashes due to use of cpu hotplug multistate

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 03:17:46PM -0500, Josh Poimboeuf wrote: > On Fri, Apr 02, 2021 at 09:54:12AM +0200, Greg KH wrote: > > On Thu, Apr 01, 2021 at 11:59:25PM +, Luis Chamberlain wrote: > > > As for the syfs deadlock possible with drivers, this fixes it in a

Re: [PATCH 1/2] zram: fix crashes due to use of cpu hotplug multistate

2021-04-07 Thread Greg KH
On Thu, Apr 08, 2021 at 03:37:53AM +0200, Thomas Gleixner wrote: > Greg, > > On Fri, Apr 02 2021 at 09:54, Greg KH wrote: > > On Thu, Apr 01, 2021 at 11:59:25PM +, Luis Chamberlain wrote: > >> As for the syfs deadlock possible with drivers, this fixes i

Re: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 01:33:35PM -0400, min.li...@renesas.com wrote: > +/** > + * struct rsmu_cdev - Driver data for RSMU character device > + * @name: rsmu device name Why not use the miscdev name field? > + * @dev: pointer to platform device So it's a parent? Why not make this a real platfo

Re: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 01:33:35PM -0400, min.li...@renesas.com wrote: > +static int > +rsmu_open(struct inode *iptr, struct file *fptr) > +{ > + return 0; > +} > + > +static int > +rsmu_release(struct inode *iptr, struct file *fptr) > +{ > + return 0; > +} If you do nothing in an open/rel

Re: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 01:33:35PM -0400, min.li...@renesas.com wrote: > --- /dev/null > +++ b/drivers/misc/rsmu_cdev.c > @@ -0,0 +1,266 @@ > +// SPDX-License-Identifier: GPL-2.0+ Do you really meen "+" here? (sorry, have to ask.) > +/* > + * This driver is developed for the IDT ClockMatrix(TM)

Re: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 01:33:35PM -0400, min.li...@renesas.com wrote: > From: Min Li > > This driver is developed for the IDT ClockMatrix(TM) and 82P33xxx families > of timing and synchronization devices.It will be used by Renesas PTP Clock > Manager for Linux (pcm4l) software to provide support

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Remove camelcase

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 06:30:00PM +0200, Fabio M. De Francesco wrote: > Remove camelcase. Issue detected by checkpatch.pl. For now, change only > names of static functions in order to not break the driver's code. > > Signed-off-by: Fabio M. De Francesco > --- > drivers/staging/rtl8723bs/hal/sdi

Re: [PATCH 07/19] drivers: rtl8723bs: rewrite comparison to null

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 05:25:34PM +0200, Fabio Aiuto wrote: > On Wed, Apr 07, 2021 at 05:14:00PM +0200, Greg KH wrote: > > On Wed, Apr 07, 2021 at 03:49:31PM +0200, Fabio Aiuto wrote: > > > fix following post-commit hook checkpatch warnings: > > > > > > CHECK:

Re: [PATCH 0/4] USB: serial: closing-wait cleanups

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 12:45:25PM +0200, Johan Hovold wrote: > Now that all USB serial drivers supports changing the closing_wait > parameter through TIOCSSERIAL (setserial), we can remove the related > driver-specific module parameters and settings. > > These depend on the recently posted TIOCSS

Re: [PATCH 00/24] USB: serial: TIOCSSERIAL fixes and generic support

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 12:39:01PM +0200, Johan Hovold wrote: > TIOCSSERIAL is a horrid, underspecified, legacy interface which for most > serial devices is only useful for setting the close_delay and > closing_wait parameters. > > This series fixes up the various USB serial driver implementations

Re: [PATCH] Staging: android: ashmem: Fixed a const coding styleissue

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 10:08:31AM -0500, Barney Goette wrote: > Sorry. > > I was following the Kernel First Patch tutorial and I didn’t quite > understand how to build a driver that was for Android while on a > desktop. Where you build the kernel does not matter, how do you think Android kernel

Re: [PATCH 00/19] staging: rtl8723bs: remove DBG_871X trace macro

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 03:49:24PM +0200, Fabio Aiuto wrote: > This patchset removes all DBG_871X usages and definitions. > > The whole private tracing system is not tied to a configuration > symbol and the default behaviour is _trace nothing_. > > DBG_871X macros require the code to be modified

Re: [PATCH 07/19] drivers: rtl8723bs: rewrite comparison to null

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 03:49:31PM +0200, Fabio Aiuto wrote: > fix following post-commit hook checkpatch warnings: > > CHECK: Comparison to NULL could be written "!psta" > 97: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:2115: > + if (psta == NULL) > > Signed-off-by: Fabio Aiuto > -

Re: [RFC PATCH v1 2/2] docs: reporting-issues: make everyone CC the regressions list

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 01:21:28PM +0200, Thorsten Leemhuis wrote: > > On 07.04.21 12:00, Greg KH wrote: > > On Wed, Apr 07, 2021 at 11:21:56AM +0200, Thorsten Leemhuis wrote: > >> Make people CC the recently created mailing list dedicated to Linux > >> kernel regres

Re: [RFC PATCH v1 1/2] MAINTAINERS: add regressions mailing list

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 12:51:43PM +0200, Thorsten Leemhuis wrote: > On 07.04.21 11:56, Greg KH wrote: > > On Wed, Apr 07, 2021 at 11:21:55AM +0200, Thorsten Leemhuis wrote: > >> Add the newly created regression mailing list finally created after it > >> already ha

Re: [GIT PULL]: Generic phy updates for v5.13-rc1

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 06:16:41PM +0530, Vinod Koul wrote: > Hello Greg, > > Please pull to receive generic phy updates for this cycle. This is usual > pull includes bunch of new driver/device support and updates to bunch of > drivers. > > The following changes since commit a38fd8748464831584a19

Re: [GIT PULL]: soundwire updates for v5.13-rc1

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 06:01:04PM +0530, Vinod Koul wrote: > Hello Greg, > > Here is the soundwire pull request for this cycle. Bunch of core cleanup > and changes along with driver updates > > The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: > > Linux 5.12-rc2 (20

Re: [PATCH] Staging: android: ashmem: Fixed a const coding style issue

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 09:35:02AM -0500, Barney Goette wrote: > Fixed a coding style issue. > Reported by checkpatch. > > Signed-off-by: Barney Goette > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashme

Re: [PATCH 0/4] Add support for HiSilicon PCIe Tune and Trace device

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 06:03:11PM +0800, Yicong Yang wrote: > On 2021/4/6 21:49, Greg KH wrote: > > On Tue, Apr 06, 2021 at 08:45:50PM +0800, Yicong Yang wrote: > >> HiSilicon PCIe tune and trace device(PTT) is a PCIe Root Complex > >> integrated Endpoint(RCiEP) devic

Re: [RFC PATCH v1 2/2] docs: reporting-issues: make everyone CC the regressions list

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 11:21:56AM +0200, Thorsten Leemhuis wrote: > Make people CC the recently created mailing list dedicated to Linux > kernel regressions when reporting one. Some paragraphs had to be > reshuffled and slightly rewritten during the process, as the text > otherwise would have gott

Re: [RFC PATCH v1 1/2] MAINTAINERS: add regressions mailing list

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 11:21:55AM +0200, Thorsten Leemhuis wrote: > Add the newly created regression mailing list finally created after it > already had been agreed on during the maintainers summit 2017 (see > https://lwn.net/Articles/738216/ ). The topic was recently discussed > again, where an i

Re: [RESEND PATCH] staging: emxx_udc: Ending line with argument

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 10:46:23AM +0100, Beatriz Martins de Carvalho wrote: > > Em 07/04/21 09:34, Greg KH escreveu: > > On Wed, Apr 07, 2021 at 09:16:44AM +0100, Beatriz Martins de Carvalho wrote: > > > Em 07/04/21 06:37, Greg KH escreveu: > > > > On Tue,

Re: [PATCH v2 08/49] staging: sm750fb: Update enum values in dpms to snake case

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 01:27:49AM -0700, Pavle Rohalj wrote: > On Wed, Apr 07, 2021 at 09:24:07AM +0200, Greg KH wrote: > > On Tue, Apr 06, 2021 at 11:36:16PM -0700, Pavle Rohalj wrote: > > > Fix "Avoid CamelCase" checkpatch.pl checks for values in > > >

Re: [RESEND PATCH] staging: emxx_udc: Ending line with argument

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 09:16:44AM +0100, Beatriz Martins de Carvalho wrote: > > Em 07/04/21 06:37, Greg KH escreveu: > > On Tue, Apr 06, 2021 at 09:00:07PM +0100, Beatriz Martins de Carvalho wrote: > > > Em 06/04/21 20:36, Greg KH escreveu: > > > > On Tue,

Re: [PATCH v2 00/49] *** SUBJECT HERE ***

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 09:32:29AM +0200, Greg KH wrote: > On Wed, Apr 07, 2021 at 12:15:22AM -0700, Pavle Rohalj wrote: > > On Wed, Apr 07, 2021 at 09:08:07AM +0200, Greg KH wrote: > > > On Tue, Apr 06, 2021 at 11:35:54PM -0700, Pavle Rohalj wrote: > > > > Change

Re: [PATCH v2 02/49] staging: sm750fb: Rename dviInit to dvi_init and update param names

2021-04-07 Thread Greg KH
On Tue, Apr 06, 2021 at 11:36:01PM -0700, Pavle Rohalj wrote: > Fix "Avoid CamelCase" checkpatch.pl checks for the function dviInit and > its parameter names in ddk750_dvi.h. > > Signed-off-by: Pavle Rohalj > --- > drivers/staging/sm750fb/ddk750_dvi.c | 2 +- > drivers/staging/sm750fb/ddk750_dv

Re: [PATCH v2 01/49] staging: sm750fb: Update dvi_ctrl_device to snake case

2021-04-07 Thread Greg KH
On Tue, Apr 06, 2021 at 11:35:56PM -0700, Pavle Rohalj wrote: > Fix "Avoid CamelCase" checkpatch.pl checks for dvi_ctrl_device structure and > its usages. > > Signed-off-by: Pavle Rohalj > --- > drivers/staging/sm750fb/ddk750_dvi.c| 30 > drivers/staging/sm750fb/ddk750_dvi.h

Re: [PATCH] staging: rtl8723bs: remove unused variable

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 11:18:19AM +0800, Jiapeng Chong wrote: > Fix the following gcc warning: > > drivers/staging/rtl8723bs/core/rtw_ieee80211.c:657:15: warning: variable > ‘sec_idx’ set but not used [-Wunused-but-set-variable]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --

Re: [Outreachy kernel] [PATCH v3] staging: rtl8723bs: hal: Remove camelcase in Hal8723BReg.h

2021-04-07 Thread Greg KH
On Tue, Apr 06, 2021 at 06:00:37PM +0200, Fabio M. De Francesco wrote: > Remove camelcase in some symbols defined in Hal8723BReg.h. These symbols > are not used anywhere else, therefore this patch does not break the driver. > > Signed-off-by: Fabio M. De Francesco > --- > > Patch v3 changes noth

Re: [PATCH] staging: rtl8712: fix avoid CamelCase in xmit_osdep.h

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 01:27:29PM +0530, Mitali Borkar wrote: > Fixed Check:Avoid CamelCase by renaming SetFilter to set_filter > Reported by checkpatch. > > Signed-off-by: Mitali Borkar > --- > drivers/staging/rtl8712/xmit_osdep.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > di

Re: [RESEND PATCH v5 1/2] bio: limit bio max size

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 03:55:07PM +0900, Changheun Lee wrote: > > On Wed, Apr 07, 2021 at 02:06:33PM +0900, Changheun Lee wrote: > > > > On Wed, Apr 07, 2021 at 09:16:12AM +0900, Changheun Lee wrote: > > > > > > On Tue, Apr 06, 2021 at 10:31:28AM +0900, Changheun Lee wrote: > > > > > > > > bio siz

Re: [PATCH v2 00/49] *** SUBJECT HERE ***

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 12:15:22AM -0700, Pavle Rohalj wrote: > On Wed, Apr 07, 2021 at 09:08:07AM +0200, Greg KH wrote: > > On Tue, Apr 06, 2021 at 11:35:54PM -0700, Pavle Rohalj wrote: > > > Changes in v2: > > > - Removed type information from variable names > &

Re: [PATCH v2 08/49] staging: sm750fb: Update enum values in dpms to snake case

2021-04-07 Thread Greg KH
On Tue, Apr 06, 2021 at 11:36:16PM -0700, Pavle Rohalj wrote: > Fix "Avoid CamelCase" checkpatch.pl checks for values in > enum dpms. > > Signed-off-by: Pavle Rohalj > --- > drivers/staging/sm750fb/ddk750_power.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/d

Re: [PATCH v2 00/49] *** SUBJECT HERE ***

2021-04-07 Thread Greg KH
On Tue, Apr 06, 2021 at 11:35:54PM -0700, Pavle Rohalj wrote: > Changes in v2: > - Removed type information from variable names > - Broken up the changes into smaller patches Your subject is very odd :(

Re: [RESEND PATCH v5 2/2] bio: add limit_bio_size sysfs

2021-04-06 Thread Greg KH
On Wed, Apr 07, 2021 at 10:21:17AM +0900, Changheun Lee wrote: > > On 3/16/21 12:44 AM, Changheun Lee wrote: > > > Add limit_bio_size block sysfs node to limit bio size. > > > Queue flag QUEUE_FLAG_LIMIT_BIO_SIZE will be set if limit_bio_size is set. > > > And bio max size will be limited by queue

Re: [PATCH] staging: rtl8712: avoid multiple line dereference

2021-04-06 Thread Greg KH
On Wed, Apr 07, 2021 at 01:15:17AM +0200, Sergei Krainov wrote: > fix post-commit hook checkpatch issues: > > WARNING: Avoid multiple line dereference - prefer > 'adapter->mlmepriv.cur_network.network.InfrastructureMode' > + adapter->mlmepriv.cur_network.network. > +

Re: [RESEND PATCH] staging: emxx_udc: Ending line with argument

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 09:00:07PM +0100, Beatriz Martins de Carvalho wrote: > > Em 06/04/21 20:36, Greg KH escreveu: > > On Tue, Apr 06, 2021 at 08:34:09PM +0100, Beatriz Martins de Carvalho wrote: > > > Cleans up check of "Lines should not end with a '('&

Re: [RESEND PATCH v5 1/2] bio: limit bio max size

2021-04-06 Thread Greg KH
On Wed, Apr 07, 2021 at 02:06:33PM +0900, Changheun Lee wrote: > > On Wed, Apr 07, 2021 at 09:16:12AM +0900, Changheun Lee wrote: > > > > On Tue, Apr 06, 2021 at 10:31:28AM +0900, Changheun Lee wrote: > > > > > > bio size can grow up to 4GB when muli-page bvec is enabled. > > > > > > but sometimes

Re: [RESEND PATCH v5 1/2] bio: limit bio max size

2021-04-06 Thread Greg KH
On Wed, Apr 07, 2021 at 09:16:12AM +0900, Changheun Lee wrote: > > On Tue, Apr 06, 2021 at 10:31:28AM +0900, Changheun Lee wrote: > > > > bio size can grow up to 4GB when muli-page bvec is enabled. > > > > but sometimes it would lead to inefficient behaviors. > > > > in case of large chunk direct I

Re: [PATCH] fs/debugfs: Convert to DEFINE_SHOW_ATTRIBUTE

2021-04-06 Thread Greg KH
On Wed, Apr 07, 2021 at 10:22:06AM +0800, Zuo Qi Lin wrote: > On Fri, 2 Apr 2021 14:22:24 +0200 > Greg KH wrote: > > > On Fri, Apr 02, 2021 at 08:11:41PM +0800, zuoqil...@163.com wrote: > > > From: zuoqilin > > > > Please use your full/real name

Re: [RESEND PATCH] staging: emxx_udc: Ending line with argument

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 08:34:09PM +0100, Beatriz Martins de Carvalho wrote: > Cleans up check of "Lines should not end with a '('" > with argument present in next line in file emxx_udc.c > > Signed-off-by: Beatriz Martins de Carvalho > > --- > drivers/staging/emxx_udc/emxx_udc.c | 11 -

Re: [PATCH AUTOSEL 5.10 07/22] scsi: iscsi: Fix race condition between login and sync thread

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 12:24:32PM -0500, Mike Christie wrote: > On 4/5/21 11:04 AM, Sasha Levin wrote: > > From: Gulam Mohamed > > > > [ Upstream commit 9e67600ed6b8565da4b85698ec659b5879a6c1c6 ] > > > > A kernel panic was observed due to a timing issue between the sync thread > > and the initi

Re: [PATCH] KVM: x86/mmu: preserve pending TLB flush across calls to kvm_tdp_mmu_zap_sp

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 08:35:55PM +0200, Paolo Bonzini wrote: > On 06/04/21 20:25, Greg KH wrote: > > On Tue, Apr 06, 2021 at 12:25:50PM -0400, Paolo Bonzini wrote: > > > Right now, if a call to kvm_tdp_mmu_zap_sp returns false, the caller > > > will skip the TLB flush,

Re: [PATCH] KVM: x86/mmu: preserve pending TLB flush across calls to kvm_tdp_mmu_zap_sp

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 12:25:50PM -0400, Paolo Bonzini wrote: > Right now, if a call to kvm_tdp_mmu_zap_sp returns false, the caller > will skip the TLB flush, which is wrong. There are two ways to fix > it: > > - since kvm_tdp_mmu_zap_sp will not yield and therefore will not flush > the TLB i

Re: linux-next: build warning after merge of the char-misc tree

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 05:28:36PM +, Gustavo Pimentel wrote: > On Tue, Apr 6, 2021 at 15:15:40, Greg KH wrote: > > > On Tue, Apr 06, 2021 at 02:13:53PM +, Gustavo Pimentel wrote: > > > On Tue, Apr 6, 2021 at 15:7:23, Greg KH wrote: > > > > > &g

<    1   2   3   4   5   6   7   8   9   10   >