Re: [PATCH v2 0/2] hwmon: (pmbus) Add ST STPDDC60 pmbus driver

2021-02-11 Thread Guenter Roeck
On 2/4/21 5:20 AM, Erik Rosen wrote: > This patch series adds hardware monitoring support for the ST STPDDC60 > chip. The driver has been tested with a Flex BMR481 converter. > > The checkpatch script complains about an unneeded paranthesis in an > if-statement but gcc gives a warning if it is rem

Re: [PATCH v5 3/3] MAINTAINERS: Add entry for Texas Instruments TPS23861 PoE PSE

2021-02-11 Thread Guenter Roeck
On Thu, Jan 21, 2021 at 02:44:34PM +0100, Robert Marko wrote: > Add maintainers entry for the Texas Instruments TPS23861 PoE PSE driver. > > Signed-off-by: Robert Marko > Cc: Luka Perkov > Reviewed-by: Guenter Roeck Applied. Thanks, Guenter > --- > Changes in v4: >

Re: [PATCH v5 2/3] hwmon: add Texas Instruments TPS23861 driver

2021-02-11 Thread Guenter Roeck
On Thu, Jan 21, 2021 at 02:44:33PM +0100, Robert Marko wrote: > Add basic monitoring support as well as port on/off control for Texas > Instruments TPS23861 PoE PSE IC. > > Signed-off-by: Robert Marko > Cc: Luka Perkov > Reviewed-by: Guenter Roeck Applied. Thanks, Guenter

Re: [PATCH v5 1/3] dt-bindings: hwmon: Add TI TPS23861 bindings

2021-02-11 Thread Guenter Roeck
On Thu, Jan 21, 2021 at 02:44:32PM +0100, Robert Marko wrote: > Document bindings for the Texas Instruments TPS23861 driver. > > Signed-off-by: Robert Marko > Cc: Luka Perkov > Reviewed-by: Rob Herring Applied. Thanks, Guenter > --- > Changes in v5: > * Drop uint32 reference > > Changes in

Re: [PATCH v6 6/7] dt-bindings: connector: Add SVDM VDO properties

2021-02-11 Thread Guenter Roeck
On Fri, Feb 05, 2021 at 11:34:14AM +0800, Kyle Tso wrote: > Add bindings of VDO properties of USB PD SVDM so that they can be > used in device tree. > > Signed-off-by: Kyle Tso Reviewed-by: Guenter Roeck Would it be possible to unify the dt definitions with the definitions in i

Re: [PATCH v6 7/7] usb: typec: tcpm: Get Sink VDO from fwnode

2021-02-11 Thread Guenter Roeck
y: Kyle Tso Reviewed-by: Guenter Roeck > --- > Changes since v5: > - no change > > drivers/usb/typec/tcpm/tcpm.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index b45cd19

Re: [PATCH v6 5/7] usb: typec: displayport: Fill the negotiated SVDM Version in the header

2021-02-11 Thread Guenter Roeck
On Fri, Feb 05, 2021 at 11:34:13AM +0800, Kyle Tso wrote: > VDM header now requires SVDM Version. Get it from typec_partner. > > Signed-off-by: Kyle Tso Reviewed-by: Guenter Roeck > --- > Changes since v5: > - follow the changes of "usb: typec: Manage SVDM version&q

Re: [PATCH v6 4/7] usb: typec: ucsi: Determine common SVDM Version

2021-02-11 Thread Guenter Roeck
Command > sent and received during VDM discovery Shall be used to determine the > lowest common Structured VDM Version supported by the Port Partners or > Cable Plug and Shall continue to operate using this Specification > Revision until they are Detached." > > Sig

Re: [PATCH v6 3/7] usb: typec: tcpm: Determine common SVDM Version

2021-02-11 Thread Guenter Roeck
On Fri, Feb 05, 2021 at 11:34:11AM +0800, Kyle Tso wrote: > PD Spec Revision 3.0 Version 2.0 + ECNs 2020-12-10 > 6.4.4.2.3 Structured VDM Version > "The Structured VDM Version field of the Discover Identity Command > sent and received during VDM discovery Shall be used to determine the > lo

Re: [PATCH v6 2/7] usb: pd: Make SVDM Version configurable in VDM header

2021-02-11 Thread Guenter Roeck
On Fri, Feb 05, 2021 at 11:34:10AM +0800, Kyle Tso wrote: > PD Rev 3.0 introduces SVDM Version 2.0. This patch makes the field > configuable in the header in order to be able to be compatible with > older SVDM version. > > Signed-off-by: Kyle Tso Reviewed-by: Guenter Roeck

Re: [PATCHi v6 1/7] usb: typec: Manage SVDM version

2021-02-11 Thread Guenter Roeck
pported by the port and another variable in typec_partner to cache the > negotiated SVDM version between the port and the partner. > > Also add setter/getter functions for the negotiated SVDM version. > > Signed-off-by: Kyle Tso Reviewed-by: Guenter Roeck > --- > Changes

Re: [PATCH] scripts/dtc: Update to upstream version v1.6.0-51-g183df9e9c2b9

2021-02-11 Thread Guenter Roeck
Hi Rob, On Wed, Feb 03, 2021 at 03:26:03PM -0600, Rob Herring wrote: > This adds the following commits from upstream: > > 183df9e9c2b9 gitignore: Ignore the swp files > 0db6d09584e1 gitignore: Add cscope files > 307afa1a7be8 Update Jon Loeliger's email > ca16a723fa9d fdtdump: Fix gcc11 warning >

Re: [PATCH v1 5/5] driver core: Set fw_devlink=on by default

2021-02-10 Thread Guenter Roeck
On 2/10/21 12:52 PM, Saravana Kannan wrote: > On Wed, Feb 10, 2021 at 7:10 AM Guenter Roeck wrote: >> >> On 2/10/21 12:20 AM, Saravana Kannan wrote: >>> On Tue, Feb 9, 2021 at 9:54 PM Guenter Roeck wrote: >>>> >>>> On Thu, Dec 17, 2020 at 07:17

Re: [PATCH v1 5/5] driver core: Set fw_devlink=on by default

2021-02-10 Thread Guenter Roeck
On 2/10/21 12:20 AM, Saravana Kannan wrote: > On Tue, Feb 9, 2021 at 9:54 PM Guenter Roeck wrote: >> >> On Thu, Dec 17, 2020 at 07:17:03PM -0800, Saravana Kannan wrote: >>> Cyclic dependencies in some firmware was one of the last remaining >>> reasons fw_devlink=o

Re: [PATCH] locking/arch: Move qrwlock.h include after qspinlock.h

2021-02-10 Thread Guenter Roeck
able, there should be a better reference than "The queued rwlock code". This patch fixes the build problem I had observed on mips. I also tested xtensa:defconfig and arm64:defconfig with no problems observed. Tested-by: Guenter Roeck Guenter > --- > arch/arm64/include/a

Re: [PATCH v3 1/8] mm: Cleanup faultaround and finish_fault() codepaths

2021-02-10 Thread Guenter Roeck
On 2/10/21 3:44 AM, Will Deacon wrote: > On Tue, Feb 09, 2021 at 12:24:49PM -0800, Guenter Roeck wrote: >> On Thu, Jan 14, 2021 at 05:59:27PM +, Will Deacon wrote: >>> From: "Kirill A. Shutemov" >>> >>> alloc_set_pte() has two users with different

Re: [PATCH v2 06/28] locking/rwlocks: Add contention detection for rwlocks

2021-02-09 Thread Guenter Roeck
On 2/9/21 4:27 PM, Waiman Long wrote: [ ... ] > > It is because in arch/mips/include/asm/spinlock.h, asm/qrwlock.h is included > before asm/qspinlock.h. The compilation error should be gone if the > asm/qrwlock.h is removed or moved after asm/qspinlock.h. > > I did a x86 build and there was no

Re: [PATCH v1 5/5] driver core: Set fw_devlink=on by default

2021-02-09 Thread Guenter Roeck
On Thu, Dec 17, 2020 at 07:17:03PM -0800, Saravana Kannan wrote: > Cyclic dependencies in some firmware was one of the last remaining > reasons fw_devlink=on couldn't be set by default. Now that cyclic > dependencies don't block probing, set fw_devlink=on by default. > > Setting fw_devlink=on by d

Re: [PATCH v2 06/28] locking/rwlocks: Add contention detection for rwlocks

2021-02-09 Thread Guenter Roeck
On Tue, Feb 09, 2021 at 04:46:02PM -0500, Waiman Long wrote: > On 2/9/21 3:39 PM, Guenter Roeck wrote: > > On Tue, Feb 02, 2021 at 10:57:12AM -0800, Ben Gardon wrote: > > > rwlocks do not currently have any facility to detect contention > > > like spinlocks do. In orde

Re: [PATCH v2 06/28] locking/rwlocks: Add contention detection for rwlocks

2021-02-09 Thread Guenter Roeck
On Tue, Feb 02, 2021 at 10:57:12AM -0800, Ben Gardon wrote: > rwlocks do not currently have any facility to detect contention > like spinlocks do. In order to allow users of rwlocks to better manage > latency, add contention detection for queued rwlocks. > > CC: Ingo Molnar > CC: Will Deacon > A

Re: [PATCH v3 1/8] mm: Cleanup faultaround and finish_fault() codepaths

2021-02-09 Thread Guenter Roeck
On Thu, Jan 14, 2021 at 05:59:27PM +, Will Deacon wrote: > From: "Kirill A. Shutemov" > > alloc_set_pte() has two users with different requirements: in the > faultaround code, it called from an atomic context and PTE page table > has to be preallocated. finish_fault() can sleep and allocate p

Re: [PATCH 5.4 00/65] 5.4.97-rc1 review

2021-02-09 Thread Guenter Roeck
let me know. > > Responses should be made by Wed, 10 Feb 2021 14:57:55 +. > Anything received after that time might be too late. > Build results: total: 157 pass: 157 fail: 0 Qemu test results: total: 427 pass: 427 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.10 000/120] 5.10.15-rc1 review

2021-02-09 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 10 Feb 2021 14:57:55 +. > Anything received after that time might be too late. > Build results: total: 154 pass: 154 fail: 0 Qemu test results: total: 427 pass: 427 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 3/4] hwmon: (occ) Start sequence number at one

2021-02-09 Thread Guenter Roeck
On Tue, Feb 09, 2021 at 11:12:34AM -0600, Eddie James wrote: > Initialize the sequence number at one, rather than zero, in order > to prevent false matches with the zero-initialized OCC SRAM > buffer before the OCC is fully initialized. > > Signed-off-by: Eddie James Acked-by

Re: [PATCH 4.9 00/43] 4.9.257-rc1 review

2021-02-09 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 10 Feb 2021 14:57:55 +. > Anything received after that time might be too late. > Build results: total: 168 pass: 168 fail: 0 Qemu test results: total: 382 pass: 382 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.19 00/38] 4.19.175-rc1 review

2021-02-09 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 10 Feb 2021 14:57:55 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 418 pass: 418 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4/4] hwmon: (occ) Print response status in first poll error message

2021-02-09 Thread Guenter Roeck
On Tue, Feb 09, 2021 at 11:12:35AM -0600, Eddie James wrote: > In order to better debug problems starting up the driver, print > the response status from the OCC in the error logged when the first > poll command fails. > > Signed-off-by: Eddie James Acked-by: Guenter Roeck &

Re: [PATCH 4.4 00/38] 4.4.257-rc1 review

2021-02-09 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 10 Feb 2021 14:57:55 +. > Anything received after that time might be too late. > Build results: total: 165 pass: 165 fail: 0 Qemu test results: total: 328 pass: 328 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.14 00/30] 4.14.221-rc1 review

2021-02-09 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 10 Feb 2021 14:57:55 +. > Anything received after that time might be too late. > Build results: total: 168 pass: 168 fail: 0 Qemu test results: total: 404 pass: 404 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH v6 2/8] drm/mediatek: add component POSTMASK

2021-02-09 Thread Guenter Roeck
On Tue, Feb 02, 2021 at 04:12:31PM +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > This patch add component POSTMASK. > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > Reviewed-by: CK Hu > --- [ ... ] > > +void mtk_postmask_config(struct device *dev, unsigned int w, sta

Re: [PATCH v2 2/4] hwmon: Use subdir-ccflags-* to inherit debug flag

2021-02-09 Thread Guenter Roeck
On Tue, Feb 09, 2021 at 07:08:17PM +0800, Yicong Yang wrote: > From: Junhao He > > We use ccflags-$(CONFIG_HWMON_DEBUG_CHIP) for the debug > message in drivers/hwmon, but the DEBUG flag will not pass to > the subdirectory. > > Considering CONFIG_HWMON_DEBUG_CHIP intends to have DEBUG > recursive

Re: [PATCH 2/4] hwmon: Use subdir-ccflags-* to inherit debug flag

2021-02-08 Thread Guenter Roeck
On 2/5/21 12:08 PM, Bjorn Helgaas wrote: > On Fri, Feb 05, 2021 at 10:28:32AM -0800, Guenter Roeck wrote: >> On Fri, Feb 05, 2021 at 05:44:13PM +0800, Yicong Yang wrote: >>> From: Junhao He >>> >>> Use subdir-ccflags-* instead of ccflags-* to inherit the

Re: Linux 5.11-rc7

2021-02-08 Thread Guenter Roeck
On Sun, Feb 07, 2021 at 02:32:37PM -0800, Linus Torvalds wrote: > So it's the biggest sporting day of the year here in the US, when > everybody is getting ready to watch the yearly top TV commercials, > occasionally interrupted by some odd handegg carrying competition that > I still haven't figured

Re: Linux 4.4.256

2021-02-08 Thread Guenter Roeck
On Sun, Feb 07, 2021 at 09:22:44AM +0100, Greg Kroah-Hartman wrote: [ ... ] > > There are lots (35) of "KERNEL_VERSION(4, 5, 0)" in chromeos-4.4. > > That should not matter with the clamped LINUX_VERSION_CODE, but > > I'd prefer to clamp KERNEL_VERSION as well just to be sure. On > > top of that, s

Re: [PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart

2021-02-08 Thread Guenter Roeck
On Tue, Dec 15, 2020 at 10:53:52PM +0530, Youghandhar Chintala wrote: > Currently in case of target hardware restart, we just reconfig and > re-enable the security keys and enable the network queues to start > data traffic back from where it was interrupted. > > Many ath10k wifi chipsets have sequ

Re: [PATCH v1 2/2] mei: bus: change remove callback to return void

2021-02-07 Thread Guenter Roeck
rs/misc/mei/bus.c | 5 ++--- > drivers/misc/mei/hdcp/mei_hdcp.c | 7 +-- > drivers/nfc/microread/mei.c | 4 +--- > drivers/nfc/pn544/mei.c | 4 +--- > drivers/watchdog/mei_wdt.c | 4 +--- Acked-by: Guenter Roeck > include/linux/mei_cl_bus.h

Re: Linux 4.4.256

2021-02-06 Thread Guenter Roeck
On Sat, Feb 06, 2021 at 07:13:39PM +0100, Greg Kroah-Hartman wrote: > On Sat, Feb 06, 2021 at 08:59:42AM -0800, Guenter Roeck wrote: > > On 2/6/21 5:22 AM, Willy Tarreau wrote: > > > On Sat, Feb 06, 2021 at 02:11:13PM +0100, Willy Tarreau wrote: > > >> Something lik

Re: Linux 4.4.256

2021-02-06 Thread Guenter Roeck
On 2/6/21 5:22 AM, Willy Tarreau wrote: > On Sat, Feb 06, 2021 at 02:11:13PM +0100, Willy Tarreau wrote: >> Something like this looks more robust to me, it will use SUBLEVEL for >> values 0 to 255 and 255 for any larger value: >> >> -expr $(VERSION) \* 65536 + 0$(PATCHLEVEL) \* 256 + 0$(SUBLEVE

Re: [PATCH v4 2/4] hwmon: lm75: Add nxp,lm75a to of_match list

2021-02-06 Thread Guenter Roeck
On 2/6/21 8:48 AM, Guenter Roeck wrote: > On 2/6/21 1:51 AM, Matwey V. Kornilov wrote: >> NXP LM75A is compatible with original LM75A while it has improved >> 11-bit precision. >> >> https://www.nxp.com/docs/en/data-sheet/LM75A.pdf >> >> Signed-off-by: Matwe

Re: [PATCH v4 3/4] hwmon: lm75: Add ti,lm75 to of_match list

2021-02-06 Thread Guenter Roeck
On 2/6/21 1:51 AM, Matwey V. Kornilov wrote: > Currently, armada-388-helios4.dts and nuvoton-npcm730-kudo.dts use > "ti,lm75" compatible string. > > TI LM75A/B are compatible with original LM75A > > https://www.ti.com/lit/ds/symlink/lm75a.pdf > https://www.ti.com/lit/ds/symlink/lm75b.pdf > > Sig

Re: [PATCH v4 2/4] hwmon: lm75: Add nxp,lm75a to of_match list

2021-02-06 Thread Guenter Roeck
On 2/6/21 1:51 AM, Matwey V. Kornilov wrote: > NXP LM75A is compatible with original LM75A while it has improved > 11-bit precision. > > https://www.nxp.com/docs/en/data-sheet/LM75A.pdf > > Signed-off-by: Matwey V. Kornilov > --- > Documentation/devicetree/bindings/hwmon/lm75.yaml | 1 + > dri

Re: [PATCH v4 1/4] hwmon: lm75: Add lm75 to of_match list

2021-02-06 Thread Guenter Roeck
On 2/6/21 1:51 AM, Matwey V. Kornilov wrote: > Currently, many boards use just 'lm75' as a compatible string. > > Signed-off-by: Matwey V. Kornilov > --- > Documentation/devicetree/bindings/hwmon/lm75.yaml | 1 + > drivers/hwmon/lm75.c | 4 > 2 files changed, 5

Re: [PATCH 5.10 00/57] 5.10.14-rc1 review

2021-02-06 Thread Guenter Roeck
> let me know. > > Responses should be made by Sun, 07 Feb 2021 14:06:42 +. > Anything received after that time might be too late. > Build results: total: 154 pass: 154 fail: 0 Qemu test results: total: 427 pass: 427 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.19 00/17] 4.19.174-rc1 review

2021-02-06 Thread Guenter Roeck
> let me know. > > Responses should be made by Sun, 07 Feb 2021 14:06:42 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 418 pass: 418 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.4 00/32] 5.4.96-rc1 review

2021-02-06 Thread Guenter Roeck
let me know. > > Responses should be made by Sun, 07 Feb 2021 14:06:42 +. > Anything received after that time might be too late. > Build results: total: 157 pass: 157 fail: 0 Qemu test results: total: 428 pass: 428 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.14 00/15] 4.14.220-rc1 review

2021-02-06 Thread Guenter Roeck
> let me know. > > Responses should be made by Sun, 07 Feb 2021 14:06:42 +. > Anything received after that time might be too late. > Build results: total: 168 pass: 168 fail: 0 Qemu test results: total: 404 pass: 404 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH v6 0/7] common SVDM version and VDO from dt

2021-02-05 Thread Guenter Roeck
On 2/5/21 3:42 AM, Heikki Krogerus wrote: [ ... ] >> Kyle Tso (7): >> usb: typec: Manage SVDM version >> usb: pd: Make SVDM Version configurable in VDM header >> usb: typec: tcpm: Determine common SVDM Version >> usb: typec: ucsi: Determine common SVDM Version >> usb: typec: displayport:

Re: Linux 4.4.256

2021-02-05 Thread Guenter Roeck
On Fri, Feb 05, 2021 at 03:26:36PM +0100, Greg Kroah-Hartman wrote: > I'm announcing the release of the 4.4.256 kernel. > > This, and the 4.9.256 release are a little bit "different" than normal. > > This contains only 1 patch, just the version bump from .255 to .256 which ends > up causing the u

Re: [PATCH 2/4] hwmon: Use subdir-ccflags-* to inherit debug flag

2021-02-05 Thread Guenter Roeck
On Fri, Feb 05, 2021 at 05:44:13PM +0800, Yicong Yang wrote: > From: Junhao He > > Use subdir-ccflags-* instead of ccflags-* to inherit the debug > settings from Kconfig when traversing subdirectories. > > Suggested-by: Bjorn Helgaas > Signed-off-by: Junhao He > Signed-off-by: Yicong Yang Wh

Re: [PATCH 5.4 00/61] 5.4.95-rc1 review

2021-02-03 Thread Guenter Roeck
let me know. > > Responses should be made by Thu, 04 Feb 2021 13:29:33 +. > Anything received after that time might be too late. > Build results: total: 157 pass: 157 fail: 0 Qemu test results: total: 427 pass: 427 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.10 000/142] 5.10.13-rc1 review

2021-02-03 Thread Guenter Roeck
> let me know. > > Responses should be made by Thu, 04 Feb 2021 13:29:33 +. > Anything received after that time might be too late. > Build results: total: 154 pass: 154 fail: 0 Qemu test results: total: 427 pass: 427 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH v2] hwmon: (pmbus) convert sysfs sprintf/snprintf family to sysfs_emit

2021-02-03 Thread Guenter Roeck
On Tue, Feb 02, 2021 at 04:49:03PM +0800, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./drivers/hwmon/pmbus/inspur-ipsps.c:73:8-16: WARNING: use scnprintf or > sprintf. > > ./drivers/hwmon/pmbus/inspur-ipsps.c:114:9-17: WARNING: use scnprintf or > sprintf. > > ./drivers/hwmo

Re: [PATCH 4.19 00/37] 4.19.173-rc1 review

2021-02-03 Thread Guenter Roeck
> let me know. > > Responses should be made by Thu, 04 Feb 2021 13:29:33 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 418 pass: 418 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.14 00/30] 4.14.219-rc1 review

2021-02-03 Thread Guenter Roeck
> let me know. > > Responses should be made by Thu, 04 Feb 2021 13:29:33 +. > Anything received after that time might be too late. > Build results: total: 168 pass: 168 fail: 0 Qemu test results: total: 404 pass: 404 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.9 00/32] 4.9.255-rc1 review

2021-02-03 Thread Guenter Roeck
> let me know. > > Responses should be made by Thu, 04 Feb 2021 13:29:33 +. > Anything received after that time might be too late. > Build results: total: 168 pass: 168 fail: 0 Qemu test results: total: 382 pass: 382 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.4 00/28] 4.4.255-rc1 review

2021-02-03 Thread Guenter Roeck
> let me know. > > Responses should be made by Thu, 04 Feb 2021 13:29:33 +. > Anything received after that time might be too late. > Build results: total: 165 pass: 165 fail: 0 Qemu test results: total: 328 pass: 328 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 1/2] hwmon: lm75: Add NXP LM75A to of_match list

2021-02-03 Thread Guenter Roeck
On 2/3/21 9:13 AM, Matwey V. Kornilov wrote: > > > сб, 30 янв. 2021 г. в 18:41, Guenter Roeck <mailto:li...@roeck-us.net>>: >> >> On 1/30/21 2:38 AM, Matwey V. Kornilov wrote: >> > NXP LM75A is compatible with original LM75A while it has improved

Re: [PATCH v5 1/8] usb: typec: Manage SVDM version

2021-02-03 Thread Guenter Roeck
On 2/3/21 7:04 AM, Heikki Krogerus wrote: > On Wed, Feb 03, 2021 at 05:01:26PM +0200, Heikki Krogerus wrote: >> On Wed, Feb 03, 2021 at 06:51:43AM -0800, Guenter Roeck wrote: >>> Thinking about it, would it make make sense to define the functions as >>> static inli

Re: [PATCH v5 1/8] usb: typec: Manage SVDM version

2021-02-03 Thread Guenter Roeck
On Wed, Feb 03, 2021 at 02:47:24PM +0200, Heikki Krogerus wrote: > Hi Kyle, > > On Wed, Feb 03, 2021 at 12:17:26AM +0800, Kyle Tso wrote: > > PD Spec Revision 3.0 Version 2.0 + ECNs 2020-12-10 > > 6.4.4.2.3 Structured VDM Version > > "The Structured VDM Version field of the Discover Identity C

Re: [PATCH] watchdog: diag288_wdt: Remove redundant assignment

2021-02-03 Thread Guenter Roeck
On 2/3/21 4:24 AM, angkery wrote: > From: Junlin Yang > > The assign for 'ret' is redundant and can be removed, > because it will be assigned before use. > > Signed-off-by: Junlin Yang Reviewed-by: Guenter Roeck > --- > drivers/watchdog/diag288_wdt.c | 4 -

Re: [PATCH v6 25/37] hwmon: (scmi) port driver to the new scmi_sensor_proto_ops interface

2021-02-02 Thread Guenter Roeck
On 2/2/21 2:15 PM, Cristian Marussi wrote: > Port driver to the new SCMI Sensor interface based on protocol handles > and common devm_get_ops(). > > Cc: Guenter Roeck > Cc: Jean Delvare > Signed-off-by: Cristian Marussi Assuming this will be handled with the series. Acked

Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

2021-02-02 Thread Guenter Roeck
; Cc: Linus Walleij > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: Daniel Palmer > Cc: Bartosz Golaszewski > Cc: Avi Fishman > Cc: Tomer Maimon > Cc: Tali Perry > Cc: Joerg Roedel > Cc: Will Deacon > Cc: Andrew Jeffery > Cc: Joel Stanley > C

Re: [PATCH v3] hwmon: lm75: Handle broken device nodes gracefully

2021-02-02 Thread Guenter Roeck
On 2/2/21 11:31 AM, Matwey V. Kornilov wrote: > > > вт, 2 февр. 2021 г. в 22:29, Guenter Roeck <mailto:li...@roeck-us.net>>: >> >> On 2/2/21 10:37 AM, Matwey V. Kornilov wrote: >> > There is a logical flaw in lm75_probe() function introduced in >>

Re: [PATCH v3] hwmon: lm75: Handle broken device nodes gracefully

2021-02-02 Thread Guenter Roeck
On 2/2/21 10:37 AM, Matwey V. Kornilov wrote: > There is a logical flaw in lm75_probe() function introduced in > > commit e97a45f1b460 ("hwmon: (lm75) Add OF device ID table") > > Note, that of_device_get_match_data() returns NULL when no match > is found. This is the case when OF node exists

Re: [PATCH v3] tpm_tis: Add missing tpm_request/relinquish_locality calls

2021-02-02 Thread Guenter Roeck
't >* been called before doing a TPM operation. >*/ > In this case we don't have to call tpm_try_get_ops() > as both calls (tpm_get_timeouts() and tpm_tis_probe_irq_single()) are > in the tpm_tis_core_init function and don't require any

Re: [PATCH] net: fec: Silence M5272 build warnings

2021-02-02 Thread Guenter Roeck
gt; dev_get_platdata(&fep->pdev->dev); > |^ > > Fix this by moving the variable declarations inside the existing #ifdef > blocks. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Guenter Roeck > --- > drivers/net/eth

Re: [PATCH v2 1/3] usb: typec: tcpm: Add Callback to Usb Communication capable partner

2021-02-02 Thread Guenter Roeck
hip specific operation. > For instance, low level driver enables USB switches on D+/D- > lines to set up data path when the bit is set. > > Refactored from patch initially authored by > Kyle Tso > > Signed-off-by: Badhri Jagan Sridharan Reviewed-by: Guenter Roeck >

Re: [PATCH v2 2/3] usb: typec: tcpci: Add Callback to Usb Communication capable partner

2021-02-02 Thread Guenter Roeck
> Signed-off-by: Badhri Jagan Sridharan Reviewed-by: Guenter Roeck > --- > drivers/usb/typec/tcpm/tcpci.c | 9 + > drivers/usb/typec/tcpm/tcpci.h | 6 ++ > 2 files changed, 15 insertions(+) > > diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typ

Re: [PATCH v2 3/3] usb: typec: tcpci_maxim: Enable data path when partner is USB Comm capable

2021-02-02 Thread Guenter Roeck
On Mon, Feb 01, 2021 at 04:31:01PM -0800, Badhri Jagan Sridharan wrote: > Configure USB switches when partner is USB Communication capable. > The is enabled USB data communication over D+/D- pins. > > Signed-off-by: Badhri Jagan Sridharan Reviewed-by: Guenter Roeck > --- >

Re: [PATCH] drm/msm: remove unneeded variable: "rc"

2021-02-02 Thread Guenter Roeck
On Tue, Feb 2, 2021 at 4:32 AM Bernard Zhao wrote: > > remove unneeded variable: "rc". > > Signed-off-by: Bernard Zhao Reviewed-by: Guenter Roeck > > --- > drivers/gpu/drm/msm/dp/dp_panel.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >

Re: [PATCH v2] hwmon: lm75: Handle broken device nodes gracefully

2021-02-02 Thread Guenter Roeck
On 2/2/21 6:21 AM, Matwey V. Kornilov wrote: > There is a logical flaw in lm75_probe() function introduced in > > commit e97a45f1b460 ("hwmon: (lm75) Add OF device ID table") > > Note, that of_device_get_match_data() returns NULL when no match > found. This is the case when OF node exists but

Re: [PATCH 1/1] Add ST STPDDC60 pmbus driver

2021-02-02 Thread Guenter Roeck
On 2/2/21 6:34 AM, Erik Rosen wrote: > On Mon, Feb 1, 2021 at 10:38 PM Guenter Roeck wrote: >> >> On 2/1/21 8:48 AM, Erik Rosen wrote: >>> Hi Guenter >>> >>> >>> On Fri, Jan 29, 2021 at 4:50 PM Guenter Roeck wrote: >>>&g

Re: [PATCH v4 3/8] usb: pd: Make SVDM Version configurable in VDM header

2021-02-02 Thread Guenter Roeck
On 2/2/21 1:33 AM, Kyle Tso wrote: > PD Rev 3.0 introduces SVDM Version 2.0. This patch makes the field > configuable in the header in order to be able to be compatible with > older SVDM version. > > Signed-off-by: Kyle Tso > --- > include/linux/usb/pd_vdo.h | 7 +-- > 1 file changed, 5 inse

Re: [PATCH v1] usb: typec: tcpm: Set in_ams flag when Source caps have been received

2021-02-01 Thread Guenter Roeck
message to the UUT repeatedly until >nCapsCount reached or a GoodCRC is received. If nCapsCount reached, the >test fails. > i) If a Request is not received timely within 30 ms after the GoodCRC EOP >corresponding to Source Capabilities message was received, the test >fails.

Re: [PATCH v2] pmbus:max31785: Support revision "B"

2021-02-01 Thread Guenter Roeck
On Mon, Feb 01, 2021 at 03:22:17PM -0600, Matthew Barth wrote: > There was an issue in how the tach feedbacks of dual rotor fans were > reported during any change in fan speeds with revision "A" of the > MAX31785. When the fan speeds would transition to a new target speed, > the rotor not wired to

Re: [PATCH 2/2] Remove unnecessary pmbus_clear_cache function call

2021-02-01 Thread Guenter Roeck
On Mon, Feb 01, 2021 at 08:59:29PM +0100, Erik Rosen wrote: > It is no longer necessary to clear the cache to update the sensor value > from the chip. > > Signed-off-by: Erik Rosen Applied, after prepending subject with "hwmon: (pmbus/lm25066)". Thanks, Guenter > --- > drivers/hwmon/pmbus/lm2

Re: [PATCH 1/2] Clear sensor data after chip write

2021-02-01 Thread Guenter Roeck
On Mon, Feb 01, 2021 at 08:59:28PM +0100, Erik Rosen wrote: > Set the sensor->data field to -ENODATA to force a chip access next time > the sensor value is read. > > Signed-off-by: Erik Rosen Applied. Please remember to add subsystem and driver to future patches. In this case, I added: hwmon: (

Re: [PATCH 1/1] Add ST STPDDC60 pmbus driver

2021-02-01 Thread Guenter Roeck
On 2/1/21 8:48 AM, Erik Rosen wrote: > Hi Guenter > > > On Fri, Jan 29, 2021 at 4:50 PM Guenter Roeck wrote: >> >> Hi Erik, >> >> On 1/29/21 5:07 AM, Erik Rosen wrote: >> [ ... ] >>>> >>>>> +

Re: [PATCH v1 1/3] usb: typec: tcpm: Add Callback to Usb Communication capable partner

2021-02-01 Thread Guenter Roeck
On 2/1/21 8:38 AM, Greg Kroah-Hartman wrote: > On Mon, Feb 01, 2021 at 06:09:25PM +0200, Heikki Krogerus wrote: >> On Mon, Feb 01, 2021 at 04:19:38PM +0100, Greg Kroah-Hartman wrote: >>> On Mon, Feb 01, 2021 at 05:12:53PM +0200, Heikki Krogerus wrote: On Mon, Feb 01, 2021 at 01:53:07AM -0800,

Re: [PATCH] pmbus:max31785: Support revision "B"

2021-02-01 Thread Guenter Roeck
On 2/1/21 8:50 AM, Matthew Barth wrote: > There was an issue in how the tach feedbacks of dual rotor fans were > reported during any change in fan speeds with revision "A" of the > MAX31785. When the fan speeds would transition to a new target speed, > the rotor not wired to the TACH input when TAC

Re: [PATCH v3 1/3] usb: typec: Determine common SVDM Versions

2021-02-01 Thread Guenter Roeck
some VDO definitions changed in the Spec. > > Signed-off-by: Kyle Tso Reviewed-by: Guenter Roeck > --- > Changes since v2: > - rename the variable and the functions (remove the text "common") > - remove the macro > > drivers/usb/typec/altmodes/displayport.c | 8 +- >

Re: [PATCH v3 3/3] usb: typec: tcpm: Get Sink VDO from fwnode

2021-02-01 Thread Guenter Roeck
On 2/1/21 5:34 AM, Kyle Tso wrote: > Commit a079973f462a ("usb: typec: tcpm: Remove tcpc_config > configuration mechanism") removed the tcpc_config which includes the > Sink VDO and it is not yet added back with fwnode. Add it now. > > Signed-off-by: Kyle Tso R

Re: [PATCH v1 1/3] usb: typec: tcpm: Add Callback to Usb Communication capable partner

2021-02-01 Thread Guenter Roeck
On 2/1/21 1:53 AM, Badhri Jagan Sridharan wrote: > The USB Communications Capable bit indicates if port > partner is capable of communication over the USB data lines > (e.g. D+/- or SS Tx/Rx). Notify the status of the bit to low > level drivers to perform chip specific operation. > For instance, lo

Re: [PATCH v1] usb: typec: tcpm: Handle vbus shutoff when in source mode

2021-02-01 Thread Guenter Roeck
> Signed-off-by: Badhri Jagan Sridharan Reviewed-by: Guenter Roeck > --- > drivers/usb/typec/tcpm/tcpm.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index 0afd8ef692e8..ff0732c12b8a 1

Re: Linux 5.11-rc6

2021-01-31 Thread Guenter Roeck
On Sun, Jan 31, 2021 at 02:01:43PM -0800, Linus Torvalds wrote: > Things look a little calmer than last week, and over-all very average > for rc6. So - like always this late in the release schedule - I'd > certainly have liked things to be even calmer, but nothing here really > stands out. > > The

Re: [PATCH v2 3/3] usb: typec: tcpm: Get Sink VDO from fwnode

2021-01-31 Thread Guenter Roeck
On 1/31/21 9:11 PM, Kyle Tso wrote: > On Mon, Feb 1, 2021 at 12:02 AM Guenter Roeck wrote: >> >> On 1/31/21 7:18 AM, Kyle Tso wrote: >>> Commit a079973f462a ("usb: typec: tcpm: Remove tcpc_config >>> configuration mechanism") removed the tcpc_config wh

Re: [PATCH for -next] docs: hwmon: rectify table in max16601.rst

2021-01-31 Thread Guenter Roeck
On 1/30/21 11:54 PM, Lukas Bulwahn wrote: > Commit 90b0f71d62df ("hwmon: (pmbus/max16601) Determine and use number of > populated phases") adjusts content in the table of > ./Documentation/hwmon/max16601.rst, but one row went beyond the column's > length. > > Hence, make htmldocs warns: > > Doc

Re: [PATCH v2 3/3] usb: typec: tcpm: Get Sink VDO from fwnode

2021-01-31 Thread Guenter Roeck
On 1/31/21 7:18 AM, Kyle Tso wrote: > Commit a079973f462a ("usb: typec: tcpm: Remove tcpc_config > configuration mechanism") removed the tcpc_config which includes the > Sink VDO and it is not yet added back with fwnode. Add it now. > > Signed-off-by: Kyle Tso > --- > Changes since v1: > - update

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

2021-01-30 Thread Guenter Roeck
On 1/30/21 4:41 PM, James Bottomley wrote: > On Sat, 2021-01-30 at 15:49 -0800, Guenter Roeck wrote: >> On 1/29/21 2:59 PM, Jarkko Sakkinen wrote: >>> On Tue, Jan 26, 2021 at 04:46:07PM +0100, Łukasz Majczak wrote: >>>> Hi Jarkko, Guenter >>>> >&

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

2021-01-30 Thread Guenter Roeck
On 1/29/21 2:59 PM, Jarkko Sakkinen wrote: > On Tue, Jan 26, 2021 at 04:46:07PM +0100, Łukasz Majczak wrote: >> Hi Jarkko, Guenter >> >> Yes, here are the logs when failure occurs - >> https://gist.github.com/semihalf-majczak-lukasz/1575461f585f1e7fb1e9366b8eceaab9 >> Look for a phrase "TPM returne

Re: [PATCH] hwmon: lm75: Use zero lm75_type for lm75

2021-01-30 Thread Guenter Roeck
On 1/30/21 2:10 AM, Matwey V. Kornilov wrote: > There is a logical flaw in lm75_probe() function introduced in > > e97a45f1b460 ("hwmon: (lm75) Add OF device ID table") > > Note, that of_device_get_match_data() returns NULL when no match > found. This is the case when OF node exists but has u

Re: [PATCH 1/2] hwmon: lm75: Add NXP LM75A to of_match list

2021-01-30 Thread Guenter Roeck
On 1/30/21 2:38 AM, Matwey V. Kornilov wrote: > NXP LM75A is compatible with original LM75A while it has improved > 11-bit precision. > > https://www.nxp.com/docs/en/data-sheet/LM75A.pdf > > Signed-off-by: Matwey V. Kornilov > --- > drivers/hwmon/lm75.c | 4 > 1 file changed, 4 insertions(

Re: [PATCH v2 4/8] KVM: arm64: Generate hyp relocation data

2021-01-30 Thread Guenter Roeck
On Sat, Jan 30, 2021 at 01:44:15PM +, Marc Zyngier wrote: > On Fri, 29 Jan 2021 21:43:25 +, > Guenter Roeck wrote: > > > > Hi, > > > > On Tue, Jan 05, 2021 at 06:05:37PM +, David Brazdil wrote: > > > Add a post-processing step to compilation o

Re: [PATCH] hwmon: lm75: Use zero lm75_type for lm75

2021-01-30 Thread Guenter Roeck
On 1/30/21 7:43 AM, Matwey V. Kornilov wrote: > > > сб, 30 янв. 2021 г. в 18:31, Guenter Roeck <mailto:li...@roeck-us.net>>: >> >> On 1/30/21 2:10 AM, Matwey V. Kornilov wrote: >> > There is a logical flaw in lm75_probe() function introduced in >> &

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

2021-01-29 Thread Guenter Roeck
On 1/29/21 2:49 PM, Jarkko Sakkinen wrote: > On Mon, Jan 25, 2021 at 09:18:46AM -0800, Guenter Roeck wrote: >> Hi Lukasz, >> >> On Sat, Jan 23, 2021 at 02:42:47AM +0100, Lukasz Majczak wrote: >>> There is a missing call to start_tpm_chip before the call to

Re: [PATCH v2 4/8] KVM: arm64: Generate hyp relocation data

2021-01-29 Thread Guenter Roeck
Hi, On Tue, Jan 05, 2021 at 06:05:37PM +, David Brazdil wrote: > Add a post-processing step to compilation of KVM nVHE hyp code which > calls a custom host tool (gen-hyprel) on the partially linked object > file (hyp sections' names prefixed). > > The tool lists all R_AARCH64_ABS64 data reloc

Re: [PATCH 5.10 00/32] 5.10.12-rc1 review

2021-01-29 Thread Guenter Roeck
> let me know. > > Responses should be made by Sun, 31 Jan 2021 10:59:01 +. > Anything received after that time might be too late. > Build results: total: 154 pass: 154 fail: 0 Qemu test results: total: 427 pass: 427 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.4 00/18] 5.4.94-rc1 review

2021-01-29 Thread Guenter Roeck
let me know. > > Responses should be made by Sun, 31 Jan 2021 10:59:01 +. > Anything received after that time might be too late. > Build results: total: 157 pass: 157 fail: 0 Qemu test results: total: 427 pass: 427 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.19 00/26] 4.19.172-rc1 review

2021-01-29 Thread Guenter Roeck
> let me know. > > Responses should be made by Sun, 31 Jan 2021 10:59:01 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 418 pass: 418 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.9 00/30] 4.9.254-rc1 review

2021-01-29 Thread Guenter Roeck
> let me know. > > Responses should be made by Sun, 31 Jan 2021 10:59:01 +. > Anything received after that time might be too late. > Build results: total: 168 pass: 168 fail: 0 Qemu test results: total: 382 pass: 382 fail: 0 Tested-by: Guenter Roeck Guenter

<    1   2   3   4   5   6   7   8   9   10   >