[PATCH 2/2 v3] usb: ohci: remove ep93xx bus glue platform driver

2013-10-17 Thread H Hartley Sweeten
Convert ep93xx to use the OHCI platform driver and remove the ohci-ep93xx bus glue driver. Enable CONFIG_OHCI_HCD_PLATFORM in the ep93xx_defconfig so that USB is still enabled by default on the EP93xx platform. Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Alan Stern Cc: Lennert

[PATCH 0/2 v4] usb: ohci: remove ep93xx bus glue platform driver

2013-10-17 Thread H Hartley Sweeten
of the Generic OHCI driver for a platform device. v2: Use the (*power_off) callback for (*power_suspend), as suggested by Alan Stern. Remove the Kconfig change to USB_OHCI_HCD_PLATFORM and refresh the ep93xx_defconfig to enable this option, as suggested by Alan Stern. H Hartley

[PATCH 2/2 v4] usb: ohci: remove ep93xx bus glue platform driver

2013-10-17 Thread H Hartley Sweeten
Convert ep93xx to use the OHCI platform driver and remove the ohci-ep93xx bus glue driver. Enable CONFIG_OHCI_HCD_PLATFORM in the ep93xx_defconfig so that USB is still enabled by default on the EP93xx platform. Signed-off-by: H Hartley Sweeten Acked-by: Alan Stern Cc: Ryan Mallon Cc: Lennert

[PATCH 1/2 v4] ARM: ep93xx_defconfig: cleanup ep93xx_defconfig

2013-10-17 Thread H Hartley Sweeten
Generate ep93xx_defconfig by doing: make ep93xx_defconfig make savedefconfig mv defconfig arch/arm/configs/ep93xx_defconfig No function change. This just refreshes the ep93xx_defconfig to make it easier and cleaner when adding new entries. Signed-off-by: H Hartley Sweeten Acked-by: Ryan Mallon

RE: [PATCH] staging: comedi: drivers: ni_atmio.c: Add a missing semicolon

2013-03-15 Thread H Hartley Sweeten
On Friday, March 15, 2013 2:41 AM, Ian Abbott wrote: > On 2013-03-15 08:14, Kumar Amit Mehta wrote: >> fix a missing end-of-statement by adding a semicolon. >> >> Signed-off-by: Kumar Amit Mehta >> --- >> drivers/staging/comedi/drivers/ni_atmio.c |2 +- >> 1 file changed, 1 insertion(+), 1

RE: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-15 Thread H Hartley Sweeten
On Thursday, March 14, 2013 6:58 AM, Arnd Bergmann wrote: > On Thursday 14 March 2013, Fabio Porcedda wrote: >> This patch converts the drivers to use the >> module_platform_driver_probe() macro which makes the code smaller and >> a bit simpler. >> >> Signed-off-by: Fabio Porcedda >> Cc: Greg

[PATCH] video: ep93xx_fb: include for devm_ioremap()

2013-03-15 Thread H Hartley Sweeten
ment makes pointer from integer without a cast Include to pickup the declaration of 'devm_ioremap'. Signed-off-by: H Hartley Sweeten Cc: Cc: Florian Tobias Schandinat Cc: Ryan Mallon Cc: Damien Cassou --- drivers/video/ep93xx-fb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/vi

[PATCH 1/3] backlight: ep93xx_bl: fix section mismatch

2013-03-15 Thread H Hartley Sweeten
Remove the __init tag from ep93xxbl_probe() to fix the section mismatch warning. Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Richard Purdie Cc: Florian Tobias Schandinat --- drivers/video/backlight/ep93xx_bl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 3/3] misc: ep93xx_pwm.c: fix section mismatch and use module_platform_driver

2013-03-15 Thread H Hartley Sweeten
Remove the __init tags from the ep93xx_pwm_probe() and ep93xx_pwm_remove() functions to fix the section mismatch warnings. Use module_platform_driver() to remove the init/exit boilerplate. Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Arnd Bergmann Cc: Greg Kroah-Hartman --- drivers

[PATCH 0/3] cleanup some arm/ep93xx drivers

2013-03-15 Thread H Hartley Sweeten
Fix a couple section mismatch warnings and convert two of the ep93xx drivers to use module_platform_driver. H Hartley Sweeten (3):   backlight: ep93xx_bl: fix section mismatch   video: ep93xx-fb.c: fix section mismatch and use module_platform_driver   misc: ep93xx_pwm.c: fix section mismatch

[PATCH 2/3] video: ep93xx-fb.c: fix section mismatch and use module_platform_driver

2013-03-15 Thread H Hartley Sweeten
Remove the __init tags from the ep93xxfb_calc_fbsize() and ep93xxfb_alloc_videomem() functions to fix the section mismatch warnings. Use module_platform_driver() to remove the init/exit boilerplate. Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Florian Tobias Schandinat --- drivers

RE: [PATCH 1/3] backlight: ep93xx_bl: fix section mismatch

2013-03-18 Thread H Hartley Sweeten
On Friday, March 15, 2013 7:20 PM, Ryan Mallon wrote: > On 16/03/13 12:03, H Hartley Sweeten wrote: > >> Remove the __init tag from ep93xxbl_probe() to fix the section >> mismatch warning. >> >> Signed-off-by: H Hartley Sweeten >> Cc: Ryan Mallon >>

RE: [PATCH] Staging: comedi: serial2002: fixed consistent spacing issue

2013-03-20 Thread H Hartley Sweeten
On Wednesday, March 20, 2013 9:04 AM, Joe Perches wrote: > On Wed, 2013-03-20 at 15:29 +, Al Viro wrote: >> On Wed, Mar 20, 2013 at 03:47:53PM +0300, Dan Carpenter wrote: >> >>> The original code here needs to broken up into functions so it isn't >>> squashed up against the 80 character

RE: [PATCH 2/2] misc: ep93xx_pwm: remove unnecessary platform_set_drvdata()

2013-05-13 Thread H Hartley Sweeten
s not needed to manually clear the device driver data to NULL. > > Signed-off-by: Jingoo Han > --- > drivers/misc/ep93xx_pwm.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Reviewed-by: H Hartley Sweeten -- To unsubscribe from this list: send the line "unsubscribe linux-

RE: [PATCH 08/10] staging/xgifb: Remove unnecessary bitshifts in XGI_SetCRT1ModeRegs

2013-02-04 Thread H Hartley Sweeten
On Monday, February 04, 2013 5:59 AM, Dan Carpenter wrote: > On Sun, Feb 03, 2013 at 10:54:37PM +0100, Peter Huewe wrote: >> Since data can only be 0x, 0x0035 or 0x0048 we can simply skip the >> bit shifting and masking as data & 0xFF is always equal to data and >> data & 0xFF00 is always 0.

[PATCH 01/11] pcmcia/ds.h: introduce helper for pcmcia_driver module boilerplate

2013-02-06 Thread H Hartley Sweeten
Introduce the module_pcmcia_driver() macro which is a convenience macro for pcmcia driver modules. It is intended to be used by pcmcia drivers with init/exit sections that do nothing but register/unregister the pcmcia driver. Signed-off-by: H Hartley Sweeten --- include/pcmcia/ds.h | 12

[PATCH 00/11] cleanup pcmcia driver module boilerplate

2013-02-06 Thread H Hartley Sweeten
Introduce a new helper macro to remove the module boilerplate code in pcmcia drivers. Use the new macro throughout the tree where possible. H Hartley Sweeten (11): pcmcia/ds.h: introduce helper for pcmcia_driver module boilerplate drivers/ata: use module_pcmcia_driver() in pcmcia drivers

[PATCH 03/11] drivers/bluetooth: use module_pcmcia_driver() in pcmcia drivers

2013-02-06 Thread H Hartley Sweeten
Use the new module_pcmcia_driver() macro to remove the boilerplate module init/exit code in the pcmcia drivers. Signed-off-by: H Hartley Sweeten --- drivers/bluetooth/bluecard_cs.c | 15 +-- drivers/bluetooth/bt3c_cs.c | 15 +-- drivers/bluetooth/btuart_cs.c | 15

[PATCH 02/11] drivers/ata: use module_pcmcia_driver() in pcmcia drivers

2013-02-06 Thread H Hartley Sweeten
Use the new module_pcmcia_driver() macro to remove the boilerplate module init/exit code in the pcmcia drivers. Signed-off-by: H Hartley Sweeten --- drivers/ata/pata_pcmcia.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/ata/pata_pcmcia.c b/drivers

[PATCH 04/11] drivers/isdn: use module_pcmcia_driver() in pcmcia drivers

2013-02-06 Thread H Hartley Sweeten
Use the new module_pcmcia_driver() macro to remove the boilerplate module init/exit code in the pcmcia drivers. Signed-off-by: H Hartley Sweeten --- drivers/isdn/hardware/avm/avm_cs.c | 14 +- drivers/isdn/hisax/avma1_cs.c | 14 +- drivers/isdn/hisax/elsa_cs.c

[PATCH 07/11] drivers/parport: use module_pcmcia_driver() in pcmcia drivers

2013-02-06 Thread H Hartley Sweeten
Use the new module_pcmcia_driver() macro to remove the boilerplate module init/exit code in the pcmcia drivers. Signed-off-by: H Hartley Sweeten --- drivers/parport/parport_cs.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/parport/parport_cs.c b

[PATCH 08/11] drivers/scsi: use module_pcmcia_driver() in pcmcia drivers

2013-02-06 Thread H Hartley Sweeten
Use the new module_pcmcia_driver() macro to remove the boilerplate module init/exit code in the pcmcia drivers. Signed-off-by: H Hartley Sweeten Cc: "Juergen E. Fischer" Cc: "James E.J. Bottomley" Cc: YOKOTA Hiroshi Cc: linux-s...@vger.kernel.org --- drivers/scsi/pcmcia

[PATCH 11/11] sound/pcmcia: use module_pcmcia_driver() in pcmcia drivers

2013-02-06 Thread H Hartley Sweeten
Use the new module_pcmcia_driver() macro to remove the boilerplate module init/exit code in the pcmcia drivers. Signed-off-by: H Hartley Sweeten --- sound/pcmcia/pdaudiocf/pdaudiocf.c | 15 +-- sound/pcmcia/vx/vxpocket.c | 14 +- 2 files changed, 2 insertions

[PATCH 06/11] drivers/net: use module_pcmcia_driver() in pcmcia drivers

2013-02-06 Thread H Hartley Sweeten
Use the new module_pcmcia_driver() macro to remove the boilerplate module init/exit code in the pcmcia drivers. Add a comment in drivers/net/wireless/b43/pcmcia.c about why that driver does not use the new macro. Signed-off-by: H Hartley Sweeten --- drivers/net/arcnet/com20020_cs.c

[PATCH 05/11] drivers/mmc: use module_pcmcia_driver() in pcmcia drivers

2013-02-06 Thread H Hartley Sweeten
Use the new module_pcmcia_driver() macro to remove the boilerplate module init/exit code in the pcmcia drivers. Signed-off-by: H Hartley Sweeten --- drivers/mmc/host/sdricoh_cs.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/mmc/host

[PATCH 09/11] drivers/tty: use module_pcmcia_driver() in pcmcia drivers

2013-02-06 Thread H Hartley Sweeten
Use the new module_pcmcia_driver() macro to remove the boilerplate module init/exit code in the pcmcia drivers. Signed-off-by: H Hartley Sweeten Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: linux-ser...@vger.kernel.org --- drivers/tty/serial/8250/serial_cs.c | 14 +- 1 file changed

[PATCH 10/11] drivers/usb: use module_pcmcia_driver() in pcmcia drivers

2013-02-06 Thread H Hartley Sweeten
Use the new module_pcmcia_driver() macro to remove the boilerplate module init/exit code in the pcmcia drivers. Signed-off-by: H Hartley Sweeten Cc: Greg Kroah-Hartman Cc: linux-...@vger.kernel.org --- drivers/usb/host/sl811_cs.c | 15 +-- 1 file changed, 1 insertion(+), 14

RE: [PATCH -next] staging: comedi: ISA DMA drivers should depend on ISA_DMA_API

2013-01-30 Thread H Hartley Sweeten
patch to enable comedi for all architectures... :-) Reviewed-by: H Hartley Sweeten

RE: [Q]staging/comedi: Considation of *_find_boardinfo possible?

2013-01-30 Thread H Hartley Sweeten
On Wednesday, January 30, 2013 4:04 AM, Ian Abbott wrote: > One way is to enumerate the possible indices of the custom board array > as a set of enum constants, initialize the custom board array using > designated element initializers (indexed by the enum constants) and > include the same enum

RE: [PATCH 15/21] staging: comedi/dawboard2000: use mdelay for large delays

2013-04-23 Thread H Hartley Sweeten
ion that does not rely on delaying the work. > > Signed-off-by: Arnd Bergmann > Cc: H Hartley Sweeten > Cc: Ian Abbott > Cc: Greg Kroah-Hartman Reviewed-by: H Hartley Sweeten Thanks, Hartley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in th

RE: [PATCH 12/12] staging: COMEDI should depend on HAS_DMA

2013-05-09 Thread H Hartley Sweeten
On Thursday, May 09, 2013 2:05 PM, Geert Uytterhoeven wrote: > If NO_DMA=y: > > ERROR: "dma_free_coherent" [drivers/staging/comedi/comedi.ko] undefined! > ERROR: "dma_alloc_coherent" [drivers/staging/comedi/comedi.ko] undefined! > > Signed-off-by: Geert Uytterhoeven > Cc: Ian Abbott > Cc: Greg

[PATCH] scsi: pcmcia: nsp_cs: remove module init/exit function prototypes

2013-04-15 Thread H Hartley Sweeten
This driver now uses the module_pcmcia_driver() macro to supply the init/exit code. The nsp_cs_{init,exit} prototypes should be removed. Reported-by: kbuild test robot Signed-off-by: H Hartley Sweeten Cc: YOKOTA Hiroshi Cc: "James E.J. Bottomley" Cc: Greg Kroah-Hartman C

[PATCH] pwm: add ep93xx PWM support

2013-10-14 Thread H Hartley Sweeten
Remove the non-standard EP93xx pwm driver in drivers/misc and add a new driver for the PWM chips on the EP93xx platforms based on the PWM framework. These PWM chips each support 1 PWM channel with programmable duty cycle, frequency, and polarity inversion. Signed-off-by: H Hartley Sweeten Cc

[PATCH] usb: ohci: remove ep93xx bus glue platform driver

2013-10-14 Thread H Hartley Sweeten
Convert ep93xx to use the OHCI platform driver and remove the ohci-ep93xx bus glue driver. Signed-off-by: H Hartley Sweeten Cc: Alan Stern Cc: Greg Kroah-Hartman Cc: Ryan Mallon --- arch/arm/mach-ep93xx/clock.c | 2 +- arch/arm/mach-ep93xx/core.c| 45 +- drivers/usb/host

[PATCH 2/2 v5] usb: ohci: remove ep93xx bus glue platform driver

2013-10-21 Thread H Hartley Sweeten
Convert ep93xx to use the OHCI platform driver and remove the ohci-ep93xx bus glue driver. Enable CONFIG_OHCI_HCD_PLATFORM in the ep93xx_defconfig so that USB is still enabled by default on the EP93xx platform. Signed-off-by: H Hartley Sweeten Acked-by: Alan Stern Cc: Ryan Mallon Cc: Lennert

[PATCH] ASoC: ep93xx: fix build of ep93xx-ac97.c

2013-07-19 Thread H Hartley Sweeten
the member 'port'. Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Lars-Peter Clausen Cc: Mark Brown Cc: Liam Girdwood Cc: Jaroslav Kysela Cc: Takashi Iwai --- sound/soc/cirrus/ep93xx-ac97.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/cirrus/ep93xx-ac97

[PATCH 0/8] spi: spi-ep93xx: tidy up and convert to queued driver infrastructure

2013-06-28 Thread H Hartley Sweeten
Do a bit of housecleaning in this driver and convert it to use the SPI queued driver infrastructure. H Hartley Sweeten (8): spi: spi-ep93xx: use read,write instead of __raw_* variants spi: spi-ep93xx: use bits_per_word_mask spi: spi-ep93xx: always handle transfer specific settings spi

[PATCH 1/8] spi: spi-ep93xx: use read,write instead of __raw_* variants

2013-06-28 Thread H Hartley Sweeten
The memory resource used by this driver is ioremap()'d and the normal read,write calls can be used instead of the __raw_* variants. Remove the inline read,write helpers and just do the read,write directly in the callers. Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Mika Westerberg Cc

[PATCH 2/8] spi: spi-ep93xx: use bits_per_word_mask

2013-06-28 Thread H Hartley Sweeten
This driver supports 16 to 4 bits per work. Set the bits_per_word_mask to allows the spi core to handle validation. Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Mika Westerberg Cc: Mark Brown Cc: Grant Likely --- drivers/spi/spi-ep93xx.c | 11 +-- 1 file changed, 1 insertion

[PATCH 3/8] spi: spi-ep93xx: always handle transfer specific settings

2013-06-28 Thread H Hartley Sweeten
for each transfer in the message. Remove the redundant ep93xx_spi_chp_setup() in ep93xx_spi_process_transfer() which just initializes the hardware to the "default" based on the SPI device. Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Mika Westerberg Cc: Mark Brown Cc: Gr

[PATCH 4/8] spi: spi-ep93xx: remove bits_per_word() helper

2013-06-28 Thread H Hartley Sweeten
This inline helper function is only used to determine the bus width of the current transfer (8 or 16 bit). Add a bool flag to the private structure and set it appropriately for each transfer. Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Mika Westerberg Cc: Mark Brown Cc: Grant Likely

[PATCH 5/8] spi: spi-ep93xx: remove 'dss' from per chip private data

2013-06-28 Thread H Hartley Sweeten
tup() in ep93xx_spi_process_transfer() and remove 'dss' from the per chip private data. Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Mika Westerberg Cc: Mark Brown Cc: Grant Likely --- drivers/spi/spi-ep93xx.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/driv

[PATCH 6/8] spi: spi-ep93xx: don't bother calculating the divisors in ep93xx_spi_setup()

2013-06-28 Thread H Hartley Sweeten
The divisors needed to generate the SPI clock are calculated per transfer based on the t->speed_hz. There is no reason to calculate them in ep93xx_spi_setup(). Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Mika Westerberg Cc: Mark Brown Cc: Grant Likely --- drivers/spi/spi-ep93x

[PATCH 7/8] spi: spi-ep93xx: move the clock divider calcs into ep93xx_spi_chip_setup()

2013-06-28 Thread H Hartley Sweeten
all into ep93xx_spi_chip_setup() and return the dividers thru pointers. Remove the divider values from the per chip data structure. Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Mika Westerberg Cc: Mark Brown Cc: Grant Likely --- drivers/spi/spi-ep93xx.c |

[PATCH 8/8] spi: spi-ep93xx: convert to the queued driver infrastructure

2013-06-28 Thread H Hartley Sweeten
The SPI core provides infrastructure for standard message queueing. Use that instead of handling it in the driver. Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Mika Westerberg Cc: Mark Brown Cc: Grant Likely --- drivers/spi/spi-ep93xx.c | 164

Q: mmc au size

2013-06-28 Thread H Hartley Sweeten
Hello Chris, I have a question concerning the "au" size of a SD Card. I have an old Kingston 64MB SD-Card and lately I have noticed this kernel message when I use the card: mmc0: SD Status: Invalid Allocation Unit size. This is due to the following commit: commit

RE: [PATCH 3/8] spi: spi-ep93xx: always handle transfer specific settings

2013-06-28 Thread H Hartley Sweeten
On Friday, June 28, 2013 4:18 PM, Ryan Mallon wrote: > On 29/06/13 04:43, H Hartley Sweeten wrote: >> __spi_async(), which starts every SPI message transfer, initializes >> the bits_per_word and max speed for every transfer in the message. >> Since

Q: mmc au size

2013-06-28 Thread H Hartley Sweeten
Hello all, I have a question concerning the "au" size of a SD Card. I have an old Kingston 64MB SD-Card and lately I have noticed this kernel message when I use the card: mmc0: SD Status: Invalid Allocation Unit size. This is due to the following commit: commit

[PATCH 0/4] usb: ohci-ep93xx: do a bit of house cleaning

2013-06-28 Thread H Hartley Sweeten
Tidy up this driver a bit. H Hartley Sweeten (4): usb: ohci-ep93xx: use devm_ioremap_resource() usb: ohci-ep93xx: use platform_get_irq() usb: ohci-ep93xx: use devm_clk_get() usb: ohci-ep93xx: tidy up ohci_hcd_ep93xx_drv_probe() drivers/usb/host/ohci-ep93xx.c | 60

[PATCH 1/4] usb: ohci-ep93xx: use devm_ioremap_resource()

2013-06-28 Thread H Hartley Sweeten
Use devm_ioremap_resource() to make the code a bit cleaner and simpler. Signed-off-by: H Hartley Sweeten Cc: Alan Stern Cc: Lennert Buytenhek Cc: Greg Kroah-Hartman --- drivers/usb/host/ohci-ep93xx.c | 35 ++- 1 file changed, 14 insertions(+), 21 deletions

[PATCH 2/4] usb: ohci-ep93xx: use platform_get_irq()

2013-06-28 Thread H Hartley Sweeten
Use platform_get_irq() instead of accessing the platform_device resources directly. Signed-off-by: H Hartley Sweeten Cc: Alan Stern Cc: Lennert Buytenhek Cc: Greg Kroah-Hartman --- drivers/usb/host/ohci-ep93xx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 3/4] usb: ohci-ep93xx: use devm_clk_get()

2013-06-28 Thread H Hartley Sweeten
Use devm_clk_get() to make the code a bit cleaner and simpler. This also fixes a bug where a clk_put() is not done if usb_add_hcd() fails. Signed-off-by: H Hartley Sweeten Cc: Alan Stern Cc: Lennert Buytenhek Cc: Greg Kroah-Hartman --- drivers/usb/host/ohci-ep93xx.c | 4 +--- 1 file changed

[PATCH 4/4] usb: ohci-ep93xx: tidy up ohci_hcd_ep93xx_drv_probe()

2013-06-28 Thread H Hartley Sweeten
Refactor the function a bit to remove the need for the local variable. The extern prototype of usb_disabled() is not needed. Signed-off-by: H Hartley Sweeten Cc: Alan Stern Cc: Lennert Buytenhek Cc: Greg Kroah-Hartman --- drivers/usb/host/ohci-ep93xx.c | 11 +++ 1 file changed, 3

RE: [PATCH v4] pwm: add sysfs interface

2013-06-19 Thread H Hartley Sweeten
On Tuesday, June 11, 2013 12:48 PM, Thierry Reding wrote: > > I'm tempted to take your v5 patch and make a note to clean that up > separately at some point (along with similar changes for the DEBUG_FS > support). Thierry, So you want a v6 of this patch or are you ok with v5? Thanks, Hartley --

RE: [PATCH 2/2] spi: convert drivers to use bits_per_word_mask

2013-05-24 Thread H Hartley Sweeten
return -EINVAL; > } > @@ -1046,6 +1036,7 @@ static int ep93xx_spi_probe(struct platform_device > *pdev) > master->bus_num = pdev->id; > master->num_chipselect = info->num_chipselect; > master->mode_bits = SPI_CPOL | S

[PATCH 00/14] misc/ep93xx_pwm: cleanup driver for conversion to PWM framework

2013-05-24 Thread H Hartley Sweeten
This driver needs to be converted to the new PWM framework. Before converting it clean up all the cruft, H Hartley Sweeten (14): misc/ep93xx_pwm: use managed device resources misc/ep93xx_pwm: use {read,write}* instead of __raw_* versions for io misc/ep93xx_pwm: remove ep93xx_pwm_{write

[PATCH 01/14] misc/ep93xx_pwm: use managed device resources

2013-05-24 Thread H Hartley Sweeten
Use managed device resources to clean up the probe/remove. Signed-off-by: H Hartley Sweeten Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Ryan Mallon Cc: Matthieu Crapet --- drivers/misc/ep93xx_pwm.c | 73 +-- 1 file changed, 20 insertions(+), 53

[PATCH 02/14] misc/ep93xx_pwm: use {read,write}* instead of __raw_* versions for io

2013-05-24 Thread H Hartley Sweeten
The mmio_base is an ioremap'ed memory resource. The normal memory io functions should be used not the __raw_* versions. Signed-off-by: H Hartley Sweeten Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Ryan Mallon Cc: Matthieu Crapet --- drivers/misc/ep93xx_pwm.c | 4 ++-- 1 file changed, 2

[PATCH 03/14] misc/ep93xx_pwm: remove ep93xx_pwm_{write,read}l() inline functions

2013-05-24 Thread H Hartley Sweeten
These are simple wrappers around writel() and readl(). Remove them. Signed-off-by: H Hartley Sweeten Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Ryan Mallon Cc: Matthieu Crapet --- drivers/misc/ep93xx_pwm.c | 30 +- 1 file changed, 9 insertions(+), 21 deletions

[PATCH 05/14] misc/ep93xx_pwm: remove ep93xx_pwm_write_dc() inline function

2013-05-24 Thread H Hartley Sweeten
This is a simple wrapper around writel(), remove it. Signed-off-by: H Hartley Sweeten Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Ryan Mallon Cc: Matthieu Crapet --- drivers/misc/ep93xx_pwm.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/misc

[PATCH 04/14] misc/ep93xx_pwm: remove ep93xx_pwm_write_tc() inline function

2013-05-24 Thread H Hartley Sweeten
This is a simple wrapper around writel(), remove it. Signed-off-by: H Hartley Sweeten Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Ryan Mallon Cc: Matthieu Crapet --- drivers/misc/ep93xx_pwm.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/misc

[PATCH 06/14] misc/ep93xx_pwm: remove ep93xx_pwm_enable() inline function

2013-05-24 Thread H Hartley Sweeten
This is a simple wrapper around writel(), remove it. Signed-off-by: H Hartley Sweeten Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Ryan Mallon Cc: Matthieu Crapet --- drivers/misc/ep93xx_pwm.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/misc

[PATCH 07/14] misc/ep93xx_pwm: remove ep93xx_pwm_disable() inline function

2013-05-24 Thread H Hartley Sweeten
This is a simple wrapper around writel(), remove it. Signed-off-by: H Hartley Sweeten Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Ryan Mallon Cc: Matthieu Crapet --- drivers/misc/ep93xx_pwm.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/misc

[PATCH 08/14] misc/ep93xx_pwm: remove ep93xx_pwm_invert() inline function

2013-05-24 Thread H Hartley Sweeten
This is a simple wrapper around writel(), remove it. Signed-off-by: H Hartley Sweeten Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Ryan Mallon Cc: Matthieu Crapet --- drivers/misc/ep93xx_pwm.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/misc

[PATCH 11/14] misc/ep93xx_pwm: remove ep93xx_pwm_is_enabled() inline function

2013-05-24 Thread H Hartley Sweeten
This is a simple wrapper around readl(), remove it. Signed-off-by: H Hartley Sweeten Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Ryan Mallon Cc: Matthieu Crapet --- drivers/misc/ep93xx_pwm.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/misc

[PATCH 10/14] misc/ep93xx_pwm: remove ep93xx_pwm_read_tc() inline function

2013-05-24 Thread H Hartley Sweeten
This is a simple wrapper around readl(), remove it. Signed-off-by: H Hartley Sweeten Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Ryan Mallon Cc: Matthieu Crapet --- drivers/misc/ep93xx_pwm.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/misc

[PATCH 12/14] misc/ep93xx_pwm: remove ep93xx_pwm_is_inverted() inline function

2013-05-24 Thread H Hartley Sweeten
This is a simple wrapper around readl(), remove it. Signed-off-by: H Hartley Sweeten Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Ryan Mallon Cc: Matthieu Crapet --- drivers/misc/ep93xx_pwm.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/misc

[PATCH 14/14] misc/ep93xx_pwm: use kstrtol instead of strict_strtol

2013-05-24 Thread H Hartley Sweeten
strict_strtol is deprecated in favor of kstrtol. Signed-off-by: H Hartley Sweeten Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Ryan Mallon Cc: Matthieu Crapet --- drivers/misc/ep93xx_pwm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/misc/ep93xx_pwm.c b

[PATCH 09/14] misc/ep93xx_pwm: remove ep93xx_pwm_normal() inline function

2013-05-24 Thread H Hartley Sweeten
This is a simple wrapper around writel(), remove it. Signed-off-by: H Hartley Sweeten Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Ryan Mallon Cc: Matthieu Crapet --- drivers/misc/ep93xx_pwm.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/misc

[PATCH 13/14] misc/ep93xx_pwm: use module_platform_driver()

2013-05-24 Thread H Hartley Sweeten
Add the (*probe) function to the platform_driver and use the module_platform_driver() macro to initialize the module. Remove the unnecessary __init and __exit tags. Signed-off-by: H Hartley Sweeten Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Ryan Mallon Cc: Matthieu Crapet --- drivers

RE: [PATCH 02/14] misc/ep93xx_pwm: use {read,write}* instead of __raw_* versions for io

2013-05-27 Thread H Hartley Sweeten
On Monday, May 27, 2013 8:18 AM, Arnd Bergmann wrote: > On Saturday 25 May 2013, H Hartley Sweeten wrote: >> @@ -42,13 +42,13 @@ struct ep93xx_pwm { >> static inline void ep93xx_pwm_writel(struct ep93xx_pwm *pwm, >> unsigned int val, unsigned int off) >>

RE: [PATCH 00/14] misc/ep93xx_pwm: cleanup driver for conversion to PWM framework

2013-05-27 Thread H Hartley Sweeten
On Monday, May 27, 2013 8:20 AM, Arnd Bergmann wrote: > On Saturday 25 May 2013, H Hartley Sweeten wrote: >> This driver needs to be converted to the new PWM framework. >> >> Before converting it clean up all the cruft, >> >> H Hartley Sweeten (14): >>

[PATCH] pwm: add sysfs interface

2013-05-29 Thread H Hartley Sweeten
| |-- duty_ns(r/w) duty cycle (in nanoseconds) | |-- enable (r/w) enable/disable PWM | |-- period_ns (r/w) period (in nanoseconds) | `-- polarity (r/w) polarity of PWM `-- unexport (w/o) return a PWM to the kernel Signed-off-by: H Hartley Sweeten Cc

RE: [PATCH 00/14] misc/ep93xx_pwm: cleanup driver for conversion to PWM framework

2013-05-29 Thread H Hartley Sweeten
On Tuesday, May 28, 2013 4:42 AM, Lars Poeschel wrote: > On Tuesday 28 May 2013 at 13:00:12, Thierry Reding wrote: >> I've added Lars Poeschel on Cc, who's done some work on a sysfs >> interface for the PWM subsystem already. It's undergone some review >> already[0] and I think he's working on a

RE: [PATCH] pwm: add sysfs interface

2013-05-30 Thread H Hartley Sweeten
On Wednesday, May 29, 2013 7:02 PM, Ryan Mallon wrote: > On 30/05/13 07:08, H Hartley Sweeten wrote: >> Add a simple sysfs interface to the PWM framework. >> >> /sys/class/pwm/ >> `-- pwmchipN/ for each PWM chip >> |-- export (w/

[PATCH v2] pwm: add sysfs interface

2013-05-30 Thread H Hartley Sweeten
to the kernel Signed-off-by: H Hartley Sweeten Cc: Thierry Reding Cc: Lars Poeschel Cc: Ryan Mallon Cc: Rob Landley --- v2: * add API documentation and update Documentation/pwm.txt * fix some issues pointed out by Ryan Mallon * add the pwm attributes to dev.groups so they are created

RE: [PATCH v2] pwm: add sysfs interface

2013-05-30 Thread H Hartley Sweeten
On Thursday, May 30, 2013 12:30 PM, H Hartley Sweeten wrote: > Add a simple sysfs interface to the generic PWM framework. > > /sys/class/pwm/ > `-- pwmchipN/ for each PWM chip > |-- export (w/o) ask the kernel to export a PWM channel > |-- n

[PATCH v3] pwm: add sysfs interface

2013-05-30 Thread H Hartley Sweeten
Signed-off-by: H Hartley Sweeten Cc: Thierry Reding Cc: Lars Poeschel Cc: Ryan Mallon Cc: Rob Landley --- v3: * fix an issue with the export/unexport of the PWM chip v2: * add API documentation and update Documentation/pwm.txt * fix some issues pointed out by Ryan Mallon * add the pwm

RE: [PATCH 1/7] input: ep93xx_keypad: Pass correct pointer to free_irq()

2013-05-20 Thread H Hartley Sweeten
On Monday, May 20, 2013 7:51 AM, Lars-Peter Clausen wrote: > free_irq() expects the same pointer that was passed to request_irq(), > otherwise > the IRQ is not freed. > Cc: H Hartley Sweeten > Signed-off-by: Lars-Peter Clausen > --- > drivers/input/keyboard/ep93xx_k

RE: [-next] staging/comedi regressions

2013-03-14 Thread H Hartley Sweeten
On Thursday, March 14, 2013 12:33 PM, Geert Uytterhoeven wrote: > On Tue, Mar 12, 2013 at 11:21 PM, Greg Kroah-Hartman > wrote: >> On Tue, Mar 12, 2013 at 11:13:50PM +0100, Geert Uytterhoeven wrote: >>> m68k/allmodconfig: >>> >>> drivers/staging/comedi/drivers/ni_atmio.c: In function >>>

RE: linux-next: build failure after merge of the final tree (staging tree related))

2013-04-24 Thread H Hartley Sweeten
On Wednesday, April 24, 2013 12:56 AM, Stephen Rothwell wrote: > Hi all, > > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: Ugh.. powerpc probably has CONFIG_ISA_DMA_API but not CONFIG_VIRT_TO_BUS. I'm looking for a fix now. Regards, Hartley

RE: linux-next: build failure after merge of the final tree (staging tree related))

2013-04-24 Thread H Hartley Sweeten
On Wednesday, April 24, 2013 12:56 AM, Stephen Rothwell wrote: > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/staging/comedi/drivers/ni_labpc.c: In function 'labpc_ai_cmd': > drivers/staging/comedi/drivers/ni_labpc.c:980:9: error:

RE: [PATCH 3/8] spi: spi-ep93xx: always handle transfer specific settings

2013-07-01 Thread H Hartley Sweeten
On Monday, July 01, 2013 3:28 AM, Mark Brown wrote: > On Fri, Jun 28, 2013 at 11:43:34AM -0700, H Hartley Sweeten wrote: >> __spi_async(), which starts every SPI message transfer, initializes >> the bits_per_word and max speed for every transfer in the message. >> Since

RE: [PATCH 1/8] spi: spi-ep93xx: use read,write instead of __raw_* variants

2013-07-01 Thread H Hartley Sweeten
On Monday, July 01, 2013 3:58 AM, Mark Brown wrote: > On Sat, Jun 29, 2013 at 09:15:09AM +1000, Ryan Mallon wrote: >> On 29/06/13 04:42, H Hartley Sweeten wrote: > >>> -static inline u8 >>> -ep93xx_spi_read_u8(const struct ep93xx_spi *spi, u16 reg) >>> -{ &g

RE: [PATCH 2/8] spi: spi-ep93xx: use bits_per_word_mask

2013-07-01 Thread H Hartley Sweeten
On Sunday, June 30, 2013 9:14 AM, Mika Westerberg wrote: > On Fri, Jun 28, 2013 at 11:43:07AM -0700, H Hartley Sweeten wrote: >> This driver supports 16 to 4 bits per work. Set the bits_per_word_mask >> to allows the spi core to handle validation. >> >> Signed-off-b

RE: [PATCH 2/8] spi: spi-ep93xx: use bits_per_word_mask

2013-07-01 Thread H Hartley Sweeten
On Monday, July 01, 2013 11:23 AM, H Hartley Sweeten wrote: > On Sunday, June 30, 2013 9:14 AM, Mika Westerberg wrote: >> Please use SPI_BPW_RANGE_MASK(4, 16) here. > > I thought there was a macro for this, just couldn't find it. I'll fix this. Doh... This patch is already in li

[PATCH v2 0/4] usb: ohci-ep93xx: do a bit of housecleaning

2013-07-01 Thread H Hartley Sweeten
Tidy up this driver a bit. v2: redo patch 4 based on suggestions from Alan Stern H Hartley Sweeten (4): usb: ohci-ep93xx: use devm_ioremap_resource() usb: ohci-ep93xx: use platform_get_irq() usb: ohci-ep93xx: use devm_clk_get() usb: ohci-ep93xx: tidy up driver (*probe) and (*remove

[PATCH v2 1/4] usb: ohci-ep93xx: use devm_ioremap_resource()

2013-07-01 Thread H Hartley Sweeten
Use devm_ioremap_resource() to make the code a bit cleaner and simpler. Signed-off-by: H Hartley Sweeten Acked-by: Alan Stern Cc: Lennert Buytenhek Cc: Greg Kroah-Hartman --- drivers/usb/host/ohci-ep93xx.c | 35 ++- 1 file changed, 14 insertions(+), 21

[PATCH v2 4/4] usb: ohci-ep93xx: tidy up driver (*probe) and (*remove)

2013-07-01 Thread H Hartley Sweeten
and simply call clk_enable() and clk_disable() directly. The extra level of redirection does not add any clarity. Signed-off-by: H Hartley Sweeten Cc: Alan Stern Cc: Lennert Buytenhek Cc: Greg Kroah-Hartman --- drivers/usb/host/ohci-ep93xx.c | 128 + 1

[PATCH v2 2/4] usb: ohci-ep93xx: use platform_get_irq()

2013-07-01 Thread H Hartley Sweeten
Use platform_get_irq() instead of accessing the platform_device resources directly. Signed-off-by: H Hartley Sweeten Acked-by: Alan Stern Cc: Lennert Buytenhek Cc: Greg Kroah-Hartman --- drivers/usb/host/ohci-ep93xx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[PATCH v2 3/4] usb: ohci-ep93xx: use devm_clk_get()

2013-07-01 Thread H Hartley Sweeten
Use devm_clk_get() to make the code a bit cleaner and simpler. This also fixes a bug where a clk_put() is not done if usb_add_hcd() fails. Signed-off-by: H Hartley Sweeten Acked-by: Alan Stern Cc: Lennert Buytenhek Cc: Greg Kroah-Hartman --- drivers/usb/host/ohci-ep93xx.c | 4 +--- 1 file

[PATCH v2 00/11] spi: spi-ep93xx: tidy up and convert to queued driver infrastructure

2013-07-02 Thread H Hartley Sweeten
here only for completeness. H Hartley Sweeten (11): spi: spi-ep93xx: always handle transfer specific settings spi: spi-ep93xx: use read,write instead of __raw_* variants spi: spi-ep93xx: remove bits_per_word() helper spi: spi-ep93xx: get platform resources early in (*probe) spi: spi

[PATCH v2 01/11] spi: spi-ep93xx: always handle transfer specific settings

2013-07-02 Thread H Hartley Sweeten
for each transfer in the message. Remove the redundant ep93xx_spi_chp_setup() in ep93xx_spi_process_transfer() which just initializes the hardware to the "default" based on the SPI device. Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Mika Westerberg Cc: Mark Brown Cc: Gr

[PATCH v2 02/11] spi: spi-ep93xx: use read,write instead of __raw_* variants

2013-07-02 Thread H Hartley Sweeten
The memory resource used by this driver is ioremap()'d and the normal read,write calls can be used instead of the __raw_* variants. Also, remove the inline tag on the helper functions and let the compiler decide if they are inlined. Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Mika

[PATCH v2 03/11] spi: spi-ep93xx: remove bits_per_word() helper

2013-07-02 Thread H Hartley Sweeten
Check t->bits_per_word directly and remove the inline helper function. Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Mika Westerberg Cc: Mark Brown Cc: Grant Likely --- drivers/spi/spi-ep93xx.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --

[PATCH v2 05/11] spi: spi-ep93xx: use devm_clk_get()

2013-07-02 Thread H Hartley Sweeten
Use devm_clk_get() so that the clk_put() happens automatically when the last reference to this driver is dropped. Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Mika Westerberg Cc: Mark Brown Cc: Grant Likely --- drivers/spi/spi-ep93xx.c | 9 +++-- 1 file changed, 3 insertions

[PATCH v2 04/11] spi: spi-ep93xx: get platform resources early in (*probe)

2013-07-02 Thread H Hartley Sweeten
Get the platform resources early in the (*probe) to minimize the number of goto's in the error path. Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Mika Westerberg Cc: Mark Brown Cc: Grant Likely --- drivers/spi/spi-ep93xx.c | 26 -- 1 file changed, 12

[PATCH v2 07/11] spi: spi-ep93xx: remove 'dss' from per chip private data

2013-07-02 Thread H Hartley Sweeten
tup() in ep93xx_spi_process_transfer() and remove 'dss' from the per chip private data. Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Mika Westerberg Cc: Mark Brown Cc: Grant Likely --- drivers/spi/spi-ep93xx.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/

[PATCH v2 08/11] spi: spi-ep93xx: don't bother calculating the divisors in ep93xx_spi_setup()

2013-07-02 Thread H Hartley Sweeten
The divisors needed to generate the SPI clock are calculated per transfer based on the t->speed_hz. There is no reason to calculate them in ep93xx_spi_setup(). Signed-off-by: H Hartley Sweeten Acked-by: Mika Westerberg Cc: Ryan Mallon Cc: Mark Brown Cc: Grant Likely --- drivers/spi/

[PATCH v2 09/11] spi: spi-ep93xx: move the clock divider calcs into ep93xx_spi_chip_setup()

2013-07-02 Thread H Hartley Sweeten
all into ep93xx_spi_chip_setup() and return the dividers thru pointers. Remove the divider values from the per chip data structure. Signed-off-by: H Hartley Sweeten Acked-by: Mika Westerberg Cc: Ryan Mallon Cc: Mark Brown Cc: Grant Likely --- drivers/spi/spi-ep93xx.c |

<    1   2   3   4   5   6   7   8   9   10   >