On Monday, November 12, 2012 11:41 AM, Bjorn Helgaas wrote:
> On Mon, Nov 12, 2012 at 9:18 AM, H Hartley Sweeten wrote:
>> Does anyone know what the Kconfig option VIRT_TO_BUS does?
>> There are a number of "depends on" that option but it does not
>> seem to directl
H Hartley Sweeten (4):
staging: comedi: comedi_parport: remove devpriv macro
staging: comedi: comedi_parport: cleanup dev->board_name
staging: comedi: comedi_parport: cleanup 'attach' printk's
staging: comedi: comedi_parport: remove the printk noise
drivers/staging/comedi/driv
This macro relies on a local variable having a specific name, Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_parport.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers
Use the 'dev->driver->driver_name' for the 'dev->board_name'. And use
the 'dev->board_name' for the resource name passed to request_region
and request_irq.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_parport.c |
Convert the printk messages in the 'attach' to dev_printk messages.
Consolidate the attach message into one message after the device
is attached.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_parport.c | 12 ++--
1
Remove the function trace message in parport_intr_cancel() and the
"bogus irq..." message is parport_interrupt(). They are just added
noise.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_parport.c | 6 +-
1 file
On Monday, August 20, 2012 2:49 PM, Dan Carpenter wrote:
> On Fri, Aug 17, 2012 at 06:17:38PM -0700, H Hartley Sweeten wrote:
>> +if (this_board->n_diochan) {
>> +s = dev->subdevices + subdev;
>
> This pointer math sucks still... I feel like the unread
H Hartley Sweeten (3):
staging: comedi: comedi_test: remove devpriv macro
staging: comedi: comedi_test: remove boardinfo
staging: comedi: comedi_test: convert attach message to dev_info
drivers/staging/comedi/drivers/comedi_test.c | 61
1 file changed, 27
This macro relies on a local variable having a specific name. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_test.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/drivers
the driver simple.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_test.c | 31 +---
1 file changed, 5 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/comedi/drivers/comedi_test.c
b/drivers/stag
Convert the 'attach' message from a printk to a dev_info.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_test.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers
On Monday, August 20, 2012 2:51 PM, H Hartley Sweeten wrote:
> On Monday, August 20, 2012 2:49 PM, Dan Carpenter wrote:
>> On Fri, Aug 17, 2012 at 06:17:38PM -0700, H Hartley Sweeten wrote:
>>> + if (this_board->n_diochan) {
>>> + s = dev->subdevices
>wq = create_singlethread_workqueue("ep93xx_spid");
> if (!espi->wq) {
> dev_err(>dev, "unable to create workqueue\n");
> + error = -ENOMEM;
> goto fail_free_dma;
> }
> INIT_WORK(>msg_work, ep93xx_spi_work);
The subdevice pointer math removal patch introduced a build error
in the s626 driver. Fix it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
Not sure how this got thru. The build error did not appear until
I did a clean make.
drivers/staging/comedi/drivers/s626.c
On Thursday, August 09, 2012 8:20 AM, Güngör Erseymen wrote:
> Fix two checkpatch.pl warnings about printk issues by using
> pr_info(...) instead of printk(KERN_INFO, ...).
>
> Signed-off-by: Güngör Erseymen
> ---
> drivers/staging/comedi/drivers/ssv_dnp.c | 4 ++--
> 1 file changed, 2
Update the comedi adl_pci6208 pci driver.
H Hartley Sweeten (4):
staging: comedi: adl_pci6208: use attach_pci callback
staging: comedi: adl_pci6208: add support for the PCI-6216 card
staging: comedi: adl_pci6208: split the digital i/o subdevice
staging: comedi: adl_pci6208: use
Add the boardinfo and pci device table information for the PCI-6216 card.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci6208.c | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git
subdevices the channel number indicates the
actual digital input/output signal.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci6208.c | 78
1 file changed, 44 insertions(+), 34 deletions(-)
diff --git
the pci
bus to find the pci_dev and the need for the pci_dev_put() in the detach.
For aesthetic reasons, rename the local variable 'thisboard' to 'boardinfo'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci6208.c | 78
d doesn't actually tell the real reason why the
call failed. It could have failed either the pci_enable_device()
or the pci_request_regions().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci6208.c | 7 ++-
1 file changed, 2 i
On Monday, August 13, 2012 6:30 PM, Greg KH wrote:
> On Fri, Aug 03, 2012 at 10:28:18AM -0700, H Hartley Sweeten wrote:
>> Currently the ADLink PCI-7230 and PCI-7432 Isolated Digital
>> I/O Boards are supported using two drivers (adl_pci7230 and
>> adl_pci7432). These dri
On Tuesday, August 14, 2012 1:59 AM, Ian Abbott wrote:
> On 2012-08-14 02:36, H Hartley Sweeten wrote:
>> On Monday, August 13, 2012 6:30 PM, Greg KH wrote:
>>> On Fri, Aug 03, 2012 at 10:28:18AM -0700, H Hartley Sweeten wrote:
>>>> Currently the ADLink PCI-7230
->private value as an
unsigned int. On 64-bit builds this results in a warning:
warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
Fix these warnings by casting the void * to an unsigned long.
Signed-off-by: H Hartley Sweeten
Reported-by: Greg Kroah-Hartman
Cc:
Update the dyna_pci10xx driver to use the PCI Pnp auto config mechanism
of the comedi core and remove the unneeded boardinfo code.
H Hartley Sweeten (7):
staging: comedi: dnya_pci10xx: remove thisboard and devpriv macros
staging: comedi: dnya_pci10xx: use attach_pci callback
staging: comedi
These macros rely on local variables having a specific name. Replace
them with local variables where used. Use the comedi_board() helper
to get the thisboard pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 23
bus to find the pci_dev and the
need for the pci_dev_put() in the detach.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 88 +++
1 file changed, 35 insertions(+), 53 deletions(-)
diff --git
The *_bits information in the boardinfo is not used by the driver.
Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/comedi/drivers
-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c
b/drivers/staging/comedi/drivers/dyna_pci10xx.c
ind
The boardinfo code is not needed by this driver. Only one board
type is supported.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 38 ++-
1 file changed, 2 insertions(+), 36 deletions(-)
diff
This define is not used in the driver. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c
b/drivers/staging/comedi
There is only one "boardtype" actually supported by this driver.
The second entry in the boardinfo is a dummy entry that would
result in an unusable device.
Remove the boardinfo fields and just use the open coded values
in the subdevice setup.
Signed-off-by: H Hartley Sweeten
Cc: Ian
Remove a couple of the addi-data files that are either not built under any
configuration or are unnecessary due to code duplication in another file.
H Hartley Sweeten (3):
staging: comedi: addi_apci_all.c: remove unused file
staging: comedi: amcc_s5933_58.h: remove unused file
staging
The Makefile for the comedi subsystem does not compile this file
for any .config selection. This file would allow building one big
driver to support all the addi-data cards.
The addi-data drivers are a big enough mess as-is. Just remove this
file.
Signed-off-by: H Hartley Sweeten
Cc: Iam Abbott
-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/addi_amcc_S5920.c | 195 -
.../comedi/drivers/addi-data/addi_amcc_S5920.h | 27 ---
.../comedi/drivers/addi-data/hwdrv_apci3200.c | 12 +-
3 files changed, 7
Nothing in the comedi subsystem references this header file. It's
actually almost a straight copy of the addi_amcc_s5933.h file anyway.
Just remove the file.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/amcc_s5933_58.h | 453
On Wednesday, July 11, 2012 3:20 AM, Ian Abbott wrote:
> On 2012-07-11 00:36, H Hartley Sweeten wrote:
>> The 'devpriv' macro usage in this driver is holding up other cleanup
>> of the comedi drivers.
>>
>> This patch series removes all the macros used to read/write the
> + readl(devpriv->las0 + LAS0_PACER); /* start pacer */
> return 0;
> }
>
> @@ -1391,8 +1403,9 @@ static int rtd_ai_cancel(struct comedi_device *dev,
> struct comedi_subdevice *s)
> u32 overrun;
> u16 status;
>
> + /* pacer stop source: SOFTWA
to remove some of the unneeded private data variables and to use the
comedi_device iobase variable.
H Hartley Sweeten (30):
staging: comedi: add pci_dev pointer to comedi_device
staging: comedi: adl_pci6208: use comedi_device pci_dev pointer
staging: comedi: adl_pci7230: use comedi_device pci_dev
Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/comedidev.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/comedi/comedidev.h
b/drivers/staging/comedi/comedidev.h
index de8c99c..55f2373 100644
--- a/drivers/staging/comedi/comedidev.h
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci6208.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci7230.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff
The private data is no longer needed by this driver. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci7230.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci7230.c
b
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci7296.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff
The private data is no longer needed by this driver. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci7296.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci7296.c
b
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci7432.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff
The private data is no longer needed by this driver. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci7432.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci7432.c
b
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci8164.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff
The private data is no longer needed by this driver. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci8164.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci8164.c
b
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 25 -
1 file changed, 12 insertions(+), 13
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 31 +++---
1 file changed, 15 insertions(+), 16
Factor the "find pci device" code out of the attach function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidio.c | 56 --
1 file changed, 29 insertions(+), 27 deletions(-)
diff --git
r
the code to remove the need for the 'goto'. Reword the messages
a bit. Also, move the setting of the dev->board_name back into the
attach.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidio.c | 47 --
1
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidio.c | 21 -
1 file changed, 8 insertions(+), 13 deletions
Use the iobase in the comedi_device struct instead of carrying it
in the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidio.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git
The private data is no longer needed by this driver. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidio.c | 23 ---
1 file changed, 23 deletions(-)
diff --git a/drivers/staging/comedi/drivers
Factor the "find pci device" code out of the attach function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/contec_pci_dio.c | 91 +
1 file changed, 49 insertions(+), 42 deletions(-)
diff --git
Cleanup the "find pci device" code to follow the format of the
other comedi pci drivers.
Create local variables for the bus and slot options to clarify the
code. Change the pci ven/dev test to reduce the indent level. Change
the printk into a dev_warn.
Signed-off-by: H Hartley Sweete
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/contec_pci_dio.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions
The private data is no longer needed by this driver. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/contec_pci_dio.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/comedi/drivers
Factor the "find pci device" code out of the attach function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 86 ++-
1 file changed, 44 insertions(+), 42 deletions(-)
diff --git
Cleanup the "find pci device" code to follow the format of the
other comedi pci drivers.
Use for_each_pci_dev() instead of open-coding the for loop. Reorder
and refactor some of the tests to reduce the indent level. Change
the printk's to dev_printk's.
Signed-off-by: H Hartley Sweete
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 25 -
1 file changed, 12 insertions(+), 13
These variables are set during the attach of the device but they are
never read. Just remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git
Use the iobase in the comedi_device struct instead of carrying it
in the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git
Factor the "find pci device" code out of the attach function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ke_counter.c | 46 ++---
1 file changed, 28 insertions(+), 18 deletions(-)
diff --git
s.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ke_counter.c | 58 -
1 file changed, 23 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ke_counter.c
b/drivers/staging/come
Use the pci_dev pointer in the comedi_device struct instead of
carrying it in the private data.
Since the pci_dev pointer was the only variable in the private
data, remove it as well.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers
in Chapter 12:
2) macros that depend on having a local variable with a magic name:
#define FOO(val) bar(index, val)
might look like a good thing, but it's confusing as hell when one reads the
code and it's prone to breakage from seemingly innocent changes.
H Hartley Sweeten (2):
staging: comedi
The macros 'update_dacsr', 'update_adcsr', and 'update_supcsr' all use
the 'devpriv' macro which uses a local variable of a specific name and
yeilds a pointer derived from that name. They are also just wrappers
around simple 'outw' calls. Remove the macros.
Signed-off-by: H Hartley Sweeten
Cc
Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/addi-data/addi_common.c | 23 --
.../staging/comedi/drivers/addi-data/addi_common.h | 1 -
.../comedi/drivers/addi-data/hwdrv_apci16xx.h | 15 --
.../comedi/drivers/addi-data
On Monday, July 16, 2012 6:52 PM, Greg KH wrote:
> On Wed, Jul 11, 2012 at 02:49:14PM -0700, H Hartley Sweeten wrote:
>> The pci_dev pointer in the private driver data is used by every
>> comedi pci driver. Some of them only have the need for the
>> private data be
On Monday, July 16, 2012 7:09 PM, Greg KH wrote:
> Because I didn't take your other large patch series, this one didn't
> apply :(
Of course... ;-)
Looking at using the hw_dev right now. I should have something tomorrow.
Thanks.
Hartley
--
To unsubscribe from this list: send the line
On Monday, July 16, 2012 7:01 PM, Greg KH wrote:
> On Mon, Jul 16, 2012 at 08:55:47PM -0500, H Hartley Sweeten wrote:
>> On Monday, July 16, 2012 6:52 PM, Greg KH wrote:
>>> No, the field above this, hw_dev, should be used instead here, as that's
>>> what it is there f
Use the 'struct device *hw_dev' variable in the comedi_device struct
to hold the pci_dev instead of carrying it in the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci6208.c | 19 ++-
1 file changed
On Monday, July 16, 2012 7:31 PM, Greg KH wrote:
> On Mon, Jul 16, 2012 at 07:26:22PM -0700, H Hartley Sweeten wrote:
>> Use the 'struct device *hw_dev' variable in the comedi_device struct
>> to hold the pci_dev instead of carrying it in the private data.
>>
>> Signe
On Tuesday, September 04, 2012 11:34 AM, Greg KH wrote:
> On Mon, Aug 20, 2012 at 04:59:16PM -0700, H Hartley Sweeten wrote:
>> Convert all the comedi_subdevice pointer access from pointer
>> math to array access.
>>
>> Signed-off-by: H Hartley Sweeten
>> Cc:
Introduce, and use, the helper macro module_hid_driver to allow removing
the init/exit boilerplate code from the HID drivers.
H Hartley Sweeten (3):
HID: introduce helper for hid_driver boilerplate
HID: hid.h: remove unused hid_generic_{init,exit} prototypes
HID: Use module_hid_driver macro
Introduce the module_hid_driver macro which is a convenience macro
for HID driver modules similar to module_usb_driver. It is intended
to be used by drivers with init/exit sections that do nothing but
register/unregister the HID driver.
Signed-off-by: H Hartley Sweeten
Cc: Jiri Kosina
These functions are not defined. Remove the extern declarations.
Signed-off-by: H Hartley Sweeten
Cc: Jiri Kosina
---
include/linux/hid.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/linux/hid.h b/include/linux/hid.h
index d6c71a6..828726c 100644
--- a/include/linux/hid.h
-by: H Hartley Sweeten
Cc: Jiri Kosina
---
drivers/hid/hid-a4tech.c | 13 +
drivers/hid/hid-apple.c| 19 +--
drivers/hid/hid-aureal.c | 13 +
drivers/hid/hid-axff.c | 14 +-
drivers/hid/hid-belkin.c | 13
On Saturday, January 12, 2013 7:11 PM, Peter Huewe wrote:
> This patch introduces a new macro 'module_comedi_pcmcia_driver'
> for comedi PCMCIA drivers which do not do anything special in module
> init/exit. This eliminates a lot of boilerplate.
>
> Adapted from 'module_comedi_pci_driver'
>
>
t to post a rebase of the last part of my drivers.c
cleanup that included this and your 2/2 patch.
Oh well... Rebase again...
FWIW, for both patches.
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...
On Monday, January 21, 2013 1:52 PM, Peter Huewe wrote:
> This patch adds the comedi_driver.name to pci_driver.name
> to the skel driver, so we can remove the workaround in drivers.c
>
> Signed-off-by: Peter Huewe
> ---
> drivers/staging/comedi/drivers/skel.c |1 +
> 1 files changed, 1
On Monday, January 21, 2013 2:25 PM, Peter Hüwe wrote:
>
> It's okay to drop my patches so you don't have to rebase.
>
> (I posted a version with the missing comma nevertheless)
Peter,
Your updated versions are ok. I'm about done with the rebase anyway.
Please make sure to at least compile test
On Tuesday, January 22, 2013 3:40 PM, Peter Huewe wrote:
> (Almost) all comedi pci drivers have some wrapper for their
> pci_driver.remove function which simply calls comedi_pci_auto_unconfig
> which has the same function prototype as the wrapper.
>
> -> we can remove these wrappers and call
On Thursday, November 15, 2012 9:28 AM, Arpith Easow Alexander wrote:
> On Tue, Nov 13, 2012 at 11:52:52AM -0800, Greg KH wrote:
>> So a macro called dbgcm tests a variable called dbgcm? Gotta love c at
>> times...
>>
>> Just delete the macro, and the variable, and call dev_dbg() directly
>>
These drivers are very similar and only differ in the total number
of di/do channels provided. Combine them into one common driver to
make it more maintainable.
H Hartley Sweeten (2):
staging: comedi: new adl_pci7x3x driver
staging: comedi: remove adl_pci7230 and adl_pci7432 drivers
drivers
.
In addition, it adds PCI PnP support for the other boards in the
ADLink PCI-723x and PCI-743x series.
This driver only supports the comedi PCI auto config attach
mechanism. The legacy attach using the comedi_config utility
is not supported or required by this driver.
Signed-off-by: H Hartley Sweeten
The boards supported by these drivers are now handled by the
adl_pci7x3x driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci7230.c | 190 -
drivers/staging/comedi/drivers/adl_pci7432.c | 200
These drivers are very similar and only differ in the total number
of di/do channels provided. Combine them into one common driver to
make it more maintainable.
v2: remove the adl_pci7230 and adl_pci7432 drivers from the Kconfig
and Makefile
H Hartley Sweeten (2):
staging: comedi: new
pci7x3x.c
b/drivers/staging/comedi/drivers/adl_pci7x3x.c
new file mode 100644
index 000..990670a
--- /dev/null
+++ b/drivers/staging/comedi/drivers/adl_pci7x3x.c
@@ -0,0 +1,342 @@
+/*
+ * COMEDI driver for the ADLINK PCI-723x/743x series boards.
+ * Copyright (C) 2012 H Hartley Sw
The boards supported by these drivers are now handled by the
adl_pci7x3x driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
v2: remove the adl_pci7230 and adl_pci7432 drivers from the Kconfig
and Makefile
drivers/staging/comedi/Kconfig | 16
the legacy attach using the comedi_config utility.
This driver now supports the comedi PCI auto config attach
mechanism and the legacy attach is not supported or required
by this driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/Kconfig
Remove the need for the boardinfo, this driver only supports one board type.
Convert the driver to use the comedi PCI auto config (attach_pci).
Cleanup the digital output insn_bits function.
H Hartley Sweeten (7):
staging: comedi: contec_pci_dio: remove thisboard macro
staging: comedi
This macro relies on a local variable of a specific name. Remove the
macro and use the comedi_board() helper to get the thisboard pointer.
Move the 'dev->board_name = thisboard->name;' in contec_attach().
The contec_find_pci_dev() function modifies the dev->board_ptr.
Signed-off-by:
The dev_dbg function trace messages in the contec_do_insn_bits
and contec_di_insn_bits functions are just noise. Remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-hartman
---
drivers/staging/comedi/drivers/contec_pci_dio.c | 9 +
1 file changed, 1 insertion
The model, in_ports, out_ports, and out_boffs information in the
boardinfo is not used by the driver. Remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-hartman
---
drivers/staging/comedi/drivers/contec_pci_dio.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions
Only one board type is supported by this driver. Instead of
passing the register offsets for the digital in/out ports in
the boardinfo, define the register map and use that to access
the ports.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-hartman
---
drivers/staging/comedi
The boardinfo code is not needed by this driver. Only one board
type is supported.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-hartman
---
drivers/staging/comedi/drivers/contec_pci_dio.c | 19 ++-
1 file changed, 2 insertions(+), 17 deletions(-)
diff --git
801 - 900 of 988 matches
Mail list logo
