[PATCH 6/7] staging: comedi: contec_pci_dio: use attach_pci callback

2012-08-15 Thread H Hartley Sweeten
to find the pci_dev and the need for the pci_dev_put in the detach. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-hartman --- drivers/staging/comedi/drivers/contec_pci_dio.c | 97 + 1 file changed, 35 insertions(+), 62 deletions(-) diff --git a/drivers

[PATCH 7/7] staging: comedi: contec_pci_dio: cleanup contec_do_insn_bits

2012-08-15 Thread H Hartley Sweeten
Create local variables for the mask and bits values passed in the data pointer to make this function a bit clearer. Return the state of the output bits (s->state) in data[1] since this is what comedilib is expecting. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-hart

[PATCH 00/35] staging: comedi: update comedi pci drivers

2012-08-16 Thread H Hartley Sweeten
Remove the manual legacy 'attach' callback in the comedi pci drivers that have it stubbed out. The 'attach' callback is not optional in the comedi core. Cleanup and convert some of the other comedi pci drivers to use the 'attach_pci' callback and remove the legacy 'attach'. H Hartley Sweeten (35

[PATCH 02/35] staging: comedi: adl_pci7296: remove manual legacy attach

2012-08-16 Thread H Hartley Sweeten
This driver uses the 'attach_pci' callback to attach the pci device to the comedi subsystem. Since the 'attach' callback is now optional it can be removed from the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci7296.c

[PATCH 01/35] staging: comedi: adl_pci6208: remove manual legacy attach

2012-08-16 Thread H Hartley Sweeten
This driver uses the 'attach_pci' callback to attach the pci device to the comedi subsystem. Since the 'attach' callback is now optional it can be removed from the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci6208.c

[PATCH 03/35] staging: comedi: adl_pci7x3x: remove manual legacy attach

2012-08-16 Thread H Hartley Sweeten
This driver uses the 'attach_pci' callback to attach the pci device to the comedi subsystem. Since the 'attach' callback is now optional it can be removed from the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci7x3x.c

[PATCH 04/35] staging: comedi: adl_pci8164: use attach_pci callback

2012-08-16 Thread H Hartley Sweeten
Convert this PCI driver to use the comedi PCI auto config attach mechanism by adding an 'attach_pci' callback function. Since the driver does not require any external configuration options, and the legacy 'attach' callback is now optional, remove it. Signed-off-by: H Hartley Sweeten Cc: Ian

[PATCH 05/35] staging: comedi: cb_pcidas: use attach_pci callback

2012-08-16 Thread H Hartley Sweeten
Convert this PCI driver to use the comedi PCI auto config attach mechanism by adding an 'attach_pci' callback function. Since the driver does not require any external configuration options, and the legacy 'attach' callback is now optional, remove it. Signed-off-by: H Hartley Sweeten Cc: Ian

[PATCH 06/35] staging: comedi: cb_pcidio: remove thisboard macro

2012-08-16 Thread H Hartley Sweeten
This macro relies on a local variable having a specific name. Remove it and use the comedi_board() helper to get the pointer. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidio.c | 13 +++-- 1 file changed, 3 insertions

[PATCH 07/35] staging: comedi: cb_pcidio: use attach_pci callback

2012-08-16 Thread H Hartley Sweeten
Convert this PCI driver to use the comedi PCI auto config attach mechanism by adding an 'attach_pci' callback function. Since the driver does not require any external configuration options, and the legacy 'attach' callback is now optional, remove it. Signed-off-by: H Hartley Sweeten Cc: Ian

[PATCH 08/35] staging: comedi: cb_pcidda: remove thisboard and devpriv macros

2012-08-16 Thread H Hartley Sweeten
These macros rely on a local variable having a specific name. Remove them and use the comedi_board() helper to get the thisboard pointer. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidda.c | 29 + 1

[PATCH 09/35] staging: comedi: cb_pcidda: remove forward declarations

2012-08-16 Thread H Hartley Sweeten
Move a couple of the functions in order to remove the need for the forward declarations. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidda.c | 389 ++--- 1 file changed, 184 insertions(+), 205 deletions

[PATCH 10/35] staging: comedi: cb_pcidda: use attach_pci callback

2012-08-16 Thread H Hartley Sweeten
Convert this PCI driver to use the comedi PCI auto config attach mechanism by adding an 'attach_pci' callback function. Since the driver does not require any external configuration options, and the legacy 'attach' callback is now optional, remove it. Signed-off-by: H Hartley Sweeten Cc: Ian

[PATCH 11/35] staging: comedi: cb_pcimdas: remove thisboard and devpriv macros

2012-08-16 Thread H Hartley Sweeten
These macros rely on a local variable having a specific name. Remove them and use the comedi_board() helper to get the thisboard pointer. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdas.c | 27 +++ 1

[PATCH 12/35] staging: comedi: cb_pcimdas: remove forward declarations

2012-08-16 Thread H Hartley Sweeten
Move a couple of the functions in order to remove the need for the forward declarations. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdas.c | 240 +--- 1 file changed, 112 insertions(+), 128 deletions

[PATCH 13/35] staging: comedi: cb_pcimdas: use attach_pci callback

2012-08-16 Thread H Hartley Sweeten
Convert this PCI driver to use the comedi PCI auto config attach mechanism by adding an 'attach_pci' callback function. Since the driver does not require any external configuration options, and the legacy 'attach' callback is now optional, remove it. Signed-off-by: H Hartley Sweeten Cc: Ian

[PATCH 14/35] staging: comedi: cb_pcimdda: remove REG_SZ and REGS_BARINDEX macros

2012-08-16 Thread H Hartley Sweeten
The REG_SZ macro isn't being use. Both macros use the 'thisboard' macro which relys on a local variable having a specific name. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdda.c | 5 + 1 file changed, 1 insertion(+), 4

[PATCH 15/35] staging: comedi: cb_pcimdda: remove thisboard and devpriv macros

2012-08-16 Thread H Hartley Sweeten
These macros rely on a local variable having a specific name. Remove them and use the comedi_board() helper to get the thisboard pointer. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdda.c | 33

[PATCH 16/35] staging: comedi: cb_pcimdda: remove forward declarations

2012-08-16 Thread H Hartley Sweeten
Move a couple of the functions in order to remove the need for the forward declarations. Also, remove the unnecessary comments. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdda.c | 241 +++- 1 file

[PATCH 17/35] staging: comedi: cb_pcimdda: add namespace to the driver

2012-08-16 Thread H Hartley Sweeten
The structs, static data, and functions in this driver have pretty generic names. Add namespace to everything to prevent any problems. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdda.c | 66 ++--- 1

[PATCH 19/35] staging: comedi: cb_pcimdda: use dev->iobase

2012-08-16 Thread H Hartley Sweeten
Use dev->iobase for the pci i/o address instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdda.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/driv

[PATCH 18/35] staging: comedi: cb_pcimdda: cleanup pci probe

2012-08-16 Thread H Hartley Sweeten
Make cb_pcimdda_probe() return the pointer to the found pci_dev and move the comedi_pci_enable() call into the 'attach' function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdda.c | 62 - 1 file

[PATCH 20/35] staging: comedi: cb_pcimdda: store the pci_dev in the comedi_device

2012-08-16 Thread H Hartley Sweeten
Use the hw_dev pointer in the comed_device struct to hold the pci_dev instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdda.c | 18 -- 1 file changed, 8 insertions(+), 10

[PATCH 21/35] staging: comedi: cb_pcimdda: cleanup the 8255 subdevice init

2012-08-16 Thread H Hartley Sweeten
. For aesthetic reasons, rename the local variable 'err' to 'ret'. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdda.c | 31 + 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/drivers/staging

[PATCH 22/35] staging: comedi: cb_pcimdda: remove the DIO_METHODS

2012-08-16 Thread H Hartley Sweeten
The digital i/o on this card is handled by an 8255 compatible device. There are not other options. Remove the DIO_METHODS enum as well as the dio_method variable in the boardinfo and the code dealing with it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers

[PATCH 23/35] staging: comedi: cb_pcimdda: remove dio_chans from the private data

2012-08-16 Thread H Hartley Sweeten
The cards supported by this driver always have 8255 compatible device. Remove the dio_chans variable from the private data and always initialize the 8255 subdevice. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdda.c | 16

[PATCH 24/35] staging: comedi: cb_pcimdda: define the register map

2012-08-16 Thread H Hartley Sweeten
Add defines for the register map of the card. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdda.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/comedi/drivers/cb_pcimdda.c b/drivers/staging/comedi

[PATCH 25/35] staging: comedi: cb_pcimdda: remove dio_offset from the boardinfo

2012-08-16 Thread H Hartley Sweeten
The 8255 device is located at a fixed offset from the base address of the card. There is not need to carry this offset in the boardinfo. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdda.c | 5 + 1 file changed

[PATCH 26/35] staging: comedi: cb_pcimdda: remove regs_badrindex and reg_sz from boardinfo

2012-08-16 Thread H Hartley Sweeten
The base address of the card is always found in pci resource 3. There is no need to carry this information in the boardinfo. The reg_sz is not used in the driver. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers

[PATCH 27/35] staging: comedi: cb_pcimdda: remove ao_chans and ao_bits from boardinfo

2012-08-16 Thread H Hartley Sweeten
This board always has 6, 16-bit analog outputs. There is no need to carry this information in the boardinfo. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdda.c | 8 ++-- 1 file changed, 2 insertions(+), 6

[PATCH 28/35] staging: comedi: cb_pcimdda: remove boardinfo

2012-08-16 Thread H Hartley Sweeten
The boardinfo struct and associated code is no longer needed by this driver. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdda.c | 38 ++--- 1 file changed, 8 insertions(+), 30 deletions

[PATCH 29/35] staging: comedi: cb_pcimdda: remove attached_to_8255 from private data

2012-08-16 Thread H Hartley Sweeten
ble. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdda.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/staging/comedi/drivers/cb_pcimdda.c b/drivers/staging/comedi/drivers/cb_pcimdda.c in

[PATCH 30/35] staging: comedi: cb_pcimdda: fix bug in call to subdev_8255_cleanup

2012-08-16 Thread H Hartley Sweeten
ned-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/cb_pcimdda.c b/drivers/staging/comedi/drivers/cb_pcimdda.c index b10831d..99a6

[PATCH 31/35] staging: comedi: cb_pcimdda: minor cleanup of the private data

2012-08-16 Thread H Hartley Sweeten
Remove the cut-and-paste comment from the skel driver and for aesthetic reasons, move the #define out of the struct. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdda.c | 11 ++- 1 file changed, 2 insertions(+), 9

[PATCH 32/35] staging: comedi: cb_pcimdda: cleanup the analog out read/write

2012-08-16 Thread H Hartley Sweeten
->n' just makes it clearer. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdda.c | 63 - 1 file changed, 26 insertions(+), 37 deletions(-) diff --git a/drivers/staging/comedi/drivers/cb_pcimdd

[PATCH 33/35] staging: comedi: cb_pcimdda: use attach_pci callback

2012-08-16 Thread H Hartley Sweeten
' callback, an assumption is made that the jumper is in the factory setting position for +/-5V outputs. This does not effect the operation of the board just the range info that is returned to the user. A sysfs method will be investigated to allow the user to change the range. Signed-off-by: H Hartley

[PATCH 34/35] staging: comedi: dyna_pci10xx: remove manual legacy attach

2012-08-16 Thread H Hartley Sweeten
This driver uses the 'attach_pci' callback to attach the pci device to the comedi subsystem. Since the 'attach' callback is now optional it can be removed from the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dyna_pci10xx.c

[PATCH 35/35] staging: comedi: ke_counter: use attach_pci callback

2012-08-16 Thread H Hartley Sweeten
Convert this PCI driver to use the comedi PCI auto config attach mechanism by adding an 'attach_pci' callback function. Since the driver does not require any external configuration options, and the legacy 'attach' callback is now optional, remove it. Signed-off-by: H Hartley Sweeten Cc: Ian

RE: [PATCH 00/35] staging: comedi: update comedi pci drivers

2012-08-17 Thread H Hartley Sweeten
On Friday, August 17, 2012 1:44 AM, Ian Abbott wrote: > On 2012-08-17 03:40, H Hartley Sweeten wrote: >> Remove the manual legacy 'attach' callback in the comedi pci drivers >> that have it stubbed out. The 'attach' callback is not optional in >> the comedi core. > >

[PATCH] staging: comedi: contec_pci: remove manual legacy attach

2012-08-17 Thread H Hartley Sweeten
This driver uses the 'attach_pci' callback to attach the pci device to the comedi subsystem. Since the 'attach' callback is now optional it can be removed from the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers

[PATCH 00/20] staging: comedi: update comedi pci drivers part 2

2012-08-17 Thread H Hartley Sweeten
Another round of updates to the comedi pci drivers. * remove function trace messages * remove devpriv and thisboard type macros * cleanup the boardinfo * remove forward declarations * use attach_pci and remove legacy attach (when possible) * misc. other changes H Hartley Sweeten (20): staging

[PATCH 01/20] staging: comedi: adv_pci1710: remove function trace messages

2012-08-17 Thread H Hartley Sweeten
The macros PCI171X_EXTDEBUG and DPRINTK enable a number of function trace messages. These trace messages should not be in the final driver. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 132

[PATCH 02/20] staging: comedi: adv_pci1710: remove devpriv and this_board macros

2012-08-17 Thread H Hartley Sweeten
These macros rely on a local variable having a specific name. Remove them and use the comedi_board() helper to get the this_board pointer. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 44

[PATCH 03/20] staging: comedi: adv_pci1710: convert boardinfo initialization to C99 format

2012-08-17 Thread H Hartley Sweeten
Convert the boardinfo initialization to C99 format to make it less error prone. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 152 +-- 1 file changed, 118 insertions(+), 34 deletions(-) diff

[PATCH 04/20] staging: comedi: adv_pci1710: remove '0' and 'NULL' boardinfo data

2012-08-17 Thread H Hartley Sweeten
Remove all the boardinfo data that is set to '0' or 'NULL'. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 23 --- 1 file changed, 23 deletions(-) diff --git a/drivers/staging/comedi/drivers

[PATCH 05/20] staging: comedi: adv_pci1710: remove forward declarations

2012-08-17 Thread H Hartley Sweeten
Move some of the functions to remove the need for the forward declarations. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 297 +-- 1 file changed, 140 insertions(+), 157 deletions(-) diff

[PATCH 06/20] staging: comedi: adv_pci1723: remove function trace messages

2012-08-17 Thread H Hartley Sweeten
Remove the DPRINTK function trace messages. These should not be in the final driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1723.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/comedi/drivers

[PATCH 07/20] staging: comedi: adv_pci1723: remove devpriv and this_board macros

2012-08-17 Thread H Hartley Sweeten
ent. Remove this macro also by making sure the dev->board_ptr is set in the pci1723_find_pci_dev() function and using the comedi_board() helper to get the pointer in pci1723_attach(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/d

[PATCH 08/20] staging: comedi: adv_pci1723: remove range_pci1723

2012-08-17 Thread H Hartley Sweeten
This comedi_lrange is the same as the global range_bipolar10 exported by the comedi core. Use that range instead. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1723.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions

[PATCH 09/20] staging: comedi: adv_pci1723: fix initial dio subdevice state and io_bits

2012-08-17 Thread H Hartley Sweeten
The initial state and io_bits for the dio subdevice is determined in the pci1723_attach() but it's being saved in the wrong subdevice. Move the code so it gets saved correctly. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers

[PATCH 10/20] staging: comedi: adv_pci1723: remove boardinfo

2012-08-17 Thread H Hartley Sweeten
This driver only supports one board type. Remove the boardinfo and associated code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1723.c | 139 --- 1 file changed, 42 insertions(+), 97 deletions

[PATCH 11/20] staging: comedi: adv_pci1723: use attach_pci callback

2012-08-17 Thread H Hartley Sweeten
Convert this PCI driver to use the comedi PCI auto config attach mechanism by adding an 'attach_pci' callback function. Since the driver does not require any external configuration options, and the legacy 'attach' callback is now optional, remove it. Signed-off-by: H Hartley Sweeten Cc: Ian

[PATCH 12/20] staging: comedi: adv_pci1723: cleanup card reset

2012-08-17 Thread H Hartley Sweeten
' function. Checking if dev->iobase is valid works just as well. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1723.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/staging/com

[PATCH 13/20] staging: comedi: adv_pci_dio: remove function trace messages

2012-08-17 Thread H Hartley Sweeten
Remove the DPRINTK function trace messages and associated PCI_DIO_EXTDEBUG define. These should not be in the final driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci_dio.c | 13 - 1 file changed, 13 deletions

[PATCH 14/20] staging: comedi: adv_pci_dio: remove devpriv and this_board macros

2012-08-17 Thread H Hartley Sweeten
These macros rely on a local variable having a specific name. Remove them and use the comedi_board() helper to get the this_board pointer. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci_dio.c | 33

[PATCH 15/20] staging: comedi: adv_pci_dio: use attach_pci callback

2012-08-17 Thread H Hartley Sweeten
Convert this PCI driver to use the comedi PCI auto config attach mechanism by adding an 'attach_pci' callback function. Since the driver does not require any external configuration options, and the legacy 'attach' callback is now optional, remove it. Signed-off-by: H Hartley Sweeten Cc: Ian

[PATCH 16/20] staging: comedi: adv_pci_dio: convert boardinfo initialization to C99 format

2012-08-17 Thread H Hartley Sweeten
Convert the boardinfo initialization to C99 format to make it less error prone. The struct diosubd_data information is not converted to C99 format yet because some of it will be removed. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers

[PATCH 17/20] staging: comedi: adv_pci_dio: remove '0' boardinfo data

2012-08-17 Thread H Hartley Sweeten
Remove all the boardinfo data that is simply '0'. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci_dio.c | 84 1 file changed, 84 deletions(-) diff --git a/drivers/staging/comedi/drivers

[PATCH 18/20] staging: comedi: adv_pci_dio: add the number of subdevices to the boardinfo

2012-08-17 Thread H Hartley Sweeten
Instead of calculating the number of subdevices in the 'attach' simply add the number to the boardinfo. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci_dio.c | 39 +--- 1 file changed, 18 insertions

[PATCH 19/20] staging: comedi: adv_pci_dio: simplify the 'detach'

2012-08-17 Thread H Hartley Sweeten
e s->type is COMEDI_SUBD_DIO. Use that to know when to call the cleanup for the 8255 subdevice. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci_dio.c | 27 +++ 1 file changed, 3 insertions(+), 24 del

[PATCH 20/20] staging: comedi: adv_pci_dio: fix bug in 'detach'

2012-08-17 Thread H Hartley Sweeten
The 'attach' function can fail between when the devpriv and the comedi subdevices are allocated. If it does the 'detach' will try to access unallocated memory when it goes thru the subdevices. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi

[PATCH 0/4] staging: comedi: update the aio_aio12_8 driver

2012-08-20 Thread H Hartley Sweeten
H Hartley Sweeten (4): staging: comedi: aio_aio12_8: remove devpriv macro staging: comedi: aio_aio12_8: add ai and ao only card versions staging: comedi: aio_aio12_8: document the register map staging: comedi: aio_aio12_8: fix i/o region size drivers/staging/comedi/drivers/aio_aio12_8.c

[PATCH 1/4] staging: comedi: aio_aio12_8: remove devpriv macro

2012-08-20 Thread H Hartley Sweeten
This macro relies on a local variable having a specific name. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/aio_aio12_8.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/staging

[PATCH 2/4] staging: comedi: aio_aio12_8: add ai and ao only card versions

2012-08-20 Thread H Hartley Sweeten
but stub in the subdevice information so it can easily be added. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/aio_aio12_8.c | 90 +++- 1 file changed, 61 insertions(+), 29 deletions(-) diff --git a/drivers

[PATCH 3/4] staging: comedi: aio_aio12_8: document the register map

2012-08-20 Thread H Hartley Sweeten
Fully document the register map and add namespace to all the defines. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/aio_aio12_8.c | 129 --- 1 file changed, 75 insertions(+), 54 deletions(-) diff --git

[PATCH 4/4] staging: comedi: aio_aio12_8: fix i/o region size

2012-08-20 Thread H Hartley Sweeten
This board has jumpers to set the board base address. These jumpers are marked A5 through A9 and A5 is the least significant bit of the address. This makes the address reqion for the board 32 bytes not 24. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers

[PATCH 0/5] staging: comedi: cleaup comedi_bond driver

2012-08-20 Thread H Hartley Sweeten
H Hartley Sweeten (5): staging: comedi: comedi_bond: remove boardinfo staging: comedi: comedi_bond: remove devpriv macro staging: comedi: comedi_bond: remove private printk macros staging: comedi: comedi_bond: remove the STR macro staging: comedi: comedi_bond: remove MODULE_NAME macro

[PATCH 1/5] staging: comedi: comedi_bond: remove boardinfo

2012-08-20 Thread H Hartley Sweeten
and driver name are identical we can simplify this driver a bit bu just removing the boardinfo completely. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/comedi_bond.c | 27 --- 1 file changed, 27 deletions(-) diff

[PATCH 2/5] staging: comedi: comedi_bond: remove devpriv macro

2012-08-20 Thread H Hartley Sweeten
This macro relies on a local variable having a specific name. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/comedi_bond.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git

[PATCH 3/5] staging: comedi: comedi_bond: remove private printk macros

2012-08-20 Thread H Hartley Sweeten
Remove the macros LOG_MSG, DEBUG, WARNING, and ERROR. Convert the printk's into dev_printk format. The DEBUG macro is not being used in the file so the module parameter 'debug' can also be removed. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging

[PATCH 4/5] staging: comedi: comedi_bond: remove the STR macro

2012-08-20 Thread H Hartley Sweeten
This macro is not used in the file. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/comedi_bond.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/comedi_bond.c b/drivers/staging/comedi

[PATCH 5/5] staging: comedi: comedi_bond: remove MODULE_NAME macro

2012-08-20 Thread H Hartley Sweeten
This macro is only used in the MODULE_DESCRIPTION. Just remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/comedi_bond.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers

[PATCH] getirq: fix /proc/interrupts output alignment

2017-02-10 Thread H Hartley Sweeten
If the irq_desc being output does not have a domain the information following the 'name' is not aligned correctly. Signed-off-by: H Hartley Sweeten Cc: Thomas Gleixner --- kernel/irq/proc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c index

[PATCH 2/2] watchdog: ts72xx_wdt: convert driver to watchdog core

2017-01-30 Thread H Hartley Sweeten
Cleanup this driver and convert it to use the watchdog framework API. Signed-off-by: H Hartley Sweeten Cc: Mika Westerberg Cc: Wim Van Sebroeck Cc: Guenter Roeck --- drivers/watchdog/ts72xx_wdt.c | 447 +- 1 file changed, 93 insertions(+), 354

[PATCH 1/2] watchdog: ep93xx_wdt: cleanup and let the core handle the heartbeat

2017-01-30 Thread H Hartley Sweeten
Cleanup this driver and remove the 200ms heartbeat timer. The core now has the ability to handle the heartbeat. Signed-off-by: H Hartley Sweeten Cc: Wim Van Sebroeck Cc: Guenter Roeck --- drivers/watchdog/ep93xx_wdt.c | 115 +- 1 file changed, 46

[PATCH 0/2] watchdog: cleanup ep93xx platform drivers

2017-01-30 Thread H Hartley Sweeten
The ep93xx_wdt driver is used by EP93xx based platforms for the internal watchdog of the EP93xx processor. The TS-72xx platforms have an additional watchdog provided by the CPLD on those boards. Cleanup both drivers. H Hartley Sweeten (2): watchdog: ep93xx_wdt: cleanup and let the core handle

RE: [PATCH v3] pwm: add sysfs interface

2013-06-10 Thread H Hartley Sweeten
Ping? -Original Message- From: H Hartley Sweeten Sent: Thursday, May 30, 2013 2:31 PM To: Linux Kernel Cc: linux-...@vger.kernel.org; linux-...@vger.kernel.org; thierry.red...@gmail.com; poesc...@lemonage.de; Ryan Mallon; r...@landley.net; H Hartley Sweeten Subject: [PATCH v3] pwm: add

RE: [PATCH v3] pwm: add sysfs interface

2013-06-10 Thread H Hartley Sweeten
On Monday, June 10, 2013 12:00 PM, Thierry Reding wrote: > On Thu, May 30, 2013 at 02:30:39PM -0700, H Hartley Sweeten wrote: >> Add a simple sysfs interface to the generic PWM framework. > > Sorry for taking so long to review this. Not a problem. Thanks for the review. >

[PATCH v4] pwm: add sysfs interface

2013-06-10 Thread H Hartley Sweeten
to the kernel Signed-off-by: H Hartley Sweeten Cc: Thierry Reding Cc: Lars Poeschel Cc: Ryan Mallon Cc: Rob Landley --- v4: * address a number of issues pointed out by Thierry Reding - fix some typos and wording issues in the Documentation - rename the new source file to sysfs.c

RE: [PATCH v4] pwm: add sysfs interface

2013-06-11 Thread H Hartley Sweeten
On Tuesday, June 11, 2013 4:29 AM, Ryan Mallon wrote: > On 11/06/13 20:14, Thierry Reding wrote: >> On Mon, Jun 10, 2013 at 04:12:07PM -0700, H Hartley Sweeten wrote: >> [...] >>> +What: /sys/class/pwm/pwmchipN/pwmX/duty >>> +Date: May

RE: [PATCH v4] pwm: add sysfs interface

2013-06-11 Thread H Hartley Sweeten
On Tuesday, June 11, 2013 9:09 AM, H Hartley Sweeten wrote: > On Tuesday, June 11, 2013 4:29 AM, Ryan Mallon wrote: >> On 11/06/13 20:14, Thierry Reding wrote: >>> On Mon, Jun 10, 2013 at 04:12:07PM -0700, H Hartley Sweeten wrote: >>>> +config PWM_SYSFS >>&

[PATCH v5] pwm: add sysfs interface

2013-06-11 Thread H Hartley Sweeten
channel to the kernel Signed-off-by: H Hartley Sweeten Cc: Thierry Reding Cc: Lars Poeschel Cc: Ryan Mallon Cc: Rob Landley --- v5: * rename the 'duty' attribute to 'duty_cycle' * make the Kconfig option hidden and enabled when CONFIG_SYSFS is enabled * use sysfs_streq

RE: [PATCH v4] pwm: add sysfs interface

2013-06-11 Thread H Hartley Sweeten
On Tuesday, June 11, 2013 11:35 AM, Thierry Reding wrote: > On Tue, Jun 11, 2013 at 11:47:23AM -0500, H Hartley Sweeten wrote: >> On Tuesday, June 11, 2013 9:09 AM, H Hartley Sweeten wrote: >>> On Tuesday, June 11, 2013 4:29 AM, Ryan Mallon wrote: >>>> On 11/06/

[PATCH v2 10/11] spi: spi-ep93xx: convert to the queued driver infrastructure

2013-07-08 Thread H Hartley Sweeten
The SPI core provides infrastructure for standard message queueing. Use that instead of handling it in the driver. Signed-off-by: H Hartley Sweeten Acked-by: Mika Westerberg Cc: Ryan Mallon Cc: Mark Brown Cc: Grant Likely --- drivers/spi/spi-ep93xx.c | 165

RE: [PATCH v2 09/11] spi: spi-ep93xx: move the clock divider calcs into ep93xx_spi_chip_setup()

2013-07-08 Thread H Hartley Sweeten
On Monday, July 08, 2013 5:10 AM, Mark Brown wrote: > On Tue, Jul 02, 2013 at 10:10:29AM -0700, H Hartley Sweeten wrote: >> The divider values stored in the per chip data are only used to set the >> registers in the hardware to generate the desired SPI clock. Since these >&g

[PATCH v2 11/11] spi: spi-ep93xx: use master->cur_msg for in-flight message

2013-07-08 Thread H Hartley Sweeten
Instead of carrying the in-flight message in the driver private data, use the cur_msg pointer that is already setup by the core. Signed-off-by: H Hartley Sweeten Cc: Ryan Mallon Cc: Mika Westerberg Cc: Mark Brown Cc: Grant Likely --- drivers/spi/spi-ep93xx.c | 88

[tip:irq/core] genirq: Fix /proc/interrupts output alignment

2017-02-10 Thread tip-bot for H Hartley Sweeten
Commit-ID: f435da416beaacc8934fc21820d9488269b39c98 Gitweb: http://git.kernel.org/tip/f435da416beaacc8934fc21820d9488269b39c98 Author: H Hartley Sweeten <hswee...@visionengravers.com> AuthorDate: Fri, 10 Feb 2017 09:54:16 -0700 Committer: Thomas Gleixner <t...@linutronix.de>

[tip:irq/core] genirq: Fix /proc/interrupts output alignment

2017-02-10 Thread tip-bot for H Hartley Sweeten
Commit-ID: f435da416beaacc8934fc21820d9488269b39c98 Gitweb: http://git.kernel.org/tip/f435da416beaacc8934fc21820d9488269b39c98 Author: H Hartley Sweeten AuthorDate: Fri, 10 Feb 2017 09:54:16 -0700 Committer: Thomas Gleixner CommitDate: Fri, 10 Feb 2017 20:17:52 +0100 genirq: Fix /proc

<    5   6   7   8   9   10